#dev-contrib | Python | Page 37

clever wraith Dec 3, 2019, 5:47 PM

#

47 dependencies

#

damnn

#

DONE
also done
pipenv run precommit

hardy gorge Dec 3, 2019, 5:48 PM

#

That's mainly because some of the packages we use have dependencies of their own.

green oriole Dec 3, 2019, 5:49 PM

#

I thought they were way more tbh

clever wraith Dec 3, 2019, 5:57 PM

#

📎 unknown.png

#

Now we talking

green oriole Dec 3, 2019, 5:58 PM

#

Oh wait you were working on the seasonalbot?

#

Okay okay

clever wraith Dec 3, 2019, 5:59 PM

#

Oh lol

#

Now i have a piece of code

#

that i want to add as a command

#

now how to do that ?

crude gyro Dec 3, 2019, 6:02 PM

#

guess you should take a look at how the other commands work and model that approach

clever wraith Dec 3, 2019, 6:03 PM

#

bangs head on the table

#

my god this code is so complexxxxxx

green oriole Dec 3, 2019, 6:04 PM

#

Not too complicated, just try to understand what piece of code do what

clever wraith Dec 3, 2019, 6:06 PM

#

just give me one hint where is the code of .uwu .random , i will find my way from there

#

📎 unknown.png

#

roll not random

brazen charm Dec 3, 2019, 6:06 PM

#

pycharm has a project search feature when you do ctrl shift f

green oriole Dec 3, 2019, 6:06 PM

#

Go inside the cogs/ folder and work your way in it

clever wraith Dec 3, 2019, 6:08 PM

#

where is cogs

#

let me try it with pycharm wait

#

so evergreen season stays online forever with other season ?

#

?

#

what class does it belongs to ? !bookmark thing

green oriole Dec 3, 2019, 6:17 PM

#

Evergreen

clever wraith Dec 3, 2019, 6:21 PM

#

how to stop the bot if i closed the CMD ?

green oriole Dec 3, 2019, 6:22 PM

#

If you closed it, it is down

#

Or CRTL + BREAK

clever wraith Dec 3, 2019, 6:24 PM

#

will continue tomorrow , done adding the command need it to include in

#

Nice

whole ruin Dec 3, 2019, 6:44 PM

#

I couldn't complete it cuz its already 12 here and school tomorrow

tawdry vapor Dec 3, 2019, 11:21 PM

#

How do I access the staff logs?

#

is it just staff.pythondiscord.local?

#

cause I get a 404 for it

#

figured it out

#

have to add bot/logs/ with the deletion context id at the end

glass pecan Dec 3, 2019, 11:42 PM

#

ye

tawdry vapor Dec 4, 2019, 1:37 AM

#

What's wrong with the url constant here? https://discordapp.com/channels/267624335836053506/303934982764625920/651584901044502538

#

Was it just not meant to be used there?

#

Yeah, it's meant to be used with format() when making an API call

tawdry vapor Dec 4, 2019, 5:19 AM

#

Made a quick PR to fix that by the way https://github.com/python-discord/bot/pull/678

green oriole Dec 4, 2019, 6:38 AM

#

@tawdry vapor just out of curiosity, why have you pushed 10 commits on my PR https://github.com/python-discord/bot/pull/630, does they came from another PR or something?

tawdry vapor Dec 4, 2019, 6:39 AM

#

No, they were my improvements to the PR

#

I was testing it and figured I'd just make the changes myself while I have the code checked out

#

Instead of like, writing paragraphs about it and going back and forth

clever wraith Dec 4, 2019, 11:10 AM

#

@green oriole there ?

#

.uptime

dusky shoreBOT Dec 4, 2019, 11:10 AM

#

I'm sorry Dave, I'm afraid I can't do that.

Sorry, but you may only use this command within #bot-commands, #sir-lancebot-playground, #ot0-psvm’s-eternal-disapproval, #ot1-perplexing-regexing, #ot2-never-nester’s-nightmare, #414574275865870337.

clever wraith Dec 4, 2019, 11:11 AM

#

remove that #deleted-channel BTW

green oriole Dec 4, 2019, 11:15 AM

#

Gonna go to eat, I'll be there in 1h or 2

clever wraith Dec 4, 2019, 11:15 AM

#

ok will wait

#

Stupid as F question still
So i added a bookmark.py with similar syntax of uptime.py , but its not loading , how to make it to load
seasonalbot BTW

green oriole Dec 4, 2019, 12:07 PM

#

@clever wraith have you pushed your changes to your fork yet?

#

So I can check it out

clever wraith Dec 4, 2019, 12:09 PM

#

one second

#

how to push the changes ?

#

📎 unknown.png

#

this doesn't worked

gusty sonnet Dec 4, 2019, 12:17 PM

#

After you commit you will have to push

#

Do you have any GUI like github desktop?

#

Otherwise CLI is fine, you will need to set branch then do a push

clever wraith Dec 4, 2019, 12:19 PM

#

why github so confusing

gusty sonnet Dec 4, 2019, 12:20 PM

#

Git can be quite confusing at first, but once you know it it is considered essential when developing

#

source control is very veyr important

#

Github has an app - Github desktop, that you can download

#

It eases the commit push branch switching thingy

clever wraith Dec 4, 2019, 12:21 PM

#

OMG GOT IT WORKING WITH THE BOT

#

@green oriole

#

I will add it a PR soon

gusty sonnet Dec 4, 2019, 12:25 PM

#

It is a better practice to do smaller single-responsibility, well documented commits instead of a big one, so if you need to you can revert to any one of them

#

Commit more frequently!

clever wraith Dec 4, 2019, 12:26 PM

#

If i get a way to submit it ,
its a very small commit
just a bookmark.py file and done

green oriole Dec 4, 2019, 12:36 PM

#

If you want to learn more about git, I can't recommend you enough the pro git book, I read it to learn more about it, and it was crazy simple!

molten bough Dec 4, 2019, 12:37 PM

#

I also find commit etiquette way more complex than actually using git most of the time

#

heh, commit etiquette

#

committiquette

green oriole Dec 4, 2019, 12:38 PM

#

Commit etiquette?

molten bough Dec 4, 2019, 12:38 PM

#

Learning when and why to commit, when to bunch commits or push them, how to write commit messages

#

learning to never force push (to master)

green oriole Dec 4, 2019, 12:39 PM

#

Oh yeah that kind of etiquette

#

Force pushing can be useful

#

But yeah, not to master

#

Just. please no

gusty sonnet Dec 4, 2019, 12:40 PM

#

stash
stash pop
omg where's my precious commits pls giv back

molten bough Dec 4, 2019, 12:40 PM

#

haha

#

I use the thing that jetbrains recommends

#

shelve?

green oriole Dec 4, 2019, 12:40 PM

#

Arg you use jetbrains features?

molten bough Dec 4, 2019, 12:40 PM

#

oh god yes

#

why waste time with the command line

#

I already know how to use it

green oriole Dec 4, 2019, 12:40 PM

#

Command line is great!

clever wraith Dec 4, 2019, 12:41 PM

#

can you give me that guide @green oriole

green oriole Dec 4, 2019, 12:41 PM

#

(except for stashing diiferent parts of a file)

#

https://git-scm.com/book/en/v2

molten bough Dec 4, 2019, 12:41 PM

#

also I find that PyCharm is way better at automatically resolving merge conflicts than git itself is

clever wraith Dec 4, 2019, 12:42 PM

#

right here is where i want the bookmark to be used

green oriole Dec 4, 2019, 12:42 PM

#

I hate pycharm's way to handle merge conficts: do nothing

clever wraith Dec 4, 2019, 12:42 PM

#

LOL

molten bough Dec 4, 2019, 12:42 PM

#

there's nothing better than a nice 3-way mergetool

#

that at least is something the community can agree on

#

haha

green oriole Dec 4, 2019, 12:42 PM

#

Yes I agree

#

But if I start resolving a merge conflit from the command line, PyCharm just don't care and doesn't open a solver or something

molten bough Dec 4, 2019, 12:43 PM

#

also by the time pycharm has prompted you to handle a merge conflict, it's already tried to merge automatically

#

well yeah, you need to use the git tools built in for those git tools to work

#

it's not going to try to interfere with your manual workflow if you use it

green oriole Dec 4, 2019, 12:44 PM

#

But I don't want to use them! ducky

molten bough Dec 4, 2019, 12:44 PM

#

well then you clearly don't need the mergetool either

clever wraith Dec 4, 2019, 12:44 PM

#

The commands can only be used in #seasonalbot-commands and #bot-commands channels

#

as said in issue comment

green oriole Dec 4, 2019, 12:44 PM

#

It is a decorator

#

I think

#

But I prefer using a mergetool than just manually resolving the conflicts

molten bough Dec 4, 2019, 12:45 PM

#

Why do you prefer the commandline to clicking a button and having PyCharm fetch, stash any changes as needed, pull, unstash, and try to merge conflicts?

green oriole Dec 4, 2019, 12:45 PM

#

I find it easier

#

Everything in one place

molten bough Dec 4, 2019, 12:45 PM

#

you find what easier?

green oriole Dec 4, 2019, 12:46 PM

#

no need to go in a submenu of a submenu of a submenu of a submenu

molten bough Dec 4, 2019, 12:46 PM

#

git pll no wait gt pull argh

#

there is no submenu?

#

it's right there in the toolbar

clever wraith Dec 4, 2019, 12:46 PM

#

hey hey @green oriole listen
the code for 8bitify is

@commands.command(name="8bitify")
    async def eightbit_command(self, ctx: commands.Context) -> None:
        """Pixelates your avatar and changes the palette to an 8bit one."""
        async with ctx.typing():
            image_bytes = await ctx.author.avatar_url.read()
            avatar = Image.open(BytesIO(image_bytes))
            avatar = avatar.convert("RGBA").resize((1024, 1024))

            eightbit = self.pixelate(avatar)
            eightbit = self.quantize(eightbit)

            bufferedio = BytesIO()
            eightbit.save(bufferedio, format="PNG")
            bufferedio.seek(0)

            file = discord.File(bufferedio, filename="8bitavatar.png")

            embed = discord.Embed(
                title="Your 8-bit avatar",
                description='Here is your avatar. I think it looks all cool and "retro"'
            )

            embed.set_image(url="attachment://8bitavatar.png")
            embed.set_footer(text=f"Made by {ctx.author.display_name}", icon_url=ctx.author.avatar_url)

        await ctx.send(file=file, embed=embed)

where is the line which triggers that it is wrong channel ?

green oriole Dec 4, 2019, 12:46 PM

#

It do it by default I think

#

Try it

molten bough Dec 4, 2019, 12:47 PM

#

seasonalbot does it by default, yeah, afaik

#

I dunno what submenu you're talking about akarys

#

I only ever go into the VCS menu if I need to manually push a commit or I need to edit the remotes or something

green oriole Dec 4, 2019, 12:49 PM

#

Like, if I want to amend the last commit, use all unstashed files and do not change the commit message commit -a --amend --no-edit I don't need to search for the option

clever wraith Dec 4, 2019, 12:49 PM

#

here it is

#

📎 unknown.png

#

https://github.com/AG4lyf/seasonalbot/tree/master/bot/seasons/evergreen

GitHub

AG4lyf/seasonalbot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to bot that changes with the seasons. - AG4lyf/seasonalbot

molten bough Dec 4, 2019, 12:49 PM

#

yeah, you don't need to search for the option in pycharm

#

hit version control at the bottom, find the commit in the log, right-click, rewrite

green oriole Dec 4, 2019, 12:49 PM

#

Please, give it a better commit message AG

#

find the commit in the log
I can just do --amend instead

clever wraith Dec 4, 2019, 12:50 PM

#

i will post the one i am sending here before sending it

molten bough Dec 4, 2019, 12:50 PM

#

well if it's the latest commit then it's the top commit in the list, isn't it

#

📎 unknown.png

#

toolbar buttons

#

pull, commit, compare, history, rollback

clever wraith Dec 4, 2019, 12:51 PM

#

wrong emoji

green oriole Dec 4, 2019, 12:51 PM

#

I learned git with the command line anyway, I don't see the point of re-learning everything

molten bough Dec 4, 2019, 12:51 PM

#

the point is that it's faster

clever wraith Dec 4, 2019, 12:51 PM

#

✅

molten bough Dec 4, 2019, 12:51 PM

#

you remind me of those 60 year old linux kernel developers

#

I WILL USE SVN UNTIL I DIE

green oriole Dec 4, 2019, 12:52 PM

#

I don't think it is faster

#

at least for me

clever wraith Dec 4, 2019, 12:52 PM

#

it is

molten bough Dec 4, 2019, 12:52 PM

#

clicking a single button is definitely faster than opening a terminal, fetching, stashing, pulling, unstashing, and resolving conflicts

#

even if your fingers are robotic

green oriole Dec 4, 2019, 12:52 PM

#

I always have a terminal open 🙂

molten bough Dec 4, 2019, 12:52 PM

#

your point? haha

#

I mean hey, it's up to you to use the tools the way you prefer, but they are more efficient when used this way

#

until you actually start trying to use them, you'll never know.

green oriole Dec 4, 2019, 12:53 PM

#

I tried them tbh, and I didn't liked

molten bough Dec 4, 2019, 12:54 PM

#

I mean, if you think you need to go through submenus to pull, I'm not sure you tried it for long

#

haha

#

but you know, I agree with you

#

it's much more efficient to have all of the tools in one place

#

that place for me happens to be pycharm

green oriole Dec 4, 2019, 12:54 PM

#

Okay, it wasn't in a submenu, but I'm sure some options of git are hidden

molten bough Dec 4, 2019, 12:55 PM

#

Nothing you'll be using on a regular basis

green oriole Dec 4, 2019, 12:55 PM

#

Yeah, you're right, like I run all my code from command line not from pycharm

molten bough Dec 4, 2019, 12:55 PM

#

yeah, I have run configs

#

although you can't use pycharm's debugger without run configs either

#

so do you never use the debugger?

green oriole Dec 4, 2019, 12:56 PM

#

Does print() count as a debugger?

molten bough Dec 4, 2019, 12:56 PM

#

no

#

haha

green oriole Dec 4, 2019, 12:56 PM

#

No I'm kidding

#

Actually.. I rarely debug

molten bough Dec 4, 2019, 12:56 PM

#

womp womp

clever wraith Dec 4, 2019, 12:56 PM

#

I202 Additional newline in a group of imports. 'from discord.ext import commands' is identified as Third Party and 'import discord' is identified as Third Party
while i lint it

green oriole Dec 4, 2019, 12:56 PM

#

I use logs and stuff, but never actual debuggers

molten bough Dec 4, 2019, 12:56 PM

#

AG, well, what do you think the problem is?

green oriole Dec 4, 2019, 12:56 PM

#

You need to add a line break between them

molten bough Dec 4, 2019, 12:57 PM

#

no, wrong

green oriole Dec 4, 2019, 12:57 PM

#

*a blank line

molten bough Dec 4, 2019, 12:57 PM

#

Neither of you read the error haha

clever wraith Dec 4, 2019, 12:57 PM

#

it says third party

green oriole Dec 4, 2019, 12:57 PM

#

You put too much blank lines 🙂

molten bough Dec 4, 2019, 12:57 PM

#

there we go

green oriole Dec 4, 2019, 12:57 PM

#

haha

molten bough Dec 4, 2019, 12:57 PM

#

you have a blank line where there shouldn't be one

clever wraith Dec 4, 2019, 12:57 PM

#

I201 Missing newline between import groups. 'import discord' is identified as Third Party and 'import logging' is identified as Stdlib.

green oriole Dec 4, 2019, 12:57 PM

#

I mean, I don't have the code in front of me soo..

molten bough Dec 4, 2019, 12:58 PM

#

yep, now you need to add one

#

read the error

#

it's quite self-explanitory

green oriole Dec 4, 2019, 12:58 PM

#

Missing

clever wraith Dec 4, 2019, 12:58 PM

#

why its so tricky

molten bough Dec 4, 2019, 12:58 PM

#

it's not tricky

green oriole Dec 4, 2019, 12:58 PM

#

linters..

#

No okay linters are fine

#

Rules are sometimes weird

#

just need to get used to them

molten bough Dec 4, 2019, 12:58 PM

#

there are three separate groups of imports and they should be separated by a blank line

clever wraith Dec 4, 2019, 12:59 PM

#

D415 First line should end with a period, question mark, or exclamation point
"""A cog for Bookmark command"""
Really

molten bough Dec 4, 2019, 12:59 PM

#

standard library, first party (as in, from the current project), and third party

#

yes, really

green oriole Dec 4, 2019, 12:59 PM

#

Oh yeah, add a dot at the end

hardy gorge Dec 4, 2019, 12:59 PM

#

Yes

molten bough Dec 4, 2019, 12:59 PM

#

docstring linting, I must say, I fully support

green oriole Dec 4, 2019, 12:59 PM

#

This one is pretty.. special?

#

but I can understand the point

clever wraith Dec 4, 2019, 12:59 PM

#

TYP001 Missing type annotation for function argument 'ctx'
now what does that mean ,

#

:int

#

got it

molten bough Dec 4, 2019, 1:00 PM

#

It means you're missing a type annotation for argument "ctx"

#

and it's not int

hardy gorge Dec 4, 2019, 1:00 PM

#

The first line of a docstring should be a summary line summing up the class/method/function. As it needs to be a single, contained sentence, requiring a ., ! or ? at the end more or less guarantees people actually do that.

molten bough Dec 4, 2019, 1:00 PM

#

that's for sure

green oriole Dec 4, 2019, 1:00 PM

#

You know what typehints are?

clever wraith Dec 4, 2019, 1:00 PM

#

i know just a type

molten bough Dec 4, 2019, 1:00 PM

#

ctx is a Context object

#

look at the other command in the bot

clever wraith Dec 4, 2019, 1:00 PM

#

commands.Context

molten bough Dec 4, 2019, 1:01 PM

#

well, just Context, and import it from discord.commands

green oriole Dec 4, 2019, 1:01 PM

#

I don't really see a case where you would put ? at the end of your docstring, like This function might do something?

molten bough Dec 4, 2019, 1:01 PM

#

long type hints are not friendly

#

def freeze():
    """"
    Do you want to build a snowman?

    This function freezes ...
    """

clever wraith Dec 4, 2019, 1:01 PM

#

D102 Missing docstring in public method
i really don't understand this one

molten bough Dec 4, 2019, 1:01 PM

#

me_irl

#

Well that means you're missing a docstring

green oriole Dec 4, 2019, 1:01 PM

#

Oh yeah!!

clever wraith Dec 4, 2019, 1:02 PM

#

what is a docstring

molten bough Dec 4, 2019, 1:02 PM

#

I'm sorry, what

#

oh right

green oriole Dec 4, 2019, 1:02 PM

#

https://discordapp.com/channels/267624335836053506/635950537262759947/651770120938717224 this

molten bough Dec 4, 2019, 1:02 PM

#

the error didn't say docstring

#

yeah, that's a docstring

#

you should document every public method or function with a docstring.

clever wraith Dec 4, 2019, 1:02 PM

#

AHHH
a """ whatever i want is here """ thing

#

so that is called a docstring

molten bough Dec 4, 2019, 1:02 PM

#

yes, that's a docstring. Triple-quoted string.

clever wraith Dec 4, 2019, 1:03 PM

#

bot\seasons\evergreen\bookmark.py:16:28: TYP201 Missing return type annotation for public function

#

why so strict

molten bough Dec 4, 2019, 1:03 PM

#

Yep, you haven't type hinted a return type

#

Because consistency is important and type hints are useful

green oriole Dec 4, 2019, 1:04 PM

#

Because typehints are great!

molten bough Dec 4, 2019, 1:04 PM

#

You'll get used to it.

clever wraith Dec 4, 2019, 1:04 PM

#

    async def bm(self, ctx: commands.Context, hypelink: str =None, *args):

#

now what is wrong i don't get what you mean by typehints

molten bough Dec 4, 2019, 1:05 PM

#

hypelink?

#

you mean hyperlink? or maybe just link?

green oriole Dec 4, 2019, 1:05 PM

#

also call it bookmark instead

clever wraith Dec 4, 2019, 1:05 PM

#

yeah hyperlink ;-; it uses that

molten bough Dec 4, 2019, 1:05 PM

#

your default type has incorrect syntax also

#

anyway, return types are ```py
def function() -> Type:

green oriole Dec 4, 2019, 1:05 PM

#

But the lint should tell it

gusty sonnet Dec 4, 2019, 1:06 PM

#

Try to name it meaningful, you can add command name / alias in later

molten bough Dec 4, 2019, 1:06 PM

#

yeah

clever wraith Dec 4, 2019, 1:06 PM

#

Done

molten bough Dec 4, 2019, 1:06 PM

#

bookmark instead of bm, add bm alias later

clever wraith Dec 4, 2019, 1:06 PM

#

    async def bookmark(self, ctx: commands.Context, hypelink: str =None, *args)-> None:

molten bough Dec 4, 2019, 1:06 PM

#

that link argument should have spaces around the = as well

clever wraith Dec 4, 2019, 1:06 PM

#

now its that

green oriole Dec 4, 2019, 1:06 PM

#

About the function name: https://media.discordapp.net/attachments/267624335836053506/448648499446284308/unknown.png

molten bough Dec 4, 2019, 1:06 PM

#

and don't call it hypelink, pls

#

I like that screenshot

#

haha

gusty sonnet Dec 4, 2019, 1:07 PM

#

Me too

#

Quick, we help with the PR so we can bookmark it

green oriole Dec 4, 2019, 1:07 PM

#

Well, you'll get a review for sure if you call it hypelink

clever wraith Dec 4, 2019, 1:07 PM

#

its catchy so i am using hypelink

molten bough Dec 4, 2019, 1:07 PM

#

don't use that

#

it's a useless name

green oriole Dec 4, 2019, 1:07 PM

#

It is pinned in #python-discussion

molten bough Dec 4, 2019, 1:07 PM

#

it needs to be descriptive

gusty sonnet Dec 4, 2019, 1:07 PM

#

It should be named jump_url or message_jump_url or message_link

#

a hyperlink is too generic

molten bough Dec 4, 2019, 1:07 PM

#

or just link maybe

#

hmm, well, I guess, yeah

clever wraith Dec 4, 2019, 1:08 PM

#

async def bookmark(self, ctx: commands.Context, hyperlink: str =None, *args)-> None:

#

ok now ?

green oriole Dec 4, 2019, 1:08 PM

#

jump_url is used in the reminder cog, so you maybe should use it

clever wraith Dec 4, 2019, 1:08 PM

#

happy now

gusty sonnet Dec 4, 2019, 1:08 PM

#

Also hyperlink is used to refer to clickable text that has url

molten bough Dec 4, 2019, 1:08 PM

#

yeah jump_url is probably better for consistency then

clever wraith Dec 4, 2019, 1:08 PM

#

BC

molten bough Dec 4, 2019, 1:08 PM

#

also that = needs a space on the right side of it

green oriole Dec 4, 2019, 1:08 PM

#

hyperlink: str =None seems wrong too

#

Well

molten bough Dec 4, 2019, 1:08 PM

#

jump_url: str = None

gusty sonnet Dec 4, 2019, 1:09 PM

#

PyCharm should have an extension for auto formatting code, right?

molten bough Dec 4, 2019, 1:09 PM

#

I mean that type hint is technically incorrect

gusty sonnet Dec 4, 2019, 1:09 PM

#

for VSCode I have one that auto format accordingly to PEP8

molten bough Dec 4, 2019, 1:09 PM

#

but I'm not sure discord.py will put up with Optional[str]

gusty sonnet Dec 4, 2019, 1:09 PM

#

It does

molten bough Dec 4, 2019, 1:09 PM

#

aha, then yeah

gusty sonnet Dec 4, 2019, 1:09 PM

#

But it should be required anyway

clever wraith Dec 4, 2019, 1:09 PM

#

    async def bookmark(self, ctx: commands.Context, jump_url: str = None, *args) -> None:

#

fine ?

molten bough Dec 4, 2019, 1:09 PM

#

What does the command do if no jump URL is given?

gusty sonnet Dec 4, 2019, 1:09 PM

#

Hmm, the jump url will never be None in that case

clever wraith Dec 4, 2019, 1:10 PM

#

it checks for the message above the .bm

gusty sonnet Dec 4, 2019, 1:10 PM

#

Like if you do !bm hello no link provided

green oriole Dec 4, 2019, 1:10 PM

#

It does correct it

molten bough Dec 4, 2019, 1:10 PM

#

Ah right

clever wraith Dec 4, 2019, 1:10 PM

#

I planeed that

gusty sonnet Dec 4, 2019, 1:10 PM

#

hello will be the jump_url

molten bough Dec 4, 2019, 1:10 PM

#

Then it should be type hinted Optional[str]

gusty sonnet Dec 4, 2019, 1:10 PM

#

So it will never be None

clever wraith Dec 4, 2019, 1:10 PM

#

        if jump_url is None or jump_url == "*":
            channel = ctx.channel
            async for x in channel.history(limit=2):
                message_id = x.id
            try:
                message = await channel.fetch_message(message_id)
            except discord.NotFound:
                await ctx.send(">>> Message not in this"
                               " channel\nOr\nYou are trying to Pin"
                               " your own message,\nPlease use the channel"
                               " where message is.")
                return
            hyperlink = f"https://discordapp.com/channels/" \
                       f"{ctx.guild.id}/{channel.id}/{message.id}"

molten bough Dec 4, 2019, 1:10 PM

#

I'm not sure it needs to take * as an argument in that case

gusty sonnet Dec 4, 2019, 1:11 PM

#

What if you do !bm bookmark this message, this is a command with no link

molten bough Dec 4, 2019, 1:11 PM

#

It just takes a url right now

gusty sonnet Dec 4, 2019, 1:11 PM

#

What will your bot do

#

jump_url should take in bookmark

clever wraith Dec 4, 2019, 1:11 PM

#

            if "discordapp.com/channels" not in jump_url:
                await ctx.send("INVALID URL")
                await ctx.send("An example of the command can be \n"
                               "!bm https://discordapp.com/channels"
                               "/267624335836053506/267631170882240512/"
                               "554639398130548746"
                               " Some of the hints here")
                return

green oriole Dec 4, 2019, 1:11 PM

#

The jump_url is generated by d.py

molten bough Dec 4, 2019, 1:11 PM

#

It's not

gusty sonnet Dec 4, 2019, 1:11 PM

#

In that case yeah it should be just py jump_url: str

green oriole Dec 4, 2019, 1:11 PM

#

Well, it can be

gusty sonnet Dec 4, 2019, 1:11 PM

#

Adding = None to it is redundant

green oriole Dec 4, 2019, 1:11 PM

#

I mean for the hyperlink

molten bough Dec 4, 2019, 1:12 PM

#

It's not redundant

gusty sonnet Dec 4, 2019, 1:12 PM

#

You mean for !bmbare?

#

That's the only case when it'll be None

molten bough Dec 4, 2019, 1:12 PM

#

Yeah, which is a supported operation

clever wraith Dec 4, 2019, 1:12 PM

#

https://paste.pythondiscord.com/odumizumej.py

gusty sonnet Dec 4, 2019, 1:12 PM

#

In that case I'd say do a py @bookmark_error async def bookmark_error_handler(self, ctx, error): await ctx.send('You have to give me a link!')

molten bough Dec 4, 2019, 1:13 PM

#

that's not

green oriole Dec 4, 2019, 1:13 PM

#

hyperlink = f"https://discordapp.com/channels/" \
                       f"{ctx.guild.id}/{channel.id}/{message.id}"```-->
```py
hyperlink = message.jump_url```too

molten bough Dec 4, 2019, 1:13 PM

#

no

#

If it's bare you just bookmark the previous message

gusty sonnet Dec 4, 2019, 1:13 PM

#

Oooooooooh

#

I see, I see why you need the = None now

#

Carry on!

molten bough Dec 4, 2019, 1:13 PM

#

however

#

the fact that the command can only be run in #bot-commands or #sir-lancebot-playground

#

kind of makes that feature useless

clever wraith Dec 4, 2019, 1:13 PM

#

yeah i also said that

green oriole Dec 4, 2019, 1:13 PM

#

It was discussed by the staff apparently

molten bough Dec 4, 2019, 1:14 PM

#

"apparently" isn't really enough info

#

haha

green oriole Dec 4, 2019, 1:14 PM

#

Well, it has been

gusty sonnet Dec 4, 2019, 1:14 PM

#

It was discussed internally, the main concern is that it can be spammy in regular help channels interrupting conversations

#

In general it should be avoided

molten bough Dec 4, 2019, 1:14 PM

#

Couldn't it just immediately remove the command message?

green oriole Dec 4, 2019, 1:14 PM

#

^

clever wraith Dec 4, 2019, 1:14 PM

#

yeah

molten bough Dec 4, 2019, 1:14 PM

#

And then only reply in DM

clever wraith Dec 4, 2019, 1:15 PM

#

thats what i said

#

https://github.com/python-discord/seasonalbot/issues/323#issuecomment-561215071

GitHub

Feature Request - personal Pins AKA bookmarks · Issue #323 · pyt...

Bot command - !bookmark Useful for the cases in which you want to pin some useful info from someone who sent it . basically it sends a embed to DM of the author , consisting a link to that specific...

molten bough Dec 4, 2019, 1:15 PM

#

I mean, they may have discussed that, but that's what I'd do, haha

clever wraith Dec 4, 2019, 1:19 PM

#

I don't think they discussed about that cuz the handler of that issue scragly went offline as soon as i commented that , and never came back , i don't think someone actually opened the issue and proceed to read even though they can see scragly reported it

woeful thorn Dec 4, 2019, 1:19 PM

#

Yes, we did

green oriole Dec 4, 2019, 1:20 PM

#

Well, everyone can see #dev-log

clever wraith Dec 4, 2019, 1:20 PM

#

oh then NICE

#

last lint then i am pulling a PR

green oriole Dec 4, 2019, 1:20 PM

#

ELA is sneaky, he set his status to idle so he can burst in the conversation at any moment haha

clever wraith Dec 4, 2019, 1:21 PM

#

second last

#

📎 unknown.png

#

LETS GOOO

molten bough Dec 4, 2019, 1:22 PM

#

just remember that passed linting doesn't mean there won't be more reviewing :>

clever wraith Dec 4, 2019, 1:23 PM

#

first ever PR

#

is that OK ?

📎 unknown.png

crude gyro Dec 4, 2019, 1:24 PM

#

..Add files via upload?

green oriole Dec 4, 2019, 1:24 PM

#

Your commit messages aren't really great

crude gyro Dec 4, 2019, 1:24 PM

#

what kind of commit message is that

clever wraith Dec 4, 2019, 1:24 PM

#

that one is from my fork

#

📎 unknown.png

#

forgot to expand it

crude gyro Dec 4, 2019, 1:25 PM

#

frankly, those commit messages aren't good enough.

green oriole Dec 4, 2019, 1:25 PM

#

So just use them as the main message, not the descriptions

clever wraith Dec 4, 2019, 1:26 PM

#

✓

green oriole Dec 4, 2019, 1:26 PM

#

Did you deleted the old commits?

clever wraith Dec 4, 2019, 1:27 PM

#

there are only 3 commits total ;-; it don't need anything else

crude gyro Dec 4, 2019, 1:27 PM

#

@clever wraith Please read through the following articles.

https://chris.beams.io/posts/git-commit/
https://thoughtbot.com/blog/5-useful-tips-for-a-better-commit-message
http://ablogaboutcode.com/2011/03/23/proper-git-commit-messages-and-an-elegant-git-history
https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

green oriole Dec 4, 2019, 1:27 PM

#

I mean, how does your commit history looks like right now?

clever wraith Dec 4, 2019, 1:28 PM

#

📎 unknown.png

green oriole Dec 4, 2019, 1:29 PM

#

Aaaand you are on master

clever wraith Dec 4, 2019, 1:29 PM

#

📎 unknown.png

green oriole Dec 4, 2019, 1:30 PM

#

Why you didn't commited from the command line or pycharm?

clever wraith Dec 4, 2019, 1:30 PM

#

i am not confident with that yet

green oriole Dec 4, 2019, 1:30 PM

#

You know what? Delete your repo, re-fork it, and then switch to a new branch, and upload your files with a nice commit message

#

We can help you if you want

clever wraith Dec 4, 2019, 1:31 PM

#

i alredy created a PR

#

;-;

#

too late

green oriole Dec 4, 2019, 1:32 PM

#

I think using the web interface is okay, as long as you write nice commit messages and you don't delete a file just to edit it

#

I'm sorry, but you need to reset the history of your branch

#

We can't merge that

clever wraith Dec 4, 2019, 1:32 PM

#

I promise i will do it next time.

#

Please I have a ton of homework to do ;-; TBH

green oriole Dec 4, 2019, 1:32 PM

#

No, we can't leave that in the history

#

I can do it for you if you want

#

But the commit author will be me then, if you really really can't do it @clever wraith

clever wraith Dec 4, 2019, 1:33 PM

#

I can

#

ok lets do it

#

delete the PR ?

green oriole Dec 4, 2019, 1:34 PM

#

No no if you have checked the allow edits from maintainers box, it is good

clever wraith Dec 4, 2019, 1:34 PM

#

yeah i did

green oriole Dec 4, 2019, 1:34 PM

#

Okay

clever wraith Dec 4, 2019, 1:36 PM

#

Now what ?

green oriole Dec 4, 2019, 1:36 PM

#

I'm squashing them

clever wraith Dec 4, 2019, 1:36 PM

#

RIP

green oriole Dec 4, 2019, 1:40 PM

#

Okay it is done

#

Time for reviewing

clever wraith Dec 4, 2019, 1:41 PM

#

It will pass for sure

#

passed

green oriole Dec 4, 2019, 1:42 PM

#

I mean, time for humans to review it

clever wraith Dec 4, 2019, 1:42 PM

#

Oh so i now need 2 people

#

ofc not you cuz you are not human ofc

#

you can't approve it right

green oriole Dec 4, 2019, 1:44 PM

#

Tbh, you can expect some changes

clever wraith Dec 4, 2019, 1:44 PM

#

ik

#

sneaky @gusty sonnet

gusty sonnet Dec 4, 2019, 1:46 PM

#

In order for a PR to be merged, you need 2 approves and at least one of them has to be from a core dev

clever wraith Dec 4, 2019, 1:47 PM

#

lets see

green oriole Dec 4, 2019, 1:47 PM

#

I can't start the bot

discord.ext.commands.errors.ExtensionFailed: Extension 'bot.seasons.evergreen.bookmark' raised an error: ClientException: The alias bookmark is already an existing command or alias.```

clever wraith Dec 4, 2019, 1:48 PM

#

wtf

#

i can

#

should i try to git my fork and opening it

green oriole Dec 4, 2019, 1:48 PM

#

I did it

clever wraith Dec 4, 2019, 1:49 PM

#

I really have no idea

#

you see whats the issue

green oriole Dec 4, 2019, 1:49 PM

#

You called the command bookmark and you want to add an alias bookmark

#

So d.py doesn't like it

clever wraith Dec 4, 2019, 1:49 PM

#

ahhh

#

u guys made me do it

green oriole Dec 4, 2019, 1:50 PM

#

Can you correct that quickly from the web edit please

clever wraith Dec 4, 2019, 1:50 PM

#

doing

green oriole Dec 4, 2019, 1:50 PM

#

Well, you were supposed to test it again

clever wraith Dec 4, 2019, 1:51 PM

#

what should i do it

#

def book_mark ?

green oriole Dec 4, 2019, 1:51 PM

#

Just delete the alias bookmark

clever wraith Dec 4, 2019, 1:52 PM

#

📎 unknown.png

green oriole Dec 4, 2019, 1:52 PM

#

THE COMMIT MESSAGE!!

clever wraith Dec 4, 2019, 1:52 PM

#

its good enough

green oriole Dec 4, 2019, 1:52 PM

#

Not update bookmark.py

#

And fixed a bug isn't enough

#

Have you read the links lemon sent you?

#

You could do something like

Delete alias bookmark

Caused an error because the same alias was used twice```

clever wraith Dec 4, 2019, 1:54 PM

#

i don't have time , i have ton of homework to do

molten bough Dec 4, 2019, 1:54 PM

#

Fix error caused by command alias conflict or something

green oriole Dec 4, 2019, 1:54 PM

#

Then do it later

clever wraith Dec 4, 2019, 1:54 PM

#

ITS OK now

#

let it do it work

#

you want a demo ? i can invite u to my test server

green oriole Dec 4, 2019, 1:55 PM

#

I prefer to test it in my own environment so we can be sure it can work outside of the machine on which the code was written 🙂

clever wraith Dec 4, 2019, 1:56 PM

#

Ok

green oriole Dec 4, 2019, 1:56 PM

#

So, the commit message?

clever wraith Dec 4, 2019, 1:56 PM

#

ahhhhhhhh

green oriole Dec 4, 2019, 1:56 PM

#

I can rollback for you, and you re-commit it with a meaningful message, is it good for you?

clever wraith Dec 4, 2019, 1:56 PM

#

Fine

#

why so peaky

#

picky* whatever is right

green oriole Dec 4, 2019, 1:57 PM

#

Because when you browse though more than a thousand commits, the commit message is important

clever wraith Dec 4, 2019, 1:58 PM

#

wait

#

have you done it ?

#

@green oriole

green oriole Dec 4, 2019, 1:59 PM

#

not yet

#

Okay it is done

#

Please do not make me do that again

clever wraith Dec 4, 2019, 1:59 PM

#

I think i found another bug lol

green oriole Dec 4, 2019, 1:59 PM

#

Write good messages!

#

Do one commit per bug please

clever wraith Dec 4, 2019, 2:00 PM

#

Am deleting the repo

#

will do it all over again

#

new PR and all

#

Ok ?

green oriole Dec 4, 2019, 2:01 PM

#

I guess that's too late

tardy marsh Dec 4, 2019, 2:01 PM

#

...

clever wraith Dec 4, 2019, 2:01 PM

#

i did it alredy

#

the pr is closed alredy

green oriole Dec 4, 2019, 2:01 PM

#

Yeah because I pushed just after you deleted it

#

Watever

clever wraith Dec 4, 2019, 2:01 PM

#

LOL

green oriole Dec 4, 2019, 2:02 PM

#

Please this time make a new branch too

#

Do not work on master

#

Bad things could happen

clever wraith Dec 4, 2019, 2:03 PM

#

📎 unknown.png

green oriole Dec 4, 2019, 2:06 PM

#

Here is what happen if you do not informative commit messages https://imgs.xkcd.com/comics/git_commit.png

molten bough Dec 4, 2019, 2:06 PM

#

It's probably worth pointing out that development is a team effort, here

#

It's not about being picky, or having a linter that's too strict

#

We have a set of standards, and everyone has to follow them - it keeps the code readable, and it makes sure everyone knows exactly what's going on and why changes were made

#

A PR is often presented in isolation, but it's going to be a smaller piece of a larger project, and it's important that it also meets the standards everyone else adheres to

#

that said, we're not making updates for pacemaker software here, if you don't have time to read the literature that people are giving you, then your PR can wait

#

I get that this is your first PR, AG, but I know you're capable of this :>

clever wraith Dec 4, 2019, 2:10 PM

#

;-;

#

working on it

molten bough Dec 4, 2019, 2:10 PM

#

Also, don't stress out about rushing

#

If you need to do homework, do homework

#

Real life takes priority, yeah?

clever wraith Dec 4, 2019, 2:10 PM

#

na

#

;-;

molten bough Dec 4, 2019, 2:11 PM

#

you don't wanna know how much time I lost when I was staff over burning myself out :>

clever wraith Dec 4, 2019, 2:12 PM

#

yeah i don't wanna

#

;-;

green oriole Dec 4, 2019, 2:12 PM

#

You should ^^

molten bough Dec 4, 2019, 2:13 PM

#

haha, I just mean, don't overdo it

#

it'll be fine if you need to something else

#

if you just keep beating your head off a wall, eventually you'll get a headache

clever wraith Dec 4, 2019, 2:15 PM

#

what was the command to lint

#

nvm got it

#

no linting issue

#

working fine

#

looks like

#

@green oriole

#

i am uploading bookmark.py now OK ?

green oriole Dec 4, 2019, 2:19 PM

#

And you write a meaningful commit message, not Added file via upload (delete it)

clever wraith Dec 4, 2019, 2:19 PM

#

it is the default line

gusty sonnet Dec 4, 2019, 2:19 PM

#

It can be as short as Introduced `!bm` command for personal bookmarking message via message jump url

clever wraith Dec 4, 2019, 2:19 PM

#

ok suggest me

📎 unknown.png

mellow hare Dec 4, 2019, 2:20 PM

#

It just needs to be descriptive, that's all

clever wraith Dec 4, 2019, 2:20 PM

#

📎 unknown.png

gusty sonnet Dec 4, 2019, 2:20 PM

#

You also want to create a branch first

#

Then commit to that branch instead of master

clever wraith Dec 4, 2019, 2:20 PM

#

ok

gusty sonnet Dec 4, 2019, 2:20 PM

#

In case things go wrong / when the master repo on the main repo updates

clever wraith Dec 4, 2019, 2:20 PM

#

lets do that first

gusty sonnet Dec 4, 2019, 2:20 PM

#

Otherwise it'll be a nightmare

#

You can open a PR from any branch

green oriole Dec 4, 2019, 2:21 PM

#

Yep, it is a nightmare <_< (I did that for my first contrib)

clever wraith Dec 4, 2019, 2:21 PM

#

how to push a branch ?

gusty sonnet Dec 4, 2019, 2:22 PM

#

You can type a name for the new branch, then hit enter

📎 unknown.png

#

Afterward, you can change the branch to push for in the CLI

clever wraith Dec 4, 2019, 2:25 PM

#

new branch ☑️

#

📎 unknown.png

#

now fine ? @green oriole

green oriole Dec 4, 2019, 2:29 PM

#

Actually I don't think you need the extended description, but you written it, and there is never too much!

clever wraith Dec 4, 2019, 2:29 PM

#

ok ?

📎 unknown.png

green oriole Dec 4, 2019, 2:29 PM

#

You could have kept it..

#

Yes yes it is fine

clever wraith Dec 4, 2019, 2:29 PM

#

hahahah

#

ok ?

📎 unknown.png

green oriole Dec 4, 2019, 2:30 PM

#

just a bit of pickiness: can you delete the space before the comma 🙂

clever wraith Dec 4, 2019, 2:31 PM

#

📎 unknown.png

green oriole Dec 4, 2019, 2:31 PM

#

Saw it ^^

#

Perfect

clever wraith Dec 4, 2019, 2:31 PM

#

next step add a pr ?

green oriole Dec 4, 2019, 2:31 PM

#

Yep!

clever wraith Dec 4, 2019, 2:32 PM

#

this is ok right

📎 unknown.png

green oriole Dec 4, 2019, 2:34 PM

#

The message body is weird, but it is fine

#

It can still be edited later and doesn't go in the history

clever wraith Dec 4, 2019, 2:34 PM

#


---
name: .bookmarks
about: helps to bookmark something useful along hint(s) to find in future.
issue: Issue #323 



---

Provide a simple description of what the PR achieves. 

## Pull Request Details

Please ensure your PR fulfills the following criteria:

[ ✓] Have you joined the PythonDiscord Community?
[ ✓] Were your changes made in a Pipenv environment?
[✓ ] Does flake8 pass (pipenv run lint)


## Additional information

There is no check whether if the call is  in the right channel or not , because seasonalbot do it itself.

green oriole Dec 4, 2019, 2:35 PM

#

👌

clever wraith Dec 4, 2019, 2:35 PM

#

DONE

gusty sonnet Dec 4, 2019, 3:08 PM

#

Hmm, I'm writing unit tests for bot.utils.time but somehow it is not being discovered, anyone knows why might be the case?

#

I created a tests.bot.utils.test_time.py

#

from unittest import TestCase

class TimeTests(TestCase):
    """Test helper functions in bot.utils.time."""

    def test_humanize_delta(self):
        ...```

#

It is not being discovered at all

green oriole Dec 4, 2019, 3:11 PM

#

@clever wraith reviewed!

clever wraith Dec 4, 2019, 3:12 PM

#

OMG

crude gyro Dec 4, 2019, 3:15 PM

#

@green oriole putting an entire pull request in a single commit isn't really that much better, but at least the commit message is marginally better.

#

I kinda feel like you should read those links I posted earlier, too.

green oriole Dec 4, 2019, 3:16 PM

#

I mean, he don't know how to use the command line, at least it is a meaningful commit message

#

I know, split commits in case you need to revert them

hardy gorge Dec 4, 2019, 3:16 PM

#

@gusty sonnet Interesting and odd. I'll check it out later. Did you push that branch to the remote?

molten bough Dec 4, 2019, 3:16 PM

#

I thought that was because he deleted his old PR and branch

gusty sonnet Dec 4, 2019, 3:16 PM

#

I created the branch, didnt push my commits yet since I cant even discover all the tests on my vscode

#

This is everything it managed to find

#

📎 unknown.png

hardy gorge Dec 4, 2019, 3:17 PM

#

Does VSCode use a different test runner?

gusty sonnet Dec 4, 2019, 3:18 PM

#

I'm discovering via unittest in it, not sure if it's different

#

📎 unknown.png

#

I guess I can try via CLI

crude gyro Dec 4, 2019, 3:18 PM

#

@green oriole so you're not gonna read those articles? they really might be helpful. you've made several cardinal sins here in this commit message:

📎 unknown.png

hardy gorge Dec 4, 2019, 3:19 PM

#

I mean, the current tests we have a definitely discovered by unittest when we run them, so if it's not recognizing other tests as well, it may be something local

green oriole Dec 4, 2019, 3:19 PM

#

I mean, I didn't wrote the message

hardy gorge Dec 4, 2019, 3:19 PM

#

can you try to run them from the command line?

#

pipenv run test?

green oriole Dec 4, 2019, 3:19 PM

#

and I thing i might have already read them

clever wraith Dec 4, 2019, 3:19 PM

#

@green oriole now how to edit the .py file that i submitted ?

crude gyro Dec 4, 2019, 3:19 PM

#

I thought you were helping @clever wraith solve the problem, my mistake.

gusty sonnet Dec 4, 2019, 3:20 PM

#

Interesting, I see the new stuff in settings.json now, I will fiddle with it

clever wraith Dec 4, 2019, 3:21 PM

#

enough to fix all the issues tho

📎 unknown.png

green oriole Dec 4, 2019, 3:22 PM

#

~~some silly things~~

#

Can it be with it doesn't detect it?

#

@clever wraith you should better do it from command line now, since all changes need to be tested

hardy gorge Dec 4, 2019, 3:23 PM

#

from which directory did you run the command, Akarys?

#

you should do it from the main directory of the repository

green oriole Dec 4, 2019, 3:24 PM

#

Oh my bad, I though it doesn't matter

#

Seems logic

clever wraith Dec 4, 2019, 3:36 PM

#

Done fixed all the grammatical issues . also simplified the code a bit .

gusty sonnet Dec 4, 2019, 3:36 PM

#

Okay, so VSCode cannot discover the tests, the unittest command can

#

Guess I have to rely on it then

hardy gorge Dec 4, 2019, 3:37 PM

#

Is there something we can change to make it work?

clever wraith Dec 4, 2019, 3:38 PM

#

I hope now it passes @green oriole take a look

green oriole Dec 4, 2019, 3:42 PM

#

Not at my computer right now, I will check it later ^^

gusty sonnet Dec 4, 2019, 3:53 PM

#

I will have to look deeper into vscode, since unittest in cmd works just fine

#

self.assertIsInstance(error, ValueError)
self.assertEqual(str(error), 'max_units must be positive')
```is there a nicer way to do this lol

hardy gorge Dec 4, 2019, 3:56 PM

#

assertRaises

#

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises

gusty sonnet Dec 4, 2019, 3:57 PM

#

Thank you

#

with self.assertRaises(ValueError) as error:
    time.humanize_delta(relativedelta(days=2, hours=2), 'hours', max_units)
    self.assertEqual(str(error), 'max_units must be positive')
```like this, yes?

#

Should I include tests for the new functions in bot.utils.time? I should wait for the PR to be approved right?

#

Or should I just open a PR for the current functions, and open another later?

crude gyro Dec 4, 2019, 4:53 PM

#

the current util functions have tests?

#

in that case, yes.

#

otherwise, well, it's your call.

#

ideally tests should be part of the same PR as the features.

gusty sonnet Dec 4, 2019, 4:54 PM

#

Hmm, that's actually a better idea

#

I'll open a PR for the current functions then

#

Thanks lemon

crude gyro Dec 4, 2019, 4:55 PM

#

np

gusty sonnet Dec 4, 2019, 5:32 PM

#

It works!

📎 unknown.png

#

Now someone tells me how to round relativedelta lol

tawdry vapor Dec 4, 2019, 5:34 PM

#

with a lot of if statements

green oriole Dec 4, 2019, 5:40 PM

#

Add a delta of one second 😁

#

From my testing for the reminder cog, it is reliable

clever wraith Dec 4, 2019, 6:18 PM

#

@crude gyro what is K&R ?

crude gyro Dec 4, 2019, 6:19 PM

#

I explained it in one of the other comments.

molten bough Dec 4, 2019, 6:19 PM

#

The authors of that C book, I thought

#

What's it RE python?

crude gyro Dec 4, 2019, 6:20 PM

#

it's an indentation style where the braces are like this:

things = (
    "stuff"
)

molten bough Dec 4, 2019, 6:20 PM

#

Oh! Right

#

And it was the same guys that came up with it, wasn't it

clever wraith Dec 4, 2019, 6:20 PM

#

why its called K&R

molten bough Dec 4, 2019, 6:21 PM

#

Brian Kernighan and Dennis Ritchie

clever wraith Dec 4, 2019, 6:21 PM

#

?

crude gyro Dec 4, 2019, 6:21 PM

#

yeah, kernighan and ritchie

clever wraith Dec 4, 2019, 6:21 PM

#

ritchie

#

that name is familiar

crude gyro Dec 4, 2019, 6:21 PM

#

basically they wrote this https://en.wikipedia.org/wiki/The_C_Programming_Language

The C Programming Language

The C Programming Language (sometimes termed K&R, after its authors' initials) is a computer programming book written by Brian Kernighan and Dennis Ritchie, the latter of whom originally designed and implemented the language, as well as co-designed the Unix operating system w...

hardy gorge Dec 4, 2019, 6:21 PM

#

If you have some time left over: https://www.youtube.com/watch?v=zmYhR8cUX90

YouTube

Computerphile

Brian Kernighan Q&A - Computerphile

Hear Brian Kernighan on how he got into programming, the successors of C and the biggest challenges... Watch Part 2 before it's live!: https://youtu.be/VVpRj...

▶ Play video

molten bough Dec 4, 2019, 6:22 PM

#

Those guys are legends, I haven't written a single line of C and I've heard of them

clever wraith Dec 4, 2019, 6:23 PM

#

lemon will squeeze me now see.

molten bough Dec 4, 2019, 6:28 PM

#

In this world, it's squeeze or be squeezed.

green oriole Dec 4, 2019, 6:36 PM

#

Yes, but if you squeeze lemon you end up with a lemonade, and I'm not sure this is what you want

gusty sonnet Dec 4, 2019, 6:38 PM

#

Requesting reviews on https://github.com/python-discord/bot/pull/680 - if this is approved, then I can put in the test for #679 too

GitHub

Added `unittest` for `bot.utils.time` by ikuyarihS · Pull Request...

Closes #608

Translated the old pytest tests in tests.utils.test_time.py to unittest
Added tests for format_infraction_with_duration

tough imp Dec 4, 2019, 6:40 PM

#

what is the purpose of def setUp(self): pass?

gusty sonnet Dec 4, 2019, 6:41 PM

#

Mostly to setup variables for the class, right now it is not doing anything, I can remove it

#

In fact, yeah, I will remove it

green oriole Dec 4, 2019, 8:22 PM

#

@clever wraith before I go, I resolved all conversation that you addressed, but there is still the ones that left. Just two small thing, can you please not comment "Agreed" on all comments and can you also press the apply suggestion button when avaliable, so it dismiss the comment, make sure you have commuted the good changes and gave credits to the reviewer please

clever wraith Dec 4, 2019, 8:23 PM

#

yeah i really didnt knew that agree were gonna look like that mess

#

i thought it will bundle up everything

green oriole Dec 5, 2019, 6:15 AM

#

Why he is doing this? https://github.com/python-discord/site/pull/315

GitHub

Bump django from 2.2.6 to 2.2.8 by dependabot · Pull Request #315...

Bumps django from 2.2.6 to 2.2.8.

Commits

b8782c5 [2.2.x] Bumped version for 2.2.8 release.
d6fa509 [2.2.x] Added release dates for 2.1.15, 2.2.8 and 3.0.
36f580a Fixed CVE-2019-19118 -- Required...

hardy gorge Dec 5, 2019, 6:23 AM

#

This is a bot that we're using; it notifies us of updates in dependencies that fix security vulnerabilities and creates an automated PR for that

green oriole Dec 5, 2019, 7:38 AM

#

I know, but there isn't a security report or something linked everytime?

hardy gorge Dec 5, 2019, 7:40 AM

#

Click on "commits"

#

📎 2019-12-05_08-40.png

green oriole Dec 5, 2019, 7:41 AM

#

Oh yeah thanks

#

Hmm seems like a pretty severe breach

hardy gorge Dec 5, 2019, 7:53 AM

#

Yeah, but I don't think we're severly affected. Still, there's not reason for us not to update soon, but we'll need to test it. The reason we're not that affected is that the privilege escalation is restricted to users who are already logged into the admin interface, meaning that the user should already have admin access. I'm also don't think we're affected, as I don't think we implement the functionality that triggers this specific thing. Still, better safe than sorry, so obviously we're going update.

clever wraith Dec 5, 2019, 9:22 AM

#

@crude gyro just to be clear all you wanted me to change

from
embed.set_thumbnail(url="https://emojipedia-us.s3."
"dualstack.us-west-1.amazonaws.com"
"/thumbs/240/twitter/"
"233/incoming-envelope_1f4e8.png")

to

    embed.set_thumbnail(url="https://emojipedia-us.s3."
                            "dualstack.us-west-1.amazonaws.com"
                            "/thumbs/240/twitter/"
                            "233/incoming-envelope_1f4e8.png"
                        )

#

thats it ?

#

this comment

green oriole Dec 5, 2019, 9:23 AM

#

No you need to a line break after the first parenthesis

clever wraith Dec 5, 2019, 9:23 AM

#

📎 unknown.png

green oriole Dec 5, 2019, 9:23 AM

#

I mean, look at my message

#

Should be pretty clear

clever wraith Dec 5, 2019, 9:23 AM

#

its same

#

as yours

green oriole Dec 5, 2019, 9:23 AM

#

Not is is not

#

look at the first line

#

and the indent

clever wraith Dec 5, 2019, 9:24 AM

#

📎 unknown.png

#

fine now ?

green oriole Dec 5, 2019, 9:25 AM

#

Wait

#

It doesn’t work at all, does it?

#

Hmm nah should be fine

clever wraith Dec 5, 2019, 9:26 AM

#

pycharm not giving any errors , should be fine

green oriole Dec 5, 2019, 9:26 AM

#

Anyway, why PyCharm is coloring the text in gray?

clever wraith Dec 5, 2019, 9:27 AM

#

cuz thats a hyperlink

#

📎 unknown.png

#

there is also a underline there

#

I am resolving this comment

green oriole Dec 5, 2019, 9:29 AM

#

whatever

clever wraith Dec 5, 2019, 9:40 AM

#

wdym

#

📎 unknown.png

green oriole Dec 5, 2019, 9:42 AM

#

Refresh the page, I thought it will leave a comment of the review

molten bough Dec 5, 2019, 9:42 AM

#

I see you two are having fun again

green oriole Dec 5, 2019, 9:42 AM

#

Yep.

molten bough Dec 5, 2019, 9:42 AM

#

Anything I can help with?

green oriole Dec 5, 2019, 9:42 AM

#

I think we can redo the 100 comment PR haha

molten bough Dec 5, 2019, 9:43 AM

#

Could just squash it

green oriole Dec 5, 2019, 9:43 AM

#

Not sure, maybe you just can review it?

clever wraith Dec 5, 2019, 9:43 AM

#

📎 unknown.png

#

i don't really understand that

molten bough Dec 5, 2019, 9:43 AM

#

Solid advice, that

#

If you use parens you don't need to escape the newline with a backslash

clever wraith Dec 5, 2019, 9:44 AM

#

what is parenthesis . ;-;

molten bough Dec 5, 2019, 9:44 AM

#

(
    "text"
    "more text"
)

clever wraith Dec 5, 2019, 9:44 AM

#

never face that thing

#

that thing was done by pycharm itself

molten bough Dec 5, 2019, 9:44 AM

#

You probably called it a bracket

#

Anyway, doesn't matter, you still gotta address the review

clever wraith Dec 5, 2019, 9:45 AM

#

📎 unknown.png

#

that gives a issue

#

without \

molten bough Dec 5, 2019, 9:45 AM

#

Yes, and add parens

green oriole Dec 5, 2019, 9:45 AM

#

Put parenthesis around it

molten bough Dec 5, 2019, 9:45 AM

#

Are you reading what we type?

green oriole Dec 5, 2019, 9:45 AM

#

Like, I left three example about it in the review

molten bough Dec 5, 2019, 9:45 AM

#

And I left an example above

#

Haha

green oriole Dec 5, 2019, 9:45 AM

#

Should be pretty self explanatory

clever wraith Dec 5, 2019, 9:46 AM

#

📎 unknown.png

molten bough Dec 5, 2019, 9:46 AM

#

Yeah, you'll need to line up that second line

clever wraith Dec 5, 2019, 9:46 AM

#

📎 unknown.png

#

DONE

green oriole Dec 5, 2019, 9:46 AM

#

K&R lemon said :)

clever wraith Dec 5, 2019, 9:46 AM

#

isn't that K&R

molten bough Dec 5, 2019, 9:46 AM

#

It is

clever wraith Dec 5, 2019, 9:46 AM

#

Nice

#

📎 unknown.png

#

this look fine ?

molten bough Dec 5, 2019, 9:47 AM

#

I'm not sure it needs the newlines in the actual message text, but sure

green oriole Dec 5, 2019, 9:47 AM

#

See my latest comment, use an embed instead

molten bough Dec 5, 2019, 9:47 AM

#

I'd probably indent the strings too

hardy gorge Dec 5, 2019, 9:47 AM

#

The closing parenthesis needs to be at the same level of await

molten bough Dec 5, 2019, 9:47 AM

#

Or, yeah

clever wraith Dec 5, 2019, 9:47 AM

#

not gonna make a embed for this little thing

molten bough Dec 5, 2019, 9:47 AM

#

What Ves said

#

Alright, AG

clever wraith Dec 5, 2019, 9:47 AM

#

📎 unknown.png

green oriole Dec 5, 2019, 9:48 AM

#

Error messages are all embeds, you should use one

molten bough Dec 5, 2019, 9:48 AM

#

I should say, you seem to be responding that way to a lot of reviews

#

Don't forget to put your rationale in the comments

clever wraith Dec 5, 2019, 9:50 AM

#

removing that actually

#

as @green oriole suggested

#

it never get triggered anyways

#

lemon also said that

molten bough Dec 5, 2019, 10:00 AM

#

And it also doesn't make sense based on the command only working in a commands channel

clever wraith Dec 5, 2019, 10:01 AM

#

yeah

#

sadly

#

maybe in future if we get something , we can use that

green oriole Dec 5, 2019, 10:02 AM

#

Well, if you can provide a message ID, that's not a problem

clever wraith Dec 5, 2019, 10:03 AM

#

message_link

#

trivia quiz throwning errors

#

?

green oriole Dec 5, 2019, 10:05 AM

#

I mean, just use the d.py message converter and you can use the command in a different channel from where I was sent plus you can use a message ID

#

Yeah that's a windows problem

clever wraith Dec 5, 2019, 10:05 AM

#

the command in a different channel

#

NO

#

they mentioned it can't be done

green oriole Dec 5, 2019, 10:06 AM

#

If you use the converter you can

clever wraith Dec 5, 2019, 10:06 AM

#

no

#

give me that link

#

i will point it out

green oriole Dec 5, 2019, 10:09 AM

#

https://discordpy.readthedocs.io/en/latest/ext/commands/api.html#discord.ext.commands.MessageConverter

clever wraith Dec 5, 2019, 10:10 AM

#

📎 unknown.png

green oriole Dec 5, 2019, 10:10 AM

#

You can provide the channelid

clever wraith Dec 5, 2019, 10:11 AM

#

so you mean doing .bm message_id channel_id *hints

green oriole Dec 5, 2019, 10:11 AM

#

{channel ID}-{message ID}

#

Look at the first lookup of the converter

clever wraith Dec 5, 2019, 10:11 AM

#

it just create a messy command , breaking the simplicty

green oriole Dec 5, 2019, 10:11 AM

#

Yes, but it makes it useful

clever wraith Dec 5, 2019, 10:11 AM

#

.bm link *hints does all that

green oriole Dec 5, 2019, 10:11 AM

#

Or allow the user to pass the channel then

clever wraith Dec 5, 2019, 10:12 AM

#

link contain 3 things , server id, channel id , message id respectively

#

https://discordapp.com/channels/267624335836053506/291284109232308226/631953598091100200

#

see

green oriole Dec 5, 2019, 10:14 AM

#

Anyway, using the converter is better, it avoid to repeat the code of the library, plus if the API changes, we don't need to make the changes ourselves and let d.py handle it

clever wraith Dec 5, 2019, 10:14 AM

#

as far i know people uses copy id . they can do copy link and everything will be fine

📎 unknown.png

#

also if people self host the bot it will make issues , cuz we are not defining server.id anywhere in .bm message_id channel_id *hints

green oriole Dec 5, 2019, 10:15 AM

#

You can get it from the config

clever wraith Dec 5, 2019, 10:16 AM

#

you mean those environmental variables ?

#

why is this making a issue ?

📎 unknown.png

#

it work regardless

#

of the error

green oriole Dec 5, 2019, 10:18 AM

#

It is a warning not an error

#

Imagine that it doesn't find the message, what is going to happen?

clever wraith Dec 5, 2019, 10:19 AM

#

yeah thats why there was that

#

but thats not happening

#

right ?

#

you said that in the comment

green oriole Dec 5, 2019, 10:20 AM

#

That could happen if you provide a fake link

clever wraith Dec 5, 2019, 10:20 AM

#

u sure link

green oriole Dec 5, 2019, 10:21 AM

#

But anyway, let the converter search for the message

clever wraith Dec 5, 2019, 10:21 AM

#

but that if only triggers if the jump_url is none or *

#

so its not getting any kind of link anyways

green oriole Dec 5, 2019, 10:22 AM

#

So why are you looping over it?

clever wraith Dec 5, 2019, 10:22 AM

#

it skips the .bm message , and take one over it

green oriole Dec 5, 2019, 10:22 AM

#

Pretty sure there is a better way to do it

clever wraith Dec 5, 2019, 10:23 AM

#

as history also consist that .bm message

#

there is always a better way

green oriole Dec 5, 2019, 10:25 AM

#

Plus, ~~what~~ why do you take only the id to re-fetch the message later?

clever wraith Dec 5, 2019, 10:25 AM

#

yeah

#

only the message id , cuz ofcourse channel id will be same as ctx.channel.id

#

same with guild.id

green oriole Dec 5, 2019, 10:26 AM

#

You can just do message = x inside your loop

clever wraith Dec 5, 2019, 10:27 AM

#

i only need id , i never needed the message itself

brazen charm Dec 5, 2019, 10:27 AM

#

Or use the message directly with the loop doing nothing else if you're just assigning directly

green oriole Dec 5, 2019, 10:27 AM

#

So just directly use the jump_url of the message inside the loop

clever wraith Dec 5, 2019, 10:28 AM

#

its used when jump_url is None or *

#

we are just looping around the same topic

green oriole Dec 5, 2019, 10:29 AM

#

Change it to

async for message in channel.history(limit=2):
  jump_url = message.jump_url```

clever wraith Dec 5, 2019, 10:30 AM

#

no

green oriole Dec 5, 2019, 10:30 AM

#

Yes?

#

Why?

clever wraith Dec 5, 2019, 10:31 AM

#

whats message.jump_url

crude gyro Dec 5, 2019, 10:31 AM

#

what the fuck no. if you're not gonna listen to the reviewers when they make suggestions, just save yourself the trouble and close the PR right away.

#

it's never gonna get merged if you're not willing to work with us.

clever wraith Dec 5, 2019, 10:32 AM

#

his saying not work with my code , like he thinks

#

we are just looping around.

#

for 30 mins straight

green oriole Dec 5, 2019, 10:38 AM

#

message.jump_url is the d.py generated jump url

#

Instead of building it yourself

clever wraith Dec 5, 2019, 10:38 AM

#

isn't that convert something

#

done a fix

green oriole Dec 5, 2019, 10:41 AM

#

No, the converter is handled by the typehint https://github.com/python-discord/seasonalbot/pull/327#discussion_r353792944

hardy gorge Dec 5, 2019, 10:41 AM

#

The converter will work on messages in other channels as long as it is in the bot's cache

#

The raw command words like that

clever wraith Dec 5, 2019, 10:42 AM

#

F i forgot to change color of embed

green oriole Dec 5, 2019, 10:42 AM

#

It says to d.py to convert the url, or id to an actual Message object

hardy gorge Dec 5, 2019, 10:42 AM

#

(The converter first tries to get the message out of the cache based on the message ID, regardless of channel)

green oriole Dec 5, 2019, 10:42 AM

#

^ see why we should use it

#

Plus among a lot of other things

hardy gorge Dec 5, 2019, 10:43 AM

#

It won't work if the message is not longer in the cache, which is pretty soon, since we have a large message volume

green oriole Dec 5, 2019, 10:43 AM

#

It calls the api if it is not in the cache right?

hardy gorge Dec 5, 2019, 10:44 AM

#

Yes, but that needs the correct channel id

clever wraith Dec 5, 2019, 10:45 AM

#

will add that next commit

hardy gorge Dec 5, 2019, 10:45 AM

#

Now, I'm not up to date on the review comments, so that's what you should go by for the feature

#

Just clarifying a few things said above

green oriole Dec 5, 2019, 10:45 AM

#

Your cog docstring is still not very descriptive

clever wraith Dec 5, 2019, 10:45 AM

#

lint force me to not go any further

hardy gorge Dec 5, 2019, 10:47 AM

#

You can make longer docstrings for something if it needs clarification (I haven't seen the docstring in question); it's just that the first line needs to be a summary line.

green oriole Dec 5, 2019, 10:47 AM

#

It is the docstring of the cogs

clever wraith Dec 5, 2019, 10:48 AM

#

📎 unknown.png

hardy gorge Dec 5, 2019, 10:48 AM

#

def something():
    """
    Do something and return nothing.

    This function is absolutely useless. It does something, I don't know what and
    returns nothing, that is, `None`. However, I'm just faking a longer, multi-line
    docstring as an example, so it's still useful in its own way.
    """
    do_something()

clever wraith Dec 5, 2019, 10:48 AM

#

if you want i can write a 2 paragraph on this

green oriole Dec 5, 2019, 10:49 AM

#

It doesn't describe how the cog works at all

hardy gorge Dec 5, 2019, 10:50 AM

#

Okay, so, what's important for our docstrings is that it's going to be used for two things:

Developers trying to read the code
The help menu (I'm not entirely sure about Seasonalbot's help)

green oriole Dec 5, 2019, 10:50 AM

#

Plus A cog for bookmarking message doesn't seems to help a lot

clever wraith Dec 5, 2019, 10:50 AM

#

📎 unknown.png

hardy gorge Dec 5, 2019, 10:50 AM

#

Now, you don't have to put a description of the entire API in the class docstring, since you have individual methods with docstrings for that.

clever wraith Dec 5, 2019, 10:50 AM

#

that doesn't do that also

green oriole Dec 5, 2019, 10:51 AM

#

I mean, this cog isn't used by the average user

hardy gorge Dec 5, 2019, 10:51 AM

#

A summary line and a quick description of what it does and why is still a good thing

#

I think that Uptime docstring is pretty clear, it summarizes exactly what the cog is for

green oriole Dec 5, 2019, 10:51 AM

#

Just checked, it doesn't affect the help page

hardy gorge Dec 5, 2019, 10:51 AM

#

For further information on the exact API of the cog, you can read the docstrings of the individual commands

green oriole Dec 5, 2019, 10:51 AM

#

But the docstring of the command does

clever wraith Dec 5, 2019, 10:52 AM

#

can you suggest me some cog description

green oriole Dec 5, 2019, 10:52 AM

#

The docstring of your command is Bookmark a message which isn't very useful too

clever wraith Dec 5, 2019, 10:52 AM

#

m so messed up

#

god i hate english sometime

green oriole Dec 5, 2019, 10:53 AM

#

Don't have time, I'm going to got and look for food haha

#

Not sure mine is better than yours

clever wraith Dec 5, 2019, 10:53 AM

#

CMON

#

just give me a cog string

green oriole Dec 5, 2019, 10:55 AM

#

I don't know, Use this cog to bookmark the message to get a link to that message in dm

#

I don't have the other docstring I don't know how to write it exactly

#

And do not use this docstring, that's just an example, it is pretty poorly written

clever wraith Dec 5, 2019, 10:57 AM

#

let me try the one ```py
async for message in channel.history(limit=2):
jump_url = message.jump_url

#

it surprisingly worked

green oriole Dec 5, 2019, 11:02 AM

#

I wouldn't have gave you if it didn't worked :p

#

Also Fixed some things isn't a good commit message

#

You should do one commit per fix, and write comprehensive commits

clever wraith Dec 5, 2019, 11:04 AM

#

last commit , its done then
fixed no . after No hint provided
used that way of yours
fixed color scheming of embed

green oriole Dec 5, 2019, 11:05 AM

#

Have you used the converter and used embeds for error messages?

clever wraith Dec 5, 2019, 11:06 AM

#

using Colours.soft_green

#

there is no error message except the usage one

#

that doesn't require a embed

#

from bot.constants import Colours right

#

why its not Colors ?

green oriole Dec 5, 2019, 11:07 AM

#

Because it has been written by someone from the UK

clever wraith Dec 5, 2019, 11:08 AM

#

📎 unknown.png

green oriole Dec 5, 2019, 11:08 AM

#

?

clever wraith Dec 5, 2019, 11:09 AM

#

colour change

#

either i am now f uped cuz @hardy gorge is writing for so long , its freaking me out sweatcat

#

can someone give me perfect cog string pleaseeeee

green oriole Dec 5, 2019, 11:11 AM

#

You need to do things by yourself

#

You'll never learn otherwise

clever wraith Dec 5, 2019, 11:11 AM

#

i changed it , no one liked it

hardy gorge Dec 5, 2019, 11:11 AM

#

@clever wraith

[11:53 AM] AG: CMON
[11:54 AM] AG: just give me a cog string

These things are important to us. It may feel like overly bureaucratic to you as, in your mind, it's just quickly hacking a feature together, but we have other concerns. The features we have need to be maintained and the code needs to be reliable. Our bots are important tools in our community and we rely heavily on them; we simply can't have them break on us. (When they do, it's always a major crisis and people literally drop their regular work to fix it.)

That means that we set fairly high standards that help us make sure that maintaining features doesn't become a pain (because of bad readability) and features don't break the bot (because of badly tested code). That's why we have such a strict review process. In addition, each feature we add to the bot increases the amount of effort needed to maintain the bot. That's why we feel it's important to seriously consider features in conversations in Issues even if the change seems small and especially if the change comes from a non-core developer. In addition, each feature the bot has, has an effect of the community: More bot commands in channels, even if they're deleted, means more (temporary) bot responses, more noise, and more disruption. That's why we keep it to the essentials and that's why we discuss everything, either in the issue or internally in the core developer group.

clever wraith Dec 5, 2019, 11:12 AM

#

sweatcat

green oriole Dec 5, 2019, 11:12 AM

#

Oh wow

#

Well

clever wraith Dec 5, 2019, 11:14 AM

#

Just wanna say, nice punctuations skills.

green oriole Dec 5, 2019, 11:14 AM

#

I want to bookmark this

clever wraith Dec 5, 2019, 11:15 AM

#

📎 unknown.png

#

how that make any sense

#

;-;

green oriole Dec 5, 2019, 11:15 AM

#

Well, that's a season specific cog

#

But it shouldn't be that way

#

Are you going to change it, yes or no?

clever wraith Dec 5, 2019, 11:17 AM

#

i am

#

trying

#

my best

green oriole Dec 5, 2019, 11:17 AM

#

I mean, if you doesn't change it, you'll never get your PR merged

#

Nice

clever wraith Dec 5, 2019, 11:17 AM

#

📎 unknown.png

#

is this fine

#

NOW

#

or more ?

#

i think that's it

green oriole Dec 5, 2019, 11:19 AM

#

No

#

Did you listened what gdude and ves said?

#

First line is a short description, then a blank line, then the extended description

clever wraith Dec 5, 2019, 11:19 AM

#

oh

#

yeah

#

📎 unknown.png

hardy gorge Dec 5, 2019, 11:21 AM

#

If we ignore the docstring itself for a minute, what would you like to include in it?

clever wraith Dec 5, 2019, 11:21 AM

#

include in the class

#

?

hardy gorge Dec 5, 2019, 11:21 AM

#

Actually writing down a docstring can be quite difficult; it needs to be short and readable, but at the same time still capture the essence of the cog.

#

What do you think should be in it so someone unfamiliar with your function knows what this class is about when reading the code?

#

Remember: very specific details of individual commands are already captured by the docstrings of those methods, so you don't have to include those in the class docstring

clever wraith Dec 5, 2019, 11:23 AM

#

A cog for the ultimate bookmark command

#

my mind not working anymore

hardy gorge Dec 5, 2019, 11:23 AM

#

Okay, so, it's a cog that creates personal bookmarks. How does it do that?

clever wraith Dec 5, 2019, 11:24 AM

#

looks fine

#

you said you wanted it to include how it works
so i did that

    if no jump_url is given it fetch the id of
    last message in ctx channel and sending it to user's DM . ```

#

how you would like to see it ?

hardy gorge Dec 5, 2019, 11:26 AM

#

Okay, the first two things are more or less details, but the very last part seems important: A "bookmark" is a bit of a vague term as it can mean anything. It's also important to note that these are personal bookmarks, not public bookmarks for everyone

clever wraith Dec 5, 2019, 11:27 AM

#

yeah

hardy gorge Dec 5, 2019, 11:27 AM

#

So, what I'd do (although I usually think a bit longer about the exact wording) is write a docstring that captures that essence. Something like this:

#

class Name:
    """A cog that creates personal bookmarks by relaying a message to the user's DMs."""

Now, this is not yet perfect, normally I think this over for quite some time if it's a difficult case, but it captures the essentials: We want to establish the term bookmarks, we want to convey that they're personal, and we highlight that it works by relaying messages to DMs.

clever wraith Dec 5, 2019, 11:29 AM

#

I think that is fine

hardy gorge Dec 5, 2019, 11:29 AM

#

The details of how the interface works (jump links, message id) can be described in the actual bookmark command method

clever wraith Dec 5, 2019, 11:30 AM

#

TBH the command itself is a very basic, it don't need any sort of explaination

#

I am pushing it

#

that's it

green oriole Dec 5, 2019, 11:34 AM

#

You.. Need a docstring for the cog

clever wraith Dec 5, 2019, 11:36 AM

#

I know

#

finally done

#

added all the changes requested by @crude gyro and @green oriole i can now go and take some rest i think

green oriole Dec 5, 2019, 11:39 AM

#

You still don't use the converter, I suggested two changes and lemon asked you to delete the embed footer

clever wraith Dec 5, 2019, 11:40 AM

#

he never asked to delete the footer

#

its cool

#

i used the convertor

#

that you gave

#

applied suggestion of that description ^^

green oriole Dec 5, 2019, 11:42 AM

#

He did asked to remove it (https://github.com/python-discord/seasonalbot/pull/327/files#r353825376)

#

I left other comments

clever wraith Dec 5, 2019, 11:42 AM

#

embeds

#

ok

green oriole Dec 5, 2019, 11:42 AM

#

But of course you can take a break if you want

clever wraith Dec 5, 2019, 11:43 AM

#

i wanna complete it

green oriole Dec 5, 2019, 11:44 AM

#

Taking a break is also important to still be productive

clever wraith Dec 5, 2019, 11:44 AM

#

can i use an NEGATIVE_REPLIES ?

#

Constant

crude gyro Dec 5, 2019, 11:45 AM

#

you can and you should.

#

if you're giving any kind of negatory reply

clever wraith Dec 5, 2019, 11:45 AM

#

error reply

#

ERROR_REPLIES

#

remove footer
"Why everything so heavy?"

#

?

green oriole Dec 5, 2019, 11:52 AM

#

I think it is what he said

#

https://github.com/python-discord/seasonalbot/pull/327#discussion_r353825376

clever wraith Dec 5, 2019, 11:53 AM

#

is this fine

#

📎 unknown.png

green oriole Dec 5, 2019, 11:54 AM

#

What is Error:-?

clever wraith Dec 5, 2019, 11:54 AM

#

no title then

green oriole Dec 5, 2019, 11:55 AM

#

Yep remove it

#

Well, not the random message, the Error:- thing

clever wraith Dec 5, 2019, 11:55 AM

#

📎 unknown.png

green oriole Dec 5, 2019, 11:56 AM

#

How does other cogs implement it?

clever wraith Dec 5, 2019, 11:56 AM

#

making it to ""

#

maybe

#

Nope

#

📎 unknown.png

#

I will just add something like - there

molten bough Dec 5, 2019, 11:58 AM

#

Don't put a field in

#

Just set the description

clever wraith Dec 5, 2019, 11:58 AM

#

doesn't work

molten bough Dec 5, 2019, 11:58 AM

#

Yeah it does

#

Fields are optional, you don't need to add one at all

clever wraith Dec 5, 2019, 11:59 AM

#

https://discordapp.com/channels/267624335836053506/635950537262759947/652115921749409812

molten bough Dec 5, 2019, 11:59 AM

#

You can just set the embed's description.

green oriole Dec 5, 2019, 11:59 AM

#

Just use the random message, and the error message

clever wraith Dec 5, 2019, 12:00 PM

#

yeah

#

got it

molten bough Dec 5, 2019, 12:00 PM

#

Embed title/header, embed description

clever wraith Dec 5, 2019, 12:00 PM

#

📎 unknown.png

#

📎 unknown.png

green oriole Dec 5, 2019, 12:00 PM

#

Perfect

molten bough Dec 5, 2019, 12:01 PM

#

Well, I'd put the spaces at the end of the strings, not the start of the next one

clever wraith Dec 5, 2019, 12:01 PM

#

done both error , embeds on baby

molten bough Dec 5, 2019, 12:01 PM

#

Also, "this" needs a capital T

clever wraith Dec 5, 2019, 12:01 PM

#

📎 unknown.png

molten bough Dec 5, 2019, 12:01 PM

#

Yup

green oriole Dec 5, 2019, 12:02 PM

#

Space before the : ?

molten bough Dec 5, 2019, 12:02 PM

#

I'm not 100% sure about this error personally

#

No, akarys

green oriole Dec 5, 2019, 12:02 PM

#

Oki

#

Why are you not sure about it?

molten bough Dec 5, 2019, 12:03 PM

#

Well, the error is that the message can't be found, right?

green oriole Dec 5, 2019, 12:03 PM

#

Yep

molten bough Dec 5, 2019, 12:03 PM

#

So why do we have command syntax here?

green oriole Dec 5, 2019, 12:04 PM

#

Oh yeah

molten bough Dec 5, 2019, 12:04 PM

#

I'd have thought just a simple That message could not be found, please try another. would suffice

green oriole Dec 5, 2019, 12:04 PM

#

But a syntax error could lead to that error

molten bough Dec 5, 2019, 12:05 PM

#

If we need to display the syntax then perhaps we should show the actual command help

#

But I don't think so

#

You could be more verbose

green oriole Dec 5, 2019, 12:05 PM

#

Yeah not sure that's a good idea

molten bough Dec 5, 2019, 12:05 PM

#

Like, for example, Message URL invalid: Unable to find message

green oriole Dec 5, 2019, 12:05 PM

#

Also @clever wraith, you don't log anything

#

Well, that could be a message ID too

molten bough Dec 5, 2019, 12:06 PM

#

Okay, but there's no reason you couldn't have handling for that too

clever wraith Dec 5, 2019, 12:06 PM

#

📎 unknown.png

#

NICE

#

now what tf is wrong

molten bough Dec 5, 2019, 12:06 PM

#

That one should really just be the actual help message

green oriole Dec 5, 2019, 12:06 PM

#

You have *args at the end of your function arguments?

molten bough Dec 5, 2019, 12:07 PM

#

That's not necessarily the right way to do that

green oriole Dec 5, 2019, 12:07 PM

#

That's a seasonalbot generated message

#

Yeah, but he did it that way

molten bough Dec 5, 2019, 12:07 PM

#

Oh, it is? Okay