#dev-contrib | Python | Page 36

gusty sonnet Nov 15, 2019, 10:07 AM

#

Perhaps you meant py self.queue_consumption_tasks[message.channel.id] = ...?

#

Ah I see now, inside the self._process_deletion_context you are checking the other dictionary, that's why it did not crash

green oriole Nov 15, 2019, 10:09 AM

#

So we can still use the delay, but we need to delete the messages after we upload the context

hardy gorge Nov 15, 2019, 10:51 AM

#

No, I don't think that's right for the antispam filter

#

It should not wait 10 seconds to delete the messages after triggering, but it should take action as soon as possible

#

However, since you are going to relay the attachments (right?), that's something that could happen earlier

#

@gusty sonnet That does look like a mistake, yeah

#

I'm not sure why it's there or what it is doing, I think I wanted to save a reference to the task, but there's no code to remove it once it's processed either

#

The DeletionContext tracks the messages that should be deleted

#

The add method of that class seems like a good place to relay the attachments and save the links to those

#

That happens before the messages are deleted

green oriole Nov 15, 2019, 11:35 AM

#

Okay i’m going to change it as soon as possible

#

Here is the nondocker guide (bot + site) for win 10 home https://gist.github.com/Akarys42/989dcfa41536c9f3b15c844ea4f04d72 !

glass pecan Nov 15, 2019, 11:37 AM

#

thank you

#

it's appreciated

#

will read it through properly when i get the chance

glass pecan Nov 15, 2019, 12:28 PM

#

if someone gets time, please review https://github.com/python-discord/bot/pull/546

GitHub

Docs command improvements by Numerlor · Pull Request #546 · pyth...

Improves the docs command by:

Resolving symbol name conflicts
Auto deleting commands that didn't find anything
Improving output for docs of modules

closes: #538
closes: #210
closes: #381

#

it only requires one more review and it can be merged

brazen charm Nov 15, 2019, 12:31 PM

#

noticed the constants are a bit messy, should I group them in some way or order them?

glass pecan Nov 15, 2019, 12:32 PM

#

up to you

#

if you think it's able to be improved, you're welcome to throw in another commit

#

ping me if you do, as i've now approved a review so the change would be best to be rechecked.

#

looks fine

glass pecan Nov 15, 2019, 1:52 PM

#

30 commits blobsweats

hardy gorge Nov 15, 2019, 1:54 PM

#

right to the top

📎 2019-11-15_14-53.png

glass pecan Nov 15, 2019, 1:54 PM

#

i look so sad down there

green oriole Nov 15, 2019, 1:57 PM

#

~~That only count commits to master?~~ yes it does

#

@hardy gorge would you mind taking a look at my tests please? (if you have time) https://github.com/python-discord/site/pull/300

crude gyro Nov 15, 2019, 2:02 PM

#

wait @hardy gorge what's this now

glass pecan Nov 15, 2019, 2:02 PM

#

commit contributions on bot master

crude gyro Nov 15, 2019, 2:03 PM

#

in what time period?

green oriole Nov 15, 2019, 2:03 PM

#

For the month

crude gyro Nov 15, 2019, 2:03 PM

#

aha

#

I don't remember having committed anything this month

#

I thought I only did duck pond

hardy gorge Nov 15, 2019, 2:03 PM

#

Yeah, not alltime

crude gyro Nov 15, 2019, 2:03 PM

#

but that's not merged

glass pecan Nov 15, 2019, 2:03 PM

#

maybe a suggested edit

crude gyro Nov 15, 2019, 2:03 PM

#

no, not 12 suggested edits

green oriole Nov 15, 2019, 2:04 PM

#

You did a PR https://github.com/python-discord/bot/pull/480 in October

#

But there was only 2 commits in it

glass pecan Nov 15, 2019, 2:05 PM

#

13 commits are hiding somewhere lol

#

branch merges count

crude gyro Nov 15, 2019, 2:16 PM

#

aha

#

that makes sense.

#

that PR is from October, @green oriole

green oriole Nov 15, 2019, 2:17 PM

#

Oh yeah

hardy gorge Nov 15, 2019, 2:18 PM

#

It's not this month, but about a month of time (30-31 days depending on the month and ignoring February, like any programmer should)

#

@green oriole I'm looking at it

brazen charm Nov 15, 2019, 3:32 PM

#

scargly is on fire today

hardy gorge Nov 15, 2019, 3:36 PM

#

@green oriole I think the only thing I'm missing is that you don't test the GET method (or I'm overlooking it)

#

I see tests for creation (including validation), deletion, and not allowing update methods

green oriole Nov 15, 2019, 3:38 PM

#

Hmm yeah I may have missed it

#

It is half tested in the deletion test but doesn't have a proper test

hardy gorge Nov 15, 2019, 3:39 PM

#

It's probably better for that test not to rely on the GET, but rather to check the database directly

green oriole Nov 15, 2019, 3:40 PM

#

Well I copied the test process from another test suite

hardy gorge Nov 15, 2019, 3:40 PM

#

You could do an assertFalse with OffensiveMessage.objects.filter(id=id).exists()

#

Hmm, I'm just thinking about making these tests fully independent

green oriole Nov 15, 2019, 3:41 PM

#

Yeah that's logic

hardy gorge Nov 15, 2019, 3:41 PM

#

In principle, we could go for an API design in which we don't allow someone to get a list using GET, but still allow DELETE (and maybe individual GET lookups based on pk)

#

Not likely here

#

but just for the general pattern

green oriole Nov 15, 2019, 3:43 PM

#

That's crazy the amount of code redundancy we have in the test suites

#

I wonder if there is a way to make reusable tests

#

Anyway I'm going to fix those two things as soon as I'm on my computer

hardy gorge Nov 15, 2019, 3:48 PM

#

Some tests can be shortened, yeah, but it's quite a project

#

Anyway, there's also a value in keeping testing logic simple; the more complex you make it, the easier it is for a test not to actually test what you're trying to test

#

That said, a lot of tests are "this specific payload for this endpoint", execute, "check if I get the specific response for this endpoint"

crude gyro Nov 15, 2019, 4:38 PM

#

+1 for keeping tests simple. they should be readable and intuitively understood, much more abstraction might hurt that.

#

something that isn't always understood is that tests can serve other functions than just preventing breaking changes from being introduced. A good test should serve as a showcase for how to interact with the implementation it is testing, and what the expected response is for each component. If the tests were written by the author of the code, the tests may even serve as a window into the authors intentions.

#

this can be a really powerful way to quickly understand complex moving parts in a system.

#

so it is imperative that we keep the tests readable.

glass pecan Nov 15, 2019, 4:46 PM

#

also because my eyes glaze over if i have to force myself to be acquainted with unreadable code and that's super hard to push through
pls don't do this to me

#

sadkitty4

#

wew, ok i went through all issues

woeful thorn Nov 15, 2019, 4:56 PM

#

only 6 more to go!

#

😄

glass pecan Nov 15, 2019, 4:56 PM

#

repos?

#

lol

#

gotta do PRs first

#

thankfully there's only a bit over a dozen of them

woeful thorn Nov 15, 2019, 4:57 PM

#

📎 Captain-Australia-Combined.png

glass pecan Nov 15, 2019, 4:59 PM

#

that is one very strange picture

#

i'd expect it to be more like a giant man-wombat with the power of sending magpies to swoop people

woeful thorn Nov 15, 2019, 5:02 PM

#

He should at least have a pouch

glass pecan Nov 15, 2019, 5:02 PM

#

or be poisonous and venomous

stable mountainBOT Nov 16, 2019, 12:39 AM

#

@tawdry vapor

It has arrived!

Here's your reminder: 651.
Jump back to when you created the reminder

mellow hare Nov 16, 2019, 12:42 AM

#

That feels cryptic

hardy gorge Nov 16, 2019, 12:46 AM

#

Probably this:

#

https://github.com/python-discord/bot/pull/651

GitHub

Show plain nick, or nothing for proxy objects instead of ID in inf...

closes: #533

mellow hare Nov 16, 2019, 12:49 AM

#

That's less exciting than like

#

A secret code

#

Or number of days to live

tawdry vapor Nov 16, 2019, 5:44 AM

#

my bank pin

green oriole Nov 16, 2019, 10:36 AM

#

So guys have you checked out the nondocker guide i’ve written? There is probably some things that could be improved

#

So we can quickly get in on the site

glass pecan Nov 16, 2019, 10:37 AM

#

not yet, i've been busy actioning the labels task first

#

once it's done i'll turn to it

green oriole Nov 16, 2019, 10:38 AM

#

Okay nice

#

i would also love to hear what non staff people think about it, so if you want to check it, it is in the pins 😄

molten bough Nov 16, 2019, 4:05 PM

#

so it turns out users with numeric usernames make it impossible for me to mention some users by ID in #592000283102674944 when I'm using the actual Discord client

#

If user event stuff is gonna be integrated into the pydis systems, then I think that'd help, but I dunno what else to do really

#

Figured out a stopgap for now anyway

austere veldt Nov 16, 2019, 5:21 PM

#

Hi I am trying to design the UI for the whitelisting task. I am clear about the listing operation. But for the edit operation I have a doubt. Is it possible to make a command like !whitelist edit channels add 1233445? This will add 1233445 to channel whitelist or !whitelist edit channels remove 1233445 will remove 1233445 from channels whitelist

#

I saw the edit operations for !tags command. But In that case we are overriding the list of tags.

hardy gorge Nov 16, 2019, 5:27 PM

#

What you could do is have !whitelist channels list the channels whitelist and have !whitelist channels add and !whitelist channel remove as mutation subcommands

#

or is channels a dynamic name?

austere veldt Nov 16, 2019, 5:27 PM

#

yes

#

it can be roles or something else as well

hardy gorge Nov 16, 2019, 5:28 PM

#

I wouldn't be opposed to !whitelist add <type> <item> and !whitelist remove <type> <item>

#

That will keep the commands shorter

austere veldt Nov 16, 2019, 5:30 PM

#

we can not add a new type with the command. Only the existing types whitelists can be modified. Still, I think this looks good.

hardy gorge Nov 16, 2019, 5:34 PM

#

No, not to add a type, just to be able to specify which type you're adding an item to

austere veldt Nov 16, 2019, 5:34 PM

#

Cool!

#

I also need some direction regarding the model design for the whitelisting table. My plan is to have a model like this

class Whitelist(ModelReprMixin, models.Model):
    """Whitelisted items for a type."""
    GUILD_INVITE = "guild invite"
    FILE_EXTENSION = "file extension"
    CHANNEL = "channel"
    ROLE = "role"
    TYPE_CHOICES = (
        ("guild_invite", GUILD_INVITE),
        ("file_extension", FILE_EXTENSION),
        ("channel", CHANNEL),
        ("role", ROLE)
    )
    type = models.CharField(
        choices=TYPE_CHOICES,
        max_length=100,
        help_text=(
            "Type for which the whitelist is stored."
        ),
        primary_key=True
    )
    whitelisted_items = pgfields.ArrayField(
        models.CharField(max_length=200),
        help_text=(
            "List of items to be whitelisted."
        )
    )

    def __str__(self):
        """Returns the type of this whitelist, for display purposes."""
        return self.type

#

what are your thoughts on this?

hardy gorge Nov 16, 2019, 5:38 PM

#

I like it. It would make it fairly easy to extend it in the future.

austere veldt Nov 16, 2019, 5:38 PM

#

Yup

#

Will this !whitelist add <type> <item> allow to have type with spaces in them?

hardy gorge Nov 16, 2019, 5:42 PM

#

It does, but not easily: It would require quotes around the name

austere veldt Nov 16, 2019, 5:43 PM

#

okay, So think it's better to keep the types snake cased

hardy gorge Nov 16, 2019, 5:43 PM

#

Or single words on the discord.py side

#

I think invites or invite is enough to know what we're talking about when it comes to guild invites for instance

austere veldt Nov 16, 2019, 5:45 PM

#

Yeah! I think we can go with the single words. Thanks!

green oriole Nov 16, 2019, 5:46 PM

#

Hi @hardy gorge, can you recheck my tests please, I've updated them like you asked https://github.com/python-discord/site/pull/300

#

(the new labels colors are way better than the old ones)

green oriole Nov 16, 2019, 6:06 PM

#

@hardy gorge @woeful thorn If you can also please re-review https://github.com/python-discord/bot/pull/617/ so we can get this functionality added

brazen charm Nov 16, 2019, 6:46 PM

#

@tawdry vapor regarding https://github.com/python-discord/bot/pull/651#discussion_r347077635 should the User object be converted to a Member with get_member to get the nick?

tawdry vapor Nov 16, 2019, 7:34 PM

#

No, I don't think it's really worth it. It'd have to be fetch so that means making an API call.

#

The code would get a bit complex too to handle potential exceptions

brazen charm Nov 16, 2019, 7:35 PM

#

I've searched and asked around, is there other way to get it?

tawdry vapor Nov 16, 2019, 7:36 PM

#

Just don't show a nick for the proxy user

brazen charm Nov 16, 2019, 7:36 PM

#

yeah but the normal objects are Users too and you can't get nicks from there neither as far as I can tell

#

there's display_name but that returned the user name too

tawdry vapor Nov 16, 2019, 7:37 PM

#

You can show their username then

#

Without the discrim is probably better

brazen charm Nov 16, 2019, 7:38 PM

#

alright

tawdry vapor Nov 16, 2019, 7:38 PM

#

There was another pr that got closed related to this

#

I suggested using fetch but it got complicated like I said

#

Then realised the api can return user info since we sync that to the db

#

So for the infraction search you could make it always display the nickname by using the api

#

But you don't have to if you don't want to

brazen charm Nov 16, 2019, 7:41 PM

#

I'll look into it

tawdry vapor Nov 16, 2019, 7:41 PM

#

You should read the pr then for more infi

#

I'm on mobile though can't link

brazen charm Nov 16, 2019, 7:41 PM

#

got the issue to get my feet wet around the moderation stuff so won't hurt to look at the other things with it too

brazen charm Nov 16, 2019, 9:35 PM

#

@tawdry vapor actually, it looks like only the scheduler gets User objects and management + superstarify get Members with management fetching them from the guild. Should I be consistent or do usernames in one and nicks in the others?

tawdry vapor Nov 16, 2019, 9:38 PM

#

Get the nickname where available (without using fetch_member). Otherwise, fall back to the username (without discriminator). If neither available, just don't show anything extra.

#

I don't think consistently really matters since their nick/username should not be used to actually refer to the users - that's what the ID is for. It's just there to quickly identify who someone is, particularly in the case of the mention "failing" due to the user not being in the client's cache.

#

That's only my view of it though.

#

Maybe someone else thinks it's worth doing an API call to get user info.

#

But considering we've gotten by fine without that so far, it doesn't seem necessary to me.

brazen charm Nov 16, 2019, 9:42 PM

#

Thanks, if there are different views there are also multiple reviewers so it can be caught there

tawdry vapor Nov 16, 2019, 9:43 PM

#

Yeah but ideally it should be decided before you go and implement something. You can do it now but you may end up changing it, so up to you. In retrospect, I admit the issue I posted wasn't fully fleshed out with details.

brazen charm Nov 16, 2019, 9:44 PM

#

the method in the scheduler have union of Member and User hinted for the user, although I haven't seen a member so far when trying a few command is it worth checking if it's an instance of member and then using nick? (if you know when it gets the member by chance)

tawdry vapor Nov 16, 2019, 9:45 PM

#

Sorry, which method are you referring to?

brazen charm Nov 16, 2019, 9:46 PM

#

apply_infraction in InfractionScheduler for example

tawdry vapor Nov 16, 2019, 9:47 PM

#

Yeah, you should. It's meant to be kind of general purpose and it's not a lot of code to check for that

#

I think you should check for the nick attribute instead of checking the type

#

here's that other issue by the way https://github.com/python-discord/bot/pull/508#pullrequestreview-307675298

GitHub

Add the current nickname of a user in infraction search by kraktus...

If the user has not changed its nickname, display None, otherwise display its current nickname.
closes #337

brazen charm Nov 16, 2019, 9:54 PM

#

oh, I see, sorry for taking up so much time with this but at line 112 in the scheduler the user is redefined for the case where the user is a ProxyUser but that also redefines it when the user is a Member which I don't think make a whole lot of sense and results in the nick being unavailable even though it's passes as an arg to the command. Assume that's not the indented behaviour?

tawdry vapor Nov 16, 2019, 9:57 PM

#

You could say that. More like it wasn't a consideration when it was written so it didn't matter if the object was overwritten for what the code was trying to accomplish at the time.

brazen charm Nov 16, 2019, 9:58 PM

#

should it be rewritten now to get that functionality back?

tawdry vapor Nov 16, 2019, 9:59 PM

#

Sure

#

I think all you need to do is check the current user type instead of always assuming the user needs to be fetched

brazen charm Nov 16, 2019, 10:00 PM

#

yeah, will also take some unecessary load off of the api

brazen charm Nov 17, 2019, 6:45 PM

#

with regard to the comment linked above, does the api keep the nicknames of the users? Haven't found anything apart from the username

molten bough Nov 17, 2019, 6:58 PM

#

Check the User model under the API app

#

That's what it's using

brazen charm Nov 17, 2019, 7:00 PM

#

only the name is there afaik but to make sure I'm not missing anything because the comment suggests it does exist

hollow lichen Nov 17, 2019, 7:05 PM

#

yes, the website does track the nicknames

brazen charm Nov 17, 2019, 7:06 PM

#

Where are they kept? Haven't had much luck finding it

austere veldt Nov 17, 2019, 7:10 PM

#

can anyone help me with the build failing https://dev.azure.com/python-discord/Python Discord/_build/results?buildId=4715

molten bough Nov 17, 2019, 7:11 PM

#

It doesn't seem to track the nick

#

@austere veldt You have a file that isn't fully covered by your unit tests

#

pydis_site/apps/api/models/bot/whitelist.py

#

That file

brazen charm Nov 17, 2019, 7:12 PM

#

the str of the class defined there

molten bough Nov 17, 2019, 7:12 PM

#

I don't see any nickname storage, yeah

#

Just looks like username

austere veldt Nov 17, 2019, 7:15 PM

#

Thanks @brazen charm and @molten bough

molten bough Nov 17, 2019, 7:16 PM

#

If you're working with the login system.. Hm, no, that won't give you the nickname either

austere veldt Nov 17, 2019, 7:17 PM

#

When I am running the tests locally. I don't get that error

molten bough Nov 17, 2019, 7:17 PM

#

Run it with coverage enabled

austere veldt Nov 17, 2019, 7:17 PM

#

@brazen charm You are talking about the __str__ of the Whitelist model?

molten bough Nov 17, 2019, 7:18 PM

#

Some IDEs will also be able to run the tests with coverage for you and show which lines aren't covered

#

PyCharm can do that for example, though it may be a pro feature

brazen charm Nov 17, 2019, 7:19 PM

#

yes the line 35

#

@tawdry vapor Should the member and the nick be fetched from the discord api for the search then when they're not kept in the server's api?

austere veldt Nov 17, 2019, 7:21 PM

#

@molten bough I have the pycharm pro, How do I run the test using that?

molten bough Nov 17, 2019, 7:23 PM

#

It's in the top toolbar (turn it on in the view menu if you haven't), near the run/debug buttons

austere veldt Nov 17, 2019, 7:23 PM

#

@brazen charm How do I add test for that? And I am confused, as I haven't test case for the entire model, then why it just throws error for the str method?

tawdry vapor Nov 17, 2019, 7:23 PM

#

@brazen charm Yes. Alternative would be to change the endpoint to support saving nicknames but that's more work since it would also involve having to use the bot as a one-off to fetch the member for all existing users in the db.

brazen charm Nov 17, 2019, 7:24 PM

#

That's a bit beyond what I can achieve for now 😄

tawdry vapor Nov 17, 2019, 7:25 PM

#

Maybe I'll get around to that eventually

#

There's no reason the syncer can't handle that

brazen charm Nov 17, 2019, 7:29 PM

#

oh, also wanted to ask; what are the # region: name # endregion for?

glass pecan Nov 17, 2019, 7:29 PM

#

they allow collapsing in editors

#

if you define a region, a small - icon shows near the line number

#

it'll auto collapse the entire defined region

brazen charm Nov 17, 2019, 7:30 PM

#

oooh didn't notice that

#

thanks

molten bough Nov 17, 2019, 7:32 PM

#

Yup, super handy

#

They're known as code folding regions

brazen charm Nov 17, 2019, 7:33 PM

#

I hardly collapse for some reason

#

just scrolling around like mad

molten bough Nov 17, 2019, 7:34 PM

#

Folding is reeeeally useful

brazen charm Nov 17, 2019, 7:46 PM

#

how are the infraction searches used? Wondering if it'd be worth to keep some sort of short timed cache around the fetching

glass pecan Nov 17, 2019, 7:47 PM

#

it's not really worth it, no

#

only the bot interacts with it so it's not like we're dealing with lots of traffic, and we want the data to be up to date

tawdry vapor Nov 17, 2019, 7:49 PM

#

By the way you can still use the expanded api to get the username if fetch_member fails

brazen charm Nov 17, 2019, 9:02 PM

#

Looking at the search_user using the UserConverter ([discord.User, ProxyUser]), can that even get to a ProxyUser when the user is fetched from the discord api before it reaches that?

glass pecan Nov 17, 2019, 9:03 PM

#

discord.User doesn't fetch from the api

#

discord.User fetches still from cache but global

#

it's almost useless to our bot though

brazen charm Nov 17, 2019, 9:03 PM

#

it gets passed to InfractionSearchQuery before it reaches that method

#

which does a fetch user

#

~~and has a wrong typehint~~

glass pecan Nov 17, 2019, 9:04 PM

#

i don't follow what you mean

#

can you show the code area you're working on

brazen charm Nov 17, 2019, 9:05 PM

#

when you do an infraction search, it triggers the search command at L163 in management.py

glass pecan Nov 17, 2019, 9:06 PM

#

give me a minute. i'll open github in a second then

#

but it sounds like it's just reusing a generic union converter that's used fine elsewhere

#

okay, so you're talking about the subcommand being invoked via the parent group

brazen charm Nov 17, 2019, 9:10 PM

#

the search triggers search_user if the query got converted to an User, so it shouldn't then need a converter for a ProxyUser typehinted in it

glass pecan Nov 17, 2019, 9:10 PM

#

when the group is invoked instead of the specific child search commands, it will fetch

#

but the InfractionSearchQuery isn't used for the child commands alone

#

search_user when used directly (!infr search user) will use proxy_user still

#

it's rare to occur, but for example if someone is given a note before joining the server

#

tbh i don't even like the usage of fetch_user here in the InfractionSearchQuery either

#

oh well

brazen charm Nov 17, 2019, 9:13 PM

#

oh right, thanks so it's kina a roundabout check through the proxyuser

glass pecan Nov 17, 2019, 9:14 PM

#

it's only for checking if the given string matches a valid discord user id so it knows to search via infr search user

#

since id's don't have information about the type of object they're created for, that's one of the most simple methods to do so

brazen charm Nov 17, 2019, 9:15 PM

#

I was thinking about implementing the nick fetching that was talked above by adding member fetching into the InfractionSearchQuery and then checking instances and creating a passable nick from that in the commands

glass pecan Nov 17, 2019, 9:15 PM

#

i'm not really up to speed on what you're working on atm

brazen charm Nov 17, 2019, 9:15 PM

#

showing the user's nick when you search infractions

glass pecan Nov 17, 2019, 9:15 PM

#

give me 10 minutes

#

i'm half way through writing something

brazen charm Nov 17, 2019, 9:16 PM

#

and trying to find a nicer implementation

#

oh no problem, least I found is that wrong typehint 😄

glass pecan Nov 17, 2019, 9:16 PM

#

it's not really wrong though

#

it's only useless in the case the parent command invokes it

brazen charm Nov 17, 2019, 9:17 PM

#

meant the one in InfractionSearchQuery's convert that fetches Users but has a Member hinted

glass pecan Nov 17, 2019, 9:18 PM

#

yes that would be correct, that it's inaccurate

#

it should be discord.User

brazen charm Nov 17, 2019, 9:18 PM

#

thanks for clearing up the above for me

glass pecan Nov 17, 2019, 9:18 PM

#

no probs. sorry for taking a bit to get up to speed

#

adding member fetching into the InfractionSearchQuery

#

this sounds fine

#

in which case if you add it, the return hint would need to still add discord.User but discord.Member can stay

#

wheres this nickname going to show anyway

brazen charm Nov 17, 2019, 9:21 PM

#

yep, just when the subcommands are executed directly. Not sure if it's the best way to add that to the converter Union or some other way

#

from https://github.com/python-discord/bot/issues/337

glass pecan Nov 17, 2019, 9:22 PM

#

the subcommand doesn't need anything different

#

the InfractionSearchQuery does

#

oh the UserConverter doesn't have the Member type in it

#

right

#

that makes more sense

#

yes, you can just add discord.Member to UserConverter but i think we have a similar typehint elsewhere

#

if that's the case we could probs just reuse what's necessary

#

https://github.com/python-discord/bot/blob/master/bot/cogs/moderation/utils.py#L28-L31

#

https://github.com/python-discord/bot/blob/master/bot/cogs/moderation/infractions.py#L19

#

if you adjust the management.py one, it's best to see if these unions are taken into consideration and ensure we keep things DRY as possible

brazen charm Nov 17, 2019, 9:30 PM

#

the discord converters only .get, and what was proposed is .fetching the Member from the api for the nick so it appears if possible. So I was thinking about doing it in the InfractionSearchQuery by fetching the Member and if that fails doing an User like mentioned above, but when the command is invoked directly, that doesn't happen and it's inconsistend because it only gets the User user instead of trying to .fetch it which also has the disadvantage of nick never being available and a higher chance of failing

glass pecan Nov 17, 2019, 9:32 PM

#

oh you want to fetch the member object

#

not the user

#

yeah

brazen charm Nov 17, 2019, 9:32 PM

#

yeah for the nick if it's possible to get it from the guild

glass pecan Nov 17, 2019, 9:33 PM

#

right.

#

as long as you're checking cache first that sounds good enough

brazen charm Nov 17, 2019, 9:35 PM

#

right now making a superclass of the InfractionSearchQuery is going around my mind that doesn't return a string but fails it as the User not existing in discord will also mean it can't have any infractions

austere veldt Nov 18, 2019, 4:35 PM

#

Hi, I have been using docker to run the bot and site till now. I have added a new API to the site and want to access that in the bot. How can I run them locally and connect without docker?

austere veldt Nov 18, 2019, 5:10 PM

#

I was able to make some progress on this. I am running django server locally and have set the SITE_URL=api.pythondiscord.local:8000 . Still the bot is trying to connect to api.web:8000

green oriole Nov 18, 2019, 5:10 PM

#

have you added the bot to the site compose project?

austere veldt Nov 18, 2019, 5:11 PM

#

you mean docker compose?

molten bough Nov 18, 2019, 5:11 PM

#

They're trying to do it without docker

#

Just update your config for the bot so it has the right domain

green oriole Nov 18, 2019, 5:12 PM

#

https://pythondiscord.com/pages/contributing/bot/#use-a-local-development-site

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

#

right here

#

Have you tried that?

austere veldt Nov 18, 2019, 5:13 PM

#

@molten bough You got it right. I want to run it without docker

#

Which config do I need to change?

green oriole Nov 18, 2019, 5:14 PM

#

Oh you don’t use docker?

molten bough Nov 18, 2019, 5:14 PM

#

See the link above

austere veldt Nov 18, 2019, 5:15 PM

#

@green oriole I do but I am trying to debug something. So I think running locally will be easier to debug

green oriole Nov 18, 2019, 5:15 PM

#

If you want to ditch docker, we have this (temporary) guide right here https://gist.github.com/Akarys42/989dcfa41536c9f3b15c844ea4f04d72

#

@molten bough there is still missing output with docker or it has been resolved?

molten bough Nov 18, 2019, 5:16 PM

#

I have no idea

green oriole Nov 18, 2019, 5:16 PM

#

You still doesn’t use docker?

molten bough Nov 18, 2019, 5:16 PM

#

I haven't bothered with it, no

green oriole Nov 18, 2019, 5:17 PM

#

Oki

austere veldt Nov 18, 2019, 5:18 PM

#

I think I got it. I need to change site url in default-config. Thanks!

#

No luck yet! Even after doing the changes I am getting this on running pipenv run start

   raise ClientConnectorError(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host api.web:8000 ssl:None [Name or service not known]

green oriole Nov 18, 2019, 5:29 PM

#

Oh yeah try to change in the config site to pythondiscord.local:8000

austere veldt Nov 18, 2019, 5:30 PM

#

my bad! I did changes in the config-defualt.yml instead of config.yml

green oriole Nov 18, 2019, 5:32 PM

#

git checkout -- config-default.yml to revert changes

mellow hare Nov 18, 2019, 5:34 PM

#

I've done that so many times....

green oriole Nov 18, 2019, 5:35 PM

#

Surprisingly enough, it haven't done it yet..

austere veldt Nov 18, 2019, 5:38 PM

#

And finally! it worked.

mellow hare Nov 18, 2019, 5:39 PM

#

Nice

hollow lichen Nov 18, 2019, 5:40 PM

#

congrats

mellow hare Nov 18, 2019, 5:44 PM

#

https://tenor.com/EThU.gif

Tenor

tough imp Nov 19, 2019, 10:29 PM

#

I wonder, is it safe to rename my fork on github while I have a PR open?

molten bough Nov 19, 2019, 10:31 PM

#

I think so

green oriole Nov 20, 2019, 6:16 AM

#

Yep it is

#

So guys, what about the nondocker guide? You're still stuck with the labels?

glass pecan Nov 20, 2019, 8:45 AM

#

https://github.com/python-discord/site/pull/313

GitHub

Correct the Discord TOS link in rules API endpoint. by scragly · ...

In the rules bot command, the link to the Discord TOS for rule 1 was directing to the guidelines page instead. This corrects that.

#

if i could get two reviews on this please, it would be appreciated

molten bough Nov 20, 2019, 8:48 AM

#

There's one for you anyway

glass pecan Nov 20, 2019, 8:48 AM

#

thank

glass pecan Nov 21, 2019, 1:10 PM

#

ah yes

#

wonder how he went

#

@snow zealot did you happen to poke around our repos a bit?

snow zealot Nov 21, 2019, 1:39 PM

#

@glass pecan yes, yeah
I'm finding it moderately difficult since I've actually never done anything opensource before so it takes me a while to understand other people's codes..
I'm learning albeit slowly.. and yeah, I had an idea which umm I dunno if people think is cool, but nevertheless I opened my first issue on there :D

I honestly think there's a loooot more python I need to know before I can be of value.. atleast that's what week 1 of trying-to-git-gud-at-bot-dev tells me

#

Also, I think I'm going to be away for the next 2 weeks owing to my semester exams, so I think I'll try to grind again after that

Mm but yeah this thing y'all do is hard xd, you guys are crazy smart, and have perhaps put in a lot of time and effort to get there

glass pecan Nov 21, 2019, 1:39 PM

#

hahaha, sounds like you've at least dipped your toes though

snow zealot Nov 21, 2019, 1:40 PM

#

yeah well I read every message posted on this channel this week, tried to see how much of it made sense

glass pecan Nov 21, 2019, 1:40 PM

#

make sure to ask questions to clarify things that seem confusing though, that's absolutely fine to do

snow zealot Nov 21, 2019, 1:40 PM

#

like when Shirayuki pointed that dictionary thing ves zappa's code, that was like big brain

glass pecan Nov 21, 2019, 1:40 PM

#

i probs missed that

snow zealot Nov 21, 2019, 1:41 PM

#

yeah, definitely will.. Infact I love asking questions here for I always get more than what I expect 😄

glass pecan Nov 21, 2019, 1:41 PM

#

noice

#

well keep it up

#

hope the enthusiam is maintained and if there's ever anything you need just ask

snow zealot Nov 21, 2019, 1:43 PM

#

yeah, absolutely.. I'll hang in around here more often and try to pick up something from y'all.. mm brb in a couple of weeks

#

also I think

#

I should probably educate myself a little more in making basic bots themselves before trying to do fancy things with python so that's that

#

So I thought I should probably create a dummy server and make a real simple bot and get it in there, and start playin around to get a feel for it

#

but yeah, I do feel good gettin into this so thanks for that

glass pecan Nov 21, 2019, 1:48 PM

#

go for it

#

making a basic botto is a great way to get familiar with working with them

snow zealot Nov 21, 2019, 2:00 PM

#

yup, thanks. 👍

tough imp Nov 23, 2019, 11:45 AM

#

im trying to set up pycharm to help me write better code for seasonalbot, but there must me something im doing incorrectly as it keeps telling me the discord package isn't installed

#

📎 img0.png

#

📎 img1.png

#

[kwzrd@kwzrd-thinkpad pydis-seasonalbot]$ pipenv shell
Loading .env environment variables…
Launching subshell in virtual environment…
 . /home/kwzrd/.local/share/virtualenvs/pydis-seasonalbot-yCADgX3-/bin/activate
[kwzrd@kwzrd-thinkpad pydis-seasonalbot]$  . /home/kwzrd/.local/share/virtualenvs/pydis-seasonalbot-yCADgX3-/bin/activate
(pydis-seasonalbot) [kwzrd@kwzrd-thinkpad pydis-seasonalbot]$ pip list
Package              Version
-------------------- -------
...
...
discord.py           1.2.3  
...

#

i added the interpreter via pycharm's settings, pointing it to a 3.7.5 pyenv install and checked install packages from pipfile

#

anyone know what could be causing pycharm to not see the package?

#

i havent used pycharm nor pipenv much

molten bough Nov 23, 2019, 11:48 AM

#

You clicked the install link in the banner, I take it?

tough imp Nov 23, 2019, 11:49 AM

#

yeah, it runs some process installing packages for a few secs, then the banner comes back same as before

#

i can run the project just fine via pipenv run start

molten bough Nov 23, 2019, 11:55 AM

#

I'm not sure, honestly

#

I don't have that problem though

tough imp Nov 23, 2019, 11:56 AM

#

mm ok, thanks for checking anyway

tough imp Nov 23, 2019, 12:31 PM

#

works fine when i install via pipenv sync --dev and then add the interpreter as a virtual envrionement, but just wont work when added as a pipenv environment, weird

green oriole Nov 23, 2019, 12:52 PM

#

~~I have a similar problem everytime I checkout a new branch, if that can help~~

#

Oh wait only with discord.py? That's because the package name is discord but it is noted discord.py in the pip list

molten bough Nov 23, 2019, 12:57 PM

#

that isn't the problem here

#

It'd be saying discord isn't installed

green oriole Nov 23, 2019, 1:00 PM

#

Hmm weird on my computer it is saying discord not discord.py

tawdry vapor Nov 24, 2019, 4:04 AM

#

Was confused why a branch wasn't checking out

#

took me too long to realise that it's cause the branch's name starts with a # so the shell thought it's a comment

#

I'm not sure what's wrong but I cannot trigger the mentions filter when testing. I can trigger other ones though

exotic ember Nov 24, 2019, 4:24 AM

#

is your role getting whitelisted?

tawdry vapor Nov 24, 2019, 4:32 AM

#

I removed my roles

#

So no, that couldn't be it

hardy gorge Nov 24, 2019, 10:06 AM

#

That is odd. We do still get the occasion mention spam alert, but they are fairly rare. Now I'm hoping that we're not missing half of the events or something.

#

Did you spam with repeated identical mentions or different mentions in a message?

#

It only counts unique mentions in a message

tawdry vapor Nov 24, 2019, 10:23 AM

#

Oh they weren't unique

long garnet Nov 24, 2019, 9:51 PM

#

I spent some time today exploring discord.py and reading parts of the source code for @stable mountain and learning a bit from it too

#

discord.py looks huge but not hard

#

is there something like a documentation for @stable mountain, or relevant tags?

hardy gorge Nov 24, 2019, 9:56 PM

#

No, we have no special documentation, other than the docstrings, but you can always ask questions.

long garnet Nov 24, 2019, 9:57 PM

#

I see

#

thanks

#

well I'd need someone really patient honestly, maybe I should poke Scragly after all

#

since he volunteered for the pain

hardy gorge Nov 24, 2019, 9:58 PM

#

There are probably more people that can help you, but he did volunteer.

tough imp Nov 24, 2019, 9:59 PM

#

i recently started looking into python's code myself and its very well written and easy to understand

hardy gorge Nov 24, 2019, 9:59 PM

#

Anyway, it's bed time for me. Only 7 hours of sleep left.

tough imp Nov 24, 2019, 9:59 PM

#

had no issues

long garnet Nov 24, 2019, 9:59 PM

#

good night @hardy gorge

tough imp Nov 24, 2019, 9:59 PM

#

sleep tight Ves

green oriole Nov 25, 2019, 3:18 PM

#

Guys, it is still okay for contributors to leave reviews?

glass pecan Nov 25, 2019, 3:21 PM

#

yes

brazen charm Nov 25, 2019, 3:22 PM

#

Yours count towards the required too I think

mellow hare Nov 25, 2019, 3:22 PM

#

Correct

glass pecan Nov 25, 2019, 3:22 PM

#

it does, but we require at least 1 core dev still

mellow hare Nov 25, 2019, 3:22 PM

#

^

#

But there's no such thing as too many reviews

glass pecan Nov 25, 2019, 3:22 PM

#

so 1 core, 1 non-core is fine

#

and having more reviews means sharing the load

mellow hare Nov 25, 2019, 3:23 PM

#

https://tenor.com/usrF.gif

Tenor

glass pecan Nov 25, 2019, 3:23 PM

#

you know it

mellow hare Nov 25, 2019, 3:23 PM

#

You knew I was going to use that gif

#

I saw you typing as I was searching

glass pecan Nov 25, 2019, 3:23 PM

#

i was thinking of it before i even hit enter

mellow hare Nov 25, 2019, 3:23 PM

#

HA

green oriole Nov 25, 2019, 3:24 PM

#

Well, let’s share the load then 😄

crude gyro Nov 25, 2019, 3:31 PM

#

we definitely want you to leave reviews, if you can.

#

and reviewing is a skill

#

you'll need practice to get good at it

#

this is a good place to find that practice.

molten bough Nov 25, 2019, 3:32 PM

#

100 comments on gitlab and rising!

#

That was really something, that MR

green oriole Nov 25, 2019, 3:34 PM

#

Sadly we can’t find it anymore 😦 😄

ornate moat Nov 25, 2019, 7:04 PM

#

The PEP8 linter doesn't seem to check for multi-line [fbcu]-strings

woeful thorn Nov 25, 2019, 7:05 PM

#

?

ornate moat Nov 25, 2019, 7:06 PM

#

s = (
    f'{this} is a long '
    'string that has '
    'been spread '
    f'across {n} lines'
)```

tough imp Nov 25, 2019, 7:07 PM

#

is it preferred to f the ones that dont need to be f'd too?

ornate moat Nov 25, 2019, 7:07 PM

#

yes

molten bough Nov 25, 2019, 7:07 PM

#

Huh, I didn't know that

ornate moat Nov 25, 2019, 7:07 PM

#

It doesn't explicitly say so in PEP8 but it follows from the aligning guidelines

tough imp Nov 25, 2019, 7:07 PM

#

for once my desire to align everything isnt antipep

ornate moat Nov 25, 2019, 7:07 PM

#

core devs have said "do it"

mellow hare Nov 25, 2019, 7:08 PM

#

Isn't there a like.... unindent thing

#

Or something like that

ornate moat Nov 25, 2019, 7:08 PM

#

textwrap.unindent?

mellow hare Nov 25, 2019, 7:08 PM

#

Yeah I think that's it

ornate moat Nov 25, 2019, 7:08 PM

#

might work

#

I think uh

#

inspect.cleandoc or whatever

#

is better

#

I don't like either personally though

mellow hare Nov 25, 2019, 7:08 PM

#

Unless we're wanting to remove the newline characters

#

I think I'm just confused by the intent

hardy gorge Nov 25, 2019, 7:08 PM

#

Hmm, I think I've just added the f prefix to the lines that needed it in the past

green oriole Nov 25, 2019, 7:09 PM

#

I'm more afraid that the linter would trigger of there is a f without any formating

mellow hare Nov 25, 2019, 7:09 PM

#

Wait, does it actually?

tough imp Nov 25, 2019, 7:09 PM

#

the linter isn't the only one i'm afraid of triggering when i format for my eye's pleasure

woeful thorn Nov 25, 2019, 7:09 PM

#

Is there actually a plugin to enforce this?

hardy gorge Nov 25, 2019, 7:09 PM

#

I don't think so, Hem

crude gyro Nov 25, 2019, 7:10 PM

#

I've seen dozens of reviews saying "this doesn't need an f", so we should probably stop doing that if we buy this

woeful thorn Nov 25, 2019, 7:10 PM

#

It's definitely not consistently enforced in any of the repos

crude gyro Nov 25, 2019, 7:10 PM

#

and I think I buy the alignment argument. does help readability a little.

hardy gorge Nov 25, 2019, 7:11 PM

#

I don't really have an opinion. I like it fine without the additional f there, but I'm not opposed to adding it

#

I just don't think relying on us noticing it in reviews is going to work consistently

#

And, some reviewers not present here have commented to remove the unnecessary fs in the past

ornate moat Nov 25, 2019, 7:12 PM

#

black seems to uh

#

be completely broken

hardy gorge Nov 25, 2019, 7:12 PM

#

We could probably catch the latter pretty easily, but I don't think we can consistently enforce it that easily

ornate moat Nov 25, 2019, 7:12 PM

#

s = f"{this} is a long " "string that has " "been spread " f"across {n} lines" lol

#

ill eat brb

woeful thorn Nov 25, 2019, 7:12 PM

#

Not enough people can be convinced to add black anyway

#

At least to anything that isn't a new start

molten bough Nov 25, 2019, 7:13 PM

#

Yeah, I noticed a couple oddities with black too

hardy gorge Nov 25, 2019, 7:14 PM

#

I think this one does not change the logic of the code (four separate strings that will be combined implicitly), while black reformatting it to one explicitly joined string in the source code would do that. It would also have to perform logic to see which prefixes the entire string should get and the prefixes may be incompatible.

#

The second one could have {} in it not meant for formatting (no prefix)

molten bough Nov 25, 2019, 7:15 PM

#

To be fair, that one is still joined implicitly

#

Super weird though

hardy gorge Nov 25, 2019, 7:15 PM

#

What I mean is, this is not broken; what else should it do?

#

This fits one line, so it goes on one line

molten bough Nov 25, 2019, 7:15 PM

#

Oh, yeah

#

Yeah, I suppose so

crude gyro Nov 25, 2019, 7:15 PM

#

yeah, but that looks ridiculous.

hardy gorge Nov 25, 2019, 7:16 PM

#

I agree, yeah

molten bough Nov 25, 2019, 7:16 PM

#

I can see why it'd do that

hardy gorge Nov 25, 2019, 7:16 PM

#

but black can't resolve it within the style framework it works in

crude gyro Nov 25, 2019, 7:16 PM

#

if it was gonna reformat it to a oneliner, it ought to have put it inside a single f string.

molten bough Nov 25, 2019, 7:16 PM

#

What happens if they're all f-strings?

hardy gorge Nov 25, 2019, 7:16 PM

#

It can't do that, lemon

crude gyro Nov 25, 2019, 7:16 PM

#

sure it can.

hardy gorge Nov 25, 2019, 7:16 PM

#

What if the second one had a literal {a} in it?

crude gyro Nov 25, 2019, 7:16 PM

#

it's just code.

molten bough Nov 25, 2019, 7:16 PM

#

They're not the same type of string, technically

hardy gorge Nov 25, 2019, 7:16 PM

#

It would have to start parsing the strings to know if it should escape those and changing the actual code

crude gyro Nov 25, 2019, 7:17 PM

#

yes.

#

I'm not saying that's what the black devs should've done, just that I agree with Ava that this example is terrible.

#

and it's the kind of thing that makes half of us not be open to using black.

#

on the pydis repos anyway

woeful thorn Nov 25, 2019, 7:18 PM

#

The existing ones at least

#

flake8-annotations is black formatted and nobody's noticed

molten bough Nov 25, 2019, 7:19 PM

#

The reason it doesn't work is that it (the code) doesn't follow the devs' undocumented recommendation

#

I wonder if that should have been in a PEP too

#

Might be worth raising an issue for

woeful thorn Nov 25, 2019, 7:45 PM

#

@hardy gorge I'd probably prefer modlog over message change log for the attachments deletion. Though the advantage of a discrete channel means we can more easily look for how often the filter is triggered & by what attachments so we can see if the rule needs adjusting

#

Another channel isn't going to bother me, most of it is muted and collapsed anyway

hardy gorge Nov 25, 2019, 7:51 PM

#

Hmm, true

#

I don't mind any of the solutions, I just think it would be a mostly dormant channel to begin with

#

We rarely ever relay messages from antispam and it's even rarer for them to contain attachments

#

Guess it doesn't really matter

#

Okay, let's do another log channel then. I'm not sure I'd like it in mod-log, since it's a channel that has actual information some people (or maybe just me) want to look at to see what's been happening

ornate moat Nov 26, 2019, 8:04 AM

#

@gusty sonnet I use kind of the reverse approach in my old bot ```py
intervals = (
('week', 604_800), # 60 * 60 * 24 * 7
('day', 86_400), # 60 * 60 * 24
('hour', 3_600), # 60 * 60
('minute', 60),
('second', 1),
)

def display_time(seconds: int) -> str:
"""
Turns seconds into human readable time.
"""
message = ''

for name, amount in intervals:
    n, seconds = divmod(seconds, amount)

    if n == 0:
        continue

    message += f'{n} {name + "s" * (n != 1)} '

return message.strip()```

gusty sonnet Nov 26, 2019, 8:29 AM

#

Hah!

#

That does look cleaner actually, in term of not having to reverse the result

#

But then you gotta do the multiplying beforehand

#

In term of performance I love your approach

#

I went with the easier to read lol

#

Imma steal your 's' approach @ornate moat

#

That is a damn clever way

ornate moat Nov 26, 2019, 8:31 AM

#

I learned it from a fizzbuzz that I learned about a week into my python career

#

(and said fizzbuzz I think is one of the nicest piece of code even though it's not maybe the mots readable)

#

'Fizz' * (not n % 3) + 'Buzz' * (not n % 5) or n for n in range(1, 101)```

gusty sonnet Nov 26, 2019, 8:34 AM

#

's' * (amount > 1) is readable enough lol

#

Hmm, or should I still stick with the 's' if amount > 1 else ''

#

Meh.

green oriole Nov 26, 2019, 8:34 AM

#

The latter is more readable

gusty sonnet Nov 26, 2019, 8:35 AM

#

That's what I thought as well

#

xd

green oriole Nov 26, 2019, 8:35 AM

#

We aren’t all doing esoteric python! 😄

gusty sonnet Nov 26, 2019, 8:37 AM

#

qq

#

I edited the code, I realized a pitfall with years ( dividing int by 1 always gives 0 remainder ), added more tests, and added Ava's method

#

I have to mention it!

ornate moat Nov 26, 2019, 8:45 AM

#

I would put it outside the f-string

#

something like plural = 's' if ... else '' f'{thing}{plural}'

gusty sonnet Nov 26, 2019, 8:50 AM

#

That way fstring stays simple and naive, it will just assemble values into a string

#

Thanks Ava

#

Also Imma stick to .0f instead of int()

tawdry vapor Nov 27, 2019, 8:01 AM

#

Would this be useful to include in our guides? https://guides.github.com/introduction/flow/

glass pecan Nov 27, 2019, 11:35 AM

#

mm github have a lot of great guides

#

it'll be worth adding some links in when we make appropriate sections for them

crude gyro Nov 27, 2019, 12:07 PM

#

I'm playing with the photoshop animation stuff

#

it kinda sucks

#

but it's usable.

hardy gorge Nov 27, 2019, 12:09 PM

#

I've used it in an older version, I remember giving up after getting frustrated

crude gyro Nov 27, 2019, 12:16 PM

#

I essentially created a video instead of a gif, I think

#

like, photoshop says it's a video

#

so I can't export to gif

#

I can only export it as an mp4 or something

#

but when I try to convert it to a "frame animation", then the transform options disappear

#

and all the work I did is gone

#

so I tried to convert the mp4 to a gif

#

but that makes it really dirty looking

#

📎 runner.gif

#

in one software I tried

#

and full of artifacts in the other

#

📎 runner_big_gif.gif

#

maybe @tough imp has some advice how I can possibly export this in a way that doesn't suck.

#

📎 runner_guttergif.gif

#

here it is guttersized.

#

the big version looks a bit shit but the tiny version looks alright I think.

#

okay, think I found a solution

#

📎 runner_512.gif

#

📎 runner_64.gif

#

@hardy gorge whatchu think honeycomb

hardy gorge Nov 27, 2019, 12:46 PM

#

That looks good to me. The larger one has a few artifacts and we were super critical of them with the first animated icons, but I think that comes with the gif format ultimately and they're not visible at server icon size anyway

crude gyro Nov 27, 2019, 12:47 PM

#

does it?

hardy gorge Nov 27, 2019, 12:47 PM

#

hmm

#

Maybe not

crude gyro Nov 27, 2019, 12:47 PM

#

just my poor excuse for a dust cloud, I think

#

the whole thing looks like an artifact pleased_lemon

#

but I do think the smaller one looks alright.

hardy gorge Nov 27, 2019, 12:48 PM

#

No, my screen is showing a couple of ligher "lines" in the blurple snake, but maybe it's just the downsize Discord does when embedding

crude gyro Nov 27, 2019, 12:48 PM

#

huh. maybe.

#

anyway, gotta run.

hardy gorge Nov 27, 2019, 12:48 PM

#

Anyway, looks good

tough imp Nov 27, 2019, 1:30 PM

#

i think the last one came out alright

#

i use the export for web (legacy) option

#

and then mostly defaults

#

most of the artifacting i was seeing was compression on discord's side

#

mostly present with colour changes, the spinny one was a headache

#

just make sure you check loop forever, because the gifs dont loop by default using the web exporter

#

im still not happy with the christmas one tbh, it somehow ends up looking blurry

#

📎 20191127_143312.JPG

crude gyro Nov 27, 2019, 1:40 PM

#

hmm.

#

yeah.

#

can the insides of the snakes maybe be a bit less transparent?

#

I think that's why it looks blurry

tough imp Nov 27, 2019, 6:44 PM

#

@crude gyro looks like the glow is the culprit, if i remove the glow its a lot more crisp, but the icon looks more poor

#

but i can have the glow come in on hover

#

📎 20191127_194230.JPG

#

this is a screenshot from my phone

#

📎 unknown.png

#

first one has no glow and transparent fill

#

i think i prefer the first one, let me know what you think

crude gyro Nov 27, 2019, 7:51 PM

#

@tough imp uh..

#

that's four.

tough imp Nov 27, 2019, 7:51 PM

#

yeah sorry lol the first screenshot is phone, second is computer

#

but the logos are the same

crude gyro Nov 27, 2019, 8:05 PM

#

I'm still confused which one is the one you are suggesting

#

is the top one the old one?

#

anyway both of the bottom ones look pretty good to me.

tough imp Nov 27, 2019, 8:07 PM

#

you mean both logos on bottom screenshot or bottom logo on both screenshots (im sorry)

crude gyro Nov 27, 2019, 8:13 PM

#

lol

#

the latter

#

but honestly those screenshots suck

#

they're very pixelated and it's hard to tell what's what.

#

the bottom logo on both screenshots looks brighter and has more contrast

tough imp Nov 27, 2019, 8:23 PM

#

i think it helps a lot to make the background darker

📎 aoc_banner_logo.png

#

can you try this on the test server

crude gyro Nov 27, 2019, 8:24 PM

#

you might be right about that.

#

that looks very clear.

tough imp Nov 27, 2019, 8:24 PM

#

alright im also fairly happy with it

crude gyro Nov 27, 2019, 8:24 PM

#

did you change the hex too?

tough imp Nov 27, 2019, 8:25 PM

#

yep thats done

crude gyro Nov 27, 2019, 8:25 PM

#

okay, cool. let's go with that, then

tough imp Nov 27, 2019, 8:25 PM

#

rainbowcat

crude gyro Nov 27, 2019, 8:26 PM

#

and, uh, nice work.

tough imp Nov 27, 2019, 8:26 PM

#

i mean its your logo lol

crude gyro Nov 27, 2019, 8:35 PM

#

naw, you're fixing it

tawdry vapor Nov 28, 2019, 5:10 AM

#

this is interesting

#

https://docs.microsoft.com/en-us/azure/devops/pipelines/caching/?view=azure-devops

Pipeline caching - Azure Pipelines

Improve pipeline performance by caching files, like dependencies, between runs

#

Tempted to see how well it works with pipenv

gusty sonnet Nov 28, 2019, 5:10 AM

#

That is interesting

green oriole Nov 28, 2019, 8:27 AM

#

@tawdry vapor I think it would be easier here

#

for every Message in messages, there is a corresponding list (which could be empty) in attachments

#

So.. they should both have the same lengh

tawdry vapor Nov 28, 2019, 8:34 AM

#

OK you can resolve that then

hollow lichen Nov 28, 2019, 6:54 PM

#

Nice bit logo

crude gyro Nov 28, 2019, 8:51 PM

#

@tough imp how's the logo coming along? we'll need it live on Sunday, so time is running out.

tough imp Nov 28, 2019, 8:52 PM

#

😬

#

give me 1 sec

#

ill get back to you shortly

#

making some fixes

#

📎 pydismas.gif

#

@crude gyro how do you feel about this

crude gyro Nov 28, 2019, 9:07 PM

#

looks great in that size, but how does it look in gutter size I wonder

#

guess we gotta test it out and see

tough imp Nov 28, 2019, 9:08 PM

#

you can sort of preview it in server settings

#

and if you apply it you get to see the first frame in the gutter

hardy gorge Nov 28, 2019, 9:08 PM

#

live testing!

tough imp Nov 28, 2019, 9:10 PM

#

alternatively its possible to not have the fade-in, fade-out

#

but then the first frame has snow, not sure how that works with you

#

1 sec ill export

crude gyro Nov 28, 2019, 9:12 PM

#

yeah but the server settings preview is also much larger than the gutter image

#

although it does look good there, too

tough imp Nov 28, 2019, 9:13 PM

#

would you like me to make one with the flakes bigger so that we can switch them on-demand if needed

hardy gorge Nov 28, 2019, 9:13 PM

#

Why don't we just actually do a live preview for 5 seconds

#

Then we can all look how it will look and it doesn't really matter

#

most people are celebrating thanksgiving anyway

#

Or so I've heard

crude gyro Nov 28, 2019, 9:13 PM

#

yeah, I don't really mind if we just do that.

#

was gonna suggest it myself.

tough imp Nov 28, 2019, 9:14 PM

#

check it on your phones as well

hardy gorge Nov 28, 2019, 9:14 PM

#

Okay, it clearly looks like snow to me

crude gyro Nov 28, 2019, 9:15 PM

#

it looks good on both desktop and phone

#

let me change it to my runner

#

oh. guess I fucked up and lost it.

#

never mind then.

tough imp Nov 28, 2019, 9:16 PM

#

it must be in the history of this chat

crude gyro Nov 28, 2019, 9:16 PM

#

I still have it but only in windows.

#

rebooting

#

<@&267629731250176001> check out the guild icon while it lasts

hardy gorge Nov 28, 2019, 9:17 PM

#

oh

#

sorry

crude gyro Nov 28, 2019, 9:17 PM

#

haha. whoops.

hardy gorge Nov 28, 2019, 9:18 PM

#

it ran away

crude gyro Nov 28, 2019, 9:18 PM

#

oh you set it to runner

#

nice.

#

well, check that out instead then.

clever wraith Nov 28, 2019, 9:18 PM

#

the icon was nice

tough imp Nov 28, 2019, 9:18 PM

#

the snowy one is scheduled for december

#

we were just doing a quick test because you cant really preview it on a non-booster server

clever wraith Nov 28, 2019, 9:19 PM

#

fair

crude gyro Nov 28, 2019, 9:20 PM

#

it's only one boost to unlock animated icon, right?

#

we should probably move one boost to the test server.

#

but it's like.. we don't have any margin then

#

for level 3

clever wraith Nov 28, 2019, 9:20 PM

#

2 boosts

tough imp Nov 28, 2019, 9:20 PM

#

i only have the cheap non-boosty nitro

clever wraith Nov 28, 2019, 9:20 PM

#

1 boost level

tough imp Nov 28, 2019, 9:20 PM

#

otherwise i'd help out

clever wraith Nov 28, 2019, 9:21 PM

#

you can now buy boosts just stand alone

#

i think it's $3.40 or something

tough imp Nov 28, 2019, 9:21 PM

#

thats a one-time payment?

#

i assume just 1 month

crude gyro Nov 28, 2019, 9:28 PM

#

https://github.com/python-discord/branding/pull/37 pushed the runner PR

GitHub

Add new animated icon: runner by lemonsaurus · Pull Request #37 ...

Adds a new icon that's in a hurry to gtfo.

tough imp Nov 28, 2019, 9:32 PM

#

good good

#

so are we happy with the snowy one?

hardy gorge Nov 28, 2019, 9:32 PM

#

let it snow, I'd say

tough imp Nov 28, 2019, 9:32 PM

#

the alternative is to just have it loop

#

no fade

#

📎 unknown.png

#

i think it doesnt look horrible

#

📎 pydismas_nofade.gif

hardy gorge Nov 28, 2019, 9:33 PM

#

I like the faded one better, I think

tough imp Nov 28, 2019, 9:33 PM

#

this way we can reduce the filesize greatly as the loop is actually only like 1 sec, and on hover it snows forever

hardy gorge Nov 28, 2019, 9:33 PM

#

ah

tough imp Nov 28, 2019, 9:33 PM

#

but yes perhaps its better with the fade

#

i dont have a strong opinion

crude gyro Nov 28, 2019, 9:36 PM

#

I don't really care if it fades or not, I think it looks good in both.

#

you did a great job making the snow look realistic.

#

quite impressive work

#

the fact that they're spinning makes all the difference.

tough imp Nov 28, 2019, 9:37 PM

#

i ended up taking it to sony vegas

#

this wouldnt be achievable with photoshop

crude gyro Nov 28, 2019, 9:37 PM

#

sounds like you should learn AE

tough imp Nov 28, 2019, 9:38 PM

#

yes i really should

crude gyro Nov 28, 2019, 9:38 PM

#

you should and you will. it's a holiday miracle!

tough imp Nov 28, 2019, 9:38 PM

#

ive actually been wanting to since primary school lol

crude gyro Nov 28, 2019, 9:38 PM

#

since you were 6 years old.

#

how about that.

tough imp Nov 28, 2019, 9:38 PM

#

when we made runescape videos the kids that used AE had better intros than us Vegasers

crude gyro Nov 28, 2019, 9:39 PM

#

filthy vegasers

tough imp Nov 28, 2019, 9:39 PM

#

but they were using templates mad

#

ok so, fade or nofade

#

we need someone to decide

#

actually Ves said he prefers fade

#

so lets go with that

crude gyro Nov 28, 2019, 9:41 PM

#

fade it is. how big is the file?

tough imp Nov 28, 2019, 9:41 PM

#

3 MB roughly

#

its not bad

#

the ones coming out of PS were up to 20 lol

#

well in 1024x1024

#

would you like me to PR the t-shirt template as well

#

or should I just dm it to you

crude gyro Nov 28, 2019, 9:48 PM

#

yeah

#

just PR it all in

tough imp Nov 28, 2019, 10:50 PM

#

@crude gyro PR is ready

#

https://github.com/python-discord/branding/pull/38

GitHub

Add christmas branding, fix spinner off-season logo by kwzrd · Pu...

In this PR we add a carefully crafted branding pack for the 2019 festive season, and I'm kaizening in a fix to the off-season spinner logo.
Christmas
bbc5509: Moves last year's fest...

crude gyro Nov 28, 2019, 10:50 PM

#

already looking at it

#

didn't the spinner use to spin the other way?

tough imp Nov 28, 2019, 10:51 PM

#

no no

#

https://raw.githubusercontent.com/python-discord/branding/master/logos/logo_animated/spinner/spinner_256.gif

crude gyro Nov 28, 2019, 10:52 PM

#

mkay

#

okay, so

#

📎 banner.png

#

the banner, with the updated logo, is font too dim now in comparison?

#

what do you guys all think

#

it's probably fine

#

📎 unknown.png

#

here's the design on a shirt.

molten bough Nov 28, 2019, 10:57 PM

#

At the size it's gonna be at, I think it's fine too

tough imp Nov 28, 2019, 10:57 PM

#

that looks blurry af

crude gyro Nov 28, 2019, 10:58 PM

#

it does. it's probably too glowy.

#

the mockup is probably a little shittier than it would actually look

#

📎 unknown.png

#

but it's probably still too glowy

molten bough Nov 28, 2019, 10:59 PM

#

I feel like it'd look better without any glow on a shirt

tough imp Nov 28, 2019, 10:59 PM

#

yeah

crude gyro Nov 28, 2019, 10:59 PM

#

yep, that's likely the case.

#

so if you'd like to, you can render that again?

tough imp Nov 28, 2019, 10:59 PM

#

im on it

molten bough Nov 28, 2019, 10:59 PM

#

I mean, since you don't get semi-transparency

tough imp Nov 28, 2019, 11:00 PM

#

i think its because it blends into white

#

rather than into the background colour

#

its the exact same logo as the one on the banner, just enlarged

crude gyro Nov 28, 2019, 11:00 PM

#

well let's just try it with no glow

tough imp Nov 28, 2019, 11:02 PM

#

📎 tshirt_noglow.png

crude gyro Nov 28, 2019, 11:02 PM

#

weird

#

still appears to have a glow

molten bough Nov 28, 2019, 11:02 PM

#

It's totally got glow

#

📎 unknown.png

tough imp Nov 28, 2019, 11:02 PM

#

but thats ur glow not my glow mad

crude gyro Nov 28, 2019, 11:02 PM

#

you got the psd

#

but I'll give this a try anyway

tough imp Nov 28, 2019, 11:03 PM

#

i can remove your glow too just need a minute

#

ill have to extract it from the original psd because i converted the snakes to smart objects so that i could animate them

#

but now i dont have access to the effects

crude gyro Nov 28, 2019, 11:04 PM

#

📎 unknown.png

#

I think you may need to cause this looks better but still not great.

tough imp Nov 28, 2019, 11:10 PM

#

📎 tshirt_noglow_noglow.png

crude gyro Nov 28, 2019, 11:11 PM

#

loving the filename

tough imp Nov 28, 2019, 11:11 PM

#

_final_final_final

crude gyro Nov 28, 2019, 11:13 PM

#

that's a lot better

#

📎 unknown.png

#

although I'm a little unhappy now with the layer mask around the eyes.

#

makes sense when the glow is there but without it, it's way too big

#

gives it giant rings around the eyes.

#

would you mind spending a minute cleaning up the excessive layer masking?

#

there's some along the edges too

tough imp Nov 28, 2019, 11:15 PM

#

im trying to figure out how you've done it

crude gyro Nov 28, 2019, 11:16 PM

#

the bits are on a layer at the bottom of the snakes folder I think

#

and those have layer masks

#

iirc

#

which I mostly just drew in free-hand

tough imp Nov 28, 2019, 11:16 PM

#

would you mind if we finish this tomorrow

#

its getting really late for me

crude gyro Nov 28, 2019, 11:16 PM

#

naw that's okay

#

we got time tomorrow

#

I gotta go sleep too

tough imp Nov 28, 2019, 11:16 PM

#

alright

crude gyro Nov 28, 2019, 11:16 PM

#

although, I'm out all tomorrow

#

but just ping me anyway

tough imp Nov 28, 2019, 11:17 PM

#

thats fine, i will commit to the PR and ping you once its ready

crude gyro Nov 28, 2019, 11:17 PM

#

excellent. thanks a million for doing this

tough imp Nov 28, 2019, 11:17 PM

#

no problem at all, thanks a million for this community rainbowcat

green oriole Nov 29, 2019, 7:39 AM

#

Guys, is it possible to disable check_run on the gh webhooks, since it is redundant the azure webhooks?

tawdry vapor Nov 29, 2019, 7:54 AM

#

Yeah we probably should if that's possible

hardy gorge Nov 29, 2019, 8:03 AM

#

There's a check suite option; the Check runs is currently not enabled

green oriole Nov 29, 2019, 8:07 AM

#

Well check_run is the extended version of check_suite, so I think you should disable it

hardy gorge Nov 29, 2019, 8:08 AM

#

Yes, I've disabled it

#

The first is not exactly the extended version; it's just for different kind of events (individual checks vs a check suite)

green oriole Nov 29, 2019, 8:09 AM

#

Oh yeah my bad they didn’t affect the same part

#

Because every actions included in check_suite is also in check_run, I was confused

#

Looks like it has worked!

crude gyro Nov 29, 2019, 8:27 AM

#

can someone fill me in on what that did?

molten bough Nov 29, 2019, 8:28 AM

#

Checks are basically what CI reports back to GH when the build is done running

tawdry vapor Nov 29, 2019, 8:29 AM

#

removes the top webhook

📎 unknown.png

molten bough Nov 29, 2019, 8:29 AM

#

Yup, was getting a link to that, haha

green oriole Nov 29, 2019, 8:30 AM

#

Plus all of them except the first one (normally)

📎 C52FDD4C-CD00-4BAB-AE10-D299C04E43FC.jpeg

green oriole Nov 29, 2019, 12:05 PM

#

You haven't disabled it on the seasonalbot?

hardy gorge Nov 29, 2019, 12:06 PM

#

No, I'd only disabled it for bot to see what was going to happen

#

It takes a bit of time to modify the webhooks for all repos, so I rather waited to see if this change is desirable

green oriole Nov 29, 2019, 12:08 PM

#

Oki

crude gyro Nov 29, 2019, 12:42 PM

#

yeah let's do it on seasonalbot too

tawdry vapor Nov 29, 2019, 5:59 PM

#

What's the deal with this? https://discordapp.com/channels/267624335836053506/303906556754395136/650031568869654531

#

Did two filters trigger simultaneously?

hardy gorge Nov 29, 2019, 6:00 PM

#

Basically.

#

They spammed a lot before the mute was finally effected

#

So, the antispam triggered twice, since to runs for each on_message and will trigger as long as the messages have not been removed yet.

#

Normally, the bot is quick enough, but sometimes there's a bit of lag

#

📎 Screenshot_20191129-1902332.png

#

It triggered after the first four, but they were able to sent more messages before they were muted.

#

Oh, they were able two sent four duplicates twice, so, yeah, forget the previous for every on_message explanation. They may have just been able to trigger it twice in rapid succession.

tawdry vapor Nov 29, 2019, 6:22 PM

#

Thanks. So nothing to really worry about?

hardy gorge Nov 29, 2019, 6:27 PM

#

No, I don't think so. The double mute failure is a bit ugly in a public channel, but it does now gather the deleted messages into a single deleted message content (as you can see, they're all in one screen). We used to get multiple smaller deleted messages contexts, too, but there's now a delay/consume task.

tough imp Nov 29, 2019, 9:40 PM

#

hmm it looks like my commits are being timestamped one hour into the future

#

📎 unknown.png

molten bough Nov 29, 2019, 9:43 PM

#

📎 unknown.png

#

Looks like your PC's time is set incorrectly

tough imp Nov 29, 2019, 9:47 PM

#

oh wow ok i fixed it

#

my computer's clock was one hour ahead and i previously fixed it by putting -1 on the time widget

#

all good now

molten bough Nov 29, 2019, 9:48 PM

#

haha, I love that solution

#

such a kludge

tough imp Nov 29, 2019, 9:49 PM

#

pleased_lemon

crude gyro Nov 30, 2019, 12:07 PM

#

@sleek mason https://github.com/python-discord/bot/pull/643 can you look at this soon, it's a bit stale.

GitHub

implement !zen command. by kingdom5500 · Pull Request #643 · pyt...

resolves #642.

sleek mason Nov 30, 2019, 1:18 PM

#

yes indeed, i'll do that soon :)

clever wraith Nov 30, 2019, 4:04 PM

#

am not proffesional and all
but did someone looked after this ?
https://discordapp.com/channels/267624335836053506/635950537262759947/639484028012986369

clever wraith Nov 30, 2019, 4:26 PM

#

probably no . cuz the thing it supposed to fix is still there

green oriole Nov 30, 2019, 5:13 PM

#

You can try searching through gh issues, and if there is none for it (opened or closed) you could open one @clever wraith

clever wraith Nov 30, 2019, 5:21 PM

#

i will do it when i get home . in 24 hour

glass pecan Dec 1, 2019, 4:14 PM

#

can someone slip in a quick sanity review for https://github.com/python-discord/seasonalbot/pull/319

GitHub

Fix cmd annotation by decorator-factory · Pull Request #319 · py...

Fix the brief argument for .aoc join to make its behaviour more obvious.

crude gyro Dec 1, 2019, 7:21 PM

#

@tough imp maybe we should fix the hex, it does suck a bit that one of the bits is outside the frame if we're gonna print it on a t-shirt..

#

and I had the idea that maybe it should just be a link to the advent of code website instead

tough imp Dec 1, 2019, 7:22 PM

#

yes im planning to make the fix tonight

#

both are good ideas

#

we can do aoc

crude gyro Dec 1, 2019, 7:22 PM

#

it sort of.. makes it the aoc t-shirt, you know?

tough imp Dec 1, 2019, 7:22 PM

#

yeah

spring ermine Dec 2, 2019, 8:50 AM

#

Moving from #esoteric-python:
Add -save and -load to eval to allow using a previous snippet multiple times to allow easier esoteric testing. The suggested implementation was to simply prepend the saved code to the new snippets.
Things that need discussing:

Memory usage
Saving strings of up to 2k characters can take up a lot of space. We need to find ways to clean this somehow, maybe if unused for x hours it gets removed. Alternatively, we could try precompiling this, but this would come with limitations too.
Argument parsing
We need to parse -save and -load, and we want this to be as clean as possible (preferably not a code.split()[0] check)

gusty sonnet Dec 2, 2019, 8:50 AM

#

A task to autoremove unused code after x hours sounds good, to prevent hogging memories

#

a way to deal with -save and -load would be adding more alias to !e and then we check the ctx.invoked_with or whatever it was

#

like !e-save / !e-load

#

Then we dont introduce extra args to the commands and have to deal with complicated of checking

spring ermine Dec 2, 2019, 8:52 AM

#

I mean I had an ArgumentParserCommand somewhere in my old codebase that literally used argparse for command parsing

gusty sonnet Dec 2, 2019, 8:52 AM

#

Same, I used to do that

green oriole Dec 2, 2019, 8:52 AM

#

Also, implementing a re-run emoji on the input message (something like 🔄) to run the same code again in case it was edited to avoid copy pasting, could be nice

tawdry vapor Dec 2, 2019, 8:52 AM

#

I think you're overthinking the arguments thing

gusty sonnet Dec 2, 2019, 8:53 AM

#

That's a nice idea @green oriole

spring ermine Dec 2, 2019, 8:54 AM

#

Maybe we could just use a LiteralArgumentConverter which could take an optional keyword, where it would return a literal if in the list of literals passed or return None/raise ArgumentError depending on optional param if not present

#

class LiteralConverter(Converter):
    def __init__(self, *literals: str, optional: bool = False):
        self.literals = literals
        self.optional = optional

    async def convert(self, ctx: Context, argument: str):
        if argument in self.literals:
            return argument
        if self.optional:
            return None
        raise BadArgument(f"Expected literal: {self.literals}")


@command()
def eval(ctx: Context, action: LiteralConverter("-save", "-load", optional=True), *, code: str):
    ...

green oriole Dec 2, 2019, 9:10 AM

#

@spring ermine have you opened an issue so we don’t forget in 1 hour? 😄

gusty sonnet Dec 2, 2019, 9:11 AM

#

That looks great @spring ermine

green oriole Dec 2, 2019, 9:13 AM

#

Btw, I see people structuring their issue with paragraph named abstract, specification, rationale and motivation, is it a good practice?

tawdry vapor Dec 2, 2019, 9:15 AM

#

Yes, if you actually have that much to say.

#

You don't have to though

#

enforcing it would feel too bureaucratic

spring ermine Dec 2, 2019, 9:17 AM

#

I feel like giving an introduction like that gives a clear picture of what we want, why we want it, and how we'd implement it, answering the 3 most common questions you could have as maintainer

gusty sonnet Dec 2, 2019, 9:19 AM

#

Abstract:
In order to get the community involved with a project, the codebase should be united, clean, and structured. <insert 5 more paragraph>

Rationale:
If we have multiple ways to format / structure codes, it will make reading the codebase once it grows larger very hard. <insert 20 PEP>

Motivation:
When I was younger, with my first steps into the field, I have always wanted to join projects. First part is always be able to know what it is doing, hence good structures are amazing. <insert 20 more personal experience>

Specification:
@client.command()
async def hello():
    print('Hello command was called for testing')

should be
@client.command()
async def hello(ctx):
    ...```

#

Jokes aside, it depends on how complicated / the level of details of your issue

#

If it's new features / enhancements, more often than not, if you can do that, please do

green oriole Dec 2, 2019, 9:20 AM

#

But what’s the difference between the rationale and the motivation?

spring ermine Dec 2, 2019, 9:20 AM

#

¯\_(ツ)_/¯

gusty sonnet Dec 2, 2019, 9:21 AM

#

📎 unknown.png

#

We have the best of fisk

green oriole Dec 2, 2019, 9:21 AM

#

I’m reading the same issue haha

#

(What is this dark theme magic?)

gusty sonnet Dec 2, 2019, 9:22 AM

#

It's a chrome extension

#

It saves my eyes

green oriole Dec 2, 2019, 9:22 AM

#

That’s great!

gusty sonnet Dec 2, 2019, 9:22 AM

#

I'm using this one https://chrome.google.com/webstore/detail/github-dark-theme/odkdlljoangmamjilkamahebpkgpeacp

green oriole Dec 2, 2019, 9:22 AM

#

i did the same with the python docs actually

#

Oh yeah thanks!

spring ermine Dec 2, 2019, 10:06 AM

#

hmm

#

so the converter seems to consume the parameter

#

i.e. it doesn't show up in the code parameter

crude gyro Dec 2, 2019, 10:35 AM

#

this seem overengineered

#

why don't we just use a command group instead of parsing -save and -load flags

spring ermine Dec 2, 2019, 10:36 AM

#

I actually have it working with what Danny gave me and it's a pretty clean solution

crude gyro Dec 2, 2019, 10:37 AM

#

I just don't get why we would need that if we can use existing discord.py features for it

spring ermine Dec 2, 2019, 10:37 AM

#

I asked him what he recommended we do tho

crude gyro Dec 2, 2019, 10:37 AM

#

I don't really care what danny thinks we should do.

spring ermine Dec 2, 2019, 10:37 AM

#

oh

molten bough Dec 2, 2019, 10:37 AM

#

I too was wondering why we didn't use a command group

#

but I'd just woken up so I wasn't sure if I was crazy

crude gyro Dec 2, 2019, 10:38 AM

#

so, flags would make sense if you need to pass multiple flags at the same time

spring ermine Dec 2, 2019, 10:38 AM

#

in that case I'll leave it up to someone else to impl since I don't have the experience nor time to implement command groups

crude gyro Dec 2, 2019, 10:38 AM

#

but I can't think of a reason why we would do both -save and -load

molten bough Dec 2, 2019, 10:38 AM

#

command groups are like.. one of the easiest things

#

haha

#

you'd be fine

crude gyro Dec 2, 2019, 10:38 AM

#

yeah honestly we use command groups in a bunch of places already and it's as easy as using a decorator

#

it's absolutely trivial

spring ermine Dec 2, 2019, 10:39 AM

#

I mean I have 7 minutes to do it if I want to do it in the next few days :P

crude gyro Dec 2, 2019, 10:39 AM

#

okay

#

sounds like you don't have time then

#

that's fine, too.

green oriole Dec 2, 2019, 10:54 AM

#

@spring ermine you should run pipenv run precommit In your local copy of the bot so your code is linted before being commited

spring ermine Dec 2, 2019, 11:06 AM

#

huh

#

I ran flake8 over it tho

green oriole Dec 2, 2019, 11:08 AM

#

Yeah, but we have a special flake8 config so..

molten bough Dec 2, 2019, 11:08 AM

#

and it also means you're all set if the pre-commit config changes

spring ermine Dec 2, 2019, 11:10 AM

#

Creating a virtualenv for this project…
Pipfile: /home/mart/git/bot/Pipfile
Using /home/mart/.pyenv/versions/3.7.0/bin/python3 (3.7.0) to create virtualenv…
⠼ Creating virtual environment...Already using interpreter /home/mart/.pyenv/versions/3.7.0/bin/python3
Using base prefix '/home/mart/.pyenv/versions/3.7.0'
New python executable in /home/mart/.local/share/virtualenvs/bot-vQrXOkDg/bin/python3
Also creating executable in /home/mart/.local/share/virtualenvs/bot-vQrXOkDg/bin/python
Installing setuptools, pip, wheel...
done.
Running virtualenv with interpreter /home/mart/.pyenv/versions/3.7.0/bin/python3

✔ Successfully created virtual environment! 
Virtualenv location: /home/mart/.local/share/virtualenvs/bot-vQrXOkDg
Error: the command pre-commit (from precommit) could not be found within PATH.

glass pecan Dec 2, 2019, 11:10 AM

#

did you use pipenv sync --dev specifically with the dev flag

spring ermine Dec 2, 2019, 11:10 AM

#

why does it even create a new venv when I already put it in a pyenv notlikethis

glass pecan Dec 2, 2019, 11:11 AM

#

yeah you don't use other virtual envs, you have to let pipenv create it as it appends a hash after the project name that it tracks

spring ermine Dec 2, 2019, 11:15 AM

#

goddamnit

#

It's this all over again

📎 python_environment.png

glass pecan Dec 2, 2019, 11:17 AM

#

no matter what project is involved, there's usually one established way to set it up. it's why there's contributors guidelines and setup docs.

gusty sonnet Dec 2, 2019, 11:57 AM

#

Oh my god I completely forgot commands group

#

That is indeed cleaner

molten bough Dec 2, 2019, 12:04 PM

#

The best part about programming XKCDs is that Randall isn't a programmer, haha

spring ermine Dec 2, 2019, 12:10 PM

#

Then how is it always so accurate blobthinkingdown

molten bough Dec 2, 2019, 12:10 PM

#

I dunno if I'd call it accurate

#

They're not supposed to be taken seriously, yknow

gusty sonnet Dec 2, 2019, 2:00 PM

#

Hmm @green oriole is there a reason why we initialize to None and then reassign later in the __init__()

#

        self.countdown_task = None
        self.status_task = None

        countdown_coro = day_countdown(self.bot)
        self.countdown_task = asyncio.ensure_future(self.bot.loop.create_task(countdown_coro))

        status_coro = countdown_status(self.bot)
        self.status_task = asyncio.ensure_future(self.bot.loop.create_task(status_coro))```

green oriole Dec 2, 2019, 2:01 PM

#

Dunno, I wasn’t even on the server when the cog was created

#

I can delete it if you want

gusty sonnet Dec 2, 2019, 2:01 PM

#

Hmm, yeah, refactor should be another PR

#

Adding cog_unload in itself is worth a PR i believe

glass pecan Dec 2, 2019, 2:01 PM

#

yes it's an unnecessary part of init

#

i seen it too but the PR scope was worth just approving

gusty sonnet Dec 2, 2019, 2:02 PM

#

That's what I thought

#

Anyway I reviewed it, it should be good to go

glass pecan Dec 2, 2019, 2:02 PM

#

coolio

#

thanks

clever wraith Dec 2, 2019, 6:04 PM

#

📎 unknown.png

#

what does this mean ?

green oriole Dec 2, 2019, 6:04 PM

#

pipenv run lint if you haven't setup precommit

glass pecan Dec 2, 2019, 6:05 PM

#

Both

gusty sonnet Dec 2, 2019, 6:05 PM

#

Hmm, anyone knows how to round ... relativedelta?

glass pecan Dec 2, 2019, 6:05 PM

#

Still setup precommit

gusty sonnet Dec 2, 2019, 6:05 PM

#

I'm running into 4 days 23 hours 59 minutes 59 seconds

#

With max 2 units it's 4 days 23 hours

green oriole Dec 2, 2019, 6:05 PM

#

Oh yeah you need to add one second

#

I got the same problem

gusty sonnet Dec 2, 2019, 6:05 PM

#

The problem is that that date is from the api

#

So I wont know if it's lacking 1 second or 7 seconds

green oriole Dec 2, 2019, 6:07 PM

#

Well if it is always 59 seconds, you lack one second right?

#

The api is pretty fast

#

But I don't understand how the api could influence that

gusty sonnet Dec 2, 2019, 6:09 PM

#

I have a feeling it's the microseconds

#

Let me try crazy stuff

#

Oh well, it'll be good enough xD

clever wraith Dec 3, 2019, 11:22 AM

#

Any status on the Feature request ? Cuz i completed its code ;-;

#

https://github.com/python-discord/seasonalbot/issues/323#issuecomment-560507787

GitHub

Feature Request - personal Pins AKA bookmarks · Issue #323 · pyt...

Bot command - !bookmark Useful for the cases in which you want to pin some useful info from someone who sent it . basically it sends a embed to DM of the author , consisting a link to that specific...

#

I am so proud of myself today ;-;

#

@crude gyro

glass pecan Dec 3, 2019, 11:24 AM

#

Please don't ping staff randomly

clever wraith Dec 3, 2019, 11:24 AM

#

He asked for that last night

glass pecan Dec 3, 2019, 11:24 AM

#

we all know when an issue ticket has been created

clever wraith Dec 3, 2019, 11:24 AM

#

@glass pecan What should i do next , add a PR ?

glass pecan Dec 3, 2019, 11:25 AM

#

you just have to be patient sometimes, you only added it less than a day ago

#

no, the issue hasn't even been approved yet

crude gyro Dec 3, 2019, 11:26 AM

#

yeah I don't really have time to look at this atm

clever wraith Dec 3, 2019, 11:26 AM

#

ok will wait

clever wraith Dec 3, 2019, 12:56 PM

#

@glass pecan

#

there ?

glass pecan Dec 3, 2019, 12:57 PM

#

whats up?

clever wraith Dec 3, 2019, 12:58 PM

#

So i have several question and answers to the comment you did an hour ago

glass pecan Dec 3, 2019, 12:59 PM

#

then can you please address them in the ticket?

clever wraith Dec 3, 2019, 12:59 PM

#

can i do it here PLEASE

#

sweatcat

glass pecan Dec 3, 2019, 1:00 PM

#

if it's directly related to the ticket, no it's best to keep discussion about the feature itself within the issue so it's not lost and other contribs can reference it

#

if it's generally about contributing such as linting and such, then you can ask it here

clever wraith Dec 3, 2019, 4:47 PM

#

@green oriole there ?

green oriole Dec 3, 2019, 4:47 PM

#

Yep!

green oriole Dec 3, 2019, 5:02 PM

#

@clever wraith having the full project also imply some thing, for example using a config entry for emojis

clever wraith Dec 3, 2019, 5:03 PM

#

ok

#

lets try doing that

#

how to do that again

green oriole Dec 3, 2019, 5:03 PM

#

Setup it? There is the guide in the pin

#

https://gist.github.com/Akarys42/989dcfa41536c9f3b15c844ea4f04d72

#

The guide have just been written, if have any issue, ping me :)

#

You have to start by the site first, that's the bottom file

clever wraith Dec 3, 2019, 5:06 PM

#

Cloning a repository

#

m doing this

#

where to find this ?

#

📎 pycharm_checkout.png

green oriole Dec 3, 2019, 5:07 PM

#

Also if you spot any typo, that would be nice if you tell me about it :)

#

Yep this button

clever wraith Dec 3, 2019, 5:08 PM

#

where to find that

green oriole Dec 3, 2019, 5:08 PM

#

And then enter https://github.com/python-discord/site

clever wraith Dec 3, 2019, 5:08 PM

#

i took that pic from site

#

website

green oriole Dec 3, 2019, 5:08 PM

#

Oh yeah, tbh I would suggest you to go with command line :)

#

I think you need to close your currently opened project to make it appear

#

But I'm not a PyCharm pro

clever wraith Dec 3, 2019, 5:09 PM

#

downloading git

#

got my dad's hotspot , it speed time

#

17 KB/s

#

wtf with git website its too slow

green oriole Dec 3, 2019, 5:19 PM

#

Don't think that's git fault of you do 17KB/s

clever wraith Dec 3, 2019, 5:33 PM

#

it was

#

anyways

#

git installing

green oriole Dec 3, 2019, 5:34 PM

#

Nice!

clever wraith Dec 3, 2019, 5:35 PM

#

📎 unknown.png

#

oh it should be in git bash

#

got it

#

got it

green oriole Dec 3, 2019, 5:36 PM

#

You need to add it to the PATH

#

Not git bash

clever wraith Dec 3, 2019, 5:36 PM

#

📎 unknown.png

green oriole Dec 3, 2019, 5:37 PM

#

Why are you downloading kosa's fork 🙂

clever wraith Dec 3, 2019, 5:37 PM

#

F

green oriole Dec 3, 2019, 5:37 PM

#

You need to make you own fork and download it

clever wraith Dec 3, 2019, 5:37 PM

#

ahh

#

i never used git u know

green oriole Dec 3, 2019, 5:38 PM

#

I know I know, that's not a problem 😄

clever wraith Dec 3, 2019, 5:38 PM

#

📎 unknown.png

green oriole Dec 3, 2019, 5:39 PM

#

You can disable Windows Explorer Integrations and keep everything else

clever wraith Dec 3, 2019, 5:39 PM

#

now what

#

📎 unknown.png

green oriole Dec 3, 2019, 5:40 PM

#

Yep this one

clever wraith Dec 3, 2019, 5:40 PM

#

installing

#

git working now

#

cloning

#

done

#

creating venv

#

📎 unknown.png

green oriole Dec 3, 2019, 5:46 PM

#

You did pipenv sync --devright?

clever wraith Dec 3, 2019, 5:47 PM

#

yeah