#dev-contrib | Python | Page 33

mellow hare Oct 28, 2019, 3:21 PM

#

I feel like I've had it not do that properly before

green oriole Oct 28, 2019, 3:21 PM

#

If you change the line?

glass pecan Oct 28, 2019, 3:22 PM

#

yes, if you commit to the referenced lines the comment is on

#

it'll show as changed

#

if it's a suggested change, it'll autoresolve

#

if it's not, it may not resolve itself and need to be resolved by the PR author

green oriole Oct 28, 2019, 3:22 PM

#

Yeah but it show as outdated not as resolved

glass pecan Oct 28, 2019, 3:22 PM

#

yep, so you'd resolve it

green oriole Oct 28, 2019, 3:23 PM

#

Okay got it

glass pecan Oct 28, 2019, 3:23 PM

#

if the implementation though is different to the suggested change

#

i would probably not resolve it

#

really one should have discussed that though in the comments first

mellow hare Oct 28, 2019, 3:23 PM

#

Commenting on it and asking for a re-review of that line would be better

#

Or yeah, ideally discussing first

hardy gorge Oct 28, 2019, 3:24 PM

#

If I go with another solution that the reviewer submitted, I don't resolve the conversation, since the reviewer may want to look at it

#

The reviewer can then dismiss it or not depending on if they're satisfied with the change I've made

glass pecan Oct 28, 2019, 3:24 PM

#

but yeah if it's already committed but slightly different, comment saying so yes

#

resolving should only occur with exact suggested changes really

#

or simple pokes like this paragraph needs to be spellchecked

#

spellchecking is important notlikecryblob

molten bough Oct 28, 2019, 3:26 PM

#

I occasionally mark comments with tiny changes resolved as I make the changes locally

#

as in, before pushing

glass pecan Oct 28, 2019, 3:27 PM

#

i think that's fine. the main thing is so long as it's in the correct state by the time you rerequest a review, do whatever

molten bough Oct 28, 2019, 3:27 PM

#

That seems fair

glass pecan Oct 28, 2019, 3:27 PM

#

if you're mid-reviews though, avoid force pushing

#

that throws all the comments out of wack

#

and can be super annoying

molten bough Oct 28, 2019, 3:28 PM

#

oh god, yeah

#

I don't think I ever force push if I can avoid it

glass pecan Oct 28, 2019, 3:28 PM

#

yeah most do avoid it

#

i use it only when cleaning up before ready for review

#

once it's review, those commits stay

molten bough Oct 28, 2019, 3:29 PM

#

I pretty much only use it for murdering commits

glass pecan Oct 28, 2019, 3:29 PM

#

yep

molten bough Oct 28, 2019, 3:29 PM

#

like happened with the github allauth branch

#

I had like 3 commits and then the discussion changed to another idea

#

haha

glass pecan Oct 28, 2019, 3:29 PM

#

there technically is cases where it can be unavoidable too

molten bough Oct 28, 2019, 3:29 PM

#

that's true, yeah

glass pecan Oct 28, 2019, 3:29 PM

#

where multiple reverts maybe are way messier than a reset

#

or just general fookups

molten bough Oct 28, 2019, 3:30 PM

#

git nobodysawthat

glass pecan Oct 28, 2019, 3:30 PM

#

haha yeah

#

we did discuss these things though in the past, it's probably worth putting somewhere easy to find

#

contrib guide maybe

molten bough Oct 28, 2019, 3:31 PM

#

Yeah, maybe

glass pecan Oct 28, 2019, 3:40 PM

#

found what i was looking for. we discussed PR review guidelines back in July. I'll try get that going again to settle them and put them into public resources.

molten bough Oct 28, 2019, 3:40 PM

#

\o/ okay

glass pecan Oct 28, 2019, 3:43 PM

#

!remind 1d PR review guidelines.

stable mountainBOT Oct 28, 2019, 3:43 PM

#

Yeah okay.

Your reminder will arrive in 1 day!

hollow lichen Oct 28, 2019, 7:12 PM

#

err

📎 Screen_Shot_2019-10-28_at_20.12.26.png

#

Should be 15minutes instead of 1y3m

hardy gorge Oct 28, 2019, 7:13 PM

#

It uses the same naming conventions as Python's strftime

#

so m = months, M = minutes

hollow lichen Oct 28, 2019, 7:14 PM

#

oh

#

maybe say somewhere it does?

hardy gorge Oct 28, 2019, 7:15 PM

#

hmm

#

!help remind new

stable mountainBOT Oct 28, 2019, 7:15 PM

#

Command Help

!remind new <expiration> <content>
Can also use: add, create

*Set yourself a simple reminder.

Expiration is parsed per: http://strftime.org/*

#

Something about your input seems off. Check the arguments:

hollow lichen Oct 28, 2019, 7:17 PM

#

well I think most users use !remind instead of !remind new

green oriole Oct 28, 2019, 7:17 PM

#

New isn't mandatory

tawdry vapor Oct 28, 2019, 7:38 PM

#

!help remind

stable mountainBOT Oct 28, 2019, 7:38 PM

#

Command Help

!remind <expiration> <content>
Can also use: reminder, reminders

Commands for managing your reminders.

Subcommands:
delete <id_>
Delete one of your active reminders.
edit
Commands for modifying your current reminders.
list
View a paginated embed of all reminders for your user.
new <expiration> <content>
Set yourself a simple reminder.

tawdry vapor Oct 28, 2019, 7:38 PM

#

Would longer docstring be displayed here?

#

Or does it only capture the first line?

#

Anyway, I think "Expiration is parsed per: http://strftime.org/" is not detailed enough

#

The infraction commands outline the durations better so that could be copied over for reminders too

green oriole Oct 28, 2019, 7:39 PM

#

That the docstring of the converter

tawdry vapor Oct 28, 2019, 7:39 PM

#

Converter?

#

You mean the command group?

mellow hare Oct 28, 2019, 7:40 PM

#

That is interesting that it only shows that first line, though

tawdry vapor Oct 28, 2019, 7:41 PM

#

I don't know if it does that

#

I was asking

#

Maybe the docstring is only 1 line currently

mellow hare Oct 28, 2019, 7:41 PM

#

!help remind new

stable mountainBOT Oct 28, 2019, 7:41 PM

#

Command Help

!remind new <expiration> <content>
Can also use: add, create

*Set yourself a simple reminder.

Expiration is parsed per: http://strftime.org/*

mellow hare Oct 28, 2019, 7:41 PM

#

On the more specific command it'll show it all

#

But in the summary of all the available ones, only the first

tawdry vapor Oct 28, 2019, 7:42 PM

#

Ah sorry

#

I was talking about for the group

mellow hare Oct 28, 2019, 7:42 PM

#

Yeah, for the group it appears to only do the first line

tawdry vapor Oct 28, 2019, 7:42 PM

#

But in retrospect it would not make sense to place it there anyway

mellow hare Oct 28, 2019, 7:42 PM

#

Correct. It'd make the embed massive

tawdry vapor Oct 28, 2019, 7:42 PM

#

Well that and it'd only be relevant for one of the subcommands

mellow hare Oct 28, 2019, 7:43 PM

#

Right

#

!mute

stable mountainBOT Oct 28, 2019, 7:43 PM

#

Something about your input seems off. Check the arguments:

#

Command Help

!tempmute <user> <duration> [reason]
Can also use: mute

*Temporarily mute a user for the given reason and duration.

A unit of time should be appended to the duration.
Units (∗case-sensitive):
y - years
m - months∗
w - weeks
d - days
h - hours
M - minutes∗
s - seconds

Alternatively, an ISO 8601 timestamp can be provided for the duration.*

mellow hare Oct 28, 2019, 7:44 PM

#

Does it have the same parsing?

tawdry vapor Oct 28, 2019, 7:45 PM

#

Probably yes

green oriole Oct 28, 2019, 7:45 PM

#

Yep they use the same converter

mellow hare Oct 28, 2019, 7:46 PM

#

I... don't think it actually does

#

Hold on

#

Yeah, it's different

#

Reminders uses the bot.converters.Duration, where as the infractions uses dateutil.parser.isoparse(infraction["expires_at"]).replace(tzinfo=None)

#

Unless I'm over looking something

#

The infractions.py doesn't even import from bot.converters

tawdry vapor Oct 28, 2019, 7:53 PM

#

infractions definitely use the duration converter

#

it's probably under an alias

mellow hare Oct 28, 2019, 7:53 PM

#

I mean I'm looking at the file right now and unless it's going some arbitrary way to it, I'm not finding it

tawdry vapor Oct 28, 2019, 7:54 PM

#

I made a union of the duration and a timestamp converter I believe

#

https://github.com/python-discord/bot/blob/master/bot/cogs/moderation/utils.py#L30

GitHub

python-discord/bot

Source code for our Discord bot. Contribute to python-discord/bot development by creating an account on GitHub.

mellow hare Oct 28, 2019, 7:55 PM

#

Ahhhh, okay I see

#

It's in time

#

So it's likely that we never made the change to the reminder time conversion that we did with the infractions

hardy gorge Oct 28, 2019, 8:02 PM

#

We use the same converter for both, the Duration converter

#

For infractions, we just have the exact ISODate converter in addition to that

mellow hare Oct 28, 2019, 8:09 PM

#

Gotcha, my mistake

hollow lichen Oct 28, 2019, 8:33 PM

#

What about adding a warning when the time looks unusual ? for example 15m looks awkward, since it's 1y3m

tawdry vapor Oct 28, 2019, 8:46 PM

#

It shows the resulting time afterwards so I don't think that's necessary

#

If it's wrong you can go back and edit it

crude gyro Oct 28, 2019, 11:24 PM

#

@long garnet after that change, your PR fails to lint due to these problems:

#

./bot/cogs/site.py:6:1: F401 'bot.constants.Channels' imported but unused
./bot/cogs/site.py:6:1: F401 'bot.constants.STAFF_ROLES' imported but unused
./bot/cogs/site.py:7:1: F401 'bot.decorators.redirect_output' imported but unused

#

you might want to set up the pre-commit so that it won't let you commit until lint passes

long garnet Oct 28, 2019, 11:25 PM

#

hummm

#

I'm sorry, I admit I didn't check the documentation

#

for contributing

#

oh

crude gyro Oct 28, 2019, 11:26 PM

#

no problem. here's the relevant guide: https://pythondiscord.com/pages/contributing/bot/

Python Discord | Contributing to Bot

We're a large, friendly community focused around the Python programming language. Our community is open to those who wish to learn the language, as well as those looking to help others.

long garnet Oct 28, 2019, 11:26 PM

#

I read it wrong anyway

#

but I still should I guess

#

I'll fix it when I'm back, I don't have my actual editor here

long garnet Oct 29, 2019, 1:03 AM

#

I amended and force-pushed since it's just an unapproved PR

jade tiger Oct 29, 2019, 7:04 AM

#

📎 Screenshot_20191029-180358.png

#

Maybe I'm the only person who uses mobile, but to me this looks a bit yuck

#

Until discord fixes formatting for mobile do we need the bold link?
I don't see use for r/python below the link since it's in the webhook name
Is the /u/ necessary?

green oriole Oct 29, 2019, 8:41 AM

#

We are a lot that are on mobile, but do people really cares about #reddit?

hardy gorge Oct 29, 2019, 8:44 AM

#

I care about the features we have ¯_(ツ)_/¯

green oriole Oct 29, 2019, 8:52 AM

#

I mean, the day when there will be only one post per days of the most commented topic, I will care about it (I think I saw an issue about it) :)

hardy gorge Oct 29, 2019, 8:53 AM

#

That's not what I mean. Even if I'm not interested in the feature myself (although I do look at it personally), that's not an excuse for not caring about a feature we have in our projects.

#

If we think it's broken, we should fix it

green oriole Oct 29, 2019, 8:57 AM

#

Someone is already working on it I think

hardy gorge Oct 29, 2019, 8:57 AM

#

In this case, it's an easy fix, add the bolding inside of the link rather than outside

#

The feature has recently seen an update, these are the daily top posts instead of a daily feed

green oriole Oct 29, 2019, 8:59 AM

#

Oh yeah it has been already merged

#

So now I care about it :)

#

The words "upvote" and "comment" can also be replaced by emoji

#

And the r/python was because the reddit cog is configurable

crude gyro Oct 29, 2019, 9:08 AM

#

I think upvote and comment emojis, fixing the bolded URLs (like ves said, it's just a matter of placing the asterisk in the right places and it will look fine on mobile), the u/ before the username and whether or not we need to have the subreddit there are all things that could be interesting.

#

I wouldn't mind if someone wanted to work on making that presentation a bit better

hardy gorge Oct 29, 2019, 9:09 AM

#

The r/python is already in the Webhook name, I think we can remove that.

crude gyro Oct 29, 2019, 9:09 AM

#

text separated by pipes isn't exactly very hot

hardy gorge Oct 29, 2019, 9:09 AM

#

I'm working on it, I want to do something mindless for a minute

crude gyro Oct 29, 2019, 9:09 AM

#

good

#

maybe lift upvote and comment graphics straight from reddit?

#

and then stick'em on an emoji server?

hardy gorge Oct 29, 2019, 9:12 AM

#

I think reddit has a comment icon in the redesign, not sure about the copyright on that one

#

maybe fontawesome has great analogues

#

Someone of us has that font pack

crude gyro Oct 29, 2019, 9:14 AM

#

I'm thinking more like

instead of | 16 upvotes | 10 comments | u/funlovingdadguy | r/python we could maybe do something like

upvote 16 🗨 10 🙎 funlovingdadguy

except with the right emojis.

#

probably needs a bit of workshopping

#

and might look better on 3 lines

#

but maybe not

gusty sonnet Oct 29, 2019, 9:15 AM

#

Hmm, if we are talking about footer you can't use custom emoji there

crude gyro Oct 29, 2019, 9:15 AM

#

reddit has these muted gray icons

#

probably not talking footer, it's not a footer currently I think?

#

📎 unknown.png

gusty sonnet Oct 29, 2019, 9:16 AM

#

Ah yes it is not footer atm

crude gyro Oct 29, 2019, 9:16 AM

#

📎 unknown.png

#

I'm saying essentially we do these icons, with their respective data, I'm sure we can make that look good.

#

anyway, just a thought

#

ves is on the job so I'm sure it'll be good.

#

ves never half asses anything.

hardy gorge Oct 29, 2019, 9:17 AM

#

It's not a footer, because we have multiple posts in one embed

crude gyro Oct 29, 2019, 9:17 AM

#

yeah that makes the sense.

#

anyway, I gotta run a bit. bbl.

hardy gorge Oct 29, 2019, 9:22 AM

#

Oh, right, those icons are from the redesign of reddit

jade tiger Oct 29, 2019, 10:16 AM

#

also not sure about the copyright on reddit logos but while we're throwing ideas out i think it might look nicer with a reddit icon in the username (I'm not sure if this should be a code thing or just changing it in the webhook settings, I think I mentioned it in PR but nothing ever happened)

📎 reddit-logo.png

crude gyro Oct 29, 2019, 10:17 AM

#

pretty sure using these logos and icons to literally link reddit posts is absolutely within allowed use.

#

I agree, by the way, that might be a nice improvement too. @hardy gorge, maybe you wanna include that in your PR

jade tiger Oct 29, 2019, 10:19 AM

#

👍

hardy gorge Oct 29, 2019, 10:24 AM

#

@crude gyro I think we should just set it as the Webhook's default avatar. In fact, done.

crude gyro Oct 29, 2019, 10:31 AM

#

yep cool

hardy gorge Oct 29, 2019, 11:05 AM

#

Can't get it quite right. Feedback would be welcome.

📎 reddit_embed.png

jade tiger Oct 29, 2019, 11:09 AM

#

I like that

#

Not sure how it would look on mobile, but miles better than now already. What does it look like with user on a newline?

hardy gorge Oct 29, 2019, 11:10 AM

#

below or above the upvotes/comments

#

above

📎 above.png

#

below

📎 below.png

#

I'm not sure if I like that

tranquil topaz Oct 29, 2019, 11:12 AM

#

i like em on one line..

#

well.. the username could get very long.. whats the limit?

hardy gorge Oct 29, 2019, 11:13 AM

#

It used to be 20 chars, but I'm not sure if that still holds

molten bough Oct 29, 2019, 11:14 AM

#

I like 'em below honestly

#

Potentially better on mobile too since you shouldn't ever have the user icon on a different line to the username

hardy gorge Oct 29, 2019, 11:18 AM

#

Another option to make that unlikely would be to dump the word "comments"

#

📎 2019-10-29_12-19.png

molten bough Oct 29, 2019, 11:22 AM

#

I don't hate that but the alignment is annoying me

#

But doing a code block like 001 is probably a bad idea too

hardy gorge Oct 29, 2019, 11:23 AM

#

Think the alignment is something we need to work with; we don't have much control over it

molten bough Oct 29, 2019, 11:24 AM

#

Yeah, you're right

tranquil topaz Oct 29, 2019, 11:24 AM

#

i like the later version. with all in one line and just icons.

#

people get emojis 😄

molten bough Oct 29, 2019, 11:25 AM

#

It's definitely better I think :>

tranquil topaz Oct 29, 2019, 11:25 AM

#

why do we not have control over alignment Ves?

#

cant we add whitespace?

hardy gorge Oct 29, 2019, 11:26 AM

#

There are some unicode whitespace characters we could use, but it's just text + emojis in a non-fixed width font

#

I'm not even sure how to even try to align it

brazen charm Oct 29, 2019, 11:29 AM

#

Can't think of a proper way without calculating the spacing from the font

gusty sonnet Oct 29, 2019, 11:30 AM

#

Hmm, removing text? Like removing that comments text

#

Yeah I like the removed version

tranquil topaz Oct 29, 2019, 11:31 AM

#

I might have a few ideas, but not sure how i could replicate the problem.

hardy gorge Oct 29, 2019, 11:31 AM

#

I don't think we are going to get it consistent across devices anyway

tranquil topaz Oct 29, 2019, 11:32 AM

#

well.. it uses web-tech. so im thinking to use tab. not sure if that works though

hardy gorge Oct 29, 2019, 11:37 AM

#

This is with tab characters; they appear as a single space, but are still there if you inspect the raw embed.

📎 2019-10-29_12-37.png

tranquil topaz Oct 29, 2019, 11:38 AM

#

how useless

crude gyro Oct 29, 2019, 11:41 AM

#

I don't think that looks very bad.

#

I do wish we could align all the user icons and stuff like that but it's probably impossible to pull off.

tranquil topaz Oct 29, 2019, 11:42 AM

#

can you embed it in a codeblock?

crude gyro Oct 29, 2019, 11:42 AM

#

can't put emojis in a code block

tranquil topaz Oct 29, 2019, 11:42 AM

#

guess you loose links that way

#

and that as well..

crude gyro Oct 29, 2019, 11:42 AM

#

@hardy gorge imo it's probably as good as it gets, and a huge step in the right direction compared to how it looks today.

hardy gorge Oct 29, 2019, 11:43 AM

#

The only thing you can do is what @molten bough suggested, put the numbers in a codeblock between the icons

#

I can try, but I'm not sure how that will look

molten bough Oct 29, 2019, 11:43 AM

#

Yep, short of finding weird unicode, that's all I can think of

crude gyro Oct 29, 2019, 11:44 AM

#

I can think of one highly creative way

#

nope

#

never mind

#

yeah no I think it looks pretty decent though

hardy gorge Oct 29, 2019, 11:46 AM

#

Inline codeblocks won't work

#

It will strip whitespace inside of them within embeds

#

!embed 1 + 33 = 44

stable mountainBOT Oct 29, 2019, 11:47 AM

#

1 + 33 = 44

hardy gorge Oct 29, 2019, 11:47 AM

#

Okay, I think this is as good as it gets

hardy gorge Oct 29, 2019, 1:02 PM

#

https://github.com/python-discord/bot/pull/635

GitHub

Enhance Reddit webhook embeds by SebastiaanZ · Pull Request #635 ...

I have made some visual changes to the embed generated for the Reddit webhook. The changes I've made boil down to:

Moved bold markdown to outside of the link markdown to prevent breakage ...

crude gyro Oct 29, 2019, 1:05 PM

#

that's hot

mellow hare Oct 29, 2019, 1:06 PM

#

https://tenor.com/rwPF.gif

Tenor

so hot right now

▶ Play video

exotic ember Oct 29, 2019, 1:17 PM

#

!reddit daily

stable mountainBOT Oct 29, 2019, 1:17 PM

#

Here are today's top r/Python posts!

Flask Webserver for Google Poly models in AR
upvotes 18 comments 4 user professormunchies

Do you use virtualenv often? I think I might be OVERdoing it.
I create a virtualenv for every single project I start. I like the idea of having a python installation completely isolated...
upvotes 15 comments 36 user I_AM_ALWAYS_ANGRY

Mentoring in programming
Hi fellow programmers, if you're interested in being (obviously totally free) mentored in any programming language or...
upvotes 7 comments 4 user GCProgrammer

I half-scientifically calculated that "r" is indeed the most...
upvotes 6 comments 0 user i-am-qix

Python 3.5.8 final is finally out!
upvotes 5 comments 1 user ExoticMandibles

molten bough Oct 29, 2019, 1:20 PM

#

Very nice

hardy gorge Oct 29, 2019, 1:20 PM

#

Okay, there's a complication

#

📎 2019-10-29_14-20.png

molten bough Oct 29, 2019, 1:21 PM

#

Webhook can't use custom emotes? Hrm

hardy gorge Oct 29, 2019, 1:21 PM

#

They probably can, just bot those added to other servers I think

molten bough Oct 29, 2019, 1:22 PM

#

I guess that makes sense when you think about it

hardy gorge Oct 29, 2019, 1:22 PM

#

Yes, I'll try it with "local" emojis manually to see if it works

#

No, I know that works, because I tested that on the test server

#

Okay

#

We have enough emoji slots here for these three

#

Okay, that fixed it for now.

📎 2019-10-29_14-36.png

molten bough Oct 29, 2019, 1:38 PM

#

Sweet

hollow lichen Oct 29, 2019, 1:39 PM

#

nice!

molten bough Oct 29, 2019, 1:41 PM

#

Would there be any interest in a PR to simple-bulma to add support for buefy?

#

I'm likely gonna need it in a project anyway, it's basically a combination of bulma and vue.js

#

as it adds components though, it'd have to be a separate "mode"

hardy gorge Oct 29, 2019, 1:42 PM

#

@crude gyro You're probably the only one who can say something useful about this

molten bough Oct 29, 2019, 1:44 PM

#

I'd be fine with doing a separate project as well if not

#

probably fork it to comect and handle the lifecycle myself

crude gyro Oct 29, 2019, 1:49 PM

#

iunno, it might sound a bit out of scope

molten bough Oct 29, 2019, 1:49 PM

#

I could see that, yeah

crude gyro Oct 29, 2019, 1:49 PM

#

although the stack is interesting

#

I'm a bit confused as to how this "mode" would work

#

wanna elaborate?

molten bough Oct 29, 2019, 1:50 PM

#

Essentially buefy is a fork of bulma

#

it provides its own sass and a whole bunch of JS, of course

#

it also covers a bunch of stuff we use extensions for, like toggles

crude gyro Oct 29, 2019, 1:51 PM

#

sounds like a lot of code then

molten bough Oct 29, 2019, 1:51 PM

#

so I call it a "mode" because it would need to provide those assets instead

#

yeah, it could well be

crude gyro Oct 29, 2019, 1:51 PM

#

maybe you should just do a django-simple-buefy :P

molten bough Oct 29, 2019, 1:51 PM

#

Haha, yeah, that might be the best idea

#

I have nothing against that anyway

mellow hare Oct 29, 2019, 1:52 PM

#

How do you even pronounce buefy

molten bough Oct 29, 2019, 1:52 PM

#

bew-fee

crude gyro Oct 29, 2019, 1:52 PM

#

wat

molten bough Oct 29, 2019, 1:52 PM

#

vue -> bue

#

bew-fee

crude gyro Oct 29, 2019, 1:52 PM

#

how would you possibly pronounce it like that

mellow hare Oct 29, 2019, 1:52 PM

#

No

#

Well wait

molten bough Oct 29, 2019, 1:53 PM

#

bway-fay if you're french?

#

I dunno

mellow hare Oct 29, 2019, 1:53 PM

#

Well actually, if dew and due are said the same....

molten bough Oct 29, 2019, 1:53 PM

#

and vue is said "view"

mellow hare Oct 29, 2019, 1:53 PM

#

Okay, fair enough

crude gyro Oct 29, 2019, 1:53 PM

#

Buefy (pronounced /ˈbyo͞oˌfī/, like beau-fy)

molten bough Oct 29, 2019, 1:53 PM

#

I mean unless you'd say that "voo" I guess

crude gyro Oct 29, 2019, 1:53 PM

#

okay, I guess so

molten bough Oct 29, 2019, 1:54 PM

#

that's like bow-fy

#

well that's not too far

mellow hare Oct 29, 2019, 1:54 PM

#

I think deep down I was hoping for beefy

molten bough Oct 29, 2019, 1:54 PM

#

haha

crude gyro Oct 29, 2019, 1:54 PM

#

I was reading it bew-eh-fy

#

as in beautify without the t

molten bough Oct 29, 2019, 1:54 PM

#

that's interesting

mellow hare Oct 29, 2019, 1:54 PM

#

I could see that

molten bough Oct 29, 2019, 1:54 PM

#

I'll give you that

#

oh good my 188 updates are ready to install

mellow hare Oct 29, 2019, 1:55 PM

#

The joy of the Manjaro update dump

crude gyro Oct 29, 2019, 1:55 PM

#

bedazzle your website with buefy

molten bough Oct 29, 2019, 1:55 PM

#

hahaha

#

I like that

mellow hare Oct 29, 2019, 1:55 PM

#

Bedazzle your website with Beefy

#

I'm going to make it a thing

crude gyro Oct 29, 2019, 1:55 PM

#

bueefy

mellow hare Oct 29, 2019, 1:55 PM

#

Yeeesssssss

hardy gorge Oct 29, 2019, 1:56 PM

#

https://tenor.com/view/nbc-the-good-place-fork-gif-9684994

Tenor

molten bough Oct 29, 2019, 3:41 PM

#

That wasn't as hard as I thought it'd be

mellow hare Oct 29, 2019, 3:42 PM

#

https://tenor.com/vd82.gif

Tenor

molten bough Oct 29, 2019, 3:43 PM

#

Haha

stable mountainBOT Oct 29, 2019, 3:43 PM

#

@glass pecan

It has arrived!

Here's your reminder: PR review guidelines..
Jump back to when you created the reminder

green oriole Oct 29, 2019, 4:27 PM

#

So guys what you want me to do for this one? https://github.com/python-discord/site/pull/303

GitHub

Show attachments in staff log by Akarys42 · Pull Request #303 · ...

Hi, this PR show the attachments along with the original message in staff logs (https://staff.pythondiscord.com/bot/logs/...). python-discord/bot#630 need to be merged after this one for the featur...

patent pivot Oct 30, 2019, 12:06 AM

#

📎 unknown.png

glass pecan Oct 30, 2019, 12:07 AM

#

links?

patent pivot Oct 30, 2019, 12:07 AM

#

https://github.com/features/actions
https://github.com/features/package-registry

glass pecan Oct 30, 2019, 12:07 AM

#

thanks

#

no pricing present on the actions one

patent pivot Oct 30, 2019, 12:08 AM

#

nor on the package registry for us

glass pecan Oct 30, 2019, 12:08 AM

#

nvm

patent pivot Oct 30, 2019, 12:08 AM

#

we are open source

glass pecan Oct 30, 2019, 12:08 AM

#

its at the bottom

patent pivot Oct 30, 2019, 12:08 AM

#

ah yeah

#

though

glass pecan Oct 30, 2019, 12:08 AM

#

not too bad

patent pivot Oct 30, 2019, 12:08 AM

#

that is under privatet repos right?

glass pecan Oct 30, 2019, 12:08 AM

#

2k minutes a month on private

#

yeah

patent pivot Oct 30, 2019, 12:08 AM

#

right okay

glass pecan Oct 30, 2019, 12:08 AM

#

free for oss

patent pivot Oct 30, 2019, 12:08 AM

#

so public is all free

#

nice

glass pecan Oct 30, 2019, 12:09 AM

#

selfhosted: coming soon pithink

patent pivot Oct 30, 2019, 12:09 AM

#

yeah that'll be nice

#

compete with gitlab for sure

glass pecan Oct 30, 2019, 12:09 AM

#

that's just their runners

patent pivot Oct 30, 2019, 12:09 AM

#

yeah

#

i meant gitlab ci

glass pecan Oct 30, 2019, 12:09 AM

#

i wonder though if gh would do selfhosting though

#

probs not

patent pivot Oct 30, 2019, 12:09 AM

#

i mean

#

enterprise

glass pecan Oct 30, 2019, 12:09 AM

#

it's not hosted?

patent pivot Oct 30, 2019, 12:10 AM

#

no

#

can be

glass pecan Oct 30, 2019, 12:10 AM

#

huh

patent pivot Oct 30, 2019, 12:10 AM

#

📎 unknown.png

glass pecan Oct 30, 2019, 12:10 AM

#

nice

#

makes sense i guess

#

gotta get those contracts

patent pivot Oct 30, 2019, 12:10 AM

#

indeed indeed

#

we could put our docker containers on github package registry

glass pecan Oct 30, 2019, 12:10 AM

#

glad they're keeping oss free entirely though

patent pivot Oct 30, 2019, 12:11 AM

#

i haven't figured out why we would do it yet but we could do it

glass pecan Oct 30, 2019, 12:11 AM

#

well

#

we technically don't need the dockers hosted publicly

molten bough Oct 30, 2019, 12:11 AM

#

Snekbox is a handy one to have a public container for to be fair

glass pecan Oct 30, 2019, 12:11 AM

#

so even if gh was an option, it's not likely any different from dockerhub

patent pivot Oct 30, 2019, 12:12 AM

#

hm

#

one thought is

#

might be nicer if we switch to actions ever to go down the all-on-github route

glass pecan Oct 30, 2019, 12:12 AM

#

yeah it's not bad

#

i use it elsewhere

#

it's not as ... what's the word

#

familiar i guess as azure atm

#

also a lot of helper tasks just don't exist in gh actions

molten bough Oct 30, 2019, 12:13 AM

#

I have a feeling it isn't quite as all encompassing, yeah

glass pecan Oct 30, 2019, 12:13 AM

#

but i guess that just comes from being so green

#

gh actions does get the benefit of being able to reference formulas other people made though

molten bough Oct 30, 2019, 12:14 AM

#

Azure does have that too

#

I imagine it's easier to write tasks for Actions though

glass pecan Oct 30, 2019, 12:14 AM

#

mm maybe

patent pivot Oct 30, 2019, 12:14 AM

#

they switched to json syntax now didn't they

glass pecan Oct 30, 2019, 12:15 AM

#

yeah

#

or rather yml

patent pivot Oct 30, 2019, 12:15 AM

#

ah yeah

#

that's the one

glass pecan Oct 30, 2019, 12:15 AM

#

json works

#

only due to being a subset

#

lol

molten bough Oct 30, 2019, 12:15 AM

#

You'd sure hope it wasn't json only..

patent pivot Oct 30, 2019, 12:15 AM

#

lol

glass pecan Oct 30, 2019, 12:15 AM

#

to be fair, i do love the readability of yml

#

it's also become super familiar to use

molten bough Oct 30, 2019, 12:16 AM

#

It feels more designed for humans than a lot of stuff

patent pivot Oct 30, 2019, 12:16 AM

#

yeah i like yaml

glass pecan Oct 30, 2019, 12:16 AM

#

i'm not a fan of some things, like their terminology for things

molten bough Oct 30, 2019, 12:16 AM

#

I mean the standard for that was INI at one point

#

And man is configparser garbage

glass pecan Oct 30, 2019, 12:16 AM

#

thankfully ini is usurped by toml now

#

which is a much better thing to use

molten bough Oct 30, 2019, 12:16 AM

#

Yeah, although I only ever see it used for build tools

#

And sponge plugins, I suppose

glass pecan Oct 30, 2019, 12:17 AM

#

linting

#

honestly linting settings was like the first time i ever seen it

patent pivot Oct 30, 2019, 12:17 AM

#

oh i like toml as well forgot about that one

molten bough Oct 30, 2019, 12:17 AM

#

Pipfile is toml but you barely should ever touch it

glass pecan Oct 30, 2019, 12:17 AM

#

yeah

patent pivot Oct 30, 2019, 12:17 AM

#

rust uses toml

glass pecan Oct 30, 2019, 12:18 AM

#

yeah iirc pyproject was inspired by rusts usage of it

#

would be nice if more things supported pyproject

#

technically anything that's already toml styled you can append to the end of pyproject and it'll work fine

#

but it's kinda .. not dodgy/hacky

#

just kinda unclean

#

because it's not following the actual pyproject syntax

#

so instead of doing ```toml
[tools.flake8]
blah = foo

you'd just put
```toml
[flake8]
blah = foo

just the same as normal configs for it

#

and then point flake8 to process pyproject.toml as the config file

#

@molten bough you use salt right?

molten bough Oct 30, 2019, 12:22 AM

#

Yup

glass pecan Oct 30, 2019, 12:22 AM

#

do you also use nginx

molten bough Oct 30, 2019, 12:22 AM

#

Yup!

glass pecan Oct 30, 2019, 12:22 AM

#

do you manage your sites-available via salt

molten bough Oct 30, 2019, 12:22 AM

#

Yup!!

#

Well, sites-enabled

#

I never bother with sites-available

glass pecan Oct 30, 2019, 12:23 AM

#

ah right

#

makes sense actually

#

we do use sites-available

#

i've got it sorted atm

#

but i was trying to think of a way to cleanup dangling symlinks in sites-enabled

molten bough Oct 30, 2019, 12:24 AM

#

I don't really see the point when you're already managing everything via salt

#

If you're not doing that, well.. Never too late!

glass pecan Oct 30, 2019, 12:24 AM

#

it's managed via salt, yeah

molten bough Oct 30, 2019, 12:24 AM

#

All my nginx configs are in the same git repo as my salt states

#

So it's just a case of copy over and reload if changed

#

But it doesn't handle removing them right now because I just didn't take the time to do that

glass pecan Oct 30, 2019, 12:25 AM

#

right, nah i've got the removals set for available

#

cleanup sites available:
  file.directory:
    - name: /etc/nginx/sites-available
    - clean: true

#

and the nginx configs are file.managed

#

with ```yml
- require_in:
- cleanup sites available

molten bough Oct 30, 2019, 12:26 AM

#

Mine are just file.recurse

#

Although I wrote all this stuff when I was still just learning salt

#

I still get confused trying to navigate the mess of docs..

glass pecan Oct 30, 2019, 12:26 AM

#

i could technically skip the symlinks

#

and just change the above to enabled

#

not 100% sure what i'd lose by doing so

molten bough Oct 30, 2019, 12:27 AM

#

Tbh even when doing it myself I still don't use sites-available

#

If I did I wouldn't symlink it

#

Primarily because mv is easier to remember the argument order for

#

Haha

glass pecan Oct 30, 2019, 12:31 AM

#

as far as i can see it's only useful if you want to be able to preserve configs while disabling individual sites

#

our configs are generated

#

that's not a problem for us

molten bough Oct 30, 2019, 12:32 AM

#

Even better

#

Mine are not, I should totally do it though since I have like 30 of them

glass pecan Oct 30, 2019, 12:33 AM

#

that's actually what i've been working on for the past two days

#

altering our nginx config generation

#

testing changes to salt is painful

#

even more fun is preserving correct yml whitespace with a ton of jinja in between things

#

worked out ok in the end i think

molten bough Oct 30, 2019, 12:34 AM

#

I'm sure you managed it amicably

glass pecan Oct 30, 2019, 12:35 AM

#

too much swearing involved to use that word

molten bough Oct 30, 2019, 12:38 AM

#

Haha

#

All my salt stuff is here anyway in case there's anything you might want to look at https://gitlab.com/gserv.me/salt/

GitLab

gserv.me / salt

Saltstack files for orchestration

#

It's likely way more basic than yours though

#

It's late anyway so I'm gonna head off

#

o/ for now

glass pecan Oct 30, 2019, 12:39 AM

#

thanks, catcha

crude gyro Oct 30, 2019, 11:07 AM

#

@molten bough we're working on it

#

ref meta.

molten bough Oct 30, 2019, 11:07 AM

#

Fair, fair

#

I can see why you'd want to do it

crude gyro Oct 30, 2019, 11:07 AM

#

removed your message because it sort of exposes a way to circumvent filters

molten bough Oct 30, 2019, 11:07 AM

#

Aha, okay

#

I did the same thing for the ProtocolSupport server RE JAR files

#

Have you had a lot of instances of people posting stuff they shouldn't, by the way?

#

Must be more common here than most places with the size

glass pecan Oct 30, 2019, 11:09 AM

#

not a ton, but there's been the rare occasion and recently someone posted a malicious exe

molten bough Oct 30, 2019, 11:09 AM

#

Yikes

glass pecan Oct 30, 2019, 11:09 AM

#

yeah, they were banned

#

it was found really quickly ofc

#

and then our lovely people added the filter

molten bough Oct 30, 2019, 11:10 AM

#

nods

#

wonder if they were trying to exploit that recent Discord issue

#

Discord can't fix that by the way, Squirrel updater doesn't support installation as admin

glass pecan Oct 30, 2019, 11:11 AM

#

nah, they just wanted to share what they made for some reason

molten bough Oct 30, 2019, 11:11 AM

#

Huh, okay

glass pecan Oct 30, 2019, 11:11 AM

#

iirc they actually said what it does

#

doesn't make it good

molten bough Oct 30, 2019, 11:11 AM

#

well that was.. smart..

#

haha

#

Anyway, all good, makes sense to have a filter I think

crude gyro Oct 30, 2019, 11:12 AM

#

was something like a forkbomb?

glass pecan Oct 30, 2019, 11:12 AM

#

yeah

#

i always mix up terms

#

forkbomb was it though

molten bough Oct 30, 2019, 11:12 AM

#

well, we know all about the dangers of forkbombs here

crude gyro Oct 30, 2019, 11:13 AM

#

the topic over on #the-pydis-mass-layoffs-lounge still says ABSOLUTELY NO FORKBOMBS

molten bough Oct 30, 2019, 11:13 AM

#

haha

hardy gorge Oct 30, 2019, 11:13 AM

#

It was a forkbomb!

crude gyro Oct 30, 2019, 11:13 AM

#

!otn a absolutely-no-forkbombs

stable mountainBOT Oct 30, 2019, 11:13 AM

#

:ok_hand: Added absolutely-no-forkbombs to the names list.

molten bough Oct 30, 2019, 11:13 AM

#

the legacy lives on

glass pecan Oct 30, 2019, 11:13 AM

#

what's the story?

hardy gorge Oct 30, 2019, 11:13 AM

#

A silly one. Once we removed the .exe. they just posted the sourcecode and urged people to use it to prank others

molten bough Oct 30, 2019, 11:13 AM

#

someone posted a link to a PHP shell they were running on their server

#

and said "BREAK IT IF YOU CAN"

#

so I broke it

glass pecan Oct 30, 2019, 11:13 AM

#

oh

#

that seems silly

#

especially considering it's php

#

which has the security level of a wet paper towel

molten bough Oct 30, 2019, 11:14 AM

#

it was like, a web shell, you could run anything you wanted on the host

hardy gorge Oct 30, 2019, 11:14 AM

#

php = pretty hostile (to) programmers

molten bough Oct 30, 2019, 11:14 AM

#

no auth

crude gyro Oct 30, 2019, 11:14 AM

#

gdude forkbombed a user and the staff got upset because owners probably shouldn't be forkbombing members of the server, even if they were begging for it.

molten bough Oct 30, 2019, 11:14 AM

#

yeah, which is fair enough

#

think it got him banned from the host, actually

crude gyro Oct 30, 2019, 11:14 AM

#

so g had to apologize for his forkbombage

#

and I changed the topic of staff-lounge to match

hardy gorge Oct 30, 2019, 11:15 AM

#

People are still trying to break snekbox, but I haven't really seen much creativity there

crude gyro Oct 30, 2019, 11:15 AM

#

forkbombing snekbox wouldn't work anyway

#

it kills the shell after a few seconds

glass pecan Oct 30, 2019, 11:15 AM

#

kinda reminds me of the dude who didn't sanitise a bot command, the arg was handed directly as is to shell execution. turns out the bot was running on root and someone did a rm -R

molten bough Oct 30, 2019, 11:15 AM

#

can't spawn processes anyway

hardy gorge Oct 30, 2019, 11:15 AM

#

It would not, you can't open other processes

#

yeah

molten bough Oct 30, 2019, 11:15 AM

#

Oh yeah, I remember that one scrags

glass pecan Oct 30, 2019, 11:16 AM

#

yeah, i think i shared the screenshots

#

was a bit of a giggle

molten bough Oct 30, 2019, 11:16 AM

#

I wonder if there's any kernel that has forkbomb protection

#

well, anyway, yeah

hollow lichen Oct 30, 2019, 11:36 AM

#

What's a fork bomb btw?

hardy gorge Oct 30, 2019, 11:37 AM

#

It's basically a self-replicating process

#

Because it self-replicates and all those replicants start replicating too, it gets out of hand real quick

#

The term comes from the line diagram you make

#

It looks like a fork

#

https://upload.wikimedia.org/wikipedia/commons/thumb/5/52/Fork_bomb.svg/300px-Fork_bomb.svg.png

#

if you draw it with sharp lines, you'd get a fork shape

hollow lichen Oct 30, 2019, 11:39 AM

#

Ah... I was thinking of forks on Github ^^

molten bough Oct 30, 2019, 11:39 AM

#

Oh, I thought it was called that because you're forking processes, like, os.fork

crude gyro Oct 30, 2019, 11:41 AM

#

it's actually named after the blink 182 song

hardy gorge Oct 30, 2019, 11:41 AM

#

yes

crude gyro Oct 30, 2019, 11:41 AM

#

not many people know this.

hardy gorge Oct 30, 2019, 11:41 AM

#

but I suspect the name of creating a fork comes from the diagrams you draw to represent that.

#

but, I may be wrong, but that's what I read as the origin for both

#

https://ieeexplore.ieee.org/mediastore_new/IEEE/content/media/85/7548977/7548985/7548985-fig-1-source-large.gif

#

That's the original diagram that inspired the name, I think, in a 1963 paper

#

So, the process "forks" into two and it looks like a fork

crude gyro Oct 30, 2019, 11:43 AM

#

yeah but. the word fork has meant to split somehting into two for like hundreds of years before that.

#

so I don't know if I buy that etymology

hardy gorge Oct 30, 2019, 11:43 AM

#

ahh

hollow lichen Oct 30, 2019, 11:43 AM

#

It only replicates itself? Messy but useless, isn't it?

crude gyro Oct 30, 2019, 11:43 AM

#

it's not useless

#

it'll usually crash whatever you let it loose on

hollow lichen Oct 30, 2019, 11:43 AM

#

At some point I suspect it crashs the computer

crude gyro Oct 30, 2019, 11:43 AM

#

because there are suddenly thousands or millions or processes running

#

yes

#

even if they're not doing much, no system can handle exponentially more process creations

hardy gorge Oct 30, 2019, 11:44 AM

#

It seems to come from the tool, but why the tool was called that way, I can't find

#

https://en.wiktionary.org/wiki/furca#Latin

furca

#

Anyway, latin etymology is probably off-topic for this channel

#

the name fork above probably comes from the "split into two"-meaning, not the shape of the diagram

green oriole Oct 30, 2019, 11:47 AM

#

OS aren't protected against forkbombs?

molten bough Oct 30, 2019, 11:48 AM

#

Wouldn't think so

#

maybe some AVs detect it

green oriole Oct 30, 2019, 11:49 AM

#

Hmm..

#

No you can protect your OS

molten bough Oct 30, 2019, 11:49 AM

#

it's effective but it's also a really shitty thing to do

green oriole Oct 30, 2019, 11:50 AM

#

You can easily limit the amount of processes that can be spawned in Ubuntu and most other Linux distributions by modifying /etc/security/limits.conf

#

Doesn't seem too complex

molten bough Oct 30, 2019, 11:50 AM

#

yes, but then you can't start any more processes

green oriole Oct 30, 2019, 11:51 AM

#

I guess superuser process override this restriction

#

I hope at least

hollow lichen Oct 30, 2019, 12:45 PM

#

Ty for all the infos on forkbombs ~~I'll try now~~

molten bough Oct 30, 2019, 12:45 PM

#

ABSOLUTELY NO FORKBOMBS

#

:>

mellow hare Oct 30, 2019, 1:11 PM

#

Inside joke noticed and acknowledged. Chuckle protocol initiated.

molten bough Oct 30, 2019, 1:12 PM

#

haha, well it's no longer an inside joke, I guess, explained above

mellow hare Oct 30, 2019, 1:19 PM

#

Inside reference then

#

Since I think that's still the channel description

molten bough Oct 30, 2019, 1:19 PM

#

Yeah, lemon said it was earlier

#

:>

mellow hare Oct 30, 2019, 1:19 PM

#

Well then

molten bough Oct 30, 2019, 1:19 PM

#

legacy lives on

exotic ember Oct 30, 2019, 1:58 PM

#

how would I test (I'm guessing I need mocks here) code that retrieves stuff from the web?

molten bough Oct 30, 2019, 1:59 PM

#

I would say mocks, yeah

#

It depends on the context though

exotic ember Oct 30, 2019, 2:01 PM

#

coughs totally not basing this question off this issue I claimed but now can't do..
if there is a function that gets something from the web > deal with response checking/error handling > builds a representation of the stuff gotten from the web all in one function, the way to go with unittesting would be to break up that function then test each part separately?

crude gyro Oct 30, 2019, 2:02 PM

#

yes.

#

at work we have a nice library for mocking responses but it only works specifically with requests

#

https://github.com/getsentry/responses

GitHub

getsentry/responses

A utility for mocking out the Python Requests library. - getsentry/responses

molten bough Oct 30, 2019, 2:03 PM

#

oh, of course sentry has that, haha

#

very nice

#

Yeah, break up the function if it makes sense, and mock out the library calls

crude gyro Oct 30, 2019, 2:03 PM

#

being able to structure it as a context manager is particularly nice

molten bough Oct 30, 2019, 2:04 PM

#

You can do that with the stdlib mock as well

#

super nice

crude gyro Oct 30, 2019, 2:05 PM

#

I wouldn't mind if we wrote a nice aiohttp requestmock thing that we can use for this so we don't have to do it the hard way every time, by the way kosa.

molten bough Oct 30, 2019, 2:05 PM

#

something like this? https://github.com/pnuckowski/aioresponses

GitHub

pnuckowski/aioresponses

Aioresponses is a helper for mock/fake web requests in python aiohttp package. - pnuckowski/aioresponses

crude gyro Oct 30, 2019, 2:05 PM

#

just something that makes it as trivial as creating an instance, feeding that instance the endpoint url and the response you want, and then using the instance as a context manager.

#

hm, yeah, that looks promising

hardy gorge Oct 30, 2019, 2:10 PM

#

We rarely talk to aiohttp directly in our codebase, though. We usually use the bot.api_client.method, which is easily mockable with a return_value

crude gyro Oct 30, 2019, 2:10 PM

#

ah, that's true.

mellow hare Oct 30, 2019, 2:10 PM

#

Yeah most of that communication is handled within discord.py

hardy gorge Oct 30, 2019, 2:10 PM

#

No, we're talking about our requests to our own api

mellow hare Oct 30, 2019, 2:10 PM

#

OH oh oh oh

#

Right, sorry

molten bough Oct 30, 2019, 2:11 PM

#

took me a second as well, haha

hardy gorge Oct 30, 2019, 2:11 PM

#

That's okay

#

That's why we're talking about it

crude gyro Oct 30, 2019, 2:11 PM

#

I'm not opposed to us adding some testing packages to the toolchain though, if we come across some cool stuff. there are some really excellent ones

#

this is one of my favorites: https://github.com/spulec/freezegun

GitHub

spulec/freezegun

Let your Python tests travel through time. Contribute to spulec/freezegun development by creating an account on GitHub.

hardy gorge Oct 30, 2019, 2:11 PM

#

yes

mellow hare Oct 30, 2019, 2:11 PM

#

Kind of off-topic, but what's our current coverage?

hardy gorge Oct 30, 2019, 2:12 PM

#

for?

#

bot?

mellow hare Oct 30, 2019, 2:12 PM

#

Yeah

crude gyro Oct 30, 2019, 2:12 PM

#

20-30 something %?

hardy gorge Oct 30, 2019, 2:12 PM

#

Branch or line coverage?

mellow hare Oct 30, 2019, 2:12 PM

#

I honestly don't know the difference

hardy gorge Oct 30, 2019, 2:12 PM

#

It's fairly easy

#

line coverage just keeps track of which lines are executed during the tests

#

And then calculates the percentage of all lines that got executed

#

if a line was never executed during testing, it was never tested

#

However, take a look at this code:

mellow hare Oct 30, 2019, 2:13 PM

#

Oh yeah, branch then

#

I know some lines would be pointless to test

hardy gorge Oct 30, 2019, 2:15 PM

#

def eggs(bacon):
    if bacon:
        spam = "ni"
    return spam

#

If, during our tests, we call this with eggs(True), all of the lines in there would be executed and we would have full line coverage

#

However, there are two paths/branches possible: bacon is truthy and bacon is falsy

#

If we only call it with a truthy bacon, we don't test the branch/path where bacon is falsy

#

So, we have full line coverage, but only partial branch coverage

molten bough Oct 30, 2019, 2:16 PM

#

Reminds me of site coverage, which does require doing all the branches too

hardy gorge Oct 30, 2019, 2:16 PM

#

Yes, bot as well. Both have coverage.py set to branch=True

molten bough Oct 30, 2019, 2:16 PM

#

nods

#

It took me a bit to realise why the file wasn't marked as 100% covered lol

hardy gorge Oct 30, 2019, 2:17 PM

#

I've added a section on that to the testing readme for bot

molten bough Oct 30, 2019, 2:17 PM

#

\o/

#

also pycharm pro's coverage tool is awesome

hardy gorge Oct 30, 2019, 2:17 PM

#

with a link to the coverage.py explanation of it

molten bough Oct 30, 2019, 2:17 PM

#

big recommend

green oriole Oct 31, 2019, 8:21 AM

#

The reddit cog break at the end of the month

#

Traceback (most recent call last):
  File "...\lib\site-packages\discord\ext\tasks\__init__.py", line 68, in _loop
    await self.coro(*args, **kwargs)
  File "...\bot\bot\cogs\reddit.py", line 133, in auto_poster_loop
    midnight_tomorrow = now.replace(day=now.day + 1, hour=0, minute=0, second=0)
ValueError: day is out of range for month```

hardy gorge Oct 31, 2019, 8:24 AM

#

Ah, yes. This should use a relativedelta instead to add the day

#

Feel free to make an issue for it

green oriole Oct 31, 2019, 8:25 AM

#

Okay

#

relativedelta or timedelta?

#

I would say timedelta is more adapted

hardy gorge Oct 31, 2019, 8:31 AM

#

yeah, you're right. That's what I meant.

#

Bit tired

hardy gorge Oct 31, 2019, 8:49 AM

#

I think it would be a good idea to add the emojis we create to the branding repo. A emoji directory would work well and we could include both the .png we upload and, if available, the svg we used to create it.

green oriole Oct 31, 2019, 8:50 AM

#

They aren't already in?

hardy gorge Oct 31, 2019, 8:52 AM

#

Not that I know of

green oriole Oct 31, 2019, 8:52 AM

#

There is some in the assets folder, but yeah a lot are missing

hardy gorge Oct 31, 2019, 8:53 AM

#

Yeah, only the very old ones, I think

#

Not our cool new duckies and what have you

molten bough Oct 31, 2019, 8:59 AM

#

Good idea

#

Easier to contribute them as well then

scenic moth Oct 31, 2019, 12:36 PM

#

is there way to suggest adding a tag or alias

molten bough Oct 31, 2019, 12:36 PM

#

I think there's an issue on the meta repo

brazen charm Oct 31, 2019, 12:37 PM

#

Or the meta channel

green oriole Oct 31, 2019, 12:37 PM

#

Yeah there is an issue on meta

#

https://github.com/python-discord/meta/issues/22

GitHub

Tag/Wiki Suggestions · Issue #22 · python-discord/meta

PyDis' Python bot uses !tags to provide brief, canonical explanations for common questions, programming pitfalls, and other Python related topics. Use this issue to suggest additional tags,...

scenic moth Oct 31, 2019, 12:58 PM

#

ty

green oriole Oct 31, 2019, 1:04 PM

#

Guys, I have three hours before hacktoberfest is completed for me, I want to do a last issue on a pydis project (my 10th contrib) any important issue in mind that need to be solved and that will not take ages?

brazen charm Oct 31, 2019, 1:09 PM

#

There's not that many to go through and check what you can handle

green oriole Oct 31, 2019, 1:11 PM

#

There is 147 issues opened on bot :)

#

Half of them are test writing

brazen charm Oct 31, 2019, 1:13 PM

#

Filter tests out and the second half is a manageable amount to check, you know better about what you can handle in that timeframe

green oriole Oct 31, 2019, 1:14 PM

#

Hmm good point

#

I found one

#

Not sure if I can finish it but I'm gonna try anyway

#

https://github.com/python-discord/bot/issues/551

GitHub

Ability to temporarily ignore user/watchword pairs in #mod-alerts ...

Occasionally a single user will very frequently cause false positive watchlist triggers, which results in constant moderator pings. This can for example happen if pasted code contains identifiers f...

#

If someone can please assign me

green oriole Oct 31, 2019, 1:55 PM

#

I think I'm going to use the bot_setting model (https://github.com/python-discord/site/blob/master/pydis_site/apps/api/models/bot/bot_setting.py) does that seems OK to you?

mellow hare Oct 31, 2019, 2:04 PM

#

Assigned

green oriole Oct 31, 2019, 2:06 PM

#

@mellow hare thanks! Any thoughts about using the bot_setting model? Because for now it is only used for the defcon settings there is maybe a reason to it?

mellow hare Oct 31, 2019, 2:07 PM

#

I don't really have any strong thoughts about it honestly. Plead your case, how do you think you'd make it work?

green oriole Oct 31, 2019, 2:22 PM

#

Well, we have this model that isn't very used, I don't think this feature deserve a brand new model and it seems to very fit the goal of this model they are runtime settings.

#

Actually I only need to store two list (one for the tokens, one for the users) and an expiration date

molten bough Oct 31, 2019, 2:24 PM

#

That seems like the wrong model

#

"settings" to me sounds like stuff you don't change automatically

#

the user sets them and they're not big lists of things

#

whereas it seems like this one is purely access programmatically by the bot, especially considering the timing aspect, and commands

#

so yeah I'd say this probably needs another model

green oriole Oct 31, 2019, 2:26 PM

#

The defcon can't be enabled at runtime?

molten bough Oct 31, 2019, 2:26 PM

#

yes but it's not like entries are going to be automatically added and removed

#

there's always a single defcon entry

green oriole Oct 31, 2019, 2:26 PM

#

Hmm yeah you're right

clever wraith Oct 31, 2019, 2:56 PM

#

btw there is a issue with bot , i am just saying cuz m not skilled enough to help fixing it ,
in the output it don't consider empty spaces

mellow hare Oct 31, 2019, 2:57 PM

#

How do you mean?

#

!e

print()
print()

stable mountainBOT Oct 31, 2019, 2:57 PM

#

@mellow hare :warning: Your eval job has completed with return code 0.

[No output]

mellow hare Oct 31, 2019, 2:57 PM

#

I think that's intentional

clever wraith Oct 31, 2019, 2:58 PM

#

no not that

#

def reformat_(a):
    len_a = 8 - len(a)
    a = " " * int(len_a / 2) + a + " " * int(len_a / 2)
    return a
reformat_("Hii")

hardy gorge Oct 31, 2019, 3:00 PM

#

It will strip the leading spaces of the first line; is that what you mean?

mellow hare Oct 31, 2019, 3:01 PM

#

Yep

hardy gorge Oct 31, 2019, 3:01 PM

#

wait

#

that's on me

#

but it shows it anyway

#

!e

print("    hello", "    goodbye", sep="\n")

stable mountainBOT Oct 31, 2019, 3:02 PM

#

@hardy gorge :white_check_mark: Your eval job has completed with return code 0.

001 | hello
002 |     goodbye

mellow hare Oct 31, 2019, 3:02 PM

#

Huh

clever wraith Oct 31, 2019, 3:02 PM

#

!e
print("hello ")

stable mountainBOT Oct 31, 2019, 3:02 PM

#

Sorry, but you may only use this command within #bot-commands.

clever wraith Oct 31, 2019, 3:03 PM

#

what about after spaces ?

molten bough Oct 31, 2019, 3:03 PM

#

I mean.. do you need those?

#

spaces at the end of the string

clever wraith Oct 31, 2019, 3:03 PM

#

in some cases YES

molten bough Oct 31, 2019, 3:03 PM

#

why?

clever wraith Oct 31, 2019, 3:04 PM

#

some conditions like if i want to print | abcd __________
and with end = ""
i do next print

#

wait its the discord

#

which strips it

mellow hare Oct 31, 2019, 3:07 PM

#

Here's the thing, they're still there in the variable, but they just aren't printed

#

And there really isn't a feasible way to see white spaces after a string

clever wraith Oct 31, 2019, 3:09 PM

#

so what happened i typed a function and wanted to check it , that reformat_ one , and i did it with this bot and was really confused why it didnt worked

hardy gorge Oct 31, 2019, 3:09 PM

#

This stripping of spaces should not influence the end="" thing

#

!e

print("A    ", end="")
print("B", end="")

stable mountainBOT Oct 31, 2019, 3:09 PM

#

@hardy gorge :white_check_mark: Your eval job has completed with return code 0.

A    B

clever wraith Oct 31, 2019, 3:09 PM

#

def reformat_(a):
    len_a = 8 - len(a)
    a = " " * int(len_a / 2) + a + " " * int(len_a / 2)
    return a

#

this one

mellow hare Oct 31, 2019, 3:09 PM

#

Right, but I'm more saying there's no way to tell if there's more spaces after B

#

Because it's the last visible character

clever wraith Oct 31, 2019, 3:10 PM

#

but after using this function it dont even show first spaces ?

mellow hare Oct 31, 2019, 3:10 PM

#

Yeah it strips the whitespace on the first line for some reason

woeful thorn Oct 31, 2019, 3:11 PM

#

!e

def reformat_(a):
    len_a = 8 - len(a)
    a = " " * int(len_a / 2) + a + " " * int(len_a / 2)
    return a
print(reformat_("Hii"))

stable mountainBOT Oct 31, 2019, 3:11 PM

#

@woeful thorn :white_check_mark: Your eval job has completed with return code 0.

Hii

hardy gorge Oct 31, 2019, 3:12 PM

#

It strips the whitespace of the output variable

#

So, leading and trailing spaces will be removed

#

I'm not sure if that's absolutely necessary, someone should experiment with removing it. It's probably there for a reason.

clever wraith Oct 31, 2019, 3:14 PM

#

or maybe maybe as python reply with ` at start and end , is throwing it off

green oriole Oct 31, 2019, 3:14 PM

#

Oh yeah ` strip the spaces

hardy gorge Oct 31, 2019, 3:15 PM

#

It's not an inline codeblock, but a multiline one

#

    this works fine
 with both leading and trailing spaces

clever wraith Oct 31, 2019, 3:15 PM

#

doesnt bot uses 2 of those `

green oriole Oct 31, 2019, 3:15 PM

#

Oh yeah

clever wraith Oct 31, 2019, 3:15 PM

#

do this ?

#

regardless

hardy gorge Oct 31, 2019, 3:16 PM

#

No, it uses a multine codeblock, not an inline codeblock

mellow hare Oct 31, 2019, 3:16 PM

#

It doesn't have to do with Discord's formatting

clever wraith Oct 31, 2019, 3:16 PM

#

hi hell no

hardy gorge Oct 31, 2019, 3:16 PM

#

https://github.com/python-discord/bot/blob/master/bot/cogs/snekbox.py#L215

#

No, it does not

#

It's purely the stripping of whitespace

#

In this line: https://github.com/python-discord/bot/blob/master/bot/cogs/snekbox.py#L171

mellow hare Oct 31, 2019, 3:16 PM

#

!e

print("               I will be flush with the | symbol")
print("               I will not.")

stable mountainBOT Oct 31, 2019, 3:16 PM

#

@mellow hare :white_check_mark: Your eval job has completed with return code 0.

001 | I will be flush with the | symbol
002 |                I will not.

mellow hare Oct 31, 2019, 3:17 PM

#

If it did have to do with Discord's formatting, the output for this would be the same as the prints

#

Snekbox is Mark's baby, right?

hardy gorge Oct 31, 2019, 3:17 PM

#

I'm sorry, it's this line: https://github.com/python-discord/bot/blob/master/bot/cogs/snekbox.py#L137

mellow hare Oct 31, 2019, 3:17 PM

#

Or who designed it?

hardy gorge Oct 31, 2019, 3:18 PM

#

The other one comes after the line numbers are added

#

This is the bot code of snekbox, not the snekbox repo.

clever wraith Oct 31, 2019, 3:18 PM

#

conclusion its the bot who is doing it on purpose ? right

hardy gorge Oct 31, 2019, 3:19 PM

#

I think gdude originally adding the stripping, but mark reformatted the code

#

(going by the git blame)

#

Yes, the bot is doing this on purpose, probably to prevent empty lines from being added at the start or end

#

We have limited space, so that would only take up space and usually isn't relevant

mellow hare Oct 31, 2019, 3:19 PM

#

Seems pointless since we have a built in spam reduction

#

It pares it down to 10ish lines anyway

hardy gorge Oct 31, 2019, 3:20 PM

#

We only allow 10 lines of eval output, using two of those empty trailing or leading lines is probably not that useful

#

However, it just means we should not strip whitespace from lines with something on it

mellow hare Oct 31, 2019, 3:20 PM

#

True but it'd be accurate to the output

green oriole Oct 31, 2019, 3:20 PM

#

Maybe we can add an option for it?

clever wraith Oct 31, 2019, 3:21 PM

#

toggle like system ?

hardy gorge Oct 31, 2019, 3:21 PM

#

No, I just think we should change the stripping logic to where it doesn't strip leading spaces on lines with actual non-blank output

mellow hare Oct 31, 2019, 3:21 PM

#

That's an easy fix

#

More or less anyway

clever wraith Oct 31, 2019, 3:23 PM

#

btw are we gonna get any support for matplotlib , like outputting a image , like spyder does ?

#

if we dont have it yet

brazen charm Oct 31, 2019, 3:25 PM

#

there's wolfram alpha support which I believe does that

mellow hare Oct 31, 2019, 3:26 PM

#

I keep forgetting about that cog

past falcon Oct 31, 2019, 3:42 PM

#

Trying to set up a dev environment for playing around with the bot, but I haven't used Docker before and I'm feeling a little lost. I'm on Windows 10, but not a Pro version so I'm not meeting the criteria for Docker Desktop. Should I then go for the Docker Toolbox? These binaries https://download.docker.com/win/static/stable/x86_64/ ? pip install docker? x_x

molten bough Oct 31, 2019, 3:44 PM

#

If you're on a home edition windows, Docker is probably not going to work for you

#

you'll need to do it without docker

past falcon Oct 31, 2019, 3:44 PM

#

Ah, oh.

brazen charm Oct 31, 2019, 3:46 PM

#

I got it working for the site on 7 with gdude's help but bot's being run through pycharm's pipenv configuration

green oriole Oct 31, 2019, 3:47 PM

#

I'm on 10 home and I use a no-docker setup @past falcon

past falcon Oct 31, 2019, 3:53 PM

#

Oh, cool! Was it a hassle to set up? @green oriole

green oriole Oct 31, 2019, 3:54 PM

#

Not that much

#

Once you know what you need to do

#

You want a bit of help?

past falcon Oct 31, 2019, 3:56 PM

#

That would be very much appreciated 🙂

green oriole Oct 31, 2019, 3:56 PM

#

Okay so

#

You want the site and the bot?

past falcon Oct 31, 2019, 3:57 PM

#

Was thinking I'd start with just the bot, unless I need the site for that too

green oriole Oct 31, 2019, 3:57 PM

#

You need it to interact with the db

past falcon Oct 31, 2019, 3:58 PM

#

I see. So another fork and clone for me

green oriole Oct 31, 2019, 3:58 PM

#

Yep

woeful thorn Oct 31, 2019, 3:59 PM

#

You're staff, you don't need to fork

green oriole Oct 31, 2019, 3:59 PM

#

In the meantime you can download postgres 12

#

Yeah if you are in the org you can clone the upstream

past falcon Oct 31, 2019, 4:00 PM

#

Ah, well I guess I'm doing a bit of a lone wolf setup then ^^

green oriole Oct 31, 2019, 4:02 PM

#

You also need postgres here https://www.enterprisedb.com/thank-you-downloading-postgresql?anid=1256972

Thank you for downloading PostgreSQL!

Thank you for downloading PostgreSQL, packaged by EnterpriseDB!

past falcon Oct 31, 2019, 4:02 PM

#

Yeah, installing atm

green oriole Oct 31, 2019, 4:03 PM

#

Okay in the meantime we can start configuring the bot

past falcon Oct 31, 2019, 4:03 PM

#

I think I did most of that

green oriole Oct 31, 2019, 4:04 PM

#

Okay you changed the channels, the roles and the webhooks?

past falcon Oct 31, 2019, 4:04 PM

#

I went through this: https://pythondiscord.com/pages/contributing/bot/#requirements

Only snagged an issue at the docker thing

green oriole Oct 31, 2019, 4:04 PM

#

(inside config.yml)

past falcon Oct 31, 2019, 4:04 PM

#

Yus

#

Uh, postgres port number. 8000?

green oriole Oct 31, 2019, 4:06 PM

#

No leave the default

#

In the env you need to add

DATABASE_URL=postgres://pysite:pysite@localhost:5432/pysite
SECRET_KEY=suitable-for-development-only
STATIC_ROOT=C:/Users/<your username>/AppData/Local/Temp/django```

past falcon Oct 31, 2019, 4:07 PM

#

Environment vars?

green oriole Oct 31, 2019, 4:07 PM

#

The .env file

#

Along with the BOT_TOKEN

#

Tell me when postgres is installed ^^

past falcon Oct 31, 2019, 4:10 PM

#

Done!

#

And this .env file is, uh, where? 🙂

green oriole Oct 31, 2019, 4:11 PM

#

In the bot folder

#

You hard-coded your token in the config file?

past falcon Oct 31, 2019, 4:12 PM

#

No, stored as environment variable

#

I'm not finding the .env?

green oriole Oct 31, 2019, 4:13 PM

#

Oh yeah you don't need to store it as an actual env var you can add it in the .env

#

You need to create it

past falcon Oct 31, 2019, 4:13 PM

#

Oooh.

green oriole Oct 31, 2019, 4:13 PM

#

When you launch your script pipenv load the variables inside the .env as actual environment variables

#

Oh wait

#

My bad I mixed things up

#

I gave you the env of the site not the bot

past falcon Oct 31, 2019, 4:15 PM

#

Ah, I'll move those to the site folder then?

green oriole Oct 31, 2019, 4:16 PM

#

Yep

#

Sorry

past falcon Oct 31, 2019, 4:16 PM

#

No worries! Thanks for the taking the time =)¨

green oriole Oct 31, 2019, 4:18 PM

#

So postgres

past falcon Oct 31, 2019, 4:19 PM

#

This is taking me through quite a few things that are new to me. I tend to stick to my comfort zone of solving fun code puzzles ^_^ Anyhoo. Got a site .env, got my postgres - leaving my bot token as a real envvar for now

green oriole Oct 31, 2019, 4:19 PM

#

Open the start menu and search for pgAdmin

past falcon Oct 31, 2019, 4:19 PM

#

Gotcha.

green oriole Oct 31, 2019, 4:20 PM

#

Oh before that you can type your bot token and BOT_API_KEY=badbot13m0n8f570f942013fc818f234916ca531 in the bot .env

past falcon Oct 31, 2019, 4:22 PM

#

Uh hm, do I have both a BOT_TOKEN and a BOT_API_KEY?

green oriole Oct 31, 2019, 4:22 PM

#

Yep both

#

With a line break between them

past falcon Oct 31, 2019, 4:25 PM

#

I'm not sure where to find that API_KEY. Discord gives me client id, client secret, bot token

molten bough Oct 31, 2019, 4:25 PM

#

the api key comes from the site

#

look at the compose file for it

#

for the bot

#

I mean

green oriole Oct 31, 2019, 4:25 PM

#

No the api key is always the same

#

The one I gave to you

molten bough Oct 31, 2019, 4:25 PM

#

it's in the compose file

#

Oh right, yeah

#

you posted it lol

past falcon Oct 31, 2019, 4:25 PM

#

Ooh.

#

Okay, back on track now I think.

green oriole Oct 31, 2019, 4:27 PM

#

Okay so

#

You should have a web page with some graph on the right side

past falcon Oct 31, 2019, 4:27 PM

#

Yeah

green oriole Oct 31, 2019, 4:28 PM

#

Right click on the user icon in the left bar and click new

#

Then name that new user pysite

#

Make it admin (it a switch in the security tab I think)

#

And in security set the password pysite

#

?

#

Anyway

past falcon Oct 31, 2019, 4:33 PM

#

Uh, hang on. I think I'm making a group role, not a user

#

...but that's also the only thing I see that I can create

green oriole Oct 31, 2019, 4:38 PM

#

Create it and I think it actually create an user

past falcon Oct 31, 2019, 4:38 PM

#

Alrighty

#

Mkay, I have this:

📎 chrome_m4PvtNO4jU.png

green oriole Oct 31, 2019, 4:43 PM

#

Perfect

#

Now right click on database and then click on create

#

Name it pysite and I think you can choose the database owner?

past falcon Oct 31, 2019, 4:44 PM

#

Yupyup

green oriole Oct 31, 2019, 4:45 PM

#

Then choose pysite as the owner and create it

past falcon Oct 31, 2019, 4:46 PM

#

So far so good

green oriole Oct 31, 2019, 4:46 PM

#

Okay

#

I think we are ready to go!

#

Try pipenv run python manage.py run --debug in the site folder and go to http://pythondiscord.local:8000/

#

(well you need to wait a bit of time until the server start)

#

(assuming you changed your host file)

past falcon Oct 31, 2019, 4:51 PM

#

I have interacted with very few host files recently 🙂 I also haven't fixed the pipenv on the site, so installing some packages now

green oriole Oct 31, 2019, 4:52 PM

#

Oh you can abort it

#

You nned to do pipenv sync --dev

past falcon Oct 31, 2019, 4:53 PM

#

Yeah, doing that

green oriole Oct 31, 2019, 4:53 PM

#

Or you are going to get an error on pyuswgi

#

You are sure it is installing the dev packages?

past falcon Oct 31, 2019, 4:54 PM

#

I ran the pipenv sync --dev, so I would hope so

green oriole Oct 31, 2019, 4:54 PM

#

Oh okay I thought pipenv was self installing it because you started the site

past falcon Oct 31, 2019, 4:55 PM

#

Ok, now what's this host file thingy

green oriole Oct 31, 2019, 4:56 PM

#

There was a note on it in the contributing guide

#

Okay so

#

Open the start menu, search for notepad, right click and select run as admin

#

Next use ctrl + o

#

Type C:\Windows\System32\Drivers\etc\hosts and press enter

#

Then add

127.0.0.1 pythondiscord.local 
127.0.0.1 api.pythondiscord.local
127.0.0.1 staff.pythondiscord.local 
127.0.0.1 admin.pythondiscord.local```at the end of the file

mellow hare Oct 31, 2019, 4:58 PM

#

Ideally with those on separate lines for clarity

#

Sorry, my pickiness kicked in

green oriole Oct 31, 2019, 4:59 PM

#

Yeah on phone I saw them with one per line

#

But they wasn't

#

No you're right, clarity is important ^^

past falcon Oct 31, 2019, 5:00 PM

#

Site is running!

green oriole Oct 31, 2019, 5:00 PM

#

Yay

#

~~And now pipenv run --debug in the bot folder~~

past falcon Oct 31, 2019, 5:00 PM

#

With site running?

green oriole Oct 31, 2019, 5:00 PM

#

Yep

#

Open another terminal

past falcon Oct 31, 2019, 5:01 PM

#

run whatnow? Missing something there I think

green oriole Oct 31, 2019, 5:02 PM

#

Missing something? Why?

#

The bot should post some log and stop around user sync finished

#

BTW we should add a proper "I have started" message

mellow hare Oct 31, 2019, 5:03 PM

#

pipenv run start --debug

green oriole Oct 31, 2019, 5:04 PM

#

(I said it)

mellow hare Oct 31, 2019, 5:04 PM

#

You forgot the start bit

green oriole Oct 31, 2019, 5:04 PM

#

Oh my bad

past falcon Oct 31, 2019, 5:04 PM

#

Stuff happening now! Hitting a snag on the yaml file though, but think I can squash that

green oriole Oct 31, 2019, 5:05 PM

#

The start commands are so wordly

mellow hare Oct 31, 2019, 5:05 PM

#

Sed, if you look in the pipfile at the bottom you'll see a variety of commands you can use through pipenv run

#

You might want to run the precommit one to make it easier to do linting before making a commit

#

I always forget to do it otherwise

green oriole Oct 31, 2019, 5:06 PM

#

You have test coverage lint precommit and all that kind of crazy stuff

#

Oh yeah precommit

#

Very important one ^^

brazen charm Oct 31, 2019, 5:07 PM

#

just remembered, would it be possible for the precommit to only run on things that are added in that commit?

woeful thorn Oct 31, 2019, 5:07 PM

#

That's what it does

green oriole Oct 31, 2019, 5:07 PM

#

(and so they are at the end of the pipfile. I always asked myself where they were)

brazen charm Oct 31, 2019, 5:07 PM

#

It picked up some test files I had laying around in the folders

woeful thorn Oct 31, 2019, 5:08 PM

#

The alternative is manually syncing the pre-commit config with everything else, which isn't desirable

green oriole Oct 31, 2019, 5:09 PM

#

Yeah it stash them before running the test

past falcon Oct 31, 2019, 5:10 PM

#

Hitting some connection errors, but I gotta do some dinner-related errands. Gonna hafta look at it later. I muchly appreciate the help so far @green oriole Making big progress here 🙂

#

You should consider expanding on that contribution guide for windows nurbs like me

green oriole Oct 31, 2019, 5:11 PM

#

Happy to have helped 😄

#

I proposed, they didn't wanted

past falcon Oct 31, 2019, 5:12 PM

#

Oh. Well, +1 on the suggestion from me.

hardy gorge Oct 31, 2019, 5:12 PM

#

We did not?

woeful thorn Oct 31, 2019, 5:12 PM

#

Pretty sure that's not true

green oriole Oct 31, 2019, 5:12 PM

#

Let me find it back

hardy gorge Oct 31, 2019, 5:13 PM

#

We eventually want one, good guide, that preferably works well for everyone

#

I think

green oriole Oct 31, 2019, 5:14 PM

#

Oh well, no staff responded

mellow hare Oct 31, 2019, 5:14 PM

#

Sure but considering not everyone has the same system we might have to take them in piecemeal and fix any discrepancies

green oriole Oct 31, 2019, 5:14 PM

#

I wanted to write a no-docker win 10 all in one guide

molten bough Oct 31, 2019, 5:15 PM

#

lemon did say he was interested

green oriole Oct 31, 2019, 5:15 PM

#

I even created an outline of the guide https://docs.google.com/document/d/13ee_G71SypP5nJj4RS8gpVaQMnL9qxTRI6gT3eOG0m4/edit?usp=drivesdk

Google Docs

PyDis Windows Install NoDocker

Setup Fork & clone bot/site Install pipenv Sync pipenv, setup precommit Test discord server/app Configuration Create .env Set hosts file DB Install postgres Setup db Run Start the site Start the bot

#

He did?

hardy gorge Oct 31, 2019, 5:16 PM

#

@mellow hare Sure, but the biggest issue is docker and it's perfectly possible to provide a guide that works without docker (but maybe has an optional docker part for people who want to use it)

mellow hare Oct 31, 2019, 5:16 PM

#

I was thinking one guide with sections

#

Similar to what we have now

green oriole Oct 31, 2019, 5:43 PM

#

I think there should be a guide special no-docker because of the additional step it had, like manually setuping the database @hardy gorge

hardy gorge Oct 31, 2019, 6:02 PM

#

@green oriole What I meant was that if docker is that problematic for a large group of (potential) contribs, because it doesn't work well on Windows 10 Home, then our main guide should not say "use docker; it makes things easy". Instead, we should probably have a robust guide without docker as the main guide (if that's the solution to those problems) and have docker as the additional guide.

#

However, this is probably topic that's going to trigger some debate, since some people really like our docker set-up

#

So, it's not something just a few people should decide

mellow hare Oct 31, 2019, 6:10 PM

#

Probably better for a meeting

#

Or a poll

hollow lichen Oct 31, 2019, 6:11 PM

#

What's the value added by docker, since there is already pipenv to properly set the dependencies?

mellow hare Oct 31, 2019, 6:12 PM

#

Docker makes setting it up even quicker

#

As well as updating the setups and what have you

green oriole Oct 31, 2019, 6:14 PM

#

Maybe just a clear distinction at the beginning of the docker guide "if you are on win 10 home see this guide instead"

#

Tbh I just recivied my raspberry pie and I'm going to do a no-docker setup even if I could have used it

#

I don't think it make things easier

#

But that's just my opinion

woeful thorn Oct 31, 2019, 6:15 PM

#

You don't think docker makes things easier?

green oriole Oct 31, 2019, 6:16 PM

#

Yeah

mellow hare Oct 31, 2019, 6:16 PM

#

Have you gotten it to successfully work on the rpi?

woeful thorn Oct 31, 2019, 6:16 PM

#

Do you have any particular reason for that?

brazen charm Oct 31, 2019, 6:17 PM

#

well, certainly not on windows at least so that should be covered in some way

woeful thorn Oct 31, 2019, 6:17 PM

#

Why not on Windows?

mellow hare Oct 31, 2019, 6:17 PM

#

Correction, not on Windows 10 Home

#

Because Docker does not work on that version since it requires...

#

What's the word...

green oriole Oct 31, 2019, 6:18 PM

#

No I don't really see any point in it

#

I just received it @mellow hare I will see tomorrow

#

That's the same as doing a normal setup and you need to work around docker

#

It just add restrictions imo

#

The fact that it made my lost my mind and two days of my life @woeful thorn :)

woeful thorn Oct 31, 2019, 6:18 PM

#

What restrictions does it add?

brazen charm Oct 31, 2019, 6:18 PM

#

because it took me 2 days to get it running, lack of resources online for looking up things yourself

mellow hare Oct 31, 2019, 6:18 PM

#

Hyper-V

#

That's it

green oriole Oct 31, 2019, 6:18 PM

#

(all my message are in the wrong order thanks internet connection)

mellow hare Oct 31, 2019, 6:19 PM

#

10 Home does not have Hyper-V functionality

#

And so it can't properly run Docker. That's something that they mention in their setup (the docker folks being the they)

green oriole Oct 31, 2019, 6:20 PM

#

@woeful thorn the fact for example you need to configure the bot and the site to be able to communicate

woeful thorn Oct 31, 2019, 6:20 PM

#

?

green oriole Oct 31, 2019, 6:20 PM

#

The fact that it take 10 minutes to shutdown the container

woeful thorn Oct 31, 2019, 6:20 PM

#

It doesn't

mellow hare Oct 31, 2019, 6:20 PM

#

Yeah neither of those are true

woeful thorn Oct 31, 2019, 6:21 PM

#

If we're going to say "don't use docker" for anything that isn't Windows 10 Home then we need real reasons

green oriole Oct 31, 2019, 6:21 PM

#

Yes you need to add the compose project or something

woeful thorn Oct 31, 2019, 6:21 PM

#

Not "I don't like it"

mellow hare Oct 31, 2019, 6:21 PM

#

Well I'm pretty sure, "It doesn't work" is enough of a reason

woeful thorn Oct 31, 2019, 6:21 PM

#

It does work lol

green oriole Oct 31, 2019, 6:21 PM

#

It doesn't take 10 minutes but it take something like 20 seconds

mellow hare Oct 31, 2019, 6:21 PM

#

Sorry, maybe it's Docker-Compose that doesn't?

hollow lichen Oct 31, 2019, 6:21 PM

#

I agree

brazen charm Oct 31, 2019, 6:21 PM

#

didn't manage to get it working for the bot

green oriole Oct 31, 2019, 6:21 PM

#

20 seconds you don't have to wait without docker

mellow hare Oct 31, 2019, 6:21 PM

#

Either way, it's something crucial for it to function

hollow lichen Oct 31, 2019, 6:21 PM

#

@green oriole You can safely kill it and it takes 2 seconds

mellow hare Oct 31, 2019, 6:22 PM

#

And true ELA, you CAN get it working on Win 10 Home, but it would require either a VM or WSL

woeful thorn Oct 31, 2019, 6:22 PM

#

I'm not talking about just Windows 10 Home

mellow hare Oct 31, 2019, 6:22 PM

#

And at that point, you might as well use the other option

green oriole Oct 31, 2019, 6:22 PM

#

WSL doesn't work

#

I tried

woeful thorn Oct 31, 2019, 6:23 PM

#

This is the context

📎 unknown.png

hollow lichen Oct 31, 2019, 6:23 PM

#

On linux/Mac installing Docker is pain-free

#

Nostalgic of #IRC?

mellow hare Oct 31, 2019, 6:23 PM

#

As is Docker for 10 business or pro

molten bough Oct 31, 2019, 6:24 PM

#

if we're talking about docker on xyz windows versions

#

pro: yes, full hyper-v available

green oriole Oct 31, 2019, 6:24 PM

#

I totally understand that some people prefers docker, I just don't like it

molten bough Oct 31, 2019, 6:24 PM

#

home stable: yes, barely, for now

mellow hare Oct 31, 2019, 6:24 PM

#

So yes, I agree that the guide shouldn't be swapped over to not suggest docker

molten bough Oct 31, 2019, 6:24 PM

#

home insider preview: nope

mellow hare Oct 31, 2019, 6:24 PM

#

Wait, home stable has Hyper-V?

molten bough Oct 31, 2019, 6:24 PM

#

no

mellow hare Oct 31, 2019, 6:24 PM

#

I was under the impression that was what was holding it back

#

I'm confused then

molten bough Oct 31, 2019, 6:24 PM

#

you can use docker toolbox, which spins up a virtualbox VM

mellow hare Oct 31, 2019, 6:24 PM

#

Gooooooootcha

molten bough Oct 31, 2019, 6:24 PM

#

there's a problem with this though

#

WSL2 is the problem

#

in order to facilitate it, home is going to include some select parts of hyper-v

#

not enough to run docker proper

#

but enough to break virtualbox

#

meaning neither solution will work

mellow hare Oct 31, 2019, 6:25 PM

#

So for practical purposes, it's not a good fit for 10 Home

molten bough Oct 31, 2019, 6:25 PM

#

Pretty much