#dev-log | Python | Page 100

regal archBOT Jul 18, 2022, 3:57 PM

#

D0rs4n

[python-discord/sir-robin] New branch created: pr\-cj\-patch\-role\-lock

#

D0rs4n

[python-discord/sir-robin] Pull request opened: #51 Remove CJ role check from the CJ command group\.

We have command level role locks, so that is unnecessary, this way the info command can be used by the Events Team.

regal archBOT Jul 18, 2022, 6:11 PM

#

D0rs4n

[python-discord/sir-robin] Pull request closed: #51 Remove CJ role check from the CJ command group\.

regal archBOT Jul 18, 2022, 8:15 PM

#

D0rs4n

[sir-robin:cj\-change\-info\-embed] 1 new commit

11b7c2d Patch CJ info embed to be raw text - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New branch created: cj\-change\-info\-embed

#

D0rs4n

[sir-robin] Branch cj\-change\-info\-embed was force-pushed to `4dbef59`

Compare changes

#

D0rs4n

[sir-robin] Branch cj\-change\-info\-embed was force-pushed to `7638c81`

Compare changes

#

D0rs4n

[python-discord/sir-robin] Pull request opened: #52 Patch CJ info embed to be raw text

alt text

Images show everything, I had to end the jam once, hence the deleted-channel (I made the screen after I ended the jam, silly me)

#

Exenifix

[python-discord/site] Pull request opened: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

odd spireBOT Jul 18, 2022, 8:27 PM

#

[python-discord/site] Checks Failed on PR: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

GitHub Actions run 2693271628 failed.

PR Author

Exenifix

Workflow Run

Lint & Test #1159

Source Branch

Exenifix:main

regal archBOT Jul 18, 2022, 8:35 PM

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #52: Patch CJ info embed to be raw text

Just out of interest, what would this look like? Just to include it in the pre-amble too.

                message = f"<@{member['user_id']}>"

                if member["is_leader"] :
                    message += " (Team Leader)"

                team_members.append(message)

            team_members_formatted = "\n".join(team_members)
            response_text = (
                f"You have been sorted into {team_channel}"
                f"{', and *you are the ...

odd spireBOT Jul 18, 2022, 8:36 PM

#

[python-discord/site] Checks Successful on PR: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

GitHub Actions run 2693315210 succeeded.

PR Author

Exenifix

Workflow Run

Lint & Test #1160

Source Branch

Exenifix:main

regal archBOT Jul 18, 2022, 8:43 PM

#

D0rs4n

[sir-robin:cj\-change\-info\-embed] 1 new commit

84cd6cf Make the CJ info output more consistent - D0rs4n

#

ChrisLovering

[python-discord/sir-robin] Pull request review submitted: #52 Patch CJ info embed to be raw text

#

D0rs4n

[sir-robin] Branch cj\-change\-info\-embed was force-pushed to `6e92f0d`

Compare changes

#

janine9vn

[python-discord/sir-robin] Issue opened: #53 Add \`&cj pin\` command for participants to use

Participants in our code jam have asked for a way to pin things in their channel. We can't reasonably give them the native Discord permission, but we do have bots. Let's use the bots.

This command should be usable by Admins, Events Team, and anyone with the Code Jam Participants Role. It'll let people pin/un-pin messages only in their team channel via the bot. This should work with a reply to a message and also a message link.

I figure one way to do this is have a wonky role-check-l...

#

D0rs4n

[python-discord/sir-robin] New comment on issue #53: Add \`&cj pin\` command for participants to use

We can use the Code Jam MGMT API, and do a basic ID check. I can do this.

#

DMFriends

[python-discord/sir-robin] New comment on issue #53: Add \`&cj pin\` command for participants to use

I really like this idea. (Note: I'm not a participant). How would the command work? Like reply to a message and invoke the command, similar to the .uwu command on Lancebot? I think that's probably the best way to implement this. Just stating my opinion.

#

camcaswell

[python-discord/sir-robin] Issue opened: #54 Create a spreadsheet\-like view of the Code Jam participants

We have bot commands for moving people between teams, but we use a manually-updated spreadsheet to figure out where to move them and who to replace as leader, etc. If we generated a view of the participants in the database we don't have to worry about maintaining two sources of truth.

Participants should be grouped into teams, and teams should be ordered by timezone. It should include whatever background info we have about each participant such as experience-level estimate, leadership pref...

regal archBOT Jul 18, 2022, 9:36 PM

#

janine9vn

[python-discord/sir-robin] Pull request review submitted: #52 Patch CJ info embed to be raw text

Tested and works like a charm!

It even works with old persisted buttons~

#

D0rs4n

[python-discord/sir-robin] Pull request closed: #52 Patch CJ info embed to be raw text

#

D0rs4n

[sir-robin:main] 3 new commits

7638c81 Patch CJ info embed to be raw text - D0rs4n
6e92f0d Make the CJ info output more consistent - D0rs4n
bef1870 Merge pull request #52 from python-discord/cj-c... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] branch deleted: cj\-change\-info\-embed

thin oysterBOT Jul 18, 2022, 9:41 PM

#

Sir Robin

Connected!

regal archBOT Jul 18, 2022, 10:01 PM

#

D0rs4n

[sir-robin:cj\-remove\-partc\-role] 1 new commit

327ab17 Remove Code Jam Participant role when issuing `... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New branch created: cj\-remove\-partc\-role

#

D0rs4n

[python-discord/sir-robin] Pull request opened: #55 Remove Code Jam Participant role when issuing \`cj remove\`

#

D0rs4n

[sir-robin] Branch cj\-remove\-partc\-role was force-pushed to `e5a88a4`

Compare changes

#

shenanigansd

[python-discord/sir-robin] Pull request review submitted: #55 Remove Code Jam Participant role when issuing \`cj remove\`

LGTM

#

D0rs4n

[python-discord/sir-robin] New comment on issue #53: Add \`&cj pin\` command for participants to use

Yes, exactly like this. We need to add a "middleware" though, to check the channel ID, but basically what you said.

regal archBOT Jul 18, 2022, 11:08 PM

#

D0rs4n

[sir-robin:cj\-pin] 2 new commits

56ca4d2 Add cj pin command and adjust permissions acc... - D0rs4n
e4b3cf5 Add cj unpin command, and a general helper to... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New branch created: cj\-pin

#

D0rs4n

[python-discord/sir-robin] Pull request opened: #56 Add \`cj pin\` and \`cj unpin\`

Lets Code Jam participants pin messages in their own team channels. Check done via the Code Jam MGMT api.

#

D0rs4n

[python-discord/sir-robin] New comment on issue #46: Code Jam: Generate output for the team arrangment from a CSV file

Closed via #49

#

D0rs4n

[python-discord/sir-robin] Issue closed: #46 Code Jam: Generate output for the team arrangment from a CSV file

regal archBOT Jul 19, 2022, 1:05 AM

#

janine9vn

[python-discord/sir-robin] Pull request review submitted: #55 Remove Code Jam Participant role when issuing \`cj remove\`

Tested and works very well. I tested with a couple of different options and it worked as expected with no errors popping up.

#

D0rs4n

[python-discord/sir-robin] Pull request closed: #55 Remove Code Jam Participant role when issuing \`cj remove\`

#

D0rs4n

[sir-robin:main] 2 new commits

e5a88a4 Remove Code Jam Participant role when issuing ... - D0rs4n [e90d240`](https://github.com/python-discord/sir-robin/commit/e90d24072baf2dc57acd455e8a9d7e5d40457d46) Merge pull request #55 from python-discord/cj-r... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] branch deleted: cj\-remove\-partc\-role

thin oysterBOT Jul 19, 2022, 1:06 AM

#

Sir Robin

Connected!

regal archBOT Jul 19, 2022, 2:14 AM

#

ichard26

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

                    await ctx.reply("You don't have permission to unpin this message in this channel!")

        else:
            await ctx.reply(":x: You have to reply to a message in order to unpin it!")

regal archBOT Jul 19, 2022, 5:03 AM

#

minalike

[site:add\-cj9\-links] 2 new commits

473c96a Add back green box link to CJ 9 page - minalike
6a1ab5b Add CJ9 page link to side bar - minalike

#

minalike

[python-discord/site] New branch created: add\-cj9\-links

#

minalike

[python-discord/site] Pull request opened: #747 Sprinkle back in some CJ9 links

So, I always navigate to the events page and somehow miss the huge summer code jam duck banner on the index page.

I was missing the big green box linking to CJ9 on the Events page and I think we should keep this here for the duration of the event. Let's not make users hunt for content.

To that end I've also added a CJ9 link on the CJ Info page, which can be updated once the theme is finalized and announced. (I know it's not a "previous" jam yet but soon enough, it will be)

odd spireBOT Jul 19, 2022, 5:10 AM

#

[python-discord/site] Checks Successful on PR: #747 Sprinkle back in some CJ9 links

GitHub Actions run 2695280768 succeeded.

PR Author

minalike

Workflow Run

Lint & Test #1161

Source Branch

add-cj9-links

regal archBOT Jul 19, 2022, 10:56 AM

#

ChrisLovering

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

In my opinion, if this command is ran outside of the code jam team category, it should silently fail. Sir-Robin has no reason to respond to this command outside of that context.

If it is inside the code jam category, then you can assume the user running the command has permission to pin the message, as no other users will be in those channels.

If we really wanted to be safe, we can still check that the user invoking the command is a participant, but it's not 100% needed with the above s...

#

ChrisLovering

[python-discord/site] Pull request review submitted: #747 Sprinkle back in some CJ9 links

#

ChrisLovering

[site:main] 3 new commits

473c96a Add back green box link to CJ 9 page - minalike
6a1ab5b Add CJ9 page link to side bar - minalike
7de0083 Merge pull request #747 from python-discord/add... - ChrisLovering

#

ChrisLovering

[python-discord/site] Pull request closed: #747 Sprinkle back in some CJ9 links

#

ChrisLovering

[python-discord/site] branch deleted: add\-cj9\-links

odd spireBOT Jul 19, 2022, 11:02 AM

#

[python-discord/site] Workflow Successful

GitHub Actions run 2697120874 succeeded.

Actor

ChrisLovering

Workflow Run

Deploy #273

Commit

7de0083

regal archBOT Jul 19, 2022, 11:21 AM

#

D0rs4n

[python-discord/sir-robin] New comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

In my opinion, if this command is ran outside of the code jam team category, it should silently fail. Sir-Robin has no reason to respond to this command outside of that context.

If it is inside the code jam category, then you can assume the user running the command has permission to pin the message, as no other users will be in those channels.

If we really wanted to be safe, we can still check that the user invoking the command is a participant, but it's not 100% needed with t...

regal archBOT Jul 19, 2022, 11:37 AM

#

D0rs4n

[sir-robin:cj\-pin] 1 new commit

d5e2102 Make Sir Robin silently fail when pinning outsi... - D0rs4n

regal archBOT Jul 19, 2022, 11:52 AM

#

brad90four

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

LGTM content-wise, have not tested locally

regal archBOT Jul 19, 2022, 12:10 PM

#

D0rs4n

[sir-robin:add\-cj\-add] 1 new commit

aa1496e Add cj add command and add_flow to the CJ e... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New branch created: add\-cj\-add

#

D0rs4n

[python-discord/sir-robin] Pull request opened: #57 Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

This PR introduces a new command and flow, which will enable the events team to add someone to the Code Jam either as a team lead or participant.

(Note: This add_flow is a modified version of the move_flow)

#

ChrisLovering

[python-discord/sir-robin] New comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

In my opinion, if this command is ran outside of the code jam team category, it should silently fail. Sir-Robin has no reason to respond to this command outside of that context.
If it is inside the code jam category, then you can assume the user running the command has permission to pin the message, as no other users will be in those channels.
If we really wanted to be safe, we can still check that the user invoking the command is a participant, but it's not 100% needed with the...

regal archBOT Jul 19, 2022, 12:56 PM

#

HassanAbouelela

[forms-frontend:404] 2 new commits

191581e Simplify Navigation Component - HassanAbouelela
cebc474 Add 404 Page - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] New branch created: 404

#

HassanAbouelela

[python-discord/forms-frontend] Pull request opened: #485 Add 404 Handlers

Adds a handler for 404s, and some cleanup for the styles used in the 404 page.

#

HassanAbouelela

[forms-frontend:404] 1 new commit

87349d0 Fix Navigation Element Size - HassanAbouelela

#

D0rs4n

[sir-robin:cj\-pin] 1 new commit

db082ac Add in_code_jam_category check and apply it o... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

In my opinion, if this command is ran outside of the code jam team category, it should silently fail. Sir-Robin has no reason to respond to this command outside of that context.
If it is inside the code jam category, then you can assume the user running the command has permission to pin the message, as no other users will be in those channels.
If we really wanted to be safe, we can still check that the user invoking the command is a participant, but it's not 100% needed wi...

regal archBOT Jul 19, 2022, 1:46 PM

#

HassanAbouelela

[forms-frontend] Branch 404 was force-pushed to `6973487`

Compare changes

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #485 Add 404 Handlers

#

HassanAbouelela

[forms-frontend:main] 3 new commits

191581e Simplify Navigation Component - HassanAbouelela
cebc474 Add 404 Page - HassanAbouelela
6323d91 Merge pull request #485 from python-discord/404 - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: 404

regal archBOT Jul 19, 2022, 2:26 PM

#

shenanigansd

[python-discord/bot] Pull request review submitted: #2224 feat\(tags\): add print\-return tag

LGTM

regal archBOT Jul 19, 2022, 4:50 PM

#

brad90four

[python-discord/sir-robin] Pull request review dismissed: #56 Add \`cj pin\` and \`cj unpin\`

LGTM content-wise, have not tested locally

regal archBOT Jul 19, 2022, 5:38 PM

#

D0rs4n

[python-discord/sir-robin] New comment on issue #54: Create a spreadsheet\-like view of the Code Jam participants

That sounds like a great idea. However as of now, the Code Jam Management system does not store timezone information.
My main question regarding that is.. whether you want this spreadsheet-like view to be editable, or just read-only.
Being editable would mean, that we would have to interact with the discord API, and upon interacting with the spreadsheet it would edit the roles as well. This is the hardest version, at least in point of implementation.
The read-only version would just be a g...

regal archBOT Jul 20, 2022, 12:15 AM

#

D0rs4n

[sir-robin:add\-cj\-add] 1 new commit

5a20a24 Update move flow to add user to the database if... - D0rs4n

regal archBOT Jul 20, 2022, 6:25 AM

#

n0Oo0Oo0b

[python-discord/bot] Issue opened: #2227 \!docs cannot find class methods of Sequence or Set types

Normally, you are able to use !docs for class methods (e.g. str.split) like so:

However, this does not work for Sequence and Set types (list, tuple, range, set, frozenset):

The most likely reason for this is because the documentation for them are formatted differently on the official documentation, they could be added as an edge case that uses a different check to search for attributes.

#

HassanAbouelela

[python-discord/bot] New comment on issue #2227: \!docs cannot find class methods of Sequence or Set types

Hey, this is actually a problem with the python docs themselves, and there's an issue open for it python/cpython#89923. To parse the symbols in the tutorial would require adding a bunch of edge case code which does not make sense for such a limited scope of resources. If you'd like to see this resolved sooner, feel free to drop a comment on the linked issue. Thanks!

#

HassanAbouelela

[python-discord/bot] Issue closed: #2227 \!docs cannot find class methods of Sequence or Set types

regal archBOT Jul 20, 2022, 7:25 AM

#

HassanAbouelela

[forms-backend:bump\-motor] 1 new commit

a36f303 Bump Motor Version To 3.0.0 - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] New branch created: bump\-motor

#

HassanAbouelela

[python-discord/forms-backend] Pull request opened: #187 Bump Motor Version To 3\.0\.0

Motor version 2.4 is not fully compatible with the version of mongo we're using (we're using latest, which is now 5.0.9 in production, and similar if you recreate your container). Run docker compose up mongo -d --build to update.

odd spireBOT Jul 20, 2022, 7:34 AM

#

[python-discord/forms-backend] Checks Failed on PR: #187 Bump Motor Version To 3.0.0

GitHub Actions run 2703031246 failed.

PR Author

HassanAbouelela

Workflow Run

Forms Backend #535

Source Branch

bump-motor

regal archBOT Jul 20, 2022, 7:43 AM

#

HassanAbouelela

[forms-backend:bump\-motor] 1 new commit

2b83c25 Fix ANN401 Linting Failures - HassanAbouelela

odd spireBOT Jul 20, 2022, 7:44 AM

#

[python-discord/forms-backend] Checks Successful on PR: #187 Bump Motor Version To 3.0.0

GitHub Actions run 2703084421 succeeded.

PR Author

HassanAbouelela

Workflow Run

Forms Backend #536

Source Branch

bump-motor

regal archBOT Jul 20, 2022, 7:53 AM

#

HassanAbouelela

[forms-backend:main] 3 new commits

a36f303 Bump Motor Version To 3.0.0 - HassanAbouelela
2b83c25 Fix ANN401 Linting Failures - HassanAbouelela
35513e3 Merge pull request #187 from python-discord/bum... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] branch deleted: bump\-motor

#

HassanAbouelela

[python-discord/forms-backend] Pull request closed: #187 Bump Motor Version To 3\.0\.0

odd spireBOT Jul 20, 2022, 7:56 AM

#

[python-discord/forms-backend] Checks Successful on PR: #155 Bump python-dotenv from 0.19.2 to 0.20.0

GitHub Actions run 2703147656 succeeded.

PR Author

dependabot[bot]

Workflow Run

Forms Backend #538

Source Branch

dependabot/pip/python-do...

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 2703137217 succeeded.

Actor

HassanAbouelela

Workflow Run

Forms Backend #537

Commit

35513e3

#

[python-discord/forms-backend] Checks Successful on PR: #185 Bump spectree from 0.7.6 to 0.10.3

GitHub Actions run 2703153884 succeeded.

PR Author

dependabot[bot]

Workflow Run

Forms Backend #539

Source Branch

dependabot/pip/spectree-...

#

[python-discord/forms-backend] Checks Successful on PR: #180 Bump starlette from 0.19.0 to 0.20.4

GitHub Actions run 2703154903 succeeded.

PR Author

dependabot[bot]

Workflow Run

Forms Backend #540

Source Branch

dependabot/pip/starlette...

regal archBOT Jul 20, 2022, 2:41 PM

#

janine9vn

[python-discord/sir-robin] Pull request review submitted: #57 Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Tested with several configurations, overall it looks good minus the one role that's getting added no matter what.

#

janine9vn

[python-discord/sir-robin] New review comment on pull request #57: Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

This is adding the Team Leader role, even if I've specified that they are not a Team Leader. This should be under a check based on what we've passed in.

#

D0rs4n

[sir-robin:add\-cj\-add] 1 new commit

6c81b0f Prevent adding team leader role to members if s... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New review comment on pull request #57: Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Oh right, thank you! Resolved in 6c81b0f

#

janine9vn

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

We can revert this. After some internal discussion we can keep it open to Events Teams.

#

janine9vn

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Same comment as earlier, potentially adding in support for message links.

#

janine9vn

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

Looks good! I have a request/comment about allowing pin/unpins from message links. I can be swayed either way though.

Also a small note about reverting an earlier decision about which role to lock commands to.

#

janine9vn

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Can we add the ability to check if they're passing in a message link? Not sure how much it would be used but it would be nice to have the option.

We would have to check if the message exists in the current channel though.

#

janine9vn

[python-discord/sir-robin] Pull request review submitted: #57 Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Works very nicely now~

#

D0rs4n

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Sure

#

D0rs4n

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Sure, we can.

#

D0rs4n

[sir-robin:cj\-pin] 1 new commit

223882b Add message ID / message link support to `cj pi... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Added in 223882b

#

D0rs4n

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Added in 223882b

#

D0rs4n

[sir-robin:cj\-pin] 1 new commit

bfd5630 Allow the Events team to use the cj info comm... - D0rs4n

#

janine9vn

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

Very nice!

#

Kronifer

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

looks good

regal archBOT Jul 20, 2022, 4:22 PM

#

ankushcodes69

[python-discord/bot] Issue opened: #2228 hehe6996

#

ankushcodes69

[python-discord/bot] Issue closed: #2228 hehe6996

regal archBOT Jul 20, 2022, 6:52 PM

#

kosayoda

[python-discord/bot] New comment on issue #2228: hehe6996

Please refrain from opening irrelevant issues.

#

brad90four

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

Looks good, just the one thing on the conditional error message (I don't think it should have a dangling comma)

#

brad90four

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

            f"Something went wrong{', you might have reached the 50 pins per channel limit!' if not unpin else ''}"

regal archBOT Jul 20, 2022, 8:11 PM

#

PH-KDX

[python-discord/branding] Issue opened: #187 Add alcoholic duck

I'd like to contribute :ducky_beer: to our fine set of ducklets.
ducky_beer_resized

#

PH-KDX

[python-discord/branding] Pull request opened: #188 Create ducky\_beer\.xvg

Addresses #187.

odd spireBOT Jul 20, 2022, 8:14 PM

#

[python-discord/branding] Checks Successful on PR: #188 Create ducky_beer.xvg

GitHub Actions run 2707403099 succeeded.

PR Author

PH-KDX

Workflow Run

Event Validation #103

Source Branch

PH-KDX:patch-1

regal archBOT Jul 20, 2022, 8:15 PM

#

PH-KDX

[python-discord/branding] New comment on pull request #188: Create ducky\_beer\.xvg

Please ignore the fact that I accidentally wrote xvg in my commit message instead of svg.

#

D0rs4n

[sir-robin:cj\-pin] 1 new commit

b194795 Allow admins and the events team to use the pin... - D0rs4n

regal archBOT Jul 20, 2022, 8:32 PM

#

akabinds

[python-discord/forms-backend] Fork created: akabinds/forms-backend

#

ichard26

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

These two commands have an authorization issue and maaaybe another one too:

The Events Lead cannot use &cj pin or &cj unpin (poor Kat)
Any helper part of the Events Team can abuse &cj pin and &cj unpin to (un)pin any messages in channels Robin has permission to do so. I have no idea what permissions Robin will be given in the actual server during normal operations, but let's verify if not block this route entirely.

#

ichard26

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

        log.trace(f"Something went wrong when pinning a CJ message: {err}")

#

ichard26

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Either get rid of the superfluous return in the except clause or move code out of the else clause.

#

ichard26

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Either get rid of the superfluous return in the except clause or move code out of the else clause.

#

D0rs4n

[python-discord/sir-robin] New comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

These two commands have an authorization issue and maaaybe another one too:

1. The Events Lead cannot use `&cj pin` or `&cj unpin` (poor Kat)

2. Any helper part of the Events Team can abuse `&cj pin` and `&cj unpin` to (un)pin any messages in channels Robin has permission to do so. I have no idea what permissions Robin will be given in the actual server during normal operations, but let's verify this won't be an issue (if not block this route entirely).

1.:The Event...

#

ichard26

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

Re 1. right makes sense. Sorry about that. Re 2. I'm talking about a staff member who is on the Events Team invoking &cj pin in a CJ team channel to pin a message outside of the CJ categories. A bit of an edge case I'll admit, but I thought it was worth mentioning.

I'll downgrade the review to comment so a merge is still possible since 2 is definitely an edge case.

#

ichard26

[python-discord/sir-robin] Pull request review dismissed: #56 Add \`cj pin\` and \`cj unpin\`

These two commands have an authorization issue and maaaybe another one too:

The Events Lead cannot use &cj pin or &cj unpin (poor Kat)
Any helper part of the Events Team can abuse &cj pin and &cj unpin to (un)pin any messages in channels Robin has permission to do so. I have no idea what permissions Robin will be given in the actual server during normal operations, but let's verify this won't be an issue (if not block this route entirely).

#

D0rs4n

[python-discord/sir-robin] New comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

2 is valid, Stalling the PR while figuring it out.

regal archBOT Jul 20, 2022, 9:14 PM

#

D0rs4n

[sir-robin:cj\-pin] 1 new commit

0ca41f2 Prevent pinning messages outside of the Code Ja... - D0rs4n

#

akabinds

[python-discord/snekbox] New comment on issue #114: Support File I/O

I would be open to helping develop this feature, if it is still being considered.

#

D0rs4n

[sir-robin:cj\-pin] 1 new commit

afc0d82 Enhance code consistency in the Code Jam Extension - D0rs4n

regal archBOT Jul 20, 2022, 9:38 PM

#

brad90four

[python-discord/sir-robin] Pull request review dismissed: #56 Add \`cj pin\` and \`cj unpin\`

Looks good, just the one thing on the conditional error message (I don't think it should have a dangling comma)

#

janine9vn

[python-discord/sir-robin] Pull request review dismissed: #56 Add \`cj pin\` and \`cj unpin\`

Very nice!

regal archBOT Jul 20, 2022, 10:05 PM

#

ichard26

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

        if not message_is_in_code_jam_category(referenced_message, _creation_utils.CATEGORY_NAME, ctx):

#

ichard26

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

I'm sorry, but some more changes are needed.

Technically the Events Team and Admins can (un)pin a message from a CJ team channel that IS NOT the channel the command was invoked in, but honestly I don't think this matters much and isn't a permission bypass (just confusing). So I suggest ignoring this unless someone feels very strongly. I'm kind of scared of making any more changes than necessary :sweat_smile:

#

ichard26

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

            await ctx.reply(":x: You cannot unpin a message outside of the Code Jam category!")

Copy and pasting is the no. 1 drug for boosting productivity, side-effects include decreased focus for the little details. Call 1-800-CPY-PAST for more information.

#

ichard26

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

                await ctx.reply("You don't have permission to unpin this message in that channel!")

regal archBOT Jul 20, 2022, 10:40 PM

#

ChrisLovering

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

Both the pin and unpin command have a lot of duplicated code. IMO this tends to mean that it should be abstracted to a helper func, where the two commands just call this function with pin or unpin and the helper func does all this work in a single place. (see the help channel implementation.)

There also seems to be a very common pattern in sir-robin where we get a team, do some API error handling and then do something with the team.

IMO this fetching of the team and error handling shoul...

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

        if ctx.message.channel.category.name == code_jam_category_name
            return True

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

This pin wrapper can be re-used from the bot, as it comes with more error handling.

https://github.com/python-discord/bot/blob/main/bot/exts/help_channels/_message.py#L264-L286

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

    return message.channel.category and message.channel.category.name == code_jam_category_name

this also removes the need for the ctx arg.

regal archBOT Jul 20, 2022, 11:00 PM

#

Robin5605

[python-discord/site] Pull request review submitted: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Thanks for the PR, could you fix up some of the issues I commented on? Thanks!

#

Robin5605

[python-discord/site] New review comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

2. Next, we need to copy our Python project's external dependencies to some directory *inside the container*. Let's call it `/app`

#

Robin5605

[python-discord/site] New review comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Can we specify what the -t mybot part is?

#

Robin5605

[python-discord/site] New review comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Could we elaborate on what a "working directory" is?

#

Robin5605

[python-discord/site] New review comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

I think explaining what a base image is would be helpful, as it's quite important

1. First we need to specify the *base image*, which is the OS that the docker container will be running. Doing that will make Docker install some apps we need to run our bot, for

#

Robin5605

[python-discord/site] Pull request review submitted: #733 Added discord\-app\-commands\.md

Thanks for your work on this PR, LGTM. I'll comment if I notice something that needs to be changed.

regal archBOT Jul 20, 2022, 11:48 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1078 Fix: \.uwu incorrectly transforms emojis in their raw text form

Just a few small comments, looks good otherwise.

I also really appreciate you including screenshots of it in action in your PR! :)

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1078: Fix: \.uwu incorrectly transforms emojis in their raw text form

REGEX_EMOJI = re.compile(r"<(a)?:(\w+?):(\d{15,21}?)>", re.ASCII)

The ? inside the first match (a?) is unneeded as the is another ? outside the match block, doing the same thing.

The ID for the emoji is a snowflake, so it's actually valid between 15 and 21 characters.

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1078: Fix: \.uwu incorrectly transforms emojis in their raw text form

        """Replaces any emoji the bot cannot send in input_text with a random emoticons."""

odd spireBOT Jul 21, 2022, 12:24 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1078 Fix: .uwu incorrectly transforms emojis in their raw text form

GitHub Actions run 2708504940 succeeded.

PR Author

ionite34

Workflow Run

Lint #2376

Source Branch

ionite34:uwu-emoji-fix

regal archBOT Jul 21, 2022, 12:25 AM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1078 Fix: \.uwu incorrectly transforms emojis in their raw text form

odd spireBOT Jul 21, 2022, 12:25 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1078 Fix: .uwu incorrectly transforms emojis in their raw text form

GitHub Actions run 2708508834 succeeded.

PR Author

ionite34

Workflow Run

Lint #2377

Source Branch

ionite34:uwu-emoji-fix

regal archBOT Jul 21, 2022, 1:04 AM

#

D0rs4n

[sir-robin:cj\-pin] 2 new commits

bb955f6 Introduce pin flow to the Code Jam Extension - D0rs4n
561b2c3 Port _pin_wrapper over from bot and apply it... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Resolved all. 🤞

regal archBOT Jul 21, 2022, 1:45 AM

#

D0rs4n

[sir-robin] Branch cj\-pin was force-pushed to `5bcb398`

Compare changes

regal archBOT Jul 21, 2022, 2:07 AM

#

ichard26

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

Wheee this looks so much nicer. Can confirm it works and has no permission issues. Great work @D0rs4n, and thank you @ChrisLovering for bringing some sensibility back into this mess :)

#

ichard26

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

            await ctx.reply(f"You don't have permission to {pin_msg} this message in this channel!")

Since the user can only use this command on a message in their current channel "this" makes more sense.

#

D0rs4n

[sir-robin] Branch cj\-pin was force-pushed to `b5f0b2e`

Compare changes

#

D0rs4n

[python-discord/sir-robin] New review comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Patched.

#

D0rs4n

[python-discord/sir-robin] New comment on pull request #56: Add \`cj pin\` and \`cj unpin\`

Wheee this looks so much nicer. Can confirm it works and has no permission issues. Great work @D0rs4n, and thank you @ChrisLovering for bringing some sensibility back into this mess :)

Thank you for your thorough review! :)

regal archBOT Jul 21, 2022, 11:51 AM

#

mbaruh

[python-discord/bot] Pull request review submitted: #2225 Use the view clear on timeout feature from bot\-core in snekbox

#

mbaruh

[python-discord/bot-core] Pull request review submitted: #106 Add an optional message attr to ViewWithUserAndRoleCheck

#

mbaruh

[python-discord/bot-core] New review comment on pull request #106: Add an optional message attr to ViewWithUserAndRoleCheck

- :feature:`106` Add an optional ``message`` attr to :obj:`botcore.utils.interactions.ViewWithUserAndRoleCheck`. On view timeout, this message has its view removed if set.

#

ChrisLovering

[bot-core:remove\-view\-on\-timeout] 1 new commit

28e5fa0 squash me: punctuation fix - ChrisLovering

#

mbaruh

[python-discord/bot-core] Pull request review submitted: #106 Add an optional message attr to ViewWithUserAndRoleCheck

#

ChrisLovering

[python-discord/bot-core] Pull request closed: #106 Add an optional message attr to ViewWithUserAndRoleCheck

#

ChrisLovering

[bot-core:main] 1 new commit

603fc83 Add an optional message attr to ViewWithUserAnd... - ChrisLovering

#

ChrisLovering

[python-discord/bot-core] branch deleted: remove\-view\-on\-timeout

#

ChrisLovering

[python-discord/bot-core] New tag created: v7\.4\.0

#

ChrisLovering

[bot] Branch snekbox\-snags was force-pushed to `76caa09`

Compare changes

odd spireBOT Jul 21, 2022, 12:06 PM

#

[python-discord/bot] Checks Successful on PR: #2225 Use the view clear on timeout feature from bot-core in snekbox

GitHub Actions run 2711614892 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint & Test #2969

Source Branch

snekbox-snags

regal archBOT Jul 21, 2022, 12:08 PM

#

ChrisLovering

[python-discord/bot] Pull request closed: #2225 Use the view clear on timeout feature from bot\-core in snekbox

#

ChrisLovering

[bot:main] 5 new commits

c6ec291 Use the view clear on timeout feature from bot-... - ChrisLovering
4148216 Include what version of Python was used in snek... - ChrisLovering
28d91d4 Update snekbox tests to expect new output - ChrisLovering
76caa09 Start 3.11 snekbox container by default - ChrisLovering
977b682 Merge pull request #2225 from python-discord/sn... - ChrisLovering

#

ChrisLovering

[python-discord/bot] branch deleted: snekbox\-snags

oak estuaryBOT Jul 21, 2022, 12:12 PM

#

Python Bot

Connected!

odd spireBOT Jul 21, 2022, 12:13 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 2711665428 succeeded.

Actor

ChrisLovering

Workflow Run

Deploy #683

Commit

977b682

regal archBOT Jul 21, 2022, 12:20 PM

#

ChrisLovering

[bot:sid/feature/tags/print\-return] 6 new commits

c6ec291 Use the view clear on timeout feature from bot-... - ChrisLovering
4148216 Include what version of Python was used in snek... - ChrisLovering
28d91d4 Update snekbox tests to expect new output - ChrisLovering
76caa09 Start 3.11 snekbox container by default - ChrisLovering
977b682 Merge pull request #2225 from python-discord/sn... - ChrisLovering

odd spireBOT Jul 21, 2022, 12:22 PM

#

[python-discord/bot] Checks Successful on PR: #2224 feat(tags): add print-return tag

GitHub Actions run 2711709730 succeeded.

PR Author

sid-maddy

Workflow Run

Lint & Test #2971

Source Branch

sid/feature/tags/print-return

regal archBOT Jul 21, 2022, 1:32 PM

#

lemonsaurus

[python-discord/branding] New comment on issue #187: Add a ducky with a beer

Renaming this PR - no need to bring alcoholism into this. All I see is a nice duck enjoying a cold one on a warm day.

#

PH-KDX

[python-discord/branding] New comment on issue #187: Add a ducky with a beer

Good point, noted.

#

ChrisLovering

[python-discord/sir-robin] Pull request review submitted: #56 Add \`cj pin\` and \`cj unpin\`

#

ChrisLovering

[sir-robin:cj\-pin] 3 new commits

e5a88a4 Remove Code Jam Participant role when issuing ... - D0rs4n [e90d240](https://github.com/python-discord/sir-robin/commit/e90d24072baf2dc57acd455e8a9d7e5d40457d46) Merge pull request #55 from python-discord/cj-r... - D0rs4n [9fbd02b`](https://github.com/python-discord/sir-robin/commit/9fbd02b6474e7ba42c4fcdefa3973de8f4e5119e) Merge branch 'main' into cj-pin - ChrisLovering

#

ChrisLovering

[python-discord/sir-robin] Pull request closed: #56 Add \`cj pin\` and \`cj unpin\`

#

ChrisLovering

[sir-robin:main] 13 new commits

56ca4d2 Add cj pin command and adjust permissions acc... - D0rs4n
e4b3cf5 Add cj unpin command, and a general helper to... - D0rs4n
d5e2102 Make Sir Robin silently fail when pinning outsi... - D0rs4n
db082ac Add in_code_jam_category check and apply it o... - D0rs4n
223882b Add message ID / message link support to `cj pi... - D0rs4n

#

ChrisLovering

[python-discord/sir-robin] branch deleted: cj\-pin

#

ChrisLovering

[python-discord/sir-robin] Issue closed: #53 Add \`&cj pin\` command for participants to use

thin oysterBOT Jul 21, 2022, 1:46 PM

#

Sir Robin

Connected!

regal archBOT Jul 21, 2022, 1:51 PM

#

ChrisLovering

[python-discord/sir-robin] Pull request review submitted: #57 Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Works well on my end too.

I don't like that the majority of the logic in in the except block with lots of indentation, with a single line else at the end, but this can be solved after the CJ.

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #188 Create ducky\_beer\.svg

You did it! 🐰

#

lemonsaurus

[branding:main] 2 new commits

940f0b9 Create ducky_beer.xvg - PH-KDX
d578c2f Merge pull request #188 from PH-KDX/patch-1 - lemonsaurus

#

lemonsaurus

[python-discord/branding] Pull request closed: #188 Create ducky\_beer\.svg

#

lemonsaurus

[python-discord/branding] Issue closed: #187 Add a ducky with a beer

#

D0rs4n

[sir-robin] Branch add\-cj\-add was force-pushed to `bf22607`

Compare changes

regal archBOT Jul 21, 2022, 2:26 PM

#

obassett

[python-discord/metricity] Fork created: obassett/metricity

#

D0rs4n

[sir-robin:pined] 1 new commit

bff243d Correct the wording of the CJ pin commands. - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New branch created: pined

#

D0rs4n

[python-discord/sir-robin] Pull request opened: #58 Correct the wording of the CJ pin commands\.

Act like nothing happened.

#

ChrisLovering

[python-discord/sir-robin] Pull request review submitted: #58 Correct the wording of the CJ pin commands\.

#

ichard26

[python-discord/sir-robin] Pull request review submitted: #58 Correct the wording of the CJ pin commands\.

#

D0rs4n

[python-discord/sir-robin] Pull request closed: #58 Correct the wording of the CJ pin commands\.

#

D0rs4n

[sir-robin:main] 2 new commits

bff243d Correct the wording of the CJ pin commands. - D0rs4n
4c51e5a Merge pull request #58 from python-discord/pined - D0rs4n

#

D0rs4n

[python-discord/sir-robin] branch deleted: pined

thin oysterBOT Jul 21, 2022, 2:39 PM

#

Sir Robin

Connected!

regal archBOT Jul 21, 2022, 2:39 PM

#

D0rs4n

[sir-robin] Branch add\-cj\-add was force-pushed to `df9afe8`

Compare changes

regal archBOT Jul 21, 2022, 3:10 PM

#

Sanchitsharma2005

[python-discord/king-arthur] New star added

regal archBOT Jul 21, 2022, 6:47 PM

#

MarkKoz

[python-discord/snekbox] New comment on issue #114: Support File I/O

@akabinds Yes, that would be a welcome contribution. However, how to accomplish this has not been researched yet; that's probably where you should start. Maybe it should be an in-memory file system (tmpfs) rather than on disk?

Here is what I believe needs to be implemented:

Each eval mounts a new read-write directory.
It is initially empty.
It is set as the CWD for the eval.
It is isolated, meaning evals from other requests cannot access this directory (neither read nor write...

regal archBOT Jul 21, 2022, 7:26 PM

#

D0rs4n

[sir-robin] Branch add\-cj\-add was force-pushed to `7baa4e1`

Compare changes

#

D0rs4n

[sir-robin] Branch add\-cj\-add was force-pushed to `0a4b9f3`

Compare changes

regal archBOT Jul 21, 2022, 7:42 PM

#

ichard26

[python-discord/sir-robin] New review comment on pull request #57: Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

        """Add a member to the Code Jam by specifying the team's name, and whether they should be a leader."""

#

ichard26

[python-discord/sir-robin] New review comment on pull request #57: Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

                if err.response.status == 404:
                    await ctx.send(":x: User could not be found.")

If the team doesn't exist, wouldn't the guarded GET request to teams/find fail and cause the function to return early?

#

ichard26

[python-discord/sir-robin] Pull request review submitted: #57 Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Did not test out this PR on the dev server, just a read-through review.

#

D0rs4n

[sir-robin:add\-cj\-add] 1 new commit

9bed4c5 Adjust the comment wording in the CJ extension - D0rs4n

regal archBOT Jul 21, 2022, 8:48 PM

#

akabinds

[python-discord/snekbox] New comment on issue #114: Support File I/O

@akabinds Yes, that would be a welcome contribution. However, how to accomplish this has not been researched yet; that's probably where you should start. Maybe it should be an in-memory file system (tmpfs) rather than on disk?

Here is what I believe needs to be implemented:

Each eval mounts a new read-write directory.

It is initially empty.

It is set as the CWD for the eval.

It is isolated, meaning evals from other requests cannot access this directory (neithe...

odd spireBOT Jul 21, 2022, 9:11 PM

#

[python-discord/forms-backend] Checks Successful on PR: #189 Bump sentry-sdk from 1.7.2 to 1.8.0

GitHub Actions run 2714722501 succeeded.

PR Author

dependabot[bot]

Workflow Run

Forms Backend #541

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Jul 21, 2022, 9:16 PM

#

ChrisLovering

[python-discord/bot] New comment on issue #1879: Python 3\.10 blockers

With the release of https://github.com/SebastiaanZ/async-rediscache/releases/tag/v1.0.0-rc1 there are no longer any blockers to using Python 3.10.

We can go ahead and make a start on 3.10 using this release candidate and bump up to the production version when it is made before merging.

#

ChrisLovering

[python-discord/bot] Issue closed: #1879 Python 3\.10 blockers

regal archBOT Jul 21, 2022, 9:34 PM

#

MarkKoz

[python-discord/snekbox] Issue opened: #149 Use modern Docker Compose command

The Compose file uses some features of the spec only supported by Docker Compose v2, such as pull_policy. The contribution documentation and the Makefile currently refer to the v1 command, docker-compose. Under some circumstances, this can be aliased to v2, but it isn't guaranteed to always be the case. All references should be updated to use the v2 command, docker compose. An explicit mention of v2 being required for the command would be helpful as well.

#

Bluenix2

[site:clarify\-websocketrule] 1 new commit

0ed9322 Clarify WebSocket restriction rule's impact on ... - Bluenix2

#

Bluenix2

[python-discord/site] New branch created: clarify\-websocketrule

#

Bluenix2

[python-discord/site] Pull request opened: #748 Clarify WebSocket restriction rule's impact on static serving

Before this change, the rule technically disallowed implementing JavaScript clients because webbrowsers use HTTP to fetch the static files.

Originally brought up in one of the code jam team channels.

This PR also fixes a mistake in a previous commit where Markdown-style characters were used instead of code-tags.

#

Bluenix2

[site:clarify\-websocketrule] 1 new commit

1d0b576 Remove unnecessary "also" in new exception to c... - Bluenix2

odd spireBOT Jul 21, 2022, 9:46 PM

#

[python-discord/site] Checks Successful on PR: #748 Clarify WebSocket restriction rule's impact on static serving

GitHub Actions run 2714890619 succeeded.

PR Author

Bluenix2

Workflow Run

Lint & Test #1163

Source Branch

clarify-websocketrule

regal archBOT Jul 21, 2022, 9:46 PM

#

HassanAbouelela

[python-discord/snekbox] New comment on issue #148: API Documentation

I like solution 2, as it seems like the most robust version. We’re not doing anything risky like generating the code from the spec, and we aren’t doing anything that’ll go out of sync. I don’t mind which library. For the GitHub pages aspect, it’s actually a very common thing to deploy the built docs from actions. There’s an action which abstracts 100% of the work, and pushes to a docs branch. We use it on botcore for the docs.

odd spireBOT Jul 21, 2022, 9:46 PM

#

[python-discord/site] Checks Successful on PR: #748 Clarify WebSocket restriction rule's impact on static serving

GitHub Actions run 2714893274 succeeded.

PR Author

Bluenix2

Workflow Run

Lint & Test #1164

Source Branch

clarify-websocketrule

regal archBOT Jul 21, 2022, 9:49 PM

#

ChrisLovering

[python-discord/snekbox] New comment on issue #148: API Documentation

Yea, solution 2 is nice. We could have some CI that builds the OpenAPI spec, and if it detects what is in the code base is out of date it fails the CI and tells the user to run poetry runn task api.

Then another CI flow to push the built spec to GH pages.

#

Bluenix2

[site:clarify\-websocketrule] 1 new commit

b1d9468 Strike out beginning of code jam date - Bluenix2

odd spireBOT Jul 21, 2022, 9:52 PM

#

[python-discord/site] Checks Successful on PR: #748 Clarify WebSocket restriction rule's impact on static serving

GitHub Actions run 2714917337 succeeded.

PR Author

Bluenix2

Workflow Run

Lint & Test #1165

Source Branch

clarify-websocketrule

regal archBOT Jul 21, 2022, 9:56 PM

#

Bluenix2

[site:clarify\-websocketrule] 1 new commit

fadda91 Update codejams sidebar about cj9 theme announc... - Bluenix2

odd spireBOT Jul 21, 2022, 9:57 PM

#

[python-discord/site] Checks Successful on PR: #748 Clarify WebSocket restriction rule's impact on static serving

GitHub Actions run 2714942215 succeeded.

PR Author

Bluenix2

Workflow Run

Lint & Test #1166

Source Branch

clarify-websocketrule

regal archBOT Jul 21, 2022, 10:00 PM

#

MarkKoz

[python-discord/snekbox] New comment on issue #148: API Documentation

Okay, I was leaning towards 2 as well. In fact, I contributed to spectree to reduce the amount of dependencies it needs.

Can you go into more detail on the build process for GH pages? Would the action on snekbox build the docs and deploy them to the GH pages repo, or would there instead be an action on the GH pages repo to do this?

How would I avoid building docs if there are no changes? Would I need to put the spec file in version control for that? Is it even worth to try to avoid red...

#

ChrisLovering

[python-discord/snekbox] New comment on issue #148: API Documentation

We could have the first part of the CI in a custom pre-commit hook if it's performant enough to not be annoying

#

ChrisLovering

[python-discord/snekbox] New comment on issue #148: API Documentation

How would I avoid building docs if there are no changes? Would I need to put the spec file in version control for that? Is it even worth to try to avoid redundant builds?

Do we even need to worry about that? If unsure what the performance of building these docs is, so we could just build them all the time, if anything in /snekbox is changed if it's only a few seconds.

#

shenanigansd

[python-discord/site] Pull request review submitted: #748 Clarify WebSocket restriction rule's impact on static serving

LGTM

#

MarkKoz

[python-discord/snekbox] New comment on issue #148: API Documentation

Apparently redoc just needs a URI to the spec file. Everything else is generated by JS I guess. So, it comes down to

CI could generate the spec and then create a commit if it detects a change, but that feels hacky. Alternatively, it could just check if a spec needs to be regenerated without actually doing it, but it would be a bit tedious for the PR author to have to generate it.

And not sure in which repo the spec file should be.

#

Bluenix2

[python-discord/sir-robin] New review comment on pull request #57: Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

If you are changing other things, maybe consider making this Optional[bool]? This enables a special behaviour, where if it fails to match the argument it will skip it - and go to the next. I believe this is what you were looking to have happen with the default?

See the documentation about it.

#

Bluenix2

[python-discord/sir-robin] Pull request review submitted: #57 Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Looks good, I think you've got a nice structure with the flows here. Looks pretty clean and somewhat nice "separation of concern" behaviour (I say somewhat because it still passes ctx).

I do have an inquiry though, what happens if there's already a leader and we want this member to be the leader? This may be a question for the codejam management system.

#

Bluenix2

[python-discord/sir-robin] New review comment on pull request #57: Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Note that it is the team that is using this command. I suppose this still satisfies the purpose of getting us to check the logging 😄.

night lilyBOT Jul 21, 2022, 10:13 PM

#

Sir Lancebot

Connected!

regal archBOT Jul 21, 2022, 10:44 PM

#

D0rs4n

[python-discord/sir-robin] New review comment on pull request #57: Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Actually, here, by team, I meant the Python Discord team.

#

D0rs4n

[sir-robin:add\-cj\-add] 1 new commit

e1a3856 Make is_leader an optional parameter in cj add - D0rs4n

#

ooliver1

[python-discord/site] Pull request review submitted: #748 Clarify WebSocket restriction rule's impact on static serving

Thanks for the clarification (you may want to specify in the PR body that this edits the info for theme and the calendar)

#

D0rs4n

[python-discord/sir-robin] New comment on pull request #57: Add \`cj add\` command and \`add\_flow\` to the CJ exts stack

Looks good, I think you've got a nice structure with the flows here. Looks pretty clean and somewhat nice "separation of concern" behaviour (I say somewhat because it still passes ctx).

I do have an inquiry though, what happens if there's already a leader and we want this member to be the leader? This may be a question for the codejam management system.

As of now, there is no Code Jam Management support for that, but I'll definitely write that one up on the list, since it's impo...