#dev-log

1 messages ยท Page 92 of 1

regal archBOT
#
[python-discord/infra] New branch created: chris/service/psql
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
#

Yea, it can

Pipelining can be enabled globally by setting โ€œpipelining=Trueโ€ in the ssh section of ansible.cfg
However it has a drawback
Unfortunately, pipelining is disabled by default because it is incompatible with sudo's requiretty setting (or su, which always requires a tty). This is because of a quirk of the Python interpreter, which enters interactive mode automatically when you pipe in data from a (pseudo) tty.

regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/sir-lancebot] New branch created: fix\-aoc\-name\-lookup
#

Description

When a user doesn't set a name, the AoC API doesn't return a name key at all, so we need to make use of the ID field instead, to build the name based on a similar tempalte that AoC uses for it's leaderboard.

Did you:

  • [ ] Join the Python Discord Community?
  • [ ] Read all the comments in this template?
  • [ ] Ensure there is an issue open, or link relevant discord discussions?
  • [ ] Read and agree to the [contributing guidelines]...
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/sir-lancebot] branch deleted: fix\-aoc\-name\-lookup
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
jb3
[python-discord/site] New branch created: jb3/django\-discord
odd spireBOT
regal archBOT
#
[python-discord/site] branch deleted: jb3/django\-discord
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
#

I really don't see why it should be bothered to hijack the commands extension to workaround this "issue". Merely adding a space after your command is effortless.

The issue is not so much that adding a space is too much effort, but to the user it could be unclear why the bot didn't respond.

As the discord client renders with and without a space the same, two seemingly equal invocations can have different results. This is sort of confusing and comes up every now and again with someone won...

regal archBOT
regal archBOT
#

I really don't see why it should be bothered to hijack the commands extension to workaround this "issue". Merely adding a space after your command is effortless.

The issue is not so much that adding a space is too much effort, but to the user it could be unclear why the bot didn't respond.

As the discord client renders with and without a space the same, two seemingly equal invocations can have different results. This is sort of confusing and comes up every now and again wi...

odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
#

Right, but that's not what I was talking about
I think wookie's point was that even if !e```โ€‹ was a command, !eโ€```py wouldn't work because of the py. I'm saying it could work because of fuzzy matching

Mayybe instead of making it an alias for the actual !eval, we could just make it send an error message saying "run this command again with a space in between". That would handle the non-responsiveness, without needing to mess around with the codeblock regex and other parsing

regal archBOT
#

It wouldnโ€™t work no, we donโ€™t do fuzzy matching like that. The fuzzy matching for command names only sends a message listing similar commands. Youโ€™d have to add all aliases no matter what (6 by my count if you add python and py). Itโ€™ll also look quite ugly in the help list if we did the command approach.

We could do it in the error handler and match the first portion of the invocation command, but I donโ€™t think we should go beyond sending an error message. Trying to adjust the parsing to a...

#

Right, but that's not what I was talking about

Let me explain.

Scale's concerns about needing to modify the parser are valid, based on the below.

I think wookie's point was that even if !e```โ€‹ was a command, !eโ€```py wouldn't work because of the py. I'm saying it could work because of fuzzy matching

We don't have any fuzzy matching on command names, only on tags. Additionally, we can show this behavior on the current bot by running the command without the first three ```...

regal archBOT
regal archBOT
#

Rerunning of code doesn't currently seem to be working, when I click the reaction to rerun code (for eval or timeit command) I get this error:

bot_1        | 2022-01-15 13:06:01 | bot.exts.backend.error_handler | ERROR | Error executing command invoked by wookie#4017: !e 2
bot_1        | Traceback (most recent call last):
bot_1        |   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/core.py", line 167, in wrapped
bot_1        |     ret = await coro(*args, **kwa...
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
#

This doesn't currently seem to enforce any memory limits on the subprocesses created, which means the command is exploitable by running a command like .latex $\genfrac{}{}{10000000}{1}{1}{1}$ (tailoring that number to allocate as much memory as is available).

This can probably be done using the resources module, https://docs.python.org/3/library/resource.html, and setting some limits before running the render in _renderer.py.

resources, however, does not support windows. Because o...

regal archBOT
#

@wookie184 the exact change you describe was implemented by me on the latex-limits branch, but it proved unreliable. The code would still often OOM completely for reasons beyond me. IMO, the desire for a latex command is mostly artificial, and we can get by fine without it. If we were to implement it, I think the path of least resistance would be using an existing framework. @vcokltfre expressed interest in writing an API ...

regal archBOT
#
[python-discord/snekbox] branch deleted: bug/dev/124/cli\-args
regal archBOT
regal archBOT
#
[python-discord/bot] New branch created: swfarnsworth\-zapped\-message
odd spireBOT
regal archBOT
#
TIME_RE = re.compile(
    r"(?P<hour_12>0?[1-9]|1[0-2])"  # hours (12 hour format)
    r"|"
    r"(?P<hour_24>00?|1[2-9]|2[0-3]))"  # hours (24hr format)
    r"[:.]"  # separator between hours and minutes is `:` or `.`
    r"(?P<minute>[0-5][0-9])"  # minutes
    r"(?::"  # separator between minutes and seconds is `:`
    r"(?P<second>[0-5][0-9]))?"  # optional seconds
    r"(?: ?)"  # separator between minutes/seconds and meridiem is a space or nothing
    r"(?P<meridiem>[AaP...
#

Running

!bb watch  test
!infraction edit last 10s

Will result in this error when the bot tries to end the infraction

bot_1        | Traceback (most recent call last):
bot_1        |   File "/bot/bot/utils/scheduling.py", line 119, in _await_later
bot_1        |     await asyncio.shield(coroutine)
bot_1        |   File "/bot/bot/exts/moderation/infraction/_scheduler.py", line 402, in deactivate_infraction
bot_1        |     raise ValueError(
bot_1        | ValueError: A...
regal archBOT
#

Just for reference, i'll post some findings on the cause of the surprisingly high memory usage here.

To limit memory usage we set the rlimit RLIMIT_AS. This corresponds to "virtual memory", which includes memory in in ram or swap space, but also memory that isn't actually used (i.e. allocated to the process but not actually allocated to any hardware). I believe this "not actually allocated" memory is what numpy seems to...

night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

751f386 Add bot-core as a dependancy - ChrisLovering
e9b72cc use regex from bot-core for discord invites - ChrisLovering
3ff21f1 Move single-use message ID regex to inside file... - ChrisLovering
8845e5b Use codeblock regex from bot-core in snekbox cog - ChrisLovering
cb4256f Merge branch 'main' into add-bot-core - wookie184

#
[python-discord/bot] branch deleted: add\-bot\-core
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
        If the code is to be re-evaluated, return the new code, and the args if the command is the timeit command.
        Otherwise return None as the first element if the eval session should be terminated.

It took me a bit to understand these two sentences, I believe the above suggestion makes it a bit better but maybe it could use a full reword. The code also never returns None alone so the second sentence should mention it'll return None for the code in the tuple i...

regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: helpdm
regal archBOT
#
[python-discord/modmail-plugins] New branch created: anon\-messagesping
#
[python-discord/modmail-plugins] branch deleted: anon\-messagesping
regal archBOT
regal archBOT
#

Description

We currently have a message in #helpers that goes out when all help channels are used and no new ones can be pulled up/created that pings all Helpers.

Unfortunately, this message is a bit too late as all the channels are already taken.

We'd like to add a non-pinging message when we're at 90% help channel usage, to let people know we're running low on help channels. If helpers are free they can try to clear up some overdue channels before we run out.

We'd like to imp...

odd spireBOT
regal archBOT
#

It seems like if any more job types are added, they'll all use the prepare input function, what do you think of making it a converter that'd be applied to the code parameter?

Some of the methods are still using the eval naming (in both their names, and some strings inside), I think send_eval and post_eval should be changed to job like the others. There's also filter_eval from the Filtering cog, but in that case I think it's clearer to use eval as it doesn't have the context of bein...

odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/forms-backend] New branch created: anon\-webhooks
#

We currently use WEBHOOK_ENABLED to determine whether user data should be stored to the db. However, when webhooking a form submission this config is ignored, and the user mention is always included if available.

This means that if a user login in using anohter form, and then submits an anonymous form with the same session, their name will be included in the webhook.

odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

This doesn't currently seem to enforce any memory limits on the subprocesses created, which means the command is exploitable by running a command like .latex $\genfrac{}{}{10000000}{1}{1}{1}$ (tailoring that number to allocate as much memory as is available).

This can probably be done using the resources module, https://docs.python.org/3/library/resource.html, and setting some limits before running the render in _renderer.py.

resources, however, does not support windows. Because o...

regal archBOT
#
jb3
[python-discord/infra] branch deleted: chris/service/psql
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
regal archBOT
#
jb3

Unfortunately, I don't think we're going to be needing this system right now, since we don't host user events anymore and can handle staff event management without it. With the introduction of the new Discord Events system we can handle interest registration and notifications for events both privately and privately. Thank you for the contributions nonetheless though, it is greatly appreciated!

#

As part of our core developer meeting, we have decided that in order to have the site pull request taken care of for now, @ChrisLovering will implement a minimal patch in the bot to adjust the infraction type name in the backend to match the new name in the site, which will be merged together with the site pull request.

The main functionality of creating a new voice ban command will be implemented separately, but this way we keep work on the site project to a minimum (e.g. conflict resolut...

#
[python-discord/forms-backend] branch deleted: anon\-webhooks
odd spireBOT
regal archBOT
#

This PR changes everything related to voice_bans to instead use voice_mute so that the bot is in line with the new site API.
As such, this should be merged at the same time as https://github.com/python-discord/site/pull/608

This also adds stub commands for voice_ban , as they are useful for moderators during the change over from voice_ban to voice_mute, to remind them that the command has been renamed.

Reviewing may be easier by reviewing individual commits, rather than the full diff.

odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

Hi,

Please follow the proper contribution guidelines before making a PR to open source projects.

Is there a reason for this change? Running a regex over this field seems kind of pointless.

To be frankly honest the contributing.md was hidden in the .github folder, my bad for not looking for it more in depth.
I think running a regex over the field would be more beneficial as it is more lenient on the webhook url format

odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot-core] New branch created: port\-utilities
#
[python-discord/bot] branch deleted: enhance/backend/time\-util\-refactor
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
#

Sentry Issue: BOT-2JY

The function call was not updated in https://github.com/python-discord/bot/commit/94936e499f303deeae785d4b643dbf598ae0a4cc

TypeError: notify_infraction() missing 2 required positional arguments: 'bot' and 'infr_id'
  File "discord/client.py", line 351, in _run_event
    await coro(*args, **kwargs)
  File "bot/exts/moderation/infraction/superstarify.py", line 73, in on_m...
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/bot] New branch created: fix\-issue\-2053
odd spireBOT
regal archBOT
regal archBOT
#

I get this error when running b!modpings s 9pm 9am:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/core.py", line 167, in wrapped
    ret = await coro(*args, **kwargs)
  File "/bot/bot/exts/moderation/modpings.py", line 266, in schedule_modpings
    f"{discord_timestamp(start, TimestampFormats.TIME)} to "
  File "/bot/bot/utils/time.py", line 71, in discord_timestamp
    timestamp = (timestamp - arrow.get(0)).total_seconds(...
regal archBOT
regal archBOT
regal archBOT
#
[python-discord/site] New branch created: otn\_active\_only
regal archBOT
#

Background

  • PR #508 added the active attribute to the off topic channel names table.
  • It also added the ability to send PATCH and PUT requests to modify the instance attributes.

Changes

  • This PR filters the off topic channels names and only sends the active names as response to an incoming GET request to bot/off-topic-channel-names?random_items=x
  • Test cases were modified which were relevant to the above change.
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/site] New branch created: fix\-subarticles\-button
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#
jb3
[python-discord/bot] New branch created: jb3/feature\-channel\-changes
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/sir-lancebot] New branch created: aoc\-logging
#

Relevant Issues

<!-- Link the issue by typing: "Closes #" (Closes #0 to close issue 0 for example). -->
Approved by myself.

Description

When browsing the prod logs looking for a specific error, I noticed that the AOC cog produced a bunch of mostly pointless logs which contributed heavily to making the logs unbrowsable. This PR removes the main offenders while not losing any important information.

This PR adds a few unrelated changes to the config, but they are minor a...

odd spireBOT
regal archBOT
#

I've asked Xith to remove me from this issue and put it up for grabs, but an important note for whoever merges this:

The change to the insert/delete command will make any URLs in prod inaccessible if they have https in the name. I've already deleted a majority of the ones that existed at the time, but before you merge, it's a good idea to go through and clean up any that have been added since.

odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
#

Myself, @HassanAbouelela and @Qwerty-133 discussed this in #dev-contrib around [here](#dev-contrib message) and came to the conclusion that sending an embed after pinning the opener message would be better than editing the available one.

This is in-line with what we do for the available and dormant embeds, and also leads to better UX, especially if the opener message is long, since there's little use editing a message ...

night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
[python-discord/sir-lancebot] New branch created: test\-actions
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: fix\-pre\-commit\-issue
#

This is caused by an upstream issue with setuptools 60.* (via virtualenv) changeing the default to using the setuptools-embedded distutils rather than the stdlib distutils, which breaks within pip's isolated builds.

This is explained quite well here https://github.com/pre-commit/pre-commit/issues/2178#issuecomment-1002163763

This also fixes a small inconsistency with our docker-compose file.

odd spireBOT
regal archBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
#
[python-discord/sir-lancebot] branch deleted: aoc\-logging
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] branch deleted: fix\-issue\-2053
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
#

1faadcf Rename contributing guidelines to contributi... - novialriptide [da315f0](https://github.com/python-discord/bot/commit/da315f0d1888427f71cdd793e7339fb2dd1801e5) Merge pull request #2059 from novialriptide/nov... - HassanAbouelela [10186af](https://github.com/python-discord/bot/commit/10186afb0a376c82f71235b06f8f5af87f41bcb6) Add missing arguments to notify_infraction call - TizzySaurus [e1d3bf6`](https://github.com/python-discord/bot/commit/e1d3bf655df15195824635d824679bf7db670811) Merge branch 'main' into fix-pre-commit-issue - HassanAbouelela

#
[python-discord/bot] branch deleted: fix\-pre\-commit\-issue
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/site] New branch created: update\-bot\-contrib\-guide
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#

1faadcf Rename contributing guidelines to contributi... - novialriptide [da315f0](https://github.com/python-discord/bot/commit/da315f0d1888427f71cdd793e7339fb2dd1801e5) Merge pull request #2059 from novialriptide/nov... - HassanAbouelela [10186af](https://github.com/python-discord/bot/commit/10186afb0a376c82f71235b06f8f5af87f41bcb6) Add missing arguments to notify_infraction call - TizzySaurus [d7095c4](https://github.com/python-discord/bot/commit/d7095c40e83800cc379115ef45bd987a5deb4649) setuptools use stdlib distutils over embedded - ChrisLovering [4383c13`](https://github.com/python-discord/bot/commit/4383c139637025917645300cda8047f32926aa99) Add missing restart-policy to metricity container - ChrisLovering

odd spireBOT
regal archBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
#
[python-discord/site] branch deleted: update\-bot\-contrib\-guide
odd spireBOT
regal archBOT
#
[python-discord/site] New branch created: voice\-mute\-in\-metricity\-endpoint
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: fix\-voice\-gate
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/bot] branch deleted: fix\-voice\-gate
#
[python-discord/site] branch deleted: voice\-mute\-in\-metricity\-endpoint
oak estuaryBOT
odd spireBOT
regal archBOT
#

Brand new events page!

Weโ€™ve all been waiting for it, so here it is. I present to you a redesigned events page... after I finish the following:

  • [ ] New text bodies (existing ones can be re-used)
  • [ ] An interactive calendar pulling events from Discord
  • [ ] A โ€œComing up:โ€ box
  • [ ] Info about each event, Iโ€™m thinking of having a card for each event, like each project in the contributing docs

Thereโ€™s probably more, just let me know.

Closes site#494.

odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

Sentry Issue: SIR-LANCEBOT-7P

ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: application/json', url=URL('http://api.wolframalpha.com/v2/query?input=y+%3D+W%E2%88%921(x)+if+%E2%88%921/e+%E2%89%A4+x+%3C+0&appid=EJTXQJ-PHQXE29HLK&output=JSON&format=image,plaintext&location=the+moon&latlong=0.0,0.0&ip=1.1.1.1')
  File "discord/ext/commands/core.py", line 167, in wr...
regal archBOT
odd spireBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

@Bluenix2 I had tested the watch options extensively when I made this PR, but it did not seem to work for me. I tested it again now with the same result (I've ensured the modified file is copied correctly into the container). Perhaps this is an OS-dependent problem? What environment are you running in? If it works for some people, might as well leave it in, but it's broken for me.

Also, did you mean to put those options in devServer? watchContentBase is (perhaps no longer) documented, so t...

regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/site] New branch created: update\-pyfakefs
odd spireBOT
regal archBOT
#
[python-discord/site] New branch created: user\-information\-endpoint
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/site] branch deleted: update\-pyfakefs
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#

Around 23% of help channel sessions go completely unanswered.

We have a theory that a large proportion of this stat are from people who don't ask their question well, or don't provide enough information for helpers to help them.

To try and reduce this issue, this issue proposes that we send a message in help channels after 15 minutes if no one other than the claimant has sent a message.

I believe this message should include:

  1. An explanation that everyone here is a volunteer, and...
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#

Resource name
Python Graph Gallery

Resource location
https://www.python-graph-gallery.com/

Payment type
Free (Open Source 0BSD)

Why it should be included
It contains information about multiple types of graphs and charts available in popular graphing libraries, and some General Knowledge about graphing.

Potential limitations
Some of the Graph examples are specific to one or two specific libraries, but it still provides a single-stop summary for what you...

regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/sir-lancebot] New branch created: love\-calculator\-unsub\-footer
odd spireBOT
regal archBOT
#

I ask that with the assumption that !subscribe can only be used in #bot-commands, but let me know if that's not the case.

For non-staff, it'll redirect the output to #bot-commands if it's used outside of there, so I don't think it matters too much.

https://github.com/python-discord/bot/blob/cf9e0157639875de8984c7365f02d19052d8df9e/bot/exts/info/subscribe.py#L175-L178

Ah gotcha.

regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
#

Description

Code-golf competition!

Proposed Implementation

  1. The bot stores a queue of challenges. Staff members should be able to add new questions to the queue with a command (say, .cg add). Questions should be uploaded as a .json file, containing the problem description, visible test cases and hidden test cases.
  2. The bot should maintain per-day leaderboards, as well as an overall one in a configured channel (top 25 entries).
    • Per-day leaderboards should display...
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
#
[python-discord/sir-lancebot] branch deleted: love\-calculator\-unsub\-footer
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
#

Currently, moderators receive a non-pinging alert in #mod-alerts when a username containing a filtered word sends a message. The moderators would like to add a Moderators ping to this alert.

https://github.com/python-discord/bot/blob/2f64912bf4fd0d8bf1f55cf97cb4d4aef5ea81a3/bot/exts/filters/filtering.py#L236-L268

We also discussed adding the same ping for when such a user joins a voice channel. However, this type of alert is not currently in the code and would require another listener.

regal archBOT
regal archBOT
#

yeah so here the colors are both in the span class (is-primary) and in the delete button (has-background-primary-light), so you'd need twice as many if's, which wouldn't really be that much simpler. The only way to simplify it down to a single span would be to store all these colors somewhere in the view and make sure I can get them from filters.items, which adds more clutter to the view.. but might be a better solution. I'm not sure.

odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
#

Regarding "Configure Podman services to use host cgroup and run managed by systemd":

[Unit]
Description = Gobble the memory

[Service]
Environment=PODMAN_SYSTEMD_UNIT=%n
Type = forking

PIDFile=%t/%n-pid
RuntimeDirectory= %n
ExecStartPre = /bin/rm -f %t/%n-pid %t/%n-cid
ExecStart = /usr/bin/podman run \
  --cgroups=no-conmon \
  --cgroups=disabled \
  --log-driver=journald \
  --cidfile %t/%n-cid \
  --conmon-pidfile %t/%n-pid \
  --detach \
  --name gobbler \
  gobb...
#
[python-discord/infra] New branch created: install\-podman
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/site] branch deleted: swfarnsworth/smarter\-resources/merge\-with\-main
odd spireBOT
regal archBOT
#

Currently the unfurl embeds provided for messages that are reported in #incidents are very helpful because they provide moderators a quick preview of the reported message, the message author ID, channel name, etc.

Moderators would also like to add the reported message's author's profile picture in the unfurl embed.

This will help give moderators a visual cue and anchor for the user's messages when reading longer conversations in public channels.

![image](https://user-images.githubu...

regal archBOT
regal archBOT
regal archBOT
#
[python-discord/site] New branch created: swfarnsworth\-google\-colab
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

Main point is just a minor issue with the docstring.

Side notes:

* [L418](https://github.com/python-discord/bot/blob/fdb702d3e186a6d5020c9b3cd32c2f0588542c56/bot/exts/filters/filtering.py#L418) uses `discord.Message` despite `Message` being imported separately (we should probably change to `Message`).

* If we change above, the only remaining usage of `discord.xxx` is `discord.Embed` and `discord.ChannelType`. If we wanted to we could remove these in favour of a ...
regal archBOT
#
regal archBOT
odd spireBOT
regal archBOT
night lilyBOT
#
Sir Lancebot

Connected!

oak estuaryBOT
regal archBOT
odd spireBOT
regal archBOT
#

I think it'd be better to put in the else of the try-except, since the exception being caught has nothing to do with this code.

Also, what do you think about defining a predicate for this in _messages.py to reduce the amount of code in the cog? I'm always concerned that the cog is growing too big and things need to be refactored out of it to stay manageable. Such predicate could probably be used by both this code and the code in the except block.

regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/site] branch deleted: swfarnsworth\-google\-colab
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: swfarnsworth\-traceback\-tag
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#

Relevant Issues

Closes #1018

Description

This PR adds topics to the .topic command for the new #programming-pedagogy channel that was recently added.

Did you:

odd spireBOT
regal archBOT
#

Besides perhaps the third question, these questions/topics are not well-suited for the .topic command. These were suggestions provided by @swfarnsworth as a primer or introduction to what pedagogy is about. However, using these questions verbatim that mention non-specific X and Ys would not be conducive to starting a discussion in that channel.

Oh alright, I see what you mean. I could try to think of some more specific ones then.

regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/site] New branch created: remove\-fa\-pro\-icons
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#

I've been having a quick look into this and how it could be implemented. This is the first time I've looked into using a server-side rendered website, let alone Django.

I am trying to get my head around how you could implement something that would use state (the user's requested theme) to serve up different stylesheets when we are using server-side rendering. I understand that Bulma is being used to created multiple themes that are {theme_name}_variables and can be served up using the `...

regal archBOT
#

The main thing missing from these changes is that file reloading does not work. Webpack-dev-server by default enables the webpack watch option, but for whatever reason, it doesn't work in the docker build. I've stumbled upon this SO post multiple times in my search, but nothing I tried worked.

Ultimately, file watching is a QoL feature. I think not having it slows down development significantly, bu...

#

I only have one code-specific comment, but can you add a few timeit tests as well? I'd say the following two will do:

  • Test setup codeblock detection
  • Submitting timeit jobs carries the correct args

I did also get an issue running this locally:

Traceback (most recent call last):
bot_1        |   File "/usr/local/lib/python3.9/site-packages/discord/ext/commands/core.py", line 167, in wrapped
bot_1        |     ret = await coro(*args, **kwargs)
bot_1        |   File "/bo...
#
[python-discord/forms-frontend] branch deleted: docker\-compose
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

Hello Joe!

I was heavily honoured to receive a review from this on this matter today. I know that time is short for everyone here, especially you, and I am glad that you managed to grant me three minutes of your free time to review this pull request.

Rest assured that I have addressed your review comment to fullest correctness by running a so-called "search-and-replace" via my text editor "neovim" by using :%s/podman/postgres/g in this file, roles/postgres/tasks/main.yml. Therefore,...

regal archBOT
#
jb3
[python-discord/infra] branch deleted: install\-podman
#

This PR overhauls the forms access system to be more dynamic and malleable using discord roles. The PR adds utilities to interact with the discord API to fetch roles and member objects, as well as modified preexisting resources to work with the new system.

Important highlights of modified resources:

  • Discord Admins can now access all forms, instead of forms admins
  • Helpers can create forms
  • Forms can be modified by anyone in any role specified in the editors in the form object (exc...
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT