#dev-log

Workflow Run

Lint & Test #1889

Source Branch

catch-403-from-Typing-calls

oak estuaryBOT Oct 4, 2021, 6:42 PM

#

Python Bot

Connected!

odd spireBOT Oct 4, 2021, 6:43 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1304856397 succeeded.

Actor

Workflow Run

Deploy #457

Commit

16918d7

regal archBOT Oct 4, 2021, 6:43 PM

#

mbaruh

[python-discord/site] New comment on issue #578: Add an endpoint to fetch user information from a username\.

@Kronifer The new API is not live at the moment, and there's no feature freeze on this repo.

odd spireBOT Oct 4, 2021, 6:52 PM

#

[python-discord/kubernetes] Checks Successful on PR: #102 Update pinned modmail hash

GitHub Actions run 1304883678 succeeded.

PR Author

Lint Kubernetes manifests #197

Workflow Run

Source Branch

update-pinned-mod...

regal archBOT Oct 4, 2021, 6:53 PM

#

jchristgit

[python-discord/api] New comment on pull request #17: Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

As for now, it wouldn't make sense to add Postgres to the CI, since we don't have any relating tests. As a possible solution, maybe I could make "database_url" Optional for now?

Could we get away with setting that to some bogus value for now? I don't think making it optional makes sense from a deployment nor testing perspective. 99% of what the API does needs the database.

Also, am I also supposed to fix linting as well? I've added a new configuration that is similar to the ones use...

odd spireBOT Oct 4, 2021, 6:54 PM

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1304888022 succeeded.

Actor

Lint Kubernetes manifests #198

Workflow Run

Commit

cbc0bfe

regal archBOT Oct 4, 2021, 7:03 PM

#

D0rs4n

[python-discord/api] New comment on pull request #17: Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

As for now, it wouldn't make sense to add Postgres to the CI, since we don't have any relating tests. As a possible solution, maybe I could make "database_url" Optional for now?

Could we get away with setting that to some bogus value for now? I don't think making it optional makes sense from a deployment nor testing perspective. 99% of what the API does needs the database.

Also, am I also supposed to fix linting as well? I've added a new configuration that is similar to th...

#

ChrisLovering

[modmail-plugins:fix\-type\-alias] 1 new commit

b38b325 Fix command alias not being a tuple - ChrisLovering

#

ChrisLovering

[python-discord/modmail-plugins] New branch created: fix\-type\-alias

#

ChrisLovering

[python-discord/modmail-plugins] Pull request opened: #8 Fix command alias not being a tuple

#

Akarys42

[python-discord/modmail-plugins] Pull request review submitted: #8 Fix command alias not being a tuple

#

ChrisLovering

[modmail-plugins] Branch fix\-type\-alias was force-pushed to `31f6d51`

#

Akarys42

[python-discord/modmail-plugins] Pull request closed: #8 Fix command alias not being a tuple

#

Akarys42

[modmail-plugins:main] 2 new commits

31f6d51 Fix command alias not being a tuple - ChrisLovering
295676e Merge pull request #8 from python-discord/fix-t... - Akarys42

#

Akarys42

[python-discord/modmail-plugins] branch deleted: fix\-type\-alias

regal archBOT Oct 4, 2021, 7:27 PM

#

ChrisLovering

[sir-lancebot:catch\-403\-from\-Typing\-calls] 1 new commit

ca1216e Monkey patch http.send_typing to catch 403s - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] New branch created: catch\-403\-from\-Typing\-calls

#

ChrisLovering

[python-discord/sir-lancebot] Pull request opened: #892 Monkey patch http\.send\_typing to catch 403s

Relevant Issues

Description

Sometimes discord turns off typing events by throwing 403's, so we should catch those

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read and agree to the [contributing guidelines](ht...

odd spireBOT Oct 4, 2021, 7:29 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #892 Monkey patch http.send_typing to catch 403s

GitHub Actions run 1305002585 succeeded.

PR Author

Workflow Run

Lint #1723

Source Branch

catch-403-from-Typing-calls

regal archBOT Oct 4, 2021, 7:30 PM

#

HassanAbouelela

[site:fix\-tests\-on\-windows] 1 new commit

67f8a3b Fixes Test Paths For Windows - HassanAbouelela

#

HassanAbouelela

[python-discord/site] New branch created: fix\-tests\-on\-windows

#

jchristgit

[python-discord/sir-lancebot] Pull request review submitted: #892 Monkey patch http\.send\_typing to catch 403s

Yes, very good. Just a small nitpick. Out of curiosity: Why datetime.now() instead of utcnow()?

#

jchristgit

[python-discord/sir-lancebot] New review comment on pull request #892: Monkey patch http\.send\_typing to catch 403s

IMO this should be a log.debug or log.trace, no? This is rather uninteresting, I think.

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #892: Monkey patch http\.send\_typing to catch 403s

this is true, we should probably update it in the other repos too

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #892: Monkey patch http\.send\_typing to catch 403s

Yes, very good. Just a small nitpick. Out of curiosity: Why datetime.now() instead of utcnow()?

no real reason for using it over utcnow(), is utcnow() preferable?

#

jchristgit

[python-discord/sir-lancebot] New comment on pull request #892: Monkey patch http\.send\_typing to catch 403s

no real reason for using it over utcnow(), is utcnow() preferable?

I think in case the time zone changes we might get weird log lines here. That happens like twice a year though, and timezones are insane anyways, just like unicode. So personally I prefer it because UTC does not change.

#

ChrisLovering

[sir-lancebot] Branch catch\-403\-from\-Typing\-calls was force-pushed to `6fbd788`

odd spireBOT Oct 4, 2021, 7:40 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #892 Monkey patch http.send_typing to catch 403s

GitHub Actions run 1305036739 succeeded.

PR Author

Workflow Run

Lint #1724

Source Branch

catch-403-from-Typing-calls

regal archBOT Oct 4, 2021, 7:41 PM

#

jchristgit

[python-discord/sir-lancebot] New comment on pull request #892: Monkey patch http\.send\_typing to catch 403s

Great work, Chris. Thanks!

#

ChrisLovering

[bot:minor\-changes\-to\-typing\-patch] 1 new commit

44e5f47 Use utcnow() and lower a logging level in patch... - ChrisLovering

#

ChrisLovering

[python-discord/bot] New branch created: minor\-changes\-to\-typing\-patch

#

ChrisLovering

[python-discord/bot] Pull request opened: #1854 Use utcnow\(\) and lower a logging level in patch\_typing

odd spireBOT Oct 4, 2021, 7:45 PM

#

[python-discord/bot] Checks Successful on PR: #1854 Use utcnow() and lower a logging level in patch_typing

GitHub Actions run 1305046031 succeeded.

PR Author

Workflow Run

Lint & Test #1891

Source Branch

minor-changes-to-typing-patch

regal archBOT Oct 4, 2021, 8:01 PM

#

TizzySaurus

[bot:antispam\-log\-improvements] 1 new commit

bcf503a Improvements to anti-spam log message - TizzySaurus

#

TizzySaurus

[python-discord/bot] New branch created: antispam\-log\-improvements

regal archBOT Oct 4, 2021, 8:33 PM

#

HassanAbouelela

[python-discord/site] Pull request opened: #596 Fixes Test Paths For Windows

Closes #566.

Fixes a test that fails on Windows due to differing path separators. This is currently the only failing test on windows.

Of note is that this doesn't implement all of 566, as I haven't included windows in the CI. Regardless, I'm pushing this now because I don't know when I'll get around to getting the CI working, and that doesn't need to block this specific bug. This will also give more time for discussion around whether Windows in CI is desirable in the first place.

#

ChrisLovering

[python-discord/site] Pull request review submitted: #596 Fixes Test Paths For Windows

odd spireBOT Oct 4, 2021, 8:35 PM

#

[python-discord/site] Checks Successful on PR: #596 Fixes Test Paths For Windows

GitHub Actions run 1305202592 succeeded.

PR Author

Workflow Run

Lint & Test #530

Source Branch

fix-tests-on-windows

regal archBOT Oct 4, 2021, 11:09 PM

#

brad90four

[python-discord/sir-lancebot] New review comment on pull request #859: Add WTF Python Command

This is what it looks like after 2197fc6:

regal archBOT Oct 5, 2021, 12:48 AM

#

aaronchall

[python-discord/site] Issue opened: #597 Discourage screenshots by those seeking help in chat

Discord voice-chat room visitors seeking help frequently post screenshots of their code.

My experience helping people in chat, Stack Overflow, and in real life (Python meetup group office hours, teaching students, etc...) is that getting screenshots instead of copy-pastable code slows the process greatly while I explain that I can't execute their pic, and what to do instead.

It would be great to have something to point them to before they start asking. Here's a part of the revision I am...

regal archBOT Oct 5, 2021, 2:00 AM

#

aaravm4

[python-discord/sir-lancebot] New comment on issue #502: Riddle command should operate like the Quiz

Im pretty busy at the moment. You can give both of my PRs to others interested.

regal archBOT Oct 5, 2021, 5:14 AM

#

gustavwilliam

[python-discord/branding] New comment on issue #155: server icon

This seems to be pretty stale, so I'm closing this. @grxpee Feel free to reach out to us in #dev-branding to discuss your ideas, if there's anything else you'd like to contribute with 😄

#

gustavwilliam

[python-discord/branding] Issue closed: #155 server icon

#

gustavwilliam

[python-discord/branding] New comment on issue #128: Create New Year's themed banner

Since we have a banner now, I'm closing this. If someone's interested in creating a new one at a future date, like you were talking about, that'll be a different issue.

#

gustavwilliam

[python-discord/branding] Issue closed: #128 Create New Year's themed banner

#

gustavwilliam

[python-discord/branding] New comment on issue #141: please make australian ducky

@lemonsaurus We do have this aura Australian ducky now:

It's not quite wearing a hat, but I assume you'd be fine with closing this issue?

regal archBOT Oct 5, 2021, 6:05 AM

#

lemonsaurus

[python-discord/branding] New comment on issue #141: please make australian ducky

not really. we should replace that duck with a true blue Australian.

regal archBOT Oct 5, 2021, 8:08 AM

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #859: Add WTF Python Command

I like that, thank you Brad.

regal archBOT Oct 5, 2021, 8:28 AM

#

TizzySaurus

[bot] Branch antispam\-log\-improvements was force-pushed to `188dd96`

#

TizzySaurus

[bot] Branch antispam\-log\-improvements was force-pushed to `269ab7e`

#

TizzySaurus

[python-discord/bot] Pull request opened: #1855 Improvements to anti\-spam logs

Closes #1850.

Messages triggering antispam which have attachments will now always be uploaded to the log site, and messages that are truncated will now be uploaded to the paste site as well as showing the truncated version of the message.

odd spireBOT Oct 5, 2021, 8:42 AM

#

[python-discord/bot] Checks Successful on PR: #1855 Improvements to anti-spam logs

GitHub Actions run 1307042021 succeeded.

PR Author

Workflow Run

Lint & Test #1892

Source Branch

antispam-log-improvements

regal archBOT Oct 5, 2021, 8:58 AM

#

Akarys42

[python-discord/bot] Pull request review submitted: #1855 Improve anti\-spam logs

I'd prefer if that check would explicitly use len()

#

Akarys42

[python-discord/bot] New review comment on pull request #1855: Improve anti\-spam logs

            len(self.messages[0].attachments) > 0,

#

TizzySaurus

[bot:defcon\-redirect\-fix] 1 new commit

5e3cf49 Add redirect message when !defcon threshold c... - TizzySaurus

#

TizzySaurus

[python-discord/bot] New branch created: defcon\-redirect\-fix

#

wookie184

[python-discord/bot] New comment on pull request #1854: Use utcnow\(\) and lower a logging level in patch\_typing

For context the reason for the now -> utcnow change is explained here: https://github.com/python-discord/sir-lancebot/pull/892#issuecomment-933795156

#

wookie184

[python-discord/bot] Pull request review submitted: #1854 Use utcnow\(\) and lower a logging level in patch\_typing

LGTM

#

TizzySaurus

[python-discord/bot] Pull request opened: #1856 Add redirect message to \`\!defcon threshold\`\.

!defcon threshold now uses the @redirect_output decorator in order to provide a redirect-messsage when command is invoked outside of #defcon.

odd spireBOT Oct 5, 2021, 9:18 AM

#

[python-discord/bot] Checks Successful on PR: #1856 Add redirect message to `!defcon threshold`.

GitHub Actions run 1307171924 succeeded.

PR Author

Workflow Run

Lint & Test #1893

Source Branch

defcon-redirect-fix

regal archBOT Oct 5, 2021, 9:35 AM

#

wookie184

[python-discord/bot] Pull request review submitted: #1856 Add redirect message to \`\!defcon threshold\`\.

I don't really mind as this is a pretty minor thing anyway, but I think just limiting the command to the defcon channel would be a bit nicer. Will approve anyway though as this works I don't think this is something that will be happen much.

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #881: Duckduckduckgoose

I agree, parentheses make sense here.

#

wookie184

[python-discord/bot] Pull request review submitted: #1831 Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

I'm not sure using log = logging.getLogger(__name__) is the best solution to the circular import problem, although i'm not sure what is either...

Other than that this looks good.

#

wookie184

[python-discord/bot] New review comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

I'm not sure this is the best option here, there was some discussion on discord on this starting here #dev-contrib message, and it seems the conclusion was that the logs here don't work anyway because this is run before logging is set up.

#

wookie184

[python-discord/bot] New review comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

Similar to other comment, although I feel we should be able to use the logger here, and using get_logger for it would be nice, although i'm not sure what the best way forwards with that is. This problem only seems to happen because this file is imported in the utils/__init__.py

regal archBOT Oct 5, 2021, 10:52 AM

#

TizzySaurus

[bot:antispam\-log\-improvements] 1 new commit

74493f2 Make attachments check explicit - TizzySaurus

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1855: Improve anti\-spam logs

Fair enough, have committed :+1:

odd spireBOT Oct 5, 2021, 10:54 AM

#

[python-discord/bot] Checks Successful on PR: #1855 Improve anti-spam logs

GitHub Actions run 1307494840 succeeded.

PR Author

Workflow Run

Lint & Test #1894

Source Branch

antispam-log-improvements

regal archBOT Oct 5, 2021, 12:18 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #1855 Improve anti\-spam logs

#

wookie184

[python-discord/bot] New review comment on pull request #1855: Improve anti\-spam logs

self.messages is a dictionary mapping message IDs to message objects, so this doesn't work.
I get this error:

bot_1        | 2021-10-05 12:13:33 | bot.utils.scheduling | ERROR | Error in task AntiSpam._process_deletion_context(frozenset({<Member id=493839819168808962 name='wookie' discriminator='4017' bot=False nick=None guild=<Guild id=813116921646022716 name="wookie's test server" shard_id=None chunked=True member_count=4>>})) 139705866738800!
bot_1        | Traceback (most recent...

#

Akarys42

[python-discord/bot] New review comment on pull request #1815: Migrate to Discord 2\.0a0

Indeed, but I am not sure how that's relevant? I could confirm through testing that's the behaviour we want

regal archBOT Oct 5, 2021, 1:00 PM

#

TizzySaurus

[bot:antispam\-log\-improvements] 1 new commit

62ec6f6 Fix if statement error - TizzySaurus

odd spireBOT Oct 5, 2021, 1:01 PM

#

[python-discord/bot] Checks Failed on PR: #1855 Improve anti-spam logs

GitHub Actions run 1307917072 failed.

PR Author

Workflow Run

Lint & Test #1895

Source Branch

antispam-log-improvements

regal archBOT Oct 5, 2021, 1:01 PM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1855: Improve anti\-spam logs

Thanks, resolved as part of 62ec6f6 :+1:

#

Akarys42

[bot:discord\-2\.0] 2 new commits

86881fd avatar.url -> display_avatar.url - Akarys42
85c30b5 Defcon: ignore create thread perms - Akarys42

odd spireBOT Oct 5, 2021, 1:06 PM

#

[python-discord/bot] Checks Failed on PR: #1815 Migrate to Discord 2.0a0

GitHub Actions run 1307929521 failed.

PR Author

Workflow Run

Lint & Test #1896

Source Branch

discord-2.0

regal archBOT Oct 5, 2021, 1:08 PM

#

Akarys42

[bot:discord\-2\.0] 1 new commit

1d886bb Test incidents: correct avatar reference - Akarys42

odd spireBOT Oct 5, 2021, 1:11 PM

#

[python-discord/bot] Checks Successful on PR: #1815 Migrate to Discord 2.0a0

GitHub Actions run 1307954303 succeeded.

PR Author

Workflow Run

Lint & Test #1897

Source Branch

discord-2.0

regal archBOT Oct 5, 2021, 1:29 PM

#

brad90four

[python-discord/sir-lancebot] Pull request review submitted: #860 Challenges

I was able to test it out this morning. Looks like it works as intended, a pretty cool command! I like the dropdowns and the views.

regal archBOT Oct 5, 2021, 1:48 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #1824 Gracefully handle invalid inventory content when adding a new doc package

All seems good to me, works nicely.

#

wookie184

[python-discord/bot] Issue opened: #1857 Logs are delayed as they wait for help commands to finish executing

I noticed that with commands sometimes logs seem to come through very late. Investigating this it seems that when a BadArgument is raised in a command, it is caught here
https://github.com/python-discord/bot/blob/16918d7c4d3925884b6ce5d1c4c326be4304f3f6/bot/exts/backend/error_handler.py#L34
which runs this https://github.com/python-discord/bot/blob/16918d7c4d3925884b6ce5d1c4c326be4304f3f6/bot/exts/backend/error_handler.py#L225
which runs await self.get_help_command(ctx) before going ...

#

wookie184

[python-discord/bot] Pull request closed: #1824 Gracefully handle invalid inventory content when adding a new doc package

#

wookie184

[python-discord/bot] Pull request reopened: #1824 Gracefully handle invalid inventory content when adding a new doc package

regal archBOT Oct 5, 2021, 2:44 PM

#

wookie184

[python-discord/bot] New comment on pull request #1855: Improve anti\-spam logs

looks good other than the linting error

regal archBOT Oct 5, 2021, 3:11 PM

#

brad90four

[python-discord/sir-lancebot] New comment on pull request #842: Add color command

Alrighty I am trying to gather my thoughts on how this would work.

There is a main entry point with

@commands.command()
async def color(self, ctx: commands.Context, *, user_input: str) -> None:

We will use regex to try to match for the modes rgb, hsv, hsl, hex, cmyk, a name or random color type. (We will still need to be able to parse out a tuple of values from the regex) This would be opposed to the "mode" method currently.

if rgb_regex_match:
    self.rgb_to_all...

#

TizzySaurus

[bot:antispam\-log\-improvements] 1 new commit

025efcd Fix linting - TizzySaurus

odd spireBOT Oct 5, 2021, 3:48 PM

#

[python-discord/bot] Checks Successful on PR: #1855 Improve anti-spam logs

GitHub Actions run 1308231107 succeeded.

PR Author

Workflow Run

Lint & Test #1898

Source Branch

antispam-log-improvements

#

[python-discord/sir-lancebot] Checks Successful on PR: #842 Add color command

GitHub Actions run 1308312085 succeeded.

PR Author

Workflow Run

Lint #1725

Source Branch

brad90four:color-677

regal archBOT Oct 5, 2021, 4:04 PM

#

TizzySaurus

[bot:defcon\-redirect\-fix] 1 new commit

a3761be Limit !defcon commands to the #defcon channel. - TizzySaurus

#

TizzySaurus

[python-discord/bot] New comment on pull request #1856: Add redirect message to \`\!defcon threshold\`\.

I don't really mind as this is a pretty minor thing anyway, but I think just limiting the command to the defcon channel would be a bit nicer. Will approve anyway though as this works I don't think this is something that will be happen much.

As discussed on discord, this has been implemented :+1:

odd spireBOT Oct 5, 2021, 4:07 PM

#

[python-discord/bot] Checks Successful on PR: #1856 Add redirect message to `!defcon threshold`.

GitHub Actions run 1308378666 succeeded.

PR Author

Workflow Run

Lint & Test #1899

Source Branch

defcon-redirect-fix

regal archBOT Oct 5, 2021, 4:09 PM

#

TizzySaurus

[bot] Branch defcon\-redirect\-fix was force-pushed to `a9d6e50`

odd spireBOT Oct 5, 2021, 4:11 PM

#

[python-discord/bot] Checks Successful on PR: #1856 Limit `!defcon` commands to #defcon

GitHub Actions run 1308394805 succeeded.

PR Author

Workflow Run

Lint & Test #1900

Source Branch

defcon-redirect-fix

regal archBOT Oct 5, 2021, 4:35 PM

#

brad90four

[python-discord/site] Pull request review submitted: #594 docs: Added site documentation for editing sir lancebot on Gitpod

LGTM, had a question regarding the order of the shell commands but were clarified in Discord.

[Message](#dev-contrib message)

#

wookie184

[python-discord/bot] Pull request review submitted: #1855 Improve anti\-spam logs

LGTM

#

wookie184

[python-discord/bot] Pull request closed: #1824 Gracefully handle invalid inventory content when adding a new doc package

#

wookie184

[python-discord/bot] Pull request reopened: #1824 Gracefully handle invalid inventory content when adding a new doc package

#

TizzySaurus

[bot] Branch defcon\-redirect\-fix was force-pushed to `1d52a42`

#

Bluenix2

[python-discord/sir-lancebot] New comment on pull request #842: Add color command

Didn't you guys figure out that you could pass rgv(r, g, b) directly to Pillow? That would help remove these "conversion methods".

odd spireBOT Oct 5, 2021, 4:45 PM

#

[python-discord/bot] Checks Successful on PR: #1824 Gracefully handle invalid inventory content when adding a new doc package

GitHub Actions run 1308507743 succeeded.

PR Author

Numerlor

Workflow Run

Lint & Test #1901

Source Branch

Numerlor:doc-fetch_inventory-err...

regal archBOT Oct 5, 2021, 4:46 PM

#

TizzySaurus

[python-discord/bot] New comment on pull request #1856: Relay \`\!defcon threshold\` message to \`ctx\.channel\` as well as \#defcon

This has been changed again, this time decision was to simply have the message relay to both ctx.channel and #defcon.

#

wookie184

[python-discord/bot] Issue closed: #1823 ValueError: invalid literal for int\(\) with base 10: ''

#

wookie184

[python-discord/bot] Pull request closed: #1824 Gracefully handle invalid inventory content when adding a new doc package

#

wookie184

[bot:main] 4 new commits

13e5379 Raise InvalidHeaderError if inventory has inval... - Numerlor
ba33608 Display BadArgument to user when invalid header... - Numerlor
8e2dca8 Merge branch 'main' into doc-fetch_inventory-er... - wookie184
e45aa66 Merge pull request #1824 from Numerlor/doc-fetc... - wookie184

odd spireBOT Oct 5, 2021, 4:46 PM

#

[python-discord/bot] Checks Successful on PR: #1856 Limit `!defcon` commands to #defcon

GitHub Actions run 1308509041 succeeded.

PR Author

Workflow Run

Lint & Test #1902

Source Branch

defcon-redirect-fix

regal archBOT Oct 5, 2021, 4:49 PM

#

Akarys42

[python-discord/bot] Pull request review submitted: #1855 Improve anti\-spam logs

Lgtm

#

Akarys42

[bot:antispam\-log\-improvements] 5 new commits

13e5379 Raise InvalidHeaderError if inventory has inval... - Numerlor
ba33608 Display BadArgument to user when invalid header... - Numerlor
8e2dca8 Merge branch 'main' into doc-fetch_inventory-er... - wookie184
e45aa66 Merge pull request #1824 from Numerlor/doc-fetc... - wookie184
ce8246f Merge branch 'main' into antispam-log-improvements - Akarys42

oak estuaryBOT Oct 5, 2021, 4:49 PM

#

Python Bot

Connected!

odd spireBOT Oct 5, 2021, 4:49 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1308523950 succeeded.

Actor

Workflow Run

Deploy #458

Commit

e45aa66

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1308522349 succeeded.

Actor

Workflow Run

Build & Deploy #5

Commit

e169d4f

regal archBOT Oct 5, 2021, 4:51 PM

#

Akarys42

[python-discord/bot] Issue closed: #1850 Always create a log if filtered messages have attachments\.

#

Akarys42

[python-discord/bot] Pull request closed: #1855 Improve anti\-spam logs

#

Akarys42

[bot:main] 6 new commits

269ab7e Improvements to anti-spam log message - TizzySaurus
74493f2 Make attachments check explicit - TizzySaurus
62ec6f6 Fix if statement error - TizzySaurus
025efcd Fix linting - TizzySaurus
ce8246f Merge branch 'main' into antispam-log-improvements - Akarys42

#

Akarys42

[python-discord/bot] branch deleted: antispam\-log\-improvements

odd spireBOT Oct 5, 2021, 4:51 PM

#

[python-discord/bot] Checks Successful on PR: #1855 Improve anti-spam logs

GitHub Actions run 1308525664 succeeded.

PR Author

Workflow Run

Lint & Test #1904

Source Branch

antispam-log-improvements

oak estuaryBOT Oct 5, 2021, 4:54 PM

#

Python Bot

Connected!

odd spireBOT Oct 5, 2021, 4:54 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1308537776 succeeded.

Actor

Workflow Run

Deploy #459

Commit

3a0ce00

regal archBOT Oct 5, 2021, 5:40 PM

#

wookie184

[python-discord/bot] New review comment on pull request #1856: Relay \`\!defcon threshold\` message to \`ctx\.channel\` as well as \#defcon

I think threshold was meant to be on the next line here :)

Also thoughts on removing the author parameter since we pass in ctx now? I can't think we'd ever want to do an updating threshold on someone elses behalf or something like that lol, reckon it'd always be ctx.author

regal archBOT Oct 5, 2021, 6:33 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #1795 Prevent repetitive stale inventory warnings from erroneously generated inventories

I'm not a redis expert but this all looks fine and from my testing seems to work well. Thanks!

#

wookie184

[python-discord/bot] Issue opened: #1858 \`\!doc setdoc\` gives malformed request error when setting a package that already exists

If you run, for example

!doc setdoc pygame https://www.pygame.org/docs/objects.inv

twice, you'll get a message saying According to the API, your request is malformed. and this error:

bot_1        | 2021-10-05 18:04:59 | bot.exts.backend.error_handler | DEBUG | API responded with 400 for command docs setdoc: {'package': ['documentation link with this package already exists.']}.

We should handle this and give the user a better error message

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1856: Relay \`\!defcon threshold\` message to \`ctx\.channel\` as well as \#defcon

I think threshold was meant to be on the next line here :)

It was indeed, thank you.

Also thoughts on removing the author parameter since we pass in ctx now?

Yeah, that seems fair enough.

Will commit both of these now :+1:

#

TizzySaurus

[bot:defcon\-redirect\-fix] 1 new commit

8722118 Fix typo and remove redundant parameter in `_up... - TizzySaurus

odd spireBOT Oct 5, 2021, 6:55 PM

#

[python-discord/bot] Checks Successful on PR: #1856 Relay `!defcon threshold` message to `ctx.channel` as well as #defcon

GitHub Actions run 1308929957 succeeded.

PR Author

Workflow Run

Lint & Test #1906

Source Branch

defcon-redirect-fix

regal archBOT Oct 5, 2021, 6:59 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #1856 Relay \`\!defcon threshold\` message to \`ctx\.channel\` as well as \#defcon

As you changed the parameters you'll need to change the function invocation too

#

TizzySaurus

[bot:defcon\-redirect\-fix] 1 new commit

c77b206 Fix _update_threshold call - TizzySaurus

odd spireBOT Oct 5, 2021, 7:07 PM

#

[python-discord/bot] Checks Successful on PR: #1856 Relay `!defcon threshold` message to `ctx.channel` as well as #defcon

GitHub Actions run 1308972625 succeeded.

PR Author

Workflow Run

Lint & Test #1907

Source Branch

defcon-redirect-fix

regal archBOT Oct 5, 2021, 7:24 PM

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #860 Challenges

Played around with it, I am satisfied with it now haha. Good job.

Thanks Shom.

#

Shom770

[python-discord/sir-lancebot] New comment on pull request #860: Challenges

Thank you so much @brad90four and @Bluenix2!

#

TizzySaurus

[bot] Branch custom\-logger\-class was force-pushed to `4355cf2`

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

This has been resolved with the little re-write :+1:

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

This has been resolved with the little re-write :+1:

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #859 Add WTF Python Command

Can we have the command have some minimum threshold?

I tried it with the start of the Bee Movie script, first few seconds of Nicki Minaj's superbass, first page of the Bible, the first sentence of the FitnessGram PACER Test, a paragraph about the MRSA bacteria, the MIT license and your name....

but it wasn't until I brought out the morse code of "Hello World" and Never Gonna Give You Up music video link that I got a failure.

regal archBOT Oct 5, 2021, 7:55 PM

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #857 Add support to query AoC results in respect of days and stars

Looks good now, thanks D0rs4n.

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #880 Add a 5 minute cooldown to the topic command

I would perhaps advocate for a 3 minute cooldown. The cooldown still does its job but we limit the "false positives" (as in, times where the cooldown prohibits usage we want to support).

Either way, it works!

#

Bluenix2

[python-discord/bot] Pull request review submitted: #1854 Use utcnow\(\) and lower a logging level in patch\_typing

Of course we don't get 403s anymore, but this should work considering you changed the time both where it is read and where it is set.

#

TizzySaurus

[bot] Branch custom\-logger\-class was force-pushed to `6840dca`

odd spireBOT Oct 5, 2021, 8:12 PM

#

[python-discord/bot] Checks Failed on PR: #1831 Add `CustomLogger` to prevent IDE lint warnings when calling `log.trace`.

GitHub Actions run 1309183922 failed.

PR Author

Workflow Run

Lint & Test #1908

Source Branch

custom-logger-class

regal archBOT Oct 5, 2021, 8:15 PM

#

Bluenix2

[python-discord/bot] New comment on pull request #1815: Migrate to Discord 2\.0a0

I found some datetimes where the timezones haven't been replaced, should they be? See the following Sourcegraph searches:

#

TizzySaurus

[bot] Branch custom\-logger\-class was force-pushed to `b7cc69f`

odd spireBOT Oct 5, 2021, 8:22 PM

#

[python-discord/bot] Checks Successful on PR: #1831 Add `CustomLogger` to prevent IDE lint warnings when calling `log.trace`.

GitHub Actions run 1309213211 succeeded.

PR Author

Workflow Run

Lint & Test #1909

Source Branch

custom-logger-class

regal archBOT Oct 5, 2021, 8:30 PM

#

TizzySaurus

[bot] Branch custom\-logger\-class was force-pushed to `4b8aea9`

#

HassanAbouelela

[python-discord/site] Pull request opened: #598 Fix http links

#

HassanAbouelela

[python-discord/site] New comment on pull request #598: Fix http links

Did not mean to create it to this repo, please ignore.

#

HassanAbouelela

[python-discord/site] Pull request closed: #598 Fix http links

odd spireBOT Oct 5, 2021, 8:32 PM

#

[python-discord/bot] Checks Successful on PR: #1831 Add `CustomLogger` to prevent IDE lint warnings when calling `log.trace`.

GitHub Actions run 1309243875 succeeded.

PR Author

Workflow Run

Lint & Test #1910

Source Branch

custom-logger-class

#

[python-discord/site] Checks Successful on PR: #598 Fix http links

GitHub Actions run 1309245001 succeeded.

PR Author

Workflow Run

Lint & Test #531

Source Branch

HassanAbouelela:fix-http-l...

regal archBOT Oct 5, 2021, 8:32 PM

#

TizzySaurus

[python-discord/bot] New comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

Have fixed the root issue of the circular imports, so now all files should be using bot.log.get_logger instead of logging.getLogger.

Also added any missing migrations from PRs made after I started this and squashed, fixed the conflicts (all 25), and did a commit for making newlines after imports consistent (part of PyCharm's "Optimize Imports" feature).

This should now be fully read for review @kosayoda @wookie184 :+1:

#

TizzySaurus

[bot] Branch defcon\-redirect\-fix was force-pushed to `67140b3`

#

HassanAbouelela

[site:fix\-http\-links] 1 new commit

26be9be Switches HTTP Links To HTTPS - HassanAbouelela

#

HassanAbouelela

[python-discord/site] New branch created: fix\-http\-links

odd spireBOT Oct 5, 2021, 8:42 PM

#

[python-discord/bot] Checks Successful on PR: #1856 Relay `!defcon threshold` message to `ctx.channel` as well as #defcon

GitHub Actions run 1309276270 succeeded.

PR Author

Workflow Run

Lint & Test #1911

Source Branch

defcon-redirect-fix

regal archBOT Oct 5, 2021, 8:42 PM

#

TizzySaurus

[bot] Branch defcon\-redirect\-fix was force-pushed to `34bced3`

odd spireBOT Oct 5, 2021, 8:44 PM

#

[python-discord/bot] Checks Successful on PR: #1856 Relay `!defcon threshold` message to `ctx.channel` as well as #defcon

GitHub Actions run 1309285078 succeeded.

PR Author

Workflow Run

Lint & Test #1912

Source Branch

defcon-redirect-fix

regal archBOT Oct 5, 2021, 8:44 PM

#

TizzySaurus

[python-discord/bot] New comment on pull request #1856: Relay \`\!defcon threshold\` message to \`channel\` as well as \#defcon

Fixed the issues with this and squashed down to one commit.

Should be ready for re-review @wookie184 :+1:

#

HassanAbouelela

[python-discord/site] Pull request opened: #599 Switches HTTP Links To HTTPS

Switches the protocol for external sites where possible. Some sites don't have secure versions, and were skipped.

The skipped sites are:

http://pyglet.org/ (Under resources/communities)
http://data8.org/ (Part of the description of the book Inferential Thinking

The motivation for this PR is that there is no reason to use insecure links on our site (and more accurately, I needed to fix them for something I'm working on), and it's easy enough to switch them out and review.

I'...

odd spireBOT Oct 5, 2021, 8:48 PM

#

[python-discord/site] Checks Successful on PR: #599 Switches HTTP Links To HTTPS

GitHub Actions run 1309297456 succeeded.

PR Author

Workflow Run

Lint & Test #532

Source Branch

fix-http-links

regal archBOT Oct 5, 2021, 8:48 PM

#

Kronifer

[python-discord/site] Pull request review submitted: #599 Switches HTTP Links To HTTPS

lgtm

#

mbaruh

[python-discord/site] Pull request review submitted: #599 Switches HTTP Links To HTTPS

Visited the links, seems fine.

odd spireBOT Oct 5, 2021, 9:13 PM

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1309381089 succeeded.

Actor

Workflow Run

Build & Deploy #7

Commit

2af0f42

regal archBOT Oct 5, 2021, 9:25 PM

#

jchristgit

[python-discord/bot] Pull request review submitted: #1806 Apply infractions before DMing

Yup. Yup. Yup. Yup. Yup. Yup.

#

jchristgit

[python-discord/bot] Pull request review submitted: #1798 Prevent role hierarchy issues with infractions

I like this. One minor nitpick. Feel free to ignore it completely.

#

jchristgit

[python-discord/bot] New review comment on pull request #1798: Prevent role hierarchy issues with infractions

in which cases do we have a top_role here? In case this is a member, right? Would it be cleaner to check for isinstance here then? That may help some typecheckers.

#

jchristgit

[python-discord/bot] Pull request review submitted: #1854 Use utcnow\(\) and lower a logging level in patch\_typing

Thanks, Chris. This is rock solid.

#

jchristgit

[bot:minor\-changes\-to\-typing\-patch] 11 new commits

13e5379 Raise InvalidHeaderError if inventory has inval... - Numerlor
ba33608 Display BadArgument to user when invalid header... - Numerlor
269ab7e Improvements to anti-spam log message - TizzySaurus
74493f2 Make attachments check explicit - TizzySaurus
62ec6f6 Fix if statement error - TizzySaurus

#

jchristgit

[python-discord/bot] Pull request closed: #1854 Use utcnow\(\) and lower a logging level in patch\_typing

#

jchristgit

[python-discord/bot] branch deleted: minor\-changes\-to\-typing\-patch

#

jchristgit

[bot:main] 3 new commits

44e5f47 Use utcnow() and lower a logging level in patch... - ChrisLovering
c672e34 Merge branch 'main' into minor-changes-to-typin... - jchristgit
7d7af13 Merge pull request #1854 from python-discord/mi... - jchristgit

odd spireBOT Oct 5, 2021, 9:32 PM

#

[python-discord/bot] Checks Successful on PR: #1854 Use utcnow() and lower a logging level in patch_typing

GitHub Actions run 1309434102 succeeded.

PR Author

Workflow Run

Lint & Test #1913

Source Branch

minor-changes-to-typing-patch

regal archBOT Oct 5, 2021, 9:33 PM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1798: Prevent role hierarchy issues with infractions

Yeah, top_role is when it's a discord.Member. I'm not sure whether I did hasattr instead of isinstance for a reason or not. I'll check and see - if there's no real reason then isinstanace is probably much clearer.

oak estuaryBOT Oct 5, 2021, 9:34 PM

#

Python Bot

Connected!

odd spireBOT Oct 5, 2021, 9:34 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1309446279 succeeded.

Actor

Workflow Run

Deploy #460

Commit

7d7af13

regal archBOT Oct 5, 2021, 9:37 PM

#

TizzySaurus

[bot:ignore\-infra\-mods\-errors] 1 new commit

a9b02a5 Use isinstance instead of hasattr to determ... - TizzySaurus

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1798: Prevent role hierarchy issues with infractions

Couldn't see a logical reason to stick to hasattr, so have pushed a commit changing to isinstance :+1:

Thanks for the review :+1:

odd spireBOT Oct 5, 2021, 9:39 PM

#

[python-discord/bot] Checks Successful on PR: #1798 Prevent role hierarchy issues with infractions

GitHub Actions run 1309455484 succeeded.

PR Author

Workflow Run

Lint & Test #1915

Source Branch

ignore-infra-mods-errors

regal archBOT Oct 5, 2021, 9:41 PM

#

jchristgit

[python-discord/site] Pull request review submitted: #508 offtopicnames active attribute and support for PUT and PATCH request

I like this. I have a few questions, but apart from that, I like this.

#

jchristgit

[python-discord/site] New review comment on pull request #508: offtopicnames active attribute and support for PUT and PATCH request

We are on Python 3.9 here, so we could just use list directly, right?

#

jchristgit

[python-discord/site] New review comment on pull request #508: offtopicnames active attribute and support for PUT and PATCH request

        Return a list with all `OffTopicChannelName`s in the database.

#

jchristgit

[python-discord/site] New review comment on pull request #508: offtopicnames active attribute and support for PUT and PATCH request

I'm kind of 50 / 50 on overriding this to add our own arguments, because this
is also called by REST Framework from what I know. That said, we also have
other places where this method is called, and .filter() is called again on it
right after. Would it make more sense to stick with the definition as-is
(without the changes from all) and update the get_queryset(**params) call
from below to perform the filter itself?

#

jb3

[python-discord/bot] Pull request review submitted: #1806 Apply infractions before DMing

#

wookie184

[python-discord/bot] Pull request review submitted: #1856 Relay \`\!defcon threshold\` message to \`channel\` as well as \#defcon

LGTM, thanks :D

#

jb3

[bot:infract\-then\-dm] 52 new commits

13e5379 Raise InvalidHeaderError if inventory has inval... - Numerlor
ba33608 Display BadArgument to user when invalid header... - Numerlor
6fb6967 Use scheduling create_task util instead of crea... - Numerlor
f6a02d8 Use create_task util instead of asyncio.create_... - Numerlor
71ce990 Adds Core Dev Voting To Changelog Blacklist - HassanAbouelela

#

jb3

[python-discord/bot] Pull request review submitted: #1798 Prevent role hierarchy issues with infractions

#

jb3

[bot:ignore\-infra\-mods\-errors] 109 new commits

78b00dc Remove WatchChannel parent of TalentPool and mi... - ks129
dda3490 Use more accurate command names and docstring f... - ks129
f144bac Migrate nominations history command to non-watc... - ks129
807a27e Migrate Talent Pool Reviewer class to non-watch... - ks129
2d47640 Migrate unnominate command to non-watchchannel - ks129

#

jchristgit

[python-discord/bot] Issue closed: #1805 Apply infraction before DMing the user

#

jchristgit

[python-discord/bot] Pull request closed: #1806 Apply infractions before DMing

#

jchristgit

[python-discord/bot] branch deleted: infract\-then\-dm

#

jchristgit

[bot:main] 3 new commits

e026c3e Apply infractions before DMing - TizzySaurus
924b063 Merge branch 'main' into infract-then-dm - jb3
5127a88 Merge pull request #1806 from python-discord/in... - jchristgit

odd spireBOT Oct 5, 2021, 9:43 PM

#

[python-discord/bot] Checks Successful on PR: #1806 Apply infractions before DMing

GitHub Actions run 1309469618 succeeded.

PR Author

Workflow Run

Lint & Test #1916

Source Branch

infract-then-dm

#

[python-discord/bot] Checks Successful on PR: #1798 Prevent role hierarchy issues with infractions

GitHub Actions run 1309471130 succeeded.

PR Author

Workflow Run

Lint & Test #1917

Source Branch

ignore-infra-mods-errors

oak estuaryBOT Oct 5, 2021, 9:46 PM

#

Python Bot

Connected!

odd spireBOT Oct 5, 2021, 9:46 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1309478742 succeeded.

Actor

Workflow Run

Deploy #461

Commit

5127a88

regal archBOT Oct 5, 2021, 9:57 PM

#

TizzySaurus

[bot:ignore\-infra\-mods\-errors] 4 new commits

e026c3e Apply infractions before DMing - TizzySaurus
924b063 Merge branch 'main' into infract-then-dm - jb3
5127a88 Merge pull request #1806 from python-discord/in... - jchristgit
dcd1b45 Merge branch 'main' into ignore-infra-mods-errors - TizzySaurus

#

jchristgit

[python-discord/bot] Issue closed: #1780 Suppress exceptions for infraction attempts on mods\+

#

jchristgit

[python-discord/bot] Pull request closed: #1798 Prevent role hierarchy issues with infractions

#

jchristgit

[bot:main] 7 new commits

8e25ed1 Prevent infractions raising error due to role h... - TizzySaurus
8fa3fa1 Fix role hierarchy check - TizzySaurus
38dc1c6 Fix tests - TizzySaurus
a9b02a5 Use isinstance instead of hasattr to determ... - TizzySaurus
9baf7bd Merge branch 'main' into ignore-infra-mods-errors - jb3

#

jchristgit

[python-discord/bot] branch deleted: ignore\-infra\-mods\-errors

odd spireBOT Oct 5, 2021, 9:59 PM

#

[python-discord/bot] Checks Successful on PR: #1798 Prevent role hierarchy issues with infractions

GitHub Actions run 1309507462 succeeded.

PR Author

Workflow Run

Lint & Test #1919

Source Branch

ignore-infra-mods-errors

oak estuaryBOT Oct 5, 2021, 10:02 PM

#

Python Bot

Connected!

odd spireBOT Oct 5, 2021, 10:02 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1309519188 succeeded.

Actor

Workflow Run

Deploy #462

Commit

8ec4593

regal archBOT Oct 5, 2021, 10:18 PM

#

HassanAbouelela

[site:netlify\-logo] 2 new commits

b8466fc Properly Resize Sponsor Logos - HassanAbouelela
bc1aae0 Adds Netlify To Sponsors - HassanAbouelela

#

HassanAbouelela

[python-discord/site] New branch created: netlify\-logo

#

HassanAbouelela

[python-discord/site] Pull request opened: #600 Add Netlify Logo To Sponsors

I added the netlify logo to sponsors in preparation for an upcoming change, as well as fixing the CSS to properly resize and place the logos, especially on smaller screens.

odd spireBOT Oct 5, 2021, 10:21 PM

#

[python-discord/site] Checks Successful on PR: #600 Add Netlify Logo To Sponsors

GitHub Actions run 1309570938 succeeded.

PR Author

Workflow Run

Lint & Test #533

Source Branch

netlify-logo

regal archBOT Oct 5, 2021, 10:23 PM

#

HassanAbouelela

[python-discord/site] New comment on pull request #600: Add Netlify Logo To Sponsors

Here's a preview while I'm at it:
https://615ccfda79588300073258a3--pydis-static.netlify.app/

regal archBOT Oct 5, 2021, 11:05 PM

#

jb3

[site:jb3/yes\-to\-www] 1 new commit

43acf90 Add www.pythondiscord.com to ALLOWED_HOSTS - jb3

#

jb3

[python-discord/site] New branch created: jb3/yes\-to\-www

#

jb3

[python-discord/site] Pull request opened: #601 Add www\.pythondiscord\.com to ALLOWED\_HOSTS

Preparing for our move to www.pythondiscord.com

odd spireBOT Oct 5, 2021, 11:07 PM

#

[python-discord/site] Checks Successful on PR: #601 Add www.pythondiscord.com to ALLOWED_HOSTS

GitHub Actions run 1309684636 succeeded.

PR Author

Workflow Run

Lint & Test #534

Source Branch

jb3/yes-to-www

regal archBOT Oct 5, 2021, 11:09 PM

#

jb3

[python-discord/site] Pull request review submitted: #600 Add Netlify Logo To Sponsors

#

HassanAbouelela

[python-discord/site] Pull request review submitted: #601 Add www\.pythondiscord\.com to ALLOWED\_HOSTS

#

HassanAbouelela

[python-discord/site] Pull request closed: #594 docs: Added site documentation for editing sir lancebot on Gitpod

#

HassanAbouelela

[site:main] 1 new commit

81054bd Merge Gitpod Docs (#594) - Kronifer

#

jb3

[site:jb3/yes\-to\-www] 1 new commit

5ea9be5 Update PARENT_HOST with www-prefixed URL - jb3

odd spireBOT Oct 5, 2021, 11:14 PM

#

[python-discord/site] Checks Successful on PR: #594 docs: Added site documentation for editing sir lancebot on Gitpod

GitHub Actions run 1309702365 succeeded.

PR Author

Workflow Run

Lint & Test #535

Source Branch

Kronifer:patch-2

regal archBOT Oct 5, 2021, 11:15 PM

#

jb3

[site:jb3/yes\-to\-www] 2 new commits

81054bd Merge Gitpod Docs (#594) - Kronifer
aae250e Merge branch 'main' into jb3/yes-to-www - jb3

odd spireBOT Oct 5, 2021, 11:15 PM

#

[python-discord/site] Checks Successful on PR: #601 Add www.pythondiscord.com to ALLOWED_HOSTS

GitHub Actions run 1309705568 succeeded.

PR Author

Workflow Run

Lint & Test #537

Source Branch

jb3/yes-to-www

#

[python-discord/site] Checks Successful on PR: #601 Add www.pythondiscord.com to ALLOWED_HOSTS

GitHub Actions run 1309708730 succeeded.

PR Author

Workflow Run

Lint & Test #538

Source Branch

jb3/yes-to-www

regal archBOT Oct 5, 2021, 11:17 PM

#

jb3

[site:jb3/yes\-to\-www] 1 new commit

7595399 Revert "Update PARENT_HOST with www-prefixed URL" - jb3

odd spireBOT Oct 5, 2021, 11:17 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 1309710522 succeeded.

Actor

Workflow Run

Deploy #130

Commit

81054bd

regal archBOT Oct 5, 2021, 11:18 PM

#

ChrisLovering

[python-discord/site] Pull request review submitted: #601 Add www\.pythondiscord\.com to ALLOWED\_HOSTS

#

jb3

[python-discord/site] Pull request closed: #601 Add www\.pythondiscord\.com to ALLOWED\_HOSTS

#

jb3

[site:main] 1 new commit

8f596f3 Add www.pythondiscord.com to ALLOWED_HOSTS (#601) - jb3

#

jb3

[python-discord/site] branch deleted: jb3/yes\-to\-www

odd spireBOT Oct 5, 2021, 11:19 PM

#

[python-discord/site] Checks Successful on PR: #601 Add www.pythondiscord.com to ALLOWED_HOSTS

GitHub Actions run 1309714312 succeeded.

PR Author

Workflow Run

Lint & Test #539

Source Branch

jb3/yes-to-www

#

[python-discord/site] Workflow Successful

GitHub Actions run 1309721110 succeeded.

Actor

Workflow Run

Deploy #131

Commit

8f596f3

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1309754381 succeeded.

Actor

Workflow Run

Build & Deploy #8

Commit

243299d

regal archBOT Oct 5, 2021, 11:36 PM

#

jb3

[site:jb3/yes\-to\-www\-take\-two] 1 new commit

b5b49ef Update hosts.py to default to www - jb3

#

jb3

[python-discord/site] New branch created: jb3/yes\-to\-www\-take\-two

#

jb3

[python-discord/site] Pull request opened: #602 Update hosts\.py to default to www

Attempt two at #601

odd spireBOT Oct 5, 2021, 11:38 PM

#

[python-discord/site] Checks Successful on PR: #602 Update hosts.py to default to www

GitHub Actions run 1309760983 succeeded.

PR Author

Workflow Run

Lint & Test #541

Source Branch

jb3/yes-to-www-take-two

regal archBOT Oct 5, 2021, 11:38 PM

#

HassanAbouelela

[python-discord/site] Pull request review submitted: #602 Update hosts\.py to default to www

regal archBOT Oct 5, 2021, 11:55 PM

#

ChrisLovering

[python-discord/site] Pull request review submitted: #602 Update hosts\.py to default to www

#

ChrisLovering

[python-discord/site] Pull request closed: #602 Update hosts\.py to default to www

#

ChrisLovering

[python-discord/site] branch deleted: jb3/yes\-to\-www\-take\-two

#

ChrisLovering

[site:main] 2 new commits

b5b49ef Update hosts.py to default to www - jb3
1f334f2 Merge pull request #602 from python-discord/jb3... - ChrisLovering

odd spireBOT Oct 5, 2021, 11:59 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 1309805668 succeeded.

Actor

Workflow Run

Deploy #132

Commit

1f334f2

odd spireBOT Oct 6, 2021, 12:24 AM

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1309877981 succeeded.

Actor

Lint Kubernetes manifests #199

Workflow Run

Commit

9248798

odd spireBOT Oct 6, 2021, 1:10 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #859 Add WTF Python Command

GitHub Actions run 1310003706 succeeded.

PR Author

Workflow Run

Lint #1726

Source Branch

brad90four:feature/wtf-python

regal archBOT Oct 6, 2021, 1:11 AM

#

brad90four

[python-discord/site] Pull request review submitted: #591 Restructure bot contributing guide

LGTM!

Perfect timing too, I just got bot and site set up and this is pretty much exactly what I followed.

#

jb3

[site:netlify\-logo] 5 new commits

81054bd Merge Gitpod Docs (#594) - Kronifer
8f596f3 Add www.pythondiscord.com to ALLOWED_HOSTS (#601) - jb3
b5b49ef Update hosts.py to default to www - jb3
1f334f2 Merge pull request #602 from python-discord/jb3... - ChrisLovering
8e6aeed Merge branch 'main' into netlify-logo - jb3

odd spireBOT Oct 6, 2021, 1:22 AM

#

[python-discord/site] Checks Successful on PR: #600 Add Netlify Logo To Sponsors

GitHub Actions run 1310025249 succeeded.

PR Author

Workflow Run

Lint & Test #543

Source Branch

netlify-logo

regal archBOT Oct 6, 2021, 1:41 AM

#

Den4200

[python-discord/site] Pull request review submitted: #600 Add Netlify Logo To Sponsors

#

jb3

[python-discord/site] Pull request closed: #600 Add Netlify Logo To Sponsors

#

jb3

[site:main] 4 new commits

b8466fc Properly Resize Sponsor Logos - HassanAbouelela
bc1aae0 Adds Netlify To Sponsors - HassanAbouelela
8e6aeed Merge branch 'main' into netlify-logo - jb3
02e1ce2 Merge pull request #600 from python-discord/net... - jb3

#

jb3

[python-discord/site] branch deleted: netlify\-logo

odd spireBOT Oct 6, 2021, 1:45 AM

#

[python-discord/site] Workflow Successful

GitHub Actions run 1310069159 succeeded.

Actor

Workflow Run

Deploy #133

Commit

02e1ce2

regal archBOT Oct 6, 2021, 1:53 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #892 Monkey patch http\.send\_typing to catch 403s

#

jchristgit

[python-discord/sir-lancebot] Pull request closed: #892 Monkey patch http\.send\_typing to catch 403s

#

jchristgit

[python-discord/sir-lancebot] branch deleted: catch\-403\-from\-Typing\-calls

#

jchristgit

[sir-lancebot:main] 2 new commits

6fbd788 Monkey patch http.send_typing to catch 403s - ChrisLovering
a1c7a20 Merge pull request #892 from python-discord/cat... - jchristgit

night lilyBOT Oct 6, 2021, 1:55 AM

#

Sir Lancebot

Connected!

odd spireBOT Oct 6, 2021, 1:55 AM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1310092354 succeeded.

Actor

Workflow Run

Build #449

Commit

a1c7a20

regal archBOT Oct 6, 2021, 10:53 AM

#

wookie184

[python-discord/bot] Pull request review submitted: #1831 Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

Two small things, other than that it looks good.

#

wookie184

[python-discord/bot] New review comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

The comment above the print here doesn't really make sense any more, i'd say it could just be removed

#

wookie184

[python-discord/bot] New review comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

Need an exception class here, KeyError would probably be good, So raise KeyError("message"). That or we could print and then just raise, maybe that would be better as it would keep the context of where the KeyError was raised? Can't remember exactly how these things work

regal archBOT Oct 6, 2021, 1:17 PM

#

Akarys42

[bot:revert\-1806\-infract\-then\-dm] 1 new commit

c3eccad Revert "Apply infractions before DMing" - Akarys42

#

Akarys42

[python-discord/bot] New branch created: revert\-1806\-infract\-then\-dm

#

Akarys42

[python-discord/bot] Pull request opened: #1859 Revert "Apply infractions before DMing"

Reverts python-discord/bot#1806

This causes notes to send DMs

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #1859 Revert "Apply infractions before DMing"

#

mbaruh

[python-discord/bot] Pull request review submitted: #1859 Revert "Apply infractions before DMing"

#

Akarys42

[python-discord/bot] Pull request closed: #1859 Revert "Apply infractions before DMing"

#

Akarys42

[bot:main] 2 new commits

c3eccad Revert "Apply infractions before DMing" - Akarys42
de031ad Merge pull request #1859 from python-discord/re... - Akarys42

#

Akarys42

[python-discord/bot] branch deleted: revert\-1806\-infract\-then\-dm

#

Akarys42

[python-discord/bot] Issue reopened: #1805 Apply infraction before DMing the user

odd spireBOT Oct 6, 2021, 1:30 PM

#

[python-discord/bot] Checks Successful on PR: #1859 Revert "Apply infractions before DMing"

GitHub Actions run 1312041625 succeeded.

PR Author

Workflow Run

Lint & Test #1921

Source Branch

revert-1806-infract-then-dm

regal archBOT Oct 6, 2021, 1:36 PM

#

TizzySaurus

[bot:fix\-infract\-then\-dm] 1 new commit

acc3e6f Attempt infraction before DMing - TizzySaurus

#

TizzySaurus

[python-discord/bot] New branch created: fix\-infract\-then\-dm

#

TizzySaurus

[python-discord/bot] Pull request opened: #1860 Attempt infraction before DMing

Closes #1805

A fix for #1806.

This time it won't DM when it's not supposed to :p

oak estuaryBOT Oct 6, 2021, 1:39 PM

#

Python Bot

Connected!

odd spireBOT Oct 6, 2021, 1:40 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1312107823 succeeded.

Actor

Workflow Run

Deploy #463

Commit

de031ad

regal archBOT Oct 6, 2021, 1:42 PM

#

TizzySaurus

[bot:fix\-infract\-then\-dm] 3 new commits

c3eccad Revert "Apply infractions before DMing" - Akarys42
de031ad Merge pull request #1859 from python-discord/re... - Akarys42
d01dd7d Merge branch 'main' into fix-infract-then-dm - TizzySaurus

odd spireBOT Oct 6, 2021, 1:45 PM

#

[python-discord/bot] Checks Successful on PR: #1860 Attempt infraction before DMing

GitHub Actions run 1312127145 succeeded.

PR Author

Workflow Run

Lint & Test #1923

Source Branch

fix-infract-then-dm

regal archBOT Oct 6, 2021, 1:57 PM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

Removed :+1:

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1831: Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

You'll still keep the context with a raise KeyError("message") so have gone for that.

>>> try:
	1 / 0
except ZeroDivisionError:
	raise ZeroDivisionError("hello")

Traceback (most recent call last):
  File "<pyshell#4>", line 2, in <module>
    1 / 0
ZeroDivisionError: division by zero

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<pyshell#4>", line 4, in <module>
    raise ZeroDivisionError("hello")
Ze...

#

TizzySaurus

[bot:custom\-logger\-class] 1 new commit

21fa40c Address review - TizzySaurus

odd spireBOT Oct 6, 2021, 2:01 PM

#

[python-discord/bot] Checks Successful on PR: #1831 Add `CustomLogger` to prevent IDE lint warnings when calling `log.trace`.

GitHub Actions run 1312189503 succeeded.

PR Author

Workflow Run

Lint & Test #1924

Source Branch

custom-logger-class

regal archBOT Oct 6, 2021, 2:10 PM

#

TizzySaurus

[bot:solve\-bot\-1852] 1 new commit

53e3d22 Distinguish between note/warning and expired in... - TizzySaurus

#

TizzySaurus

[python-discord/bot] New branch created: solve\-bot\-1852

#

TizzySaurus

[python-discord/bot] Pull request opened: #1861 Distinguish between note/warning and expired infraction

Closes #1852.

Error message when editing infraction now distinguishes between a note/warning and an actual expired infraction.

Also made it so that editing reason will fail when date failed to change.

odd spireBOT Oct 6, 2021, 2:15 PM

#

[python-discord/bot] Checks Successful on PR: #1861 Distinguish between note/warning and expired infraction

GitHub Actions run 1312251154 succeeded.

PR Author

Workflow Run

Lint & Test #1925

Source Branch

solve-bot-1852

regal archBOT Oct 6, 2021, 5:16 PM

#

SebastiaanZ

[python-discord/modmail-plugins] Pull request review submitted: #4 Add a ping manager plugin

Save point to already share the two comments/questions I had. I'll continue reviewing later.

#

SebastiaanZ

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

According to the modmail bot repository, the plugin_db is deprecated. I think it simply relays to a method of bot.api.db now:

    def get_partition(self, cog):
        cls_name = cog.__class__.__name__
        return self.bot.api.db.plugins[cls_name]

I can't find it that quickly, but I think the intended way is to use that directly now.

#

SebastiaanZ

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

Since you don't pass an event loop, this will eventually call asyncio.create_task directly, right? In bot, we don't do that because the event loop is typically not running yet when Cogs are initialized by the bot. (Or is that outdated? I'm getting a bit d.py rusty.)

asyncio.create_task requires a running event loop.

#

doublevcodes

[python-discord/sir-lancebot] New comment on pull request #842: Add color command

Update

After much discussion (please refer to the conversation in #dev-contrib starting [here](#dev-contrib message), it has been decided to change the way the user interacts with this command.

<details>
<summary>Expand for the full new usage specification</summary>
<br/>

Command name: colour (alias color)
Subcommands:
- rgb - <red> <green> <blue>
- `hsl - <hue> <saturation> <lightne...

#

brad90four

[python-discord/sir-lancebot] New comment on pull request #842: Add color command

Update

After much discussion (please refer to the conversation in #dev-contrib starting [here](#dev-contrib message), it has been decided to change the way the user interacts with this command.
Expand for the full new usage specification
* Command name: `colour` (alias `color`)

* Subcommands:
  
  * `rgb - <red> <green> <blue>`
  * `hsl - <hue> <saturation> <...

regal archBOT Oct 6, 2021, 5:56 PM

#

doublevcodes

[python-discord/api] Pull request review submitted: #17 Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

#

SebastiaanZ

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

Why is this called when_to_close? Wouldn't when_to_ping be more descriptive? Or am I misunderstanding the purpose of this class?

#

SebastiaanZ

[python-discord/modmail-plugins] Pull request review submitted: #4 Add a ping manager plugin

Some comments/questions, but feel free to dismiss them without implementing them. They're not too pressing.

#

SebastiaanZ

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

If some other exception happened (e.g., another outage in the Discord API), the task will not be removed. I assume this is intended behavior to ensure that the bot will retry the ping later. If not, one option would be to use a finally clause to ensure that the clean-up stage is always attempted regardless of failures.

#

SebastiaanZ

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

In theory, this could lead to an inconsistent state between the database and the cached ping_tasks list if the database operation fails for some reason (e.g., network issues). Would that cause issues? Handling that situation also requires a bit of messy logic, so if it's not needed, I wouldn't add it.

Another option here would be to create a layer of abstraction (e.g., using a repository pattern) that manages both the local cache and the remote database, keeping them in sync and failing ...

#

jchristgit

[python-discord/api] Pull request review submitted: #17 Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

Rock solid.

regal archBOT Oct 6, 2021, 6:46 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review dismissed: #860 Challenges

I am currently getting an error when trying to run this. It seems to be here:

 first_kata_div = await to_thread(soup.find_all("div", class_="item-title px-0"))

to_thread takes a function as the argument for what to run, this is instead running soup.find_all and passing the result to to_thread, which causes an error. Looking at the docs, https://docs.python.org/3/library/asyncio-task.html#asyncio.to_thread,
it seems something like

first_kata_div = await ...

#

TizzySaurus

[python-discord/sir-lancebot] Pull request review dismissed: #860 Challenges

A lot of these are nitpicks and up to you whether you implement, but I do feel the following should be addressed:

L101-L102
trailing commas
the split __init__ function
the inconsistency of "kata" vs "Kata"
the inconsistency of "codewars.com" vs "`codewards.com`"

regal archBOT Oct 6, 2021, 7:14 PM

#

doublevcodes

[python-discord/api] Pull request opened: #18 Make development workflow easier to use

This PR introduces changes such as:
- chore: Replace tool.poetry.description with GitHub repository description to be consistent

deps: Add taskipy as a development dependency
feat: Add new taskipy tasks to aid with development

#

wookie184

[branding:main] 2 new commits

b39904b Add halloween event and assets - wookie184
637faa8 Remove old halloween assets - wookie184

odd spireBOT Oct 6, 2021, 7:15 PM

#

[python-discord/branding] Workflow Successful

GitHub Actions run 1313316519 succeeded.

Actor

Workflow Run

Event Validation #44

Commit

637faa8

regal archBOT Oct 6, 2021, 7:33 PM

#

ChrisLovering

[python-discord/site] Pull request review submitted: #599 Switches HTTP Links To HTTPS

#

ChrisLovering

[site:fix\-http\-links] 9 new commits

b8466fc Properly Resize Sponsor Logos - HassanAbouelela
bc1aae0 Adds Netlify To Sponsors - HassanAbouelela
81054bd Merge Gitpod Docs (#594) - Kronifer
8f596f3 Add www.pythondiscord.com to ALLOWED_HOSTS (#601) - jb3
b5b49ef Update hosts.py to default to www - jb3

#

ChrisLovering

[python-discord/site] Pull request closed: #599 Switches HTTP Links To HTTPS

#

ChrisLovering

[python-discord/site] branch deleted: fix\-http\-links

#

ChrisLovering

[site:main] 3 new commits

26be9be Switches HTTP Links To HTTPS - HassanAbouelela
e608c0b Merge branch 'main' into fix-http-links - ChrisLovering
3e0c866 Merge pull request #599 from python-discord/fix... - ChrisLovering

odd spireBOT Oct 6, 2021, 7:34 PM

#

[python-discord/site] Checks Successful on PR: #599 Switches HTTP Links To HTTPS

GitHub Actions run 1313375355 succeeded.

PR Author

Workflow Run

Lint & Test #545

Source Branch

fix-http-links

#

[python-discord/site] Workflow Successful

GitHub Actions run 1313383908 succeeded.

Actor

Workflow Run

Deploy #134

Commit

3e0c866

regal archBOT Oct 6, 2021, 7:44 PM

#

lxnn

[python-discord/sir-lancebot] New comment on pull request #842: Add color command

I would like to keep the format of the embed the same, if we can. Example in message

The same as in, constant across commands. Or as in, the same as it is in the current state of this PR?

#

brad90four

[python-discord/sir-lancebot] New comment on pull request #842: Add color command

I would like to keep the format of the embed the same, if we can. Example in message

The same as in, constant across commands. Or as in, the same as it is in the current state of this PR?

The same as in the current state of the PR, with the vertical spacing of the fields. Unless we want to move away from that entirely?

#

D0rs4n

[python-discord/api] Pull request review submitted: #18 Make development workflow easier to use

odd spireBOT Oct 6, 2021, 8:50 PM

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1313603998 succeeded.

Actor

Lint Kubernetes manifests #200

Workflow Run

Commit

8cdb500

regal archBOT Oct 6, 2021, 9:03 PM

#

jchristgit

[site:decrease\-batch\-size\-for\-user\-list\-endpoint] 1 new commit

9d2f4d2 Decrease page size for user list endpoint. - jchristgit

#

jchristgit

[python-discord/site] New branch created: decrease\-batch\-size\-for\-user\-list\-endpoint

#

jchristgit

[python-discord/site] Pull request opened: #603 Decrease page size for user list endpoint\.

From some debugging via python-discord/kubernetes#96, we have determined
that this endpoint results in high latencies to the site and eventually
Kubernetes killing off site pods randomly.

#

HassanAbouelela

[python-discord/site] Pull request review submitted: #603 Decrease page size for user list endpoint\.

odd spireBOT Oct 6, 2021, 9:04 PM

#

[python-discord/site] Checks Failed on PR: #603 Decrease page size for user list endpoint.

GitHub Actions run 1313651195 failed.

PR Author

Workflow Run

Lint & Test #547

Source Branch

decrease-batch-size-for-user-li...

regal archBOT Oct 6, 2021, 9:08 PM

#

jb3

[python-discord/site] Pull request review submitted: #603 Decrease page size for user list endpoint\.

#

ChrisLovering

[bot:add\-appeals\-categories] 1 new commit

b40459a Add appeal categories to mod categories - ChrisLovering

#

ChrisLovering

[python-discord/bot] New branch created: add\-appeals\-categories

#

ChrisLovering

[python-discord/bot] Pull request opened: #1862 Add appeal categories to mod categories

This allows us to run moderation commands in the appeal categories

odd spireBOT Oct 6, 2021, 9:14 PM

#

[python-discord/bot] Checks Successful on PR: #1862 Add appeal categories to mod categories

GitHub Actions run 1313684263 succeeded.

PR Author

Workflow Run

Lint & Test #1926

Source Branch

add-appeals-categories

regal archBOT Oct 6, 2021, 9:21 PM

#

jchristgit

[site:subdomains\-to\-query\-paths] 74 new commits

aa00efc Allow empty value for inventory url field - Numerlor
58e0611 Move base_url field to the end - Numerlor
cc3407e Update gunicorn options for deployment - jb3
b84bd10 Merge pull request #573 from python-discord/jb3... - jchristgit
e85a641 Merge branch 'main' into doc-blank-base_url - ChrisLovering

#

jchristgit

[site] Branch subdomains\-to\-query\-paths was force-pushed to `ce75197`

odd spireBOT Oct 6, 2021, 9:23 PM

#

[python-discord/site] Checks Successful on PR: #526 Move subdomains to query paths.

GitHub Actions run 1313711107 succeeded.

PR Author

Workflow Run

Lint & Test #548

Source Branch

subdomains-to-query-paths

regal archBOT Oct 6, 2021, 9:23 PM

#

doublevcodes

[python-discord/bot] Pull request review submitted: #1862 Add appeal categories to mod categories

odd spireBOT Oct 6, 2021, 9:24 PM

#

[python-discord/site] Checks Successful on PR: #526 Move subdomains to query paths.

GitHub Actions run 1313715735 succeeded.

PR Author

Workflow Run

Lint & Test #549

Source Branch

subdomains-to-query-paths

regal archBOT Oct 6, 2021, 9:24 PM

#

jchristgit

[bot] Branch kill\-subdomains was force-pushed to `a84cab1`

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1862 Add appeal categories to mod categories

#

ChrisLovering

[python-discord/bot] Pull request closed: #1862 Add appeal categories to mod categories

#

ChrisLovering

[bot:main] 2 new commits

b40459a Add appeal categories to mod categories - ChrisLovering
ac58b88 Merge pull request #1862 from python-discord/ad... - ChrisLovering

#

ChrisLovering

[python-discord/bot] branch deleted: add\-appeals\-categories

odd spireBOT Oct 6, 2021, 9:26 PM

#

[python-discord/bot] Checks Successful on PR: #1630 Kill subdomains from configuration file.

GitHub Actions run 1313720952 succeeded.

PR Author

Workflow Run

Lint & Test #1927

Source Branch

kill-subdomains

oak estuaryBOT Oct 6, 2021, 9:28 PM

#

Python Bot

Connected!

odd spireBOT Oct 6, 2021, 9:28 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1313730635 succeeded.

Actor

Workflow Run

Deploy #464

Commit

ac58b88

regal archBOT Oct 6, 2021, 9:34 PM

#

jb3

[python-discord/site] Pull request review submitted: #526 Move subdomains to query paths\.

#

jb3

[python-discord/bot] Pull request review submitted: #1630 Kill subdomains from configuration file\.

#

jb3

[bot:kill\-subdomains] 3 new commits

b40459a Add appeal categories to mod categories - ChrisLovering
ac58b88 Merge pull request #1862 from python-discord/ad... - ChrisLovering
b182a84 Merge branch 'main' into kill-subdomains - jb3

odd spireBOT Oct 6, 2021, 9:38 PM

#

[python-discord/bot] Checks Successful on PR: #1630 Kill subdomains from configuration file.

GitHub Actions run 1313757250 succeeded.

PR Author

Workflow Run

Lint & Test #1929

Source Branch

kill-subdomains

regal archBOT Oct 6, 2021, 9:38 PM

#

jb3

[python-discord/site] Issue closed: #391 Get rid of subdomains in our site

#

jb3

[python-discord/site] Pull request closed: #526 Move subdomains to query paths\.

#

jb3

[site:main] 5 new commits

c998d47 Move subdomains to query paths. - jchristgit
fa4a8dd Merge branch 'master' into subdomains-to-query-... - jchristgit
3699245 Merge branch 'main' into subdomains-to-query-paths - jb3
ce75197 Merge branch 'master' into subdomains-to-query-... - jchristgit
3c2fcb8 Merge pull request #526 from python-discord/sub... - jb3

#

jb3

[python-discord/site] branch deleted: subdomains\-to\-query\-paths

#

jb3

[python-discord/bot] Pull request closed: #1630 Kill subdomains from configuration file\.

#

jb3

[bot:main] 3 new commits

a84cab1 Kill subdomains from configuration file. - jchristgit
b182a84 Merge branch 'main' into kill-subdomains - jb3
cfd579e Merge pull request #1630 from python-discord/ki... - jb3

#

jb3

[python-discord/bot] branch deleted: kill\-subdomains

odd spireBOT Oct 6, 2021, 9:42 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 1313772502 succeeded.

Actor

Workflow Run

Deploy #135

Commit

3c2fcb8

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1313780841 succeeded.

Actor

Workflow Run

Deploy #465

Commit

cfd579e

regal archBOT Oct 6, 2021, 9:47 PM

#

jb3

[site:jb3/add\-site\-local\-svc] 1 new commit

6a129ca Update ALLOWED_HOSTS to include internal address - jb3

#

jb3

[python-discord/site] New branch created: jb3/add\-site\-local\-svc

#

jb3

[python-discord/site] Pull request opened: #604 Update ALLOWED\_HOSTS to include internal address

#

jchristgit

[python-discord/site] Pull request review submitted: #604 Update ALLOWED\_HOSTS to include internal address

#

HassanAbouelela

[python-discord/site] Pull request review submitted: #604 Update ALLOWED\_HOSTS to include internal address

Hello!

Thanks for your interest in our projects, however our contributing guidelines require a body for your PR. Please review, and we'll proceed.

#

HassanAbouelela

[python-discord/site] Pull request review submitted: #604 Update ALLOWED\_HOSTS to include internal address

#

jchristgit

[python-discord/site] Pull request closed: #604 Update ALLOWED\_HOSTS to include internal address

#

jchristgit

[site:main] 2 new commits

6a129ca Update ALLOWED_HOSTS to include internal address - jb3
3b78d9a Merge pull request #604 from python-discord/jb3... - jchristgit

#

jchristgit

[python-discord/site] branch deleted: jb3/add\-site\-local\-svc

odd spireBOT Oct 6, 2021, 9:48 PM

#

[python-discord/site] Checks Successful on PR: #604 Update ALLOWED_HOSTS to include internal address

GitHub Actions run 1313787821 succeeded.

PR Author

Workflow Run

Lint & Test #551

Source Branch

jb3/add-site-local-svc

oak estuaryBOT Oct 6, 2021, 9:51 PM

#

Python Bot

Connected!

odd spireBOT Oct 6, 2021, 9:51 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 1313795595 succeeded.

Actor

Workflow Run

Deploy #136

Commit

3b78d9a

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1313816259 succeeded.

Actor

Lint Kubernetes manifests #201

Workflow Run

Commit

2070516

regal archBOT Oct 6, 2021, 10:29 PM

#

Bluenix2

[python-discord/sir-lancebot] New comment on pull request #884: Fix error with \`\.help\`

Do you perhaps want to convert this to a draft?

regal archBOT Oct 6, 2021, 10:55 PM

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #558: Markov poem gen

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #558 Markov poem gen

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #558: Markov poem gen

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #558: Markov poem gen

We use Python 3.9 which has asyncio.to_thread().

regal archBOT Oct 7, 2021, 8:56 AM

#

TizzySaurus

[python-discord/sir-lancebot] New comment on pull request #884: Fix error with \`\.help\`

Do you perhaps want to convert this to a draft?

Yeah, that seems smart so have done so. I don't think I'll be able to work on this much for a week or so.

regal archBOT Oct 7, 2021, 10:30 AM

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #859 Add WTF Python Command

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #859: Add WTF Python Command

Pleasse remember to remove your debug statements.

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #859: Add WTF Python Command

We can restructure this code like this:

            match = self.fuzzy_match_header(query)

        if not match:
            embed = Embed(
                title=random.choice(constants.ERROR_REPLIES),
                description=ERROR_MESSAGE,
                colour=constants.Colours.soft_red,
            )
            await ctx.send(embed=embed)
            return

        embed = Embed(
            title="WTF Python?!",
            colour=constants.Colours.dar...

odd spireBOT Oct 7, 2021, 11:50 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #859 Add WTF Python Command

GitHub Actions run 1316024640 succeeded.

PR Author

Workflow Run

Lint #1728

Source Branch

brad90four:feature/wtf-python

#

[python-discord/sir-lancebot] Checks Successful on PR: #859 Add WTF Python Command

GitHub Actions run 1316027757 succeeded.

PR Author

Workflow Run

Lint #1730

Source Branch

brad90four:feature/wtf-python

regal archBOT Oct 7, 2021, 4:50 PM

#

MrHemlock

[python-discord/bot] New comment on issue #1849: Create new voice\-ban command and change the current voice\-ban's name to voice\-mute

Current command that we have will be named voicemute
New command will be named voiceban

#

brad90four

[python-discord/api] Pull request review submitted: #17 Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

Could only find one thing, and have not tested the code reviewed here. Otherwise looks to be solid to me.

#

MrHemlock

[python-discord/site] Issue opened: #605 Add new infraction type to backend

In regards to python-discord/bot#1849

The linked issue will do the following:

Rename the current voiceban command to voicemute
Create a new command called voiceban

So we will need to add a relevant new type as well as convert the current voiceban infractions to voicemutes.

#

wookie184

[python-discord/branding] New comment on issue #162: Halloween branding

Committed in b39904b39e3dcfba062e1697d335e4cea6ef0968 and 637faa8e555af222ed7a6432cf6265cfbeeae9d0

Logo: (taken from previous assets) https://github.com/python-discord/branding/blob/main/events/halloween/server_icons/logo_256.png?raw=true
Banner: https://github.com/python-discord/branding/blob/main/events/halloween/banner.png?raw=true

#

wookie184

[python-discord/branding] Issue closed: #162 Halloween branding

regal archBOT Oct 7, 2021, 5:25 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #1831 Add \`CustomLogger\` to prevent IDE lint warnings when calling \`log\.trace\`\.

All seems good to me 👍

regal archBOT Oct 7, 2021, 6:29 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #883: suggestion: button paginator

This seems like a great idea, but that brings forth the question of if we should phase out all reactions or not

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #710: New avatarmod command \[name subject to change\]

is this open?

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #710: New avatarmod command \[name subject to change\]

id be interested in doing this

#

Kronifer

[python-discord/bot] Pull request review submitted: #1663 Add tag groups and in file metadata

Everything looks good!

regal archBOT Oct 7, 2021, 6:54 PM

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #699: Cowsay

I'm putting this on pause until I have .quack done

.quack has been merged. Can you finish up this PR? Also, there seems to be a singular file conflict with poetry.lock. Please fix that up.

#

doublevcodes

[python-discord/api] Pull request review submitted: #17 Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

I've also tested this locally now! Everything is functioning as expected.

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #699: Cowsay

@Xithrius thanks for reminding me that this exists, I'll get on it soon

regal archBOT Oct 7, 2021, 7:23 PM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #874 Added Anagrams command

When committing suggestions through GitHub, it's possible to change the message that the commit contains. Given this, please follow our guidelines for writing great commit messages.

Otherwise, looks good to me. Thanks for creating this PR!

odd spireBOT Oct 7, 2021, 7:25 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #874 Added Anagrams command

GitHub Actions run 1317610269 succeeded.

PR Author

maxyodedara5

Workflow Run

Lint #1731

Source Branch

maxyodedara5:anagram-game-command

regal archBOT Oct 7, 2021, 7:27 PM

#

Xithrius

[python-discord/sir-lancebot] Issue closed: #730 Anagrams Minigame command

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #874 Added Anagrams command

#

Xithrius

[sir-lancebot:main] 1 new commit

dccd30e Added Anagrams command (#874) - maxyodedara5

night lilyBOT Oct 7, 2021, 7:30 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 7, 2021, 7:30 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1317624347 succeeded.

Actor

Workflow Run

Build #450

Commit

dccd30e

regal archBOT Oct 7, 2021, 7:33 PM

#

ChrisLovering

[sir-lancebot] Branch topic\-command\-cooldown was force-pushed to `515c639`

odd spireBOT Oct 7, 2021, 7:34 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #880 Add a 5 minute cooldown to the topic command

GitHub Actions run 1317638775 succeeded.

PR Author

Workflow Run

Lint #1733

Source Branch

topic-command-cooldown

regal archBOT Oct 7, 2021, 7:34 PM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #880 Add a 2 minute cooldown to the topic command

Y e s.

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #880 Add a 2 minute cooldown to the topic command

#

Xithrius

[python-discord/sir-lancebot] Issue closed: #868 Add a per\-channel cooldown for \.topic

#

Xithrius

[sir-lancebot:main] 3 new commits

60b146f Add a 2 minute cooldown to the topic command - ChrisLovering
515c639 Allow topics to be refreshed - ChrisLovering
e8e6067 Merge pull request #880 from python-discord/top... - Xithrius

#

Xithrius

[python-discord/sir-lancebot] branch deleted: topic\-command\-cooldown

night lilyBOT Oct 7, 2021, 7:36 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 7, 2021, 7:37 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1317648551 succeeded.

Actor

Workflow Run

Build #451

Commit

e8e6067

regal archBOT Oct 7, 2021, 7:40 PM

#

ChrisLovering

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

Yea, you're right. This must have been a copy-paste oversight. I'll change this.

#

ChrisLovering

[python-discord/modmail-plugins] Pull request review submitted: #4 Add a ping manager plugin

#

ChrisLovering

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

How frustrating, since the method I used is what they suggest on the wiki https://github.com/kyb3r/modmail/wiki/Plugins#database-interfacing

I'll double check around the place and find the "proper" way to do this now.

#

ChrisLovering

[python-discord/modmail-plugins] Pull request review submitted: #4 Add a ping manager plugin

#

Bluenix2

[python-discord/bot] New review comment on pull request #1836: Fix typos and grammar in tags

@TizzySaurus can you make this change and I can approve it?

regal archBOT Oct 7, 2021, 8:06 PM

#

jb3

[api:main] 1 new commit

bfc718d Create review-policy.yml - jb3

#

ChrisLovering

[modmail-plugins:add\-ping\-manager] 3 new commits

651de33 Rename a attr in PingTask to be more descriptive - ChrisLovering
f68e1d1 Ensure tasks are always removed if any errors h... - ChrisLovering
b189eac Further explain the usage of the create_task wr... - ChrisLovering

#

ChrisLovering

[python-discord/modmail-plugins] Pull request review submitted: #4 Add a ping manager plugin

#

ChrisLovering

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

This is a good point, I'll move it into a finally to ensure these pings are cleaned up.

#

ChrisLovering

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

Huh I'm not too sure, this code, along with the helper util were pulled directly from the bot.

We add tasks in this way in cog init's all the time in the bot, so it must be something d.py is doing under the hood.

I'm not too familiar with the internal to say why it's working, only that it seems to be.

We do make sure to add the bot loop to this call when creating a task after running the bot though.

regal archBOT Oct 7, 2021, 8:28 PM

#

doublevcodes

[python-discord/site] Pull request opened: #606 Add a pull request template

This pull request template was mainly added so that the second bullet point in this PR comment can be addressed.

odd spireBOT Oct 7, 2021, 8:29 PM

#

[python-discord/site] Checks Successful on PR: #606 Add a pull request template

GitHub Actions run 1317809057 succeeded.

PR Author

Workflow Run

Lint & Test #553

Source Branch

doublevcodes:patch-1

#

[python-discord/site] Checks Successful on PR: #606 Add a pull request template

GitHub Actions run 1317837869 succeeded.

PR Author

Workflow Run

Lint & Test #554

Source Branch

doublevcodes:patch-1

#

[python-discord/site] Checks Successful on PR: #606 Add a pull request template

GitHub Actions run 1317873532 succeeded.

PR Author

Workflow Run

Lint & Test #555

Source Branch

doublevcodes:patch-1

regal archBOT Oct 7, 2021, 9:02 PM

#

dawnofmidnight

[python-discord/site] New review comment on pull request #606: Add a pull request template

This feels unclear. Maybe something more like this from the Lancebot repository?

Describe what changes you made, and how you've implemented them.

odd spireBOT Oct 7, 2021, 9:06 PM

#

[python-discord/forms-backend] Checks Successful on PR: #107 Bump pyjwt from 2.0.1 to 2.2.0

GitHub Actions run 1317917453 succeeded.

PR Author

dependabot[bot]

Workflow Run

Forms Backend #364

Source Branch

dependabot/pip/pyjwt-2.2.0

#

[python-discord/site] Checks Successful on PR: #606 Add a pull request template

GitHub Actions run 1317933810 succeeded.

PR Author

Workflow Run

Lint & Test #556

Source Branch

doublevcodes:patch-1

regal archBOT Oct 7, 2021, 9:12 PM

#

dawnofmidnight

[python-discord/site] New review comment on pull request #606: Add a pull request template

Is this really needed? Couldn't you just say "one of the following" up above?

#

jb3

[python-discord/site] Pull request review submitted: #606 Add a pull request template

#

dawnofmidnight

[python-discord/site] Pull request review submitted: #606 Add a pull request template

#

jb3

[python-discord/site] Pull request closed: #606 Add a pull request template

#

jb3

[site:main] 5 new commits

bb23a46 Add a pull request template - doublevcodes
3d97138 chore: Add comments to instruct users - doublevcodes
1bb70f3 chore: Replace examples with comments - doublevcodes
b57c7e8 fix: clarify descirption of changes section - doublevcodes
5985beb Merge pull request #606 from doublevcodes/patch-1 - jb3

odd spireBOT Oct 7, 2021, 9:31 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 1317990922 succeeded.

Actor

Workflow Run

Deploy #137

Commit

5985beb

regal archBOT Oct 8, 2021, 12:33 AM

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #881 Duckduckduckgoose

Everything looks good!

regal archBOT Oct 8, 2021, 5:58 AM

#

Akarys42

[sir-lancebot:bug/candy\-collection/fix\-typeerror\-id] 1 new commit

0cc435c Candy collection: fix positional arg being pass... - Akarys42

#

Akarys42

[python-discord/sir-lancebot] New branch created: bug/candy\-collection/fix\-typeerror\-id

#

Akarys42

[python-discord/sir-lancebot] Pull request opened: #893 Candy collection: fix positional arg being passed as kword

This caused a TypeError to be raised, as the id argument could only be used as a positional argument and not by keyword.

Relevant Issues

Description

Did you:

[ ] Join the Python Discord Community?
[ ] Read all the comments in this template?
[ ] Ensure there is an issue open, or link relevant discord discussions?
[ ] Read and ...

odd spireBOT Oct 8, 2021, 5:59 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #893 Candy collection: fix positional arg being passed as kword

GitHub Actions run 1319134875 succeeded.

PR Author

Workflow Run

Lint #1735

Source Branch

bug/candy-collection/fix-typeerror-id

regal archBOT Oct 8, 2021, 7:57 AM

#

Nipa-Code

[python-discord/sir-lancebot] Issue opened: #894 issue on \.topic reaction

Description

When bot adds reaction to .topic , and then user tries reacting happens on it. If moderator reacts to reaction, then it works.

Steps to Reproduce

Use .topic without any mod role
Click the reaction
Nothing happens

Expected Behaviour

On reaction bot should refresh the topic.

Actual Behaviour

When non moderator reacts to message the bot does not refresh anything.

Known Impacted Platforms

[ ] Web
[x] Desktop
[x] A...

regal archBOT Oct 8, 2021, 8:15 AM

#

Nipa-Code

[python-discord/sir-lancebot] New comment on issue #894: issue on \.topic reaction

@TizzySaurus has said he'd like to work on this

regal archBOT Oct 8, 2021, 8:57 AM

#

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #710: New avatarmod command \[name subject to change\]

@vcokltfre Are you still wanting to do this yourself? If not, it seems Kronifer is interested.

#

TizzySaurus

[bot:tags\-revision] 1 new commit

a1dd2a9 Bluenix Review #4 - TizzySaurus

odd spireBOT Oct 8, 2021, 9:09 AM

#

[python-discord/bot] Checks Successful on PR: #1836 Fix typos and grammar in tags

GitHub Actions run 1319682273 succeeded.

PR Author

Workflow Run

Lint & Test #1931

Source Branch

tags-revision

regal archBOT Oct 8, 2021, 9:10 AM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1836: Fix typos and grammar in tags

@Bluenix2 Have just committed :+1:. Thanks for the bump-reminder.

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #894: issue on \.topic reaction

For self-reference, the issue is that this if statement compares the user.id against message.author.id, where the message author is the bot -- not the user who invoked the command.

This PR will likely mean a little bit of reshuffling so that we have access to the ctx/ctx.author

regal archBOT Oct 8, 2021, 10:02 AM

#

Bluenix2

[python-discord/bot] Pull request review submitted: #1836 Fix typos and grammar in tags

#

Bluenix2

[python-discord/bot] New review comment on pull request #1836: Fix typos and grammar in tags

Note that in the `asyncio.run()`, where we appear to be calling `main()`, this does not execute the code in `main`. Rather, it creates and returns a new `coroutine` object (i.e `main() is not main()`) which is then handled and run by the event loop via `asyncio.run()`.

#

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #894: issue on \.topic reaction

While you're doing this, could you also have the bot remove the user's reactions after it's refreshed the topic?

#

TizzySaurus

[bot:tags\-revision] 1 new commit

d63406c Fix typo - TizzySaurus

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1836: Fix typos and grammar in tags

Oops, fixed lol.

odd spireBOT Oct 8, 2021, 10:20 AM

#

[python-discord/bot] Checks Successful on PR: #1836 Fix typos and grammar in tags

GitHub Actions run 1319910662 succeeded.

PR Author

Workflow Run

Lint & Test #1932

Source Branch

tags-revision

regal archBOT Oct 8, 2021, 10:39 AM

#

TizzySaurus

[sir-lancebot:topic\-improvements] 1 new commit

999604b .topic command improvements. - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: topic\-improvements

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #895 \`\.topic\` command improvements

Fix bug where command author couldn't re-roll
Now removes user's reaction up re-roll
Added a missing break statement

Relevant Issues

Closes #894.
Extension of #880.

Description

Fixed a bug where command author couldn't re-roll (the if statement was checking against message.author which is the bot, instead of the command invoker)
Now removes user's reaction up re-roll (as requested by @ChrisLovering)
Added a missing break statement (now breaks when the `w...

odd spireBOT Oct 8, 2021, 10:44 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #895 `.topic` command improvements

GitHub Actions run 1319982452 succeeded.

PR Author

Workflow Run

Lint #1736

Source Branch

topic-improvements

regal archBOT Oct 8, 2021, 10:51 AM

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #895: \`\.topic\` command improvements

We should suppress NotFound for this call, in case the user removes their own reaction before the bot can get to it.

Thinking of it, the line above should also have NotFound suppressed, in case the topic message gets deleted while processing the predicate.

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #895 \`\.topic\` command improvements

Just one request, rest looks good to me

#

SebastiaanZ

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

If I look at a few random cogs in the bot, then I'm seeing the loop being passed explicitly, like here:

        self.init_task = scheduling.create_task(self.init_cog(), event_loop=self.bot.loop)

Passing an explicit loop object means that it will work with a loop that has not been started yet.

#

SebastiaanZ

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

I don't really know either; I only came across it when I was trying to find out what this did during my review.

regal archBOT Oct 8, 2021, 11:34 AM

#

ChrisLovering

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

There is already a configurable ping string in modmail itself, we should use that, rather than roll our own.

regal archBOT Oct 8, 2021, 12:08 PM

#

TizzySaurus

[python-discord/sir-lancebot] Pull request review submitted: #893 Candy collection: fix positional arg being passed as kword

regal archBOT Oct 8, 2021, 1:24 PM

#

TizzySaurus

[sir-lancebot:topic\-improvements] 1 new commit

3c26b4d Add handling for discord.NotFound when re-rol... - TizzySaurus

odd spireBOT Oct 8, 2021, 1:25 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #895 `.topic` command improvements

GitHub Actions run 1320481632 succeeded.

PR Author

Workflow Run

Lint #1737

Source Branch

topic-improvements

regal archBOT Oct 8, 2021, 1:27 PM

#

TizzySaurus

[sir-lancebot:topic\-improvements] 1 new commit

e01503a Remove unnecessary else - TizzySaurus

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #895 \`\.topic\` command improvements

odd spireBOT Oct 8, 2021, 1:28 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #895 `.topic` command improvements

GitHub Actions run 1320492180 succeeded.

PR Author

Workflow Run

Lint #1738

Source Branch

topic-improvements

regal archBOT Oct 8, 2021, 1:30 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #893 Candy collection: fix positional arg being passed as kword

#

ChrisLovering

[sir-lancebot:main] 2 new commits

0cc435c Candy collection: fix positional arg being pass... - Akarys42
3544878 Merge pull request #893 from python-discord/bug... - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #893 Candy collection: fix positional arg being passed as kword

#

ChrisLovering

[python-discord/sir-lancebot] branch deleted: bug/candy\-collection/fix\-typeerror\-id

night lilyBOT Oct 8, 2021, 1:32 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 8, 2021, 1:32 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1320504410 succeeded.

Actor

Workflow Run

Build #452

Commit

3544878

regal archBOT Oct 8, 2021, 1:46 PM

#

TizzySaurus

[sir-lancebot:update\-role\-constants] 2 new commits

304d848 Allow .env values for all roles - TizzySaurus
56c3d9e Rename Roles.moderator to `Roles.moderation_t... - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: update\-role\-constants

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #895: \`\.topic\` command improvements

Done :+1:

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #896 Update \`constants\.Roles\`

Relevant Issues

N/A (discussed with @ChrisLovering on discord [here](#dev-contrib message))

Description

Renamed constants.Roles.moderator to constants.Roles.moderation_team.
Added ability to set the value of Roles.owner, Roles.moderation_team and Roles.core_developers in .env file.

NB: This change will require editing the relevant sections of the following two files on the site repo: [apps/cont...

#

TizzySaurus

[sir-lancebot] Branch update\-role\-constants was force-pushed to `457e05d`

odd spireBOT Oct 8, 2021, 1:55 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #896 Update `constants.Roles`

GitHub Actions run 1320581264 succeeded.

PR Author

Workflow Run

Lint #1740

Source Branch

update-role-constants

regal archBOT Oct 8, 2021, 1:56 PM

#

TizzySaurus

[sir-lancebot] Branch update\-role\-constants was force-pushed to `8f091a7`

odd spireBOT Oct 8, 2021, 1:56 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #896 Update `constants.Roles`

GitHub Actions run 1320585642 succeeded.

PR Author

Workflow Run

Lint #1741

Source Branch

update-role-constants

#

[python-discord/sir-lancebot] Checks Successful on PR: #896 Update `constants.Roles`

GitHub Actions run 1320589091 succeeded.

PR Author

Workflow Run

Lint #1742

Source Branch

update-role-constants

regal archBOT Oct 8, 2021, 2:02 PM

#

TizzySaurus

[sir-lancebot] Branch update\-role\-constants was force-pushed to `67e5683`

odd spireBOT Oct 8, 2021, 2:04 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #896 Update `constants.Roles`

GitHub Actions run 1320609357 succeeded.

PR Author

Workflow Run

Lint #1743

Source Branch

update-role-constants

regal archBOT Oct 8, 2021, 2:06 PM

#

TizzySaurus

[sir-lancebot:update\-role\-constants] 2 new commits

5b2a8ff Rename Roles.admin to Roles.admins - TizzySaurus
98d42c5 Rename Roles.owner to Roles.owners - TizzySaurus

odd spireBOT Oct 8, 2021, 2:07 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #896 Update `constants.Roles`

GitHub Actions run 1320627198 succeeded.

PR Author

Workflow Run

Lint #1744

Source Branch

update-role-constants

regal archBOT Oct 8, 2021, 2:10 PM

#

TizzySaurus

[sir-lancebot] Branch update\-role\-constants was force-pushed to `1d0e9bd`

odd spireBOT Oct 8, 2021, 2:12 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #896 Update `constants.Roles`

GitHub Actions run 1320643226 succeeded.

PR Author

Workflow Run

Lint #1745

Source Branch

update-role-constants

regal archBOT Oct 8, 2021, 2:13 PM

#

TizzySaurus

[site:lancebot\-env\-changes] 1 new commit

39c7795 Add ROLE_OWNERS and ROLE_MODERATION_TEAM - TizzySaurus

#

TizzySaurus

[python-discord/site] New branch created: lancebot\-env\-changes

#

TizzySaurus

[site:lancebot\-env\-changes] 1 new commit

46809cd Add missing backquotes - TizzySaurus

#

TizzySaurus

[site:lancebot\-env\-changes] 1 new commit

1ab99ef Add ROLE_OWNERS, ROLE_MODERATION_TEAM, `ROL... - TizzySaurus

#

TizzySaurus

[site:lancebot\-env\-changes] 1 new commit

f9a2a16 Add missing Core Developers role - TizzySaurus

#

TizzySaurus

[python-discord/site] Pull request opened: #607 Sir\-Lancebot env changes

This PR makes documentation reflect the changes made in sir-lancebot#896, as well as adding a few missing details such as backquotes.

#

TizzySaurus

[site:lancebot\-env\-changes] 1 new commit

22d2ae8 Add missing Core Developers role - TizzySaurus

odd spireBOT Oct 8, 2021, 2:24 PM

#

[python-discord/site] Checks Successful on PR: #607 Sir-Lancebot env changes

GitHub Actions run 1320686886 succeeded.

PR Author

Workflow Run

Lint & Test #558

Source Branch

lancebot-env-changes

regal archBOT Oct 8, 2021, 2:24 PM

#

TizzySaurus

[site:lancebot\-env\-changes] 1 new commit

77a1b81 Fix typo - TizzySaurus

odd spireBOT Oct 8, 2021, 2:25 PM

#

[python-discord/site] Checks Successful on PR: #607 Sir-Lancebot env changes

GitHub Actions run 1320691230 succeeded.

PR Author

Workflow Run

Lint & Test #559

Source Branch

lancebot-env-changes

#

[python-discord/site] Checks Successful on PR: #607 Sir-Lancebot env changes

GitHub Actions run 1320693260 succeeded.

PR Author

Workflow Run

Lint & Test #560

Source Branch

lancebot-env-changes

regal archBOT Oct 8, 2021, 2:32 PM

#

TizzySaurus

[site] Branch lancebot\-env\-changes was force-pushed to `16e7d02`

odd spireBOT Oct 8, 2021, 2:34 PM

#

[python-discord/site] Checks Successful on PR: #607 Sir-Lancebot env changes

GitHub Actions run 1320722885 succeeded.

PR Author

Workflow Run

Lint & Test #561

Source Branch

lancebot-env-changes

regal archBOT Oct 8, 2021, 2:35 PM

#

TizzySaurus

[site] Branch lancebot\-env\-changes was force-pushed to `eb4ff25`

odd spireBOT Oct 8, 2021, 2:36 PM

#

[python-discord/site] Checks Successful on PR: #607 Sir-Lancebot env changes

GitHub Actions run 1320733241 succeeded.

PR Author

Workflow Run

Lint & Test #562

Source Branch

lancebot-env-changes

regal archBOT Oct 8, 2021, 3:58 PM

#

InvisibleOS

[python-discord/branding] Pull request opened: #164 Change banner

odd spireBOT Oct 8, 2021, 3:59 PM

#

[python-discord/branding] Checks Successful on PR: #164 Change banner

GitHub Actions run 1321018423 succeeded.

PR Author

InvisibleOS

Workflow Run

Event Validation #45

Source Branch

InvisibleOS:halloween-bran...

regal archBOT Oct 8, 2021, 4:17 PM

#

bsoyka

[python-discord/branding] New comment on pull request #164: Change banner

Looks pretty good to me! Vestergurkan said he'd have a look, so I'll leave this here for him too.

regal archBOT Oct 8, 2021, 6:40 PM

#

Kronifer

[python-discord/sir-lancebot] Pull request closed: #699 Cowsay

regal archBOT Oct 8, 2021, 7:06 PM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #895 \`\.topic\` command improvements

Thank you.

#

Xithrius

[sir-lancebot:topic\-improvements] 3 new commits

0cc435c Candy collection: fix positional arg being pass... - Akarys42
3544878 Merge pull request #893 from python-discord/bug... - ChrisLovering
be87067 Merge branch 'main' into topic-improvements - Xithrius

#

Xithrius

[python-discord/sir-lancebot] Issue closed: #894 issue on \.topic reaction

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #895 \`\.topic\` command improvements

#

Xithrius

[python-discord/sir-lancebot] branch deleted: topic\-improvements

#

Xithrius

[sir-lancebot:main] 5 new commits

999604b .topic command improvements. - TizzySaurus
3c26b4d Add handling for discord.NotFound when re-rol... - TizzySaurus
e01503a Remove unnecessary else - TizzySaurus
be87067 Merge branch 'main' into topic-improvements - Xithrius
0cc1e8a Merge pull request #895 from python-discord/top... - Xithrius

odd spireBOT Oct 8, 2021, 7:08 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #895 `.topic` command improvements

GitHub Actions run 1321571554 succeeded.

PR Author

Workflow Run

Lint #1746

Source Branch

topic-improvements

night lilyBOT Oct 8, 2021, 7:09 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 8, 2021, 7:09 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1321574969 succeeded.

Actor

Workflow Run

Build #453

Commit

0cc1e8a

regal archBOT Oct 8, 2021, 7:20 PM

#

gustavwilliam

[python-discord/branding] Pull request review submitted: #164 Change banner

Thanks for making this banner. It looks great!

I just have a few comments/questions about this:

Why was the logo.svg file deleted?
Is a vector (.svg) version of the banner available? It's good to have the source files available in the branding repo.

I'd also like to note that there's a (very minor) imperfection where you edited the "Y", shown below, but it's unnoticeable enough that I'll let it pass.
![image](https://user-images.githubusercontent.com/65498475/136613773-85443daf-3f...

regal archBOT Oct 8, 2021, 8:08 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #881 Duckduckduckgoose

#

ChrisLovering

[python-discord/sir-lancebot] Issue closed: #866 Fix the DDDG game board

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #881 Duckduckduckgoose

#

ChrisLovering

[sir-lancebot:main] 12 new commits

fc84224 Get rid of footer argument to embed init - camcaswell
420968c Split initial embed in two - camcaswell
e7bbd14 Add function for appending to claimed answers e... - camcaswell
65aec40 Bring end_game up to date - camcaswell
f96ecff Change board embed color - camcaswell

odd spireBOT Oct 8, 2021, 8:10 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #881 Duckduckduckgoose

GitHub Actions run 1321741136 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1748

Source Branch

camcaswell:duckduckduckgoose

night lilyBOT Oct 8, 2021, 8:11 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 8, 2021, 8:11 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1321744205 succeeded.

Actor

Workflow Run

Build #454

Commit

7a6c3a0

regal archBOT Oct 9, 2021, 2:44 AM

#

InvisibleOS

[python-discord/branding] New comment on pull request #164: Change banner

I deleted logo.svg since I thought that the assets folder isn't required. It wouldn't take me a second to add it back though.
I will be adding the assets folder with the svg files for the banner and server icon.

odd spireBOT Oct 9, 2021, 2:50 AM

#

[python-discord/branding] Checks Successful on PR: #164 Change banner

GitHub Actions run 1322580243 succeeded.

PR Author

InvisibleOS

Workflow Run

Event Validation #46

Source Branch

InvisibleOS:halloween-bran...

regal archBOT Oct 9, 2021, 6:22 AM

#

gustavwilliam

[python-discord/branding] New comment on pull request #164: Change banner

Awesome! I'll have a look at the files when I get back from work.

If you're wondering why we include the source files, it's so we can modify things, export the assets in any size, and reuse pieces of the content in other places, in the future.

regal archBOT Oct 9, 2021, 10:19 AM

#

ChrisLovering

[modmail-plugins:add\-ping\-manager] 1 new commit

0a690a6 Use supported DB partition and pass bot loop to... - ChrisLovering

regal archBOT Oct 9, 2021, 2:07 PM

#

bsoyka

[python-discord/.github] Fork created: bsoyka/.github-1

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #889 Change pascal's triangle image

regal archBOT Oct 9, 2021, 2:44 PM

#

wookie184

[python-discord/site] Pull request review submitted: #607 Sir\-Lancebot env changes

Admin should be the only role needed to test sir-lancebot features, so I think that's the only role we should mention on the main page (it makes sense to list the others on the reference page though).

I'd even say Helpers is stretching it a bit as what is necessary, although probably fair to mention so one can differentiate between MODERATION_ROLES and STAFF_ROLES in testing.

regal archBOT Oct 9, 2021, 3:17 PM

#

wookie184

[sir-lancebot:command\-prefix\-fix] 1 new commit

f316b3d Replace usage of bot.command_prefix with consta... - wookie184

#

wookie184

[python-discord/sir-lancebot] New branch created: command\-prefix\-fix

#

wookie184

[python-discord/sir-lancebot] Pull request opened: #897 Replace usage of bot\.command\_prefix with constants\.Client\.prefix

Relevant Issues

Fixes an issue where you got messages like Game is already running... do <function when_mentioned_or..inner at 0x7fe4412a8ee0>quiz stop because command_prefix isn't always a string https://discordpy.readthedocs.io/en/stable/ext/commands/api.html?highlight=bot command_prefix#discord.ext.commands.Bot.command_prefix

Description

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this...

odd spireBOT Oct 9, 2021, 3:21 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #897 Replace usage of bot.command_prefix with constants.Client.prefix

GitHub Actions run 1323788269 succeeded.

PR Author

Workflow Run

Lint #1750

Source Branch

command-prefix-fix

regal archBOT Oct 9, 2021, 3:22 PM

#

D0rs4n

[python-discord/sir-lancebot] Pull request review submitted: #897 Replace usage of bot\.command\_prefix with constants\.Client\.prefix

#

wookie184

[python-discord/sir-lancebot] New comment on pull request #897: Replace usage of bot\.command\_prefix with constants\.Client\.prefix

accidentally missed one instance of it, will fix

#

wookie184

[sir-lancebot] Branch command\-prefix\-fix was force-pushed to `febe5b9`

odd spireBOT Oct 9, 2021, 3:28 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #897 Replace usage of bot.command_prefix with constants.Client.prefix

GitHub Actions run 1323798374 succeeded.

PR Author

Workflow Run

Lint #1751

Source Branch

command-prefix-fix

regal archBOT Oct 9, 2021, 3:28 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #897 Replace usage of bot\.command\_prefix with constants\.Client\.prefix

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #897 Replace usage of bot\.command\_prefix with constants\.Client\.prefix

#

ChrisLovering

[sir-lancebot:main] 2 new commits

febe5b9 Replace usage of bot.command_prefix with consta... - wookie184
0b4751d Merge pull request #897 from python-discord/com... - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] branch deleted: command\-prefix\-fix

night lilyBOT Oct 9, 2021, 3:30 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 9, 2021, 3:30 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1323800917 succeeded.

Actor

Workflow Run

Build #455

Commit

0b4751d

regal archBOT Oct 9, 2021, 3:42 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #896 Update \`constants\.Roles\`

The checks for == Roles.moderation_team should probably be changed to in MODERATION_ROLES, but this all seems like this should work.

#

jchristgit

[python-discord/site] New comment on pull request #586: URLs: add an allow everything robots\.txt

I'd rather have the robots.txt content in a multi-line string than with \n, also we shouldn't allow everything, we should disallow /admin/.

What's the value in disallowing /admin/ though?

#

jchristgit

[python-discord/site] New comment on pull request #586: URLs: add an allow everything robots\.txt

@Akarys42 can you address the merge conflict and Joe's comment? It's good to me otherwise.

#

jchristgit

[python-discord/site] Pull request review submitted: #586 URLs: add an allow everything robots\.txt

Thanks!

regal archBOT Oct 9, 2021, 4:18 PM

#

jchristgit

[site:decrease\-batch\-size\-for\-user\-list\-endpoint] 1 new commit

ef37848 Automatically adjust test to page_size. - jchristgit

#

jchristgit

[site] Branch decrease\-batch\-size\-for\-user\-list\-endpoint was force-pushed to `4c527e7`

#

jchristgit

[site:main] 3 new commits

afec45b Decrease page size for user list endpoint. - jchristgit
4c527e7 Automatically adjust test to page_size. - jchristgit
3eec0c3 Merge pull request #603 from python-discord/dec... - jchristgit

#

jchristgit

[python-discord/site] branch deleted: decrease\-batch\-size\-for\-user\-list\-endpoint

odd spireBOT Oct 9, 2021, 4:19 PM

#

[python-discord/site] Checks Successful on PR: #603 Decrease page size for user list endpoint.

GitHub Actions run 1323881747 succeeded.

PR Author

Workflow Run

Lint & Test #563

Source Branch

decrease-batch-size-for-user-li...

regal archBOT Oct 9, 2021, 4:19 PM

#

jchristgit

[python-discord/site] Pull request closed: #603 Decrease page size for user list endpoint\.

odd spireBOT Oct 9, 2021, 4:19 PM

#

[python-discord/site] Checks Successful on PR: #603 Decrease page size for user list endpoint.

GitHub Actions run 1323881996 succeeded.

PR Author

Workflow Run

Lint & Test #564

Source Branch

decrease-batch-size-for-user-li...

#

[python-discord/site] Workflow Successful

GitHub Actions run 1323885970 succeeded.

Actor

Workflow Run

Deploy #138

Commit

3eec0c3

regal archBOT Oct 9, 2021, 4:25 PM

#

jchristgit

[python-discord/api] Issue closed: #16 Migrate models based on the current Database Schema to SQLAlchemy

#

jchristgit

[python-discord/api] Pull request closed: #17 Generate SQLAlchemy models based on the current schema, using SQLAcodegen, add PostgreSQL dependencies

#

jchristgit

[api:main] 23 new commits

c4d7ad1 Generate SQLAlchemy models based on the current... - D0rs4n
0706001 Make model class naming more consistent, add mo... - D0rs4n
3ed24c4 Remove 'api' prefix from model tablenames - D0rs4n
aaf362c Add new NominationEntry model, Validations and ... - D0rs4n
04c9e86 Implement futher validations in models - D0rs4n

odd spireBOT Oct 9, 2021, 5:02 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #879 Uwuification update.

GitHub Actions run 1323942589 failed.

PR Author

gitautas

Workflow Run

Lint #1763

Source Branch

gitautas:uwu

regal archBOT Oct 9, 2021, 5:52 PM

#

wookie184

[bot:fix\-delayed\-logs] 3 new commits

305e375 Run debug log before help command invocation to... - wookie184
d67dabb Refactored other areas of code slightly, ensuri... - wookie184
4f866e1 Ensured debug logs were sent for disabled commands - wookie184

#

wookie184

[python-discord/bot] New branch created: fix\-delayed\-logs

#

wookie184

[python-discord/bot] Pull request opened: #1863 Fixed delayed logs and made some other minor refactors

Closes #1857

I also removed a comment that seemed to no longer be valid, made a change to clean up some code, and another to move some log calls to before ctx.sends

#

ks129

[python-discord/bot] New comment on pull request #1863: Fixed delayed logs and made some other minor refactors

I don't like this repeating log.debug. Maybe this could be solved by running coroutine in the background and waiting after log instead?

odd spireBOT Oct 9, 2021, 5:57 PM

#

[python-discord/bot] Checks Successful on PR: #1863 Fixed delayed logs and made some other minor refactors

GitHub Actions run 1324027561 succeeded.

PR Author

Workflow Run

Lint & Test #1933

Source Branch

fix-delayed-logs

regal archBOT Oct 9, 2021, 6:11 PM

#

wookie184

[python-discord/bot] New comment on pull request #1863: Fixed delayed logs and made some other minor refactors

I don't like this repeating log.debug. Maybe this could be solved by running coroutine in the background and waiting after log instead?

All this really does is change the code from indicating conditions that shouldn't be logged, to conditions that should be logged. Rather than repeating return # Exit early to avoid logging. we are repeating log.debug. I think this is a more readable way of doing things, and makes it clear that the logs will run without being delayed by any...

regal archBOT Oct 9, 2021, 7:36 PM

#

ks129

[site:voicemute] 1 new commit

53bbaac Implement voice mute + migration from voice mut... - ks129

#

ks129

[python-discord/site] New branch created: voicemute

#

ks129

[python-discord/site] Pull request opened: #608 Implement voice mute and migration from voice mute \-> voice ban

Closes #605

Added new voice_mute infraction type, added migration to migrate existing voice bans to voice mutes. Had to upper type's max length from 9 to 10.

Voice mute cannot be hidden.

THIS HAS TO BE MERGED AT THE SAME TIME AS BOT PR!

odd spireBOT Oct 9, 2021, 7:40 PM

#

[python-discord/site] Checks Successful on PR: #608 Implement voice mute and migration from voice mute -> voice ban

GitHub Actions run 1324203615 succeeded.

PR Author

ks129

Workflow Run

Lint & Test #566

Source Branch

voicemute

regal archBOT Oct 9, 2021, 8:21 PM

#

TizzySaurus

[sir-lancebot:update\-role\-constants] 1 new commit

bdbbf2a Check role id in MODERATION_ROLES instead of co... - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New comment on pull request #896: Update \`constants\.Roles\`

The checks for == Roles.moderation_team should probably be changed to in MODERATION_ROLES, but this all seems like this should work.

Thanks for the review; have changed the checks :+1:

#

TizzySaurus

[sir-lancebot:update\-role\-constants] 22 new commits

fc84224 Get rid of footer argument to embed init - camcaswell
420968c Split initial embed in two - camcaswell
e7bbd14 Add function for appending to claimed answers e... - camcaswell
65aec40 Bring end_game up to date - camcaswell
f96ecff Change board embed color - camcaswell

odd spireBOT Oct 9, 2021, 8:23 PM

#

[python-discord/kubernetes] Checks Failed on PR: #103 Add Patsy service

GitHub Actions run 1324270699 failed.

PR Author

Lint Kubernetes manifests #202

Workflow Run

Source Branch

patsy

#

[python-discord/sir-lancebot] Checks Successful on PR: #896 Update `constants.Roles`

GitHub Actions run 1324271374 succeeded.

PR Author

Workflow Run

Lint #1764

Source Branch

update-role-constants

odd spireBOT Oct 9, 2021, 9:03 PM

#

[python-discord/kubernetes] Checks Successful on PR: #103 Add Patsy service

GitHub Actions run 1324328543 succeeded.

PR Author

Lint Kubernetes manifests #203

Workflow Run

Source Branch

patsy

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1324347753 succeeded.

Actor

Workflow Run

Build & Deploy #9

Commit

8405902

odd spireBOT Oct 9, 2021, 9:36 PM

#

[python-discord/kubernetes] Checks Successful on PR: #103 Add Patsy service

GitHub Actions run 1324387897 succeeded.

PR Author

Lint Kubernetes manifests #204

Workflow Run

Source Branch

patsy

regal archBOT Oct 9, 2021, 10:31 PM

#

HassanAbouelela

[site:static\-previews] 4 new commits

e9c4cdf Adds Django Distill To Project - HassanAbouelela
247c4ba Adds Static Route Configurations - HassanAbouelela
595185d Adds Static Docker Build - HassanAbouelela
74a9111 Adds Netlify Builds - HassanAbouelela

#

HassanAbouelela

[python-discord/site] New branch created: static\-previews

#

Bluenix2

[python-discord/bot] Pull request review submitted: #1836 Fix typos and grammar in tags

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #879 Uwuification update\.

There's still some comments left so I'll wait for those to get resolved before taking another full review.

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #879: Uwuification update\.

How does this work? Users cannot send embeds?

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #879: Uwuification update\.

The linting action complained that this was unused.

#

HassanAbouelela

[python-discord/site] Pull request opened: #609 Static Previews

It's finally here! Static previews on the site.

This PR uses django-distill to build a static version of the site, which is then deployed and hosted on netlify. Netlify will give us a static preview of the main branch, and it'll also give us previews on PRs. You can find examples of what that'll look like on my fork here:

https://github.com/HassanAbouelela/site-1/pull/8
This is a static preview of the changes made in #591.

Important!

1...

odd spireBOT Oct 9, 2021, 10:50 PM

#

[python-discord/site] Checks Successful on PR: #609 Static Previews

GitHub Actions run 1324495860 succeeded.

PR Author

Workflow Run

Lint & Test #567

Source Branch

static-previews

regal archBOT Oct 9, 2021, 10:50 PM

#

HassanAbouelela

[python-discord/site] New comment on pull request #609: Static Previews

Redirects

The situation with redirects is a little complex, so I've decided to give it it's own comment here.

I've put a lot of work into redirects (you can see my latest efforts here. You can find those changes deployed to this preview branch.

In short: it really does not work as intended yet, and it's already too complex, and to...

regal archBOT Oct 9, 2021, 11:11 PM

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #859 Add WTF Python Command

🎉 Thanks Brad!

regal archBOT Oct 9, 2021, 11:51 PM

#

HassanAbouelela

[python-discord/site] New comment on pull request #609: Static Previews

I've done some more work on the redirects. The latest changes on the branch I linked in my previous comment are deployed here.

Now, while my changes do work, they still feel sloppy. I did a bit more digging though, and I found a lot of guides and articles still using old links, so I'm not sure what the right call is here.

There's also a question of cost, since we generate ~40 extra HTML files for redirects alone. It's probab...

regal archBOT Oct 10, 2021, 12:27 AM

#

HassanAbouelela

[python-discord/site] New comment on pull request #609: Static Previews

Decided to ignore the caching problems, since we'll only save just around 15 seconds anyways. The buildx cache does not play nice with regular docker builds, and I couldn't figure out how to run an image built by buildx. If someone else wants to give it a shot, they are more than welcome to, otherwise, I'm marking this PR as ready.

regal archBOT Oct 10, 2021, 1:27 AM

#

ichard26

[python-discord/site] Pull request review submitted: #591 Restructure bot contributing guide

This reads soooo much better, thank you! I didn't know setting up a poetry environment for the bot was completely unnecessary haha :)

#

ichard26

[python-discord/site] New review comment on pull request #591: Restructure bot contributing guide

I've set up an instance of the bot earlier today and I've found setting urls.site to "web:8000" broke it:

bot_1        | Traceback (most recent call last):
bot_1        |   File "/bot/bot/api.py", line 66, in maybe_raise_for_status
bot_1        |     response_json = await response.json()
bot_1        |   File "/usr/local/lib/python3.9/site-packages/aiohttp/client_reqrep.py", line 1097, in json
bot_1        |     raise ContentTypeError(
bot_1        | aiohttp.client_exceptions.Con...

regal archBOT Oct 10, 2021, 3:49 AM

#

mbaruh

[python-discord/site] New review comment on pull request #591: Restructure bot contributing guide

The subdomains were removed from the site a few days ago, so I need to update the guide 👍

#

mbaruh

[python-discord/site] New comment on pull request #591: Restructure bot contributing guide

@ichard26 thanks, now I know I need to a section on why you might want to set up the env anyway 😃

#

ichard26

[python-discord/site] New comment on pull request #591: Restructure bot contributing guide

Well okay to be clear I meant that if you were using docker (like me). If running on the host then doing a poetry dev install is important 🙂

#

mbaruh

[python-discord/site] New comment on pull request #591: Restructure bot contributing guide

Well okay to be clear I meant that if you were using docker (like me) it's a step you can skip. If running on the host then doing a poetry dev install is important 🙂

What I mean is that you'll want to have the env to lint and test before committing, unless you interactively run the container

regal archBOT Oct 10, 2021, 8:54 AM

#

Xithrius

[python-discord/bot] New comment on pull request #1833: \`\!contribute\` tag

@janine9vn Please address the request for reviews when you're available.

odd spireBOT Oct 10, 2021, 8:57 AM

#

[python-discord/patsy] Checks Successful on PR: #1 Run on port 8000 by default.

GitHub Actions run 1325431049 succeeded.

PR Author

https://github.com/Rapptz/discord.py/blob/45d498c1b76deaf3b394d17ccf56112fa691d160/discord/channel.py#L406-#L407

Workflow Run

Lint & Test #12

Source Branch

port-8000

regal archBOT Oct 10, 2021, 9:15 AM

#

jchristgit

[python-discord/bot] New review comment on pull request #1793: Clean Cog Rework

Could you add small docstrings describing what these variables do?
I can sort-of guess MESSAGE_DELETE_DELAY, but I am not sure what DEFAULT_TRAVERSE would do. Also, could we maybe place these on the cog itself?

#

jchristgit

[python-discord/bot] Pull request review submitted: #1793 Clean Cog Rework

I like this. I have a few comments, but I like it.

#

jchristgit

[python-discord/bot] New review comment on pull request #1793: Clean Cog Rework

Up there you add the type aliases unconditionally, down here if TYPE_CHECKING, would it make sense to just add all of them unconditionally?

#

jchristgit

[python-discord/bot] New review comment on pull request #1793: Clean Cog Rework

As with the BadArgument raise above, should we add from e here to preserve traceback information, or do you think e.msg is sufficient?

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1860: Attempt infraction before DMing

Isn't this branch redundant? The default values is we don't go into the if branch are identical.

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1860 Attempt infraction before DMing

Minor comment, everything else looks fine.

regal archBOT Oct 10, 2021, 9:46 AM

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1793: Clean Cog Rework

Doesn't look like that

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1793: Clean Cog Rework

I think discord takes all date-times as the date-time of the client(date-time of the system bot is running on), so this wouldn't do the correct thing. I may be wrong.

#

TizzySaurus

[bot:fix\-infract\-then\-dm] 1 new commit

1e6d9bd Improve logic to remove redundant else clauses - TizzySaurus

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1860: Attempt infraction before DMing

Good catch. Have updated this in 1e6d9bd :+1:

odd spireBOT Oct 10, 2021, 10:05 AM

#

[python-discord/bot] Checks Successful on PR: #1860 Attempt infraction before DMing

GitHub Actions run 1325540318 succeeded.

PR Author

Workflow Run

Lint & Test #1934

Source Branch

fix-infract-then-dm

regal archBOT Oct 10, 2021, 10:10 AM

#

kwzrd

[python-discord/bot] New review comment on pull request #1793: Clean Cog Rework

@jchristgit time.time() is UTC, but datetime.utcnow().timestamp() is not. 😄 You can verify by pasting those timestamps into e.g. https://www.unixtimestamp.com/

I wrote about it in more detail here but the tldr is that utcnow gives a naive timestamp, so when you call timestamp on it, it shifts to UTC again. It's entirely counter-intuitive.

#

TizzySaurus

[python-discord/bot] Issue opened: #1864 Add \`DM Sent\` field to infaction details

It was [suggested on discord](#mod-tools message) by @codephile1221 that when viewing an infraction via the !infraction command, it should have a DM Sent field for reference -- particularly helpful in the case of a warning as the user may not even realise they were warned for a certain behaviour.

This will require a PR to site since means updating the database schema.

#

HassanAbouelela

[site:static\-previews] 1 new commit

7fc4ad6 Fixes Caching On Docker Build - HassanAbouelela

odd spireBOT Oct 10, 2021, 10:25 AM

#

[python-discord/site] Checks Successful on PR: #609 Static Previews

GitHub Actions run 1325575468 succeeded.

PR Author

Workflow Run

Lint & Test #568

Source Branch

static-previews

regal archBOT Oct 10, 2021, 10:30 AM

#

TizzySaurus

[python-discord/site] Issue opened: #610 Add \`dm\_sent\` field to infractions database

Refers to bot#1864.

Make the necessary database changes to support infractions having a dm_sent field in the database which is shown upon !infraction command.

TO BE MERGED WITH bot#1864.

#

HassanAbouelela

[site] Branch static\-previews was force-pushed to `f4a6e65`

odd spireBOT Oct 10, 2021, 10:32 AM

#

[python-discord/site] Checks Successful on PR: #609 Static Previews

GitHub Actions run 1325584615 succeeded.

PR Author

Workflow Run

Lint & Test #569

Source Branch

static-previews

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1325585930 succeeded.

Actor

Workflow Run

Build & Deploy #10

Commit

1f46686

#

[python-discord/patsy] Checks Successful on PR: #2 Replicate prod-like env in dev

GitHub Actions run 1325598856 succeeded.

PR Author

Workflow Run

Lint & Test #14

Source Branch

Replicate-prod-like-env-in-dev

regal archBOT Oct 10, 2021, 10:40 AM

#

HassanAbouelela

[site] Branch static\-previews was force-pushed to `fa0d75e`

odd spireBOT Oct 10, 2021, 10:40 AM

#

[python-discord/kubernetes] Checks Successful on PR: #103 Add Patsy service

GitHub Actions run 1325599023 succeeded.

PR Author

Lint Kubernetes manifests #205

Workflow Run

Source Branch

patsy

#

[python-discord/site] Checks Successful on PR: #609 Static Previews

GitHub Actions run 1325601713 succeeded.

PR Author

Workflow Run

Lint & Test #570

Source Branch

static-previews

#

[python-discord/kubernetes] Checks Successful on PR: #103 Add Patsy service

GitHub Actions run 1325601707 succeeded.

PR Author

Lint Kubernetes manifests #206

Workflow Run

Source Branch

patsy

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1325609850 succeeded.

Actor

Workflow Run

Build & Deploy #11

Commit

5b1c49a

regal archBOT Oct 10, 2021, 10:49 AM

#

jchristgit

[python-discord/bot] New review comment on pull request #1793: Clean Cog Rework

@kwzrd jesus christ, what the hell did I just read. Thanks for the heads up. Apparently I have been wrongfully suggesting this at work and elsewhere for years. What the hell. Jesus Christ. What the fuck.

Okay, apart from the fact that I have some cleaning to do at work tomorrow, with an aware instance, it seems to do the correct thing. I always thought time.time() isn't UTC... jesus christ, can we deprecate timezones ?? What the hell.

>>> datetime.datetime.now(tz=datetime.timez...

#

jchristgit

[python-discord/bot] New review comment on pull request #1793: Clean Cog Rework

Yup, yup, sounds good, then this is fine.

#

HassanAbouelela

[site] Branch static\-previews was force-pushed to `cf199b2`

odd spireBOT Oct 10, 2021, 10:53 AM

#

[python-discord/site] Checks Successful on PR: #609 Static Previews

GitHub Actions run 1325620495 succeeded.

PR Author

Workflow Run

Lint & Test #571

Source Branch

static-previews

regal archBOT Oct 10, 2021, 10:57 AM

#

jchristgit

[python-discord/site] Pull request review submitted: #609 Static Previews

This is very cool!!!!!!!!!!!! Nice work on the documentation. I have a few smaller comments, but actually they are more like questions. You can deal with them, or you can not. This looks good from an implementation perspective.

#

jchristgit

[python-discord/site] New review comment on pull request #609: Static Previews

Is there no way that we can re-use the main Dockerfile here?

#

jchristgit

[python-discord/site] New review comment on pull request #609: Static Previews

Hmm, why the double underscores here? Would it be more clean to use __all__ to signify what is external?

#

jchristgit

[python-discord/site] New review comment on pull request #609: Static Previews

Since we use this variable outside of this block, would it be more clean to define it on a separate line? Just a thought.

odd spireBOT Oct 10, 2021, 11:00 AM

#

[python-discord/kubernetes] Checks Successful on PR: #103 Add Patsy service

GitHub Actions run 1325628322 succeeded.

PR Author

Lint Kubernetes manifests #207

Workflow Run

Source Branch

patsy

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1325629676 succeeded.

Actor

Lint Kubernetes manifests #208

Workflow Run

Commit

189d7d7

regal archBOT Oct 10, 2021, 11:54 AM

#

HassanAbouelela

[site:static\-previews] 2 new commits

79259eb Merges Dockerfiles - HassanAbouelela
8b58305 Error Out On Missing Files In CI - HassanAbouelela

#

HassanAbouelela

[python-discord/site] New review comment on pull request #609: Static Previews

I had initially avoided that so we can have each on a separate repo, and utilize cache better, but in it's current state, yeah it can be done.

Changed in 79259eb8

odd spireBOT Oct 10, 2021, 11:55 AM

#

[python-discord/site] Checks Successful on PR: #609 Static Previews

GitHub Actions run 1325722364 succeeded.

PR Author

Workflow Run

Lint & Test #572

Source Branch

static-previews

regal archBOT Oct 10, 2021, 12:01 PM

#

HassanAbouelela

[python-discord/site] New review comment on pull request #609: Static Previews

My intention was to explicitly hide it because while it is technically a utility, it probably shouldn't be used directly from this file. I'm not sure if placing it under all conveys the same intention. It can still be imported and nothing will complain AFAIK.

What do you think?

#

jchristgit

[python-discord/site] New review comment on pull request #609: Static Previews

Yes, that makes sense to me.

#

jchristgit

[python-discord/site] New comment on pull request #609: Static Previews

Rock solid work. Thank you very much. Lemon will be very happy about this.

#

jchristgit

[python-discord/site] New review comment on pull request #608: Implement voice mute and migration from voice ban \-> voice mute

Hmm, out of curiosity, can't Django do a bulk update for all these infractions? It's probably a small count anyways, so it doesn't matter too much.

#

jchristgit

[python-discord/site] Pull request review submitted: #608 Implement voice mute and migration from voice ban \-> voice mute

This looks good to me. Thank you!

#

jchristgit

[python-discord/site] New comment on pull request #608: Implement voice mute and migration from voice ban \-> voice mute

THIS HAS TO BE MERGED AT THE SAME TIME AS BOT PR!

Can you link the bot PR? From a quick search, I couldn't find it

regal archBOT Oct 10, 2021, 12:34 PM

#

HassanAbouelela

[site:static\-previews] 1 new commit

03ad772 Move Static Build Into Separate Variable - HassanAbouelela

#

HassanAbouelela

[python-discord/site] New review comment on pull request #609: Static Previews

Changed in cf199b2b

odd spireBOT Oct 10, 2021, 12:35 PM

#

[python-discord/site] Checks Successful on PR: #609 Static Previews

GitHub Actions run 1325796078 succeeded.

PR Author

Workflow Run

Lint & Test #573

Source Branch

static-previews

regal archBOT Oct 10, 2021, 12:52 PM

#

ChrisLovering

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

Yea that's true. I can't think of a reason that an embed would appear in a thread without it being triggered by someone, which would imply they have seen the thread. So I'm not sure this is an issue either.

#

ChrisLovering

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

This is true. I am currently wondering if the cache is even worth it, since at this level getting data from the mongo db directly wouldn't add much noticeable delay.

#

ChrisLovering

[modmail-plugins:configurable\-appeal\-categories] 1 new commit

d447db8 Specifiy the bot loop when creating the init task - ChrisLovering

#

ChrisLovering

[python-discord/modmail-plugins] New review comment on pull request #4: Add a ping manager plugin

FWIW, I realised the reason I got away with this here is because plugins are loaded after the main bot is already up and running, so there's always a running event loop. Specifying the bot loop explicitly is still better here though.

odd spireBOT Oct 10, 2021, 2:31 PM

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1325993750 succeeded.

Actor

Workflow Run

Build & Deploy #12

Commit

cea8e97

regal archBOT Oct 10, 2021, 2:45 PM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1860 Attempt infraction before DMing

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1860: Attempt infraction before DMing

I'm not sure if this is the right behavior. When we go into the if failed branch and for hidden infractions, we don't want to show an envelope since there is nothing to be delivered. I guess we can just reset these two in those branches.

#

wookie184

[python-discord/bot] Pull request review submitted: #1861 Distinguish between note/warning and expired infraction

regal archBOT Oct 10, 2021, 3:07 PM

#

ichard26

[python-discord/bot] New comment on issue #1858: \`\!doc setdoc\` gives malformed request error when setting a package that already exists

I'd like to fix this issue as my first code contribution to the repo ^^ ... I suppose I should just assign this to myself or is that not how this works?

regal archBOT Oct 10, 2021, 3:23 PM

#

HassanAbouelela

[python-discord/site] Issue opened: #611 Remove Subdomains From Bot Guide

#526 and python-discord/bot#1630 removed subdomains from the bot and site this week, but we still need to update the guides to reflect those changes.

What needs to be done:

Under the configure the bot section, we will need to remove the mentions of subdomains, and instead mention query paths (localhost:8000/api for instance).
We should delete the guide on [setting up hosts](https://www.py...

regal archBOT Oct 10, 2021, 3:51 PM

#

Akarys42

[python-discord/bot] New comment on pull request #1815: Migrate to Discord 2\.0a0

I found some datetimes where the timezones haven't been replaced, should they be? See the following Sourcegraph searches:

Search for created_at

Search for edited_at

Went over those, they should (...

#

mbaruh

[python-discord/bot] Pull request review dismissed: #1815 Migrate to Discord 2\.0a0

#

Akarys42

[bot:discord\-2\.0] 87 new commits

2a83c5f Only check URL-like objects against domain filters - ChrisLovering
8e25ed1 Prevent infractions raising error due to role h... - TizzySaurus
8fa3fa1 Fix role hierarchy check - TizzySaurus
38dc1c6 Fix tests - TizzySaurus
6bb0dba Declare and refresh TalentPool.cache on init of... - ChrisLovering

odd spireBOT Oct 10, 2021, 3:56 PM

#

[python-discord/bot] Checks Successful on PR: #1815 Migrate to Discord 2.0a0

GitHub Actions run 1326133748 succeeded.

PR Author

Workflow Run

Lint & Test #1935

Source Branch

discord-2.0

regal archBOT Oct 10, 2021, 4:07 PM

#

D0rs4n

[python-discord/api] Issue opened: #19 Add new Infraction type \`Voice Mute\` \- Model changes inherited from site\.

Add new Infraction type Voice Mute, to the Infraction model (according to this PR)

regal archBOT Oct 10, 2021, 4:34 PM

#

gitautas

[python-discord/sir-lancebot] New review comment on pull request #879: Uwuification update\.

This should grab the text generated by the embed, i.e the preview of an article or something like that. This was a feature of the old uwu so I kept it for feature parity.

regal archBOT Oct 10, 2021, 5:13 PM

#

HassanAbouelela

[site:static\-previews] 1 new commit

036f1b6 Uses Nightly To Download Artifacts - HassanAbouelela

#

HassanAbouelela

[python-discord/site] New comment on pull request #609: Static Previews

Hey @jchristgit I've made some slight changes to the netlify build file. We now use https://nightly.site instead of a github token to increase security in our builds. Functionally, everything is still the same, and tested working on my fork.

odd spireBOT Oct 10, 2021, 5:15 PM

#

[python-discord/site] Checks Successful on PR: #609 Static Previews

GitHub Actions run 1326255387 succeeded.

PR Author

Workflow Run

Lint & Test #574

Source Branch

static-previews

regal archBOT Oct 10, 2021, 5:32 PM

#

jchristgit

[python-discord/site] Pull request review submitted: #609 Static Previews

@HassanAbouelela thanks! That's great news. More security 🚢🇮🇹

#

ichard26

[bot:fix\-bot\-1858] 1 new commit

412f9b4 Handle 400 when setting pre-existing doc package - ichard26

#

ichard26

[python-discord/bot] New branch created: fix\-bot\-1858

#

ichard26

[python-discord/bot] Pull request opened: #1865 Handle 400 when setting pre\-existing doc package

If you run, for example:

!doc setdoc black https://black.readthedocs/en/stable/objects.inv

twice over. You'll get an unhelpful "According to the API, your request
is malformed." error message back. This commit adds an error handler
to catch the HTTP 400 and tell the user the package already exists.

Fixes #1858

FYI this is my first proper contribution to the project so have fun requesting changes :wink:

odd spireBOT Oct 10, 2021, 5:50 PM

#

[python-discord/bot] Checks Successful on PR: #1865 Handle 400 when setting pre-existing doc package

GitHub Actions run 1326311487 succeeded.

PR Author

ichard26

Workflow Run

Lint & Test #1936

Source Branch

fix-bot-1858

regal archBOT Oct 10, 2021, 5:51 PM

#

ichard26

[bot] Branch fix\-bot\-1858 was force-pushed to `016f65b`

odd spireBOT Oct 10, 2021, 5:53 PM

#

[python-discord/bot] Checks Successful on PR: #1865 Handle 400 when setting pre-existing doc package

GitHub Actions run 1326315793 succeeded.

PR Author

ichard26

Workflow Run

Lint & Test #1937

Source Branch

fix-bot-1858

regal archBOT Oct 10, 2021, 6:20 PM

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #1865 Handle 400 when setting pre\-existing doc package

Looks good to me and works locally, thanks :D

#

Bluenix2

[python-discord/bot] Pull request review submitted: #1865 Handle 400 when setting pre\-existing doc package

Hello I am here to bikeshed, please stay calm.

#

Bluenix2

[python-discord/bot] New review comment on pull request #1865: Handle 400 when setting pre\-existing doc package

Would flipping this looks better?

Flip the if-statement to check if the status is not 400 and "already exists" does not exist in the package, then raise immediately and move the "safe" code out an indentation.

#

Bluenix2

[python-discord/bot] New review comment on pull request #1865: Handle 400 when setting pre\-existing doc package

This should have the all-familiar :x:

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1865: Handle 400 when setting pre\-existing doc package

I prefer it this way, rather than do a if with two nots in it. deal with the things we want to catch first, then raise afterwards

#

wookie184

[python-discord/bot] Pull request review submitted: #1865 Handle 400 when setting pre\-existing doc package

Works nicely, thanks!

Only thing I noticed while testing is that you can also get the same error from using a package name that is too long (50 seems to be the max). You can add something to handle this if you'd like.

regal archBOT Oct 10, 2021, 7:00 PM

#

jb3

[python-discord/site] Pull request review submitted: #609 Static Previews

#

jb3

[python-discord/site] Issue closed: #500 Long\-term: Deploy previews\!

#

jb3

[python-discord/site] Pull request closed: #609 Static Previews

#

jb3

[site:main] 10 new commits

e9c4cdf Adds Django Distill To Project - HassanAbouelela
247c4ba Adds Static Route Configurations - HassanAbouelela
595185d Adds Static Docker Build - HassanAbouelela
f9ba4a8 Adds Netlify Builds - HassanAbouelela
cf199b2 Fixes Caching On Docker Build - HassanAbouelela

#

jb3

[python-discord/site] branch deleted: static\-previews

odd spireBOT Oct 10, 2021, 7:05 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 1326441883 succeeded.

Actor

Workflow Run

Deploy #139

Commit

3f8854e

regal archBOT Oct 10, 2021, 7:07 PM

#

Sn4u

[python-discord/bot] New review comment on pull request #1865: Handle 400 when setting pre\-existing doc package

                await ctx.send(f"Package {package_name} has already been added.")

Is that a typo there?

#

HassanAbouelela

[python-discord/site] New comment on pull request #591: Restructure bot contributing guide

Well, I've seen the latest developments here after I opened an issue. I'll just link it to this PR

#

ichard26

[python-discord/bot] New review comment on pull request #1865: Handle 400 when setting pre\-existing doc package

haha, let's ignore the fact at least four people missed this :p

#

HassanAbouelela

[site:redirects] 1 new commit

41749a4 Adds Redirects To Static Builds - HassanAbouelela

#

HassanAbouelela

[python-discord/site] New branch created: redirects

#

HassanAbouelela

[python-discord/site] Pull request opened: #612 Adds Redirects To Static Builds

This PR continues the work done in #609, but adds redirects.

I've left quite a few comments there about redirects, and this is where I ended up now. It's kind of complicated, and not the most useful thing, so I decided to split it into a separate PR to help us decide what to do.

odd spireBOT Oct 10, 2021, 7:25 PM

#

[python-discord/site] Checks Failed on PR: #612 Adds Redirects To Static Builds

GitHub Actions run 1326479509 failed.

PR Author

Workflow Run

Lint & Test #576

Source Branch

redirects

regal archBOT Oct 10, 2021, 8:05 PM

#

HassanAbouelela

[site:redirects] 1 new commit

a1e8ade Adds Redirects To Static Builds - HassanAbouelela

odd spireBOT Oct 10, 2021, 8:07 PM

#

[python-discord/site] Checks Successful on PR: #612 Adds Redirects To Static Builds

GitHub Actions run 1326545574 succeeded.

PR Author

Workflow Run

Lint & Test #577

Source Branch

redirects

regal archBOT Oct 10, 2021, 8:07 PM

#

HassanAbouelela

[site] Branch redirects was force-pushed to `a7e9bdd`

odd spireBOT Oct 10, 2021, 8:09 PM

#

[python-discord/site] Checks Successful on PR: #612 Adds Redirects To Static Builds

GitHub Actions run 1326549622 succeeded.

PR Author

Workflow Run

Lint & Test #578

Source Branch

redirects

regal archBOT Oct 10, 2021, 8:26 PM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1815 Migrate to Discord 2\.0a0

This PR is not ready to be merged once reviewed, please wait for the great merge event.

#

HassanAbouelela

[python-discord/bot] Pull request review dismissed: #1815 Migrate to Discord 2\.0a0

This PR is not ready to be merged once reviewed, please wait for the great merge event.

regal archBOT Oct 10, 2021, 8:49 PM

#

janine9vn

[python-discord/bot] New comment on pull request #1833: \`\!contribute\` tag

@janine9vn Please address the reviews when you're available.

Will get this done this weekend~ (Totally missed that I had comments on this >_>)

#

TizzySaurus

[bot] Branch fix\-infract\-then\-dm was force-pushed to `1df1527`

#

TizzySaurus

[python-discord/bot] New review comment on pull request #1860: Attempt infraction before DMing

Yeah, that wasn't the correct behaviour. Should now be fixed :+1:

odd spireBOT Oct 10, 2021, 9:00 PM

#

[python-discord/bot] Checks Successful on PR: #1860 Attempt infraction before DMing

GitHub Actions run 1326632407 succeeded.

PR Author

Workflow Run

Lint & Test #1938

Source Branch

fix-infract-then-dm

regal archBOT Oct 10, 2021, 9:06 PM

#

janine9vn

[python-discord/bot] Issue opened: #1866 Change \`\!subscribe\` to Buttons for sub\-roles

This is coming from python-discord/meta#150.

Context

For recurring events where users might want to be notified about happenings, I'd like to add roles where we can ping people about information. The most notable application here is for PyWeek! Considering this functionality is very similar to the !subscribe command, we've determined the best UX would be to utilize the Discord Button Components and change how the !subscribe command works.

Details

This should have a button...

#

ChrisLovering

[python-discord/bot] New comment on issue #1866: Change \`\!subscribe\` to Buttons for sub\-roles

I'd like to add to this that the implementation should be extendable. IE adding a new role would just be the case of adding an ID to a list.

#

ichard26

[bot:fix\-bot\-1858] 1 new commit

72c843e Fix typo in bot/exts/info/doc/_cog.py

ichard26

odd spireBOT Oct 10, 2021, 9:10 PM

#

[python-discord/bot] Checks Successful on PR: #1865 Handle 400 when setting pre-existing doc package

GitHub Actions run 1326653371 succeeded.

PR Author

ichard26

Workflow Run

Lint & Test #1939

Source Branch

fix-bot-1858

regal archBOT Oct 10, 2021, 9:13 PM

#

ChrisLovering

[python-discord/bot] Issue closed: #1858 \`\!doc setdoc\` gives malformed request error when setting a package that already exists

#

ChrisLovering

[python-discord/bot] branch deleted: fix\-bot\-1858

#

ChrisLovering

[python-discord/bot] Pull request closed: #1865 Handle 400 when setting pre\-existing doc package

#

ChrisLovering

[bot:main] 3 new commits

016f65b Handle 400 when setting pre-existing doc package - ichard26
72c843e Fix typo in bot/exts/info/doc/_cog.py

ichard26
13135ce Merge pull request #1865 from python-discord/fi... - ChrisLovering

odd spireBOT Oct 10, 2021, 9:14 PM

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1326663931 succeeded.

Actor

Workflow Run

Build & Deploy #13

Commit

0fc6f49

oak estuaryBOT Oct 10, 2021, 9:16 PM

#

Python Bot

Connected!

odd spireBOT Oct 10, 2021, 9:16 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1326667907 succeeded.

Actor

Workflow Run

Deploy #466

Commit

13135ce

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1326668719 succeeded.

Actor

Workflow Run

Build & Deploy #14

Commit

62dcb36

odd spireBOT Oct 10, 2021, 10:56 PM

#

[python-discord/patsy] Workflow Cancelled

GitHub Actions run 1326832652 was cancelled.

Actor

Workflow Run

Build & Deploy #15

Commit

ca5aa19

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 1326833984 succeeded.

Actor

Workflow Run

Build & Deploy #16

Commit

296ca5d

regal archBOT Oct 11, 2021, 6:16 AM

#

Shivansh-007

[python-discord/bot] New comment on pull request #1446: Enhancing information within the incidents channel\.

Update: Good news! I am almost done with my exams, would be going through the reviews and mentioning the required changes within this week, I would be focusing on this PR over the other 2 first 🙂

odd spireBOT Oct 11, 2021, 6:39 AM

#

[python-discord/bot] Checks Successful on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 1327806068 succeeded.

PR Author

Workflow Run

Lint & Test #1941

Source Branch

Shivansh-007:feature/enhance...

odd spireBOT Oct 11, 2021, 7:09 AM

#

[python-discord/bot] Checks Successful on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 1327890989 succeeded.

PR Author

Workflow Run

Lint & Test #1942

Source Branch

Shivansh-007:feature/enhance...

odd spireBOT Oct 11, 2021, 7:25 AM

#

[python-discord/bot] Checks Successful on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 1327941032 succeeded.

PR Author

Workflow Run

Lint & Test #1943

Source Branch

Shivansh-007:feature/enhance...

regal archBOT Oct 11, 2021, 8:27 AM

#

Akarys42

[.github:review\-policies/do\-not\-merge\-tag] 2 new commits

b2e486a Review: add janine9vn to the event rule - Akarys42
52253e2 Review: add the do not merge rule - Akarys42

#

Akarys42

[python-discord/.github] New branch created: review\-policies/do\-not\-merge\-tag

#

Akarys42

[python-discord/.github] Pull request opened: #6 Review policy: do not merge tag

This adds a rule that won't ever complete (require a review from the ghost user, which cannot exist).
The rule is only applied if a "DO NOT MERGE" label is added to the PR.

The PR also adds @janine9vn to the event rule.

#

Xithrius

[python-discord/.github] Pull request review submitted: #6 Review policy: do not merge tag

I do an approve.

regal archBOT Oct 11, 2021, 9:00 AM

#

jb3

[python-discord/.github] Pull request review submitted: #6 Review policy: do not merge tag

I'd rather have something that matches our other labels, like review: do not merge.

#

Akarys42

[.github:review\-policies/do\-not\-merge\-tag] 1 new commit

8340885 Review: 'DO NOT MERGE' -> 'review: do not merge' - Akarys42

#

jb3

[python-discord/.github] Pull request review submitted: #6 Review policy: do not merge tag

#

jb3

[.github:main] 4 new commits

b2e486a Review: add janine9vn to the event rule - Akarys42
52253e2 Review: add the do not merge rule - Akarys42
8340885 Review: 'DO NOT MERGE' -> 'review: do not merge' - Akarys42
9ad0d98 Merge pull request #6 from python-discord/revie... - jb3

#

jb3

[python-discord/.github] Pull request closed: #6 Review policy: do not merge tag

regal archBOT Oct 11, 2021, 10:17 AM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1860 Attempt infraction before DMing

WIth the latest changes, some infraction types will send messages twice. Warns, for instance, get sent in the original block, then get sent again in the modified block.

We can get around this by adding a conditional opoosite to the not in (ban, kick) from the new block, but perhaps we should instead rework this so it's a little less confusing?

regal archBOT Oct 11, 2021, 10:48 AM

#

TizzySaurus

[python-discord/bot] New comment on pull request #1860: Attempt infraction before DMing

WIth the latest changes, some infraction types will send messages twice. Warns, for instance, get sent in the original block, then get sent again in the modified block.

We can get around this by adding a conditional opoosite to the not in (ban, kick) from the new block, but perhaps we should instead rework this so it's a little less confusing?

For some reason the second part of the if statement was missing. if not infraction["hidden"]: should be `if not infraction["hidden"] an...

#

TizzySaurus

[bot:fix\-infract\-then\-dm] 1 new commit

371869a Only send DM before applying infraction for ban... - TizzySaurus

odd spireBOT Oct 11, 2021, 10:52 AM

#

[python-discord/bot] Checks Successful on PR: #1860 Attempt infraction before DMing

GitHub Actions run 1328617004 succeeded.

PR Author

Workflow Run

Lint & Test #1944

Source Branch

fix-infract-then-dm

regal archBOT Oct 11, 2021, 10:56 AM

#

Akarys42

[python-discord/.github] branch deleted: review\-policies/do\-not\-merge\-tag

#

Akarys42

[bot:tags\-revision] 65 new commits

8e25ed1 Prevent infractions raising error due to role h... - TizzySaurus
8fa3fa1 Fix role hierarchy check - TizzySaurus
38dc1c6 Fix tests - TizzySaurus
e026c3e Apply infractions before DMing - TizzySaurus
13e5379 Raise InvalidHeaderError if inventory has inval... - Numerlor

#

Akarys42

[python-discord/bot] Issue closed: #1832 Tag Content Revision

#

Akarys42

[python-discord/bot] Pull request closed: #1836 Fix typos and grammar in tags

#

Akarys42

[bot:main] 10 new commits

18f0f36 Fix typos and grammar in tags - TizzySaurus
f249373 Merge branch 'main' into tags-revision - ToxicKidz
33b4f42 Bluenix Review - TizzySaurus
e7b5b60 Merge remote-tracking branch 'origin/tags-revis... - TizzySaurus
7ec98f7 Bluenix Review #2 - TizzySaurus

#

Akarys42

[python-discord/bot] branch deleted: tags\-revision

odd spireBOT Oct 11, 2021, 11:02 AM

#

[python-discord/bot] Checks Successful on PR: #1836 Fix typos and grammar in tags

GitHub Actions run 1328646103 succeeded.

PR Author

Workflow Run

Lint & Test #1945

Source Branch

tags-revision

oak estuaryBOT Oct 11, 2021, 11:05 AM

#

Python Bot

Connected!

odd spireBOT Oct 11, 2021, 11:06 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 1328662155 succeeded.

Actor

Workflow Run

Deploy #467

Commit

06e90af

regal archBOT Oct 11, 2021, 11:28 AM

#

TizzySaurus

[python-discord/api] Issue opened: #20 Add \`dm\_sent\` field to infractions database model

Refers to bot#1864 and site#610.

Make the necessary database model changes to this file in order to support infractions having a dm_sent field in the database which is shown upon !infraction command.

The field will be a nullable boolean (pre-existing infractions will have the value se...

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1860 Attempt infraction before DMing

This is the good stuff.

#

HassanAbouelela

[bot:fix\-infract\-then\-dm] 19 new commits

18f0f36 Fix typos and grammar in tags - TizzySaurus
f249373 Merge branch 'main' into tags-revision - ToxicKidz
33b4f42 Bluenix Review - TizzySaurus
e7b5b60 Merge remote-tracking branch 'origin/tags-revis... - TizzySaurus
7ec98f7 Bluenix Review #2 - TizzySaurus

odd spireBOT Oct 11, 2021, 11:34 AM

#

[python-discord/bot] Checks Successful on PR: #1860 Attempt infraction before DMing

GitHub Actions run 1328751956 succeeded.

PR Author

Workflow Run

Lint & Test #1947

Source Branch

fix-infract-then-dm

regal archBOT Oct 11, 2021, 11:41 AM

#

TizzySaurus

[python-discord/site] New comment on pull request #607: Sir\-Lancebot env changes

Admin should be the only role needed to test sir-lancebot features, so I think that's the only role we should mention on the main page (it makes sense to list the others on the reference page though).

I'd even say Helpers is stretching it a bit as what is necessary, although probably fair to mention so one can differentiate between MODERATION_ROLES and STAFF_ROLES in testing.

How exactly do you define "needed"? All of these roles are used within different checks etc. so to...

#

HassanAbouelela

[python-discord/site] New comment on pull request #607: Sir\-Lancebot env changes

Most of these roles are not needed to test the functionality of something. Yes they may be used in checks, but do you for instance need to test with mod,admin,etc or, would just admin suffice. Same sort of philosophy as the test server. You don't need all channels, to use the bot, so here is a shorter list of ones you do need. I think that's even more important here since we already have problems with the guides.

Unless you are adding a feature that needs that role specifically, we probabl...

regal archBOT Oct 11, 2021, 12:38 PM

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #898 AttributeError: 'AI' object has no attribute 'user'

Sentry Issue: SIR-LANCEBOT-6M

AttributeError: 'AI' object has no attribute 'user'
(8 additional frame(s) were not displayed)
...
  File "discord/ext/commands/core.py", line 1124, in can_run
    return await discord.utils.async_all(predicate(ctx) for predicate in predicates)  # type: ignore
  File "discord/utils.py", line 522, in async_all
    elem = await elem
  File "bot/exts/fun/tic_tac_toe...

#

TizzySaurus

[sir-lancebot:fix\-issue\-898] 1 new commit

b6a9ee8 Set AI.user to @Python - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: fix\-issue\-898

#

TizzySaurus

[sir-lancebot] Branch fix\-issue\-898 was force-pushed to `0c814ce`

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #899 Set \`AI\.user\` to @Python

Relevant Issues

Closes #898 .

Description

Resolved the AttributeError by setting AI.user to the bot (ctx.me)

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read and agree to the contributing guidelines?

odd spireBOT Oct 11, 2021, 12:58 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #899 Set `AI.user` to @Python

GitHub Actions run 1329037694 succeeded.

PR Author

Workflow Run

Lint #1765

Source Branch

fix-issue-898

regal archBOT Oct 11, 2021, 12:59 PM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #899 Set \`AI\.user\` to @Sir Lancebot

#

D0rs4n

[python-discord/api] New comment on issue #20: Add \`dm\_sent\` field to infractions database model

I'll implement this shortly, along with the other change in regarding the Infractions model.

#

D0rs4n

[python-discord/api] New comment on issue #19: Add new Infraction type \`Voice Mute\` \- Model changes inherited from site\.

I'll implement this shortly, along with the other change in regarding the Infractions model.

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #898: AttributeError: 'AI' object has no attribute 'user'

Duplicate of #772

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #898: AttributeError: 'AI' object has no attribute 'user'

Duplicate of #772

Good catch.

It seems in that issue they were planning to do isinstance checks, whereas I just set AI.user to @Sir Lancebot since that's way simpler. It also seems the user planning to do #772 never actually got around to it.

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #898: AttributeError: 'AI' object has no attribute 'user'

Yeah 👍🏻 Although there is an additional fix for game.channel mentioned by myself on the issue.

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #898: AttributeError: 'AI' object has no attribute 'user'

I can implement that as well I guess :+1:

#

TizzySaurus

[sir-lancebot:fix\-issue\-898] 1 new commit

462b83c Add missing Game.channel attribute - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #772: Handle the AI in Tic\-Tac\-Toe requester check\.

I didn't realise this PR existed; ended up solving myself in #899 by just setting AI.user to be @Sir Lancebot (since it's easier and less messy than having to do a bunch of isinstance checks).

Also added the missing Game.channel attribute that Shivansh pointed out.

Sorry for stealing this 😅

odd spireBOT Oct 11, 2021, 1:19 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #899 Set `AI.user` to @Sir Lancebot

GitHub Actions run 1329121925 succeeded.

PR Author

Workflow Run

Lint #1766

Source Branch

fix-issue-898

regal archBOT Oct 11, 2021, 1:24 PM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #772: Handle the AI in Tic\-Tac\-Toe requester check\.

Issue* 🙃

#

TizzySaurus

[python-discord/api] New comment on issue #20: Add \`dm\_sent\` field to infractions database model

I'll implement this shortly, along with the other change in regarding the Infractions model.

As discussed on discord, I'm planning to do this myself as part of bot#1864.

#

HassanAbouelela

[snekbox:bump\-310] 2 new commits

84a5e97 Bumps Python Version To 3.10 - HassanAbouelela
507ff42 Updates Runtime Modules For 3.10 - HassanAbouelela

#

HassanAbouelela

[python-discord/snekbox] New branch created: bump\-310

#

TizzySaurus

[python-discord/site] New comment on pull request #607: Sir\-Lancebot env changes

It was decided internally on Discord that this PR isn't something we're after.

We'd like to keep config to a bare minimum to make setting up the bot easier, and since the only strictly necessary role is Admins, that should be the only one that's configurable (as is currently the case).

#

TizzySaurus

[python-discord/site] Pull request closed: #607 Sir\-Lancebot env changes

#

TizzySaurus

[python-discord/site] branch deleted: lancebot\-env\-changes

#

TizzySaurus

[python-discord/sir-lancebot] New comment on pull request #896: Update \`constants\.Roles\`

It was decided internally on Discord that this PR isn't something we're after.

We'd like to keep config to a bare minimum to make setting up the bot easier, and since the only strictly necessary role is Admins, that should be the only one that's configurable (as is currently the case).

#

TizzySaurus

[python-discord/sir-lancebot] Pull request closed: #896 Update \`constants\.Roles\`

#

TizzySaurus

[python-discord/sir-lancebot] branch deleted: update\-role\-constants

#

[snekbox] GitHub Actions checks success on pull request #117

regal archBOT Oct 11, 2021, 2:02 PM

#

TizzySaurus

[sir-lancebot:update\-role\-constants] 6 new commits

11d00e7 Rename Roles.moderator to Roles.moderation_t... - TizzySaurus [71d800a](https://github.com/python-discord/sir-lancebot/commit/71d800add94df3d678786ab482747ae904290129) Rename Roles.admintoRoles.admins - TizzySaurus [dc5f73b](https://github.com/python-discord/sir-lancebot/commit/dc5f73be8c18ef11c701822e8c600c8fca7b149c) Rename Roles.ownertoRoles.owners - TizzySaurus [e2da188](https://github.com/python-discord/sir-lancebot/commit/e2da188b554aba07b6c5a7a25b8af0baa74973cb) Check role id in MODERATION_ROLES instead of co... - TizzySaurus [aa272db`](https://github.com/python-discord/sir-lancebot/commit/aa272dbe789e86013969bc6f4e506d70ddfc63be) Check role id in STAFF_ROLES instead of compari... - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: update\-role\-constants

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #900 Update role constants

Relevant Issues

N/A; this is a refined version of #896

Description

Renamed some role constants to reflect their in-server name
Added some safeguarding for .roles attribute
Corrected some typehints from Member to Union[User, Member]
Made some AOC commands guild-only since they require Member attributes (e.g. .aoc subscribe which updates the invoker's roles)

Did you:

[x] Join the Python Discord Community?
[x] Re...

odd spireBOT Oct 11, 2021, 2:09 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #900 Update role constants

GitHub Actions run 1329301799 succeeded.

PR Author

Workflow Run

Lint #1767

Source Branch

update-role-constants

regal archBOT Oct 11, 2021, 6:39 PM

#

HassanAbouelela

[snekbox:bump\-310] 1 new commit

ed35e11 Bumps Coverage Version - HassanAbouelela

#

[snekbox] GitHub Actions checks success on pull request #117

#

HassanAbouelela

[python-discord/snekbox] New comment on pull request #117: Bump To Python 3\.10

Having a weird thing with coverage, where it seems to think a branch was not hit when it was supposed to. That is theoretically possible, but the code and tests did not change, so I don't think there is an actual decrease in coverage, just either a bug with coverage now, or the one used to generate the initial report. I do not think this is related to my changes.

regal archBOT Oct 11, 2021, 7:06 PM

#

gustavwilliam

[python-discord/branding] New comment on pull request #164: Change banner

@InvisibleOS design wise, this is excellent! The only real issue now is the SVG itself.

There's currently text for "Python" and "Discord". When submitting source files (like SVGs), I'd recommend converting the text objects into paths (curves). Otherwise, anyone who doesn't have the font installed can't view the SVG correctly.

I'm far from an Inkscape expert, but I'll try to help you with this if you don't know (or can't figure out) how to do this 😄

regal archBOT Oct 11, 2021, 8:28 PM

#

jchristgit

[python-discord/api] New comment on issue #19: Add new Infraction type \`Voice Mute\` \- Model changes inherited from site\.

Reassigned 👍

#

jchristgit

[python-discord/api] New comment on issue #20: Add \`dm\_sent\` field to infractions database model

Reassigned 👍

odd spireBOT Oct 11, 2021, 9:09 PM

#

[python-discord/forms-backend] Checks Successful on PR: #108 Bump python-dotenv from 0.17.0 to 0.19.1

GitHub Actions run 1330590891 succeeded.

PR Author

dependabot[bot]

Workflow Run

Forms Backend #365

Source Branch

dependabot/pip/python-do...

regal archBOT Oct 11, 2021, 10:29 PM

#

HassanAbouelela

[snekbox:bump\-310] 1 new commit

b71e63c Uses Coveralls Github Action - HassanAbouelela

#

[snekbox] GitHub Actions checks failure on pull request #117

#

HassanAbouelela

[snekbox] Branch bump\-310 was force-pushed to `3f1e82d`

#

[snekbox] GitHub Actions checks failure on pull request #117

#

[snekbox] GitHub Actions checks success on pull request #117

#

HassanAbouelela

[python-discord/snekbox] Pull request closed: #117 Bump To Python 3\.10

#

HassanAbouelela

[python-discord/snekbox] Pull request reopened: #117 Bump To Python 3\.10

#

HassanAbouelela

[snekbox:bump\-310] 1 new commit

516ee00 Temp Commit - HassanAbouelela

#

[snekbox] GitHub Actions checks success on pull request #117

#

[snekbox] GitHub Actions checks success on pull request #117

#

[snekbox] GitHub Actions checks success on pull request #117

#

HassanAbouelela

[python-discord/snekbox] New comment on pull request #117: Bump To Python 3\.10

I'll leave this here as a historical footnote:

The latest 5.x version of coverage.py seems to have changed/broken something that meant we ended up with a lower coverage % than we did on main when it was last published. Version 6.x fixes that problem, but does not appear to be compatible with coveralls.

With no clear fix available, Mark suggested we remove the failure on coverage decreases, which is exactly what was done through the coveralls site. The coverage will technically be incorr...

regal archBOT Oct 11, 2021, 11:25 PM

#

MarkKoz

[python-discord/snekbox] Pull request review submitted: #117 Bump To Python 3\.10

#

MarkKoz

[python-discord/snekbox] Pull request closed: #117 Bump To Python 3\.10

#

MarkKoz

[snekbox:main] 4 new commits

84a5e97 Bumps Python Version To 3.10 - HassanAbouelela
507ff42 Updates Runtime Modules For 3.10 - HassanAbouelela
ed35e11 Bumps Coverage Version - HassanAbouelela
94da7f9 Merge #117 - Bump To Python 3.10 - MarkKoz

#

MarkKoz

[python-discord/snekbox] branch deleted: bump\-310

#

[snekbox] GitHub Actions checks success on main

#

[snekbox] GitHub Actions checks success on main

odd spireBOT Oct 11, 2021, 11:47 PM

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1330981115 succeeded.

Actor

Lint Kubernetes manifests #209

Workflow Run

Commit

d73c21b

regal archBOT Oct 12, 2021, 1:02 AM

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

I am not sure if that would be required, its just 3 trace logs and aren't doing any harm. Summarising would add unnecessary complexity to it, where you need to collect the IDs in a iterable and then log them.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

make_message_link_embed may return None if an exception was raised or helpers don't have message read perms in that linked message channel.

#

DMFriends

[python-discord/sir-lancebot] Pull request opened: #901 Madlibs

Relevant Issues

Closes #847

Description

This PR is designed to add a fun Madlibs game to Sir Lancebot.

When the command, .madlibs, is run, the bot will ask the user to enter a word that fits a random part of speech (e.g. noun, adjective, verb, plural noun, etc.). The user will simply send a message with any word that fits the given part of speech.

The bot chooses a random number of user inputs to use for the game and a random story.

Once the user has finished entering...

odd spireBOT Oct 12, 2021, 1:18 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #901 Madlibs

GitHub Actions run 1331194330 failed.

PR Author

Workflow Run

Lint #1768

Source Branch

DMFriends:madlibs

#

[python-discord/sir-lancebot] Checks Failed on PR: #901 Madlibs

GitHub Actions run 1331199944 failed.

PR Author

Workflow Run

Lint #1769

Source Branch

DMFriends:madlibs

#

[python-discord/bot] Checks Successful on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 1331202471 succeeded.

PR Author

Workflow Run

Lint & Test #1948

Source Branch

Shivansh-007:feature/enhance...

regal archBOT Oct 12, 2021, 1:28 AM

#

Shivansh-007

[python-discord/bot] New comment on pull request #1634: Modpings schedule

It isn't using the persistent scheduler, depending on whichever PR would get merged first, the other can do the required changes, it would be a quick change anyhow.

odd spireBOT Oct 12, 2021, 1:30 AM

#

[python-discord/bot] Checks Failed on PR: #1634 Modpings schedule

GitHub Actions run 1331216881 failed.

PR Author

Workflow Run

Lint & Test #1949

Source Branch

Shivansh-007:modpings-schedule

regal archBOT Oct 12, 2021, 1:31 AM

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #745: Add logic for preserving unloaded Cogs\.

Many of us aren't using redis on the bot, thus the async rediscache won't persist across runs and would be cleared. Hence for the purpose of testing, I have added those links, they would be removed before merging, as told in the PR description.

odd spireBOT Oct 12, 2021, 1:33 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #901 Madlibs

GitHub Actions run 1331222925 failed.

PR Author

Workflow Run

Lint #1770

Source Branch

DMFriends:madlibs

regal archBOT Oct 12, 2021, 1:45 AM

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #745: Add logic for preserving unloaded Cogs\.

The message link of the message which "ran" the command to unload the extension.

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #745: Add logic for preserving unloaded Cogs\.

We are using the unload_command to unload any extension, all unloads would pass through that function hence the logic for adding it to unloads cache is set in there.

Andd I didn't get why you commented this on the above code lines 🤔

odd spireBOT Oct 12, 2021, 1:48 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #901 Madlibs

GitHub Actions run 1331247835 failed.

PR Author

Workflow Run

Lint #1771

Source Branch

DMFriends:madlibs

#

[python-discord/sir-lancebot] Checks Failed on PR: #901 Madlibs

GitHub Actions run 1331283132 failed.

PR Author

Workflow Run

Lint #1772

Source Branch

DMFriends:madlibs

odd spireBOT Oct 12, 2021, 2:31 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #901 Madlibs

GitHub Actions run 1331356725 failed.

PR Author

Workflow Run

Lint #1773

Source Branch

DMFriends:madlibs

regal archBOT Oct 12, 2021, 6:38 AM

#

Akarys42

[python-discord/site] New comment on pull request #586: URLs: add an allow everything robots\.txt

We will be using a worker for this

#

Akarys42

[python-discord/site] Pull request closed: #586 URLs: add an allow everything robots\.txt

#

Akarys42

[python-discord/site] branch deleted: robots\.txt

regal archBOT Oct 12, 2021, 7:06 AM

#

Akarys42

[bot] Branch filters/dotgg\-boundary was force-pushed to `0bebd55`

odd spireBOT Oct 12, 2021, 7:08 AM

#

[python-discord/bot] Checks Successful on PR: #1817 Regex: add a word boundary before .gg

GitHub Actions run 1331995980 succeeded.

PR Author

Workflow Run

Lint & Test #1950

Source Branch

filters/dotgg-boundary

regal archBOT Oct 12, 2021, 8:35 AM

#

Akarys42

[workers:experiments/akarys/robots\.txt] 1 new commit

17e21c4 Server robots worker - Akarys42

#

Akarys42

[python-discord/workers] New branch created: experiments/akarys/robots\.txt

#

Akarys42

[python-discord/workers] Pull request opened: #13 Server robots worker

This worker will be used to serve robots.txt files across our infrastructure.

The worker should be set on *.pythondiscord.com/robots.txt and pythondiscord.com/robots.txt. Each robot file is defined in the robots/ directory, the file name being the domain the rule should be served on.

The rules will be defined in a later PR, right now only the main site is set up.

#

Akarys42

[python-discord/workers] New review comment on pull request #8: Support Webhooks From Labels

what is this semi-colon doing here?

regal archBOT Oct 12, 2021, 9:22 AM

#

Akarys42

[python-discord/workers] New branch created: feature/9/hastebin\-filter

#

Akarys42

[workers:feature/9/hastebin\-filter] 1 new commit

b62dbd2 Hastebin filter - Akarys42

#

Akarys42

[python-discord/workers] Pull request opened: #14 Hastebin filter

This worker is in charge of filtering out uploads that contain seemingly valid tokens.

Closes #9

regal archBOT Oct 12, 2021, 10:29 AM

#

Qwerty-133

[python-discord/bot] New branch created: watch\-output

odd spireBOT Oct 12, 2021, 12:57 PM

#

[python-discord/branding] Checks Successful on PR: #164 Change banner

GitHub Actions run 1333174501 succeeded.

PR Author

InvisibleOS

Workflow Run

Event Validation #47

Source Branch

InvisibleOS:halloween-bran...

regal archBOT Oct 12, 2021, 3:36 PM

#

D0rs4n

[python-discord/api] Pull request opened: #21 Add Voice Mute and modify the field size of \`type\` in the Infraction Model

Closes #19

regal archBOT Oct 12, 2021, 3:53 PM

#

ChrisLovering

[python-discord/bot] New comment on issue #1866: Change \`\!subscribe\` to Buttons for sub\-roles

Since no one has expressed interest directly for two days, I'm going to pick this one up myself, since I quite want to do it :D

#

Kronifer

[python-discord/branding] New comment on issue #75: Cowboy lemoji, please\.

@Xithrius shouldn't this be closed as we already have a cowboy lemoji now

#

Xithrius

[python-discord/branding] New comment on issue #75: Cowboy lemoji, please\.

yuh

#

Xithrius

[python-discord/branding] Issue closed: #75 Cowboy lemoji, please\.

regal archBOT Oct 12, 2021, 4:50 PM

#

jchristgit

[python-discord/api] Pull request review submitted: #21 Add Voice Mute and modify the field size of \`type\` in the Infraction Model

#

jchristgit

[python-discord/api] Issue closed: #19 Add new Infraction type \`Voice Mute\` \- Model changes inherited from site\.

#

jchristgit

[python-discord/api] Pull request closed: #21 Add Voice Mute and modify the field size of \`type\` in the Infraction Model

#

jchristgit

[api:main] 2 new commits

04ffbe2 Add Voice Mute and modify the field size of ty... - D0rs4n [551d8a2`](https://github.com/python-discord/api/commit/551d8a2def405808bcaa22230474f286f85f6723) Merge pull request #21 from D0rs4n/pr/infractio... - jchristgit

#

jchristgit

[python-discord/api] New comment on pull request #21: Add Voice Mute and modify the field size of \`type\` in the Infraction Model

Thanks!

regal archBOT Oct 12, 2021, 5:23 PM

#

D0rs4n

[python-discord/api] Issue opened: #22 Migrate \`reminders\` endpoint from the site API

At this point, I believe it's time we started migrating a few of the endpoints, there is an issue regarding the off-topic names endpoint, however I think we can also migrate the reminders endpoint, to see a more complicated one in this new environment as well.
(Although, the Alembic migration environment hasn't been set up just yet, a PR should come up anytime now.)
I would be glad If I could implement( or more like migrate) this one myself. (If it's possible, of course)

regal archBOT Oct 12, 2021, 6:12 PM

#

Qwerty-133

[bot:watch\-output] 1 new commit

5839e63 Send the user's mention in the watch command. - Qwerty-133

#

Qwerty-133

[python-discord/bot] Pull request opened: #1867 Use mentions instead of usernames in the \`watch\` command's output\.

This would make the output consistent with other moderation commands.

odd spireBOT Oct 12, 2021, 6:16 PM

#

[python-discord/bot] Checks Successful on PR: #1867 Use mentions instead of usernames in the `watch` command's output.

GitHub Actions run 1334325012 succeeded.

PR Author

Qwerty-133

Workflow Run

Lint & Test #1951

Source Branch

watch-output

regal archBOT Oct 12, 2021, 6:51 PM

#

Xithrius

[python-discord/bot] New comment on pull request #1867: Use mentions instead of usernames in the \`watch\` command's output\.

Stalled due to no discussion being had beforehand. This will be un-stalled once users agree on what should be done.

regal archBOT Oct 12, 2021, 7:39 PM

#

ChrisLovering

[bot:subscribe\-with\-buttons] 4 new commits

2a5ff30 Move handle_role_change to a util file - ChrisLovering
53c5258 Remove the subscribe command from the verificat... - ChrisLovering
42b196f Add the PyWeek announcements role - ChrisLovering
cce4ba7 AMMEND ME! Add stub for the subscribe command - ChrisLovering

#

ChrisLovering

[python-discord/bot] New branch created: subscribe\-with\-buttons

#

ChrisLovering

[python-discord/bot] Pull request opened: #1868 Subscribe with buttons

Closes #1866

This is based on top of #1815, so will need rebasing before merging.

odd spireBOT Oct 12, 2021, 7:43 PM

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1334603808 succeeded.

PR Author

Workflow Run

Lint & Test #1952

Source Branch

subscribe-with-buttons

regal archBOT Oct 12, 2021, 7:44 PM

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

These buttons seem to be dynamically generated, their ids should be modified before the view is sent.

#

onerandomusername

[python-discord/bot] Pull request review submitted: #1868 Subscribe with buttons

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

This should 100% have a custom id assigned to it.

While I know this is still a work in progress, this is a very important note.

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Yea, my idea was to have the custom ID be the role id.

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Ah, I would also prefix the IDs with something particular for this cog/function

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Yea, makes sense, I'll prefix it with the cog name since it's easily done

regal archBOT Oct 12, 2021, 8:19 PM

#

gustavwilliam

[python-discord/bot] Issue opened: #1869 Helpers can’t mention others in reminders

Helpers (and partners/python community) should be able to mention other users, but not roles, in reminders. In late June, this was still possible, but it currently isn't.

While looking through the source code and git blame (looks calmly at @TizzySaurus), I think I managed to locate the issue to the Reminders._check_mentions method. For a non-mod helper, the error message when mentioning another user in a reminder (should be allowed), is the error message that should be used when trying t...

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #899: Fix \`AttributeError\`s in tic\-tac\-toe command

This is the error that occurs now when two users try to play against AI, one after the other, while one game is still in progress. Is this the desired output?

#

TizzySaurus

[python-discord/bot] New comment on issue #1869: Helpers can’t mention others in reminders

Looking through the code, the _check_mentions method seems to do exactly what it should. The MODERATIONS_ROLES check is for mentioning roles.

elif await has_no_roles_check(ctx, *MODERATION_ROLES):
    return all(isinstance(mention, discord.Member) for mention in mentions), "roles"

This essentially says "if the user isn't a moderator, and they mentioned a role, return False -- since only mods can mention roles". To me that's exactly what should happen.

#

TizzySaurus

[python-discord/sir-lancebot] New comment on pull request #899: Fix \`AttributeError\`s in tic\-tac\-toe command

This is the error that occurs now when two users try to play against AI, one after the other, while one game is still in progress. Is this the desired output?

The code from before this PR made it so that their can only even be one command per channel, and the user invoking the command cannot already be playing a game.

I guess the missing channel attribute of the `Ga...

odd spireBOT Oct 12, 2021, 8:37 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #901 Madlibs

GitHub Actions run 1334781907 succeeded.

PR Author

Workflow Run

Lint #1774

Source Branch

DMFriends:madlibs

regal archBOT Oct 12, 2021, 8:40 PM

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #778: Merge automatic issue linking into the github cog

Isn't the point of dataclasses that it can do this for us?

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #778 Merge automatic issue linking into the github cog

regal archBOT Oct 12, 2021, 9:00 PM

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #901 Madlibs

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

I assume this should be removed?

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

This looks like dead code from an older implementation.

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Does this even work? I thought you did event="message"?

Remember that here we use double-quotes

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Ok, I guess that works. I will fix that.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

I asked @Shom770 over DM and he said that I have to say "on_message" instead of "message". I don't know where he got that from though. If you are absolutely certain it is "message", I will gladly change it back.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

No? I want the user to know how many inputs there are left for them to enter. Why should this be removed?

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Yes, indeed! Since this is my first time contributing, I used parts of the hangman implementation that I worked on with @Shom770 in my code. However, that is not dead code. I changed that according to the game I am writing.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

I'm a bit confused. I think you might be misunderstanding the point of this game. I want the exact opposite of what you said - I do not, under any circumstances, want the bot to use the same template every time. That would make the game very boring because the point of the game is that the player does not know what the template is. That's what makes this game more interesting. However, it is using the same JSON file with the templates, but the templates used in the game should not be the same.

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

I understand what you're trying to do now, so the issue is that i = 0 above. So you basically create a variable and then increment it, which looks pretty useless.

What you need to do is store this i somewhere. Either on the class (self.tries) or perhaps return it and let the game pass it again.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Ok, got it. I'll try to see what I can do with that.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

@Bluenix2 Can you elaborate a little on what self.tries means?

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

self.tries is a hypothetical attribute, just an example of one you can create.

You need to store this integer somewhere.

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Right, but this is what you're telling Python to do.

You're saying, "Hey open this file and remember a random template."

You should store all templates in a variable and randomly pick one when you start a game.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

The templates are really long, so I'm not sure whether or not it makes sense to store them in a variable. My knowledge of JSON is currently very limited, so I'm not even sure how variables work in JSON (if that even is a thing). Unless you were talking about the Python program itself?

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

@Bluenix2 Is this what you were looking for?
timeout = await self.bot.wait_for(event='on_message', timeout=60.0)

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Yes I was talking about Python itself. Right now you're only "remembering" one of those templates.

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

No I was thinking TIMEOUT = 60.0 at the top of the file. And then you use this variable with the keyword-argument timeout=TIMEOUT

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Ah, ok, will do.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

I think you're missing something. This is all that is needed for the purpose of the game. I don't need to manipulate the templates in any way, why would I need to do anything more than just "remember" a random template. Maybe I'm still missing something?

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Well it means that two games will use the same template, because you don't pick a new one each time.

#

ChrisLovering

[bot] Branch subscribe\-with\-buttons was force-pushed to `09071ad`

odd spireBOT Oct 12, 2021, 10:16 PM

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1335068246 succeeded.

PR Author

Workflow Run

Lint & Test #1953

Source Branch

subscribe-with-buttons

regal archBOT Oct 12, 2021, 10:30 PM

#

ChrisLovering

[bot] Branch subscribe\-with\-buttons was force-pushed to `c36cb9d`

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

I presume that the changes in this file is because its being compared to main and not the branch of the other pr.

#

onerandomusername

[python-discord/bot] Pull request review submitted: #1868 Subscribe with buttons

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Maybe a comment, these roles are able to be added with the subscribe command.

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

is it worth trying to fetch the role here if its not in the cache?

#

onerandomusername

[python-discord/bot] New comment on pull request #1868: Subscribe with buttons

I have more changes, but github doesn't let you finish a review if the diff is changed while reviewing it...

odd spireBOT Oct 12, 2021, 10:32 PM

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1335108322 succeeded.

PR Author

Workflow Run

Lint & Test #1954

Source Branch

subscribe-with-buttons

regal archBOT Oct 12, 2021, 10:33 PM

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Should this be an error instead of a warning?

#

onerandomusername

[python-discord/bot] Pull request review submitted: #1868 Subscribe with buttons

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

I call wait_until_guild_available at the start, which doesn't get set if the role cache is empty. We can assume if it's not in the cache, it doesn't exist in the guild.

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

No, the changes to this file is because I moved handle_role_change out of here and into a helper function

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Yea, the comment is in the config.yml already, I can copy that comment to here.

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Ah okay, I'll review that too after I eat.

#

ChrisLovering

[bot] Branch subscribe\-with\-buttons was force-pushed to `294a008`

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Having checked other cogs that do something similar to this, yes it should be for consistency.

odd spireBOT Oct 12, 2021, 10:38 PM

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1335123302 succeeded.

PR Author

Workflow Run

Lint & Test #1955

Source Branch

subscribe-with-buttons

regal archBOT Oct 12, 2021, 10:38 PM

#

ChrisLovering

[bot] Branch subscribe\-with\-buttons was force-pushed to `6aa2121`

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

force pushed

odd spireBOT Oct 12, 2021, 10:40 PM

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1335129654 succeeded.

PR Author

Workflow Run

Lint & Test #1956

Source Branch

subscribe-with-buttons

regal archBOT Oct 12, 2021, 10:45 PM

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Should check if interaction.user is a Member here, before attempting to update the roles, since it could be a User.

In the case it's a User, delete the interaction.message

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Could you explain why? I don't see how those lines of code that you commented on would make the bot use the same template twice.

#

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Because you load the file and pick a random one at the start. A new one is newer picked.

It's like this code:

def random_number():
    # Guaranteed random by dice roll
    return 4

regal archBOT Oct 12, 2021, 11:19 PM

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

The templates are really long, so I'm not sure whether or not it makes sense to store them in a variable. My knowledge of JSON is currently very limited, so I'm not even sure how variables work in JSON (if that even is a thing). Unless you were talking about the Python program itself?

Ok. This is starting to make a little more sense. But as I said above, the templates are really long, so I don't know how I would save them to a variable like you suggested. Is there anything else you could s...

regal archBOT Oct 13, 2021, 1:33 AM

#

Kronifer

[python-discord/sir-lancebot] Pull request opened: #902 feat: added cowsay

Relevant Issues

Closes #667

Description

Added a cowsay command that emulates the classic CLI tool.

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read and agree to the [contributing guidelines](https://pythond...

odd spireBOT Oct 13, 2021, 1:34 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #902 feat: added cowsay

GitHub Actions run 1335560443 failed.

PR Author

Workflow Run

Lint #1775

Source Branch

Kronifer:cowsay

regal archBOT Oct 13, 2021, 2:25 AM

#

Shivansh-007

[python-discord/api] Pull request review submitted: #18 Make development workflow easier to use

regal archBOT Oct 13, 2021, 2:42 AM

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Is this what you were looking for? @Bluenix2
TIMEOUT = 60.0 await self.bot.wait_for(event='on_message', timeout=TIMEOUT)

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Actually, there is one thing I can think of, but I'm not sure if it's very efficient. What do you think about this? @Bluenix2
`madlibs_stories = Path("bot/exts/fun/madlibs/madlibs_templates.json")

with madlibs_stories as file:
templates = [
file["templates"][0],
file["templates"][1],
file["templates"][2],
file["templates"][3],
file["templates"][4],
file["templates"][5],
file["templates"][6],
file["templates"][7],
...

regal archBOT Oct 13, 2021, 6:55 AM

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Why not use a list comprehension? Something like

with madlibs_stories as file:
    templates = [template for template in file["templates"]]

Although I can't help but feel like this isn't valid syntax. You probably need with open(madlibs_stories) and then files aren't subscriptable, so file["templates"] isn't valid.

If you're trying to load JSON, I'd recommend reading this RealPython tutorial on how to do so.

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Is this what you were looking for? @Bluenix2 TIMEOUT = 60.0 await self.bot.wait_for(event='on_message', timeout=TIMEOUT)

Yes, but make sure the TIMEOUT variable is defined at the top of the file (just after the imports) since it's a constant.

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Maybe mention that the "random number of user inputs" is within the specified bounds of the command arguments.

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

As of the cleanup PR on sir-lancebot, we now use list over List. You should also specify the types within the list (e.g. list[str]) if possible.

regal archBOT Oct 13, 2021, 8:37 AM

#

ChrisLovering

[bot:subscribe\-with\-buttons] 2 new commits

60ae5ea Ensure the user interacting is still in guild b... - ChrisLovering
c5f530d Handle subscribe messages being deleted before ... - ChrisLovering

odd spireBOT Oct 13, 2021, 8:39 AM

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1336648640 succeeded.

PR Author

Workflow Run

Lint & Test #1957

Source Branch

subscribe-with-buttons

regal archBOT Oct 13, 2021, 11:18 AM

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Ok, I will add that.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Ok, will do.

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Ok. I will take a look at your reviews later today.

regal archBOT Oct 13, 2021, 1:47 PM

#

HassanAbouelela

[workers:label\-webhooks] 1 new commit

c5c5a7b Remove Dangling Semicolon - HassanAbouelela

#

HassanAbouelela

[python-discord/workers] New review comment on pull request #8: Support Webhooks From Labels

Just making sure the dev-ops team is paying attention! 10/10, would test again.

Fixed in c5c5a7b7.

#

Akarys42

[python-discord/workers] Pull request review submitted: #8 Support Webhooks From Labels

Thank you mister hassan

#

Akarys42

[python-discord/workers] Pull request closed: #8 Support Webhooks From Labels

#

Akarys42

[workers:main] 5 new commits

99280de Adds Support For Github Webhooks From Labels - HassanAbouelela
f9d0f77 Adds KV ID - HassanAbouelela
5f0d79f Adds Support For Pull Requests - HassanAbouelela
c5c5a7b Remove Dangling Semicolon - HassanAbouelela
22d1f8b Merge pull request #8 from python-discord/label... - Akarys42

#

Akarys42

[python-discord/workers] branch deleted: label\-webhooks

#

[workers] Deploy failure on main

#

[workers] GitHub Actions checks failure on main

#

Akarys42

[python-discord/workers] New comment on pull request #5: Bump browserslist from 4\.16\.3 to 4\.16\.6 in /github\-filter\-worker

@dependabot rebase

#

Akarys42

[python-discord/workers] New comment on pull request #6: Bump browserslist from 4\.16\.4 to 4\.16\.6 in /short\-urls

@dependabot rebase

#

Akarys42

[python-discord/workers] New comment on pull request #7: Bump browserslist from 4\.16\.4 to 4\.16\.6 in /report\-uri

@dependabot rebase

#

Akarys42

[python-discord/workers] New comment on pull request #10: Bump path\-parse from 1\.0\.6 to 1\.0\.7 in /github\-filter\-worker

@dependabot rebase

#

Akarys42

[python-discord/workers] New comment on pull request #11: Bump path\-parse from 1\.0\.6 to 1\.0\.7 in /short\-urls

@dependabot rebase

#

Akarys42

[python-discord/workers] New comment on pull request #12: Bump path\-parse from 1\.0\.6 to 1\.0\.7 in /report\-uri

@dependabot rebase

#

Akarys42

[workers:main] 2 new commits

77f78d8 Bump browserslist from 4.16.3 to 4.17.3 in /git... - dependabot[bot]
3aee80d Merge pull request #15 from python-discord/depe... - Akarys42

#

Akarys42

[python-discord/workers] Pull request closed: #15 Bump browserslist from 4\.16\.3 to 4\.17\.3 in /github\-filter\-worker

#

Akarys42

[python-discord/workers] Pull request closed: #16 Bump browserslist from 4\.16\.4 to 4\.17\.3 in /short\-urls

#

Akarys42

[workers:main] 2 new commits

46f48db Bump browserslist from 4.16.4 to 4.17.3 in /sho... - dependabot[bot]
be33c26 Merge pull request #16 from python-discord/depe... - Akarys42

#

Akarys42

[python-discord/workers] Pull request closed: #10 Bump path\-parse from 1\.0\.6 to 1\.0\.7 in /github\-filter\-worker

#

Akarys42

[workers:main] 2 new commits

3291c53 Bump path-parse from 1.0.6 to 1.0.7 in /github-... - dependabot[bot]
a3557a8 Merge pull request #10 from python-discord/depe... - Akarys42

#

Akarys42

[workers:main] 1 new commit

cb1d29a Upgrade dependencies - Akarys42

#

Akarys42

[python-discord/workers] Pull request closed: #12 Bump path\-parse from 1\.0\.6 to 1\.0\.7 in /report\-uri

#

Akarys42

[python-discord/workers] Pull request closed: #11 Bump path\-parse from 1\.0\.6 to 1\.0\.7 in /short\-urls

#

Akarys42

[python-discord/workers] Pull request closed: #17 Bump browserslist from 4\.16\.4 to 4\.17\.3 in /report\-uri

#

Akarys42

[python-discord/workers] Pull request closed: #18 Bump browserslist from 4\.16\.4 to 4\.17\.3 in /short\-urls

#

Akarys42

[python-discord/workers] Pull request closed: #19 Bump browserslist from 4\.16\.3 to 4\.17\.3 in /github\-filter\-worker

#

Akarys42

[workers:main] 1 new commit

97b4334 Rename github-filter-worker to github-filter - Akarys42

#

Akarys42

[bot:discord\-2\.0] 14 new commits

18f0f36 Fix typos and grammar in tags - TizzySaurus
f249373 Merge branch 'main' into tags-revision - ToxicKidz
33b4f42 Bluenix Review - TizzySaurus
e7b5b60 Merge remote-tracking branch 'origin/tags-revis... - TizzySaurus
7ec98f7 Bluenix Review #2 - TizzySaurus

odd spireBOT Oct 13, 2021, 2:31 PM

#

[python-discord/bot] Checks Successful on PR: #1815 Migrate to Discord 2.0a0

GitHub Actions run 1337913259 succeeded.

PR Author

Workflow Run

Lint & Test #1958

Source Branch

discord-2.0

regal archBOT Oct 13, 2021, 2:39 PM

#

brad90four

[python-discord/bot] Pull request review submitted: #1815 Migrate to Discord 2\.0a0

LGTM

regal archBOT Oct 13, 2021, 4:50 PM

#

ChrisLovering

[bot:subscribe\-with\-buttons] 1 new commit

bed2b35 Add 10s member cooldown to subscribe command - ChrisLovering

#

ChrisLovering

[bot:subscribe\-with\-buttons] 1 new commit

ab9be33 Stop listening for events when message is deleted - ChrisLovering

odd spireBOT Oct 13, 2021, 4:52 PM

#

[python-discord/bot] Checks Cancelled on PR: #1868 Subscribe with buttons

GitHub Actions run 1338433914 was cancelled.

PR Author

Workflow Run

Lint & Test #1959

Source Branch

subscribe-with-buttons

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1338438607 succeeded.

PR Author

Workflow Run

Lint & Test #1960

Source Branch

subscribe-with-buttons

regal archBOT Oct 13, 2021, 5:55 PM

#

sentry-io[bot]

[python-discord/bot] Issue opened: #1870 TypeError: object of type 'NoneType' has no len\(\)

Sentry Issue: BOT-1NS

TypeError: object of type 'NoneType' has no len()
(2 additional frame(s) were not displayed)
...
  File "bot/exts/moderation/infraction/_scheduler.py", line 85, in reapply_infraction
    expiry = dateutil.parser.isoparse(infraction["expires_at"]).replace(tzinfo=None)
  File "dateutil/parser/isoparser.py", line 37, in func
    return f(self, str_in, *args, **kwargs)
  Fil...

regal archBOT Oct 13, 2021, 6:19 PM

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Docstring is now incorrect.

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

Minor minor nitpick, is it possible to alphabetize these?
Or, if the command does it based on the order here, comment as such.

Not sure if it makes sense to give these aliases/tags and have a second category which uses them too so all roles in that are used by the subscribe command, could be cool.

#

onerandomusername

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

This may need to stay for the verify command, Not sure if it can raise this or not,

#

onerandomusername

[python-discord/bot] Pull request review submitted: #1868 Subscribe with buttons

odd spireBOT Oct 13, 2021, 6:30 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #902 feat: added cowsay

GitHub Actions run 1335560443 failed.

PR Author

Workflow Run

Lint #1775

Source Branch

Kronifer:cowsay

odd spireBOT Oct 13, 2021, 6:46 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #902 feat: added cowsay

GitHub Actions run 1338813238 failed.

PR Author

Workflow Run

Lint #1776

Source Branch

Kronifer:cowsay

regal archBOT Oct 13, 2021, 7:21 PM

#

DMFriends

[python-discord/sir-lancebot] New review comment on pull request #901: Madlibs

Yeah @TizzySaurus, I have the TIMEOUT = 60.0 just below the imports and the await statement right before the class definition. Is that ok?

#

janine9vn

[python-discord/sir-lancebot] Issue opened: #903 Python Trivia Night Command\(s\)

Description

One of the events I'm planning to host in 2022 is a Python Trivia Night! People will gather in a stage channel and we'll be asking Python Trivia questions for people to answer. To help with participation and running the event, I'd like to have a cog/extension with a set of commands to help facilitate this.

Proposed Implementation

I'd like a new set of commands under .trivianight or .triviaevent.

.trivianight load will accept a json file of appropriately f...

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

There is no in whitelist check in the verify cog now, so this isn't needed.

#

ChrisLovering

[bot] Branch subscribe\-with\-buttons was force-pushed to `100443f`

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

fixed with the force push

#

ChrisLovering

[bot] Branch subscribe\-with\-buttons was force-pushed to `1aa2b12`

odd spireBOT Oct 13, 2021, 7:33 PM

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1338963829 succeeded.

PR Author

Workflow Run

Lint & Test #1961

Source Branch

subscribe-with-buttons

regal archBOT Oct 13, 2021, 7:34 PM

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1868: Subscribe with buttons

alphabetised in the force push, won't fix the second part, the rest of the yml file uses comments to distinguish groupings like this, which this has. I don't want to add a new class that needs to be imported just for the subscribe cog.

night lilyBOT Oct 13, 2021, 7:34 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 13, 2021, 7:35 PM

#

[python-discord/bot] Checks Successful on PR: #1868 Subscribe with buttons

GitHub Actions run 1338971509 succeeded.

PR Author

Workflow Run

Lint & Test #1962

Source Branch

subscribe-with-buttons

regal archBOT Oct 13, 2021, 7:44 PM

#

ChrisLovering

[sir-lancebot:update\-advent\-of\-code\-channel\-ids] 1 new commit

b0be25b update advent of code channel IDs - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] New branch created: update\-advent\-of\-code\-channel\-ids

#

ChrisLovering

[python-discord/sir-lancebot] Pull request opened: #904 update advent of code channel IDs

Description

We deleted and re-made the channels so new IDs are needed.

Did you:

[ ] Join the Python Discord Community?
[ ] Read all the comments in this template?
[ ] Ensure there is an issue open, or link relevant discord discussions?
[ ] Read and agree to the contributing guidelines?

odd spireBOT Oct 13, 2021, 7:46 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #904 update advent of code channel IDs

GitHub Actions run 1339007203 succeeded.

PR Author

Workflow Run

Lint #1777

Source Branch

update-advent-of-code-channel-ids

regal archBOT Oct 13, 2021, 7:46 PM

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #905 Channel "advent\_of\_code" with ID 782715290437943306 missing

Sentry Issue: SIR-LANCEBOT-3E

Channel "advent_of_code" with ID 782715290437943306 missing

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #906 AttributeError: 'NoneType' object has no attribute 'guild'

Sentry Issue: SIR-LANCEBOT-6Q

AttributeError: 'NoneType' object has no attribute 'guild'
  File "bot/exts/events/advent_of_code/_helpers.py", line 524, in new_puzzle_notification
    aoc_role = aoc_channel.guild.get_role(AdventOfCode.role_id)

Background task `Daily AoC Notification` failed:

#

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #904 update advent of code channel IDs

Well I can't test it in the server, but these are the correct channel IDs haha

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #904 update advent of code channel IDs

I've checked as well that these are the correct IDs, and they are. Very nice.

#

Xithrius

[python-discord/sir-lancebot] Issue closed: #905 Channel "advent\_of\_code" with ID 782715290437943306 missing

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #904 update advent of code channel IDs

#

Xithrius

[sir-lancebot:main] 2 new commits

b0be25b update advent of code channel IDs - ChrisLovering
f16e778 Merge pull request #904 from python-discord/upd... - Xithrius

#

Xithrius

[python-discord/sir-lancebot] branch deleted: update\-advent\-of\-code\-channel\-ids

#

ChrisLovering

[python-discord/sir-lancebot] Issue closed: #906 AttributeError: 'NoneType' object has no attribute 'guild'

night lilyBOT Oct 13, 2021, 7:56 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 13, 2021, 7:57 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1339035704 succeeded.

Actor