dev-log

[regal arch]

MarkKoz

[python-discord/bot] Pull request opened: #1752 Help channels: fix initialisation of available channels set

Fixes #1715

If the cog is reloaded while there are less than the maximum amount of available channels, it makes some channels available until the limit is reached. When a channel is made available, it updates the available_help_channels set. The update_available_help_channels() function would not update this set if it sees that the set already contains elements. This resulted in only the channels that were just made available being in the set; the set would not contain the channels tha...

[odd spire]

[python-discord/bot] Checks Successful on PR: #1752 Help channels: fix initialisation of available channels set

GitHub Actions run 1133944981 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1531

Source Branch

bug/help/1715/avail-set-init

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on pull request #281: Time Command

Hey @scragly, I hope you're doing well.

Just checking up on this PR since it's been a couple months. How goes it?

Xithrius

[python-discord/sir-lancebot] New comment on pull request #555: Ports LinePaginator from python\-discord bot to fix overflowing line issue

@melodicht will you be able to finish off this PR?

Hi, I have made changes to the PR, hopefully that fixes the conflicts.

Thank you for the changes, but there seems to be more conflicts. Please ping me when they're resolved.

Xithrius

[python-discord/sir-lancebot] New comment on pull request #586: Implemented youtube command

@SuperMaZingCoder are you still interested in doing this feature? If not, that's completely fine, happens to a lot of people including myself.

As always, take the time that you need.

Xithrius

[python-discord/sir-lancebot] New comment on pull request #610: Teapot support

This user has not been active for some time on GitHub. This PR is now up for grabs, just ping me if you'd like to take it.

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on pull request #732: Music Command

@magicandcode will you eventually be resolving the reviews in this PR?

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #778 Merge automatic issue linking into the github cog

LGTM, just fix up this and we should be good to go.

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

@decorator-factory has noticed that this PR still uses fuzzywuzzy, which contains the GPLv2 license. We now use rapidfuzz because it uses the MIT license, so this new feature needs to reflect this change.

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #806 Love command checks

Yes.

Xithrius

[python-discord/sir-lancebot] Pull request closed: #806 Love command checks

Xithrius

[sir-lancebot:main] 9 new commits

dcd3bc3 Add February in_month check to love calculator ... - ChrisLovering
cd90422 Require both members used in love calculator ha... - ChrisLovering
c334c20 Sort the members before calculating a love score - ChrisLovering
66d5315 Update love calculator docstring to reflect new... - ChrisLovering
0a2e184 Remove unneeded checks in love calculator command - ChrisLovering

Xithrius

[python-discord/sir-lancebot] branch deleted: love\-command\-checks

[night lily]

Sir Lancebot

Connected!

[odd spire]

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1134077334 succeeded.

Actor

Xithrius

Workflow Run

Build #397

Commit

f58e898

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on issue #784: Wrong title in love calc when 0% love

While this truly is a bug, I think it is quite fun and it is a known hidden fact of our bot, I would actually vote to not fix it.

This be a bug. I approve of this issue being fixed.

Xithrius

[python-discord/sir-lancebot] New comment on pull request #785: Correct an off\-by\-one bug due to bisect\.bisect\(\)

I've approved.

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #785 Correct an off\-by\-one bug due to bisect\.bisect\(\)

Xithrius

[python-discord/sir-lancebot] New comment on pull request #786: Duckduckduckgoose

@camcaswell will you be fixing up this PR?

[regal arch]

lxnn

[python-discord/sir-lancebot] Pull request review submitted: #805 800 \- Real Python search command

Nice work!

I tried it out in a test server and it seems to be working very well. The only thing I wasn't certain about is the meaning of the message in the final except clause:

"Your search was not Ok, please try something else."
Under what circumstances would the user see this message?

[oak estuary]

Doc item doc_item.symbol_id='resources' present in loaded documentation inventories not found on site, inventories may need to be refreshed.

[regal arch]

NIRDERIi

[python-discord/sir-lancebot] New comment on pull request #805: 800 \- Real Python search command

The best thing I can think about is if something might be wrong with the URL that can raise HTTPException, but I don't think that would happen. I would consider if the bot didn't have perms, but he didn't put try-except on any other send or something like that. Other than that, should be fine.

[regal arch]

ChrisLovering

[python-discord/bot] Pull request review submitted: #1752 Help channels: fix initialisation of available channels set

Yup LGTM!

[regal arch]

TizzySaurus

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

So are you suggesting using UserMentionOrId (not Snowflake), but changing the convert method to return a discord.Object when the call to UserConverter fails?

[odd spire]

[python-discord/site] Checks Failed on PR: #563 Implement front-end spec for Smarter Resources

GitHub Actions run 1134870305 failed.

PR Author

doublevcodes

Workflow Run

Lint & Test #413

Source Branch

doublevcodes:doublevcodes/sma...

[regal arch]

Xithrius

[python-discord/bot] New comment on pull request #1285: Formats Per\-Command Help Output

@HassanAbouelela we should probably open up another PR to fix the necessary docstrings.

[odd spire]

[python-discord/bot] Checks Failed on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 1135029623 failed.

PR Author

Shivansh-007

Workflow Run

Lint & Test #1532

Source Branch

Shivansh-007:feature/enhance...

[python-discord/bot] Checks Successful on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 1135035131 succeeded.

PR Author

Shivansh-007

Workflow Run

Lint & Test #1533

Source Branch

Shivansh-007:feature/enhance...

[regal arch]

Shivansh-007

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

I don't see how it would simplify the process, we would either need to check if extract_message_links returns an empty list or None?

[regal arch]

wookie184

[python-discord/bot] New review comment on pull request #1752: Help channels: fix initialisation of available channels set

I think you could use _channel.get_category_channels here instead
https://github.com/python-discord/bot/blob/4c9405b21341880d9bdc1f0dde02219de9ade005/bot/exts/help_channels/_channel.py#L32-L39

[regal arch]

dawnofmidnight

[python-discord/sir-lancebot] Pull request review submitted: #792 More topics to start Python\-related conversations with\.

[regal arch]

D0rs4n

[python-discord/bot] Pull request opened: #1753 Delete Webhooks when one is accidentally posted\.

Closes #1747

From now on, webhooks that were posted in the chat will be also
deleted from Discord in order to eliminate the risk.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1753 Delete Webhooks when one is accidentally posted.

GitHub Actions run 1135382657 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1534

Source Branch

D0rs4n:pr/deletewebhook

[regal arch]

Bluenix2

[python-discord/bot] Pull request review submitted: #1753 Delete Webhooks when one is accidentally posted\.

Bluenix2

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

This says

Bluenix, looks like you posted a Discord webhook URL. Therefore, your message has been removed, alongside with your webhook you can re-create it if you wish to. If you believe this was a mistake, please let us know.

You should add a period between "your webhook" and "you can re-create it if you wish to".

Bluenix2

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

            f"{format_user(msg.author)} posted a Discord webhook URL to {msg.channel.mention}. {delete_state} "

You don't have a space in delete_state so we need to add it here

[regal arch]

wookie184

[python-discord/bot] New comment on pull request #1487: Goodbye, \#talent\-pool

@Xithrius do you have a status on when you might be able to respond to Mark's comments/finish this up? It seems pretty close and would be nice to get it merged fairly soon. Thanks!

[regal arch]

Numerlor

[python-discord/bot] Pull request review submitted: #1753 Delete Webhooks when one is accidentally posted\.

Numerlor

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

The connection doesn't need to be held open to send the discord message, we can also get rid of the conditional

            async with self.bot.http_session.delete(msg.content) as resp:
                # The Discord API Returns a 204 NO CONTENT repsonse on success.
                deleted_successfully = resp.status == 204
            await self.delete_and_respond(msg, matches[1] + "xxx", deleted_successfully)

Numerlor

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

Making webhook_deleted a kwarg only param would make the interface clearer from the caller

Numerlor

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

                # The Discord API Returns a 204 NO CONTENT response on success.

[regal arch]

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #760: Adds \`\.reverse\`

Merged reverse into one command, resolved

swfarnsworth

[python-discord/site] New review comment on pull request #563: Implement front\-end spec for Smarter Resources

This dictionary should be a global so that it's not being re-created each time. Try naming it _ICONS.

[regal arch]

Numerlor

[python-discord/bot] New review comment on pull request #1721: Refactor time utilities

On one hand I agree that it doesn't hurt, but then I'm also not sure how many readers will benefit from knowing that it's the same interface as arrow.get which they probably don't know from memory whole, if at all

Bluenix2

[python-discord/site] New review comment on pull request #563: Implement front\-end spec for Smarter Resources

Pretty sure Python handles this and uses LOAD CONST, that said using an all-caps variable at the top of the file is cleaner.

D0rs4n

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

Valid point. Very inefficient, it is.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1753 Delete Webhooks when one is accidentally posted.

GitHub Actions run 1136173976 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1535

Source Branch

D0rs4n:pr/deletewebhook

[regal arch]

swfarnsworth

[python-discord/site] New review comment on pull request #563: Implement front\-end spec for Smarter Resources

Also I wish we had function composition so that this function could just be get_category_icon = register.filter @ 'fa {icon_name}'.format @ icons.get, but no :disappointed:

MarkKoz

[python-discord/bot] New review comment on pull request #1721: Refactor time utilities

At least they'd have enough information to look up the arrow docs.

[regal arch]

wookie184

[bot:wookie184\-patch\-1] 1 new commit

44adebc Remove the admins mention from the modmail tag - wookie184

wookie184

[python-discord/bot] New branch created: wookie184\-patch\-1

wookie184

[python-discord/bot] Pull request opened: #1754 Remove the admins mention from the modmail tag

Removing as it isn't particularly relevant to the tag and may make users think they should ping admins for moderation related concerns.

vcokltfre

[python-discord/bot] Pull request review submitted: #1754 Remove the admins mention from the modmail tag

[odd spire]

[python-discord/bot] Checks Successful on PR: #1754 Remove the admins mention from the modmail tag

GitHub Actions run 1136278449 succeeded.

PR Author

wookie184

Workflow Run

Lint & Test #1536

Source Branch

wookie184-patch-1

[regal arch]

mbaruh

[python-discord/bot] Pull request closed: #1754 Remove the admins mention from the modmail tag

mbaruh

[bot:main] 2 new commits

44adebc Remove the admins mention from the modmail tag - wookie184
7ebcdb7 Merge pull request #1754 from python-discord/wo... - mbaruh

mbaruh

[python-discord/bot] branch deleted: wookie184\-patch\-1

MarkKoz

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

Either that or keeping them separate like Union[UserMentionOrId, Snowflake, str] so that UserMentionOrId remains versatile. I think the latter would be better. What do you think?

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1136292426 succeeded.

Actor

mbaruh

Workflow Run

Deploy #398

Commit

7ebcdb7

[regal arch]

TizzySaurus

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

Yeah, I think keeping it versatile is better actually. I'll do that :+1:

ChrisLovering

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

Won't msg.content be the full message here? I think you should be using matches[1], as that's the actual webhook url.

ChrisLovering

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

    "message has been removed, and your webhook has been deleted."

ChrisLovering

[python-discord/bot] Pull request review submitted: #1753 Delete Webhooks when one is accidentally posted\.

Could you add a screenshot of the alert message to this Pr so we can see what it looks like in Discord?

ChrisLovering

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

Ah, it seems the regex doesn't match the webhook secret, just the url and ID. This will need to be changed

D0rs4n

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

Yes, how foolish of me. But I believe the full url is matches[0]

[regal arch]

camcaswell

[python-discord/sir-lancebot] New comment on pull request #786: Duckduckduckgoose

@camcaswell will you be fixing up this PR in the near future?

Yes, sorry I've been busy lately but I'll get to it

[odd spire]

[python-discord/bot] Checks Successful on PR: #1753 Delete Webhooks when one is accidentally posted.

GitHub Actions run 1136517485 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1538

Source Branch

D0rs4n:pr/deletewebhook

[regal arch]

D0rs4n

[python-discord/bot] New comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

Also, I'm not sure if that's what you asked for, but here's the alert message the user gets.

[regal arch]

HassanAbouelela

[python-discord/bot] New comment on pull request #1285: Formats Per\-Command Help Output

Just to clarify, which solution is this?

There are two similar solutions. The first one is the change added by this PR + changing the doc strings of time units.

The other is to change every single docstring that takes more than one line.

ChrisLovering

[python-discord/bot] Pull request review submitted: #1753 Delete Webhooks when one is accidentally posted\.

ChrisLovering

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

After testing, this still doesn't work. It seems the regex does not capture the https:// part of the webhook, this will need to be added back in before you can make a request to delete it.

D0rs4n

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

That's strange, I've tested out the regEx and by using matches[0] it worked just fine, it included the whole url.

D0rs4n

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

Turns out the regex did not match the https:// part in case of canary urls. The regEx pattern has to be changed.

Xithrius

[sir-lancebot:more\-py\-topics] 15 new commits

f72bb8a Pinned aioredis to 1.3 and relocked dependencies - wookie184
8e653f4 Replace fuzzywuzzy with rapidfuzz - wookie184
fac37b2 Modify code to comply with new linter error N818 - wookie184
78f1cd5 Merge branch 'main' into remove-gpl-deps - Akarys42
67caea1 Merge pull request #799 from python-discord/rem... - Akarys42

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #792 More topics to start Python-related conversations with.

GitHub Actions run 1136826333 succeeded.

PR Author

Xithrius

Workflow Run

Lint #1220

Source Branch

more-py-topics

[regal arch]

Xithrius

[python-discord/bot] New comment on pull request #1487: Goodbye, \#talent\-pool

@Xithrius do you have a status on when you might be able to respond to Mark's comments/finish this up? It seems pretty close and would be nice to get it merged fairly soon. Thanks!

I'm still in the process of slowly resolving all of this. At the same time, I will also be needing to resolve the current file conflict. I also hope to merge this soon.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1753 Delete Webhooks when one is accidentally posted.

GitHub Actions run 1136825953 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1539

Source Branch

D0rs4n:pr/deletewebhook

[regal arch]

Xithrius

[python-discord/bot] New comment on pull request #1285: Formats Per\-Command Help Output

I think we're going for the 1st option. @ChrisLovering, opinions?

Xithrius

[python-discord/sir-lancebot] New comment on pull request #786: Duckduckduckgoose

Thank you for the update.

Xithrius

[sir-lancebot:more\-py\-topics] 1 new commit

81ad623 Added another topic. - Xithrius

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #792 More topics to start Python-related conversations with.

GitHub Actions run 1136846615 succeeded.

PR Author

Xithrius

Workflow Run

Lint #1221

Source Branch

more-py-topics

[regal arch]

Xithrius

[sir-lancebot] Branch more\-py\-topics was force-pushed to `129db3c`

Compare changes

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #792 More topics to start Python-related conversations with.

GitHub Actions run 1136851806 succeeded.

PR Author

Xithrius

Workflow Run

Lint #1222

Source Branch

more-py-topics

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on issue #775: add topic to py\_topics

Added.

Xithrius

[python-discord/sir-lancebot] Issue closed: #775 add topic to py\_topics

Xithrius

[sir-lancebot] Branch more\-py\-topics was force-pushed to `c18676e`

Compare changes

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #792 More topics to start Python-related conversations with.

GitHub Actions run 1136859711 succeeded.

PR Author

Xithrius

Workflow Run

Lint #1223

Source Branch

more-py-topics

[regal arch]

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #792 More topics to start Python\-related conversations with\.

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #792 More topics to start Python\-related conversations with\.

ChrisLovering

[sir-lancebot:main] 2 new commits

c18676e Added more topics to py_topics.yaml. - blankRiot96
d7a688c Merge pull request #792 from python-discord/mor... - ChrisLovering

ChrisLovering

[python-discord/sir-lancebot] branch deleted: more\-py\-topics

[night lily]

Sir Lancebot

Connected!

[odd spire]

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1136875050 succeeded.

Actor

ChrisLovering

Workflow Run

Build #401

Commit

d7a688c

[regal arch]

ChrisLovering

[python-discord/bot] New comment on pull request #1285: Formats Per\-Command Help Output

Yea, the former. We should have a mechanism to force a line break when needed though, for when we need to do things like the time units in future.

ChrisLovering

[python-discord/bot] Pull request review submitted: #1753 Delete Webhooks when one is accidentally posted\.

Tested locally, works well 👍

ChrisLovering

[python-discord/bot] Pull request review submitted: #1716 Don't send code snippets if the original message was deleted

ChrisLovering

[bot:bug/info/bot\-13b/code\-snippet\-msg\-404] 68 new commits

fb9cbe4 Create events ext, prepare jams cog for file split - mbaruh
6986600 Move jam channels creation to separate file - mbaruh
d4271b0 More code jam functionality - mbaruh
bc390bc Added command to remove from team - mbaruh
fdc6f23 Fix end command docstring - mbaruh

[odd spire]

[python-discord/bot] Checks Successful on PR: #1716 Don't send code snippets if the original message was deleted

GitHub Actions run 1136921505 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1540

Source Branch

bug/info/bot-13b/code-snippet-msg...

[python-discord/kubernetes] Checks Successful on PR: #76 Alert on soon-ish certificate expiration.

GitHub Actions run 1136946158 succeeded.

PR Author

jchristgit

Workflow Run

Lint Kubernetes manifests #143

Source Branch

certificate-expir...

[regal arch]

Bluenix2

[python-discord/bot] Pull request review submitted: #1753 Delete Webhooks when one is accidentally posted\.

Bluenix2

[python-discord/bot] New review comment on pull request #1753: Delete Webhooks when one is accidentally posted\.

I don't understand, I saw the screenshot of this message which looked like there was a space after this period.

    "message has been removed, and your webhook has been deleted. "

[odd spire]

[python-discord/bot] Checks Successful on PR: #1753 Delete Webhooks when one is accidentally posted.

GitHub Actions run 1136979163 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1541

Source Branch

D0rs4n:pr/deletewebhook

[regal arch]

ChrisLovering

[python-discord/bot] Pull request closed: #1716 Don't send code snippets if the original message was deleted

ChrisLovering

[python-discord/bot] branch deleted: bug/info/bot\-13b/code\-snippet\-msg\-404

ChrisLovering

[bot:main] 6 new commits

3504731 CodeSnippets: refactor on_message - MarkKoz
cfbeabb CodeSnippets: move init to the top of the c... - MarkKoz
4753264 CodeSnippets: refactor snippet parsing into a s... - MarkKoz
900bf69 CodeSnippets: don't send snippets if the origin... - MarkKoz
a6ac449 Merge branch 'main' into bug/info/bot-13b/code-... - ChrisLovering

[odd spire]

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1137020672 succeeded.

Actor

jb3

Workflow Run

Lint Kubernetes manifests #144

Commit

9a4f5a6

[regal arch]

Bluenix2

[python-discord/bot] New review comment on pull request #1663: Add tag groups and in file metadata

This is actually a bit sad when you think about it haha

Discord.py uses an internal array to store role IDs attached to a member, .roles is a property that gets all of the roles from cache by their ID. We then use a set comprehension to convert it to a set of.. role IDs.

Bluenix2

[python-discord/bot] New review comment on pull request #1663: Add tag groups and in file metadata

    current = 0
    for _target in _targets:
        index = 0
        while index < len(_target) and _search[current] == _target[index]:
            current += 1
            index += 1

Bluenix2

[python-discord/bot] Pull request review submitted: #1663 Add tag groups and in file metadata

Looks good otherwise

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1137027865 succeeded.

Actor

ChrisLovering

Workflow Run

Deploy #399

Commit

4ae4f83

[regal arch]

Bluenix2

[python-discord/bot] Pull request review submitted: #1753 Delete Webhooks when one is accidentally posted\.

This looks good now

[odd spire]

[python-discord/site] Checks Failed on PR: #563 Implement front-end spec for Smarter Resources

GitHub Actions run 1137034044 failed.

PR Author

doublevcodes

Workflow Run

Lint & Test #414

Source Branch

doublevcodes:doublevcodes/sma...

[regal arch]

ChrisLovering

[python-discord/bot] Issue closed: #1747 Delete detected webhooks

ChrisLovering

[python-discord/bot] Pull request closed: #1753 Delete Webhooks when one is accidentally posted\.

ChrisLovering

[bot:main] 7 new commits

5f0d7f7 Enhance security in the Webhook remover. - D0rs4n
d388d39 Improve code consistency in webhook_remover - D0rs4n
e8b2235 Fix up, and improve code consistency in webhook... - D0rs4n
7d73215 Patch the regEx pattern in webhook_remover to m... - D0rs4n
60b1d16 Improve output message consistency in webhook_r... - D0rs4n

MarkKoz

[bot:bug/help/1715/avail\-set\-init] 1 new commit

052cead HelpChannels: use utility method to get availab... - MarkKoz

MarkKoz

[python-discord/bot] New review comment on pull request #1752: Help channels: fix initialisation of available channels set

Yes 052cead

[odd spire]

[python-discord/bot] Checks Successful on PR: #1753 Delete Webhooks when one is accidentally posted.

GitHub Actions run 1137040020 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1543

Source Branch

D0rs4n:pr/deletewebhook

[python-discord/bot] Checks Successful on PR: #1752 Help channels: fix initialisation of available channels set

GitHub Actions run 1137043732 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1545

Source Branch

bug/help/1715/avail-set-init

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1137049591 succeeded.

Actor

ChrisLovering

Workflow Run

Deploy #400

Commit

a2e84db

[regal arch]

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #760: Adds \`\.reverse\`

The changes look good now :) One small comment I have is that we can avoid this huge if statement here by doing the unhappy path first IE

if text:
    await ctx.send(f"> {text[::-1]}", allowed_mentions=discord.AllowedMentions.none())
    return
``` and then doing the rest of the code. This will avoid the large nested block

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #760: Adds \`\.reverse\`

alright, gimme a few seconds

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #760 Adds \`\.reverse\`

Nice, looks good!

wookie184

[python-discord/bot] Pull request review submitted: #1752 Help channels: fix initialisation of available channels set

Thanks

[odd spire]

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1137176073 succeeded.

Actor

jb3

Workflow Run

Lint Kubernetes manifests #145

Commit

beeafea

[regal arch]

HassanAbouelela

[python-discord/bot] New comment on pull request #1285: Formats Per\-Command Help Output

I had actually written a small patch to allow for forcefully breaking lines (more specifically, I used the escape sequence used for time units -- \u2003 -- as a non-escapable break).

The implementation had the added benefit of not requiring any docstring changes. At this point, it's gone, and this PR is very outaded, but it should be pretty easy to take the work already done here, add on the patch I just described in a new PR.

[regal arch]

lxnn

[python-discord/sir-lancebot] Pull request review submitted: #805 800 \- Real Python search command

Changing my review to 'approve' to speed things along. Although I'm still interested in the answer to the above question.

MarkKoz

[bot:bug/help/1715/avail\-set\-init] 16 new commits

3504731 CodeSnippets: refactor on_message - MarkKoz
cfbeabb CodeSnippets: move init to the top of the c... - MarkKoz
4753264 CodeSnippets: refactor snippet parsing into a s... - MarkKoz
900bf69 CodeSnippets: don't send snippets if the origin... - MarkKoz
5f0d7f7 Enhance security in the Webhook remover. - D0rs4n

MarkKoz

[python-discord/bot] Issue closed: #1715 Set may be missing some available help channels after initialisation

MarkKoz

[python-discord/bot] Pull request closed: #1752 Help channels: fix initialisation of available channels set

MarkKoz

[python-discord/bot] branch deleted: bug/help/1715/avail\-set\-init

MarkKoz

[bot:main] 5 new commits

8731b19 HelpChannels: fix incomplete init of available ... - MarkKoz
f6a1f00 HelpChannels: simplify formatting of category n... - MarkKoz
052cead HelpChannels: use utility method to get availab... - MarkKoz
cb99afe Merge branch 'main' into bug/help/1715/avail-se... - MarkKoz
5a7256f Merge #1752 - help channels: fix initialisation... - MarkKoz

[odd spire]

[python-discord/bot] Checks Successful on PR: #1752 Help channels: fix initialisation of available channels set

GitHub Actions run 1138029033 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1546

Source Branch

bug/help/1715/avail-set-init

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1138040173 succeeded.

Actor

MarkKoz

Workflow Run

Deploy #401

Commit

5a7256f

[odd spire]

[python-discord/bot] Checks Successful on PR: #1749 Update reminders to reply instead of using a jump url to the origin message

GitHub Actions run 1138788665 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1548

Source Branch

D0rs4n:pr/replinders

[regal arch]

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #760 Adds \`\.reverse\`

Works well

[regal arch]

wookie184

[python-discord/sir-lancebot] New comment on issue #715: ValueError: empty range for randrange\(\) \(10, 9, \-1\)

Have managed to reproduce this locally, it seems discord will let you upload profile pictures as small as 1x1px, and even when accessing them with e.g. ?size=1024 discord will not upscale them. The fix for this is pretty simple, just using PIL to resize the image before applying the effect. This will also make images display more consistently in the embeds.

I can implement this

[regal arch]

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #715: ValueError: empty range for randrange\(\) \(10, 9, \-1\)

Sounds good to me, probably want to make the upscale a helper function, rather than specific to spookify effect, just in case we need it elsewhere too.

Preferably the upscaling is done in the executor too, rather than blocking the main thread 👍

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #715: ValueError: empty range for randrange\(\) \(10, 9, \-1\)

Possibly even make the upscaling default behaviour, if a user's avatar is found to be smaller than 1024x1024 when applying any effect

[odd spire]

[python-discord/site] Checks Failed on PR: #563 Implement front-end spec for Smarter Resources

GitHub Actions run 1139060216 failed.

PR Author

doublevcodes

Workflow Run

Lint & Test #415

Source Branch

doublevcodes:doublevcodes/sma...

[python-discord/site] Checks Failed on PR: #563 Implement front-end spec for Smarter Resources

GitHub Actions run 1139082702 failed.

PR Author

doublevcodes

Workflow Run

Lint & Test #416

Source Branch

doublevcodes:doublevcodes/sma...

[regal arch]

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #785 Correct an off\-by\-one bug due to bisect\.bisect\(\)

While this works fine, I don't think the current comment is entirely clear. It says that -1 is needed, but it isn't very clear why, and if we aren't using it then surely it isn't needed.

From some testing it seems that -1 was there to prevent values triggering on the number before. e.g. without -1 the message for 100 in the JSON also appears on 99. I think this behaviour isn't a problem, but the current comment should be changed to explain this behaviour, or at least remove the...

[regal arch]

RohanJnr

[python-discord/sir-lancebot] Pull request review submitted: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

            raw_data = await resp.json()
      
            if not raw_data.get("query"):

An empty line to keep things spaced.

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

I would just call it APIError

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

Passing an empty list here instead of having the else block here would be better as you are already checking if contents is populated in the wikipedia_search_command.

            return lines

The else block can be used in the wikipedia_search_command. This will require you to define the lines variable (line 64) outside the if-else scope.
And also don't forget to change the function return annotation to only List[str] instead of Optional[List[str]].

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #618 Wikiguess Game

Nice stuff, I'm approving this as it does seem to work, although there are two comments I would like to make.

Firstly, while the randomness of the articles chosen is nice, there are a lot of wikipedia articles, to the extent that usually picking a random wikipedia page will give you some obscure topic you have no idea about. For example:

[redacted] is a village in Nowkand Kola Rural District, in the Central District of Qaem Shahr County, Mazandaran Province, Iran. At the 2006 cens...

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

GitHub Actions run 1139671100 succeeded.

PR Author

D0rs4n

Workflow Run

Lint #1227

Source Branch

D0rs4n:pr/wikipediaissue

[regal arch]

RohanJnr

[python-discord/sir-lancebot] New comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

We should handle APIErrors and ResponseCode errors (if the response code is not 200). APIError could mean there is an error with the feed of the response which this PR is solving. We might have unexpected errors where the response code is not 200, do we have any instances of this situation of non 200 responses?

RohanJnr

[python-discord/sir-lancebot] Pull request review submitted: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

A return statement is not required.

D0rs4n

[python-discord/sir-lancebot] New comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

We should handle APIErrors and ResponseCode errors (if the response code is not 200). APIError could mean there is an error with the feed of the response which this PR is solving. We might have unexpected errors where the response code is not 200, do we have any instances of this situation of non 200 responses?

This issue can be delt separately from the issues being solved by this PR but I would like to know what others think about this.

The Wikipedia API will always send back a r...

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

GitHub Actions run 1139816673 succeeded.

PR Author

D0rs4n

Workflow Run

Lint #1228

Source Branch

D0rs4n:pr/wikipediaissue

[regal arch]

PythonTryHard

[python-discord/sir-lancebot] New comment on pull request #785: Correct an off\-by\-one bug due to bisect\.bisect\(\)

I'll try get back on my dev environment, though probably not until 2021-08-25 due to irl complications. Reading back, I kinda with you, comment isn't very clear

[regal arch]

Kronifer

[python-discord/sir-lancebot] New comment on pull request #699: Cowsay

Alright, resolved that

[odd spire]

[python-discord/sir-lancebot] Checks Failed on PR: #699 Cowsay

GitHub Actions run 1139898913 failed.

PR Author

Kronifer

Workflow Run

Lint #1229

Source Branch

Kronifer:cowsay

[regal arch]

Kronifer

[python-discord/sir-lancebot] New comment on issue #789: Pokemon Game

I dont think this fits the theme of the server

[regal arch]

wookie184

[python-discord/bot] New comment on issue #1037: raw command doesn't trim lines that are too long for the paginator

Sending a hastebin link sounds like a good idea.

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on pull request #699: Cowsay

There seems to be some linting errors as well. Run poetry run task lint to see what they are on your end in the repository, and run poetry run task precommit to make sure everything is correct before anything is committed.

brad90four

[python-discord/sir-lancebot] New comment on pull request #805: 800 \- Real Python search command

Changing my review to 'approve' to speed things along. Although I'm still interested in the answer to the above question.

Since I do check if the API call is OK with the checking if 200 at the front, this is more if there is some other error between a good response from Real Python and the bot sending the embeds to the user in Discord. It is a kind of catchall, and could probably function just as well without it.

I'm currently away from my normal set up so I wouldn't be able to test ...

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #699 Cowsay

GitHub Actions run 1140618935 succeeded.

PR Author

Kronifer

Workflow Run

Lint #1230

Source Branch

Kronifer:cowsay

[regal arch]

doublevcodes

[python-discord/king-arthur] Pull request opened: #5 Make cloudflare purge command use interactions

This PR enabled you to:

1. Purge the cache of more than 1 zone
2. Use amazing drop downs and buttons

[king-arthur] Build & Push skipped on main

[king-arthur] Lint failure on main

[king-arthur] Deploy skipped on main

[king-arthur] GitHub Actions checks failure on main

[king-arthur] Build & Push skipped on main

[king-arthur] Lint failure on main

[king-arthur] Deploy skipped on main

[king-arthur] GitHub Actions checks failure on main

[king-arthur] Build & Push skipped on main

[king-arthur] Lint failure on main

[king-arthur] Deploy skipped on main

[king-arthur] GitHub Actions checks failure on main

[king-arthur] Build & Push skipped on main

[king-arthur] Lint success on main

[king-arthur] Deploy skipped on main

[king-arthur] GitHub Actions checks success on main

doublevcodes

[python-discord/king-arthur] Pull request opened: #6 Create status embed workflow

Currently the GitHub embed still looks ugly. This makes it look pretty.

P.S. merge #5 before this to avoid merge conflicts

[king-arthur] Build & Push skipped on status\-embed

[king-arthur] Lint success on status\-embed

[king-arthur] Deploy skipped on status\-embed

[king-arthur] GitHub Actions checks success on status\-embed

[regal arch]

jb3

[python-discord/king-arthur] Pull request review submitted: #5 Make cloudflare purge command use interactions

jb3

[python-discord/king-arthur] Pull request closed: #5 Make cloudflare purge command use interactions

jb3

[king-arthur:main] 6 new commits

3fb5287 feat: Make purge zones command use dropdown to ... - doublevcodes
2c0224c feat: Allow for selection of multiple zones - doublevcodes
2561b4b lint: Remove lint - doublevcodes
8854643 lint: Remove extraneous lint - doublevcodes
304df40 fix: Make string f-string - doublevcodes

[king-arthur] Build & Push skipped on status\-embed

[king-arthur] Build & Push success on main

[king-arthur] Lint success on main

[king-arthur] Lint success on status\-embed

[king-arthur] Deploy skipped on status\-embed

[king-arthur] GitHub Actions checks success on status\-embed

[king-arthur] Deploy success on main

[king-arthur] GitHub Actions checks success on main

jb3

[python-discord/king-arthur] Pull request review submitted: #6 Create status embed workflow

jb3

[python-discord/king-arthur] Pull request closed: #6 Create status embed workflow

jb3

[king-arthur:main] 3 new commits

f662576 actions: Create status embed action - doublevcodes
7c0bdca Merge branch 'main' into status-embed - jb3
daee257 Merge pull request #6 from doublevcodes/status-... - jb3

[king-arthur] Lint success on main

[king-arthur] Build & Push success on main

[king-arthur] Deploy success on main

[king-arthur] GitHub Actions checks success on main

[regal arch]

jb3

[king-arthur:main] 3 new commits

b4615af Move emote in Cloudflare purge - jb3
6f071b6 Update Cloudflare cache to correctly respond & ... - jb3
c7547d5 Merge branch 'main' of github.com:python-discor... - jb3

[king-arthur] Lint success on main

[king-arthur] Build & Push success on main

[king-arthur] Deploy success on main

[king-arthur] GitHub Actions checks success on main

[regal arch]

VikranthMaster

[python-discord/sir-lancebot] New comment on issue #789: Pokemon Game

I dont think this fits the theme of the server
its just a extra game that's all for sir Lanceot

JacobMonck

[python-discord/sir-lancebot] New comment on issue #789: Pokemon Game

Yeah, this doesn't really fit our server too well. It's a great idea but I don't think it suits our server.

[regal arch]

VikranthMaster

[python-discord/sir-lancebot] New comment on issue #789: Pokemon Game

Yeah, this doesn't really fit our server too well. It's a great idea but I don't think it suits our server.

at least we can try right?

bsoyka

[python-discord/sir-lancebot] New comment on issue #789: Pokemon Game

at least we can try right?

There's really no point in trying something that wouldn't fit or be used in our server. You're always welcome to make your own bot for your own server, but if multiple staff have said it wouldn't fit here, there's really no reason to make this for Python Discord.

[regal arch]

VikranthMaster

[python-discord/sir-lancebot] New comment on issue #789: Pokemon Game

at least we can try right?

There's really no point in trying something that wouldn't fit or be used in our server. You're always welcome to make your own bot for your own server, but if multiple staff have said it wouldn't fit here, there's really no reason to make this for Python Discord.

alright

VikranthMaster

[python-discord/sir-lancebot] Issue closed: #789 Pokemon Game

[oak estuary]

Doc item doc_item.symbol_id='environment-variables' present in loaded documentation inventories not found on site, inventories may need to be refreshed.

[regal arch]

lxnn

[python-discord/sir-lancebot] New comment on pull request #805: 800 \- Real Python search command

Don't feel like you need to change it. I was just confused about what it was for.

[regal arch]

jb3

[king-arthur:main] 1 new commit

0eb07e4 Disable select once complete - jb3

[king-arthur] Lint on main

There are 3 failures, 0 warnings, and 0 notices.

[king-arthur] Build & Push success on main

[king-arthur] Deploy skipped on main

[king-arthur] GitHub Actions checks failure on main

jb3

[king-arthur:main] 1 new commit

787ea58 Linting compliance - jb3

kinez9999

[python-discord/bot] Issue opened: #1755 Can someone help me setup this bot on Replit

[king-arthur] Lint success on main

[king-arthur] Build & Push success on main

[king-arthur] Deploy success on main

[king-arthur] GitHub Actions checks success on main

jb3

[king-arthur:main] 1 new commit

b83a31c Edit message using direct message instead of he... - jb3

[king-arthur] Lint success on main

[king-arthur] Build & Push success on main

[king-arthur] Deploy success on main

[king-arthur] GitHub Actions checks success on main

[odd spire]

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1143562816 succeeded.

Actor

jb3

Workflow Run

Lint Kubernetes manifests #146

Commit

9992629

[regal arch]

Kronifer

[python-discord/bot] New comment on issue #1755: Can someone help me setup this bot on Replit

This is an innapropriate place to put this, try asking in #dev-contrib on discord

[regal arch]

mbaruh

[bot:mbaruh/anti\-spam] 1 new commit

20aea4f Move max_interval to init - mbaruh

mbaruh

[python-discord/bot] New branch created: mbaruh/anti\-spam

HassanAbouelela

[python-discord/bot] New comment on issue #1755: Can someone help me setup this bot on Replit

Hi! This bot can not be run on repl, as it requires running extra services (site, database, snekbox).

please use dev-contrib for general questions as Kronifer mentioned.

HassanAbouelela

[python-discord/bot] Issue closed: #1755 Can someone help me setup this bot on Replit

[regal arch]

ChrisLovering

[python-discord/sir-lancebot] Issue closed: #749 Add a \.reverse command

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #760 Adds \`\.reverse\`

ChrisLovering

[sir-lancebot:main] 20 new commits

fc8fae8 Update Pipfile - Kronifer
e9dd8d6 Merge branch 'main' of https://github.com/pytho... - Kronifer
c5b4a94 command finished - Kronifer
ef31980 Blocked mentions. - Kronifer
a25b9a2 changes asked for by chris - Kronifer

[night lily]

Sir Lancebot

Connected!

[odd spire]

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1143787470 succeeded.

Actor

ChrisLovering

Workflow Run

Build #404

Commit

e712f39

[regal arch]

ChrisLovering

[thread-bot:Add\-util\-cogs] 4 new commits

63ae672 Move nomination cog to a subfolder - ChrisLovering
b98a8fa Add an error handler cog - ChrisLovering
4b4cacd Add the extensions management cog - ChrisLovering
b4c7017 Add the source cog - ChrisLovering

ChrisLovering

[python-discord/thread-bot] Pull request opened: #2 Add util cogs

This PR adds a bunch of utility cogs to the bot, copy and pasted from the python bot with minor modifications/removing unneeded features

[odd spire]

[python-discord/thread-bot] Checks Successful on PR: #2 Add util cogs

GitHub Actions run 1143973233 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint #25

Source Branch

Add-util-cogs

[regal arch]

ChrisLovering

[thread-bot] Branch Add\-util\-cogs was force-pushed to `b220fc4`

Compare changes

[odd spire]

[python-discord/thread-bot] Checks Successful on PR: #2 Add util cogs

GitHub Actions run 1143980076 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint #26

Source Branch

Add-util-cogs

[regal arch]

ChrisLovering

[bot:Formatting\-issues\-on\-the\-\!server\-command] 2 new commits

fe5c6a5 Fix linebreak formatting on server command - ChrisLovering
480d26d Add comma separators to member counts in !server - ChrisLovering

ChrisLovering

[python-discord/bot] New branch created: Formatting\-issues\-on\-the\-\!server\-command

ChrisLovering

[python-discord/bot] Pull request opened: #1756 Formatting issues on the \!server command

This fixes linebreak formatting on the server command.
The features part of the embed isn't included in some channels, this leads to there not being a linebreak between voice regions and roles in the embed. By changing it to this, rather than dedent, we specify exact where we want the linebreaks to be.

This also adds comma separators to the large member counts in the embed too.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1756 Formatting issues on the !server command

GitHub Actions run 1145151910 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint & Test #1549

Source Branch

Formatting-issues-on-the-!s...

[regal arch]

doublevcodes

[python-discord/bot] Pull request review submitted: #1756 Formatting issues on the \!server command

LGTM

[regal arch]

ventaquil

[python-discord/sir-lancebot] Pull request review submitted: #699 Cowsay

Generally looks fine for me.

Akarys42

[python-discord/bot] Pull request review submitted: #1756 Formatting issues on the \!server command

I approve of this pickiness

[regal arch]

dawnofmidnight

[python-discord/bot] Pull request review submitted: #1756 Formatting issues on the \!server command

Akarys42

[python-discord/bot] Pull request closed: #1756 Formatting issues on the \!server command

Akarys42

[python-discord/bot] branch deleted: Formatting\-issues\-on\-the\-\!server\-command

Akarys42

[bot:main] 3 new commits

fe5c6a5 Fix linebreak formatting on server command - ChrisLovering
480d26d Add comma separators to member counts in !server - ChrisLovering
9e9900d Merge pull request #1756 from python-discord/Fo... - Akarys42

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1146743519 succeeded.

Actor

Akarys42

Workflow Run

Deploy #402

Commit

9e9900d

[regal arch]

mbaruh

[python-discord/bot] Issue opened: #1757 Fallback to site DB on searches by username

We sometimes need to query user data such as the user or infractions embed, when all we have is the username.

Since the site DB stores user ID's and usernames, and already has an endpoint to retrieve stored data based on username, we can use that in case the user is not in the guild and we try to query by their username, to get the user's ID.

This can be implemented by improving the FetchedUser converter to handle cases where the given arguement doesn't represent an integer.

[regal arch]

decorator-factory

[python-discord/sir-lancebot] Pull request review submitted: #618 Wikiguess Game

decorator-factory

[python-discord/sir-lancebot] New review comment on pull request #618: Wikiguess Game

Why was this change made?

decorator-factory

[python-discord/sir-lancebot] New review comment on pull request #618: Wikiguess Game

1. Why is answer not a set/list of allowed answers?
2. I would remove words like "dataclass" and repeating the class name, which are already clear without the docstring.

decorator-factory

[python-discord/sir-lancebot] New review comment on pull request #618: Wikiguess Game

fuzzywuzzy is licensed under GPL, which means we can't include it in this MIT-licensed project. We have changed this dependency to rapidfuzz

decorator-factory

[python-discord/sir-lancebot] New review comment on pull request #618: Wikiguess Game

Oh I see, it's because of https://github.com/python-discord/sir-lancebot/pull/618#issuecomment-857994321
I suppose you could add a comment as to why, or just use null instead of an empty string in the questions.

[regal arch]

minalike

[python-discord/sir-lancebot] Issue opened: #811 Allow bookmark command \`\.bm\` by users in help channels

Description

The proposal is to allow users to run the bookmark .bm command in help channels. Currently the command can be run in some other channels such as off-topic, but it is not allowed in the help channels.

Reasoning

Sometimes I wish to bookmark a particularly helpful response I receive in a help channel without having to go to #bot-commands or #sir-lancebot-playground. It would be very nice for users to be able to run .bm within their current help channel.

Prop...

[regal arch]

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #811: Allow bookmark command \`\.bm\` by users in help channels

Seems like a good idea to me. With the recent changes to the bookmark command, the ability to react to an embed to receive a bookmark, I don't feel like it would be too spammy either.

Whoever looks into implementing this can take a look at the issue command bot.exts.evergreen.issues to see how it does it. Specifically the whitelist_override decorator.

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1148275190 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1232

Source Branch

camcaswell:duckduckduckgoose

[regal arch]

ChrisLovering

[python-discord/bot] Issue opened: #1758 Python community & partners get same access as staff

I'd like to propose that everywhere in the bot (barring talent pool) that uses STAFF_ROLES as a check is changed to also include both python community and partners as passing that check.

These places would be:

• Duck pond (for seeing if a message was from a staff member)
• Help command (Posts output in channel, rather then being relayed to bot-commands)
• Role list (a command to list all roles)
• Role info (a command to get info on a given role)
• User info (Posts output in channel,...

ChrisLovering

[python-discord/bot] Issue opened: #1759 Remove restriction on snowflake command

Now that the output of the snowflake command is paginated, I see no reason to limit non-staff members to only invoke it with 1 snowflake at a time.

I think we should remove the staff role check in this command and allow anyone to run it with as many snowflakes as needed.

camcaswell

[python-discord/sir-lancebot] New review comment on pull request #786: Duckduckduckgoose

So this was the way I was doing it originally, but reacting to every message has the effect of burying the board even faster. My reasoning was that, in terms of gameplay, the player needs to know if their answer was incorrect (so they can correct it, or see where they went wrong), but doesn't immediately need to know whether their answer was accepted or was a repeat.

Currently I have it updating the list of claimed solutions below the board. I found that to be a good compromise in testing,...

camcaswell

[python-discord/sir-lancebot] New review comment on pull request #786: Duckduckduckgoose

My reasoning for this is the same as here: https://github.com/python-discord/sir-lancebot/pull/786#discussion_r692440022

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1148320572 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1233

Source Branch

camcaswell:duckduckduckgoose

[odd spire]

[python-discord/forms-backend] Checks Successful on PR: #103 Bump httpx from 0.17.1 to 0.19.0

GitHub Actions run 1148507167 succeeded.

PR Author

dependabot[bot]

Workflow Run

Forms Backend #356

Source Branch

dependabot/pip/httpx-0.19.0

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1148575135 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1234

Source Branch

camcaswell:duckduckduckgoose

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1148662641 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1235

Source Branch

camcaswell:duckduckduckgoose

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1148665997 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1236

Source Branch

camcaswell:duckduckduckgoose

[regal arch]

swfarnsworth

[python-discord/site] New comment on pull request #517: Smarter resources \- tag filtering

Superceded by #563.

swfarnsworth

[python-discord/site] Pull request closed: #517 Smarter resources \- tag filtering

vhashimotoo

[python-discord/king-arthur] Fork created: vhashimotoo/king-arthur

[regal arch]

jb3

[king-arthur:main] 1 new commit

6a9abbb Add Jishaku - jb3

jb3

[king-arthur:jb3/add\-cronjobs] 1 new commit

4990a59 Add CronJob triggering - jb3

jb3

[python-discord/king-arthur] New branch created: jb3/add\-cronjobs

[king-arthur] Build & Push success on main

[king-arthur] Lint on main

There are 2 failures, 0 warnings, and 0 notices.

[king-arthur] Deploy skipped on main

jb3

[king-arthur:jb3/add\-cronjobs] 1 new commit

df21495 Add missing docstring - jb3

jb3

[python-discord/king-arthur] Pull request opened: #7 Add CronJob triggering

Add command for triggering a cronjob.

Closes #2.

[king-arthur] Build & Push skipped on pull request #7

[king-arthur] Lint on pull request #7

There are 3 failures, 0 warnings, and 0 notices.

[king-arthur] Deploy skipped on pull request #7

jb3

[king-arthur:jb3/add\-cronjobs] 1 new commit

15c5937 Sort imports - jb3

[king-arthur] Build & Push skipped on pull request #7

[king-arthur] Lint success on pull request #7

[king-arthur] Deploy skipped on pull request #7

jb3

[python-discord/king-arthur] Pull request closed: #7 Add CronJob triggering

jb3

[king-arthur:main] 1 new commit

f0ac4bd Add CronJob triggering (#7) - jb3

jb3

[python-discord/king-arthur] branch deleted: jb3/add\-cronjobs

jb3

[python-discord/king-arthur] New comment on issue #3: Command to start a kubernetes job

Added in #7.

jb3

[python-discord/king-arthur] Issue closed: #3 Command to start a kubernetes job

[king-arthur] Build & Push success on main

[king-arthur] Lint success on main

[king-arthur] Deploy success on main

[king-arthur] GitHub Actions checks success on main

jb3

[king-arthur:main] 1 new commit

dfa30ca Update is_owner check - jb3

[king-arthur] Lint success on main

[king-arthur] Build & Push success on main

[king-arthur] Deploy success on main

[king-arthur] GitHub Actions checks success on main

[regal arch]

lxnn

[python-discord/bot] New comment on issue #1697: Remove line numbers from \!eval command output\.

To be honest, I originally gave too much weight to the wrapping. The main issue is the potential confusion caused by the line numbers appearing to be part of the output.

As this tool is mostly used to demonstrate the output of code snippets to learners, I feel that messing with that output is problematic. I'm often saying "ignore the stuff on the left" in help-sessions.

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

@mbaruh The fetch API call already provides a User object with a name attribute filled in. Did you mean "nickname" rather than "username"?

MarkKoz

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

Also, can you provide an example of a situation in which you are only able to identify someone by their user/nickname? If it's coming from bot output, then appending the ID to those outputs or using mentions can be considered.

[regal arch]

Akarys42

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

Also, can you provide an example of a situation in which you are only able to identify someone by their user/nickname? If it's coming from bot output, then appending the ID to those outputs or using mentions can be considered.

Most of the time it is in a ModMail thread, where a user would report a user who left in the meantime for instance.

TizzySaurus

[bot:remove\-redundant\-converters] 1 new commit

3ce1272 Update infraction_search_group typehint to `U... - TizzySaurus

[odd spire]

[python-discord/bot] Checks Successful on PR: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

GitHub Actions run 1149965712 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1551

Source Branch

remove-redundant-converters

[regal arch]

TizzySaurus

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

@MarkKoz A bit of a delay because I was away camping but have just pushed a commit for this :+1:

[regal arch]

Akarys42

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

I agree with all of this, except for #duck-pond, since they don't have access to that channel, I don't think it would make sense to be able to duck their messages.

RohanJnr

[python-discord/site] Pull request opened: #567 User events management

WIP
for https://github.com/issues/assigned

[odd spire]

[python-discord/site] Checks Failed on PR: #567 User events management

GitHub Actions run 1150100114 failed.

PR Author

RohanJnr

Workflow Run

Lint & Test #417

Source Branch

RohanJnr:user_events_management

[regal arch]

gitautas

[python-discord/sir-lancebot] Issue opened: #812 Uwuification unsatisfactory\.

Description and reasoning

The current uwuification algorithm is very simple and frankly unsatisfactory, as there have been many recent advances in the field of uwuification I believe that Sir Lancebot would be greatly improved by the addition of a more feature-rich uwugorithm.

Proposed Implementation

I personally have written a more advanced uwuifier in python that does not depend on any external libraries and am willing to implement it into...

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #812: Uwuification unsatisfactory\.

Hey! Congrats on finishing your project!

I’m not personally in favor of this idea. There are costs to implementing any feature, which most people don’t consider. The most obvious costs are implementation, and review, but the more expensive ones are maintenance.

I really don’t care all that much about this command, and I don’t think it’s worth investing effort into making it some super generator that will replace all generators (TM).

If the current implementation is unsatisfactory, le...

gitautas

[python-discord/sir-lancebot] New comment on issue #812: Uwuification unsatisfactory\.

That's a valid concern, I personally believe that it's a fine feature, also with things like this, once they're up and running, maintenance isn't a real burden since there are no additional dependencies and there would be a single call to a black box which alters a string, not exactly a towering monolith of complexity. I'd personally be more interested in seeing the project grow, not regress in terms of features.

Either way, not my call.

[odd spire]

[python-discord/site] Checks Successful on PR: #508 offtopicnames active attribute and support for PUT and PATCH request

GitHub Actions run 1150316965 succeeded.

PR Author

RohanJnr

Workflow Run

Lint & Test #418

Source Branch

RohanJnr:otn_softdel

[python-discord/bot] Checks Successful on PR: #1568 Add reroll command.

GitHub Actions run 1150323995 succeeded.

PR Author

RohanJnr

Workflow Run

Lint & Test #1552

Source Branch

RohanJnr:off_topic_reroll

[regal arch]

RohanJnr

[python-discord/bot] New comment on issue #1559: Create a delete and reroll command for OT names

If we reroll a channel's name, do we want to reschedule the daily OT update tasks to update the channel name 24h from the reroll, or does the channel name update at the standard time 00:00 UTC?

[regal arch]

JacobMonck

[python-discord/sir-lancebot] New comment on issue #812: Uwuification unsatisfactory\.

I have to agree with Scale on this one, I think it will take way too much time and effort for just one command that only a few people will use. I don't see a problem with the current implementation honestly.

MrHemlock

[python-discord/sir-lancebot] New comment on issue #812: Uwuification unsatisfactory\.

If the current implementation is unsatisfactory, let’s remove it.

I disagree with this. Lancebot is, at its whole, a fun bot. If people want to improve on existing things, more power to them.

I've read the code for the implementation @gitautas wrote up. Since it uses all built-ins and execution/processing time is minimal, there is very little strain on the system itself. @gitautas Has also mentioned (in voice chat) that they are more than willing to make it native to Lancebot in...

[oak estuary]

Python Bot

Connected!

[regal arch]

swfarnsworth

[python-discord/bot] New comment on issue #1559: Create a delete and reroll command for OT names

@RohanJnr I do not think rerolling the name with the command should reschedule the default reroll at midnight.

[regal arch]

swfarnsworth

[python-discord/bot] New comment on issue #1559: Create a delete and reroll command for OT names

@RohanJnr I've added this to the specification:

...and (updated 20 August) marks the removed name as "inactive" in the database. When attempting to add a name to the pool that exists in the pool as inactive, the command should fail with the bot explaining as much. One should be able to circumvent this with forceadd.

[regal arch]

Bluenix2

[python-discord/bot] Pull request review submitted: #1743 fix: update urls in site cog

Looks good, I see nothing wrong.

Bluenix2

[python-discord/bot] New review comment on pull request #1725: added escape markdown in PythonNews

Can we add * here too?

        return re.sub(r"[_*|]", lambda match: "\\" + match[0], content)

Bluenix2

[python-discord/bot] New review comment on pull request #1725: added escape markdown in PythonNews

I understand that it may capture honest markdown such as italic, but I would prefer we escape most markdown. If you look at the mailing list through the archive that the embed links you don't get this formatting so we might as well escape it as well?

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #805 800 \- Real Python search command

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

Wait is the ? necessary here?

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

            if response.status != 200:
                logger.error(f"Status code is not 200, it is {response.status}")
                await ctx.send(embed=ERROR_EMBED)
                return

            data = await response.json()

Is there a benefit structuring it like this?

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

        """Send 5 articles that match the user's search terms."""

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

number_of_results is not used anywhere else?

            lines = []
            if raw_data["query"]["searchinfo"]["totalhits"]:

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

    """Raised when an external API (eg. Wikipedia) returns an error response."""

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

Unnecessary variable in my opinion

[regal arch]

D0rs4n

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

It is passed to the APIErro exception as an argument.
(Since, different APIs return different status codes for errors, so I added a field to the error to indicate those status codes)

Bluenix2

[python-discord/thread-bot] New review comment on pull request #2: Add util cogs

Should this perhaps be a static method?

Bluenix2

[python-discord/thread-bot] Pull request review submitted: #2 Add util cogs

Mostly skimmed through it, looks good

Bluenix2

[python-discord/thread-bot] New review comment on pull request #2: Add util cogs

Isn't commands.ExtensionNotLoaded an error?

Bluenix2

[python-discord/thread-bot] New review comment on pull request #2: Add util cogs

        show_tag = True if tags_cog else False

        if argument.lower() in tags_cog._cache:

Which is just..

        show_tag = bool(tags_cog)

        if argument.lower() in tags_cog._cache:

Which simply can be removed and just use if tags_cog.

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

Right, but you have resp.status right there haha

D0rs4n

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

Alright, valid point. I'll remove it!

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

GitHub Actions run 1151832887 succeeded.

PR Author

D0rs4n

Workflow Run

Lint #1238

Source Branch

D0rs4n:pr/wikipediaissue

[python-discord/kubernetes] Checks Successful on PR: #77 Trigger 4xx / 5xx alerts with service information.

GitHub Actions run 1151834528 succeeded.

PR Author

jchristgit

Workflow Run

Lint Kubernetes manifests #147

Source Branch

nginx-controller-...

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1151861735 succeeded.

Actor

jb3

Workflow Run

Lint Kubernetes manifests #148

Commit

65de20e

[python-discord/sir-lancebot] Checks Successful on PR: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

GitHub Actions run 1151868167 succeeded.

PR Author

D0rs4n

Workflow Run

Lint #1239

Source Branch

D0rs4n:pr/wikipediaissue

[regal arch]

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

                for article in raw_data["query"]["search"]:

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

Ryu1845

[python-discord/bot] New review comment on pull request #1725: added escape markdown in PythonNews

I can add it but I was asked to keep it there #dev-contrib message

Bluenix2

[python-discord/bot] New review comment on pull request #1725: added escape markdown in PythonNews

Ah, right. In that case leave it, I'll mark this as resolved.

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

GitHub Actions run 1151966387 succeeded.

PR Author

D0rs4n

Workflow Run

Lint #1241

Source Branch

D0rs4n:pr/wikipediaissue

[regal arch]

D0rs4n

[python-discord/sir-lancebot] New review comment on pull request #795: Handle Wikipedia API errors and warnings in the Wikipedia Cog

I pushed the changes, although the only thing I changed in the code was a few checks, that was the base code, it made it a bit more consistent, but I understand that those variables were unnecessary.

Bluenix2

[python-discord/bot] Pull request review submitted: #1725 added escape markdown in PythonNews

Looks good now according to what was specified.

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

This looks good now to me, thank you

[regal arch]

jchristgit

[python-discord/olli] Issue opened: #12 Attach matching logs as file

As discussed during my 1 AM Gedankenblitz call.

This will make it easier to debug.

jb3

[python-discord/olli] Pull request closed: #11 Bump addressable from 2\.7\.0 to 2\.8\.0 in /docs

jb3

[olli:main] 2 new commits

abf9eb8 Bump addressable from 2.7.0 to 2.8.0 in /docs - dependabot[bot]
b4816cc Merge pull request #11 from python-discord/depe... - jb3

[regal arch]

Shivansh-007

[python-discord/bot] New comment on pull request #1634: Modpings schedule

Yep it is waiting for a re-review :D

[regal arch]

mbaruh

[bot:mbaruh/anti\-spam] 3 new commits

34d7f7c AntiSpam modified to work with cache - mbaruh
e1e104d AntiSpam deletes from all spammed channels - mbaruh
ad3d197 Identify DeletionContext by members, not channels - mbaruh

[regal arch]

mbaruh

[bot:mbaruh/anti\-spam] 1 new commit

b4ddc0b Fix MessageCache slicing bugs, improve tests - mbaruh

[regal arch]

mbaruh

[python-discord/bot] Pull request opened: #1760 Cross\-channel and deleted messages anti\-spam

Closes #622, closes #665, closes #1522

This PR gives the AntiSpam cog the ability to detect spam of users across channels, and even when their messages (or part of them) were deleted, either by them or automatically because of another filter.

Implementation

The feature was implemented by making the on_message listener search for messages in a cache, rather than the history of the channel the message was sent in.

The MessageCache class

The cache used is an instance of a class...

[odd spire]

[python-discord/bot] Checks Successful on PR: #1760 Cross-channel and deleted messages anti-spam

GitHub Actions run 1153611684 succeeded.

PR Author

mbaruh

Workflow Run

Lint & Test #1553

Source Branch

mbaruh/anti-spam

[regal arch]

Akarys42

[python-discord/bot] Pull request review submitted: #1760 Cross\-channel and deleted messages anti\-spam

The code is very well written, and the feature works perfectly well. Thanks a lot, Zig, favourite zebra ever!

Akarys42

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

        self._messages = [None] * self.maxlen

This annotation can be removed, but I don't really care that much :P

mbaruh

[bot:mbaruh/anti\-spam] 1 new commit

aa2a6b4 Clean up code - mbaruh

[odd spire]

[python-discord/bot] Checks Successful on PR: #1760 Cross-channel and deleted messages anti-spam

GitHub Actions run 1153702844 succeeded.

PR Author

mbaruh

Workflow Run

Lint & Test #1554

Source Branch

mbaruh/anti-spam

[regal arch]

wookie184

[sir-lancebot:avatar\-effects\-fix] 2 new commits

83eb6a6 Resize avatar to 1024x1024 before applying effects - wookie184
df3c882 Refactor mosaic command to use apply_effect - wookie184

wookie184

[python-discord/sir-lancebot] New branch created: avatar\-effects\-fix

wookie184

[python-discord/sir-lancebot] Pull request opened: #813 Avatar effects fix

Relevant Issues

<!-- Link the issue by typing: "Closes #" (Closes #0 to close issue 0 for example). -->
Closes #715

Description

Resized images to 1024x1024 before applying effects. Also made a small refactor

Did you:

• [x] Join the Python Discord Community?
• [x] Read all the comments in this template?
• [x] Ensure there is an issue open, or link relevant discord discussions?
• [x] Read and agree to the [contributing guideline...

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #813 Avatar effects fix

GitHub Actions run 1153802623 succeeded.

PR Author

wookie184

Workflow Run

Lint #1242

Source Branch

avatar-effects-fix

[regal arch]

Akarys42

[python-discord/sir-lancebot] Pull request review submitted: #813 Avatar effects fix

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #813 Avatar effects fix

Akarys42

[python-discord/sir-lancebot] Issue closed: #715 ValueError: empty range for randrange\(\) \(10, 9, \-1\)

Akarys42

[python-discord/sir-lancebot] Pull request closed: #813 Avatar effects fix

Akarys42

[sir-lancebot:main] 3 new commits

83eb6a6 Resize avatar to 1024x1024 before applying effects - wookie184
df3c882 Refactor mosaic command to use apply_effect - wookie184
aa01271 Merge pull request #813 from python-discord/ava... - Akarys42

Akarys42

[python-discord/sir-lancebot] branch deleted: avatar\-effects\-fix

[night lily]

Sir Lancebot

Connected!

[odd spire]

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1153861754 succeeded.

Actor

Akarys42

Workflow Run

Build #405

Commit

aa01271

[odd spire]

[python-discord/kubernetes] Checks Successful on PR: #78 Exclude metabase in p99 alert.

GitHub Actions run 1153966610 succeeded.

PR Author

jchristgit

Workflow Run

Lint Kubernetes manifests #149

Source Branch

nginx-p99-exclude...

[regal arch]

bast0006

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

I think we should comment here that we're relying on how python's modulus treats negative numbers.

-1 % 5 results in +4. This may not be exactly intuitive, and IIRC differs across languages.

bast0006

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

Can you add a triple negative slice here? slice(-1, -10, -2) for example

[odd spire]

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1153993089 succeeded.

Actor

jb3

Workflow Run

Lint Kubernetes manifests #150

Commit

3eb3b6d

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1154009434 succeeded.

Actor

jb3

Workflow Run

Lint Kubernetes manifests #151

Commit

2c9b970

[regal arch]

mbaruh

[bot:mbaruh/anti\-spam] 1 new commit

0531b1e Additional comments and tests for slicing - mbaruh

[odd spire]

[python-discord/bot] Checks Successful on PR: #1760 Cross-channel and deleted messages anti-spam

GitHub Actions run 1154071608 succeeded.

PR Author

mbaruh

Workflow Run

Lint & Test #1555

Source Branch

mbaruh/anti-spam

[regal arch]

mbaruh

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

@MarkKoz the UserConverter relies on the cache, which is usually not enough. Whenever we try look someone up by name#discrim when they've left the guild we get an error.

MarkKoz

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

@MarkKoz the UserConverter relies on the cache, which is usually not enough. Whenever we try look someone up by name#discrim when they've left the guild we get an error.

It doesn't anymore; see #1742

mbaruh

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

I see. If after merging it's resolved I'll close the issue then.

MarkKoz

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

My comment was only on infraction_search_group. search_user did not need to be updated because it only accepts users; there's no risk of ambiguity between names and reasons.

ChrisLovering

[python-discord/thread-bot] New review comment on pull request #2: Add util cogs

2a5960d

ChrisLovering

[python-discord/thread-bot] New review comment on pull request #2: Add util cogs

46bb863

ChrisLovering

[python-discord/thread-bot] New review comment on pull request #2: Add util cogs

46bb863

ChrisLovering

[thread-bot:Add\-util\-cogs] 2 new commits

2a5960d Convert error embed func to a static method - ChrisLovering
3003ac9 Remove unused code related to tags cog - ChrisLovering

ChrisLovering

[python-discord/thread-bot] New review comment on pull request #2: Add util cogs

This was some code I missed when removing unneded things when copying from the bot. ext not loaded is reaised in that command then you try to get the source of a tag and the tags cog isn't loaded.

3003ac9

[odd spire]

[python-discord/thread-bot] Checks Successful on PR: #2 Add util cogs

GitHub Actions run 1154311182 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint #27

Source Branch

Add-util-cogs

[regal arch]

TizzySaurus

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

If I don't change search_user then I can a lint error on L211 since I'm passing a UserMentionOrId to a MemberOrUser parameter. In reality UserMentionOrId gives a discord.User so it isn't actually an issue but the linter doesn't pick up on that.

Am I okay to just ignore this linting error and revert search_user back to the MemberOrUser converter?

ChrisLovering

[thread-bot] Branch Add\-util\-cogs was force-pushed to `3fc786d`

Compare changes

MarkKoz

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

Yes just ignore it.

[odd spire]

[python-discord/thread-bot] Checks Successful on PR: #2 Add util cogs

GitHub Actions run 1154315012 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint #28

Source Branch

Add-util-cogs

[regal arch]

MarkKoz

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

A type checker like mypy isn't used, so it will not fail the CI step. There is a check that a type annotation exists, but it doesn't not enforce type correctness.

TizzySaurus

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

@MarkKoz the UserConverter relies on the cache, which is usually not enough. Whenever we try look someone up by name#discrim when they've left the guild we get an error.

From my understanding this will still be the case. The UserConverter only doesn't rely on cache when the user id is passed. If you want name#discrim support for non-cached users then the UserConverter doesn't give this (again, if I'm correctly understanding everything).

[regal arch]

Bluenix2

[python-discord/thread-bot] Pull request review submitted: #2 Add util cogs

Again, quickly skimmed through it. I see nothing wrong, though I haven't tested it.

TizzySaurus

[bot:remove\-redundant\-converters] 1 new commit

c886987 Revert search_user typehint back to `MemberOr... - TizzySaurus

[odd spire]

[python-discord/bot] Checks Successful on PR: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

GitHub Actions run 1154365326 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1556

Source Branch

remove-redundant-converters

[regal arch]

TizzySaurus

[python-discord/bot] New review comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

It has been committed

ChrisLovering

[python-discord/thread-bot] Pull request closed: #2 Add util cogs

ChrisLovering

[thread-bot:main] 7 new commits

63ae672 Move nomination cog to a subfolder - ChrisLovering
b98a8fa Add an error handler cog - ChrisLovering
d6825ca Add the extensions management cog - ChrisLovering
a4b9113 Add the source cog - ChrisLovering
eb219a0 Convert error embed func to a static method - ChrisLovering

[odd spire]

[python-discord/thread-bot] Workflow Successful

GitHub Actions run 1154370663 succeeded.

Actor

ChrisLovering

Workflow Run

Lint #29

Commit

e41be37

[sullen whale]

Thread Bot

Connected!

[odd spire]

[python-discord/thread-bot] Workflow Successful

GitHub Actions run 1154371060 succeeded.

Actor

ChrisLovering

Workflow Run

Build #12

Commit

e41be37

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

[regal arch]

onerandomusername

[python-discord/king-arthur] Pull request opened: #8 Make doubly sure that isort uses the black profile

Context: #black-formatter message

[king-arthur] Build & Push skipped on patch\-1

[king-arthur] Lint success on patch\-1

[king-arthur] Deploy skipped on patch\-1

[odd spire]

[python-discord/sir-lancebot] Checks Failed on PR: #805 800 - Real Python search command

GitHub Actions run 1154654488 failed.

PR Author

brad90four

Workflow Run

Lint #1244

Source Branch

brad90four:800

[regal arch]

brad90four

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

I'll need to double-check that on my test server before removing, but if it is not necessary I'll take it out.

brad90four

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

None that are obvious to me, went ahead and changed that.

brad90four

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

I'll test it more and see if I can make it fault, if not I'll make a small update.

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #805 800 - Real Python search command

GitHub Actions run 1154669445 succeeded.

PR Author

brad90four

Workflow Run

Lint #1245

Source Branch

brad90four:800

[regal arch]

Xithrius

[python-discord/bot] Pull request review submitted: #1725 added escape markdown in PythonNews

Looks good. We can always update this if we find something new to escape.

Xithrius

[python-discord/bot] Pull request closed: #1725 added escape markdown in PythonNews

Xithrius

[bot:main] 7 new commits

1a95275 added escape markdown in PythonNews - Ryu1845
9345647 fix linting issues - Ryu1845
357c718 Removed comment - Ryu1845
054d5da apply changes for review https://github.com/pyt... - Ryu1845
c5d26a9 change docstring in escape markdown to reflect ... - Ryu1845

[odd spire]

[python-discord/bot] Checks Successful on PR: #1725 added escape markdown in PythonNews

GitHub Actions run 1155301074 succeeded.

PR Author

Ryu1845

Workflow Run

Lint & Test #1557

Source Branch

Ryu1845:escape_md_news

[regal arch]

Xithrius

[python-discord/bot] New comment on pull request #1602: Add the timeit command

@ToxicKidz will you be able to finish this, or should I put it up for grabs?

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1155305653 succeeded.

Actor

Xithrius

Workflow Run

Deploy #403

Commit

49cd8b4

[regal arch]

jb3

[python-discord/bot] New comment on pull request #1446: Enhancing information within the incidents channel\.

ℹ️ Note to merger: This PR should be squashed to avoid a wildly inflated git history.

jb3

[python-discord/king-arthur] Pull request review submitted: #8 Make doubly sure that isort uses the black profile

jb3

[python-discord/king-arthur] Pull request closed: #8 Make doubly sure that isort uses the black profile

jb3

[king-arthur:main] 1 new commit

e5f62a0 Make doubly sure that isort uses the black prof... - onerandomusername

[king-arthur] Lint success on main

[king-arthur] Build & Push success on main

[king-arthur] Deploy success on main

[king-arthur] GitHub Actions checks success on main

Xithrius

[python-discord/bot] New comment on pull request #1446: Enhancing information within the incidents channel\.

I realize that this PR was never approved to go forth with, planning was stated here.

Please wait for approval before going ahead with PRs next time.

Xithrius

[python-discord/bot] New review comment on pull request #1749: Update reminders to reply instead of using a jump url to the origin message

While you're doing this PR, we seem to have a little bug. It's a bit broken at this line (see screenshot below). We should also change the wording to Sorry, your reminder should have arrived at <time here> !

Fix this up and we should be good to go!

[regal arch]

D0rs4n

[python-discord/bot] New review comment on pull request #1749: Update reminders to reply instead of using a jump url to the origin message

Yes, it seems like you can't put discord timestamps into the author field, so it seems like we have to go with the second message :(

Xithrius

[python-discord/bot] New review comment on pull request #1749: Update reminders to reply instead of using a jump url to the origin message

Unfortunate. Please implement, either way.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 1155392968 succeeded.

PR Author

Shivansh-007

Workflow Run

Lint & Test #1559

Source Branch

Shivansh-007:feature/enhance...

[python-discord/bot] Checks Successful on PR: #1749 Update reminders to reply instead of using a jump url to the origin message

GitHub Actions run 1155396270 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1560

Source Branch

D0rs4n:pr/replinders

[python-discord/bot] Checks Successful on PR: #1749 Update reminders to reply instead of using a jump url to the origin message

GitHub Actions run 1155400636 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1561

Source Branch

D0rs4n:pr/replinders

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on pull request #802: Fix type annotations

I will be continuing this PR, as @decorator-factory authorized.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1749 Update reminders to reply instead of using a jump url to the origin message

GitHub Actions run 1155410529 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1562

Source Branch

D0rs4n:pr/replinders

[python-discord/bot] Checks Successful on PR: #1749 Update reminders to reply instead of using a jump url to the origin message

GitHub Actions run 1155425165 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1563

Source Branch

D0rs4n:pr/replinders

[regal arch]

Xithrius

[python-discord/bot] Pull request review submitted: #1749 Update reminders to reply instead of using a jump url to the origin message

Does the do.

Shivansh-007

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

Mentioned in ed30b1e and 94bcc93.

[regal arch]

Akarys42

[python-discord/bot] Pull request review submitted: #1749 Update reminders to reply instead of using a jump url to the origin message

Another one in the book, thanks a lot @D0rs4n!

Akarys42

[python-discord/bot] Issue closed: #1741 Reply to the original message where the reminder was invoked instead of using a jump url

Akarys42

[python-discord/bot] Pull request closed: #1749 Update reminders to reply instead of using a jump url to the origin message

Akarys42

[bot:main] 6 new commits

2ea95a0 Update reminders to reply instead of using a ju... - D0rs4n
d681725 Improve code consitency in remainders - D0rs4n
d697860 Provide jump_url in reminders even when the bot... - D0rs4n
7e8d24f Modify reminder response messages to be in the ... - D0rs4n
69b65a2 Merge branch 'main' into pr/replinders - Akarys42

[odd spire]

[python-discord/bot] Checks Successful on PR: #1749 Update reminders to reply instead of using a jump url to the origin message

GitHub Actions run 1155467374 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1564

Source Branch

D0rs4n:pr/replinders

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1155474499 succeeded.

Actor

Akarys42

Workflow Run

Deploy #404

Commit

771c871

[regal arch]

Xithrius

[python-discord/bot] New branch created: log\-info\-reminder\-replies

Xithrius

[bot:log\-info\-reminder\-replies] 1 new commit

2a00be5 Error to info log level on missing reminder mes... - Xithrius

Xithrius

[python-discord/bot] Pull request opened: #1761 Lowering log level to info for missing reminder replies\.

We don't need sentry to trigger because of this, info is good.

Akarys42

[python-discord/bot] Pull request review submitted: #1761 Lowering log level to info for missing reminder replies\.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1761 Lowering log level to info for missing reminder replies.

GitHub Actions run 1155492479 succeeded.

PR Author

Xithrius

Workflow Run

Lint & Test #1566

Source Branch

log-info-reminder-replies

[regal arch]

ChrisLovering

[python-discord/bot] Pull request review submitted: #1761 Lowering log level to info for missing reminder replies\.

ChrisLovering

[python-discord/bot] Pull request closed: #1761 Lowering log level to info for missing reminder replies\.

ChrisLovering

[python-discord/bot] branch deleted: log\-info\-reminder\-replies

ChrisLovering

[bot:main] 2 new commits

2a00be5 Error to info log level on missing reminder mes... - Xithrius
c63a9f7 Merge pull request #1761 from python-discord/lo... - ChrisLovering

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1155499814 succeeded.

Actor

ChrisLovering

Workflow Run

Deploy #405

Commit

c63a9f7

[regal arch]

jchristgit

[metricity:sync\-channels\-guard\-no\-category] 1 new commit

469665b Prevent error on uncategorized channel. - jchristgit

jchristgit

[python-discord/metricity] New branch created: sync\-channels\-guard\-no\-category

jchristgit

[python-discord/metricity] Pull request opened: #6 Prevent error on uncategorized channel\.

If the channel is not part of a category, channel.category will be
None, and the check would fail with an AttributeError.

[metricity] Lint code success on pull request #6

Akarys42

[python-discord/metricity] Pull request review submitted: #6 Prevent error on uncategorized channel\.

That should work

Akarys42

[python-discord/metricity] Pull request closed: #6 Prevent error on uncategorized channel\.

Akarys42

[metricity:main] 2 new commits

469665b Prevent error on uncategorized channel. - jchristgit
310d10b Merge pull request #6 from python-discord/sync-... - Akarys42

Akarys42

[python-discord/metricity] branch deleted: sync\-channels\-guard\-no\-category

[metricity] Lint code success on main

[metricity] Build & Publish Docker image success on main

jchristgit

[python-discord/metricity] New comment on pull request #6: Prevent error on uncategorized channel\.

Thanks!

Akarys42

[python-discord/metricity] New comment on pull request #6: Prevent error on uncategorized channel\.

No, thank you!

[regal arch]

ChrisLovering

[bot:metabase\-sharing] 4 new commits

9ad34a8 Move metabase error handling to a cog error han... - ChrisLovering
30bcc28 Change metabase config to base url, rather than... - ChrisLovering
ce80b92 Add alias for metabase export - ChrisLovering
3f02853 Add ability to publish metabase questions - ChrisLovering

ChrisLovering

[python-discord/bot] New branch created: metabase\-sharing

ChrisLovering

[python-discord/bot] Pull request opened: #1762 Metabase sharing

This adds the ability to publicly share metabase questions via the bot, since admins don't have admin access to metabase, but the bot does.

This also refactors the error handling in the metabase cog to avoid copy pasting.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1762 Metabase sharing

GitHub Actions run 1155570938 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint & Test #1568

Source Branch

metabase-sharing

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1155572521 succeeded.

Actor

jb3

Workflow Run

Lint Kubernetes manifests #152

Commit

751547c

[regal arch]

ChrisLovering

[bot] Branch metabase\-sharing was force-pushed to `4a0d619`

Compare changes

jb3

[python-discord/bot] Pull request review submitted: #1762 Metabase sharing

[odd spire]

[python-discord/bot] Checks Successful on PR: #1762 Metabase sharing

GitHub Actions run 1155576611 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint & Test #1569

Source Branch

metabase-sharing

[regal arch]

D0rs4n

[python-discord/api] Pull request review submitted: #14 Fallback to the old API for undefined routes\.

[regal arch]

mbaruh

[bot:mbaruh/anti\-spam] 1 new commit

d0d1404 Improve cache iteration speed - mbaruh

[odd spire]

[python-discord/bot] Checks Successful on PR: #1760 Cross-channel and deleted messages anti-spam

GitHub Actions run 1155750354 succeeded.

PR Author

mbaruh

Workflow Run

Lint & Test #1570

Source Branch

mbaruh/anti-spam

[oak estuary]

Doc item doc_item.symbol_id='resources' present in loaded documentation inventories not found on site, inventories may need to be refreshed.

[ashen phoenix]

!docs refreshdoc

[oak estuary]

Inventories refreshed

[regal arch]

swfarnsworth

[site:swfarnsworth/smarter\-resources/new\-resources] 17 new commits

9a5fd18 feat: Make default options ticked when page loads - doublevcodes
667a13e chore: Update django-simple-bulma from v2.1 to ... - doublevcodes
07ba4f0 fix: Pin psycopg2-binary to v2.8.* - doublevcodes
577dd08 feat: Center Search and Clear Search buttons - doublevcodes
0d0ab20 feat: Add a source button to the resource boxes - doublevcodes

swfarnsworth

[python-discord/site] New branch created: swfarnsworth/smarter\-resources/new\-resources

[regal arch]

sentry-io[bot]

[python-discord/bot] Issue opened: #1763 Weird stage state causes users to not have a \.joined\_at attribute

Sentry Issue: BOT-1M7

TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'
  File "bot/utils/time.py", line 78, in discord_timestamp
    return f""
  File "bot/exts/info/information.py", line 260, in create_user_embed
    joined = discord_timestamp(user.joined_at, TimestampFormats.RELATIVE)
  File "bot/exts/info/information.py", line 235, in user_info
  ...

[regal arch]

TizzySaurus

[bot:TizzySaurus\-patch\-1] 1 new commit

9c199db Fix edge-case of user.joined_at being None ... - TizzySaurus

TizzySaurus

[python-discord/bot] New branch created: TizzySaurus\-patch\-1

TizzySaurus

[python-discord/bot] Pull request opened: #1764 Fix edge\-case of \`user\.joined\_at\` being \`None\` in userinfo command\.

Solves #1763

Now displays "Unable to get join date" when user.joined_at is None.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1764 Fix edge-case of `user.joined_at` being `None` in userinfo command.

GitHub Actions run 1156249877 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1571

Source Branch

TizzySaurus-patch-1

[regal arch]

mbaruh

[python-discord/bot] Pull request review submitted: #1764 Fix edge\-case of \`user\.joined\_at\` being \`None\` in userinfo command\.

Epic

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #805 800 - Real Python search command

GitHub Actions run 1156317166 succeeded.

PR Author

brad90four

Workflow Run

Lint #1246

Source Branch

brad90four:800

[regal arch]

brad90four

[python-discord/sir-lancebot] New comment on pull request #610: Teapot support

Hey @Xithrius , I can take a stab at this I think. Looks like all of the changes requested are pretty clear. Not sure what you mean by file conflicts and reviews that need to be resolved but I could probably figure it out with a little bit of help.

Akarys42

[python-discord/bot] Pull request review submitted: #1764 Fix edge\-case of \`user\.joined\_at\` being \`None\` in userinfo command\.

Let's make sure @mbaruh can sleep tonight. Thanks Tizzy!

Akarys42

[python-discord/bot] Pull request closed: #1764 Fix edge\-case of \`user\.joined\_at\` being \`None\` in userinfo command\.

Akarys42

[python-discord/bot] branch deleted: TizzySaurus\-patch\-1

Akarys42

[bot:main] 2 new commits

9c199db Fix edge-case of user.joined_at being None ... - TizzySaurus
ee23d67 Merge pull request #1764 from python-discord/Ti... - Akarys42

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1156357846 succeeded.

Actor

Akarys42

Workflow Run

Deploy #406

Commit

ee23d67

[regal arch]

TizzySaurus

[bot] Branch remove\-redundant\-converters was force-pushed to `4e158b2`

Compare changes

[odd spire]

[python-discord/bot] Checks Successful on PR: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

GitHub Actions run 1156401406 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1573

Source Branch

remove-redundant-converters

[regal arch]

TizzySaurus

[python-discord/bot] New comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

I've just squashed a load of commits, would appreciate someone just confirming that everything still looks good (from my quick look-over it does)

TizzySaurus

[python-discord/bot] New comment on issue #1763: Weird stage state causes users to not have a \.joined\_at attribute

Solved by #1764

TizzySaurus

[python-discord/bot] Issue closed: #1763 Weird stage state causes users to not have a \.joined\_at attribute

mbaruh

[python-discord/bot] Pull request review submitted: #1743 fix: update urls in site cog

mbaruh

[bot:dawnofmidnight/site\-urls] 62 new commits

fb9cbe4 Create events ext, prepare jams cog for file split - mbaruh
6986600 Move jam channels creation to separate file - mbaruh
d4271b0 More code jam functionality - mbaruh
bc390bc Added command to remove from team - mbaruh
fdc6f23 Fix end command docstring - mbaruh

mbaruh

[python-discord/bot] Pull request closed: #1743 fix: update urls in site cog

mbaruh

[bot:main] 3 new commits

939535d fix: update urls in site cog - dawnofmidnight
969f3bf Merge branch 'main' into dawnofmidnight/site-urls - mbaruh
4a59465 Merge pull request #1743 from python-discord/da... - mbaruh

mbaruh

[python-discord/bot] branch deleted: dawnofmidnight/site\-urls

[odd spire]

[python-discord/bot] Checks Successful on PR: #1743 fix: update urls in site cog

GitHub Actions run 1156437046 succeeded.

PR Author

dawnofmidnight

Workflow Run

Lint & Test #1574

Source Branch

dawnofmidnight/site-urls

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1156442070 succeeded.

Actor

mbaruh

Workflow Run

Deploy #407

Commit

4a59465

[regal arch]

mbaruh

[python-discord/bot] Pull request review submitted: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

This is an outdated comment:
https://github.com/python-discord/bot/blob/4e158b2a64e6f640847f0f7d2f229c96cecb2c46/bot/exts/moderation/watchchannels/bigbrother.py#L97

Otherwise looks great

mbaruh

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

From my testing the converters PR does not achieve the desired behavior described here.

TizzySaurus

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

How exactly are we planning on implementing this functionality?

My thoughts currently is that rather than adding another converter, we'd allow the passed user to be a str and in the case it is a string, we call some utility function which will query the database -- the utility function returning either None or raising an error when the username isn't found and returning the wanted data (e.g. infractions) when the username is found.

MarkKoz

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

Why should it not just be a converter? What advantage is there to invoking it manually?

TizzySaurus

[python-discord/bot] New comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

This is an outdated comment:
https://github.com/python-discord/bot/blob/4e158b2a64e6f640847f0f7d2f229c96cecb2c46/bot/exts/moderation/watchchannels/bigbrother.py#L97

Otherwise looks great

What exactly is this if statement here doing? I feel like it's supposed to check the user is in the server and isn't staff, but that's not what it's currently doing (the and should be an or and instead of hasattr(user, 'roles') can use isinstance(user, discord.User) (although if we on...

ChrisLovering

[python-discord/bot] Issue opened: #1765 Shoutout our patreon supporters\!

In a recent staff meeting we agreed that we weren't giving enough love to our patreon supporters.

As such, we have agreed that we should have the bot post in #community-meta every time someone new receives one of the patreon roles, along with posting once a month (on the 1st, just after the patreon subscription cycle) with a full list of all of our supporters.

The post when we get a new supporter should include:

• A mention for the user who has started supporting
• What tier they ar...

MarkKoz

[python-discord/bot] New comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

I feel like it's supposed to check whether the user is a staff, but would make more sense for the hasattr part to be isinstance(user, discord.Member)

I suppose it's more ducktype-y to check for the attribute instead of the whole type. However, we know the converter can only return one of two types, so it doesn't really matter in this case.

ChrisLovering

[python-discord/bot] New comment on issue #1765: Shoutout our patreon supporters\!

The role IDs are:

• Tier 1 - 505040943800516611
• Tier 2 - 743399725914390631
• Tier 3 - 743400204367036520
  The link to our Patreon is https://www.patreon.com/python_discord

TizzySaurus

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

Making it a converter brings other complications, such as what would the converter return?

From my understanding it'd have to end up returning t.Union[MemberOrUser, discord.Object] when the person is valid since we want to allow for deleted accounts but then this leads to a typehint being of two different types, potentially leading to further implications.

There's also the fact that we'd be querying the database twice (once for the conversion, and a potential second time for the actua...

mbaruh

[python-discord/bot] New comment on pull request #1682: Allow manual mutes to override auto mutes

When you added the notify argument to mute pardons, why you did so for voice bans as well?

ChrisLovering

[python-discord/bot] New comment on issue #1765: Shoutout our patreon supporters\!

Patreon subscription cycle seems to be the 1st of the month in PST, so posting the monthly embed at ~1700 UTC seems like a good time to do it.

TizzySaurus

[python-discord/bot] New comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

I feel like it's supposed to check whether the user is a staff, but would make more sense for the hasattr part to be isinstance(user, discord.Member)

I suppose it's more ducktype-y to check for the attribute instead of the whole type. However, we know the converter can only return one of two types, so it doesn't really matter in this case.

Yeah, I guess. I'll just pretend I didn't see this and update the comment to say discord.User instead of FetchedUser.

TizzySaurus

[bot:remove\-redundant\-converters] 1 new commit

9c41f0b Update outdated comment - TizzySaurus

TizzySaurus

[python-discord/bot] New comment on pull request #1742: Remove redundant converters and renamed FetchedMember to MemberOrUser

This is an outdated comment:
https://github.com/python-discord/bot/blob/4e158b2a64e6f640847f0f7d2f229c96cecb2c46/bot/exts/moderation/watchchannels/bigbrother.py#L97

Otherwise looks great

Committed :+1:

[odd spire]

[python-discord/bot] Checks Successful on PR: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

GitHub Actions run 1156518606 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1576

Source Branch

remove-redundant-converters

[regal arch]

mbaruh

[python-discord/bot] Pull request review submitted: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

mbaruh

[bot:remove\-redundant\-converters] 67 new commits

fb9cbe4 Create events ext, prepare jams cog for file split - mbaruh
6986600 Move jam channels creation to separate file - mbaruh
d4271b0 More code jam functionality - mbaruh
bc390bc Added command to remove from team - mbaruh
fdc6f23 Fix end command docstring - mbaruh

mbaruh

[python-discord/bot] Issue closed: #1681 apply\_infraction assumes the user will have a mention attribute

mbaruh

[python-discord/bot] branch deleted: remove\-redundant\-converters

mbaruh

[python-discord/bot] Pull request closed: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

mbaruh

[bot:main] 18 new commits

73bc011 Remove converters made redundant by dpy V1.6's ... - TizzySaurus
17f3750 Update to new converters - TizzySaurus
bb2c20f Remove unused imports - TizzySaurus
ad873f9 Rename converter from FetchedMember to MemberOr... - TizzySaurus
4c8d775 Fix import order - TizzySaurus

[odd spire]

[python-discord/bot] Checks Successful on PR: #1742 Remove redundant converters and renamed FetchedMember to MemberOrUser

GitHub Actions run 1156528070 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1577

Source Branch

remove-redundant-converters

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1156532815 succeeded.

Actor

mbaruh

Workflow Run

Deploy #408

Commit

e8c17c5

[regal arch]

mbaruh

[python-discord/bot] New comment on pull request #1700: Restrict internal eval command to bot owner when in debug mode

The biggest downside I see is that it’ll leave a possible security vulnerability if the user doesn’t set it, and nothing will tell them so

Yeah, that's the concern, and I think it's a completely valid point. I'm thinking that production could just "take the hit" and set the env var to False explicitly. It has to set other env vars anyway.

What is the verdict then? do we set an env var in prod, and default to true?

[regal arch]

TizzySaurus

[bot:TizzySaurus\-patch\-1] 1 new commit

27a2a0d Update time format in reminder message to DAY_T... - TizzySaurus

TizzySaurus

[python-discord/bot] New branch created: TizzySaurus\-patch\-1

TizzySaurus

[python-discord/bot] Pull request opened: #1766 Update time format in reminder message to DAY\_TIME from RELATIVE

Closes #1750

The message sent when you create a new reminder now uses the DAY_TIME time formatting instead of RELATIVE time format.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1766 Update time format in reminder message to DAY_TIME from RELATIVE

GitHub Actions run 1156577816 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1579

Source Branch

TizzySaurus-patch-1

[regal arch]

D0rs4n

[python-discord/bot] New comment on issue #1759: Remove restriction on snowflake command

I would be glad to do this! :)

[regal arch]

TizzySaurus

[python-discord/bot] Issue opened: #1767 Reminder command is too greedy

Currently the typehint for the mentions argument of the !remind command is Greedy[Mentionable], where Mentionable = t.Union[discord.Member, discord.Role].

The issue with have a greedy discord.Member is that cases like !remind 3d fix this" ends up raising the error fix is not a valid duration string.since the3d` gets matched to a member instead of the duration of 3 days.

My proposed solution to this, is simply to instead do Greedy[t.Union[UserMentionOrID, discord.Role]]...

mbaruh

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

Making it a converter brings other complications, like what would it return?

I suppose we'd want the converter to return a custom datatype instance which has all of the user data obtainable from the database?

I'm struggling to envisage how exactly this would work.

The way it would work is that it would try to find the username and discrim in the database, and if it's there fetch the ID. Once you have the ID you can use the discord API as usual.

TizzySaurus

[bot:fix\-reminder\-greediness] 1 new commit

8c52b89 Update reminders command to use `UserMentionOrI... - TizzySaurus

TizzySaurus

[python-discord/bot] New branch created: fix\-reminder\-greediness

TizzySaurus

[python-discord/bot] Pull request opened: #1768 Update reminders command to use \`UserMentionOrID\` instead of \`discord\.Member\`

Closes #1767.

Makes it so that user mentions for the reminder command have to be mention/id to prevent greediness issues with the discord.Member converter.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1768 Update reminders command to use `UserMentionOrID` instead of `discord.Member`

GitHub Actions run 1156689650 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1580

Source Branch

fix-reminder-greediness

[regal arch]

TizzySaurus

[python-discord/bot] New comment on issue #1757: Fallback to site DB on searches by username

Right, but what about when it's a deleted account? The user id will return but converting to a User object will fail (would have to have a fallback of discord.Object, meaning the converter would have two possible return types)

[regal arch]

Xithrius

[python-discord/bot] New review comment on pull request #1766: Update time format in reminder message to DAY\_TIME from RELATIVE

I think Your reminder will arrive on Thursday, January 1, 1970 1:00 AM sounds better than Your reminder will arrive Thursday, January 1, 1970 1:00 AM

        mention_string = f"Your reminder will arrive on {discord_timestamp(expiration, TimestampFormats.DAY_TIME)}"

Xithrius

[python-discord/bot] Pull request review submitted: #1762 Metabase sharing

Very good.

MarkKoz

[python-discord/bot] New comment on pull request #1682: Allow manual mutes to override auto mutes

When you added the notify argument to mute pardons, why you did so for voice bans as well?

Because they also send a pardon DM. It'd be inconsistent to allow it for one infraction type but not another when both send a DM.

Xithrius

[bot:metabase\-sharing] 24 new commits

939535d fix: update urls in site cog - dawnofmidnight
9c199db Fix edge-case of user.joined_at being None ... - TizzySaurus
73bc011 Remove converters made redundant by dpy V1.6's ... - TizzySaurus
17f3750 Update to new converters - TizzySaurus
bb2c20f Remove unused imports - TizzySaurus

Xithrius

[bot:main] 7 new commits

9ad34a8 Move metabase error handling to a cog error han... - ChrisLovering
30bcc28 Change metabase config to base url, rather than... - ChrisLovering
ce80b92 Add alias for metabase export - ChrisLovering
eb5cede Trigger typing, to avoid wrapping whole func in... - ChrisLovering
4a0d619 Add ability to publish metabase questions - ChrisLovering

Xithrius

[python-discord/bot] Pull request closed: #1762 Metabase sharing

Xithrius

[python-discord/bot] branch deleted: metabase\-sharing

[odd spire]

[python-discord/bot] Checks Successful on PR: #1762 Metabase sharing

GitHub Actions run 1156741575 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint & Test #1581

Source Branch

metabase-sharing

[regal arch]

MarkKoz

[python-discord/bot] New comment on pull request #1700: Restrict internal eval command to bot owner when in debug mode

The biggest downside I see is that it’ll leave a possible security vulnerability if the user doesn’t set it, and nothing will tell them so

Yeah, that's the concern, and I think it's a completely valid point. I'm thinking that production could just "take the hit" and set the env var to False explicitly. It has to set other env vars anyway.

What is the verdict then? do we set an env var in prod, and default to true? I don't mind that approach.

I am okay ...

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1156749187 succeeded.

Actor

Xithrius

Workflow Run

Deploy #409

Commit

abef38e

[regal arch]

TizzySaurus

[bot:TizzySaurus\-patch\-1] 1 new commit

3fadbd3 Update message sent when reminder made

• TizzySaurus

TizzySaurus

[python-discord/bot] New review comment on pull request #1766: Update time format in reminder message to DAY\_TIME from RELATIVE

Done :+1:

[odd spire]

[python-discord/bot] Checks Successful on PR: #1766 Update time format in reminder message to DAY_TIME from RELATIVE

GitHub Actions run 1157686870 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1584

Source Branch

TizzySaurus-patch-1

[python-discord/bot] Checks Successful on PR: #1766 Update time format in reminder message to DAY_TIME from RELATIVE

GitHub Actions run 1157686854 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1583

Source Branch

TizzySaurus-patch-1

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on issue #238: Text Based Adventure

@MrKomodoDragon @Kronifer what's your status on this feature?

Bluenix2

[python-discord/bot] Pull request review submitted: #1766 Update time format in reminder message to DAY\_TIME from RELATIVE

Simple enough, looks good. Thank you

Xithrius

[python-discord/sir-lancebot] New comment on issue #325: Personal stats with something like \!aoc mystats

@LeptoFlare Will you be able to continue the development of this feature?

Xithrius

[python-discord/sir-lancebot] New comment on issue #384: Logging Level Adjustments

@ChrisLovering looks like this can be worked on. Would you like to go ahead?

Xithrius

[python-discord/sir-lancebot] New comment on issue #746: Escape square brackets in reddit post bodies

@PseudoCodeNerd @Joe-Sin7h Sorry for being a year late, would either of you like to still work on this?

Xithrius

[python-discord/sir-lancebot] New comment on issue #436: Beardify — Lemoji beard structure text generator

@gustavwilliam How's this feature going?

Xithrius

[python-discord/sir-lancebot] Issue closed: #437 Bot not able to catch answers typed in bursts

Xithrius

[python-discord/sir-lancebot] New comment on issue #437: Bot not able to catch answers typed in bursts

I've seen people spam on purpose and I've tried reproducing myself, the bug no longer seems to exist.

Xithrius

[python-discord/bot] Pull request review submitted: #1766 Update time format in reminder message to DAY\_TIME from RELATIVE

Xithrius

[bot:TizzySaurus\-patch\-1] 8 new commits

9ad34a8 Move metabase error handling to a cog error han... - ChrisLovering
30bcc28 Change metabase config to base url, rather than... - ChrisLovering
ce80b92 Add alias for metabase export - ChrisLovering
eb5cede Trigger typing, to avoid wrapping whole func in... - ChrisLovering
4a0d619 Add ability to publish metabase questions - ChrisLovering

Xithrius

[python-discord/bot] Issue closed: #1750 Use DAY\_TIME or DATE\_TIME timestamp format for reminders

Xithrius

[python-discord/bot] Pull request closed: #1766 Update time format in reminder message to DAY\_TIME from RELATIVE

Xithrius

[bot:main] 1 new commit

a831aa0 Update time format in reminder message to DAY_T... - TizzySaurus

Xithrius

[python-discord/bot] branch deleted: TizzySaurus\-patch\-1

[odd spire]

[python-discord/bot] Checks Successful on PR: #1766 Update time format in reminder message to DAY_TIME from RELATIVE

GitHub Actions run 1157732725 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1585

Source Branch

TizzySaurus-patch-1

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1157743465 succeeded.

Actor

Xithrius

Workflow Run

Deploy #410

Commit

a831aa0

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on issue #489: hacktoberissues must have "hacktoberfest" topic for the repo

@hedyhli Greetings. I seem to be around a year late to this, but would you still like to implement this fix?

Xithrius

[python-discord/sir-lancebot] New comment on issue #494: Add Yoda Text Command

@aaravm4 How's it going?

Xithrius

[python-discord/sir-lancebot] New comment on issue #502: Riddle command should operate like the Quiz

@aaravm4 will you be able to output a PR?

Xithrius

[python-discord/sir-lancebot] New comment on issue #513: Create rollover cooldown logic for wolfram alpha

Unfortunately I'm not for this issue as we're usually against "gamifying" commands where a number can go up over time if a user triggers a command.

We only have a limited amount of API calls to Wolfram, and I'd rather not hit the ratelimits of such a powerful command.

Xithrius

[python-discord/sir-lancebot] Issue closed: #513 Create rollover cooldown logic for wolfram alpha

Xithrius

[python-discord/sir-lancebot] New comment on issue #527: Clean up constants\.py

Given that smartconfig may not be worked on until later this year, @HassanAbouelela would you like to have a crack again at cleaning up constants.py?

Xithrius

[python-discord/sir-lancebot] New comment on issue #551: Have a type race command for the bot\.

@Inheritanc-e how's this feature going?

Xithrius

[python-discord/sir-lancebot] New comment on issue #581: Block commands from working in DMs

What's the verdict of this issue?

Xithrius

[python-discord/sir-lancebot] New comment on issue #594: Only allow 1 concurrent image processing command

@ChrisLovering how's the 1 concurrent command at a time feature going?

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #384: Logging Level Adjustments

I don't think this is relevant any more, we change the log levels as needed if we a sentry report come in at a wrong level.

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #594: Only allow 1 concurrent image processing command

Ah, I did not realise I was still assigned to this one, it's up for grand for anyone to work on

[odd spire]

[python-discord/bot] Checks Failed on PR: #1731 Add converter typehints

GitHub Actions run 1157935141 failed.

PR Author

Numerlor

Workflow Run

Lint & Test #1587

Source Branch

Numerlor:converter-typehints

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

Stalled because of quackstack

Xithrius

[python-discord/sir-lancebot] New comment on issue #670: Authenticate all Github Requests

@D0rs4n you can go ahead and take this once that PR is merged. Should be done sometime soon.

HassanAbouelela

[python-discord/bot] New branch created: Quo

Xithrius

[python-discord/sir-lancebot] New comment on issue #677: Create a colo\[u\]r command

Given that the author hasn't responded to the ping, this issue is now up for grabs.

HassanAbouelela

[python-discord/bot] branch deleted: Quo

Xithrius

[python-discord/sir-lancebot] New comment on issue #706: Adapt selective trace logging from bot

@ToxicKidz is this being done, or should I make this up for grabs?

Xithrius

[python-discord/sir-lancebot] New comment on issue #707: New \`\.case\` commands

@vcokltfre Greetings. I hope you've been doing well. Are you still planning on doing this feature?

Xithrius

[python-discord/sir-lancebot] New comment on issue #710: New avatarmod command \[name subject to change\]

@ChrisLovering @vcokltfre #597 is now merged, this can be done.

Xithrius

[python-discord/sir-lancebot] New comment on issue #730: Anagrams Minigame command

The author doesn't seem to be active in GitHub, and hasn't responded to the ping.

This issue is now up for grabs.

Xithrius

[python-discord/sir-lancebot] New comment on issue #743: Issue/PR hyperlink embed upgrade

@D0rs4n Is this currently being worked on?

Xithrius

[python-discord/sir-lancebot] New comment on issue #772: Handle the AI in Tic\-Tac\-Toe requester check\.

@OculusMode what's your status on this fix?

Xithrius

[python-discord/sir-lancebot] New comment on issue #783: Rickroll Avatar

I'm worried about how much computational power this would take.

@HassanAbouelela random poke, what do you think about this?

Xithrius

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

@VikranthMaster I think the planning stage is done, would you like to implement this?

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

Xithrius

[python-discord/sir-lancebot] Issue closed: #793 KeyError: 'query' \(wikipedia cog\)

Xithrius

[python-discord/sir-lancebot] Pull request closed: #795 Handle Wikipedia API errors and warnings in the Wikipedia Cog

Xithrius

[sir-lancebot:main] 13 new commits

c9f8efc Handle Wikipedia API errors and warnings in the... - D0rs4n
f36cdb2 Refactor wiki_request, add External API related... - D0rs4n
95d7a4d Resolve merge conflict - D0rs4n
ff0d3a8 Improve code consitency in Wikipedia Cog,Except... - D0rs4n
12a4139 Remove duplicated code, improve consitency in W... - D0rs4n

[night lily]

Sir Lancebot

Connected!

[odd spire]

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 1158029542 succeeded.

Actor

Xithrius

Workflow Run

Build #406

Commit

0a1b7b4

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on issue #797: Adding tags to the stackoverflow command

We're thinking of slimming down the stackoverflow command because it looks like a dumpster fire on mobile, so I'm going to mark this as stalled until we fix that up.

Planning can continue, if possible.

Xithrius

[python-discord/sir-lancebot] New comment on issue #811: Allow bookmark command \`\.bm\` by users in help channels

I've approved this, anyone can take this up.

Xithrius

[python-discord/sir-lancebot] New comment on issue #620: Incorrect Zodiac Dates

I have checked more websites, and the dates do indeed seem correct.

Xithrius

[python-discord/sir-lancebot] Issue closed: #620 Incorrect Zodiac Dates

Xithrius

[python-discord/sir-lancebot] New comment on issue #615: Codeblock rendering inconsistency on Android client\.

For people on android, does this bug still exist?

Xithrius

[python-discord/sir-lancebot] New comment on issue #612: Coin Flip Command

@InvisibleOS Can you make a PR with your feature so we can start reviewing it?

D0rs4n

[python-discord/sir-lancebot] New comment on issue #743: Issue/PR hyperlink embed upgrade

Yes, it is. Unfortunately, I'm waiting for the same PR(merge issues into GithubInfo cog) to be merged. That PR was also gonna introduce minor bug fixes in the .issue command, but it was removed.

Xithrius

[python-discord/sir-lancebot] New comment on issue #611: Full support for Gitpod

I think this falls under the same reasoning of if https://github.com/python-discord/sir-lancebot/issues/451 should be kept open as well. Codespaces are now paid for, so not many users are going to have this as an advantage.

My point is: should we implement codespaces at all? @HassanAbouelela @Kronifer please give me your opinions.

Xithrius

[python-discord/sir-lancebot] New comment on issue #743: Issue/PR hyperlink embed upgrade

Ah yes, we're just waiting on Toxic to fix things up and we should be good.

Xithrius

[python-discord/sir-lancebot] New comment on issue #384: Logging Level Adjustments

Alright then. Thanks for the information.

D0rs4n

[python-discord/sir-lancebot] New comment on issue #743: Issue/PR hyperlink embed upgrade

OK, I'll push my PRs right after it is merged! 👍

Xithrius

[python-discord/sir-lancebot] Issue closed: #384 Logging Level Adjustments

Xithrius

[python-discord/sir-lancebot] New comment on issue #743: Issue/PR hyperlink embed upgrade

Very cool.

[regal arch]

Bluenix2

[python-discord/sir-lancebot] Pull request review submitted: #805 800 \- Real Python search command

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

                logger.error(f"Unexpect status code {response.status} from RealPython")

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

Useless variable here too?

Bluenix2

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

Are you sure there shouldn't be more empty lines?

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

If we decide to use the quackstack API, there shouldn't be any reason to stall this issue and it can be worked on. Otherwise, if we decide to use quackstack via a PyPI package and generate the duck images ourselves, we would need to wait for python-discord/quackstack#52.

There are downsides to both of them, if we use the API, anyone wanting to run the quack command on sir-Lancelot would need to have the API running and if we decide to use the PyPI package and generate the image ourselves, ...

Bluenix2

[python-discord/bot] Pull request review submitted: #1768 Update reminders command to use \`UserMentionOrID\` instead of \`discord\.Member\`

Looks good, thanks

Xithrius

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

I think we should wait for quackstack to be contained within a package.

Xithrius

[python-discord/bot] Pull request review submitted: #1768 Update reminders command to use \`UserMentionOrID\` instead of \`discord\.Member\`

Poifect.

Xithrius

[bot:fix\-reminder\-greediness] 9 new commits

9ad34a8 Move metabase error handling to a cog error han... - ChrisLovering
30bcc28 Change metabase config to base url, rather than... - ChrisLovering
ce80b92 Add alias for metabase export - ChrisLovering
eb5cede Trigger typing, to avoid wrapping whole func in... - ChrisLovering
4a0d619 Add ability to publish metabase questions - ChrisLovering

Xithrius

[python-discord/bot] Issue closed: #1767 Reminder command is too greedy

Xithrius

[python-discord/bot] Pull request closed: #1768 Update reminders command to use \`UserMentionOrID\` instead of \`discord\.Member\`

Xithrius

[bot:main] 1 new commit

26073a9 Update reminders command to use `UserMentionOrI... - TizzySaurus

Xithrius

[python-discord/bot] branch deleted: fix\-reminder\-greediness

[odd spire]

[python-discord/bot] Checks Successful on PR: #1768 Update reminders command to use `UserMentionOrID` instead of `discord.Member`

GitHub Actions run 1158159010 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1588

Source Branch

fix-reminder-greediness

[regal arch]

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

Does quackstack not support api requests from the public? I don't understand why someone would need a version of quackstack running locally.

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

🤦🏾 You are right.

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1158169448 succeeded.

Actor

Xithrius

Workflow Run

Deploy #411

Commit

26073a9

[regal arch]

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

It would be nice to have sirlance use the internal cluster route in production, but then use the public api endpoint for local dev, just to save egress/ingress from the cluster

Xithrius

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

If we have those public API requests, that solves all our problems. Let's just go with that for now.

Xithrius

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

Whoever wants to pick this issue up, you're free to do so. Ping a core dev and we'll assign.

You can find all the docs stuff here: https://quackstack.pythondiscord.com/docs.

Bluenix2

[python-discord/bot] Pull request review submitted: #1760 Cross\-channel and deleted messages anti\-spam

Bluenix2

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

Should there not be a new line after this?

Bluenix2

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

I don't think I understand this, you go through each message and add them to the list in the dictionary?

Then you go through this dictionary and delete those messages in bulk?

Why is the channels a default dict? I thought we already had all channels because of the set?

Bluenix2

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

When is this used? This should be a reference to the same Message object, so it will be changed "automatically".

[regal arch]

mbaruh

[python-discord/bot] New comment on pull request #1487: Goodbye, \#talent\-pool

@MarkKoz I think the current duplicated functions should remain where they are for now. If we do decide to move these functions somewhere else, it should be within a different PR focused on refactoring.

The functions themselves in my own attempt of refactoring ended up taking a bit too many variables as arguments. That may have just been me though, and it was quite a while since said last attempt. Although at this point in time it seems to be still the same case.

I feel li...

mbaruh

[python-discord/bot] New comment on pull request #1682: Allow manual mutes to override auto mutes

When you added the notify argument to mute pardons, why you did so for voice bans as well?

Because they also send a pardon DM. It'd be inconsistent to allow it for one infraction type but not another when both send a DM.

What about the pardon_ban function then?

jb3

[python-discord/quackstack] New comment on issue #7: Set up a PyPI\-friendly package to execute the CLI commands\.

We're not going to proceed with packaging Quackstack at this point. Integrations such as Sir Lancebot and potentially a CLI in future will call out to the publicly hosted instance at quackstack.pythondiscord.com.

jb3

[python-discord/quackstack] Issue closed: #7 Set up a PyPI\-friendly package to execute the CLI commands\.

jb3

[python-discord/quackstack] New comment on issue #8: CI: Push package to PyPI on release

We're not going to proceed with packaging Quackstack at this point. Integrations such as Sir Lancebot and potentially a CLI in future will call out to the publicly hosted instance at quackstack.pythondiscord.com.

jb3

[python-discord/quackstack] Issue closed: #8 CI: Push package to PyPI on release

jb3

[python-discord/quackstack] New comment on issue #24: Add GitHub Actions job for pushing semver release on release event

We're not going to proceed with packaging Quackstack at this point. Integrations such as Sir Lancebot and potentially a CLI in future will call out to the publicly hosted instance at quackstack.pythondiscord.com.

jb3

[python-discord/quackstack] Issue closed: #24 Add GitHub Actions job for pushing semver release on release event

jb3

[python-discord/quackstack] New comment on issue #5: CLI: Generate ducky from CLI command\.

We're not going to proceed with packaging Quackstack for PyPI at this point. Integrations such as Sir Lancebot and potentially a CLI in future will call out to the publicly hosted instance at quackstack.pythondiscord.com. I'll keep this issue open but retarget it as a long term goal of the project.

mbaruh

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

This is a copy of the deque error message

jb3

[python-discord/quackstack] New comment on pull request #52: feat: make quackstack package\-ready

We're not going to proceed with packaging Quackstack at this point. Integrations such as Sir Lancebot and potentially a CLI in future will call out to the publicly hosted instance at quackstack.pythondiscord.com.

jb3

[python-discord/quackstack] Pull request closed: #52 feat: make quackstack package\-ready

mbaruh

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

Why is the benefit?

mbaruh

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

I'm grouping the messages per channel to be able to use the delete_messages method on all messages of that channel at the same time.

mbaruh

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

The new line is in the value of the variable. If there is only one channel then the string does not appear at all and I don't want a new line in that case.

jb3

[python-discord/quackstack] Issue opened: #59 S3 Storage

Instead of serving ducks from our hosts we should upload generated ducks to an S3 host (preferably Linode Object Storage, which is compatible with any S3 wrapper).

Once generated we'll return these links to the clients and serve from there to save bandwidth and improve speed of delivery. We should check for presence of an image before generating so that we don't store duplicate ducks.

mbaruh

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

This is used in the antispam's on_message_edit. The listener receives two different Message objects.

mbaruh

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

Iteration stops when you return. There's no difference between having something to iterate on first and then return, and having nothing to iterate on and then return.

jb3

[python-discord/quackstack] New comment on pull request #52: feat: make quackstack package\-ready

Reopened because there are still some amendments here which may be nice to have even if not distributing to PyPI.

jb3

[python-discord/quackstack] Pull request reopened: #52 feat: make quackstack package\-ready

vcokltfre

[quackstack:vcokltfre/feat/package\-ready\-rewrite] 1 new commit

ed64ce5 chore: clean up indentation - vcokltfre

vcokltfre

[quackstack:vcokltfre/feat/package\-ready\-rewrite] 8 new commits

c5f5024 Create LICENSE - jb3
bcb1620 Update LICENSE - jb3
499f573 Merge pull request #56 from python-discord/jb3/... - jb3
06aca03 Bump fastapi from 0.63.0 to 0.65.2 - dependabot[bot]
1633e1c Merge pull request #57 from python-discord/depe... - vcokltfre

Bluenix2

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

Ah interesting, doesn't type checkers complain though?

mbaruh

[python-discord/bot] New review comment on pull request #1760: Cross\-channel and deleted messages anti\-spam

Nothing that I've seen so far. Once you have a yield statement the function returns a generator which you use to get the values, and a generator is an iterator.

[regal arch]

hedyhli

[python-discord/sir-lancebot] New comment on issue #489: hacktoberissues must have "hacktoberfest" topic for the repo

@Xithrius I'm not sure I'll have the time, and I haven't worked with the codebase for quite a while so I might need some getting use to.

Also (for hacktoberfest stats/prs), this year's hacktoberfest (if it's happening) probably doesn't need the "first 3 days counts even if it doesn't haven hacktoberfest label" anymore. Again, I haven't been on discord for a long time nor have I seen the commits and stuff so I'm not sure if that needs to be changed before October.

In any case, I think we...

[regal arch]

Numerlor

[python-discord/bot] New comment on pull request #1700: Restrict internal eval command to bot owner when in debug mode

The biggest downside I see is that it’ll leave a possible security vulnerability if the user doesn’t set it, and nothing will tell them so

Yeah, that's the concern, and I think it's a completely valid point. I'm thinking that production could just "take the hit" and set the env var to False explicitly. It has to set other env vars anyway.

What is the verdict then? do we set an env var in prod, and default to true? I don't mind that approach.
...

[regal arch]

Kronifer

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

@Xithrius I'll take this on

VikranthMaster

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

@Xithrius I thought u guys implemented it already

Kronifer

[python-discord/sir-lancebot] New comment on issue #611: Full support for Gitpod

I think either way works. It would be nice to have dependencies installed right off the bat, but at the same time it isn't hard to install them

Kronifer

[python-discord/sir-lancebot] New comment on issue #238: Text Based Adventure

I don't think it's happening at the moment

[regal arch]

Inheritanc-e

[python-discord/sir-lancebot] New comment on issue #551: Have a type race command for the bot\.

Its in the testing phase and nearly done

LeptoFlare

[python-discord/sir-lancebot] New comment on issue #325: Personal stats with something like \!aoc mystats

I am looking to complete this during October !

[regal arch]

TizzySaurus

[python-discord/bot] Issue opened: #1769 \`\!user\` command doesn't escape markdown in user's name

Pretty self explanatory. The title of the embed (the name) doesn't escape markdown so can end up being italic etc.

wookie184

[bot:antispam\-ignore\-bot\-mentions] 1 new commit

0199600 Ignore bot mentions in antispam mentions rule - wookie184

wookie184

[python-discord/bot] New branch created: antispam\-ignore\-bot\-mentions

wookie184

[python-discord/bot] Pull request opened: #1770 Ignore bot mentions in antispam mentions rule

People may for example list all the bots on this server, this is not a potentially malicious use of pings so there is no reason for it to count towards the threshold for the antispam ping rule.

TizzySaurus

[bot:TizzySaurus\-patch\-1] 1 new commit

eb4aab5 Escape markdown in user's name for !user command - TizzySaurus

TizzySaurus

[python-discord/bot] New branch created: TizzySaurus\-patch\-1

[odd spire]

[python-discord/bot] Checks Failed on PR: #1770 Ignore bot mentions in antispam mentions rule

GitHub Actions run 1159519810 failed.

PR Author

wookie184

Workflow Run

Lint & Test #1590

Source Branch

antispam-ignore-bot-mentions

[regal arch]

Akarys42

[python-discord/bot] Pull request review submitted: #1770 Ignore bot mentions in antispam mentions rule

TizzySaurus

[python-discord/bot] Pull request opened: #1771 Escape markdown in user's name for \`\!user\` command

Closes #1769.

Markdown in the user's name/nickname is now escaped in the !user command.

Akarys42

[python-discord/bot] Pull request review submitted: #1771 Escape markdown in user's name for \`\!user\` command

ChrisLovering

[python-discord/bot] New comment on issue #1759: Remove restriction on snowflake command

I would be glad to do this! :)

Assigned!

ChrisLovering

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

I agree with all of this, except for #duck-pond, since they don't have access to that channel, I don't think it would make sense to be able to duck their messages.

Yup, that sounds good. Seems like 3 core devs are in agreement, I'll approve this :)

wookie184

[python-discord/bot] New comment on pull request #1770: Ignore bot mentions in antispam mentions rule

need to fix the tests before merging

ChrisLovering

[python-discord/bot] Pull request review submitted: #1771 Escape markdown in user's name for \`\!user\` command

Akarys42

[python-discord/bot] Issue closed: #1769 \`\!user\` command doesn't escape markdown in user's name

Akarys42

[python-discord/bot] Pull request closed: #1771 Escape markdown in user's name for \`\!user\` command

Akarys42

[python-discord/bot] branch deleted: TizzySaurus\-patch\-1

Akarys42

[bot:main] 2 new commits

eb4aab5 Escape markdown in user's name for !user command - TizzySaurus
f640c5f Merge pull request #1771 from python-discord/Ti... - Akarys42

[odd spire]

[python-discord/bot] Checks Successful on PR: #1771 Escape markdown in user's name for `!user` command

GitHub Actions run 1159532815 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1591

Source Branch

TizzySaurus-patch-1

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1159552298 succeeded.

Actor

Akarys42

Workflow Run

Deploy #412

Commit

f640c5f

[regal arch]

D0rs4n

[python-discord/bot] Pull request opened: #1772 Remove restriction on snowflake command

Closes #1759

[odd spire]

[python-discord/bot] Checks Successful on PR: #1772 Remove restriction on snowflake command

GitHub Actions run 1159613998 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1593

Source Branch

D0rs4n:pr/nostafflake

[regal arch]

wookie184

[python-discord/bot] Pull request review submitted: #1772 Remove restriction on snowflake command

lgtm

wookie184

[bot:antispam\-ignore\-bot\-mentions] 2 new commits

7daab91 Fix current tests by using MockMember in mentio... - wookie184
a6121e6 Added some more test cases to ensure bot mentio... - wookie184

[odd spire]

[python-discord/bot] Checks Successful on PR: #1770 Ignore bot mentions in antispam mentions rule

GitHub Actions run 1159637641 succeeded.

PR Author

wookie184

Workflow Run

Lint & Test #1594

Source Branch

antispam-ignore-bot-mentions

[regal arch]

mbaruh

[python-discord/bot] Pull request review submitted: #1682 Allow manual mutes to override auto mutes

Looks good, thank you

mbaruh

[bot:feat/mod/1665/override\-auto\-mute] 199 new commits

6f45d68 Bump embed limit to 4096 characters - Akarys42
db410e8 Make use of Discord timestamps - Akarys42
231f6dc Tests: remove stale patch of time_since - Akarys42
fb9cbe4 Create events ext, prepare jams cog for file split - mbaruh
6986600 Move jam channels creation to separate file - mbaruh

mbaruh

[python-discord/bot] Issue closed: #1665 Make mutes override auto\-mutes

mbaruh

[python-discord/bot] Pull request closed: #1682 Allow manual mutes to override auto mutes

mbaruh

[bot:main] 10 new commits

66ec867 Allow manual mutes to override auto mutes - MarkKoz
786b690 Display error if overriding mute fails - MarkKoz
8ec6f08 Fix get_active_infraction test - MarkKoz
24e4a9d Remove redundant parameter from pardon_voice_ban - MarkKoz
c84ed0f Avoid sending pardon DM when overriding a mute - MarkKoz

mbaruh

[python-discord/bot] branch deleted: feat/mod/1665/override\-auto\-mute

[odd spire]

[python-discord/bot] Checks Successful on PR: #1682 Allow manual mutes to override auto mutes

GitHub Actions run 1159666875 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1595

Source Branch

feat/mod/1665/override-auto-mute

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1159678351 succeeded.

Actor

mbaruh

Workflow Run

Deploy #413

Commit

1642337

[regal arch]

TizzySaurus

[python-discord/bot] Pull request review submitted: #1772 Remove restriction on snowflake command

Simple enough. Should work perfectly :+1:

wookie184

[python-discord/bot] Pull request review submitted: #1760 Cross\-channel and deleted messages anti\-spam

I haven't looked through the MessageCache implementation too closely, but the rest looks great and seems to work perfectly.

Bluenix2

[python-discord/bot] Pull request review submitted: #1772 Remove restriction on snowflake command

Looks good, thank you

Akarys42

[bot:mbaruh/anti\-spam] 63 new commits

66ec867 Allow manual mutes to override auto mutes - MarkKoz
786b690 Display error if overriding mute fails - MarkKoz
8ec6f08 Fix get_active_infraction test - MarkKoz
24e4a9d Remove redundant parameter from pardon_voice_ban - MarkKoz
c84ed0f Avoid sending pardon DM when overriding a mute - MarkKoz

[odd spire]

[python-discord/bot] Checks Successful on PR: #1760 Cross-channel and deleted messages anti-spam

GitHub Actions run 1159780034 succeeded.

PR Author

mbaruh

Workflow Run

Lint & Test #1597

Source Branch

mbaruh/anti-spam

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on issue #489: hacktoberissues must have "hacktoberfest" topic for the repo

Alright, I'll leave it up for grabs for now.

Xithrius

[python-discord/sir-lancebot] New comment on issue #652: \.quack \- Procedural Duck Generator\!

@Kronifer Very well.

Xithrius

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

Have we? Let me check.

Xithrius

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

@VikranthMaster We have not.

Xithrius

[python-discord/sir-lancebot] New comment on issue #551: Have a type race command for the bot\.

Very well.

Xithrius

[python-discord/sir-lancebot] New comment on issue #325: Personal stats with something like \!aoc mystats

@LeptoFlare Thanks!

doublevcodes

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

We can't get the timezone of the user calling the command, I propose we use the same time/duration converter we have in Python.

This converter accepts durations and ISO date times (Timezone naive) . It may also be in lancebot already, but I can't check right now.

I think discord.Message.created_at is tz aware, is it not?

Bluenix2

[python-discord/bot] Pull request review submitted: #1760 Cross\-channel and deleted messages anti\-spam

Thank you 🦓. Looks good!

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

We can't get the timezone of the user calling the command, I propose we use the same time/duration converter we have in Python.
This converter accepts durations and ISO date times (Timezone naive) . It may also be in lancebot already, but I can't check right now.

I think discord.Message.created_at is tz aware, is it not?

It is tz-aware yes, but that just means that it includes the tzinfo that it's UTC, it does not include the timezone of the invoker.

mbaruh

[python-discord/bot] Issue closed: #622 Utilize a Message Cache for the Antispam Cog

mbaruh

[python-discord/bot] Issue closed: #665 Support Anti\-Spam Checks Across Channels

mbaruh

[python-discord/bot] Issue closed: #1522 Keep deleted messages in cache

mbaruh

[python-discord/bot] Pull request closed: #1760 Cross\-channel and deleted messages anti\-spam

mbaruh

[bot:main] 10 new commits

20aea4f Move max_interval to init - mbaruh
34d7f7c AntiSpam modified to work with cache - mbaruh
e1e104d AntiSpam deletes from all spammed channels - mbaruh
ad3d197 Identify DeletionContext by members, not channels - mbaruh
b4ddc0b Fix MessageCache slicing bugs, improve tests - mbaruh

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1159871995 succeeded.

Actor

mbaruh

Workflow Run

Deploy #414

Commit

697c0da

[regal arch]

mbaruh

[python-discord/bot] Pull request review submitted: #1772 Remove restriction on snowflake command

[odd spire]

[python-discord/bot] Checks Successful on PR: #1772 Remove restriction on snowflake command

GitHub Actions run 1159882460 succeeded.

PR Author

D0rs4n

Workflow Run

Lint & Test #1599

Source Branch

D0rs4n:pr/nostafflake

[regal arch]

mbaruh

[python-discord/bot] Issue closed: #1759 Remove restriction on snowflake command

mbaruh

[python-discord/bot] Pull request closed: #1772 Remove restriction on snowflake command

mbaruh

[bot:main] 3 new commits

26af16e Remove restriction on snowflake command - D0rs4n
dbf09b0 Merge branch 'main' into pr/nostafflake - mbaruh
69495d5 Merge pull request #1772 from D0rs4n/pr/nostaff... - mbaruh

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1159903197 succeeded.

Actor

mbaruh

Workflow Run

Deploy #415

Commit

69495d5

[regal arch]

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #612: Coin Flip Command

@InvisibleOS has stated on discord that they'd like someone else to take over, so I'll do so. Have reassigned the issue accordingly

doublevcodes

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

We can't get the timezone of the user calling the command, I propose we use the same time/duration converter we have in Python.

This converter accepts durations and ISO date times (Timezone naive) . It may also be in lancebot already, but I can't check right now.

I think discord.Message.created_at is tz aware, is it not?

It is tz-aware yes, but that just means that it includes the tzinfo that it's UTC, it does not include the timezone of the invoker....

mbaruh

[python-discord/bot] Pull request review submitted: #1770 Ignore bot mentions in antispam mentions rule

[regal arch]

jchristgit

[python-discord/olli] Issue opened: #13 Expose recent error / warning logs by service as Prometheus metric

this is a great idea

• Joe Banks

[odd spire]

[python-discord/bot] Checks Successful on PR: #1731 Add converter typehints

GitHub Actions run 1159995629 succeeded.

PR Author

Numerlor

Workflow Run

Lint & Test #1601

Source Branch

Numerlor:converter-typehints

[regal arch]

Numerlor

[python-discord/bot] New comment on pull request #1731: Add converter typehints

Noticed TagContentConverter was still around even though tags have been file based for a while now so I removed it in 37804ce14c4aeb322ef772b14e7fe55658f80ebf

[odd spire]

[python-discord/bot] Checks Successful on PR: #1731 Add converter typehints

GitHub Actions run 1160018158 succeeded.

PR Author

Numerlor

Workflow Run

Lint & Test #1602

Source Branch

Numerlor:converter-typehints

[regal arch]

mbaruh

[bot:antispam\-ignore\-bot\-mentions] 26 new commits

66ec867 Allow manual mutes to override auto mutes - MarkKoz
786b690 Display error if overriding mute fails - MarkKoz
8ec6f08 Fix get_active_infraction test - MarkKoz
24e4a9d Remove redundant parameter from pardon_voice_ban - MarkKoz
c84ed0f Avoid sending pardon DM when overriding a mute - MarkKoz

mbaruh

[bot:main] 5 new commits

0199600 Ignore bot mentions in antispam mentions rule - wookie184
7daab91 Fix current tests by using MockMember in mentio... - wookie184
a6121e6 Added some more test cases to ensure bot mentio... - wookie184
c2c4319 Merge branch 'main' into antispam-ignore-bot-me... - mbaruh
37de267 Merge pull request #1770 from python-discord/an... - mbaruh

mbaruh

[python-discord/bot] Pull request closed: #1770 Ignore bot mentions in antispam mentions rule

mbaruh

[python-discord/bot] branch deleted: antispam\-ignore\-bot\-mentions

[odd spire]

[python-discord/bot] Checks Successful on PR: #1770 Ignore bot mentions in antispam mentions rule

GitHub Actions run 1160054237 succeeded.

PR Author

wookie184

Workflow Run

Lint & Test #1603

Source Branch

antispam-ignore-bot-mentions

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1160068192 succeeded.

Actor

mbaruh

Workflow Run

Deploy #416

Commit

37de267

[regal arch]

mbaruh

[python-discord/bot] New comment on pull request #1527: Re\-work clean command to be more efficient, have more features\.

I'll be taking over this PR.

[regal arch]

MarkKoz

[bot:enhance/1683/restrict\-int\-eval] 1 new commit

b6b0525 Enable debug mode by default - MarkKoz

[odd spire]

[python-discord/bot] Checks Successful on PR: #1700 Restrict internal eval command to bot owner when in debug mode

GitHub Actions run 1160129517 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1605

Source Branch

enhance/1683/restrict-int-eval

[regal arch]

TizzySaurus

[sir-lancebot:coinflip\-command] 1 new commit

5f20826 Initial commit (add coinflip command in coinfli... - TizzySaurus

TizzySaurus

[python-discord/sir-lancebot] New branch created: coinflip\-command

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #814 Add coinflip command

Relevant Issues

Closes #612.

Description

Implemented coinflip command within bot/exts/evergreen/coinflip.py.

The command simulates flipping a coin. If a coin side was provided to the command, then the bot states whether the user correctly guessed the side of the flipped coin.

Did you:

• [x] Join the Python Discord Community?
• [x] Read all the comments in this template?
• [x] Ensure there is an issue open, or link relevant discord di...

[odd spire]

[python-discord/sir-lancebot] Checks Failed on PR: #814 Add coinflip command

GitHub Actions run 1160152817 failed.

PR Author

TizzySaurus

Workflow Run

Lint #1249

Source Branch

coinflip-command

[regal arch]

TizzySaurus

[sir-lancebot:coinflip\-command] 2 new commits

4e965fd Add missing docstrings - TizzySaurus
197edcd Add missing blank line after class docstring - TizzySaurus

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #814 Add coinflip command

GitHub Actions run 1160187545 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint #1250

Source Branch

coinflip-command

[regal arch]

TizzySaurus

[sir-lancebot] Branch coinflip\-command was force-pushed to `e58eb7c`

Compare changes

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #814 Add coinflip command

GitHub Actions run 1160201250 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint #1251

Source Branch

coinflip-command

[regal arch]

mbaruh

[python-discord/bot] New review comment on pull request #1630: Kill subdomains from configuration file\.

Looking at the location of our logs currently, it's in staff.pythondiscord.com/bot/logs, not `pythondiscord.com/staff/bot/logs

DARKM3THODZ91

[python-discord/forms-frontend] Fork created: DARKM3THODZ91/forms-frontend

ChrisLovering

[python-discord/bot] Issue opened: #1773 Add mypy to the codebase

I'd like to propose that we add mypy to the codebase and add it to our linting workflow.

The initial PR for this would be a large one, fixing the legacy issues, but from then on it'll be picked up before a PR can even be merged.

There are stubs that we can add as dev dependencies for discord.py and any other deps that we find lacking in the type hinting department.

This issue is mostly for planning for now, as I'd like to get more opinions on this change.

[regal arch]

Objectivitix

[python-discord/sir-lancebot] Issue opened: #815 Quiz command: 30 \- 70 new questions to the Python category

Description

Add 30 to 70 (tbd, we're making the q/a pairs currently as we speak) new question/answer pairs to the Python category. They will range from easier topics such as dunder methods for container classes, to harder and more obscure ones like whether __prepare__ in a metaclass should be an instance, static, or class method.

The subsequent PR, if this issue is approved, will also add some more possible answers to some of the past questions.

We'll do this once in a while to ke...

[regal arch]

Objectivitix

[python-discord/sir-lancebot] Pull request opened: #816 Whitelist \`\.bm\` command in occupied help channels

Relevant Issues

Closes #811

Description

Allows the execution of the .bm command by users in help channels.

Did you:

• [x] Join the Python Discord Community?
• [x] Read all the comments in this template?
• [x] Ensure there is an issue open, or link relevant discord discussions?
• [x] Read and agree to the contributing guidelines?

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #816 Whitelist `.bm` command in occupied help channels

GitHub Actions run 1160452220 succeeded.

PR Author

Objectivitix

Workflow Run

Lint #1252

Source Branch

Objectivitix:patch-1

[regal arch]

Objectivitix

[python-discord/sir-lancebot] New comment on pull request #816: Whitelist \`\.bm\` command in occupied help channels

I would like to expand upon the original issue, but since that needs separate explicit approval I'll put it down here:

Description

I believe categories such as discussion (ID: 356012535780081676) and development (ID: 411199786025484308) should also be whitelisted. The implementation would be simple: adding the two IDs into the whitelist tuple.

[regal arch]

brad90four

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

@Vthechamp22 , how does that sound to you?

brad90four

[python-discord/sir-lancebot] New review comment on pull request #805: 800 \- Real Python search command

It passed flake 8, but I will add it real quick

[odd spire]

[python-discord/sir-lancebot] Checks Failed on PR: #805 800 - Real Python search command

GitHub Actions run 1160550705 failed.

PR Author

brad90four

Workflow Run

Lint #1253

Source Branch

brad90four:800

[python-discord/sir-lancebot] Checks Successful on PR: #805 800 - Real Python search command

GitHub Actions run 1160559182 succeeded.

PR Author

brad90four

Workflow Run

Lint #1254

Source Branch

brad90four:800

[regal arch]

vcokltfre

[python-discord/sir-lancebot] Pull request review submitted: #814 Add coinflip command

vcokltfre

[python-discord/sir-lancebot] New review comment on pull request #814: Add coinflip command

Same as above about capital F

vcokltfre

[python-discord/sir-lancebot] New review comment on pull request #814: Add coinflip command

This looks weird I think, it'd off to have a mention followed by caps (first line) vs a lowercase 'f' ((second line)

vcokltfre

[python-discord/sir-lancebot] New review comment on pull request #814: Add coinflip command

These emojis should probably be in the constants file, not here, in case they are wanted elsewhere/people want to change them locally

vcokltfre

[python-discord/sir-lancebot] Pull request review submitted: #816 Whitelist \`\.bm\` command in occupied help channels

Looks good. I'd also like to voice my support for members being able to use .bm in the other categories mentioned by Objectivix

[regal arch]

Objectivitix

[python-discord/sir-lancebot] New comment on pull request #816: Whitelist \`\.bm\` command in occupied help channels

@vcokltfre I agree. .bm seems like the type of command which we should allow everywhere - perhaps we could even rewrite whitelist_override to be able to accept a boolean parameter everywhere which, when set to True, makes the command available everywhere?

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

I've never given mypy a proper shot before. The one time I tried it I got a bad impression because I was immediately trying to do something it cannot support (defining a JSON type, which is recursive). It's left me with the impression that it may be a burden trying to appease mypy. Anyway, I am open to trying it.

My concern is the type stubs. Do all packages we use have type stubs? Are they all well maintained and up to date? What recourse do we have if something is lacking type stubs or f...

[regal arch]

MarkKoz

[bot] Branch enhance/backend/time\-util\-refactor was force-pushed to `a85104f`

Compare changes

[odd spire]

[python-discord/bot] Checks Successful on PR: #1721 Refactor time utilities

GitHub Actions run 1161088186 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1606

Source Branch

enhance/backend/time-util-refactor

[regal arch]

MarkKoz

[bot:enhance/backend/time\-util\-refactor] 1 new commit

ef09481 Time: put region comments around overloads - MarkKoz

MarkKoz

[python-discord/bot] New review comment on pull request #1721: Refactor time utilities

Done ef09481

[odd spire]

[python-discord/bot] Checks Successful on PR: #1721 Refactor time utilities

GitHub Actions run 1161096928 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1607

Source Branch

enhance/backend/time-util-refactor

[regal arch]

D0rs4n

[python-discord/bot] New comment on issue #1348: Embed helper

I read through the issue, I'm not sure about the consensus on using enums, but I think defining the categories with an enum would look a bit more consistent. Also.. I believe to implement the no-delete "functionality" we should sort of "hand-over" the control to the embed helper, and it'll handle the logic needed to allow the users to delete the message.
Like:

await embed_helper(ctx, no_delete=False,category=embed_categories.ERROR, description="Something went wrong")

That...

[regal arch]

TizzySaurus

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

My concern is the type stubs. Do all packages we use have type stubs? Are they all well maintained and up to date? What recourse do we have if something is lacking type stubs or falls out of date?

To install all the known stubs we can do mypy --install-types. I can't remember from my testing how many this installs but it does install a few.

As for libraries without stubs, we can just not check those libraries by passing --disable-error-code import. We probably also want to ignore ...

TizzySaurus

[sir-lancebot:coinflip\-command] 2 new commits

58c0875 Update message to start with lowercase - TizzySaurus
d2e9bfb Move lemojis into constants.py - TizzySaurus

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #814: Add coinflip command

Agree, lowercase looks more natural so have committed :+1:

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #814 Add coinflip command

GitHub Actions run 1162282706 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint #1255

Source Branch

coinflip-command

[regal arch]

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #814: Add coinflip command

Committed :+1:

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #814: Add coinflip command

Have moved these into constants.py under the Emojis class :+1:

TizzySaurus

[python-discord/bot] Issue opened: #1774 Update nomination messages to display user mention instead of name\#discrim

Exactly what the title says.

@Akarys42 said on Discord that they remember users by the pfp moreso than their name, which I concur with. There's also the fact that some members have nicknames and so displaying the name#discrim can make you think you've nominated the wrong person.

By displaying the mention, we can easily see their pfp + nickname, and if someone really wanted the name#discrim they can still access it.

TizzySaurus

[bot:TizzySaurus\-patch\-1] 1 new commit

5d448f1 Update nomination messages to display user mention - TizzySaurus

TizzySaurus

[python-discord/bot] New branch created: TizzySaurus\-patch\-1

TizzySaurus

[python-discord/bot] Pull request opened: #1775 Update nomination messages to display user mention

Closes #1774.

Messages now use user.mention instead of an implicit str(user).

[odd spire]

[python-discord/bot] Checks Successful on PR: #1775 Update nomination messages to display user mention

GitHub Actions run 1162328605 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1608

Source Branch

TizzySaurus-patch-1

[regal arch]

Akarys42

[python-discord/bot] Pull request review submitted: #1775 Update nomination messages to display user mention

[regal arch]

wookie184

[python-discord/bot] Pull request review submitted: #1775 Update nomination messages to display user mention

Akarys42

[python-discord/bot] Issue closed: #1774 Update nomination messages to display user mention instead of name\#discrim

Akarys42

[python-discord/bot] Pull request closed: #1775 Update nomination messages to display user mention

Akarys42

[bot:main] 2 new commits

5d448f1 Update nomination messages to display user mention - TizzySaurus
58f7982 Merge pull request #1775 from python-discord/Ti... - Akarys42

Akarys42

[python-discord/bot] branch deleted: TizzySaurus\-patch\-1

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1162426644 succeeded.

Actor

Akarys42

Workflow Run

Deploy #417

Commit

58f7982

[regal arch]

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

I'd be interested in working on this, but need to know what approach we'd like to take.

Would it simply be a case of changing has_no_roles_check(*STAFF_ROLES) to has_no_roles(*STAFF_ROLES, partners, python_community), or do we want to add some sort of separate roles-category for this?

Akarys42

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

I'd be interested in working on this, but need to know what approach we'd like to take.

Would it simply be a case of changing has_no_roles_check(*STAFF_ROLES) to has_no_roles(*STAFF_ROLES, partners, python_community), or do we want to add some sort of separate roles-category for this?

What I would do is add the two roles to the existing STAFF_ROLES constant. You can then explicitly list all of those roles except partners and community members in the duck pond cog.

Akarys42

[python-discord/sir-lancebot] New comment on pull request #816: Whitelist \`\.bm\` command in occupied help channels

Hello, thanks for the PR @Objectivitix! We agreed to allow the bookmark command in every channel, please go forth and obliterate the check!

ChrisLovering

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

Hhmm, we may want to add a new constant, that's staff + the two new roles, since the staff roles constant will still be used in some places (duck pond and talent pool)

Akarys42

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

Right, I forgot about talent pool. Let's do that then.

wookie184

[python-discord/sir-lancebot] Issue opened: #817 Limit internal eval command to bot owner

Description

In https://github.com/python-discord/bot/issues/1683 we decided to limit the internal eval command to owners if the bot is in debug mode, it would probably make sense to do a similar thing for sir-lancebot.
We already have a debug constant that seems to default to true
https://github.com/python-discord/sir-lancebot/blob/0a1b7b4bedbb6c19ad572869b57b466adae66b4a/bot/constants.py#L137
So all that needs to be done is add a check to the command, as was done in the Python bot P...

wookie184

[python-discord/bot] Pull request review submitted: #1700 Restrict internal eval command to bot owner when in debug mode

Akarys42

[bot:enhance/1683/restrict\-int\-eval] 175 new commits

fb9cbe4 Create events ext, prepare jams cog for file split - mbaruh
6986600 Move jam channels creation to separate file - mbaruh
d4271b0 More code jam functionality - mbaruh
bc390bc Added command to remove from team - mbaruh
fdc6f23 Fix end command docstring - mbaruh

Akarys42

[python-discord/bot] Pull request review submitted: #1700 Restrict internal eval command to bot owner when in debug mode

Akarys42

[python-discord/bot] Issue closed: #1683 Restrict internal eval command to bot owner when in debug mode

Akarys42

[python-discord/bot] Pull request closed: #1700 Restrict internal eval command to bot owner when in debug mode

Akarys42

[bot:main] 5 new commits

741c0dc Specify DEBUG_MODE via the config file - MarkKoz
14056b3 Restrict internal eval to bot owner when in deb... - MarkKoz
b6b0525 Enable debug mode by default - MarkKoz
6098a47 Merge branch 'main' into enhance/1683/restrict-... - Akarys42
3a6b9d1 Merge pull request #1700 from python-discord/en... - Akarys42

Akarys42

[python-discord/bot] branch deleted: enhance/1683/restrict\-int\-eval

[odd spire]

[python-discord/bot] Checks Successful on PR: #1700 Restrict internal eval command to bot owner when in debug mode

GitHub Actions run 1162498007 succeeded.

PR Author

MarkKoz

Workflow Run

Lint & Test #1610

Source Branch

enhance/1683/restrict-int-eval

[python-discord/bot] Workflow Successful

GitHub Actions run 1162511492 succeeded.

Actor

Akarys42

Workflow Run

Deploy #418

Commit

3a6b9d1

[regal arch]

decorator-factory

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

What are the benefits of adding mypy to the CI?

VikranthMaster

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

@Xithrius No offense would love to Implement but my exams are going on currently..so..sorry 😔

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

What do we want to call the constant? Perhaps STAFF_PARTNERS_COMMUNITY?

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/kubernetes] Checks Successful on PR: #79 Add new bot debug env var to readme

GitHub Actions run 1162561390 succeeded.

PR Author

ChrisLovering

Workflow Run

Lint Kubernetes manifests #153

Source Branch

new-bot-env-var

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1162567074 succeeded.

Actor

Akarys42

Workflow Run

Lint Kubernetes manifests #154

Commit

ebe9f88

[regal arch]

ChrisLovering

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

Probably want to put _ROLES on the end too, for consistency with other constants.

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

True. STAFF_PARTNERS_COMMUNITY_ROLES seems good I think.

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

Although I have just realised I have no clue how to configure constants. I'm assuming it's just a matter of editing the constants.py, or do I need to adjust the default-config.yml too?

ChrisLovering

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

The classes marked with metaclass=YAMLGetter read directly from the yaml file(s).

For this, i think it should be fine to just do STAFF_PARTNERS_COMMUNITY_ROLES = STAFF_ROLES = [Roles.partners, Roles.python_community] after the STAFF_ROLES definition, without changing any of the yaml files.

[regal arch]

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

@ChrisLovering Do we want to allow partners + python community to have member-pings in the !remind command?

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

Also in terms of commits, do we want "Allow partners + python community to use x" for each "x" or just one overall "Allow partners + python community more access"

[regal arch]

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

And do we want to allow partners + python community to use the snowflake command anywhere?

wookie184

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

Do we want to allow partners + python community to have member-pings in the !remind command?

I think that would be fine, although I wouldn't mind.

Also in terms of commits, do we want "Allow partners + python community to use x" for each "x" or just one overall "Allow
partners + python community more access"

I think one overall commit would be good.

And do we want to allow partners + python community to use the snowflake command anywhere?

Sounds fine to allow that.

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

Okay :+1:

I'm doing individual commits right now but can rebase and squash at the end.

[regal arch]

TizzySaurus

[bot:community\-partners\-access] 7 new commits

429ca2a Add constants.STAFF_PARTNERS_COMMUNITY_ROLES - TizzySaurus
2c93e2d Allow partners & members of the python communit... - TizzySaurus
675b961 Allow partners & members of the python communit... - TizzySaurus
5be8cd1 Allow partners & members of the python communit... - TizzySaurus
5998a8e Minor linting fixes - TizzySaurus

TizzySaurus

[python-discord/bot] New branch created: community\-partners\-access

TizzySaurus

[python-discord/bot] Pull request opened: #1776 Give partners and community members more access

Closes #1758.

Partners and community members can now use commands in any channel as well as bypass cooldowns and a few other restrictions, such as the pings in !remind command.

[odd spire]

[python-discord/kubernetes] Checks Successful on PR: #80 Alerts: ignore prestashop

GitHub Actions run 1163247767 succeeded.

PR Author

Akarys42

Workflow Run

Lint Kubernetes manifests #155

Source Branch

alerts/prestani

[regal arch]

TizzySaurus

[bot:community\-partners\-access] 39 new commits

66ec867 Allow manual mutes to override auto mutes - MarkKoz
786b690 Display error if overriding mute fails - MarkKoz
8ec6f08 Fix get_active_infraction test - MarkKoz
24e4a9d Remove redundant parameter from pardon_voice_ban - MarkKoz
c84ed0f Avoid sending pardon DM when overriding a mute - MarkKoz

TizzySaurus

[python-discord/bot] New comment on issue #1758: Python community & partners get same access as staff

bot#1776 is now ready for reviews :+1:

[odd spire]

[python-discord/bot] Checks Failed on PR: #1776 Give partners and community members more access

GitHub Actions run 1163260256 failed.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1612

Source Branch

community-partners-access

[regal arch]

Akarys42

[python-discord/bot] Pull request review submitted: #1776 Give partners and community members more access

Minus the failed lint (you should really set up pre-commit, like, right now), this looks good to me. Thanks!

[odd spire]

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 1163317756 succeeded.

Actor

ChrisLovering

Workflow Run

Lint Kubernetes manifests #156

Commit

da5dcd8

[regal arch]

TizzySaurus

[bot:community\-partners\-access] 2 new commits

f5246e1 Fix linting - TizzySaurus
cf30503 Merge remote-tracking branch 'origin/community-... - TizzySaurus

[odd spire]

[python-discord/bot] Checks Failed on PR: #1776 Give partners and community members more access

GitHub Actions run 1163325163 failed.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1613

Source Branch

community-partners-access

[regal arch]

TizzySaurus

[bot:community\-partners\-access] 1 new commit

8e2f515 Fix linting - TizzySaurus

[odd spire]

[python-discord/bot] Checks Failed on PR: #1776 Give partners and community members more access

GitHub Actions run 1163368605 failed.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1614

Source Branch

community-partners-access

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

What are the benefits of adding mypy to the CI?

To ensure the code conforms to mypy. We can encourage contributors all we want, but ultimately we have no way to enforce that they run mypy before making commits. However, we do have control over CI, so that's where we can enforce it.

TizzySaurus

[bot:community\-partners\-access] 1 new commit

93386c4 Fix tests - TizzySaurus

[odd spire]

[python-discord/bot] Checks Successful on PR: #1776 Give partners and community members more access

GitHub Actions run 1163441515 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1615

Source Branch

community-partners-access

[regal arch]

ChrisLovering

[python-discord/bot] New comment on issue #1348: Embed helper

I'm not sure what problem we're trying to solve here.

Wouldn't we achieve the same thing by just renaming the constants to when they should be used, rather than describing the colour itself? IE constants.Colours.soft_red becomes constants.Colour.error

ChrisLovering

[python-discord/bot] Pull request review submitted: #1776 Give partners and community members more access

Akarys42

[python-discord/bot] Issue closed: #1758 Python community & partners get same access as staff

Akarys42

[python-discord/bot] Pull request closed: #1776 Give partners and community members more access

Akarys42

[bot:main] 13 new commits

429ca2a Add constants.STAFF_PARTNERS_COMMUNITY_ROLES - TizzySaurus
2c93e2d Allow partners & members of the python communit... - TizzySaurus
675b961 Allow partners & members of the python communit... - TizzySaurus
5be8cd1 Allow partners & members of the python communit... - TizzySaurus
5998a8e Minor linting fixes - TizzySaurus

Akarys42

[python-discord/bot] branch deleted: community\-partners\-access

ChrisLovering

[python-discord/bot] Pull request review submitted: #1731 Add converter typehints

[oak estuary]

Python Bot

Connected!

[regal arch]

ChrisLovering

[python-discord/bot] Issue closed: #1730 Monkeypatch discord\.py to understand Annotated typehints

ChrisLovering

[python-discord/bot] Pull request closed: #1731 Add converter typehints

ChrisLovering

[bot:main] 9 new commits

da85add Move all converters to converters.py - Numerlor
dd2c41a Assign converters to their return values during... - Numerlor
8264fda fix wrong name being interpolated - Numerlor
7678982 remove redundant typehints - Numerlor
89db623 Merge remote-tracking branch 'upstream/main' in... - Numerlor

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1163566259 succeeded.

Actor

Akarys42

Workflow Run

Deploy #419

Commit

09daaaa

[python-discord/bot] Checks Successful on PR: #1731 Add converter typehints

GitHub Actions run 1163563235 succeeded.

PR Author

Numerlor

Workflow Run

Lint & Test #1617

Source Branch

Numerlor:converter-typehints

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1163574089 succeeded.

Actor

ChrisLovering

Workflow Run

Deploy #420

Commit

1782cfa

[regal arch]

Kronifer

[python-discord/sir-lancebot] New comment on pull request #699: Cowsay

@ToxicKidz please re-review

D0rs4n

[python-discord/bot] New comment on issue #1348: Embed helper

Yes, but most of times in the code you choose a random reply(ERROR_REPLIES) as well, you set the color, all around the code. Furthermore, making a helper would make it much more easier to generate embeds that could be deleted. (Like mentioned in the issue description)

[regal arch]

Objectivitix

[python-discord/sir-lancebot] New comment on pull request #816: Whitelist \`\.bm\` command in occupied help channels

Alright, thanks @Akarys42! I'm thinking of implementing an everywhere parameter to facilitate future use if another command like this needs to be completely whitelisted - I just need to find the part where the bot checks the channel and sends the rejection embed so I can add a new condition :D

[regal arch]

Xithrius

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

@VikranthMaster Good luck with your exams!

ChrisLovering

[python-discord/bot] New comment on issue #1348: Embed helper

Following discussions in Discord (from [here](#dev-contrib message) down) we have decided this is not something we want to implement in the bot.

When discord.py 2.0 comes around, there will definetely be a use in making a generic ui.View that handles the delete action with a button, that can be used in any Messagable.send() call.

ChrisLovering

[python-discord/bot] Issue closed: #1348 Embed helper

[regal arch]

ventaquil

[python-discord/sir-lancebot] Pull request review submitted: #802 Fix type annotations

Can some explain why sometimes it's import typing, sometimes it's from typing import ... and even sometimes it's import typing as t? 🤔

ventaquil

[python-discord/sir-lancebot] New review comment on pull request #802: Fix type annotations

Cannot use Optional here?

ventaquil

[python-discord/sir-lancebot] New review comment on pull request #802: Fix type annotations

Cannot import Any from typing? 🤔

ventaquil

[python-discord/sir-lancebot] New review comment on pull request #802: Fix type annotations

Cannot we use Optional here?

[regal arch]

mbaruh

[bot:mbaruh\-patch\-1] 1 new commit

ed966d4 Fix antispam looking at wrong messages - mbaruh

mbaruh

[python-discord/bot] New branch created: mbaruh\-patch\-1

mbaruh

[python-discord/bot] Pull request opened: #1777 Fix antispam looking at wrong messages

[odd spire]

[python-discord/bot] Checks Successful on PR: #1777 Fix antispam looking at wrong messages

GitHub Actions run 1164134613 succeeded.

PR Author

mbaruh

Workflow Run

Lint & Test #1619

Source Branch

mbaruh-patch-1

[oak estuary]

Python Bot

Connected!

Python Bot

Connected!

[regal arch]

ChrisLovering

[python-discord/bot] Pull request review submitted: #1777 Fix antispam looking at wrong messages

[night lily]

Sir Lancebot

Connected!

[sullen whale]

Thread Bot

Connected!

[odd spire]

[python-discord/kubernetes] Checks Successful on PR: #92 NSA hardening

GitHub Actions run 1164439407 succeeded.

PR Author

jb3

Workflow Run

Lint Kubernetes manifests #157

Source Branch

jb3/nsa-hardening

[regal arch]

MarkKoz

[python-discord/bot] New comment on pull request #1777: Fix antispam looking at wrong messages

This seems rushed. Can you explain the differences between the sets of messages and the reason for this change?

mbaruh

[python-discord/bot] New comment on pull request #1777: Fix antispam looking at wrong messages

@MarkKoz I erroneously used the wrong set of messages in the cross-channel antispam PR. The one I used is all messages that the predicate looks at to see if there was a violation. The one that needs to be used is the one I use here which is the actual messages that are part of the offense.

mbaruh

[python-discord/bot] New comment on pull request #1777: Fix antispam looking at wrong messages

To put it simply, currently if there's a violation it deletes unrelated messages.

janine9vn

[python-discord/bot] Pull request review submitted: #1777 Fix antispam looking at wrong messages

Didn't do a full test but after looking at this and discussing with you this should now have the intended behavior.

ChrisLovering

[python-discord/bot] Pull request closed: #1777 Fix antispam looking at wrong messages

ChrisLovering

[bot:main] 2 new commits

ed966d4 Fix antispam looking at wrong messages - mbaruh
09b45e6 Merge pull request #1777 from python-discord/mb... - ChrisLovering

ChrisLovering

[python-discord/bot] branch deleted: mbaruh\-patch\-1

MarkKoz

[python-discord/bot] New comment on pull request #1777: Fix antispam looking at wrong messages

Okay this code is confusing because it reassigned relevant_messages to be a different set of messages... I was staring at it for 5 minute and this change seemed wrong until I caught that important detail.

MarkKoz

[python-discord/bot] New comment on pull request #1777: Fix antispam looking at wrong messages

It doesn't help that this comment is inaccurate since it actually returns 3 items, not 2

If it doesn't, it returns a tuple in the form (str, Iterable[discord.Member])

[oak estuary]

Python Bot

Connected!

[odd spire]

[python-discord/bot] Workflow Successful

GitHub Actions run 1164486639 succeeded.

Actor

ChrisLovering

Workflow Run

Deploy #421

Commit

09b45e6

[regal arch]

mbaruh

[python-discord/bot] New comment on pull request #1777: Fix antispam looking at wrong messages

Yeah it took me a bit to understand what's going on there. But the key point is that the messages that are logged were already relevant_messages (line 211), and those were the correct messages, which is probably why it wasn't caught in testing the original PR.

[oak estuary]

Python Bot

Connected!

[regal arch]

VikranthMaster

[python-discord/sir-lancebot] New comment on issue #787: \.epoch command

@VikranthMaster Good luck with your exams! I'll assign this to you now, just be sure to focus on that education!

Thanks :) I will :)

[regal arch]

decorator-factory

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

To ensure the code conforms to mypy

Of course, that's what adding mypy to the CI does. But why do we want the code to strictly conform to mypy?

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

To ensure the code conforms to mypy

Of course, that's what adding mypy to the CI does. But why do we want the code to strictly conform to mypy? That was my question

How do you use mypy? Is there some middle ground between not using it at all and enforcing it in CI? Or are you instead asking why we should be using mypy in any capacity?

[regal arch]

decorator-factory

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

Or are you instead asking why we should be using mypy in any capacity?

Yes, that's what I'm asking. As you mentioned, mypy isn't perfect, and there are issues like missing/outdated/poor type stubs, which could be an obstacle. Therefore I'm asking what benefits it would bring so we can evaluate the pros vs cons.

decorator-factory

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

Perhaps we should also evaluate alternative type checkers, like pyright or pyre?

[regal arch]

TizzySaurus

[python-discord/bot] New comment on issue #1655: add time formats tooltip to the \!remind command

Have just discussed this with @ChrisLovering in #dev-core. The decision was to edit the docstring of both the remind group and remind new command to have the suggested "documentation" of the supported time types.

I'll work on this shortly.

Akarys42

[python-discord/bot] New comment on issue #1482: Mention \#how\-to\-get\-help in default help command\.

I share Mark's and Tizzy's concerns, I don't think the tradeoff is worth it. We won't be implementing this.

Akarys42

[python-discord/bot] Issue closed: #1482 Mention \#how\-to\-get\-help in default help command\.

TizzySaurus

[bot:update\-remind\-help] 1 new commit

2962cc7 Add time units to docstring of !remind and `!... - TizzySaurus

TizzySaurus

[python-discord/bot] New branch created: update\-remind\-help

TizzySaurus

[bot:update\-remind\-help] 1 new commit

0961e1f Add missing backquotes around command invocatio... - TizzySaurus

TizzySaurus

[bot] Branch update\-remind\-help was force-pushed to `506f1d2`

Compare changes

TizzySaurus

[python-discord/bot] Pull request opened: #1778 Add time units and example to docstring of \`\!remind\` and \`\!remind new\`

Closes #1655

As the title says.

Now when the help message for !remind / !remind new is displayed, it'll also show the supported time units with an example invocation.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1778 Add time units and example to docstring of `!remind` and `!remind new`

GitHub Actions run 1166050642 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1621

Source Branch

update-remind-help

[regal arch]

TizzySaurus

[python-discord/bot] New comment on issue #1748: Allow reminders in all channels

This is a good suggestion as it will really improve the usability of the command for the masses. A few points which are open to discussion:

1. In cases where it's not sending it to the same channel, is it feasible to first try to DM before resorting to sending it in #bot-commands? This might get complicated when multiple roles/users are mentioned in the reminder, but note that the feature is limited to Helpers+.
2. It should never send a reminder in a help channel, even if invok...

[regal arch]

vcokltfre

[python-discord/sir-lancebot] Pull request review submitted: #814 Add coinflip command

All looks good!

[regal arch]

wookie184

[python-discord/bot] Pull request review submitted: #1778 Add time units and example to docstring of \`\!remind\` and \`\!remind new\`

The edit_reminder_duration docstring should also be changed to include the new time units.

[regal arch]

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #814 Add coinflip command

This doesn't seem to handle invalid choices properly, would be nice if it gave an error:

wookie184

[python-discord/sir-lancebot] New comment on pull request #816: Whitelist \`\.bm\` command in occupied help channels

I sort of think that if we're thinking of allowing it everywhere that's an indicator it would be better as a feature for Python bot than sir-lancebot, maybe not worth moving though.

RE the everywhere parameter, would adding the everyone role to the whitelist_override be equivalent to that?

[regal arch]

Akarys42

[bot:experiments/akarys/check\-licenses] 1 new commit

4b03a94 CI: check for dependency licenses - Akarys42

Akarys42

[python-discord/bot] New branch created: experiments/akarys/check\-licenses

Akarys42

[python-discord/bot] Pull request opened: #1779 CI: check for dependency licenses

Since our project is licensed under the MIT License, we can't be using any dependencies in our project. This PR adds a step to the CI lint phase that will use pip-licenses to verify that all the installed packages are part of an ALLOWED_LICENSE variable. This variable is currently set to be every license we currently use. We opted to use an allowlist instead of a denylist to make sure that new licenses are reviewed by hand and added to that variable.

[odd spire]

[python-discord/bot] Checks Failed on PR: #1779 CI: check for dependency licenses

GitHub Actions run 1166922192 failed.

PR Author

Akarys42

Workflow Run

Lint & Test #1622

Source Branch

experiments/akarys/check-licenses

[regal arch]

Akarys42

[bot] Branch experiments/akarys/check\-licenses was force-pushed to `b3b9d3f`

Compare changes

[odd spire]

[python-discord/bot] Checks Failed on PR: #1779 CI: check for dependency licenses

GitHub Actions run 1166930265 failed.

PR Author

Akarys42

Workflow Run

Lint & Test #1623

Source Branch

experiments/akarys/check-licenses

[regal arch]

Akarys42

[python-discord/site] Pull request review dismissed: #565 Fix data reviews URL

Hey @ethansocal, thanks a lot for the PR! After internal discussions, we decided to instead use the notion.site link to avoid domain blocks. Sorry 😅

Feel free to apply directly from GitHub or from your computer!

Akarys42

[python-discord/site] Pull request review submitted: #565 Fix data reviews URL

Perfect, thank you!

Akarys42

[python-discord/site] Issue closed: #564 Monthly Data Reviews Link Missing

Akarys42

[python-discord/site] Pull request closed: #565 Fix data reviews URL

Akarys42

[site:main] 3 new commits

65adf37 Fix data reviews URL - ethansocal
b3d7265 Update pydis_site/templates/home/timeline.html - ethansocal
c3cb8c9 Merge pull request #565 from ethansocal/main - Akarys42

[odd spire]

[python-discord/site] Workflow Successful

GitHub Actions run 1167011513 succeeded.

Actor

Akarys42

Workflow Run

Deploy #111

Commit

c3cb8c9

[regal arch]

TizzySaurus

[bot:update\-remind\-help] 1 new commit

fe840ca Add time units to the !remind edit and `!remi... - TizzySaurus

TizzySaurus

[python-discord/bot] New comment on pull request #1778: Add time units and example to docstring of \`\!remind\` and \`\!remind new\`

The edit_reminder_duration docstring should also be changed to include the new time units.

Good catch. Also included it in the edit_reminder_group to keep the behaviour consistent with remind_group.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1778 Add time units and example to docstring of `!remind` and `!remind new`

GitHub Actions run 1167319893 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1624

Source Branch

update-remind-help

[regal arch]

TizzySaurus

[python-discord/sir-lancebot] New comment on pull request #814: Add coinflip command

It does raise an error. I guess it's getting eaten somewhere else?

TizzySaurus

[python-discord/bot] New comment on issue #1427: Place 3 help channels in the available pool

I believe the issues we had with the on_typing have been resolved on Discord's end, and so this is no longer stalled if someone would like to look into it.

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

An advantage is that it provides type safety, which can catch more errors. A disadvantage is that we cannot be lazy with the type annotations (e.g. the callables for decorators).

[regal arch]

wookie184

[python-discord/bot] Pull request review submitted: #1778 Add time units and example to docstring of \`\!remind\` and \`\!remind new\`

LGTM

[regal arch]

wookie184

[python-discord/sir-lancebot] New comment on pull request #814: Add coinflip command

This doesn't seem to handle invalid choices properly, would be nice if it gave an error:

It does raise an error. I guess it's getting eaten somewhere else? I don't know how to fix this.

I'd guess it's because of the Optional, not exactly sure what the neatest thing to do here would be. Returning some object indicating an error and then hand...

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1167757328 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1256

Source Branch

camcaswell:duckduckduckgoose

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1167798300 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1257

Source Branch

camcaswell:duckduckduckgoose

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1167813159 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1258

Source Branch

camcaswell:duckduckduckgoose

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #805 800 - Real Python search command

GitHub Actions run 1167885338 succeeded.

PR Author

brad90four

Workflow Run

Lint #1259

Source Branch

brad90four:800

[regal arch]

TizzySaurus

[sir-lancebot:coinflip\-command] 2 new commits

3d15c39 Fix CoinSide error being suppressed - TizzySaurus
d5139ee General improvements - TizzySaurus

TizzySaurus

[python-discord/sir-lancebot] New comment on pull request #814: Add coinflip command

I'd guess it's because of the Optional, not exactly sure what the neatest thing to do here would be. Returning some object indicating an error and then handling that in the function would probably work but in that case there's no point in using a converter. I feel there should be a better way though...

I've simply gone with the approach of doing = None instead of using Optional, which seems to fix things.

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #814 Add coinflip command

GitHub Actions run 1168037053 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint #1260

Source Branch

coinflip-command

[regal arch]

MarkKoz

[python-discord/bot] Issue opened: #1780 Suppress exceptions for infraction attempts on mods\+

Due to the role hierarchy, the bot cannot infract mods or higher. Currently, this error is caught and handled by the infraction system, but it still logs the exception, causing it to show up on Sentry. A discussion on Discord came to the conclusion that the exception should only be logged if the target user is lower than a mod. The idea is that mods+ is an expected failure, but anything else would be unexpected. The implementation would require hard-coding a condition that the user is not a m...

[odd spire]

[python-discord/sir-lancebot] Checks Successful on PR: #786 Duckduckduckgoose

GitHub Actions run 1168184047 succeeded.

PR Author

camcaswell

Workflow Run

Lint #1261

Source Branch

camcaswell:duckduckduckgoose

[regal arch]

camcaswell

[python-discord/sir-lancebot] New review comment on pull request #786: Duckduckduckgoose

@wookie184 I moved the final scores to a new message sent when the game is over, but left the claimed and missed flights in the initial embed. So as it stands the UI is split into 3 parts:

initial embed: the board and flights that use labels that reference the board
message reactions: solely for incorrect guesses since reactions bury the initial embed faster but these ones are necessary
final message: indicates how the game ends (time/goose/mod) and shows the final scores

Are you good...

[regal arch]

jb3

[site:jb3/collectstatic\-build] 1 new commit

a775366 Run collectstatic in the Docker build process a... - jb3

jb3

[python-discord/site] New branch created: jb3/collectstatic\-build

jb3

[python-discord/site] Pull request opened: #568 Run collectstatic in the Docker build process and disable in production

Don't run collectstatic on container start, run it in the build process!

This bakes all our static files into the Docker image meaning that we don't have to perform writes to site-packages on startup allowing us to remove some volumes from python-discord/kubernetes#92 and have a slightly faster application start up time.

[odd spire]

[python-discord/site] Checks Failed on PR: #568 Run collectstatic in the Docker build process and disable in production

GitHub Actions run 1168335387 failed.

PR Author

jb3

Workflow Run

Lint & Test #420

Source Branch

jb3/collectstatic-build

[regal arch]

jb3

[site] Branch jb3/collectstatic\-build was force-pushed to `ed15b2c`

Compare changes

[odd spire]

[python-discord/site] Checks Successful on PR: #568 Run collectstatic in the Docker build process and disable in production

GitHub Actions run 1168343287 succeeded.

PR Author

jb3

Workflow Run

Lint & Test #421

Source Branch

jb3/collectstatic-build

[regal arch]

MarkKoz

[python-discord/site] New comment on pull request #568: Run collectstatic in the Docker build process and disable in production

Docker image fails to build locally

You have requested to collect static files at the destination
location as specified in your settings:

    /app/staticfiles

This will overwrite existing files!
Are you sure you want to do this?

Type 'yes' to continue, or 'no' to cancel: Traceback (most recent call last):
  File "/app/manage.py", line 198, in <module>
    main()
  File "/app/manage.py", line 194, in main
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/py...

jb3

[site:jb3/collectstatic\-build] 1 new commit

3cb529b Add --noinput and --clear to collectstatic flags - jb3

jb3

[python-discord/site] New comment on pull request #568: Run collectstatic in the Docker build process and disable in production

Interesting, I think interactive mode needs disabling and clear enabling, as we do in the manage.py file. I've pushed a change for that, can you give it a try now?

[odd spire]

[python-discord/site] Checks Successful on PR: #568 Run collectstatic in the Docker build process and disable in production

GitHub Actions run 1168358171 succeeded.

PR Author

jb3

Workflow Run

Lint & Test #422

Source Branch

jb3/collectstatic-build

[regal arch]

MarkKoz

[python-discord/site] Pull request review submitted: #568 Run collectstatic in the Docker build process and disable in production

Yup that fixed it.

[regal arch]

PiggymanXD

[python-discord/bot] Issue opened: #1781 hi

ok

PiggymanXD

[python-discord/bot] Issue closed: #1781 hi

[regal arch]

Akarys42

[python-discord/bot] New comment on issue #1781: hi

Please do not open spam issues

[regal arch]

Akarys42

[python-discord/site] Pull request review submitted: #568 Run collectstatic in the Docker build process and disable in production

Looks like a decent fix to me. I have one pretty much kaizen suggestion before merging.

Akarys42

[python-discord/site] New review comment on pull request #568: Run collectstatic in the Docker build process and disable in production

Right now, due to the verbosity of this command, reloading the server generates about 200 log lines, saying the existing assets have been deleted. I think it is causing more harm than good, so I propose to reduce the verbosity by one.

            call_command("collectstatic", interactive=False, clear=True, verbosity=self.verbosity - 1)

With this suggestion applied, it only generates one log line, Collecting static files..

[regal arch]

TizzySaurus

[python-discord/bot] Issue opened: #1782 Add message link support to \`\!user\`

Requested by @Akarys42.

If a message link is passed to !user, the bot should show the user information of the message author.

TizzySaurus

[bot:user\-message\-link\-support] 1 new commit

78d71f9 Add message link support to !user command - TizzySaurus

TizzySaurus

[python-discord/bot] New branch created: user\-message\-link\-support

TizzySaurus

[python-discord/bot] Pull request opened: #1783 Add message link support to \`\!user\`

Closes #1782.

!user now allows you to pass a message, and the bot will give the user info of the message author.

[odd spire]

[python-discord/bot] Checks Successful on PR: #1783 Add message link support to `!user`

GitHub Actions run 1169441588 succeeded.

PR Author

TizzySaurus

Workflow Run

Lint & Test #1625

Source Branch

user-message-link-support

[regal arch]

Bluenix2

[python-discord/bot] New review comment on pull request #1783: Add message link support to \`\!user\`

Are these changes meant to be part of this PR?

I think you can put them seperately

Bluenix2

[python-discord/bot] Pull request review submitted: #1783 Add message link support to \`\!user\`

TizzySaurus

[python-discord/bot] New review comment on pull request #1783: Add message link support to \`\!user\`

They're not (they're from #1778). I didn't create the branch from main. I'm fixing at the moment.

TizzySaurus

[python-discord/bot] Pull request closed: #1783 Add message link support to \`\!user\`

TizzySaurus

[bot:user\-message\-link\-support] 1 new commit

26268b8 Add message link support to !user command - TizzySaurus