#dev-log

Workflow Run

Lint & Test #107

Source Branch

ks123/nomination/split

regal archBOT Mar 6, 2021, 12:16 PM

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 5 new commits

013ce6d Improve readibility of code, and fix grammar is... - ChrisLovering
67db0d1 Convert method to static as it doesn't use clas... - ChrisLovering
50a344d Fix return type of in_executor. Its return type... - ChrisLovering
ea44e8e Don't return discord.Messages. - ChrisLovering
49ce886 Remove superfluous str cast. - ChrisLovering

odd spireBOT Mar 6, 2021, 12:17 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 627211305 succeeded.

PR Author

Workflow Run

Lint #466

Source Branch

Enforce-image-processing-concurrency

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 627209272 succeeded.

PR Author

Workflow Run

Lint & Test #597

Source Branch

ks123/talentpool/migrate

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 627209275 succeeded.

PR Author

Workflow Run

Lint & Test #598

Source Branch

ks123/talentpool/migrate

regal archBOT Mar 6, 2021, 12:19 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

This is because we want to asynchronously load the gender options file. This task only runs once on start, rather than perdiodically.

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 1 new commit

365a272 Split up complex line. - ChrisLovering

odd spireBOT Mar 6, 2021, 12:21 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 627219058 succeeded.

PR Author

Workflow Run

Lint #467

Source Branch

Enforce-image-processing-concurrency

regal archBOT Mar 6, 2021, 12:22 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

Do you not think have it written like if flag is None is easier to read? As it specifically stating the case in which the if block is running, rather than the inverse.

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

Code looks good, just one issue while testing locally. I think it could be a good idea to have a .wtf list or similar, to output all of the available pages. Maybe one for after the paginator PR in merged.

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Running both .wtf del and .wtf subclass results in the error embed, do these need to be updated?

#

ks129

[bot:ks123/talentpool/migrate] 1 new commit

4532b40 Fix trace logging of nomination 404 - ks129

odd spireBOT Mar 6, 2021, 12:35 PM

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 627238419 succeeded.

PR Author

Workflow Run

Lint & Test #599

Source Branch

ks123/talentpool/migrate

regal archBOT Mar 6, 2021, 12:35 PM

#

ks129

[bot:ks123/talentpool/migrate] 1 new commit

ce5fb70 Fix grammar of nomination cog - ks129

#

ks129

[bot:ks123/talentpool/migrate] 1 new commit

4f7a9fb Use actor mention instead of username in nomina... - ks129

#

ks129

[python-discord/bot] Pull request review submitted: #1445 Migrate talentpool to new API schema

#

ks129

[python-discord/bot] New review comment on pull request #1445: Migrate talentpool to new API schema

This would need to replace it everywhere, so yeah, let's not do this here.

odd spireBOT Mar 6, 2021, 12:37 PM

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 627243029 succeeded.

PR Author

Workflow Run

Lint & Test #601

Source Branch

ks123/talentpool/migrate

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 627243017 succeeded.

PR Author

Workflow Run

Lint & Test #600

Source Branch

ks123/talentpool/migrate

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 627244520 succeeded.

PR Author

Workflow Run

Lint & Test #602

Source Branch

ks123/talentpool/migrate

regal archBOT Mar 6, 2021, 12:47 PM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Maybe I could lower down the certainty check.

#

Shivansh-007

[python-discord/sir-lancebot] New comment on pull request #605: Add WTF Python Command

Code looks good, just one issue while testing locally. I think it could be a good idea to have a .wtf list or similar, to output all of the available pages. Maybe one for after the paginator PR in merged.

Alright will do.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

Well that’s my preference and I find it more readable.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

Oh alright! We can skip both of the requested changes then.

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1449 Use JSON logging in production

Interestingly, some things slip through the JSON formatting (probably because they aren't logged, just straight up warnings/errors, such as not having python-Levenshtein installed), but that's not really important for the bot, just something you'd have to account for on the Loki end.

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1449: Use JSON logging in production

Version lock, please 😜

#

jb3

[bot:json\-logging] 1 new commit

fe5e2ab Version lock JSON logger - jb3

#

jb3

[python-discord/bot] Pull request review submitted: #1449 Use JSON logging in production

#

jb3

[python-discord/bot] New review comment on pull request #1449: Use JSON logging in production

Addressed in fe5e2ab947a8c2123f2856db24d9c6e978adec9d

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1449 Use JSON logging in production

odd spireBOT Mar 6, 2021, 1:08 PM

#

[python-discord/bot] Checks Failed on PR: #1449 Use JSON logging in production

GitHub Actions run 627295058 failed.

PR Author

Workflow Run

Lint & Test #603

Source Branch

json-logging

regal archBOT Mar 6, 2021, 1:08 PM

#

jb3

[python-discord/bot] New comment on pull request #1449: Use JSON logging in production

Hold on, need a Pipfile.lock bump

#

mbaruh

[python-discord/site] Pull request review submitted: #447 Rework nominations

#

jb3

[bot] Branch json\-logging was force-pushed to `477956d`

odd spireBOT Mar 6, 2021, 1:17 PM

#

[python-discord/bot] Checks Successful on PR: #1449 Use JSON logging in production

GitHub Actions run 627305170 succeeded.

PR Author

Workflow Run

Lint & Test #604

Source Branch

json-logging

regal archBOT Mar 6, 2021, 1:17 PM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1449 Use JSON logging in production

One more approval for old time's sake.

#

jb3

[python-discord/bot] Pull request closed: #1449 Use JSON logging in production

#

jb3

[bot:master] 4 new commits

e9bdccf Add JSON logging dependencies - jb3
fd7a693 Use JSON logging when debug mode is disabled - jb3
477956d Version lock JSON logger - jb3
2204412 Merge pull request #1449 from python-discord/js... - jb3

#

jb3

[python-discord/bot] branch deleted: json\-logging

oak estuaryBOT Mar 6, 2021, 1:24 PM

#

Python Bot

Connected!

odd spireBOT Mar 6, 2021, 1:24 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 627321460 succeeded.

Actor

Workflow Run

Deploy #176

Commit

2204412

regal archBOT Mar 6, 2021, 1:41 PM

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #462: Add emojis cog

User no longer seems to be active. If anyone wants to take over, let me know.

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #485: Pride Leader\(pl\)

If anyone would like to pick up this PR, feel free to do so. Author doesn't look to be active anymore.

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #555: Ports LinePaginator from python\-discord bot to fix overflowing line issue

@melodicht will you be fixing up this PR?

regal archBOT Mar 6, 2021, 2:35 PM

#

Xithrius

[python-discord/bot] New comment on pull request #1234: Add timeit eval command

This PR is now available for anyone to take over. Please ping me if you do decide to do so.

#

Xithrius

[python-discord/bot] Pull request review submitted: #1392 Don't fuzzy search for tags when tag is on cooldown

Very good.

odd spireBOT Mar 6, 2021, 2:41 PM

#

[python-discord/bot] Checks Successful on PR: #1392 Don't fuzzy search for tags when tag is on cooldown

GitHub Actions run 627438592 succeeded.

PR Author

Workflow Run

Lint & Test #606

Source Branch

ChrisLovering:Don't-suggest-...

regal archBOT Mar 6, 2021, 2:42 PM

#

Xithrius

[python-discord/bot] Issue closed: #1373 Command suggester wrongly invoked for commands under cooldown

#

Xithrius

[python-discord/bot] Pull request closed: #1392 Don't fuzzy search for tags when tag is on cooldown

#

Xithrius

[bot:master] 4 new commits

085f8ac return true when tag is on cd - ChrisLovering
cc23ad6 Grammar - ChrisLovering
4ab89c5 Merge branch 'master' into Don't-suggest-when-a... - Xithrius
7122481 Merge pull request #1392 from ChrisLovering/Don... - Xithrius

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #165 Bump @typescript\-eslint/eslint\-plugin from 4\.15\.1 to 4\.16\.1

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #165 Bump @typescript\-eslint/eslint\-plugin from 4\.15\.1 to 4\.16\.1

#

HassanAbouelela

[forms-frontend:main] 2 new commits

c236e16 Bump @typescript-eslint/eslint-plugin from 4.15... - dependabot[bot]
7502ff9 Merge pull request #165 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/typescript\-eslint/eslint\-plugin\-4\.16\.1

oak estuaryBOT Mar 6, 2021, 2:45 PM

#

Python Bot

Connected!

odd spireBOT Mar 6, 2021, 2:46 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 627448299 succeeded.

Actor

Workflow Run

Deploy #177

Commit

7122481

regal archBOT Mar 6, 2021, 3:12 PM

#

Xithrius

[python-discord/bot] Pull request review submitted: #1402 Implement showing filterlist entry comment in alerts

It works very well.

#

Xithrius

[bot:ks123/watchlist\-trigger\-reason] 198 new commits

aae8001 Added defcon status notifier - mbaruh
ede6823 Merge branch 'master' into mbaruh/defcon - mbaruh
f23c2e7 Make the cog update even if write to DB fails - mbaruh
f2c8e29 Moved self.enabled update to _defcon_action - mbaruh
76574ad Moved channel topic change to _defcon_action - mbaruh

#

kosayoda

[python-discord/bot] Pull request review submitted: #1402 Implement showing filterlist entry comment in alerts

#

InvisibleOS

[python-discord/sir-lancebot] Issue opened: #612 Coin Flip Command and Rock\-Paper\-Scissors Command

Description

Coin flipping and rock-paper-scissors are very common games that can be really interesting to play, especially on Discord. It would be a good choice to have them on Sir LanceBot, known for its simple but fun and interesting games.

Reasoning

These are simple games that can instantly cure boredom and can also be very engaging at times. It would be used by many on the server and it also deserves to be added along with the other games, such as tic-tac-toe and battleship.
...

#

Xithrius

[python-discord/bot] Issue closed: #1394 Mention the reason on watchlist triggers

#

Xithrius

[python-discord/bot] Pull request closed: #1402 Implement showing filterlist entry comment in alerts

#

Xithrius

[python-discord/bot] branch deleted: ks123/watchlist\-trigger\-reason

#

Xithrius

[bot:master] 8 new commits

81af009 Implement showing filterlist entry comment in a... - ks129
cd0e443 Add missing None reason returns of filters - ks129
480dd04 Rename filter trigger reason from entry command... - ks129
90bba1c Add comments about returning blacklist entry re... - ks129
2268d46 Move reason for guild filtering to footer - ks129

odd spireBOT Mar 6, 2021, 3:15 PM

#

[python-discord/bot] Checks Successful on PR: #1402 Implement showing filterlist entry comment in alerts

GitHub Actions run 627488670 succeeded.

PR Author

Workflow Run

Lint & Test #608

Source Branch

ks123/watchlist-trigger-reason

oak estuaryBOT Mar 6, 2021, 3:19 PM

#

Python Bot

Connected!

odd spireBOT Mar 6, 2021, 3:19 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 627498660 succeeded.

Actor

Workflow Run

Deploy #178

Commit

ded90d5

regal archBOT Mar 6, 2021, 3:23 PM

#

Xithrius

[python-discord/bot] New comment on pull request #1414: Reworked dynamic available help message logic\.

I'm coming back to this, just figuring out Redis things. Should be done relatively soon.

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

The finally also does the trace log indicating the parsing has finished which is quite useful. If there's no way other than add_done_callback to achieve it I think I'd prefer leaving the finally in place and checking None as is done now

regal archBOT Mar 6, 2021, 3:40 PM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #208: Tech Leaders Pride

I will take over PR #485. Thanks

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #158 Bump react\-spinners from 0\.10\.4 to 0\.10\.6

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #158 Bump react\-spinners from 0\.10\.4 to 0\.10\.6

#

HassanAbouelela

[forms-frontend:main] 2 new commits

1096e1c Bump react-spinners from 0.10.4 to 0.10.6 - dependabot[bot]
928c048 Merge pull request #158 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/react\-spinners\-0\.10\.6

#

mbaruh

[bot:master] 1 new commit

a98ecbf Filtering hotfix - mbaruh

odd spireBOT Mar 6, 2021, 3:45 PM

#

[python-discord/bot] Workflow Failed

GitHub Actions run 627542086 failed.

Actor

Workflow Run

Lint & Test #610

Commit

a98ecbf

regal archBOT Mar 6, 2021, 3:47 PM

#

mbaruh

[bot:master] 1 new commit

8f1ef21 Remove trailing whitespace - mbaruh

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #154 Bump @types/react from 17\.0\.1 to 17\.0\.2

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #154 Bump @types/react from 17\.0\.1 to 17\.0\.2

#

HassanAbouelela

[forms-frontend:main] 2 new commits

dea045c Bump @types/react from 17.0.1 to 17.0.2 - dependabot[bot]
956fa9d Merge pull request #154 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/types/react\-17\.0\.2

oak estuaryBOT Mar 6, 2021, 3:50 PM

#

Python Bot

Connected!

odd spireBOT Mar 6, 2021, 3:51 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 627551057 succeeded.

Actor

Workflow Run

Deploy #180

Commit

8f1ef21

regal archBOT Mar 6, 2021, 3:52 PM

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #168 Bump @testing\-library/user\-event from 12\.7\.2 to 12\.8\.1

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #168 Bump @testing\-library/user\-event from 12\.7\.2 to 12\.8\.1

#

HassanAbouelela

[forms-frontend:main] 2 new commits

c01afa5 Bump @testing-library/user-event from 12.7.2 to... - dependabot[bot]
ca5ab6d Merge pull request #168 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/testing\-library/user\-event\-12\.8\.1

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #164 Bump @typescript\-eslint/parser from 4\.15\.0 to 4\.16\.1

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #164 Bump @typescript\-eslint/parser from 4\.15\.0 to 4\.16\.1

#

HassanAbouelela

[forms-frontend:main] 2 new commits

d45fb2b Bump @typescript-eslint/parser from 4.15.0 to 4... - dependabot[bot]
362c129 Merge pull request #164 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/typescript\-eslint/parser\-4\.16\.1

regal archBOT Mar 6, 2021, 4:16 PM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on pull request #485: Pride Leader\(pl\)

I have taken over this PR and will be opening a new one, mentioning changes requested here.

We can close this one.

regal archBOT Mar 6, 2021, 5:16 PM

#

kosayoda

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

kosayoda

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Our version works a lot better, the arrow version is clunky and not customizable.

regal archBOT Mar 6, 2021, 6:42 PM

#

SuperMaZingCoder

[python-discord/sir-lancebot] Pull request review submitted: #586 Implemented youtube command

#

SuperMaZingCoder

[python-discord/sir-lancebot] New review comment on pull request #586: Implemented youtube command

@decorator-factory As it's been a bit since I've worked on this, were we thinking about making the request, and if it fails, just tell the user "Something went wrong!"

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #170 Bump eslint from 7\.20\.0 to 7\.21\.0

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #170 Bump eslint from 7\.20\.0 to 7\.21\.0

#

HassanAbouelela

[python-discord/forms-frontend] Pull request reopened: #170 Bump eslint from 7\.20\.0 to 7\.21\.0

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #170 Bump eslint from 7\.20\.0 to 7\.21\.0

#

HassanAbouelela

[forms-frontend:main] 2 new commits

6af442e Bump eslint from 7.20.0 to 7.21.0 - dependabot[bot]
54158e6 Merge pull request #170 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/eslint\-7\.21\.0

#

jb3

[forms-frontend:dependabot/npm\_and\_yarn/husky\-5\.0\.9] 1 new commit

95509ee Set pre-commit to be executable - jb3

regal archBOT Mar 6, 2021, 7:14 PM

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #167 Bump typescript from 4\.1\.5 to 4\.2\.3

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #167 Bump typescript from 4\.1\.5 to 4\.2\.3

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/typescript\-4\.2\.3

#

HassanAbouelela

[forms-frontend:main] 2 new commits

360f490 Bump typescript from 4.1.5 to 4.2.3 - dependabot[bot]
2939d37 Merge pull request #167 from python-discord/dep... - HassanAbouelela

#

jb3

[python-discord/forms-frontend] Pull request review submitted: #134 Bump husky from 4\.3\.8 to 5\.0\.9

#

jb3

[python-discord/forms-frontend] Pull request closed: #134 Bump husky from 4\.3\.8 to 5\.0\.9

#

jb3

[forms-frontend:main] 4 new commits

be4771b Bump husky from 4.3.8 to 5.0.9 - dependabot[bot]
ce99800 Migrate Husky To v5 - HassanAbouelela
95509ee Set pre-commit to be executable - jb3
376520d Merge pull request #134 from python-discord/dep... - jb3

#

jb3

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/husky\-5\.0\.9

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #166 Bump @sentry/react from 6\.2\.0 to 6\.2\.1

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #166 Bump @sentry/react from 6\.2\.0 to 6\.2\.1

#

HassanAbouelela

[forms-frontend:main] 2 new commits

074cde8 Bump @sentry/react from 6.2.0 to 6.2.1 - dependabot[bot]
d0ae2ac Merge pull request #166 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/sentry/react\-6\.2\.1

#

jb3

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

We can probably drop the Backend here, maybe a bit pedantic though.

        cookie = request.cookies.get("token")

#

jb3

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

This should be above AuthorizeResponse and AuthorizeRequest.

#

jb3

[python-discord/forms-backend] Pull request review submitted: #58 Redesign Authentication Process

A few minor things. Looks good otherwise.

#

jb3

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

Linebreak for clarity.


if not constants.PRODUCTION:

#

HassanAbouelela

[forms-backend:token\-expiry] 1 new commit

0215429 Renames Token To token

HassanAbouelela

odd spireBOT Mar 6, 2021, 7:44 PM

#

[python-discord/forms-backend] Checks Successful on PR: #58 Redesign Authentication Process

GitHub Actions run 627940535 succeeded.

PR Author

Workflow Run

Forms Backend #246

Source Branch

token-expiry

regal archBOT Mar 6, 2021, 7:49 PM

#

HassanAbouelela

[forms-backend:token\-expiry] 1 new commit

ca73008 Formats Authorize File - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #58 Redesign Authentication Process

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

Addressed in ca73008.

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #58 Redesign Authentication Process

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

Addressed in ca73008.

odd spireBOT Mar 6, 2021, 7:50 PM

#

[python-discord/forms-backend] Checks Successful on PR: #58 Redesign Authentication Process

GitHub Actions run 627948507 succeeded.

PR Author

Workflow Run

Forms Backend #247

Source Branch

token-expiry

regal archBOT Mar 6, 2021, 7:51 PM

#

jb3

[python-discord/forms-backend] Pull request review submitted: #58 Redesign Authentication Process

:shipit::shipit::shipit::shipit::shipit::shipit:

#

jb3

[forms-backend:token\-expiry] 4 new commits

3293927 Bump uvicorn from 0.13.3 to 0.13.4 - dependabot[bot]
f15dc34 Merge branch 'main' into dependabot/pip/uvicorn... - HassanAbouelela
715ef65 Merge pull request #62 from python-discord/depe... - HassanAbouelela
7b4a47c Merge branch 'main' into token-expiry - jb3

odd spireBOT Mar 6, 2021, 7:52 PM

#

[python-discord/forms-backend] Checks Successful on PR: #58 Redesign Authentication Process

GitHub Actions run 627950993 succeeded.

PR Author

Workflow Run

Forms Backend #248

Source Branch

token-expiry

regal archBOT Mar 6, 2021, 7:54 PM

#

jb3

[python-discord/forms-backend] Pull request closed: #58 Redesign Authentication Process

#

jb3

[forms-backend:main] 15 new commits

7c01270 Adds Production Constant - HassanAbouelela
7a16a6b Adds Token Refresh Route - HassanAbouelela
10a2afb Refreshes User Data On Form Submit - HassanAbouelela
839525e Remove AuthorizationHeaders Class - HassanAbouelela
423a1bd Adds CORS Rules - HassanAbouelela

#

jb3

[python-discord/forms-backend] branch deleted: token\-expiry

#

jb3

[python-discord/forms-frontend] Pull request review submitted: #156 Fixes Broken Links To Assets

#

jb3

[python-discord/forms-frontend] Pull request closed: #156 Fixes Broken Links To Assets

#

jb3

[forms-frontend:main] 2 new commits

3dece70 Fixes Broken Links To Assets - HassanAbouelela
9c0f168 Merge pull request #156 from python-discord/fix... - jb3

#

jb3

[python-discord/forms-frontend] branch deleted: fix\-broken\-links

odd spireBOT Mar 6, 2021, 7:57 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 627953675 succeeded.

Actor

Workflow Run

Forms Backend #249

Commit

0f363c2

regal archBOT Mar 6, 2021, 7:58 PM

#

jb3

[python-discord/forms-frontend] Pull request review submitted: #173 Bump @swc/core from 1\.2\.47 to 1\.2\.50

#

jb3

[python-discord/forms-frontend] Pull request closed: #173 Bump @swc/core from 1\.2\.47 to 1\.2\.50

#

jb3

[forms-frontend:main] 2 new commits

e11d2e2 Bump @swc/core from 1.2.47 to 1.2.50 - dependabot[bot]
d705756 Merge pull request #173 from python-discord/dep... - jb3

#

jb3

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/swc/core\-1\.2\.50

regal archBOT Mar 6, 2021, 8:19 PM

#

HassanAbouelela

[forms-backend:main] 1 new commit

013ea90 Sets Token Cookie To Same Site To Lax - HassanAbouelela

#

HassanAbouelela

[forms-frontend:discord\-oauth] 1 new commit

b915ce2 Set Username Expiry To Permanent - HassanAbouelela

odd spireBOT Mar 6, 2021, 8:21 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 627990854 succeeded.

Actor

Workflow Run

Forms Backend #250

Commit

013ea90

regal archBOT Mar 6, 2021, 9:05 PM

#

HassanAbouelela

[forms-backend:main] 1 new commit

b2ad14a Revert "Sets Token Cookie To Same Site To Lax" - HassanAbouelela

odd spireBOT Mar 6, 2021, 9:07 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628058890 succeeded.

Actor

Workflow Run

Forms Backend #251

Commit

b2ad14a

regal archBOT Mar 6, 2021, 9:08 PM

#

HassanAbouelela

[forms-backend:dynamic\-token\-origin] 1 new commit

2e5b5fe Makes Helper To Handle Token SameSite Logic - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] New branch created: dynamic\-token\-origin

#

HassanAbouelela

[python-discord/forms-backend] Pull request opened: #68 Makes Helper To Handle Token SameSite Logic

This PR fixes problems with token security on deploy previews.

The same site attribute would fail on preview branches, as the backend (hosted on the main python discord site), and the request origin (CF or Netlify) were different. This PR simply bypasses that, by setting same site to None on the preview branches.

odd spireBOT Mar 6, 2021, 9:11 PM

#

[python-discord/forms-backend] Checks Successful on PR: #68 Makes Helper To Handle Token SameSite Logic

GitHub Actions run 628068144 succeeded.

PR Author

Workflow Run

Forms Backend #252

Source Branch

dynamic-token-origin

regal archBOT Mar 6, 2021, 9:14 PM

#

HassanAbouelela

[forms-backend] Branch dynamic\-token\-origin was force-pushed to `5bab391`

odd spireBOT Mar 6, 2021, 9:15 PM

#

[python-discord/forms-backend] Checks Successful on PR: #68 Makes Helper To Handle Token SameSite Logic

GitHub Actions run 628075035 succeeded.

PR Author

Workflow Run

Forms Backend #253

Source Branch

dynamic-token-origin

regal archBOT Mar 6, 2021, 9:19 PM

#

kwzrd

[python-discord/branding] Issue opened: #127 Create Easter themed banner

The Easter season currently lacks a banner asset.

For a simple solution, the contribution can simply adapt the Evergreen banner and apply the colours used by the Easter logo.

However, there's plenty of room for creativity. For example, the banner could incorporate usual Easter motives. :rabbit: :egg: :chocolate_bar:

Feel fr...

#

kwzrd

[python-discord/branding] Issue opened: #128 Create New Year's themed banner

The New Year event currently lacks a banner asset.

For a simple solution, the contribution can simply adapt the Evergreen banner, use the New Year icon, and apply its colours.

More ambitious contributions could incorporate usual motives of New ...

#

jb3

[python-discord/forms-backend] Pull request review submitted: #68 Fixes SameSite For Deploy Previews

#

jb3

[python-discord/forms-backend] Pull request closed: #68 Fixes SameSite For Deploy Previews

#

jb3

[forms-backend:main] 2 new commits

5bab391 Makes Helper To Handle Token SameSite Logic - HassanAbouelela
606db35 Merge pull request #68 from python-discord/dyna... - jb3

#

jb3

[python-discord/forms-backend] branch deleted: dynamic\-token\-origin

odd spireBOT Mar 6, 2021, 9:23 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628085898 succeeded.

Actor

Workflow Run

Forms Backend #254

Commit

606db35

regal archBOT Mar 6, 2021, 9:27 PM

#

swfarnsworth

[bot:swfarnsworth/infraction\_message] 1 new commit

96a369c Made multiline concatenated string conform to a... - swfarnsworth

#

swfarnsworth

[bot:swfarnsworth/infraction\_message] 108 new commits

aae8001 Added defcon status notifier - mbaruh
ede6823 Merge branch 'master' into mbaruh/defcon - mbaruh
f23c2e7 Make the cog update even if write to DB fails - mbaruh
f2c8e29 Moved self.enabled update to _defcon_action - mbaruh
76574ad Moved channel topic change to _defcon_action - mbaruh

odd spireBOT Mar 6, 2021, 9:29 PM

#

[python-discord/bot] Checks Successful on PR: #1435 Instructions to dispute an infraction vary by infraction type.

GitHub Actions run 628095536 succeeded.

PR Author

swfarnsworth

Workflow Run

Lint & Test #612

Source Branch

swfarnsworth/infraction_message

#

[python-discord/bot] Checks Successful on PR: #1435 Instructions to dispute an infraction vary by infraction type.

GitHub Actions run 628095882 succeeded.

PR Author

swfarnsworth

Workflow Run

Lint & Test #613

Source Branch

swfarnsworth/infraction_message

regal archBOT Mar 6, 2021, 9:38 PM

#

HassanAbouelela

[forms-backend:main] 1 new commit

8811959 Fixes Domain URL On Token Cookie - HassanAbouelela

odd spireBOT Mar 6, 2021, 9:40 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628112835 succeeded.

Actor

Workflow Run

Forms Backend #255

Commit

8811959

regal archBOT Mar 6, 2021, 9:41 PM

#

HassanAbouelela

[forms-backend:main] 1 new commit

311a58b Corrects Domain On Token Cookie - HassanAbouelela

odd spireBOT Mar 6, 2021, 9:44 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628118810 succeeded.

Actor

Workflow Run

Forms Backend #256

Commit

311a58b

regal archBOT Mar 6, 2021, 9:44 PM

#

HassanAbouelela

[forms-backend:main] 1 new commit

8539676 Corrects Domain On Token Cookie - HassanAbouelela

odd spireBOT Mar 6, 2021, 9:46 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628122810 succeeded.

Actor

Workflow Run

Forms Backend #257

Commit

8539676

regal archBOT Mar 6, 2021, 9:46 PM

#

HassanAbouelela

[forms-frontend:discord\-oauth] 1 new commit

9f04d5f Fixes Return Home Button Centering - HassanAbouelela

#

kwzrd

[python-discord/branding] Pull request opened: #129 Restructure event directories

Closes #123.

This is a draft PR to implement the changes proposed in #123. I will make an attempt to keep the description here an accurate representation of my progress.

I may prefer to keep this in draft status until I have a functioning implementation Python-side, in case I realize that the structure needs to change in order to make things easier on the other side. In the dev environment Python can target the source branch so there's no rush to merge this.

For meta.md files I'm p...

#

HassanAbouelela

[forms-backend:main] 1 new commit

8ef22e9 Switches Forwarded Protocol Header - HassanAbouelela

odd spireBOT Mar 6, 2021, 9:57 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628137933 succeeded.

Actor

Workflow Run

Forms Backend #258

Commit

8ef22e9

oak estuaryBOT Mar 6, 2021, 10:33 PM

#

Python Bot

Connected!

regal archBOT Mar 6, 2021, 11:00 PM

#

mbaruh

[site:mbaruh/channel\-activity] 1 new commit

4f9c088 Add route to get a member's data for helper review - mbaruh

#

mbaruh

[python-discord/site] New branch created: mbaruh/channel\-activity

#

mbaruh

[site:mbaruh/channel\-activity] 1 new commit

d2690bb Amend top_channel_activity return type - mbaruh

#

mbaruh

[python-discord/site] Pull request opened: #451 WIP: Add route to get a member's data for helper review

Added route for getting a user's join date, total messages, and top 3 channels by activity.

This information will be used to auto-review nominees.

Thank you @jb3 for the query, and everyone who helped me set-up metricity.

[ ] Add relevant tests.

odd spireBOT Mar 6, 2021, 11:08 PM

#

[python-discord/site] Checks Failed on PR: #451 WIP: Add route to get a member's data for helper review

GitHub Actions run 628246039 failed.

PR Author

Workflow Run

Lint & Test #108

Source Branch

mbaruh/channel-activity

regal archBOT Mar 6, 2021, 11:39 PM

#

mbaruh

[site:mbaruh/channel\-activity] 1 new commit

3468d12 Added test for metricity-review-data - mbaruh

odd spireBOT Mar 6, 2021, 11:41 PM

#

[python-discord/site] Checks Failed on PR: #451 WIP: Add route to get a member's data for helper review

GitHub Actions run 628297232 failed.

PR Author

Workflow Run

Lint & Test #109

Source Branch

mbaruh/channel-activity

regal archBOT Mar 6, 2021, 11:46 PM

#

mbaruh

[site:mbaruh/channel\-activity] 1 new commit

66047f0 Test metricity-review-data when user doesn't exist - mbaruh

odd spireBOT Mar 6, 2021, 11:49 PM

#

[python-discord/site] Checks Successful on PR: #451 WIP: Add route to get a member's data for helper review

GitHub Actions run 628309095 succeeded.

PR Author

Workflow Run

Lint & Test #110

Source Branch

mbaruh/channel-activity

regal archBOT Mar 7, 2021, 12:05 AM

#

HassanAbouelela

[forms-backend:main] 1 new commit

99e82b5 Corrects Token Cookie Domain - HassanAbouelela

odd spireBOT Mar 7, 2021, 12:07 AM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628335263 succeeded.

Actor

Workflow Run

Forms Backend #259

Commit

99e82b5

regal archBOT Mar 7, 2021, 12:17 AM

#

HassanAbouelela

[forms-frontend:main] 1 new commit

df35009 Fixes Radio Button Rounding - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #169 Bump webpack from 5\.23\.0 to 5\.24\.3

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #169 Bump webpack from 5\.23\.0 to 5\.24\.3

#

HassanAbouelela

[forms-frontend:main] 2 new commits

5d46690 Bump webpack from 5.23.0 to 5.24.3 - dependabot[bot]
f64d2ff Merge pull request #169 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/webpack\-5\.24\.3

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #171 Bump copy\-webpack\-plugin from 7\.0\.0 to 8\.0\.0

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #171 Bump copy\-webpack\-plugin from 7\.0\.0 to 8\.0\.0

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/copy\-webpack\-plugin\-8\.0\.0

#

HassanAbouelela

[forms-frontend:main] 2 new commits

4b6bada Bump copy-webpack-plugin from 7.0.0 to 8.0.0 - dependabot[bot]
0231f9c Merge pull request #171 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] New comment on pull request #172: Bump husky from 4\.3\.8 to 5\.1\.3

@dependabot rebase

#

HassanAbouelela

[forms-frontend:dependabot/npm\_and\_yarn/husky\-5\.1\.3] 1 new commit

bad36a3 Removes Pre Commit Step - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #172 Bump husky from 4\.3\.8 to 5\.1\.3

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #172 Bump husky from 4\.3\.8 to 5\.1\.3

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #172 Bump husky from 4\.3\.8 to 5\.1\.3

#

HassanAbouelela

[forms-frontend:main] 3 new commits

f2c8a1c Bump husky from 4.3.8 to 5.1.3 - dependabot[bot]
bad36a3 Removes Pre Commit Step - HassanAbouelela
691457c Merge pull request #172 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/husky\-5\.1\.3

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #174 Bump workbox\-webpack\-plugin from 6\.1\.0 to 6\.1\.1

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #174 Bump workbox\-webpack\-plugin from 6\.1\.0 to 6\.1\.1

#

HassanAbouelela

[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/workbox\-webpack\-plugin\-6\.1\.1

#

HassanAbouelela

[forms-frontend:main] 2 new commits

7d48129 Bump workbox-webpack-plugin from 6.1.0 to 6.1.1 - dependabot[bot]
ad212a9 Merge pull request #174 from python-discord/dep... - HassanAbouelela

regal archBOT Mar 7, 2021, 1:15 AM

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #66 Bump httpx from 0\.16\.1 to 0\.17\.0

#

HassanAbouelela

[forms-frontend:discord\-oauth] 57 new commits

be4771b Bump husky from 4.3.8 to 5.0.9 - dependabot[bot]
ce99800 Migrate Husky To v5 - HassanAbouelela
dafc38e Bump html-webpack-plugin from 5.0.0 to 5.1.0 - dependabot[bot]
941c2b0 Bump eslint from 7.19.0 to 7.20.0 - dependabot[bot]
3563486 Bump @types/node from 14.14.25 to 14.14.30 - dependabot[bot]

#

HassanAbouelela

[forms-backend:dependabot/pip/httpx\-0\.17\.0] 25 new commits

7c01270 Adds Production Constant - HassanAbouelela
7a16a6b Adds Token Refresh Route - HassanAbouelela
10a2afb Refreshes User Data On Form Submit - HassanAbouelela
839525e Remove AuthorizationHeaders Class - HassanAbouelela
423a1bd Adds CORS Rules - HassanAbouelela

odd spireBOT Mar 7, 2021, 1:21 AM

#

[python-discord/forms-backend] Checks Successful on PR: #66 Bump httpx from 0.16.1 to 0.17.0

GitHub Actions run 628450075 succeeded.

PR Author

Workflow Run

Forms Backend #260

Source Branch

dependabot/pip/httpx-0.17.0

regal archBOT Mar 7, 2021, 1:21 AM

#

HassanAbouelela

[python-discord/forms-backend] Pull request closed: #66 Bump httpx from 0\.16\.1 to 0\.17\.0

#

HassanAbouelela

[forms-backend:main] 3 new commits

7f25b19 Bump httpx from 0.16.1 to 0.17.0 - dependabot[bot]
9b47639 Merge branch 'main' into dependabot/pip/httpx-0... - HassanAbouelela
68190f7 Merge pull request #66 from python-discord/depe... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] branch deleted: dependabot/pip/httpx\-0\.17\.0

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #67 Bump pydantic from 1\.7\.3 to 1\.8\.1

#

HassanAbouelela

[python-discord/forms-backend] Pull request closed: #67 Bump pydantic from 1\.7\.3 to 1\.8\.1

#

HassanAbouelela

[forms-backend:main] 2 new commits

63d41c3 Bump pydantic from 1.7.3 to 1.8.1 - dependabot[bot]
9846c93 Merge pull request #67 from python-discord/depe... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] branch deleted: dependabot/pip/pydantic\-1\.8\.1

odd spireBOT Mar 7, 2021, 1:24 AM

#

[python-discord/forms-backend] Checks Successful on PR: #67 Bump pydantic from 1.7.3 to 1.8.1

GitHub Actions run 628457519 succeeded.

PR Author

Workflow Run

Forms Backend #262

Source Branch

dependabot/pip/pydantic-...

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628455437 succeeded.

Actor

Workflow Run

Forms Backend #261

Commit

68190f7

regal archBOT Mar 7, 2021, 1:27 AM

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #69 Bump flake8\-annotations from 2\.5\.0 to 2\.6\.0

odd spireBOT Mar 7, 2021, 1:28 AM

#

[python-discord/forms-backend] Checks Successful on PR: #69 Bump flake8-annotations from 2.5.0 to 2.6.0

GitHub Actions run 628462585 succeeded.

PR Author

Workflow Run

Forms Backend #264

Source Branch

dependabot/pip/flake8-an...

regal archBOT Mar 7, 2021, 1:28 AM

#

HassanAbouelela

[python-discord/forms-backend] Pull request closed: #69 Bump flake8\-annotations from 2\.5\.0 to 2\.6\.0

#

HassanAbouelela

[forms-backend:main] 2 new commits

e3995a4 Bump flake8-annotations from 2.5.0 to 2.6.0 - dependabot[bot]
167b87f Merge pull request #69 from python-discord/depe... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] branch deleted: dependabot/pip/flake8\-annotations\-2\.6\.0

odd spireBOT Mar 7, 2021, 1:28 AM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628459886 succeeded.

Actor

Workflow Run

Forms Backend #263

Commit

9846c93

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 628466118 succeeded.

Actor

https://github.com/python-discord/sir-lancebot/pull/462#discussion_r588906493

Workflow Run

Forms Backend #265

Commit

167b87f

regal archBOT Mar 7, 2021, 1:37 AM

#

Shivansh-007

[python-discord/bot] New comment on pull request #1234: Add timeit eval command

Shouldn’t this be part of python-discord/snekbox rather than breaking into the user code and appending few lines to it or making two calls?

odd spireBOT Mar 7, 2021, 4:01 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #462 Add emojis cog

GitHub Actions run 628695157 succeeded.

PR Author

AtieP

Workflow Run

Lint #468

Source Branch

AtieP:master

regal archBOT Mar 7, 2021, 4:03 AM

#

kosayoda

[python-discord/sir-lancebot] New comment on pull request #462: Add emojis cog

Emoji related commands are now under the same cog+command group, emoji.

.emojicount is now .emoji count

Emoji information is now .emoji info, and the embed is changed slightly.

.emoji brings up the help, and .emoji <emoji> is a shortcut to `.emoji in...

regal archBOT Mar 7, 2021, 4:26 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Do you propose to just wrap it whole in the symbol_get_event? I suppose it would make it less likely for race conditions to occur in future changes even if it should be safe now

regal archBOT Mar 7, 2021, 5:36 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

regal archBOT Mar 7, 2021, 7:15 AM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

I don't think this comment is needed.

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Arrow library has humanize() function which can do this.

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Is overwriting the import discord.Emoji.

#

scragly

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

scragly

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

I haven't looked into the differences so this isn't my opinion on it, but I noticed this touches a previously reviewed aspect, which you can find kosa's response to here:

Our version works a lot better, the arrow version is clunky and not customizable.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Alright! Didn't see the earlier reviews.

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

If the user doesn't input a name for this argument, emoji will be explicitly None. I think it's better to say that's what we're checking for.

#

scragly

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Titles shouldn't end in periods, it's unconventional unless it's a fully structured sentence.

#

scragly

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Alright! Then it is meant for the other parts of the code. There are 2-3 cases.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Well if emoji: is the same as if emoji is not None:. And according to me if emoji: seems the better way

#

scragly

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

scragly

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Let's avoid arguing over code style opinions unless the style is clearly defined in our projects.

Since both works, and there's not really an explicit bias in our projects other than a slight lean towards "explicit is better than implicit", there's no need to request a change for this.

#

Xithrius

[bot:pypi\-url\-formatter\-patch] 12 new commits

0b11d7d Add truncate_message util - gustavwilliam
e1d269d Add function to DM users when opening help channel - gustavwilliam
e6483d6 Add green question mark to default config - gustavwilliam
e34ea2f Send DM when user claims help channel - gustavwilliam
bb9e56c Update embed field title to be more formal - gustavwilliam

#

scragly

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

scragly

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

I had a look over the code but I'm unable to see more than 1 string that may require a period to be added.

If you meant for each of the list items in the .emoji info embed, they're not really at the level of a fully constructed sentence either. The closest may be the Created line due to humanisation, but I think it's too ambiguous to enforce and would clash with the rest of the output as it would be the only line to do so. Better to just leave it in my opinion.

If there was any other...

#

scragly

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

scragly

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Actually on a detailed look, it appears that even that one I noticed isn't part of the diff here, instead looks to be from previous commits, so there may be more from code outside of the range I'm reading over.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Not part of this PR (5th one is part of this PR). But will be good if it would be done as they part of the emoji command:

#

Xithrius

[python-discord/bot] Pull request opened: #1450 Only allow some characters within a request URL to PyPi\.

If someone spams a bunch of characters, we don't want to send a request to PyPi with a bunch of gibberish. This also protects against injections (if possible, if any).

Some examples of cases with illegal characters within them:

#

Xithrius

[bot:pypi\-url\-formatter\-patch] 1 new commit

b78597e Undone grammer. - Xithrius

#

Xithrius

[bot] Branch pypi\-url\-formatter\-patch was force-pushed to `7857dde`

odd spireBOT Mar 7, 2021, 7:51 AM

#

[python-discord/bot] Checks Successful on PR: #1450 Only allow some characters within a request URL to PyPi.

GitHub Actions run 629040521 succeeded.

PR Author

Workflow Run

Lint & Test #614

Source Branch

pypi-url-formatter-patch

regal archBOT Mar 7, 2021, 7:51 AM

#

Xithrius

[python-discord/bot] New comment on pull request #1450: Only allow some characters within a request URL to PyPi\.

There are some changes from a different branch on here. Fixing.

odd spireBOT Mar 7, 2021, 7:51 AM

#

[python-discord/bot] Checks Successful on PR: #1450 Only allow some characters within a request URL to PyPi.

GitHub Actions run 629041225 succeeded.

PR Author

Workflow Run

Lint & Test #615

Source Branch

pypi-url-formatter-patch

#

[python-discord/bot] Checks Successful on PR: #1450 Only allow some characters within a request URL to PyPi.

GitHub Actions run 629042249 succeeded.

PR Author

Workflow Run

Lint & Test #616

Source Branch

pypi-url-formatter-patch

regal archBOT Mar 7, 2021, 7:56 AM

#

Xithrius

[bot:pypi\-url\-formatter\-patch] 1 new commit

b6cd44b Removed changes from different branch. - Xithrius

#

Xithrius

[bot] Branch pypi\-url\-formatter\-patch was force-pushed to `fa016c0`

odd spireBOT Mar 7, 2021, 7:59 AM

#

[python-discord/bot] Checks Successful on PR: #1450 Only allow some characters within a request URL to PyPi.

GitHub Actions run 629048226 succeeded.

PR Author

Workflow Run

Lint & Test #617

Source Branch

pypi-url-formatter-patch

#

[python-discord/bot] Checks Successful on PR: #1450 Only allow some characters within a request URL to PyPi.

GitHub Actions run 629049639 succeeded.

PR Author

See: https://github.com/python-discord/sir-lancebot/pull/462#discussion_r496356447

Workflow Run

Lint & Test #618

Source Branch

pypi-url-formatter-patch

regal archBOT Mar 7, 2021, 8:32 AM

#

kosayoda

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

kosayoda

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

regal archBOT Mar 7, 2021, 9:54 AM

#

Srijandev

[python-discord/sir-lancebot] New comment on issue #612: Coin Flip Command and Rock\-Paper\-Scissors Command

Sounds like a great idea , I appreciate that :D

#

mbaruh

[site:mbaruh/channel\-activity] 1 new commit

07847e9 Get rid of stray print - mbaruh

odd spireBOT Mar 7, 2021, 10:00 AM

#

[python-discord/site] Checks Successful on PR: #451 Add route to get a member's data for helper review

GitHub Actions run 629238814 succeeded.

PR Author

https://pythondiscord.com/pages/contributing/

Workflow Run

Lint & Test #111

Source Branch

mbaruh/channel-activity

regal archBOT Mar 7, 2021, 10:24 AM

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #612: Coin Flip Command and Rock\-Paper\-Scissors Command

Hello,
Thanks for the suggestions, they sound cool. Could you split these out into two issues though? They seem like separate features.

Be sure to check out our contributing guide for setting up the bot, and the style guide we use, before starting work. They can both be found here:

regal archBOT Mar 7, 2021, 11:26 AM

#

InvisibleOS

[python-discord/sir-lancebot] New comment on issue #612: Coin Flip Command and Rock\-Paper\-Scissors Command

Alright, so I'll change this one to the coin flip command and make another one for the rock-paper-scissors command.

I'll also be sure to check out the contributing guide.

#

HassanAbouelela

[forms-frontend] Branch discord\-oauth was force-pushed to `5424481`

#

InvisibleOS

[python-discord/sir-lancebot] Issue opened: #613 Rock\-Paper\-Scissors Command

Description

Rock-paper-scissors is a very common game that can be really interesting to play, especially on Discord. It would be a good choice to have it on Sir LanceBot, known for its simple but fun and interesting games.

Reasoning

This is a simple game that can instantly cure boredom and can also be very engaging at times. It would be used by many on the server and it also deserves to be added along with the other games, such as tic-tac-toe and battleship.

Proposed Impl...

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #612: Coin Flip Command

👍 Sounds good to me, I've assigned you here.

regal archBOT Mar 7, 2021, 12:12 PM

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1450: Only allow some characters within a request URL to PyPi\.

Missing a . full stop at the end of the sentence,

            embed.description = f"Illegal character passed into command: '{escape_markdown(character.group(0))}'."

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1450 Only allow some characters within a request URL to PyPi\.

Thanks! Looks Good To Me! Just one thing, not sure if it is needed or not tho.

Tested locally.

#

Xithrius

[python-discord/bot] Pull request review submitted: #1450 Only allow some characters within a request URL to PyPi\.

#

Xithrius

[python-discord/bot] New review comment on pull request #1450: Only allow some characters within a request URL to PyPi\.

I tested this a while ago. I didn't think it looked right. Here's a comparison.

With period:

And without:

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1450 Only allow some characters within a request URL to PyPi\.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1450: Only allow some characters within a request URL to PyPi\.

Yeah, even I had the same feeling.

regal archBOT Mar 7, 2021, 12:40 PM

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #1450 Only allow some characters within a request URL to PyPi\.

All looks good to me!

regal archBOT Mar 7, 2021, 12:55 PM

#

LeptoFlare

[python-discord/sir-lancebot] New comment on issue #325: Personal stats with something like \!aoc mystats

Regarding features in #321, some of them I don't think I'd be able to implement as they seem out of the scope of this issue. I'll try my best though

#

melodicht

[python-discord/sir-lancebot] New comment on pull request #555: Ports LinePaginator from python\-discord bot to fix overflowing line issue

@melodicht will you be fixing up this PR?

Hi, I am so sorry, I just finished my exams. I will take a look at it in a day or two.

#

HassanAbouelela

[forms-frontend:main] 1 new commit

b92baa6 Makes Code Inputs TextAreas - HassanAbouelela

#

scragly

[python-discord/bot] Pull request review submitted: #1450 Only allow some characters within a request URL to PyPi\.

#

scragly

[python-discord/bot] Pull request closed: #1450 Only allow some characters within a request URL to PyPi\.

#

scragly

[python-discord/bot] branch deleted: pypi\-url\-formatter\-patch

#

scragly

[bot:master] 2 new commits

fa016c0 Added filter. - Xithrius
e5a1a30 Merge pull request #1450 from python-discord/py... - scragly

#

jb3

[python-discord/forms-frontend] Pull request review submitted: #141 Discord OAuth

Few notes, otherwise looks good and works great.

#

jb3

[python-discord/forms-frontend] New review comment on pull request #141: Discord OAuth

Not sure the point of this. Originally it was to reset the button state after a user exited the login flow abnormally but this doesn't seem to have any use.

    // Clean up on login
    const interval = setInterval(() => {
        if (windowRef?.closed) {
            clearInterval(interval);
        }
    }, 500);

#

jb3

[python-discord/forms-frontend] New review comment on pull request #141: Discord OAuth

How do these get presented to the user? Maybe we should add a note to clear up the way this gets shown to the user (instead of the current ErrorBoundary setup we have).

#

jb3

[python-discord/forms-frontend] New review comment on pull request #141: Discord OAuth

Do we need to list all possible scopes? Maybe only the ones we will absolutely use.

export enum OAuthScopes {
    Connections = "connections",
    Email = "email",
    Identify = "identify",
    Guilds = "guilds"
}

oak estuaryBOT Mar 7, 2021, 1:18 PM

#

Python Bot

Connected!

odd spireBOT Mar 7, 2021, 1:18 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 629565568 succeeded.

Actor

scragly

Workflow Run

Deploy #181

Commit

e5a1a30

regal archBOT Mar 7, 2021, 2:09 PM

#

mbaruh

[python-discord/bot] New comment on issue #1423: Fix tp list command

The command should additionally mention in parantheses that a user was already reviewed (if they weren't no need to add anything).

#

HassanAbouelela

[forms-frontend:discord\-oauth] 1 new commit

3b83545 Remove Unused OAuth Scopes - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #141 Discord OAuth

#

HassanAbouelela

[python-discord/forms-frontend] New review comment on pull request #141: Discord OAuth

Currently, they get rendered below the discord login button, with the button being reset to either an OAuth button or a submit button depending on the failure.

Easiest way to replicate a failure, is to open the form page, turn off the backend, then try to authenticate.

The error logging is there for our debug purposes.

#

jb3

[python-discord/forms-frontend] Pull request review submitted: #141 Discord OAuth

#

jb3

[python-discord/forms-frontend] New review comment on pull request #141: Discord OAuth

Nice nice.

#

HassanAbouelela

[python-discord/forms-frontend] New review comment on pull request #141: Discord OAuth

Things do seem fine without it, I think it's safe to remove.

#

HassanAbouelela

[python-discord/forms-frontend] Pull request review submitted: #141 Discord OAuth

#

HassanAbouelela

[forms-frontend:discord\-oauth] 1 new commit

7e0d4a9 Removes Unused OAuth Cleaning - HassanAbouelela

odd spireBOT Mar 7, 2021, 3:01 PM

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629729172 succeeded.

PR Author

Workflow Run

Lint & Test #112

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629729173 succeeded.

PR Author

Workflow Run

Lint & Test #113

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629729925 succeeded.

PR Author

Workflow Run

Lint & Test #115

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629729924 succeeded.

PR Author

Workflow Run

Lint & Test #114

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629730429 succeeded.

PR Author

Workflow Run

Lint & Test #116

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629730802 succeeded.

PR Author

Workflow Run

Lint & Test #119

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629730793 succeeded.

PR Author

Workflow Run

Lint & Test #118

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629730432 succeeded.

PR Author

Workflow Run

Lint & Test #117

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629731378 succeeded.

PR Author

Workflow Run

Lint & Test #120

Source Branch

kunal097:limit-infraction-result

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 629731384 succeeded.

PR Author

Workflow Run

Lint & Test #121

Source Branch

kunal097:limit-infraction-result

regal archBOT Mar 7, 2021, 3:23 PM

#

mbaruh

[python-discord/bot] New comment on issue #1423: Fix tp list command

Afte discussing it with @Shivansh-007 I'll be handling this issue.

#

jb3

[python-discord/forms-frontend] Pull request review submitted: #141 Discord OAuth

#

Akarys42

[bot:master] 1 new commit

cd71b84 Mark #appeals as a mod channel - Akarys42

#

jb3

[python-discord/forms-frontend] Pull request closed: #141 Discord OAuth

#

jb3

[forms-frontend:main] 18 new commits

0309638 Adds Basic Auth Functionality - HassanAbouelela
edcdc9b Cleans Up OAuth Button - HassanAbouelela
2350aa1 Makes Authorize Helper Async - HassanAbouelela
451c825 Dynamically Show Discord OAuth Button - HassanAbouelela
e8bd779 Adds Error Handling To Auth Helpers - HassanAbouelela

#

jb3

[python-discord/forms-frontend] branch deleted: discord\-oauth

oak estuaryBOT Mar 7, 2021, 3:31 PM

#

Python Bot

Connected!

odd spireBOT Mar 7, 2021, 3:31 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 629783519 succeeded.

Actor

Workflow Run

Deploy #182

Commit

cd71b84

regal archBOT Mar 7, 2021, 3:48 PM

#

HassanAbouelela

[forms-frontend:main] 2 new commits

8440c05 Revert "Removes Unused OAuth Cleaning" - HassanAbouelela
71388eb Renables OAuth Button On Failure - HassanAbouelela

regal archBOT Mar 7, 2021, 4:48 PM

#

ks129

[forms-frontend:hcaptcha] 58 new commits

be4771b Bump husky from 4.3.8 to 5.0.9 - dependabot[bot]
ce99800 Migrate Husky To v5 - HassanAbouelela
0309638 Adds Basic Auth Functionality - HassanAbouelela
edcdc9b Cleans Up OAuth Button - HassanAbouelela
2350aa1 Makes Authorize Helper Async - HassanAbouelela

#

wookie184

[python-discord/bot] Pull request review submitted: #1445 Migrate talentpool to new API schema

Thanks for doing this! Have tested this and it seems to work as expected, nice job.

Only thing I would say is that the result from tp search is a bit messy/hard to read at the moment, here's an example

I'm not sure if changing this much is within the scope of this PR, if you think not I can add them in a separate PR, but here are some thoughts:

The "Nomination ID" for inacti...

#

ks129

[bot:ks123/talentpool/migrate] 1 new commit

75df6d9 Improve nomination string representation - ks129

#

ks129

[python-discord/bot] New comment on pull request #1445: Migrate talentpool to new API schema

@wookie184 I made these changes.

odd spireBOT Mar 7, 2021, 4:59 PM

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 629932188 succeeded.

PR Author

https://github.com/Rapptz/discord.py/blob/69bdc3a1849407f64ef93bd2e5119e54d6cd2208/discord/embeds.py#L589-L590

Workflow Run

Lint & Test #621

Source Branch

ks123/talentpool/migrate

night lilyBOT Mar 7, 2021, 7:50 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 7, 2021, 8:40 PM

#

laundmo

[python-discord/bot] Issue opened: #1451 Improve help channel closing by differentiating between the OP and other users\.

Goal

Implement a system that closes help channels more quickly if the OP (the person who originally opened the channel) has not responded in a while. This is to prevent channels from going stale for a very long time.

Implementation suggestion

The initial implementation suggestion is that 10 minutes after the last user message, and 30 minutes after the last OP message the channel will be closed.

This issue is meant as a place to discuss different implementations and ideas rel...

regal archBOT Mar 7, 2021, 11:07 PM

#

dawnofmidnight

[python-discord/branding] New comment on issue #128: Create New Year's themed banner

I can work on this. I've done the base, I just need to add the accents.

regal archBOT Mar 8, 2021, 1:38 AM

#

mbaruh

[python-discord/bot] New comment on pull request #1445: Migrate talentpool to new API schema

This doesn't paginate well, gets cut off. Doesn't seem to happen with the infractions paginator.

regal archBOT Mar 8, 2021, 5:27 AM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I'm not gonna request any changes here then, but your idea isn't totally out of the window. My say on it is to leave it as is.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I think it's good enough. Thanks.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I haven't looked over the new commits yet, but my point was that it wasn't safe. There was nothing to prevent a refresh from running during this code and I had outlined why that happening would be problematic.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I don't value the trace log as much, but we can leave it as-is.

#

scragly

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

scragly

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I was just wondering if Discord allows empty strings as descriptions or if it wants it to be None in such cases.

        if self.description:
            result['description'] = self.description

Just for reference, anything Falsey is ignored when building the payload.

regal archBOT Mar 8, 2021, 6:11 AM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

It's a fix because everything above is synchronous, right? Doesn't this seem quite fragile and implicit? If someone didn't know any better, they could introduce race conditions simply by moving re-arranging code, which is an ostensibly harmless thing (because none of the code has directly evident side effects). Just me rambling a bit. I don't have a good idea of how to deal with it nicely.

odd spireBOT Mar 8, 2021, 6:22 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #605 Add WTF Python Command

GitHub Actions run 631351152 succeeded.

PR Author

Workflow Run

Lint #469

Source Branch

Shivansh-007:feature/wtf-python

regal archBOT Mar 8, 2021, 6:26 AM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I've looked over everything now. Help me understand if this is correct:

get_markdown has two awaits (the get request and the executor) which are opportunities for a refresh to occur. If a refresh occurs, it clears out the futures. Once get_markdown resumes, it will still add the symbols to the queue. At the end, it will create a new future (thanks to defaultdict) and await it. Because the symbols were queued and the queue will still be consumed, the queue will eventually get the newl...

#

MarkKoz

[python-discord/bot] New comment on pull request #1014: Doc improvements

Everything looks good besides the outstanding requested changes. I have also yet to try the command on Discord, but I don't foresee any problems thanks to my thorough understanding of the code. The chances are that any remaining problems are likely edge cases that I will not do a thorough enough job of testing to encounter.

#

MarkKoz

[python-discord/snekbox] Pull request review submitted: #93 Fix NsJail Tests

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #93: Fix NsJail Tests

Though maybe it's bad practice, even in CI, and I should have kept using the Python version task...

#

dlasusa

[python-discord/branding] New comment on issue #126: Holi logo

Python_Holi_sm

Just having some fun with a concept/idea.

#

Xithrius

[bot:dynamic\-available\-message\-patch] 155 new commits

aae8001 Added defcon status notifier - mbaruh
ede6823 Merge branch 'master' into mbaruh/defcon - mbaruh
f23c2e7 Make the cog update even if write to DB fails - mbaruh
f2c8e29 Moved self.enabled update to _defcon_action - mbaruh
76574ad Moved channel topic change to _defcon_action - mbaruh

odd spireBOT Mar 8, 2021, 6:51 AM

#

[python-discord/bot] Checks Successful on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631410757 succeeded.

PR Author

Workflow Run

Lint & Test #622

Source Branch

dynamic-available-message-patch

regal archBOT Mar 8, 2021, 7:02 AM

#

Xithrius

[python-discord/bot] Pull request closed: #1414 Reworked dynamic available help message logic\.

#

Xithrius

[bot:dynamic\-available\-message\-patch] 1 new commit

c07b211 Added Redis caching. - Xithrius

#

Xithrius

[python-discord/bot] Pull request reopened: #1414 Reworked dynamic available help message logic\.

#

Xithrius

[bot:dynamic\-available\-message\-patch] 212 new commits

aae8001 Added defcon status notifier - mbaruh
ede6823 Merge branch 'master' into mbaruh/defcon - mbaruh
f23c2e7 Make the cog update even if write to DB fails - mbaruh
f2c8e29 Moved self.enabled update to _defcon_action - mbaruh
76574ad Moved channel topic change to _defcon_action - mbaruh

odd spireBOT Mar 8, 2021, 7:10 AM

#

[python-discord/bot] Checks Failed on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631457567 failed.

PR Author

Workflow Run

Lint & Test #623

Source Branch

dynamic-available-message-patch

#

[python-discord/bot] Checks Failed on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631457570 failed.

PR Author

Workflow Run

Lint & Test #624

Source Branch

dynamic-available-message-patch

#

[python-discord/bot] Checks Failed on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631458043 failed.

PR Author

Workflow Run

Lint & Test #625

Source Branch

dynamic-available-message-patch

regal archBOT Mar 8, 2021, 7:13 AM

#

Xithrius

[bot:dynamic\-available\-message\-patch] 1 new commit

71ea5a6 Removed extra newline at end of _cog.py. - Xithrius

odd spireBOT Mar 8, 2021, 7:16 AM

#

[python-discord/bot] Checks Successful on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631468422 succeeded.

PR Author

Workflow Run

Lint & Test #626

Source Branch

dynamic-available-message-patch

regal archBOT Mar 8, 2021, 7:23 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Unless I missed something, after the get_markdown coro is called, the user_requested attribute of the future is immediately set to True before a refresh can occur (currenty L102 and L118).
Then if a refresh occurs at the two points you mentioned, it'll clear the cog's containers (which we don't care about as new doc gets are suspended until it finishes), afterwards it'll clear the BatchParser which will await every future where the user_requested attr is True before the task is ...

#

MarkKoz

[snekbox] Branch bug/tests/nsjail was force-pushed to `0f604e5`

#

MarkKoz

[python-discord/snekbox] Pull request review submitted: #93 Fix NsJail Tests

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #93: Fix NsJail Tests

Don't yell at me, but I forced push to get rid of it. Turns out I had already dropped the commit locally last month, forgot about it, and commited changes over it.

#

MarkKoz

[snekbox] Branch bug/tests/nsjail was force-pushed to `3f474ff`

#

[snekbox] GitHub Actions checks failure on bug/tests/nsjail

#

[snekbox] GitHub Actions checks failure on pull request #93

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

You're right. I overlooked the fact that the clear waits for the futures. The future will already exist by the type a refresh can be called, so it will be forced to wait for it.

Unless I missed something, after the get_markdown coro is called, the user_requested attribute of the future is immediately set to True before a refresh can occur (currenty L102 and L118).

Yes. However, if a refresh was able to delete the future (it can't since it awaits it), then it'd force a new future to be...

#

MarkKoz

[snekbox:bug/tests/nsjail] 7 new commits

df90f21 Dynamically create parent cgroups for nsjail - jb3
9dac45e Remove cgroup parent constants from config file - jb3
c9368a4 Merge branch 'master' into dynamic-parent-cgroups - jb3
af704c1 Merge pull request #91 from python-discord/dyna... - Akarys42
06173ee Remove all child cgroups before removing parents - jb3

#

[snekbox] GitHub Actions checks failure on pull request #93

#

MarkKoz

[python-discord/snekbox] New comment on pull request #93: Fix NsJail Tests

@jb3 One of the tests is failing. This is a similar issue to what #94 was trying to fix, but the test still fails despite merging that into this branch.

======================================================================
ERROR: test_stdout_flood_results_in_graceful_sigterm (tests.test_nsjail.NsJailTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/snekbox/snekbox/tests/test_nsjail.py", line ...

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Well, it clearly is a bit confusing with the synchronization around it. I'll just move the body after the refresh event wait into the get_event and add a comment so the future changes are aware of its use without going over the awaits themselves

regal archBOT Mar 8, 2021, 8:12 AM

#

Xithrius

[bot:dynamic\-available\-message\-patch] 1 new commit

016614c Using http methods to edit/send messages. - Xithrius

odd spireBOT Mar 8, 2021, 8:14 AM

#

[python-discord/bot] Checks Successful on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631604254 succeeded.

PR Author

Workflow Run

Lint & Test #627

Source Branch

dynamic-available-message-patch

regal archBOT Mar 8, 2021, 8:34 AM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request opened: #614 Tech Leaders Pride

Relevant Issues

Closes #208
Continuation #485

Description

Adds a command .prideleader which will give a pretty embed containing information given in a resources/pride/prideleader.json. It also links to the wikipedia command for that particular Pride Leader so that the user can get some more information on that. In case of Pride Leader not contained in the resources, it will add it to the hackbot.log with level TRACE and give link to the wikipedia command for that Pride...

#

Xithrius

[python-discord/bot] New comment on issue #1443: Delete messages when \`\!pypi\` module is invalid

I'll take this up.

odd spireBOT Mar 8, 2021, 8:35 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #614 Tech Leaders Pride

GitHub Actions run 631661405 succeeded.

PR Author

Workflow Run

Lint #470

Source Branch

Shivansh-007:feature/pride-leaders

regal archBOT Mar 8, 2021, 8:41 AM

#

kosayoda

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

kosayoda

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

I don't see the harm of having the original source linked, so I'm inclined to keep it.

#

kosayoda

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

kosayoda

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

Good catch!

#

kosayoda

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

kosayoda

[python-discord/sir-lancebot] New review comment on pull request #462: Add emojis cog

The only thing suggested here that's part of my PR is not a sentence, so I don't see a reason for the period at the end. I'll tweak the other ones.

odd spireBOT Mar 8, 2021, 8:53 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #462 Add emojis cog

GitHub Actions run 631708709 succeeded.

PR Author

AtieP

Workflow Run

Lint #471

Source Branch

AtieP:master

regal archBOT Mar 8, 2021, 9:05 AM

#

Xithrius

[bot:pypi\-delete\-on\-not\-found] 1 new commit

2c3043c Remove invoked command and message after failure. - Xithrius

#

Xithrius

[python-discord/bot] New branch created: pypi\-delete\-on\-not\-found

#

Xithrius

[python-discord/bot] Pull request opened: #1452 Remove invoked command and message after failure\.

Closes #1443.

Removes the invoked command and any error embed the bot sent (from the pypi cog) after a constant amount of time that's set in the config.

odd spireBOT Mar 8, 2021, 9:11 AM

#

[python-discord/bot] Checks Successful on PR: #1452 Remove invoked command and message after failure.

GitHub Actions run 631753964 succeeded.

PR Author

Workflow Run

Lint & Test #628

Source Branch

pypi-delete-on-not-found

regal archBOT Mar 8, 2021, 9:12 AM

#

Xithrius

[python-discord/bot] New comment on pull request #1452: Remove invoked command and message after failure\.

Branch name should be pypi-delete-on-error, whoops.

regal archBOT Mar 8, 2021, 9:38 AM

#

Xithrius

[python-discord/bot] New comment on issue #1412: Show purgebanned in the feedback message of pban

I'll be yoinking this one.

#

kosayoda

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

Haven't tested yet, but I noticed that we're defining caches in bot/exts/help_channels/_caches.py, so it would be a good idea to have that there too.
Going by convention then, the namespace could be HelpChannels.dynamic_message? I'd also suggest simplifying the redis key, maybe message_id or just id

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

Code looks good and it works pretty well too. Except one change.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

Can we add this to _caches.py? And if this is to be kept here, there is no need to specify namespace and move it to t class variables.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

"Help channels have been updated" Sounds more accurate imo.

#

Xithrius

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

Yep. See this comment.

#

Xithrius

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

Xithrius

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

Xithrius

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

Could you explain what you mean by "more accurate"? I don't really see the main purpose of changing between "changed" to "updated".

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

I got the sentence wrong, nvm.

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

Thanks! Looks Good To Me!

Tested locally.

#

Xithrius

[bot:dynamic\-available\-message\-patch] 1 new commit

7896894 Moved cache, reworked logic so message sends on... - Xithrius

#

Xithrius

[bot:dynamic\-available\-message\-patch] 1 new commit

9d78367 Removed async_rediscache import. - Xithrius

odd spireBOT Mar 8, 2021, 10:19 AM

#

[python-discord/bot] Checks Failed on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631946559 failed.

PR Author

Workflow Run

Lint & Test #629

Source Branch

dynamic-available-message-patch

#

[python-discord/bot] Checks Failed on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631946559 failed.

PR Author

Workflow Run

Lint & Test #629

Source Branch

dynamic-available-message-patch

#

[python-discord/bot] Checks Successful on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 631949592 succeeded.

PR Author

Workflow Run

Lint & Test #630

Source Branch

dynamic-available-message-patch

odd spireBOT Mar 8, 2021, 10:55 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #462 Add emojis cog

GitHub Actions run 632042799 succeeded.

PR Author

AtieP

Workflow Run

Lint #472

Source Branch

AtieP:master

regal archBOT Mar 8, 2021, 11:11 AM

#

scragly

[python-discord/sir-lancebot] Pull request review submitted: #462 Add emojis cog

#

Den4200

[python-discord/sir-lancebot] Pull request review dismissed: #462 Add emojis cog

This was purely a code review, I'll test out this new command soon.

#

Xithrius

[bot:ban\-vs\-pban] 1 new commit

4ab3a38 Purge ban now says 'purge ban' on user purge ban. - Xithrius

#

Xithrius

[python-discord/bot] New branch created: ban\-vs\-pban

#

gustavwilliam

[python-discord/sir-lancebot] Pull request review dismissed: #462 Add emojis cog

Just a few minor comments

#

scragly

[python-discord/sir-lancebot] Issue closed: #461 Add cog that shows info about emojis

#

scragly

[python-discord/sir-lancebot] Pull request closed: #462 Add emojis cog

#

scragly

[sir-lancebot:master] 13 new commits

734adde Add time utils - AtieP
9813bed Add emojis cog - AtieP
cb75d95 No need to typecast emoji.url to str - AtieP
68a7bb5 Rename the last description line - AtieP
2fd63f6 Set precision to hours - AtieP

odd spireBOT Mar 8, 2021, 11:15 AM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 632091250 succeeded.

Actor

scragly

Workflow Run

Build #168

Commit

1df233e

night lilyBOT Mar 8, 2021, 11:16 AM

#

Sir Lancebot

Connected!

regal archBOT Mar 8, 2021, 11:16 AM

#

Xithrius

[python-discord/bot] Pull request opened: #1453 Purge ban now shows that user was purge banned within infraction message\.

Just a small QOL change. When a user is purge banned, the feedback message shows that the purge was applied.

The difference between a regular ban and a purge ban:

odd spireBOT Mar 8, 2021, 11:17 AM

#

[python-discord/bot] Checks Failed on PR: #1453 Purge ban now shows that user was purge banned within infraction message.

GitHub Actions run 632100181 failed.

PR Author

Workflow Run

Lint & Test #631

Source Branch

ban-vs-pban

regal archBOT Mar 8, 2021, 11:20 AM

#

HassanAbouelela

[forms-frontend:main] 1 new commit

e6c1116 Opens OAuth In New Tab - HassanAbouelela

#

Xithrius

[bot] Branch ban\-vs\-pban was force-pushed to `1255bbe`

#

scragly

[python-discord/sir-lancebot] Issue opened: #615 Codeblock rendering inconsistency on Android client\.

Description

In Discord's markdown formatting, it has been mentioned in the past that codeblocks should have their triple backticks on their own lines. For the vast majority of time, this could be ignored, however recently the Android Discord client renders the two codeblocks differently now, with those without the dedicated lines for the backticks resulting in inline code blocks being rendered instead.

![image](https://user-images.githubusercontent.com/29337040/110314953-44835d00-805...

odd spireBOT Mar 8, 2021, 11:30 AM

#

[python-discord/bot] Checks Failed on PR: #1453 Purge ban now shows that user was purge banned within infraction message.

GitHub Actions run 632128070 failed.

PR Author

Workflow Run

Lint & Test #632

Source Branch

ban-vs-pban

regal archBOT Mar 8, 2021, 11:30 AM

#

HassanAbouelela

[forms-backend:dependabot/pip/sentry\-sdk\-0\.20\.3] 32 new commits

7c01270 Adds Production Constant - HassanAbouelela
7a16a6b Adds Token Refresh Route - HassanAbouelela
10a2afb Refreshes User Data On Form Submit - HassanAbouelela
839525e Remove AuthorizationHeaders Class - HassanAbouelela
423a1bd Adds CORS Rules - HassanAbouelela

odd spireBOT Mar 8, 2021, 11:31 AM

#

[python-discord/forms-backend] Checks Successful on PR: #61 Bump sentry-sdk from 0.19.5 to 0.20.3

GitHub Actions run 632135407 succeeded.

PR Author

Workflow Run

Forms Backend #266

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Mar 8, 2021, 11:34 AM

#

HassanAbouelela

[python-discord/forms-backend] New comment on pull request #61: Bump sentry\-sdk from 0\.19\.5 to 0\.20\.3

Messed the lock file up, I'll try to fix it.

#

Xithrius

[bot:ban\-vs\-pban] 1 new commit

f76e47b Fixed unittest for purge infraction. - Xithrius

odd spireBOT Mar 8, 2021, 11:38 AM

#

[python-discord/bot] Checks Successful on PR: #1453 Purge ban now shows that user was purge banned within infraction message.

GitHub Actions run 632150262 succeeded.

PR Author

Workflow Run

Lint & Test #633

Source Branch

ban-vs-pban

regal archBOT Mar 8, 2021, 11:39 AM

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #611: Full support for Gitpod

Gonna leave my two cents here:

I don't have anything against gitpod, and wouldn't mind us adding this. What I do have a problem with, however, is if this will "open the floodgates" so to speak. Will this lead to more editor specific changes? If so, which editors do we accommodate?

I'm not going to shoot this down immediately, because it seems cool and helpful, but I also won't approve it until we get more opinions.

regal archBOT Mar 8, 2021, 12:31 PM

#

kwzrd

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

Looks great, I think the caching reduced the solution's complexity a lot, which is always good.

#

kwzrd

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

This log is misleading; we hit this line either in the described case or when the message ID was there but the edit failed.

#

kwzrd

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

I think you don't need to keep the dynamic_message attribute on the class ~ you can just retrieve it from the cache every time you need it (inside the update function). Although this will have a little less overhead, so maybe it makes sense.

Regarding the available_help_channels attribute. In terms of code cleanliness I think it would be a lot nicer to always look at the d.py representation (as we do when the set isn't populated yet) rather than keeping our own state, but I understan...

#

kwzrd

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

I think this forgets to call the update function?

#

kwzrd

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

kwzrd

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

Perhaps this should be moved down below the init_available call. Makes more sense to wait for the channels to be synced before we edit the message.

#

kosayoda

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

kosayoda

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

I actually have a different opinion on this one, I think the log should come after, since the whole purpose of logging is to record events, ie. if we see the log it means x happened, if it doesn't then we never reached that point.

#

kwzrd

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

kwzrd

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

I'd log before the edit, then both in the except and the else clause to document the outcome. :smile:

regal archBOT Mar 8, 2021, 1:25 PM

#

aaravm4

[python-discord/sir-lancebot] New comment on issue #494: Add Yoda Text Command

Almost done.

#

dawnofmidnight

[python-discord/bot] New comment on issue #1432: Faulty tag suggestions

I'm open to working on this. But to make sure I'm not misunderstanding this, you want to only use the first word and not the whole statement, correct?

regal archBOT Mar 8, 2021, 1:50 PM

#

lemonsaurus

[python-discord/branding] New comment on issue #104: Lemoji contributions guide

I think it has to be a readme to be displayed, but not sure.

#

Akarys42

[python-discord/branding] New comment on issue #104: Lemoji contributions guide

It has to be called README, yes. The extension doesn't matter.

regal archBOT Mar 8, 2021, 2:27 PM

#

HassanAbouelela

[forms-backend:dependabot/pip/sentry\-sdk\-0\.20\.3] 1 new commit

75d954d Fixes Production URL Constant - HassanAbouelela

odd spireBOT Mar 8, 2021, 2:28 PM

#

[python-discord/forms-backend] Checks Successful on PR: #61 Bump sentry-sdk from 0.19.5 to 0.20.3

GitHub Actions run 632581355 succeeded.

PR Author

Workflow Run

Forms Backend #267

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Mar 8, 2021, 2:28 PM

#

HassanAbouelela

[forms-backend:main] 1 new commit

4fadbef Fixes Production URL Constant - HassanAbouelela

odd spireBOT Mar 8, 2021, 2:29 PM

#

[python-discord/forms-backend] Checks Successful on PR: #61 Bump sentry-sdk from 0.19.5 to 0.20.3

GitHub Actions run 632583191 succeeded.

PR Author

Workflow Run

Forms Backend #268

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Mar 8, 2021, 2:30 PM

#

dawnofmidnight

[python-discord/bot] Issue opened: #1454 Remove reactions from users that aren't the OP for pagination and trash can\.

Goal

When using pagination or the trash can symbol (the one used to delete embeds), it is set to only be able to use by the OP. It may help clean it up to delete reactions from people that aren't the OP.

Implementation Suggestion

Python already checks whether the person adding the reactions for pagination or the trash can is used by the OP, so it would be simple to use remove_reaction to get rid of the useless reactions.

This isn't a high priority issue, but it would help cl...

odd spireBOT Mar 8, 2021, 2:30 PM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 632585595 succeeded.

Actor

Workflow Run

Forms Backend #269

Commit

4fadbef

regal archBOT Mar 8, 2021, 3:30 PM

#

Akarys42

[python-discord/snekbox] Pull request review submitted: #93 Fix NsJail Tests

#

Akarys42

[python-discord/snekbox] New review comment on pull request #93: Fix NsJail Tests

Cool!

regal archBOT Mar 8, 2021, 4:05 PM

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1452 Remove invoked command and message after failure\.

Thanks! Looks Good To Me! Just two comments.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1452: Remove invoked command and message after failure\.

Not sure if it is needed as a wrapper but I think it is good to have it since it describes the purpose of the constant better than RedirectOutput.delete_delay.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1452: Remove invoked command and message after failure\.

I feel setting error To False as default is better and then setting it to True here.

But yeah that’s just my personal preference.

#

jb3

[python-discord/snekbox] New comment on pull request #93: Fix NsJail Tests

So I guess the child cgroups are still busy. I'll check it out.

#

MrKomodoDragon

[python-discord/branding] New comment on issue #126: Holi logo

Nice!

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1453 Purge ban now shows that user was purge banned within infraction message\.

Thanks! Looks Good To Me!

regal archBOT Mar 8, 2021, 4:31 PM

#

Akarys42

[bot:many\-snowflakes] 2 new commits

7a97eec Make the snowflake command accept many snowflakes - Akarys42
0a2e08c Restrict non-staffer to one snowflake at the time - Akarys42

#

Akarys42

[python-discord/bot] New branch created: many\-snowflakes

#

Akarys42

[python-discord/bot] Pull request opened: #1455 Allow the sf command to take more than one snowflake at the time

Here is how it looks with many snowflakes:

To avoid users making the bot hit ratelimits, it is still limited to one snowflake per invocation for non-staffers

odd spireBOT Mar 8, 2021, 4:36 PM

#

[python-discord/bot] Checks Successful on PR: #1455 Allow the sf command to take more than one snowflake at the time

GitHub Actions run 632934359 succeeded.

PR Author

Workflow Run

Lint & Test #634

Source Branch

many-snowflakes

regal archBOT Mar 8, 2021, 5:11 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #1445 Migrate talentpool to new API schema

After testing it seems to be working okay for many, a bit shorter nominations. So I guess limiting it to 1000 characters really is enough like you said.

I also think you should change the approval message in line 112 to ":white_check_mark: The nomination for {user} has been added to the talent pool"

#

ks129

[bot:ks123/talentpool/migrate] 1 new commit

ecdffd5 Don't mention watching anymore in talent pool a... - ks129

#

ks129

[bot:ks123/talentpool/migrate] 1 new commit

fa93d2f Shorten reason of nomination string to 1000 cha... - ks129

odd spireBOT Mar 8, 2021, 5:21 PM

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 633064763 succeeded.

PR Author

Workflow Run

Lint & Test #635

Source Branch

ks123/talentpool/migrate

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 633072402 succeeded.

PR Author

Workflow Run

Lint & Test #636

Source Branch

ks123/talentpool/migrate

oak estuaryBOT Mar 8, 2021, 5:30 PM

#

Python Bot

Connected!

regal archBOT Mar 8, 2021, 5:33 PM

#

ks129

[bot:ks123/talentpool/migrate] 1 new commit

7d3d3ea Limit maximum characters for reasons to 1000 - ks129

odd spireBOT Mar 8, 2021, 5:36 PM

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 633107337 succeeded.

PR Author

Workflow Run

Lint & Test #637

Source Branch

ks123/talentpool/migrate

regal archBOT Mar 8, 2021, 5:42 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #1445 Migrate talentpool to new API schema

#

mbaruh

[bot:ks123/talentpool/migrate] 61 new commits

aae8001 Added defcon status notifier - mbaruh
ede6823 Merge branch 'master' into mbaruh/defcon - mbaruh
f23c2e7 Make the cog update even if write to DB fails - mbaruh
f2c8e29 Moved self.enabled update to _defcon_action - mbaruh
76574ad Moved channel topic change to _defcon_action - mbaruh

#

mbaruh

[site:ks123/nomination/split] 11 new commits

3f99f18 Add powered by linode to the footer - Akarys42
2f3c30f Merge pull request #448 from python-discord/add... - ks129
97d0ece Reduce worker count from 4 to 2 - jb3
ebf128e Add 404 page - gustavwilliam
3020e2e Add error page styling - gustavwilliam

odd spireBOT Mar 8, 2021, 5:47 PM

#

[python-discord/site] Checks Successful on PR: #447 Rework nominations

GitHub Actions run 633144174 succeeded.

PR Author

Workflow Run

Lint & Test #122

Source Branch

ks123/nomination/split

regal archBOT Mar 8, 2021, 5:48 PM

#

mbaruh

[python-discord/site] Issue closed: #445 Allow many nominations per user

odd spireBOT Mar 8, 2021, 5:49 PM

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 633142923 succeeded.

PR Author

Workflow Run

Lint & Test #638

Source Branch

ks123/talentpool/migrate

regal archBOT Mar 8, 2021, 5:49 PM

#

mbaruh

[python-discord/site] Pull request closed: #447 Rework nominations

#

mbaruh

[python-discord/site] branch deleted: ks123/nomination/split

#

mbaruh

[site:master] 31 new commits

9ac4773 Split nomination model to 2 tables and create m... - ks129
ff46d9f Change nominations admin interface and add nomi... - ks129
4bc55a5 Change nominations serializer and add nominatio... - ks129
51c57d3 Update nominations viewset GET and POST to make... - ks129
71388ff Add reviewed field to nomination serializer - ks129

#

mbaruh

[python-discord/bot] Pull request review submitted: #1445 Migrate talentpool to new API schema

#

mbaruh

[python-discord/bot] Issue closed: #1425 Allow multiple nominations on a member to be active at once

#

mbaruh

[python-discord/bot] Pull request closed: #1445 Migrate talentpool to new API schema

#

mbaruh

[python-discord/bot] branch deleted: ks123/talentpool/migrate

#

mbaruh

[bot:master] 12 new commits

54952d1 Add disable_header to watchchannel to disable t... - ks129
86988b6 Migrate talentpool to new schema - ks129
b9141ea Add parentheses back to previous nominations count - ks129
4532b40 Fix trace logging of nomination 404 - ks129
ce5fb70 Fix grammar of nomination cog - ks129

oak estuaryBOT Mar 8, 2021, 5:55 PM

#

Python Bot

Connected!

regal archBOT Mar 8, 2021, 5:55 PM

#

HassanAbouelela

[python-discord/bot] New comment on pull request #1449: Use JSON logging in production

This PR is being reverted due to an internal decision. See discussion [here](#dev-core message).

#

HassanAbouelela

[bot:revert\-1449\-json\-logging] 1 new commit

1ebc283 Revert "Use JSON logging in production" - HassanAbouelela

#

HassanAbouelela

[python-discord/bot] New branch created: revert\-1449\-json\-logging

odd spireBOT Mar 8, 2021, 5:55 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 633165278 succeeded.

Actor

Workflow Run

Deploy #183

Commit

01f011d

#

[python-discord/site] Workflow Successful

GitHub Actions run 633160143 succeeded.

Actor

Workflow Run

Deploy #30

Commit

e0fc61a

regal archBOT Mar 8, 2021, 5:57 PM

#

HassanAbouelela

[python-discord/bot] Pull request opened: #1456 Revert "Use JSON logging in production"

Reverts python-discord/bot#1449

See internal reasoning [here](#dev-core message).

#

ks129

[python-discord/bot] Pull request review submitted: #1456 Revert "Use JSON logging in production"

#

Senjan21

[python-discord/bot] Pull request review submitted: #1456 Revert "Use JSON logging in production"

#

Senjan21

[python-discord/site] Issue opened: #452 Hacktoberfest branding asset link is dead\.

Currently, when visiting https://pythondiscord.com/pages/events/ you can't see any logo for Hacktoberfest event.

It is due to the fact that structure of branding was changed. Currently we point to python-discord/branding/master/seasonal/halloween/hacktober/hacktoberfest_animated.gif
The hacktober folder has since been renamed to hacktoberfest and and we have categories...

#

HassanAbouelela

[python-discord/bot] Pull request closed: #1456 Revert "Use JSON logging in production"

#

HassanAbouelela

[bot:master] 2 new commits

1ebc283 Revert "Use JSON logging in production" - HassanAbouelela
4187a1a Merge pull request #1456 from python-discord/re... - HassanAbouelela

#

HassanAbouelela

[python-discord/bot] branch deleted: revert\-1449\-json\-logging

odd spireBOT Mar 8, 2021, 6:01 PM

#

[python-discord/bot] Checks Successful on PR: #1456 Revert "Use JSON logging in production"

GitHub Actions run 633172129 succeeded.

PR Author

Workflow Run

Lint & Test #640

Source Branch

revert-1449-json-logging

regal archBOT Mar 8, 2021, 6:03 PM

#

ks129

[python-discord/bot] Pull request review submitted: #1455 Allow the sf command to take more than one snowflake at the time

#

ks129

[python-discord/bot] New review comment on pull request #1455: Allow the sf command to take more than one snowflake at the time

Please mention here that this is only case if user is not staff member.

oak estuaryBOT Mar 8, 2021, 6:06 PM

#

Python Bot

Connected!

odd spireBOT Mar 8, 2021, 6:07 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 633194836 succeeded.

Actor

Workflow Run

Deploy #184

Commit

4187a1a

regal archBOT Mar 8, 2021, 6:19 PM

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #49: Implement Discord roles assigning for form submissions

Could you break this into multiple lines to avoid the noqa?

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #49 Implement Discord roles assigning for form submissions

Everything looks good for the most part. Could you also resolve conflicts and merge master?

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #49: Implement Discord roles assigning for form submissions

                "discord_role field is required when ASSIGN_ROLE flag is provided."

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #49: Implement Discord roles assigning for form submissions

This was initially incorrect, as value is a list of str not feature. We should be checking if FormFeatures.REQUIRES_LOGIN.value not in value. This goes for the other two checks as well.

#

Hillo111

[python-discord/sir-lancebot] New comment on issue #599: Hangman Game Command

I am a little confused with the executor part, so the bot will become the guesser?

yes

regal archBOT Mar 8, 2021, 6:39 PM

#

Akarys42

[sir-lancebot:aoc\-fixes] 2 new commits

6c89267 Properly rename countdown_task -> notification_... - Akarys42
e6e12c3 Restrict the aoc leaderboard commands to december - Akarys42

#

Akarys42

[python-discord/sir-lancebot] New branch created: aoc\-fixes

#

HassanAbouelela

[python-discord/bot] Issue opened: #1457 Shorten PyPI Embed

Description

The PyPI embed can take up a lot of vertical space, which can be a little problematic in rapidly moving chat channels, such as python-general. We could maintain most of the embed's functionality while reducing the space it takes up.

Implementation

There are currently the following fields in the embed: Author, Summary, License, and Python Versions.
One possible implementation would be to limit the number of fields displayed to only include the most helpful ones. For exa...

#

Xithrius

[python-discord/bot] New comment on issue #1457: Shorten PyPI Embed

I like this new embed, and I also agree that the license and author is not necessary when providing info.

Do we want the "Summary" field as well, or do we just want the summary below the title?

Either way, I can yoink this one.

#

Xithrius

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

Xithrius

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

Actually, the call is not needed here. Works perfectly fine without it.

#

Xithrius

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

Xithrius

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

Will do, thanks!

#

Xithrius

[python-discord/bot] Pull request review submitted: #1414 Reworked dynamic available help message logic\.

#

Xithrius

[python-discord/bot] New review comment on pull request #1414: Reworked dynamic available help message logic\.

I'll put it above the edit log.

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1453 Purge ban now shows that user was purge banned within infraction message\.

Simple, and clean. Thanks

#

AG4lyf

[python-discord/branding] Issue opened: #130 A lemoji for Highfive

Kinda same apporch to either this

or a lemon with a hand in front of it.

#

AG4lyf

[python-discord/branding] Issue opened: #131 A hugging lemoji

🤗 totally like this.

#

Kronifer

[python-discord/branding] New comment on issue #75: Cowboy lemoji, please\.

@Senjan21 I would like to take this

#

Akarys42

[python-discord/bot] Pull request review submitted: #1453 Purge ban now shows that user was purge banned within infraction message\.

Lgtm

#

Akarys42

[bot:ban\-vs\-pban] 15 new commits

54952d1 Add disable_header to watchchannel to disable t... - ks129
86988b6 Migrate talentpool to new schema - ks129
b9141ea Add parentheses back to previous nominations count - ks129
4532b40 Fix trace logging of nomination 404 - ks129
ce5fb70 Fix grammar of nomination cog - ks129

#

Xithrius

[python-discord/bot] Issue closed: #1412 Show purgebanned in the feedback message of pban

#

Xithrius

[python-discord/bot] Pull request closed: #1453 Purge ban now shows that user was purge banned within infraction message\.

#

Xithrius

[bot:master] 4 new commits

1255bbe Purge ban now says 'purge ban' on user purge ban. - Xithrius
f76e47b Fixed unittest for purge infraction. - Xithrius
e6d9bcc Merge branch 'master' into ban-vs-pban - Akarys42
0d6925e Merge pull request #1453 from python-discord/ba... - Xithrius

#

Xithrius

[python-discord/bot] branch deleted: ban\-vs\-pban

odd spireBOT Mar 8, 2021, 7:35 PM

#

[python-discord/bot] Checks Successful on PR: #1453 Purge ban now shows that user was purge banned within infraction message.

GitHub Actions run 633420795 succeeded.

PR Author

Workflow Run

Lint & Test #642

Source Branch

ban-vs-pban

oak estuaryBOT Mar 8, 2021, 7:38 PM

#

Python Bot

Connected!

odd spireBOT Mar 8, 2021, 7:39 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 633434582 succeeded.

Actor

Workflow Run

Deploy #185

Commit

0d6925e

regal archBOT Mar 8, 2021, 7:46 PM

#

Akarys42

[python-discord/sir-lancebot] Pull request opened: #616 Aoc fixes

Relevant Issues

🤷‍♂️

Description

Replace a dead variable with its actual name
Restrict the aoc leaderboard commands to December

Reasoning

The dead variable caused the cog to not properly unload while the leaderboard cannot work outside of December.

Screenshots

none

Additional Details

I mean, do you really need additional details?

Did you:

[no, I don't like them] Join the [Python Discord Community](https://di...

odd spireBOT Mar 8, 2021, 7:47 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #616 Aoc fixes

GitHub Actions run 633454544 succeeded.

PR Author

Workflow Run

Lint #474

Source Branch

aoc-fixes

regal archBOT Mar 8, 2021, 7:56 PM

#

Xithrius

[bot:master] 1 new commit

bf5efea Resolving KeyError on infractions that don't pu... - Xithrius

oak estuaryBOT Mar 8, 2021, 7:59 PM

#

Python Bot

Connected!

odd spireBOT Mar 8, 2021, 8:00 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 633478584 succeeded.

Actor

Workflow Run

Deploy #186

Commit

bf5efea

regal archBOT Mar 8, 2021, 8:05 PM

#

jb3

[python-discord/bot] New review comment on pull request #1455: Allow the sf command to take more than one snowflake at the time

That's probably not necessary. We can let the staff know that or alternatively add it to the help section of the command.

regal archBOT Mar 8, 2021, 9:20 PM

#

Slushs

[python-discord/sir-lancebot] Issue opened: #617 Funny Tech Tips

Description

This feature will post funny and just really outrageously silly and funny. For example I was thinking the command could be along the lines of .techtip and there would be a bunch of different responses one being "Make sure after you come home for work you run a virus scan on your laptop to make sure it isn't sick" and just really funny pointless stuff like. I can give a more updated list that you guys can check over and moderate if needs to be.

Reasoning

This proposa...

#

SebastiaanZ

[python-discord/sir-lancebot] New review comment on pull request #616: Aoc fixes

We could just remove the of initialization of these names here, as we reassign them a few lines lower anyway. I think this is a leftover from a time where they may not have been assigned at __init__ time.

#

SebastiaanZ

[python-discord/sir-lancebot] Pull request review submitted: #616 Aoc fixes

#

MarkKoz

[python-discord/snekbox] New comment on pull request #93: Fix NsJail Tests

Turns out that killing the parent process does not kill its children. Therefore, we have nsjail's children (which are Python processes in this case) sticking around preventing child cgroups from being removed. This will be addressed in a separate PR.

#

MarkKoz

[python-discord/snekbox] Pull request closed: #93 Fix NsJail Tests

#

MarkKoz

[snekbox:master] 8 new commits

e12e403 CI: fix test step not failing when tests fail - MarkKoz
cfe57d2 Suppress NsJail info logs during tests - MarkKoz
a8b9c33 Close file descriptors when subprocess ends - MarkKoz
a1b5e5b Fix the memory limit test and the import error - MarkKoz
2240dde Fix patch for DEBUG value during testing - MarkKoz

#

MarkKoz

[python-discord/snekbox] branch deleted: bug/tests/nsjail

#

[snekbox] GitHub Actions checks success on master

#

[snekbox] GitHub Actions checks failure on master

regal archBOT Mar 8, 2021, 11:26 PM

#

jb3

[snekbox:prctl\-reparenting] 3 new commits

a6e0d41 Add python-prctl dependency - jb3
e36342e Install build dependencies in Docker for python... - jb3
f52252b Run set_child_subreaper on init and os.wait on ... - jb3

#

jb3

[python-discord/snekbox] New branch created: prctl\-reparenting

#

jb3

[python-discord/snekbox] Pull request opened: #95 Reparent orphaned child processors

After receiving a set of busy resource errors after trying to remove dynamic cgroups introduced in #91, it became evident that Python interpreters were remaining active for a period after the nsjail parent had exited.

This PR fixes that by using prctl to register the Python NSJail workers as subreapers and collect orphaned processes.

Then, before cleaning up cgroups we use [os.wait](https://docs.python.org/3/library/os.html#os.wait...

#

jb3

[snekbox:prctl\-reparenting] 11 new commits

e12e403 CI: fix test step not failing when tests fail - MarkKoz
cfe57d2 Suppress NsJail info logs during tests - MarkKoz
a8b9c33 Close file descriptors when subprocess ends - MarkKoz
a1b5e5b Fix the memory limit test and the import error - MarkKoz
2240dde Fix patch for DEBUG value during testing - MarkKoz

#

[snekbox] GitHub Actions checks failure on pull request #95

#

jb3

[snekbox:prctl\-reparenting] 1 new commit

865f372 Silently drop ChildProcessError - jb3

#

[snekbox] GitHub Actions checks success on pull request #95

oak estuaryBOT Mar 9, 2021, 12:05 AM

#

Python Bot

Connected!

regal archBOT Mar 9, 2021, 6:43 AM

#

ks129

[forms-backend:ks123/role\-assigning] 1 new commit

7bb9f53 Add missing "is" to error message - ks129

#

ks129

[forms-backend:ks123/role\-assigning] 65 new commits

7c01270 Adds Production Constant - HassanAbouelela
7a16a6b Adds Token Refresh Route - HassanAbouelela
10a2afb Refreshes User Data On Form Submit - HassanAbouelela
839525e Remove AuthorizationHeaders Class - HassanAbouelela
423a1bd Adds CORS Rules - HassanAbouelela

odd spireBOT Mar 9, 2021, 6:50 AM

#

[python-discord/forms-backend] Checks Successful on PR: #49 Implement Discord roles assigning for form submissions

GitHub Actions run 634887064 succeeded.

PR Author

Workflow Run

Forms Backend #270

Source Branch

ks123/role-assigning

regal archBOT Mar 9, 2021, 6:50 AM

#

ks129

[forms-backend:ks123/role\-assigning] 1 new commit

e096c70 Simplify role assigning rate limit handling - ks129

odd spireBOT Mar 9, 2021, 6:51 AM

#

[python-discord/forms-backend] Checks Successful on PR: #49 Implement Discord roles assigning for form submissions

GitHub Actions run 634889848 succeeded.

PR Author

Workflow Run

Forms Backend #271

Source Branch

ks123/role-assigning

#

[python-discord/forms-backend] Checks Successful on PR: #49 Implement Discord roles assigning for form submissions

GitHub Actions run 634889860 succeeded.

PR Author

Workflow Run

Forms Backend #272

Source Branch

ks123/role-assigning

regal archBOT Mar 9, 2021, 7:02 AM

#

Senjan21

[python-discord/branding] New comment on issue #75: Cowboy lemoji, please\.

@Senjan21 I would like to take this

I have assigned you. Have fun with the design!

regal archBOT Mar 9, 2021, 8:49 AM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request opened: #618 Wikiguess Game

Relevant Issues

Closes #446

Description

Restructured the trivia_quiz.py as it was getting huge into two separate files inside trivia_quiz/ namely _cog and _helpers. A new task has been added to _cog to get 10 random questions from wikipedia after 1 hour.
A new category is added (sort of) to the trivia quiz i.e. wiki/wikipedia that would use the 10 questions which the task has got us.

The problem is there is no good way to form the question, either the extract c...

odd spireBOT Mar 9, 2021, 8:50 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #618 Wikiguess Game

GitHub Actions run 635172139 succeeded.

PR Author

Workflow Run

Lint #475

Source Branch

Shivansh-007:feature/wikipedia-game

regal archBOT Mar 9, 2021, 9:21 AM

#

Akarys42

[sir-lancebot:aoc\-fixes] 1 new commit

8b0c1cd Remove useless initialization in the AoC cog - Akarys42

#

Akarys42

[python-discord/sir-lancebot] New review comment on pull request #616: Aoc fixes

Changed in 8b0c1cd3b6729558218bd85aeb660d1975877345

odd spireBOT Mar 9, 2021, 9:22 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #616 Aoc fixes

GitHub Actions run 635257633 succeeded.

PR Author

Workflow Run

Lint #476

Source Branch

aoc-fixes

regal archBOT Mar 9, 2021, 9:25 AM

#

Akarys42

[python-discord/bot] New review comment on pull request #1455: Allow the sf command to take more than one snowflake at the time

I don’t think it is necessary, we don’t mention that only moderators can use !user on other users than themselves. I don’t mind adding it to the docstring but I feel like that will just add noise since the new command signature will reflect this change, what do you think?

regal archBOT Mar 9, 2021, 11:31 AM

#

SebastiaanZ

[python-discord/sir-lancebot] Pull request review submitted: #616 Aoc fixes

regal archBOT Mar 9, 2021, 1:17 PM

#

jb3

[bot:master] 1 new commit

1c4e438 DevOps team reviews for bot deployments - jb3

oak estuaryBOT Mar 9, 2021, 1:22 PM

#

Python Bot

Connected!

odd spireBOT Mar 9, 2021, 1:22 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 635895721 succeeded.

Actor

Workflow Run

Deploy #187

Commit

1c4e438

regal archBOT Mar 9, 2021, 1:29 PM

#

HassanAbouelela

[forms-frontend:main] 1 new commit

15278ab Adds HassanAbouelela To Codeowners - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #178 Bump @types/react\-dom from 17\.0\.1 to 17\.0\.2

#

HassanAbouelela

[python-discord/forms-frontend] Pull request reopened: #178 Bump @types/react\-dom from 17\.0\.1 to 17\.0\.2

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #175 Bump html\-webpack\-plugin from 5\.2\.0 to 5\.3\.0

#

HassanAbouelela

[forms-frontend:main] 2 new commits

cea171f Bump html-webpack-plugin from 5.2.0 to 5.3.0 - dependabot[bot]
18fd508 Merge pull request #175 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #176 Bump @types/react from 17\.0\.2 to 17\.0\.3

#

HassanAbouelela

[forms-frontend:main] 2 new commits

7b1b311 Bump @types/react from 17.0.2 to 17.0.3 - dependabot[bot]
a9f655e Merge pull request #176 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #179 Bump @typescript\-eslint/parser from 4\.16\.1 to 4\.17\.0

#

HassanAbouelela

[forms-frontend:main] 2 new commits

d198e16 Bump @typescript-eslint/parser from 4.16.1 to 4... - dependabot[bot]
eba3fb3 Merge pull request #179 from python-discord/dep... - HassanAbouelela

regal archBOT Mar 9, 2021, 2:06 PM

#

Akarys42

[bot:master] 1 new commit

b7d3419 Fix typo in stars.json - Akarys42

oak estuaryBOT Mar 9, 2021, 2:11 PM

#

Python Bot

Connected!

odd spireBOT Mar 9, 2021, 2:11 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 636024772 succeeded.

Actor

Workflow Run

Deploy #188

Commit

b7d3419

regal archBOT Mar 9, 2021, 2:13 PM

#

jb3

[bot:master] 1 new commit

5a8cbaa Delete repo specific FUNDING.yml file in favour... - jb3

oak estuaryBOT Mar 9, 2021, 2:17 PM

#

Python Bot

Connected!

odd spireBOT Mar 9, 2021, 2:17 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 636045324 succeeded.

Actor

Workflow Run

Deploy #189

Commit

5a8cbaa

regal archBOT Mar 9, 2021, 3:06 PM

#

dawnofmidnight

[python-discord/bot] New comment on issue #1454: Remove reactions from users that aren't the OP for pagination and trash can\.

I can work on this, but I'll need some time to finish up some branding assets.

#

Kronifer

[python-discord/branding] New comment on issue #75: Cowboy lemoji, please\.

Thanks!

regal archBOT Mar 9, 2021, 3:42 PM

#

Kronifer

[python-discord/branding] New comment on issue #75: Cowboy lemoji, please\.

Thanks! 🤠

#

Kronifer

[python-discord/branding] Issue opened: #132 Saint Patrick's Day theme

Could we have a special logo for st. Patrick's Day?

#

dawnofmidnight

[python-discord/branding] New comment on issue #132: Saint Patrick's Day theme

That already exists.
https://github.com/python-discord/branding/tree/master/events/st_patricks_day

#

Kronifer

[python-discord/branding] Pull request review submitted: #96 Adding Diwali assets

Everything looks great!

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #618 Wikiguess Game

Everything looks great good job!

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #616: Aoc fixes

Idk man, you didn't lint

#

dawnofmidnight

[python-discord/branding] Issue opened: #133 Thanksgiving Theme

Could we have a Thanksgiving theme?

I'm working on some other assets, so anyone could do this.

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #178 Bump @types/react\-dom from 17\.0\.1 to 17\.0\.2

#

HassanAbouelela

[forms-frontend:main] 2 new commits

fc5818b Bump @types/react-dom from 17.0.1 to 17.0.2 - dependabot[bot]
84473c8 Merge pull request #178 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #177 Bump @types/node from 14\.14\.31 to 14\.14\.32

#

HassanAbouelela

[forms-frontend:main] 2 new commits

e32dcc2 Bump @types/node from 14.14.31 to 14.14.32 - dependabot[bot]
26ff3cb Merge pull request #177 from python-discord/dep... - HassanAbouelela

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #616 Aoc fixes

regal archBOT Mar 9, 2021, 6:05 PM

#

AG4lyf

[python-discord/branding] New comment on issue #126: Holi logo

I am gonna be working on this one yayyy.

regal archBOT Mar 9, 2021, 6:29 PM

#

Kronifer

[python-discord/branding] Pull request review dismissed: #96 Adding Diwali assets

Everything looks great!

regal archBOT Mar 9, 2021, 8:58 PM

#

JagTheFriend

[python-discord/sir-lancebot] Pull request opened: #619 Added another alias and fixed a bug in Tic\-Tac\-Toe

Fixed bugs in the Tic-Tac-Toe

I changed the code up a bit,
So when the user tries to play the game with an opponent,
The program would first check whether the opponent is a bot or not.
If the bot is a opponent, then game would not start, instead
a message saying: "You can't play Tic-Tac-Toe with bots!" would be sent

Another alias

I also made a new alias called tic

odd spireBOT Mar 9, 2021, 8:59 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #619 Added another alias and fixed a bug in Tic-Tac-Toe

GitHub Actions run 637138056 failed.

PR Author

Workflow Run

Lint #477

Source Branch

JagTheFriend:master

#

[python-discord/sir-lancebot] Checks Successful on PR: #619 Added another alias and fixed a bug in Tic-Tac-Toe

GitHub Actions run 637145411 succeeded.

PR Author

Workflow Run

Lint #478

Source Branch

JagTheFriend:master

regal archBOT Mar 9, 2021, 9:32 PM

#

ToxicKidz

[python-discord/sir-lancebot] Pull request review submitted: #619 Added another alias and fixed a bug in Tic\-Tac\-Toe

#

ToxicKidz

[python-discord/sir-lancebot] New review comment on pull request #619: Added another alias and fixed a bug in Tic\-Tac\-Toe

async def tic_tac_toe(self, ctx: Context, opponent: t.Optional[discord.User]) -> None:

The return type hint here is None, yet you are returning a Message object.

            if opponent.bot:  # check whether the opponent is a bot or not
                await ctx.send("You can't play Tic-Tac-Toe with bots!")
                return

regal archBOT Mar 9, 2021, 10:15 PM

#

Slushs

[python-discord/bot] Issue opened: #1458 Improving help channels

Hey,

I was recently thinking about a smarter way the the help channels could be done. I was thinking that there could be one more channel category that could be called "Ready For Help". How this would work, I was thinking as a help channel is opened and if the user asks a question the channel would go into the "Ready For Help" until its receives a response from a different user.

regal archBOT Mar 9, 2021, 11:02 PM

#

TizzySaurus

[python-discord/sir-lancebot] Issue opened: #620 Incorrect Zodiac Dates

Description

The stored start/end dates of zodiac signs are mostly incorrect, resulting in dates given on the .zodiac command being incorrect, as well as the wrong zodiac sign being given in certain scenarios for the .zodiac date command.

Steps to Reproduce

Perform the .zodiac command (e.g. .zodiac scorpio / .zodiac date 22 november)

Expected Behaviour

The correct dates / zodiac sign should be shown

Actual Behaviour

Incorrect date / sign are shown:

...

#

Kronifer

[python-discord/sir-lancebot] Pull request opened: #621 Embed fix in earth\_photos

Relevant Issues

Fixes a small visual bug on mobile in the .earth_photos command

Description

Made a change suggested by ToxicKidz on discord shown [here](#sir-lancebot-playground message)

Reasoning

The bug was annoying

Screenshots

Before fix:
Screenshot_20210309-170341_Discord
After fix:
![Scree...

odd spireBOT Mar 9, 2021, 11:09 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #621 Embed fix in earth_photos

GitHub Actions run 637435947 succeeded.

PR Author

Kronifer

Workflow Run

Lint #479

Source Branch

Kronifer:earth_photos

regal archBOT Mar 10, 2021, 12:01 AM

#

AG4lyf

[python-discord/branding] New comment on pull request #96: Adding Diwali assets

i think with this
the pr is ready to be merged.
stale.

regal archBOT Mar 10, 2021, 3:11 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #616 Aoc fixes

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #616 Aoc fixes

#

Xithrius

[sir-lancebot:master] 4 new commits

6c89267 Properly rename countdown_task -> notification_... - Akarys42
e6e12c3 Restrict the aoc leaderboard commands to december - Akarys42
8b0c1cd Remove useless initialization in the AoC cog - Akarys42
3454a88 Merge pull request #616 from python-discord/aoc... - Xithrius

#

Xithrius

[python-discord/sir-lancebot] branch deleted: aoc\-fixes

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #619: Added another alias and fixed a bug in Tic\-Tac\-Toe

I don't feel like this change is necessary. If two items are returned at the same time, it will be returned as a tuple of those two items.

odd spireBOT Mar 10, 2021, 3:15 AM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 637948806 succeeded.

Actor

Workflow Run

Build #171

Commit

3454a88

night lilyBOT Mar 10, 2021, 3:16 AM

#

Sir Lancebot

Connected!

regal archBOT Mar 10, 2021, 3:41 AM

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

We can be sure that they're at the end, there may be more levels of them though. Parsing them for enabling splits inside is fairly easy as other brackets will have a = somewhere between them and the last comma, but I couldn't think of a nice way to then add them at the end when truncating without some ugly counting going on or something like that.
Come to think of it I don't recall seeing any symbols with a long signature and a optionals, as those are done for functions from extension modu...

#

Numerlor

[python-discord/bot] New review comment on pull request #1452: Remove invoked command and message after failure\.

I think with multiple renamed uses like this it'd be better to move it value to a more appropriate key, although I'm not sure where something general like it would fit

regal archBOT Mar 10, 2021, 4:06 AM

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Yeah, it's a bit involved, but I don't envision it being too ugly. It could be a done with a recursive parser that returns a flattened list of arguments while maintaining their opening/closing brackets, if present. A flat list is simple to truncate, but you do have to be mindful of the current depth of brackets at the truncation boundary so that you can insert the appropriate ellipses and closing brackets.

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Maybe making the parser return the text and depth as a tuple would make it cleaner. Or maybe not.

odd spireBOT Mar 10, 2021, 4:26 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #618 Wikiguess Game

GitHub Actions run 638099794 failed.

PR Author

Workflow Run

Lint #481

Source Branch

Shivansh-007:feature/wikipedia-game

#

[python-discord/sir-lancebot] Checks Successful on PR: #618 Wikiguess Game

GitHub Actions run 638113324 succeeded.

PR Author

Workflow Run

Lint #482

Source Branch

Shivansh-007:feature/wikipedia-game

regal archBOT Mar 10, 2021, 6:30 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #485 Pride Leader\(pl\)

regal archBOT Mar 10, 2021, 8:14 AM

#

gustavwilliam

[python-discord/branding] New comment on issue #132: Saint Patrick's Day theme

Yep, this already exists! Thanks for opening the issue, though.

#

gustavwilliam

[python-discord/branding] Issue closed: #132 Saint Patrick's Day theme

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #621: Embed fix in earth\_photos

                value=(
                    f"Photo by [{username}]({profile}{rf}) "
                    f"on [Unsplash](https://unsplash.com{rf})."
                )

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #621: Embed fix in earth\_photos

Maybe at this point it would be better to put it in a variable.

#

gustavwilliam

[python-discord/branding] New comment on issue #116: A winking lemoji

We have these two emojis already, but I personally don't have anything against adding a pure :lemon_wink: emoji. It would be a fun addition.
<img width="59" alt="Screenshot 2021-03-10 at 09 21 24" src="https://user-images.githubusercontent.com/65498475/110598405-ff5d4900-8181-11eb-8e0b-b3b0be66fbe8.png">

#

Akarys42

[python-discord/bot] New comment on issue #1458: Improving help channels

Hello @Slushs, thanks for your suggestion! Transferring this to the meta repo as it will need to be more discussed.

regal archBOT Mar 10, 2021, 8:48 AM

#

Akarys42

[python-discord/branding] Issue opened: #134 Create GitHub team icons

Currently our GitHub teams doesn’t have any icon, which is a bit of a shame. Here are the ones that could deserve one:

Admins
Mods
Core Devs
DevOps
Media
Generic event team

We shouldn’t spend too much time on this, but having some simple icons would be nice.

One of my idea would be to have a burple background with a white icon on top. If you have any better idea go for it, icon design isn’t my strong point.

oak estuaryBOT Mar 10, 2021, 9:47 AM

#

Python Bot

Connected!

regal archBOT Mar 10, 2021, 10:09 AM

#

Akarys42

[python-discord/site] Issue opened: #453 Remove the 100k banner

Now that we are approaching the 200k members (we are at around 160k at the time of writing), it would be nice to remove the 100k banner. We should still keep the wave and the overall new design brought by @scragly in #415.

The timeline should also be added to the “More” drop down in the navbar. For reference, here is how the site looked before this PR:

regal archBOT Mar 10, 2021, 10:37 AM

#

scragly

[python-discord/site] New comment on issue #453: Remove the 100k banner

I have two largish tasks to complete, so I am unsure on being able to get to this particular task, however I'd be happy to work on it as soon as I'm able to. I'm thinking about a month or so from now.

There was a 2nd stage semi planned that we never got around to thanks to my recent inactivity, so it would be good to see this actually completed properly.

regal archBOT Mar 10, 2021, 11:16 AM

#

bast0006

[python-discord/sir-lancebot] Issue opened: #622 Battleship game ends abruptly if given bad input

Description

Entering I9ASDF causes the battleship game to error and end.

Steps to Reproduce

Start a game, enter a valid target, then add more to the message before sending it. Any text will do.

Expected Behaviour

The bot to respond with a red X like it does for non-matching input (such as AAAA)

Actual Behaviour

The game ends abruptly with An error occurred. Game failed

Possible Solutions/Details

The core issue lies on this line: https://github.com/...

regal archBOT Mar 10, 2021, 12:04 PM

#

jb3

[python-discord/branding] New comment on issue #134: Create GitHub team icons

I need to clean up the GitHub Teams a bit, so the list might change slightly.

regal archBOT Mar 10, 2021, 12:55 PM

#

dawnofmidnight

[python-discord/site] New comment on issue #453: Remove the 100k banner

If you need help, I can assist. I've worked with raw CSS and Bulma before.

regal archBOT Mar 10, 2021, 1:37 PM

#

JagTheFriend

[python-discord/sir-lancebot] New review comment on pull request #619: Added another alias and fixed a bug in Tic\-Tac\-Toe

i just added to for no real reason :)

odd spireBOT Mar 10, 2021, 1:40 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #619 Added another alias and fixed a bug in Tic-Tac-Toe

GitHub Actions run 639437150 succeeded.

PR Author

Workflow Run

Lint #483

Source Branch

JagTheFriend:master

regal archBOT Mar 10, 2021, 1:50 PM

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #621: Embed fix in earth\_photos

it's not unfortunately

odd spireBOT Mar 10, 2021, 1:51 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #621 Embed fix in earth_photos

GitHub Actions run 639468365 succeeded.

PR Author

Kronifer

Workflow Run

Lint #484

Source Branch

Kronifer:earth_photos

regal archBOT Mar 10, 2021, 2:01 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #621: Embed fix in earth\_photos

oop mentioned wrong person there in https://github.com/python-discord/sir-lancebot/pull/621/commits/3939fa7e065a0ccab7e4aa0ece866ec99c016139

regal archBOT Mar 10, 2021, 3:53 PM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #621 Embed fix in earth\_photos

regal archBOT Mar 10, 2021, 4:19 PM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

We can probably raise a BadArgument error here, but am fine both the cases, the current one and raising a error (letting the error handler handle it).

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

Shouldn’t this comment be above the EASTER_COLOURS line.

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

I didn’t understand this line. Why are you double assigning the same variables to the same value?

regal archBOT Mar 10, 2021, 4:36 PM

#

HassanAbouelela

[python-discord/forms-frontend] New comment on pull request #182: Bump html\-webpack\-plugin from 5\.3\.0 to 5\.3\.1

@dependabot rebase

#

HassanAbouelela

[python-discord/forms-frontend] New comment on pull request #181: Bump @typescript\-eslint/eslint\-plugin from 4\.16\.1 to 4\.17\.0

@dependabot rebase

#

HassanAbouelela

[python-discord/forms-frontend] New comment on pull request #182: Bump html\-webpack\-plugin from 5\.3\.0 to 5\.3\.1

@dependabot recreate

#

HassanAbouelela

[python-discord/forms-frontend] New comment on pull request #181: Bump @typescript\-eslint/eslint\-plugin from 4\.16\.1 to 4\.17\.0

@dependabot recreate

#

HassanAbouelela

[python-discord/forms-frontend] New comment on pull request #183: Bump webpack from 5\.24\.3 to 5\.24\.4

@dependabot recreate

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #180 Bump @testing\-library/user\-event from 12\.8\.1 to 12\.8\.3

#

HassanAbouelela

[forms-frontend:main] 2 new commits

507421e Bump @testing-library/user-event from 12.8.1 to... - dependabot[bot]
0ef0997 Merge pull request #180 from python-discord/dep... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] Pull request closed: #184 Bump @types/node from 14\.14\.32 to 14\.14\.33

#

HassanAbouelela

[forms-frontend:main] 2 new commits

67c6afa Bump @types/node from 14.14.32 to 14.14.33 - dependabot[bot]
ca63db6 Merge pull request #184 from python-discord/dep... - HassanAbouelela

#

Shivansh-007

[python-discord/branding] Issue opened: #135 Create a logo for Trivia quiz game

The trivia quiz command on sir-lancebot currently lacks a branding/logo.

With the introduction on Wikipedia Guess Game along with it, I had like add a nice pretty logo on it as the thumbnail.

Feel free to discuss ideas here or in #media-branding on Discord. Give me a ping if you come with a nice idea/logo for it.

regal archBOT Mar 10, 2021, 5:38 PM

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1297: Implements Voice Channel Muting

Test has been removed in 1b9f8ee9.

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1297: Implements Voice Channel Muting

Thanks for the suggestion, addressed in 1b9f8ee9.

regal archBOT Mar 10, 2021, 5:53 PM

#

jb3

[sir-lancebot:pipenv\-to\-poetry] 9 new commits

2758242 Alter pre-commit - jb3
15c6dae Remove Pipfile and Pipfile.lock - jb3
390f731 Add poetry.lock and pyproject.toml - jb3
03ef262 Update Dockerfile - jb3
a40967b Load environment variables from .env - jb3

#

jb3

[python-discord/sir-lancebot] New branch created: pipenv\-to\-poetry

#

jb3

[sir-lancebot:pipenv\-to\-poetry] 1 new commit

6d2327e Bump lint workflow to py3.9 - jb3

#

jb3

[python-discord/sir-lancebot] Pull request opened: #623 Pipenv to poetry

This PR migrates the dependency manager for Sir Lancebot to Poetry.

This is not intended to be merged anytime soon but is more of an experiment to see whether the tool integrates well and has good support across platforms, hence why it is currently a draft.

There are minor things that have had to be altered in order to make support work, as it's building on Python 3.9.

If we decide to go through with this then we'll probably merge this and then make alterations to new Python 3.9 synt...

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1297: Implements Voice Channel Muting

Yeah, this test is quite redundant. I cleaned it up in aef979e6.

odd spireBOT Mar 10, 2021, 5:57 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #623 Pipenv to poetry

GitHub Actions run 640180611 failed.

PR Author

Workflow Run

Lint #485

Source Branch

pipenv-to-poetry

regal archBOT Mar 10, 2021, 6:13 PM

#

Akarys42

[python-discord/sir-lancebot] New review comment on pull request #623: Pipenv to poetry

If we want to go forth with this PR, this line will have to be changed :D

#

jb3

[python-discord/sir-lancebot] New review comment on pull request #623: Pipenv to poetry

Lol, I chose ignore authors and it does this.

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #621 Embed fix in earth\_photos

Looks good to me!

regal archBOT Mar 10, 2021, 6:56 PM

#

jb3

[sir-lancebot:pipenv\-to\-poetry] 2 new commits

aeb72c9 Disable poetry venv creation in Dockerfile and ... - jb3
57cfa3b Annotate Dockerfile - jb3

odd spireBOT Mar 10, 2021, 6:58 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #623 Pipenv to poetry

GitHub Actions run 640340186 succeeded.

PR Author

Workflow Run

Lint #486

Source Branch

pipenv-to-poetry

regal archBOT Mar 10, 2021, 7:00 PM

#

jb3

[sir-lancebot:pipenv\-to\-poetry] 1 new commit

1cb0b20 Change authors value in pyproject.toml - jb3

#

jb3

[python-discord/sir-lancebot] New review comment on pull request #623: Pipenv to poetry

Addressed in 1cb0b203bb3af2f9377786aae672593783946314

odd spireBOT Mar 10, 2021, 7:02 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #623 Pipenv to poetry

GitHub Actions run 640349787 succeeded.

PR Author

Workflow Run

Lint #487

Source Branch

pipenv-to-poetry

regal archBOT Mar 10, 2021, 7:14 PM

#

HassanAbouelela

[python-discord/bot] New comment on pull request #1297: Implements Voice Channel Muting

Thanks for the last review round. I'm slowly working through everything, but I'll rerequest review when the branch is ready.

odd spireBOT Mar 10, 2021, 7:17 PM

#

[python-discord/bot] Checks Successful on PR: #1297 Implements Voice Channel Muting

GitHub Actions run 640388911 succeeded.

PR Author

Workflow Run

Lint & Test #648

Source Branch

HassanAbouelela:voicechann...

regal archBOT Mar 10, 2021, 7:21 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #621: Embed fix in earth\_photos

@Xithrius could you review

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #621: Embed fix in earth\_photos

Oops sorry Chris, hit the wrong thing

#

jb3

[python-discord/workers] New star added

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #611: Full support for Gitpod

I don't think so, there aren't many browser dev environments used besides these two @HassanAbouelela

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #621 Embed fix in earth\_photos

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #621 Embed fix in earth\_photos

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #621 Embed fix in earth\_photos

#

Xithrius

[sir-lancebot:master] 5 new commits

ccfb8a7 small style fix - Kronifer
abc41bd embed fix - Kronifer
3939fa7 suggestion by @Xithrius - Kronifer
6e9a71c Merge branch 'master' into earth_photos - Xithrius
1d3860d Merge pull request #621 from Kronifer/earth_photos - Xithrius

odd spireBOT Mar 10, 2021, 7:30 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #621 Embed fix in earth_photos

GitHub Actions run 640427467 succeeded.

PR Author

Kronifer

Workflow Run

Lint #488

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 640432348 succeeded.

Actor

Workflow Run

Build #173

Commit

1d3860d

regal archBOT Mar 10, 2021, 7:33 PM

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #619: Added another alias and fixed a bug in Tic\-Tac\-Toe

Then I'm removing this change.

night lilyBOT Mar 10, 2021, 7:33 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 10, 2021, 7:37 PM

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

Yes, its a little more complicated than that, as file name is defined within _effects.apply_effect. I can pass through a str var for the filename though. Will do that in a future commit.

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 3 new commits

2ff5096 Move colours to constants - ChrisLovering
3d54a88 Improve docstring and split line for readibility - ChrisLovering
33141d9 Remove double assignment of a variable - ChrisLovering

odd spireBOT Mar 10, 2021, 7:39 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #619 Added another alias and fixed a bug in Tic-Tac-Toe

GitHub Actions run 640452943 succeeded.

PR Author

Workflow Run

Lint #491

Source Branch

JagTheFriend:master

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 640452488 succeeded.

PR Author

Workflow Run

Lint #490

Source Branch

Enforce-image-processing-concurrency

regal archBOT Mar 10, 2021, 7:40 PM

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1297: Implements Voice Channel Muting

I knew there must've been a better way haha. Thank you. Changed in b867fb21.

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #619 Added another alias and fixed a bug in Tic\-Tac\-Toe

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #619 Added another alias and fixed a bug in Tic\-Tac\-Toe

Thanks for your contribution!

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #619 Added another alias and fixed a bug in Tic\-Tac\-Toe

#

Xithrius

[sir-lancebot:master] 2 new commits

11bf370 Removed requesting to bots. Added grammer. - JagTheFriend
10b98e9 Merge pull request #619 from JagTheFriend/master - Xithrius

odd spireBOT Mar 10, 2021, 7:47 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 640468694 succeeded.

Actor

Workflow Run

Build #175

Commit

10b98e9

night lilyBOT Mar 10, 2021, 7:48 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 10, 2021, 11:40 PM

#

mbaruh

[bot:mbaruh/autoreview] 5 new commits

6f880bb Moved talentpool to a new recruitment extension - mbaruh
65f93df Rename talentpool.py to _cog.py - mbaruh
f7f38d3 Make talentpool a package and move cog load to ... - mbaruh
f6b608a Add init.py to recruitment - mbaruh
4f08f04 Added an auto-reviewer to the talentpool cog - mbaruh

#

mbaruh

[python-discord/bot] New branch created: mbaruh/autoreview

regal archBOT Mar 11, 2021, 12:13 AM

#

mbaruh

[python-discord/bot] Pull request opened: #1459 Mbaruh/autoreview

This is blocked by python-discord/site#451

This closes #1423 and #1424

Reorganization

This PR requires the code to be split across multiple files. To avoid unnecessary file moves, I moved the files to a separate recruitment extension now instead of waiting for #1422.

Talentpool listing

The user's name and discriminator are now shown.
It is shown whether the user's automatic review is scheduled or if it was already posted.
Users who left the server are crossed of...

odd spireBOT Mar 11, 2021, 12:15 AM

#

[python-discord/bot] Checks Successful on PR: #1459 Mbaruh/autoreview

GitHub Actions run 641099543 succeeded.

PR Author

Workflow Run

Lint & Test #649

Source Branch

mbaruh/autoreview

regal archBOT Mar 11, 2021, 12:21 AM

#

jb3

[python-discord/site] Pull request review submitted: #451 Add route to get a member's data for helper review

All looking good! Couple of minor comments.

#

jb3

[python-discord/site] New review comment on pull request #451: Add route to get a member's data for helper review

Grammar here is irking me a bit.

                    WHEN channels.name ILIKE 'help-%%' THEN 'Help channels'
                    WHEN channels.name ILIKE 'ot%%' THEN 'Off topic'

#

jb3

[python-discord/site] New review comment on pull request #451: Add route to get a member's data for helper review

Do we want to include deleted messages (probably a minor thing)?

If not:

                author_id = '%s' AND NOT messages.is_deleted

Otherwise, please ignore.

#

gustavwilliam

[python-discord/branding] New comment on issue #134: Create GitHub team icons

Should we stall this until there's an updated list available?

#

jb3

[python-discord/branding] New comment on issue #134: Create GitHub team icons

List updated. Everything here is fine except that the Event Team has been removed.

#

mbaruh

[python-discord/site] New review comment on pull request #451: Add route to get a member's data for helper review

The purpose of those names is to be used in a sentence, rather than titles, although I agree it's not the prettiest

#

mbaruh

[site:mbaruh/channel\-activity] 1 new commit

fdc1be6 Ignore deleted messaages in message counts - mbaruh

#

mbaruh

[site:mbaruh/channel\-activity] 32 new commits

9ac4773 Split nomination model to 2 tables and create m... - ks129
ff46d9f Change nominations admin interface and add nomi... - ks129
4bc55a5 Change nominations serializer and add nominatio... - ks129
51c57d3 Update nominations viewset GET and POST to make... - ks129
71388ff Add reviewed field to nomination serializer - ks129

odd spireBOT Mar 11, 2021, 12:39 AM

#

[python-discord/site] Checks Successful on PR: #451 Add route to get a member's data for helper review

GitHub Actions run 641151299 succeeded.

PR Author

Workflow Run

Lint & Test #124

Source Branch

mbaruh/channel-activity

#

[python-discord/site] Checks Successful on PR: #451 Add route to get a member's data for helper review

GitHub Actions run 641154966 succeeded.

PR Author

Workflow Run

Lint & Test #125

Source Branch

mbaruh/channel-activity

regal archBOT Mar 11, 2021, 12:59 AM

#

mbaruh

[bot:mbaruh/autoreview] 1 new commit

0eb8059 Limit new commands to mods+ - mbaruh

#

jb3

[python-discord/site] New review comment on pull request #451: Add route to get a member's data for helper review

Ah, gotcha, I thought it would be more a sort of list like ```
Help channels: 24,404 messages
Off topic: 12,000 messages
...: ... messages

odd spireBOT Mar 11, 2021, 1:02 AM

#

[python-discord/bot] Checks Successful on PR: #1459 Talentpool Autoreview

GitHub Actions run 641198628 succeeded.

PR Author

Workflow Run

Lint & Test #650

Source Branch

mbaruh/autoreview

regal archBOT Mar 11, 2021, 1:41 AM

#

mbaruh

[python-discord/bot] New comment on issue #393: Deferred moderative action

Interesting to see that this issue has been open since August 2019 haha

In terms of today's bot, the plans are to import the idea we had for rattlesnake. Yes, it will most likely make use of redis.

regal archBOT Mar 11, 2021, 7:28 AM

#

Shivansh-007

[python-discord/bot] New comment on issue #1427: Place 3 help channels in the available pool

We should remove good first issue label from this issue (#1427) and add a status: deferred label since there are problems in on_typing event of discord.py.

Context: #dev-contrib message

#

Akarys42

[python-discord/branding] New comment on issue #134: Create GitHub team icons

That was probably poorly explained, but my thought was to have a special icon for temporary or team created for an event that is bound to disappear. Like a star or something generic.

regal archBOT Mar 11, 2021, 2:30 PM

#

JagTheFriend

[python-discord/sir-lancebot] New comment on pull request #619: Added another alias and fixed a bug in Tic\-Tac\-Toe

Thanks for your contribution!

np x)

regal archBOT Mar 11, 2021, 3:43 PM

#

ToxicKidz

[python-discord/sir-lancebot] Issue opened: #624 Using group commands without specifying a subcommand sends the default help command\.

Description

Whenever someone uses a group command without providing a subcommand, it sends the default help command instead of the one we already have.:

Steps to Reproduce

If I just do .group_name, it sends the default help command.

Expected Behaviour

It should use our help command, so it should look like this:

Actual Behaviour

It sends this:
![image...

regal archBOT Mar 11, 2021, 5:55 PM

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 1 new commit

d90f735 Use a more specific filename for avatar modifiy... - ChrisLovering

odd spireBOT Mar 11, 2021, 5:57 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 643670197 succeeded.

PR Author

Workflow Run

Lint #493

Source Branch

Enforce-image-processing-concurrency

regal archBOT Mar 11, 2021, 6:01 PM

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 1 new commit

6c1b715 Update docstring to refer to groups rather than... - ChrisLovering

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 2 new commits

856cffb Defer errors in pride image to error handler - ChrisLovering
d55b92b Merge branches 'Enforce-image-processing-concur... - ChrisLovering

odd spireBOT Mar 11, 2021, 6:02 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 643684465 succeeded.

PR Author

Workflow Run

Lint #494

Source Branch

Enforce-image-processing-concurrency

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 643684834 succeeded.

PR Author

Workflow Run

Lint #495

Source Branch

Enforce-image-processing-concurrency

regal archBOT Mar 11, 2021, 6:06 PM

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 1 new commit

335702f Fix filename for spooky effect avatars - ChrisLovering

odd spireBOT Mar 11, 2021, 6:07 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 643697988 succeeded.

PR Author

Workflow Run

Lint #496

Source Branch

Enforce-image-processing-concurrency

regal archBOT Mar 11, 2021, 6:50 PM

#

HassanAbouelela

[python-discord/bot] New comment on issue #1457: Shorten PyPI Embed

I think the latter sounds better. Feel free to grab the issue 😄.

regal archBOT Mar 11, 2021, 8:50 PM

#

mbaruh

[bot:mbaruh/autoreview] 1 new commit

608f755 The 'seen vote' emoji is now a random ducky. - mbaruh

odd spireBOT Mar 11, 2021, 8:53 PM

#

[python-discord/bot] Checks Successful on PR: #1459 Talentpool Autoreview

GitHub Actions run 644106811 succeeded.

PR Author

Workflow Run

Lint & Test #651

Source Branch

mbaruh/autoreview

regal archBOT Mar 11, 2021, 9:03 PM

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #614 Tech Leaders Pride

Looks good so far, will review once at a computer and can test

regal archBOT Mar 11, 2021, 11:00 PM

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #624: Using group commands without specifying a subcommand sends the default help command\.

Dew it.

#

kwzrd

[python-discord/bot] Pull request opened: #1460 Compose: read GitHub API key from '\.env'

When running with Compose, the GITHUB_API_KEY env var isn't being read from .env into the container, causing harsh rate limits when making unauthenticated requests. With this PR, the env var is set and made available on constants.Keys.github.

Please note that this causes different behaviour when there's no key set in the .env ~ after this PR, constants.Keys.github will resolve to an empty string, rather than None. However, the two places that read this constant check it for tru...

odd spireBOT Mar 11, 2021, 11:13 PM

#

[python-discord/bot] Checks Successful on PR: #1460 Compose: read GitHub API key from '.env'

GitHub Actions run 644424648 succeeded.

PR Author

kwzrd

Workflow Run

Lint & Test #652

Source Branch

kwzrd:kwzrd/compose-read-github-api-...

regal archBOT Mar 11, 2021, 11:21 PM

#

ToxicKidz

[python-discord/sir-lancebot] Pull request opened: #625 change ctx\.send\_help to ctx\.invoke\(help\_command\)

;

Relevant Issues

Closes #624

Description

I've changed all the ctx.send_help's to bot.get_command("help") and ctx.invoke(help_command, ctx.command.name).

Reasoning

Screenshots

Before:

After:

Additional Details

Affected ...

odd spireBOT Mar 11, 2021, 11:23 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #625 change ctx.send_help to ctx.invoke(help_command)

GitHub Actions run 644448443 succeeded.

PR Author

Workflow Run

Lint #497

Source Branch

ToxicKidz:no-ctx-send-help

regal archBOT Mar 11, 2021, 11:31 PM

#

MarkKoz

[python-discord/bot] New comment on pull request #1460: Compose: read GitHub API key from '\.env'

It could just read everything from the file with env_file: .env. Why don't we do that?

regal archBOT Mar 12, 2021, 12:01 AM

#

kwzrd

[python-discord/bot] New comment on pull request #1460: Compose: read GitHub API key from '\.env'

Okay, let's do that.

odd spireBOT Mar 12, 2021, 12:01 AM

#

[python-discord/bot] Checks Successful on PR: #1460 Compose: read GitHub API key from '.env'

GitHub Actions run 644524802 succeeded.

PR Author

kwzrd

Workflow Run

Lint & Test #653

Source Branch

kwzrd:kwzrd/compose-read-github-api-...

odd spireBOT Mar 12, 2021, 12:34 AM

#

[python-discord/bot] Checks Successful on PR: #1460 Compose: read all env vars from '.env'

GitHub Actions run 644593706 succeeded.

PR Author

kwzrd

Workflow Run

Lint & Test #654

Source Branch

kwzrd:kwzrd/compose-read-github-api-...

regal archBOT Mar 12, 2021, 1:29 AM

#

Xithrius

[python-discord/bot] New review comment on pull request #1452: Remove invoked command and message after failure\.

I'm not sure either, but I think this should be discussed within the future.

I'm going to rename NOT_FOUND_DELETE_DELAY to ON_ERROR_DELETE_DELAY to describe the situations more accurately.

#

Xithrius

[bot:pypi\-delete\-on\-not\-found] 1 new commit

d0fd687 NOT_FOUND_DELETE_DELAY to INVALID_INPUT_DELETE_... - Xithrius

odd spireBOT Mar 12, 2021, 1:36 AM

#

[python-discord/bot] Checks Failed on PR: #1452 Remove invoked command and message after failure.

GitHub Actions run 644725495 failed.

PR Author

Workflow Run

Lint & Test #655

Source Branch

pypi-delete-on-not-found

regal archBOT Mar 12, 2021, 1:44 AM

#

Xithrius

[bot:pypi\-delete\-on\-not\-found] 1 new commit

c124df8 Renamed variables. - Xithrius

#

Xithrius

[bot] Branch pypi\-delete\-on\-not\-found was force-pushed to `92bfdd3`

odd spireBOT Mar 12, 2021, 1:47 AM

#

[python-discord/bot] Checks Successful on PR: #1452 Remove invoked command and message after failure.

GitHub Actions run 644745580 succeeded.

PR Author

Workflow Run

Lint & Test #656

Source Branch

pypi-delete-on-not-found

#

[python-discord/bot] Checks Successful on PR: #1452 Remove invoked command and message after failure.

GitHub Actions run 644746822 succeeded.

PR Author

https://cdn.discordapp.com/attachments/753252897059373066/819712051848151040/v1.gif

Workflow Run

Lint & Test #657

Source Branch

pypi-delete-on-not-found

regal archBOT Mar 12, 2021, 1:54 AM

#

Xithrius

[python-discord/bot] Pull request review submitted: #1460 Compose: read all env vars from '\.env'

regal archBOT Mar 12, 2021, 2:21 AM

#

fisher60

[python-discord/bot] Pull request review submitted: #1452 Remove invoked command and message after failure\.

LGTM

regal archBOT Mar 12, 2021, 3:03 AM

#

xkawixgirlx

[python-discord/branding] New comment on commit `e985aac`

This is a commit to issue #135.
Logo for Trivia

regal archBOT Mar 12, 2021, 4:09 AM

#

xkawixgirlx

[python-discord/branding] Pull request opened: #136 Create Python Logo\_trivia\-08\.png

This is the Trivia Logo.

regal archBOT Mar 12, 2021, 4:43 AM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1460 Compose: read all env vars from '\.env'

#

MarkKoz

[python-discord/bot] Pull request closed: #1460 Compose: read all env vars from '\.env'

#

MarkKoz

[bot:master] 3 new commits

326cd6d Compose: read GitHub API key from '.env' - kwzrd
a8c0da0 Compose: read all environment variables from '.... - kwzrd
28e4ff0 Merge PR #1460 - compose: read all env vars fro... - MarkKoz

oak estuaryBOT Mar 12, 2021, 4:47 AM

#

Python Bot

Connected!

odd spireBOT Mar 12, 2021, 4:48 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 645099012 succeeded.

Actor

MarkKoz

Workflow Run

Deploy #190

Commit

28e4ff0

regal archBOT Mar 12, 2021, 4:51 AM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1455 Allow the sf command to take more than one snowflake at the time

regal archBOT Mar 12, 2021, 5:24 AM

#

MarkKoz

[python-discord/site] Pull request review submitted: #451 Add route to get a member's data for helper review

#

MarkKoz

[python-discord/site] New review comment on pull request #451: Add route to get a member's data for helper review

There should be subtests to test each case in the query (i.e. you need to test off topic and help channels too).

#

MarkKoz

[python-discord/site] New review comment on pull request #451: Add route to get a member's data for helper review

It'd be better to make a separate test for each endpoint. In any case, the names response1 and response2 aren't great.

#

MarkKoz

[python-discord/site] New review comment on pull request #451: Add route to get a member's data for helper review

Document this endpoint in the viewset's docstring above.

regal archBOT Mar 12, 2021, 6:31 AM

#

MarkKoz

[python-discord/bot] New comment on pull request #1459: Talentpool Autoreview

I'm not sold on the current design that subclasses Scheduler. The main reason is that it doesn't provide much benefit over exposing the scheduler as an attribute. You stated yourself that it's unclear that the class is also a scheduler. If it was exposed as an attribute, the code would be more explicit.

The other issue with the design is that the subclass does a lot more than just scheduling. There's basically 1 function, schedule_review, that is directly tied to the scheduler. One may...

regal archBOT Mar 12, 2021, 7:30 AM

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

The command takes in user as argument but doesn't use it while converting the image into bytes.

            image_bytes = await user.avatar_url.read()

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

                author=user.display_name

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

Last requested change 🎉

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

            embed.set_footer(text=f"Made by {user.display_name}.", icon_url=user.avatar_url)

regal archBOT Mar 12, 2021, 7:53 AM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #625 change ctx\.send\_help to ctx\.invoke\(help\_command\)

Can we add help_command a class attribute in Bot class in bot/bot.py, then we could just do:

await ctx.invoke(self.bot.help_command, ctx.command.name)

regal archBOT Mar 12, 2021, 8:45 AM

#

anand2312

[python-discord/sir-lancebot] New comment on pull request #625: change ctx\.send\_help to ctx\.invoke\(help\_command\)

Can we add help_command a class attribute in Bot class in bot/bot.py, then we could just do:
await ctx.invoke(self.bot.help_command, ctx.command.name)

bot.help_command is an attribute of commands.Bot and has to be of type HelpCommand. I don't know how overriding this with something that is not of that type will work.

#

Shivansh-007

[python-discord/sir-lancebot] New comment on pull request #625: change ctx\.send\_help to ctx\.invoke\(help\_command\)

Can we add help_command a class attribute in Bot class in bot/bot.py, then we could just do:
await ctx.invoke(self.bot.help_command, ctx.command.name)
bot.help_command is an attribute of commands.Bot and has to be of type HelpCommand. I don't know how overriding this with something that is not of that type will work.

Ah right! Forgot ...

regal archBOT Mar 12, 2021, 10:46 AM

#

AG4lyf

[python-discord/branding] Issue opened: #137 RGB animated logo

A draft was given by me in media-branding channel with following content

although it doesn't follow the 3 second animation 5 second rest rule. it is still viable to use 7 seconds of animation saying there is nothing to focus on.

regal archBOT Mar 12, 2021, 11:15 AM

#

mbaruh

[python-discord/bot] New comment on pull request #1459: Talentpool Autoreview

Hmm I get what you're saying about not subclassing it and making an attribute instead, but is it really better to apply changes to the scheduler directly from outside? I'd say it's clearer to write the methods that define how to interact with the class.

regal archBOT Mar 12, 2021, 12:16 PM

#

mbaruh

[bot:mbaruh/autoreview] 1 new commit

de0bc6e Reviewer no longer subclasses Scheduler - mbaruh

odd spireBOT Mar 12, 2021, 12:19 PM

#

[python-discord/bot] Checks Successful on PR: #1459 Talentpool Autoreview

GitHub Actions run 646135383 succeeded.

PR Author

Workflow Run

Lint & Test #659

Source Branch

mbaruh/autoreview

regal archBOT Mar 12, 2021, 1:10 PM

#

Akarys42

[python-discord/bot] Pull request review submitted: #1452 Remove invoked command and message after failure\.

Setting error to true then false feels a bit weird, but I guess that works. Thanks sir Xith.

#

Akarys42

[bot:pypi\-delete\-on\-not\-found] 4 new commits

326cd6d Compose: read GitHub API key from '.env' - kwzrd
a8c0da0 Compose: read all environment variables from '.... - kwzrd
28e4ff0 Merge PR #1460 - compose: read all env vars fro... - MarkKoz
1223aea Merge branch 'master' into pypi-delete-on-not-f... - Akarys42

odd spireBOT Mar 12, 2021, 1:13 PM

#

[python-discord/bot] Checks Successful on PR: #1452 Remove invoked command and message after failure.

GitHub Actions run 646277631 succeeded.

PR Author

Workflow Run

Lint & Test #660

Source Branch

pypi-delete-on-not-found

regal archBOT Mar 12, 2021, 1:17 PM

#

mbaruh

[bot:mbaruh/autoreview] 1 new commit

4f17ba5 Improve string building for long lines - mbaruh

#

Akarys42

[python-discord/bot] Issue closed: #1443 Delete messages when \`\!pypi\` module is invalid

#

Akarys42

[python-discord/bot] branch deleted: pypi\-delete\-on\-not\-found

#

Akarys42

[bot:master] 3 new commits

92bfdd3 Remove invoked command and message after failure. - Xithrius
1223aea Merge branch 'master' into pypi-delete-on-not-f... - Akarys42
7d9a406 Merge pull request #1452 from python-discord/py... - Akarys42

#

Akarys42

[python-discord/bot] Pull request closed: #1452 Remove invoked command and message after failure\.

odd spireBOT Mar 12, 2021, 1:19 PM

#

[python-discord/bot] Checks Successful on PR: #1459 Talentpool Autoreview

GitHub Actions run 646294214 succeeded.

PR Author

Workflow Run

Lint & Test #661

Source Branch

mbaruh/autoreview

oak estuaryBOT Mar 12, 2021, 1:21 PM

#

Python Bot

Connected!

odd spireBOT Mar 12, 2021, 1:21 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 646302731 succeeded.

Actor

Workflow Run

Deploy #191

Commit

7d9a406

regal archBOT Mar 12, 2021, 1:49 PM

#

Akarys42

[python-discord/sir-lancebot] Pull request review submitted: #625 change ctx\.send\_help to ctx\.invoke\(help\_command\)

LGTM, thanks a lot!

#

Akarys42

[bot:master] 1 new commit

e82931b Fix typo in the token remover - Akarys42

oak estuaryBOT Mar 12, 2021, 1:55 PM

#

Python Bot

Connected!

odd spireBOT Mar 12, 2021, 1:56 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 646393705 succeeded.

Actor

Workflow Run

Deploy #192

Commit

e82931b

regal archBOT Mar 12, 2021, 3:40 PM

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1459 Talentpool Autoreview

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

        To permanently cancel someone's review, either remove them from the pool, or use mark_reviewed.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

review = (
  f"They were nominated **{nomination_times}** before"
  f", but their nomination was called off **{rejection_times}**."
)

Can we use this method instead of combining multiple strings, am not a big fan of the current one.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

There is no class attribute named self.log, probably a typo:

                log.trace(f"Nomination API 404: Can't find nomination with id {nomination_id}")

regal archBOT Mar 12, 2021, 4:08 PM

#

Xithrius

[python-discord/bot] Pull request review submitted: #1455 Allow the sf command to take more than one snowflake at the time

#

Xithrius

[bot:many\-snowflakes] 30 new commits

54952d1 Add disable_header to watchchannel to disable t... - ks129
86988b6 Migrate talentpool to new schema - ks129
b9141ea Add parentheses back to previous nominations count - ks129
4532b40 Fix trace logging of nomination 404 - ks129
ce5fb70 Fix grammar of nomination cog - ks129

odd spireBOT Mar 12, 2021, 4:12 PM

#

[python-discord/bot] Checks Successful on PR: #1455 Allow the sf command to take more than one snowflake at the time

GitHub Actions run 646760602 succeeded.

PR Author

Workflow Run

Lint & Test #664

Source Branch

many-snowflakes

regal archBOT Mar 12, 2021, 4:14 PM

#

Akarys42

[python-discord/bot] Pull request closed: #1455 Allow the sf command to take more than one snowflake at the time

#

Akarys42

[bot:master] 4 new commits

7a97eec Make the snowflake command accept many snowflakes - Akarys42
0a2e08c Restrict non-staffer to one snowflake at the time - Akarys42
b6fea4a Merge branch 'master' into many-snowflakes - Xithrius
7f531a0 Merge pull request #1455 from python-discord/ma... - Akarys42

#

Akarys42

[python-discord/bot] branch deleted: many\-snowflakes

oak estuaryBOT Mar 12, 2021, 4:18 PM

#

Python Bot

Connected!

odd spireBOT Mar 12, 2021, 4:19 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 646783849 succeeded.

Actor

Workflow Run

Deploy #193

Commit

7f531a0

regal archBOT Mar 12, 2021, 4:35 PM

#

MrKomodoDragon

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

LGTM!

regal archBOT Mar 12, 2021, 7:18 PM

#

ToxicKidz

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Why is this an async function? I don't see it await'ing anything.

    def make_embed(query: str, link: str) -> Embed:

#

ToxicKidz

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

I don't think you can create an embed object within a sync function.

regal archBOT Mar 12, 2021, 7:39 PM

#

Xithrius

[bot:simplify\-pypi] 1 new commit

5e5e6e5 Added '_' to allowed chars, shortened embed. - Xithrius

#

Xithrius

[python-discord/bot] New branch created: simplify\-pypi

#

anand2312

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Why not? Sync function

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Huh, I guess I was wrong. maybe in previous versions that was a thing? Not sure.

#

ToxicKidz

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

I don't think you can create an embed object within a sync function.

Why not?

#

Xithrius

[bot:simplify\-pypi] 1 new commit

951d59c Replaced field with a description. - Xithrius

#

Xithrius

[python-discord/bot] Pull request opened: #1461 Simplify pypi

Information besides summary is not very useful.

The license, Python version needed, and author has been removed.

Only the summary remains, with the title staying as a hyperlink to the package name with the current version.

Here's some examples of what the new embed looks like:

#

Xithrius

[bot:simplify\-pypi] 12 new commits

7a97eec Make the snowflake command accept many snowflakes - Akarys42
0a2e08c Restrict non-staffer to one snowflake at the time - Akarys42
326cd6d Compose: read GitHub API key from '.env' - kwzrd
a8c0da0 Compose: read all environment variables from '.... - kwzrd
92bfdd3 Remove invoked command and message after failure. - Xithrius

odd spireBOT Mar 12, 2021, 8:10 PM

#

[python-discord/bot] Checks Successful on PR: #1461 Simplifying the PyPi command.

GitHub Actions run 647302518 succeeded.

PR Author

Workflow Run

Lint & Test #666

Source Branch

simplify-pypi

regal archBOT Mar 12, 2021, 8:17 PM

#

Xithrius

[bot:dynamic\-available\-message\-patch] 2 new commits

fb74ec0 Cleared up messages in logs. - Xithrius
c242c37 First dynamic update moved to the init_availabl... - Xithrius

odd spireBOT Mar 12, 2021, 8:20 PM

#

[python-discord/bot] Checks Successful on PR: #1414 Reworked dynamic available help message logic.

GitHub Actions run 647326718 succeeded.

PR Author

Workflow Run

Lint & Test #667

Source Branch

dynamic-available-message-patch

regal archBOT Mar 12, 2021, 8:56 PM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1461 Simplifying the PyPi command\.

No major changes, everything seems good.

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1461: Simplifying the PyPi command\.

Could we possibily have a "No Description Provided" for packages with no descriptions?

#

Xithrius

[python-discord/bot] New review comment on pull request #1461: Simplifying the PyPi command\.

Yes.

#

Xithrius

[bot:simplify\-pypi] 2 new commits

a1991c1 'No summary provided' when there's no summary. - Xithrius
a693c20 Merge branch 'simplify-pypi' of https://github.... - Xithrius

odd spireBOT Mar 12, 2021, 9:07 PM

#

[python-discord/bot] Checks Successful on PR: #1461 Simplifying the PyPi command.

GitHub Actions run 647430400 succeeded.

PR Author

Workflow Run

Lint & Test #668

Source Branch

simplify-pypi

regal archBOT Mar 12, 2021, 9:08 PM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1461 Simplifying the PyPi command\.

🆗 👌 🙆‍♂️ 🙆 🙆‍♀️ 👍 💯 🥇

#

Xithrius

[bot] Branch simplify\-pypi was force-pushed to `1b1e7ad`

odd spireBOT Mar 12, 2021, 9:16 PM

#

[python-discord/bot] Checks Successful on PR: #1461 Simplifying the PyPi command.

GitHub Actions run 647453615 succeeded.

PR Author

Workflow Run

Lint & Test #669

Source Branch

simplify-pypi

regal archBOT Mar 12, 2021, 9:50 PM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1461 Simplifying the PyPi command\.

Still looks good to me, but I'm all out of emojis.

regal archBOT Mar 12, 2021, 11:09 PM

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1461 Simplifying the PyPi command\.

Thanks! Looks Good To Me!

odd spireBOT Mar 12, 2021, 11:23 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #605 Add WTF Python Command

GitHub Actions run 647726397 succeeded.

PR Author

Workflow Run

Lint #498

Source Branch

Shivansh-007:feature/wtf-python

regal archBOT Mar 12, 2021, 11:27 PM

#

ToxicKidz

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

LGTM!

odd spireBOT Mar 13, 2021, 12:19 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #625 change ctx.send_help to ctx.invoke(help_command)

GitHub Actions run 647832485 failed.

PR Author

Workflow Run

Lint #499

Source Branch

ToxicKidz:no-ctx-send-help

regal archBOT Mar 13, 2021, 12:33 AM

#

mbaruh

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

Well, it's already unicode, and I think the code reads better that way

#

mbaruh

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

That's called a bad copy-paste :D

#

mbaruh

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

It could, but I'm not sure if it's a good idea to load the file with functions that are only used in a single file and could pass as just simple helper functions. We can move it when needed, like I did with get_time_delta in this PR

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

Am not sure whether this style in followed in bot or not, but it is certainly followed in sir-lancebot (emojis are used as unicode characters).

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

Sounds good! :D

#

mbaruh

[python-discord/bot] New review comment on pull request #1459: Talentpool Autoreview

I think what I wrote here is correct, it's a list of nominated users, hence a nominated users list :D

odd spireBOT Mar 13, 2021, 1:02 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #625 change ctx.send_help to ctx.invoke(help_command)

GitHub Actions run 647915624 failed.

PR Author

Workflow Run

Lint #500

Source Branch

ToxicKidz:no-ctx-send-help

#

[python-discord/sir-lancebot] Checks Successful on PR: #625 change ctx.send_help to ctx.invoke(help_command)

GitHub Actions run 647924895 succeeded.

PR Author

Workflow Run

Lint #501

Source Branch

ToxicKidz:no-ctx-send-help

#

[python-discord/bot] Checks Successful on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 647925548 succeeded.

PR Author

Workflow Run

Lint & Test #670

Source Branch

Shivansh-007:feature/enhance-...

regal archBOT Mar 13, 2021, 1:28 AM

#

MrKomodoDragon

[python-discord/bot] Pull request review submitted: #1461 Simplifying the PyPi command\.

LGTM!

#

Shivansh-007

[python-discord/branding] New comment on pull request #136: Create Python Logo\_trivia\-08\.png

This is a icon, and hence should go into icons/trivia_quiz.
Can you also include a .svg of the Icon?
The files should be formatted this way: trivia-quiz-dist.png and trivia-quiz-src.svg

#

ToxicKidz

[python-discord/bot] New review comment on pull request #1461: Simplifying the PyPi command\.

Do you think it would be better to use ILLEGAL_CHARACTERS.search?

        if characters := ILLEGAL_CHARACTERS.search(package):

#

ToxicKidz

[python-discord/bot] Pull request review submitted: #1461 Simplifying the PyPi command\.

#

Xithrius

[python-discord/bot] New review comment on pull request #1461: Simplifying the PyPi command\.

I don't see how this would improve the code.

#

ToxicKidz

[python-discord/bot] New review comment on pull request #1461: Simplifying the PyPi command\.

I don't see how this would improve the code.

Hmm I guess so.

regal archBOT Mar 13, 2021, 5:02 AM

#

MarkKoz

[smartconfig:package\-develop] 5 new commits

cc39305 Rename overwrote_attributes to overwritten_attr... - MarkKoz
98d9d18 Refactor registry - MarkKoz
aa0ee0b Separate registry functions - MarkKoz
fc39676 Ignore non-mapping parent nodes when unloading ... - MarkKoz
4293f9b Use a more generic type to type check mapping n... - MarkKoz

regal archBOT Mar 13, 2021, 5:42 AM

#

ks129

[python-discord/bot] Pull request review submitted: #1461 Simplifying the PyPi command\.

#

ks129

[python-discord/bot] Pull request closed: #1461 Simplifying the PyPi command\.

#

ks129

[python-discord/bot] branch deleted: simplify\-pypi

#

ks129

[bot:master] 2 new commits

1b1e7ad Added '_' to allowed chars, shortened embed. - Xithrius
5856fe4 Merge pull request #1461 from python-discord/si... - ks129

oak estuaryBOT Mar 13, 2021, 5:47 AM

#

Python Bot

Connected!

odd spireBOT Mar 13, 2021, 5:48 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 648392025 succeeded.

Actor

Workflow Run

Deploy #194

Commit

5856fe4

regal archBOT Mar 13, 2021, 8:10 AM

#

ks129

[python-discord/sir-lancebot] Pull request review submitted: #625 change ctx\.send\_help to ctx\.invoke\(help\_command\)

#

ks129

[python-discord/sir-lancebot] New review comment on pull request #625: change ctx\.send\_help to ctx\.invoke\(help\_command\)

You can receive full name with parents using ctx.command.qualified_name, so you don't have to pass command name manually.

regal archBOT Mar 13, 2021, 10:25 AM

#

jb3

[bot:fruit\-names] 1 new commit

d01c008 Update and rename elements.json to fruits.json - jb3

#

jb3

[python-discord/bot] New branch created: fruit\-names

#

jb3

[python-discord/bot] Pull request opened: #1462 Update help channel names

#

jb3

[bot:fruit\-names] 1 new commit

4387984 Update _name.py - jb3

odd spireBOT Mar 13, 2021, 10:28 AM

#

[python-discord/bot] Checks Successful on PR: #1462 Update help channel names

GitHub Actions run 648834579 succeeded.

PR Author

Workflow Run

Lint & Test #672

Source Branch

fruit-names

regal archBOT Mar 13, 2021, 10:29 AM

#

jb3

[bot:fruit\-names] 1 new commit

01f6f8d Update _cog.py - jb3

odd spireBOT Mar 13, 2021, 10:29 AM

#

[python-discord/bot] Checks Successful on PR: #1462 Update help channel names

GitHub Actions run 648837299 succeeded.

PR Author

Workflow Run

Lint & Test #673

Source Branch

fruit-names

#

[python-discord/bot] Checks Successful on PR: #1462 Update help channel names

GitHub Actions run 648840287 succeeded.

PR Author

Workflow Run

Lint & Test #674

Source Branch

fruit-names

regal archBOT Mar 13, 2021, 10:50 AM

#

Akarys42

[python-discord/bot] Pull request review submitted: #1462 Update help channel names

🍎 🍌 🍒 🍉🥝🍑🍓🍋

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1462 Update help channel names

Tasty! 😋

#

jb3

[bot] Branch fruit\-names was force-pushed to `2d70fed`

#

scragly

[python-discord/bot] Pull request review submitted: #1462 Update help channel names

Cheers mate, hopefully we don't make too many new devs hungry while getting help.

#

jb3

[python-discord/bot] Pull request closed: #1462 Update help channel names

#

jb3

[bot:master] 1 new commit

7bc390e Update help channel names from chemical element... - jb3

#

jb3

[python-discord/bot] branch deleted: fruit\-names

odd spireBOT Mar 13, 2021, 11:04 AM

#

[python-discord/bot] Checks Successful on PR: #1462 Update help channel names

GitHub Actions run 648891811 succeeded.

PR Author

Workflow Run

Lint & Test #675

Source Branch

fruit-names

oak estuaryBOT Mar 13, 2021, 11:07 AM

#

Python Bot

Connected!

odd spireBOT Mar 13, 2021, 11:08 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 648899551 succeeded.

Actor

Workflow Run

Deploy #195

Commit

7bc390e

regal archBOT Mar 13, 2021, 11:32 AM

#

kwzrd

[python-discord/bot] Pull request opened: #1463 Rewrite branding manager

Resolves #1431

This is a draft PR to implement the changes proposed in #1431. The branding management extension is rewritten to comply with the new event structures in the branding repository.

The implementation is functional but lacks a command API. I also need to spend more time testing.

Steps:

[x] Implement branding repository abstraction
[x] Implement # region: Internal utility
[x] Implement `# region: Da...

regal archBOT Mar 13, 2021, 12:10 PM

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #96 Adding Diwali assets

Gorgeous assets. Attribution looks adequate. Let's merge.

#

lemonsaurus

[python-discord/branding] Pull request closed: #96 Adding Diwali assets

#

lemonsaurus

[branding:master] 3 new commits

f9409c6 Initial Commit for Diwali assets - AG4lyf
c6c745f Giving proper credits. - AG4lyf
af438ed Merge pull request #96 from AG4lyf/master - lemonsaurus

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #112 Fix valentines banner colour

Yep, let's do this.

#

lemonsaurus

[python-discord/branding] Pull request closed: #112 Fix valentines banner colour

#

lemonsaurus

[branding:master] 2 new commits

5a00597 Fix valentines banner colour - MarkKoz
3aab98a Merge pull request #112 from python-discord/val... - lemonsaurus

#

decorator-factory

[branding:decorator\-factory\-\-duck\_bike] 82 new commits

c4a1d02 added lemonsaurus SVG - MrAwesomeRocks
59c1919 added lemonsaurus PNG - MrAwesomeRocks
6f161db Add lemon_tongue - Akarys42
56f557d Add lemon_swag - Akarys42
01f9ecc Add lemon_raised_eyebrow - Akarys42

#

Xithrius

[python-discord/bot] Issue closed: #1457 Shorten PyPI Embed

#

lemonsaurus

[python-discord/branding] New comment on issue #137: RGB animated logo

I guess that's okay, but can we have the animation flow diagonally instead of straight top to bottom?

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #94 Add a \`:ducky\_bike:\` emoji

Looks good

#

gustavwilliam

[python-discord/branding] Pull request review dismissed: #94 Add a \`:ducky\_bike:\` emoji

This looks mildly terrifying, which seems to be intentional.

The cutouts for the wheels don't quite match the wheels themselves. There's a slight mismatch.

I'm also curious how this would look with slightly larger wheels. When used as an emoji, I think they're just a tiny bit too small.

#

lemonsaurus

[python-discord/branding] Pull request closed: #94 Add a \`:ducky\_bike:\` emoji

#

lemonsaurus

[branding:master] 6 new commits

89de612 Add :duck_bike: - decorator-factory
15257c1 Move duckies in the correct folder - decorator-factory
f587282 Merge branch 'decorator-factory--duck_bike' of ... - decorator-factory
83dbaa4 Merge remote-tracking branch 'origin/master' in... - decorator-factory
14e78d2 change the color of duckybike - decorator-factory

regal archBOT Mar 13, 2021, 1:02 PM

#

gustavwilliam

[python-discord/branding] branch deleted: decorator\-factory\-\-duck\_bike

#

AG4lyf

[python-discord/branding] New comment on issue #137: RGB animated logo

That's a great idea.
i will open the PR with diagonal gradient.

night lilyBOT Mar 13, 2021, 2:25 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 13, 2021, 2:27 PM

#

mbaruh

[bot:mbaruh/autoreview] 2 new commits

4b5af57 Use log instead of erroneous self.log - mbaruh
4324b3f Apply requested grammar and style changes. - mbaruh

odd spireBOT Mar 13, 2021, 2:30 PM

#

[python-discord/bot] Checks Successful on PR: #1459 Talentpool Autoreview

GitHub Actions run 649232440 succeeded.

PR Author

Workflow Run

Lint & Test #677

Source Branch

mbaruh/autoreview

regal archBOT Mar 13, 2021, 2:57 PM

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 1 new commit

88e7ab5 Use user reference passed via command

ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

I think we should keep this one the same, as it shows who created the new avatar.

odd spireBOT Mar 13, 2021, 2:58 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 649278138 succeeded.

PR Author

Workflow Run

Lint #502

Source Branch

Enforce-image-processing-concurrency

odd spireBOT Mar 13, 2021, 3:18 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #625 change ctx.send_help to ctx.invoke(help_command)

GitHub Actions run 649309282 succeeded.

PR Author

Workflow Run

Lint #503

Source Branch

ToxicKidz:no-ctx-send-help

regal archBOT Mar 13, 2021, 3:20 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #625 change ctx\.send\_help to ctx\.invoke\(help\_command\)

Looks good to me!

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

Thanks! Looks Good To Me!

#

ks129

[python-discord/sir-lancebot] Pull request review submitted: #625 change ctx\.send\_help to ctx\.invoke\(help\_command\)

#

ks129

[python-discord/sir-lancebot] Issue closed: #624 Using group commands without specifying a subcommand sends the default help command\.

#

ks129

[python-discord/sir-lancebot] Pull request closed: #625 change ctx\.send\_help to ctx\.invoke\(help\_command\)

#

ks129

[sir-lancebot:master] 6 new commits

1cd9c7a change ctx.send_help to ctx.invoke(help_command) - ToxicKidz
cc72d48 make utility invoke_help_command function - ToxicKidz
ccf7d11 Make flake8 happy. - ToxicKidz
b395c05 Make flake8 happy again. - ToxicKidz
9ec1cf9 make invoke_help_command only take ctx - ToxicKidz

odd spireBOT Mar 13, 2021, 3:47 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 649354411 succeeded.

Actor

Workflow Run

Build #176

Commit

0f69e00

night lilyBOT Mar 13, 2021, 3:47 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 13, 2021, 3:50 PM

#

ToxicKidz

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

Looks good to me, just one change.

#

ToxicKidz

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

Since #625 was merged, you want to use bot.utils.extensions.invoke_help_command instead.

            await invoke_help_command(ctx)

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 1 new commit

d8b30f2 Use new help command ext - ChrisLovering

odd spireBOT Mar 13, 2021, 3:56 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 649373230 succeeded.

PR Author

Workflow Run

Lint #505

Source Branch

Enforce-image-processing-concurrency

regal archBOT Mar 13, 2021, 3:56 PM

#

ToxicKidz

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

Thanks, LGTM!

#

xkawixgirlx

[python-discord/branding] Pull request review submitted: #136 Create Python Logo\_trivia\-08\.png

Here is the fixed commit and pull to repo.
File has been deleted from previous location and moved to proper location.
Proper file names have been added.
SVG file type has been added.

#

Shivansh-007

[python-discord/branding] Pull request review submitted: #136 Create Python Logo\_trivia\-08\.png

Thanks! Looks Good To Me!

regal archBOT Mar 13, 2021, 5:23 PM

#

Akarys42

[bot:allow\-poll\-to\-leads] 2 new commits

80e0377 Add leads to the constants - Akarys42
6724505 Allow the !poll command to leads - Akarys42

#

Akarys42

[python-discord/bot] New branch created: allow\-poll\-to\-leads

#

kwzrd

[python-discord/branding] New comment on issue #123: Rework seasonal branding structure

For a quick update: my more-or-less finished implementation Python-side is using python-frontmatter, but I'm still looking for input regarding the CI setup.

#

HassanAbouelela

[python-discord/bot] New comment on issue #1427: Place 3 help channels in the available pool

Thanks, done.

#

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #614: Tech Leaders Pride

            error_msg = "Sorry your input didn't match any stored names, here is a list of available names:"

#

Akarys42

[python-discord/bot] Pull request opened: #1464 Allow \!poll to leads

This PR adds Projects and Domains Leads to the constants and allow them to use !poll.

odd spireBOT Mar 13, 2021, 5:49 PM

#

[python-discord/bot] Checks Failed on PR: #1464 Allow !poll to leads

GitHub Actions run 649564568 failed.

PR Author

Workflow Run

Lint & Test #678

Source Branch

allow-poll-to-leads

regal archBOT Mar 13, 2021, 5:50 PM

#

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #614: Tech Leaders Pride

    """Loads the Pride leader cog."""

#

RohanJnr

[python-discord/sir-lancebot] Pull request review submitted: #614 Tech Leaders Pride

Apart from the minor changes mentioned above, everything else looks good and tested!

#

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #618: Wikiguess Game

So currently, we are using 4 variables to store the state of a quiz game.
Would it be better to have a class representing a game? like

class Game:
    def __init__(self, author, *args *kwargs):
        ...

and then in the Cog init method,
we can have a variable games (a dict).
the games dict would look something like this

{
channel_id: Game(...) class instance,
}

Also, another question is if we still want to store game instances, because this...

regal archBOT Mar 13, 2021, 6:31 PM

#

RohanJnr

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

What happens if the status is not 200?
Then self.headers will be an empty dict, then the command fails as line 78

match, certainty = process.extractOne(query, self.headers.keys())

fails with the error

and the user does not get any output.

IMO, we should disable to command if we cannot fetch the data from the website/readme or if the response status is not ...

#

RohanJnr

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

why is this an instance attribute instead of a local variable?

regal archBOT Mar 13, 2021, 7:17 PM

#

jb3

[python-discord/branding] New branch created: main

#

jb3

[python-discord/branding] branch deleted: master

#

jb3

[metricity:main] 76 new commits

098757b Initial commit - jb3
5d49d96 Add basic project files - jb3
cb6f16b Create lint.yml - jb3
3a8c2cb Update lint.yml - jb3
dbd817b Fix init file docstring. - jb3

#

jb3

[metricity:main] 1 new commit

06d5549 master => main - jb3

#

[metricity] Lint code success on main

#

jb3

[python-discord/async-rediscache] branch deleted: master

#

jb3

[python-discord/async-rediscache] New branch created: main

#

jb3

[async-rediscache:main] 1 new commit

3c2b8bb Update linting workflow to use main branch - jb3

#

[metricity] Build & Publish Docker image success on main

#

jb3

[async-rediscache:main] 1 new commit

df18deb Update coveralls branch badge in README - jb3

#

[async-rediscache] GitHub Actions checks success on main

#

[async-rediscache] GitHub Actions checks success on main

#

jb3

[python-discord/snekbox] New branch created: main

#

jb3

[python-discord/snekbox] branch deleted: master

#

jb3

[snekbox:main] 1 new commit

c85249f master => main - jb3

#

[snekbox] GitHub Actions checks success on main

#

jb3

[python-discord/bot] New branch created: main

#

jb3

[python-discord/bot] branch deleted: master

#

[snekbox] GitHub Actions checks failure on main

#

jb3

[bot:main] 1 new commit

a394c42 master => main - jb3

odd spireBOT Mar 13, 2021, 7:55 PM

#

[python-discord/bot] Workflow Failed

GitHub Actions run 649768866 failed.

Actor

Workflow Run

Deploy #196

Commit

a394c42

oak estuaryBOT Mar 13, 2021, 7:56 PM

#

Python Bot

Connected!

odd spireBOT Mar 13, 2021, 7:56 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 649768866 succeeded.

Actor

Workflow Run

Deploy #196

Commit

a394c42

regal archBOT Mar 13, 2021, 7:57 PM

#

jb3

[python-discord/site] New branch created: main

#

jb3

[site:main] 1 new commit

e4e5268 master => main - jb3

odd spireBOT Mar 13, 2021, 8:07 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 649780456 succeeded.

Actor

Workflow Run

Deploy #31

Commit

e4e5268

regal archBOT Mar 13, 2021, 8:08 PM

#

jb3

[site:main] 1 new commit

de7c6b3 Dockerfile optimisations - jb3

#

jb3

[python-discord/sir-lancebot] New branch created: main

#

jb3

[sir-lancebot:main] 1 new commit

87219f3 master => main - jb3

odd spireBOT Mar 13, 2021, 8:14 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 649793985 succeeded.

Actor

Workflow Run

Deploy #32

Commit

de7c6b3

regal archBOT Mar 13, 2021, 8:16 PM

#

jb3

[sir-lancebot:main] 1 new commit

1c94d02 Dockerfile optimisations - jb3

odd spireBOT Mar 13, 2021, 8:17 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 649800959 succeeded.

Actor

Workflow Run

Build #177

Commit

87219f3

night lilyBOT Mar 13, 2021, 8:18 PM

#

Sir Lancebot

Connected!

odd spireBOT Mar 13, 2021, 8:19 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 649804384 succeeded.

Actor

Workflow Run

Build #178

Commit

1c94d02

night lilyBOT Mar 13, 2021, 8:20 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 13, 2021, 8:30 PM

#

HassanAbouelela

[sir-lancebot:main] 1 new commit

0e074b7 Removes Unused Roles & Channels - HassanAbouelela

odd spireBOT Mar 13, 2021, 8:32 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 649827217 succeeded.

Actor