#dev-log

Workflow Run

Deploy #160

Commit

5df02cc

regal archBOT Feb 25, 2021, 10:08 AM

#

HassanAbouelela

[python-discord/bot] Pull request opened: #1436 Helpful Startup Errors

Description

One of the biggest hurdles that people face when setting up the bot, is the lack of helpful information when things go wrong. From redis, to the API, plenty can go wrong, and it requires experience to read the traceback and figure out why.

Inspiration

This PR aims to take a step in fixing that, by offering more descriptive errors on startup. This is inspired by #1385, but only covers a portion of the proposed changes.

Implemntation

This PR does two things:

It lo...

odd spireBOT Feb 25, 2021, 10:11 AM

#

[python-discord/bot] Checks Successful on PR: #1436 Helpful Startup Errors

GitHub Actions run 599058097 succeeded.

PR Author

Workflow Run

Lint & Test #542

Source Branch

startup-errors

regal archBOT Feb 25, 2021, 10:15 AM

#

Akarys42

[python-discord/snekbox] Pull request review submitted: #91 Dynamically create parent cgroups

It seems to be working fine, cheers!

#

Akarys42

[python-discord/snekbox] Issue closed: #83 Snekbox returning 137 when processing multiple memory\-intensive requests simultaneously

#

Akarys42

[python-discord/snekbox] Pull request closed: #91 Dynamically create parent cgroups

#

Akarys42

[python-discord/snekbox] branch deleted: dynamic\-parent\-cgroups

#

Akarys42

[snekbox:master] 4 new commits

df90f21 Dynamically create parent cgroups for nsjail - jb3
9dac45e Remove cgroup parent constants from config file - jb3
c9368a4 Merge branch 'master' into dynamic-parent-cgroups - jb3
af704c1 Merge pull request #91 from python-discord/dyna... - Akarys42

#

[snekbox] GitHub Actions checks success on master

#

[snekbox] GitHub Actions checks success on master

#

Akarys42

[python-discord/snekbox] Pull request review submitted: #93 Fix NsJail Tests

#

Akarys42

[python-discord/snekbox] New review comment on pull request #93: Fix NsJail Tests

Is there any reason why we don't make a user install rather than a system install?

#

HassanAbouelela

[bot:startup\-errors] 1 new commit

900923c Catches All Site Startup Issues - HassanAbouelela

odd spireBOT Feb 25, 2021, 10:26 AM

#

[python-discord/bot] Checks Successful on PR: #1436 Helpful Startup Errors

GitHub Actions run 599098568 succeeded.

PR Author

Workflow Run

Lint & Test #543

Source Branch

startup-errors

regal archBOT Feb 25, 2021, 10:32 AM

#

Akarys42

[python-discord/bot] New review comment on pull request #1436: Helpful Startup Errors

Nitpicky, but it can just be

                    raise

#

Akarys42

[python-discord/bot] New review comment on pull request #1436: Helpful Startup Errors

This should be an isinstance check ~~and it should be a tuple, not a list :P~~

#

Akarys42

[python-discord/bot] New review comment on pull request #1436: Helpful Startup Errors

I believe you meant

        super().__init__()

#

Akarys42

[python-discord/bot] New review comment on pull request #1436: Helpful Startup Errors

This should exit with a non-zero code

#

HassanAbouelela

[bot:startup\-errors] 1 new commit

4c566bb Cleans Up Startup Error Handler Code Style - HassanAbouelela

#

HassanAbouelela

[bot:startup\-errors] 1 new commit

283857f Call Super init in Startup Error - HassanAbouelela

odd spireBOT Feb 25, 2021, 10:45 AM

#

[python-discord/bot] Checks Failed on PR: #1436 Helpful Startup Errors

GitHub Actions run 599153016 failed.

PR Author

Workflow Run

Lint & Test #544

Source Branch

startup-errors

#

[python-discord/bot] Checks Failed on PR: #1436 Helpful Startup Errors

GitHub Actions run 599154779 failed.

PR Author

Workflow Run

Lint & Test #545

Source Branch

startup-errors

regal archBOT Feb 25, 2021, 10:47 AM

#

Akarys42

[python-discord/bot] New review comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

I'd rather a constant set of email appealable infractions, but it is fine like this

#

Akarys42

[python-discord/bot] New review comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

Could we make it a mention of the modmail bot? Changing ModMail to @barren sonnet should do it.

#

Akarys42

[python-discord/bot] New review comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

We use this style of multiline strings throughout the code base.

INFRACTION_APPEAL_MODMAIL_FOOTER = (
    'If you would like to discuss or appeal this infraction, '
    'send a message to the ModMail bot'
)

#

Akarys42

[python-discord/bot] Pull request review submitted: #1435 Instructions to dispute an infraction vary by infraction type\.

It looks pretty good, I left a few little comments. Also, it seems like it broke the modlog tests.

#

HassanAbouelela

[bot:startup\-errors] 1 new commit

fb7e21a Removes Unused Variable - HassanAbouelela

odd spireBOT Feb 25, 2021, 10:52 AM

#

[python-discord/bot] Checks Successful on PR: #1436 Helpful Startup Errors

GitHub Actions run 599168424 succeeded.

PR Author

Workflow Run

Lint & Test #546

Source Branch

startup-errors

regal archBOT Feb 25, 2021, 11:07 AM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #602: Add Subsection Command for WTFPython

I would like to work on this.

#

Akarys42

[python-discord/sir-lancebot] New comment on issue #602: Add Subsection Command for WTFPython

Thanks you @Shivansh-007, assigned !

#

Senjan21

[python-discord/bot] Pull request review submitted: #1392 Don't fuzzy search for tags when tag is on cooldown

Looks like a good change, thanks.

regal archBOT Feb 25, 2021, 12:03 PM

#

bast0006

[python-discord/bot] New comment on issue #1421: MFA User Token filter

@bast0006 was this eventually taken care of, or do we need to make a PR? As far as I saw, we just added another regex filter.

We've got a regex registered as a custom filter, but I think it'd be a good idea to immortalize it within the filter_token cog

regal archBOT Feb 25, 2021, 12:21 PM

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #63: Support code unit testing through snekbox

        response.raise_for_status()

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #63: Support code unit testing through snekbox

I'd much rather this be a multiline string, as it's quite hard to parse as is.

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #63: Support code unit testing through snekbox

This shouldn't be a blind filter. If admin is true, it should be included, as this will be important information to include in the admin panel.

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #63 Support code unit testing through snekbox

Preliminary feedback:

Add the env variable to the Readme
We do the parsing of user code into the template on the backend. Can we instead do it in snekbox?

I'll do a more complete review later, this is just what I had time to look over.

regal archBOT Feb 25, 2021, 1:36 PM

#

Akarys42

[forms-backend:feat/9/unittest\-validation] 2 new commits

8939c8e Add return code 6 for exceptions when loading m... - Akarys42
7d34cb8 Add return code 7 for processes killed by NsJail - Akarys42

#

Akarys42

[forms-backend:feat/9/unittest\-validation] 1 new commit

8fd2096 Make use of .raise_for_status() - Akarys42

odd spireBOT Feb 25, 2021, 1:37 PM

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 599580467 succeeded.

PR Author

Workflow Run

Forms Backend #222

Source Branch

feat/9/unittest-validation

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 599582275 succeeded.

PR Author

Workflow Run

Forms Backend #224

Source Branch

feat/9/unittest-validation

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 599582238 succeeded.

PR Author

Workflow Run

Forms Backend #223

Source Branch

feat/9/unittest-validation

regal archBOT Feb 25, 2021, 1:41 PM

#

Akarys42

[forms-backend] Branch feat/9/unittest\-validation was force-pushed to `99f9a0a`

odd spireBOT Feb 25, 2021, 1:42 PM

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 599593227 succeeded.

PR Author

Workflow Run

Forms Backend #225

Source Branch

feat/9/unittest-validation

regal archBOT Feb 25, 2021, 1:48 PM

#

Akarys42

[forms-backend:feat/9/unittest\-validation] 6 new commits

2bdcab1 Don't try to parse the composed code - Akarys42
52f12f4 Make use of list.copy() instead of [:] - Akarys42
e46047d Only filter units if we aren't using an admin t... - Akarys42
06c01e7 Remove unneeded temp variable - Akarys42
bfc44e8 Make _make_unit_code more readable - Akarys42

odd spireBOT Feb 25, 2021, 1:49 PM

#

[python-discord/forms-backend] Checks Failed on PR: #63 Support code unit testing through snekbox

GitHub Actions run 599612733 failed.

PR Author

Workflow Run

Forms Backend #226

Source Branch

feat/9/unittest-validation

regal archBOT Feb 25, 2021, 3:21 PM

#

MrKomodoDragon

[python-discord/sir-lancebot] New comment on issue #602: Add Subsection Command for WTFPython

Would this possibly go along with the PR i made about python facts?

regal archBOT Feb 25, 2021, 3:36 PM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #602: Add Subsection Command for WTFPython

Should I make use of the line pagination here, since some examples are really big. For example the walrus operator example.

regal archBOT Feb 25, 2021, 4:17 PM

#

Senjan21

[python-discord/bot] New comment on issue #1432: Faulty tag suggestions

As to why it happens, https://github.com/python-discord/bot/blob/master/bot/exts/backend/error_handler.py#L208 shows that we simply use .replace on user input, we probably could simply just put the suggested command name instead of parsing whole user input and replacing it with suggestion. Would you like to work on it?

#

sebkuip

[python-discord/bot] New comment on pull request #1393: Made a tag to help people fix an empty file JSON error\.

@sebkuip will you be updating this PR relatively soon within the future?

Sorry was under the impression that I already merged the requested changes. I have merged these now.

#

MrKomodoDragon

[python-discord/sir-lancebot] New comment on issue #602: Add Subsection Command for WTFPython

@Shivansh-007 just an idea, could we add it as a subcommand for the .pyfacts command PR #596 ?

odd spireBOT Feb 25, 2021, 4:19 PM

#

[python-discord/bot] Checks Successful on PR: #1393 Made a tag to help people fix an empty file JSON error.

GitHub Actions run 600020483 succeeded.

PR Author

sebkuip

Workflow Run

Lint & Test #547

Source Branch

sebkuip:json-tag

regal archBOT Feb 25, 2021, 4:33 PM

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #63 Support code unit testing through snekbox

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #63: Support code unit testing through snekbox

After some discussion, it was decided this isn't worth the effort.

regal archBOT Feb 25, 2021, 4:57 PM

#

jb3

[site:master] 1 new commit

97d0ece Reduce worker count from 4 to 2 - jb3

odd spireBOT Feb 25, 2021, 5:03 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 600146753 succeeded.

Actor

Workflow Run

Deploy #27

Commit

97d0ece

regal archBOT Feb 25, 2021, 5:18 PM

#

Akarys42

[forms-backend:feat/9/unittest\-validation] 1 new commit

e57b7ea Remove unused import - Akarys42

odd spireBOT Feb 25, 2021, 5:19 PM

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 600192800 succeeded.

PR Author

Workflow Run

Forms Backend #227

Source Branch

feat/9/unittest-validation

regal archBOT Feb 25, 2021, 5:20 PM

#

Akarys42

[forms-backend:feat/9/unittest\-validation] 1 new commit

a1a14d8 Properly hadnle hidden tests starting with test_ - Akarys42

odd spireBOT Feb 25, 2021, 5:22 PM

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 600199334 succeeded.

PR Author

Workflow Run

Forms Backend #228

Source Branch

feat/9/unittest-validation

regal archBOT Feb 25, 2021, 5:49 PM

#

anand2312

[python-discord/bot] New comment on issue #1432: Faulty tag suggestions

I'm busy currently; anyone is free to work on this.

regal archBOT Feb 25, 2021, 9:57 PM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1393 Made a tag to help people fix an empty file JSON error\.

regal archBOT Feb 25, 2021, 10:13 PM

#

MarkKoz

[python-discord/site] Pull request review submitted: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

#

MarkKoz

[python-discord/site] New review comment on pull request #443: Apply LimitOffsetPagination in GET Infraction with default Page Size 100

A better place for this file would be pydis_site/apps/api/pagination.py. It shouldn't be under viewsets since it's not a viewset.

#

MarkKoz

[python-discord/site] New review comment on pull request #443: Apply LimitOffsetPagination in GET Infraction with default Page Size 100

The documentation doesn't have to be extremely detailed, but what you currently have is too vague. It doesn't really provide any information the reader doesn't already know.

#

MarkKoz

[python-discord/site] New review comment on pull request #443: Apply LimitOffsetPagination in GET Infraction with default Page Size 100

Too vague; same as above.

#

MarkKoz

[python-discord/smartconfig] Pull request review submitted: #10 Add the core package

#

MarkKoz

[python-discord/smartconfig] New review comment on pull request #10: Add the core package

I think relying on GC is fine. However, how will you know if the value is still the default? If the config happens to have the same value as the default, then that value should still be accessible if the class unloads since it's not relying on the class for the value.

odd spireBOT Feb 25, 2021, 11:05 PM

#

[python-discord/bot] Checks Successful on PR: #1393 Made a tag to help people fix an empty file JSON error.

GitHub Actions run 601007694 succeeded.

PR Author

sebkuip

Workflow Run

Lint & Test #548

Source Branch

sebkuip:json-tag

regal archBOT Feb 26, 2021, 1:39 AM

#

Xithrius

[python-discord/sir-lancebot] New branch created: modifying\-topics

regal archBOT Feb 26, 2021, 1:55 AM

#

Xithrius

[sir-lancebot:modifying\-topics] 1 new commit

3766b14 Added more topics. - Xithrius

#

Xithrius

[python-discord/sir-lancebot] Pull request opened: #603 Added more topics\.

We haven't updated the topics in the .topic command for a while.

Some of the topics included in the #python-general section including IDEs were problematic, so we moved them over to the #editors-ides channel.

Many more topics have been added for offtopic channels.

odd spireBOT Feb 26, 2021, 1:59 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #603 Added more topics.

GitHub Actions run 601369658 succeeded.

PR Author

Workflow Run

Lint #391

Source Branch

modifying-topics

regal archBOT Feb 26, 2021, 2:03 AM

#

Xithrius

[python-discord/bot] New comment on pull request #1393: Made a tag to help people fix an empty file JSON error\.

@swfarnsworth Please review when you're available.

regal archBOT Feb 26, 2021, 2:22 AM

#

Numerlor

[python-discord/sir-lancebot] Pull request review submitted: #603 Added more topics\.

#

Numerlor

[python-discord/sir-lancebot] New review comment on pull request #603: Added more topics\.

Is TLI a thing? Searched around a bit and only found a few uses, I believe TUI would be a more familiar and fitting term

#

Numerlor

[python-discord/sir-lancebot] New review comment on pull request #603: Added more topics\.

Should this use a more precise term in place of database, something like DBMS?

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #603: Added more topics\.

Sorry, misspelled. It's TUI, thanks for catching that!

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #603 Added more topics\.

odd spireBOT Feb 26, 2021, 2:28 AM

#

[python-discord/bot] Checks Successful on PR: #1437 Bump aiohttp from 3.7.3 to 3.7.4

GitHub Actions run 601424301 succeeded.

PR Author

Workflow Run

Lint & Test #549

Source Branch

dependabot/pip/aiohttp-3.7.4

regal archBOT Feb 26, 2021, 2:35 AM

#

swfarnsworth

[python-discord/bot] Pull request review submitted: #1393 Made a tag to help people fix an empty file JSON error\.

Thanks!

#

swfarnsworth

[python-discord/bot] New review comment on pull request #1393: Made a tag to help people fix an empty file JSON error\.

Per my previous review, "your JSON is invalid in its current state" may be unnecessarily technical.

At any given time, it should be made clear whether an "empty json" refers to a completely empty json file or an object with no keys.

#

swfarnsworth

[python-discord/bot] New review comment on pull request #1393: Made a tag to help people fix an empty file JSON error\.

I don't think we should refer to "objects" or "arrays" because these have different meanings in the context of Python, and all that seems to matter is that one puts some valid content in the .json file.

#

Xithrius

[python-discord/bot] Pull request closed: #1393 Made a tag to help people fix an empty file JSON error\.

#

Xithrius

[bot:master] 19 new commits

01ad92b Re created file from last point - sebkuip
5a6f77f name fix, added suggestions from previous PR - sebkuip
4704344 Fixed EOF - sebkuip
9931ebc Removed extra whitespace line in last example - sebkuip
dc8a5d4 Changed some wording - sebkuip

oak estuaryBOT Feb 26, 2021, 2:46 AM

#

Python Bot

Connected!

odd spireBOT Feb 26, 2021, 2:46 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 601465418 succeeded.

Actor

Workflow Run

Deploy #161

Commit

9b7b545

regal archBOT Feb 26, 2021, 3:29 AM

#

Vthechamp22

[python-discord/sir-lancebot] New comment on pull request #583: Add the stackoverflow command

@Xithrius Actually I'm having my exams right now, so hopefully I will be able to complete it by the end of March.

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #583: Add the stackoverflow command

Alright. Good luck with your exams!

regal archBOT Feb 26, 2021, 4:08 AM

#

RohanJnr

[python-discord/sir-lancebot] New comment on issue #599: Hangman Game Command

I am a little confused with the executor part, so the bot will become the guesser?

regal archBOT Feb 26, 2021, 6:54 AM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #602: Add Subsection Command for WTFPython

Ahh I am not in favour of that, this should be kept separate.

odd spireBOT Feb 26, 2021, 7:42 AM

#

[python-discord/site] Checks Successful on PR: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

GitHub Actions run 602043641 succeeded.

PR Author

kunal097

Workflow Run

Lint & Test #96

Source Branch

kunal097:limit-infraction-result

night lilyBOT Feb 26, 2021, 9:14 AM

#

Sir Lancebot

Connected!

regal archBOT Feb 26, 2021, 11:59 AM

#

jb3

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

Probably the same comment as above.

#

jb3

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

Minor thoughts, but otherwise all looks good and works locally.

It would be nice to iron out the startup KeyErrors

#

jb3

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

Can we avoid the startup KeyError on first use by using .get() here?

            self.threshold = parse_duration_string(settings["threshold"]) if settings.get("threshold") else None

#

mbaruh

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

Is it possible that we won't be able to read from redis properly? because if there is, a KeyError will allow us to find out about it.

#

mbaruh

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

jb3

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

jb3

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

I'm not aware of such a situation, if we had connection problems then that'd manifest elsewhere.

#

mbaruh

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

Right, but then you are also reminded that your defcon settings aren't synced and that you should bring them back if defcon was active. If it's not desirable I don't mind changing it, but that's pretty much the goal of the try clause.

#

mbaruh

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

I think the proper solution here is to have a fallback that this cog falls to, not just let everything crash and burn. If we want to add an alert system, that's fine, but it's complementary to the other solution.

#

mbaruh

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

mbaruh

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

It does have fallback, it just sets to the default 0. You can still use defcon, it's just unsynced

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

I mean we shouldn't error out just because redis is having trouble. The cog should continue without errors, or with proper error handling, and the report should be handled seperately.

#

mbaruh

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

It continues, it just lets you know that it wasn't able to sync

#

mbaruh

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

mbaruh

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

I can suppress any errors while updating actually. But other than that defcon is functional even without a connection.

#

mbaruh

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

SebastiaanZ

[api:main] 1 new commit

729e7ed Add endpoint issue template to GitHub repository - Sebastiaan Zeeff

#

ks129

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

ks129

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

This is constant, so this should be uppercase. Also, I think _DURATION_REGEX would be a better name.

#

SebastiaanZ

[api:add\-endpoint\-issue\-template] 1 new commit

f32ce49 Add issue template for endpoints to repository - SebastiaanZ

#

SebastiaanZ

[python-discord/api] New branch created: add\-endpoint\-issue\-template

#

SebastiaanZ

[python-discord/api] Pull request opened: #1 Add issue template for endpoints to repository

#

SebastiaanZ

[api:main] 1 new commit

cad6995 Add issue template header to endpoint template - Sebastiaan Zeeff

#

mbaruh

[bot:mbaruh/defcon] 1 new commit

cea82da Supressing any exceptions while updating the th... - mbaruh

#

jb3

[python-discord/api] Pull request review submitted: #1 Add issue template for endpoints to repository

odd spireBOT Feb 26, 2021, 12:51 PM

#

[python-discord/bot] Checks Successful on PR: #1262 Defcon overhaul

GitHub Actions run 602764281 succeeded.

PR Author

Workflow Run

Lint & Test #551

Source Branch

mbaruh/defcon

regal archBOT Feb 26, 2021, 12:55 PM

#

kunal097

[python-discord/site] Pull request review submitted: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

#

kunal097

[python-discord/site] New review comment on pull request #443: Apply LimitOffsetPagination in GET Infraction with default Page Size 100

I tried to resolve all the required changes. Please take a look.

regal archBOT Feb 26, 2021, 1:17 PM

#

mbaruh

[bot:mbaruh/defcon] 1 new commit

80153ed Changed name of _duration_parser constant to up... - mbaruh

odd spireBOT Feb 26, 2021, 1:20 PM

#

[python-discord/bot] Checks Successful on PR: #1262 Defcon overhaul

GitHub Actions run 602838673 succeeded.

PR Author

Workflow Run

Lint & Test #552

Source Branch

mbaruh/defcon

regal archBOT Feb 26, 2021, 1:21 PM

#

Akarys42

[forms-backend:feat/9/unittest\-validation] 1 new commit

9d2c379 Use base64 encoded code snippets - Akarys42

odd spireBOT Feb 26, 2021, 1:22 PM

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 602847734 succeeded.

PR Author

Workflow Run

Forms Backend #229

Source Branch

feat/9/unittest-validation

regal archBOT Feb 26, 2021, 1:52 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #1402 Implement showing filterlist entry comment in alerts

Seems to be working as intended.

regal archBOT Feb 26, 2021, 2:22 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

mbaruh

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

@jb3 yeah so in short the purpose here is to catch that key error or any other error that might indicate things aren't working well. Do you want to remove that?

#

gustavwilliam

[python-discord/branding] Pull request review submitted: #115 Add lemon\_starstruck lemoji

Looks excellent! Well done.

#

jb3

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

jb3

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

So, I haven't tested with redis locally, but if we start up the bot and don't immediately set a defcon will it just alert the moderators on every startup?

I think a better idea is to alert and then actually take action and set the preferences.

regal archBOT Feb 26, 2021, 3:19 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #174: \[Feature Request\] Earth Photos

This sounds like something I'm interested in, only problem is I've never worked with cogs...

regal archBOT Feb 26, 2021, 3:39 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

mbaruh

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

No, it will only misfire when the PR is merged because the cache is new. Once we set the cache once it won't do that anymore.

#

mbaruh

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

#

mbaruh

[python-discord/bot] New review comment on pull request #1262: Defcon overhaul

Practically speaking you run !dc t 0 once and that's it. The issue is that you need to have the keys in the cache.

#

Akarys42

[python-discord/bot] Pull request review submitted: #1437 Bump aiohttp from 3\.7\.3 to 3\.7\.4

:ok_hand:

#

Akarys42

[bot:dependabot/pip/aiohttp\-3\.7\.4] 20 new commits

01ad92b Re created file from last point - sebkuip
5a6f77f name fix, added suggestions from previous PR - sebkuip
4704344 Fixed EOF - sebkuip
9931ebc Removed extra whitespace line in last example - sebkuip
dc8a5d4 Changed some wording - sebkuip

odd spireBOT Feb 26, 2021, 4:05 PM

#

[python-discord/bot] Checks Successful on PR: #1437 Bump aiohttp from 3.7.3 to 3.7.4

GitHub Actions run 603253551 succeeded.

PR Author

Workflow Run

Lint & Test #553

Source Branch

dependabot/pip/aiohttp-3.7.4

regal archBOT Feb 26, 2021, 4:07 PM

#

Akarys42

[python-discord/bot] Pull request closed: #1437 Bump aiohttp from 3\.7\.3 to 3\.7\.4

#

Akarys42

[python-discord/bot] branch deleted: dependabot/pip/aiohttp\-3\.7\.4

#

Akarys42

[bot:master] 3 new commits

82190ee Bump aiohttp from 3.7.3 to 3.7.4 - dependabot[bot]
7fafd75 Merge branch 'master' into dependabot/pip/aioht... - Akarys42
707d55d Merge pull request #1437 from python-discord/de... - Akarys42

oak estuaryBOT Feb 26, 2021, 4:12 PM

#

Python Bot

Connected!

odd spireBOT Feb 26, 2021, 4:12 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 603278389 succeeded.

Actor

Workflow Run

Deploy #162

Commit

707d55d

regal archBOT Feb 26, 2021, 4:22 PM

#

Akarys42

[python-discord/bot] Pull request review submitted: #1436 Helpful Startup Errors

LGTM, thanks!

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1436 Helpful Startup Errors

Thanks! Looks Good To Me!

#

Akarys42

[bot:startup\-errors] 27 new commits

01ad92b Re created file from last point - sebkuip
5a6f77f name fix, added suggestions from previous PR - sebkuip
4704344 Fixed EOF - sebkuip
9931ebc Removed extra whitespace line in last example - sebkuip
dc8a5d4 Changed some wording - sebkuip

odd spireBOT Feb 26, 2021, 4:40 PM

#

[python-discord/bot] Checks Successful on PR: #1436 Helpful Startup Errors

GitHub Actions run 603348992 succeeded.

PR Author

Workflow Run

Lint & Test #555

Source Branch

startup-errors

regal archBOT Feb 26, 2021, 4:43 PM

#

Akarys42

[python-discord/bot] Issue closed: #1349 Waiting for the website to be up before starting in development mode

#

Akarys42

[python-discord/bot] Pull request closed: #1436 Helpful Startup Errors

#

Akarys42

[python-discord/bot] branch deleted: startup\-errors

#

Akarys42

[bot:master] 8 new commits

c5e1137 Adds More Descriptive Startup Error Messages - HassanAbouelela
866f315 Adds Site Readiness Checks - HassanAbouelela
900923c Catches All Site Startup Issues - HassanAbouelela
4c566bb Cleans Up Startup Error Handler Code Style - HassanAbouelela
283857f Call Super init in Startup Error - HassanAbouelela

oak estuaryBOT Feb 26, 2021, 4:46 PM

#

Python Bot

Connected!

odd spireBOT Feb 26, 2021, 4:47 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 603371556 succeeded.

Actor

Workflow Run

Deploy #163

Commit

47edc94

regal archBOT Feb 26, 2021, 4:58 PM

#

jb3

[snekbox:recursive\-remove\-cgroups] 1 new commit

06173ee Remove all child cgroups before removing parents - jb3

#

jb3

[python-discord/snekbox] New branch created: recursive\-remove\-cgroups

#

jb3

[python-discord/snekbox] Pull request opened: #94 Remove all child cgroups before removing parents

After #91 was merged we starting seeing errors with large stdout causing errors like the following:

2021-02-26 16:02:56,706 |    14 |                 snekbox.nsjail |     INFO | Executing code...
2021-02-26 16:02:56,741 |    14 |                 snekbox.nsjail |     INFO | Output exceeded the output limit, sending SIGKILL to NsJail.
2021-02-26 16:02:56,743 |    14 |                 snekbox.nsjail |     INFO | nsjail return code: 137
2021-02-26 16:02:56,744 |    14 |     snekbox.api.r...

#

[snekbox] GitHub Actions checks success on pull request #94

#

jb3

[python-discord/snekbox] New comment on pull request #94: Remove all child cgroups before removing parents

Also worth noting that the RAM limits and PID limits are not affected by this, only evaluations which result in a large stdout.

#

mbaruh

[bot:mbaruh/defcon] 1 new commit

6dbf8de Sync alert won't trigger with fake redis - mbaruh

odd spireBOT Feb 26, 2021, 5:12 PM

#

[python-discord/bot] Checks Successful on PR: #1262 Defcon overhaul

GitHub Actions run 603431442 succeeded.

PR Author

Workflow Run

Lint & Test #557

Source Branch

mbaruh/defcon

regal archBOT Feb 26, 2021, 5:21 PM

#

Akarys42

[python-discord/snekbox] Pull request review submitted: #94 Remove all child cgroups before removing parents

It does solve our current issue, thanks captain Joe!

#

Akarys42

[snekbox:master] 2 new commits

06173ee Remove all child cgroups before removing parents - jb3
59a1bf4 Merge pull request #94 from python-discord/recu... - Akarys42

#

Akarys42

[python-discord/snekbox] Pull request closed: #94 Remove all child cgroups before removing parents

#

Akarys42

[python-discord/snekbox] branch deleted: recursive\-remove\-cgroups

#

[snekbox] GitHub Actions checks success on master

#

[snekbox] GitHub Actions checks success on master

regal archBOT Feb 26, 2021, 9:02 PM

#

jb3

[bot:master] 1 new commit

64e85dd !int socketstats improvements - jb3

oak estuaryBOT Feb 26, 2021, 9:06 PM

#

Python Bot

Connected!

odd spireBOT Feb 26, 2021, 9:06 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 603971378 succeeded.

Actor

Workflow Run

Deploy #164

Commit

64e85dd

regal archBOT Feb 26, 2021, 9:24 PM

#

gustavwilliam

[bot:plural\-events] 1 new commit

de226ea Make "event" plural in socketstats embed - gustavwilliam

#

gustavwilliam

[python-discord/bot] New branch created: plural\-events

#

gustavwilliam

[python-discord/bot] Pull request opened: #1438 Make "event" plural in socketstats embed

This is how the socketstats embed previously looked:

This is how it looks now:

Notice the new "s"? Yep, events is now plural.

#

jb3

[python-discord/bot] Pull request review submitted: #1438 Make "event" plural in socketstats embed

the most important PR to ever reach our repositories

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1438 Make "event" plural in socketstats embed

Is this how I request changes?

odd spireBOT Feb 26, 2021, 9:30 PM

#

[python-discord/bot] Checks Successful on PR: #1438 Make "event" plural in socketstats embed

GitHub Actions run 604022205 succeeded.

PR Author

Workflow Run

Lint & Test #559

Source Branch

plural-events

regal archBOT Feb 26, 2021, 9:30 PM

#

HassanAbouelela

[python-discord/bot] Pull request closed: #1438 Make "event" plural in socketstats embed

#

HassanAbouelela

[bot:master] 2 new commits

de226ea Make "event" plural in socketstats embed - gustavwilliam
1ab728b Merge pull request #1438 from python-discord/pl... - HassanAbouelela

#

HassanAbouelela

[python-discord/bot] branch deleted: plural\-events

oak estuaryBOT Feb 26, 2021, 9:34 PM

#

Python Bot

Connected!

odd spireBOT Feb 26, 2021, 9:34 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 604034399 succeeded.

Actor

Workflow Run

Deploy #165

Commit

1ab728b

regal archBOT Feb 26, 2021, 10:54 PM

#

SebastiaanZ

[api:main] 4 new commits

8db7495 Add pydantic and fastapi to the dependencies - Sebastiaan Zeeff
6f3eee9 Add uvicorn to the development dependencies - Sebastiaan Zeeff
a03c568 Add custom TokenAuthentication middleware - Sebastiaan Zeeff
668f5a4 Add minimal API with health check endpoint - Sebastiaan Zeeff

regal archBOT Feb 26, 2021, 11:46 PM

#

SebastiaanZ

[api:main] 3 new commits

d9ff66b Remove superfluous endpoints directory from api.v1 - Sebastiaan Zeeff
a65ce9b Add alembic and SQLAlchemy to dependencies - Sebastiaan Zeeff
1804ecd Define entrypoint with reload in docker-compose - Sebastiaan Zeeff

#

SebastiaanZ

[python-discord/api] New comment on pull request #1: Add issue template for endpoints to repository

This is no longer necessary.

#

SebastiaanZ

[python-discord/api] Pull request closed: #1 Add issue template for endpoints to repository

regal archBOT Feb 27, 2021, 5:19 AM

#

MarkKoz

[python-discord/snekbox] Pull request review submitted: #93 Fix NsJail Tests

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #93: Fix NsJail Tests

IIRC it's cause the user site is not on PATH. It's more convenient to use sudo in this case.

regal archBOT Feb 27, 2021, 1:31 PM

#

mbaruh

[python-discord/bot] Issue closed: #1172 User Events Management System

#

mbaruh

[python-discord/site] Issue closed: #396 User Events Management System

regal archBOT Feb 27, 2021, 2:03 PM

#

HassanAbouelela

[python-discord/bot] New comment on issue #393: Deferred moderative action

I don't know if this issue is still relevant, when was the last time the API went down without the entire server going down? Regardless, the best solution today would probably be something to do with redis, Maybe a redis queue that we try to keep empty and add to if API requests fail. I don't think bypassing the API and going straight for the DB is very wise.

What happens when Redis goes down? Well first contact DevOps because something has gone horribly wrong if both site and redis are do...

#

HassanAbouelela

[python-discord/bot] New comment on issue #361: Potential Unhandled Exceptions in Perpetual Tasks

v1.6.0 is now released. 🎉

On a more serious note, 360 has been merged for over a year, tasks should probably be pretty stable, and this issue has been dormant for so long it probably has not come up at all since. Have we stopped using create_task? I don't believe so.

The library support is there for it, but the question is: is this still relevant?

#

HassanAbouelela

[python-discord/bot] New comment on issue #657: Expand Off Topic Channel Allowed Characters

This seems like a pretty simple fix, but I don't know about having a huge list of valid characters sitting somewhere in some file, looking ugly. Is there any way to better predict which letters are going to be valid, without hardcoding every single one? (P.S o7 cmdr)

#

HassanAbouelela

[python-discord/bot] New comment on issue #863: Unfurling shortened URLs, following redirects and trust checking URLs

Closing this for the same reason mentioned in python-discord/meta#88. Feel free to reopen if you believe this is different.

#

HassanAbouelela

[python-discord/bot] Issue closed: #863 Unfurling shortened URLs, following redirects and trust checking URLs

#

mbaruh

[bot:mbaruh/mute] 784 new commits

b3ad47a Feature: suggest command usage for misspelt com... - F4zii
adfb87e Merge branch 'master' into feat/F4zi/CommandSug... - Akarys42
dfe9dd8 Seperated tags.get_command into a function and ... - F4zii
eb01f3f Feature: suggest command usage for misspelt com... - F4zii
777088b Merge branches 'feat/F4zi/CommandSuggestion' an... - F4zii

regal archBOT Feb 27, 2021, 2:54 PM

#

SavagePastaMan

[bot:comparison\-tag] 1 new commit

bdc1cb2 Create comparison.md - SavagePastaMan

#

SavagePastaMan

[python-discord/bot] New branch created: comparison\-tag

regal archBOT Feb 27, 2021, 3:24 PM

#

00-00-00-11

[python-discord/logcord] Fork created: 00-00-00-11/logcord

regal archBOT Feb 27, 2021, 3:41 PM

#

SavagePastaMan

[python-discord/bot] Pull request opened: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

Title is self explanatory, I think.

odd spireBOT Feb 27, 2021, 3:44 PM

#

[python-discord/bot] Checks Successful on PR: #1439 Add a tag to explain a common error with substituting `=` and `==`.

GitHub Actions run 605794768 succeeded.

PR Author

Workflow Run

Lint & Test #561

Source Branch

comparison-tag

regal archBOT Feb 27, 2021, 4:01 PM

#

Akarys42

[forms-backend:feat/9/unittest\-validation] 1 new commit

0e4a95b Obliterate the _unit_cache variable - Akarys42

odd spireBOT Feb 27, 2021, 4:02 PM

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 605823513 succeeded.

PR Author

Workflow Run

Forms Backend #230

Source Branch

feat/9/unittest-validation

regal archBOT Feb 27, 2021, 4:12 PM

#

Senjan21

[python-discord/forms-backend] Pull request review submitted: #63 Support code unit testing through snekbox

Code and logic wise, looks good.

regal archBOT Feb 27, 2021, 5:07 PM

#

gustavwilliam

[python-discord/bot] New review comment on pull request #1439: Add a tag to explain a common error with substituting \`=\` and \`==\`\.

If we add something like the following, it might become a bit more clear what has happened:

print(x)  # Prints 5

You could also write it like if it was in a repl. Both are fine with me, but some more context would be nice, considering that the people who mess this up probably don't have too much experience with python.

#

gustavwilliam

[python-discord/bot] New review comment on pull request #1439: Add a tag to explain a common error with substituting \`=\` and \`==\`\.

This is often referred to as the "assignment operator" iirc. What do you think about writing that instead of "equals operator"?

#

gustavwilliam

[python-discord/bot] Pull request review submitted: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

Thanks—I like how simple and clean this tag is. Well done!

There are a few things that caught my eye though, where I've left comments. In most cases, it's not meant as a "this is right", but rather to see what you think and if it's worth changing.

#

gustavwilliam

[python-discord/bot] New review comment on pull request #1439: Add a tag to explain a common error with substituting \`=\` and \`==\`\.

The double equals operator (`==`) is used to compare values.

What do you think about adding code blocks around the ==, since it's referring to code?

regal archBOT Feb 27, 2021, 6:53 PM

#

MarkKoz

[python-discord/bot] New comment on issue #361: Potential Unhandled Exceptions in Perpetual Tasks

Yes. It may seem like it doesn't come up because exceptions are not caught anywhere and this is more of a proactive measure than a reactive one.

I made some progress by implementing this https://github.com/python-discord/bot/blob/master/bot/utils/scheduling.py#L160-L164

However, there is no support for scheduling on a loop (which is necessary to be able to schedule tasks before the loop starts) nor is there support for retrying upon failure. Still, logging exceptions is beneficial for a...

regal archBOT Feb 27, 2021, 10:59 PM

#

SebastiaanZ

[api:main] 9 new commits

ed9e1c8 Add package docstrings to init.py files - SebastiaanZ
7dd5168 Add docstrings to modules and functions - SebastiaanZ
9e01891 Configure Settings to automatically read from .env - SebastiaanZ
169354a Add commit sha to API health check response - SebastiaanZ
cb938a3 Add dependencies for async tests - SebastiaanZ

regal archBOT Feb 27, 2021, 11:23 PM

#

SebastiaanZ

[api:main] 3 new commits

f316974 Add pre-commit configuration - SebastiaanZ
71af743 Add black to pre-commit configuration - SebastiaanZ
bf684a6 Fix issues identified by new pre-commit checks - SebastiaanZ

odd spireBOT Feb 28, 2021, 12:50 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #595 Update Tic Tac Toe Command

GitHub Actions run 606655248 succeeded.

PR Author

Workflow Run

Lint #392

Source Branch

Shivansh-007:fix/ttt

#

[python-discord/sir-lancebot] Checks Successful on PR: #600 Improve Wikipedia Command

GitHub Actions run 606657239 succeeded.

PR Author

Workflow Run

Lint #393

Source Branch

Shivansh-007:feature/improve-wiki

regal archBOT Feb 28, 2021, 2:25 AM

#

SavagePastaMan

[python-discord/bot] Pull request review submitted: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

#

SavagePastaMan

[python-discord/bot] New review comment on pull request #1439: Add a tag to explain a common error with substituting \`=\` and \`==\`\.

Is there an equally concise name for the other? Equality operator? Equivalence operator?

#

SavagePastaMan

[python-discord/bot] Pull request review submitted: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

#

SavagePastaMan

[python-discord/bot] New review comment on pull request #1439: Add a tag to explain a common error with substituting \`=\` and \`==\`\.

Yep, I agree.

#

SavagePastaMan

[python-discord/bot] New review comment on pull request #1439: Add a tag to explain a common error with substituting \`=\` and \`==\`\.

Yep

#

SavagePastaMan

[python-discord/bot] Pull request review submitted: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

#

SavagePastaMan

[bot:comparison\-tag] 1 new commit

f542866 Improve examples and add codeblocks where needed. - SavagePastaMan

odd spireBOT Feb 28, 2021, 2:42 AM

#

[python-discord/bot] Checks Successful on PR: #1439 Add a tag to explain a common error with substituting `=` and `==`.

GitHub Actions run 606831958 succeeded.

PR Author

Workflow Run

Lint & Test #562

Source Branch

comparison-tag

regal archBOT Feb 28, 2021, 9:36 AM

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #63 Support code unit testing through snekbox

#

HassanAbouelela

[forms-backend:abouelela\-codeowners] 1 new commit

99f7e00 Adds Hassan Abouelela To Code Owners - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] New branch created: abouelela\-codeowners

#

HassanAbouelela

[python-discord/forms-backend] Pull request opened: #64 Adds Hassan Abouelela To Code Owners

odd spireBOT Feb 28, 2021, 9:39 AM

#

[python-discord/forms-backend] Checks Successful on PR: #64 Adds Hassan Abouelela To Code Owners

GitHub Actions run 607457724 succeeded.

PR Author

Workflow Run

Forms Backend #231

Source Branch

abouelela-codeowners

regal archBOT Feb 28, 2021, 9:40 AM

#

HassanAbouelela

[forms-backend] Branch abouelela\-codeowners was force-pushed to `dd4d4b7`

odd spireBOT Feb 28, 2021, 9:41 AM

#

[python-discord/forms-backend] Checks Successful on PR: #64 Adds Hassan Abouelela To Code Owners

GitHub Actions run 607461643 succeeded.

PR Author

Workflow Run

Forms Backend #232

Source Branch

abouelela-codeowners

regal archBOT Feb 28, 2021, 9:42 AM

#

jb3

[python-discord/site] Issue opened: #449 Dewikification: Group resources by experience level

Remember to target the dewikification branch with this pull request

We should add functionality to group resources by experience level, for example some of our editors are really suited for beginner programmers and some for advanced, but we have no way of distinguishing that right now.

Each resource in our collection should have a difficulty rating which is one of:

Beginner
Intermediate
Advanced

This issue supersedes python-discord/meta#49.

#

Akarys42

[python-discord/forms-backend] Pull request review submitted: #64 Adds Hassan Abouelela To Code Owners

regal archBOT Feb 28, 2021, 11:22 AM

#

ks129

[python-discord/forms-backend] Pull request review submitted: #64 Adds Hassan Abouelela To Code Owners

#

ks129

[python-discord/forms-backend] Pull request closed: #64 Adds Hassan Abouelela To Code Owners

#

ks129

[forms-backend:main] 2 new commits

dd4d4b7 Adds Hassan Abouelela To Code Owners - HassanAbouelela
f1e1223 Merge pull request #64 from python-discord/abou... - ks129

#

ks129

[python-discord/forms-backend] branch deleted: abouelela\-codeowners

#

ks129

[python-discord/forms-backend] Pull request review submitted: #63 Support code unit testing through snekbox

Wow, really really nice work! 😃

#

ks129

[forms-backend:ks123/role\-assigning] 7 new commits

87012d5 Bump starlette from 0.14.1 to 0.14.2 - dependabot[bot]
993b230 Merge pull request #55 from python-discord/depe... - ks129
0da9c70 Bump motor from 2.3.0 to 2.3.1 - dependabot[bot]
c6cd8fe Merge pull request #56 from python-discord/depe... - jb3
dd4d4b7 Adds Hassan Abouelela To Code Owners - HassanAbouelela

#

HassanAbouelela

[forms-backend:feat/9/unittest\-validation] 3 new commits

dd4d4b7 Adds Hassan Abouelela To Code Owners - HassanAbouelela
f1e1223 Merge pull request #64 from python-discord/abou... - ks129
7a1ea21 Merge branch 'main' into feat/9/unittest-valida... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] Issue closed: #9 Add support for unittest evaluation using snekbox

#

HassanAbouelela

[python-discord/forms-backend] Pull request closed: #63 Support code unit testing through snekbox

#

HassanAbouelela

[forms-backend:main] 29 new commits

c31bb72 Add snekbox to the environment - Akarys42
c311359 Add unittests to the schema - Akarys42
d931810 Add unittest template - Akarys42
6c38d1f Support code unit testing through snekbox - Akarys42
96c659f Hook up unittesting in the submit protocol - Akarys42

#

HassanAbouelela

[python-discord/forms-backend] branch deleted: feat/9/unittest\-validation

odd spireBOT Feb 28, 2021, 11:26 AM

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 607617737 succeeded.

Actor

Workflow Run

Forms Backend #233

Commit

f1e1223

#

[python-discord/forms-backend] Checks Successful on PR: #49 Implement Discord roles assigning for form submissions

GitHub Actions run 607622546 succeeded.

PR Author

Workflow Run

Forms Backend #234

Source Branch

ks123/role-assigning

#

[python-discord/forms-backend] Checks Successful on PR: #63 Support code unit testing through snekbox

GitHub Actions run 607623236 succeeded.

PR Author

Workflow Run

Forms Backend #235

Source Branch

feat/9/unittest-validation

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 607624121 succeeded.

Actor

Workflow Run

Forms Backend #236

Commit

cf13799

regal archBOT Feb 28, 2021, 11:35 AM

#

HassanAbouelela

[forms-backend:token\-expiry] 32 new commits

c31bb72 Add snekbox to the environment - Akarys42
c311359 Add unittests to the schema - Akarys42
d931810 Add unittest template - Akarys42
6c38d1f Support code unit testing through snekbox - Akarys42
96c659f Hook up unittesting in the submit protocol - Akarys42

odd spireBOT Feb 28, 2021, 11:36 AM

#

[python-discord/forms-backend] Checks Successful on PR: #58 Redesign Authentication Process

GitHub Actions run 607637534 succeeded.

PR Author

Workflow Run

Forms Backend #237

Source Branch

token-expiry

regal archBOT Feb 28, 2021, 11:41 AM

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #62 Bump uvicorn from 0\.13\.3 to 0\.13\.4

#

HassanAbouelela

[forms-backend:dependabot/pip/uvicorn\-0\.13\.4] 32 new commits

c31bb72 Add snekbox to the environment - Akarys42
c311359 Add unittests to the schema - Akarys42
d931810 Add unittest template - Akarys42
6c38d1f Support code unit testing through snekbox - Akarys42
96c659f Hook up unittesting in the submit protocol - Akarys42

#

HassanAbouelela

[python-discord/forms-backend] Pull request closed: #62 Bump uvicorn from 0\.13\.3 to 0\.13\.4

#

HassanAbouelela

[forms-backend:main] 3 new commits

3293927 Bump uvicorn from 0.13.3 to 0.13.4 - dependabot[bot]
f15dc34 Merge branch 'main' into dependabot/pip/uvicorn... - HassanAbouelela
715ef65 Merge pull request #62 from python-discord/depe... - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] branch deleted: dependabot/pip/uvicorn\-0\.13\.4

odd spireBOT Feb 28, 2021, 11:42 AM

#

[python-discord/forms-backend] Checks Successful on PR: #62 Bump uvicorn from 0.13.3 to 0.13.4

GitHub Actions run 607648291 succeeded.

PR Author

Workflow Run

Forms Backend #238

Source Branch

dependabot/pip/uvicorn-0...

#

[python-discord/forms-backend] Workflow Successful

GitHub Actions run 607649667 succeeded.

Actor

Workflow Run

Forms Backend #239

Commit

715ef65

regal archBOT Feb 28, 2021, 11:49 AM

#

HassanAbouelela

[forms-backend:dependabot/pip/sentry\-sdk\-0\.20\.3] 35 new commits

3293927 Bump uvicorn from 0.13.3 to 0.13.4 - dependabot[bot]
c31bb72 Add snekbox to the environment - Akarys42
c311359 Add unittests to the schema - Akarys42
d931810 Add unittest template - Akarys42
6c38d1f Support code unit testing through snekbox - Akarys42

odd spireBOT Feb 28, 2021, 11:51 AM

#

[python-discord/forms-backend] Checks Successful on PR: #61 Bump sentry-sdk from 0.19.5 to 0.20.3

GitHub Actions run 607659709 succeeded.

PR Author

Workflow Run

Forms Backend #240

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Feb 28, 2021, 3:24 PM

#

Akarys42

[smartconfig:package\-develop] 1 new commit

cf46693 Remove attributes from the man configuration wh... - Akarys42

#

Akarys42

[smartconfig] Branch package\-develop was force-pushed to `20f3e2b`

#

swfarnsworth

[python-discord/bot] Pull request review submitted: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

LGTM

regal archBOT Feb 28, 2021, 4:36 PM

#

swfarnsworth

[python-discord/bot] Pull request review submitted: #1435 Instructions to dispute an infraction vary by infraction type\.

#

swfarnsworth

[python-discord/bot] New review comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

For all infractions that remove the individual from the server, the infr_type argument that gets passed to this function is 'Ban' (upper-case B), as opposed to 'ban' or 'kick', which are the names for those infractions used elsewhere in the code base. I therefore decided on a string literal in the function so that we don't give the false impression that 'Ban' is used elsewhere.

#

swfarnsworth

[python-discord/bot] Pull request review submitted: #1435 Instructions to dispute an infraction vary by infraction type\.

#

swfarnsworth

[python-discord/bot] New review comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

I tried this and it didn't render as expected, presumably because the DM is out-of-guild content.

#

swfarnsworth

[python-discord/bot] Pull request review submitted: #1435 Instructions to dispute an infraction vary by infraction type\.

#

swfarnsworth

[python-discord/bot] New review comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

That's fine. Perhaps we could add that rule to the pre-commit checks?

#

swfarnsworth

[bot:swfarnsworth/infraction\_message] 1 new commit

75f2b9d Update the tests to reflect changes in expected... - swfarnsworth

#

swfarnsworth

[python-discord/bot] New comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

@Akarys42 I'll commit the change you requested regarding the formatting of multi-line strings along with any other requested changes.

#

Akarys42

[python-discord/bot] Pull request review submitted: #1435 Instructions to dispute an infraction vary by infraction type\.

#

Akarys42

[python-discord/bot] New review comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

Alright, it is fine like this then

odd spireBOT Feb 28, 2021, 4:42 PM

#

[python-discord/bot] Checks Successful on PR: #1435 Instructions to dispute an infraction vary by infraction type.

GitHub Actions run 608120924 succeeded.

PR Author

swfarnsworth

Workflow Run

Lint & Test #563

Source Branch

swfarnsworth/infraction_message

regal archBOT Feb 28, 2021, 4:44 PM

#

Akarys42

[python-discord/bot] Pull request review submitted: #1435 Instructions to dispute an infraction vary by infraction type\.

#

Akarys42

[python-discord/bot] New review comment on pull request #1435: Instructions to dispute an infraction vary by infraction type\.

Hmm yeah it can cause issues if it isn't in the cache. Could we maybe have both, like having a mention in parenthesis along with the bot name?

regal archBOT Feb 28, 2021, 7:42 PM

#

jb3

[python-discord/branding] New comment on issue #118: Python Discord\-specific PFP for the ModMail bot

We've actioned this through other means, so changing our modmail branding is not necessary.

#

jb3

[python-discord/branding] Issue closed: #118 Python Discord\-specific PFP for the ModMail bot

#

ChrisLovering

[sir-lancebot:Add\-lancebot\-to\-staff\-channels] 1 new commit

f429ce6 Add issue cog to staff channels. - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] New branch created: Add\-lancebot\-to\-staff\-channels

#

ChrisLovering

[python-discord/sir-lancebot] Pull request opened: #604 Add issue cog to staff channels\.

Description

Add staff category and staff voice to constants.py and added them to the list in the issues cog.

Reasoning

To make use of the already present code.

Did you:

[ ] Join the Python Discord Community?
[ ] If dependencies have been added or updated, run pipenv lock?
[ ] Lint your code (pipenv run lint)?
[ ] Set the PR to allow edits from contributors?

odd spireBOT Feb 28, 2021, 7:50 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #604 Add issue cog to staff channels.

GitHub Actions run 608435550 succeeded.

PR Author

Workflow Run

Lint #394

Source Branch

Add-lancebot-to-staff-channels

regal archBOT Feb 28, 2021, 7:58 PM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #604 Add issue cog to staff channels\.

https://github.com/python-discord/sir-lancebot/blob/f429ce6aaa57d680893be0cbd5a7760de947aac6/bot/constants.py#L130-L135
Should be in the same order as the following:
https://github.com/python-discord/sir-lancebot/blob/f429ce6aaa57d680893be0cbd5a7760de947aac6/bot/exts/evergreen/issues.py#L26-L28

Also, this
https://github.com/python-discord/sir-lancebot/blob/f429ce6aaa57d680893be0cbd5a7760de947aac6/bot/constants.py#L96-L127
Should be in the same order as
https://github.com/python-discor...

regal archBOT Feb 28, 2021, 8:13 PM

#

Xithrius

[python-discord/bot] Pull request review submitted: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

Very cool.

#

ChrisLovering

[sir-lancebot:Add\-lancebot\-to\-staff\-channels] 1 new commit

6994d03 Fix ordering of categories in issues cog - ChrisLovering

odd spireBOT Feb 28, 2021, 8:14 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #604 Add issue cog to staff channels.

GitHub Actions run 608469627 succeeded.

PR Author

Workflow Run

Lint #395

Source Branch

Add-lancebot-to-staff-channels

regal archBOT Feb 28, 2021, 8:56 PM

#

gustavwilliam

[python-discord/bot] Pull request review submitted: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

Looks excellent! Just one minor tweak and it'll be great.

#

gustavwilliam

[python-discord/bot] New review comment on pull request #1439: Add a tag to explain a common error with substituting \`=\` and \`==\`\.

print(x)  # Prints 5

Let's make sure this follows pep 8

#

gustavwilliam

[bot:comparison\-tag] 1 new commit

fbef11f Make assignment vs equals tag pep 8 compliant - gustavwilliam

#

gustavwilliam

[python-discord/bot] Pull request review submitted: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

Perfect. This is a very well needed tag.

odd spireBOT Feb 28, 2021, 9:01 PM

#

[python-discord/bot] Checks Successful on PR: #1439 Add a tag to explain a common error with substituting `=` and `==`.

GitHub Actions run 608538791 succeeded.

PR Author

Workflow Run

Lint & Test #564

Source Branch

comparison-tag

regal archBOT Feb 28, 2021, 9:04 PM

#

gustavwilliam

[bot:comparison\-tag] 1 new commit

7edfbad Capitalise word in assignment vs comparison tag - gustavwilliam

odd spireBOT Feb 28, 2021, 9:07 PM

#

[python-discord/bot] Checks Successful on PR: #1439 Add a tag to explain a common error with substituting `=` and `==`.

GitHub Actions run 608547237 succeeded.

PR Author

Workflow Run

Lint & Test #565

Source Branch

comparison-tag

regal archBOT Feb 28, 2021, 9:10 PM

#

Xithrius

[bot] Branch comparison\-tag was force-pushed to `e82429c`

odd spireBOT Feb 28, 2021, 9:13 PM

#

[python-discord/bot] Checks Successful on PR: #1439 Add a tag to explain a common error with substituting `=` and `==`.

GitHub Actions run 608557815 succeeded.

PR Author

Workflow Run

Lint & Test #566

Source Branch

comparison-tag

regal archBOT Feb 28, 2021, 9:16 PM

#

Xithrius

[python-discord/bot] Pull request closed: #1439 Add a tag to explain a common error with substituting \`=\` and \`==\`\.

#

Xithrius

[python-discord/bot] branch deleted: comparison\-tag

#

Xithrius

[bot:master] 2 new commits

e82429c Create comparison.md - SavagePastaMan
f040a27 Merge pull request #1439 from python-discord/co... - Xithrius

oak estuaryBOT Feb 28, 2021, 9:19 PM

#

Python Bot

Connected!

odd spireBOT Feb 28, 2021, 9:20 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 608573157 succeeded.

Actor

Workflow Run

Deploy #166

Commit

f040a27

regal archBOT Feb 28, 2021, 10:10 PM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #604 Add issue cog to staff channels\.

Thanks for the changes, I think this is good to be merged once you address the reordering.

#

ChrisLovering

[sir-lancebot] Branch Add\-lancebot\-to\-staff\-channels was force-pushed to `b61aa30`

#

ToxicKidz

[python-discord/sir-lancebot] New comment on pull request #597: Move pfp commands into executors

For #594 commands.max_concurrency won't work, as it can only impose the limits to a single command, rather that at a group at a time.
This isn't true, you can put the commands.max_concurrency check on the group and every time the group's subcommand are invoked it will use that check.

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #603: Added more topics\.

The seems quite wordy to me, maybe a comma could help?

    - What is something you know now, that you wish you knew when you were starting out?

Maybe even

    - What is something you know now, that you wish you knew when starting out?

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #603 Added more topics\.

These look good to me! One minor point about one of the topics, but not enough to stop the merge!

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #597: Move pfp commands into executors

For #594 commands.max_concurrency won't work, as it can only impose the limits to a single command, rather that at a group at a time.

This isn't true, you can put the commands.max_concurrency check on the group and every time the group's subcommand are invoked it will use that check.

Huh, maybe my tests we're conclusive enough. I'll give this another look soon.

regal archBOT Feb 28, 2021, 10:57 PM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #604 Add issue cog to staff channels\.

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #604 Add issue cog to staff channels\.

#

Xithrius

[sir-lancebot:master] 3 new commits

f429ce6 Add issue cog to staff channels. - ChrisLovering
b61aa30 Fix ordering of categories in issues cog - ChrisLovering
05969b7 Merge pull request #604 from python-discord/Add... - Xithrius

#

Xithrius

[python-discord/sir-lancebot] branch deleted: Add\-lancebot\-to\-staff\-channels

night lilyBOT Feb 28, 2021, 11:01 PM

#

Sir Lancebot

Connected!

odd spireBOT Feb 28, 2021, 11:01 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 608730369 succeeded.

Actor

Workflow Run

Build #153

Commit

05969b7

regal archBOT Mar 1, 2021, 3:54 AM

#

gustavwilliam

[branding:banner\-pattern] 1 new commit

ebf62a2 Add banner pattern tiles - gustavwilliam

#

gustavwilliam

[python-discord/branding] New branch created: banner\-pattern

regal archBOT Mar 1, 2021, 4:10 AM

#

gustavwilliam

[python-discord/branding] Pull request opened: #124 Add banner pattern tiles

The tiles are repeated in a grid to form a banner pattern.
pattern-tile

Application

Used in the site's custom error pages as part of a repeating background pattern. This PR will need to be merged before the error pages will be functional. Here is current version of the page in question:
![image](https://user-images.githubusercontent.com/65498475/109450143-83108a80-7a4a-11eb-8a8f-...

regal archBOT Mar 1, 2021, 5:00 AM

#

jb3

[python-discord/branding] Pull request review submitted: #124 Add banner pattern tiles

#

jb3

[python-discord/branding] Pull request closed: #124 Add banner pattern tiles

#

jb3

[branding:master] 1 new commit

2c85ab3 Add banner pattern tiles (#124) - gustavwilliam

regal archBOT Mar 1, 2021, 5:49 AM

#

Xithrius

[sir-lancebot:modifying\-topics] 1 new commit

f74a49f Removed wordy-ness of one singular question. - Xithrius

odd spireBOT Mar 1, 2021, 5:50 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #603 Added more topics.

GitHub Actions run 609495989 succeeded.

PR Author

Workflow Run

Lint #398

Source Branch

modifying-topics

regal archBOT Mar 1, 2021, 5:52 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #603 Added more topics\.

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #603: Added more topics\.

I feel like that could start some sort of flame war, so I'll leave it alone for now and see how it does.

#

Xithrius

[sir-lancebot:modifying\-topics] 1 new commit

f9339e6 There's no such thing as TLI. Added TUI. - Xithrius

odd spireBOT Mar 1, 2021, 5:54 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #603 Added more topics.

GitHub Actions run 609503073 succeeded.

PR Author

Workflow Run

Lint #399

Source Branch

modifying-topics

regal archBOT Mar 1, 2021, 6:06 AM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #603 Added more topics\.

No major comments, I'd live without the changes. New topics are always appreciated it.

#

HassanAbouelela

[python-discord/sir-lancebot] New review comment on pull request #603: Added more topics\.

Just unacceptable.

- What is your favourite color?

#

HassanAbouelela

[python-discord/sir-lancebot] New review comment on pull request #603: Added more topics\.

This question is quite wordy, but since it's just moving and old question, I won't complain if you leave it as is. If you're looking for ways to shorten it, I think we can start with lobbing of when programming in Python.

#

Xithrius

[sir-lancebot:modifying\-topics] 1 new commit

add46b3 "colour" to "color". - Xithrius

odd spireBOT Mar 1, 2021, 6:07 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #603 Added more topics.

GitHub Actions run 609528608 succeeded.

PR Author

Workflow Run

Lint #400

Source Branch

modifying-topics

regal archBOT Mar 1, 2021, 6:08 AM

#

Xithrius

[sir-lancebot:modifying\-topics] 36 new commits

3616302 Add connect four cog supporting player vs playe... - Shivansh-007
f44a39d fix grammar and spacing - Shivansh-007
24e7f95 COrrect annotations and improve docstrings ; ma... - Shivansh-007
d1acfa3 Change Ai to bot's user and add stop game funct... - Shivansh-007
46e594c Add loading message before finishing all reacti... - Shivansh-007

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #603 Added more topics\.

#

Xithrius

[sir-lancebot:master] 6 new commits

3766b14 Added more topics. - Xithrius
f74a49f Removed wordy-ness of one singular question. - Xithrius
f9339e6 There's no such thing as TLI. Added TUI. - Xithrius
add46b3 "colour" to "color". - Xithrius
25d6845 Merge branch 'master' into modifying-topics - Xithrius

#

Xithrius

[python-discord/sir-lancebot] branch deleted: modifying\-topics

odd spireBOT Mar 1, 2021, 6:09 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #603 Added more topics.

GitHub Actions run 609533199 succeeded.

PR Author

Workflow Run

Lint #401

Source Branch

modifying-topics

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 609536411 succeeded.

Actor

Workflow Run

Build #154

Commit

6177659

night lilyBOT Mar 1, 2021, 6:14 AM

#

Sir Lancebot

Connected!

odd spireBOT Mar 1, 2021, 6:32 AM

#

[python-discord/bot] Checks Failed on PR: #836 Tags cog unit tests and tags cog fixes

GitHub Actions run 609583785 failed.

PR Author

Workflow Run

Lint & Test #568

Source Branch

ks129:tags-tests

#

[python-discord/bot] Checks Successful on PR: #836 Tags cog unit tests and tags cog fixes

GitHub Actions run 609591253 succeeded.

PR Author

Workflow Run

Lint & Test #569

Source Branch

ks129:tags-tests

regal archBOT Mar 1, 2021, 7:19 AM

#

Senjan21

[python-discord/bot] Pull request review submitted: #836 Tags cog unit tests and tags cog fixes

Code and logic wise, all looks good! Thanks for the PR!

regal archBOT Mar 1, 2021, 8:06 AM

#

HassanAbouelela

[python-discord/site] New comment on pull request #447: Rework nominations

I've looked over the new schema, and from a functional standpoint, it seems good.

Here are the old vs new schemas if anyone wants to compare (you can play around with it here):

Old
New

odd spireBOT Mar 1, 2021, 8:37 AM

#

[python-discord/forms-backend] Checks Successful on PR: #65 Bump pydantic from 1.7.3 to 1.8

GitHub Actions run 609867458 succeeded.

PR Author

Workflow Run

Forms Backend #241

Source Branch

dependabot/pip/pydantic-1.8

#

[python-discord/forms-backend] Checks Successful on PR: #66 Bump httpx from 0.16.1 to 0.17.0

GitHub Actions run 609868520 succeeded.

PR Author

Workflow Run

Forms Backend #242

Source Branch

dependabot/pip/httpx-0.17.0

regal archBOT Mar 1, 2021, 10:18 AM

#

gustavwilliam

[branding:fix\-pattern] 1 new commit

40eac26 Fix artifact in banner pattern png - gustavwilliam

#

gustavwilliam

[python-discord/branding] New branch created: fix\-pattern

#

gustavwilliam

[python-discord/branding] Pull request opened: #125 Fix artifact in banner pattern png

Fixes an issue where the left side of the png has an approximately 1 px wide strand of semi-transparency. This led to the tile being rendered in a strange way when combined with other tiles. This is the original:
pattern-tile

This is the updated version:
pydis-tile

This was mo...

#

bast0006

[python-discord/bot] Pull request opened: #1440 Add \!u, \!tban, \!superstar, and \!unsuperstar aliases

#

jb3

[python-discord/branding] Pull request review submitted: #125 Fix artifact in banner pattern png

#

jb3

[python-discord/branding] Pull request closed: #125 Fix artifact in banner pattern png

#

jb3

[branding:master] 1 new commit

41633a5 Fix artifact in banner pattern png (#125) - gustavwilliam

#

jb3

[python-discord/branding] branch deleted: fix\-pattern

#

ks129

[python-discord/bot] Pull request review submitted: #1440 Add \!u, \!tban, \!superstar, and \!unsuperstar aliases

#

Senjan21

[python-discord/bot] Pull request review submitted: #1440 Add \!u, \!tban, \!superstar, and \!unsuperstar aliases

#

Senjan21

[python-discord/bot] Pull request closed: #1440 Add \!u, \!tban, \!superstar, and \!unsuperstar aliases

#

Senjan21

[bot:master] 5 new commits

c3a9e70 Add alias !u for !user - bast0006
5b31aa9 Add alias !tban for !tempban - bast0006
58c3736 Add !superstar and !unsuperstar aliases for !su... - bast0006
dec9a9d Add !stban alias for !shadowtempban - bast0006
29ab19b Merge pull request #1440 from bast0006/master - Senjan21

odd spireBOT Mar 1, 2021, 10:42 AM

#

[python-discord/bot] Checks Successful on PR: #1440 Add !u, !tban, !superstar, and !unsuperstar aliases

GitHub Actions run 610146898 succeeded.

PR Author

bast0006

Workflow Run

Lint & Test #571

Source Branch

bast0006:master

oak estuaryBOT Mar 1, 2021, 10:48 AM

#

Python Bot

Connected!

odd spireBOT Mar 1, 2021, 10:50 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 610177199 succeeded.

Actor

Senjan21

Workflow Run

Deploy #168

Commit

29ab19b

regal archBOT Mar 1, 2021, 12:18 PM

#

gustavwilliam

[python-discord/branding] Issue closed: #114 "star\-struck" lemoji

#

gustavwilliam

[python-discord/branding] Pull request closed: #115 Add lemon\_starstruck lemoji

#

gustavwilliam

[branding:master] 11 new commits

60bb73f Add lemon starstruck svg - v1nam
d3b1a5c Add lemon_starstruck png - v1nam
7a9a9ea Delete lemon_starstruck.svg - v1nam
156f34b Add files via upload - v1nam
88e9fde Delete lemon_starstruck.png - v1nam

regal archBOT Mar 1, 2021, 1:27 PM

#

ks129

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

We are using Motor, which is asynchronous.

#

ks129

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

Let's give refresh default value False.

#

ks129

[python-discord/forms-backend] Pull request review submitted: #58 Redesign Authentication Process

#

ks129

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

Please set this to false by default in docker-compose.yml.

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #58 Redesign Authentication Process

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

I don't think that really makes sense to be honest. It's a value that will highly depend on the situation, and will significantly alter the way the function works, so it should be explicitly specified by the caller.

regal archBOT Mar 1, 2021, 1:51 PM

#

HassanAbouelela

[forms-backend:token\-expiry] 1 new commit

c175279 Allows All CORS Requests On Development - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-backend] Pull request review submitted: #58 Redesign Authentication Process

#

HassanAbouelela

[python-discord/forms-backend] New review comment on pull request #58: Redesign Authentication Process

This wasn't enough on its own due to the way docker handles external traffic, so I just resorted to allowing all non-production traffic.

odd spireBOT Mar 1, 2021, 1:52 PM

#

[python-discord/forms-backend] Checks Successful on PR: #58 Redesign Authentication Process

GitHub Actions run 610685379 succeeded.

PR Author

Workflow Run

Forms Backend #243

Source Branch

token-expiry

regal archBOT Mar 1, 2021, 1:57 PM

#

HassanAbouelela

[forms-backend:token\-expiry] 1 new commit

da41f25 Make Admin Fetch Async - HassanAbouelela

odd spireBOT Mar 1, 2021, 1:59 PM

#

[python-discord/forms-backend] Checks Successful on PR: #58 Redesign Authentication Process

GitHub Actions run 610698827 succeeded.

PR Author

Workflow Run

Forms Backend #244

Source Branch

token-expiry

regal archBOT Mar 1, 2021, 3:06 PM

#

asleep-cult

[python-discord/bot] Pull request opened: #1441 Unescape html escape characters in reddit text and titles

Use html.unescape to replace html escape characters with their Unicode equivalent in reddit text and titles.
Examples:

odd spireBOT Mar 1, 2021, 3:07 PM

#

[python-discord/bot] Checks Failed on PR: #1441 Unescape html escape characters in reddit text and titles

GitHub Actions run 610888674 failed.

PR Author

Workflow Run

Lint & Test #573

Source Branch

asleep-cult:master

#

[python-discord/bot] Checks Failed on PR: #1441 Unescape html escape characters in reddit text and titles

GitHub Actions run 610898431 failed.

PR Author

Workflow Run

Lint & Test #574

Source Branch

asleep-cult:master

odd spireBOT Mar 1, 2021, 3:58 PM

#

[python-discord/bot] Checks Failed on PR: #1441 Unescape html escape characters in reddit text and titles

GitHub Actions run 611039411 failed.

PR Author

Workflow Run

Lint & Test #575

Source Branch

asleep-cult:master

regal archBOT Mar 1, 2021, 4:14 PM

#

gustavwilliam

[site:error\_pages] 3 new commits

ebf128e Add 404 page - gustavwilliam
3020e2e Add error page styling - gustavwilliam
df9f590 Add 500 page - gustavwilliam

#

gustavwilliam

[python-discord/site] New branch created: error\_pages

#

gustavwilliam

[python-discord/site] Pull request opened: #450 New error pages

This PR adds pages for 404 and 500 errors on the site. They are following the same structure as the recently merged custom CF error pages (python-discord/error-pages#1).

Preview

404

500

odd spireBOT Mar 1, 2021, 4:24 PM

#

[python-discord/site] Checks Successful on PR: #450 New error pages

GitHub Actions run 611112453 succeeded.

PR Author

Workflow Run

Lint & Test #97

Source Branch

error_pages

regal archBOT Mar 1, 2021, 4:30 PM

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1441 Unescape html escape characters in reddit text and titles

Nitpick

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1441: Unescape html escape characters in reddit text and titles

We don’t really need the full library here.

from html import unescape

#

Senjan21

[python-discord/sir-lancebot] Pull request review submitted: #600 Improve Wikipedia Command

Looks good, thanks.

#

Senjan21

[python-discord/sir-lancebot] Issue closed: #565 Improve Wikipedia Command\.

#

Senjan21

[python-discord/sir-lancebot] Pull request closed: #600 Improve Wikipedia Command

#

Senjan21

[sir-lancebot:master] 7 new commits

8cdd0b3 Improve wikipedia command to send a snippet of ... - Shivansh-007
86dc294 Goodbye Wikipedia Class, no need of you anymore - Shivansh-007
fa9e205 Add log.info() statement if the wikipedia api r... - Shivansh-007
439873d Don't use enums for wikipedia error messages, u... - Shivansh-007
db4b3d4 Merge branch 'master' into feature/improve-wiki - Shivansh-007

odd spireBOT Mar 1, 2021, 4:36 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #600 Improve Wikipedia Command

GitHub Actions run 611149640 succeeded.

PR Author

Workflow Run

Lint #403

Source Branch

Shivansh-007:feature/improve-wiki

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 611154483 succeeded.

Actor

Senjan21

Workflow Run

Build #155

Commit

09c371e

night lilyBOT Mar 1, 2021, 4:40 PM

#

Sir Lancebot

Connected!

odd spireBOT Mar 1, 2021, 4:46 PM

#

[python-discord/bot] Checks Successful on PR: #1441 Unescape html escape characters in reddit text and titles

GitHub Actions run 611176602 succeeded.

PR Author

Workflow Run

Lint & Test #576

Source Branch

asleep-cult:master

regal archBOT Mar 1, 2021, 5:02 PM

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1441 Unescape html escape characters in reddit text and titles

Thanks! Looks Good To Me!

odd spireBOT Mar 1, 2021, 5:03 PM

#

[python-discord/bot] Checks Successful on PR: #1441 Unescape html escape characters in reddit text and titles

GitHub Actions run 611225898 succeeded.

PR Author

Workflow Run

Lint & Test #577

Source Branch

asleep-cult:master

regal archBOT Mar 1, 2021, 5:46 PM

#

mbaruh

[bot:mbaruh/defcon] 1 new commit

2293b9d Change to handle specifically redis errors - mbaruh

odd spireBOT Mar 1, 2021, 5:49 PM

#

[python-discord/bot] Checks Successful on PR: #1262 Defcon overhaul

GitHub Actions run 611352628 succeeded.

PR Author

Workflow Run

Lint & Test #578

Source Branch

mbaruh/defcon

regal archBOT Mar 1, 2021, 5:51 PM

#

mbaruh

[bot:mbaruh/defcon] 1 new commit

b9d1de2 Provide default cache values when syncing - mbaruh

odd spireBOT Mar 1, 2021, 5:53 PM

#

[python-discord/bot] Checks Successful on PR: #1262 Defcon overhaul

GitHub Actions run 611365362 succeeded.

PR Author

Workflow Run

Lint & Test #579

Source Branch

mbaruh/defcon

regal archBOT Mar 1, 2021, 6:00 PM

#

gustavwilliam

[bot:license\-year] 1 new commit

b33fc15 Bump license year to 2021 - gustavwilliam

#

gustavwilliam

[python-discord/bot] New branch created: license\-year

#

gustavwilliam

[python-discord/bot] Pull request opened: #1442 Bump license year to 2021

It seems like we were enjoying a good old 2018 license. Time to update!

odd spireBOT Mar 1, 2021, 6:04 PM

#

[python-discord/bot] Checks Successful on PR: #1442 Bump license year to 2021

GitHub Actions run 611393272 succeeded.

PR Author

Workflow Run

Lint & Test #580

Source Branch

license-year

regal archBOT Mar 1, 2021, 6:04 PM

#

gustavwilliam

[bot:license\-year] 1 new commit

91defa2 Update license year to a range - gustavwilliam

odd spireBOT Mar 1, 2021, 6:06 PM

#

[python-discord/bot] Checks Successful on PR: #1442 Bump license year to 2021

GitHub Actions run 611400901 succeeded.

PR Author

Workflow Run

Lint & Test #581

Source Branch

license-year

regal archBOT Mar 1, 2021, 6:22 PM

#

lemonsaurus

[python-discord/site] Pull request review submitted: #450 New error pages

Looks very good overall. Excellent work, @gustavwilliam.

#

lemonsaurus

[python-discord/site] New review comment on pull request #450: New error pages

I'm nitpicking, but in RFC7231 where this error code is defined, it's styled with capital letters, like 404 Not Found.

            <h1>404 — Not Found</h1>

#

lemonsaurus

[python-discord/site] New review comment on pull request #450: New error pages

Same thing here, see https://tools.ietf.org/html/rfc7231#section-6.6.1

            <h1>500 — Internal Server Error</h1>

#

jb3

[python-discord/site] Pull request review submitted: #450 New error pages

Looks good. Minor comment on wording + including a Discord link on the 500 page as well as the 404 one.

#

jb3

[python-discord/site] New review comment on pull request #450: New error pages

            <p>Something went wrong at our end. Please try again shortly, or if the problem persists please let us know <a href="https://discord.gg/python">on Discord</a></p>

#

jb3

[python-discord/bot] New comment on pull request #1442: Bump license year to 2021

Since we have implicit copyright for 95 years it isn't necessary to update this. If we make major alterations to the project we can add a year like ":copyright: 2018, 2021" but at this stage I don't think that is necessary.

For certain, we should not rebuke our 2018 license, as that is the time of publication.

#

jb3

[python-discord/bot] Pull request closed: #1442 Bump license year to 2021

#

jb3

[python-discord/bot] branch deleted: license\-year

regal archBOT Mar 1, 2021, 7:28 PM

#

gustavwilliam

[site:error\_pages] 1 new commit

1ed129f Capitalise error codes in 404 and 500 pages - gustavwilliam

odd spireBOT Mar 1, 2021, 7:30 PM

#

[python-discord/site] Checks Successful on PR: #450 New error pages

GitHub Actions run 611621554 succeeded.

PR Author

Workflow Run

Lint & Test #98

Source Branch

error_pages

regal archBOT Mar 1, 2021, 7:34 PM

#

gustavwilliam

[site:error\_pages] 1 new commit

9243fef Update error message for 500 page - gustavwilliam

odd spireBOT Mar 1, 2021, 7:36 PM

#

[python-discord/site] Checks Successful on PR: #450 New error pages

GitHub Actions run 611636874 succeeded.

PR Author

Workflow Run

Lint & Test #99

Source Branch

error_pages

regal archBOT Mar 1, 2021, 8:18 PM

#

jb3

[python-discord/site] Pull request review submitted: #450 New error pages

:shipit::shipit::shipit::shipit::shipit:

#

jb3

[python-discord/site] Pull request closed: #450 New error pages

#

jb3

[python-discord/site] branch deleted: error\_pages

#

jb3

[site:master] 6 new commits

ebf128e Add 404 page - gustavwilliam
3020e2e Add error page styling - gustavwilliam
df9f590 Add 500 page - gustavwilliam
1ed129f Capitalise error codes in 404 and 500 pages - gustavwilliam
9243fef Update error message for 500 page - gustavwilliam

#

jb3

[site:master] 1 new commit

f17075f Update Dockerfile - jb3

odd spireBOT Mar 1, 2021, 8:26 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 611749661 succeeded.

Actor

Workflow Run

Deploy #28

Commit

9375d27

#

[python-discord/site] Workflow Successful

GitHub Actions run 611760580 succeeded.

Actor

Workflow Run

Deploy #29

Commit

f17075f

regal archBOT Mar 1, 2021, 10:12 PM

#

jb3

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

:shipit::shipit::shipit::shipit:

regal archBOT Mar 2, 2021, 6:22 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #558 Markov poem gen

I like where this PR is going. Please consider making these changes.

Sorry for hitting you with all of this at once.

Thank you for contributing to Sir-Lancebot!

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #558: Markov poem gen

This needs a return annotation.

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #558: Markov poem gen

We should sanitize the rhyme_scheme with regex, as we don't want random characters going into the GET request that goes off here:
https://github.com/python-discord/sir-lancebot/blob/ef61267835e0e37bd4e772fa394e678d857d72c7/bot/exts/valentines/markov_poem_generator.py#L227-L230

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #558: Markov poem gen

I don't see any use of this attribute outside this function. Do we need it?

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

@ncDevMan are you still planning on working on this feature?

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #214: \[Feature Request\] Pride Event Calendar

@RohanJnr are you still interested?

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #558 Markov poem gen

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #558: Markov poem gen

I don't see any use of this attribute outside this function. Do we need it?

It would be caught in non handled errors if we don’t set this attribute.

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #558 Markov poem gen

#

Xithrius

[python-discord/sir-lancebot] New review comment on pull request #558: Markov poem gen

Thanks for the info. I've never set this before.

#

Shivansh-007

[python-discord/sir-lancebot] New comment on pull request #558: Markov poem gen

Also do fix the merge conflicts. For the pipfile.lock, just reset it and then run pipenv lock.

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #228: Flag background for prideavatar\.

Greetings. Great idea y'all, I think this should be implemented.

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #325: Personal stats with something like \!aoc mystats

Hello @LeptoFlare, it seems the other user has become inactive. Would you like to take over this?

regal archBOT Mar 2, 2021, 7:12 AM

#

Akarys42

[python-discord/sir-lancebot] Pull request review submitted: #482 Startup channel check

Lgtm, cheers!

#

ks129

[python-discord/sir-lancebot] Pull request review submitted: #482 Startup channel check

#

ks129

[python-discord/sir-lancebot] Issue closed: #393 Verify channel constants on startup

#

ks129

[python-discord/sir-lancebot] Pull request closed: #482 Startup channel check

#

ks129

[sir-lancebot:master] 8 new commits

931fb3e Verify channel constants on startup - WillDaSilva
b907c4c Add docstring to check_channels - WillDaSilva
7bec6f4 Capitalize "ID" in error message - WillDaSilva
52d6261 Merge branch 'master' into startup-channel-check - WillDaSilva
a9fbfd2 Merge branch 'master' into startup-channel-check - Xithrius

odd spireBOT Mar 2, 2021, 7:14 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #482 Startup channel check

GitHub Actions run 613197314 succeeded.

PR Author

WillDaSilva

Workflow Run

Lint #405

Source Branch

WillDaSilva:startup-channel-check

regal archBOT Mar 2, 2021, 7:17 AM

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #416: Make pridavatar command work correctly with GIF avatars

As of #584 getting closed, we can't really work on GIFs given the possibility of them being very long.

CPU usage is also a problem, as this would definitely take up a large portion of it.

Maybe we can do this in the future, but for now we'll have to put it off until we can afford more computations.

#

Xithrius

[python-discord/sir-lancebot] Issue closed: #416 Make pridavatar command work correctly with GIF avatars

odd spireBOT Mar 2, 2021, 7:18 AM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 613200505 succeeded.

Actor

Workflow Run

Build #156

Commit

3ef0fdd

night lilyBOT Mar 2, 2021, 7:19 AM

#

Sir Lancebot

Connected!

regal archBOT Mar 2, 2021, 7:34 AM

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #470: Porting CustomHelpCommand from \`bot\`

@PureFunctor are you still planning on implementing this?

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #436: Beardify — Lemoji beard structure text generator

I've communicated with @gustavwilliam. This is still in the works, and is a bit on hold.

I hope this feature works out, very cool stuff.

#

PureFunctor

[python-discord/sir-lancebot] New comment on issue #470: Porting CustomHelpCommand from \`bot\`

I can't say I can work on this for now; I suppose further discussion might be needed in terms of the implications towards complexity or feature parity with the other bot.

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #437: Bot not able to catch answers typed in bursts

@ramansrivastava would you still be willing to work on this? I'm not completely sure if this bug still exists.

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #470: Porting CustomHelpCommand from \`bot\`

Thank you for the quick response. I hope everything works out in the end.

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #425: Optional user arguments

@slushiegoose are you still planning on making a PR for this?

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #494: Add Yoda Text Command

@aaravm4 I'd like to see this feature in Sir-Lancebot. Are you still willing to implement this?

regal archBOT Mar 2, 2021, 9:36 AM

#

TizzySaurus

[python-discord/bot] Issue opened: #1443 Delete messages when \`\!pypi\` module is invalid

When users use the !pypi command with an invalid module, you currently get a response saying "Package could not be found.".

What I'm proposing it that after a delay (I believe we have bot.constants.RedirectOutput.delete_delay for this) the bot should delete both its response and the invocation message, like !d currently does.

This would help reduce channel flooding when someone is trying to reme...

regal archBOT Mar 2, 2021, 9:58 AM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request opened: #605 Add WTF Python Command

Relevant Issues

Closes #602

Description

Gets the fuzzy match of a search query, returns None if the ratio is below 90 else returns the fuzzy match. If the return is None, then we send our custom Error Message else it sends the link to the subsection of the WTF Python README.md.

Reasoning

Approved by a staff.

Screenshots

On Dark Theme

![Screenshot from 2021-03-02 15-22-56](https://user-images.githubusercontent.com/69356296/109631103-a67f2680-7b6b-11...

odd spireBOT Mar 2, 2021, 9:59 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #605 Add WTF Python Command

GitHub Actions run 613609890 succeeded.

PR Author

Workflow Run

Lint #407

Source Branch

Shivansh-007:feature/wtf-python

regal archBOT Mar 2, 2021, 10:00 AM

#

Shivansh-007

[python-discord/bot] New comment on issue #1423: Fix tp list command

I would like to work on this.

#

HassanAbouelela

[python-discord/sir-lancebot] Issue opened: #606 Startup Channel Check Bug

Description

#482 Was merged a couple hours ago, and in it, the following change was introduced:
https://github.com/python-discord/sir-lancebot/blob/53af90f92258905c2bfc4c2db2341dfd1fdc0124/bot/bot.py#L74-L82

This logs an error for every single channel we have into sentry.

Steps to Reproduce

Startup the bot.

Expected Behaviour

It should only log missing channels.

Actual Behaviour

All channels are logged as missing.

Possible Solutions

So this bug ...

#

ks129

[python-discord/bot] New comment on issue #1423: Fix tp list command

@Shivansh-007 I think you should wait until I finish refactor of nominations schema. These may start conflicting otherwise.

#

Shivansh-007

[python-discord/bot] New comment on issue #1423: Fix tp list command

Alright @ks129.

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #606: Startup Channel Check Bug

I would like to work on this.

regal archBOT Mar 2, 2021, 10:24 AM

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #606: Startup Channel Check Bug

Thanks, you've been assigned.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request opened: #607 Fixes Startup Channel Check Bug

Relevant Issues

Closes #606

Description

Uses channel.ids instead of channel object while checking for missing channels. Skips the check if debug is set to False in the .env.

Did you:

[x] Join the Python Discord Community?
[x] Lint your code (pipenv run lint)?
[x] Set the PR to allow edits from contributors?

odd spireBOT Mar 2, 2021, 10:26 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #607 Fixes Startup Channel Check Bug

GitHub Actions run 613692739 succeeded.

PR Author

Workflow Run

Lint #408

Source Branch

Shivansh-007:fix/startup-channels

regal archBOT Mar 2, 2021, 10:27 AM

#

HassanAbouelela

[python-discord/sir-lancebot] New review comment on pull request #607: Fixes Startup Channel Check Bug

We probably don't have to use a set here, but everything else is fine. Thanks 👍

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #607 Fixes Startup Channel Check Bug

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #607 Fixes Startup Channel Check Bug

odd spireBOT Mar 2, 2021, 10:31 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #607 Fixes Startup Channel Check Bug

GitHub Actions run 613709002 succeeded.

PR Author

Workflow Run

Lint #409

Source Branch

Shivansh-007:fix/startup-channels

regal archBOT Mar 2, 2021, 12:24 PM

#

aaravm4

[python-discord/sir-lancebot] New comment on issue #494: Add Yoda Text Command

Yea, I can still implement it.

#

mbaruh

[python-discord/sir-lancebot] Pull request review submitted: #607 Fixes Startup Channel Check Bug

I'll approve for the purpose of the hotfix, but I think there should be a split between channels which are constant are actually required, and ones which are temporary.

An even better approach would be for each cog to specify which channels it needs.

regal archBOT Mar 2, 2021, 12:58 PM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on pull request #607: Fixes Startup Channel Check Bug

Alright @mbaruh I will have a look at that. Can u tell how should i progress with the second method of implemented. Like how should the channel - cog map be stored/

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on pull request #607: Fixes Startup Channel Check Bug

@Shivansh-007 This shouldn’t be part of this hot fix. There will be another issue for it.

#

HassanAbouelela

[sir-lancebot:master] 3 new commits

167774e Fix Channel Check to use channel ids instead of... - Shivansh-007
6748387 Don't use sets - Shivansh-007
a3bd208 Merge pull request #607 from Shivansh-007/fix/s... - HassanAbouelela

#

HassanAbouelela

[python-discord/sir-lancebot] Issue closed: #606 Startup Channel Check Bug

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request closed: #607 Fixes Startup Channel Check Bug

odd spireBOT Mar 2, 2021, 1:03 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 614101986 succeeded.

Actor

Workflow Run

Build #157

Commit

a3bd208

night lilyBOT Mar 2, 2021, 1:05 PM

#

Sir Lancebot

Connected!

oak estuaryBOT Mar 2, 2021, 3:02 PM

#

According to the API, your request is malformed.

regal archBOT Mar 2, 2021, 3:30 PM

#

ncDevMan

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

If @Kronifer would like to take this, he may. I tested a few API's- one around NASA. But I did not get very far.

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

@ncDevMan I'd love to! I'm gonna go over cogs and get started.

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

@Xithrius the command file should go in the bot/exts/Easter folder, right?

regal archBOT Mar 2, 2021, 5:11 PM

#

janine9vn

[python-discord/branding] Issue opened: #126 Holi logo

Holi, also known as the festival of colors, festival of love, or the festival of spring is March 28-29 this year. It'd be super chill if we had a logo for this since we had a logo for Diwali.

If anyone is interested in making a logo for this please comment here~

#

HassanAbouelela

[forms-frontend:prism\-code\-demo] 1 new commit

64593eb Adds Basic Prism Stuff - HassanAbouelela

#

HassanAbouelela

[python-discord/forms-frontend] New branch created: prism\-code\-demo

#

HassanAbouelela

[forms-frontend:discord\-oauth] 1 new commit

54fd22c Saves Username & Scopes On / Path - HassanAbouelela

regal archBOT Mar 2, 2021, 6:27 PM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

I have no real feedback, everything seems fine. The only change I would ask for is for the method of shutting down defcon to be added to the help command.

#

Akarys42

[python-discord/bot] Pull request review dismissed: #1262 Defcon overhaul

Looks pretty good, just a few things.

What would you say about adding an error handler to relay any failure in defcon to Discord directly, as it is a quite critical cog?

regal archBOT Mar 2, 2021, 6:45 PM

#

MrKomodoDragon

[python-discord/branding] New comment on issue #126: Holi logo

Can I make one for holi?

#

mbaruh

[bot:mbaruh/defcon] 2 new commits

ca3389e Improved docstring for threshold command. - mbaruh
91d9748 Merge branch 'mbaruh/defcon' of https://github.... - mbaruh

odd spireBOT Mar 2, 2021, 6:49 PM

#

[python-discord/bot] Checks Successful on PR: #1262 Defcon overhaul

GitHub Actions run 615103282 succeeded.

PR Author

Workflow Run

Lint & Test #582

Source Branch

mbaruh/defcon

#

[python-discord/bot] Checks Successful on PR: #1262 Defcon overhaul

GitHub Actions run 615113535 succeeded.

PR Author

Workflow Run

Lint & Test #583

Source Branch

mbaruh/defcon

regal archBOT Mar 2, 2021, 6:53 PM

#

HassanAbouelela

[python-discord/bot] Pull request review submitted: #1262 Defcon overhaul

Thanks

#

mbaruh

[python-discord/bot] Pull request closed: #1262 Defcon overhaul

#

mbaruh

[python-discord/bot] branch deleted: mbaruh/defcon

#

mbaruh

[bot:master] 36 new commits

aae8001 Added defcon status notifier - mbaruh
ede6823 Merge branch 'master' into mbaruh/defcon - mbaruh
f23c2e7 Make the cog update even if write to DB fails - mbaruh
f2c8e29 Moved self.enabled update to _defcon_action - mbaruh
76574ad Moved channel topic change to _defcon_action - mbaruh

oak estuaryBOT Mar 2, 2021, 6:57 PM

#

Python Bot

Connected!

odd spireBOT Mar 2, 2021, 6:58 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 615128831 succeeded.

Actor

Workflow Run

Deploy #174

Commit

29deeaa

regal archBOT Mar 2, 2021, 7:44 PM

#

LeptoFlare

[python-discord/sir-lancebot] New comment on issue #325: Personal stats with something like \!aoc mystats

Hey! I haven't worked with the bot in a while, but I'd to see if I can take a crack 😄

regal archBOT Mar 2, 2021, 8:01 PM

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #325: Personal stats with something like \!aoc mystats

Alright, cool! Be sure to include features mentioned in https://github.com/python-discord/sir-lancebot/issues/321 as well.

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

@Xithrius the command file should go in the bot/exts/Easter folder, right?

Yep!

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #494: Add Yoda Text Command

Alright, cool.

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

Alright, perfect! I'll get started on that soon.

#

Xithrius

[python-discord/bot] New comment on issue #1421: MFA User Token filter

Alright, I'll shove it into that cog.

regal archBOT Mar 2, 2021, 8:31 PM

#

sam-heller

[python-discord/sir-lancebot] Issue opened: #608 HTTP Status Code 418 not recognized by \.http\_status command

Description

The .http_status .status and .httpstatus commands do not recognize HTTP status code 418 (I am a Teapot) as described in RFC-2324 : Hyper Text Coffee Pot Control Protocol (HTCPCP/1.0)

2.3.2 418 I'm a teapot

Any attempt to brew coffee with a teapot should result in the error
code "418 I'm a teapot". The resulting entity body MAY be short and
stout.

Steps to Reproduce

Input any of the following commands in ...

#

Xithrius

[bot:mfa\-token\-filter] 1 new commit

2e30bc6 Added MFA user token filter. - Xithrius

#

Xithrius

[python-discord/bot] New branch created: mfa\-token\-filter

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

Hey @Xithrius , I'm trying to do this with the unsplash API. Is there somewhere we can store secret keys for the bot?

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

Hey checkout:
https://github.com/python-discord/sir-lancebot/blob/a3bd208580ff223cd0120d0c4b5a1bf3c28d03e5/bot/constants.py#L264-L266

Basically, you add an environment variable to this list, and we'll set it up on our end before we merge the feature. Just be sure to leave a note asking us to do so in the pull request.

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

@HassanAbouelela so when it's ready, should I email one of you guys the keys?

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

No, we'll create our own app, and I see they have a process for requesting a production token, which we will have to go through.

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

I'm having a quick look through the API, please note that:

All applications must follow the API Guidelines, including properly providing attribution for the photographer and Unsplash.

- Unsplash Documentation

This is something you'll have to keep in mind with your implementation, as well as all their other rules.

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #174: Earth Photos

@HassanAbouelela thanks for clarifying! I'll make my own for testing purposes then. I'll be sure to keep in line with the rules 🙂

regal archBOT Mar 2, 2021, 10:36 PM

#

kwzrd

[python-discord/branding] New comment on issue #123: Rework seasonal branding structure

I really like the idea of using the frontloaded YAML for the meta file. Assuming the #changelog notif will be sent as an embed, we will basically have a tag with some extra meta information (not to digress, but could Python's tag system also benefit from this?).

However, I think we need to decide on how to define the time periods. The proposed example is a little different to what I imagined, which was to have year-agnostic dates, e.g.:

period: 24/12  # Active on the 24th of Decemb...

#

kwzrd

[python-discord/bot] New comment on issue #1431: Rework branding manager

Everything proposed in this issue sounds great to me. Provided we design the meta.md files well, none of this should be difficult to implement, though I'd still like to update the cog's internals a little bit, in particular:

Probably use d.py's tasks extension for the daemon
Use Redis to persist the last icon cycle date so that the cycle maintains a consistent n-day schedule even across restarts

Are there any commands that ...

#

kwzrd

[python-discord/branding] New comment on issue #123: Rework seasonal branding structure

For the date formats, we agree with @jb3 that using the month name may be the best option, especially since we can still parse it with datetime:

>>> datetime.strptime("January 5", "%B %d")
datetime.datetime(1900, 1, 5, 0, 0)

So the config file could look like:

start_date: January 5
end_date: March 12

This remains easy to parse both programmatically and humanly.

regal archBOT Mar 3, 2021, 1:42 AM

#

dawnofmidnight

[python-discord/branding] New comment on issue #123: Rework seasonal branding structure

I have a quick suggestion. Maybe add a branding command (eg. !branding) that anyone would be able to use to see what the current branding is, what it means, and why it's there.

This could help with certain events like international holidays such as the Diwali ones where many people may not known what it means. This is just a rough idea, but maybe something like:

Branding
Right now, PyDis's current branding is for Saint Patrick's Day.

_Goes on to elaborate about the da...

regal archBOT Mar 3, 2021, 3:39 AM

#

Den4200

[python-discord/sir-lancebot] New comment on issue #608: HTTP Status Code 418 not recognized by \.http\_status command

This has been discussed a couple of times in the past. I believe we came to a general consensus that we don't need to use the http module to check the status code. Instead, we can just send a request to the site and if the status code returned is invalid, display a 404 dog/cat.

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #608: HTTP Status Code 418 not recognized by \.http\_status command

According to issue https://github.com/python-discord/sir-lancebot/issues/428, we'll probably be waiting until we can upgrade to 3.9 without any worries.

#

Kronifer

[python-discord/sir-lancebot] Pull request opened: #609 Earth photos

Added .earth_photos command

Closes issue #174

Description

Added a .earth_photos command by using the unsplash api

Reasoning

An approved issue I was assigned to.

Screenshots

Additional Details

Please add environment variable UNSPLASH_KEY and set it to the key for an unsplash app created on their API

Did you:

[x] Join the [**Python...

odd spireBOT Mar 3, 2021, 3:46 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 616307670 failed.

PR Author

Workflow Run

Lint #411

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 3:48 AM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

Hi there, I ran the linter but it seems to not have returned the errors that are showing on the server check.

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

What command did you run?

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Xithrius pipenv run lint

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

If you haven't already, try running pipenv run precommit, and then pipenv run lint.

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

I'm re-running it now.

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Xithrius I ran pre-commit, it's buffering on Flake8 right now

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

By installing the precommit hook, committing will be blocked until you fix all of its complaints.

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Xithrius it didn't complain when run but checks failed on github action. Flake8 passed now.

odd spireBOT Mar 3, 2021, 4:00 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 616328125 failed.

PR Author

Workflow Run

Lint #412

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 4:05 AM

#

Den4200

[python-discord/sir-lancebot] New comment on issue #608: HTTP Status Code 418 not recognized by \.http\_status command

Nevertheless, I think it'd be quite amusing for a 404 status dog/cat to appear for invalid status codes. I don't see any reason not to fix this now and remove our dependency on the http module either.

odd spireBOT Mar 3, 2021, 4:07 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 616341012 failed.

PR Author

Workflow Run

Lint #413

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 616351056 failed.

PR Author

Workflow Run

Lint #414

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 616366380 succeeded.

PR Author

Workflow Run

Lint #415

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 4:26 AM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #608: HTTP Status Code 418 not recognized by \.http\_status command

Another way is to use regex and get all the status codes.

regal archBOT Mar 3, 2021, 4:53 AM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

Please consider making these changes.

Sorry for hitting you with all of this at once.

Thank you for contributing to Sir-Lancebot!

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Since the discord.py bot framework is asynchronous, the requests library cannot be used. You can check out other cogs in this repository for examples on how to use aiohttp to make asynchronous web requests.

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

    def __init__(self, bot: commands.Bot) -> None:

init has no special meaning in Python. It's just a method.

__init__ is the magic method that's called automatically on object instantiation.

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Can we break this down into lines for easier readability, for example like this:

embed = discord.Embed(
     title=random.choice(ERROR_REPLIES),
     color=Colours.soft_red,
     description="You don't have permission to view this channel."
 )

regal archBOT Mar 3, 2021, 6:14 AM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

This PR is looking good so far, but it is not in compliance with the unsplash API, so I am blocking it. The rules it violates are:

API Guidelines, Technical Guidelines Section, Point 2: "you must send a request to the download endpoint". See here for a more complete review of how this should be done.
[API Guidelines, Technical Guidelines...

regal archBOT Mar 3, 2021, 7:26 AM

#

Skaft

[python-discord/sir-lancebot] New comment on issue #321: AoC: Leaderboard per star

Apologies for abandoning this, after missing the first deadline of having it included in the 2019 event I kinda lost interest =/ I've since lost my progress on it, so I'd be happy for someone else to pick it up.

regal archBOT Mar 3, 2021, 10:17 AM

#

Shivansh-007

[python-discord/bot] New comment on issue #1226: Enhancing information within the incidents channel\.

I will give this a go!

regal archBOT Mar 3, 2021, 11:55 AM

#

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #608: HTTP Status Code 418 not recognized by \.http\_status command

I concur with @Den4200 I think we should remove the http module check and just call the status sites directly. Then rely on them sending a 404/302 and dealing with that.

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on issue #608: HTTP Status Code 418 not recognized by \.http\_status command

I've approved it now, and assigned you. I think you'd be best off following Den's suggestion yeah.

odd spireBOT Mar 3, 2021, 1:15 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 617637095 failed.

PR Author

Workflow Run

Lint #416

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 1:20 PM

#

sam-heller

[python-discord/sir-lancebot] Pull request opened: #610 Teapot support

Relevant Issues

Closes #428
Closes #500
Closes #608

Description

Removed HTTPStatus from the equation entirely in favor of just relying on the cat/dog servers to send us back errors if we get bad input.

Minor refactor to pull strings out of the executable code into variables at the top.

Reasoning

Implemented design and strategy suggested by staff in #608 discussion.

Screenshots

Did you:

[X] Join the [Python Discord Community](https://di...

odd spireBOT Mar 3, 2021, 1:21 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #610 Teapot support

GitHub Actions run 617654753 succeeded.

PR Author

sam-heller

Workflow Run

Lint #417

Source Branch

sam-heller:teapot-support

regal archBOT Mar 3, 2021, 1:38 PM

#

sam-heller

[python-discord/sir-lancebot] New comment on issue #608: HTTP Status Code 418 not recognized by \.http\_status command

PR is up, please do your worst! I'll take brutality over pushing dodgy code any day of the week.

odd spireBOT Mar 3, 2021, 1:44 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 617718810 succeeded.

PR Author

Workflow Run

Lint #418

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 1:54 PM

#

jb3

[python-discord/sir-lancebot] Pull request review submitted: #610 Teapot support

:cat: The most important PR ever received :tea:

Some minor comments on wording, tested locally and all works well.

#

jb3

[python-discord/sir-lancebot] New review comment on pull request #610: Teapot support

This docstring is used in the .help documentation, so we should keep it more human friendly.

        """Send a cat version of the requested HTTP status code."""

#

jb3

[python-discord/sir-lancebot] New review comment on pull request #610: Teapot support

Same as above

        """Send a dog version of the requested HTTP status code."""

#

jb3

[python-discord/sir-lancebot] New review comment on pull request #610: Teapot support

ERR_404 = 'Unable to find status floof for {code}.'
ERR_UNKNOWN = 'Error attempting to retrieve status floof for {code}.'

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #610 Teapot support

Bug 🙃

Screenshot from 2021-03-03 19-38-45

#

ks129

[bot:ks123/talentpool/migrate] 2 new commits

54952d1 Add disable_header to watchchannel to disable t... - ks129
86988b6 Migrate talentpool to new schema - ks129

#

ks129

[python-discord/bot] New branch created: ks123/talentpool/migrate

#

lemonsaurus

[python-discord/branding] New comment on issue #123: Rework seasonal branding structure

@kwzrd
I think your suggestion is fine, provided that we accept an optional years parameter for non-recurring events, like we discussed in the community.

@dawnofmidnight
I don't necessarily mind having a !branding command, but I'm not sure if it's necessary if that information is always going to be available in #changelog. Either way, it'd have to be implemented after we're done with these initial changes, as I'm hesitant to expand the scope of this task further.

If you're keen ...

#

ks129

[python-discord/bot] Pull request opened: #1445 Migrate talentpool to new API schema

Note: This has to be merged exactly same time than python-discord/site#447

Migrates talent pool to the new system. More exact changes are in the commit message body.

Closes #1425

#

lemonsaurus

[python-discord/bot] New comment on issue #1431: Rework branding manager

Probably use d.py's tasks extension for the daemon
Use Redis to persist the last icon cycle date so that the cycle maintains a consistent n-day schedule even across restarts

Excellent ideas.

Are there any commands that the cog currently doesn't offer, that would be useful to have?

There was a suggestion in https://github.com/python-discord/branding/issues/123 to add a sort of branding info command that would just display the same as we're gonna put into #changelog. I'm not opp...

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #610: Teapot support

Bug 🙃

Could you list some reproduction steps to help @sam-heller with fixing it?

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #610: Teapot support

Also, I'm not sure about passing user input directly into a web request like this, without sanitising it first.
I also realise this is the way is was before this PR too, but looks like something we should fix.

odd spireBOT Mar 3, 2021, 2:21 PM

#

[python-discord/bot] Checks Successful on PR: #1445 Migrate talentpool to new API schema

GitHub Actions run 617810677 succeeded.

PR Author

Workflow Run

Lint & Test #585

Source Branch

ks123/talentpool/migrate

regal archBOT Mar 3, 2021, 2:28 PM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on pull request #610: Teapot support

@Shivansh-007 Could you list some reproduction steps to help @sam-heller with fixing it?

We can make use textwrap module and then do something like this:

textwrap.shorten(code width=50, placeholder="...")

#

jb3

[python-discord/sir-lancebot] New comment on pull request #610: Teapot support

We could also just validate that codes are below some sane value, like 999.

Convert to an integer and handle any failure there, then check the integer is greater than 0 and less than 999, we don’t need to bring textwrap into it.

On 3 Mar 2021, at 14:28, Shivansh-007 notifications@github.com wrote:

@Shivansh-007 https://github.com/Shivansh-007 Could you list some reproduction steps to help @sam-heller https://github.com/sam-heller with fixing it?

We can make use textwrap...

#

janine9vn

[python-discord/branding] New comment on issue #119: Add Saint Patrick’s day Icon

This is closed by #120 . Thanks for the contribution by the way!

#

janine9vn

[python-discord/branding] Issue closed: #119 Add Saint Patrick’s day Icon

#

janine9vn

[python-discord/branding] New comment on issue #126: Holi logo

Absolutely, I'll assign you now.

#

janine9vn

[python-discord/branding] New comment on issue #15: St Patricks Day

We have one now! Check #120

#

janine9vn

[python-discord/branding] Issue closed: #15 St Patricks Day

#

janine9vn

[python-discord/branding] New comment on issue #113: Animated Valentines Logo Uses Incorrect Shades of Pink

@MarkKoz I remember there being some work done on this but unsure if anything was merged?

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Xithrius @HassanAbouelela so as I'm seeing it, I need to do the following:

[ ] Switch to aiohttp
[ ] Remove unneeded modules
[ ] Change docstrings
[ ] Reformat embeds
[ ] Make sure stuff complies with the unsplash API

Give me a day or two and I'll try to fix these!

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

This PR is looking good so far, but it is not in compliance with the unsplash API, so I am blocking it. The rules it violates are:

API Guidelines, Technical Guidelines Section, Point 2: "you must send a request to the download endpoint". See here for a more complete review of how this should be done.
[API Guidelines, Technical Gu...

odd spireBOT Mar 3, 2021, 3:27 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 618006778 succeeded.

PR Author

Workflow Run

Lint #419

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 618025046 failed.

PR Author

Workflow Run

Lint #420

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 3:46 PM

#

Numerlor

[python-discord/sir-lancebot] Pull request review submitted: #610 Teapot support

The style for hanging indents in the projects is to have the closing parentheses on their own line which isn't used in the build_embed if chain. I believe only creating the embed objects in the if bodies and then having a send at the end of the function will look better and won't need any splitting up of the lines

#

Numerlor

[python-discord/sir-lancebot] New review comment on pull request #610: Teapot support

This won't catch invalid dog codes, as those redirect to their 404 image page through the 302 response code, and will go to the generic handler

#

Numerlor

[python-discord/sir-lancebot] New review comment on pull request #610: Teapot support

This doesn't work, you'll have to set the footer through embed_obj.set_footer(text=...)

#

Numerlor

[python-discord/sir-lancebot] Pull request review submitted: #610 Teapot support

#

Numerlor

[python-discord/sir-lancebot] New review comment on pull request #610: Teapot support

The yoda condition looks a bit weird to me as I don't think I've seen it anywhere else in the codebase but I suppose it's fine

odd spireBOT Mar 3, 2021, 3:58 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 618095620 failed.

PR Author

Workflow Run

Lint #421

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 618097333 failed.

PR Author

Workflow Run

Lint #422

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 4:42 PM

#

sam-heller

[python-discord/sir-lancebot] Pull request review submitted: #610 Teapot support

#

sam-heller

[python-discord/sir-lancebot] New review comment on pull request #610: Teapot support

Taking another look and it's definitely not the most readable. What do you think about swapping it with

if response.status in range(200,299):

?

odd spireBOT Mar 3, 2021, 4:47 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 618243392 failed.

PR Author

Workflow Run

Lint #423

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 618250327 succeeded.

PR Author

Workflow Run

Lint #424

Source Branch

Kronifer:earth_photos

odd spireBOT Mar 3, 2021, 5:08 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 618305333 succeeded.

PR Author

https://github.com/python-discord/sir-lancebot/pull/609#pullrequestreview-602548202

Workflow Run

Lint #425

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 6:01 PM

#

MarkKoz

[python-discord/branding] New comment on issue #113: Animated Valentines Logo Uses Incorrect Shades of Pink

nothing as far as i know

regal archBOT Mar 3, 2021, 6:38 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@HassanAbouelela The issues you presented should be fixed.

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Use self.bot.http_session here instead of making a new client session

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

We should pass params using a dict and the params kwarg with aiohttp, rather than adding directly to the url.

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Is this used for anything?

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

oh, okay!

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

sure!

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

you mean self.current_channel? I got rid of it i thought

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

sure

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

i added the changes requested

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Ah, so this line specifically is doing nothing, we just need to send the get request?

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

yeah, but i needed to call er.status or it wouldn't lint

regal archBOT Mar 3, 2021, 8:14 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@ChrisLovering self.bot.http_session only works once.

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review dismissed: #609 Earth photos

This PR is looking good so far, but it is not in compliance with the unsplash API, so I am blocking it. The rules it violates are:

API Guidelines, Technical Guidelines Section, Point 2: "you must send a request to the download endpoint". See here for a more complete review of how this should be done.
[API Guidelines, Technical Guidelines...

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@ChrisLovering never mind, fixed

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

I've dismissed my review for now, as it seems we are now in compliance with the API's requirements. I tried to make sure we meet them to the best of my ability, but I am not a lawyer. If someone is more legally inclined, or if someone has time to sort through a bunch of requirements, I'd appreciate a second set of eyes looking over: https://help.unsplash.com/en/articles/2511245-unsplash-api-guidelines.

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@ChrisLovering i have made the changes requested.

odd spireBOT Mar 3, 2021, 8:21 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 618803664 failed.

PR Author

Workflow Run

Lint #426

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 8:22 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

it seems pipenv failed install on the lint check, should I re-commit or will someone re-run it?

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

It seems I forgot to lock, fixing now.

odd spireBOT Mar 3, 2021, 8:28 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 618819360 failed.

PR Author

Workflow Run

Lint #427

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 618824556 succeeded.

PR Author

Workflow Run

Lint #428

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 8:30 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

Alright, lint passed!

regal archBOT Mar 3, 2021, 9:20 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #451: Fully supporting GitHub codespaces

This would be in my interest if I had access to CodeSpaces

#

Kronifer

[python-discord/sir-lancebot] Issue opened: #611 Full support for Gitpod

Description

Similar to the issue open for supporting GitHub CodeSpaces. When you try to use Gitpod for sir-lancebot, you have to install lots of things manually.

Reasoning

Quicker development times online as there is no need to manually install dependencies.

Proposed Implementation

Creating a .gitpod.yml file, described here

Would you like to implement this yourself?

[ ] I'd like to implement this feature myself
...

#

kwzrd

[python-discord/branding] New comment on issue #123: Rework seasonal branding structure

Okay, sounds like I can start moving things around. It quickly became apparent to me that I will be writing some sort of validation script for my own self anyway, to be safe that all event directories are setup correctly. So we'll see, maybe I'll include it in the PR.

I'm interested what kind of CI setup we'd come up with. Since it'll depend on something (python-frontmatter works well, although it hasn't had a commit since late 2019, but it...

odd spireBOT Mar 3, 2021, 10:28 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 619109792 succeeded.

PR Author

Workflow Run

Lint #429

Source Branch

Kronifer:earth_photos

regal archBOT Mar 3, 2021, 11:21 PM

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Uhhh what does line do?

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

                color=Colours.grass_green
            )

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Can you reset this to upstream/master.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

I like where this PR is going. Please consider making these changes.

regal archBOT Mar 4, 2021, 12:09 AM

#

Xithrius

[python-discord/bot] New comment on issue #1226: Enhancing information within the incidents channel\.

@Shivansh-007 I think this should be planned out a bit more before we do something.

regal archBOT Mar 4, 2021, 1:03 AM

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

I didn't know that happened, sure

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1434 Send command help for BadUnionArgument errors

Thanks! Looks Good To Me!

odd spireBOT Mar 4, 2021, 1:04 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 619445482 succeeded.

PR Author

https://github.com/python-discord/sir-lancebot/pull/609#pullrequestreview-602548202

Workflow Run

Lint #430

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 1:04 AM

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

odd spireBOT Mar 4, 2021, 1:06 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 619448809 succeeded.

PR Author

Workflow Run

Lint #432

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 619448798 succeeded.

PR Author

Workflow Run

Lint #431

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 1:06 AM

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

I have to keep them for getting specific data, unless there's a better way, I don't work with web requests much

odd spireBOT Mar 4, 2021, 1:06 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 619449566 succeeded.

PR Author

Workflow Run

Lint #434

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 619449561 succeeded.

PR Author

https://help.unsplash.com/en/articles/2511245-unsplash-api-guidelines

Workflow Run

Lint #433

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 1:08 AM

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Sorry I didn’t get you.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

userlinks is being used anywhere and even a few others so I don’t see a need of them.

#

jb3

[metricity:master] 1 new commit

461c65a Cascade delete channels on category deletion - jb3

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

#

[metricity] Lint code success on master

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

userlinks is used to get profile link for embed, downloadlinksdata for the download links, linksdata for the embed links, embedlink is self-explanitory, userdata is also self explanitory, username is for crediting the person who made the image as of here, name crediting is needed for production app, profile is used for a link to the profile

#

[metricity] Build & Publish Docker image success on master

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

fixed as of https://github.com/python-discord/sir-lancebot/pull/609/commits/825080e805787afc1f36a80b4fa3f73040ebdc75

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Quoting https://github.com/Kronifer/sir-lancebot/blob/earth_photos/Pipfile.lock#L591

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Shivansh-007 I've fixed everything over in my repo

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

I am, and it is still not solved.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Am talking about er.status.

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

I have to call er.status otherwise the lint fails

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

because then flake8 returns er is defined but never used

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

This is still not fixed.

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Oh wow, Im stupid! Sorry @Shivansh-007 , I looked at it wrong

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

odd spireBOT Mar 4, 2021, 1:26 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 619487672 failed.

PR Author

Workflow Run

Lint #435

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 1:27 AM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Shivansh-007 it seems some of this is outdated, as the logging thing no longer exists as shown here

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Hi @Shivansh-007 , I cant do this as it breaks pipenv and the packages, sorry!

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Flake8 never fails on this issue. You have added it in b2ee1b9e79766b8cfe7b45670f6c86e7166ee84f commit and I don’t see it failing before. And you can replace it with _, it is used to indicate that the result is being deliberately ignored.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

It doesn’t beak them. You are doing pipenv lock, am asking you to reset it to what it is at the main branch master that is, what it is here

#

Shivansh-007

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Shivansh-007 it seems some of this is outdated, as the logging thing no longer exists as shown here

Which logging thing are you talking about?

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

sorry, im not sure how to do this, what would i use?

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

oh sorry, i ran flake8 locally and it freaked on me

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Copy the Pipfile.lock from python-discord/sir-lancebot and paste it into yours.

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Shivansh-007 it seems some of this is outdated, as the logging thing no longer exists as shown here

Which logging thing are you talking about?

You said something about it in the change requested directly below here

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

sorry, two under the linked comment

#

Shivansh-007

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Shivansh-007 it seems some of this is outdated, as the logging thing no longer exists as shown here

Which logging thing are you talking about?

You said something about it in the change requested directly below here

I never said anything about logging, I asked you to remove th...

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

oh im dumb

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

how do you mean?

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

ok

regal archBOT Mar 4, 2021, 2:14 AM

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

@Shivansh-007 I did this but as soon as I ran pipenv sync --dev locally it reset this

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

it failed identify install when I made the change

odd spireBOT Mar 4, 2021, 2:18 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 619594647 failed.

PR Author

Workflow Run

Lint #437

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 619598816 succeeded.

PR Author

Workflow Run

Lint #438

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 2:57 AM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Shivansh-007 all changes have been made

odd spireBOT Mar 4, 2021, 4:03 AM

#

[python-discord/site] Checks Successful on PR: #412 Hide arrow to the right of More below the 1024px breakpoint

GitHub Actions run 619791746 succeeded.

PR Author

Transfusion

Workflow Run

Lint & Test #102

Source Branch

Transfusion:fix_327

regal archBOT Mar 4, 2021, 6:06 AM

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

    While any code is executing in this context manager, the underlying event will not be set;

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

I apologise for the long delay. I've been busy recently with things outside OSS.

A lot of my suggestions relate to documentation and comments. With a feature this complex, I think future readers will appreciate having some comments.

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Why is it called api_package_name rather than package_name. More specifically, why is it important to make a distinction here between a name coming from our API and a name from elsewhere?

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

It's singular, so use is. Also, specifying the type in the docstring is redundant due to the use of type annotations.

            * `package` is the content of a intersphinx inventory.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Your name is good enough; not worth bikeshedding over it. The docstring already explains what the class does very well.

I don't have any great ideas for it either. My ideas were not concrete but involved the name containing some form of SymbolMarkdown or QueuedParser.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Yeah, I think you're right. await self.item_fetcher.clear() is the first opportunity to yield control to the event loop, at which point it all scheduled tasks should raise the exception (docs say it happens at the next cycle of the event loop).

regal archBOT Mar 4, 2021, 6:40 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Before the inventory file parser was implemented the intersphinx package/project name was also exposed in the function, but I suppose package_name should be sufficient now

odd spireBOT Mar 4, 2021, 6:57 AM

#

[python-discord/forms-backend] Checks Successful on PR: #67 Bump pydantic from 1.7.3 to 1.8.1

GitHub Actions run 620139091 succeeded.

PR Author

Workflow Run

Forms Backend #245

Source Branch

dependabot/pip/pydantic-...

regal archBOT Mar 4, 2021, 7:00 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I left it in as without it the bot will consume all available resources for a task that's really low priority - at the cost of maybe delaying the next user request by up to 100 ms; can remove it if that won't be an issue.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Maybe that was the case back at 758dd3ef6ca5c1cd7615f0eb6688d7d2f19578ea, but you've since added multiple io-bound coroutines. I doubt it's still an issue, but I have not tried it.

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

If the coro suspends here, and a refresh deleting the doc_item (or an equal value) occurs then the get_markdown would fail, thinking about it I'm not sure if it's possible depending on how asyncio works but I'd rather be safe unless you think it's unnecessary.
All the other code in the function is either synchronous or safe to switch on

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

We use the tasks here that you mentioned in a comment to prevent locking up the queue waiting for one of them, so the only await here is for the cpu bound executor. Locally on a 4 thread CPU the process takes up roughly 33% of the overall usage

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Refreshing inventories doesn't clear the cache.

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

The containers in the BatchParser will be cleared and an old doc_item will be passed to get_markdown if it continues from here

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Okay, never mind.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Using this event here doesn't prevent such situation: as soon as an item is fetched from redis (or not found), the event will be set and the refresh will finally be allowed to continue. It will end up clearing everything potentially before get_markdown is called.

To avoid crashes in get_markdown, store the relevant future as a local variable rather than always accessing it through the dict.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Actually, that last suggestion is a bad idea since the future will never set and it will wait forever.

regal archBOT Mar 4, 2021, 8:30 AM

#

Shivansh-007

[python-discord/bot] Pull request opened: #1446 Enhancing information within the incidents channel\.

Relevant Issues

Closes #1226

Description

Whenever a staff member would post a message in #incidents channel, it would be searched through a regex and all the message links in it would be extracted.

Then the bot would send this the messages the link point towards in embeds.

The Embed would contain the following information -->
        Author: @Jason Terror ♦ (736234578745884682)
        Channel: Special/#bot-commands (814190307980607493)
        Content: This is a...

odd spireBOT Mar 4, 2021, 8:33 AM

#

[python-discord/bot] Checks Failed on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 620358006 failed.

PR Author

Workflow Run

Lint & Test #586

Source Branch

Shivansh-007:feature/enhance-...

regal archBOT Mar 4, 2021, 8:39 AM

#

ks129

[python-discord/bot] Pull request review submitted: #1446 Enhancing information within the incidents channel\.

Quick first review

#

ks129

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

Don't parse manually, use MessageConverter from discord.py instead.

#

ks129

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

Message can also be None if not found.

regal archBOT Mar 4, 2021, 8:56 AM

#

Senjan21

[python-discord/bot] Pull request closed: #1434 Send command help for BadUnionArgument errors

#

Senjan21

[bot:master] 3 new commits

3153ad0 Send command help for BadUnionArguments - Numerlor
d56b01a Close coroutine to prevent RuntimeWarnings - Numerlor
b34da23 Merge pull request #1434 from Numerlor/sendhelp - Senjan21

oak estuaryBOT Mar 4, 2021, 8:59 AM

#

Python Bot

Connected!

odd spireBOT Mar 4, 2021, 8:59 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 620426758 succeeded.

Actor

Senjan21

Workflow Run

Deploy #175

Commit

b34da23

regal archBOT Mar 4, 2021, 9:01 AM

#

Senjan21

[bot:cleanrework] 669 new commits

b3ad47a Feature: suggest command usage for misspelt com... - F4zii
adfb87e Merge branch 'master' into feat/F4zi/CommandSug... - Akarys42
dfe9dd8 Seperated tags.get_command into a function and ... - F4zii
eb01f3f Feature: suggest command usage for misspelt com... - F4zii
777088b Merge branches 'feat/F4zi/CommandSuggestion' an... - F4zii

regal archBOT Mar 4, 2021, 9:26 AM

#

Senjan21

[bot:cleanrework] 1 new commit

26c60c1 Change typing, remove range alias - Senjan21

odd spireBOT Mar 4, 2021, 11:20 AM

#

[python-discord/bot] Checks Failed on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 620794881 failed.

PR Author

Workflow Run

Lint & Test #588

Source Branch

Shivansh-007:feature/enhance-...

regal archBOT Mar 4, 2021, 4:20 PM

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Could you please rename this to unsplash_access_key to make it clear for anyone in future, as unsplash give you different two keys.

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Could you add a check here, so that if the token isn't set the cog doesn't try to load. As it raises an error currently if the token isn't present.
For example from the games cog:
https://github.com/python-discord/sir-lancebot/blob/a3bd208580ff223cd0120d0c4b5a1bf3c28d03e5/bot/exts/evergreen/game.py#L472-L481

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Could you please remove this wrapper and use Tokens.unsplash_key directly in your param's dict.

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

I've done this, i just dont have it commited yet as far as I know

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

sure!

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

this makes sense, okay!

#

Shivansh-007

[python-discord/bot] New comment on issue #663: Adding extra functionality and refinements to \!remind

For the more language time parsing feature, can we make use of parsedatetime?

#

ChrisLovering

[python-discord/bot] New comment on issue #663: Adding extra functionality and refinements to \!remind

we already have arrow as a dependency, so maybe we can make use of that?

#

Shivansh-007

[python-discord/bot] New comment on issue #663: Adding extra functionality and refinements to \!remind

we already have arrow as a dependency, so maybe we can make use of that?

That would do it too! Yes 👍

odd spireBOT Mar 4, 2021, 4:38 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 621683045 failed.

PR Author

Workflow Run

Lint #439

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 621689409 failed.

PR Author

Workflow Run

Lint #440

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 4:41 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@ChrisLovering made the requested changes

odd spireBOT Mar 4, 2021, 4:43 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 621697847 succeeded.

PR Author

Workflow Run

Lint #441

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 4:46 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

Looks good to me!

Note to core devs: We should make sure this env var exists in the bot env before mreging, and we should update the contributing guide too

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

Thanks @ChrisLovering !

#

dlasusa

[python-discord/branding] New comment on issue #126: Holi logo

Can anyone contribute or possibly provide inspiration/ideas for this? If so, where should images be posted? Is there any sort of "idea board" area? Thanks!

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

Looks awesome! Just a few nitpicks 😛

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

Take this inside the indent. As it is part of

        await with ctx.typing()

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

                description="A photo of Earth 🌎  from Unsplash.",

Emoji can be ignored, came up on my keyboard and just put it. It looks good tho

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

I don’t like the word 'made' here, the photos are not made but rather added or clicked.

odd spireBOT Mar 4, 2021, 4:57 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 621741164 succeeded.

PR Author

Workflow Run

Lint #442

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 621742490 succeeded.

PR Author

Workflow Run

Lint #443

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 621742515 succeeded.

PR Author

Workflow Run

Lint #444

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 4:59 PM

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

changed to photo by, as per the unsplash api production checklist

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

odd spireBOT Mar 4, 2021, 4:59 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 621747783 succeeded.

PR Author

Workflow Run

Lint #445

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 5:00 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Shivansh-007 all changes made

odd spireBOT Mar 4, 2021, 5:00 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 621751292 succeeded.

PR Author

Workflow Run

Lint #446

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 5:01 PM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

This hasn’t being mentioned yet.

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

oh sorry, i'll fix that!

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

fixed as of commit https://github.com/python-discord/sir-lancebot/pull/609/commits/68ff4f3a524e90099e6953bd601321623e789e66

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

odd spireBOT Mar 4, 2021, 5:05 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 621763445 succeeded.

PR Author

Workflow Run

Lint #447

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 5:06 PM

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

Thanks! Looks Good To Me!

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

Thanks! Looks Good To Me!

No problem!

regal archBOT Mar 4, 2021, 6:15 PM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Can it refresh before get_markdown is called? The event will be set when the last get finishes and the context mgr is exited, after which the next context switch can only occur after user_requested is set to true on the item in get_markdown making the clear wait for that to be parsed

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Looks like you're right, but I believe allowing a refresh to run in the middle of get_markdown is still a problem. The two problems are that _page_doc_items and _item_futures, causing KeyErrors later in get_markdown.

regal archBOT Mar 4, 2021, 7:08 PM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

HassanAbouelela

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

There is still a bit more that needs to be added. This article recommends that you have both the author and the site links. It also requires you use a referral link instead of a regular link. Check the article for all the specifics.

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #609: Earth photos

oh, whoops! I'll get going on that

odd spireBOT Mar 4, 2021, 7:27 PM

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 622143606 failed.

PR Author

Workflow Run

Lint #449

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Failed on PR: #609 Earth photos

GitHub Actions run 622152629 failed.

PR Author

Workflow Run

Lint #450

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 7:33 PM

#

mbaruh

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

I'm not sure why you removed the spaces here, they were added for readability

#

mbaruh

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

This shouldn't be a bare exception

#

mbaruh

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

Similarly here, your change isn't in line with the rest of the codebase

#

mbaruh

[python-discord/bot] Pull request review submitted: #1446 Enhancing information within the incidents channel\.

First review. Looks pretty good overall.

odd spireBOT Mar 4, 2021, 7:45 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 622191316 succeeded.

PR Author

Workflow Run

Lint #451

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 622209925 succeeded.

PR Author

Workflow Run

Lint #452

Source Branch

Kronifer:earth_photos

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 622216241 succeeded.

PR Author

Workflow Run

Lint #453

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 8:02 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

Made a quick update to the info at the top, make sure to take a look as it is important for api verification

#

MarkKoz

[python-discord/site] New review comment on pull request #443: Apply LimitOffsetPagination in GET Infraction with default Page Size 100

        """Override to skip metadata i.e. `count`, `next`, and `previous`."""

#

MarkKoz

[python-discord/site] New review comment on pull request #443: Apply LimitOffsetPagination in GET Infraction with default Page Size 100

    Response is paginated but the result is returned without any pagination metadata.

#

MarkKoz

[python-discord/site] Pull request review submitted: #443 Apply LimitOffsetPagination in GET Infraction with default Page Size 100

This works fine and I will approve it. However, I've left some more minor suggestions to clean up the documentation and make it more consistent.

#

MarkKoz

[python-discord/site] New review comment on pull request #443: Apply LimitOffsetPagination in GET Infraction with default Page Size 100

Add blank line between responses


    ## Required response

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #609 Earth photos

Very clean PR, and works as expected. We are now blocked by the API application, but the code is ready.

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #596: Add \.pyfacts command

replace this embed code with:

embed.add_field(
   name='Suggestions',
   value="Suggest more topic [here!](https://github.com/python-discord/meta/discussions/93)"
)

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #596 Add \.pyfacts command

This looks great, just one critique so far!

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

to the people merging this:
It should take 5-10 business days for unsplash to review an application

#

MrKomodoDragon

[python-discord/sir-lancebot] Pull request review submitted: #596 Add \.pyfacts command

#

MrKomodoDragon

[python-discord/sir-lancebot] New review comment on pull request #596: Add \.pyfacts command

Hmmm... why do you want to take out “Want to suggest a fact?” 🤔

#

MrKomodoDragon

[python-discord/sir-lancebot] New review comment on pull request #596: Add \.pyfacts command

Ok, i understand, a little wordy

#

MrKomodoDragon

[python-discord/sir-lancebot] Pull request review submitted: #596 Add \.pyfacts command

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #596 Add \.pyfacts command

#

Kronifer

[python-discord/sir-lancebot] New review comment on pull request #596: Add \.pyfacts command

for consistency with .topic

odd spireBOT Mar 4, 2021, 8:20 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #596 Add .pyfacts command

GitHub Actions run 622269323 succeeded.

PR Author

MrKomodoDragon

Workflow Run

Lint #454

Source Branch

MrKomodoDragon:master

regal archBOT Mar 4, 2021, 8:24 PM

#

Kronifer

[python-discord/sir-lancebot] Pull request review submitted: #596 Add \.pyfacts command

Looks amazing!

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

Storing these here for the application, but I have the raw versions too.

earth command

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #238: Text Based Adventure

I would be interested in taking this!

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

awesome! thanks for the animations

#

Kronifer

[python-discord/site] New comment on issue #354: Create robots\.txt file

what would have to be done to do this?

night lilyBOT Mar 4, 2021, 8:41 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 4, 2021, 8:41 PM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Does validation on the API side need to be updated too?

There is a PR that I forgot about open for it, I'll take a look at it.

#

HassanAbouelela

[python-discord/site] New comment on issue #354: Create robots\.txt file

It should be quite simple on django. Add a URL for robots.txt which returns a basic text response. The response will depend on the consensus of this issue, but it mostly seems to be:

User-agent: *
Allow: *

It may be wise to block certain routes, such as admin, but that requires more discussion.

#

Kronifer

[python-discord/site] New comment on issue #354: Create robots\.txt file

alright, sounds good!

regal archBOT Mar 4, 2021, 9:17 PM

#

lemonsaurus

[python-discord/site] Pull request review submitted: #447 Rework nominations

I'm mostly okay with this PR. There are grammar issues, but it looks like it does what it needs to do.

#

lemonsaurus

[python-discord/site] New review comment on pull request #447: Rework nominations

            # The serializer will truncate and get rid of excessive data

#

lemonsaurus

[python-discord/site] New review comment on pull request #447: Rework nominations

    is not allowed and invalid fields are ignored. If `user` already has an

#

lemonsaurus

[python-discord/site] New review comment on pull request #447: Rework nominations

    active nomination, a new nomination entry will be created and assigned as the

#

jb3

[python-discord/site] New review comment on pull request #447: Rework nominations

Single quotes.

                    {'actor': ['Actor don't exist or have not nominated user.']}

#

jb3

[python-discord/site] Pull request review submitted: #447 Rework nominations

Mainly grammar + code style fixes, but otherwise looks good.

#

jb3

[python-discord/site] New review comment on pull request #447: Rework nominations

Grammar

                {'actor': ['This actor has already endorsed this nomination.']}

#

jb3

[python-discord/site] New review comment on pull request #447: Rework nominations

I don't understand what this means, but I think this is an improvement. (It may be the opposite).

                    {'reviewed': ['This field cannot be set while you are ending a nomination.']}

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1303 Adding stream and revokestream commands

Everything looks good. Went through and tested it on my end. Was able to remove the role, let it naturally be removed by the time set, as well as restart the bot in the middle of it having someone in the timeout list and then having it sucessfully remove the role.

I'm more than happy to see this go forward.

#

SebastiaanZ

[python-discord/site] Pull request review submitted: #447 Rework nominations

#

SebastiaanZ

[python-discord/site] New review comment on pull request #447: Rework nominations

If this is going to be changed, it's needs to be changed in the test as well

#

SebastiaanZ

[python-discord/site] New review comment on pull request #447: Rework nominations

Make sure to change the test as well.

#

SebastiaanZ

[python-discord/site] New review comment on pull request #447: Rework nominations

make sure to adjust the test as well

regal archBOT Mar 4, 2021, 10:05 PM

#

HassanAbouelela

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@Kronifer The token is ready, please update the app name to Sir Lancebot (I believe in code that would be Sir%20Lancebot

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Maybe unpacking this type into match, certainty could help with readability of the if statement below.

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Remove debug print, or make it a log.trace()

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Minor grammar.

        """Gets the content of README.md from the WTF Python Repository."""

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

@HassanAbouelela thats done!

odd spireBOT Mar 4, 2021, 10:18 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #609 Earth photos

GitHub Actions run 622545819 succeeded.

PR Author

Workflow Run

Lint #455

Source Branch

Kronifer:earth_photos

regal archBOT Mar 4, 2021, 10:19 PM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request closed: #609 Earth photos

#

HassanAbouelela

[sir-lancebot:master] 44 new commits

1e240e7 initial commit of earth_photos - Kronifer
99a9d7a Update earth_photos.py - Kronifer
0260ad0 finished function - Kronifer
51f16ed Update earth_photos.py - Kronifer
286d40b linting changes - Kronifer

#

Kronifer

[python-discord/sir-lancebot] New comment on pull request #609: Earth photos

awesome!

odd spireBOT Mar 4, 2021, 10:23 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 622552849 succeeded.

Actor

Workflow Run

Build #160

Commit

0bc3cc5

night lilyBOT Mar 4, 2021, 10:24 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 4, 2021, 10:29 PM

#

HassanAbouelela

[python-discord/sir-lancebot] Issue closed: #174 Earth Photos

odd spireBOT Mar 4, 2021, 10:36 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #596 Add .pyfacts command

GitHub Actions run 622586995 succeeded.

PR Author

MrKomodoDragon

Workflow Run

Lint #457

Source Branch

MrKomodoDragon:master

#

[python-discord/sir-lancebot] Checks Successful on PR: #596 Add .pyfacts command

GitHub Actions run 622597010 succeeded.

PR Author

MrKomodoDragon

Workflow Run

Lint #458

Source Branch

MrKomodoDragon:master

regal archBOT Mar 4, 2021, 10:42 PM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #596 Add \.pyfacts command

#

HassanAbouelela

[python-discord/sir-lancebot] Issue closed: #587 Add command for fun facts about Python

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request closed: #596 Add \.pyfacts command

#

HassanAbouelela

[sir-lancebot:master] 16 new commits

7ba7149 Add .pyfacts command - MrKomodoDragon
b112226 Change bot: Bot to commands.Bot for consistency - MrKomodoDragon
fdfa5c7 Remove unused import - MrKomodoDragon
e571087 Merge branch 'master' of https://github.com/MrK... - MrKomodoDragon
06d600f Move loading of file outside of command - MrKomodoDragon

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #598 Removed the Question about the Nile

This change itself looks good an resolves the linked issue.

odd spireBOT Mar 4, 2021, 10:45 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 622603551 succeeded.

Actor

Workflow Run

Build #163

Commit

caacd7b

night lilyBOT Mar 4, 2021, 10:46 PM

#

Sir Lancebot

Connected!

regal archBOT Mar 4, 2021, 10:54 PM

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #238: Text Based Adventure

@Xithrius is it ok if I take this one?

#

MarkKoz

[python-discord/bot] New review comment on pull request #1297: Implements Voice Channel Muting

Why does the mock need to be reset? Isn't each mock in the list a separate instance?

#

MarkKoz

[python-discord/bot] New review comment on pull request #1297: Implements Voice Channel Muting

These should be await asserts in all the tests. In general, you should go over all your tests and make sure anything that's a coroutine is using the await assert.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1297 Implements Voice Channel Muting

#

MarkKoz

[python-discord/bot] New review comment on pull request #1297: Implements Voice Channel Muting

Perhaps irrelevant since this test needs to be redone anyway:

This message can be constant.
Because it is constant, it does not need to be included in the tuple.
It doesn't have to be MSG_SILENCE_SUCCESS; an arbitrary string literal can be used, which would simplify the test by avoiding format() and replace().

regal archBOT Mar 4, 2021, 11:33 PM

#

MarkKoz

[python-discord/bot] New review comment on pull request #1303: Adding stream and revokestream commands

There weren't any changes to Pipfile so relocking is unnecessary. Please undo these changes to the lock file.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1303 Adding stream and revokestream commands

#

MarkKoz

[python-discord/bot] New review comment on pull request #1303: Adding stream and revokestream commands

This function is also redundant.

#

MarkKoz

[python-discord/bot] New review comment on pull request #1303: Adding stream and revokestream commands

                await ctx.send(f"{Emojis.check_mark} Changed temporary permission to permanent.")

regal archBOT Mar 5, 2021, 12:53 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Addressed this in 70ecd087 as we already take care of many edge cases over the cog anyway

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I've removed it in fbe52273 and replaced it with a simpler system. A future is created either when an user requests it or the parsing of its associated doc item begins, then it is kept in the dict until its result is set.
I've replaced the redis set task with a normal await to prevent a potential race condition when the cache wouldn't be set before the item deletion and an another request for the item came in from an user.
I believe it didn't introduce any race conditions or logic errors bu...

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I've moved it outside of the try; the item access can't really fail now but the code is flatter and clearer with it outside.

What do you mean with the invariant? I'm afraid I didn't quite get that

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #598 Removed the Question about the Nile

#

Xithrius

[python-discord/sir-lancebot] Issue closed: #592 Remove question about the Nile

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #598 Removed the Question about the Nile

#

Xithrius

[sir-lancebot:master] 3 new commits

7bc0ea4 Removed the Question about the Nile and changed... - Arez1337
872d11c Merge branch 'master' into trivia - Xithrius
c2f2518 Merge pull request #598 from Arez1337/trivia - Xithrius

odd spireBOT Mar 5, 2021, 1:14 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #598 Removed the Question about the Nile

GitHub Actions run 622927698 succeeded.

PR Author

Arez1337

Workflow Run

Lint #460

Source Branch

Arez1337:trivia

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 622930194 succeeded.

Actor

Workflow Run

Build #164

Commit

c2f2518

night lilyBOT Mar 5, 2021, 1:17 AM

#

Sir Lancebot

Connected!

regal archBOT Mar 5, 2021, 1:18 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I believe I've encountered a few where the parsing algo ended up with an empty string (or all whitespace, only saw it on discord), do you propose we use Unable to parse the requested symbol. for the description in those cases too?

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I've set the future exceptions at first to let the errors get to the users directly, but didn't consider that there is still useful information to provide even if the parsing failed. I've removed the exception set in df5c7de8 and use the None default for the handling

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1446 Enhancing information within the incidents channel\.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

Similarly here, your change isn't in line with the rest of the codebase

I needed import of Bot from discord.ext.commands earlier, but later I didn't need it and I forgot to remove it from here.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

Is the error going to be posted to the channel? I'm not sure that's desired. I'd say it should log the error and return without creating an embed.

It would be posted along the other embeds with the webhook. I did this so it is easier to know what happened about that message link. I could just log it with a log.info and not create a embed for it

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1446 Enhancing information within the incidents channel\.

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

If we get through the request I don't think this can really fail unless the data gets corrupted in some way. The HTML is auto generated and the parser is fairly generous in what it allows

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

No, it is talking about how it parses the README.md into self.headers

odd spireBOT Mar 5, 2021, 2:14 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #605 Add WTF Python Command

GitHub Actions run 623052297 succeeded.

PR Author

Workflow Run

Lint #462

Source Branch

Shivansh-007:feature/wtf-python

regal archBOT Mar 5, 2021, 2:21 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Should we retry the connection, or just let the users know it failed with the request and let them redo it if they want to?

regal archBOT Mar 5, 2021, 2:52 AM

#

Kronifer

[python-discord/sir-lancebot] New comment on issue #238: Text Based Adventure

Hi, please add @MrKomodoDragon to the issue, were doing this together

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I imagine that most failures are of a nature for which retrying immediately would not succeed. Furthermore, conversations may move on, so adding a delay between retries won't be good.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I think it wouldn't hurt to take the precaution, but it's not strictly necessary. I'll leave it up to you to decide.

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

The presence of the future corresponding to a queue item is an internal invariant. It means that the program expects that there will always be a future for the queue item it popped. I'm proposing to add an assertion for that.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

MarkKoz

[python-discord/bot] New review comment on pull request #1014: Doc improvements

That's not where I was going with this. I was just wondering if Discord allows empty strings as descriptions or if it wants it to be None in such cases. I'm not sure if making such substitution for empty strings is accurate. Couldn't it be a case of a symbol truly lacking a description rather than it being a result of a parsing error?

regal archBOT Mar 5, 2021, 4:01 AM

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #238: Text Based Adventure

Alright. Good luck on development! Remember, if you have any questions, feel free to post in #dev-contrib.

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #238: Text Based Adventure

They will have to participate in this issue if you want me to assign them.

regal archBOT Mar 5, 2021, 4:31 AM

#

MrKomodoDragon

[python-discord/sir-lancebot] New comment on issue #238: Text Based Adventure

Yes?

regal archBOT Mar 5, 2021, 5:48 AM

#

ks129

[site:ks123/nomination/split] 1 new commit

54eca6d Fix grammar of nomination endpoints documentation - ks129

#

ks129

[site:ks123/nomination/split] 1 new commit

72693a6 Replace double quotes with single quotes - ks129

odd spireBOT Mar 5, 2021, 5:51 AM

#

[python-discord/site] Checks Successful on PR: #447 Rework nominations

GitHub Actions run 623470663 succeeded.

PR Author

Workflow Run

Lint & Test #103

Source Branch

ks123/nomination/split

#

[python-discord/site] Checks Failed on PR: #447 Rework nominations

GitHub Actions run 623474009 failed.

PR Author

Workflow Run

Lint & Test #104

Source Branch

ks123/nomination/split

regal archBOT Mar 5, 2021, 6:01 AM

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1446 Enhancing information within the incidents channel\.

#

Shivansh-007

[python-discord/bot] New review comment on pull request #1446: Enhancing information within the incidents channel\.

In many places of the code we use a bare exception, and for the similar case I using this, If any error occurs it should be mentioned in the embed, whether it is Channel Not Found, Channel Unreadable or Message Not Found. This is then set as the header of the error embed for that particular message link.

odd spireBOT Mar 5, 2021, 6:20 AM

#

[python-discord/bot] Checks Failed on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 623527612 failed.

PR Author

Workflow Run

Lint & Test #589

Source Branch

Shivansh-007:feature/enhance-...

regal archBOT Mar 5, 2021, 6:23 AM

#

ks129

[site:ks123/nomination/split] 2 new commits

9075231 Use double quotes instead apostrophe because st... - ks129
d8751ad Fix grammar of error messages and change tests ... - ks129

odd spireBOT Mar 5, 2021, 6:25 AM

#

[python-discord/site] Checks Successful on PR: #447 Rework nominations

GitHub Actions run 623537720 succeeded.

PR Author

Workflow Run

Lint & Test #105

Source Branch

ks123/nomination/split

odd spireBOT Mar 5, 2021, 7:12 AM

#

[python-discord/bot] Checks Cancelled on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 623620365 was cancelled.

PR Author

Workflow Run

Lint & Test #590

Source Branch

Shivansh-007:feature/enhance-...

#

[python-discord/bot] Checks Cancelled on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 623620365 was cancelled.

PR Author

Workflow Run

Lint & Test #590

Source Branch

Shivansh-007:feature/enhance-...

regal archBOT Mar 5, 2021, 7:23 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I'm not sure if a symbol like that can exist, or at least be directly parsed with an "empty" description by the parser as it'll always try to look for something.
But functionally the description works fine with an empty string

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

fdafa7423596d8a11b5c25a7f6a9ab47ed3ce6b6 changed the dict to a defaultdict, doing the assert on that would be redundant

regal archBOT Mar 5, 2021, 9:04 AM

#

gustavwilliam

[python-discord/branding] Pull request review submitted: #110 Add :lemon\_angrysad:

Thanks! This is starting to look pretty good.

This is what the lemoji looks like in use:

#

gustavwilliam

[python-discord/branding] Pull request closed: #110 Add :lemon\_angrysad:

#

gustavwilliam

[branding:master] 5 new commits

5cbe4ab Add files via upload - Atharv-Attri
7dbb9d8 uploaded :lemon_angrysad: and renamed the file - Atharv-Attri
da5c9a8 updated lemon_angrysad - Atharv-Attri
d14d91b resized to 128x128 - Atharv-Attri
8519005 Merge pull request #110 from Atharv-Attri/master - gustavwilliam

regal archBOT Mar 5, 2021, 10:27 AM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Ahh, so self.headers is a name: link dict?

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Is the cast to list needed?

regal archBOT Mar 5, 2021, 11:52 AM

#

vodelYT

[python-discord/bot] Issue opened: #1447 No way to disconnect user from channel

There is nothing like discord.Member.disconnect or VoiceChannel.disconnect(member)

#

HassanAbouelela

[python-discord/bot] New comment on issue #1447: No way to disconnect user from channel

There is member.move_to(None), but is that related to this repository?

#

vodelYT

[python-discord/bot] New comment on issue #1447: No way to disconnect user from channel

Sorry, wrong rep and thank you for your help

#

vodelYT

[python-discord/bot] Issue closed: #1447 No way to disconnect user from channel

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Ahh, so self.headers is a name: link dict? If so, could you update this docstring to say that it parses the readme into the self.headers dict, where the key is the heading and the value is the link to the heading?

Yes you are right! Alright will update the doc-string.

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Yes

d = {'a':1, 'b':2, 'c':3}
print(d.keys())
print(type(d.keys()))

Will give:

001 | dict_keys(['a', 'b', 'c'])
002 | <class 'dict_keys'>

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Yea, I know that, but as far as I can see process.extractOne() will work with a dict_keys class directly as its an iterable.

regal archBOT Mar 5, 2021, 3:26 PM

#

MrHemlock

[python-discord/bot] New review comment on pull request #1303: Adding stream and revokestream commands

@MarkKoz It does not kick them out. We would have to boot them from the voice channel. Currently, I'd prefer if we don't implement anything for it at the moment, as Mods+ do have permissions to boot someone from VC manually.

Typically if it came down to that, either they'd be receiving a voice ban or some other full infraction, which would bump them off call anyway. Even a regular server mute does so.

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1303 Adding stream and revokestream commands

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #605 Add WTF Python Command

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #605: Add WTF Python Command

Ah right,

regal archBOT Mar 5, 2021, 3:54 PM

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1303 Adding stream and revokestream commands

#

MrHemlock

[python-discord/bot] New review comment on pull request #1303: Adding stream and revokestream commands

In my opinion, the use case for revoke would be if someone finishes up their help session or what have you before it would expire, rather than having to remove it due to bad behavior.

regal archBOT Mar 5, 2021, 4:32 PM

#

gustavwilliam

[python-discord/branding] New comment on issue #84: Angrily\-sad lemoji

This was closed by #110.

#

gustavwilliam

[python-discord/branding] Issue closed: #84 Angrily\-sad lemoji

regal archBOT Mar 5, 2021, 4:52 PM

#

Shivansh-007

[python-discord/sir-lancebot] New comment on issue #446: Wikiguess game

I will be taking over this issue, had a talk with @gustavwilliam.

#

gustavwilliam

[python-discord/sir-lancebot] New comment on issue #446: Wikiguess game

I'm too busy to implement this myself, but let's wait for a core dev to assign you, before getting started.

#

Shivansh-007

[python-discord/bot] Pull request review submitted: #1435 Instructions to dispute an infraction vary by infraction type\.

Looks good, other than the changes mentioned by Akarys I don’t think anything is needed.

regal archBOT Mar 5, 2021, 5:15 PM

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 1 new commit

722d9b2 Fix Pipfile merge conflicts - ChrisLovering

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 123 new commits

931fb3e Verify channel constants on startup - WillDaSilva
b907c4c Add docstring to check_channels - WillDaSilva
7bec6f4 Capitalize "ID" in error message - WillDaSilva
52d6261 Merge branch 'master' into startup-channel-check - WillDaSilva
3616302 Add connect four cog supporting player vs playe... - Shivansh-007

odd spireBOT Mar 5, 2021, 5:19 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 625144221 succeeded.

PR Author

Workflow Run

Lint #463

Source Branch

Enforce-image-processing-concurrency

regal archBOT Mar 5, 2021, 5:51 PM

#

MrHemlock

[python-discord/bot] Issue opened: #1448 Add DM to current \#voice\-verification ping

When a user joins the voice chat for the first time, they receive a ping in the #voice-verification channel. This was done in an attempt to solve new users' confusion as to why they couldn't talk when joining the chat. However, it does not seem to be having the desired effect, as there are still quite a few users still confused.

The proposal now is to send a DM to the user with a link and explanation so that they have a lasting link and reminder on how to get verified. Message requir...

regal archBOT Mar 5, 2021, 6:42 PM

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1441: Unescape html escape characters in reddit text and titles

The line above could be moved into this if statement as a walrus operator

            if text := unescape(data["selftext"]):

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #1441 Unescape html escape characters in reddit text and titles

We usually recommend that you raise issues before raising a PR directly to the repo, as it's possible the core dev team will have opinions.

As far this change, we are currently porting this over to Sir Lancebot with https://github.com/python-discord/sir-lancebot/issues/530 and https://github.com/python-discord/sir-lancebot/pull/569

If we decide that we want these changes in the meantime, my comments are below.

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1441: Unescape html escape characters in reddit text and titles

Could we have this and the line above in a single assignment?

            title = textwrap.shorten(
                unescape(data["title"]),
                width=64,
                placeholder="..."
            )

regal archBOT Mar 5, 2021, 8:34 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #1445 Migrate talentpool to new API schema

Only a code review, haven't tested yet. Mostly grammer

#

mbaruh

[python-discord/bot] New review comment on pull request #1445: Migrate talentpool to new API schema

I think "You have already nominated this user" sounds better

                    await ctx.send(":x: You have already nominated this user")

#

mbaruh

[python-discord/bot] New review comment on pull request #1445: Migrate talentpool to new API schema

The wording here is a little confusing, I'd go for something like:

        """Edits the reason of a specific nominator in a specific active nomination."""

#

mbaruh

[python-discord/bot] New review comment on pull request #1445: Migrate talentpool to new API schema

This should be in parentheses

            msg += f"\n\n({len(history)} previous nominations in total)"

regal archBOT Mar 5, 2021, 9:06 PM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

The code on master doesn't do any handling around it and it doesn't look like there were any issues with it. I'll leave it for now, with my points above in mind, and if an issue pops up in the future it can be addressed then

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I mostly saw it as an opportunity to not store unnecessary data in the redis keys, with the added benefit of them looking a bit nicer when they're inspected during development

regal archBOT Mar 5, 2021, 10:06 PM

#

ChrisLovering

[sir-lancebot:Enforce\-image\-processing\-concurrency] 1 new commit

64576f5 Rename in_thread fuction for clarity. - ChrisLovering

odd spireBOT Mar 5, 2021, 10:07 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #597 Move pfp commands into executors

GitHub Actions run 625807452 succeeded.

PR Author

Workflow Run

Lint #464

Source Branch

Enforce-image-processing-concurrency

regal archBOT Mar 6, 2021, 1:46 AM

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

        if not user:

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

Can we add this color (0xFF0000) to the constants.py or use it from there?

#

Shivansh-007

[python-discord/sir-lancebot] Pull request review submitted: #597 Move pfp commands into executors

#

Shivansh-007

[python-discord/sir-lancebot] New review comment on pull request #597: Move pfp commands into executors

Doesn’t user.name return a string data type?

odd spireBOT Mar 6, 2021, 2:02 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #605 Add WTF Python Command

GitHub Actions run 626258580 succeeded.

PR Author

Workflow Run

Lint #465

Source Branch

Shivansh-007:feature/wtf-python

regal archBOT Mar 6, 2021, 3:09 AM

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

Actually, this will fall under the broad exception handling added in 51a11cc4

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I've moved the creation of the footer text before the get symbol await to avoid this.

#

Numerlor

[python-discord/bot] Pull request review submitted: #1014 Doc improvements

#

Numerlor

[python-discord/bot] New review comment on pull request #1014: Doc improvements

I've moved the handling around getting the DocItem from doc_symbols and fetching the markdown from redis/the BatchParser to separate methods in 4f5f284d3eec46b9209d19142d5c21456c4c403a, do you think this is still worth moving, leaving the method to just manage the few calls and some hadnling around htem?

regal archBOT Mar 6, 2021, 10:54 AM

#

mbaruh

[python-discord/site] New review comment on pull request #447: Rework nominations

Another small correction

        help_text="Whether a review was made."

#

mbaruh

[python-discord/site] Pull request review submitted: #447 Rework nominations

#

mbaruh

[python-discord/site] Pull request review submitted: #447 Rework nominations

A few more

#

mbaruh

[python-discord/site] New review comment on pull request #447: Rework nominations

    """A nomination entry created by a single staff member."""

#

mbaruh

[python-discord/site] New review comment on pull request #447: Rework nominations

    active nomination, a new nomination entry will be created and assigned to the

#

mbaruh

[python-discord/site] New review comment on pull request #447: Rework nominations

        help_text="The nomination this entry belongs to.",

odd spireBOT Mar 6, 2021, 11:42 AM

#

[python-discord/bot] Checks Failed on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 627160537 failed.

PR Author

Workflow Run

Lint & Test #591

Source Branch

Shivansh-007:feature/enhance-...

#

[python-discord/bot] Checks Failed on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 627171751 failed.

PR Author

Workflow Run

Lint & Test #592

Source Branch

Shivansh-007:feature/enhance-...

regal archBOT Mar 6, 2021, 11:59 AM

#

jb3

[bot:json\-logging] 2 new commits

e9bdccf Add JSON logging dependencies - jb3
9636593 Use JSON logging when debug mode is disabled - jb3

#

jb3

[python-discord/bot] New branch created: json\-logging

#

jb3

[python-discord/bot] Pull request opened: #1449 Use JSON logging in production

JSON logging allows for greater filtering with our log aggregator, Loki.

This PR introduces JSON logging when debug mode is set to false (i.e. the bot is running in production).

odd spireBOT Mar 6, 2021, 12:02 PM

#

[python-discord/bot] Checks Successful on PR: #1446 Enhancing information within the incidents channel.

GitHub Actions run 627183224 succeeded.

PR Author

Workflow Run

Lint & Test #593

Source Branch

Shivansh-007:feature/enhance-...

#

[python-discord/bot] Checks Failed on PR: #1449 Use JSON logging in production

GitHub Actions run 627186850 failed.

PR Author

Workflow Run

Lint & Test #594

Source Branch

json-logging

regal archBOT Mar 6, 2021, 12:03 PM

#

mbaruh

[python-discord/bot] New comment on pull request #1446: Enhancing information within the incidents channel\.

You should keep commit titles short. If you want to add more detail you should do it in the commit body.

#

jb3

[bot] Branch json\-logging was force-pushed to `f29524b`

odd spireBOT Mar 6, 2021, 12:07 PM

#

[python-discord/bot] Checks Failed on PR: #1449 Use JSON logging in production

GitHub Actions run 627193163 failed.

PR Author

Workflow Run

Lint & Test #595

Source Branch

json-logging

regal archBOT Mar 6, 2021, 12:08 PM

#

jb3

[bot] Branch json\-logging was force-pushed to `fd7a693`

#

ks129

[site:ks123/nomination/split] 1 new commit

53a9f52 Fix grammar of nomination models - ks129

odd spireBOT Mar 6, 2021, 12:11 PM

#

[python-discord/site] Checks Successful on PR: #447 Rework nominations

GitHub Actions run 627200344 succeeded.

PR Author