#dev-log

1 messages ยท Page 66 of 1

regal archBOT
odd spireBOT
regal archBOT
regal archBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/forms-frontend] New branch created: discord\-oauth
#

Heard you wanted some PRs.

Implemented

  • Basic auth flow (open discord oauth menu -> get code; send code to backend -> store jwt)
  • Helper methods to handle each of the auth steps
  • Added a cookie library, may remove before PR is ready
  • Dynamic selection between auth button, and submit

Implementation note:
Cookies are currently stored on the /form route, meaning any other parts of the application such as admin panel, will need to handle their own authentication. This is not ...

#
[python-discord/forms-backend] New branch created: token\-expiry
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

Description

The current xkcd command doesnโ€™t have the description, or a link to the comic.

Reasoning

It would help provide more info about the comic.

Proposed Implementation

Use the โ€˜altโ€™ key in the json page and use the URL var we use to make the requests.

Would you like to implement this yourself?

  • [x] I'd like to implement this feature myself
  • [ ] Anyone can implement this feature
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] branch deleted: pypi\-command
#
[python-discord/bot] New branch created: ks123/docker\-git\-sha
oak estuaryBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: pypi\-command\-escape\-markdown
odd spireBOT
regal archBOT
#
[python-discord/bot] branch deleted: pypi\-command\-escape\-markdown
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

4687f3d Intial Commit; Change secret functionality and ... - Shivansh-007
ae51830 Fix return statements and return type annotations - Shivansh-007
1951ce5 Remove code that requires intents.member set True - Shivansh-007
d9a40f8 If whom is None, take the user as whom - Shivansh-007
370535b Improve grammar and update docstrings, add try.... - Shivansh-007

odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/sir-lancebot] New branch created: Reset\-valentine\-command\-cooldown\-on\-failure
#

Description

By raising UserInputError the handler in bot.py will reset the command cooldown.

Reasoning

The reset cd already exists, so raising the error utilizes already implemented & tested code.

Did you:

  • [ ] Join the Python Discord Community?
  • [ ] If dependencies have been added or updated, run pipenv lock?
  • [ ] Lint your code (pipenv run lint)?
  • [ ] Set the PR to allow edits from contributors?
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#

Description

Currently, when interacting from files we using the normal

with open('filename.extension') as f:
    ...

This way of interacting with files is blocking. We should switch to a non-blocking method of handling files, both when reading and writing.

Reasoning

Most file interactions happen on startup, so doing this will improve bot start times. it is also possible that we do this in some places during the command, so this will mean those commands will no lo...

odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
oak estuaryBOT
odd spireBOT
regal archBOT
#

https://github.com/python-discord/sir-lancebot/blob/13620a6461a78e43e8b16b9ad35691ff30622332/bot/resources/evergreen/trivia_quiz.json#L194

There's no way to definitively say if the Nile river or Amazon river is larger than the other. While the Amazon indisputably discharges more water, I believe there's some debate about where the Amazon definitively starts, and thus there's no way to say which is longer.

Because this question is ambiguous, it should be removed.

odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/html\-webpack\-plugin\-5\.1\.0
#

Bumps html-webpack-plugin from 5.0.0 to 5.1.0.

Changelog
Sourced from html-webpack-plugin's changelog.

5.1.0 (2021-02-12)
Features

omit html tag attribute with null/undefined/false value (aa6e78d), closes #1598

Commits

2e30bb1 chore(release): 5.1.0
aa6e78d feat: omit html tag attribute with null/undefined/false value
33d69f4 Update scriptLoading's default on README.md
See full diff in compare view

[![Dependabot compatibility scor...

#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/types/node\-14\.14\.28
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/types/node\-14\.14\.26
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/testing\-library/user\-event\-12\.7\.1
#

Bumps @testing-library/user-event from 12.6.3 to 12.7.1.

Release notes
Sourced from @testing-library/user-event's releases.

v12.7.1
12.7.1 (2021-02-13)
Bug Fixes

click links on 'enter' key press (#534) (8a34d0b)

v12.7.0
12.7.0 (2021-02-11)
Features

add type support for {home} and {end} (#536) (808c550)

Commits

8a34d0b fix: click links on 'enter' key press (#534)
217b487 docs: add curiosity26 as a contributor (#555)
808c550 feat: add t...

#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/testing\-library/user\-event\-12\.7\.0
regal archBOT
#
[python-discord/forms-backend] New branch created: dependabot/pip/sentry\-sdk\-0\.20\.1
#

Bumps sentry-sdk from 0.19.5 to 0.20.1.

Release notes
Sourced from sentry-sdk's releases.

0.20.1

Fix for error that occurs with Async Middlewares when the middleware is a function rather than a class

0.20.0

Fix for header extraction for AWS lambda/API extraction
Fix multiple **kwargs type hints # 967
Fix that corrects AWS lambda integration failure to detect the aws-lambda-ric 1.0 bootstrap #976
Fix AWSLambda integration: variable "timeo...

#
[python-discord/forms-backend] branch deleted: dependabot/pip/sentry\-sdk\-0\.20\.0
odd spireBOT
regal archBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
regal archBOT
#

Description

We limit add a global limit of 1 concurrent command at a time to the image processing commands (easterifiy, pride avatar 8bitify etc.). We should also run them in an executor so they are non-blocking.

Reasoning

Image processing commands can be quite CPU intensive, especially if the image is high resolution. We discussed adding a concurrency limit across the bot of only allowing 1 command to be ran at a time.

Also, running these in an executor will mean its no-lon...

regal archBOT
#
[python-discord/forms-backend] New branch created: dependabot/pip/sentry\-sdk\-0\.20\.2
#

Bumps sentry-sdk from 0.19.5 to 0.20.2.

Release notes
Sourced from sentry-sdk's releases.

0.20.2

Fix incorrect regex in craft to include wheel file in pypi release

0.20.1

Fix for error that occurs with Async Middlewares when the middleware is a function rather than a class

0.20.0

Fix for header extraction for AWS lambda/API extraction
Fix multiple **kwargs type hints # 967
Fix that corrects AWS lambda integration failure to detect the aws-l...

#
[python-discord/forms-backend] branch deleted: dependabot/pip/sentry\-sdk\-0\.20\.1
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
oak estuaryBOT
regal archBOT
#

A few suggestions:

  • Add paginated response for many results (maybe 5 pages, 5 results on each page or maybe a bit less pages).
  • Order results in descending order of views or another parameter which would suit.
  • I don't like the idea of this being restricted to only sir-lancebot channel, I think even voice channels, help channels, python and general/adv channels should have access to this command as it could prove to be quite useful.
  • After the feature is merged, we could use caching i...
regal archBOT
#
  1. I don't think 5 pages are needed, we should get only say the top 10, since after that, the questions are non relevant ones.
  2. Agree with this.
  3. On every question people would just run the command, and I am not in the favour of that, voice channels and bot commands channels are fine, and ots, but I am not in favour about the others.
  4. It is quiet fast right now, so caching isn't really needed.
  5. Agree with this.
regal archBOT
#
[python-discord/sir-lancebot] branch deleted: Reset\-valentine\-command\-cooldown\-on\-failure
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#

In asynchronous programming, blocking calls are all the parts of your function that are not using await.

Not all forms of blocking are bad, and using blocking calls are inevitable, but make sure not to use too much.

I think this part would be a bit vague for someone who's new to async/await. x + y is a blocking call, but you wouldn't usually describe it as such. Maybe clarify that it applies mostly to blocking I/O (with examples such as open and requests), or to CPU-heavy ...

regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/typescript\-4\.1\.5
regal archBOT
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/eslint\-7\.20\.0
#

Bumps eslint from 7.19.0 to 7.20.0.

Release notes
Sourced from eslint's releases.

v7.20.0

f4ac3b0 Docs: fix sibling selector descriptions (#14099) (Milos Djermanovic)
9d6063a Fix: Crash with esquery when using JSX (fixes #13639) (#14072) (Yosuke Ota)
a0871f1 Docs: Triage process (#14014) (Nicholas C. Zakas)
ad90761 Update: add enforceForJSX option to no-unused-expressions rule (#14012) (Duncan Beevers)
d6c84af Fix: --init autoconfig shouldn't add depreca...

regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#

Recently a user posted a valid user token and we realized we do not have a filter for this. I believe it would be simple enough to implement this check and worth it to protect users that, for whatever reason make this mistake.

While there is no valid reason I can think of for a user to have their token in their clipboard, I still think it is important to protect our users. This could also potentially aid in moderating selfbotting discussions in the very off chance a user accidentally pos...

regal archBOT
#

We've got rudimentary detection for regular user tokens courtesy of the work I did (a few months ago). However, it only works on regular tokens (of which bot tokens are a part of). Users who have multi-factor authentication on have a different token format.

As far as I'm aware, they always start with mfa although I believe I've sometimes seen that capitalized. But no other letter pattern. We may or may not want to be strict with this? I'm pretty sure they always have two underscores wit...

regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
[python-discord/sir-lancebot] New branch created: Enforce\-image\-processing\-concurrency
#

Relevant Issues

Closes #593 and #594

TODO

Have all image processing code run in threads. Currently only done for pride avatar.
Add root aliases for rest of pfp processing commands. Currently only done for price avatar.
Test that root aliases still share the single max concurrency bucket

Description

  1. Ported root alias support from https://github.com/python-discord/bot/pull/1124.
  2. Merged all pfp modifying cogs into one.
  3. Added a concurrency queue to the group c...
odd spireBOT
regal archBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
#

It basically cycles through the element of the list one by one, like here is a example

>>> import itertools
>>> shape_list = ["square", "triangle", "circle", "pentagon", "star", "octagon"]
>>> g = itertools.cycle(shape_list)
# Then call next() whenever you want another one.
>>> next(g)
'square'
>>> next(g)
'triangle'
>>> next(g)
'circle'
>>> next(g)
'pentagon'
>>> next(g)
'star'
>>> next(g)
'octagon'
>>> next(g)
'square'
>>> next(g)
'triangle'
regal archBOT
regal archBOT
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/types/node\-14\.14\.30
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/types/node\-14\.14\.28
odd spireBOT
regal archBOT
#
[python-discord/forms-backend] New branch created: dependabot/pip/sentry\-sdk\-0\.20\.3
#

Bumps sentry-sdk from 0.19.5 to 0.20.3.

Release notes
Sourced from sentry-sdk's releases.

0.20.3

Added scripts to support auto instrumentation of no code AWS lambda Python functions

0.20.2

Fix incorrect regex in craft to include wheel file in pypi release

0.20.1

Fix for error that occurs with Async Middlewares when the middleware is a function rather than a class

0.20.0

Fix for header extraction for AWS lambda/API extraction
Fix multiple ...

#
[python-discord/forms-backend] branch deleted: dependabot/pip/sentry\-sdk\-0\.20\.2
odd spireBOT
regal archBOT
#
[python-discord/forms-frontend] branch deleted: forms\-submitting
regal archBOT
oak estuaryBOT
odd spireBOT
oak estuaryBOT
#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

ashen phoenix
#

oh

shrewd jacinth
#

first time I see that here

oak estuaryBOT
regal archBOT
odd spireBOT
oak estuaryBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
odd spireBOT
regal archBOT
#

Currently the talentpool list command shows invalid-user for lots of the user mentions in the embed, as discord only displays them if they're already in the user's cache.

To fix this we can make it display the username and ID in the embed instead of using a mention. If the user is not in the server, this should also be mentioned (afaik we also may not be able to get the username if this is the case).

This is the command in question:
https://github.com/python-discord/bot/blob/844a1b66...

#

The idea here is to remove the need for moderators to write up votes by making it automated. This will happen a certain period after nomination (I think 1 month would be a good duration to start off with).

This should be done as a pinging message in the #mod-announcements channel, and it should contain:

  • User details, e.g. mention and user ID (although if we use a mention it probably shouldn't be in an embed)
  • Nomination history, number of nominations, unnominations, and reasons (rea...
regal archBOT
odd spireBOT
regal archBOT
#

I'm writing this issue without having consulted the rest of the staff about whether or not this is something we'd want, so this issue should also be a discussion about that if anyone objects.

Currently, the PFP for the ModMail bot is generic. While most ModMail interactions are initiated by server members, we occasionally start them ourselves, and we have to introduce ourselves as "a moderator on Python Discord"; otherwise it isn't necessarily clear what is happening. I think integrating o...

#
jb3

The good thing about the envelope is that it does help convey the DM nature of the bot, without people knowing what "modmail" means.

I'm curious if there is a logo design which can incoporate both icons to make it clearer.

Could the same effect be achieved through nicknames? Renaming the bot to Python Discord ModMail and giving it a nickname of ModMail in the server is probably the most clear we'd get it.

regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] branch deleted: ks123/duplicates\-ignore\-attachments
oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: feat/1365/add\-bot\-badges\-to\-user
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
#
[python-discord/site] New branch created: ks123/multiple\-nominations
odd spireBOT
regal archBOT
#

โ€ฆrder again

Relevant Issues

Closes #592

Description

I deleted the Question about the longest river and then changed all following IDs to match the order again

Reasoning

The answer to this question is not definitively "nile"

Did you:

  • [x ] Join the Python Discord Community?
  • [x ] If dependencies have been added or updated, run pipenv lock?
  • [x ] Lint your code (pipenv run lint)?
  • [x ] Set the PR to **allow ed...
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/forms-frontend] New branch created: redux\-hcaptcha
regal archBOT
oak estuaryBOT
night lilyBOT
#
Sir Lancebot

Connected!

night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
odd spireBOT
regal archBOT
oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/site] branch deleted: ks123/multiple\-nominations
oak estuaryBOT
regal archBOT
regal archBOT
#
jb3

Following on from python-discord/meta#92.

We want to provide a third help channel in the available category so that more people can type their question at once without the channel being claimed halfway through. Please see the original issue for the justification.

The help channels cog must be altered to provide for this and place 3 help channels into the available pool (as opposed to the current two).

oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
#

Description

A hangman game command where the user can play as the guesser or the executioner. As a guesser, the player will guess letters one at a time. Each time, the bot will show how hanged the man is and if the half-guessed word. By default, the word will be 4-8 letters long and will have 3-4 unique letters. As an executioner, the bot will first guess a letter and receive confirmation or denial about the guess from the player. If the player says the bot guessed a letter correctly, t...

regal archBOT
regal archBOT
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/types/node\-14\.14\.30
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/eslint\-7\.20\.0
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/html\-webpack\-plugin\-5\.1\.0
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/types/react\-dom\-17\.0\.1
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/webpack\-5\.23\.0
#

Bumps webpack from 5.21.2 to 5.23.0.

Release notes
Sourced from webpack's releases.

v5.23.0
Features

add parserOptions.url: "relative" option

Allows to generate relative URLs from new URL (e. g. for SSG/SSR)

Bugfixes

fixes for electron target

electron has importScripts in worker
only choose a chunkLoading which fits to the chunkFormat
prefer fetch wasm loading over node wasm loading

fix regression when combining library + runtimeChunk...

#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/typescript\-eslint/eslint\-plugin\-4\.15\.1
#

Bumps @typescript-eslint/eslint-plugin from 4.15.0 to 4.15.1.

Release notes
Sourced from @typescript-eslint/eslint-plugin's releases.

v4.15.1
4.15.1 (2021-02-15)
Bug Fixes

eslint-plugin: [explicit-module-boundary-types] check allowNames on function declarations and property methods (#3051) (0ade469)

Changelog
Sourced from @typescript-eslint/eslint-plugin's changelog.

4.15.1 (2021-02-15)
Bug Fixe...

#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/webpack\-5\.23\.0
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/typescript\-eslint/eslint\-plugin\-4\.15\.1
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/types/react\-dom\-17\.0\.1
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/html\-webpack\-plugin\-5\.2\.0
#

Bumps html-webpack-plugin from 5.1.0 to 5.2.0.

Changelog
Sourced from html-webpack-plugin's changelog.

5.2.0 (2021-02-19)
Features

improve ssr (73d2a66)

Commits

dea2f4d chore(release): 5.2.0
20bf6f2 chore: update to html-loader 2
1f7ce7e chore: remove deprecated file-loader from examples
73d2a66 feat: improve ssr
e5036c8 chore: upgrade dev dependency to latest webpack version
See full diff in compare view

[![Dependabot compatibil...

#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/types/node\-14\.14\.31
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/types/react\-17\.0\.2
regal archBOT
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/types/node\-14\.14\.31
regal archBOT
#

Bumps @sentry/react from 6.1.0 to 6.2.0.

Release notes
Sourced from @sentry/react's releases.

6.2.0

[tracing] feat: Mongoose tracing support added to MongoDB (#3252)
[tracing] fix: Add missing find method from mongo tracing list (#3253)
[tracing] fix: Create spanRecorder whenever transactions are sampled (#3255)
[node] fix: Parse ESM based frames with file:// protocol (#3264)
[react] fix: Remove react-dom peer dependency for RN (#3250)
[emb...

#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/sentry/react\-6\.2\.0
regal archBOT
#
[python-discord/forms-frontend] New branch created: fix\-broken\-links
#
[python-discord/site] New branch created: ks123/nomination/split
#

Previously, links to assets in public/ were using relative paths, which works on the home page, but on subpages, such as forms, the app would try to fetch them from an incorrect location, and 404. This PR uses fixed paths for the assets to allow proper locating.

Note: If your IDE complains about being unable to find the files, that's because the fixed path in the source code, and in the compiled output are different (see webpack config).

regal archBOT
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/sentry/react\-6\.2\.0
#
[python-discord/forms-backend] New branch created: dependabot/pip/uvicorn\-0\.13\.4
#

Bumps uvicorn from 0.13.3 to 0.13.4.

Release notes
Sourced from uvicorn's releases.

Version 0.13.4
0.13.4 - 2021-02-20
Fixed

Fixed wsgi middleware PATH_INFO encoding (#962) 2/20/21
Fixed uvloop dependency (#952) 2/10/21 then (#959) 2/20/21
Relax watchgod up bound (#946) 1/31/21
Return 'connection: close' header in response (#721) 1/25/21

Added:

Docs: Nginx + websockets (#948) 2/10/21
Document the default value of 1 for workers (#940) (#943) 1/25/21
E...

odd spireBOT
regal archBOT
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/types/react\-17\.0\.2
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/html\-webpack\-plugin\-5\.2\.0
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/testing\-library/user\-event\-12\.7\.2
#

Bumps @testing-library/user-event from 12.6.3 to 12.7.2.

Release notes
Sourced from @testing-library/user-event's releases.

v12.7.2
12.7.2 (2021-02-22)
Bug Fixes

upload: apply accept attribute (#558) (d513d6e)

v12.7.1
12.7.1 (2021-02-13)
Bug Fixes

click links on 'enter' key press (#534) (8a34d0b)

v12.7.0
12.7.0 (2021-02-11)
Features

add type support for {home} and {end} (#536) (808c550)

Commits

d513d6e fix(upload): apply accept attr...

#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/testing\-library/user\-event\-12\.7\.1
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/testing\-library/user\-event\-12\.7\.2
odd spireBOT
regal archBOT
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/html\-webpack\-plugin\-5\.2\.0
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/react\-spinners\-0\.10\.6
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/types/react\-transition\-group\-4\.4\.1
#
[python-discord/forms-frontend] New branch created: dependabot/npm\_and\_yarn/typescript\-eslint/parser\-4\.15\.1
#

Bumps @typescript-eslint/parser from 4.15.0 to 4.15.1.

Release notes
Sourced from @typescript-eslint/parser's releases.

v4.15.1
4.15.1 (2021-02-15)
Bug Fixes

eslint-plugin: [explicit-module-boundary-types] check allowNames on function declarations and property methods (#3051) (0ade469)

Changelog
Sourced from @typescript-eslint/parser's changelog.

4.15.1 (2021-02-15)
Note: Version bump only for package ...

odd spireBOT
regal archBOT
regal archBOT
#

Note! This HAVE to be merged EXACTLY the same time as bot PR

Changes

Instead of one nominations table, there are now 2 tables: Nominations and nomination entries. The nominations table got one new field reviewed (boolean). Here are schemas of these tables:

Table: nomination

active (boolean)
user (User)
inserted_at (datetime)
end_reason (string)
ended_at (datetime)
reviewed (boolean)
Table: nomination entries

nomination (Nomination)
actor (User)
reason...
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/bot] New branch created: wookie184\-tag\-updates
#

I'm just curious as to why a static change (a simple bump to 3 channels) was chosen, as opposed to dynamic change, as described in the original issue:

the bot could detect typing in these channels and if both are being typed into at the same time, send a new channel in

Dynamic change like this could be quite beneficial and wouldn't require further issues with increasing the count, it would also mean that during the more active hours, there would perhaps be more help channels, to satisfy...

odd spireBOT
regal archBOT
regal archBOT
#

The current question is "What's the name of the largest river in the world?", which I think is quite ambiguous (does it mean length, volume, or discharge?).

Wikipedia suggests there is disagreement on what is the longest river, although from what I can tell the Amazon seems to be widely regarded as the river with the largest drainage basin and greatest average discharge.

I think removing the question is fine....

regal archBOT
#

Relevant Issues

Closes #565

Description

This has been implemented with help of aiohttp to request and get json data of the Wikipedia Article. It then filters the data and stores only the required information namely Title, Snippet and Page ID. This filtered data to the Line Paginator.

Reasoning

Approved by Staff Member.

Screenshots

No Result Found

![Screenshot from 2021-02-22 20-35-51](https://user-images.githubusercontent.com/69356296/108727918...

odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

Hi! Thanks for the PR! This looks great, but there are a few things I'd like to mention.

Seems like there's some weird blue on the banner logo

There's also some weird outlines on the server icon:

It seems like this was done using something like Photoshop. I'd recommend Illustrator, Affinity Designer or Inkscape, so you can work directly with the vector shapes. (Ping Vestergurkan on the server if you'd like me to explain more).

Considering that the server icon will be tiny...

regal archBOT
regal archBOT
#
[python-discord/branding] New branch created: question\-mark
#

Adds an icon used in DMs sent to the user after claiming a help channel. This is used for python-discord/bot#1174. Here's the emoji and the use case:
green-question-mark-dist

Consistent style

The icon is designed to match the style of the green checkmark used in the available help channel embed. This will provide a consistent user experience from the moment they first claim the ...

odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: dm\-on\-open\-help\-channel
#

Closes #1174.

This PR introduces a feature that will DM users when they claim help channels, with links to the original message and more. It looks like this:

This also introduces a new message truncation feature, that we can use whenever the content of a message needs to be truncated to a certain length. The bot simply ignores to send a DM if the claimant's DMs aren't open.

Before merging

The thumbnail icon is currently waiting to get merged into master on the branding repo. Pl...

odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
odd spireBOT
oak estuaryBOT
regal archBOT
regal archBOT
#
[python-discord/site] New branch created: add\-linode\-footer
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: pypi\-url\-formatter\-patch
#
[python-discord/bot] branch deleted: dm\-on\-open\-help\-channel
#

0b11d7d Add truncate_message util - gustavwilliam
e1d269d Add function to DM users when opening help channel - gustavwilliam
e6483d6 Add green question mark to default config - gustavwilliam
e34ea2f Send DM when user claims help channel - gustavwilliam
bb9e56c Update embed field title to be more formal - gustavwilliam

oak estuaryBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/forms-frontend] New branch created: hcaptcha
regal archBOT
#
[python-discord/branding] New branch created: hidden\-gems\-logo
regal archBOT
#
[python-discord/branding] branch deleted: hidden\-gems\-logo
oak estuaryBOT
odd spireBOT
odd spireBOT
regal archBOT
#

I ran out of time for now, but I'm a few commits in. I've just gone over the code as of now and I wanted to give my feedback early, rather than late, as I'm not sure when I'll have time again.

Things I haven't reviewed yet:

  • Grammar
  • Functional test

As a general comment: None of the commit messages I've read have a meaningful commit message body and some of the titles are a bit too long. Ideally, a commit message should explain the what and why of the change you're committing to th...

#

The current branding manager is just ported over from Sir Lancebot. This was originally meant to match with Sir Lancebot command-lock seasons, but now this is meant to manage server icon and banner, and having branding stuff in the branding repository and seasons in bot repository doesn't make sense anymore.

We should migrate all seasons data to branding repository YAML files what bot reads. Also, we should start supporting sub-seasons that are a short period during the larger season. This...

regal archBOT
odd spireBOT
regal archBOT
#

Testing this locally, we will need to add this check to both this and the ai sub command.

This command will never work, as no one will be able to respond.
The ai sub command won't work as the bot isn't able to remove the player's reaction after they add one.

For this I think just a simple embed saying something like, You can't play connect 4 in DMs. Go to <sir-lancebot-playground-channel> instead!

regal archBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
regal archBOT
#
[python-discord/branding] branch deleted: question\-mark
regal archBOT
regal archBOT
regal archBOT
#

The banner was previously an sag that only contained an image, which led to the strange artifacting of the fill tool. After discussing this in #media-branding, I've recreated the banner using the colors and dimensions of the original file. Since it seems like an svg can't be uploaded in a GitHub comment, I'll send the file to @MrKomodoDragon over on Discord and he'll export it as a png.

regal archBOT
regal archBOT
regal archBOT
regal archBOT
#

Optional arguments in brackets prevent this function from doing much in a lot of cases as it won't be able to split in them. Do you think it's worth looking into more? So far I haven't been able to come up with a satisfactory way to handle it later on in _truncate_signatures as it'll need to know the depth of optional brackets to be able to add them when not taking in all params

regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/site] branch deleted: add\-linode\-footer
odd spireBOT
regal archBOT
#
[python-discord/forms-backend] New branch created: feat/9/unittest\-validation
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

So, we already have this handler here https://github.com/python-discord/sir-lancebot/blob/3ad829d98f1de30f08d26fe592b8a89701301983/bot/exts/evergreen/error_handler.py#L85-L87 which catches the case where a command decorated with the commands.in_guild() check fails.

The question is, do we want to enforce this across all commands, or do we want to just make sure this check is added to commands as needed.

regal archBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/forms-frontend] branch deleted: dependabot/npm\_and\_yarn/types/react\-transition\-group\-4\.4\.1
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
odd spireBOT
regal archBOT
oak estuaryBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
#
[python-discord/bot] New branch created: etiquette\-off\-topic\-tag
odd spireBOT
regal archBOT
#

I hinted at this in a discussion on Discord, but I'm having doubts over the path remapping feature. It's proven to complicate the implementation and doesn't seem too useful in retrospect. In fact, it may be an unintuitive feature for end-users that edit configurations, since it breaks the established 1:1 relationship between the paths in YAML and Python. It's not inherently transparent to users that an attribute has been remapped.

I'm in favour of dropping the feature at this point. ...

odd spireBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#

Currently the bot only sends the error embed when a BadUnionArgument or ArgumentParsingError occurs, unlike all the other handled exceptions which send the help for the command.
The PR adds sending the help under the BadUnionArgument error.
For ArgumentParsingError I've decided to only close the coroutine, as the error fails on the user's formatting and occurs regardless of the user passing in the expected args or not

odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: swfarnsworth/infraction\_message
#

Previously, the user was instructed to email the appeals email for infraction types that don't remove one from the server. They are now instructed to DM ModMail, except for infractions that remove them from the server (which all get mapped to the string Ban by the time the relevant code is involved).

There was also a header that read "Please review our rules over at ", and this now reads "Please review our rules". The header itself was and still is a link to the URL in question. I thoug...

odd spireBOT
regal archBOT
regal archBOT
#

@MarkKoz do you think we should continue with implementing this, or would it be too messy?

I'm not sure if this feature is completely necessary. It would be useful if someone accidentally let their channel go dormant to retrieve it to continue, but we may have to set a limit on how many times you can revive.

oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT