#dev-log
1 messages ยท Page 61 of 1
[python-discord/forms-backend] branch deleted: renovate/uvicorn\-0\.x
This function is meant to be used in AoC cog and utility, so having it accept here timezone doesn't have point. When we make this helper function for all cogs, then this may have reason.
[python-discord/forms-frontend] branch deleted: renovate/webpack\-cli\-4\.x
[forms-frontend] Branch renovate/jest\-monorepo was force-pushed to `0f29e9a`
[python-discord/forms-frontend] branch deleted: renovate/react\-router\-dom\-5\.x
[python-discord/forms-frontend] branch deleted: renovate/swc\-core\-1\.x
[python-discord/forms-frontend] branch deleted: renovate/sentry\-monorepo
[forms-frontend] Branch renovate/font\-awesome was force-pushed to `71bbd49`
[python-discord/forms-frontend] branch deleted: renovate/jest\-monorepo
This will return the JSON literal null as the response body.
I think it would be better practice to return a {"status": "okay"} and 200 code or alternative return a normal response with empty body and 204 status.
Returns or deletes a single form given an ID.
Returns or deletes a single form given an ID.
[python-discord/forms-frontend] branch deleted: renovate/font\-awesome
[python-discord/forms-backend] branch deleted: ks123/routes\-parsing
Looks like after our upgrades there are some conflicts in our Yarn lockfile. We should be able to relock the lockfile and resolve them.
f421659 Update App.tsx - jb3
[python-discord/forms-frontend] New branch created: Switch\-suspense\-loader\-to\-RingLoader
HashLoader is TOO SLACK-Y.
We need a better loader.
Introducing: Ring Loader, find it on this page: https://www.davidhu.io/react-spinners/
8598ae3 Update Loading component - jb3
0de49d4 Return some JSON from delete endpoint - ks129
[python-discord/forms-frontend] branch deleted: Switch\-suspense\-loader\-to\-RingLoader
cff916e Update dependency @sentry/react to v5.29.1 - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/sentry\-monorepo
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| @sentry/react | 5.29.0 -> 5.29.1 |
[ |
200 is default.
return JSONResponse({"status": "ok"})
c4a2a3c Remove unnecessary status code - ks129
[python-discord/forms-frontend] branch deleted: renovate/sentry\-monorepo
[python-discord/forms-backend] branch deleted: ks123/form\-delete
d9518d0 Add enhanced status embed workflow - SebastiaanZ
[python-discord/forms-backend] New branch created: sebastiaan/ci/status\-embed
75cfaac Upload artifact with pull request payload - SebastiaanZ
I've added a workflow_run-triggered workflow that reports the status of the forms-backend.yaml workflow using a custom status embed. To make sure we have enough information to generate embeds for pull_request triggers, the forms-backend.yaml file will now upload an artifact with the required information.
f3c5d98 Add enhanced status embed workflow - SebastiaanZ
[python-discord/forms-frontend] New branch created: sebastiaan/ci/status\-embed
9e96b65 Upload artifact with pull request payload - SebastiaanZ
I've added a workflow-run triggered workflow to send an enhanced status embed to our Discord webhook whenever the "Test & Lint" workflow finishes. If the Test & Lint workflow was triggered for a pull_request, it will now upload a build artifact to communicate details about the PR to the status embed workflow.
Connected!
Connected!
Connected!
wget --quiet --header="Authorization: token $GITHUB_TOKEN" -O pull_request_payload.zip "$DOWNLOAD_URL" || exit 2
The cat is unnecessary. jq accepts a filename argument.
DOWNLOAD_URL=$(jq -r '.artifacts[] | select(.name == "pull-request-payload") | .archive_download_url' artifacts.json)
This makes the script safer. e and pipefail I consider essentially for any non-trivial script to get some sane error handling behaviour.
run: |
set -euo pipefail
curl -s -H "Authorization: token $GITHUB_TOKEN" ${{ github.event.workflow_run.artifacts_url }} > artifacts.json
Also consider setting x, which will output each command as its executed for debugging purposes.
The || exit ... will no longer be necessary after commands unl...
Likely a good idea to add these. -S shows errors even when silent. -L follows HTTP 3xx redirects.
curl -sSL -H "Authorization: token $GITHUB_TOKEN" ${{ github.event.workflow_run.artifacts_url }} > artifacts.json
This makes the script safer. e and pipefail I consider essentially for any non-trivial script to get some sane error handling behaviour.
run: |
set -euo pipefail
Also consider setting x, which will output each command as its executed for debugging purposes.
The || exit ... will no longer be necessary after commands unless you want a custom exit code.
I had some inconsistent results with curl while downloading the zip-file that I couldn't quite explain. I'll see if I can dig them up. wget worked reliable every time.
No, if the artifact was not uploaded, it will send an embed for a non-PR workflow. This is just a safeguard as the action currently only supports success/failure/cancelled as workflow conclusions. It's not really important here, but I added it as a safe guard against a future CI redesign suddenly breaking this action unexpectedly.
53c6217 Update dependency @sentry/react to v5.29.0 - renovate-bot
861e3ab Update dependency @swc/core to v1.2.40 - renovate-bot
ee893db Update dependency @types/react-router-dom to v5... - renovate-bot
3cb3a9a Update dependency webpack-cli to v4.2.0 - renovate-bot
eaf3116 Merge pull request #40 from python-discord/reno... - jb3
97879ae Add DELETE method to response route for form re... - ks129
[python-discord/forms-backend] New branch created: ks123/response\-delete
Admin-only route that deletes form response by form ID and response ID in path parameters.
@Skaft Hey, are you still working on this? It's a great idea and I'd love to have it for AoC this year.
82a6007 Add function that allows tasks to sleep until AoC - SebastiaanZ
cb41813 Let status update task sleep until the AoC starts - SebastiaanZ
575fedc Ensure status countdown waits for bot start-up - SebastiaanZ
3e5cff4 Let puzzle notification sleep until AoC starts - SebastiaanZ
d9e98c3 Clarify time_left_until_est_midnight function - SebastiaanZ
[python-discord/sir-lancebot] branch deleted: sebastiaan/advent\-of\-code/refactor\-background\-tasks
Actually, some more comments.
At beginning of this listener this should catch bots instantly, return and then remove check for this from other lines.
Here is no need to make this call 3 lines. Also 2 * 60 * 60 mentioning in comment is also not required, better should be # sleep for two hours.
This should use environment variable
Connected!
Would this be as simple as concatenating the unit tests onto the end of the user's submission and evaluating it in snekbox as one script?
From this end, possibly yes. I have concerns about namespace conflicts but it should be possible to write a test suite in a manner that minimally pollutes the namespace. From the snekbox end, the endpoint may need to be adjusted to allow disabling/changing time and memory limits.
779f59c Replace broken webpack mode config with NODE_ENV - jb3
[python-discord/forms-frontend] New branch created: bugfix/webpack\-config
Replaces the config in webpack.config.js which sets the webpack mode from using a weird env function parameter to fetching from the NODE_ENV environment variable, which will always be one of "development" or "production", or alternative will default to "none".
@MarkKoz we could start every name specific to the test suite with something like __PyDisTest_ (I believe PyCharm does something like this for its debugger), while also checking if the set of names defined in the user's submission is a subset of the ones we expect to run tests with. I don't know off the top of my head what changing those configurations for snekbox would entail but I'll of course wait to see what Akarys says before doing any work towards this.
This works, but can be simplified to
mode: process.env.NODE_ENV,
as undefined will fallback to "none".
[python-discord/forms-frontend] branch deleted: bugfix/webpack\-config
Tested locally, works fine on macOS and I presume you tested it on Windows :smile:
[python-discord/forms-frontend] branch deleted: add\-cross\-env
[python-discord/forms-backend] branch deleted: ks123/response\-delete
Relevant Issues
Description
Reasoning
Screenshots
Additional Details
Did you:
- [ ] Join the Python Discord Community?
- [ ] If dependencies have been added or updated, run
pipenv lock? - [ ] Lint your code (
pipenv run lint)? - [ ] Set the PR to allow edits from contributors?
Thank you for contributing to Python Discord!
Please check out the following documents:
- Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
- Python Discord Contributor Wiki - A set of resources about setting up our services
- Python Discord Code of Conduct - Code of conduct for our commu...
<img width="1677" alt="Screenshot 2020-12-16 at 23 31 35" src="https://user-images.githubusercontent.com/20439493/102419026-d865ff80-3ff6-11eb-9f46-bcf8bd1e8a93.png">
Connected!
We have migrated Python Discord Form issue tracking to Notion.
This specific ticket can be found here.
This discussion will be locked for now, all future conversation should occur in the Notion documents.
If you are an external collaborator who is interested in contributing to forms please shoot me a DM on Discord, joe#6000.
This GitHub discussion has bee...
We have migrated Python Discord Form issue tracking to Notion.
This specific ticket can be found here.
This discussion will be locked for now, all future conversation should occur in the Notion documents.
If you are an external collaborator who is interested in contributing to forms please shoot me a DM on Discord, joe#6000.
This GitHub discuss...
We have migrated Python Discord Form issue tracking to Notion.
This specific ticket can be found here.
This discussion will be locked for now, all future conversation should occur in the Notion documents.
If you are an external collaborator who is interested in contributing to forms please shoot me a DM on Discord, joe#6000.
This GitHub discussion has been transf...
f3369d8 Adds Timestamp Field - HassanAbouelela
[python-discord/forms-backend] New branch created: submission\-timestamp
Closes this notion ticket.
Adds timestamp field to user form responses on model generation.
The model saves an ISO formatted time string to avoid serialization errors. The field is set by the program, even if a user passes the timestamp field.
Current way doesn't work, because this overwrite datetime every time when model instance is created. Instance is also created when document is fetched:
https://github.com/python-discord/forms-backend/blob/main/backend/routes/forms/response.py#L27
Datetime must be provided by submit route. Parser should be @validator('timestamp', pre=True) and this should take datetime and return str.
def set_timestamp(cls, iso_string: t.Optional[str]) -> t.Optional[str]:
You do None check, so iso_string can be None. When this raise ValueError, then no string is returned and this is also None.
1d28213 Update backend/models/form_response.py - HassanAbouelela
Tested locally, works.
[python-discord/forms-backend] branch deleted: submission\-timestamp
Hello @GitHubEmploy,
Since this change doesn't seem to have any linked issues, neither any reasoning about why this change has been made, I'm going to close this PR.
Feel free to add a comment explaining why do you think we should ignore this flake8 error.
Thanks for your interest in our project!
GitHub Actions run 428465789 succeeded.
GitHub Actions run 428476434 failed.
GitHub Actions run 428502483 succeeded.
adcd196 Update dependency webpack to v5.11.0 - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/webpack\-5\.x
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| webpack | 5.10.3 -> 5.11.0 |
[![adopt... |
Hello @GitHubEmploy,
Since this change doesn't seem to have any linked issues, neither any reasoning about why this change has been made, I'm going to close this PR.
Feel free to add a comment explaining why do you think we should ignore this flake8 error.Thanks for your interest in our project!
If you don't change this, the program will become liable for crashing randomly. After this, It will stop, IDK why, but for me when I changed this it stopped. You guys can resear...
e0cd542 Add fakeredis with Lua support to setup.py extras - SebastiaanZ
51a0f0c State that Python 3.9 is supported in setup.py - SebastiaanZ
c6fe0ee Add test for TypeError raised by increment method - SebastiaanZ
5b7a839 Add rescheduling scripts for atomic rescheduling - SebastiaanZ
588eee8 Add version compatibility for Lua unpack function - SebastiaanZ
[python-discord/async-rediscache] branch deleted: release/0\.1\.3
bf8795a Reverse direction of RedisQueue for consistency - SebastiaanZ
b90d525 Add deprecation warning to NamespaceLock - SebastiaanZ
e5dfc7a Add optional value converter that supports errors - SebastiaanZ
b1b6882 Allow loading/registering Lua scripts in Redis - SebastiaanZ
710825d Make increment atomic from a redis perspective - SebastiaanZ
[python-discord/async-rediscache] New branch created: release/0\.2\.0
[python-discord/async-rediscache] New branch created: release/0\.1\.3
[python-discord/forms-frontend] branch deleted: renovate/webpack\-5\.x
It's high time for a new release of Async RedisCache. This new version will bring a number of new features to this package and add a deprecation warning to the usage of NamespaceLock.
New features
Atomic Compound Operations
All compound operations consisting of multiple Redis commands should now be atomic from a Redis perspective due to the usage of a Lua Redis script that adds the missing functionality.
RedisQueue Task Iteration
You can now iterate over a RedisQueue w...
[python-discord/async-rediscache] New tag created: v0\.2\.0\-rc2
58f4d00 Update dependency @sentry/react to v5.29.2 - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/sentry\-monorepo
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| @sentry/react | 5.29.1 -> 5.29.2 |
[ |
[python-discord/async-rediscache] New tag created: v0\.2\.0\-rc3
606ace3 Update Pipfile.lock - SebastiaanZ
234ba48 Install coverage.py with toml for pyproject.toml - SebastiaanZ
[python-discord/async-rediscache] branch deleted: release/0\.1\.3
6b05bae Add test for set_expiry_at with datetime instance - SebastiaanZ
[python-discord/async-rediscache] New tag created: v0\.2\.0\-rc4
bf8795a Reverse direction of RedisQueue for consistency - SebastiaanZ
b90d525 Add deprecation warning to NamespaceLock - SebastiaanZ
e5dfc7a Add optional value converter that supports errors - SebastiaanZ
b1b6882 Allow loading/registering Lua scripts in Redis - SebastiaanZ
710825d Make increment atomic from a redis perspective - SebastiaanZ
[python-discord/forms-frontend] branch deleted: renovate/sentry\-monorepo
[python-discord/async-rediscache] New tag created: v0\.2\.0
Closes this notion ticket.
Important to do note
The webhook links to a frontend URL that displays the form response, which is currently not supported. The frontend URL was added to environment variables in preparation, but the actual viewing URL will have to be added in place of the placeholder once available.
Description
Implements discord webhoo...
I think that we could use something prettier than _user_mention_ here. How about {user}?
Initial review pass. Functionality all looks good and is what I was expecting, nice work!
Not sure how I feel about synchronous validation here. This has the potential to block the worker from handling any requests.
If we can't use asyncio in the validator maybe we should write our own utility for validating and then call that before even creating the webhook model.
I've considered making the string formattable and using it as an f-string, but my fear here is that means we allow anyone to run code inside the message. I don't know who will be allowed to create forms yet, so I didn't want to leave an easy exploit in.
Previously, users wouldn't get the DM from the bot that one usually gets when they verify if a moderator verifies them manually. This PR solves this.
Per @Den4200's request, the response from the bot also mentions the user rather than stating their account name.
30de873 Add PATCH method to form endpoint - ks129
[python-discord/forms-backend] New branch created: ks123/form\-patch
To allow updating form after creation, add PATCH method to form endpoint. Does partial update.
- Removed validation from route.
- Removed field from model.
- Removed dependency.
Oops I think I had formatted it with black by mistake once, so maybe thats why it spans across 3 lines
Needs code to actually write back to the database, but validation looks good.
Our new policy for Pydantic validation errors is HTTP 422, since this will automatically pick up the response structure for pydantic validations.
return JSONResponse(e.errors(), status_code=422)
473f61d Actually update form in DB in PATCH method - ks129
1b82bac Update status code of pydantic errors response - ks129
d1cb420 Runs Initial Validation Asynchronously - HassanAbouelela
5250e54 Adds Missing Annotation - HassanAbouelela
Addressed in d1cb420, but I'll leave this open a little longer in case anyone has a better implementation.
aa322af Update dependency eslint to v7.16.0 - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/eslint\-7\.x
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| eslint (source) | 7.15.0 -> 7.16.0 |
[ |
[python-discord/bot] New branch created: native\-gating
Until Discord.py emits the pending property in member_update events we must use a workaround to watch for users who pass the native gate.
This PR creates an internal set of members who are pending and then eventually removes them once the pending property gets set to false. It is only a temporary solution before the pending event is handled by Discord.py.
Connected!
Connected!
Connected!
We want to DM users some information once they pass the native Discord verification gate. To do this we need to watch for the pending attribute of the user change from True to False.
As of now we have implemented this by keeping track of a list of users who need to receive a welcome DM in a set called pending_members in the Verification cog but we should switch this to use on_member_update(before, after) as soon as discord.py makes this available.
Once a user passes the nati...
fb4d82c Install git in Docker container - jb3
6ed94da Bump discord.py to a unreleased ref - jb3
9e61bed Update verification.py to use on_member_update,... - jb3
[python-discord/bot] New branch created: native\-gating\-two\-user\-boogaloo
- Install git in Docker container
- Bump discord.py to a unreleased ref with pending flag
- Update verification.py to use on_member_update, closes #1330
539aaa2 Update discord.py name in Pipfile - jb3
fb4d82c Install git in Docker container - jb3
6ed94da Bump discord.py to a unreleased ref - jb3
9e61bed Update verification.py to use on_member_update,... - jb3
fe7f7ad Lock Pipfile - jb3
17e1ca3 Fix linting errors - jb3
[python-discord/bot] branch deleted: native\-gating\-two\-user\-boogaloo
Connected!
[python-discord/site] New branch created: metricity\-temp\-fix
eff717b Update verified_at fields to joined_at fields - jb3
Swap out the verified_at column in metricity for joined_at.
This might be temporary while we find a solution for recording accurate verified dates in future, though for now we'll keep it as joined at (hence why the response has also been changed).
Connected!
Connected!
Connected!
I put this currently to stalled and planning status. We can currently discuss, is this good feature and worth implementing, but until Dewikification project is done, nothing can be actually done. Currently resources is stored in HTML article and there is not way to fetch these without writing complex HTML parsers. After Dewikification is done, we are able to build simple API for such data.
Sir Lancebot already have issue about getting copy of bookmark: python-discord/sir-lancebot#341.
[python-discord/bot] New branch created: ks123/sentry
- Bumped Sentry SDK from
0.14to0.19. - Added workflow for creating Sentry releases (used site's one as base).
[python-discord/sir-lancebot] New branch created: ks123/sentry
Relevant Issues
Approved in #dev-core.
Description
- Bumped Sentry SDK version from
0.14to0.19. - Added Redis and aiohttp integrations to Sentry SDK initializing.
- Added workflow for creating Sentry releases (based on site's one).
Did you:
- [x] Join the Python Discord Community?
- [x] If dependencies have been added or updated, run
pipenv lock? - [x] Lint your code (
pipenv run lint)? - [x] Set the PR to **allo...
We should really be initialising the Sentry SDK with the release label. I think @lemonsaurus implemented this on site so we should look there for how the SHA is fetched (we can either use a .git folder or inject the SHA into the Docker build, I think I prefer the latter) and passed into the Sentry SDK.
This can just be sir-lancebot.
release=f"sir-lancebot@{GIT_SHA}"
We concluded that we do not need the AioHttp integration, it is for servers.
826ff04 Remove aiohttp integration from Sentry - ks129
9392a2a Use sir-lancebot instead pydis-sir-lancebot for... - ks129
[python-discord/bot] New branch created: bug/backend/bot\-j8/api\-session\-closed
Fixes BOT-J8.
I've simplified the code for creation sessions upon startup. This was facilitated by dropping support for Bot.clear(), which we never relied on. I go into a bit more detail in the commit messages. I've ran the bot locally and don't have any issues with closed sessions upon startup.
d3492b9 Fix flake8 pre-commit hook running through PyCharm - MarkKoz
[python-discord/bot] New branch created: bug/precommit\-pycharm
Running the hook through PyCharm used to work a long time ago due to a pipenv bug which eventually got fixed. Now it normally fails because PIPENV_IGNORE_VIRTUALENVS is unset. Manually editing the hook and adding os.putenv('PIPENV_IGNORE_VIRTUALENVS', '1') or similar fixes it.
Recently, I've found out about language: system for the hook, which is a better alternative to setting the environment variable. As per https://github.com/pre-commit/pre-commit/issues/1412#issuecomment-61926374...
Thanks, edited my comment to remove the bookmark part.
dc455e8 Remove verification features - jb3
229e94b Version bump to 1.1.0 - jb3
43a963e Merge branch 'master' of github.com:python-disc... - jb3
Updating:
The master branch now runs off of discord.py 1.5.1, and #1196 has been merged.
These strings had getter functions before, I asked moving them from functions to constants.
Implemented Git SHA injecting to container and using release for Sentry SDK initialization
Thanks for your first contribution. Unfortunately, this PR is currently pretty far off the mark. I get the sense you did not attempt to run and test this feature. I understand setting up a dev environment in which to run the bot is tedious at the moment, but I encourage you to try to run it locally to test your changes before pushing them.
Speaking of dev environments, you really should get the pre-commit hook set up at the least. This is written in our contributing guidelines. Please re...
This should be in a separate function which is defined in _message.py and called by move_to_available. The scope of get_available_candidate should remain narrow: to get a candidate channel for the available category and nothing more.
fetch_message doesn't return None; it raises various exceptions which need to be handled.
The default is to get 100 messages. Set the limit to 1.
[python-discord/bot] branch deleted: bug/backend/bot\-j8/api\-session\-closed
Connected!
Sentry Issue: BOT-JD
In the case below, the GitHub rate limit was exceed and a 403 was returned.
TypeError: string indices must be integers
File "bot/exts/utils/utils.py", line 224, in refresh_peps_urls
name = file["name"]
Task exception was never retrieved
future: <Task finished name='Task-10' coro= exception=TypeError('string indices must be integers')>
Sentry Issue: BOT-JE
last_refreshed_peps may be unset if an error was encountered with refresh_peps_urls, such as the rate limit in #1335
TypeError: unsupported operand type(s) for +: 'NoneType' and 'datetime.timedelta'
File "discord/ext/commands/core.py", line 85, in wrapped
ret = await coro(*args, **kwargs)
File "bot/exts/utils/utils.py", line 244, in pep_command
if not (pep...
477af4e Add GitHub API key to config as environment var... - ks129
de3dd22 Move PEP related functions and command to own cog - ks129
d9fed58 Set last PEPs listing at beginning of function - ks129
b7ab159 Make last PEPs listing refresh non-optional - ks129
4527f9a Log warning and return early when can't get PEP... - ks129
[python-discord/bot] New branch created: ks123/pep
Note: Before merging this PR, DevOps team should add GITHUB_API_TOKEN environment variable.
Should be merged fast, PEP command is broken currently because of rate limits.
- Moved PEP related utilities and command to own cog.
- Make last refresh non-optional.
- Catch non-200 responses.
- Add GitHub token.
- Closes #1335
- Closes #1336
Increment and decrement now return the new value in version 0.3.0.
Could you explain your idea about generics for the type? The types supported by the framework are specific: By supporting generics on the various Redis types, we may give the impression that we support storing generic types. We don't, we only support the four specific types listed in the alias and we use the aliases to indicate which specific types we expect for the various arguments (and return types).
Now, my experienc...
[python-discord/site] New branch created: ks123/sentry
- Bumped Sentry SDK from 0.14 to 0.19.
- Inject Git SHA to container using build arguments.
- Use Git SHA from environment instead from GitPython package.
- Removed GitPython package.
- Added
.gitdirectory back to.dockerignore.
[python-discord/snekbox] New branch created: ks123/sentry
Added injecting Git SHA to container using build arguments. On SDK initialization this uses this SHA for release defining. Also added workflow for creating releases.
Connected!
I didn't realize the native gate rollout was imminent when making this PR. I'll submit a new version that checks if the user is pending, and if not, assigns and subsequently removes the developer role. I'll probably also rename the function accordingly.
What are the consequences of making a sentry release for a SHA that doesn't go into production (e.g. cause a build failed)? Does it not matter?
@MarkKoz So much how I understand by reading docs, this doesn't affect anything. This will be just empty release then.
[python-discord/snekbox] branch deleted: ks123/sentry
Connected!
So the most probable cause for this to happen would be if the webhook feature was enabled, but the webhook link wasn't entered/was removed from the website. This might happen if we for example have an on/off toggle for the hooks, and a separate field to enter the URLs.
What this means, is that it is probably not an error, rather the form is just waiting on a URL to be setup. Ideally, this would be some sort of warning icon on the frontend. If we want to alert the user to an error happening...
96c0827 Update dependency @emotion/react to v11.1.3 - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/emotion\-monorepo
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| @emotion/react | 11.1.2 -> 11.1.3 |
[ |
[python-discord/forms-frontend] branch deleted: renovate/eslint\-7\.x
[python-discord/forms-frontend] branch deleted: renovate/emotion\-monorepo
Gotcha, the feature and webhook URL will most likely be separate fields (e.g. enable webhook feature, then a text box is displayed).
We can probably validate on the frontend that there is not a point where the webhook feature is enabled when no webhook is set.
what if I check if get_channel or get_role returns None, then I unload the cog with appropriate logging instead of fetch_channel raising an error and unloading the cog?
We must be ready that channels or role(s) is not in cache, so we need to fetch them.
Description
IGDB shut down APIv3 in October 2020. games command is currently built to use v3 of API, but now, when URLs is gone, this command is currently not usable. Command must be migrated APIv4, about to what migrating can be read https://api-docs.igdb.com/#upgrading-to-v4-from-v3.
Steps to Reproduce
When you have API key of IGDB, then genres refreshing task fails, because API not found, also command fails.
Expected Behaviour
Should successfully refresh genres an...
debug = getenv('BOT_DEBUG', False) # Enable if you do not want to limit the commands to October or if you do not want
[python-discord/bot] branch deleted: ks123/sentry
Let's take this as an opportunity to change from the pydis-site prefix to site
Connected!
As python-discord/django-simple-bulma#46 is closed, I'm moving this issue out from stalled status.
e50af0a Update typescript-eslint monorepo to v4.11.0 - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/typescript\-eslint\-monorepo
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| @typescript-eslint/eslint-plugin | 4.10.0 -> 4.11.0 |
[:
... user_id: str
...
>>> MyObject(user_id="1")
MyObject(user_id='1')
>>> MyObject(user_id=1)
MyObject(user_id='1')
We don't need this comment, the data is already a string when it comes from Discord.
Providing you agree with my comment on the validator, this import is not required.
from pydantic import BaseModel
Excellent work, well done!
d0e19ef Remove unnecessary comment about ID - ks129
GitHub Actions run 436460183 succeeded.
GitHub Actions run 436460209 succeeded.
GitHub Actions run 436461315 failed.
GitHub Actions run 436462004 succeeded.
Re-approving for policy bot!
[python-discord/forms-backend] branch deleted: discord\-webhook
[python-discord/forms-frontend] branch deleted: renovate/typescript\-eslint\-monorepo
56279e2 Bump node-notifier from 8.0.0 to 8.0.1 - dependabot[bot]
[python-discord/forms-frontend] Pull request opened: #50 Bump node\-notifier from 8\.0\.0 to 8\.0\.1
Bumps node-notifier from 8.0.0 to 8.0.1.
Changelog
Sourced from node-notifier's changelog.
v8.0.1
fixes possible injection issue for notify-send
Commits
5d62799 v8.0.1
0c4a80d chore: adds changelog
f5a7bc6 fix: test cases
b9d148d patch: fixes possible injection issue for notify-send
See full diff in compare view
[, which means that it's mature enough for us to start looking into upgrading the Python version of sir-lancebot. We'll obviously have to make sure all our dependencies support 3.9 and everything works well, but it would be nice to use the new language features.
Reasoning
It's better to keep up with Python version, adjusting our code base as required, than making a major leap in major versions with a potential more sizeable mi...
b1afa49 Update dependency @fortawesome/react-fontawesom... - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/font\-awesome
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| @fortawesome/react-fontawesome | 0.1.13 -> 0.1.14 |
[",
If the constants are moved outside the class, this should be renamed.
PEPS_LISTING_API_URL,
I feel like these constants should be outside the class, next to ICON_URL.
@digasred Hello, your comment is not related with this issue, what is also already closed. Please open new issue instead.
b2911b9 Fix Seperator Bug - HassanAbouelela
Besides this one line in the ALTERNATE_VERIFIED_MESSAGE docstring that may need to be changed, everything looks good to me.
It may just be me, but I feel this would be "easier" to read for more users by saying
You are now verified!
12cbfe7 (Aliases, discord.py 1.3.x Migration): Replaced... - ks129
61a93c1 (Snekbox, discord.py 1.3.x Migration): Replaced... - ks129
88b4c72 (Patches, discord.py 1.3.x Migration): Removed ... - ks129
1a14f4f (Off-Topic Names, discord.py 1.3.x Migration): ... - ks129
a4a4b98 (Reddit, discord.py 1.3.x Migration): Replaced ... - ks129
I won't have time to finish this, if someone feels up to the task, feel free to continue the work here!
I made that change under the pretense that we'd still have bot verification. Does anyone actually get the alternate verified message anymore?
This cog would better fit into the info directory.
Moved PEP cog to info extensions group.
477af4e Add GitHub API key to config as environment var... - ks129
de3dd22 Move PEP related functions and command to own cog - ks129
d9fed58 Set last PEPs listing at beginning of function - ks129
b7ab159 Make last PEPs listing refresh non-optional - ks129
4527f9a Log warning and return early when can't get PEP... - ks129
[python-discord/bot] branch deleted: ks123/pep
Connected!
32908eb Update dependency @types/node to v14.14.16 - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/node\-14\.x
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| @types/node | 14.14.14 -> 14.14.16 |
[ |
477af4e Add GitHub API key to config as environment var... - ks129
de3dd22 Move PEP related functions and command to own cog - ks129
d9fed58 Set last PEPs listing at beginning of function - ks129
b7ab159 Make last PEPs listing refresh non-optional - ks129
4527f9a Log warning and return early when can't get PEP... - ks129
When user have pending True, I think this means that user isn't already verified?
I think you're right--this should probably be if not user.pending.
That will raise Forbidden on edit.
@MarkKoz I'm so sorry, and yeah I tried to setup precommit, doesn't seem to work. I'll try again and fix all of the things you mentioned.
fc1f7ac User gets the bot DM when verified via !verify. - swfarnsworth
2b09d73 Responses from the bot mention the user. - swfarnsworth
2b73df6 Merge branch 'master' of https://github.com/pyt... - swfarnsworth
ce46567 Rewrite !verify to account for new native-gat... - swfarnsworth
e565515 Merge branch 'master' of https://github.com/pyt... - swfarnsworth
[python-discord/bot] branch deleted: swfarnsworth/developer\_command
Connected!
so people can type hint a specific redis cache (e.g., say "this RedisCache maps str -> str only, not all allowed redis types")?
Yes, it would give people the option of specifying which of all redis-compatible types a specific RedisCache is intended to deal with.
What if someone assumes that they'd now be able to add arbitrary types, such as a user-defined type, because they can type hint it using the generic?
Based on my understanding of the specification of typing.TypeVar, we ...
I have seen a lot of people come for help to the python discord with the error JSONDecodeError: Expecting value: line 1 column 1 (char 0). Which really is a simple fix. To speed up the helping progress I thought having it as a tag would help.
Feel free to suggest any rewording/renaming and I will be happy to comply.
337ccc3 Update dependency webpack-cli to v4.3.0 - renovate-bot
[python-discord/forms-frontend] New branch created: renovate/webpack\-cli\-4\.x
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| webpack-cli | 4.2.0 -> 4.3.0 |
