#dev-log

1 messages · Page 58 of 1

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20201112.1 succeeded

Requested by

GitHub

Duration

00:01:29

Build pipeline

Seasonal Bot

#

Build 20201112.2 succeeded

Requested by

GitHub

Duration

00:01:29

Build pipeline

Seasonal Bot

ebon magnetBOT
#

Build 20201112.3 succeeded

Requested by

GitHub

Duration

00:02:02

Build pipeline

Seasonal Bot

regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
MrHemlock
[python-discord/bot] branch deleted: Hemlock/voice\-gate\-ping
ebon magnetBOT
#

Build 20201112.3 failed

Requested by

GitHub

Duration

00:00:47

Build pipeline

Bot

ebon magnetBOT
#

Build 20201112.3 failed

Requested by

GitHub

Duration

00:00:40

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20201113.2 failed

Requested by

GitHub

Duration

00:00:47

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20201113.3 succeeded

Requested by

GitHub

Duration

00:04:33

Build pipeline

Bot

regal archBOT
north knotBOT
oak estuaryBOT
ebon magnetBOT
#

Build 20201113.4 succeeded

Requested by

GitHub

Duration

00:06:17

Build pipeline

Bot

regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New branch created: sebastiaan/features/move\-ci\-to\-github\-actions
regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] branch deleted: sebastiaan/features/move\-ci\-to\-github\-actions
#
SebastiaanZ
[python-discord/bot] New branch created: sebastiaan/features/move\-ci\-to\-github\-actions
#
SebastiaanZ
[python-discord/bot] Pull request opened: #1284 Migrate CI Pipeline to GitHub Actions

I've migrated our Azure CI Pipeline to GitHub Actions. While the general workflow is the same, there are a few changes:

  • flake8 is no longer run by pre-commit, but rather by a separate action that adds annotations to the GH Action results page.

  • As we no longer have need for xml-formatted coverage files, the xmlrunner for unittest has been removed as a dependency. Instead, we now publish our coverage results to coveralls.io. Each Actions run will echo a uni...

ebon magnetBOT
#

Build 20201114.1 succeeded

Requested by

GitHub

Duration

00:03:10

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New review comment on pull request #1284: Migrate CI Pipeline to GitHub Actions

I was a bit torn on this, but I agree that it should probably in there. It is currently persisted, the caching process will run just before the job clean-up steps are run, but it's better to have it where all our other dependencies are.

The reason I did not do it was because this is only needed in CI; there's no need to install or require this dependency in local dev environments. However, keeping all dependencies in one spot is also valuable and it's a relatively small package anyway.

#
SebastiaanZ
[python-discord/bot] New review comment on pull request #1284: Migrate CI Pipeline to GitHub Actions

Not sure, the expression I've used here was the recommended expression for steps that need to run conditionally on the cache being restored in the README for the cache action.

I think the documentation implies that if you have no explicit "status" check function, it will use success() by default. The if we have does not use a status function, so it should also depend on the success() function result by default.

...

regal archBOT
regal archBOT
regal archBOT
regal archBOT
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20201114.1 succeeded

Requested by

Joseph Banks

Duration

00:04:40

Build pipeline

Site

regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] New branch created: sebastiaan/backend/move\-ci\-to\-gha
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] Pull request opened: #514 Migrate to GitHub Actions and GHCR

We are currently migrating our backend to a Kubernetes cluster. As this requires changes to our CI anyway, this is a good time to also migrate our CI Pipeline to GitHub Actions and start using the GitHub Container Registry to push our builds to.

Changes compared to the old situation:

  • flake8 linting errors will now show up as GH Actions annotations
  • containers are tagged with both "latest" and a short commit SHA

Note: This version of the workflow still pushes to DockerHub **in add...

regal archBOT
regal archBOT
#
jerbob
[python-discord/seasonalbot] New branch created: feature/non\-persistence
ebon magnetBOT
#

Build 20201114.1 failed

Requested by

GitHub

Duration

00:01:10

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20201114.2 failed

Requested by

GitHub

Duration

00:01:20

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20201114.3 failed

Requested by

GitHub

Duration

00:01:15

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20201114.4 succeeded

Requested by

GitHub

Duration

00:01:24

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20201114.5 succeeded

Requested by

GitHub

Duration

00:01:19

Build pipeline

Seasonal Bot

regal archBOT
#
lemonsaurus
[python-discord/seasonalbot] branch deleted: sebastiaan/backend/move\-ci\-to\-gha
north knotBOT
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
north knotBOT
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
#
MarkKoz
[python-discord/snekbox] New branch created: feat/deps/py\-3\.9
ebon magnetBOT
#

Build 20201114.1 failed

Requested by

GitHub

Duration

00:02:46

Build pipeline

Snekbox

regal archBOT
ebon magnetBOT
#

Build 20201114.2 succeeded

Requested by

GitHub

Duration

00:02:47

Build pipeline

Snekbox

regal archBOT
#
SebastiaanZ
[python-discord/site] New branch created: sebastiaan/backend/move\-ci\-to\-gha
regal archBOT
regal archBOT
#
lemonsaurus
[python-discord/site] New branch created: get\_rid\_of\_uwsgi
ebon magnetBOT
#

Build 20201114.2 failed

Requested by

GitHub

Duration

00:01:19

Build pipeline

Site

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20201114.3 failed

Requested by

GitHub

Duration

00:02:55

Build pipeline

Site

regal archBOT
#
lemonsaurus
[python-discord/seasonalbot] branch deleted: feature/non\-persistence
ebon magnetBOT
#

Build 20201114.4 succeeded

Requested by

GitHub

Duration

00:02:23

Build pipeline

Site

north knotBOT
regal archBOT
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
night lilyBOT
#
SeasonalBot

Connected!

#
SeasonalBot

Connected!

regal archBOT
#
jb3
[python-discord/seasonalbot] New branch created: kubernetes\-deploy
#
jb3
[python-discord/seasonalbot] branch deleted: kubernetes\-deploy
north knotBOT
regal archBOT
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
#
lemonsaurus
[python-discord/site] branch deleted: get\_rid\_of\_uwsgi
ebon magnetBOT
#

Build 20201114.5 failed

Requested by

Leon Sandøy

Duration

00:03:01

Build pipeline

Site

regal archBOT
#
lemonsaurus
[python-discord/site] branch deleted: sebastiaan/backend/move\-ci\-to\-gha
regal archBOT
north knotBOT
night lilyBOT
#
SeasonalBot

Connected!

#
SeasonalBot

Connected!

regal archBOT
oak estuaryBOT
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] New branch created: sebastiaan/backend/apply\-proper\-check\-name
#
SebastiaanZ
[python-discord/seasonalbot] New branch created: sebastiaan/backend/remove\-dockerhub\-push
#
jb3
[python-discord/site] New branch created: kubernetes\-deployment
#
lemonsaurus
[python-discord/seasonalbot] branch deleted: sebastiaan/backend/remove\-dockerhub\-push
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
#
jb3
[python-discord/site] branch deleted: kubernetes\-deployment
ebon magnetBOT
#

Build 20201115.1 succeeded

Requested by

GitHub

Duration

00:04:26

Build pipeline

Bot

regal archBOT
#
gustavwilliam
[python-discord/seasonalbot] New branch created: gurkancount
#
gustavwilliam
[python-discord/seasonalbot] Pull request opened: #518 Add gurkancount command

Description

This command loops through the display names of all members and checks which ones contain "gurkan".

Important note:

This enables member intents, which means that it'll have to be enabled on Discord Developers Portal, if it isn't already. It also means that we'll be tracking member intents.

This is needed, since the display names of guild members will be checked.

Screenshots

Here is the new command:

...

#
Numerlor
[python-discord/bot] New review comment on pull request #1014: Doc improvements

This is used to allow the bot to do other stuff during the fully synchronous parsing while keeping the load a bit lighter since it's not a priority.
Because we await above we could remove this, causing the bot to take all available resources and maybe (?) slowing down some other parts of it, but the whole queue would be parsed considerably faster
It could also be moved into a thread but I felt like it'd complicate the code a bit too much while this is sufficient

I'm not too sure on how p...

#
Numerlor
[python-discord/bot] New review comment on pull request #1014: Doc improvements

Should we attempt to go deeper in the handling? Currently in case we get a long tag like a div or ul with different p tags we'll most probably just skip it while we would be able to extract the p tags and split them properly but because we'd be keeping the end of the tags out it'd need some per tag behaviour complicating the implementation even more (open to suggestions here as I feel like it is a bit of a mess)

regal archBOT
#
gustavwilliam
[python-discord/seasonalbot] New review comment on pull request #518: Add gurkancount command

Looks much better. I didn't quite like having all of that on a single line nor creating two variables for it, so this solution looks better in some sense.

The only real reason that having two variables would be worth considering is if we would like to add some feature to do additional filtering in the future. That can be added when it becomes relevant, though, so this change looks good to me.

#
gustavwilliam
[python-discord/seasonalbot] New comment on pull request #518: Add gurkancount command

That would be really interesting. Sadly, it would interfere with the emojicount command. If we were to ever do that (which would be super cool), we'd have to turn emoji count into a command + subcommand or something similar.

Either way, if we keep in within the scope of this PR, I wouldn't mind adding an optional argument with the string to search for. I think keeping the command name gurkancount would also be slightly funny and work well.

Then again, do we want people to search for any...

#
Den4200
[python-discord/seasonalbot] New comment on pull request #518: Add gurkancount command

what would be really cool is if you could hijack any command that ended with count , so that .gurkancount and .lemoncount and .vescount would all just work.

This is a cool idea, I like it.

That would be really interesting. Sadly, it would interfere with the emojicount command. If we were to ever do that (which would be super cool), we'd have to turn emoji count into a command + subcommand or something similar.

This shouldn't be an issue, since the logic would have to be...

north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] New comment on pull request #518: Add gurkancount command

One thing to consider is that SeasonalBot currently does not have the "members intent", which means that it also does not receive those events from Discord. Enabling the intent does increase the resource usage of Seasonal Bot (although the "presences intent" is probably way more heavy). I think I'm just a bit confused as to why we'd want this count command and if it's worth the additional load it will have on our back-end.

regal archBOT
regal archBOT
#
gustavwilliam
[python-discord/seasonalbot] New comment on pull request #518: Add gurkancount command

@SebastiaanZ yes. That's an important question to ask. I don't know exactly how much that would cost to have, but is it something that we have resources for? While we shouldn't add commands just because we can, I also think it would be a fun command to have — which is an important part for SeasonalBot.

As for the reasoning behind having a command like this, I think there's an interest in counting the amount of members with "gurkan" in their display names. You have probably noticed that the c...

#
kwzrd
[python-discord/seasonalbot] New comment on pull request #518: Add gurkancount command

We do have resources for it, the question is more whether we want to use them this way. Before intents rolled out, every bot was subscribed by default. When I was working on #478, core dev consensus seemed to be that we'd rather not have the intent if feasible. I'm impartial, but I don't know if this is a feature that would justify adding the intent, if we don't otherwise want it. If it's well implemented, generic and would be a useful utility to e.g. mods, we can also consider adding it to t...

regal archBOT
regal archBOT
regal archBOT
#
jb3
[bot:master] 10 new commits

4d4dfe4 Migrate CI Pipeline to GitHub Actions - SebastiaanZ
8588d2d Add CI dependency coveralls to our Pipfile - SebastiaanZ
5d50adf Stop Checkout Actions from persisting credentials - SebastiaanZ
135ecf5 Set flake8 action checkName to correct value

  • SebastiaanZ
    7f3dee1 Remove codeql analysis as it had little effect - SebastiaanZ
#
jb3
[python-discord/bot] branch deleted: sebastiaan/features/move\-ci\-to\-github\-actions
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] New branch created: sebastiaan/backend/test\-ci\-linting
regal archBOT
#
MarkKoz
[python-discord/snekbox] branch deleted: feat/deps/py\-3\.9
regal archBOT
#
jb3
[python-discord/bot] New branch created: kubernetes\-deploy
regal archBOT
#
HassanAbouelela
[python-discord/bot] New comment on issue #1282: Add ability for mods to shut down a voice channel

I'm working on implementing this, and want thoughts on implementation. Right now the command only mutes the channel it was invoked in, but there would have to be some form of channel parsing for VC. I implemented a prototype for that (see branch), but I enabled it for text channels too.

Should text channels fall under this modification or not? On a more specific implementation detail, I have it notifying in the invocation ch...

regal archBOT
regal archBOT
#
gustavwilliam
[python-discord/bot] New branch created: help\-channel\-msg
regal archBOT
#
gustavwilliam
[python-discord/bot] Pull request opened: #1287 Updated available help channel embed

Closes parts of python-discord/organisation#305.

This new embed is meant to be clearer and more user friendly, as well as providing more easy to understand tips for asking better questions.

Screenshots

This is the previous version:

This is the new version:

Reasoning

The green color of the embed — which is the same as one of the colors used in SeasonalBot — is meant to provide a clear feeling of the channel being available. The current grey color doesn’t give that. Th...

north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] New branch created: sebastiaan/backend/fix\-flake8\-check
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] Pull request opened: #520 Fix flake8 check in CI and separate Lint and Build jobs into separate workflows

This PR makes two changes to our CI:

1. Instead of using a predefined action, we now use flake8 directly to generate annotations for a CI check

Unfortunately, the flake8 action we were using from the marketplace required us to use the pull_request_target event, which runs in the context of the target repository to protect secrets. However, this also meant that flake8 would run on files already merged into our master branch, not the actual changes made in teh PR! That's obviousl...

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New comment on issue #998: Send message contents in DMs for messages deleted by auto mod

Let's consider adding a word or character count threshold. Really short messages aren't worth relaying. This may alleviate concerns of DMs being annoying.

webhooks removers, and antimalware are the ones that will benefit the most

I agree, though in the case of antimalware, attachments without any message written should be ignored.

everyone ping filter and invite filters

Maybe for the ping but I don't think it's necessary for invites.

Then keep the message around through r...

#
MarkKoz
[python-discord/bot] Pull request review submitted: #1275 Parse URL and match domain name in filtering to avoid false positives

This isn't too accurate because not all URLs posted by users will include the HTTP scheme. Unfortunately, this will cause problems with urllib even if the URL regex is adjusted:

Following the syntax specifications in RFC 1808, urlparse recognizes a netloc only if it is properly introduced by ‘//’. Otherwise the input is presumed to be a relative URL and thus to start with a path component.

Furthermore, the netloc may include a port and/or a subdomain e.g. www.cwi.nl:80. Some filte...

regal archBOT
regal archBOT
#
MarkKoz
[bot:feat/global\-bot] 290 new commits

1447327 Improve !pep command - ks129
355c1bd Merge branch 'master' into pep-improvisations - ks129
6b6d2a7 Moved async_cache decorator from Doc cog fi... - ks129
bf26ad7 Created new task in Utils cog: refresh_peps_... - ks129 [a2f0de1](https://github.com/python-discord/bot/commit/a2f0de1c34dc320f4ee61d64a33b0d866bf41af2) Refactor pep` command, implement caching - ks129

#
MarkKoz
[python-discord/bot] branch deleted: feat/global\-bot
#
SebastiaanZ
[python-discord/snekbox] New branch created: sebastiaan/backend/migrate\-ci\-to\-github\-actions
regal archBOT
regal archBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
#
SebastiaanZ
[python-discord/snekbox] New branch created: sebastiaan/backend/cache\-docker\-images
regal archBOT
#
ks129
[python-discord/seasonalbot] Pull request opened: #521 Redis storage, JSON \-> Redis migration, remove branding manager, improve docker\-compose\.yml

Relevant Issues

All these things got approved in server.

Description

Redis storage

Implemented async_rediscache to bot in order to allow replace JSON with Redis. Added following env variables: REDIS_HOST (default redis.default.svc.cluster.local), REDIS_PORT (default 6379), REDIS_PASSWORD and USE_FAKEREDIS (default false).

Moved candies and hacktoberstats cogs to use Redis instead JSON. Monstersurvey need bigger refactor.

Docs should be updated abo...

regal archBOT
#
gustavwilliam
[python-discord/branding] New branch created: tick\-emoji
#
gustavwilliam
[python-discord/branding] branch deleted: tick\-emoji
#
gustavwilliam
[python-discord/branding] New branch created: swoopy\-icon
#
gustavwilliam
[python-discord/branding] branch deleted: swoopy\-icon
regal archBOT
regal archBOT
oak estuaryBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
#
gustavwilliam
[python-discord/branding] New comment on issue #75: Cowboy lemoji, please\.

@saiTama-max Thanks for giving this a shot. I'm not a huge fan of how the hat looks. It's not symmetrical and it's closer to one eyebrow than the other. Are we sure we even want leaves under the hat? Just some things to keep in mind.

Also, in the future, try to get assigned to the issue before working on it. Most importantly, it signals that someone is working on it and ensures that multiple people aren't at the same time. Do you want me to assign you to this issue?

regal archBOT
regal archBOT
regal archBOT
#
lemonsaurus
[python-discord/branding] Issue opened: #101 Clean up and vectorize new bot icons

I've created three rough bot icons for the new bots. I'm wondering if someone would like to polish them a little, turn them into vector, but stay within the same overall style. Simplification is allowed, if it makes sense to do so, and little pydisifications would also be fun to see.

Here are the icons as raster pngs.

Sir Lancebot

This one is pretty rough - the lines are not very sharp and the tail is a complete disaster.
![image](https://user-images.githubusercontent.com/2098517/9...

regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/snekbox] Pull request opened: #79 Migrate to GitHub Actions and GitHub Container Registry

I've migrated the build pipeline to GitHub Actions and changed the container registry to GitHub Container Registry. In the process, I've also made some changes to our docker setup and caching.

  • Note: This PR does not yet take #64 into account. I will update that PR later.

  • Note II: We need to get to a mergeable state sooner rather than later, as this is currently blocking our migration to the Kubernetes cluster.

Most notable aspects of this PR:

We are now using a ...

regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New branch created: sebastiaan/backend/improve\-actions\-workflow
#
SebastiaanZ
[python-discord/bot] Pull request opened: #1290 Ensure flake8 actually lints pull requests

Unfortunately, the way I'd configured our workflow meant that flake8 was running in the context of the target repository, which means it was linting our master branch without the changes introduced by the PR. This is obviously a bit useless when it comes to guarding our codebase from linting errors. That's why I've changed the way we run flake8.

I've also decided to split the workflow file in two separate ones: one to lint/test and one to build/deploy.

Finally, I've updated the dock...

#
MarkKoz
[python-discord/snekbox] New review comment on pull request #79: Migrate to GitHub Actions and GitHub Container Registry

I think what is restored from the partial cache hit is written to the new cache created when the workflow ends, since the cache action just saves whatever is in a particular directory. Maybe running docker system prune -f before ending the workflow will avoid this problem. Hopefully that will not clear stuff related to the images that were just built. However, I think the -a option might (how would it know which images are "in use").

regal archBOT
#
SebastiaanZ
[python-discord/snekbox] New branch created: sebastiaan/backend/test\-repository\-caching
#
SebastiaanZ
[python-discord/snekbox] New review comment on pull request #79: Migrate to GitHub Actions and GitHub Container Registry

That seems to work well. I think it may lead to faster builds in some situations and longer builds in some others, where the latest image is a bit out of sync with cache-invalidating changes made in a feature branch. However, if that's not the cache, this seems to be faster than using the local cache option.

A fully non-cached build took 3m7s; a fully cached build took 1m45s, using just the repository cache. I think we should just be happy with that and not worry about the local cache th...

#
MarkKoz
[python-discord/snekbox] New review comment on pull request #79: Migrate to GitHub Actions and GitHub Container Registry

One thing I forgot is that when it restores a cache from master, the new cache it writes will be scoped locally rather to master. Therefore, PRs will only bloat caches for PRs. Since PRs don't tend to have very long lifetimes, bloating shouldn't be as bad. It's still not ideal, since every new commit a PR makes will add new layers to the cache without getting rid of layers specific to previous commits. However, I imagine the layers will be small (basically just the source code copy step) unle...

regal archBOT
#
SebastiaanZ
[python-discord/site] New branch created: sebastiaan/backend/fix\-flake8\-in\-ci
#
lemonsaurus
[python-discord/snekbox] branch deleted: sebastiaan/backend/migrate\-ci\-to\-github\-actions
#
lemonsaurus
[python-discord/snekbox] New branch created: lemon/kubernetes\_manifest
#
SebastiaanZ
[python-discord/bot] branch deleted: sebastiaan/backend/improve\-actions\-workflow
#
jb3
[python-discord/snekbox] branch deleted: lemon/kubernetes\_manifest
#
lemonsaurus
[python-discord/site] branch deleted: sebastiaan/backend/fix\-flake8\-in\-ci
#
jb3
[python-discord/bot] branch deleted: kubernetes\-deploy
oak estuaryBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
#
lemonsaurus
[python-discord/seasonalbot] branch deleted: sebastiaan/backend/fix\-flake8\-check
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
regal archBOT
oak estuaryBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New branch created: sebastiaan/backend/fix\-deploy\-stage
regal archBOT
#
SebastiaanZ
[python-discord/bot] branch deleted: sebastiaan/backend/fix\-deploy\-stage
oak estuaryBOT
regal archBOT
regal archBOT
#
bast0006
[python-discord/bot] Issue opened: #1292 Filter functionality for emoji\-spam messages

Now that someone's figured out you can cause havok by dumping massive amounts of emojis into a channel, we need a filter to automatically manage this ASAP. Detection should be fairly simple, a very high emoji count is required for the effect (>20/message) but emoji variance is not required.

Tangentially: This is also likely related to a discord update that went out that has slowed the emoji loading process recently.

I think we can safely filter out and autodelete high emoji messages wi...

regal archBOT
regal archBOT
#
janine9vn
[python-discord/seasonalbot] Issue opened: #522 Advent of Code Updates for 2020

Description

Advent of Code (AoC) will be run a bit differently this year on PyDis, so some changes are required in the code itself. We'll have 3 leaderboards in the server, a global leaderboard, "private" PyDis leaderboard, and then a staff leaderboard. The current code only allows for the global and private PyDis leaderboard.

Proposed Implementation

  • The leaderboard commands should provide the information for the staff leaderboard if triggered in the staff AoC channel. It shou...
regal archBOT
regal archBOT
regal archBOT
#
fisher60
[python-discord/seasonalbot] Issue opened: #523 Add "Wonder Twins" inspired command

Description

A fun command that assembles a phrase which is an object to transform into. Similar to the old "Wonder Twins" cartoon. I.e "Form of a bucket of water."

Reasoning

I was recently watching a compilation of all the wonder twins' transformations and the video is hilarious. I believe users could have some fun seeing all of the combinations of (usually useless) water-themed objects a person could transform into if they were a wonder twin.
![image](https://user-images.github...

#
fisher60
[python-discord/seasonalbot] New branch created: feature/wonder\-twins\-command
#
fisher60
[python-discord/seasonalbot] Pull request opened: #524 feature/add wonder twins command

This commit implements a wonder twins inspired command. This is a purely fun command that uses real transformations from the show to make random new transformations. The yaml is all hand transcribed from the actual show.

Relevant Issues

Closes: #523

Description

I added a wonder_twins cog as well as the yaml of quotes from the show.

Reasoning

It has been implemented so that users can quickly use the command to get a random, hopefully funny, transformation inspired by ...

north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/snekbox] New branch created: sebastiaan/bug/stdout\-flood
#
gustavwilliam
[python-discord/branding] New comment on issue #83: Organising labels

This have been actioned. All currently existing labels were migrated, so all previously set labels are simply updated to work with the new system, without removing the old ones.

The new labels are live. If you'd like to, feel free to give it another look and see if there's anything we want to adjust and simply change it. If there's something you'd like us to discuss further, you're free to open another issue with one of the new labels.

Let's try to update the other repos as well.

regal archBOT
#
gustavwilliam
[python-discord/branding] New branch created: okhand
regal archBOT
#
Akarys42
[python-discord/branding] branch deleted: okhand
regal archBOT
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
MrHemlock
[bot:master] 5 new commits

902b5fa Install emoji package for emojis filtering - ks129
29a22b4 Catch Unicode emojis in emojis filtering rule - ks129
14734fd Cover Unicode emojis catching as antispam rule ... - ks129
fb7ca02 Merge branch 'master' into emojis-filter - MrHemlock
c84f312 Merge pull request #1293 from ks129/emojis-filter - MrHemlock

oak estuaryBOT
regal archBOT
regal archBOT
regal archBOT
#
MarkKoz
[python-discord/snekbox] New review comment on pull request #81: Limit STDOUT to prevent OOM events in container

this increases the uncertainty about the size in bytes we're reading due to UTF-8 characters being up to 4 bytes long.

Well, even being 40 KB over is not a big deal.

This is the default value for Popen due to the negative default value for bufsize

That was worded poorly. I mean that when you read from the stream, use read(io.DEFAULT_BUFFER_SIZE) or set the bufsize to the same number you use to read from the stream. Not sure if it really makes a difference.

#
SebastiaanZ
[python-discord/snekbox] New comment on pull request #81: Limit STDOUT to prevent OOM events in container

Just to double check, there will always be a front-end indication of truncation since 1 MB is 250,000 - 1 million characters, but pastebin has a limit of 100,000 characters or 0.1 - 0.4 MB. Is this correct?

That is correct. My idea was that I did not want to go lower than the pastebin limit, so I used a safe margin. Now I'm thinking that we could also count the number of characters we consume and limit that to, say, 99,900. That means we can always upload the results. We could even inclu...

regal archBOT
regal archBOT
#
gustavwilliam
[python-discord/seasonalbot] Issue opened: #525 Hard coded bot name when connecting

Description

The bot sends "SeasonalBot" — a hardcoded string for the bot name — in the dev log, when connecting. This use the username of the bot instead.

Steps to Reproduce

(Re)start the bot and check the "connected" message sent in your dev log. The interesting part is the author name.

Expected Behaviour

I would expect either the username or display name of the bot to be used.

Actual Behaviour

The author part on top will use the hardcoded string "SeasonalBot" as the name....

regal archBOT
#
lemonsaurus
[python-discord/seasonalbot] New branch created: redis\-persist
night lilyBOT
#
SeasonalBot

Connected!

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] Pull request opened: #1294 Help Channel Refactor

Functions were split into separate modules because the single module was monolithic. What remains in the cog is too interconnected to refactor any further (relying on a bunch of shared state like queues).

There isn't much else to go into here since the changes mostly consist of moving things without further modification. There are a few exceptions like 840348b642f2d197e15d98a823d6e431b0a65d2a and 5ca816cccfe25eebba49d1c86b53d6b9166ce41a.

#
MarkKoz
[python-discord/snekbox] New review comment on pull request #81: Limit STDOUT to prevent OOM events in container

I tend to associate it with functions that are broader in scope than they should be. It could also be a sign of clumsiness, like when returning some sort of boolean in addition to data. It may indicate a function can be further refactored. It's also more difficult to document, especially when not using named tuples. Returning two ostensibly unrelated things in a tuple makes the purpose of the function less clear.

In fact, ideally this function would only be concerned with the output and no...

#
lemonsaurus
[python-discord/sir-lancebot] New branch created: lemon/refactor/seasonalbot\_name\_change
#
MarkKoz
[snekbox:master] 11 new commits

5639a40 Limit STDOUT to prevent OOM events in container - SebastiaanZ
af4846a Refactor STDOUT consumer to separate function - SebastiaanZ
ac16745 Keep output that took us over the output limit - SebastiaanZ
83e4586 Increase number of characters in each read chunk - SebastiaanZ
18ab777 Use SIGKILL instead of SIGTERM to terminate NsJail - SebastiaanZ

#
MarkKoz
[python-discord/snekbox] branch deleted: sebastiaan/bug/stdout\-flood
#
mbaruh
[bot:master] 9 new commits

99ffe92 Add bright green color to constants - gustavwilliam
6db3713 Update help channel available message - gustavwilliam
43e52d7 Add green-checkmark to bot constants - gustavwilliam
6a53035 Use author as the title of the embed - gustavwilliam
1e9b22b Update available message to sound better - gustavwilliam

#
mbaruh
[python-discord/bot] branch deleted: help\-channel\-msg
oak estuaryBOT
regal archBOT
#
lemonsaurus
[python-discord/sir-lancebot] branch deleted: lemon/refactor/seasonalbot\_name\_change
#
gustavwilliam
[python-discord/bot] Issue opened: #1295 Improving dormant help channel embed

Following the successful implementation of an updated available help channel embed, I think it's time that we update the dormant help channel embed as well. There are two main reasons and goals for wanting to update this:

  • Improving consistency
  • Improving the dormant message
    • Telling the user what to do if the question wasn't answered

Current help channel embeds

Here is the new available help channel embed:

This is the current dormant embed:

Implementation

I'm c...

regal archBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
regal archBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
#
mbaruh
[python-discord/bot] branch deleted: superstar\-fix
#
gustavwilliam
[python-discord/branding] Issue opened: #104 Lemoji contributions guide

Lemojis are great and I've heard about many people being interested in contributing. There are however many steps involved and things to know before getting started, which is why I'm proposing a lemoji contributions guide. It will mention at least the following core points:

  • The lemojis are based on Twemojis
  • How relevant Twemojis are found and downloaded
  • We work with vector graphics, which means that the contributors should be based on the source files (svgs)
  • What lemoji template they ...
oak estuaryBOT
regal archBOT