north knotBOT Sep 2, 2020, 10:43 PM

#

Auto-deployed: site

regal archBOT Sep 2, 2020, 10:43 PM

#

[site] Azure Pipelines checks success on master

ebon magnetBOT Sep 2, 2020, 10:44 PM

#

Build 20200902.6 succeeded

Requested by

Leon Sandøy

Duration

00:03:58

Build pipeline

Site

regal archBOT Sep 2, 2020, 10:44 PM

#

[site] GitHub Code Scanning checks success on master

#

[site] GitHub Actions checks success on master

regal archBOT Sep 3, 2020, 2:29 AM

#

fiskenslakt

[site:feat/timeline] 3 new commits

1b07a00 add timeline view - fiskenslakt
6b692e9 add timeline template - fiskenslakt
e138286 add static timeline assets - fiskenslakt

#

fiskenslakt

[python-discord/site] New branch created: feat/timeline

#

fiskenslakt

[python-discord/site] Pull request opened: #381 100k milestone timeline page

Abstract

Our 100k milestone is coming up fast, and to celebrate we are creating a timeline of significant events in PyDis history.

This is an extremely rough draft as of writing, just wanted to get something out there.

ebon magnetBOT Sep 3, 2020, 2:37 AM

#

Build 20200903.1 failed

Requested by

GitHub

Duration

00:02:05

Build pipeline

Site

north knotBOT Sep 3, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 3, 2020, 12:22 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 3, 2020, 4:37 PM

#

LordHemlock

[python-discord/bot] Pull request review submitted: #1135 Auto\-respond to everyone pings\.

Seems to work as intended in testing. Giving it the green light.

regal archBOT Sep 3, 2020, 4:58 PM

#

lemonsaurus

[python-discord/bot] Pull request review submitted: #1135 Auto\-respond to everyone pings\.

Alright, seems fine now. let's get this merged.

ebon magnetBOT Sep 3, 2020, 5:05 PM

#

Build 20200903.1 succeeded

Requested by

GitHub

Duration

00:03:52

Build pipeline

Bot

regal archBOT Sep 3, 2020, 5:07 PM

#

LordHemlock

[python-discord/bot] Issue closed: #1131 Auto\-respond to non\-mod everyone pings\.

#

LordHemlock

[python-discord/bot] Pull request closed: #1135 Auto\-respond to everyone pings\.

#

LordHemlock

[bot:master] 18 new commits

40ad0de Everyone Ping: Add rules to default config file - MrAwesomeRocks
df4ef2e Everyone Ping: Added rule - MrAwesomeRocks
99aa7d5 Everyone Ping: Added rule to recognized rules - MrAwesomeRocks
f873e68 Everyone Ping: Added required values to config - MrAwesomeRocks
c55b7e3 Everyone Ping: Fixed rule, edited config - MrAwesomeRocks

north knotBOT Sep 3, 2020, 5:13 PM

#

Auto-deployed: bot

ebon magnetBOT Sep 3, 2020, 5:14 PM

#

Build 20200903.2 succeeded

Requested by

GitHub

Duration

00:05:47

Build pipeline

Bot

oak estuaryBOT Sep 3, 2020, 5:14 PM

#

Python Bot

Connected!

regal archBOT Sep 3, 2020, 6:35 PM

#

MarkKoz

[python-discord/bot] Issue closed: #1130 Mod\-alerts channel pings when large amounts of emojis are within a code block\.

#

MarkKoz

[python-discord/bot] Pull request closed: #1132 AntiSpam: ignore custom emojis in code blocks

#

MarkKoz

[bot:master] 2 new commits

30cbde7 AntiSpam: ignore custom emojis in code blocks - MarkKoz
07b5f23 Merge pull request #1132 from python-discord/bu... - MarkKoz

#

MarkKoz

[python-discord/bot] branch deleted: bug/filters/1130/ignore\-codeblock\-emoji

north knotBOT Sep 3, 2020, 6:41 PM

#

Auto-deployed: bot

ebon magnetBOT Sep 3, 2020, 6:41 PM

#

Build 20200903.3 succeeded

Requested by

GitHub

Duration

00:05:20

Build pipeline

Bot

oak estuaryBOT Sep 3, 2020, 6:41 PM

#

Python Bot

Connected!

north knotBOT Sep 4, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 4, 2020, 9:31 AM

#

Anubhav1603

[python-discord/seasonalbot] Pull request opened: #430 \!wiki command

"Closes #331"

when bot able to search

when times up
fail

when error happen
error

It sends value error if user try to send str or float value
it gives list from ...

#

python-discord-bot

[python-discord/seasonalbot] New comment on pull request #430: \!wiki command

Thank you for contributing to Python Discord!

Please check out the following documents:

Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
Python Discord Contributor Wiki - A set of resources about setting up our services
Python Discord Code of Conduct - Code of conduct for our commu...

ebon magnetBOT Sep 4, 2020, 9:33 AM

#

Build 20200904.1 failed

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

#

Build 20200904.2 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

regal archBOT Sep 4, 2020, 11:14 AM

#

Anubhav1603

[python-discord/bot] Fork created: Anubhav1603/bot

regal archBOT Sep 4, 2020, 12:27 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 4, 2020, 12:57 PM

#

RohanJnr

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

The feature works well. Just a few coding conventions to change here and there.

Also, this is my first review on a pydis PR, would love to hear some feedback on this.

#

RohanJnr

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Could use better variable names, example: search_description instead of s?

#

RohanJnr

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

here too, instead of a and j, we can use better names. maybe rename title -> titles and a-> title.

#

RohanJnr

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

this is the second time we are looping over the title list and the final list is not required. we can simply replace j with a.replace(" ", "_"). (a should be renamed as mentioned in a previous comment).
This way, we don't have to loop over the title list 2 times and populate the final list as done in line 52.

regal archBOT Sep 4, 2020, 1:27 PM

#

MrAwesomeRocks

[python-discord/bot] Issue opened: #1142 Everyone Ping rule picking up false positives

The everyone ping rule has been picking up some false positives, working on a solution now.

regal archBOT Sep 4, 2020, 1:43 PM

#

Anubhav1603

[python-discord/seasonalbot] New comment on pull request #430: \!wiki command

Ok I will make changes according to what u said :) btw this is my first pr also in pydis too

ebon magnetBOT Sep 4, 2020, 2:33 PM

#

Build 20200904.3 succeeded

Requested by

GitHub

Duration

00:00:56

Build pipeline

Seasonal Bot

regal archBOT Sep 4, 2020, 2:49 PM

#

MrAwesomeRocks

[python-discord/bot] Pull request opened: #1143 Fix false\-positives in everyone ping rule\.

Closes #1142

The everyone ping rule was picking up some false positives, such as

`a`@everyone`b`

or

Hello`@everyone`

This fixes that issue by first removing all codeblocks from the message, then checking the the clean, de-codeblocked message has any @everyone pings inside of it.

ebon magnetBOT Sep 4, 2020, 2:53 PM

#

Build 20200904.1 succeeded

Requested by

GitHub

Duration

00:03:08

Build pipeline

Bot

regal archBOT Sep 4, 2020, 3:06 PM

#

kosayoda

[python-discord/bot] Pull request review submitted: #1143 Fix false\-positives in everyone ping rule\.

This introduces false negatives with

`@everyone``

and possibly other messages.

I'm not sure regex is the way to go now.

regal archBOT Sep 4, 2020, 4:09 PM

#

lemonsaurus

[python-discord/bot] New comment on pull request #1143: Fix false\-positives in everyone ping rule\.

I think I'm gonna close this PR - we will handle this in the core dev team, @MrAwesomeRocks, because I want some good unit tests for this so we're sure we're catching every edge case.

#

lemonsaurus

[python-discord/bot] Pull request closed: #1143 Fix false\-positives in everyone ping rule\.

#

Shreyansh-Mishra

[python-discord/bot] Fork created: Shreyansh-Mishra/bot

regal archBOT Sep 4, 2020, 5:56 PM

#

lemonsaurus

[python-discord/site] New branch created: dewikification

#

[site] GitHub Code Scanning checks success on master

#

[site] GitHub Actions checks success on dewikification

#

SebastiaanZ

[bot:master] 1 new commit

1512dcc Disable burst_shared filter of the AntiSpam cog - SebastiaanZ

#

lemonsaurus

[python-discord/site] Issue opened: #382 Dewikification: Remove django\-wiki from the site

We need to completely remove django-wiki from the site, as a step in our journey towards complete dewikification.

It will be useful to look at https://github.com/python-discord/site/pull/202 to see what kinds of changes we made when introducing it - this issue is to essentially do the opposite of that. However, we can't simply revert this because we've made many changes to the wiki stuff since then, so this will need to be done manually.

This will probably also require a migration, si...

north knotBOT Sep 4, 2020, 6:12 PM

#

Auto-deployed: bot

ebon magnetBOT Sep 4, 2020, 6:12 PM

#

Build 20200904.2 succeeded

Requested by

GitHub

Duration

00:04:35

Build pipeline

Bot

oak estuaryBOT Sep 4, 2020, 6:12 PM

#

Python Bot

Connected!

regal archBOT Sep 4, 2020, 6:13 PM

#

lemonsaurus

[python-discord/site] Issue opened: #383 Dewikification: Make an app to serve guides

Create a new Django app that will serve guides.

This app will have a folder full of markdown files with guide content, and will render those markdown files dynamically depending on the url. Something like pythondiscord.com/guides/ will navigate to a page displaying all the content in the correct markdown file. These markdown files should be GitHub-flavored markdown.

What should a page like this look like?

Well, it should look like one of our current guides.
![image](https://user...

#

lemonsaurus

[python-discord/site] Issue opened: #384 Dewikification: Migrate all existing guides on pythondiscord\.com to the new guides system\.

This issue must be solved after #383.

Once a new system for the guides is ready, we should migrate our existing guides into this new system.

Please make this a separate pull request, so that we can review the system and the content separately.

Remember to target the dewikification branch with this pull request

#

lemonsaurus

[python-discord/site] Issue opened: #385 Dewikification: Create an app for showing event info\.

For displaying event information (like for our code jams), we will want a slightly different approach. These will basically just be normal static pages, but we need a clever, modular system for displaying sidebars.

What's a sidebar?

Take a look at one of our current event pages.

See the information on the right hand side? That's a sidebar. These sidebars should be able to c...

#

lemonsaurus

[python-discord/site] Issue opened: #386 Dewikification: Migrate all existing event pages to the new events app\.

This issue must be solved after #385

Once a new system for the event pages is ready, we should migrate our existing event pages into this new system.

Please make this a separate pull request, so that we can review the system and the content separately.

Remember to target the dewikification branch with this pull request

#

Numerlor

[python-discord/bot] Pull request opened: #1144 Move bolding markdown outside of text link in help channel messages\.

On some clients (android), the markdown is commonly not rendered properly within text links, in this case the bolding didn't happen and the markdown asterisks remainder as plaintext.
Moving them outside of the link text fixes the issue

ebon magnetBOT Sep 4, 2020, 6:32 PM

#

Build 20200904.3 succeeded

Requested by

GitHub

Duration

00:03:04

Build pipeline

Bot

regal archBOT Sep 4, 2020, 7:05 PM

#

lemonsaurus

[python-discord/site] Issue opened: #387 Dewikification: Create a Django app for showing lists of resources\.

Remember to target the dewikification branch with this pull request

On the current site, we provide a curated set of resources - It's beautiful!

We need to recreate this for the dewikified site.

So, what precisely needs to be done?

Well, you need to create a django app, let's call it resources, which will contain all this stuff.

When someone navigates to `p...

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

Overall I like what I see, but I do have one question and one suggestion that I'd like to see addressed.

#

MrHemlock

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

Should the thresholds be stored in here or in the configuration file? The other constants like the join and verification messages make sense here but as an example we have the anti-spam settings in the config-default.yaml file

#

MrHemlock

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

Will this be an issue if the bot is forced to restart? Is the task_cache stored somewhere persistent?

#

SebastiaanZ

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

SebastiaanZ

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

task_cache is a RedisCache; it will persist in Redis.

#

lemonsaurus

[python-discord/site] Issue opened: #388 Dewikification: Display lists of resources based on a YAML hierarchy\.

Remember to target the dewikification branch with this pull request

This must be solved after the https://github.com/python-discord/site/issues/387 solution has been merged.

Okay, so currently we have these lists of resources, right?

These pages should be generated based on a hierarchy of YAML files - one for each resource - so that we don't actually have to writ...

#

lemonsaurus

[python-discord/site] Issue opened: #389 Dewikification: Set up redirects for old routes

Remember to target the dewikification branch with this pull request

This will depend on most of the issues in the https://github.com/python-discord/site/projects/1 project, so it should be handled pretty late in the dewikification process.

Most of the issues in the dewikification will probably end up changing the URLs that refer to certain key pages, such as our resources page. This is problematic because many pages on the world wide web refer to our pages, and these will end up b...

#

kwzrd

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

kwzrd

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

Yea, think of task_cache as a dict that persists across restarts.

This condition should only be True the first time the bot connects. After that, the last sent reminder should always be cached, but nothing bad happens if it isn't ~ the bot will just send another one, and then cache it.

#

kwzrd

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

kwzrd

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

I'm not sure. I usually try to advocate keeping the definitions close to where they are used.

Let's imagine that these settings are in the config.yml. If you're reading the code and you wonder what the value is, you have to:

Follow the import to constants.py
Look at from where the value is being loaded
Navigate to the YAML and find the value

IDE generally cannot aid you in this process, as the value only gets bound at runtime. In my opinion, this creates a significant level...

#

kwzrd

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

kwzrd

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

Another downside that I notice with creating move distance between the value and its use, is that it increases the amount of necessary documentation. The names of these variables would likely need to be longer, and be more annotated, so that it's obvious what they represent.

regal archBOT Sep 4, 2020, 8:15 PM

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

MrHemlock

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

Excellent, that takes care of my worry on that then.

regal archBOT Sep 4, 2020, 8:37 PM

#

jb3

[metricity:master] 1 new commit

9d5d4b3 Add some new staff categories - jb3

#

[metricity] Lint code success on master

#

[metricity] Build & Publish Docker image success on master

north knotBOT Sep 4, 2020, 8:39 PM

#

Auto-deployed: metricity

regal archBOT Sep 4, 2020, 8:39 PM

#

[metricity] Trigger Auto\-Deploy success on master

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1144 Move bolding markdown outside of text link in help channel messages\.

For what it's worth, both on Windows and Android, it doesn't render as bold. However, unlike the screenshot, the asterisk aren't visible either.

#

SebastiaanZ

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

SebastiaanZ

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

One additional factor to consider is if these values need to be changed for a testing environment. If so, using the config system ensures that people do not have the modify any of the files checked into our version control system, as they only have to configure config.yaml to their liking to overwrite the default in config-default.yaml. This prevents debug values from being accidentally committed to the repository.

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

MrHemlock

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

I'm honestly kind of torn about whether we should move it. On one hand you're right, there's all the distance between the values and the and where they're used that causes potential issues sifting through the code, as I've certainly had in the past.

I also think there's an argument to be made that the anti-spam cog needs it to be in the config file just due to the number of rules it touches. But I think my main concern is when we actually need to tweak the configuration from a moderati...

#

Numerlor

[python-discord/bot] New comment on pull request #1144: Move bolding markdown outside of text link in help channel messages\.

For what it's worth, both on Windows and Android, it didn't render as bold before your fix.

Hmm, it does render properly for me on windows; I guess it's inconsistent all over.

#

janine9vn

[python-discord/branding] Fork created: janine9vn/branding

#

kwzrd

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

This prevents debug values from being accidentally committed to the repository.

@SebastiaanZ: This is true, although it doesn't feel like a very strong argument to me. I don't think it's difficult to review the diff before commiting it, and it should definitely be done before pushing. Unintended diff being commited & pushed sadly happens often even with these measures in place. I actually probably find it easier to have them version controlled, it forces you to keep your settings tidy & ...

#

kwzrd

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

SebastiaanZ

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

SebastiaanZ

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

This is true, although it doesn't feel like a very strong argument to me. I don't think it's difficult to review the diff before commiting it, and it should definitely be done before pushing. Unintended diff being commited & pushed sadly happens often even with these measures in place. I actually probably find it easier to have them version controlled, it forces you to keep your settings tidy & you will always know when and how your configured behaviour differs from the production one.

T...

regal archBOT Sep 4, 2020, 9:32 PM

#

kwzrd

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

kwzrd

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

To me, personally, it's one of the biggest reasons why we use the configuration system we do.

Interesting, thanks for sharing that. It's the opposite for me. I don't feel very comfortable having a config.yml with no history or easy way to see how it differs from production settings, or other developers' settings. It feels to me like that's an easy way to miss something during review, because you're not aware that you're getting different behaviour.

For me, the most notable advantage...

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

MarkKoz

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

Ideally these would be configurable. It's just that the current config system sucks and we haven't gotten far with coming up with an alternative.

oak estuaryBOT Sep 4, 2020, 11:23 PM

#

Python Bot

Connected!

#

Python Bot

Connected!

regal archBOT Sep 4, 2020, 11:37 PM

#

ItsCbass

[python-discord/snekbox] Fork created: ItsCbass/snekbox

regal archBOT Sep 5, 2020, 12:58 AM

#

kosayoda

[python-discord/bot] New branch created: bug/1142/fix\-everyone\-ping

#

kosayoda

[bot:bug/1142/fix\-everyone\-ping] 2 new commits

0351a23 Detect pings after removing codeblocks. - kosayoda
3189afa Add test for everyone_ping rule. - kosayoda

#

kosayoda

[python-discord/bot] Pull request opened: #1145 Fix @everyone ping rule\.

This PR modifies the regex in the everyone ping rule to avoid false positives and negatives. Test cases have also been added to enforce correctness.

Implementation

The check now removes all codeblocks, inline or multiline from the message before detecting pings. As it uses re.sub, there may be a performance concern. If that turns out to be the case, we can do a basic ping inclusion check, then strip codeblocks if the first filter passes.

Tests

There may be more edge cases th...

ebon magnetBOT Sep 5, 2020, 1:15 AM

#

Build 20200905.1 succeeded

Requested by

GitHub

Duration

00:02:55

Build pipeline

Bot

regal archBOT Sep 5, 2020, 4:03 AM

#

Anubhav1603

[python-discord/seasonalbot] New comment on issue #414: partnerzodiac ext update with dates | or new zodiac ext

I want to work on this issue :)

regal archBOT Sep 5, 2020, 5:22 AM

#

gustavwilliam

[python-discord/bot] Issue opened: #1146 \!help output in muted \#bot\-commands

When someone uses !help in another channel than #bot-commands, the output is redirected to #bot-commands.

This is still the case when send message permissions in #bot-commands are removed, which could lead to spamming or "drowning" a potential message about what is happening, in the channel.

north knotBOT Sep 5, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 5, 2020, 7:40 AM

#

Jack92829

[python-discord/bot] Issue opened: #1147 Everyone warning picking up nicknames

The warning system trying to prevent people from attempting to @everyone is also picking up on people with the nickname 'everyone'

regal archBOT Sep 5, 2020, 8:38 AM

#

Jack92829

[python-discord/bot] New comment on issue #1147: Everyone warning picking up nicknames

Although after discussing this with other people in discord and looking at the code, it might just be an issue on discords side

regal archBOT Sep 5, 2020, 9:04 AM

#

SebastiaanZ

[python-discord/bot] New comment on issue #1147: Everyone warning picking up nicknames

I'm not sure if the message that you're highlighting is the one that actually triggered this filter. The filter normally also removes the message in question and there's no error that says that the bot was unable to delete a message here. My working hypothesis is that this user sent two messages in a row: the first one (still there) had a member ping and the second one contained an actual everyone-ping.

#

SebastiaanZ

[bot:master] 1 new commit

53cb77b Disable everyone_ping filter in AntiSpam cog - SebastiaanZ

north knotBOT Sep 5, 2020, 9:15 AM

#

Auto-deployed: bot

ebon magnetBOT Sep 5, 2020, 9:15 AM

#

Build 20200905.2 succeeded

Requested by

GitHub

Duration

00:05:11

Build pipeline

Bot

oak estuaryBOT Sep 5, 2020, 9:15 AM

#

Python Bot

Connected!

regal archBOT Sep 5, 2020, 9:37 AM

#

Jack92829

[python-discord/bot] New comment on issue #1147: Everyone warning picking up nicknames

Ah yeah that sounds more likely

#

Jack92829

[python-discord/bot] Issue closed: #1147 Everyone warning picking up nicknames

regal archBOT Sep 5, 2020, 12:34 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 5, 2020, 1:10 PM

#

ArduinoidIOT

[python-discord/bot] Fork created: ArduinoidIOT/bot

regal archBOT Sep 5, 2020, 3:51 PM

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

There will be an error here when entering a negative number or a number that is greater than the amount of results:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/discord/ext/commands/core.py", line 85, in wrapped
    ret = await coro(*args, **kwargs)
  File "/bot/bot/exts/evergreen/wikipedia.py", line 72, in w_pedia
    await ctx.send(WIKIPEDIA_URL.format(title=final[int(user.content) - 1]))
IndexError: list index out of range

Also en...

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

Overall it looks pretty good, but there are some designs that can be improved.

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

This docstring does not really tell what this function is about, how it is used, I strongly suggest adding more information, otherwise invoking .help wiki will yield this

A good docstring can yield good help as well, as seen here:

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

    async def search_wikipedia(self, search_term: str) -> Optional[List[str]]:

You will want to import List from typing as well.

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #429 Wolfram cog

#

ikuyarihS

[python-discord/seasonalbot] Pull request closed: #429 Wolfram cog

#

ikuyarihS

[python-discord/seasonalbot] branch deleted: wolfram\-cog

#

ikuyarihS

[seasonalbot:master] 9 new commits

d6f91f8 Updated constants to include Wolfram configurat... - Xithrius
c373d4c Migrated Wolfram cog from the Python bot in Pyt... - Xithrius
38bebb3 Added necessary utility for Wolfram cog. - Xithrius
a3941cb Update bot/exts/evergreen/wolfram.py - Xithrius
d472389 Removed the time utility and replaced it with t... - Xithrius

north knotBOT Sep 5, 2020, 3:58 PM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 5, 2020, 3:58 PM

#

Build 20200905.1 succeeded

Requested by

GitHub

Duration

00:02:29

Build pipeline

Seasonal Bot

night lilyBOT Sep 5, 2020, 3:58 PM

#

SeasonalBot

Connected!

regal archBOT Sep 5, 2020, 3:58 PM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #421 Caesar cipher command

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #421: Caesar cipher command

Is there a reason why these are defined inside the command? From the look of it, you can move it outside as well to prevent them being defined everytime the command is run, declaring them as @staticmethod

ebon magnetBOT Sep 5, 2020, 4:00 PM

#

Build 20200905.2 failed

Requested by

GitHub

Duration

00:01:11

Build pipeline

Seasonal Bot

regal archBOT Sep 5, 2020, 4:25 PM

#

PureFunctor

[python-discord/seasonalbot] Pull request review submitted: #421 Caesar cipher command

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #421: Caesar cipher command

I've initially decided to define these inside of the function to be consistent with the form of the other commands inside of the Fun cog. I could change them into @staticmethods but I'm not sure whether making them standalone top-level functions would avoid polluting the cog.

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #421 Caesar cipher command

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #421: Caesar cipher command

I would suggest moving them outside, in case we want to write unittests for these. Naming these with a _ in front of the name to signify that these are to be used internally might be able to help, otherwise you can always move them outside in their own class and just call it inside the Cog.

#

ikuyarihS

[python-discord/bot] Pull request review submitted: #1144 Move bolding markdown outside of text link in help channel messages\.

LGTM

ebon magnetBOT Sep 5, 2020, 4:38 PM

#

Build 20200905.3 succeeded

Requested by

GitHub

Duration

00:03:12

Build pipeline

Bot

regal archBOT Sep 5, 2020, 4:48 PM

#

ikuyarihS

[python-discord/bot] Pull request closed: #1144 Move bolding markdown outside of text link in help channel messages\.

#

ikuyarihS

[bot:master] 3 new commits

d2e7dd3 Move bolding markdown outside of text link. - Numerlor
a4ab2c4 Merge branch 'master' into text-link-fix - ikuyarihS
a3de2cd Merge pull request #1144 from Numerlor/text-lin... - ikuyarihS

#

PureFunctor

[python-discord/seasonalbot] Pull request review submitted: #421 Caesar cipher command

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #421: Caesar cipher command

I'll go ahead and do that :+1:

north knotBOT Sep 5, 2020, 4:53 PM

#

Auto-deployed: bot

ebon magnetBOT Sep 5, 2020, 4:53 PM

#

Build 20200905.4 succeeded

Requested by

GitHub

Duration

00:04:31

Build pipeline

Bot

oak estuaryBOT Sep 5, 2020, 4:53 PM

#

Python Bot

Connected!

regal archBOT Sep 5, 2020, 9:15 PM

#

MarkKoz

[python-discord/bot] New comment on issue #130: Top 5 leaderboard for mod\-alert triggers\.

Grafana can show this now. Do we really need a Discord front-end to it? @lemonsaurus

#

fadedmax

[python-discord/bot] Pull request review submitted: #1145 Fix @everyone ping rule\.

LGTM

#

lemonsaurus

[python-discord/bot] New comment on issue #130: Top 5 leaderboard for mod\-alert triggers\.

nope. I mean, this is an issue that severely predates grafana. I consider this solved.

#

lemonsaurus

[python-discord/bot] Issue closed: #130 Top 5 leaderboard for mod\-alert triggers\.

regal archBOT Sep 5, 2020, 10:48 PM

#

MrAwesomeRocks

[python-discord/bot] Pull request review submitted: #1145 Fix @everyone ping rule\.

I would add a check for @everyone in messages before re.sub, just to make this as robust as possible, because we can't really test this in a server of 98k+ without deploying it, and it would be bad if the bot got lagged out during a raid or something.

regal archBOT Sep 5, 2020, 11:09 PM

#

MrAwesomeRocks

[python-discord/bot] New comment on issue #1136: Add trash option to all bot responses

I see @MarkKoz's way working better, because then we could just add an @deleteable or @trashable decorator and would not have to completely modify the bot's message-sending functionality. It just seems simpler to implement this that way.

regal archBOT Sep 6, 2020, 12:02 AM

#

nitori

[python-discord/seasonalbot] Issue opened: #431 Docstring on 8bitify doesn't match actual code

https://github.com/python-discord/seasonalbot/blob/d77a2bbc50305d05371197f4cfe3354cfca4c627/bot/exts/evergreen/8bitify.py#L21-L22

A bit nitpicky, but after being curious on how it works, I looked it up and saw this little discrepancy.

Docstring says 256 colors (8-bit), but it actually only uses 32 colors (5 bit?). Either of those should probably be adjusted to match the other?

regal archBOT Sep 6, 2020, 4:16 AM

#

ArduinoidIOT

[python-discord/bot] New comment on issue #556: Write unit tests for \`bot/cogs/moderation/\_\_init\_\_\.py\`

I'd like to work on this please.

regal archBOT Sep 6, 2020, 5:28 AM

#

Shivansh-007

[python-discord/bot] New comment on issue #810: Tag Suggestions

putting these here so i remember to do them

anyone is welcome to beat me to it (please )

[x] REPL

[x] exit()

[x] if __name__ == '__main__'

[x] off-topic

[x] metasyntactic variables (foo, bar, etc)

[x] paste (link to paste.pydis.com, explain about saving and url changing)

[x] xy problem

[x] parameters vs. arguments

[x] codeblock [UPDATED] (added info about backticks and other bad formatting)

[x] self

[x] classes...

north knotBOT Sep 6, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 6, 2020, 6:15 AM

#

Jack92829

[python-discord/bot] Fork created: Jack92829/bot

#

Jack92829

[python-discord/bot] Pull request opened: #1148 New guilds tag

A new tag named guilds that directs people towards the awesome list found under the communities section of the python discord's site and to partners of the python discord. I believe this will come in handy both when people ask for help regarding other languages and fields and for when people ask if there is any guilds similar to the python discord but that are focused on othe...

#

python-discord-bot

[python-discord/bot] New comment on pull request #1148: New guilds tag

Thank you for contributing to Python Discord!

Please check out the following documents:

Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
Python Discord Contributor Wiki - A set of resources about setting up our services
Python Discord Code of Conduct - Code of conduct for our commu...

#

Shivansh-007

[python-discord/bot] Fork created: Shivansh-007/bot

ebon magnetBOT Sep 6, 2020, 6:27 AM

#

Build 20200906.1 succeeded

Requested by

GitHub

Duration

00:03:03

Build pipeline

Bot

ebon magnetBOT Sep 6, 2020, 9:47 AM

#

Build 20200906.2 succeeded

Requested by

GitHub

Duration

00:03:04

Build pipeline

Bot

regal archBOT Sep 6, 2020, 10:04 AM

#

lemonsaurus

[python-discord/bot] Pull request review submitted: #1145 Fix @everyone ping rule\.

As we discussed during the admin meeting today, we'd like to see the automod stuff completely removed from the feature, keep the mod-alert, and make it work for @here too.

regal archBOT Sep 6, 2020, 11:44 AM

#

kosayoda

[python-discord/bot] New comment on pull request #1145: Fix @everyone ping rule\.

Going by that, does it make sense to move it from antispam to filtering? The former is rigid on pinging/infracting, and I think it suits the latter more.

regal archBOT Sep 6, 2020, 12:15 PM

#

lemonsaurus

[python-discord/bot] New comment on pull request #1145: Fix @everyone ping rule\.

does it make sense to move it from antispam to filtering?

Yes I think it does.

#

Akarys42

[python-discord/branding] Fork created: Akarys42/branding

#

[site] GitHub Actions checks success on master

regal archBOT Sep 6, 2020, 12:48 PM

#

MrAwesomeRocks

[python-discord/bot] New comment on pull request #1145: Fix @everyone ping rule\.

Looking at filtering, that file is getting very long (583 lines) because of all the different rules. The filtering rules also seem to be organized similarly to the antispam rules.

Would it make sense to move the rules out of filtering and into a rules directory somewhere, sort of like in antispam? It would make it simpler to add rules later on.
It could be out of the scope of this PR to change filtering that much, though.

#

janine9vn

[python-discord/branding] Pull request opened: #59 lemoji templates with symmetrical beard

2 lemoji templates, one straightened and one tilted, with the symmetrical beard.
The straightened one should help ensure that any added features can also be symmetrical before tilting.

#

python-discord-bot

[python-discord/branding] New comment on pull request #59: lemoji templates with symmetrical beard

Thank you for contributing to Python Discord!

Please check out the following documents:

Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
Python Discord Code of Conduct Code of conduct for our community
Python Discord Contributor Wiki - A set of resources about setting up our services

ebon magnetBOT Sep 6, 2020, 12:55 PM

#

Build 20200906.1 succeeded

Requested by

GitHub

Duration

00:00:51

Build pipeline

Seasonal Bot

regal archBOT Sep 6, 2020, 1:00 PM

#

MrAwesomeRocks

[python-discord/branding] New comment on pull request #58: Add lemonsaurus lemoji

Waiting for #59 to merge to change the lemonsaurus head.

regal archBOT Sep 6, 2020, 1:44 PM

#

janine9vn

[python-discord/branding] Pull request opened: #60 Lemoji updates for new symmetrical beard template

Updating all existing lemojis to incorporate new lemon template that has the symmetrical beard. Slight adjustments to the emojis themselves are also done to unify the style.

regal archBOT Sep 6, 2020, 2:20 PM

#

lemonsaurus

[python-discord/bot] New comment on pull request #1145: Fix @everyone ping rule\.

Would it make sense to move the rules out of filtering and into a rules directory somewhere, sort of like in antispam?

Yeah, I think we should probably consider doing that - maybe rules could have a subfolder for filtering and one for antispam. But yeah it's probably out of scope for this PR. You could make an issue for it if you want, @MrAwesomeRocks ?

regal archBOT Sep 6, 2020, 3:08 PM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

The quality and the design has definitely improved, great job!

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

I would definitely advise against introducing unnecessary blank line, especially between if / elif / else or try / except.

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

You do want to capitalize the S in Sorry and you would want proper grammar here instead of informal language.

            await ctx.send("Sorry, but you cannot do that, I will only accept an integer.")

The same can be said for other messages as well.

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

This should be moved up to line 33, since at this line we've already finished appending titles.
You can also change the text here as well to something like "Finished appending titles."

ebon magnetBOT Sep 6, 2020, 3:56 PM

#

Build 20200906.2 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

regal archBOT Sep 6, 2020, 6:23 PM

#

wookie184

[python-discord/seasonalbot] Issue opened: #432 Update discord\.py version to 1\.4\.1

Description

Update the discord.py version to 1.4.1, and also put the voice extra back in

Reasoning

It currently gets the package straight from GitHub,
https://github.com/python-discord/seasonalbot/blob/da468c51502c88c00687e2869f05a1a46c715e45/Pipfile#L10
which was necessary to allow for usage of AllowedMentions before it was released, but wasn't ideal. Now that the new version has been released I believe this is no longer necessary. Currently it also doesn't include the voice...

north knotBOT Sep 7, 2020, 6:00 AM

#

Postgres backup completed!

ebon magnetBOT Sep 7, 2020, 10:24 AM

#

Build 20200907.1 succeeded

Requested by

GitHub

Duration

00:00:58

Build pipeline

Seasonal Bot

regal archBOT Sep 7, 2020, 10:32 AM

#

Anubhav1603

[python-discord/seasonalbot] New comment on pull request #430: \!wiki command

sorry my commit msg is looking weired, actually my commit failed and then i corrected changes and commited again with new msg and previous commit msg got disappeared 😓

regal archBOT Sep 7, 2020, 10:56 AM

#

Anubhav1603

[python-discord/seasonalbot] New comment on issue #432: Update discord\.py version to 1\.4\.1

i wnt to do this :)

regal archBOT Sep 7, 2020, 12:22 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 7, 2020, 5:12 PM

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

MrHemlock

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

I think for now, we should align with the current configuration standard and move the things we would need to tweak on the fly (the constants I mentioned up above) to the config-default.yaml

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

            log.info("trying to append titles")

There are some typos in the file similar to this one, let's fix them so they show up properly in the log as well.

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

        log.info("Finished appending titles with underscores")

Did you mean "with underscore"?

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

I like the idea of using chances, that's a great design! We're almost there!

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

The 3 number should not be hard-coded and should be moved up to be a variable for the cog.
Even better, you can make it configurable in the config as well, by declaring them in the bot/constants.py for example

ebon magnetBOT Sep 7, 2020, 5:34 PM

#

Build 20200907.2 succeeded

Requested by

GitHub

Duration

00:01:20

Build pipeline

Seasonal Bot

regal archBOT Sep 7, 2020, 5:43 PM

#

Anubhav1603

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

Anubhav1603

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Screenshot_2020-09-07-23-06-58-857
I don't know why that happen to you but when u tried that worked fine can u show me what u searched

regal archBOT Sep 7, 2020, 6:29 PM

#

gustavwilliam

[python-discord/bot] Issue opened: #1149 Link to channel when using \!rule

When using !rule 6, the embed contains the string #python-general as a reference to the channel. Let's make it a link.

In #rules, it's already a link.

regal archBOT Sep 7, 2020, 6:57 PM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Sure think, I did what you tried as well, and this is what I got:

It makes senses as well, since l_of_list is indeed an int.

regal archBOT Sep 7, 2020, 7:27 PM

#

sanket-16

[python-discord/bot] Fork created: sanket-16/bot

regal archBOT Sep 7, 2020, 10:15 PM

#

MarkKoz

[bot:feat/backend/217/has\_any\_role] 6 new commits

8c39b74 Remove with_role decorator in favour of has_any... - MarkKoz
24657d4 Implement the without_role decorator by negatin... - MarkKoz
b0a2ebb Use has_any_role's predicate directly - MarkKoz
8e161a3 Implement role checks using has_any_role - MarkKoz
7722578 Rename role checks and decorators - MarkKoz

#

MarkKoz

[python-discord/bot] New branch created: feat/backend/217/has\_any\_role

#

MarkKoz

[python-discord/bot] Pull request opened: #1150 Implement with\(out\)\_role checks and decorators using has\_any\_role

Resolves #217

This simplifies the implementations by relying on the function discord.py provides. with_role is entirely replaced by has_any_role since it was identical. The rest had their implementations changed. Consequently, they now support specifying roles as names in addition to IDs. They were also renamed to be more consistent with has_any_role's name.

ebon magnetBOT Sep 7, 2020, 10:20 PM

#

Build 20200907.1 failed

Requested by

GitHub

Duration

00:00:50

Build pipeline

Bot

regal archBOT Sep 7, 2020, 10:25 PM

#

MarkKoz

[bot] Branch feat/backend/217/has\_any\_role was force-pushed to `5feb9f0`

Compare changes

#

MarkKoz

[python-discord/bot] New comment on issue #1075: Should the syncer confirmation be removed?

Okay, it's been a few days and I got 2 "yes" responses. I'm going to start on this.

ebon magnetBOT Sep 7, 2020, 10:28 PM

#

Build 20200907.2 failed

Requested by

GitHub

Duration

00:02:16

Build pipeline

Bot

regal archBOT Sep 7, 2020, 10:53 PM

#

MarkKoz

[bot:feat/backend/1075/remove\-syncer\-confirm] 1 new commit

7b31119 Sync: remove confirmation - MarkKoz

#

MarkKoz

[python-discord/bot] New branch created: feat/backend/1075/remove\-syncer\-confirm

#

MarkKoz

[python-discord/bot] Pull request opened: #1151 Sync: remove confirmation

The confirmation was intended to be a safe guard against cache issues that would cause a huge number of roles/users to deleted after syncing. With wait_until_guild_available, such cache issue shouldn't arise. Therefore, this feature is obsolete.

Resolve #1075

#

MarkKoz

[python-discord/bot] New comment on issue #784: Sync as much as possible instead of aborting on first sight of an error

Stalled until #1151 is merged, which will simplify this implementation.

ebon magnetBOT Sep 7, 2020, 10:57 PM

#

Build 20200907.3 failed

Requested by

GitHub

Duration

00:02:41

Build pipeline

Bot

regal archBOT Sep 7, 2020, 11:02 PM

#

MarkKoz

[bot:feat/backend/1075/remove\-syncer\-confirm] 1 new commit

9de2bbe Fix test for sync message being edited - MarkKoz

ebon magnetBOT Sep 7, 2020, 11:05 PM

#

Build 20200907.4 succeeded

Requested by

GitHub

Duration

00:03:15

Build pipeline

Bot

regal archBOT Sep 8, 2020, 1:18 AM

#

Anubhav1603

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

Anubhav1603

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Actually I did this to detect spam of command if user use try to give .wiki in spam bot can detect with this

regal archBOT Sep 8, 2020, 4:06 AM

#

kosayoda

[bot:bug/1142/fix\-everyone\-ping] 2 new commits

0c6215f Remove everyone_ping rule from antispam. - kosayoda
ab4eb39 Add everyone_ping filter. - kosayoda

north knotBOT Sep 8, 2020, 6:00 AM

#

Postgres backup completed!

night lilyBOT Sep 8, 2020, 6:47 AM

#

SeasonalBot

Connected!

regal archBOT Sep 8, 2020, 10:27 AM

#

Akarys42

[python-discord/branding] Pull request opened: #61 More lemojis, always more lemojis

This PR adds 3 new lemojis

:lemon_raised_eyebrow
:lemon_tongue:
:lemon_swag:

regal archBOT Sep 8, 2020, 10:43 AM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

That's fine, but you mutate it into two totally different types, and that can cause confusion to anyone reading the code, so I still strongly suggest using two variables instead.

regal archBOT Sep 8, 2020, 11:16 AM

#

ikuyarihS

[python-discord/seasonalbot] New comment on issue #425: Optional user arguments

@slushiegoose do you still want to work on this issue?

regal archBOT Sep 8, 2020, 11:53 AM

#

lemonsaurus

[python-discord/branding] New comment on pull request #59: lemoji templates with symmetrical beard

This looks great, and I appreciate you opening this request.

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #59 lemoji templates with symmetrical beard

Excellent work.

#

lemonsaurus

[python-discord/branding] Pull request closed: #59 lemoji templates with symmetrical beard

#

lemonsaurus

[branding:master] 4 new commits

806849b lemoji templates with symmetrical beard - janine9vn
f7bd035 update lemon_xd with new template - janine9vn
a9bcf24 Revert "update lemon_xd with new template" - janine9vn
9197075 Merge pull request #59 from janine9vn/master - lemonsaurus

#

lemonsaurus

[python-discord/branding] New comment on pull request #58: Add lemonsaurus lemoji

I think this is fun, and I don't mind adding it to the emoji roster in our community - but I don't think it really belongs in the lemoji folder in this repo, it's just too different.

So, I'm gonna add it to the community and then close this PR.

#

lemonsaurus

[python-discord/branding] Pull request closed: #58 Add lemonsaurus lemoji

regal archBOT Sep 8, 2020, 12:21 PM

#

[site] GitHub Actions checks success on master

ebon magnetBOT Sep 8, 2020, 12:43 PM

#

Build 20200908.1 succeeded

Requested by

GitHub

Duration

00:01:03

Build pipeline

Seasonal Bot

regal archBOT Sep 8, 2020, 1:13 PM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

Awesome! Only some minor typo and grammar errors and I believe it'll be ready!

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

                    await ctx.send(f"Sorry, please give an integer between `1` and `{l_of_list}`, {error_msg}")

This can be applied to the prompts below as well for IndexError

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

There's a typo here, it should be appending instead of appening

ebon magnetBOT Sep 8, 2020, 1:36 PM

#

Build 20200908.2 succeeded

Requested by

GitHub

Duration

00:01:03

Build pipeline

Seasonal Bot

#

Build 20200908.3 succeeded

Requested by

GitHub

Duration

00:01:05

Build pipeline

Seasonal Bot

ebon magnetBOT Sep 8, 2020, 3:35 PM

#

Build 20200908.4 succeeded

Requested by

GitHub

Duration

00:00:56

Build pipeline

Seasonal Bot

#

Build 20200908.5 succeeded

Requested by

GitHub

Duration

00:00:55

Build pipeline

Seasonal Bot

#

Build 20200908.6 succeeded

Requested by

GitHub

Duration

00:00:51

Build pipeline

Seasonal Bot

regal archBOT Sep 8, 2020, 3:45 PM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

ebon magnetBOT Sep 8, 2020, 3:57 PM

#

Build 20200908.7 succeeded

Requested by

GitHub

Duration

00:00:58

Build pipeline

Seasonal Bot

regal archBOT Sep 8, 2020, 4:26 PM

#

ikuyarihS

[python-discord/seasonalbot] New comment on issue #414: partnerzodiac ext update with dates | or new zodiac ext

@Vincenwobdo do you still want to work on this? Or you are fine leaving the issue to @Anubhav1603?

#

Vincenwobdo

[python-discord/seasonalbot] New comment on issue #414: partnerzodiac ext update with dates | or new zodiac ext

@Anubhav1603 you certainly can take it on. Thank you.

#

Anubhav1603

[python-discord/seasonalbot] New comment on issue #414: partnerzodiac ext update with dates | or new zodiac ext

Ok i will work on this issue 🙂 ty

regal archBOT Sep 8, 2020, 5:32 PM

#

MarkKoz

[bot] Branch feat/backend/217/has\_any\_role was force-pushed to `39b6e25`

Compare changes

ebon magnetBOT Sep 8, 2020, 5:36 PM

#

Build 20200908.1 succeeded

Requested by

GitHub

Duration

00:03:00

Build pipeline

Bot

regal archBOT Sep 9, 2020, 5:41 AM

#

[site] Azure Pipelines checks failure on c1442bb

ebon magnetBOT Sep 9, 2020, 5:41 AM

#

Build 20200909.1 failed

Requested by

GitHub

Duration

00:01:42

Build pipeline

Site

regal archBOT Sep 9, 2020, 5:43 AM

#

[site] GitHub Code Scanning checks success on c1442bb

#

[site] GitHub Actions checks success on user\_endpoint

north knotBOT Sep 9, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 9, 2020, 12:22 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 9, 2020, 4:31 PM

#

[site] Azure Pipelines checks success on c2fd139

ebon magnetBOT Sep 9, 2020, 4:31 PM

#

Build 20200909.2 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Site

regal archBOT Sep 9, 2020, 4:34 PM

#

[site] GitHub Code Scanning checks success on c2fd139

#

[site] GitHub Actions checks success on user\_endpoint

regal archBOT Sep 9, 2020, 5:14 PM

#

Anubhav1603

[python-discord/seasonalbot] Issue opened: #433 \.source command

Description

We doesnt have source command for seasonal bot so it will be good if we add one

Reasoning

with source command we can quickly check source of any command same like python bot

Would you like to implement this yourself?

[x] I'd like to implement this feature myself
[x] Anyone can implement this feature

regal archBOT Sep 9, 2020, 5:38 PM

#

xsultanfhx

[python-discord/bot] Fork created: xsultanfhx/bot

oak estuaryBOT Sep 9, 2020, 6:18 PM

#

Python Bot

Connected!

regal archBOT Sep 9, 2020, 8:05 PM

#

Xithrius

[python-discord/seasonalbot] Issue opened: #434 Changing the \.topic output from plain text to a useful embed\.

Description

Changing the output of the .topic command from plain text to an embed. The suggested topic will be in the title, bold. The description will be a hyperlink to the topic suggestion form, which can be found here

Reasoning

The output of the .topic command is too plain, and no one knows where to suggest new topics! With this addition, people will now not only be able to see the topic more clearly, but they will know where to go...

regal archBOT Sep 9, 2020, 9:08 PM

#

MarkKoz

[bot:bug/utility/829/non\-py\-code\-detection] 58 new commits

e0438b2 Watchchannels: censor message content if it has... - MarkKoz
c0afea1 Don't send code block help if message has a web... - MarkKoz
59a58db Use wait_for_deletion from bot/utils/messages.p... - AtieP
ee4efbb Define a Command subclass with root alias support - MarkKoz
f455a79 Bot: add root alias support - MarkKoz

ebon magnetBOT Sep 9, 2020, 9:12 PM

#

Build 20200909.1 succeeded

Requested by

GitHub

Duration

00:03:25

Build pipeline

Bot

regal archBOT Sep 9, 2020, 9:31 PM

#

gustavwilliam

[python-discord/branding] Pull request opened: #62 Add ducky lemon

Here's the new emote:

And in a message:

#

lemonsaurus

[python-discord/branding] New comment on pull request #62: Add ducky lemon

Yes. This is excellent.

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #62 Add ducky lemon

#

lemonsaurus

[python-discord/branding] Pull request closed: #62 Add ducky lemon

#

lemonsaurus

[branding:master] 2 new commits

ecb50e5 Add lemon ducky svg - gustavwilliam
cf5c009 Merge pull request #62 from gustavwilliam/master - lemonsaurus

regal archBOT Sep 9, 2020, 10:01 PM

#

Xithrius

[seasonalbot:topic\-embeds] 3 new commits

33ad42c Changed from json formatting to yaml to get the... - Xithrius
415b8bf Added more topics. - Xithrius
3544e71 Topics are now iterated through instead of rand... - Xithrius

#

Xithrius

[python-discord/seasonalbot] New branch created: topic\-embeds

#

Xithrius

[python-discord/seasonalbot] Pull request opened: #435 Topic embeds

Relevant Issues

Closes #434

Description

Embeds are now used for providing the topic and the hyperlink to where you can suggest more. The form here has been updated to include the offtopic section.

Reasoning

By using itertools.cycle, all channels in the TOPICS dictionary have an infinite generator. This was created by shuffling the topics in their current state and then putting them into their own section of a dictionary. Th...

ebon magnetBOT Sep 9, 2020, 10:11 PM

#

Build 20200909.1 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

regal archBOT Sep 9, 2020, 10:18 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

f1b0c9d Removed logging. - Xithrius

ebon magnetBOT Sep 9, 2020, 10:19 PM

#

Build 20200909.2 succeeded

Requested by

GitHub

Duration

00:00:57

Build pipeline

Seasonal Bot

regal archBOT Sep 9, 2020, 10:49 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

434e9a6 Added RandomCycle utility to jump between set i... - Xithrius

ebon magnetBOT Sep 9, 2020, 10:50 PM

#

Build 20200909.3 succeeded

Requested by

GitHub

Duration

00:00:56

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 12:26 AM

#

MarkKoz

[bot:bug/util/795/reminders\-dupe\-delete] 4 new commits

2544d19 Decorators: replace asyncio.Lock with a custom ... - MarkKoz
6556a5c Decorators: remove locked() decorator - MarkKoz
85e4d91 Decorators: rename mutually_exclusive decorators - MarkKoz
ac25ada Move lock decorators to utils/lock.py - MarkKoz

#

MarkKoz

[python-discord/bot] Pull request review submitted: #835 Fix reminders sending duplicate DELETE request and cancelling themselves

#

MarkKoz

[python-discord/bot] New review comment on pull request #835: Fix reminders sending duplicate DELETE request and cancelling themselves

I've gone ahead with your suggestion to use a custom lock class.

#

MarkKoz

[bot:bug/util/795/reminders\-dupe\-delete] 1 new commit

fe08fd2 Fix attribute docstring for LockedResourceError - MarkKoz

#

MarkKoz

[bot:bug/util/795/reminders\-dupe\-delete] 185 new commits

db79b6a Kaizen: Move OffTopicName to converters.py. - lemonsaurus
98c325f Cache AllowDenyList data at bot startup. - lemonsaurus
d834174 Add ValidAllowDenyListType converter. - lemonsaurus
0d22a04 Kaizen: Make error_handler.py more embeddy. - lemonsaurus
ccc2e7a Better BadArgument exception text. - lemonsaurus

ebon magnetBOT Sep 10, 2020, 12:38 AM

#

Build 20200910.1 succeeded

Requested by

GitHub

Duration

00:02:48

Build pipeline

Bot

regal archBOT Sep 10, 2020, 2:47 AM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

Very nice idea with RandomCycle, I like it a lot!

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

This can be simplified to

TOPICS = {
    channel: RandomCycle(topics or ['No topics found for this channel.'])
    for channel, topics in all_topics.items()
}

And then you can remove a layer of checking when getting topics in line 60 where we do not have to check if TOPICS[ctx.channel.id] is False or not. like so

        try:
            # Fetching topics.
            channel_topics = TOPICS[ctx.channel.id]

        # If the channel isn't Python-relate...

#

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

ALL_TOPICS = {'default': STARTERS, **PY_TOPICS}

This should be uppercased to signify that it should be treated as a constant,

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

2844b11 Update bot/exts/evergreen/conversationstarters.py - Xithrius

ebon magnetBOT Sep 10, 2020, 3:03 AM

#

Build 20200910.1 failed

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 3:23 AM

#

Xithrius

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

#

Xithrius

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

I like these simplifications. Thanks for the input!

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

Looks good to me - only a few small things.

#

Den4200

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

Is there any reason for captializing Python here? The text channel names are all lowercase in the guild.

#

Den4200

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

I think this could have a more descriptive docstring, such as:

    """
    Cycles through elements from a randomly shuffled iterable, repeating indefinitely.

    The iterable is reshuffled after each full cycle.
    """

north knotBOT Sep 10, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 10, 2020, 7:19 AM

#

Jhern315

[python-discord/bot] Fork created: Jhern315/bot

regal archBOT Sep 10, 2020, 12:21 PM

#

[site] GitHub Actions checks success on master

oak estuaryBOT Sep 10, 2020, 3:08 PM

#

Python Bot

Connected!

regal archBOT Sep 10, 2020, 3:44 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

189d2e3 Update bot/utils/randomization.py - Xithrius

ebon magnetBOT Sep 10, 2020, 3:45 PM

#

Build 20200910.2 failed

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 3:46 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

ee693c2 Update bot/exts/evergreen/conversationstarters.py - Xithrius

ebon magnetBOT Sep 10, 2020, 3:48 PM

#

Build 20200910.3 failed

Requested by

GitHub

Duration

00:00:53

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 4:04 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

f206290 Renamed "esoteric-Python" to "esoteric-python" - Xithrius

#

Xithrius

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

#

Xithrius

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

I did a replace-all for "python" to "Python", and I had forgotten that #esoteric-python is a channel that exists.

This has been reverted to esoteric-python to keep consistency with the actual channels on the server.

ebon magnetBOT Sep 10, 2020, 4:06 PM

#

Build 20200910.4 failed

Requested by

GitHub

Duration

00:01:12

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 4:07 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

ffdb4ac Updated conversationstarters to simplify what v... - Xithrius

ebon magnetBOT Sep 10, 2020, 4:09 PM

#

Build 20200910.5 succeeded

Requested by

GitHub

Duration

00:01:10

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 5:15 PM

#

kwzrd

[bot:kwzrd/verification] 1 new commit

1b3a5c5 Verification: move constants to config - kwzrd

#

kwzrd

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

#

kwzrd

[python-discord/bot] New review comment on pull request #1077: Take steps to increase verification rate

Moved constants to the YAML file in 1b3a5c5 including BOT_MESSAGE_DELETE_DELAY which was an in-module constant before this PR. I'm not sure, but it doesn't look like the top-level definitions in neither constants.py nor the YAML are ordered lexicographically, so I just put mine below PythonNews in both.

ebon magnetBOT Sep 10, 2020, 5:20 PM

#

Build 20200910.2 succeeded

Requested by

GitHub

Duration

00:04:08

Build pipeline

Bot

regal archBOT Sep 10, 2020, 5:52 PM

#

gustavwilliam

[python-discord/branding] Pull request opened: #63 Add exploding head lemoji

Here is the new lemoji!

And this is how it looks in a message:

regal archBOT Sep 10, 2020, 6:08 PM

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

#

Den4200

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

Python is also capitalized in some of the other channel names as well.

regal archBOT Sep 10, 2020, 6:37 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

f2cd221 Made all channel names lowercase. - Xithrius

#

Xithrius

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

#

Xithrius

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

Fixed all of them.

ebon magnetBOT Sep 10, 2020, 6:39 PM

#

Build 20200910.6 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 7:54 PM

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1077 Take steps to increase verification rate

Looks good to me, let's get the ball rolling.

#

MrHemlock

[bot:kwzrd/verification] 119 new commits

e2a035c Filtering: ignore webhooks for nickname filter - MarkKoz
1344d3d Utils: show error message for long poll titles - MarkKoz
f553785 HelpChannels: move unpinning to separate function - MarkKoz
9b9a439 HelpChannels: add more detail to unpin log mess... - MarkKoz
6f31a11 HelpChannels: don't unpin message if ID is None - MarkKoz

ebon magnetBOT Sep 10, 2020, 7:58 PM

#

Build 20200910.3 succeeded

Requested by

GitHub

Duration

00:02:43

Build pipeline

Bot

regal archBOT Sep 10, 2020, 8:58 PM

#

MrHemlock

[python-discord/bot] Pull request closed: #1077 Take steps to increase verification rate

#

MrHemlock

[python-discord/bot] branch deleted: kwzrd/verification

#

MrHemlock

[bot:master] 61 new commits

a221895 Verification: add initial on join message - kwzrd
fad7961 Verification: adjust & rename welcome message - kwzrd
0521af6 Verification: send initial message on member join - kwzrd
226af0e Verification: add @Unverified role to config - kwzrd
5006105 Verification: refactor discord imports - kwzrd

north knotBOT Sep 10, 2020, 9:03 PM

#

Auto-deployed: bot

ebon magnetBOT Sep 10, 2020, 9:03 PM

#

Build 20200910.4 succeeded

Requested by

GitHub

Duration

00:04:28

Build pipeline

Bot

oak estuaryBOT Sep 10, 2020, 9:03 PM

#

Python Bot

Connected!

regal archBOT Sep 10, 2020, 9:48 PM

#

JonasUJ

[python-discord/django-simple-bulma] Pull request opened: #64 Use DOMContentLoaded in bulma\-dropdown\.js

There was basically no guarantee that the dropdown element was loaded when the script ran. This was a leftover from the original script #27. Issue 27 also says you use that script on the PyDis site, so you should probably look into fixing it there too (unless the jQuery parts does some magic that defers the script execution/adding event listeners)

#

[django-simple-bulma] GitHub Actions checks success on master

regal archBOT Sep 10, 2020, 10:43 PM

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

There was something I missed previously, and a few things that need to be fixed in py_topics.yaml.

#

Den4200

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

This isn't the correct ID for #computer-science. I'm guessing you committed the test server channel IDs?

650401909852864553:

#

Den4200

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

I'm surprised I didn't catch this before in a previous PR, but the list comprehension is not needed. You can just do list(PY_TOPICS). If you want to be more explicit, list(PY_TOPICS.keys()) works as well.

    ALL_ALLOWED_CHANNELS = list(PY_TOPICS.keys()) + list(WHITELISTED_CHANNELS)

#

Den4200

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

This isn't the correct ID for #python-general.

267624335836053506:

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

e7f6512 Update bot/exts/evergreen/conversationstarters.py - Xithrius

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

d2d09af Update bot/resources/evergreen/py_topics.yaml - Xithrius

ebon magnetBOT Sep 10, 2020, 10:55 PM

#

Build 20200910.7 succeeded

Requested by

GitHub

Duration

00:01:05

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 10:56 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

05bade4 Update bot/resources/evergreen/py_topics.yaml - Xithrius

ebon magnetBOT Sep 10, 2020, 10:57 PM

#

Build 20200910.9 succeeded

Requested by

GitHub

Duration

00:00:53

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 10:59 PM

#

Xithrius

[python-discord/seasonalbot] New comment on pull request #435: Topic embeds

Both previous commits that updated the py_topics.yaml file changed the IDs from the test server channel IDs to the actual Python Discord channel IDs.

#

Xithrius

[seasonalbot] Branch topic\-embeds was force-pushed to `ef040cf`

Compare changes

#

Xithrius

[seasonalbot] Branch topic\-embeds was force-pushed to `bf09b71`

Compare changes

ebon magnetBOT Sep 10, 2020, 11:07 PM

#

Build 20200910.11 succeeded

Requested by

GitHub

Duration

00:00:56

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 11:08 PM

#

Xithrius

[seasonalbot:topic\-embeds] 1 new commit

10ad837 Renamed from python-extensions to c-extensions,... - Xithrius

ebon magnetBOT Sep 10, 2020, 11:09 PM

#

Build 20200910.12 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

regal archBOT Sep 10, 2020, 11:24 PM

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

Sorry, I forgot to also mention that you forgot the #tools-and-devops topical channel.

regal archBOT Sep 11, 2020, 12:01 AM

#

Xithrius

[python-discord/seasonalbot] New comment on pull request #435: Topic embeds

The force pushes were both meant to show a different commit for the previous commits that only said that a file was updated.

regal archBOT Sep 11, 2020, 12:20 AM

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

#

Den4200

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

One last thing - this should be in alphabetical order, like this:

from discord import Color, Embed
from discord.ext import commands
import yaml

I'm kind of surprised the linting tests didn't catch this.

regal archBOT Sep 11, 2020, 1:19 AM

#

Xithrius

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

#

Xithrius

[python-discord/seasonalbot] New review comment on pull request #435: Topic embeds

pipenv run lint complains when imports are reordered to what you suggested. Pycharm reorders the imports when autoformatting, and a manual run of flake8 on the bot directory also complains.

regal archBOT Sep 11, 2020, 3:15 AM

#

ncDevMan

[python-discord/seasonalbot] New comment on issue #174: \[Feature Request\] Earth Photos

This sounds like fun. I could take a look at this if you would like.

north knotBOT Sep 11, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 11, 2020, 8:06 AM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

Looks good to me.

#

ikuyarihS

[python-discord/seasonalbot] New comment on issue #174: \[Feature Request\] Earth Photos

Sure thing, I've assigned the issue to you @ncDevMan

#

ikuyarihS

[python-discord/seasonalbot] New comment on pull request #419: More Questions for the Trivia Quiz

@AtieP will you have time to address the requested changes? After they have been addressed I can approve this as well

regal archBOT Sep 11, 2020, 11:55 AM

#

jb3

[public-stats:master] 1 new commit

aa4f748 Update init.py - jb3

#

[public-stats] GitHub Actions checks success on master

#

[public-stats] GitHub Actions checks success on master

regal archBOT Sep 11, 2020, 12:30 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 11, 2020, 12:56 PM

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #63 Add exploding head lemoji

Looks great!

#

lemonsaurus

[python-discord/branding] New comment on pull request #63: Add exploding head lemoji

Added to the community.

#

lemonsaurus

[python-discord/branding] Pull request closed: #63 Add exploding head lemoji

#

lemonsaurus

[branding:master] 3 new commits

9875a35 Add exploding head lemoji - gustavwilliam
00cc337 Update exploding head lemoji with symmetrical b... - gustavwilliam
200eb72 Merge pull request #63 from gustavwilliam/master - lemonsaurus

regal archBOT Sep 11, 2020, 2:43 PM

#

Alfonzo1215

[python-discord/bot] Fork created: Alfonzo1215/bot

regal archBOT Sep 11, 2020, 3:05 PM

#

gustavwilliam

[python-discord/branding] Pull request opened: #64 Beard structure lemojis

Demo

Here is a quick demo of what can be done with the new beard structure!

The included pieces

This new set of 20 lemojis can be used to create almost any beard structure imaginable. The following pieces are included:

Four 90° separated rotations of the head
Four 90° separated rotations of the beard end
One blank piece for alignment
Eleven regular beard piece...

#

gustavwilliam

[python-discord/branding] New comment on pull request #64: Beard structure lemojis

File names

We have blank, head_DIRECTION, end_DIRECTION and CONNECTIONS pieces.

CONNECTIONS is the places that the piece connects to pieces. For example, one called l_t_r_b would be a piece has connections on all four sides — a "center piece" — while l_r would be an only horizontal one.
DIRECTION is simply the way that a head or end is pointing. A head_t piece would be an upright head piece.

regal archBOT Sep 11, 2020, 4:33 PM

#

gustavwilliam

[python-discord/seasonalbot] Issue opened: #436 Beardify — Lemoji beard structure text generator

Description

A command that would let the user easily convert text to a beard structure, using the beard structure lemojis.

Here's PyDis using the beard structure, in a Discord channel!

Reasoning

Being able to write with lemoji beard, without having to reinvent the characters every time, would be fantastic.

Proposed Implementation

A command like `.beardif...

regal archBOT Sep 11, 2020, 5:04 PM

#

wookie184

[python-discord/bot] New comment on issue #1146: \!help output in muted \#bot\-commands

Us having to disable send message permissions in bot-commands specifically is a rare event, and it isn't the end of the world if this issue happens anyway. Messages with information can be pinned in the channel, and updates on an incident would usually be in #announcements or #changelog anyway.

I'm not sure changing this behavior is really worth it imo.

regal archBOT Sep 11, 2020, 5:49 PM

#

kwzrd

[bot:master] 1 new commit

7ebc481 Verification: update & improve docstrings - kwzrd

north knotBOT Sep 11, 2020, 5:54 PM

#

Auto-deployed: bot

ebon magnetBOT Sep 11, 2020, 5:55 PM

#

Build 20200911.1 succeeded

Requested by

GitHub

Duration

00:05:10

Build pipeline

Bot

oak estuaryBOT Sep 11, 2020, 5:55 PM

#

Python Bot

Connected!

regal archBOT Sep 11, 2020, 9:43 PM

#

eivl

[site:allow\_blank\_or\_null\_for\_nomination\_reason] 1 new commit

49e7243 Allow blank/null input to the nomination reason. - eivl

#

eivl

[python-discord/site] New branch created: allow\_blank\_or\_null\_for\_nomination\_reason

#

eivl

[python-discord/site] Pull request opened: #390 Allow blank/null input to the nomination reason\.

We are lowering the threshold for nomination. By allowing the users to
make a nomination without a reason might make this feature more
attractive amongst members of staff.

ebon magnetBOT Sep 11, 2020, 9:48 PM

#

Build 20200911.1 failed

Requested by

GitHub

Duration

00:01:58

Build pipeline

Site

regal archBOT Sep 11, 2020, 9:50 PM

#

Mark-co

[python-discord/bot] Fork created: Mark-co/bot

regal archBOT Sep 11, 2020, 10:13 PM

#

eivl

[site:allow\_blank\_or\_null\_for\_nomination\_reason] 1 new commit

1ed2241 Fix a broken test for nomination reason. - eivl

ebon magnetBOT Sep 11, 2020, 10:16 PM

#

Build 20200911.2 succeeded

Requested by

GitHub

Duration

00:02:15

Build pipeline

Site

regal archBOT Sep 11, 2020, 11:31 PM

#

eivl

[bot:Make\_nomination\_reason\_optional] 3 new commits

7b83b7c Make nomination reason optional. - eivl
d75e1bc Only show reason if it exist. - eivl
0e24d10 Update user cache after nomination reason edit. - eivl

#

eivl

[python-discord/bot] New branch created: Make\_nomination\_reason\_optional

#

eivl

[python-discord/bot] Pull request opened: #1152 Make\_nomination\_reason\_optional

ebon magnetBOT Sep 11, 2020, 11:33 PM

#

Build 20200911.2 failed

Requested by

GitHub

Duration

00:00:47

Build pipeline

Bot

regal archBOT Sep 11, 2020, 11:39 PM

#

eivl

[bot:Make\_nomination\_reason\_optional] 1 new commit

057efd0 Fix import order to pass linting tests. - eivl

ebon magnetBOT Sep 11, 2020, 11:42 PM

#

Build 20200911.3 succeeded

Requested by

GitHub

Duration

00:02:33

Build pipeline

Bot

regal archBOT Sep 12, 2020, 1:16 AM

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #435 Topic embeds

Looks good to me as well.

#

Den4200

[python-discord/seasonalbot] Issue closed: #434 Changing the \.topic output from plain text to a useful embed\.

#

Den4200

[python-discord/seasonalbot] Pull request closed: #435 Topic embeds

#

Den4200

[seasonalbot:master] 16 new commits

33ad42c Changed from json formatting to yaml to get the... - Xithrius
415b8bf Added more topics. - Xithrius
3544e71 Topics are now iterated through instead of rand... - Xithrius
f1b0c9d Removed logging. - Xithrius
434e9a6 Added RandomCycle utility to jump between set i... - Xithrius

#

Den4200

[python-discord/seasonalbot] branch deleted: topic\-embeds

north knotBOT Sep 12, 2020, 1:19 AM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 12, 2020, 1:19 AM

#

Build 20200912.1 succeeded

Requested by

GitHub

Duration

00:02:31

Build pipeline

Seasonal Bot

night lilyBOT Sep 12, 2020, 1:19 AM

#

SeasonalBot

Connected!

regal archBOT Sep 12, 2020, 1:38 AM

#

jb3

[metricity:master] 1 new commit

8386910 Store user verification date - jb3

#

[metricity] Lint code failure on master

#

[metricity] Build & Publish Docker image failure on master

#

[metricity] Trigger Auto\-Deploy skipped on master

#

jb3

[metricity:master] 1 new commit

5e9c9a4 Linting - jb3

#

[metricity] Lint code success on master

#

[metricity] Build & Publish Docker image success on master

north knotBOT Sep 12, 2020, 1:42 AM

#

Auto-deployed: metricity

regal archBOT Sep 12, 2020, 1:42 AM

#

[metricity] Trigger Auto\-Deploy success on master

#

jb3

[metricity:master] 1 new commit

0b5e5db Add extra logic for handing newer users - jb3

#

[metricity] Lint code success on master

#

[metricity] Build & Publish Docker image success on master

north knotBOT Sep 12, 2020, 1:54 AM

#

Auto-deployed: metricity

regal archBOT Sep 12, 2020, 1:54 AM

#

[metricity] Trigger Auto\-Deploy success on master

regal archBOT Sep 12, 2020, 2:36 AM

#

jb3

[metricity:master] 1 new commit

f4e10de Fix some issues with verification time logic - jb3

#

[metricity] Lint code success on master

#

[metricity] Build & Publish Docker image success on master

north knotBOT Sep 12, 2020, 2:38 AM

#

Auto-deployed: metricity

regal archBOT Sep 12, 2020, 2:38 AM

#

[metricity] Trigger Auto\-Deploy success on master

north knotBOT Sep 12, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 12, 2020, 6:11 AM

#

lemonsaurus

[python-discord/site] Pull request review submitted: #390 Allow blank/null input to the nomination reason\.

Looks fine. Good change.

regal archBOT Sep 12, 2020, 6:30 AM

#

slushiegoose

[python-discord/seasonalbot] New comment on issue #425: Optional user arguments

sure

regal archBOT Sep 12, 2020, 8:13 AM

#

scrazzz

[python-discord/bot] Issue opened: #1153 \!reddit command doesn’t filter nsfw subreddits\.

So yeah, ask the title says !reddit command doesn’t filter nsfw subreddits ._.

doing: !reddit top nsfw displays the direct URL link to the nsfw subreddit.

regal archBOT Sep 12, 2020, 9:02 AM

#

RohanJnr

[python-discord/bot] New comment on issue #1153: \!reddit command doesn’t filter nsfw subreddits\.

this should be a simple fix as done here
https://github.com/python-discord/seasonalbot/blob/master/bot/exts/evergreen/reddit.py#L57
it's another Reddit command, but for seasonalbot

regal archBOT Sep 12, 2020, 12:20 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 12, 2020, 12:53 PM

#

lemonsaurus

[python-discord/site] New comment on issue #366: Search bar

This is blocked by the major changes we've got planned for our content management system.

I'm going to add this issue to the Dewikification project, and edit the description with a more precise spec.

#

lemonsaurus

[python-discord/site] Issue opened: #391 Get rid of subdomains in our site

There is no reason we should use subdomains in our app.

Get rid of subdomains. instead of staff.pythondiscord.com, we will simply use pythondiscord.com/staff/.
Get rid of the subdomain dependencies.
We will need to update the bot, which specifically uses the subdomains in its configuration. This should just be a matter of changing a few lines in the default-config.yml file. Please make sure this change is made, that both pull requests are open at the same time and that they ge...

regal archBOT Sep 12, 2020, 1:29 PM

#

SebastiaanZ

[python-discord/async-rediscache] Issue opened: #1 Set up linting check suite in GitHub actions

We need to set up a linting check suite in GitHub Actions for this project. The check suite run on commits to master and on pull requests, including those opened from forks. The latter makes it difficult to use GitHub Actions from the marketplace that insert annotations/review comments, as you need to have access to the secrets/GitHub token for that. This is disabled for Pull Requests opened from a fork.

My proposal:

Use a set up similar to python-discord/django-simple-bulma
Optional...

regal archBOT Sep 12, 2020, 2:56 PM

#

kwzrd

[python-discord/async-rediscache] Issue opened: #2 RedisCache: boolean values are being converted to float typestrings

There is a bug in the _to_typestring conversion method.

https://github.com/python-discord/bot/blob/02d1dd1b5034778f6bfc296317c9241e93395b2a/bot/utils/redis_cache.py#L108-L121

When converting values, the first tuple in prefixes is ("f|", float). If a bool is being stored, the conditional on line 113 then triggers and returns f|0 or f|1. On the way out, the int get cast to float as per the typestring and so we get 0.0 or 1.0.

The test_set_get_item test function does not...

regal archBOT Sep 12, 2020, 4:59 PM

#

SebastiaanZ

[async-rediscache:master] 4 new commits

f984e65 Add support for bool values to RedisObject - SebastiaanZ
e392bc0 Fix incorrect handling of bools in type converter - SebastiaanZ
aaeca7c Add basic usage instructions to README.md - SebastiaanZ
062034f Bump version to v0.1.0-alpha - SebastiaanZ

#

SebastiaanZ

[python-discord/async-rediscache] Issue closed: #2 Boolean values are being converted to float typestrings

#

SebastiaanZ

[python-discord/async-rediscache] New tag created: v0\.1\.0\-alpha

#

[async-rediscache] GitHub Actions checks success on v0\.1\.0\-alpha

#

SebastiaanZ

[async-rediscache:master] 1 new commit

42c22a8 Close session in README example - SebastiaanZ

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #64 Beard structure lemojis

I love these.

#

lemonsaurus

[python-discord/branding] Pull request closed: #64 Beard structure lemojis

#

lemonsaurus

[branding:master] 3 new commits

d8ea3a9 Add beard structure pngs - gustavwilliam
929f3b7 Add beard structure svgs - gustavwilliam
9a4f420 Merge pull request #64 from gustavwilliam/master - lemonsaurus

regal archBOT Sep 12, 2020, 5:51 PM

#

janine9vn

[python-discord/branding] New comment on pull request #60: Lemoji updates for new symmetrical beard template

This PR resolves #56. Lemon_pika was updated to remove black outlines in this lemoji update.

regal archBOT Sep 12, 2020, 7:22 PM

#

scrazzz

[python-discord/bot] New comment on issue #1153: \!reddit command doesn’t filter nsfw subreddits\.

Nice. Hopefully they implement this 👍

#

scrazzz

[python-discord/bot] Issue closed: #1153 \!reddit command doesn’t filter nsfw subreddits\.

#

jb3

[python-discord/bot] New comment on issue #1153: \!reddit command doesn’t filter nsfw subreddits\.

We should keep this open until it is implemented.

#

jb3

[python-discord/bot] Issue reopened: #1153 \!reddit command doesn’t filter nsfw subreddits\.

regal archBOT Sep 12, 2020, 8:32 PM

#

janine9vn

[python-discord/branding] Pull request opened: #65 lemon\_ping and lemon\_grimace emoji additions

"and don't try to ping 90000 people." deserves to be immortalized. Thus, lemon_ping.
Also lemon_grimace.

lemon_ping_grimace

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #60 Lemoji updates for new symmetrical beard template

Looks fantastic, thanks so much for all these improvements.

#

lemonsaurus

[python-discord/branding] Issue closed: #56 Fix pikachu lemoji

#

lemonsaurus

[python-discord/branding] Pull request closed: #60 Lemoji updates for new symmetrical beard template

#

lemonsaurus

[branding:master] 25 new commits

9012786 lemoji update: lemon_xd - janine9vn
54f894b lemoji update: lemon_warpaint - janine9vn
506598a lemoji update: lemon_unamused - janine9vn
35972c8 lemoji update: lemon_thinks/thinking - janine9vn
060e8ff lemoji update: lemon_sweat - janine9vn

regal archBOT Sep 12, 2020, 11:27 PM

#

gustavwilliam

[python-discord/branding] Pull request opened: #66 New PyDis\-Snake emoji tileset

A new tileset, consisting of 20 emojis is added — including source files. The snake uses the PyDis brand colors.

Preview

These are the pieces in the PyDis-Snake tileset:
Tileset

Changes

A new directory emotes/tilesets consisting of all tilesets was added.
The new snake tileset was added to tilesets/pydis_snake. The files are split into two subfolders — src and...

regal archBOT Sep 12, 2020, 11:58 PM

#

Den4200

[python-discord/bot] Pull request review submitted: #1152 Make nomination reason optional

One small thing!

#

Den4200

[python-discord/bot] New review comment on pull request #1152: Make nomination reason optional

I don't think the Optional annotation is needed here, since the default argument is a string.

#

Den4200

[python-discord/site] Pull request review submitted: #390 Allow blank/null input to the nomination reason\.

Looks good to me.

#

Den4200

[python-discord/site] Pull request closed: #390 Allow blank/null input to the nomination reason\.

#

Den4200

[site:master] 3 new commits

49e7243 Allow blank/null input to the nomination reason. - eivl
1ed2241 Fix a broken test for nomination reason. - eivl
dcc3684 Merge pull request #390 from python-discord/all... - Den4200

#

Den4200

[python-discord/site] branch deleted: allow\_blank\_or\_null\_for\_nomination\_reason

#

[site] GitHub Actions checks success on master

north knotBOT Sep 13, 2020, 12:05 AM

#

Auto-deployed: site

regal archBOT Sep 13, 2020, 12:05 AM

#

[site] Azure Pipelines checks success on master

ebon magnetBOT Sep 13, 2020, 12:06 AM

#

Build 20200913.1 succeeded

Requested by

GitHub

Duration

00:04:25

Build pipeline

Site

regal archBOT Sep 13, 2020, 12:06 AM

#

[site] GitHub Code Scanning checks success on master

#

[site] GitHub Actions checks success on master

regal archBOT Sep 13, 2020, 2:47 AM

#

RohanJnr

[python-discord/bot] New comment on issue #1153: \!reddit command doesn’t filter nsfw subreddits\.

I would like to finish this

regal archBOT Sep 13, 2020, 5:12 AM

#

ks129

[python-discord/bot] Issue opened: #1154 Add projects subcommands to source command

Add subcommands for different PyDis projects to !source command. For example, SeasonalBot: !source seasonalbot. These subcommands should give short description about project and link to GitHub.

I think these projects should have subcommands:

site
seasonalbot
branding
snekbox
public-stats
django-simple-bulma

regal archBOT Sep 13, 2020, 5:46 AM

#

ks129

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

#

ks129

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

I solved this issue by force-shortening (ignoring word breaks) in case when description will be still too long.

ebon magnetBOT Sep 13, 2020, 5:49 AM

#

Build 20200913.1 failed

Requested by

GitHub

Duration

00:02:33

Build pipeline

Bot

north knotBOT Sep 13, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 13, 2020, 7:10 AM

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #65 lemon\_ping and lemon\_grimace emoji additions

So good. I need them now.

#

lemonsaurus

[python-discord/branding] Pull request closed: #65 lemon\_ping and lemon\_grimace emoji additions

#

lemonsaurus

[branding:master] 3 new commits

ea97ed2 lemon_ping emoji addition - janine9vn
359fe54 lemon_grimace emoji addition - janine9vn
5aeac08 Merge pull request #65 from janine9vn/master - lemonsaurus

regal archBOT Sep 13, 2020, 11:30 AM

#

kwzrd

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

#

kwzrd

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

I think this approach is much better, but why are we still running the reason through textwrap.shorten? That shouldn't be necessary anymore, right?

#

AtieP

[python-discord/bot] Pull request review submitted: #1148 New guilds tag

regal archBOT Sep 13, 2020, 12:22 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 13, 2020, 1:17 PM

#

ks129

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

#

ks129

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

I think this should be still there, because this try first soft-shortening (breaking between words) and when after this string is still too long, this force-break, what may break word.

#

kwzrd

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

#

kwzrd

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

That is true, but it still suffers from the problem of guessing at what the maximum length should be. I think that for the sake of simplicity and transparency, just the final cut-off would be fine (also easier to make assertions about in the tests). I don't personally see much appeal in keeping whole words if a sentence gets cut off anyway.

ebon magnetBOT Sep 13, 2020, 5:36 PM

#

Build 20200913.1 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

regal archBOT Sep 13, 2020, 5:36 PM

#

AtieP

[python-discord/seasonalbot] New comment on pull request #419: More Questions for the Trivia Quiz

@ikuyarihS Done, I addressed the requested changes.

regal archBOT Sep 13, 2020, 10:01 PM

#

SarcasticNastik

[python-discord/bot] Fork created: SarcasticNastik/bot

#

Hasenn

[python-discord/bot] Issue opened: #1155 Links that are autodeleted by the bot are sometimes still visible to some users

https://cdn.discordapp.com/attachments/267624335836053506/754823336210727003/Screenshot_20200914_005756_com.discord.jpg

steps to reproduce:

post a link
bot fetches the site doc title and description, and deletes the original link
most users don't see the bot's message but some do regardless of being mods or having privileges

for some reason it's timestamped jan 1 1970

#

gustavwilliam

[python-discord/branding] Pull request opened: #67 Updated lemoji template

Fixes issue where some yellow from the lemon shape was shown on the edges of the beard
Makes lemon shape fully symmetrical (excluding the hair)

Here's a preview of the new template:

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #67 Updated lemoji template

symmetrical lemon, yes. I need this in my life.

#

lemonsaurus

[python-discord/branding] Pull request closed: #67 Updated lemoji template

#

lemonsaurus

[branding:master] 3 new commits

e635914 Update lemoji template - gustavwilliam
d4f6672 Merge branch 'master' of https://github.com/pyt... - gustavwilliam
d52cb6c Merge pull request #67 from gustavwilliam/symme... - lemonsaurus

north knotBOT Sep 14, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 14, 2020, 7:27 AM

#

SebastiaanZ

[async-rediscache:master] 3 new commits

c2327a4 Remove check for duplicate namespaces - SebastiaanZ
a76cbb8 Allow RedisObject to bypass global namespace - SebastiaanZ
fe5eefc Add tests for namespacing of RedisObject instances - SebastiaanZ

regal archBOT Sep 14, 2020, 12:01 PM

#

MinerBryan

[python-discord/bot] Fork created: MinerBryan/bot

regal archBOT Sep 14, 2020, 12:22 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 14, 2020, 1:22 PM

#

RohanJnr

[python-discord/site] New comment on issue #367: Youtube Push Notifications in Discord\.

Sorry for being late,
I feel tutorials could be a great choice for notification. Channel examples:

Corey MS
Python programming tutorials.
Traversy Media
Mostly related to JS, but also covers other languages too (this channel has kinda become a replica of freecodecamp now).
coding For Entrepreneurs
This one is my favorite. Great Django and python tutorials. Recently uploading 30 days of python series.
JetBrains TV
IDE related and python tutorials occasionally.

The above-m...

regal archBOT Sep 14, 2020, 8:34 PM

#

ZonaBRDev

[python-discord/bot] Issue opened: #1156 A

A

#

Den4200

[python-discord/bot] New comment on issue #1156: A

Spam is not appreciated, don't waste our time.

#

Den4200

[python-discord/bot] Issue closed: #1156 A

#

aaravm4

[python-discord/seasonalbot] Issue opened: #437 Bot not able to catch answers typed in bursts

Description

I was using the .quiz command with the Seasonal Bot, and the question was When did World War I start? I put a bunch of years between 1910 and 1920 one after another and I had typed the correct answer 1914 but the Bot wasn't able to detect that even though it said the correct answer was 1914.

Steps to Reproduce

You can look at the quiz thread

I basically jus...

regal archBOT Sep 14, 2020, 11:42 PM

#

AlexEshoo

[python-discord/bot] Fork created: AlexEshoo/bot

regal archBOT Sep 15, 2020, 12:06 AM

#

AlexEshoo

[python-discord/site] Fork created: AlexEshoo/site

regal archBOT Sep 15, 2020, 4:20 AM

#

ikuyarihS

[python-discord/bot] New comment on issue #1153: \!reddit command doesn’t filter nsfw subreddits\.

@RohanJnr I've assigned the issue to you

ebon magnetBOT Sep 15, 2020, 4:21 AM

#

Build 20200915.1 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

regal archBOT Sep 15, 2020, 5:21 AM

#

RohanJnr

[python-discord/bot] New comment on issue #1153: \!reddit command doesn’t filter nsfw subreddits\.

thanks

north knotBOT Sep 15, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 15, 2020, 7:06 AM

#

RohanJnr

[python-discord/bot] Pull request opened: #1157 Restrict nsfw subreddit\(s\) or similar

closes #1153

Changes made to Reddit Cog:

Check if the subreddit is NSFW or similar by using the over_18 boolean value got with the API response.
if True, then send an error message.
if False, the fetched data is sent to the user.
A small change to the return format of the fetch_posts() method, instead of returning an empty list in case of an error, it now returns a list, with a dict containing the error message. This is done in order to distinguish between the ...

ebon magnetBOT Sep 15, 2020, 7:09 AM

#

Build 20200915.1 succeeded

Requested by

GitHub

Duration

00:02:58

Build pipeline

Bot

regal archBOT Sep 15, 2020, 7:31 AM

#

SebastiaanZ

[async-rediscache:master] 1 new commit

c290343 Make compound transactions atomic within namespace - SebastiaanZ

regal archBOT Sep 15, 2020, 11:12 AM

#

thomaspet

[python-discord/site] Issue opened: #392 Note on "Using Local Images in Embeds" in discord\.py guide

We should add a note on the "Using Local Images in Embeds" section, stating that the filename parameter of discord.File should be the same as the end of the embed url (after attachment://)

Suggested by 609540346304659477 (RaVen) in #discord.py

bilde

regal archBOT Sep 15, 2020, 12:05 PM

#

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #419 More Questions for the Trivia Quiz

regal archBOT Sep 15, 2020, 12:21 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 15, 2020, 2:31 PM

#

Akarys42

[python-discord/site] New comment on pull request #381: 100k milestone timeline page

I’d just like to mention that I put together a little document some time ago of another PyDis timeline, maybe that could help you to complete this one.

regal archBOT Sep 15, 2020, 9:43 PM

#

kriseax

[python-discord/bot] Fork created: kriseax/bot

north knotBOT Sep 16, 2020, 6:00 AM

#

Postgres backup completed!

ebon magnetBOT Sep 16, 2020, 8:17 AM

#

Build 20200916.1 failed

Requested by

GitHub

Duration

00:01:07

Build pipeline

Seasonal Bot

#

Build 20200916.2 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

regal archBOT Sep 16, 2020, 8:38 AM

#

gustavwilliam

[python-discord/seasonalbot] New comment on issue #436: Beardify — Lemoji beard structure text generator

TL;DR: I've begun implementing this myself.

I have a few updates to the implementation of it:

Resulting text will be returned as a png
Emojis will be on a separate server
Multiple different fonts can be used (one exists as of now). The font height between fronts and letter width within fonts is variable

I'll write more about the custom emoji font format soon, if anyone is interested in contributing with more fonts!

regal archBOT Sep 16, 2020, 8:57 AM

#

Anubhav1603

[python-discord/seasonalbot] Pull request opened: #438 Partnerzodiac subcommand

"Closes #414"

Added two subcommand
- zodiac
- date

searching with zodiac

searching with month and date

error

[x] Join the [**Python Discord ...

#

python-discord-bot

[python-discord/seasonalbot] New comment on pull request #438: Partnerzodiac subcommand

Thank you for contributing to Python Discord!

Please check out the following documents:

Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
Python Discord Contributor Wiki - A set of resources about setting up our services
Python Discord Code of Conduct - Code of conduct for our commu...

#

Anubhav1603

[python-discord/seasonalbot] Pull request closed: #438 Partnerzodiac subcommand

#

Anubhav1603

[python-discord/seasonalbot] New comment on pull request #438: Partnerzodiac subcommand

it pulling data of wiki command also

ebon magnetBOT Sep 16, 2020, 8:59 AM

#

Build 20200916.3 succeeded

Requested by

GitHub

Duration

00:01:03

Build pipeline

Seasonal Bot

regal archBOT Sep 16, 2020, 9:53 AM

#

lemonsaurus

[python-discord/branding] Issue opened: #68 Recreate the dice emoji with PyDis colors\.

We currently have dice emoji in our community, which are used quite actively both by our users and in a seasonalbot feature .roll. They look like this:

https://cdn.discordapp.com/emojis/431249694467948544.png?v=1

It's been suggested that we could rebrand these to have pydis colors, and I think this is a good idea. This issue asks you to create these rebranded pydis dice.

ebon magnetBOT Sep 16, 2020, 10:08 AM

#

Build 20200916.4 succeeded

Requested by

GitHub

Duration

00:01:09

Build pipeline

Seasonal Bot

ebon magnetBOT Sep 16, 2020, 10:34 AM

#

Build 20200916.6 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

regal archBOT Sep 16, 2020, 10:40 AM

#

MagicTurtle2203

[python-discord/branding] New comment on issue #68: Recreate the dice emoji with PyDis colors\.

A while ago, a member pointed out that the layout of the dice is incorrect. For a standard die, opposite sides should add up to 7. In the picture above, however, 3 and 4 are next to each other rather than on opposite sides. This problem also exists in the other dice. This issue would be a good opportunity to correct the layout of the dice as well.

regal archBOT Sep 16, 2020, 11:07 AM

#

lemonsaurus

[python-discord/bot] New comment on issue #416: How should the global error handler handle errors when a command/cog has its own error handler?

@MarkKoz can this be closed?

#

lemonsaurus

[python-discord/bot] New comment on issue #513: Standardized format instead of Slow\-mode in show\-your\-projects

No longer relevant, as this channel has been archived.

#

lemonsaurus

[python-discord/bot] Issue closed: #513 Standardized format instead of Slow\-mode in show\-your\-projects

ebon magnetBOT Sep 16, 2020, 11:22 AM

#

Build 20200916.7 failed

Requested by

GitHub

Duration

00:01:02

Build pipeline

Seasonal Bot

regal archBOT Sep 16, 2020, 11:23 AM

#

lemonsaurus

[python-discord/bot] New comment on issue #532: Slim down the role embed

I've edited this issue now since !mention is no longer relevant to us - I still think we want this slimming down of the role embed, it looks great.

#

gustavwilliam

[python-discord/branding] New comment on issue #68: Recreate the dice emoji with PyDis colors\.

@lemonsaurus could you assign me this, here on GitHub as well?

@MagicTurtle2203 At least the first design iteration will be flat, eliminating this issue. If this doesn't quite work (which I doubt), we'll make sure to get that right.

#

scragly

[python-discord/bot] New comment on issue #532: Slim down the role embed

Good to know. I'll put it on the todo immediately after the site admin pages which I'm working on atm. Thanks lemon.

#

Anubhav1603

[python-discord/seasonalbot] Pull request opened: #439 Partnerzodiac

"Closes #414 "

Added partnerzodiac subcommands -zodiac and date

[x] Join the Python Discord Community?
[x] If dependencies h...

#

python-discord-bot

[python-discord/seasonalbot] New comment on pull request #439: Partnerzodiac

Thank you for contributing to Python Discord!

Please check out the following documents:

Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
Python Discord Contributor Wiki - A set of resources about setting up our services
Python Discord Code of Conduct - Code of conduct for our commu...

#

Anubhav1603

[python-discord/seasonalbot] New comment on pull request #439: Partnerzodiac

Sorry but i dont know y but its fetching my old commits also

ebon magnetBOT Sep 16, 2020, 11:32 AM

#

Build 20200916.8 failed

Requested by

GitHub

Duration

00:00:58

Build pipeline

Seasonal Bot

regal archBOT Sep 16, 2020, 11:32 AM

#

Anubhav1603

[python-discord/seasonalbot] New comment on pull request #439: Partnerzodiac

last two commits are the commits which are used for partnerzodiac subcommand

ebon magnetBOT Sep 16, 2020, 11:43 AM

#

Build 20200916.9 failed

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

#

Build 20200916.10 succeeded

Requested by

GitHub

Duration

00:01:06

Build pipeline

Seasonal Bot

regal archBOT Sep 16, 2020, 12:00 PM

#

lemonsaurus

[python-discord/bot] New comment on issue #532: Slim down the role embed

Sounds good, @scragly. Looks like maybe you already have this solved and it just needs to be a pull request, so I think you're exactly the right person to handle it.

regal archBOT Sep 16, 2020, 12:22 PM

#

[site] GitHub Actions checks success on master

#

lemonsaurus

[python-discord/branding] New comment on issue #68: Recreate the dice emoji with PyDis colors\.

Thanks, assigned!

regal archBOT Sep 16, 2020, 1:00 PM

#

kosayoda

[python-discord/bot] Pull request review submitted: #1126 Whitelist the modmail category for displaying verbose infraction info from the user command

Works good.

regal archBOT Sep 16, 2020, 3:34 PM

#

Senjan21

[bot:config\-update] 1 new commit

9314552 Updating names of reddit emotes. - Senjan21

#

Senjan21

[python-discord/bot] New branch created: config\-update

#

Senjan21

[python-discord/bot] Pull request opened: #1158 Updated the names of reddit emotes

Names of emotes used in #reddit have been changed to have reddit_ prefixed in their name, config must be updated so bot still can use those emotes without problems.

#

kosayoda

[python-discord/bot] Pull request review submitted: #927 Truncate internal eval\.

Stone solid.

ebon magnetBOT Sep 16, 2020, 3:40 PM

#

Build 20200916.1 succeeded

Requested by

GitHub

Duration

00:03:04

Build pipeline

Bot

regal archBOT Sep 16, 2020, 3:49 PM

#

kosayoda

[python-discord/bot] Issue closed: #907 Truncate internal eval responses over 2000 characters

#

kosayoda

[python-discord/bot] Pull request closed: #927 Truncate internal eval\.

#

kosayoda

[bot:master] 23 new commits

f0795ea Create utility function for uploading to paste ... - Numerlor
4980726 Attempt requests multiple times with connection... - Numerlor
2644316 Send long eval output to paste service. - Numerlor
1b98e6c Increase log level. - Numerlor
d0d2054 Handle failed paste uploads. - Numerlor

#

kosayoda

[python-discord/bot] New comment on issue #1155: Links that are autodeleted by the bot are sometimes still visible to some users

Thank you for the feedback, but this is very likely an issue on Discord's end. I'm closing this until it's verifiable that it's a bug with our bot.

#

kosayoda

[python-discord/bot] Issue closed: #1155 Links that are autodeleted by the bot are sometimes still visible to some users

north knotBOT Sep 16, 2020, 3:54 PM

#

Auto-deployed: bot

ebon magnetBOT Sep 16, 2020, 3:54 PM

#

Build 20200916.3 succeeded

Requested by

GitHub

Duration

00:04:38

Build pipeline

Bot

oak estuaryBOT Sep 16, 2020, 3:54 PM

#

Python Bot

Connected!

regal archBOT Sep 16, 2020, 4:24 PM

#

gustavwilliam

[python-discord/branding] Pull request opened: #69 Recreated dice emojis

This PR adds new PyDis branded dice emojis. Here's a preview, as seen from Discord clients using both dark and light mode:

This resolves #68.

#

SebastiaanZ

[async-rediscache:master] 5 new commits

d8e4bf3 Fix deadlocks in methods that call other methods - SebastiaanZ
74ff2e7 Remove local package build and publication tools - SebastiaanZ
57ad2a1 Ignore function name linting error for tests - SebastiaanZ
cbe8e95 Add unittests for our Redis types - SebastiaanZ
07e4ee9 Add GitHub Actions for linting and unit tests - SebastiaanZ

#

[async-rediscache] GitHub Actions checks failure on master

#

SebastiaanZ

[async-rediscache:master] 1 new commit

3f5fe9f Use system version of python instead of pipenv - SebastiaanZ

#

[async-rediscache] GitHub Actions checks success on master

#

SebastiaanZ

[async-rediscache:master] 1 new commit

6c6e8ae Bump version to 0.1.1 - SebastiaanZ

#

[async-rediscache] GitHub Actions checks success on master

#

SebastiaanZ

[python-discord/async-rediscache] New tag created: v0\.1\.1

#

[async-rediscache] GitHub Actions checks success on v0\.1\.1

regal archBOT Sep 16, 2020, 5:42 PM

#

Senjan21

[bot:config\-update] 1 new commit

f8272b4 update the reddit emojis to actual emojis' - Senjan21

#

Senjan21

[bot:config\-update] 1 new commit

6cef33e remove random space in upvotes value - Senjan21

#

Senjan21

[python-discord/bot] Pull request closed: #1158 Updated the names of reddit emotes

#

Senjan21

[bot:master] 4 new commits

9314552 Updating names of reddit emotes. - Senjan21
f8272b4 update the reddit emojis to actual emojis' - Senjan21
6cef33e remove random space in upvotes value - Senjan21
ce8d758 Merge pull request #1158 from python-discord/co... - Senjan21

#

Senjan21

[python-discord/bot] branch deleted: config\-update

ebon magnetBOT Sep 16, 2020, 5:47 PM

#

Build 20200916.5 succeeded

Requested by

GitHub

Duration

00:02:48

Build pipeline

Bot

north knotBOT Sep 16, 2020, 5:50 PM

#

Auto-deployed: bot

ebon magnetBOT Sep 16, 2020, 5:50 PM

#

Build 20200916.6 succeeded

Requested by

GitHub

Duration

00:04:13

Build pipeline

Bot

oak estuaryBOT Sep 16, 2020, 5:50 PM

#

Python Bot

Connected!

regal archBOT Sep 16, 2020, 6:08 PM

#

Lvl4Sword

[python-discord/site] New comment on issue #355: Fix issues in https://web\.dev/measure

@MarkKoz Not anymore, no.
Since I'm not part of the organization, I'll need to be removed from this. Thanks :+1:

#

Lvl4Sword

[python-discord/site] Issue closed: #355 Fix issues in https://web\.dev/measure

regal archBOT Sep 16, 2020, 8:26 PM

#

AnonGuy

[python-discord/branding] Pull request review submitted: #66 New PyDis\-Snake emoji tileset

#

AnonGuy

[python-discord/branding] Pull request review submitted: #69 Recreated dice emojis

#

AnonGuy

[python-discord/branding] Issue closed: #68 Recreate the dice emoji with PyDis colors\.

#

AnonGuy

[python-discord/branding] Pull request closed: #69 Recreated dice emojis

#

AnonGuy

[branding:master] 3 new commits

fc8dde0 Add new dice emojis - gustavwilliam
353d7ec Merge branch 'master' of https://github.com/pyt... - gustavwilliam
95eb0c5 Merge pull request #69 from gustavwilliam/master - AnonGuy

#

AnonGuy

[python-discord/branding] Pull request review submitted: #66 New PyDis\-Snake emoji tileset

#

AnonGuy

[python-discord/branding] Pull request closed: #66 New PyDis\-Snake emoji tileset

#

AnonGuy

[branding:master] 6 new commits

97ed015 Add PyDis-Snake tileset pngs - gustavwilliam
6e2580b Add PyDis-Snake tileset svgs - gustavwilliam
400ad3f Move lemoji-beard tileset files - gustavwilliam
7af27f1 Change name of lemoji-beard files to match conv... - gustavwilliam
e901a1e Merge branch 'master' of https://github.com/pyt... - gustavwilliam

regal archBOT Sep 16, 2020, 8:57 PM

#

gustavwilliam

[python-discord/seasonalbot] Issue opened: #440 \.dice doesn’t display emojis

Description

After an update to the server's dice emojis' names (together with updated designs), the output of .dice will be the string of the old emoji names, instead of the new ones. This causes it to be displayed as text.

Steps to Reproduce

Send .roll in any channel that accepts the command.

Expected Behaviour

Assuming that the output is 3, the returned string should be:
:dice_3:

This would be converted to the correct emoji by Discord.

Actual Behaviour

The output of...

regal archBOT Sep 16, 2020, 10:03 PM

#

gustavwilliam

[python-discord/seasonalbot] Pull request opened: #441 Update \.roll to use new dice emojis

Relevant Issues

Closes #440.

Description

Emojis in constants.py were replaced with the new emojis, following the dice redesign
.roll command was updated to use the new emoji names in constants.py

Did you:

[x] Join the Python Discord Community?
[x] If dependencies have been added or updated, run pipenv lock?
[x] Lint your code (pipenv run lint)?
[x] Set the PR to allow edits from contributors?

#

python-discord-bot

[python-discord/seasonalbot] New comment on pull request #441: Update \.roll to use new dice emojis

Thank you for contributing to Python Discord!

Please check out the following documents:

Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
Python Discord Contributor Wiki - A set of resources about setting up our services
Python Discord Code of Conduct - Code of conduct for our commu...

ebon magnetBOT Sep 16, 2020, 10:04 PM

#

Build 20200916.11 succeeded

Requested by

GitHub

Duration

00:01:02

Build pipeline

Seasonal Bot

regal archBOT Sep 16, 2020, 10:14 PM

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #441 Update \.roll to use new dice emojis

Nice, only one small request.

#

Den4200

[python-discord/seasonalbot] New review comment on pull request #441: Update \.roll to use new dice emojis

Maybe also rename the variable to dice or die?

#

gustavwilliam

[python-discord/seasonalbot] Pull request review submitted: #441 Update \.roll to use new dice emojis

#

gustavwilliam

[python-discord/seasonalbot] New review comment on pull request #441: Update \.roll to use new dice emojis

Sure; we could do that. The emojis on the server are called dice_X, though.

If we rename this, I think we should rename the server icons as well.

ebon magnetBOT Sep 16, 2020, 10:34 PM

#

Build 20200916.12 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

regal archBOT Sep 16, 2020, 10:41 PM

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #441 Update \.roll to use new dice emojis

Looks good to me, thanks!

regal archBOT Sep 16, 2020, 11:14 PM

#

kwzrd

[python-discord/seasonalbot] Pull request review submitted: #441 Update \.roll to use new dice emojis

Thanks for the fix!

#

kwzrd

[python-discord/seasonalbot] Issue closed: #440 \.dice doesn’t display emojis

#

kwzrd

[python-discord/seasonalbot] Pull request closed: #441 Update \.roll to use new dice emojis

#

kwzrd

[seasonalbot:master] 3 new commits

c8ba498 Update .roll to use new dice emojis - gustavwilliam
f1ac628 Update variable name from terning to dice - gustavwilliam
5d817bb Merge pull request #441 from gustavwilliam/master - kwzrd

north knotBOT Sep 16, 2020, 11:18 PM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 16, 2020, 11:18 PM

#

Build 20200916.13 succeeded

Requested by

GitHub

Duration

00:02:20

Build pipeline

Seasonal Bot

night lilyBOT Sep 16, 2020, 11:18 PM

#

SeasonalBot

Connected!

regal archBOT Sep 16, 2020, 11:18 PM

#

MarkKoz

[python-discord/bot] New comment on issue #416: How should the global error handler handle errors when a command/cog has its own error handler?

Yes. I don't strongly feel that testing it is necessary. If someone forgets to add the attribute, it's not a big problem. It's not hard to notice or fix.

#

MarkKoz

[python-discord/bot] Issue closed: #416 How should the global error handler handle errors when a command/cog has its own error handler?

regal archBOT Sep 17, 2020, 12:05 AM

#

MarkKoz

[python-discord/bot] Issue opened: #1159 Remove alias cog

Since the merging of #1124, only 3 alias commands remain, listed below. All usage statistics are since stats have been tracked, which is around April of 2020.

!get docs - alias for !docs get
- Usage: 4 times
- Usage of !docs get: 793 times
- Usage of !docs: 9240 times (includes all the above and empty arg invocations)
!get tags - alias for !tags get
- Usage: 0 times
- Usage of !tags get: 4 times
- Usage of !tags: 720 times (includes all ...

#

Anubhav1603

[python-discord/seasonalbot] Pull request closed: #439 Partnerzodiac

regal archBOT Sep 17, 2020, 3:05 AM

#

Den4200

[python-discord/seasonalbot] Pull request review submitted: #419 More Questions for the Trivia Quiz

Thanks @AtieP!

ebon magnetBOT Sep 17, 2020, 3:07 AM

#

Build 20200917.1 succeeded

Requested by

GitHub

Duration

00:01:06

Build pipeline

Seasonal Bot

regal archBOT Sep 17, 2020, 3:07 AM

#

Den4200

[python-discord/seasonalbot] Pull request closed: #419 More Questions for the Trivia Quiz

#

Den4200

[seasonalbot:master] 9 new commits

217b429 6 more questions added. - AtieP
ab63770 Update bot/resources/evergreen/trivia_quiz.json - AtieP
9eaaf91 Update bot/resources/evergreen/trivia_quiz.json - AtieP
49b9933 Update bot/resources/evergreen/trivia_quiz.json - AtieP
42bde31 Merge branch 'master' into master - jodth07

north knotBOT Sep 17, 2020, 3:09 AM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 17, 2020, 3:10 AM

#

Build 20200917.2 succeeded

Requested by

GitHub

Duration

00:02:27

Build pipeline

Seasonal Bot

night lilyBOT Sep 17, 2020, 3:10 AM

#

SeasonalBot

Connected!

ebon magnetBOT Sep 17, 2020, 3:49 AM

#

Build 20200917.3 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

north knotBOT Sep 17, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 17, 2020, 10:43 AM

#

thomaspet

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

I might be harsh, but it's my honest review at least.

-Chibli

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

        # Ignore pages with "may refer to"

Sounds better stay neutral, in addition the comment should probably state why we ignore them. Personally I have no idea just reading the comment. Is there no information on those pages?

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

        if not search_results:

Pythonic, and might catch a None / False instead of an empty list

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Does it return a list of what i searched for? Or a list of results containing my search quest?

ebon magnetBOT Sep 17, 2020, 10:54 AM

#

Build 20200917.5 succeeded

Requested by

GitHub

Duration

00:00:58

Build pipeline

Seasonal Bot

#

Build 20200917.6 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

#

Build 20200917.7 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

#

Build 20200917.8 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

regal archBOT Sep 17, 2020, 11:02 AM

#

Anubhav1603

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

Anubhav1603

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

It returns a list
Screenshot_2020-09-17-16-31-13-895

ebon magnetBOT Sep 17, 2020, 11:05 AM

#

Build 20200917.10 succeeded

Requested by

GitHub

Duration

00:01:05

Build pipeline

Seasonal Bot

#

Build 20200917.9 succeeded

Requested by

GitHub

Duration

00:01:03

Build pipeline

Seasonal Bot

regal archBOT Sep 17, 2020, 12:21 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 17, 2020, 2:16 PM

#

Anubhav1603

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

Anubhav1603

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

i am doing str concating because list concating is taking 160 character s_desc = "\n".join([f'`{index}` [{title}]({WIKIPEDIA_URL.format(title=title.replace(" ", "_"))})for (index, title) in enumerate(titles, start=1)])` and flake8 is failing that as we are allowed 120 char only

#

Anubhav1603

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

Anubhav1603

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

others are mostly string or int thats y i have not typed them

ebon magnetBOT Sep 17, 2020, 2:27 PM

#

Build 20200917.11 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

regal archBOT Sep 17, 2020, 5:53 PM

#

Senjan21

[seasonalbot:reddit\-command\-fix] 1 new commit

c501cdf fix reddit command to use new emojis. - Senjan21

#

Senjan21

[python-discord/seasonalbot] New branch created: reddit\-command\-fix

#

Senjan21

[python-discord/seasonalbot] Pull request opened: #442 fix \`reddit\` command to use new emojis\.

Description

Changed the ID's to use ID's of new emojis.

Reasoning

Old emojis were removed from the server and moved to emojis server.

Did you:

[x] Join the Python Discord Community?
[x] If dependencies have been added or updated, run pipenv lock?
[x] Lint your code (pipenv run lint)?
[x] Set the PR to allow edits from contributors?

#

python-discord-bot

[python-discord/seasonalbot] New comment on pull request #442: fix \`reddit\` command to use new emojis\.

Thank you for contributing to Python Discord!

Please check out the following documents:

Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
Python Discord Contributor Wiki - A set of resources about setting up our services
Python Discord Code of Conduct - Code of conduct for our commu...

#

scragly

[python-discord/seasonalbot] Pull request review submitted: #442 fix \`reddit\` command to use new emojis\.

Noice

ebon magnetBOT Sep 17, 2020, 6:05 PM

#

Build 20200917.12 succeeded

Requested by

GitHub

Duration

00:01:04

Build pipeline

Seasonal Bot

regal archBOT Sep 17, 2020, 6:06 PM

#

Senjan21

[python-discord/seasonalbot] Pull request closed: #442 fix \`reddit\` command to use new emojis\.

#

Senjan21

[seasonalbot:master] 2 new commits

c501cdf fix reddit command to use new emojis. - Senjan21
f557b9a Merge pull request #442 from python-discord/red... - Senjan21

#

Senjan21

[python-discord/seasonalbot] branch deleted: reddit\-command\-fix

north knotBOT Sep 17, 2020, 6:08 PM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 17, 2020, 6:09 PM

#

Build 20200917.13 succeeded

Requested by

GitHub

Duration

00:02:19

Build pipeline

Seasonal Bot

night lilyBOT Sep 17, 2020, 6:09 PM

#

SeasonalBot

Connected!

regal archBOT Sep 18, 2020, 12:00 AM

#

janine9vn

[python-discord/bot] Issue opened: #1160 \!shh Equivalent Command for Voice Chat

Description

There is currently no way to quickly silence users in voice chat with a command. This currently makes it somewhat difficult to moderate when there are a lot of users in chat talking over each other and the mods. Users also don't always pay attention to the #voice-chat text channel if mods try to de-escalate a situation via the text channel.

This suggestion would be to implement a !shh-equivalent command that would be run in the voice chat text channels that would apply mut...

regal archBOT Sep 18, 2020, 2:14 AM

#

Anubhav1603

[python-discord/bot] New comment on issue #766: Filtering malicious URLs

I think regex will be good to use in this case

regal archBOT Sep 18, 2020, 3:37 AM

#

kosayoda

[python-discord/bot] New comment on issue #1159: Remove alias cog

Let's do this. Always good to trim unused features.

!exception isn't a suitable alias for traceback anyway, and we have tags for both.

regal archBOT Sep 18, 2020, 5:52 AM

#

scragly

[python-discord/site] New comment on pull request #289: Improvements to Admin pages for the API Section

If you, say, edit a note infraction, you won't be able to save your changes unless you set an expiry date.

The issue for non-expiring infractions being unable to save changes has been addressed coincidentally, but out of concern that the bot infraction tasks will desync if editing expiry is allowed external to the bot.

I've double checked, and turning the expiry read-only results in successful reason edits.

#

scragly

[python-discord/site] New comment on pull request #289: Improvements to Admin pages for the API Section

I'm in the middle of thoroughly testing this branch as I populate my local database, and I've run into an odd bug.

Through the power of laziness, neglect and sheer forgetfulness, much time has passed, and just as the water stream eventually erodes the rock, we have lost the presence of tags in the database, with them being stored back in repos. Hence, time is the true solution to all that is bad with the world.

#

scragly

[site:admin\-api\-pages\-improvements] 368 new commits

ec2ae9d Add validation rules to Infraction serializer - SebastiaanZ
cf1a075 Migrate undesirable active infraction to inactive - SebastiaanZ
0d383cb Prevent double active infractions with constraint - SebastiaanZ
6670a3b Merge branch 'master' into active-infractions-v... - SebastiaanZ
e415428 Solve migration conflict by renaming migrations - SebastiaanZ

north knotBOT Sep 18, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 18, 2020, 6:17 AM

#

scragly

[python-discord/site] New comment on pull request #289: Improvements to Admin pages for the API Section

I've gone through and tweaked edit permissions for certain models, and atm it's showing the following in the admin site:

Figured I'd give a bit of an update. I'll try get a proper update coming tomorrow, but unfortunately I'm absolutely wrecked and need sleep.

regal archBOT Sep 18, 2020, 6:35 AM

#

Senjan21

[python-discord/bot] New comment on issue #593: Write unit tests for \`bot/cogs/wolfram\.py\`

The file has since been removed from the bot to move it to SeasonalBot in PR #1134
Closing as its no longer relevant to the state of the bot.

#

Senjan21

[python-discord/bot] Issue closed: #593 Write unit tests for \`bot/cogs/wolfram\.py\`

regal archBOT Sep 18, 2020, 12:08 PM

#

Quadante

[python-discord/bot] Fork created: Quadante/bot

regal archBOT Sep 18, 2020, 12:31 PM

#

[site] GitHub Actions checks success on master

ebon magnetBOT Sep 18, 2020, 12:52 PM

#

Build 20200918.1 succeeded

Requested by

GitHub

Duration

00:00:56

Build pipeline

Seasonal Bot

ebon magnetBOT Sep 18, 2020, 1:49 PM

#

Build 20200918.1 failed

Requested by

Scragly

Duration

00:01:49

Build pipeline

Site

regal archBOT Sep 18, 2020, 3:02 PM

#

thomaspet

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

s_desc = "\n".join([
    f'`{index}` [{title}]({WIKIPEDIA_URL.format(title=title.replace(" ", "_"))})'
    for index, title
    in enumerate(titles, start=1)
])

It would look cleaner if you combined the 2 for loops that both iterate titles, since you could remove the replace then and just use title_for_creating_link, but I digress.

ebon magnetBOT Sep 18, 2020, 3:03 PM

#

Build 20200918.3 succeeded

Requested by

GitHub

Duration

00:00:52

Build pipeline

Seasonal Bot

regal archBOT Sep 18, 2020, 3:03 PM

#

kosayoda

[python-discord/seasonalbot] Issue closed: #420 Caesar cipher command

#

kosayoda

[python-discord/seasonalbot] Pull request closed: #421 Caesar cipher command

#

kosayoda

[seasonalbot:master] 22 new commits

4b87160 Add initial caesarcipher command - PureFunctor
3e58b35 Make caesarcipher a command group - PureFunctor
baa2050 Add basic caesar cipher information embed - PureFunctor
3260a16 Refactor translate subcommand to encrypt and de... - PureFunctor
f1a79fb Add offset validation - PureFunctor

north knotBOT Sep 18, 2020, 3:07 PM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 18, 2020, 3:07 PM

#

Build 20200918.4 succeeded

Requested by

GitHub

Duration

00:03:24

Build pipeline

Seasonal Bot

night lilyBOT Sep 18, 2020, 3:08 PM

#

SeasonalBot

Connected!

regal archBOT Sep 18, 2020, 3:15 PM

#

thomaspet

[python-discord/seasonalbot] New comment on pull request #430: \!wiki command

I still feel like these 2 could be combined

for title in titles:
    title_for_creating_link = title.replace(" ", "_")  # wikipedia uses "_" as spaces
    titles_no_underscore.append(title_for_creating_link)
log.info("Finished appending titles to titles_no_underscore list")

async with ctx.typing():
    for index, title in enumerate(titles, start=1):
        s_desc += f'`{index}` [{title}]({WIKIPEDIA_URL.format(title=title.replace(" ", "_"))})\n'
    embed = Embed(colour=Color...

#

scragly

[site:admin\-api\-pages\-improvements] 1 new commit

8edeb88 Remove noqa from DeletedMessagesLogURLTests setup. - scragly

ebon magnetBOT Sep 18, 2020, 3:26 PM

#

Build 20200918.2 failed

Requested by

GitHub

Duration

00:02:10

Build pipeline

Site

regal archBOT Sep 18, 2020, 3:41 PM

#

kosayoda

[seasonalbot:bug/message\-convert\-fix] 1 new commit

dc63f50 Stop users from viewing messages they shouldn't. - kosayoda

#

kosayoda

[python-discord/seasonalbot] New branch created: bug/message\-convert\-fix

#

kosayoda

[python-discord/seasonalbot] Pull request opened: #443 Stop users from viewing messages they shouldn't\.

Using a user token, a user could fetch the message ID of a message in any channel, which may leak information when potential Message objects are automatically converted and parsed.

Now, the bot will only retrive text from a valid Message object if the user has read permissions for the message the channel is in.

ebon magnetBOT Sep 18, 2020, 3:44 PM

#

Build 20200918.5 succeeded

Requested by

GitHub

Duration

00:01:16

Build pipeline

Seasonal Bot

regal archBOT Sep 18, 2020, 3:52 PM

#

kwzrd

[python-discord/seasonalbot] Pull request review submitted: #443 Stop users from viewing messages they shouldn't\.

Looks LGTM to me, tested with an alt in the dev server.

#

scragly

[python-discord/seasonalbot] Pull request review submitted: #443 Stop users from viewing messages they shouldn't\.

#

scragly

[python-discord/seasonalbot] Pull request closed: #443 Stop users from viewing messages they shouldn't\.

#

scragly

[seasonalbot:master] 2 new commits

dc63f50 Stop users from viewing messages they shouldn't. - kosayoda
2115079 Merge pull request #443 from python-discord/bug... - scragly

#

scragly

[python-discord/seasonalbot] branch deleted: bug/message\-convert\-fix

north knotBOT Sep 18, 2020, 3:57 PM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 18, 2020, 3:57 PM

#

Build 20200918.6 succeeded

Requested by

GitHub

Duration

00:03:03

Build pipeline

Seasonal Bot

night lilyBOT Sep 18, 2020, 3:57 PM

#

SeasonalBot

Connected!

regal archBOT Sep 18, 2020, 4:23 PM

#

scragly

[site:admin\-api\-pages\-improvements] 1 new commit

520ea63 Update user model in DeletedMessagesLogURLTests. - scragly

ebon magnetBOT Sep 18, 2020, 4:26 PM

#

Build 20200918.3 failed

Requested by

GitHub

Duration

00:02:35

Build pipeline

Site

regal archBOT Sep 18, 2020, 5:39 PM

#

Elektron-blip

[python-discord/bot] Fork created: Elektron-blip/bot

regal archBOT Sep 18, 2020, 8:03 PM

#

Senjan21

[python-discord/bot] New comment on issue #554: Write unit tests for \`bot/cogs/alias\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #554 Write unit tests for \`bot/cogs/alias\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #557: \[Feature Request\] Link GH Account

This feature is now a thing within the discord client thus the issue isn't needed anymore.
SmartSelect_20200918-220422_Discord

#

Senjan21

[python-discord/bot] Issue closed: #557 \[Feature Request\] Link GH Account

#

Senjan21

[python-discord/bot] New comment on issue #566: Write unit tests for \`bot/cogs/watchchannels/\_\_init\_\_\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #566 Write unit tests for \`bot/cogs/watchchannels/\_\_init\_\_\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #567: Write unit tests for \`bot/cogs/watchchannels/bigbrother\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #567 Write unit tests for \`bot/cogs/watchchannels/bigbrother\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #568: Write unit tests for \`bot/cogs/watchchannels/talentpool\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #568 Write unit tests for \`bot/cogs/watchchannels/talentpool\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #569: Write unit tests for \`bot/cogs/watchchannels/watchchannel\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #569 Write unit tests for \`bot/cogs/watchchannels/watchchannel\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #571: Write unit tests for \`bot/cogs/bot\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #571 Write unit tests for \`bot/cogs/bot\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #574: Write unit tests for \`bot/cogs/doc\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #574 Write unit tests for \`bot/cogs/doc\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #576: Write unit tests for \`bot/cogs/eval\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #576 Write unit tests for \`bot/cogs/eval\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #580: Write unit tests for \`bot/cogs/help\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #580 Write unit tests for \`bot/cogs/help\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #581: Write unit tests for \`bot/cogs/information\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #581 Write unit tests for \`bot/cogs/information\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #584: Write unit tests for \`bot/cogs/off\_topic\_names\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #584 Write unit tests for \`bot/cogs/off\_topic\_names\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #585: Write unit tests for \`bot/cogs/reddit\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #585 Write unit tests for \`bot/cogs/reddit\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #586: Write unit tests for \`bot/cogs/reminders\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #586 Write unit tests for \`bot/cogs/reminders\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #587: Write unit tests for \`bot/cogs/site\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #587 Write unit tests for \`bot/cogs/site\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #590: Write unit tests for \`bot/cogs/token\_remover\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #590 Write unit tests for \`bot/cogs/token\_remover\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #591: Write unit tests for \`bot/cogs/utils\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #591 Write unit tests for \`bot/cogs/utils\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #594: Write unit tests for \`bot/patches/message\_edited\_at\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #594 Write unit tests for \`bot/patches/message\_edited\_at\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #605: Write unit tests for \`bot/utils/checks\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #605 Write unit tests for \`bot/utils/checks\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #606: Write unit tests for \`bot/utils/messages\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #606 Write unit tests for \`bot/utils/messages\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #609: Write unit tests for \`bot/\_\_init\_\_\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #609 Write unit tests for \`bot/\_\_init\_\_\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #610: Write unit tests for \`bot/\_\_main\_\_\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #610 Write unit tests for \`bot/\_\_main\_\_\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #612: Write unit tests for \`bot/constants\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #612 Write unit tests for \`bot/constants\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #613: Write unit tests for \`bot/converters\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #613 Write unit tests for \`bot/converters\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #614: Write unit tests for \`bot/decorators\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #614 Write unit tests for \`bot/decorators\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #615: Write unit tests for \`bot/interpreter\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #615 Write unit tests for \`bot/interpreter\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #616: Write unit tests for \`bot/pagination\.py\`

Internal discussions deemed these tests to be unnecessary.

#

Senjan21

[python-discord/bot] Issue closed: #616 Write unit tests for \`bot/pagination\.py\`

#

Senjan21

[python-discord/bot] New comment on issue #623: Python 2 code detection\.

Considering Python2 is EOL since January of this year, we don't really need this feature.

#

Senjan21

[python-discord/bot] Issue closed: #623 Python 2 code detection\.

regal archBOT Sep 18, 2020, 9:58 PM

#

Senjan21

[python-discord/bot] Pull request review submitted: #1152 Make nomination reason optional

LGTM

regal archBOT Sep 19, 2020, 12:02 AM

#

Numerlor

[python-discord/bot] New comment on issue #1067: Remove sphinx dependency

I'll go ahead and push this into #1014 in the near future if there's nobody against it.
Should the sphinx license be handled like in #886 with the same file?

regal archBOT Sep 19, 2020, 1:36 AM

#

papix2020

[python-discord/bot] Fork created: papix2020/bot

regal archBOT Sep 19, 2020, 4:14 AM

#

PureFunctor

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

There should be no need to add type hinting for message in this case as it's local to the try-except block and doesn't actually do anything at runtime.

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

.join should be able to accept a generator expression just fine as well. I also suggest refactoring the formatting into a staticmethod if it means making the expression much more readable.

s_desc = "\n".join(
    self._format_wikipedia_url(index, title)
    for index, title in enumerate(titles, start=1)
)

#

RohanJnr

[python-discord/bot] New comment on issue #1119: Smart syncing of users to the site

I would like to work on this too as I have been working on the related site issue too
https://github.com/python-discord/site/pull/378

north knotBOT Sep 19, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 19, 2020, 6:11 AM

#

kosayoda

[bot:bug/1142/fix\-everyone\-ping] 94 new commits

f0795ea Create utility function for uploading to paste ... - Numerlor
4980726 Attempt requests multiple times with connection... - Numerlor
2644316 Send long eval output to paste service. - Numerlor
1b98e6c Increase log level. - Numerlor
d0d2054 Handle failed paste uploads. - Numerlor

ebon magnetBOT Sep 19, 2020, 6:15 AM

#

Build 20200919.1 succeeded

Requested by

GitHub

Duration

00:03:08

Build pipeline

Bot

regal archBOT Sep 19, 2020, 7:48 AM

#

ks129

[python-discord/site] Fork created: ks129/site

regal archBOT Sep 19, 2020, 10:04 AM

#

SebastiaanZ

[async-rediscache:release/test/pipeline] 1 new commit

f2092a7 Update release workflow - SebastiaanZ

#

SebastiaanZ

[python-discord/async-rediscache] New branch created: release/test/pipeline

#

[async-rediscache] GitHub Actions checks success on release/test/pipeline

#

SebastiaanZ

[async-rediscache:release/test/pipeline] 1 new commit

f76bc36 Update release workflow - SebastiaanZ

#

ks129

[python-discord/site] New comment on issue #383: Dewikification: Make an app to serve guides

I will work on it

regal archBOT Sep 19, 2020, 10:55 AM

#

SebastiaanZ

[async-rediscache:release/test/pipeline] 2 new commits

e630ced Update release workflow - SebastiaanZ
558ed51 Update release workflow - SebastiaanZ

#

SebastiaanZ

[async-rediscache:] 1 new commit

6f64b39 Update release workflow - SebastiaanZ

#

SebastiaanZ

[python-discord/async-rediscache] New tag created: v0\.1\.2\-dev2

#

[async-rediscache] GitHub Actions checks success on v0\.1\.2\-dev2

regal archBOT Sep 19, 2020, 12:21 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 19, 2020, 1:44 PM

#

Senjan21

[python-discord/bot] Pull request review submitted: #1061 Use mentions for users in mod logs and infraction search results

Looks very solid, just 1 small change

#

Senjan21

[python-discord/bot] New review comment on pull request #1061: Use mentions for users in mod logs and infraction search results

eval_msg should end with a space if the is_eval is set to True
Otherwise we will end with
... via DM using !evalwith ... as an example.

regal archBOT Sep 19, 2020, 2:02 PM

#

kosayoda

[python-discord/seasonalbot] Pull request review submitted: #397 Tic\-tac\-toe command

Thank you for the pull request, and sorry for the delay in review. I've done a quick first round of review, which involves some high level changes. Feel free to ask for clarification.

PS: Can you also add a spacer to the first line of the board whenever it is printed? Using the compact display setting, the game looks like this:

#

kosayoda

[python-discord/seasonalbot] New review comment on pull request #397: Tic\-tac\-toe command

A docstring here describing the check would be nice.

#

kosayoda

[python-discord/seasonalbot] New review comment on pull request #397: Tic\-tac\-toe command

This is identical to #L198-L214 and should be factored out to a helper function.

#

kosayoda

[python-discord/seasonalbot] New review comment on pull request #397: Tic\-tac\-toe command

Can you please document the return type here? What do the boolean value and the optional string represent?

#

scragly

[site:admin\-api\-pages\-improvements] 1 new commit

394d1ca Test username property formatting for user model. - scragly

ebon magnetBOT Sep 19, 2020, 2:07 PM

#

Build 20200919.1 succeeded

Requested by

GitHub

Duration

00:02:07

Build pipeline

Site

regal archBOT Sep 19, 2020, 2:11 PM

#

Senjan21

[python-discord/bot] Pull request review submitted: #1150 Implement with\(out\)\_role checks and decorators using has\_any\_role

Code looks very solid :+1:

regal archBOT Sep 19, 2020, 2:30 PM

#

SebastiaanZ

[async-rediscache:master] 5 new commits

a9131e2 Exclude tests package from PyPI release - SebastiaanZ
d10032f Remove dev as optional feature of our release - SebastiaanZ
e369856 Change package url to python-discord GH org - SebastiaanZ
a0f09b0 Specify supported Python versions in setup.py - SebastiaanZ
54ab562 Bump version to 0.1.2 - SebastiaanZ

#

[async-rediscache] GitHub Actions checks success on master

#

SebastiaanZ

[python-discord/async-rediscache] New tag created: v0\.1\.2

#

[async-rediscache] GitHub Actions checks success on v0\.1\.2

regal archBOT Sep 19, 2020, 3:59 PM

#

bast0006

[python-discord/bot] Fork created: bast0006/bot

#

scragly

[site:admin\-api\-pages\-improvements] 1 new commit

a3fe02a Change UserTopRoleFilter to UserRoleFilter. - scragly

#

scragly

[site] Branch admin\-api\-pages\-improvements was force-pushed to `dafca0f`

Compare changes

#

[site] Azure Pipelines checks cancelled on admin\-api\-pages\-improvements

ebon magnetBOT Sep 19, 2020, 4:09 PM

#

Build 20200919.3 succeeded

Requested by

GitHub

Duration

00:02:13

Build pipeline

Site

regal archBOT Sep 19, 2020, 4:09 PM

#

[site] GitHub Code Scanning checks success on admin\-api\-pages\-improvements

#

[site] GitHub Code Scanning checks success on admin\-api\-pages\-improvements

#

[site] GitHub Actions checks success on admin\-api\-pages\-improvements

#

[site] GitHub Actions checks success on admin\-api\-pages\-improvements

#

SebastiaanZ

[python-discord/async-rediscache] New comment on issue #1: Set up linting check suite in GitHub actions

I've set up a simple linting CI using GitHub actions. It's currently not using one of the actions from the marketplace; it's just using plain flake8.

#

scragly

[python-discord/async-rediscache] New comment on issue #1: Set up linting check suite in GitHub actions

Does it have inline code annotations

#

SebastiaanZ

[python-discord/async-rediscache] New comment on issue #1: Set up linting check suite in GitHub actions

Not yet, but I'm planning on changing that later.

To be able to use such actions, we'll need to change the trigger event to pull_request_target, which will slightly change the way in which the workflow works. I think it only means that it will use the already committed workflow file, so it's safer to expose the secrets needed for such annotations actions, but it's still a bit vague.

Another thing that the current annotations actions don't have is the option to also just print the flak...

regal archBOT Sep 19, 2020, 5:45 PM

#

bast0006

[python-discord/bot] Pull request opened: #1161 Add userid decoding and user token detection to the token removal moderation feature

This PR edits token_remover to add the following features:

Decode and report a discord user ID from a detected token
Check the user ID against the server, and if found, report within the alerting channel and additionally ping everyone
Check the HMAC portion of the token against low-entropy: if it has less than four case-insensitive characters, it's probably a dummy value (like Xxxxxxxxxx), and thus it's not a "valid" token and won't be actioned )

I've left the HMAC portion in a se...

#

python-discord-bot

[python-discord/bot] New comment on pull request #1161: Add userid decoding and user token detection to the token removal moderation feature

Thank you for contributing to Python Discord!

Please check out the following documents:

Join the Discord server! - If you have not already, join the Discord server and introduce yourself in our #dev-contrib channel.
Python Discord Contributor Wiki - A set of resources about setting up our services
Python Discord Code of Conduct - Code of conduct for our commu...

ebon magnetBOT Sep 19, 2020, 5:48 PM

#

Build 20200919.2 failed

Requested by

GitHub

Duration

00:02:29

Build pipeline

Bot

regal archBOT Sep 19, 2020, 6:27 PM

#

SebastiaanZ

[python-discord/bot] Issue opened: #1162 Replace \`bot\.utils\.redis\_cache\` by \`async\-rediscache\` package

We've recently published a PyPI package, async-rediscache, that contains all of the functionality of the RedisCache class that we use in our bot and more. This means that it's now time to remove the RedisCache implementation from this repository and use the async-rediscache package instead.

While it's mostly a drop-in replacement, there are a few differences as well in that the package offers a new data type, RedisQueue, which is go...

regal archBOT Sep 19, 2020, 6:52 PM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #1061 Use mentions for users in mod logs and infraction search results

#

MarkKoz

[python-discord/bot] New review comment on pull request #1061: Use mentions for users in mod logs and infraction search results

        eval_msg = "using !eval " if is_eval else ""

#

MarkKoz

[bot:feat/frontend/533/mod\-log\-names] 1 new commit

1480232 Filtering: add missing space to log msg - MarkKoz

#

scragly

[site:admin\-api\-pages\-improvements] 1 new commit

715dd46 Allow Nomination end_reason to have a blank val... - scragly

ebon magnetBOT Sep 19, 2020, 7:06 PM

#

Build 20200919.4 succeeded

Requested by

GitHub

Duration

00:02:10

Build pipeline

Site

#

Build 20200919.3 succeeded

Requested by

GitHub

Duration

00:03:03

Build pipeline

Bot

regal archBOT Sep 19, 2020, 7:53 PM

#

SebastiaanZ

[bot:sebastiaan/features/use\-async\-rediscache\-package] 2 new commits

e57fc91 Use async-rediscache package for our redis caches - SebastiaanZ
a522e11 Remove vestigial RedisCache class definition - SebastiaanZ

#

SebastiaanZ

[python-discord/bot] New branch created: sebastiaan/features/use\-async\-rediscache\-package

#

SebastiaanZ

[bot:sebastiaan/features/use\-async\-rediscache\-package] 1 new commit

aca700c Use global namespace bot for our RedisSession - SebastiaanZ

#

SebastiaanZ

[bot] Branch sebastiaan/features/use\-async\-rediscache\-package was force-pushed to `9bb3a48`

Compare changes

#

SebastiaanZ

[python-discord/bot] Pull request opened: #1163 Use \`async\-rediscache\` package for our redis caches

As we've recently isolated the RedisCache code and moved it into its own PyPI package, it's now time to start using that package here in the bot. The main reason for this change is that we can now use RedisCache instances in all of our bots by simply installing a package instead of duplicating the code.

The package and the new RedisCache is pretty much a drop-in replacement, although the internals have changed a bit:

There's now a application-level global namespace to prevent name...

ebon magnetBOT Sep 19, 2020, 8:25 PM

#

Build 20200919.4 succeeded

Requested by

GitHub

Duration

00:03:26

Build pipeline

Bot

regal archBOT Sep 19, 2020, 8:27 PM

#

scragly

[site:admin\-api\-pages\-improvements] 1 new commit

d39eeb9 Change Infraction admin to use fieldsets for be... - scragly

#

Senjan21

[python-discord/bot] Pull request review submitted: #1061 Use mentions for users in mod logs and infraction search results

LGTM

ebon magnetBOT Sep 19, 2020, 8:30 PM

#

Build 20200919.5 succeeded

Requested by

GitHub

Duration

00:02:02

Build pipeline

Site

regal archBOT Sep 19, 2020, 8:40 PM

#

scragly

[site:admin\-api\-pages\-improvements] 2 new commits

9344d8a Change documentation link model to order by pac... - scragly
1916074 Add migrations for nomination and doc link mode... - scragly

#

eivl

[python-discord/bot] Pull request review submitted: #1152 Make nomination reason optional

#

eivl

[python-discord/bot] New review comment on pull request #1152: Make nomination reason optional

Im not seeing it. Maybe I do not understand the Optional annotation. reason: Optional[str] ? like I thought it was to annotate that it could be "falsy" a string.

ebon magnetBOT Sep 19, 2020, 8:42 PM

#

Build 20200919.6 succeeded

Requested by

GitHub

Duration

00:02:04

Build pipeline

Site

regal archBOT Sep 19, 2020, 8:42 PM

#

scragly

[python-discord/bot] Pull request review submitted: #1152 Make nomination reason optional

#

scragly

[python-discord/bot] New review comment on pull request #1152: Make nomination reason optional

Nah, Optional is explicitly Union[str, None], so the alternative must be a NoneType.

#

scragly

[site:admin\-api\-pages\-improvements] 1 new commit

3fc5aa7 Remove delete permission for bot settings admin. - scragly

ebon magnetBOT Sep 19, 2020, 8:48 PM

#

Build 20200919.7 failed

Requested by

GitHub

Duration

00:01:31

Build pipeline

Site

regal archBOT Sep 19, 2020, 9:00 PM

#

scragly

[python-discord/seasonalbot] New comment on issue #433: \.source command

Sounds good, go for it.

#

Xithrius

[python-discord/seasonalbot] New comment on issue #398: Enhancement: Support requesting multiple issues using \.issue

I'll be taking this one.

#

scragly

[python-discord/seasonalbot] New comment on issue #398: Enhancement: Support requesting multiple issues using \.issue

I agree, greedy parsing would be best here, as commas can be problematic especially on mobile.

#

scragly

[site] Branch admin\-api\-pages\-improvements was force-pushed to `a105de7`

Compare changes

ebon magnetBOT Sep 19, 2020, 9:09 PM

#

Build 20200919.8 succeeded

Requested by

GitHub

Duration

00:02:07

Build pipeline

Site

regal archBOT Sep 19, 2020, 9:47 PM

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1103 Move cogs to subdirectories

Everything looks clean to me.

#

Xithrius

[seasonalbot:greedy\-issues] 1 new commit

a13f573 Updated issue/pr command to get multiple links. - Xithrius

#

Xithrius

[python-discord/seasonalbot] New branch created: greedy\-issues

#

Xithrius

[seasonalbot:greedy\-issues] 1 new commit

7a29cce Replaced single quotes with double, set the rep... - Xithrius

#

Xithrius

[seasonalbot:greedy\-issues] 1 new commit

733a634 Described how links are shown in the embed. - Xithrius

#

Xithrius

[python-discord/seasonalbot] Pull request opened: #444 Updated issue/PR command to acquire multiple links\.

Relevant Issues

Closes #398

Description

By looping through the set of number(s) given by the user, this bot will acquire as many links as it can. All links acquired are appended to a list, which is eventually formatted and put into an embed. If any of the issue/PR numbers are incorrect, the bot will stop at the first one giving the error and let the user know what the response from GitHub was.

Reasoning

The loop will be broken out of at the first error, since it's po...

ebon magnetBOT Sep 19, 2020, 10:10 PM

#

Build 20200919.1 succeeded

Requested by

GitHub

Duration

00:01:04

Build pipeline

Seasonal Bot

regal archBOT Sep 19, 2020, 10:23 PM

#

scragly

[python-discord/seasonalbot] Pull request review submitted: #444 Updated issue/PR command to acquire multiple links\.

LGTM

#

Senjan21

[python-discord/seasonalbot] Pull request review submitted: #444 Updated issue/PR command to acquire multiple links\.

LGTM!

#

Senjan21

[python-discord/seasonalbot] Issue closed: #398 Enhancement: Support requesting multiple issues using \.issue

#

Senjan21

[python-discord/seasonalbot] Pull request closed: #444 Updated issue/PR command to acquire multiple links\.

#

Senjan21

[seasonalbot:master] 4 new commits

a13f573 Updated issue/pr command to get multiple links. - Xithrius
7a29cce Replaced single quotes with double, set the rep... - Xithrius
733a634 Described how links are shown in the embed. - Xithrius
8872455 Merge pull request #444 from python-discord/gre... - Senjan21

#

Senjan21

[python-discord/seasonalbot] branch deleted: greedy\-issues

north knotBOT Sep 19, 2020, 10:41 PM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 19, 2020, 10:42 PM

#

Build 20200919.2 succeeded

Requested by

GitHub

Duration

00:02:26

Build pipeline

Seasonal Bot

night lilyBOT Sep 19, 2020, 10:42 PM

#

SeasonalBot

Connected!

regal archBOT Sep 19, 2020, 11:03 PM

#

lemonsaurus

[python-discord/site] Pull request review submitted: #289 Improvements to Admin pages for the API Section

An exceptinoally good PR. Beautifully described, well documented code, concise, and useful.

night lilyBOT Sep 19, 2020, 11:08 PM

#

SeasonalBot

Connected!

regal archBOT Sep 19, 2020, 11:42 PM

#

gustavwilliam

[python-discord/branding] Pull request opened: #70 Fix typo in filename

Prevented emojify command from working correctly by having an image file name that didn't follow the convention.

#

scragly

[python-discord/branding] Pull request closed: #70 Fix typo in filename

#

scragly

[branding:master] 2 new commits

bab0296 Fix typo in filename - gustavwilliam
59d1934 Merge pull request #70 from gustavwilliam/master - scragly

#

gustavwilliam

[python-discord/branding] Pull request opened: #71 Fix typo in directory name

For both the snake and beard, the distobution directory is now called dist
Done in order to imporve consistency and allow SeasonalBot to fetch data automatically

#

jb3

[python-discord/site] Pull request review submitted: #289 Improvements to Admin pages for the API Section

Excellent PR

#

jb3

[python-discord/site] Pull request closed: #289 Improvements to Admin pages for the API Section

#

jb3

[python-discord/site] branch deleted: admin\-api\-pages\-improvements

#

jb3

[site:master] 36 new commits

6ab05d3 Set default example.com dev site to pythondisco... - scragly
e2956b8 Set newest-first sorting for message deletion m... - scragly
f590d2b Add message log links, improved formatting to m... - scragly
618610f Order roles by positioning, add filters and sea... - scragly
0021d4a Improve infractions admin list and page, add se... - scragly

#

[site] GitHub Actions checks success on master

north knotBOT Sep 20, 2020, 12:06 AM

#

Auto-deployed: site

regal archBOT Sep 20, 2020, 12:06 AM

#

[site] Azure Pipelines checks success on master

ebon magnetBOT Sep 20, 2020, 12:06 AM

#

Build 20200920.1 succeeded

Requested by

Joseph Banks

Duration

00:04:18

Build pipeline

Site

regal archBOT Sep 20, 2020, 12:07 AM

#

[site] GitHub Code Scanning checks success on master

#

[site] GitHub Actions checks success on master

regal archBOT Sep 20, 2020, 12:44 AM

#

Den4200

[seasonalbot:fix/issue\-pr\-command] 4 new commits

24b788d Allow issue command in #dev-branding - Den4200
91ca04e Limit maximum PRs/issues to 10 per invocation - Den4200
d777222 Invoke help command when no PRs/issues are given - Den4200
157cc18 Authenticate with the GitHub API to allow for m... - Den4200

#

Den4200

[python-discord/seasonalbot] New branch created: fix/issue\-pr\-command

#

Den4200

[seasonalbot:fix/issue\-pr\-command] 1 new commit

fc58377 Fix order of imports - Den4200

#

Den4200

[python-discord/seasonalbot] Pull request opened: #445 Small fixes for the \.issue command

Description

This PR changes a few things for the .issue command:

Allows use in #dev-branding
Limits the maximum PRs/issues to 10 per command invocation
Invokes the help command when no PRs/issues are given
Makes requests to the GitHub API with authentication

Just some small improvements for this command!

ebon magnetBOT Sep 20, 2020, 12:58 AM

#

Build 20200920.1 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

regal archBOT Sep 20, 2020, 1:11 AM

#

scragly

[python-discord/seasonalbot] Pull request review submitted: #445 Small fixes for the \.issue command

LGTM

north knotBOT Sep 20, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 20, 2020, 6:09 AM

#

Anubhav1603

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

Anubhav1603

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

in constants.py i have stored total chances and its incrementing at every input from user.
User has total of 3 chance if he/she gives 3 wrong input looks breaks, so i dont think is there any chance of infinite loop
or i am missing anything can u tell me how infinite loop can happen.
Loop breaks if these two thing happens also:

If user gives right input
If times up

ebon magnetBOT Sep 20, 2020, 6:21 AM

#

Build 20200920.2 succeeded

Requested by

GitHub

Duration

00:01:05

Build pipeline

Seasonal Bot

regal archBOT Sep 20, 2020, 6:25 AM

#

PureFunctor

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

In my opinion for _ in range(total_chances) or more precisely for _ in range(Wikipedia.total_retries) is a better idiom for this purpose. It's not that probable that somehow, somewhere, something is going to error out and cause an infinite loop but then again, using common idioms helps better with readability.

#

PureFunctor

[python-discord/seasonalbot] New comment on pull request #430: \!wiki command

Looks good! Just a few more changes and it should be fairly ready.

#

Anubhav1603

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

Anubhav1603

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

ok

#

PureFunctor

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

In addendum to using for _ in range(Wikipedia.total_retries), this can probably be refactored to the following:

for retry_count in range(1, Wikipedia.total_retries + 1):
    if retry_count < Wikipedia.total_retries:
        retries_left = Wikipedia.total_retries - retry_count
        error_msg = f"You have `{retries_left}/{Wikipedia.total_retries}` chances left"
    else:
        error_msg = 'Please try again by using `.wiki` command'

Refactor as you see fit.

ebon magnetBOT Sep 20, 2020, 6:45 AM

#

Build 20200920.3 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

ebon magnetBOT Sep 20, 2020, 7:08 AM

#

Build 20200920.4 succeeded

Requested by

GitHub

Duration

00:01:02

Build pipeline

Seasonal Bot

regal archBOT Sep 20, 2020, 12:21 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 20, 2020, 1:23 PM

#

jb3

[python-discord/bot] Pull request review submitted: #886 Code block detection rewrite

#

jb3

[python-discord/bot] New review comment on pull request #886: Code block detection rewrite

We should add pycon here I think, python console is what it is for.

PY_LANG_CODES = ("python", "pycon", "py")  # Order is important; "py" is second cause it's a subset.

regal archBOT Sep 20, 2020, 5:19 PM

#

SebastiaanZ

[bot:sebastiaan/bugs/duckpond] 7 new commits

409f0b5 Determine eligible duckpond emojis dynamically - SebastiaanZ
3fea325 Ignore non-staff messages for our duckpond - SebastiaanZ
9410194 Add channel blacklist for duckpond - SebastiaanZ
d68d6d2 Fix relay race condition in duckpond using a lock - SebastiaanZ
0c5c472 Remove unit tests for duck pond - SebastiaanZ

#

SebastiaanZ

[python-discord/bot] New branch created: sebastiaan/bugs/duckpond

regal archBOT Sep 20, 2020, 6:26 PM

#

SebastiaanZ

[bot:sebastiaan/bugs/duckpond] 1 new commit

588213c Lower duckpond threshold to increase activity - SebastiaanZ

#

SebastiaanZ

[python-discord/bot] Pull request opened: #1164 Several improvements to duckpond

This PR brings several improvements to our duckpond, including those suggested in #673. It also does away with the over-complicated tests we'd written for the duckpond that only really served to slow down development. I suggest reviewing the PR commit by commit, as I tried to document the changes in each commit message. I've also summarized the changed below.

Changes

The duckpond should now longer suffer from a relay race condition. Say goodbye to duplicate messages in our pond!
...

ebon magnetBOT Sep 20, 2020, 6:39 PM

#

Build 20200920.1 succeeded

Requested by

GitHub

Duration

00:03:00

Build pipeline

Bot

regal archBOT Sep 20, 2020, 6:48 PM

#

ks129

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

#

ks129

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

This is now done @kwzrd

ebon magnetBOT Sep 20, 2020, 6:49 PM

#

Build 20200920.2 failed

Requested by

GitHub

Duration

00:00:50

Build pipeline

Bot

regal archBOT Sep 20, 2020, 6:50 PM

#

Senjan21

[python-discord/bot] Pull request review submitted: #1164 Several improvements to duckpond

Code looks solid, very nice.

ebon magnetBOT Sep 20, 2020, 7:02 PM

#

Build 20200920.3 failed

Requested by

GitHub

Duration

00:02:53

Build pipeline

Bot

#

Build 20200920.4 failed

Requested by

GitHub

Duration

00:02:46

Build pipeline

Bot

#

Build 20200920.5 succeeded

Requested by

GitHub

Duration

00:02:47

Build pipeline

Bot

regal archBOT Sep 20, 2020, 8:20 PM

#

Senjan21

[python-discord/seasonalbot] Pull request review submitted: #445 Small fixes for the \.issue command

#

Senjan21

[python-discord/seasonalbot] Pull request closed: #445 Small fixes for the \.issue command

#

Senjan21

[seasonalbot:master] 6 new commits

24b788d Allow issue command in #dev-branding - Den4200
91ca04e Limit maximum PRs/issues to 10 per invocation - Den4200
d777222 Invoke help command when no PRs/issues are given - Den4200
157cc18 Authenticate with the GitHub API to allow for m... - Den4200
fc58377 Fix order of imports - Den4200

#

Senjan21

[python-discord/seasonalbot] branch deleted: fix/issue\-pr\-command

north knotBOT Sep 20, 2020, 8:25 PM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 20, 2020, 8:25 PM

#

Build 20200920.5 succeeded

Requested by

GitHub

Duration

00:02:46

Build pipeline

Seasonal Bot

night lilyBOT Sep 20, 2020, 8:25 PM

#

SeasonalBot

Connected!

regal archBOT Sep 20, 2020, 9:19 PM

#

kwzrd

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

#

kwzrd

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

Thanks, looks excellent. I will test tomorrow before I merge but I think this is now ready.

regal archBOT Sep 20, 2020, 10:19 PM

#

gustavwilliam

[python-discord/seasonalbot] Issue opened: #446 Wikiguess game

Description

A new .wikiguess game, where you get points for guessing the correct article name.

This would be a typical game:

Send .wikigame or .wikigame start to start a new game.
Get an embed with instructions about the game (click green reaction tick box to start game)
X (5?) rounds are done
The user receives a score

This is how a normal round would look:

Get the first few sentences from a not too uncommon Wikipedia article
Get X (10?) seconds to answer what the arti...

ebon magnetBOT Sep 20, 2020, 10:37 PM

#

Build 20200920.6 succeeded

Requested by

GitHub

Duration

00:03:04

Build pipeline

Bot

regal archBOT Sep 20, 2020, 10:50 PM

#

gustavwilliam

[python-discord/seasonalbot] Issue opened: #447 Cog managment command

Description

Just like we can run !c r COG_NAME (!cog reload COG_NAME) to reload a cog with the Python bot, we should be able to do something similar with SeasonalBot.

While the entire suite of cog management commands would be nice to have, the reload one would be the most beneficial during development.

Reasoning

While developing the .emojify command, I've restarted the bot around 100 times already. Being able to simply reload the relevant cog would make life a lot easier.

...

regal archBOT Sep 20, 2020, 11:50 PM

#

Numerlor

[python-discord/bot] New comment on pull request #1014: Doc improvements

Pushed in the new cached parser; it should overall have a smaller footprint and is only missing a way of clearing the cached results in case a lot of them pile up, can think of 4 different ways of doing this

Do thing: a lot of different pages would need to be fetched for this to become an issue with simple strings, but it is a possibility
Clear some amount of arbitrary items when over a certain limit
Keep track of how many times individual doc items were accessed and only clear f...

regal archBOT Sep 21, 2020, 3:45 AM

#

PureFunctor

[python-discord/seasonalbot] New comment on issue #447: Cog managment command

Sounds good! Feel free to start working on this if you haven't already. One more thing, maybe you could use the reload [implementation](https://www.github.com/python-discord/bot/tree/master/bot/cogs/extensions.py] in bot as a reference.

regal archBOT Sep 21, 2020, 4:02 AM

#

Den4200

[python-discord/seasonalbot] New comment on issue #447: Cog managment command

I would recommend just copying over the extensions manager from bot. The implementation there is already quite good, and no need to spend time creating a new solution when we already have one.

regal archBOT Sep 21, 2020, 4:48 AM

#

PureFunctor

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Maybe you could add a message on log.info? Something like log.info(f"Caught exception {e}, breaking out of retry loop")

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Looks good!

#

MarkKoz

[python-discord/bot] New comment on issue #1067: Remove sphinx dependency

in the near future if there's nobody against it.

Fine by me. As I said, I'm not against it. Haven't had input from anyone else unfortunately.

Should the sphinx license be handled like in #886 with the same file?

Yes, in my opinion. I haven't heard any negative feedback about this so far.

#

PureFunctor

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Returning an Optional[List[str]] in search_wikipedia seems redundant as you're able to return a list and check for its truthiness. Might be better to have this instead as iterating over an empty list does nothing:

    async def search_wikipedia(self, search_term: str) -> Optional[List[str]]:
        """Search wikipedia and return the first page found."""
        async with self.http_session.get(SEARCH_API.format(search_term=search_term)) as response:
            data = ...

#

gustavwilliam

[python-discord/seasonalbot] New comment on issue #447: Cog managment command

Yep! That's what I'm thinking as well.

Could you assign me to the issue? I'll have a look at it soon, when I get time.

regal archBOT Sep 21, 2020, 5:22 AM

#

MarkKoz

[python-discord/bot] New comment on pull request #1014: Doc improvements

"Do thing"

You mean do nothing? That doesn't seem viable. If the cache is never cleared, then it will get stale and outdated. Do you have any other provisions currently to prevent that? Is there a way to know when docs update without having to actually scrape the page? If yes, then I think periodically checking (like once per week?) and clearing caches for updates docs sounds good.

Keep track of how many times individual doc items were accessed and only clear from the ones that hav...

#

MarkKoz

[python-discord/bot] New comment on issue #1136: Add trash option to all bot responses

Using a decorator feels confusing (because it's less direct and relies on return values, which is kind of implicit). Furthermore, I think it's redundant. Is it really a worthwhile design to save a single function call?

#

MarkKoz

[python-discord/seasonalbot] New comment on issue #447: Cog managment command

I don't think that what's on master will work with the current seasonalbot extension layout because it contains nested extensions. I've rewritten it to support that in https://github.com/python-discord/bot/pull/1103. That being said, since this is going to be used across 3 bots now, we should start considering moving such features to a common repo, like we did for async-rediscache.

#

thomaspet

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

I'm for the staticmethod change, but the naming doesn't quite add up. You're typing titles as a string, but titles implies its a list of titles. formatted_wiki_urls & List[str] - also implies it returns a list, but you're just returning a string.

I'd rewrite this function to only handle creating one line, and using loops/comprehensions with it.

    @staticmethod
    def formatted_wiki_url(index: int, titles: str) -> str:
        """Making formatted wikipedia link.."""
  ...

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Don't think you need this list at all, just do the replace in place on line 90 where you do

await ctx.send(WIKIPEDIA_URL.format(title=titles_no_underscore[response - 1]))

see suggestion

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

        titles_len = len(titles)  # getting length of list

Remove the title_no_underscore list, and just use the length of titles.. since that's what its based on anyways

ebon magnetBOT Sep 21, 2020, 5:40 AM

#

Build 20200921.2 failed

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

#

Build 20200921.1 failed

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

regal archBOT Sep 21, 2020, 5:41 AM

#

thomaspet

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

            s_desc = "\n".join(self.formatted_wiki_url(index, title) for index, title in enumerate(titles, start=1))

and don't forget to rename this.

#

Numerlor

[python-discord/bot] New comment on pull request #1014: Doc improvements

"Do thing"

You mean do nothing? That doesn't seem viable. If the cache is never cleared, then it will get stale and outdated. Do you have any other provisions currently to prevent that? Is there a way to know when docs update without having to actually scrape the page? If yes, then I think periodically checking (like once per week?) and clearing caches for updates docs sounds good.

Yeah that was meant to be nothing. I'm not aware of a way to keep everything up to date automatically...

north knotBOT Sep 21, 2020, 6:00 AM

#

Postgres backup completed!

regal archBOT Sep 21, 2020, 6:00 AM

#

PureFunctor

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

PureFunctor

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Optional is not being used anymore and flake8 errors out when pre-commit hooks are run.

regal archBOT Sep 21, 2020, 6:23 AM

#

gustavwilliam

[python-discord/seasonalbot] New comment on issue #447: Cog managment command

@MarkKoz I agree. Maybe it's best to move the common things like pagination as well, so we have it all in the same place.

For now, I think copying over the command (possibly from your PR) and maybe altering it slightly to work with SeasonalBot would be the best method.

We could work on combining it to a single repo later. Maybe open an issue about it in the meta already?

ebon magnetBOT Sep 21, 2020, 6:28 AM

#

Build 20200921.7 failed

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

#

Build 20200921.8 failed

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

#

Build 20200921.11 failed

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

#

Build 20200921.12 failed

Requested by

GitHub

Duration

00:01:06

Build pipeline

Seasonal Bot

ebon magnetBOT Sep 21, 2020, 7:04 AM

#

Build 20200921.13 succeeded

Requested by

GitHub

Duration

00:01:06

Build pipeline

Seasonal Bot

regal archBOT Sep 21, 2020, 7:06 AM

#

kosayoda

[bot:feat/backend/160/cog\-subdirs] 181 new commits

f0795ea Create utility function for uploading to paste ... - Numerlor
4980726 Attempt requests multiple times with connection... - Numerlor
2644316 Send long eval output to paste service. - Numerlor
1b98e6c Increase log level. - Numerlor
d0d2054 Handle failed paste uploads. - Numerlor

#

thomaspet

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

    async def search_wikipedia(self, search_term: str) -> List[str]:
        """Search wikipedia and return the first 10 pages found."""
        async with self.http_session.get(SEARCH_API.format(search_term=search_term)) as response:
            data = await response.json()

        pages = []

        search_results = data["query"]["search"]

        # Ignore pages with "may refer to"
        for search_result in search_results:
            log.info("trying to appe...

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

    def formatted_wiki_url(index: int, title: str) -> str:
        """Making formatted wikipedia link.."""
        return f'`{index}` [{title}]({WIKIPEDIA_URL.format(title=title.replace(" ", "_"))})'

Titles is still plural

#

thomaspet

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

        """Making formatted wikipedia link."""

Nit-picking

ebon magnetBOT Sep 21, 2020, 7:10 AM

#

Build 20200921.1 succeeded

Requested by

GitHub

Duration

00:03:25

Build pipeline

Bot

regal archBOT Sep 21, 2020, 7:12 AM

#

kosayoda

[python-discord/bot] Pull request review submitted: #1103 Move cogs to subdirectories

All aboard the merge train choo choo~

#

kosayoda

[python-discord/bot] Issue closed: #160 Introduce subfolders into the cog folder so that we can organize the cogs better\.

#

kosayoda

[python-discord/bot] Pull request closed: #1103 Move cogs to subdirectories

#

kosayoda

[python-discord/bot] branch deleted: feat/backend/160/cog\-subdirs

#

kosayoda

[bot:master] 20 new commits

0fca244 Move extensions into sub-directories - MarkKoz
b224d46 Restructure tests and fix broken tests - MarkKoz
470ca20 Prefix names of non-extension modules with _ - MarkKoz
aaee0f8 Fix ModLog imports - MarkKoz
bb548c2 Fix paths used to load extensions - MarkKoz

north knotBOT Sep 21, 2020, 7:20 AM

#

Auto-deployed: bot

ebon magnetBOT Sep 21, 2020, 7:20 AM

#

Build 20200921.2 succeeded

Requested by

GitHub

Duration

00:05:45

Build pipeline

Bot

oak estuaryBOT Sep 21, 2020, 7:20 AM

#

Python Bot

Connected!

regal archBOT Sep 21, 2020, 7:23 AM

#

SebastiaanZ

[python-discord/bot] Pull request review submitted: #835 Fix reminders sending duplicate DELETE request and cancelling themselves

#

SebastiaanZ

[python-discord/bot] New review comment on pull request #835: Fix reminders sending duplicate DELETE request and cancelling themselves

I don't mind it that much. I think it's easy enough to look this up to retain the documentation power of our function annotations.

#

SebastiaanZ

[python-discord/bot] Pull request review submitted: #835 Fix reminders sending duplicate DELETE request and cancelling themselves

Long overdue review, but the code looks solid. It does add some more complicated features to our bot, but I think the "this should only ever happen once so if something else tries it, it should just stop" behavior is something that come in handy with different features as well.

I tested the functionality, it all seems to work, although that obviously doesn't tell us everything, which a fairly complicated feature like this. I think the utilities introduced are a candidate to receive unit te...

regal archBOT Sep 21, 2020, 7:52 AM

#

kosayoda

[python-discord/bot] New branch created: feat/info/server\-cmd\-enhancements

ebon magnetBOT Sep 21, 2020, 7:53 AM

#

Build 20200921.17 failed

Requested by

GitHub

Duration

00:00:50

Build pipeline

Seasonal Bot

#

Build 20200921.16 failed

Requested by

GitHub

Duration

00:00:53

Build pipeline

Seasonal Bot

ebon magnetBOT Sep 21, 2020, 8:13 AM

#

Build 20200921.18 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

#

Build 20200921.19 succeeded

Requested by

GitHub

Duration

00:01:05

Build pipeline

Seasonal Bot

#

Build 20200921.20 succeeded

Requested by

GitHub

Duration

00:00:57

Build pipeline

Seasonal Bot

night lilyBOT Sep 21, 2020, 8:20 AM

#

SeasonalBot

Connected!

regal archBOT Sep 21, 2020, 8:31 AM

#

scragly

[seasonalbot:clean\_uwu] 1 new commit

27d29c0 Prevent uwu output from pinging globally allowe... - scragly

#

scragly

[python-discord/seasonalbot] New branch created: clean\_uwu

#

scragly

[python-discord/seasonalbot] Pull request opened: #448 Prevent uwu output from pinging globally allowed roles\.

Description

This PR introduces sanitisation of the uwu text before uwufication in order to prevent moderator roles being pinged unnecessarily.

I've just changed the str typehint to the clean_content converter to do this as simply as possible.

Reasoning

While we do have a global limit to allowed roles being pinged in the bot, all mod+ roles were still capable of being pinged through this method.

Screenshots

Before (role resolves)
![image](https://user-images....

ebon magnetBOT Sep 21, 2020, 8:40 AM

#

Build 20200921.21 succeeded

Requested by

GitHub

Duration

00:00:56

Build pipeline

Seasonal Bot

regal archBOT Sep 21, 2020, 8:43 AM

#

scragly

[seasonalbot:clean\_uwu] 35 new commits

4b87160 Add initial caesarcipher command - PureFunctor
3e58b35 Make caesarcipher a command group - PureFunctor
baa2050 Add basic caesar cipher information embed - PureFunctor
3260a16 Refactor translate subcommand to encrypt and de... - PureFunctor
f1a79fb Add offset validation - PureFunctor

ebon magnetBOT Sep 21, 2020, 8:49 AM

#

Build 20200921.22 succeeded

Requested by

GitHub

Duration

00:01:12

Build pipeline

Seasonal Bot

regal archBOT Sep 21, 2020, 10:00 AM

#

SebastiaanZ

[python-discord/seasonalbot] Pull request review submitted: #448 Prevent uwu output from pinging globally allowed roles\.

#

SebastiaanZ

[python-discord/seasonalbot] New review comment on pull request #448: Prevent uwu output from pinging globally allowed roles\.

If the command argument is a message ID or message jumplink, the command will internally fetch the message text on this line in the command:

        text, embed = await Fun._get_text_and_embed(ctx, text)

This bypasses the clean_content converter (which is only applied to the ID/jumplink, not the message text that is fetched from it later).

#

scragly

[python-discord/seasonalbot] Pull request review submitted: #448 Prevent uwu output from pinging globally allowed roles\.

#

scragly

[python-discord/seasonalbot] New review comment on pull request #448: Prevent uwu output from pinging globally allowed roles\.

Good point, thanks. I'll get that fixed up.

#

thomaspet

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

was this changed back to titles? It's a function that takes 1 title at the time, hence why I meant it shouldn't have a plural name for title. (titles).

    @staticmethod
    def formatted_wiki_url(index: int, title: str) -> str:
        """Formating wikipedia link with index and title."""
        return f'`{index}` [{title}]({WIKIPEDIA_URL.format(title=title.replace(" ", "_"))})'

#

thomaspet

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

scragly

[seasonalbot:clean\_uwu] 1 new commit

1c0afb8 Use clean_content when fetching linked msgs for... - scragly

ebon magnetBOT Sep 21, 2020, 10:14 AM

#

Build 20200921.23 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

regal archBOT Sep 21, 2020, 10:14 AM

#

scragly

[python-discord/seasonalbot] Pull request review submitted: #448 Prevent uwu output from pinging globally allowed roles\.

#

scragly

[python-discord/seasonalbot] New review comment on pull request #448: Prevent uwu output from pinging globally allowed roles\.

OK, I should have resolved this now, along with also applying the cleaning to the mixed case command so mentions don't scramble the raw mention format, instead always using the resolved names.

#

SebastiaanZ

[python-discord/seasonalbot] Pull request review submitted: #448 Prevent uwu output from pinging globally allowed roles\.

ebon magnetBOT Sep 21, 2020, 10:25 AM

#

Build 20200921.25 succeeded

Requested by

GitHub

Duration

00:00:57

Build pipeline

Seasonal Bot

#

Build 20200921.24 succeeded

Requested by

GitHub

Duration

00:01:04

Build pipeline

Seasonal Bot

regal archBOT Sep 21, 2020, 10:29 AM

#

Anubhav1603

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

#

Anubhav1603

[python-discord/seasonalbot] New review comment on pull request #430: \!wiki command

Sorry I understood opposite, I have now committed the changes which u propose🙂

#

thomaspet

[python-discord/seasonalbot] Pull request review submitted: #430 \!wiki command

Make sure you test it locally after all these changes.

#

Anubhav1603

[python-discord/seasonalbot] New comment on pull request #430: \!wiki command

Make sure you test it locally after all these changes.

Sure🙂

#

Akarys42

[python-discord/seasonalbot] Pull request review submitted: #448 Prevent uwu output from pinging globally allowed roles\.

Works like a charm

#

SebastiaanZ

[python-discord/seasonalbot] Pull request closed: #448 Prevent uwu output from pinging globally allowed roles\.

#

SebastiaanZ

[seasonalbot:master] 4 new commits

27d29c0 Prevent uwu output from pinging globally allowe... - scragly
bb02341 Merge branch 'master' into clean_uwu - scragly
1c0afb8 Use clean_content when fetching linked msgs for... - scragly
25b7f51 Merge pull request #448 from python-discord/cle... - SebastiaanZ

#

SebastiaanZ

[python-discord/seasonalbot] branch deleted: clean\_uwu

north knotBOT Sep 21, 2020, 10:52 AM

#

Auto-deployed: seasonalbot

ebon magnetBOT Sep 21, 2020, 10:53 AM

#

Build 20200921.26 succeeded

Requested by

GitHub

Duration

00:02:37

Build pipeline

Seasonal Bot

night lilyBOT Sep 21, 2020, 10:53 AM

#

SeasonalBot

Connected!

regal archBOT Sep 21, 2020, 12:22 PM

#

[site] GitHub Actions checks success on master

regal archBOT Sep 21, 2020, 1:57 PM

#

RohanJnr

[python-discord/bot] Pull request opened: #1165 Smart syncing of Users

Closes #1119

Implementation

[x] Refactor Code to support paginated response.
[ ] Bulk Update Users whose properties have changed.

ebon magnetBOT Sep 21, 2020, 2:01 PM

#

Build 20200921.27 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

ebon magnetBOT Sep 21, 2020, 2:33 PM

#

Build 20200921.3 failed

Requested by

GitHub

Duration

00:02:53

Build pipeline

Bot

regal archBOT Sep 21, 2020, 2:46 PM

#

RohanJnr

[python-discord/bot] New comment on pull request #1165: Smart syncing of Users

This PR will be ready for review when the related site PR has been merged.
https://github.com/python-discord/site/pull/378

regal archBOT Sep 21, 2020, 3:08 PM

#

kosayoda

[bot:feat/info/server\-cmd\-enhancements] 6 new commits

4615571 Move Channels information to embed field. - kosayoda
6b42380 Move member status information to embed field. - kosayoda
78cac10 Simplify channel counting. - kosayoda
dfb8568 Move member count to embed field. - kosayoda
0f074d5 Add more role information to server embed. - kosayoda

regal archBOT Sep 21, 2020, 3:32 PM

#

kosayoda

[python-discord/bot] Pull request opened: #1166 Enhance the \!server command\.

The !server command is now more compact, and has more information.

In a regular channel

In a moderation channel

For contrast, the old embed:
![image](https://user-images.githubusercontent.com/41782385/93786915-6e8dc200-fc62-11ea-945f-9291a067f8c7.pn...

ebon magnetBOT Sep 21, 2020, 3:36 PM

#

Build 20200921.4 succeeded

Requested by

GitHub

Duration

00:03:44

Build pipeline

Bot

regal archBOT Sep 21, 2020, 4:05 PM

#

kwzrd

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

This all looks great to me now, and I think we can merge it. Would you be able to resolve the conflicts here, @ks129?

#

kwzrd

[python-discord/bot] New comment on pull request #817: Writing tests for moderation utils\.

FYI, I edited the PR description to cover the bugfix that we decided to include.

regal archBOT Sep 21, 2020, 4:39 PM

#

SebastiaanZ

[async-rediscache:master] 2 new commits

8171b02 Use separate workflow for PyPI test releases - SebastiaanZ
e936772 Change the package layout to make it scalable - SebastiaanZ

#

[async-rediscache] GitHub Actions checks success on master

ebon magnetBOT Sep 21, 2020, 5:15 PM

#

Build 20200921.5 failed

Requested by

GitHub

Duration

00:01:06

Build pipeline

Bot

regal archBOT Sep 21, 2020, 5:16 PM

#

RohanJnr

[python-discord/site] New comment on pull request #378: Add pagination and bulk update support for User\(discord user\) serializer\.

The bulk update method needs optimization. It calls the database on every instance that needs to be updated.
Currently working on a fix.

regal archBOT Sep 21, 2020, 5:40 PM

#

MrHemlock

[python-discord/bot] Pull request review submitted: #1145 Fix @everyone ping rule\.

Everything looks solid to me.

ebon magnetBOT Sep 21, 2020, 5:45 PM

#

Build 20200921.6 failed

Requested by

GitHub

Duration

00:02:31

Build pipeline

Bot

#

Build 20200921.7 failed

Requested by

GitHub

Duration

00:00:54

Build pipeline

Bot

regal archBOT Sep 21, 2020, 5:56 PM

#

ks129

[python-discord/site] Pull request opened: #393 Dewikification \- Create guides app

Created app that show guides without wiki.
All guides is stored to repository.
Also included guide, that teach how to write a guide.
Created website embed for these pages for Discord
Created categories system, but this allow only 1 level of categories.
Fixes #383

Screenshot 2020-09-20 at 10 36 51
![Screenshot 2020-09-20 at 10 37 07](https://user-images.githubuserconte...

#

[site] Azure Pipelines checks neutral on b1d4b07

ebon magnetBOT Sep 21, 2020, 6:02 PM

#

Build 20200921.8 failed

Requested by

GitHub

Duration

00:02:36

Build pipeline

Bot

regal archBOT Sep 21, 2020, 6:02 PM

#

[site] GitHub Code Scanning checks success on b4003a7

#

[site] GitHub Actions checks success on guides\-app

regal archBOT Sep 21, 2020, 6:26 PM

#

gustavwilliam

[python-discord/seasonalbot] Pull request opened: #449 Add extension management commands

Relevant Issues

Closes #447.

Description

The code for the extensions cog is copied from the Python bot.
-checks.py had to be added, together with a new bot/exts/utils directory
Status emojis, core developer id and URLs had to be added
Import locations and other tweaks had to be made from the command used in the Python bot

Did you:

[x] Join the Python Discord Community?
[x...

ebon magnetBOT Sep 21, 2020, 6:28 PM

#

Build 20200921.28 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

regal archBOT Sep 21, 2020, 6:34 PM

#

Numerlor

[python-discord/bot] Pull request opened: #1167 Upload eval output with codeblock escapes to pastebin

closes: #918

Attempts to upload eval output to the paste service to give some output to the user in case the escape filter is triggered

ebon magnetBOT Sep 21, 2020, 6:37 PM

#

Build 20200921.9 failed

Requested by

GitHub

Duration

00:02:38

Build pipeline

Bot

regal archBOT Sep 21, 2020, 6:39 PM

#

lemonsaurus

[python-discord/bot] Pull request review submitted: #1145 Fix @everyone ping rule\.

I feel like it's a bit dry without the "don't try to ping 95000 people" line, but I suppose that was removed because it no longer makes sense with @here?

Anyway, not a showstopper for me, looks good to me.

ebon magnetBOT Sep 21, 2020, 6:46 PM

#

Build 20200921.10 succeeded

Requested by

GitHub

Duration

00:03:10

Build pipeline

Bot

#

Build 20200921.11 succeeded

Requested by

GitHub

Duration

00:02:51

Build pipeline

Bot

regal archBOT Sep 21, 2020, 7:03 PM

#

kwzrd

[python-discord/bot] New comment on pull request #817: Writing tests for moderation utils\.

Thanks for all the work you put into this!

#

kwzrd

[python-discord/bot] Issue closed: #562 Write unit tests for \`bot/cogs/moderation/utils\.py\`

#

kwzrd

[python-discord/bot] Pull request closed: #817 Writing tests for moderation utils\.

#

kwzrd

[bot:master] 87 new commits

81711d7 Created file for moderation utils tests + added... - ks129
1549690 (Moderation Utils Tests): Added imports, modifi... - ks129
fa6a0ae (Moderation Utils Tests): Created tests for ha... - ks129 [98f7a37](https://github.com/python-discord/bot/commit/98f7a3777152b32bfda24f9d5add938479827c85) (Moderation Utils Tests): Created tests for no... - ks129
4a746fc (Moderation Utils Tests): Created tests for `no... - ks129

#dev-log

Abstract

Closes #1142

What should a page like this look like?

What's a sidebar?

So, what precisely needs to be done?

Implementation

Tests

putting these here so i remember to do them

Description

Reasoning

Description

Reasoning

Would you like to implement this yourself?

Description

Reasoning

Relevant Issues

Description

Reasoning

Demo

The included pieces

File names

Description

Reasoning

Proposed Implementation

Preview

Changes

Description

Steps to Reproduce

Changes made to Reddit Cog:

Description

Steps to Reproduce

Expected Behaviour

Actual Behaviour

Relevant Issues

Description

Did you:

Description

Reasoning

Did you:

Description

Relevant Issues

Description

Reasoning

Description

Changes

Description

Description

Reasoning

...

Reasoning

Screenshots

Implementation

In a regular channel

In a moderation channel

Relevant Issues

Description

Did you: