dev-log

[regal arch]

SebastiaanZ

[python-discord/bot] New comment on issue #827: \!zen command not working as intended

The current matching strategy is a bit simplistic in more than one way, but the specific case eivl mentions is more difficult to tackle. We could prioritize matches that contain the word as-is (except for capitalization), which would solve the "explicit" versus "explicitly" problem when looking explicitly for "explicit".

The next bit is that the current fuzzy matching tactic will always return a match; there's no lower bound/threshold below which it simply doesn't return anything. I don't ...

[regal arch]

Akarys42

[bot:ytdl\-tag\-fix] 11 new commits

9fd7b08 Added all the tag files in resources and modifi... - RohanJnr
f256346 added white spaces on statements before bullet ... - RohanJnr
fe31808 Re-corrected the lines which I had changed by m... - RohanJnr
d583e9b Merge branch 'master' into tags_overhaul - RohanJnr
1b56868 Caching all the tags when the bot has loaded(ca... - RohanJnr

Akarys42

[python-discord/bot] New branch created: ytdl\-tag\-fix

Akarys42

[bot:ytdl\-tag\-fix] 1 new commit

9bd044c Update ytdl tag to the new YouTube ToS - Akarys42

[ebon magnet]

Build 20200312.2 succeeded

Requested by

GitHub

Duration

00:01:51

Build pipeline

Bot

Build 20200312.3 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

[regal arch]

sco1

[python-discord/bot] New review comment on pull request #803: Removed API dependency for Tags

Not sure why the language regarding redistribution was removed from this tag:

1. access, reproduce, download, distribute, transmit, broadcast, display, sell, license, alter, modify or otherwise use any part of the Service or any Content except: (a) as expressly authorized by the Service; or (b) with prior written permission from YouTube and, if applicable, the respective rights holders;
2. use the Service to view or listen to Content other than for personal, non-commercial use (for ex...

sco1

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

[ebon magnet]

Build 20200312.4 failed

Requested by

GitHub

Duration

00:01:25

Build pipeline

Bot

Build 20200312.5 failed

Requested by

GitHub

Duration

00:01:22

Build pipeline

Bot

[regal arch]

Akarys42

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

Akarys42

[python-discord/bot] New review comment on pull request #803: Removed API dependency for Tags

I removed it because it is just a side effect of youtube-dl, this tool in itself is only against 3rd paragraph, the first and 9th paragraph are about redistributibg the content created by tool such as youtube-dl, but aren't directly caused by it. For instance I could download my music collection using it and keep it on my computer, and it would only be against the 3rd paragraph.

sco1

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

sco1

[python-discord/bot] New review comment on pull request #803: Removed API dependency for Tags

The overwhelming majority of use cases encountered on our server utilize ytdl to stream content with a discord bot, which is redistributing content outside of YouTube’s platform. That is why these sections were all included and why they should remain in the tag.

Please ask questions on these things before unilaterally making a decision to remove them.

[ebon magnet]

Build 20200312.6 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

[regal arch]

Akarys42

[python-discord/bot] New review comment on pull request #803: Removed API dependency for Tags

It just didn't made sense to me based on what was already in the tag.

Akarys42

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

The tag search command is broken:

AttributeError: 'Tags' object has no attribute '_get_tags'

As far as I can see, everything else is fine. Fix the above error and this PR should be good to go.

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

MarkKoz

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

            expected = Embed(
                description="Example content",
                colour=PARDON_COLOR
            ).set_author(
                name="Test title",
                icon_url=case["icon"]
            )

MarkKoz

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

This seems strange. The bot is in the setUp fixture, which is called for every test. Therefore, the mock will be "fresh" and there shouldn't be a need to reset the mock. What's going on here?

MarkKoz

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

Should assert it got called twice.

[ebon magnet]

Build 20200313.2 succeeded

Requested by

GitHub

Duration

00:01:31

Build pipeline

Bot

[north knot]

Postgres backup completed!

[ebon magnet]

Build 20200313.3 succeeded

Requested by

GitHub

Duration

00:02:18

Build pipeline

Bot

[ebon magnet]

Build 20200313.1 succeeded

Requested by

GitHub

Duration

00:00:58

Build pipeline

Seasonal Bot

[regal arch]

AG4lyf

[python-discord/seasonalbot] New comment on issue #360: \.mars command to get pics by rovers on mars

@ks129 As you are the one who is currently working on this.
I want to bring in your view that there is a huge lack of picture from NAVCAM and Rear CAM
You should include pictures from inside cameras. otherwise it's quiet useless to see same 5-7 pictures

ks129

[python-discord/seasonalbot] New comment on issue #360: \.mars command to get pics by rovers on mars

@AG4lyf Cameras is random in ny code, and my code support all 3 rovers. I think this will not affect it.

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

MarkKoz

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

I was thinking of just using call count originally but this is an even better way of doing it.

MarkKoz

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

A separate test case was a good decision. Keeps things more organised.

MarkKoz

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

I don't feel this constant needs an alias.

MarkKoz

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

MarkKoz

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

I don't feel this constant needs an alias.

MarkKoz

[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

As with the other constants, this could be defined and used by the utils module too.

sco1

[python-discord/seasonalbot] Pull request review submitted: #371 Added Python bot help command to SeasonalBot

[ebon magnet]

Build 20200313.2 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

[regal arch]

sco1

[python-discord/seasonalbot] Issue closed: #295 Add Pagination to \.help

sco1

[python-discord/seasonalbot] Pull request closed: #371 Added Python bot help command to SeasonalBot

sco1

[seasonalbot:master] 10 new commits

6ec6c81 Copy-pasted help command content from Python bot - ks129
9fe7684 (Help): Added information comment to top of file - ks129
dad85ff (Help): Made modifications to original code to ... - ks129
62cf4a6 (Help): Added unloading block in cogs loading - ks129
7ce17e3 (Help): Added cog loading to main.py - ks129

[north knot]

Auto-deployed: seasonalbot

[ebon magnet]

Build 20200313.3 succeeded

Requested by

GitHub

Duration

00:02:21

Build pipeline

Seasonal Bot

Build 20200313.4 failed

Requested by

GitHub

Duration

00:01:12

Build pipeline

Bot

Build 20200313.5 succeeded

Requested by

GitHub

Duration

00:01:54

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

sco1

[python-discord/seasonalbot] New review comment on pull request #364: Space Cog implementing

Isn't this parameter the same as APOD_DEFAULT_PARAMS?

sco1

[python-discord/seasonalbot] New review comment on pull request #364: Space Cog implementing

There needs to be a comment stating that an API key isn't needed for this endpoint.

sco1

[python-discord/seasonalbot] New review comment on pull request #364: Space Cog implementing

Instead of copying this constant in one subcommand, recreating it entirely in another subcommand, etc. , how about we have the fetch_from_nasa method create the base parameters and add in any additional parameters required? This way the behavior is consistent between all of the subcommands.

sco1

[python-discord/seasonalbot] Pull request review submitted: #364 Space Cog implementing

There are a few instances where multilining doesn't align with the prevailing codestyle in the repository, and also is inconsistent within the cog.

This, for example:

await ctx.send(embed=await self.create_nasa_embed(
    item["data"][0]["title"],
    item["data"][0]["description"],
    item["links"][0]["href"]
))

Should be something like this:

await ctx.send(
    embed=await self.create_nasa_embed(
        item["data"][0]["title"],
        item["data"][0...

[regal arch]

LordHemlock

[bot:hemlock\-perma\-ban\-watch\-removal] 2 new commits

96639bc Corrected expiration check logic and cog loading - LordHemlock
9b18912 Verification Cog Kaizen Changes - LordHemlock

[ebon magnet]

Build 20200313.6 succeeded

Requested by

GitHub

Duration

00:01:45

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] New comment on pull request #813: Cache all Python dependencies in CI

We'll likely have to evaluate any potential issues with partial cache hits as they happen in order to determine whether or not it represents a recurring issue. Just something to be vigilant for in our diagnosis of any potential failures.

It will either always happen when a package is removed from the lock file, or it will never happen. I think it will be the former but I have not tested. At the least, it means the cache will get bloated with packages which are no longer needed. They ...

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

I didn't know two spaces after full stops was a practice. I can live with it but it isn't consistent with any of the other text in this project as far as I know.

MarkKoz

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

apply_ban's docstring should mention that this happens.

MarkKoz

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

This doesn't do the function justice

        """
        Add `user` to watched users and apply a watch infraction with `reason`.

        A message indicating the result of the operation is sent to `ctx`.
        The message will include `user`'s previous watch infraction history, if it exists.
        """

MarkKoz

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Reduced nesting, moved reason to a variable to avoid splitting args, and revised some of the logging to include the user's name.

        if infraction.get('expires_at') is not None:
            log.trace(f"Ban isn't permanent; user {user} won't be unwatched by Big Brother.")
            return

        bb_cog = self.bot.get_cog("Big Brother")
        if not bb_cog:
            log.trace(f"Big Brother cog not loaded; perma-banned user {user} won't be unwatched.")
     ...

[regal arch]

MarkKoz

[bot] Branch feat/test/765/command\-shadowing was force-pushed to `99b5eb9`

Compare changes

MarkKoz

[bot] Branch feat/test/765/command\-shadowing was force-pushed to `da6b3ab`

Compare changes

MarkKoz

[bot] Branch feat/test/765/command\-shadowing was force-pushed to `7e7c538`

Compare changes

MarkKoz

[python-discord/bot] Pull request opened: #828 Test for command name and alias shadowing

Resolves #765

Adds a test to ensure command and alias names are unique. This allows for any names or aliases which shadow other commands to be caught in CI when tests run. The test will report all conflicts. It will not stop at the first conflict encountered. For conflicts, the test will provide the following in the error message:

1. The command's fully qualified name or alias
2. The command's function's name qualified by its module's name
3. The qualified (similar to № 2) command ...

[ebon magnet]

Build 20200314.1 failed

Requested by

GitHub

Duration

00:01:51

Build pipeline

Bot

[regal arch]

MarkKoz

[bot:feat/test/765/command\-shadowing] 1 new commit

f105ae7 Cog tests: fix leading space in aliases without... - MarkKoz

[ebon magnet]

Build 20200314.2 failed

Requested by

GitHub

Duration

00:01:26

Build pipeline

Bot

[regal arch]

MarkKoz

[bot:feat/test/765/command\-shadowing] 1 new commit

b4df122 Cog tests: fix error on import due to discord.e... - MarkKoz

[ebon magnet]

Build 20200314.3 succeeded

Requested by

GitHub

Duration

00:01:35

Build pipeline

Bot

[regal arch]

MarkKoz

[bot] Branch feat/test/765/command\-shadowing was force-pushed to `4d49755`

Compare changes

[ebon magnet]

Build 20200314.4 succeeded

Requested by

GitHub

Duration

00:01:42

Build pipeline

Bot

[north knot]

Postgres backup completed!

[regal arch]

bast0006

[python-discord/bot] Issue opened: #829 Code markdown suggestion behavior triggers in clearly incorrect scenarios

At the moment, the code in bot/bot/cogs/bot.py that handles when people post code blocks without language tagging them--that says "It looks like you're trying to paste code into this channel." uses pythons AST module to determine whether a code block is valid python or not.

However, it doesn't make sure that a language has already been specified before doing this. The following discord message demonstrates incorrect behavior:

```ini
[test_block]
test_value=1
test_value_two=2
`...

[ebon magnet]

Build 20200314.1 succeeded

Requested by

GitHub

Duration

00:01:06

Build pipeline

Seasonal Bot

[regal arch]

ks129

[python-discord/seasonalbot] Pull request review submitted: #349 Bookmark reaction bookmark

I made error handling for reaction removing + modified existing error handler suggestions.

ks129

[python-discord/seasonalbot] New review comment on pull request #349: Bookmark reaction bookmark

                try:
                    await reaction.remove(user)
                except discord.Forbidden:
                    await ctx.send("I don't have permissions to remove reaction.")
                except discord.HTTPException:
                    await ctx.send("Unknown error while removing reaction.")
                except discord.NotFound:
                    await ctx.send("Message or reaction author not found, can't remove reaction.")

ks129

[python-discord/seasonalbot] New review comment on pull request #349: Bookmark reaction bookmark

            except discord.HTTPException:
                await ctx.send("Unknown error while sending bookmark to user.")

[ebon magnet]

Build 20200314.5 succeeded

Requested by

GitHub

Duration

00:01:53

Build pipeline

Bot

[regal arch]

ks129

[python-discord/seasonalbot] New comment on issue #331: Addition of a new command \!wiki

Due this have no activity, can I work on it?

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

MarkKoz

[python-discord/bot] New review comment on pull request #803: Removed API dependency for Tags

I've added 1 & 9.

MarkKoz

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

[ebon magnet]

Build 20200314.6 succeeded

Requested by

GitHub

Duration

00:01:47

Build pipeline

Bot

[regal arch]

LordHemlock

[bot:hemlock\-perma\-ban\-watch\-removal] 1 new commit

a43315e Update bot/cogs/moderation/infractions.py - LordHemlock

[ebon magnet]

Build 20200314.7 succeeded

Requested by

GitHub

Duration

00:01:39

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

            * If it matches shh+ or unshh+, the channel is silenced or unsilenced respectively.
              Otherwise, if it matches a tag, the tag is invoked

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

can_run may raise CommandError, which should be handled here. Refer to how try_get_tag did it.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

This is wrong. Logging should only be avoided if a tag or the hush command succeeds.

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 5 new commits

e723dd2 Deseasonify: add convenience method to get curr... - kwzrd
2faffc4 Deseasonify: add convenience method to get seas... - kwzrd
0cee968 Deseasonify: add set_banner method to Seasona... - kwzrd
c67cbbb Deseasonify: improve documentation for icon_cy... - kwzrd [545f05f](https://github.com/python-discord/seasonalbot/commit/545f05faf35974e3ea80f4fabc77f5d3ae439bc7) Deseasonify: implement BrandingManager` cog - kwzrd

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 2 new commits

fad8152 Deseasonify: improve logic in set command - kwzrd
8e27bb3 Deseasonify: use more descriptive name for `Rec... - kwzrd

MarkKoz

[python-discord/bot] New comment on issue #738: Delete Message API change breaks bot features

Duplicate of #792.

MarkKoz

[python-discord/bot] Issue closed: #738 Delete Message API change breaks bot features

[regal arch]

RohanJnr

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

RohanJnr

[python-discord/bot] New review comment on pull request #803: Removed API dependency for Tags

We are no longer gonna paginate it as tags are meant to be a 1-page thing, more descriptive tags will be on the website.

[north knot]

Postgres backup completed!

[ebon magnet]

Build 20200315.1 failed

Requested by

GitHub

Duration

00:01:07

Build pipeline

Seasonal Bot

Build 20200315.5 failed

Requested by

GitHub

Duration

00:00:48

Build pipeline

Seasonal Bot

Build 20200315.4 failed

Requested by

GitHub

Duration

00:01:06

Build pipeline

Seasonal Bot

[regal arch]

ikuyarihS

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

ikuyarihS

[python-discord/bot] New review comment on pull request #803: Removed API dependency for Tags

Since you are removing this line, consider changing the method back to non-async.

ikuyarihS

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

ikuyarihS

[python-discord/bot] New review comment on pull request #803: Removed API dependency for Tags

Then everything looks good to go.

[ebon magnet]

Build 20200315.1 succeeded

Requested by

GitHub

Duration

00:01:38

Build pipeline

Bot

[ebon magnet]

Build 20200315.2 succeeded

Requested by

GitHub

Duration

00:01:51

Build pipeline

Bot

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 2 new commits

09f01da Deseasonify: lock branding commands to moderati... - kwzrd
6e8b239 Deseasonify: improve in_month command check - kwzrd

[regal arch]

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

How do we want to handle it here?
Invoking the error handler (and returning False) will cause it to be triggered twice because of the try_get_tag that follows.
The errors could be silenced for the user with just being logged, or None can be returned to also cancel the tag fallback

hot9cups

[python-discord/seasonalbot] New comment on issue #331: Addition of a new command \!wiki

@SebastiaanZ Unfortunately, I haven't been able to complete it yet. It's been a while I know, so I won't stall anyone. I'll continue to work on it, but I don't mind it being assigned to others if someone wants it.

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 2 new commits

066436d Deseasonify: add listener decorator for season ... - kwzrd
a2852ea Deseasonify: season-lock listeners where approp... - kwzrd

[regal arch]

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

How necessary is this? The vars finish loading in milliseconds after the bot connects and the commands become available for invoking.

MarkKoz

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

wait_until_guild_available may take a long time. It'd be a rare occurrence but I think it's a low effort to make it more robust.

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Providing kwargs creates a permission overwrite object from them internally, so it doesn't keep them.

But realized that we can skip the PermissionOverwrite itself here and just unpack the dict into kwargs.

MarkKoz

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

The invoked_from_error_handler attribute exists to prevent long or infinite recursion in the error handler when it's a CommandNotFound.

[ebon magnet]

Build 20200315.3 succeeded

Requested by

GitHub

Duration

00:01:31

Build pipeline

Bot

[regal arch]

ikuyarihS

[python-discord/bot] Pull request review submitted: #803 Removed API dependency for Tags

[ebon magnet]

Build 20200315.4 succeeded

Requested by

GitHub

Duration

00:01:47

Build pipeline

Bot

[regal arch]

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Copying that behaviour (and not changing anything else),
the await self.on_command_error(ctx, error) from the methods can get executed twice. Once in the silence attempt and then in the tag attempt.
invoked_from_error_handler doesn't come into play here because we're skipping the error handler with a CommandError with which it gets invoked.

ikuyarihS

[python-discord/bot] Issue closed: #777 Tags overhaul

ikuyarihS

[python-discord/bot] Pull request closed: #803 Removed API dependency for Tags

ikuyarihS

[bot:master] 23 new commits

9fd7b08 Added all the tag files in resources and modifi... - RohanJnr
f256346 added white spaces on statements before bullet ... - RohanJnr
fe31808 Re-corrected the lines which I had changed by m... - RohanJnr
d583e9b Merge branch 'master' into tags_overhaul - RohanJnr
1b56868 Caching all the tags when the bot has loaded(ca... - RohanJnr

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Was aiming for a list like look here (under the colon).
Should it just be a 2-4 spaces?

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200315.5 succeeded

Requested by

GitHub

Duration

00:03:07

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Yes, the command handler can be triggered twice if both commands error out, and that's fine. That's the point: why write code (logging, sending a message, etc.) to handle errors when the error handler already has code which can handle them?

MarkKoz

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Yes, 4 spaces should be fine. If you think it helps you can prepend an asterisk or number them.

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Do we want it to be triggered twice? It can result in duplicate messages being sent on an invalid command.

kwzrd

[seasonalbot:seasonal\-purge] 2 new commits

f15732d Deseasonify: add convenience decorator for seas... - kwzrd
edf419c Deseasonify: apply seasonal task mechanism to t... - kwzrd

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 12 new commits

6ec6c81 Copy-pasted help command content from Python bot - ks129
9fe7684 (Help): Added information comment to top of file - ks129
dad85ff (Help): Made modifications to original code to ... - ks129
62cf4a6 (Help): Added unloading block in cogs loading - ks129
7ce17e3 (Help): Added cog loading to main.py - ks129

[ebon magnet]

Build 20200315.6 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 2 new commits

f686cba Deseasonify: remove fragile attr dependency in ... - kwzrd
f9cef6a Deseasonify: relax type annotation - kwzrd

[ebon magnet]

Build 20200315.7 succeeded

Requested by

GitHub

Duration

00:01:02

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[python-discord/seasonalbot] New comment on pull request #329: Extension System Simplification

Status update

I was able to make some progress here and figured it'd be a good time for a status update. You can approach this as a summary of the things that I've done so far, but I may also pose a couple of open questions if anyone wants to give me a little bit of feedback or opinion - I will be more than happy to hear those. I am also keeping the PR description above up-to-date periodically so that the progress is more easy to track (I've added and changed a couple of the bullet poi...

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

No, probably not. Let's just go with what you said and log it directly.

[north knot]

Postgres backup completed!

[regal arch]

ks129

[python-discord/bot] Pull request opened: #830 ModLog Channel Update formatting fix\.

I added None string possibility to modlog channel update event to avoid bad MD formatting when one of values is empty. Closes #793

[ebon magnet]

Build 20200316.1 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

[regal arch]

eivl

[python-discord/bot] New comment on issue #793: Formatting issue for empty topic in channel update log

@ks129 could you explain what your fix does? I think I'm not getting what it does. Why does adding None fix this issue? maybe screenshots before and after could help me understand it.

eivl

[python-discord/bot] Pull request review submitted: #828 Test for command name and alias shadowing

This looks great. I approve even though I have some comments, those have nothing much to do with the approval or not.

eivl

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

this tripped me up a bit. is this something everyone does?

eivl

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

is there any cases where obj is only an instance of commands.Cog and not type?

eivl

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

Damn this is great.

[regal arch]

scragly

[python-discord/site] Issue opened: #341 Replace Allauth anti\-email monkey\-patch with proper settings\.

The allauth extension we use for the discord login and connection to a github account for any of our site accounts.

We have a monkeypatch to avoid saving in our database any email details that we may get from oauth authorisations. This does not avoid the request for emails showing in the auth request page though, as the scope is still requested.

Instead, we can define in settings.py the appropriate provider settings, particularly any required scopes to be requested. If we only provide `...

[regal arch]

ks129

[python-discord/bot] New comment on pull request #830: ModLog Channel Update formatting fix\.

@eivl Here is main change:
Before:

After:

This channel topic part especially.

[regal arch]

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Went with an asterisk and a space like in other docstrings in the module.

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

[ebon magnet]

Build 20200316.2 succeeded

Requested by

GitHub

Duration

00:01:48

Build pipeline

Bot

[regal arch]

sco1

[python-discord/bot] New review comment on pull request #830: ModLog Channel Update formatting fix\.

There should be a comment here explaining why this substitution is necessary to keep the formatting from breaking when an empty value is provided.

sco1

[python-discord/bot] Pull request review submitted: #830 ModLog Channel Update formatting fix\.

[ebon magnet]

Build 20200316.3 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

[regal arch]

kwzrd

[python-discord/bot] Pull request review submitted: #828 Test for command name and alias shadowing

I think this is super well written code. I love the commit history and how it walks us through the gradual development - something that I should learn from.

One thing that confused me is that, as far as I can tell, discord.py does raise an exception if there is a name conflict, but the mechanism doesn't check cross-group which is a weakness that only manifests itself due to our bot.cogs.alias module. If this is correct then this should perhaps be documented in the test's docstring ...

kwzrd

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

Looks like this is exactly what Cog.get_commands does, why not use that?

kwzrd

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

Is this to prevent this line from being executed? I feel like this is something that should be commented.

MarkKoz

[python-discord/bot] Pull request review submitted: #828 Test for command name and alias shadowing

MarkKoz

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

No, not really. However, I think I stole this idea from some other code bases. Maybe it's a bad habit of mine. The benefit of this is reducing length of annotations and thus increasing readability. If annotations get too long, the function's arguments also have to be broken up, which makes it take up more space. Doing from typing import x, y, z, a, b, c, d can work if there are only a couple things but it eventually gets out of control.

MarkKoz

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

Yes, that's exactly right. I believe I wrote about it in the commit message but didn't leave any comment in code.

MarkKoz

[python-discord/bot] Pull request review submitted: #828 Test for command name and alias shadowing

MarkKoz

[python-discord/bot] Pull request review submitted: #828 Test for command name and alias shadowing

MarkKoz

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

Because that's an instance method.

MarkKoz

[python-discord/bot] Pull request review submitted: #828 Test for command name and alias shadowing

MarkKoz

[python-discord/bot] New review comment on pull request #828: Test for command name and alias shadowing

The former checks that it's a class. Without that check, these errors may occur:

TypeError: issubclass() arg 1 must be a class

sco1

[python-discord/bot] Pull request review submitted: #830 ModLog Channel Update formatting fix\.

MarkKoz

[bot:feat/test/765/command\-shadowing] 1 new commit

b8559cc Cog tests: comment some code for clarification - MarkKoz

[ebon magnet]

Build 20200316.4 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

Build 20200316.5 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] New comment on pull request #828: Test for command name and alias shadowing

discord.py does raise an exception if there is a name conflict

Yes, but the bot would have to run for that to happen. This test does static checks.

but the mechanism doesn't check cross-group which is a weakness that only manifests itself due to our bot.cogs.alias module.

Don't understand what you mean by cross-group exactly nor how the alias cog plays a role.

If this is correct then this should perhaps be documented in the test's docstring

Document what exactly? I could ...

ks129

[python-discord/bot] New comment on issue #589: Write unit tests for \`bot/cogs/tags\.py\`

@sco1 PR is now merged, can you assign me now? I have free time currently, no school

[regal arch]

LordHemlock

[bot:hemlock\-perma\-ban\-watch\-removal] 1 new commit

e32d89e Nesting reduced, logging cleaned up and made cl... - LordHemlock

[ebon magnet]

Build 20200316.6 failed

Requested by

GitHub

Duration

00:01:15

Build pipeline

Bot

[regal arch]

kwzrd

[python-discord/bot] New comment on pull request #828: Test for command name and alias shadowing

@MarkKoz Ok, I understand now. I was looking for a way in which a name collision could exist such that one command shadows the other, but discord.py doesn't raise. So I managed to convince myself that the alias cog somehow circumvents the check.

The collision cannot be detected during tests if the command never gets registered.

Document what exactly?

Nothing, as I was wrong in my assumption.

MarkKoz

[bot:feat/test/765/command\-shadowing] 24 new commits

9fd7b08 Added all the tag files in resources and modifi... - RohanJnr
f256346 added white spaces on statements before bullet ... - RohanJnr
fe31808 Re-corrected the lines which I had changed by m... - RohanJnr
d583e9b Merge branch 'master' into tags_overhaul - RohanJnr
1b56868 Caching all the tags when the bot has loaded(ca... - RohanJnr

[ebon magnet]

Build 20200316.7 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Issue closed: #765 Unit test for command alias shadowing

MarkKoz

[python-discord/bot] Pull request closed: #828 Test for command name and alias shadowing

MarkKoz

[bot:master] 16 new commits

60814ee Cog tests: create boilerplate for command name ... - MarkKoz
d31f7e3 Cog tests: add a function to get all commands - MarkKoz
d9ed249 Cog tests: add a function to get all extensions - MarkKoz
b923c0f Cog tests: add a function to get all cogs - MarkKoz
0358121 Cog tests: add a function to get all qualified ... - MarkKoz

MarkKoz

[python-discord/bot] branch deleted: feat/test/765/command\-shadowing

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200316.8 succeeded

Requested by

GitHub

Duration

00:03:28

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #830 ModLog Channel Update formatting fix\.

[ebon magnet]

Build 20200316.9 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Issue closed: #793 Formatting issue for empty topic in channel update log

MarkKoz

[python-discord/bot] Pull request closed: #830 ModLog Channel Update formatting fix\.

MarkKoz

[bot:master] 5 new commits

590c263 (Mod Log): Fixed case when on_guild_channel_up... - ks129 [8e60f04](https://github.com/python-discord/bot/commit/8e60f04048cf9272daf2a2e08eab76a69af97bf4) (Mod Log): Added comment about channel update f... - ks129 [88d2d85](https://github.com/python-discord/bot/commit/88d2d85ec114eac2b9e3be9b18e075302f73509e) Update explanation comment so it explains what ... - sco1 [f70b40a](https://github.com/python-discord/bot/commit/f70b40afbf73ecf2ee525b216000654a910330da) Merge branch 'master' into bug-fixes - MarkKoz [7dfcd1a`](https://github.com/python-discord/bot/commit/7dfcd1a2d09918a7324f2be9d188a0486622bd02) Merge pull request #830 from ks129/bug-fixes - MarkKoz

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200316.10 succeeded

Requested by

GitHub

Duration

00:03:14

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[native jolt]

sco1

[flake8-annotations:dev\-next] 1 new commit

7a92645 Dependency bump - sco1

[flake8-annotations] Azure Pipelines checks neutral on 38e90c4

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

        If the channel was silenced indefinitely, notifications for the channel will stop.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

        Unsilence the current channel.

MarkKoz

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

        Silence the current channel for `duration` minutes or `forever`.

sentry-io[bot]

[python-discord/bot] Issue opened: #831 IndexError when re\-evaluating snekbox code

Sentry Issue: BOT-2C

IndexError: list index out of range
  File "discord/ext/commands/core.py", line 83, in wrapped
    ret = await coro(*args, **kwargs)
  File "bot/cogs/snekbox.py", line 281, in eval_command
    code = await self.continue_eval(ctx, response)
  File "bot/cogs/snekbox.py", line 235, in continue_eval
    code = new_message.content.split(' ', maxsplit=1)[1]

Using `get_cont...

sco1

[bot:fix\-token\-strip\-log] 1 new commit

ac6321f Update token filter logging to match expanded d... - sco1

sco1

[python-discord/bot] New branch created: fix\-token\-strip\-log

MarkKoz

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

MarkKoz

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Oops, forgot to include a comma in the args for apply_unwatch. Feel free to amend the commit and force push it.

sco1

[python-discord/bot] Pull request opened: #832 Update token filter logging to match expanded detection

While the token detection was successfully expanded by #825 to evaluate all potential token matches in the message, the logging method was not similarly updated & still utilized the re.search approach to get the matching substring for use in the log message.

Rather than searching for the token again, instead return the potential token substring from the detection method to be used later.

I'm opening this as a draft until Discord stops having issues & the changes can be tested.

[ebon magnet]

Build 20200316.11 succeeded

Requested by

GitHub

Duration

00:01:48

Build pipeline

Bot

[north knot]

Postgres backup completed!

[regal arch]

ks129

[python-discord/bot] Pull request opened: #833 Fixed \!zen command exact word matching\.

Closes #827
Now this match exact word first, before trying to use difflib's matching, due like in issue is shown, exact word may not best choice for matcher.
Result for !zen explicit
Before (from issue):

**The Zen of Python (line 10):**
Unless explicitly silenced.

After:

[ebon magnet]

Build 20200317.1 succeeded

Requested by

GitHub

Duration

00:01:57

Build pipeline

Bot

[regal arch]

eivl

[python-discord/bot] Pull request review submitted: #833 Fixed \!zen command exact word matching\.

looks good to me.

eivl

[python-discord/bot] Pull request review submitted: #530 Strip spoiler tags for watchlist triggers

looks fine, just surprised that there are no more changes then this :D

[regal arch]

AnonGuy

[bot:spoiler\-check] 45 new commits

9fd7b08 Added all the tag files in resources and modifi... - RohanJnr
f256346 added white spaces on statements before bullet ... - RohanJnr
fe31808 Re-corrected the lines which I had changed by m... - RohanJnr
d583e9b Merge branch 'master' into tags_overhaul - RohanJnr
1b56868 Caching all the tags when the bot has loaded(ca... - RohanJnr

[ebon magnet]

Build 20200317.2 succeeded

Requested by

GitHub

Duration

00:01:44

Build pipeline

Bot

[regal arch]

Akarys42

[python-discord/bot] Pull request review submitted: #833 Fixed \!zen command exact word matching\.

Work as intended, good job

[ebon magnet]

Build 20200317.3 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

[regal arch]

SebastiaanZ

[python-discord/bot] Pull request review submitted: #833 Fixed \!zen command exact word matching\.

SebastiaanZ

[python-discord/bot] New review comment on pull request #833: Fixed \!zen command exact word matching\.

While this solution works for this particular case, it now picks the first line that contains the word as a substring. For example, if you swap the lines containing explicit and explicitly around, it will match the wrong one again. @sco1 has an alternative suggestion that matches based on words instead of an entire sentence to truly prefer full word matches.

[ebon magnet]

Build 20200317.4 succeeded

Requested by

GitHub

Duration

00:01:45

Build pipeline

Bot

[regal arch]

lemonsaurus

[python-discord/bot] Pull request review submitted: #530 Strip spoiler tags for watchlist triggers

hell yeah, let's merge this bad boy

lemonsaurus

[python-discord/bot] Issue closed: #299 Strip spoiler tags for watchlist triggers

lemonsaurus

[python-discord/bot] Pull request closed: #530 Strip spoiler tags for watchlist triggers

lemonsaurus

[bot:master] 12 new commits

83e49c2 Check partially hidden words against the wordlist - AnonGuy
e731db9 Update spoiler regex to support multi-line spoi... - AnonGuy
def24f5 Expand spoilers to match multiple interpretations - AnonGuy
61df1d6 Merge branch 'master' into spoiler-check - AnonGuy
afeb920 Merge branch 'master' into spoiler-check - AnonGuy

lemonsaurus

[python-discord/bot] branch deleted: spoiler\-check

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200317.5 succeeded

Requested by

Leon Sandøy

Duration

00:03:20

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Can't believe I missed this one, thanks.

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Missed the assert in here.

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Yep, called every time; tried with an assert False in the test block.

[ebon magnet]

Build 20200317.6 succeeded

Requested by

GitHub

Duration

00:01:35

Build pipeline

Bot

[regal arch]

lemonsaurus

[python-discord/seasonalbot] New comment on pull request #329: Extension System Simplification

@kwzrd thank you so much for the detailed update!

I think it sounds like you've solved this in a robust and elegant way. I have a few questions, and a few answers for you.

Another decorator to lock listeners to specific months

I wonder if this could be the same decorator? That is to say, keeping the functions separate to making some sort of superdecorator that worked for both commands and listeners (maybe even for tasks? but then again the tasks one has different args..) - that way...

MarkKoz

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

[regal arch]

kwzrd

[python-discord/seasonalbot] New comment on pull request #329: Extension System Simplification

Thanks for the response, @lemonsaurus!

I wonder if this could be the same decorator? ...

Yeah, probably. I was thinking the same, but then forgot about it. I'll look into it, it's true that having the simplicity of just plopping an in_month there would be cool.

It may be relevant to be able to deactivate the time-restriction that these decorators enforce. Did you consider that? Something like, disabling them if DEBUG is true or even having a new env var that toggles the feature...

Numerlor

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Good idea, implemented 2 new tests for this when using silence and unsilence.

Numerlor

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

[ebon magnet]

Build 20200317.7 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

[regal arch]

Numerlor

[python-discord/bot] New comment on pull request #812: Implement silencer \(hush\) cog\.

Managed to lose my changes to the converter tests when I was fixing up my commits and didn't notice, pushed them in now.

[ebon magnet]

Build 20200317.8 succeeded

Requested by

GitHub

Duration

00:01:58

Build pipeline

Bot

[regal arch]

Greenjam94

[python-discord/bot] Fork created: Greenjam94/bot

kwzrd

[seasonalbot:seasonal\-purge] 9 new commits

199418d Deseasonify: improve SeasonBase docstring wor... - kwzrd
14d58b6 Deseasonify: allow set to take multi-word args - kwzrd
376b24d Deseasonify: keep track of path on github files - kwzrd
cd10299 Deseasonify: fallback on evergreen on incomplet... - kwzrd
bf3ed7d Deseasonify: make asset filenames module constants - kwzrd

[ebon magnet]

Build 20200317.1 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #125: Even more infraction search improvements

There's two ways to approach this (or a mix of both I suppose):

1. A generic search command which will support partial matches on user and actor names along with the reason. It will also support exact matches for IDs. This is easier to implement and easier to use (just a single command covers everything) but at the cost of less control over the search query. For example, if one wishes to search for an actor by name, if their name appeared in an unrelated infraction's reason, that would als...

[north knot]

Postgres backup completed!

[regal arch]

ikuyarihS

[python-discord/seasonalbot] Pull request review submitted: #349 Bookmark reaction bookmark

ikuyarihS

[python-discord/seasonalbot] New review comment on pull request #349: Bookmark reaction bookmark

This looks better now, and it won't crash the loop.
But should these messages be automatically deleted after a delay? Or should they be simple logging only?

ks129

[python-discord/seasonalbot] Pull request review submitted: #349 Bookmark reaction bookmark

ks129

[python-discord/seasonalbot] New review comment on pull request #349: Bookmark reaction bookmark

                try:
                    await reaction.remove(user)
                except discord.Forbidden:
                    await ctx.send("I don't have permissions to remove reaction.", delete_after=7.5)
                except discord.HTTPException:
                    await ctx.send("Unknown error while removing reaction.", delete_after=7.5)
                except discord.NotFound:
                    await ctx.send("Message or reaction author not found, can't r...

[regal arch]

kwzrd

[branding:seasonal\-structure] 1 new commit

d347e2e Rename all bot icons to avatars - kwzrd

Akarys42

[python-discord/bot] branch deleted: ytdl\-tag\-fix

DhruvDuseja

[python-discord/seasonalbot] Pull request opened: #375 Nationday

Relevant Issues

Closes #143

Description

Added the .nationday [param] Where [param] can be "today" or a country name.
Countries available are the ones scraped from Wikipedia's List of national independence days page, plus a few more countries added manually.

Reasoning

Added the command because it was an open and approved issue.

Screenshots

![working...

[ebon magnet]

Build 20200318.1 failed

Requested by

GitHub

Duration

00:01:06

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[branding:seasonal\-structure] 1 new commit

66645d2 Use green avatar for off-season - kwzrd

[ebon magnet]

Build 20200318.2 failed

Requested by

GitHub

Duration

00:01:02

Build pipeline

Seasonal Bot

[ebon magnet]

Build 20200318.5 failed

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

Build 20200318.3 failed

Requested by

GitHub

Duration

00:01:11

Build pipeline

Seasonal Bot

Build 20200318.6 failed

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

[native jolt]

leksuss

[python-discord/flake8-annotations] Fork created: leksuss/flake8-annotations

[regal arch]

Akarys42

[python-discord/bot] New comment on issue #769: Python mailing list channel

After some discussions, here is some details about the implementation :
A backgorund task on the bot could be created, that will fetch every 5 minutes the pydis mailgun API, searching for stored events, with the sender field matching [e-mail] OR [e-mail]. A special email address will have to be setup before. If a message is found, the bot could send an embed with the thread, author and...

kwzrd

[branding] Branch seasonal\-structure was force-pushed to `82c5d11`

Compare changes

[regal arch]

Akarys42

[python-discord/site] Issue opened: #342 Python mailing list channel

Abstract

It would be nice to have a channel tracking some of the official python mailing lists, such as [e-mail].

Specification

A background task will make the bot fetch from an email API to check if a new email from one of the tracked mailing list have been received, if any email is found, it will post them as an embed to a specific channel inside the server. Some additional content can be put in the embed, such as some informations about the sender, or a jump link t...

Akarys42

[python-discord/site] New comment on issue #342: Python mailing list channel

Transfering this issue as this could be solved by simply getting webhook POST requests from mailguns and re-encoding them using the site to send them to discord, as said by @SebastiaanZ

[regal arch]

Akarys42

[python-discord/bot] Issue opened: #834 Python mailing list channel

Abstract

It would be nice to have a channel tracking some of the official python mailing lists, such as [e-mail].

Specification

A background task will make the bot fetch from an email API to check if a new email from one of the tracked mailing list have been received, if any email is found, it will post them as an embed to a specific channel inside the server. Some additional content can be put in the embed, such as some informations about the sender, or a jump link t...

sco1

[python-discord/bot] New comment on issue #834: Python mailing list channel

What mailing list(s) are intended to be followed? What's the general traffic on them, and are we going to stream every message or are we going to do a "digest"? Are we also including the PEP RSS feed?

jos-b

[python-discord/bot] New comment on issue #834: Python mailing list channel

I'm transferring this back to bot because the API driven solution is much more sustainable than the mailgun webhook driven approach.

While the mailman3 API does break when you request all threads we don't need to do that. There is an endpoint which returns the IDs and dates of all recent threads (albeit in a HTML format, but that's nothing that beautifulsoup or any other HTML parsing library can't handle). This document contains a load of <div> with an anchor in them with a href like `/a...

sco1

[python-discord/seasonalbot] New comment on pull request #375: \.nationday command

Thanks for your contribution. Can you please either clean up this branch or start from a fresh one? We shouldn't need any "fix linting errors" commits, much less at least 7 of them in a row. Please ensure that you lint your code before making the commit, and definitely before pushing it.

You can read about all of this in our Contributing Guide

[regal arch]

sco1

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

sco1

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

Since the discord.py bot framework is asynchronous, the requests library cannot be used. You can check out other cogs in this repository for examples on how to use aiohttp to make asynchronous web requests.

[regal arch]

atmishra

[python-discord/bot] New comment on issue #639: \`\!whitelist\` command to whitelist stuff from our filters\.

@lemonsaurus Thanks for the feeback. I am done with the most of the work on bot side as well. I will soon raise a PR for that.

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

Alright, will check that out as soon as possible. Thanks for the quick reply!

kwzrd

[seasonalbot] Branch seasonal\-purge was force-pushed to `7e3dd1e`

Compare changes

[ebon magnet]

Build 20200318.12 succeeded

Requested by

GitHub

Duration

00:00:56

Build pipeline

Seasonal Bot

[regal arch]

sco1

[python-discord/meta] Pull request opened: #42 Contributor Doc Updates

For review prior to pushing to individual projects, updated verbiage related to our logging levels.

See: https://github.com/python-discord/organisation/issues/222 for additional information

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #766: Filtering malicious URLs

Paste services sometimes include the extension in the URL which presents a problem. Either paste services would have to be whitelisted (there are so many out on the internet) or a separate whitelist would be needed for file extensions we don't want shared at all.

[regal arch]

MarkKoz

[bot:bug/util/795/reminders\-dupe\-delete] 2 new commits

321ef37 Reminders: remove duplicate deletion in schedul... - MarkKoz
286d4f9 Reminders: remove _delete_reminder function - MarkKoz

MarkKoz

[python-discord/bot] New branch created: bug/util/795/reminders\-dupe\-delete

MarkKoz

[python-discord/bot] Pull request opened: #835 Fix reminders sending duplicate DELETE request and cancelling themselves

Fixes #795

[ebon magnet]

Build 20200319.1 succeeded

Requested by

GitHub

Duration

00:01:54

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #835 Fix reminders sending duplicate DELETE request and cancelling themselves

MarkKoz

[python-discord/bot] New review comment on pull request #835: Fix reminders sending duplicate DELETE request and cancelling themselves

Because edited reminders re-use the previous ID, this delete could lead to a race condition:

1. Original reminder starts being sent
2. User edits reminder and PATCH request goes through
3. Original reminder is sent and DELETE request goes through
4. Original reminder task is cancelled (well, too late - it's already finished and been deleted) and edited one is scheduled

Now the reminder is scheduled but doesn't actually exist in the database. I wanted to put this delete into a `finall...

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

@sco1 So should I just close this PR and start afresh?

[north knot]

Postgres backup completed!

[regal arch]

lemonsaurus

[python-discord/meta] Pull request review submitted: #42 Contributor Doc Updates

Yeah, these are excellent. This encapsulates perfectly the discussion we had on this topic, and is well-written besides. Also, the other changes here unrelated to log levels are necessary, and well executed.

Nice work.

SebastiaanZ

[seasonalbot:python38] 11 new commits

6ec6c81 Copy-pasted help command content from Python bot - ks129
9fe7684 (Help): Added information comment to top of file - ks129
dad85ff (Help): Made modifications to original code to ... - ks129
62cf4a6 (Help): Added unloading block in cogs loading - ks129
7ce17e3 (Help): Added cog loading to main.py - ks129

lemonsaurus

[python-discord/bot] New comment on issue #766: Filtering malicious URLs

hmmm. that's a good point, @MarkKoz. Damn. I didn't think about that.

I'm not sure what the best approach here would be, but I'm open to suggestions.

[ebon magnet]

Build 20200319.1 succeeded

Requested by

GitHub

Duration

00:01:36

Build pipeline

Seasonal Bot

[regal arch]

SebastiaanZ

[python-discord/seasonalbot] Pull request review submitted: #373 Bump Python version to 3\.8

SebastiaanZ

[python-discord/seasonalbot] Issue closed: #372 Upgrade Seasonalbot to Python 3\.8

SebastiaanZ

[python-discord/seasonalbot] Pull request closed: #373 Bump Python version to 3\.8

SebastiaanZ

[seasonalbot:master] 6 new commits

c4c9192 Pipenv: bump Python to 3.8 & re-lock - kwzrd
0804617 Docker: bump Python to 3.8 - kwzrd
2b55e3f CI: bump Python to 3.8 - kwzrd
d1ec434 CI: bump Ubuntu image to 18.04 - kwzrd
5b0565c Merge branch 'master' into python38 - SebastiaanZ

SebastiaanZ

[python-discord/seasonalbot] branch deleted: python38

ks129

[python-discord/seasonalbot] New comment on issue #143: \[Feature Request\] Independence Day

I think maybe will be cooler when nationalday is part of like country command, with what you can get much information about world countries.

[north knot]

Auto-deployed: seasonalbot

[ebon magnet]

Build 20200319.2 succeeded

Requested by

GitHub

Duration

00:02:30

Build pipeline

Seasonal Bot

[night lily]

SeasonalBot Loaded!

Active Season: Evergreen

[regal arch]

kwzrd

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

Let's do these as part of the __init__ above (indent 1 level deeper).

kwzrd

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

So should I just close this PR and start afresh? Also, sorry for redundant questions, I'm a first timer.

Yeah, that'd probably be best. You can run pipenv run lint locally before you push (or ideally before you even commit - read about precommit at the very bottom here) to execute the exact same tests that your code will be checked against in the pipeline, so there should be no reason for "fix lint" commit...

kwzrd

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

To multi-line a string literal, it's nicer to do:

white_flag = (
    "abcd"
    "efgh"
)

Notice no separating comma.

kwzrd

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

This could be a template:

flag_url = "https://www.countryflags.io/{country_code}/flat/64.png"
....
flag_url.format(country_code="DE")  # German flag

For your consideration: could there be a case where we want to parametrize the style and size also?

kwzrd

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

Marking this as changes requested since I forgot above.

[regal arch]

ks129

[python-discord/seasonalbot] Pull request review submitted: #250 Battleships Game

ks129

[python-discord/seasonalbot] New review comment on pull request #250: Battleships Game

Maybe use SHIPS constant joining instead hard-coded strings? But this is only thing. Everything other is good.

        embed.add_field(name="Name", value="\n".join(SHIPS))
        embed.add_field(name="Size", value="\n".join(str(size) for size in SHIPS.values()))

[regal arch]

LeonardoFdSantos

[python-discord/bot] Fork created: LeonardoFdSantos/bot

[ebon magnet]

Build 20200319.3 failed

Requested by

GitHub

Duration

00:01:02

Build pipeline

Seasonal Bot

Build 20200319.4 failed

Requested by

GitHub

Duration

00:01:14

Build pipeline

Seasonal Bot

[regal arch]

AG4lyf

[python-discord/seasonalbot] New comment on pull request #349: Bookmark reaction bookmark

I am well aware that my lint is failing . I am gonna debug it right now . as i now got some time after whole this time.

Akarys42

[python-discord/bot] New comment on issue #796: Command for fetching package information from PyPi

Since this command will only pull data from PyPi, I feel like !pypi is a better name for it. It sounds like a good command to have.

ks129

[python-discord/bot] New comment on issue #796: Command for fetching package information from PyPi

@Akarys42 Or maybe: !pypi as main name, !package as alias?

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

Thanks for all the suggestions! Will look into it soon.

[ebon magnet]

Build 20200319.5 failed

Requested by

GitHub

Duration

00:00:50

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[python-discord/meta] Pull request review submitted: #42 Contributor Doc Updates

I find this very well written, informative and easy to digest.

One thing that I noticed going over the doc is that the type annotation examples are out of sync with prevailing style in our repositories. Here, we'd prefer that input_2 is annotated using typing.Dict with the key, value types also specified:

def foo(input_1: int, input_2: dict) -> bool:

The example just be...

[regal arch]

kwzrd

[python-discord/meta] Pull request review submitted: #42 Contributor Doc Updates

kwzrd

[python-discord/meta] Pull request closed: #42 Contributor Doc Updates

MarkKoz

[python-discord/meta] Pull request review submitted: #42 Contributor Doc Updates

MarkKoz

[python-discord/meta] New review comment on pull request #42: Contributor Doc Updates

    * [Git Hooks](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks) are a powerful tool that can seem daunting to set up. Fortunately, `pre-commit` abstracts this process away from you and is provided as a dev dependency for this project. Run `pipenv run precommit` when setting up the project and you'll never have to worry about breaking the build for linting errors.

The can be a daunting to set up is totally wrong and at the least should be fixed, but here ar...

[regal arch]

sco1

[python-discord/meta] Pull request review submitted: #42 Contributor Doc Updates

sco1

[python-discord/meta] New review comment on pull request #42: Contributor Doc Updates

Changes made to master after internal review!

[ebon magnet]

Build 20200320.1 failed

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

Build 20200320.2 succeeded

Requested by

GitHub

Duration

00:00:55

Build pipeline

Seasonal Bot

Build 20200320.3 succeeded

Requested by

GitHub

Duration

00:00:58

Build pipeline

Seasonal Bot

[north knot]

Postgres backup completed!

[regal arch]

AG4lyf

[python-discord/seasonalbot] New comment on pull request #349: Bookmark reaction bookmark

Since this PR is such a mess now and so much outdated , i am closing this and following it up with a new PR cuz i can't fork a new until this fork is deleted.

AG4lyf

[python-discord/seasonalbot] Pull request closed: #349 Bookmark reaction bookmark

[regal arch]

ks129

[python-discord/seasonalbot] Pull request review submitted: #250 Battleships Game

Looks good for me.

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

So this should be alright, I suppose?
try: # Get list of countries countries = self.by_day[today_date] countries = list(countries.split(',')) except KeyError as ke: err_msg = f"**No countries have their independence day today.**" logger.warning(err_msg) return [(err_msg, white_flag)]

[regal arch]

DuckMasterAl

[python-discord/seasonalbot] New comment on issue #374: \.snakes about has the wrong prefix

Hey,
Sorry I kind of didn't open Github and just was on Github Desktop for a while...
I've just changed the prefix to the one right now since I'm a little busy this week, anyone else can feel free to help and change it though!
Thanks,
DuckMasterAl

DuckMasterAl

[python-discord/seasonalbot] Pull request opened: #376 Changed Prefix

Changed Prefix in .snakes about from ! to .
https://github.com/python-discord/seasonalbot/issues/374

Relevant Issues

Closes #374

Description

Changed prefix from ! to .

Reasoning

The prefix used to be ! but the commands were using a . prefix

Did you:

• [x] Join the Python Discord Community?
• [x] If dependencies have been added or updated, run pipenv lock?
• [x] Lint your code (pipenv run lint)?
• [x] Set...

[ebon magnet]

Build 20200320.4 succeeded

Requested by

GitHub

Duration

00:00:51

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

kwzrd

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

That's a lot better, as it will no longer silence errors other than KeyError.

Since only the first line in the try block, the countries = self.by_day[today_date], may raise the KeyError, the line after (countries.split(...)), could be moved out - below the except block.

This will help you communicate the intent of the code a lot better. To generalize:

try:
    # A dangerous piece of code that may raise specifically KeyError
except KeyError as ke:
    # Handl...

kwzrd

[python-discord/seasonalbot] New comment on issue #374: \.snakes about has the wrong prefix

Sounds good, no worries.

Thanks for opening the PR, I will take a look tonight!

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request closed: #375 \.nationday command

DhruvDuseja

[python-discord/seasonalbot] New comment on pull request #375: \.nationday command

@kwzrd Also wanted to know about these.

kwzrd

[python-discord/seasonalbot] New comment on pull request #375: \.nationday command

The idea is that you create your own discord server for testing purposes, set up these channels to "emulate" the live server, and then put their ids in the .env file so that your bot knows which channel is which.

Once you have your server ready, the easiest way to obtain the ids directly on discord is to right click each channel and click Copy ID. If you don't see this option in the menu, you will have to go to discord settings and enable developer mode, I think it's somewhere under th...

[regal arch]

Akarys42

[python-discord/seasonalbot] Pull request review submitted: #376 Changed Prefix

Akarys42

[python-discord/seasonalbot] New review comment on pull request #376: Changed Prefix

Hey, thanks for your contribution. Although, the prefix is dynamic and set by the constant bot.constants.Client.prefix, you should use it instead of hardcoding it.

[regal arch]

LordHemlock

[bot:hemlock\-perma\-ban\-watch\-removal] 1 new commit

f39b2eb Updated doc strings to be more descriptive - LordHemlock

ks129

[python-discord/bot] Pull request opened: #836 Tags cog unit tests and tags cog fixes

Wrote unit tests for Tags cog + made some fixes there.

[ebon magnet]

Build 20200320.1 failed

Requested by

GitHub

Duration

00:01:24

Build pipeline

Bot

Build 20200320.2 failed

Requested by

GitHub

Duration

00:02:02

Build pipeline

Bot

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

Well, 64 is the biggest size, and appears reasonably descriptive on an embed. So I'm not sure about size. As for style, there's only one other style, which is shiny... which I don't think will really make a difference to the final outcome.

[ebon magnet]

Build 20200320.3 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

[regal arch]

LordHemlock

[bot:hemlock\-perma\-ban\-watch\-removal] 1 new commit

8a983d2 Updated Docstrings, parameters, and log messages - LordHemlock

[ebon magnet]

Build 20200320.4 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

[regal arch]

LordHemlock

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

LordHemlock

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Addressed in most recent commit

LordHemlock

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

LordHemlock

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Addressed in most recent commit

LordHemlock

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

LordHemlock

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Addressed in most recent commit

sco1

[bot] Branch fix\-token\-strip\-log was force-pushed to `abfaef9`

Compare changes

[ebon magnet]

Build 20200320.5 succeeded

Requested by

GitHub

Duration

00:01:53

Build pipeline

Bot

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #375 \.nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #375: \.nationday command

Yep, gotcha. I really appreciate the pointers!

sco1

[python-discord/bot] New review comment on pull request #836: Tags cog unit tests and tags cog fixes

While this may work fine in this specific instance, it's not a good idea to compare floats for equality without a tolerance. assertAlmostEqual is a better choice.

Then you also don't have to do things like "expected_output": 33.33333333333333

sco1

[python-discord/bot] Pull request review submitted: #836 Tags cog unit tests and tags cog fixes

Some comments from a quicklook, and one major point that should probably be addressed:

Right now these tests utilize the production tags repository and assume that its contents are never changed. This means that as soon as we add tags that could potentially also be part of the test cases for the fuzzy matching then the tests are going to start failing unless they are updated every time.

For example, in the test_get_suggestions test, we have this for fuzzy matching against "class":
...

sco1

[python-discord/bot] New review comment on pull request #836: Tags cog unit tests and tags cog fixes

This works fine for testing the _get_suggestions method, but it's a bit confusing to use a case that would never invoke this method in the first place. !tag get class is going to match the class tag directly, so we're not going to need to invoke a fuzzy search.

sco1

[python-discord/bot] New review comment on pull request #836: Tags cog unit tests and tags cog fixes

Is there any reason to compare the full contents of the tag rather than just the tag name (dictionary key) in this test?

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] New comment on pull request #375: \.nationday command

@kwzrd Yeahhhh so I got those down. Sorry about that..
So it says I can run my project with pipenv run start
Can you advise me if this is the right way:
make branch "nationday" -> move code to appropriate repos -> pipenv run start ?

LordHemlock

[bot:hemlock\-perma\-ban\-watch\-removal] 57 new commits

83e49c2 Check partially hidden words against the wordlist - AnonGuy
e731db9 Update spoiler regex to support multi-line spoi... - AnonGuy
def24f5 Expand spoilers to match multiple interpretations - AnonGuy
61df1d6 Merge branch 'master' into spoiler-check - AnonGuy
afeb920 Merge branch 'master' into spoiler-check - AnonGuy

[ebon magnet]

Build 20200320.6 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

Works perfectly.

sco1

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

sco1

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

While I understand that this is part of the trace logging flow, if this situation is encountered then this should be issued at the error level, not a trace.

LordHemlock

[bot:hemlock\-perma\-ban\-watch\-removal] 1 new commit

c432bf9 Changed a logging level - LordHemlock

MarkKoz

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

MarkKoz

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Why?

LordHemlock

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

LordHemlock

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Corrected in the most recent commit

sco1

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

sco1

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Why wouldn't we want to be notified that the big brother cog isn't loaded?

[ebon magnet]

Build 20200320.7 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

[regal arch]

LordHemlock

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

LordHemlock

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

For the purpose of the trace logic it makes no difference if this is an error or a trace, but for the sake of knowing that something isn't quite right with one of our cogs, it makes total sense for it to be an error. I just didn't think about it when writing it.

MarkKoz

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

If that's the case then IMO a warning is more appropriate. If there's ever a legitimate reason to unload it, even temporarily, then it'd be strange to be greeted with an error when nothing is actually wrong with the code. If you don't want it to be unloaded, consider adding it to the blacklist in the extensions cog.

MarkKoz

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

LordHemlock

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

LordHemlock

[python-discord/bot] New review comment on pull request #821: Automatically Remove Users from BigBrother Watch List on Perma Ban

Fair point, a warning makes sense to me. @sco1 that work for you?

sco1

[python-discord/bot] Pull request review submitted: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

Looks cool, works cool, very cool

kwzrd

[python-discord/seasonalbot] New comment on pull request #375: \.nationday command

Sorry, I'm not sure what you're asking me. Could you clarify?

Our discord has a channel dedicated specifically to contributions called #dev-contrib. Feel free to drop by and say hi - if you have more questions you'll get answers there faster.

sco1

[python-discord/bot] Issue closed: #321 No embed is send when a user gets "auto\-unwatched" after a ban

sco1

[python-discord/bot] Pull request closed: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

sco1

[bot:master] 12 new commits

76a9a03 Added BigBrother Helper Methods - LordHemlock
f1eb927 Added BigBrother Helper Methods - LordHemlock
229254d Merge remote-tracking branch 'origin/hemlock-pe... - LordHemlock
96639bc Corrected expiration check logic and cog loading - LordHemlock
9b18912 Verification Cog Kaizen Changes - LordHemlock

sco1

[python-discord/bot] branch deleted: hemlock\-perma\-ban\-watch\-removal

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200320.8 succeeded

Requested by

GitHub

Duration

00:03:11

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[ebon magnet]

Build 20200320.5 succeeded

Requested by

GitHub

Duration

00:00:51

Build pipeline

Seasonal Bot

[regal arch]

sco1

[python-discord/seasonalbot] Pull request review submitted: #364 Space Cog implementing

sco1

[python-discord/bot] Pull request review submitted: #833 Fixed \!zen command exact word matching\.

The fuzzy matching could probably use some more work but let's put that in the scope of its own PR.

DhruvDuseja

[python-discord/seasonalbot] New comment on pull request #375: \.nationday command

Alright, will do. Appreciate it!

CharlieADavies

[python-discord/seasonalbot] Issue opened: #377 \.xkcd command

Description

A command to retrieve xkcd comics (by number, most recent, or at random) and display them in an embed. Idea was first proposed by Discord user AG.

Reasoning

XKCD comics are funny, and they are often relevant to a conversation. I think a command to let people find comics such as the the Bobby Tables comic https://xkcd.com/327/ or to discover new comics would be a cool feature.

Proposed Implementation

XKCD have a JSON interface that can be used to retrieve comi...

[regal arch]

sco1

[python-discord/seasonalbot] New comment on issue #377: \.xkcd command to get xkcd comics

We could probably implement a persistent cache of at least the comic title & ID. Sites like Explain XKCD do have such tables already, which would be an expensive cache for initial seed, with a smaller daily hit to update anything recent that is missing.

For deeper aliasing there are things like Relevant XKCD that exist, but I'm not...

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 11 new commits

c4c9192 Pipenv: bump Python to 3.8 & re-lock - kwzrd
0804617 Docker: bump Python to 3.8 - kwzrd
2b55e3f CI: bump Python to 3.8 - kwzrd
d1ec434 CI: bump Ubuntu image to 18.04 - kwzrd
5b0565c Merge branch 'master' into python38 - SebastiaanZ

[ebon magnet]

Build 20200320.6 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

Build 20200320.7 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

[regal arch]

sco1

[python-discord/seasonalbot] Pull request review submitted: #250 Battleships Game

sco1

[python-discord/seasonalbot] Issue closed: #246 \[Feature Request\] Battleship

sco1

[python-discord/seasonalbot] Pull request closed: #250 Battleships Game

sco1

[seasonalbot:master] 9 new commits

ec4d86c Battleships Game - Suhail6inkling
254113c Post results and boards to initial channel - Suhail6inkling
9e758d4 Merge branch 'master' into battleships - Suhail6inkling
edeb2a1 Applied suggestions from code review for Battle... - Suhail6inkling
3d7aaa5 Applied suggestions from code review for Battle... - Suhail6inkling

[north knot]

Auto-deployed: seasonalbot

[ebon magnet]

Build 20200320.8 succeeded

Requested by

GitHub

Duration

00:02:01

Build pipeline

Seasonal Bot

[regal arch]

SebastiaanZ

[python-discord/seasonalbot] Pull request review dismissed: #364 Space Cog implementing

As a general question, I noticed that we're only using the image urls we get back from the API; do the API responses also include image data? And, if so, do you have an idea about the size of these responses? Are we talking KBs? MB? Multiple MB per request?

sco1

[seasonalbot:update\-contrib] 1 new commit

92d4f0a Update contributor doc - sco1

sco1

[python-discord/seasonalbot] New branch created: update\-contrib

sco1

[bot:update\-contrib] 1 new commit

387d0aa Update contributor doc - sco1

sco1

[python-discord/bot] New branch created: update\-contrib

sco1

[site:update\-contrib] 1 new commit

497ebc0 Update contributor doc - sco1

sco1

[python-discord/site] New branch created: update\-contrib

[native jolt]

sco1

[flake8-annotations:dev\-next] 1 new commit

cc63d57 Update contributor doc - sco1

[regal arch]

sco1

[snekbox:update\-contrib] 1 new commit

4b1bc04 Update contributor doc - sco1

sco1

[python-discord/snekbox] New branch created: update\-contrib

sco1

[python-discord/django-simple-bulma] branch deleted: precommit\-fix

sco1

[django-simple-bulma:update\-contrib] 1 new commit

e3c2e6f Update contributor doc - sco1

sco1

[python-discord/django-simple-bulma] New branch created: update\-contrib

sco1

[django-simple-bulma] Branch update\-contrib was force-pushed to `27f0485`

Compare changes

sco1

[django-crispy-bulma:update\-contrib] 1 new commit

52124ed Update contributor doc - sco1

sco1

[python-discord/django-crispy-bulma] New branch created: update\-contrib

sco1

[python-discord/django-simple-bulma] Pull request opened: #41 Update contributor doc

Trickle-down across the org repos via https://github.com/python-discord/meta/pull/42

See: https://github.com/python-discord/organisation/issues/222 for additional information

sco1

[python-discord/django-crispy-bulma] Pull request opened: #30 Update contributor doc

Trickle-down across the org repos via https://github.com/python-discord/meta/pull/42

See: https://github.com/python-discord/organisation/issues/222 for additional information

sco1

[python-discord/seasonalbot] Pull request opened: #378 Update contributor doc

Trickle-down across the org repos via https://github.com/python-discord/meta/pull/42

See: https://github.com/python-discord/organisation/issues/222 for additional information

sco1

[python-discord/bot] Pull request opened: #837 Update contributor doc

Trickle-down across the org repos via https://github.com/python-discord/meta/pull/42

See: https://github.com/python-discord/organisation/issues/222 for additional information

sco1

[python-discord/site] Pull request opened: #343 Update contributor doc

Trickle-down across the org repos via https://github.com/python-discord/meta/pull/42

See: https://github.com/python-discord/organisation/issues/222 for additional information

sco1

[python-discord/snekbox] Pull request opened: #67 Update contributor doc

Trickle-down across the org repos via https://github.com/python-discord/meta/pull/42

See: https://github.com/python-discord/organisation/issues/222 for additional information

[ebon magnet]

Build 20200320.1 succeeded

Requested by

GitHub

Duration

00:01:09

Build pipeline

Django Simple Bulma

Build 20200320.1 succeeded

Requested by

GitHub

Duration

00:01:13

Build pipeline

Django Crispy Bulma

Build 20200320.9 succeeded

Requested by

GitHub

Duration

00:00:57

Build pipeline

Seasonal Bot

Build 20200320.1 succeeded

Requested by

GitHub

Duration

00:01:11

Build pipeline

Snekbox

Build 20200320.9 succeeded

Requested by

GitHub

Duration

00:01:47

Build pipeline

Bot

Build 20200320.1 succeeded

Requested by

GitHub

Duration

00:02:28

Build pipeline

Site

[regal arch]

lemonsaurus

[python-discord/django-crispy-bulma] Issue opened: #31 Check compatibility with Django 3\.0

Probably easiest to just test it with Django 3 and see what happens. I imagine it will probably more or less work.

[regal arch]

MarkKoz

[python-discord/site] Issue opened: #344 Update to Django 3\.0

In addition to testing our own code for Django 3.0 compatibility, some dependencies need to be updated. django-crispy-bulma in particular is currently blocking (and maybe django-environ - see notes below).

Dependencies

Name	Version in Master	3.0 Compatible Version	Notes
django-allauth	0.41.0	0.41.0
django-crispy-bulma	0.2.0	❌	It requires django-crispy-forms 1.7 but 1.8 is the minimum vers...

[regal arch]

MarkKoz

[python-discord/site] Issue opened: #345 Redesign infractions schema

Current problems

The current design has some limitations. It cannot store a separate actor, timestamp, or reason for pardoning infractions. For the reason field, the current workaround used by Big Brother is to prepend the reason with 'Watched: ' or 'Unwatched: ' to distinguish them. Furthermore, the design cannot keep track of edits made to infractions.

New Design

Action table

Create a new table to store "action" records. Actions can include making an infraction act...

[north knot]

Postgres backup completed!

[ebon magnet]

Build 20200321.1 failed

Requested by

GitHub

Duration

00:01:38

Build pipeline

Bot

Build 20200321.2 succeeded

Requested by

GitHub

Duration

00:01:54

Build pipeline

Bot

[regal arch]

sco1

[bot:master] 1 new commit

3597d22 Fix regression in verification cog - sco1

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200321.3 succeeded

Requested by

GitHub

Duration

00:03:34

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

kwzrd

[python-discord/seasonalbot] Issue opened: #379 Persistence directory isn't \.gitignored

Seasonalbot's persistence module writes to a data/ directory, which should be local only, and not version controlled.

However, this currently isn't declared in the .gitignore, and the directory could sneak into a commit on accident.

Let's fix this by adding it to the .gitignore.

kwzrd

[seasonalbot:gitignore\-data] 1 new commit

0f24be1 Add data persistence directory to .gitignore - kwzrd

kwzrd

[python-discord/seasonalbot] New branch created: gitignore\-data

kwzrd

[python-discord/seasonalbot] Pull request opened: #380 Add \`data\` persistence directory to \.gitignore

Closes #379

Make git ignore the directory that the persistence module writes to. Prevents accidentally adding it to version control.

[ebon magnet]

Build 20200321.1 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

[regal arch]

scragly

[python-discord/seasonalbot] Pull request review submitted: #380 Add \`data\` persistence directory to \.gitignore

scragly

[python-discord/seasonalbot] Issue closed: #379 Persistence directory isn't \.gitignored

scragly

[python-discord/seasonalbot] Pull request closed: #380 Add \`data\` persistence directory to \.gitignore

scragly

[seasonalbot:master] 2 new commits

0f24be1 Add data persistence directory to .gitignore - kwzrd
a94627c Merge pull request #380 from python-discord/git... - scragly

scragly

[python-discord/seasonalbot] branch deleted: gitignore\-data

[north knot]

Auto-deployed: seasonalbot

[ebon magnet]

Build 20200321.2 succeeded

Requested by

GitHub

Duration

00:02:24

Build pipeline

Seasonal Bot

[night lily]

SeasonalBot Loaded!

Active Season: Evergreen

[regal arch]

kwzrd

[seasonalbot] Branch seasonal\-purge was force-pushed to `561b95e`

Compare changes

[ebon magnet]

Build 20200321.3 succeeded

Requested by

GitHub

Duration

00:00:57

Build pipeline

Seasonal Bot

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request opened: #381 Add nationday command

Relevant Issues

Closes #143

Description

Added the .nationday [param] Where [param] can be "today" or a country name.
Countries available are the ones scraped from Wikipedia's List of national independence days page, plus a few more countries added manually.

Reasoning

Added the command because it was an open and approved issue.

Screenshots

![workin...

[ebon magnet]

Build 20200321.4 succeeded

Requested by

GitHub

Duration

00:00:51

Build pipeline

Seasonal Bot

[regal arch]

sco1

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

Though this seems like a wall, the majority of these comments are pretty minor adjustments.

Overall this looks quite nice.

sco1

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

The method & variable names here should be more descriptive. Since this isn't a generic function they don't need to have generic names.

sco1

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

Can we sort this by date? It's really difficult to parse visually with the dates randomly arranged.

sco1

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

Per PEP 8, constants should be all-capitals

Numerlor

[python-discord/bot] New comment on issue #789: Wrong annotation for Tags\.\_fuzzy\_search

This has been addressed in #803

MarkKoz

[django-crispy-bulma:feat/deps/31/django\-3\.0] 3 new commits

a73c64c Update requirements to support Django 3.0 - MarkKoz
617ebff Add and correct PyPI classifiers - MarkKoz
12caecb Bump version to 0.3 - MarkKoz

MarkKoz

[python-discord/django-crispy-bulma] New branch created: feat/deps/31/django\-3\.0

sco1

[python-discord/bot] Issue closed: #789 Wrong annotation for Tags\.\_fuzzy\_search

MarkKoz

[python-discord/django-crispy-bulma] Pull request opened: #32 Add support for Django 3\.0

django-crispy-forms has to be at least version 1.8 for Django 3.0 support, but I pinned it to 1.9 because it seems there were some import issues and deprecation warnings fixed in 1.9.

I haven't extensively tested this and don't really know how, so this has to wait for #31.

[ebon magnet]

Build 20200321.1 succeeded

Requested by

GitHub

Duration

00:01:10

Build pipeline

Django Crispy Bulma

[regal arch]

MarkKoz

[site:feat/deps/344/django\-3\.0] 3 new commits

f84ec78 Update to Django 3.0 - MarkKoz
e772593 Use basename instead of base_name with DRF router - MarkKoz
145beb3 Allow empty list for message embeds - MarkKoz

MarkKoz

[python-discord/site] New branch created: feat/deps/344/django\-3\.0

MarkKoz

[python-discord/site] Pull request opened: #346 Update to Django 3\.0

Resolves #344

Blocked by python-discord/django-crispy-bulma#32. Still needs to be tested extensively. If you have ideas for what should be tested, leave a comment.

[ebon magnet]

Build 20200321.1 succeeded

Requested by

GitHub

Duration

00:02:58

Build pipeline

Site

[regal arch]

MarkKoz

[python-discord/snekbox] Pull request review submitted: #67 Update contributor doc

MarkKoz

[python-discord/snekbox] Pull request closed: #67 Update contributor doc

MarkKoz

[snekbox:master] 2 new commits

4b1bc04 Update contributor doc - sco1
4737494 Merge pull request #67 from python-discord/upda... - MarkKoz

MarkKoz

[python-discord/snekbox] branch deleted: update\-contrib

MarkKoz

[python-discord/site] Pull request review submitted: #343 Update contributor doc

[north knot]

Auto-deployed: snekbox

[regal arch]

[snekbox] Azure Pipelines checks success on master

[ebon magnet]

Build 20200321.1 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Snekbox

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

I just made it that way so that it's consistent with the return type.
Should just change it to return None, None ? Cause when it's called, I unpack it into two variables.

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

Well, I scraped them from Wikipedia. It was easier for me to leave it this way than change it.
Also, when I'm returning the actual Independence day, it's easier to read this than let the user wonder if it's MM/DD or DD/MM.

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

It's a globe. Should I be putting it in some other way?

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

The `flag_url' ?

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

Alright, so do I structure that with multiple try blocks?

[north knot]

Postgres backup completed!

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 10 new commits

5d700cf Deseasonify: improve get_seasons convenience ... - kwzrd
4687bd4 Deseasonify: simplify get_extensions convenie... - kwzrd
e987735 Deseasonify: remove season_override env var - kwzrd
9b94998 Deseasonify: add class for branding config - kwzrd
612f7a2 Deseasonify: add autostart env var - kwzrd

[ebon magnet]

Build 20200322.1 succeeded

Requested by

GitHub

Duration

00:00:43

Build pipeline

Seasonal Bot

[regal arch]

ks129

[python-discord/bot] Issue opened: #838 Remove Zen tag\.

Remove zen tag, due it's now in!zen command. I can do this.

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 9 new commits

d137d6b Deseasonify: do not automatically apply after... - kwzrd
fc79676 Deseasonify: guard bot nickname setter - kwzrd
e04e03b Deseasonify: propagate success value of set_icon - kwzrd
9fe6657 Deseasonify: uncomment API calls - kwzrd
f31e381 Deseasonify: return failed assets - kwzrd

[ebon magnet]

Build 20200322.2 succeeded

Requested by

GitHub

Duration

00:00:54

Build pipeline

Seasonal Bot

[regal arch]

lemonsaurus

[python-discord/django-crispy-bulma] Pull request review submitted: #30 Update contributor doc

lemonsaurus

[python-discord/django-crispy-bulma] Pull request closed: #30 Update contributor doc

lemonsaurus

[django-crispy-bulma:master] 2 new commits

52124ed Update contributor doc - sco1
b4043ff Merge pull request #30 from python-discord/upda... - lemonsaurus

[ebon magnet]

Build 20200322.1 succeeded

Requested by

Leon Sandøy

Duration

00:01:22

Build pipeline

Django Crispy Bulma

[regal arch]

lemonsaurus

[python-discord/django-crispy-bulma] Pull request review submitted: #32 Add support for Django 3\.0

I say we just merge this and see what happens.

lemonsaurus

[python-discord/django-crispy-bulma] Pull request closed: #32 Add support for Django 3\.0

lemonsaurus

[django-crispy-bulma:master] 4 new commits

a73c64c Update requirements to support Django 3.0 - MarkKoz
617ebff Add and correct PyPI classifiers - MarkKoz
12caecb Bump version to 0.3 - MarkKoz
c741d39 Merge pull request #32 from python-discord/feat... - lemonsaurus

[ebon magnet]

Build 20200322.2 succeeded

Requested by

Leon Sandøy

Duration

00:01:17

Build pipeline

Django Crispy Bulma

[regal arch]

pydis-bot

[python-discord/django-crispy-bulma] New release published: 0\.3

pydis-bot

[python-discord/django-crispy-bulma] New tag created: 0\.3

[ebon magnet]

Deployment on stage GitHub succeeded.

Deployment status

Succeeded

Time to deploy

00:00:32

Release

Release-9

Release pipeline

Django Crispy Bulma

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:35

Release

Release-9

Release pipeline

Django Crispy Bulma

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:36

Release

Release-9

Release pipeline

Django Crispy Bulma

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:00

Release

Release-10

Release pipeline

Django Crispy Bulma

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:00

Release

Release-10

Release pipeline

Django Crispy Bulma

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:00

Release

Release-10

Release pipeline

Django Crispy Bulma

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:00

Release

Release-10

Release pipeline

Django Crispy Bulma

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:34

Release

Release-10

Release pipeline

Django Crispy Bulma

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:36

Release

Release-10

Release pipeline

Django Crispy Bulma

[regal arch]

MarkKoz

[bot] Branch feat/frontend/o200/help\-channels was force-pushed to `b0bb6f2`

Compare changes

[ebon magnet]

Deployment on stage PyPi rejected.

Deployment status

Rejected

Time to deploy

00:00:32

Release

Release-11

Release pipeline

Django Crispy Bulma

Build 20200322.1 succeeded

Requested by

GitHub

Duration

00:01:56

Build pipeline

Bot

[regal arch]

MarkKoz

[bot] Branch feat/frontend/o200/help\-channels was force-pushed to `ece8984`

Compare changes

[ebon magnet]

Build 20200322.2 succeeded

Requested by

GitHub

Duration

00:01:48

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Issue opened: #839 Use role overwrites for new help channel system

Copying from the main PR #786:

Are per-member overwrites scalable? Discord may have a limit. Furthermore, there is supposedly client performance degradation with a high amount of overwrites. If this becomes an issue, an overwrite for a role can be used instead. The role would be added/removed from users as needed.

Not 100% decided if it should be switched to a role. Given a total channel limit of 32, there's going to be at most a bit over 32 simultaneous overwrites. That should be fine ...

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #837 Update contributor doc

MarkKoz

[python-discord/seasonalbot] Pull request review submitted: #378 Update contributor doc

MarkKoz

[python-discord/django-simple-bulma] Pull request review submitted: #41 Update contributor doc

MarkKoz

[python-discord/django-simple-bulma] Pull request closed: #41 Update contributor doc

MarkKoz

[django-simple-bulma:master] 2 new commits

27f0485 Update contributor doc - sco1
1ffa9f4 Merge pull request #41 from python-discord/upda... - MarkKoz

MarkKoz

[python-discord/django-simple-bulma] branch deleted: update\-contrib

[django-simple-bulma] Azure Pipelines checks success on master

[ebon magnet]

Build 20200323.1 succeeded

Requested by

GitHub

Duration

00:01:34

Build pipeline

Django Simple Bulma

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #838: Remove Zen tag\.

Sure, go for it. I've assigned you.

MarkKoz

[python-discord/bot] New review comment on pull request #832: Update token filter logging to match expanded detection

        """Return a seemingly valid token found in `msg` or `None` if no token is found."""

MarkKoz

[python-discord/bot] Pull request review submitted: #832 Update token filter logging to match expanded detection

One minor request to change a docstring. Everything else is great and working.

[regal arch]

ks129

[python-discord/bot] Pull request opened: #840 Removed \`zen\` tag due \`\!zen\` command exist\.

Closes #838

[ebon magnet]

Build 20200323.1 succeeded

Requested by

GitHub

Duration

00:01:54

Build pipeline

Bot

[north knot]

Postgres backup completed!

[regal arch]

maxbachmann

[python-discord/snekbox] Fork created: maxbachmann/snekbox

[regal arch]

ks129

[python-discord/seasonalbot] Pull request opened: #382 Game genre matching fix

Relevant Issues

Closes #369

Description

I added matching function (thanks to @ikuyarihS for code).

Reasoning

Due currently when you type genre wrong, this only suggest genres, but this will auto use correct genre.

Did you:

• [x] Join the Python Discord Community?
• [x] If dependencies have been added or updated, run pipenv lock?
• [x] Lint your code (pipenv run lint)?
• [x] Set the PR to **allow edits from con...

[ebon magnet]

Build 20200323.1 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Seasonal Bot

[regal arch]

sco1

[bot:fix\-token\-strip\-log] 1 new commit

8d3a100 Clarify docstring for token check function - sco1

sco1

[python-discord/bot] Pull request review submitted: #840 Removed \`zen\` tag due \`\!zen\` command exist\.

MarkKoz

[python-discord/bot] Pull request review submitted: #832 Update token filter logging to match expanded detection

[ebon magnet]

Build 20200323.2 succeeded

Requested by

GitHub

Duration

00:02:04

Build pipeline

Bot

[regal arch]

MarkKoz

[snekbox:feat/doc/57/docker\-run\-cmd] 3 new commits

7a66975 Document a simple way to run the container from... - MarkKoz
7e395ab Use reference links in README.md - MarkKoz
414c672 Replace NsJail config details with a reference ... - MarkKoz

MarkKoz

[python-discord/snekbox] New branch created: feat/doc/57/docker\-run\-cmd

MarkKoz

[python-discord/snekbox] Pull request opened: #68 Document a simpler way to run snekbox

Resolves #57 by adding a docker run command to README.md. Also included some other minor documentation improvements. See commit messages for more info.

[ebon magnet]

Build 20200323.1 succeeded

Requested by

GitHub

Duration

00:01:12

Build pipeline

Snekbox

[regal arch]

MarkKoz

[snekbox:feat/doc/57/docker\-run\-cmd] 1 new commit

d1c4605 Fix a grammatical error in README.md - MarkKoz

[ebon magnet]

Build 20200323.2 succeeded

Requested by

GitHub

Duration

00:01:11

Build pipeline

Snekbox

[regal arch]

kwzrd

[python-discord/snekbox] Pull request review submitted: #68 Document a simpler way to run snekbox

Excellent, I like it.

MarkKoz

[python-discord/snekbox] Issue closed: #57 Improve non\-developer access

MarkKoz

[python-discord/snekbox] Pull request closed: #68 Document a simpler way to run snekbox

MarkKoz

[snekbox:master] 5 new commits

7a66975 Document a simple way to run the container from... - MarkKoz
7e395ab Use reference links in README.md - MarkKoz
414c672 Replace NsJail config details with a reference ... - MarkKoz
d1c4605 Fix a grammatical error in README.md - MarkKoz
496226e Merge pull request #68 from python-discord/feat... - MarkKoz

MarkKoz

[python-discord/snekbox] branch deleted: feat/doc/57/docker\-run\-cmd

[north knot]

Auto-deployed: snekbox

[regal arch]

[snekbox] Azure Pipelines checks success on master

[ebon magnet]

Build 20200323.3 succeeded

Requested by

GitHub

Duration

00:01:23

Build pipeline

Snekbox

[regal arch]

MarkKoz

[snekbox:bug/ci/66/pipenv\-run\-creates\-venv] 3 new commits

7a212ed Move snekbox.cfg to a config directory - MarkKoz
58371bd Use a config file for gunicorn - MarkKoz
76c5e84 Fix #66: venv being created in container - MarkKoz

MarkKoz

[python-discord/snekbox] New branch created: bug/ci/66/pipenv\-run\-creates\-venv

MarkKoz

[python-discord/snekbox] Pull request opened: #69 Fix venv being created in Dockerfile

Fixes #66

pipenv run creates a venv because it cannot detect that a --system install was done. The solution is to invoke gunicorn directly. To avoid specifying config options in both the Dockerfile and the Pipfile, a config file for gunicorn was created.

[ebon magnet]

Build 20200323.4 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Snekbox

[regal arch]

ks129

[python-discord/seasonalbot] New comment on issue #300: Tic\-Tac\-Toe command

Can I work on this?

kwzrd

[python-discord/seasonalbot] New comment on issue #300: Tic\-Tac\-Toe command

This looks like a fun feature, but what is the proposed control scheme?

Given a 3x3 board, how will users select which field they would like to place their mark on? The issue mentions using reactions - the bot could populate the board with the 1, 2, ... emojis, and slowly replace them with Xs and Os as they are placed, but then I'm consufed about the :empty_square: emoji.

Adding an optional AI player for this would be pretty cool, too!

[regal arch]

NeKitDS

[python-discord/seasonalbot] New comment on issue #300: Tic\-Tac\-Toe command

Hey everyone! Glad someone came to working on this. The idea of :empty_square: is to fill the spaces which don't have X or O at their places yet. Originally I thought about using 1-9 for controls, but arrow emojis also seem like a way to go. Good luck on this one! <3

kwzrd

[python-discord/seasonalbot] Pull request review submitted: #378 Update contributor doc

kwzrd

[seasonalbot:update\-contrib] 3 new commits

0f24be1 Add data persistence directory to .gitignore - kwzrd
a94627c Merge pull request #380 from python-discord/git... - scragly
61785fc Merge branch 'master' into update-contrib - kwzrd

[ebon magnet]

Build 20200323.2 succeeded

Requested by

GitHub

Duration

00:00:53

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[seasonalbot:master] 3 new commits

92d4f0a Update contributor doc - sco1
61785fc Merge branch 'master' into update-contrib - kwzrd
69ad549 Merge pull request #378 from python-discord/upd... - kwzrd

kwzrd

[python-discord/seasonalbot] Pull request closed: #378 Update contributor doc

kwzrd

[python-discord/seasonalbot] branch deleted: update\-contrib

ks129

[python-discord/seasonalbot] New comment on issue #300: Tic\-Tac\-Toe command

My idea was use messages for controlling, like 1 1 will use top left. These messages will be deleted.

NeKitDS

[python-discord/seasonalbot] New comment on issue #300: Tic\-Tac\-Toe command

Well, that also works, but imho reactions would be better.

[north knot]

Auto-deployed: seasonalbot

[ebon magnet]

Build 20200323.3 succeeded

Requested by

GitHub

Duration

00:02:15

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[python-discord/site] Pull request review submitted: #343 Update contributor doc

kwzrd

[python-discord/site] Pull request closed: #343 Update contributor doc

kwzrd

[site:master] 2 new commits

497ebc0 Update contributor doc - sco1
2a71c77 Merge pull request #343 from python-discord/upd... - kwzrd

kwzrd

[python-discord/site] branch deleted: update\-contrib

kwzrd

[bot:update\-contrib] 2 new commits

3597d22 Fix regression in verification cog - sco1
694a9ba Merge branch 'master' into update-contrib - kwzrd

[ebon magnet]

Build 20200323.3 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

[regal arch]

kwzrd

[python-discord/bot] Pull request review submitted: #837 Update contributor doc

kwzrd

[python-discord/bot] Pull request closed: #837 Update contributor doc

kwzrd

[bot:master] 3 new commits

387d0aa Update contributor doc - sco1
694a9ba Merge branch 'master' into update-contrib - kwzrd
3a14814 Merge pull request #837 from python-discord/upd... - kwzrd

kwzrd

[python-discord/bot] branch deleted: update\-contrib

[north knot]

Auto-deployed: site

[regal arch]

[site] Azure Pipelines checks success on master

[ebon magnet]

Build 20200323.1 succeeded

Requested by

GitHub

Duration

00:03:52

Build pipeline

Site

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200323.4 succeeded

Requested by

GitHub

Duration

00:03:11

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

MarkKoz

[snekbox] Branch feat/deps/63/pep8\-naming was force-pushed to `900dd5f`

Compare changes

[ebon magnet]

Build 20200323.5 failed

Requested by

GitHub

Duration

00:01:58

Build pipeline

Snekbox

[regal arch]

kwzrd

[python-discord/seasonalbot] New comment on issue #300: Tic\-Tac\-Toe command

@ks129: My idea was use messages for controlling, like 1 1 will use top left.

I prefer @NeKitDS 's approach, I cannot imagine this being very user-friendly. You'd have to explain whether indices begin at 0 or 1, and whether origin is bottom-left or top-left. With arrows, most will instantly understand what to do, so it'll lead to much better UX.

Discord provides the full set of arrows necessary, including diagonal (e.g. :arrow_lower_left:), so with NeKit's X's and O's we're almo...

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #716: Wiki: document tests and snekbox

Maybe snekbox should be included in docker-compose 🤔

[north knot]

Postgres backup completed!

[regal arch]

Bester43

[python-discord/bot] Fork created: Bester43/bot

[ebon magnet]

Build 20200324.1 succeeded

Requested by

GitHub

Duration

00:01:02

Build pipeline

Seasonal Bot

[regal arch]

AnonGuy

[python-discord/snekbox] Pull request review submitted: #69 Fix venv being created in Dockerfile

LGTM

[regal arch]

MarkKoz

[python-discord/snekbox] Issue closed: #66 Main Docker image creates a venv because pipenv run is used

MarkKoz

[python-discord/snekbox] Pull request closed: #69 Fix venv being created in Dockerfile

MarkKoz

[snekbox:master] 4 new commits

7a212ed Move snekbox.cfg to a config directory - MarkKoz
58371bd Use a config file for gunicorn - MarkKoz
76c5e84 Fix #66: venv being created in container - MarkKoz
2ebea7e Merge pull request #69 from python-discord/bug/... - MarkKoz

MarkKoz

[python-discord/snekbox] branch deleted: bug/ci/66/pipenv\-run\-creates\-venv

[north knot]

Auto-deployed: snekbox

[regal arch]

[snekbox] Azure Pipelines checks success on master

[ebon magnet]

Build 20200324.1 succeeded

Requested by

GitHub

Duration

00:02:37

Build pipeline

Snekbox

[regal arch]

sco1

[bot:update\-deps] 1 new commit

30f8c8d Remove unused safety & dodgy dev dependencies - sco1

sco1

[python-discord/bot] New branch created: update\-deps

sco1

[python-discord/bot] Pull request opened: #841 Remove unused safety & dodgy dev dependencies

GitHub recently released CVE-2020-5252 illustrating how malicious packages could bypass checks being made by the safety package, currently installed for this repo as a dev dependency.

Since we don't use this dependency anywhere, it can just be removed. dodgy is also unused, so it can also be removed.

[ebon magnet]

Build 20200324.1 succeeded

Requested by

GitHub

Duration

00:02:00

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #841 Remove unused safety & dodgy dev dependencies

[regal arch]

sco1

[python-discord/site] New comment on pull request #346: Update to Django 3\.0

Per CVE-2020-6816, we may need to temporarily pin the bleach dependency.

bleach is a django-wiki requirement & is currently pinned by 0.6b1 to bleach>=3.1.0,<3.2. The current PyPI version of bleach is 3.1.3, so the current django-wiki pinning should be sufficient, and presumably they'll bump the requirement with the next beta so it might not be neces...

[regal arch]

scragly

[python-discord/bot] Pull request review submitted: #841 Remove unused safety & dodgy dev dependencies

scragly

[python-discord/bot] Pull request closed: #841 Remove unused safety & dodgy dev dependencies

scragly

[bot:master] 2 new commits

30f8c8d Remove unused safety & dodgy dev dependencies - sco1
a734d2e Merge pull request #841 from python-discord/upd... - scragly

scragly

[python-discord/bot] branch deleted: update\-deps

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200324.2 succeeded

Requested by

GitHub

Duration

00:03:18

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

kwzrd

[python-discord/seasonalbot] New comment on issue #335: \.aoc leaderboard \#deleted\-channel

Since the outdated constant still hasn't been removed I will do it in #329.

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 16 new commits

fdaca94 Deseasonify: add exceptions module - kwzrd
fcdd9ff Deseasonify: handle BrandingError - kwzrd
d9de849 Deseasonify: use BrandingError for negative res... - kwzrd
cf53da2 Deseasonify: extend BrandingManager documentation - kwzrd
6491897 Deseasonify: remove load_extensions method - kwzrd

[ebon magnet]

Build 20200324.2 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

Taking this out of draft as I'm not planning any further changes here and https://github.com/python-discord/seasonalbot/pull/329 will be done soon. The two PRs should be merged at once (currently Seasonalbot is looking into this branch, but that should be switched to master).

The seasonal structure (i.e. everything under seasonal/...) proposed in PR desc is considered final as the new Seasonalbot depends on it. For all things unrelated to that, feel free to propose or just push your own ...

kwzrd

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

@lemonsaurus Send you a review request as you're familiar with this repo and project.

MarkKoz

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

@kwzrd Regarding duplicates, what do you think about using symlinks? Git supports committing them and I think it'd be really neat solution. It makes more sense to me for original files to remain in the misc directory and for stuff outside to be symlinks to the misc directory.

kwzrd

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

@MarkKoz That's a really good idea. I will look into this tomorrow, thanks.

MarkKoz

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

Since the standard blurple logo is also used elsewhere, it shouldn't entirely be moved to the evergreen directory. Any logo that is general purpose and not strongly associated with a season should stay in the logos directory.

MarkKoz

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

1. The black_history_month season seems to have not been done structured properly.
2. Let's include a readme in the seasonal directory to briefly explain the directory structure and how it relates to the bot.

[north knot]

Postgres backup completed!

[regal arch]

lemonsaurus

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

Frankly, black_history_month isn't in use and was just something that was added as a "hey maybe this could be useful for something else some day" thing.

I'll review this fully when I get a chance.

[regal arch]

kwzrd

[branding:seasonal\-structure] 1 new commit

62efbd4 Use symlinks for christmas branding - kwzrd

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #840 Removed \`zen\` tag due \`\!zen\` command exist\.

MarkKoz

[python-discord/bot] Pull request closed: #840 Removed \`zen\` tag due \`\!zen\` command exist\.

MarkKoz

[python-discord/bot] Issue closed: #838 Remove Zen tag\.

MarkKoz

[bot:master] 3 new commits

ece2e7a Removed zen tag due !zen command exist. - ks129
b6b1096 Merge branch 'master' into zen-tag-remove - MarkKoz
789f445 Merge pull request #840 from ks129/zen-tag-remove - MarkKoz

[ebon magnet]

Build 20200325.1 succeeded

Requested by

GitHub

Duration

00:01:48

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] New comment on pull request #519: Refactor the \!help command\.

Hi @mathsman5133, can you address the requested changes?

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200325.2 succeeded

Requested by

GitHub

Duration

00:03:07

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

MarkKoz

[bot:feat/ci/b000/cache\-pipenv] 1 new commit

95db4c9 CI: remove support for partial cache hits - MarkKoz

MarkKoz

[python-discord/bot] New comment on pull request #813: Cache all Python dependencies in CI

Decided to just remove support for partial cache hits to be on the safe side.

[ebon magnet]

Build 20200325.3 succeeded

Requested by

GitHub

Duration

00:02:26

Build pipeline

Bot

[regal arch]

kwzrd

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

@MarkKoz I've tried using symlinks for christmas branding and while locally it appeared as an excellent solution, resolving them into download urls would add some level of complexity on seasonalbot's side and @scragly pointed out that it may introduce problems for Windows users. So I'm not sure whether that's an approach we should take.

The black_history_month season seems to have not been done structured properly.

That and retro gaming do not actually have a corresponding season, so ...

scragly

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

they don't really have a good place to go

Could consider using a non-season-specific /events directory. Would allow us for easily adding codejam stuff too.

[regal arch]

MarkKoz

[bot:bug/util/831/snekbox\-reeval\-parsing] 4 new commits

dd0550d Removed zen tag due !zen command exist. - ks129
00afb8a Snekbox: fix re-eval when '!eval' is removed fr... - MarkKoz
a651f5e Snekbox tests: test get_code - MarkKoz
ef44cfc Snekbox tests: use get_code in `test_continue... - MarkKoz

MarkKoz

[python-discord/bot] New branch created: bug/util/831/snekbox\-reeval\-parsing

MarkKoz

[bot] Branch bug/util/831/snekbox\-reeval\-parsing was force-pushed to `026e848`

Compare changes

MarkKoz

[python-discord/bot] Pull request opened: #842 Fix snekbox's message parsing to extract code for re\-evaluation

Fixes #831.

If the edited message is still a valid eval invocation, it will split by space to get the first arg (will be None if the arg doesn't exist). Otherwise (yes, even if it's a different valid command), it will consider the entire content of the message to be the code.

MarkKoz

[bot] Branch bug/util/831/snekbox\-reeval\-parsing was force-pushed to `c3e9a29`

Compare changes

[ebon magnet]

Build 20200325.5 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

[regal arch]

kwzrd

[branding] Branch seasonal\-structure was force-pushed to `9379b92`

Compare changes

eivl

[python-discord/bot] Pull request review submitted: #842 Fix snekbox's message parsing to extract code for re\-evaluation

after some explanation of what the test does and how it works, I can say that both the fix and the test looks good :D

kwzrd

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

Ok, so no symlinks - disadvantages seem to outweight benefits. I moved assets that are inspired by a common theme, but aren't bound to any actual season, to a new events directory (parallel to seasonal). Going to think about how to demiscify the seasonal dirs now.

lemonsaurus

[python-discord/branding] Pull request review submitted: #40 Add voice state icons

these look fine.

lemonsaurus

[python-discord/branding] Pull request closed: #40 Add voice state icons

lemonsaurus

[branding:master] 2 new commits

1dcf5b8 Add voice state icons - MarkKoz
6884fbe Merge pull request #40 from python-discord/voic... - lemonsaurus

MarkKoz

[python-discord/branding] branch deleted: voice\-state

[regal arch]

jos-b

[seasonalbot:setup\-sentry] 1 new commit

f2ca5d1 Setup Sentry - jos-b

jos-b

[python-discord/seasonalbot] New branch created: setup\-sentry

jos-b

[python-discord/seasonalbot] Pull request opened: #383 Setup Sentry

Relevant Issues

Finishes part of the organisation issue for Sentry setup: python-discord/organisation#209

Description

Sentry SDK has been installed. A special handler for command errors has been setup.

SEASONALBOT_SENTRY_DSN is present within the seasonalbot environment already.

Screenshots

[ebon magnet]

Build 20200326.1 succeeded

Requested by

GitHub

Duration

00:00:57

Build pipeline

Seasonal Bot

[regal arch]

MarkKoz

[python-discord/seasonalbot] Pull request review submitted: #383 Setup Sentry

[regal arch]

kmonteith25

[python-discord/bot] Fork created: kmonteith25/bot

[north knot]

Postgres backup completed!

[regal arch]

scragly

[python-discord/seasonalbot] Pull request review submitted: #383 Setup Sentry

scragly

[python-discord/seasonalbot] Pull request closed: #383 Setup Sentry

scragly

[seasonalbot:master] 2 new commits

f2ca5d1 Setup Sentry - jos-b
d645525 Merge pull request #383 from python-discord/set... - scragly

scragly

[python-discord/seasonalbot] branch deleted: setup\-sentry

[north knot]

Auto-deployed: seasonalbot

[ebon magnet]

Build 20200326.2 succeeded

Requested by

GitHub

Duration

00:04:10

Build pipeline

Seasonal Bot

[night lily]

SeasonalBot Loaded!

Active Season: Evergreen

[regal arch]

sentry-io[bot]

[python-discord/bot] Issue opened: #843 Warning check failure for users attempting disallowed commands\.

Sentry Issue: BOT-2D

username#0000 tried to run the command "commandname"

This could probably just be a INFO level log rather than WARNING now that we use sentry.

scragly

[python-discord/bot] Issue opened: #844 Limit alises output to only allowed commands\.

Description

We currently have a system for aliases to be able to be output for informative reasons with the !aliases command. It'll show a full paginated list of all command aliases, including any commands that aren't able to be used by the invoker, meaning it's just providing unnecessary information for them that they can't really utilise.

Proposal

Just the same as when doing help output, check each command that has an alias if the author can run it, allowing only those they ca...

[regal arch]

lemonsaurus

[bot:master] 1 new commit

ee7cfbf Change Alias warnings to info - lemonsaurus

lemonsaurus

[python-discord/bot] New comment on issue #843: Warning check failure for users attempting disallowed commands\.

Solved in https://github.com/python-discord/bot/commit/ee7cfbfca1b23408d7cb3f603498347fcef00c86

lemonsaurus

[python-discord/bot] Issue closed: #843 Warning check failure for users attempting disallowed commands\.

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200326.1 succeeded

Requested by

Leon Sandøy

Duration

00:03:14

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

sco1

[bot:update\-logging\-levels] 1 new commit

fe267ad Initial pass on log severity reduction - sco1

sco1

[python-discord/bot] New branch created: update\-logging\-levels

sco1

[python-discord/bot] Pull request opened: #845 Initial pass on log severity reduction

With the updated definition on logging levels (see: #837), there are a few events that are potentially issuing logs at too high of a level, alerting the DevOps team for things that aren't actionable, or at too low of a level.

While some instances are obvious adjustments, I've opened this as a draft for feedback on the changes being made & also to ask questions on non-obvious adjustments.

[ebon magnet]

Build 20200326.2 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

[regal arch]

sco1

[python-discord/bot] New comment on pull request #845: Initial pass on log severity reduction

Some initial questions on downgrading from warning to info:

https://github.com/python-discord/bot/blob/ee7cfbfca1b23408d7cb3f603498347fcef00c86/bot/cogs/sync/cog.py#L37-L44

I'm assuming this is still something we want to be aware of, in case the race condition becomes a recurring issue?

https://github.com/python-discord/bot/blob/ee7cfbfca1b23408d7cb3f603498347fcef00c86/bot/cogs/sync/syncers.py#L133-L138

Since I believe this is being done as part of an interactive session with a st...

[regal arch]

sco1

[bot] Branch update\-logging\-levels was force-pushed to `4d33b9f`

Compare changes

[ebon magnet]

Build 20200326.3 succeeded

Requested by

GitHub

Duration

00:01:41

Build pipeline

Bot

[regal arch]

sco1

[python-discord/seasonalbot] Issue opened: #384 Logging Level Adjustments

With the updated definition on logging levels (see: #378), there are a few events that are potentially issuing logs at too high of a level, alerting the DevOps team for things that aren't actionable, or at too low of a level.

Since a lot of things are changing with #329, will defer this until that work is completed.

MarkKoz

[python-discord/bot] New review comment on pull request #845: Initial pass on log severity reduction

While the consequences of the situation are not that big, I believe it should remain warning because this would happen due to programmer error (i.e. not manually closing before clearing/logging in).

MarkKoz

[python-discord/bot] Pull request review submitted: #845 Initial pass on log severity reduction

MarkKoz

[python-discord/bot] New review comment on pull request #845: Initial pass on log severity reduction

While the consequences of the situation are not that big, I believe it should remain warning because this would happen due to programmer error (i.e. not manually closing before clearing/logging in).

[regal arch]

MarkKoz

[python-discord/bot] New comment on pull request #845: Initial pass on log severity reduction

I'm assuming this is still something we want to be aware of, in case the race condition becomes a recurring issue?

I don't quite get this warning. A 404 would mean the user is not found in the database. The only way I can see that happening is if a user is edited the moment they join the server, and the PATCH for the edit goes through before the user is POSTed to the database. If that's the case, then, if left as a warning, it would remind us to come up with a better solution. On the oth...

[regal arch]

sco1

[python-discord/bot] New comment on pull request #845: Initial pass on log severity reduction

I suppose it all has to be an info level to avoid sentry bugging us?

I'm not particularly concerned about Sentry being verbose as long as it's telling us about things that require action. In the case of the syncer reaction loop, staff has already been pinged in the same context that the warning would be issued, so unless I'm missing something this is essentially pinging twice.

This is also used by Big Brother.
I meant the else clause specifically. From what I can see, other than ...

[regal arch]

lancegoyke

[python-discord/django-crispy-bulma] Fork created: lancegoyke/django-crispy-bulma

[regal arch]

MarkKoz

[python-discord/bot] New comment on pull request #845: Initial pass on log severity reduction

so unless I'm missing something this is essentially pinging twice.

Yes, it would. For that reason, it should be moved down to info. If it weren't for Sentry then I'd have kept this as a warning.

In the case of the antispam call, reaching the else clause is intentional and not something that we need to be reminded of.

OK, makes sense. I'm fine with an info for it then.

[regal arch]

sco1

[python-discord/bot] Pull request review submitted: #842 Fix snekbox's message parsing to extract code for re\-evaluation

sco1

[bot:bug/util/831/snekbox\-reeval\-parsing] 2 new commits

ee7cfbf Change Alias warnings to info - lemonsaurus
d99175a Merge branch 'master' into bug/util/831/snekbox... - sco1

[ebon magnet]

Build 20200326.4 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

[regal arch]

sco1

[python-discord/bot] Issue closed: #831 IndexError when re\-evaluating snekbox code

sco1

[python-discord/bot] Pull request closed: #842 Fix snekbox's message parsing to extract code for re\-evaluation

sco1

[bot:master] 5 new commits

02e230e Snekbox: fix re-eval when '!eval' is removed fr... - MarkKoz
430c616 Snekbox tests: test get_code - MarkKoz
c3e9a29 Snekbox tests: use get_code in test_continue... - MarkKoz [d99175a](https://github.com/python-discord/bot/commit/d99175a1983c5f339724c7d4f12a3e75a110a0ce) Merge branch 'master' into bug/util/831/snekbox... - sco1 [19c5d2a`](https://github.com/python-discord/bot/commit/19c5d2aa82cc2af57de3de0dbda71b2a51290528) Merge pull request #842 from python-discord/bug... - sco1

sco1

[python-discord/bot] branch deleted: bug/util/831/snekbox\-reeval\-parsing

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200326.6 succeeded

Requested by

GitHub

Duration

00:01:44

Build pipeline

Bot

Build 20200326.5 succeeded

Requested by

GitHub

Duration

00:03:17

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 2 new commits

c04103b Deseasonify: extend in_month doc - kwzrd
6b7caa1 Deseasonify: season-lock commands where appropr... - kwzrd

[ebon magnet]

Build 20200326.3 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 3 new commits

bcd6752 Deseasonify: show help on group invoke - kwzrd
6dfd694 Deseasonify: use help-friendly docstring summaries - kwzrd
6169342 Deseasonify: ignore dirs in server icons dir - kwzrd

[ebon magnet]

Build 20200326.4 succeeded

Requested by

GitHub

Duration

00:00:49

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[python-discord/seasonalbot] New comment on issue #384: Logging Level Adjustments

I was wondering whether this should be included in #329. But I agree that it's better deferred until that's done, and approached as a separate issue. All new code I'm writing is (hopefully) using sensible log levels.

[regal arch]

sco1

[python-discord/seasonalbot] New comment on issue #384: Logging Level Adjustments

There aren't that many, so there isn't much issue doing it in #329, I just didn't want to do it in the middle of all the other changes

kwzrd

[seasonalbot:seasonal\-purge] 2 new commits

226bb61 Deseasonify: move exceptions module under utils - kwzrd
4e0294f Deseasonify: move pagination module under utils - kwzrd

[ebon magnet]

Build 20200326.5 succeeded

Requested by

GitHub

Duration

00:00:53

Build pipeline

Seasonal Bot

[north knot]

Postgres backup completed!

[regal arch]

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

It was just for ease of calling a function to get the key (date) instead of having those many more lines in one large function.

[regal arch]

lemonsaurus

[branding:master] 1 new commit

91e901f Adding more game jam 2020 assets - sorry kwzrd! - lemonsaurus

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

But I need to check if the input given is a country. Only then can I process it according to get_specific_country. Otherwise, it'll fall through to the else block at the end.

DhruvDuseja

[python-discord/seasonalbot] Pull request review submitted: #381 Add nationday command

DhruvDuseja

[python-discord/seasonalbot] New review comment on pull request #381: Add nationday command

Followed an existing cog, movie.py, for implementation.

SebastiaanZ

[site:master] 1 new commit

df80fe2 Add events section to menu dropdown - SebastiaanZ

[north knot]

Auto-deployed: site

[regal arch]

[site] Azure Pipelines checks success on master

[ebon magnet]

Build 20200327.1 succeeded

Requested by

GitHub

Duration

00:03:45

Build pipeline

Site

[regal arch]

SebastiaanZ

[site:master] 1 new commit

b3ab644 Add Game Jam banner to landing page - SebastiaanZ

[north knot]

Auto-deployed: site

[regal arch]

[site] Azure Pipelines checks success on master

[ebon magnet]

Build 20200327.2 succeeded

Requested by

GitHub

Duration

00:03:54

Build pipeline

Site

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #300: Uncaught exception when trying to remove pagination of deleted message

Duplicate of #770 and fixed in #771.

MarkKoz

[python-discord/bot] Issue closed: #300 Uncaught exception when trying to remove pagination of deleted message

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #322: Watchlist Tokens & Watchlist Words merge and bug

How about leaving the regex lists separate in the config but combining the filters in the code? Would keep the convenience of not requiring manual word boundaries.

[regal arch]

creator1372

[python-discord/seasonalbot] Pull request opened: #385 Add a command to look for Game Jam 2020 teammates

This adds a command that searches for teammates

Relevant Issues

None

Description

I've added a little matchmaking pool and a command that searches for users.

Reasoning

The #game-gam channel is filled with people looking for teammates so i figured, this could be automated!

Did you:

• [X ] Join the Python Discord Community?
• [X ] If dependencies have been added or updated, run pipenv lock?
• [X ] Lint your code (`pip...

[ebon magnet]

Build 20200327.1 failed

Requested by

GitHub

Duration

00:01:06

Build pipeline

Seasonal Bot

[regal arch]

MarkKoz

[bot:feat/filter/322/merge\-tokens\-words] 1 new commit

e88bb94 Filtering: merge the word and token watch filters - MarkKoz

MarkKoz

[python-discord/bot] New branch created: feat/filter/322/merge\-tokens\-words

MarkKoz

[python-discord/bot] Pull request opened: #846 Filtering: merge the word and token watch filters

The only difference was the automatic addition of word boundaries.
Otherwise, they shared a lot of code. The regex lists were kept separate
in the config to retain the convenience of word boundaries automatically
being added.

• Rename filter to watch_regex
• Expand spoilers for both words and tokens
• Ignore URLs for both words and tokens

[ebon magnet]

Build 20200327.1 succeeded

Requested by

GitHub

Duration

00:01:47

Build pipeline

Bot

Build 20200327.2 failed

Requested by

GitHub

Duration

00:00:51

Build pipeline

Seasonal Bot

Build 20200327.3 succeeded

Requested by

GitHub

Duration

00:00:58

Build pipeline

Seasonal Bot

[regal arch]

MarkKoz

[python-discord/seasonalbot] New comment on pull request #385: Add a command to look for Game Jam 2020 teammates

Hi, please open an issue for this feature and fill out the template. An issue will allow for discussion on the merits of having such feature and some of its implementation details.

Also, it seems you did not set up pre-commit and/or run the linter despite having checked the box. Please set this up for yourself - it's covered in the contributing guidelines.

MarkKoz

[python-discord/seasonalbot] Pull request closed: #385 Add a command to look for Game Jam 2020 teammates

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #337: Provide current nickname in embed for infraction search

This is blocked until https://github.com/python-discord/bot/issues/533#issuecomment-586673988 is figured out.

MarkKoz

[python-discord/bot] New comment on issue #513: Standardized format instead of Slow\-mode in show\-your\-projects

I don't think a strict format is necessary, especially when the format would be so simple anyway. Keeping it free form and simple makes it more approachable to make a post. Alternate idea: send a mod alert if the message doesn't have a URL. Sometimes people use code blocks which we could try to detect too (we already have code written to do that elsewhere).

MarkKoz

[python-discord/bot] New comment on issue #623: Python 2 code detection\.

I'm not a fan of this idea - it seems like a nuisance to users. It's not a big enough issue to warrant automated notices. Furthermore, keep in mind some are stuck with Python 2. I think other users can be diligent enough to inform of the EOL with the added power of the human mind to assess the context of the situation.

MarkKoz

[python-discord/bot] New comment on issue #447: Support partial searches for documentation

Is this proposing fuzzymatching along with disambiguation by showing all available choices, or just disambiguation of all exact partial matches.

I think the latter is better.

I'm not sure if this is a good idea, but it could go as far as to look for exact matches for parts of the path delimited by the dot. For example, a query of text would not match discord.TextChannel, only TextChannel would. It'd have to be smart enough to know when to display a single page vs a bunch of res...

MarkKoz

[python-discord/bot] New comment on issue #497: Make auto code encoding more simple, complete and easier to read

No progress for 5 months so I'm unassigning. This is open for anyone to work on again.

MarkKoz

[python-discord/bot] New comment on issue #532: Refine Mention and Role Commands\.

I'm a fan of the slimmer design you demonstrated for the role command. Including an image of the colour is a good call.

That being said, I believe all the mention stuff is irrelevant due to the new feature Discord rolled out. I'm not too familiar with it, but I think it allows server admins to configure who can mention a given role.

@scragly Any updates on this?

MarkKoz

[python-discord/bot] New comment on issue #639: \`\!whitelist\` command to whitelist stuff from our filters\.

@atmishra Any updates on your progress?

scragly

[python-discord/bot] New comment on issue #532: Refine Mention and Role Commands\.

It does indeed, so the unlock and lock featureset is mostly useless. But the rest we can do still.

scragly

[python-discord/bot] New comment on issue #532: Refine Mention and Role Commands\.

I'll try get it implemented today. I should have some time :)

MarkKoz

[python-discord/bot] New comment on issue #532: Refine Mention and Role Commands\.

Feel free to remove the mention command while you're at it, if that's all obsolete now.

MarkKoz

[python-discord/bot] New comment on issue #654: Refactor and improve \`information\` cog

#741 saw improvements to this cog. You've assigned yourself to this @SebastiaanZ - do you still plan to work on this?

MarkKoz

[python-discord/bot] New comment on issue #673: Duck Pond improvements

@SebastiaanZ Any updates on this?

MarkKoz

[python-discord/bot] New comment on issue #160: Introduce subfolders into the cog folder so that we can organize the cogs better\.

I think we're waiting for the PRs to clear up before implementing this to avoid many conflicts. Besides that, there's nothing really else stopping it. I am happy with the discussion and conclusion reached for the directory structure.

MarkKoz

[python-discord/bot] New comment on issue #217: remove with\_roles decorator and replace with has\_any\_role

No progress for 4 months; unassigning. This is now open for anyone to work on.

MarkKoz

[python-discord/site] New comment on issue #345: Redesign infractions schema

The edit history is proving to be complicated to design a schema for. Maybe not worth doing - no one was really requesting this feature anyway, just thought I may be able to squeeze it in.

MarkKoz

[python-discord/bot] New comment on issue #240: Moderation undo reaction, infraction void subcommand

See https://github.com/python-discord/site/issues/345 for a DB schema proposal which would support the aforementioned features.

MarkKoz

[python-discord/bot] New comment on issue #297: Making the behavior of the red cross emoji consistent for all embed control interfaces

#625 addressed this. it just didn't close properly due to a colon in the "closes #xxx".

MarkKoz

[python-discord/bot] Issue closed: #297 Making the behavior of the red cross emoji consistent for all embed control interfaces

MarkKoz

[python-discord/bot] New comment on issue #303: Proposal to change send\_log\_message calls to event dispatches\.

I'm not a fan of the modlog in its current state and welcome improvements to it. I particularly dislike that the cog is used in other cogs. Would you mind demonstrating how the dispatching would work? I'm not familiar with it.

@scragly Have you made any progress on this?

MarkKoz

[python-discord/bot] New comment on issue #362: Mute bug resulting in early unmuting when 2 or more are active for a member\.

@scragly @SebastiaanZ I believe this was addressed by https://github.com/python-discord/site/pull/278, which disallows multiple active infractions. Can you confirm?

Finally, I've introduced a database-level UniqueConstraint to prevent a user from having multiple active infractions of the same type.

MarkKoz

[python-discord/bot] New comment on issue #331: Source command\.

No progress in 4-5 months; unassigning. This is now open for anyone to work on.

MarkKoz

[python-discord/bot] New comment on issue #718: Add ability to provide reason for \!unban command

https://github.com/python-discord/site/issues/345 will add support for this on the API side.

MarkKoz

[python-discord/bot] New comment on issue #708: Implement automated change of names for the staff main channel

Hello @manusaurio, have you made any progress on this?

MarkKoz

[python-discord/bot] New comment on issue #707: Move aliases to their respective cogs

This is getting stale. I will try to explore the decorator idea myself soon, as I like the sound of the idea on the surface and no one else has said otherwise so far.

MarkKoz

[python-discord/bot] New comment on issue #697: \!ping command

I'm fine with everything here, but just one comment:

do we just run a ping to the site, or we use a special route?

I wonder, are the site and bot on the same machine? In that case, I'd imagine there really wouldn't be any significant network latency between them.

MarkKoz

[python-discord/bot] New comment on issue #717: Announce OT name changes when they happen

I'm not married to the term "picked" however, or the overall wording in general. So if someone has suggestions for a better way to word it, make a comment on this issue.

How about "this is the first time this name has been used".

Since we don't store logs, in order to get historic channel name changes, we need to poll the server audit logs.

At least from what I can see in the client, logs only go back a couple of months at most.

Getting creation times

There's no field for...

scragly

[python-discord/bot] New comment on issue #303: Proposal to change send\_log\_message calls to event dispatches\.

I haven't personally started an implementation but it's actually pretty simple to do so I'll discuss it when I'm online next with you.

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #557: \[Feature Request\] Link GH Account

1. Why was this transferred from seasonalbot to here?
2. I don't think the site's functionality of linking a GH account is necessarily useful because those users did not specify that they want to make the association publicly available.

manusaurio

[python-discord/bot] New comment on issue #708: Implement automated change of names for the staff main channel

I haven't, and I should have said something earlier, my apologies. I'm also afraid I won't be able to do so for now and the following months, so this could be assigned to anyone else.

[regal arch]

scragly

[python-discord/bot] New comment on issue #303: Proposal to change send\_log\_message calls to event dispatches\.

bot.dispatch is a low level bot method that's considered for internal usage

It allows you to have the bot retrieve all base handlers and listeners for a specified event name:

bot.dispatch("myeventname", *args, **kwargs)

If there's no base handlers or listeners, it silently fails in a manner that suits this type of non-essential logging, without breaking other usually more important function...

[north knot]

Postgres backup completed!

[regal arch]

ks129

[python-discord/bot] Pull request opened: #847 Added \`Command\.can\_run\` check to \!aliases command\.

Closes #844

[ebon magnet]

Build 20200328.1 succeeded

Requested by

GitHub

Duration

00:01:55

Build pipeline

Bot

[regal arch]

ks129

[python-discord/bot] Pull request opened: #848 Hard\-coded PEP 0 to \!pep command

Closes #805

[ebon magnet]

Build 20200328.2 succeeded

Requested by

GitHub

Duration

00:01:53

Build pipeline

Bot

[regal arch]

ks129

[python-discord/site] New comment on issue #311: Add star table, API endpoints, admin views for Superstarify\.

Is anyone already working on this (and bot side) or not (I want a little rest from tic-tac-toe... 😅 )?

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 9 new commits

99b23ff Deseasonify: move decorators module under utils - kwzrd
99ba795 Deseasonify: move help extension under evergree... - kwzrd
09edf44 Deseasonify: move branding extension under ever... - kwzrd
4953466 Deseasonify: info log on help cog load - kwzrd
2949150 Deseasonify: rename seasons pkg to exts - kwzrd

kwzrd

[seasonalbot:seasonal\-purge] 6 new commits

92d4f0a Update contributor doc - sco1
61785fc Merge branch 'master' into update-contrib - kwzrd
69ad549 Merge pull request #378 from python-discord/upd... - kwzrd
f2ca5d1 Setup Sentry - jos-b
d645525 Merge pull request #383 from python-discord/set... - scragly

[ebon magnet]

Build 20200328.1 succeeded

Requested by

GitHub

Duration

00:01:14

Build pipeline

Seasonal Bot

[regal arch]

MarkKoz

[python-discord/site] New comment on issue #311: Add star table, API endpoints, admin views for Superstarify\.

What's the justification for adding an API for it? It seems overcomplicated. Why can't we keep it local on the bot in a JSON file? The convenience of being able to add or remove stars on the fly doesn't strike me as particularly useful.

kwzrd

[seasonalbot:seasonal\-purge] 4 new commits

5feabe6 Deseasonify: log in add_cog rather than in ea... - kwzrd
7c7d5dd Deseasonify: add helper to give all available s... - kwzrd
c02836d Deseasonify: add cmd showing all available seasons - kwzrd
b684719 Deseasonify: re-order command defs for consiste... - kwzrd

[ebon magnet]

Build 20200328.2 succeeded

Requested by

GitHub

Duration

00:00:56

Build pipeline

Seasonal Bot

[regal arch]

MarkKoz

[python-discord/site] New comment on issue #311: Add star table, API endpoints, admin views for Superstarify\.

Turns out we decided not to use the API but these issues were never updated to reflect that decision. I'm closing this issue as this should be purely a bot side implementation.

MarkKoz

[python-discord/site] Issue closed: #311 Add star table, API endpoints, admin views for Superstarify\.

ks129

[python-discord/bot] Pull request opened: #849 Discord Webhook URL removing

Closes #788

MarkKoz

[python-discord/bot] New comment on pull request #849: Discord Webhook URL removing

Is there an implementation reason for not adding this to the existing filtering cog infrastructure or did you just overlook that?

[ebon magnet]

Build 20200328.3 succeeded

Requested by

GitHub

Duration

00:01:41

Build pipeline

Bot

[regal arch]

ks129

[python-discord/bot] New comment on pull request #849: Discord Webhook URL removing

I made this to separate cog due token remover is too in the separate cog.

[regal arch]

MarkKoz

[python-discord/bot] New review comment on pull request #849: Discord Webhook URL removing

Sort alphabetically

bot.load_extension("bot.cogs.webhook_remover")
bot.load_extension("bot.cogs.wolfram")

MarkKoz

[python-discord/bot] Pull request review submitted: #849 Discord Webhook URL removing

I thought about it more and it makes more sense for this to be a separate cog. This is mainly because we likely wouldn't want to support whitelisted channels or roles for this in particular and also because the filtering cog is a bit of a mess. There's not much, if any, duplication of code with the filtering cog.

MarkKoz

[python-discord/bot] New review comment on pull request #849: Discord Webhook URL removing

I feel this code is too simple to warrant a separate function.

MarkKoz

[python-discord/bot] New review comment on pull request #849: Discord Webhook URL removing

This is a repetition of on_message

        await self.on_message(after)

dantediclemente

[python-discord/bot] Fork created: dantediclemente/bot

sco1

[bot:update\-logging\-levels] 1 new commit

81d2cdd Logging severity pass from review - sco1

[ebon magnet]

Build 20200328.4 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

[regal arch]

kwzrd

[branding:seasonal\-structure] 1 new commit

a5467f2 Add readme file for seasonal directory - kwzrd

[ebon magnet]

Build 20200328.5 succeeded

Requested by

GitHub

Duration

00:01:44

Build pipeline

Bot

[regal arch]

sco1

[python-discord/bot] Pull request review submitted: #849 Discord Webhook URL removing

Minor comment, otherwise looks fine.

sco1

[python-discord/bot] New review comment on pull request #849: Discord Webhook URL removing

url should be redacted in this method, or at the very least have a more descriptive variable name so we don't have to look into the on_message handler to see whether or not this method recieves the full URL or a redacted one.

sco1

[python-discord/bot] Pull request review submitted: #848 Hard\-coded PEP 0 to \!pep command

One adjustment, otherwise works fine.

sco1

[python-discord/bot] New review comment on pull request #848: Hard\-coded PEP 0 to \!pep command

This explanation could be a lot better. What is different for PEP 0 vs. the other PEPs that makes the existing logic unusable?

[ebon magnet]

Build 20200328.6 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Bot

Build 20200328.7 succeeded

Requested by

GitHub

Duration

00:01:44

Build pipeline

Bot

[regal arch]

kwzrd

[branding:seasonal\-structure] 6 new commits

bb7a385 Remove christmas misc dir - kwzrd
64ab124 Rename easter misc dir to 'assets' - kwzrd
a8ae134 Remove evergreen misc dir - kwzrd
063024a Remove halloween misc dir - kwzrd
b6fc96f Remove pride misc dir - kwzrd

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #849 Discord Webhook URL removing

MarkKoz

[python-discord/bot] New review comment on pull request #849: Discord Webhook URL removing

        """Delete `msg` and send a warning that it contained the Discord webhook `redacted_url`."""

MarkKoz

[python-discord/bot] New review comment on pull request #849: Discord Webhook URL removing

            f"{msg.author} (`{msg.author.id}`) posted a Discord webhook URL "

MarkKoz

[python-discord/bot] New review comment on pull request #849: Discord Webhook URL removing

            title="Discord webhook URL removed!",

MarkKoz

[python-discord/bot] Issue opened: #850 Disallow editing duration of expired infractions

Currently the command assumes that an infraction is still active if a duration is being edited. It tries to cancel the previous infraction but it will fail with a warning if the infraction already expired. Relevant code can be found here.

sentry-io[bot]

[python-discord/bot] New comment on issue #850: Disallow editing duration of expired infractions

Sentry issue: BOT-2G

MarkKoz

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

MarkKoz

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

While the **easter** season is active, the bot will apply its `avatar.png` and `banner.png` assets. However as the season does not provide any server icons, the bot will continue to cycle the evergreen ones - `winky.gif` and `spinner.png`.

MarkKoz

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

Once we enter the **christmas** season, the bot will apply the `snowing.gif` server icon - it will not cycle, as there is only one icon. Additionally, the christmas `avatar.png` will be used. However, the bot will fall back to the evergreen `banner.png`.

MarkKoz

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

If a non-evergreen season does not provide all assets, the bot will search for the missing ones in the evergreen directory. We will illustrate this behaviour with the following example:

kwzrd

[branding:seasonal\-structure] 6 new commits

1dcf5b8 Add voice state icons - MarkKoz
cdf513d Adding game jam 2020 branding - lemonsaurus
4ee6847 Merge pull request #47 from python-discord/game... - lemonsaurus
6884fbe Merge pull request #40 from python-discord/voic... - lemonsaurus
91e901f Adding more game jam 2020 assets - sorry kwzrd! - lemonsaurus

MarkKoz

[python-discord/bot] Pull request review submitted: #848 Hard\-coded PEP 0 to \!pep command

MarkKoz

[python-discord/bot] New review comment on pull request #848: Hard\-coded PEP 0 to \!pep command

Let's make this a separate function so that the command isn't so monolithic.

MarkKoz

[python-discord/bot] New review comment on pull request #848: Hard\-coded PEP 0 to \!pep command

Adding constants feels like clutter when these are unlikely to change and aren't used in more than one place. I suggest you just use the values directly in code.

MarkKoz

[python-discord/bot] New review comment on pull request #848: Hard\-coded PEP 0 to \!pep command

This URL should be a constant since it's now used in two spots.

kwzrd

[branding] Branch seasonal\-structure was force-pushed to `b1fb572`

Compare changes

[regal arch]

kwzrd

[branding:seasonal\-structure] 1 new commit

fbe068e Adjust seasonal readme based on Mark's feedback - kwzrd

kwzrd

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

@MarkKoz Thanks for all the feedback!

@lemonsaurus The game jam 2020 conflicts were resolved in b1fb572 by moving them to the new events/ directory. Hopefully you'll agree with this.

@scragly No more misc!

MarkKoz

[bot:update\-logging\-levels] 1 new commit

608f5c5 Use debug log level instead of warning in `post... - MarkKoz

[ebon magnet]

Build 20200328.8 succeeded

Requested by

GitHub

Duration

00:01:41

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #845 Logging Level Adjustments

MarkKoz

[python-discord/bot] New review comment on pull request #845: Logging Level Adjustments

Well I still think it should be visible in production logs so I disagree with it being anything lower than info. Someone looking at logs may not necessarily be looking at Discord to see the edited message.

[ebon magnet]

Build 20200328.9 succeeded

Requested by

GitHub

Duration

00:01:34

Build pipeline

Bot

Build 20200328.10 succeeded

Requested by

GitHub

Duration

00:01:45

Build pipeline

Bot

[regal arch]

sco1

[bot:update\-logging\-levels] 1 new commit

cc153e0 Increase syncer logging level - sco1

[ebon magnet]

Build 20200328.11 succeeded

Requested by

GitHub

Duration

00:01:42

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #845 Logging Level Adjustments

Looks like all warnings have been covered now. Haven't looked at lower levels but they aren't as big of a concern at the moment.

[regal arch]

sco1

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

Nothing immediately leaps out at me as an issue from reviewing the code. This is very well written & seems to test well both locally and from the small-scale staff interaction on the dev server.

I think it's in a great place to trial on the server.

[regal arch]

vivax3794

[python-discord/seasonalbot] New comment on issue #331: Addition of a new command \!wiki

I could work on this, I should be able to do it in a few days when I get the time since I have made exactly a command like this for my twitch bot. so it should mainly just be porting that code over and fixing up the spaghetti I normally leave in my personal projects xD

[night lily]

SeasonalBot Loaded!

Active Season: Evergreen

[regal arch]

brelane33

[python-discord/bot] Fork created: brelane33/bot

[north knot]

Postgres backup completed!

[ebon magnet]

Build 20200329.1 succeeded

Requested by

GitHub

Duration

00:01:42

Build pipeline

Bot

[regal arch]

AG4lyf

[python-discord/seasonalbot] Pull request opened: #386 Bookmark

This PR is addition to #349
I had to destroy that PR because it got old and due to some reasons(me not knowing how to use github CLI tool) I couldn't update the branch and i can't fork until old fork is deleted so here we go.

Closes #341 , Closes #338

• [x] Join the Python Discord Community?
• [x] If dependencies have been added or updated, run pipenv lock?
• [x] Lint your code (pipenv run lint)?
• [x] Set the PR to **allow edits from cont...

[ebon magnet]

Build 20200329.1 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

[regal arch]

AG4lyf

[python-discord/seasonalbot] New comment on pull request #386: Bookmark

About this

I tried making a branch named bookmark like how we normally make from switching branch menu, turned out it was not possible ;-; weird.

neonsea

[python-discord/snekbox] Fork created: neonsea/snekbox

ks129

[python-discord/seasonalbot] New comment on pull request #386: Bookmark

Overall looks good, but one thing: I really don't suggest making commit messages like initial commit. This can be much more descriptive, like Bookmark: Added thing 1, thing 2 ... when you want to make big commit messages, but better will be ever split these to small commits. @AG4lyf

atmishra

[python-discord/bot] Pull request opened: #851 Added whitelist command

Closes #639

This PR adds whitelist command to manage whitelists in the backend DB. Here is how I have designed the command. This is the first time I am working on creating a new command group, so feel free to add your inputs.

General Syntax

Listing whitelisted items of a particular type

![image (2)](https://user-images.githubusercont...

atmishra

[python-discord/bot] New comment on issue #639: \`\!whitelist\` command to whitelist stuff from our filters\.

Hi @MarkKoz I have raised a PR for this.

[ebon magnet]

Build 20200329.2 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

[regal arch]

neonsea

[python-discord/snekbox] Pull request opened: #70 add \-\-dev flag to readme

In the "development environment" section of the readme, it instructs to run pipenv sync to install dependencies and pipenv run precommit immediately after to install the pre-commit hooks. Since the pre-commit package (and related packages) is listed in the pipfile under [dev-packages], this command fails.

Solution: instruct the user to install all dependencies with the --dev flag.

[snekbox] Azure Pipelines checks success on 11fe28f

[ebon magnet]

Build 20200329.1 succeeded

Requested by

GitHub

Duration

00:01:25

Build pipeline

Snekbox

[regal arch]

Akarys42

[python-discord/snekbox] Pull request review submitted: #70 add \-\-dev flag to readme

Seems fair to me

[regal arch]

SebastiaanZ

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

Looks solid. I've looked into the channel position thing (see the code comment) and we could try the approach suggested there. We could also just forgo any attempt of keeping them in order.

SebastiaanZ

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

As we've discovered, this approach does not work. After doing a bit of testing, I found out it's because Discord channels the position integers of channels that are already in the category: If you add a channel to a category, the position of all channels with a higher (or equal?) position integer than the one you're inserting will be increased by one:

Moving channel h to position 8
Before move: [('b', 2), ('e', 5), ('f', 7),           ('i', 10), ('g', 11), ('j', 13), ('m', 19)]
Afte...

SebastiaanZ

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

I think it's a sane decision to use escaped line endings here keep the style within this file consistent with the messages below. The downside of using the style we use at other parts (e.g., in token_remover.py) is that you'd have to insert explicit line endings for the separated paragraphs below.

I still don't like escaping line endings in general, but with these string...

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 7 new commits

c97a75a Deseasonify: remove unused set_username method - kwzrd
98b8a86 Deseasonify: reduce icon shuffle log verbosity - kwzrd
cb58702 Deseasonify: add AssetType enum - kwzrd
abc62d3 Deseasonify: implement generic media asset setter - kwzrd
7d7a78b Deseasonify: use new _apply_asset setter - kwzrd

[ebon magnet]

Build 20200329.2 succeeded

Requested by

GitHub

Duration

00:01:01

Build pipeline

Seasonal Bot

[regal arch]

jos-b

[python-discord/site] Issue opened: #347 Remove custom logging handler and log storage

Since we have solved our logging with the integration of Sentry we have no need for log aggregation on pydis site now.

The custom log API, the methods the Django site uses to store logs in this and the actual log table should be removed from the API.

[regal arch]

MarkKoz

[python-discord/snekbox] Pull request review submitted: #70 add \-\-dev flag to readme

MarkKoz

[python-discord/snekbox] Pull request closed: #70 add \-\-dev flag to readme

MarkKoz

[snekbox:master] 2 new commits

11fe28f add --dev flag to readme - neonsea
46faa97 Merge pull request #70 from neonsea/clarify-readme - MarkKoz

MarkKoz

[python-discord/snekbox] New comment on pull request #70: add \-\-dev flag to readme

Thanks for catching that

MarkKoz

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

MarkKoz

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

I really appreciate you looking into this. I'll try to implement your code into the cog.

[north knot]

Auto-deployed: snekbox

[regal arch]

[snekbox] Azure Pipelines checks success on master

[ebon magnet]

Build 20200329.2 succeeded

Requested by

GitHub

Duration

00:01:26

Build pipeline

Snekbox

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #848 Hard\-coded PEP 0 to \!pep command

Thanks!

MarkKoz

[python-discord/bot] Pull request review submitted: #849 Discord Webhook URL removing

[regal arch]

sco1

[python-discord/bot] Pull request review submitted: #848 Hard\-coded PEP 0 to \!pep command

sco1

[python-discord/bot] Issue closed: #805 Pep command cannot fetch PEP 0\.

sco1

[python-discord/bot] Pull request closed: #848 Hard\-coded PEP 0 to \!pep command

sco1

[bot:master] 6 new commits

aba5c32 (PEP Command): Hard-coded PEP 0 - ks129
e955b83 (PEP Command): Fixed comment of explanation of ... - ks129
317b5db (PEP Command): Moved icon URL to constant inste... - ks129
3e81904 (PEP Command): Moved PEP 0 information to hard-... - ks129
8bebc1e (PEP Command): Fixed comment about PEP 0 separa... - ks129

[ebon magnet]

Build 20200329.4 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Bot

[north knot]

Auto-deployed: bot

[oak estuary]

Python Bot

Connected!

[ebon magnet]

Build 20200329.3 succeeded

Requested by

GitHub

Duration

00:04:08

Build pipeline

Bot

[regal arch]

sco1

[python-discord/bot] Pull request review submitted: #849 Discord Webhook URL removing

sco1

[python-discord/bot] Issue closed: #788 Filter Discord Webhook URLs

sco1

[python-discord/bot] Pull request closed: #849 Discord Webhook URL removing

sco1

[bot:master] 17 new commits

f086fb2 (Webhook Detection): Created cog. - ks129
f4b5718 (Webhook Detection): Added webhook match regex. - ks129
e5c41fa (Webhook Detection): Added cog loading to __mai... - ks129
7e34c5e (Webhook Detection): Added ModLog fetching pr... - ks129
3a9494d (Webhook Detection): Created `delete_and_respon... - ks129

[north knot]

Auto-deployed: bot

[oak estuary]

Python Bot

Connected!

[ebon magnet]

Build 20200329.5 succeeded

Requested by

GitHub

Duration

00:03:26

Build pipeline

Bot

[regal arch]

ks129

[python-discord/bot] Pull request opened: #852 Don't let change expiration time when infraction already expired\.

Closes #850

scragly

[python-discord/bot] Issue opened: #853 Command for editing bot authored messages\.

In order to assist staff being able to send bot-authored commands to avoid restricting the ability to edit it's contents to a single person, a command to edit a target message without resorting to int eval could make the experience a little friendlier.

There's a possibility that we have other message-related commands that could be appropriately grouped together, so a consideration might be to add a message|msg parent group for these utilities.

[ebon magnet]

Build 20200329.6 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 3 new commits

bad7223 Deseasonify: add month_override env var - kwzrd
0c7d501 Deseasonify: validate configured month override - kwzrd
b4b3ea0 Deseasonify: add helper func to resolve current... - kwzrd

[ebon magnet]

Build 20200329.3 succeeded

Requested by

GitHub

Duration

00:01:21

Build pipeline

Seasonal Bot

[regal arch]

MarkKoz

[python-discord/bot] New comment on issue #745: Add ability to remove bot tag responses\.

I'm fine with that approach. Simple and familiar. Let's just always do it rather than only when using fuzzy matching.

ks129

[python-discord/bot] New comment on issue #745: Add ability to remove bot tag responses\.

I'll work on it.

[regal arch]

MarkKoz

[bot:feat/frontend/o200/help\-channels] 3 new commits

28e9c74 HelpChannels: fix alphabetical sorting of dorma... - MarkKoz
0c6a5a1 HelpChannels: remove positions from element names - MarkKoz
1509d3b BotCog: fix AttributeError getting a category f... - MarkKoz

MarkKoz

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

MarkKoz

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

It works! But what would happen if the channel_names list is unsorted or partially sorted? discord.py sorts the category's channels by position rather than by name. Would it be better to sort them by name ourselves?

MarkKoz

[bot:feat/frontend/o200/help\-channels] 1 new commit

00c9f09 HelpChannels: fix typo in docstring - MarkKoz

[ebon magnet]

Build 20200330.1 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

Build 20200330.2 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

[regal arch]

MarkKoz

[python-discord/bot] New comment on pull request #786: Implement a new help channel system

Having trouble ignoring mod log events since moving a channel and changing its topic seem to dispatch separate channel update events.

[regal arch]

MarkKoz

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

I'm happy with this.

[north knot]

Postgres backup completed!

[regal arch]

ks129

[python-discord/bot] Pull request opened: #854 Tags response \+ command message deletion with trashcan reaction

Closes #745

[ebon magnet]

Build 20200330.3 succeeded

Requested by

GitHub

Duration

00:01:55

Build pipeline

Bot

[regal arch]

ks129

[python-discord/site] New comment on issue #309: Track usage of off topic names to better distribute name usage\.

Can I work on this?

[regal arch]

lemonsaurus

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

I think this structure looks excellent, a huge improvement on the current. If you can answer some of my questions, I'd be happy to merge afterwards.

lemonsaurus

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

Perhaps we should link the seasonalbot repo from this readme?

While the primary function is to organize the various assets we have, they are also used by **[Seasonalbot](https://github.com/python-discord/seasonalbot)'s branding manager**. The bot will automatically apply seasonal assets pulled directly from this repository to the server. In order for Seasonalbot to properly detect and apply assets, certain conventions must be followed.

lemonsaurus

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

Is there any particular reason we're requiring banners and avatars to be png? Doesn't discord technically support other formats?

lemonsaurus

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

this is very cool, and a nice clarification.

[regal arch]

neonsea

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

neonsea

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

It ensures consistent lossless image quality across the board, and is supported by pretty much every image editor/viewer out there. Encoding it with any other format is prone to differences in quality (compression levels, artifacting, etc). Not sure if this is the reason, but it's a reason.

neonsea

[python-discord/branding] New comment on pull request #46: Re\-organize seasonal branding

Looks great.

Akarys42

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

Akarys42

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

Most of the assets are vectorized, using a format with compression would be horrendous if we need to edit them later.

neonsea

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

neonsea

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

Vectors still need to be converted to bitmaps if we want to use them anywhere.

[native jolt]

dependabot-preview[bot]

[flake8-annotations:dependabot/pip/pep8\-naming\-0\.10\.0] 1 new commit

e39abbd Bump pep8-naming from 0.9.1 to 0.10.0 - dependabot-preview[bot]

dependabot-preview[bot]

[python-discord/flake8-annotations] New branch created: dependabot/pip/pep8\-naming\-0\.10\.0

dependabot-preview[bot]

[python-discord/flake8-annotations] Pull request opened: #74 Bump pep8\-naming from 0\.9\.1 to 0\.10\.0

Bumps pep8-naming from 0.9.1 to 0.10.0.

Changelog
Sourced from pep8-naming's changelog.

0.10.0 - 2020-03-20 ------------------

--ignore-names now supports globbing and applies to the N804 and N805 checks.
"acronym" imports are now treated as their own error code (N817).
Metaclass detection has been improved.
Annotated variable declarations (PEP 526) and := variable assignments are now supported.

Commits

666ab84 Prepare the version 0.10...

[regal arch]

eivl

[python-discord/bot] Pull request review submitted: #812 Implement silencer \(hush\) cog\.

eivl

[python-discord/bot] New review comment on pull request #812: Implement silencer \(hush\) cog\.

Magic numbers aside, I really like this implementation.

[ebon magnet]

Build 20200330.4 succeeded

Requested by

GitHub

Duration

00:01:36

Build pipeline

Bot

[regal arch]

eivl

[python-discord/bot] Issue closed: #661 \!hush command

eivl

[python-discord/bot] Pull request closed: #812 Implement silencer \(hush\) cog\.

eivl

[bot:master] 64 new commits

1231f38 Add HushDurationConverter. - Numerlor
be67389 Add Silence cog. - Numerlor
1f8933f Add logging to loop start and loop end. - Numerlor
4254053 Restrict cog to moderators. - Numerlor
8be3c7d Add handling for shh/unshh for CommandNotFound. - Numerlor

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200330.5 succeeded

Requested by

GitHub

Duration

00:03:29

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

SebastiaanZ

[bot:master] 1 new commit

582ddbb Set unsilence permissions to inherit instead of... - SebastiaanZ

[north knot]

Auto-deployed: bot

[ebon magnet]

Build 20200330.6 succeeded

Requested by

GitHub

Duration

00:03:16

Build pipeline

Bot

[oak estuary]

Python Bot

Connected!

[regal arch]

lemonsaurus

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

Almost annoyingly clean code. help_channels is a master class in good object oriented design and use of helper functions. This is an impressive solution that I'd be proud to have in our codebase.

lemonsaurus

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

We shouldn't put the number 45 here, since this is a configurable parameter that may change - and in fact, it's not even set to 45 in the settings in this PR.

lemonsaurus

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

Intentional typo?

        """Return channel names which are already being used."""

lemonsaurus

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

unintentional typo?

        # This may confuse users. So would potentially long delays for the cog to become ready.

[regal arch]

AG4lyf

[python-discord/seasonalbot] New comment on pull request #386: Bookmark

@ks129 this is just the same commits from old PR . there is nothing changed actually. so same commit messages of #349 applies here

[native jolt]

sco1

[python-discord/flake8-annotations] New comment on pull request #74: Bump pep8\-naming from 0\.9\.1 to 0\.10\.0

Will address in #73

sco1

[python-discord/flake8-annotations] Pull request closed: #74 Bump pep8\-naming from 0\.9\.1 to 0\.10\.0

dependabot-preview[bot]

[python-discord/flake8-annotations] New comment on pull request #74: Bump pep8\-naming from 0\.9\.1 to 0\.10\.0

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot-preview[bot]

[python-discord/flake8-annotations] branch deleted: dependabot/pip/pep8\-naming\-0\.10\.0

[regal arch]

ks129

[python-discord/site] Pull request opened: #348 Off\-topic channel names non random selecting

I don't know, is this best way to do this, but I'm not super good with Django. Bot side implementation is simple: Under task, for request, add a new query param: mark_used. I'm not gonna add anything in bot side before this way to do this get approved. Should fix #309

[site] Azure Pipelines checks failure on a3d2938

vivax3794

[python-discord/seasonalbot] New comment on issue #331: Addition of a new command \!wiki

should I just start working on this?

[regal arch]

neonsea

[python-discord/snekbox] Pull request opened: #71 WIP: Initial support for running unix commands

Description

This is a patchset to utilise snekbox to run Unix commands (namely GNU/Linux Debian stable).

Implementation

It implements a new API endpoint /unixcmd, the usage of which is analogue to the already existing /eval endpoint - but instead of evaluating the input parameter value as Python code, it is executed in a real Linux environment in a bash shell. As with /eval, it returns output with the combined output of stdout and stderr and whatever return code bas...

[snekbox] Azure Pipelines checks failure on 4b43078

[ebon magnet]

Build 20200330.1 failed

Requested by

GitHub

Duration

00:04:01

Build pipeline

Snekbox

[regal arch]

[snekbox] Azure Pipelines checks success on 40d70e7

[ebon magnet]

Build 20200330.2 succeeded

Requested by

GitHub

Duration

00:04:35

Build pipeline

Snekbox

[regal arch]

MarkKoz

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

MarkKoz

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

I prefer to leave it.

MarkKoz

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

MarkKoz

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

The typo I mentioned in the meeting was fixed in 00c9f092a0c056b21e012fdadd807d0410a3ca09 😄

MarkKoz

[bot:feat/frontend/o200/help\-channels] 1 new commit

c289111 HelpChannels: fix typos in docstrings - MarkKoz

[ebon magnet]

Build 20200330.7 succeeded

Requested by

GitHub

Duration

00:01:45

Build pipeline

Bot

Build 20200330.8 succeeded

Requested by

GitHub

Duration

00:01:51

Build pipeline

Bot

[regal arch]

kwzrd

[branding:seasonal\-structure] 1 new commit

b3a1b10 Hyperlink Seasonalbot repo in seasonal README - kwzrd

MarkKoz

[python-discord/branding] Pull request review dismissed: #46 Re\-organize seasonal branding

I'm happy with this.

kwzrd

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

kwzrd

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

Good idea, thanks. Added in b3a1b10.

MarkKoz

[bot:feat/frontend/o200/help\-channels] 1 new commit

58fad65 HelpChannels: use constant names instead of def... - MarkKoz

MarkKoz

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

MarkKoz

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

I've removed references to default values and replaced them with references to the config variable names.

SebastiaanZ

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

SebastiaanZ

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

If the channel_names list is partially sorted and/or entirely out of order, we will slowly start building an order and it will get back into order at the latest when every channel has been cycled once. I'm not quite sure what sorting the list manually would do, except that it will guarantee that we then insert a channel before the one it's supposed to come for.

That could be preferable, but it won't be a magic "sorting fix". We could also try to detect if the thing is out of order and, i...

[native jolt]

sco1

[flake8-annotations:dev\-next] 1 new commit

41a9bc8 Dependency bump & add pep8-naming to dependabot... - sco1

[ebon magnet]

Build 20200330.9 succeeded

Requested by

GitHub

Duration

00:01:58

Build pipeline

Bot

[regal arch]

kwzrd

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

kwzrd

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

@lemonsaurus: Is there any particular reason we're requiring banners and avatars to be png? Doesn't discord technically support other formats?

Technically, we could support them. However, I believe neither bot avatars nor banners can be animated at the moment. We do not currently have any static non-png assets, and I do not foresee us having them. The png format just appears to be the most fitting for this use case.

Therefore, I decided to make my life easier on Seasonalbot's side, an...

MarkKoz

[python-discord/bot] New review comment on pull request #786: Implement a new help channel system

I'm fine with it as it is since it will eventually fix itself. It should only get out of order if someone accidentally moves a channel (or if the implementation turns out to not always work). An separate issue can be opened to tackle this in a more clever way.

MarkKoz

[python-discord/bot] Pull request review submitted: #786 Implement a new help channel system

Akarys42

[python-discord/snekbox] New comment on pull request #71: WIP: Initial support for running unix commands

I looks like a pretty good and very clean implementation. Although, do we want snekbox to support both python and unix commands, or create another project for it? The name itself doesn't really make sense anymore imo

sentry-io[bot]

[python-discord/seasonalbot] Issue opened: #387 Minesweeper: KeyError in reveal command when game no longer exists

Sentry Issue: SEASONALBOT-A

KeyError: 
  File "discord/ext/commands/core.py", line 83, in wrapped
    ret = await coro(*args, **kwargs)
  File "bot/seasons/evergreen/minesweeper.py", line 256, in reveal_command
    game = self.games[ctx.author.id]

Unhandled command error: 

neonsea

[python-discord/snekbox] New comment on pull request #71: WIP: Initial support for running unix commands

I think the name makes sense - the project is still a Python implementation :)

On a more serious note, if this were a separate project, it would have a lot of overlapping code with snekbox as it would technically be largely the same backend. Maintaining two different projects for what are essentially the same things doesn't seem advantageous to me, but I want to hear more thoughts on this.

kwzrd

[python-discord/branding] Pull request review submitted: #46 Re\-organize seasonal branding

kwzrd

[python-discord/branding] New review comment on pull request #46: Re\-organize seasonal branding

I don't think it's necessary. We've linked the repository as per your other suggestion, the cog shouldn't be difficult to find.

I'm not sure how linking would work in this case - if we reference a specific commit, the link would become outdated, right?

[regal arch]

MarkKoz

[bot:feat/frontend/o200/help\-channels] 1 new commit

d37a0a1 ModLog: ignore update channel events for help c... - MarkKoz

[ebon magnet]

Build 20200330.10 succeeded

Requested by

GitHub

Duration

00:01:47

Build pipeline

Bot

[regal arch]

scragly

[python-discord/bot] Issue opened: #855 Discord Channel Logs Improvements

Note: This issue description is a brief and will be expanded in the near future with full details.

Current Setup

We use discord channels for providing logs of certain events, such as moderative actions, member updates, guild updates, message updates.

Log output is done through individual webhooks, to avoid contributing to the bot rate limits unnecessarily, and as it is an appropriate choice for a send-and-forget log system.

Sending messages to the logs requires hooking into the...

MarkKoz

[bot:feat/frontend/o200/help\-channels] 1 new commit

740bf3e HelpChannels: set to enabled by default - MarkKoz

[ebon magnet]

Build 20200330.11 succeeded

Requested by

GitHub

Duration

00:01:45

Build pipeline

Bot

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 3 new commits

fbcdf13 Deseasonify: add default persistent config file... - kwzrd
9259f98 Deseasonify: add persistent branding configuration - kwzrd
548dc99 Deseasonify: remove autostart env var - kwzrd

[ebon magnet]

Build 20200330.1 succeeded

Requested by

GitHub

Duration

00:00:52

Build pipeline

Seasonal Bot

[regal arch]

kwzrd

[seasonalbot:seasonal\-purge] 2 new commits

0e117b4 Deseasonify: move current month resolver to utils - kwzrd
83f5b0c Deseasonify: resolve current season w.r.t. mont... - kwzrd

[ebon magnet]

Build 20200330.2 succeeded

Requested by

GitHub

Duration

00:01:02

Build pipeline

Seasonal Bot

[regal arch]

RohanJnr

[python-discord/bot] New comment on issue #778: Role restricted tags

I would like to work on this.

[regal arch]

kwzrd

[python-discord/seasonalbot] New comment on pull request #329: Deseasonify: Make all cogs available year\-round, and manage only branding by season\.

I think the time has come for me to open this for review. The original tasks of the PR (and a couple more) have been accomplished, and although there remain parts of this repository that could use a little touch-up, I believe that's all out of the originally intended scope.

This project hasn't been entirely easy for me to work on. It's the largest PR that I've ever opened, and in its nature somewhat different to the typical "add a new cog" contribution. I've never really been able to defin...

ks129

[python-discord/bot] New comment on issue #778: Role restricted tags

I think one way to solve this is using Markdown Metadata. There should something like required_role: moderator or something and bot should check this.

MarkKoz

[python-discord/snekbox] Pull request review submitted: #71 WIP: Initial support for running unix commands

Have not tried it out yet but looks good so far.

MarkKoz

[python-discord/snekbox] New review comment on pull request #71: WIP: Initial support for running unix commands

Avoid using pipenv run inside Docker because it will create a venv. It cannot know that a --system install was done.

MarkKoz

[python-discord/snekbox] New comment on pull request #71: WIP: Initial support for running unix commands

Yes, the name isn't totally accurate but whatever - it's just a name. For simplicity's sake, it makes most sense to keep everything together. You're correct about the similarities they would share. That would either involve duplicating code (hard to maintain) or creating a third repo for a common library (adds complexity to the dev process).

MarkKoz

[python-discord/snekbox] New comment on pull request #71: WIP: Initial support for running unix commands

Another thing you'll need to do is update documentation such as README.md and docstrings.

neonsea

[python-discord/snekbox] Pull request review submitted: #71 WIP: Initial support for running unix commands

neonsea

[python-discord/snekbox] New review comment on pull request #71: WIP: Initial support for running unix commands

Any suggestions for this?

MarkKoz

[python-discord/bot] New comment on pull request #846: Filtering: merge the word and token watch filters

No, the word boundaries are still added automatically.

MarkKoz

[python-discord/snekbox] Pull request review submitted: #71 WIP: Initial support for running unix commands

MarkKoz

[python-discord/snekbox] New review comment on pull request #71: WIP: Initial support for running unix commands

Invoke the command directly in the Dockerfile. What is the rationale for having it in the Pipfile in the first place?