#dev-log

1 messages · Page 42 of 1

regal archBOT
ebon magnetBOT
#

Build 20200229.6 succeeded

Requested by

GitHub

Duration

00:01:38

Build pipeline

Bot

regal archBOT
#
SebastiaanZ
[python-discord/bot] New review comment on pull request #755: Don't suppress all errors in scheduler

This is a smart way of doing it and it handles the three cases I can think of nicely. I also like the logging approach we've got here and I think it's best we can do for now. We could look into signalling an exception back to the user directly, but, honestly, the people that matter get to see it anyway as long as we're using Sentry because if exceptions are raised within a task, they should either be handled or it's a bug waiting to be fixed.

I'm sure we as core-devs can contact the user i...

ebon magnetBOT
#

Build 20200229.7 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

regal archBOT
#
SebastiaanZ
[bot:master] 18 new commits

95fd351 Scheduler: fix #754 - only suppress CancelledError - MarkKoz
f905f73 Scheduler: remove create_task function - MarkKoz
f5cd7e3 Scheduler: correct schedule_task's docstring - MarkKoz
0d05be3 Scheduler: remove loop parameter from schedule_... - MarkKoz
6b7c0a7 Scheduler: raise task exceptions besides Cancel... - MarkKoz

#
SebastiaanZ
[python-discord/bot] branch deleted: bug/backend/b754/scheduler\-suppresses\-errors
north knotBOT
ebon magnetBOT
#

Build 20200229.8 succeeded

Requested by

GitHub

Duration

00:03:18

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200229.1 succeeded

Requested by

GitHub

Duration

00:00:43

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.9 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

#

Build 20200229.10 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.11 succeeded

Requested by

GitHub

Duration

00:01:34

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.12 failed

Requested by

GitHub

Duration

00:01:02

Build pipeline

Bot

#

Build 20200229.13 failed

Requested by

GitHub

Duration

00:01:17

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.14 failed

Requested by

GitHub

Duration

00:00:56

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.15 failed

Requested by

GitHub

Duration

00:01:10

Build pipeline

Bot

regal archBOT
regal archBOT
#
kwzrd
[python-discord/branding] New branch created: seasonal\-structure
regal archBOT
ebon magnetBOT
#

Build 20200229.16 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.17 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.18 succeeded

Requested by

GitHub

Duration

00:01:30

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.19 succeeded

Requested by

GitHub

Duration

00:01:42

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200229.20 succeeded

Requested by

GitHub

Duration

00:01:42

Build pipeline

Bot

regal archBOT
#
kwzrd
[python-discord/branding] Pull request opened: #46 Re\-organize seasonal branding

Closes #45

Opening a draft so that it's easier to see where I'm going with this.

I've basically adopted @lemonsaurus 's proposed approach, as I liked it the most. The idea is to follow the structure given by seasons:

├── branding/
│ ├── seasonal/
│ │ ├── christmas/
│ │ │ ├── server_icons/
│ │ │ │ ├── snowing.gif
│ │ │ │ ├── bells.gif
│ │ │ │ ├── santa.png
│ │ │ ├── misc/
│ │ │ │ ├── banner_2018.png
│ │ │ │ ├── santa_256.png
│ │ │ │ ├── santa_512.png
│ │ │ ├── banner.png...
ebon magnetBOT
#

Build 20200229.21 succeeded

Requested by

GitHub

Duration

00:01:58

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200229.22 succeeded

Requested by

GitHub

Duration

00:01:54

Build pipeline

Bot

night lilyBOT
#
SeasonalBot Loaded!

Active Season: Evergreen

regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: feat/frontend/b000/coloured\-logs
north knotBOT
#

Postgres backup completed!

regal archBOT
#
MarkKoz
[python-discord/bot] Pull request opened: #806 Coloured log output

The coloredlogs module was used. It requires colorma on Windows, which pipenv will install if it detects Windows as the current OS. It is configured to only affect logs to stdout.

bild

Besides the colours, the other notable difference is the omission of milliseconds from the timestamp. This is coloredlog's default behaviour. It can be changed, but...

ebon magnetBOT
#

Build 20200301.1 succeeded

Requested by

GitHub

Duration

00:01:55

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200301.2 failed

Requested by

GitHub

Duration

00:01:17

Build pipeline

Bot

#

Build 20200301.3 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200301.1 succeeded

Requested by

GitHub

Duration

00:02:05

Build pipeline

Site

regal archBOT
#
lemonsaurus
[python-discord/site] branch deleted: feat/deps/s335/wiki\-pypi
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200301.2 succeeded

Requested by

Leon Sandøy

Duration

00:03:32

Build pipeline

Site

regal archBOT
regal archBOT
regal archBOT
#
AG4lyf
[python-discord/seasonalbot] New comment on issue #348: Problems with Reddit command\.

Bot doesn't check if the reddit have any post in it.
Such reddit can be /r/makemyideas
Bot fails silently
I found this on private testing

03/01/20 09:29:29 - bot.seasons.evergreen.error_handler ERROR: Unhandled command error: list index out of range
Traceback (most recent call last):
  File "/home/ag/.local/share/virtualenvs/seasonalbot-0Ba-uPuk/lib/python3.8/site-packages/discord/ext/commands/core.py", line 79, in wrapped
    ret = await coro(*args, **kwargs)
  File "/home/a...
regal archBOT
#
eivl
[python-discord/bot] branch deleted: feat/frontend/b000/coloured\-logs
north knotBOT
ebon magnetBOT
#

Build 20200301.4 succeeded

Requested by

GitHub

Duration

00:03:07

Build pipeline

Bot

oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200301.3 succeeded

Requested by

GitHub

Duration

00:01:51

Build pipeline

Site

regal archBOT
#
eivl
[site:master] 4 new commits

a54d978 Make newlines visible in deleted messages - SebastiaanZ
fa7c2aa Merge branch 'master' into deleted-messages-vis... - jos-b
36ccee0 Merge branch 'master' into deleted-messages-vis... - SebastiaanZ
5e4027b Merge pull request #304 from python-discord/del... - eivl

#
eivl
[python-discord/site] branch deleted: deleted\-messages\-visible\-line\-endings
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200301.4 succeeded

Requested by

GitHub

Duration

00:03:25

Build pipeline

Site

regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New comment on issue #792: \!clean command returns malformed API request

The issue is caused by a small oversight in how ModLog.upload_log handles empty attachment lists. Normally, attachments is a list of lists, with each sublist containing the attachments for that particular message

However, if the attachments kwarg isn't used (i.e., gets the default None value), we initialize attachments with an empty outer list. That results in us adding None from the default value of zip_longests in the request part instead of an empty list indicating that a me...

regal archBOT
ebon magnetBOT
#

Build 20200301.5 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

regal archBOT
#
jos-b
[python-discord/bot] Pull request review dismissed: #783 Migrate bot to Python 3\.8

While testing locally it appears that contextlib.suppress is not stopping CancelledError from being raised.

bot_1       | 2020-02-25 19:23:16,017 | asyncio | ERROR | Exception in callback _silent_exception(>) at /bot/bot/utils/scheduling.py:71
bot_1       | handle: <Handle _silent_exception(>) at /bot/bot/utils/scheduling.py:71>
bot_1       | Traceback (most recent call last):
bot_1       |   File "/usr/local/lib/python3.8/asyncio/events.py", line 81, in _run
bot_1       |     s...
ebon magnetBOT
#

Build 20200301.6 succeeded

Requested by

GitHub

Duration

00:02:20

Build pipeline

Bot

regal archBOT
#
Akarys42
[python-discord/bot] New review comment on pull request #617: Autodelete offensive messages after one week\.

Yeah, I put the except here in order to avoid uncaught exception, I think rescheduling them seems like the way to go.
I'm not sure about unremoveable messages you're talking about though. Are you talking about errors not caused by a discord downtime, but by an actual error that will not solve with time? If so, yeah, it could be an issue. We could also delete them anyway if the deletion failed more than 3 times for instance.

ebon magnetBOT
#

Build 20200301.7 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

#

Build 20200301.8 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200301.9 succeeded

Requested by

GitHub

Duration

00:01:59

Build pipeline

Bot

regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200301.10 succeeded

Requested by

GitHub

Duration

00:03:16

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200301.11 failed

Requested by

GitHub

Duration

00:01:08

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200301.12 succeeded

Requested by

GitHub

Duration

00:01:30

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200301.13 succeeded

Requested by

GitHub

Duration

00:01:19

Build pipeline

Bot

regal archBOT
#
jos-b
[python-discord/bot] New branch created: ban\-grabify\-urls
ebon magnetBOT
#

Build 20200301.14 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Bot

regal archBOT
#
kwzrd
[python-discord/bot] branch deleted: ban\-grabify\-urls
north knotBOT
ebon magnetBOT
#

Build 20200301.15 succeeded

Requested by

GitHub

Duration

00:03:16

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200301.16 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

#

Build 20200301.1 succeeded

Requested by

GitHub

Duration

00:00:37

Build pipeline

Seasonal Bot

native joltBOT
regal archBOT
ebon magnetBOT
#

Build 20200301.17 succeeded

Requested by

GitHub

Duration

00:01:22

Build pipeline

Bot

native joltBOT
regal archBOT
#
Suhail6inkling
[python-discord/seasonalbot] Pull request opened: #365 Connect Four Game

Relevant Issues

Closes #244

Description

Added a ConnectFour cog which includes a connectfour command (with several different aliases) to allow users to play a Connect Four game in a specific channel

Also includes an ai subcommand to allow a user to play against a "CPU" player

Reasoning

This was part of the retro gaming season we had. Better late than never!

Screenshots

![image](https://user-images.githubusercontent.com/38522108/75635092-3c0b7180-5c0b-11...

native joltBOT
ebon magnetBOT
#

Build 20200301.2 succeeded

Requested by

GitHub

Duration

00:00:39

Build pipeline

Seasonal Bot

native joltBOT
#
sco1
[python-discord/flake8-annotations] New tag created: v2\.0\.1
#
sco1
[python-discord/flake8-annotations] branch deleted: property\-decorator
#
sco1
[python-discord/flake8-annotations] New branch created: dev\-next
regal archBOT
#
sco1
[python-discord/bot] branch deleted: python38\-migration
north knotBOT
ebon magnetBOT
#

Build 20200301.18 succeeded

Requested by

GitHub

Duration

00:02:55

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
sco1
[python-discord/bot] Issue opened: #810 Tag Suggestions

PyDis' Python bot uses !tags to provide brief, canonical explanations for common questions, programming pitfalls, and other Python related topics.

Use this issue to suggest additional tags, bonus points if you help out with the body of the tag as well!

edit: Since there's often an overlap between what's desired for a tag vs. the ability for a wiki article to be more comprehensive, I've expanded the scope of this to also include suggestions for Wiki articles (implemented soon) so you d...

regal archBOT
#
sco1
[python-discord/seasonalbot] New branch created: tidy\-seasonal\-channels
ebon magnetBOT
#

Build 20200301.3 succeeded

Requested by

GitHub

Duration

00:00:47

Build pipeline

Seasonal Bot

regal archBOT
native joltBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] New review comment on pull request #364: Space Cog implementing

NASA uses the title "Astronomy Picture of the Day", although it leaves the t out of the initialism they use (apod) in the url.

Additionally, the "in" in "Astronomy Picture of the Day in [date here]" doesn't sound right to me, but I'm not a native speaker of English. I think we sidestep the issue by using a separator (e.g., -) here instead of a word. Still, we do have a few native speakers in the core dev team, so maybe you'll get another opinion on this soon.

       ...
regal archBOT
regal archBOT
regal archBOT
#
lemonsaurus
[python-discord/bot] New review comment on pull request #617: Autodelete offensive messages after one week\.

What if the message was manually deleted after the filter trigger? This is quite likely to happen a lot, and perhaps warning is not the right log level to use for this if we're going to be seeing it every time somone has deleted the message manually. I mean, as long as the message is gone, that's a good thing and no warning is necessary.

If we rescheduled these so that they would at least attempt to delete the message twice, then we could safely assume that if it fails twice, it's not due ...

#
lemonsaurus
[python-discord/bot] New comment on issue #767: Filters should not apply to staff members

Looks like you're right. It appears for AntiSpam, this is already solved, but on Filtering we have a config option with a role whitelist where not all staff members are on the whitelist.

I kind of feel like this is logic duplication, though. We probably be using the same whitelist for all three of these cogs, rather than solving the problem in three different ways. Perhaps we should refactor the approach taken in AntiMalware and AntiSpam to use the same role whitelist that Filtering does, ...

#
SebastiaanZ
[python-discord/bot] New review comment on pull request #617: Autodelete offensive messages after one week\.

What if the message was manually deleted after the filter trigger? This is quite likely to happen a lot,

There's a special except NotFound clause with an info-level log message. This clause seems to be specifically for messages that the bot either could not fetch for other reasons that NotFound (whatever that may be, it could be a temporary API fluke at Discord's end) or where the deletion action fails (for whatever reason).

north knotBOT
ebon magnetBOT
#

Build 20200302.1 succeeded

Requested by

Leon Sandøy

Duration

00:03:21

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200302.1 succeeded

Requested by

GitHub

Duration

00:00:41

Build pipeline

Seasonal Bot

regal archBOT
regal archBOT
#
Akarys42
[python-discord/bot] New branch created: autoconfig
ebon magnetBOT
#

Build 20200302.2 succeeded

Requested by

GitHub

Duration

00:00:45

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20200302.2 succeeded

Requested by

GitHub

Duration

00:01:31

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200302.3 succeeded

Requested by

GitHub

Duration

00:00:43

Build pipeline

Seasonal Bot

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: feat/deps/o138/pre\-commit\-hooks
regal archBOT
#
MarkKoz
[python-discord/bot] Pull request opened: #811 Add more pre\-commit hooks and run them in CI

New hooks were added for pre-commit and they will run in CI too. The pipenv run lint script will now run all the new hooks, including flake8.

Hooks added

A couple of these hooks automatically apply fixes. However, they still report failure and leave any changes they make uncommitted. Therefore, the user has to commit the automatic fixes.

  • check-merge-conflict - Check for files that contain merge conflict strings.
  • check-toml - Attempts to load all toml files to verify sy...
ebon magnetBOT
#

Build 20200302.3 succeeded

Requested by

GitHub

Duration

00:01:55

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200302.4 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

regal archBOT
#
Numerlor
[python-discord/bot] Pull request opened: #812 Implement silencer \(hush\) cog\.

closes: #661
Adds silencer cog with requested capabilities.

  • [x] !hush restricts Developers role in invoked or specified channel.
  • [x] silence/unsilence aliases
  • [x] custom duration, including forever
  • [x] ping mods periodically with channels that are hushed forever.
  • [ ] list hushed channels
  • [ ] !shh/!unshh with arbitrary amount of hs after for specifying duration
  • [ ] tests
ebon magnetBOT
#

Build 20200302.5 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200303.1 succeeded

Requested by

GitHub

Duration

00:02:01

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: feat/ci/b000/cache\-pipenv
ebon magnetBOT
#

Build 20200303.2 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.3 succeeded

Requested by

GitHub

Duration

00:02:43

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.4 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.5 failed

Requested by

GitHub

Duration

00:00:35

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.6 failed

Requested by

GitHub

Duration

00:00:35

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.7 succeeded

Requested by

GitHub

Duration

00:02:28

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
#
eivl
[python-discord/seasonalbot] branch deleted: tidy\-seasonal\-channels
north knotBOT
ebon magnetBOT
#

Build 20200303.1 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Seasonal Bot

night lilyBOT
#
SeasonalBot Loaded!

Active Season: Evergreen

regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New comment on pull request #811: Add more pre\-commit hooks and run them in CI

It's worth noting that moving flake8 out of the virtual environment also comes with a disadvantage for local development. While it's still going to be possible to run the linter from the command line using pre-commit, it will break editors that use flake8 to lint within the editor. There may be ways to deal with this, as I haven't looked into whether or not it's possible to configure editors in such a way that they're able to use pre-commit's flake8, but this will be a more complicated an...

regal archBOT
ebon magnetBOT
#

Build 20200303.8 succeeded

Requested by

GitHub

Duration

00:01:35

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.9 succeeded

Requested by

GitHub

Duration

00:02:26

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.10 succeeded

Requested by

GitHub

Duration

00:01:16

Build pipeline

Bot

#

Build 20200303.11 succeeded

Requested by

GitHub

Duration

00:01:27

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.12 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

regal archBOT
#
MarkKoz
[bot:master] 15 new commits

edffd9b API: accept additional session kwargs for recre... - MarkKoz
b19e6aa Bot: avoid DeprecationWarning for aiohttp.Async... - MarkKoz
253073a Bot: add warning for when connector is a specif... - MarkKoz
9b6c9e8 Bot: fix error trying to close a None session - MarkKoz
a21f4e6 Bot: override login() instead of start() - MarkKoz

#
MarkKoz
[python-discord/bot] branch deleted: bug/backend/b748/resolver\-in\-coro
ebon magnetBOT
#

Build 20200303.14 failed

Requested by

GitHub

Duration

00:00:42

Build pipeline

Bot

north knotBOT
ebon magnetBOT
#

Build 20200303.13 succeeded

Requested by

GitHub

Duration

00:03:01

Build pipeline

Bot

regal archBOT
oak estuaryBOT
ebon magnetBOT
#

Build 20200303.15 succeeded

Requested by

GitHub

Duration

00:01:20

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] New comment on pull request #811: Add more pre\-commit hooks and run them in CI

OK. What do you all think of using this hack in CI?

printf '%s\n%s' '#!/bin/bash' '"${@:2}"' >> pipenv && chmod +x pipenv

It creates a mock pipenv run executable. It will ignore the first arg (i.e. ignore the run in pipenv run) and interpret the rest as if it was a command. It'll get prepended to PATH somewhere so that when pre-commit runs the flake8 hook, it will prefer it as the pipenv executable over the normal one.

ebon magnetBOT
#

Build 20200303.16 succeeded

Requested by

GitHub

Duration

00:02:47

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200303.17 succeeded

Requested by

GitHub

Duration

00:01:08

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200304.1 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

regal archBOT
#
sco1
[python-discord/bot] New branch created: watchchannel\-dm
ebon magnetBOT
#

Build 20200304.2 succeeded

Requested by

GitHub

Duration

00:01:39

Build pipeline

Bot

#

Build 20200304.3 succeeded

Requested by

GitHub

Duration

00:01:30

Build pipeline

Bot

regal archBOT
regal archBOT
#
sco1
[python-discord/bot] New comment on issue #775: Add pep8\-naming to linting toolchain

I'll add this in with #811 since we're already making other linting changes.

Running against the branch in its current state yields the following errors:

$ flake8 .
.\bot\utils\__init__.py:57:40: N803 argument name 'F' should be lowercase
.\tests\base.py:34:10: N802 function name 'assertNotLogs' should be lowercase
.\tests\base.py:84:10: N802 function name 'assertHasPermissionsCheck' should be lowercase
.\tests\bot\cogs\test_snekbox.py:92:56: N803 argument name 'mock_Signal...
ebon magnetBOT
#

Build 20200304.4 succeeded

Requested by

GitHub

Duration

00:01:55

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.5 succeeded

Requested by

GitHub

Duration

00:01:15

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.6 succeeded

Requested by

GitHub

Duration

00:01:27

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.8 failed

Requested by

GitHub

Duration

00:00:29

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.7 succeeded

Requested by

GitHub

Duration

00:01:45

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.9 failed

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.10 failed

Requested by

GitHub

Duration

00:00:53

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.11 failed

Requested by

GitHub

Duration

00:01:02

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.12 failed

Requested by

GitHub

Duration

00:00:38

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.13 failed

Requested by

GitHub

Duration

00:00:41

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.14 failed

Requested by

GitHub

Duration

00:00:37

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.15 failed

Requested by

GitHub

Duration

00:02:07

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.16 failed

Requested by

GitHub

Duration

00:02:10

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.17 succeeded

Requested by

GitHub

Duration

00:02:30

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.18 failed

Requested by

GitHub

Duration

00:00:59

Build pipeline

Bot

regal archBOT
#
ikuyarihS
[python-discord/seasonalbot] New review comment on pull request #361: Added \.games command

Since we only do _get_genres() once, if this fails we have to reload the entire cog everytime, so I suggest turning self.genres into a property instead like so

@property
def gernes(self):
    ...

This way, we can also add another command to refresh genres whenever we want to.

Or, you can create a discord.ext.tasks that loop every x amount that will fetch the genres, and of course, a command to refresh self.genres.

ebon magnetBOT
#

Build 20200304.19 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.20 succeeded

Requested by

GitHub

Duration

00:01:23

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
#
scragly
[python-discord/bot] branch deleted: watchchannel\-dm
north knotBOT
ebon magnetBOT
#

Build 20200304.21 succeeded

Requested by

GitHub

Duration

00:03:23

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New branch created: extensions\-cog\-docstring\-deprecation\-warning
#
SebastiaanZ
[python-discord/bot] Pull request opened: #816 Use raw strings for docstrings with forward slashes

A few docstrings in bot.cogs.extensions use forward slashed to escape Markdown rendering when the docstrings are used in our bot's help feature. However, forward slashes are also interpreted as escape sequences in Python and since these ones are not valid, they will now raise a DeprecationWarning:

/home/sebastiaan/pydis/repositories/bot/bot/cogs/extensions.py:72: DeprecationWarning: invalid escape sequence \*

[PEP 257 -- Docstring Conventions](https://www.python.org/dev/...

ebon magnetBOT
#

Build 20200304.22 succeeded

Requested by

GitHub

Duration

00:01:59

Build pipeline

Bot

#

Build 20200304.23 succeeded

Requested by

GitHub

Duration

00:01:45

Build pipeline

Bot

ebon magnetBOT
#

Build 20200304.1 succeeded

Requested by

GitHub

Duration

00:00:50

Build pipeline

Seasonal Bot

regal archBOT
#
scragly
[python-discord/bot] branch deleted: feat/deps/o138/pre\-commit\-hooks
north knotBOT
ebon magnetBOT
#

Build 20200304.24 succeeded

Requested by

GitHub

Duration

00:03:41

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200304.25 succeeded

Requested by

GitHub

Duration

00:02:06

Build pipeline

Bot

regal archBOT
#
ikuyarihS
[python-discord/bot] branch deleted: extensions\-cog\-docstring\-deprecation\-warning
north knotBOT
ebon magnetBOT
#

Build 20200304.26 succeeded

Requested by

GitHub

Duration

00:03:28

Build pipeline

Bot

oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200304.2 succeeded

Requested by

GitHub

Duration

00:01:27

Build pipeline

Seasonal Bot

regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200304.29 succeeded

Requested by

GitHub

Duration

00:02:40

Build pipeline

Bot

#

Build 20200304.3 succeeded

Requested by

GitHub

Duration

00:00:38

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20200304.4 succeeded

Requested by

GitHub

Duration

00:00:47

Build pipeline

Seasonal Bot

regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200304.5 succeeded

Requested by

GitHub

Duration

00:01:48

Build pipeline

Seasonal Bot

night lilyBOT
#
SeasonalBot Loaded!

Active Season: Evergreen

regal archBOT
ebon magnetBOT
#

Build 20200304.30 succeeded

Requested by

GitHub

Duration

00:02:08

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] branch deleted: antimalware\-logging
north knotBOT
ebon magnetBOT
#

Build 20200304.31 succeeded

Requested by

GitHub

Duration

00:03:56

Build pipeline

Bot

oak estuaryBOT
ebon magnetBOT
#

Build 20200304.32 failed

Requested by

GitHub

Duration

00:01:15

Build pipeline

Bot

#

Build 20200304.33 failed

Requested by

GitHub

Duration

00:01:10

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] New comment on pull request #803: Removed API dependency for Tags

Hey @RohanJnr, recently more pre-commit hooks were added. I'm not sure if you don't have the pre-commit hook installed or if it just failed to update and include the new hooks for you. CI is failing because the new hooks remove trailing whitespaces and ensure final newlines in files. Some of the tag markdown files you added have those issues. If you run pipenv run lint and commit the changes, it should fix all those issues.

regal archBOT
ebon magnetBOT
#

Build 20200304.34 succeeded

Requested by

GitHub

Duration

00:01:54

Build pipeline

Bot

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/seasonalbot] New branch created: feat/deps/355/pep8\-naming
#
MarkKoz
[python-discord/seasonalbot] Pull request opened: #368 Add pep8\-naming and more pre\-commit hooks

Relevant Issues

Resolves #355
python-discord/organisation#138

Description

New hooks were added for pre-commit and they will run in CI too. The pipenv run lint script will now run all the new hooks, including flake8.

Hooks added

A couple of these hooks automatically apply fixes. However, they still report failure and leave any changes they make uncommitted. Therefore, the user has to commit the automatic fixes.

  • check-merge-conflict - Check for files that c...
ebon magnetBOT
#

Build 20200305.1 succeeded

Requested by

GitHub

Duration

00:02:11

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20200305.2 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20200305.3 succeeded

Requested by

GitHub

Duration

00:01:15

Build pipeline

Seasonal Bot

regal archBOT
#
MarkKoz
[python-discord/site] New branch created: feat/deps/o138/pre\-commit\-hooks
#
MarkKoz
[python-discord/site] Pull request opened: #339 Add more pre\-commit hooks

Relevant Issues

python-discord/organisation#138

Description

New hooks were added for pre-commit and they will run in CI too. The pipenv run lint script will now run all the new hooks, including flake8. As a side effect of running in CI, flake8's output will now be shown in stdout in addition to the XML that's published.

Hooks added

A couple of these hooks automatically apply fixes. However, they still report failure and leave any changes they make uncommitted. The...

#
ikuyarihS
[python-discord/seasonalbot] Issue opened: #369 \.games not accurately get genre

Description

Right now when searching for a genre, the genre has to be 100% similar to the genre listed, otherwise it will be regarded as not correct. The code responsible for getting the searched genre and suggesting genres can be seen here:
https://github.com/python-discord/seasonalbot/blob/ce8fb0f8f541ade993d6c93bdcefa33a63287311/bot/seasons/evergreen/game.py#L194-L199

Some example of not being able to find the genre can be seen here:

ebon magnetBOT
#

Build 20200305.1 failed

Requested by

GitHub

Duration

00:02:39

Build pipeline

Site

regal archBOT
#
ikuyarihS
[python-discord/seasonalbot] branch deleted: feat/deps/355/pep8\-naming
ebon magnetBOT
#

Build 20200305.2 succeeded

Requested by

GitHub

Duration

00:02:35

Build pipeline

Site

north knotBOT
ebon magnetBOT
#

Build 20200305.4 succeeded

Requested by

GitHub

Duration

00:02:39

Build pipeline

Seasonal Bot

night lilyBOT
#
SeasonalBot Loaded!

Active Season: Evergreen

regal archBOT
ebon magnetBOT
#

Build 20200305.3 succeeded

Requested by

GitHub

Duration

00:02:04

Build pipeline

Site

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/snekbox] New branch created: feat/deps/63/pep8\-naming
#
MarkKoz
[python-discord/snekbox] Pull request opened: #64 Add pep8\-naming and more pre\-commit hooks

Relevant Issues

Resolves #63
python-discord/organisation#138

Description

New hooks were added for pre-commit and they will run in CI too. The pipenv run lint script will now run all the new hooks, including flake8.

Hooks added

A couple of these hooks automatically apply fixes. However, they still report failure and leave any changes they make uncommitted. Therefore, the user has to commit the automatic fixes.

  • check-merge-conflict - Check for files that con...
ebon magnetBOT
#

Build 20200305.1 failed

Requested by

GitHub

Duration

00:01:35

Build pipeline

Snekbox

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200305.1 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

ebon magnetBOT
#

Build 20200305.2 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

regal archBOT
#
SebastiaanZ
[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

This test currently depends on the working of two separate units of code: the coroutines notify_infraction and send_private_embed. In fact, you currently assert whether or not notify_infraction works by looking at something that send_private_embed produces. That means that we're not testing those units independently from each other and, if the test fails, we don't know which unit caused it to fail.

While it obviously happens that one unit uses another unit in its execution, I think...

#
SebastiaanZ
[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

Since we patch the get method and set its return value manually, there currently is no test for if we're actually supplying the arguments correctly. I think we could add an assert_awaited_once_with here, since
querying the API correctly is quite essential (and we only want to do it once per run of this coroutine). It does require the mock to be reset for each iteration, otherwise the...

#
Akarys42
[python-discord/bot] New review comment on pull request #617: Autodelete offensive messages after one week\.

I am facing a little issue. The OffensiveMessage model of the site database doesn’t allow PATCH requests, and the PR adding it was merged. I think we have two options:

Option 1

Open a new PR to allow PATCH requests and a new deletion attempts field.

Option 2

When the deletion needs to be retried, delete the current object from the database and create a new one. To check if we should still retry later, we could check if the message was posted DELETION_TIME * 2 ago.

...

regal archBOT
#
Akarys42
[python-discord/bot] Issue opened: #818 AutoSync cog to sync development servers

Abstract

Syncing the channels, roles, emojis and webhooks from the production server to a personal development server is quite a tedious task. This cog can be used to do this task for us.

Specification

The cog will be based around snapshots, which will be json serialized objects containing all the guild metadata, such as categories, channels ordering, emojis, channels topic..., along with their production IDs. At each bot restart, a new snapshot will be created and pushed to the s...

regal archBOT
#
Akarys42
[python-discord/bot] New branch created: format\-infraction\-with\-duration\-one\-sec
ebon magnetBOT
#

Build 20200305.3 failed

Requested by

GitHub

Duration

00:01:42

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200305.4 failed

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

regal archBOT
#
Akarys42
[python-discord/bot] branch deleted: format\-infraction\-with\-duration\-one\-sec
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200305.5 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200305.6 succeeded

Requested by

GitHub

Duration

00:01:44

Build pipeline

Bot

regal archBOT
#
scragly
[python-discord/bot] New review comment on pull request #643: implement \!zen command\.

I actually agree with you, and I pondered over it for a while. A particularly nice one is:
image

In the end, it's become obvious that we need to implement a decent difflib based partial matching solution that's used as a utility across the entire project(s), and honestly I don't find it absolutely essential for it to be implemented in this PR to get it merged and dealt with for later e...

#
scragly
[bot:master] 9 new commits

ded89e8 !roles Command: Added pagination (LinePaginator... - ks129
fc2224f !roles Command Test: Applied !roles command cha... - ks129
e5566eb Merge branch 'master' into roles-command-pagina... - sco1
25369cb (Information Cog, !roles command): Added empty ... - ks129
5579f2d (Information Cog, !roles command test): Applied... - ks129

ebon magnetBOT
#

Build 20200305.9 succeeded

Requested by

GitHub

Duration

00:01:53

Build pipeline

Bot

north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200305.8 succeeded

Requested by

GitHub

Duration

00:03:27

Build pipeline

Bot

regal archBOT
oak estuaryBOT
regal archBOT
#
scragly
[python-discord/bot] branch deleted: zen\-command
north knotBOT
ebon magnetBOT
#

Build 20200305.10 succeeded

Requested by

GitHub

Duration

00:03:35

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
MarkKoz
[python-discord/seasonalbot] New branch created: feat/deps/355/pep8\-naming
#
MarkKoz
[python-discord/seasonalbot] Pull request opened: #370 Name the use Python version task

Relevant Issues

#368

Description

The name is needed to be able to retrieve its output variable, pythonLocation. It's used by the pre-commit cache and the pipenv mock steps. I forgot to include it in the original PR.

Did you:

  • [x] Join the Python Discord Community?
  • [ ] If dependencies have been added or updated, run pipenv lock?
  • [x] Lint your code (pipenv run lint)?
  • [x] Set the PR to **allow edits from contribut...
ebon magnetBOT
#

Build 20200305.6 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Seasonal Bot

regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] branch deleted: feat/deps/355/pep8\-naming
north knotBOT
ebon magnetBOT
#

Build 20200305.7 succeeded

Requested by

GitHub

Duration

00:02:24

Build pipeline

Seasonal Bot

night lilyBOT
#
SeasonalBot Loaded!

Active Season: Evergreen

regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: feat/ci/pre\-commit\-tweaks
ebon magnetBOT
#

Build 20200305.11 succeeded

Requested by

GitHub

Duration

00:02:10

Build pipeline

Bot

ebon magnetBOT
#

Build 20200305.12 failed

Requested by

GitHub

Duration

00:03:14

Build pipeline

Bot

#

Build 20200305.13 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

regal archBOT
regal archBOT
#
sco1
[python-discord/seasonalbot] Pull request review submitted: #364 Space Cog implementing

As stated in the issues this PR covers, these should all be implemented as subcommands of a single command, rather than as individual commands.

As also stated in the issues this PR covers, there should be some more customization available for the commands to make queries more interesting.

For example:

  • The NASA Image API supports quite a few search options, including a free text search, keyword search, description search, and year start/end constraints
  • The Earth API endpoint s...
native joltBOT
#
sco1
[python-discord/flake8-annotations] New branch created: azure\-playground
#
sco1
[flake8-annotations] Branch azure\-playground was force-pushed to `3f1a3de`

Compare changes

#
sco1
[python-discord/flake8-annotations] branch deleted: azure\-playground
north knotBOT
#

Postgres backup completed!

regal archBOT
#
eivl
[python-discord/bot] branch deleted: feat/ci/pre\-commit\-tweaks
north knotBOT
ebon magnetBOT
#

Build 20200306.1 succeeded

Requested by

GitHub

Duration

00:03:36

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200306.2 succeeded

Requested by

GitHub

Duration

00:01:35

Build pipeline

Bot

native joltBOT
#
sco1
[python-discord/flake8-annotations] Pull request opened: #73 Release v2\.1\.0

Changelog

[v2.1.0]

Added

  • #68 Add --suppress-dummy-args configuration option to suppress ANN000 level errors for dummy arguments, defined as "_"

Additional Details

This release adds the opinionated --suppress-dummy-args flag, as requested by #68. If this flag is set, TYP000-level errors are suppressed for "dummy" arguments, defined as _.

For example:

def foo(a: int, _) -> None:
    """This is a test function."""
    ...

Would not yield an ...

native joltBOT
native joltBOT
regal archBOT
#
LordHemlock
[python-discord/bot] New branch created: hemlock\-perma\-ban\-watch\-removal
regal archBOT
#
LordHemlock
[python-discord/bot] Pull request opened: #821 Automatically Remove Users from BigBrother Watch List on Perma Ban

Previously we had the bot set up so that when a user was permanently banned. This originally worked just fine, but the issue was that there was no embed being sent telling us about this. However, after the big rewrite, that automated functionality was lost in the process. This PR is intended to restore it.

The discussed solution was to move most of the current unwatch command's functionality into a helper method and allow for a flag to be set when it's sent from a permanent ban. Th...

ebon magnetBOT
#

Build 20200306.3 succeeded

Requested by

GitHub

Duration

00:01:57

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
#
lemonsaurus
[python-discord/bot] New comment on issue #661: \!hush command

@Numerlor

How are you planning to detect that there are active hushed channels on restart? It does sound like a good solution to just setup the mod ping cycle, though, yes.

I don't think we need to take channel as an arg for any of these commands. This command should only be invoked in the channel we are currently in.

I'm not sure what you're asking about regarding keeping remaining durations. are you suggesting some sort of storage for these things? I was hoping to keep this command as si...

regal archBOT
regal archBOT
#
ks129
[python-discord/seasonalbot] Pull request opened: #371 Added Python bot help command to SeasonalBot

Relevant Issues

Closes #295

Description

I copy-pasted file from Python bot + made changes (can be seen in commit history)

Reasoning

Due there is issue what is approved

Screenshots

Check #367 for images

Did you:

  • [x] Join the Python Discord Community?
  • [x] If dependencies have been added or updated, run pipenv lock?
  • [x] Lint your code (pipenv run lint)?
  • [x] Set the PR to **allow edits from cont...
ebon magnetBOT
#

Build 20200307.1 succeeded

Requested by

GitHub

Duration

00:00:47

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20200307.2 succeeded

Requested by

GitHub

Duration

00:01:00

Build pipeline

Seasonal Bot

regal archBOT
#
Numerlor
[python-discord/bot] New comment on issue #661: \!hush command

@Numerlor

How are you planning to detect that there are active hushed channels on restart? It does sound like a good solution to just setup the mod ping cycle, though, yes.

I don't think we need to take channel as an arg for any of these commands. This command should only be invoked in the channel we are currently in.

I'm not sure what you're asking about regarding keeping remaining durations. are you suggesting some sort of storage for these things? I was hoping to kee...

regal archBOT
ebon magnetBOT
#

Build 20200307.3 succeeded

Requested by

GitHub

Duration

00:00:49

Build pipeline

Seasonal Bot

ebon magnetBOT
#

Build 20200307.4 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

regal archBOT
regal archBOT
regal archBOT
#
lemonsaurus
[python-discord/bot] New comment on issue #661: \!hush command

personally I think both listing commands and optional channel selection are probably overkill, but maybe someone else can give their opinion too.

I also am not sure how you plan to differentiate between staff channels and hushed channels, since just developers not having speaking permissions is not a very unusual configuration.

#
Numerlor
[python-discord/bot] New comment on issue #661: \!hush command

Ah right, I kinda mixed up some permission things in my mind. Could be done by checking read permissions (if the public channels are set up in a way that makes it easy or are then removed) but it indeed looks a bit overkill there with the list with the above logic being required behind it

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] Pull request review submitted: #817 Writing tests for moderation utils\.

The docstrings for the tests do not describe the tests.

return correct value
create correct result
work correctly

The act of testing already implies that we're testing for correct behaviour. Writing "correct x" doesn't actually define what "correct" means in that context. If correct means returning True if x and False if y, then try to be more specific and mention that instead. Of course, it doesn't have to be ultra specific (e.g. describing the expected value of eve...

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: bug/mod/792/null\-attachments
#
MarkKoz
[python-discord/bot] Pull request opened: #822 ModLog: fix posting null attachments for deleted message logs

If attachments are not given to upload_log, an empty list is used. By default, zip_longest uses None ass the fill value, so each message was getting paired with a None (AKA null) attachment. The filed in the DB is non-nullable so an empty list must be used instead.

Fixes #792

Note that the clean command still won't send attachments. This PR just fixes the error so at least the clean command can post messages to the API.

ebon magnetBOT
#

Build 20200308.1 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

ebon magnetBOT
#

Build 20200308.1 succeeded

Requested by

GitHub

Duration

00:01:20

Build pipeline

Seasonal Bot

regal archBOT
#
ikuyarihS
[python-discord/bot] New branch created: tag\-search\-searches\-tags\-via\-content\-instead\-of\-names
regal archBOT
ebon magnetBOT
#

Build 20200308.2 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200308.3 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200308.4 succeeded

Requested by

GitHub

Duration

00:02:06

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200308.5 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Bot

regal archBOT
#
lemonsaurus
[python-discord/bot] New review comment on pull request #823: Subcommand \`search\` and \`search any\` to search inside tags' contents and not names\.

This whole block is incredibly dense. I have a number of objections to it and think you should simplify and refactor the entire block.

  • Why are you using type annotations here? It's perfectly obvious that the first line is a tuple from the tuple() call, and that the last line is a list from the fact that it's wrapped in square brackets. Please only use inline type annotations in cases where they add clarity, such as surprising types and cases in which the reader would otherwise have a h...
#
ikuyarihS
[python-discord/bot] New review comment on pull request #823: Subcommand \`search\` and \`search any\` to search inside tags' contents and not names\.

Since I am allowing searching with multiple keywords, separated by comma at the same time, simply counting for ' ' will not work, for example if use search for code,block - there will be no space at all in the keywords

After thinking about this more, it is definitely over kill with my original intention to check if any separated query has any space in it, so the line can be reduced to

is_plural = len(keywords_processed) > 1 or keywords.strip().count(' ')
regal archBOT
ebon magnetBOT
#

Build 20200308.6 succeeded

Requested by

GitHub

Duration

00:01:57

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200308.7 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200308.2 succeeded

Requested by

GitHub

Duration

00:00:58

Build pipeline

Seasonal Bot

regal archBOT
regal archBOT
#
sco1
[python-discord/bot] New branch created: antimalware\-fix
ebon magnetBOT
#

Build 20200308.8 succeeded

Requested by

GitHub

Duration

00:01:35

Build pipeline

Bot

regal archBOT
#
kwzrd
[python-discord/seasonalbot] Issue opened: #372 Upgrade Seasonalbot to Python 3\.8

With bot and snekbox now being bumped to 3.8, we should also look into bumping Seasonalbot.

This is a fairly self-explanatory issue.

As explained in https://github.com/python-discord/bot/issues/758, one of the motivations for upgrading were the improvements to unittesting asynchronous code. We do not have a testing suite for Seasonalbot, which means that we won't benefit from those improvements here, but it also means that we can more or less expect everything to work out-of-the-box...

regal archBOT
#
jos-b
[python-discord/snekbox] New branch created: sentry\-integration
ebon magnetBOT
#

Build 20200308.1 failed

Requested by

GitHub

Duration

00:00:34

Build pipeline

Snekbox

regal archBOT
ebon magnetBOT
#

Build 20200308.2 failed

Requested by

GitHub

Duration

00:00:33

Build pipeline

Snekbox

regal archBOT
regal archBOT
#
kwzrd
[python-discord/seasonalbot] New branch created: python38
ebon magnetBOT
#

Build 20200308.3 succeeded

Requested by

GitHub

Duration

00:01:23

Build pipeline

Seasonal Bot

#

Build 20200308.3 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Snekbox

regal archBOT
#
sco1
[python-discord/bot] New branch created: token\-detection\-fix
#
MarkKoz
[python-discord/snekbox] branch deleted: sentry\-integration
#
sco1
[python-discord/bot] Pull request opened: #825 Refactor token detection to check all potential substrings in message

Occasionally it's been noticed that the bot token filter has been missing seemingly valid tokens without any obvious reason. Upon closer inspection of some recent messages, it appears that the bug has been identified.

The current filter implementation utilizes re.search, which matches only the first location of our token pattern, which is essentially ... However, certain chained method calls can potentially also match this pattern and generally appear before the token in the bot code, ...

north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200308.4 succeeded

Requested by

GitHub

Duration

00:02:19

Build pipeline

Snekbox

regal archBOT
#
MarkKoz
[python-discord/snekbox] Issue opened: #66 Main Docker image creates a venv because pipenv run is used

The venv image doesn't actually create a venv anymore; dependencies are installed into the system's site. However, because the image uses pipenv run snekbox, a virtual environment is still created:

snekbox    | Creating a virtualenv for this project…
snekbox    | Pipfile: /snekbox/Pipfile
snekbox    | Using /usr/local/bin/python (3.8.0) to create virtualenv…
snekbox    | created virtual environment in 303ms CPython3Posix(dest=/root/.local/share/virtualenvs/snekbox--1TroHYA, clear...
ebon magnetBOT
#

Build 20200308.9 succeeded

Requested by

GitHub

Duration

00:01:34

Build pipeline

Bot

regal archBOT
regal archBOT
#
DuckMasterAl
[python-discord/seasonalbot] Issue opened: #374 \.snakes about has the wrong prefix

Description

The text in the .snakes about command has the wrong prefix for the commands you should try. It uses ! as a prefix instead of .

Steps to Reproduce

  1. Do .snakes about
  2. Read the embed and notice the bot's command has a prefix with ! not .

Expected Behaviour

It talks about the bot then says
The bot says

Make sure you check out .snakes sal, .snakes draw and .snakes hatch to see what they came up with.
in the embed

Actual Behaviou...

regal archBOT
ebon magnetBOT
#

Build 20200309.1 succeeded

Requested by

GitHub

Duration

00:01:36

Build pipeline

Bot

regal archBOT
regal archBOT
#
MarkKoz
[bot:master] 7 new commits

2e81f05 Implemented search as a subcommand for tag ... - ikuyarihS
76fccc1 Refactored tag searching via keywords in contents - ikuyarihS
89f86f8 Fixed searching for , returing all tags. Made... - ikuyarihS
dd70718 Refactored dense codes, removed obvious type hint. - ikuyarihS
139a714 Fixed is_plural counting 1 less space. - ikuyarihS

#
MarkKoz
[python-discord/bot] branch deleted: tag\-search\-searches\-tags\-via\-content\-instead\-of\-names
north knotBOT
oak estuaryBOT
ebon magnetBOT
#

Build 20200309.2 succeeded

Requested by

GitHub

Duration

00:03:26

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

ebon magnetBOT
#

Build 20200309.3 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] branch deleted: antimalware\-fix
north knotBOT
ebon magnetBOT
#

Build 20200309.4 succeeded

Requested by

GitHub

Duration

00:03:30

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
scragly
[python-discord/bot] New branch created: vote
#
scragly
[python-discord/bot] Pull request opened: #826 Implement vote command\.

Description

The vote command takes a given list of options and generates a simple message and corresponding reactions for each so members can quickly take a vote on a subject during in-server discussions and meetings.

The title and options require double quotes to be used for multiple-word entries. It would be impossible to distinguish where titles and options start and stop otherwise without adding some custom separator and parsing, which is just unnecessary for such a simple comman...

ebon magnetBOT
#

Build 20200309.5 succeeded

Requested by

GitHub

Duration

00:01:31

Build pipeline

Bot

#

Build 20200309.6 succeeded

Requested by

GitHub

Duration

00:01:55

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] New review comment on pull request #817: Writing tests for moderation utils\.

For the third point, consider that when the loop repeats, post() gets called. It is undesirable for that to be repeated, therefore I phrased it as the loop being exited. But really, think about it as "assert that post() doesn't happen again". Such an assertion can be made by looking at the call_count attribute of the mock.

When a post() is successful, the test should ensure that no error message is sent and no user is posted. If the aforementioned assertions are made, then it effec...

ebon magnetBOT
#

Build 20200309.7 succeeded

Requested by

GitHub

Duration

00:02:06

Build pipeline

Bot

regal archBOT
regal archBOT
#
eivl
[python-discord/bot] branch deleted: vote
north knotBOT
oak estuaryBOT
ebon magnetBOT
#

Build 20200309.8 succeeded

Requested by

GitHub

Duration

00:03:20

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200309.9 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

regal archBOT
#
eivl
[python-discord/bot] branch deleted: token\-detection\-fix
north knotBOT
ebon magnetBOT
#

Build 20200309.10 succeeded

Requested by

GitHub

Duration

00:04:16

Build pipeline

Bot

#

Build 20200309.11 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

regal archBOT
#
eivl
[python-discord/bot] branch deleted: bug/mod/792/null\-attachments
north knotBOT
ebon magnetBOT
#

Build 20200309.12 succeeded

Requested by

GitHub

Duration

00:03:16

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New review comment on pull request #617: Autodelete offensive messages after one week\.

A mix of the two sounds better to me. Make the API support PATCHing the delete_date (this is a very simple change to make with DRF). Make the client (i.e. the bot) compare the message's timestamp (keep in mind this can be calculated directly from the snowflake if needed) to determine if a deletion should be re-scheduled. A field for a deletion attempts just doesn't feel right to me.

regal archBOT
#
sco1
[python-discord/seasonalbot] Pull request review submitted: #371 Added Python bot help command to SeasonalBot

I think you went really overboard on comments when you were moving this cog over from the main bot; there is such a thing as too many comments.

For example, we don't really need comments like these, where the benavior is immediately obvious without the comment:

# show name if query is a cog
if isinstance(self.query, Cog):
    paginator.add_line(f'**{self.query.name}**')

Things like this are also unnecessary:

# Original: def unload(bot: Bot) -> None:
def unloa...
regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New comment on issue #765: Unit test for command alias shadowing

There are two approaches to this:

  1. Discover all cog definitions in all modules and check their commands. This is more complex, but it means no cogs ever get instantiated. Modules do get imported so any code defined at the module level would still be executed (usually minor things like defining constants, importing, reading files, etc.)
  2. Let the bot be created and load all extensions. The check commands via bot.commands. This is very simple and more accurate because commands are not ...
#
MarkKoz
[python-discord/bot] New branch created: feat/test/765/command\-shadowing\-simple
#
MarkKoz
[python-discord/bot] New branch created: feat/test/765/command\-shadowing
regal archBOT
#
Numerlor
[python-discord/bot] New comment on issue #661: \!hush command

After some discussion in #dev-contrib I'll be removing the channel params.

Without adding any persistence to the channels or changing their structure
to be able to discover hushed at runtime, we can do an alert with hushed
channels on cog unload.
Only sure thing without persisting it externally is potential loss of a
permissions state for send messages, for an unhush it can only be either
set to allowed or the inherited without knowing what it was on previously,
if that's a concern.

Do we c...

regal archBOT
ebon magnetBOT
#

Build 20200310.1 failed

Requested by

GitHub

Duration

00:00:00

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.2 failed

Requested by

GitHub

Duration

00:00:46

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.3 failed

Requested by

GitHub

Duration

00:00:37

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.4 failed

Requested by

GitHub

Duration

00:01:21

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.5 failed

Requested by

GitHub

Duration

00:00:57

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.6 failed

Requested by

GitHub

Duration

00:01:27

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.7 succeeded

Requested by

GitHub

Duration

00:02:52

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.8 failed

Requested by

GitHub

Duration

00:01:01

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 6399 failed

Requested by

GitHub

Duration

00:00:00

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.9 failed

Requested by

GitHub

Duration

00:01:02

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.10 succeeded

Requested by

GitHub

Duration

00:02:13

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.11 succeeded

Requested by

GitHub

Duration

00:02:46

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.12 succeeded

Requested by

GitHub

Duration

00:01:22

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.13 failed

Requested by

GitHub

Duration

00:01:28

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200310.14 succeeded

Requested by

GitHub

Duration

00:02:28

Build pipeline

Bot

regal archBOT
#
lemonsaurus
[python-discord/bot] New comment on issue #661: \!hush command

removing channel args sounds good.

Throwing a warning on cog unload for active hushed channels is a bit of an edge case but nice to have. most of the time the docker containers shutdown probably will not be graceful enough to allow that to trigger (I might be wrong about this), and so it will only work for !cog unload, which is rarely used.

beyond that I don't see the need for any of the extras you mention. it doesn't matter that staff channels are hushable - it might actually be nice for t...

regal archBOT
ebon magnetBOT
#

Build 20200310.15 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

regal archBOT
#
lemonsaurus
[python-discord/bot] New comment on issue #639: \`\!whitelist\` command to whitelist stuff from our filters\.

@atmishra The site-side changes seem to be done, but we still need the bot-side changes to be made. Are you still interested in tackling this part? If so, when do you think you'll be able to open a pull request for it?

I don't want to merge the site-side changes until the bot changes are ready, since that might require us to write another migration for site for any changes made to the whitelists in the space between now and then. It would be better to merge both of these at the same time.

regal archBOT
regal archBOT
#
eivl
[python-discord/site] New comment on issue #340: Bleach security alert

After some discussion in dev-core.
The problem lies with django-wiki so we can dismiss the alert or upgrade to 0.6-beta

We cant upgrade to a pre-release without allowing all dependencies to also upgrade to pre-releases. So, for now, we will ignore the alert, it does not affect us as we do not use bleach anymore.

regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200310.16 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

#

Build 20200310.18 succeeded

Requested by

GitHub

Duration

00:01:47

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/site] branch deleted: feat/deps/o138/pre\-commit\-hooks
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200310.1 succeeded

Requested by

GitHub

Duration

00:04:36

Build pipeline

Site

regal archBOT
#
MarkKoz
[python-discord/bot] New review comment on pull request #519: Refactor the \!help command\.
  1. Looks like the remove_reaction belongs inside the except block. If moved inside, return and pass could be removed and thus make the code easier to understand.
  2. Keep in mind remove_reaction may also raise an HTTPException, and that is especially more likely if attempting to delete the message raised an exception.
  3. It shouldn't ignore all HTTPExceptions. It could ignore NotFound, the rest should get logged.
ebon magnetBOT
#

Build 20200310.1 succeeded

Requested by

GitHub

Duration

00:00:53

Build pipeline

Seasonal Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200310.19 failed

Requested by

GitHub

Duration

00:00:59

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200310.20 succeeded

Requested by

GitHub

Duration

00:01:48

Build pipeline

Bot

regal archBOT
#
SebastiaanZ
[python-discord/seasonalbot] New comment on pull request #373: Bump Python version to 3\.8

@SebastiaanZ I requested your review specifically because you handled the migration for bot, so there may still be some things fresh in memory that had to be adjusted, but I'm fairly sure they're more or less irrelevant for Seasonalbot.

I can look at it tomorrow. I don't think there's anything particularly interesting that applies to Seasonal Bot, except maybe the handling of those asyncio exceptions.

regal archBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200311.1 succeeded

Requested by

GitHub

Duration

00:00:59

Build pipeline

Seasonal Bot

regal archBOT
ebon magnetBOT
#

Build 20200311.1 succeeded

Requested by

GitHub

Duration

00:01:09

Build pipeline

Bot

ebon magnetBOT
#

Build 20200311.2 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

regal archBOT
#
sco1
[python-discord/bot] Pull request review submitted: #813 Cache all Python dependencies in CI

I'm in favor of just sending it and seeing how it ends up working out in the long run. It kinda sucks that Azure is so inconsistent on restoring from cache but if it ends up being a net win then why not.

We'll likely have to evaluate any potential issues with partial cache hits as they happen in order to determine whether or not it represents a recurring issue. Just something to be vigilant for in our diagnosis of any potential failures.

regal archBOT
ebon magnetBOT
#

Build 20200311.3 succeeded

Requested by

GitHub

Duration

00:01:44

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200311.4 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200311.5 succeeded

Requested by

GitHub

Duration

00:01:23

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200312.1 succeeded

Requested by

GitHub

Duration

00:01:39

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT