#dev-log

1 messages · Page 40 of 1

ebon magnetBOT
#

Build 20200112.12 succeeded

Requested by

GitHub

Duration

00:02:52

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200112.13 succeeded

Requested by

GitHub

Duration

00:01:39

Build pipeline

Bot

regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200112.14 succeeded

Requested by

GitHub

Duration

00:03:18

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
jchristgit
[python-discord/bot] New branch created: track\-command\-completions
ebon magnetBOT
#

Build 20200112.15 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200112.16 succeeded

Requested by

GitHub

Duration

00:01:36

Build pipeline

Bot

regal archBOT
#
jchristgit
[python-discord/bot] branch deleted: track\-command\-completions
north knotBOT
ebon magnetBOT
#

Build 20200112.17 succeeded

Requested by

GitHub

Duration

00:03:06

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
jchristgit
[python-discord/bot] New branch created: track\-command\-completions\-by\-user
ebon magnetBOT
#

Build 20200112.18 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200112.19 succeeded

Requested by

GitHub

Duration

00:01:44

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
#
SebastiaanZ
[python-discord/bot] Issue opened: #727 The \`\!docs\` command is failing as it's unable to make requests

Currently, the !docs command is completely broken as intersphinx is unable to form a proper request. I haven't looked deeply into the issue yet, but it seems like there's an internal error in how intersphinx forms the request. The user_agent of the config it passes does not seem to exist, while requests expects such an attribute to be there:

Jan 13 08:09:17 Bot: |            bot.cogs.error_handler |    ERROR | Error executing command invoked by Ves Zappa#3787: +docs refr...
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200113.1 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

regal archBOT
#
lemonsaurus
[python-discord/bot] branch deleted: track\-command\-completions\-by\-user
north knotBOT
ebon magnetBOT
#

Build 20200113.3 succeeded

Requested by

GitHub

Duration

00:01:54

Build pipeline

Bot

#

Build 20200113.2 succeeded

Requested by

Leon Sandøy

Duration

00:03:23

Build pipeline

Bot

oak estuaryBOT
regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200113.4 succeeded

Requested by

GitHub

Duration

00:03:34

Build pipeline

Bot

oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200113.1 succeeded

Requested by

GitHub

Duration

00:01:58

Build pipeline

Site

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200113.2 succeeded

Requested by

GitHub

Duration

00:02:34

Build pipeline

Site

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200113.3 succeeded

Requested by

GitHub

Duration

00:02:20

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200113.5 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Bot

regal archBOT
#
bendiller
[python-discord/site] New branch created: reminder\-tests
#
bendiller
[python-discord/site] Pull request opened: #322 Reminder tests

I believe this is ready for review. I'm not very familiar with Django (let alone the REST framework module), nor am I very familiar with testing overall, but I tried to model my efforts after the examples already present for other ViewSets.

I'll be happy to make any changes necessary, thanks for your time!

ebon magnetBOT
#

Build 20200113.4 succeeded

Requested by

GitHub

Duration

00:02:02

Build pipeline

Site

regal archBOT
#
jchristgit
[python-discord/site] branch deleted: bot\#549\-show\-attachments\-staff
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200113.5 succeeded

Requested by

GitHub

Duration

00:05:10

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200114.1 failed

Requested by

GitHub

Duration

00:01:14

Build pipeline

Site

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200114.1 succeeded

Requested by

Joseph Banks

Duration

00:03:35

Build pipeline

Bot

oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200114.2 succeeded

Requested by

GitHub

Duration

00:02:35

Build pipeline

Site

regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200114.2 succeeded

Requested by

GitHub

Duration

00:03:52

Build pipeline

Bot

oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200114.3 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

regal archBOT
oak estuaryBOT
ocean rock
#

that was me, ignore

oak estuaryBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
#
sco1
[python-discord/bot] Issue opened: #729 User command fails for certain custom statuses

Basic support for handling custom user activity (status?) was added by #648 (Parent: #647) after Discord introduced the feature. However, this seems to be broken for the case where a user sets an emoji as their status without any accompanying text:

image

In this scenario, activity.status is None, which causes discord.utils.escape_markdown to raise the above exception, as it's ex...

#
sco1
[python-discord/bot] New branch created: user\-info\-fix
ebon magnetBOT
#

Build 20200116.1 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200116.2 succeeded

Requested by

GitHub

Duration

00:01:42

Build pipeline

Bot

regal archBOT
#
ikuyarihS
[python-discord/bot] branch deleted: feature/645\-voice\-event\-log
north knotBOT
ebon magnetBOT
#

Build 20200116.3 succeeded

Requested by

GitHub

Duration

00:03:30

Build pipeline

Bot

oak estuaryBOT
ebon magnetBOT
#

Build 20200116.4 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

regal archBOT
#
ikuyarihS
[bot:master] 31 new commits

d8a9261 Add FetchedUser to convert ids of absent users ... - manusaurio
051565d Remove pointless comma after last argument - manusaurio
2798e2d Add post_user function to POST a new user to ... - manusaurio
447de16 Make post_infraction try to post_user if user... - manusaurio
e9ed644 Refactor minor details in post_infraction - manusaurio

north knotBOT
oak estuaryBOT
ebon magnetBOT
#

Build 20200116.5 succeeded

Requested by

GitHub

Duration

00:03:17

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200116.6 succeeded

Requested by

GitHub

Duration

00:01:24

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] branch deleted: user\-info\-fix
north knotBOT
ebon magnetBOT
#

Build 20200116.7 succeeded

Requested by

GitHub

Duration

00:02:53

Build pipeline

Bot

oak estuaryBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

native joltBOT
#
sco1
[python-discord/flake8-annotations] New branch created: poetry\-adventures
north knotBOT
#

Postgres backup completed!

native joltBOT
native joltBOT
#
sco1
[python-discord/flake8-annotations] New comment on issue #59: Flake8 optparse conflict when invoking as a module

Per the upstream issue, this seems to be an issue with entrypoints, as the issue disappears when flake8 is installed from the master branch rather than from PyPI. flake8 is switching from entrypoints to importlib_metadata.

Short term, this should be a simple resolution of adjusting the Azure pipeline config to utilize flake8 vs. python3 -m flake8. I'd rather go with this approach than pinning flake8 away from PyPI.

native joltBOT
native joltBOT
north knotBOT
#

Postgres backup completed!

native joltBOT
#
sco1
[python-discord/flake8-annotations] Pull request opened: #60 Release v1\.2\.0

Changelog:

[v1.2.0]

Added

  • Add test case for checking whether flake8 invokes our plugin
  • #41 Add --suppress-none-returning configuration option to suppress TYP200 level errors for functions that either lack a return statement or only explicitly return None.

Additional Details:

This release adds the --suppress-none-returning configuration option, as requested by #41. If this flag is set, TYP200-level errors are suppressed for functions that meet one of the foll...

native joltBOT
native joltBOT
native joltBOT
native joltBOT
native joltBOT
#
sco1
[python-discord/flake8-annotations] Issue opened: #61 Migrate from Pipenv to Poetry

I'd like to propose for discussion migrating the management of the developer environment from Pipenv to Poetry.

I will state up front that there is no major advantage to making this switch, but rather a collection of minor differences that contribute to what I believe is an overall improvement for the developer. In the fairly recent past PyDis looked into migrating all of the repositories to Poetry, as at the time ...

native joltBOT
north knotBOT
#

Postgres backup completed!

native joltBOT
#
dependabot-preview[bot]
[python-discord/flake8-annotations] Pull request opened: #62 Bump typed\-ast from 1\.4\.0 to 1\.4\.1

Bumps typed-ast from 1.4.0 to 1.4.1.

Commits

a834bc1 Release version 1.4.1
c6bf09c Fix build on cpython (3.9) master branch (#128)
6b109b6 Build artifacts for 3.8 (#127)
d0908cf Clean up old build scripts (#123)
63adaee Bump version to 1.4.1.dev0
See full diff in compare view

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=typed-ast&package-manager=pip&previous-version=1.4.0&new-version=1.4....

regal archBOT
north knotBOT
#

Postgres backup completed!

native joltBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

north knotBOT
#

Postgres backup completed!

regal archBOT
#
sco1
[python-discord/bot] Issue opened: #731 Superstarify Not Appropriately Capturing Reason String

The superstarify command function definition isn't correctly capturing the (optional) reason string, causing the command set the first word as the reason, if specified, or raising an error if the first word contains an apostrophe:

https://github.com/python-discord/bot/blob/33dd712d3fe046c196ac0d31e0bfaf121f469ed5/bot/cogs/moderation/superstarify.py#L106-L113

Changing to:

    @command(name="superstarify", aliases=("force_nick", "star"))
    async def superstarify(
        sel...
regal archBOT
#
jos-b
[python-discord/snekbox] New branch created: increase\-process\-time\-limit
#
jos-b
[python-discord/snekbox] branch deleted: increase\-process\-time\-limit
ebon magnetBOT
#

Build 20200124.1 succeeded

Requested by

GitHub

Duration

00:05:39

Build pipeline

Snekbox

north knotBOT
#

Postgres backup completed!

north knotBOT
#

Postgres backup completed!

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
#
kwzrd
[python-discord/bot] Pull request opened: #733 Add test cases for antispam rules, fix bug in attachments rule & test

This PR introduces a series of unit test cases for the bot's antispam rules. This addresses the following issues.

Closes #595 via 1f17d0e.
Closes #596 via b0713be.
Closes #597 via f15f318.
Closes #598 via 4bfe30d.
Closes #603 via f32ffaf.

I also sneak in a quick bugfix in 4199b12: it appears that the already existing rule for attachments contains a slight bug where in the printout, the configured 'max' key is looked up instead of 'interval'. The same commit also fixes the key in...

ebon magnetBOT
#

Build 20200126.1 succeeded

Requested by

GitHub

Duration

00:02:04

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

native joltBOT
#
dependabot-preview[bot]
[python-discord/flake8-annotations] New branch created: dependabot/pip/pipenv\-setup\-3\.0\.1
#
dependabot-preview[bot]
[python-discord/flake8-annotations] Pull request opened: #63 Bump pipenv\-setup from 2\.2\.4 to 3\.0\.1

Bumps pipenv-setup from 2.2.4 to 3.0.1.

Release notes
Sourced from pipenv-setup's releases.

Minor Bug Fix
Colorama dependency corrected from ~=0.4.3 to ~=0.4
Python 3.4 support dropped
Python 3.4 has reached end of life in 2019. Support for python 3.4 is dropped now as some of our dependencies has dropped support for it.
Minor Bug Fix
allow sync to work in the absence of lockfile if --pipfile flag is supplied

Commits

f2b9a98 Update setup....

regal archBOT
regal archBOT
regal archBOT
native joltBOT
regal archBOT
#
sco1
[python-discord/site] Issue opened: #323 Truncate Verbose Infraction Reason Strings

Currently, the bot paginator raises a RuntimeError if the string it's attempting to paginate exceeds the defined page size:

def add_line(self, line: str = '', *, empty: bool = False) -> None:
    """
    Adds a line to the current page.
    If the line exceeds the `self.max_size` then an exception is raised.
    This function overrides the `Paginator.add_line` from inside `discord.ext.commands`.
    It overrides in order to allow us to configure the maximum number of lines ...
north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200128.1 succeeded

Requested by

GitHub

Duration

00:02:03

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200129.1 succeeded

Requested by

GitHub

Duration

00:01:27

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
#
MarkKoz
[python-discord/bot] Issue opened: #734 Update discord\.py to 1\.3\.x

Let's discuss:

  • Is now a good time or is there a reason to hold off?
  • What changes would our code base require to facilitate the update?
  • What new features could we make use of to improve our code base?
    • IIRC, fetch_members and/or fetch_roles could have use somewhere. Perhaps it was in the watch channel cog.
    • We have a patch for some bug. Is it fixed in 1.3?
    • utils.sleep_until...
regal archBOT
ebon magnetBOT
#

Build 20200130.1 succeeded

Requested by

GitHub

Duration

00:01:39

Build pipeline

Bot

native joltBOT
#
KyleKing
[python-discord/flake8-annotations] Issue opened: #64 flake8\-annotations and flake8\-typing\-imports Compatibility

Hi, I ran into the below error when installing both flake8-annotations and flake8-typing-imports

optparse.OptionConflictError: option --min-python-version: conflicting option string(s): --min-python-version

Both packages use the same options flag for minimum python version and same error codes.
I opened an issue on flake8-typing-imports (link) and the package author redirected me to submit an issue here: https://github.com/a...

native joltBOT
#
sco1
[python-discord/flake8-annotations] New comment on issue #64: flake8\-annotations and flake8\-typing\-imports Compatibility

The duplicate options flag is a flake8 bug that has already been reported (and fixed) upstream, but not included in a new release. See: #59 and https://gitlab.com/pycqa/flake8/issues/610 for more information. Our current release (1.1.3) registers no custom options.

We will look into changing the error prefix to mitigate the conflict with flake8-typing-imports. ANN seems like a reasonable option.

regal archBOT
#
Akarys42
[python-discord/bot] New branch created: test\-resources
ebon magnetBOT
#

Build 20200130.2 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200130.3 succeeded

Requested by

GitHub

Duration

00:01:30

Build pipeline

Bot

regal archBOT
#
lemonsaurus
[python-discord/bot] branch deleted: test\-resources
north knotBOT
ebon magnetBOT
#

Build 20200130.4 succeeded

Requested by

Leon Sandøy

Duration

00:03:27

Build pipeline

Bot

oak estuaryBOT
native joltBOT
#
sco1
[python-discord/flake8-annotations] branch deleted: poetry\-adventures
native joltBOT
#
sco1
[python-discord/flake8-annotations] Pull request opened: #65 Release v2\.0\.0

Changelog

[v2.0.0]

Changed

  • #64 Change prefix from TYP to ANN in order to deconflict with flake8-typing-imports

Additional Details

Per #64, due to prefix shadowing of TYP between flake8-annotations and flake8-typing-imports, it's been suggested that the prefix for this repository be changed to ANN so the plugins can coexist peacefully.

As this is a breaking change to existing linting configurations, it will be released as version 2.x

Closes #64

north knotBOT
#

Postgres backup completed!

native joltBOT
regal archBOT
ebon magnetBOT
#

Build 20200131.1 succeeded

Requested by

GitHub

Duration

00:01:37

Build pipeline

Bot

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New comment on pull request #733: Add test cases for antispam rules, fix bug in attachments rule & test

Two helper functions: one for "allows" tests and one for "disallows". They should be passed the apply function and the subtest arguments. The helpers will do the loop, calling of apply, and the assertions.

As I mentioned, some of the subtest arguments follow a similar pattern across test suites. To facilitate this, a function could be defined which will take a make_msg function and return subtest arguments. This function can shared among some test suites to generate subtest arguments...

north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200202.1 succeeded

Requested by

GitHub

Duration

00:01:36

Build pipeline

Bot

regal archBOT
#
bendiller
[python-discord/site] New review comment on pull request #322: Reminder tests

I thought that was odd too. I used a couple existing files created by respected contributors as models for mine, and this "assert within setUp()" appeared in a couple places. Would it be appropriate to move this into the test_reminder_in_full_list test? Or is it better to test creation using a post against the list endpoint in one test, and use another test to check that a get for the list endpoint returns expected reminder instances?

#
MarkKoz
[python-discord/site] New review comment on pull request #322: Reminder tests

I think a single test for anything invalid is adequate to ensure the API reacts appropriately to erroneous data.

Here's my perspective on why:

Testing each field may be more applicable to model tests (which we don't do anywhere I believe, but maybe we should...), but these are API/viewset tests. The viewset is using standard mixins/base classes from DRF without any overrides. Those mixins are tested by DRF themselves. If the viewset used custom mixins and/or custom method handlers, th...

regal archBOT
regal archBOT
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200202.1 succeeded

Requested by

Joseph Banks

Duration

00:03:53

Build pipeline

Site

regal archBOT
#
tagptroll1
[python-discord/bot] New branch created: tagptroll1\-md\-filefilter
north knotBOT
ebon magnetBOT
#

Build 20200202.2 succeeded

Requested by

Joseph Banks

Duration

00:03:35

Build pipeline

Bot

#

Build 20200202.3 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
bendiller
[python-discord/site] New comment on pull request #322: Reminder tests

Needs a test case for the list endpoint to test retrieval of existing objects and also test searching and filtering.

I think I've got most of these issues sorted, but I'm not certain I've done what you asked regarding searching and filtering. I adapted what looked like the requested behavior from test_infractions.test_filter_search(). If what I've done is correct, can you help me understand when this searching is actually used in practice? Is this the mechanism by which the bot lists t...

ebon magnetBOT
#

Build 20200202.2 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Site

regal archBOT
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200202.1 succeeded

Requested by

Joseph Banks

Duration

00:06:22

Build pipeline

Snekbox

regal archBOT
#
kwzrd
[python-discord/bot] branch deleted: tagptroll1\-md\-filefilter
north knotBOT
ebon magnetBOT
#

Build 20200202.4 succeeded

Requested by

GitHub

Duration

00:03:22

Build pipeline

Bot

oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200202.3 succeeded

Requested by

GitHub

Duration

00:01:59

Build pipeline

Site

regal archBOT
#
jos-b
[python-discord/bot] New branch created: remove\-prometheus
ebon magnetBOT
#

Build 20200202.5 succeeded

Requested by

GitHub

Duration

00:01:58

Build pipeline

Bot

regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200202.6 succeeded

Requested by

Joseph Banks

Duration

00:03:23

Build pipeline

Bot

oak estuaryBOT
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200202.4 succeeded

Requested by

Joseph Banks

Duration

00:03:14

Build pipeline

Site

north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200202.2 succeeded

Requested by

Joseph Banks

Duration

00:04:13

Build pipeline

Snekbox

#

Build 20200202.7 succeeded

Requested by

GitHub

Duration

00:01:35

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/site] Pull request review submitted: #322 Reminder tests

If what I've done is correct, can you help me understand when this searching is actually used in practice? Is this the mechanism by which the bot lists the reminders for a particular user, when commanded?

I don't know - I didn't make the viewset. I would have expected search_fields to be specified so it only searches on a subset of the fields. It doesn't seem to have practical use to me in this case considering the viewset also supports filtering by fields. At least for infractions it...

regal archBOT
ebon magnetBOT
#

Build 20200202.8 succeeded

Requested by

GitHub

Duration

00:01:44

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200202.9 succeeded

Requested by

GitHub

Duration

00:01:22

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200202.10 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
#
SebastiaanZ
[python-discord/site] Issue opened: #324 Storing deleted messages fails because of "not null" constraint

Currently, some of our moderation tools fail because our database rejects messages without a value for the attachment field. The issue is caused by the fact that null=True is not set for this field, while we do not always provide a value:

https://github.com/python-discord/site/blob/824566b157710c0bb64e4bf97124708729d2377a/pydis_site/apps/api/models/bot/message.py#L54-L60

(Note that blank=True means that the field won't be required in form validation, but it does not mean the field c...

regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200203.1 failed

Requested by

GitHub

Duration

00:01:09

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200203.2 succeeded

Requested by

GitHub

Duration

00:01:50

Build pipeline

Bot

regal archBOT
#
scragly
[python-discord/site] New branch created: unbleach\-wiki
ebon magnetBOT
#

Build 20200203.1 succeeded

Requested by

GitHub

Duration

00:02:04

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200203.3 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

regal archBOT
#
scragly
[python-discord/bot] branch deleted: \#549\-show\-attachments\-staff
north knotBOT
ebon magnetBOT
#

Build 20200203.4 succeeded

Requested by

GitHub

Duration

00:03:07

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
lemonsaurus
[python-discord/site] branch deleted: unbleach\-wiki
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200203.2 succeeded

Requested by

Leon Sandøy

Duration

00:03:33

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200203.3 succeeded

Requested by

GitHub

Duration

00:01:47

Build pipeline

Site

regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/site] New review comment on pull request #322: Reminder tests

I think this test is a bit fragile. Formally, the model has no default ordering defined, which makes the order in which the objects are returned "unspecified":

If a query doesn’t have an ordering specified, results are returned from the database in an unspecified order. A particular ordering is guaranteed only when ordering by a set of fields that uniquely identify each object in the results. For example, if a name field isn’t unique, ordering by it won’t guarantee objects with the sam...

ebon magnetBOT
#

Build 20200203.4 succeeded

Requested by

GitHub

Duration

00:01:58

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200203.5 succeeded

Requested by

GitHub

Duration

00:02:33

Build pipeline

Site

regal archBOT
#
MarkKoz
[python-discord/site] branch deleted: reminder\-tests
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200203.6 succeeded

Requested by

GitHub

Duration

00:03:37

Build pipeline

Site

regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200204.1 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200204.2 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

regal archBOT
#
kwzrd
[python-discord/bot] New comment on pull request #733: Add test cases for antispam rules, fix bug in attachments rule & test

I've added tests for duplicates (54e8c98) and newlines (cae7f25).

As the latter is more complex than the other rules, yielding two distinct error reports, I decided to implement two subclasses of the RuleTest ABC for it. Each checks one type of violation.

If the given messages violate both total count and max consecutive, the rule will fail on the total as that is checked first. Since I consider this an implementation detail and not "desired functionality", I do not te...

ebon magnetBOT
#

Build 20200204.3 succeeded

Requested by

GitHub

Duration

00:01:20

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] New comment on pull request #542: Make it easier for user to search for tags

In some cases that still isn't working so well:

  • asks returns args-kwargs instead of ask
  • foos returns off-topic and functions-are-objects instead of foo
  • dict returns iterate-dict without considering dictcomps too

Also discovered an unrelated issue in which it can't handle DELETE or GET requests for tags with spaces in them (returns 404). Might be a URL encoding issue since the tag is part of the URL path. It can POST fine because the tag name is instead part o...

#
SebastiaanZ
[python-discord/bot] Issue opened: #738 Delete Message API change breaks bot features

Recently, the deleted messages API received an update that introduced a new required field (attachments). Unfortunately, not every bot feature using this endpoint has been updated yet, causing the API to reject the requests.

One such feature that currently fails is bulk deletion by the Clean cog. Another one is part of [the on_message_delete event listener in the modlog Cog](https://github.com/python-discord/bot/blob...

regal archBOT
#
ikuyarihS
[python-discord/bot] New comment on pull request #542: Make it easier for user to search for tags

Hmm, I've added another complexity that will force this to search from words to words, here's the snippets I used to test

from typing import Dict, List, Optional

stuff = ['args-kwargs', 'ask', 'class', 'classmethod', 'codeblock', 'decorators', 'dictcomps', 'enumerate', 'except', 'exit()', 'f-strings', 'foo', 'functions-are-objects', 'global', 'if-name-main', 'indent', 'inline', 'iterate-dict', 'listcomps', 'mutable-default-args', 'names', 'no-dm',
         'off-topic', 'open', '...
ebon magnetBOT
#

Build 20200205.1 succeeded

Requested by

GitHub

Duration

00:01:52

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200205.2 succeeded

Requested by

GitHub

Duration

00:01:38

Build pipeline

Bot

regal archBOT
regal archBOT
#
scragly
[python-discord/bot] New branch created: resources\-move
ebon magnetBOT
#

Build 20200205.3 succeeded

Requested by

GitHub

Duration

00:01:49

Build pipeline

Bot

regal archBOT
#
scragly
[python-discord/site] New branch created: resources\-update
ebon magnetBOT
#

Build 20200205.1 succeeded

Requested by

GitHub

Duration

00:01:58

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200205.4 succeeded

Requested by

GitHub

Duration

00:02:05

Build pipeline

Bot

regal archBOT
#
lemonsaurus
[python-discord/bot] branch deleted: resources\-move
ebon magnetBOT
#

Build 20200205.5 succeeded

Requested by

Leon Sandøy

Duration

00:03:48

Build pipeline

Bot

north knotBOT
oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200205.6 succeeded

Requested by

GitHub

Duration

00:01:57

Build pipeline

Bot

regal archBOT
#
sco1
[python-discord/bot] New comment on issue #734: Update discord\.py to 1\.3\.x

As a general thought, we should strive to keep a relatively close cadence with the library when feasible. The expansion of our test suite & apparent slowing of major breaking changes in the library should help make the process much more straightforward than it has been in the past.

It's probably beneficial to keep updating separate from refactoring outside of scenarios where the two are linked. While we should absolutely be identifying & planning out refactor targets based on update librar...

#
Denayder
[python-discord/bot] Pull request opened: #740 Update information\.py so it's a bit cleaner

Hello! I was looking a bit around, and I stumbled over the information.py cog. I found a couple of things that I thought could be improved a slight bit, and went ahead and gave it a shot. If there are any further changes you would like me to make for this PR, please let me know and I will go ahead and do so :grin:

Here’s a list of changes that I made:

  • Improved imports a slight bit
  • Instead of checking if every role name is @everyone or not, I simply use ctx.guild.roles[1:] inste...
regal archBOT
#
MarkKoz
[python-discord/bot] branch deleted: remove\-prometheus
north knotBOT
ebon magnetBOT
#

Build 20200205.7 succeeded

Requested by

GitHub

Duration

00:02:59

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
sco1
[python-discord/bot] New comment on pull request #740: Update information\.py so it's a bit cleaner

Hello, thanks for the contribution!

A couple general requests before we open this up to a broader review:

  • Please ensure that your fork is kept up to date with the latest changes to the upstream repository. This will help avoid merge conflicts (like we have here currently) and ensure that you have the most up-to-date functionality. GitHub has some guides to assist with this if you're not fam...
regal archBOT
ebon magnetBOT
#

Build 20200205.2 succeeded

Requested by

GitHub

Duration

00:03:00

Build pipeline

Snekbox

regal archBOT
#
MarkKoz
[python-discord/snekbox] branch deleted: proper\-chroot
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200205.3 succeeded

Requested by

GitHub

Duration

00:04:51

Build pipeline

Snekbox

#

Build 20200205.8 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Bot

#

Build 20200205.9 succeeded

Requested by

GitHub

Duration

00:01:47

Build pipeline

Bot

#

Build 20200205.12 failed

Requested by

GitHub

Duration

00:00:54

Build pipeline

Bot

regal archBOT
#
Denayder
[python-discord/bot] New comment on pull request #740: Update information\.py so it's a bit cleaner

Hi - Thank you for the feedback, and apologies for the issues and commit-spam. I do admit I'm not the most experienced with git, so I apologize for the forking mistake and commit spam that has happened. Would you like this PR to be re-created so the commit history is not as messy?

As to your code requests:

  • The import changes make a lot of modifications to the file with seemingly little gain. Without a better justification for the changes it would be better if they were left as-is.
    Is...
ebon magnetBOT
#

Build 20200205.13 failed

Requested by

GitHub

Duration

00:01:10

Build pipeline

Bot

regal archBOT
regal archBOT
#
scragly
[python-discord/site] branch deleted: resources\-update
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200206.1 succeeded

Requested by

GitHub

Duration

00:03:41

Build pipeline

Site

north knotBOT
#

Postgres backup completed!

regal archBOT
#
sco1
[python-discord/bot] New comment on pull request #740: Update information\.py so it's a bit cleaner

No worries, it's all a learning experience. If you wouldn't mind, let's start from scratch & on a new branch so your master is clean and in sync with our repo and we don't have all the unnecessary commits. Then we can dive into everything else.

Regarding the failing test, it's an issue with how we're mocking a member list for the test:

https://github.com/python-discord/bot/blob/ca0ee4a4a41789e9c1349f2768352cb09f610746/tests/bot/cogs/test_information.py#L127-L131

With the old logic ...

regal archBOT
regal archBOT
regal archBOT
#
Denayder
[python-discord/bot] Pull request opened: #741 Refactor information\.py with lots of changes that makes the overall code cleaner and faster

Hello. I created #740 yesterday, but with lack of knowledge of forking and proper commit messages, the commit history became a slight bit messy. I'm here again with pretty much the same PR, with a few changes here and there. Thanks to @sco1 for the helpful advice so far.

A change log can be found here and in the commit messages:

  • No longer check if every role is @everyone or not. Simply skipping the first element in the .roles will skip the @everyone role.
  • Channel and statu...
ebon magnetBOT
#

Build 20200206.1 failed

Requested by

GitHub

Duration

00:01:00

Build pipeline

Bot

#

Build 20200206.2 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200207.1 succeeded

Requested by

GitHub

Duration

00:01:42

Build pipeline

Bot

regal archBOT
#
ikuyarihS
[bot:master] 10 new commits

8c2871f Make it easier for user to search for tags - ikuyarihS
b71acff Merge branch 'master' into fuzzy-tag-search - jos-b
7f0e673 Fixed _last_fetch not being updated after each ... - ikuyarihS
868de47 Refactored get_suggestions following Mark's su... - ikuyarihS
a38926f Removed non-alphabets from both search and tag... - ikuyarihS

#
ikuyarihS
[python-discord/bot] branch deleted: fuzzy\-tag\-search
north knotBOT
ebon magnetBOT
#

Build 20200207.2 succeeded

Requested by

GitHub

Duration

00:03:18

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
ikuyarihS
[python-discord/bot] Issue opened: #742 Suggest a list of available commands in case of typos

When we try to invoke a command, we can make little typos, for example
!muet @shirayuki 72H oh come on, cant you make a proper issue?

In this case, the bot can then steps in and do a friendly suggestions:
did you perhaps mean
!mute @shirayuki 72H oh come on, cant you make a proper issue?

The typo in this example was !muet when trying to do !mute

This will greatly relieve the stress of typing every command rights, and thus enhancing the experience with the bot much further.

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200207.3 failed

Requested by

GitHub

Duration

00:01:17

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: dep/b734/discord\.py\-1\.3
ebon magnetBOT
#

Build 20200207.4 failed

Requested by

GitHub

Duration

00:00:29

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200207.5 succeeded

Requested by

GitHub

Duration

00:01:22

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] branch deleted: dep/b734/discord\.py\-1\.3
north knotBOT
ebon magnetBOT
#

Build 20200207.6 succeeded

Requested by

GitHub

Duration

00:03:49

Build pipeline

Bot

oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200207.7 failed

Requested by

GitHub

Duration

00:01:21

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200208.1 succeeded

Requested by

GitHub

Duration

00:01:12

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200208.1 failed

Requested by

GitHub

Duration

00:01:28

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200208.2 succeeded

Requested by

GitHub

Duration

00:02:02

Build pipeline

Site

regal archBOT
#
MarkKoz
[site:master] 14 new commits

4b25725 Infractions: fix UniqueTogetherValidator incorr... - MarkKoz
6b99214 Add regression test for the UniqueTogetherValid... - MarkKoz
a0ea44f Add fixtures to create infractions in serialize... - MarkKoz
8d49389 Test that new infractions pass validation - MarkKoz
309acd3 Output errors more clearly for infraction seria... - MarkKoz

#
MarkKoz
[python-discord/site] branch deleted: fix\-infraction\-validator
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200208.3 succeeded

Requested by

GitHub

Duration

00:03:30

Build pipeline

Site

regal archBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200209.1 succeeded

Requested by

GitHub

Duration

00:01:30

Build pipeline

Bot

regal archBOT
regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New review comment on pull request #741: Refactor information\.py with lots of changes that makes the overall code cleaner and faster

With the ChannelType suggestions, this description would not be accounting for all types (most significant is the news type currently) or any future types that Discord may introduce. I could live with that, but if you're up for it, you could make this part of the description be dynamically generated from whatever types are inside the channels dictionary.

ebon magnetBOT
#

Build 20200209.2 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

regal archBOT
#
MarkKoz
[bot:master] 10 new commits

4e87b4e Use trashcan emoji for message deletion - kosayoda
30ba84e Differentiate clear and delete emoji in help cog - kosayoda
56696b3 Remove dev-test limit for filtering debugging - kosayoda
af0e532 Revert "Remove dev-test limit for filtering deb... - kosayoda
a221024 Add delete emoji to pagination - kosayoda

#
MarkKoz
[python-discord/bot] branch deleted: emoji\-cleanup
north knotBOT
ebon magnetBOT
#

Build 20200209.3 succeeded

Requested by

GitHub

Duration

00:03:31

Build pipeline

Bot

regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New comment on issue #673: Duck Pond improvements

I've added an action point to implement a lock for the message relay.

The reason is that, on occasion, the same message gets relayed more than once due to a race condition: If, for some reason, multiple reaction events fire when we go over the ducking threshold and all of them make it past the "green checkmark check" before a relay is successful, all of them will relay the message as none of them are "aware" that the message is already going to be relayed by one of the other near-simultane...

north knotBOT
#

Postgres backup completed!

ebon magnetBOT
#

Build 20200210.1 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

regal archBOT
regal archBOT
regal archBOT
regal archBOT
native joltBOT
native joltBOT
#
sco1
[python-discord/flake8-annotations] New tag created: v1\.2\.0
native joltBOT
native joltBOT
regal archBOT
ebon magnetBOT
#

Build 20200211.1 succeeded

Requested by

GitHub

Duration

00:01:59

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

native joltBOT
regal archBOT
native joltBOT
#
GhostofGoes
[python-discord/flake8-annotations] New branch created: fix\-tests\-windows
regal archBOT
native joltBOT
#
GhostofGoes
[python-discord/flake8-annotations] Pull request opened: #66 Fix Tox test execution on Windows

Running the tests is not currently possible on Windows, and will fail with ERROR: InvocationError for command could not find executable python3. This is because Tox executes pytest using python3, which isn't a valid python command on Windows. Since the Tox runs the tests in a virtual environment, plain python can be safely used.

Tested against Python 3.6 and 3.6 on Windows (PowerShell) and 3.7 in Ubuntu (WSL).

native joltBOT
#
sco1
[python-discord/flake8-annotations] branch deleted: fix\-tests\-windows
#
sco1
[python-discord/flake8-annotations] branch deleted: TYP\-to\-ANN
#
sco1
[python-discord/flake8-annotations] New branch created: dev\-next
#
sco1
[python-discord/flake8-annotations] New tag created: v2\.0\.0
regal archBOT
#
Denayder
[python-discord/bot] New review comment on pull request #741: Refactor information\.py with lots of changes that makes the overall code cleaner and faster

Call me dumb, but I'm not sure if I exactly understand what you mean here. I assume you basically mean something like this?

        channel_counts = ""
        for ch in channels:
            channel_counts += f"{str(ch).title()} channels: {channels[ch]} \n"

If so, that for-loop can be simplified using this. Would this be preferred instead?

        channel_counts = "".join(f"{str(ch).title()} channels: {channels[ch]} \n" for ch in channels)

All of the changes ha...

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
regal archBOT
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200212.1 succeeded

Requested by

GitHub

Duration

00:03:29

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200212.1 succeeded

Requested by

GitHub

Duration

00:01:45

Build pipeline

Bot

regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200212.2 succeeded

Requested by

GitHub

Duration

00:03:03

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200212.3 succeeded

Requested by

GitHub

Duration

00:01:41

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200212.4 succeeded

Requested by

GitHub

Duration

00:01:36

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] Issue opened: #748 aiohttp\.AsyncResolver needs to be created inside an async function

Despite the efforts in #681, I failed to realise aiohttp.AsyncResolver suffers from the same DeprecationWarning as the session.

Thankfully, it seems that the resolver of a aiohttp.TCPConnector instance can be swapped out whenever. It just uses whatever the value of self._resolver is every time it needs to resolve a host. It is a "private" attribute but ostensibly there isn't any reason it shouldn't be changed.

So, the resolver can simply be created in Bot.start(). I believe ...

ebon magnetBOT
#

Build 20200212.5 succeeded

Requested by

GitHub

Duration

00:01:24

Build pipeline

Bot

regal archBOT
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
sco1
[python-discord/bot] New branch created: reminder\-enhancements
#
sco1
[python-discord/bot] Pull request opened: #749 Reminder Embed Enhancements & Whitelist Expansion

Per #663, this PR imlements the first subset of enhancements to the reminders feature.

  • Expand channel whitelist for non-staff to include #dev-contrib
  • Add reminder ID to confirmation message footer so users don't have to use !remind list to figure out what reminder they need to reference for changes.
  • Add targeted due date to confirmation message footer for sanity checking. While the initial reminder creation confirmation currently has a humanized delta, the duration edit does no...
ebon magnetBOT
#

Build 20200212.6 succeeded

Requested by

GitHub

Duration

00:01:43

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
#
lemonsaurus
[python-discord/branding] Issue opened: #44 More lemojis\!

@manusaurio expressed an interest in working on a set of lemojis. As we're removing a few generic emojis that express certain things, it would be good to start with lemojis that express these same emotions, so that we can still communicate in effectively the same way as we currently do.

Emotions we should express

  • [ ] Sadness
  • [ ] Laughing with XD face.
  • [ ] Thinking
  • [ ] Fingerguns
  • [ ] Fingerguns with sunglasses
  • [ ] Grumpy
  • [ ] Crying blood while grinning
  • [ ] Inspect...
ebon magnetBOT
#

Build 20200213.1 failed

Requested by

GitHub

Duration

00:01:22

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] New comment on issue #748: aiohttp\.AsyncResolver needs to be created inside an async function

Turns out clear() is not an async function so re-creating the connector there is not exactly an option. May need to be accomplished somehow in start() instead.

Another issue I discovered is that the APIClient.loop attribute is not really tied to Bot.loop so they could end up being different if someone wanted to change the loop and didn't bother to change APIClient.loop too. It's important they're the same so that the session creation task is scheduled on the correct loop. However...

regal archBOT
#
MarkKoz
[python-discord/bot] New comment on issue #748: aiohttp\.AsyncResolver needs to be created inside an async function

Client.clear() does HTTPClient.recreate() to recreate the aiohttp session. However, that function is not a coroutine. I would expect it to cause a DeprecationWarning yet it doesn't (is it being suppressed somewhere?). Furthermore, when starting the bot normally, Client.login() is called. That calls HTTPClient.static_login, which also creates a session. Unlike HTTPClient.recreate(), it is a coroutine and is discord.py's own way of working around the DeprecationWarning.

It's...

#
MarkKoz
[python-discord/bot] New comment on issue #748: aiohttp\.AsyncResolver needs to be created inside an async function

My conclusion is that it's fine to re-create the connector in Bot.start() as long as it is done before Client.start() is called. Just forget about trying to use a custom connector with the session created in Client.clear(). In other words, a custom connector will only be used when running a bot; using the Client just for making Discord API requests will use the default connector. Setting the connector to None in such case should be good enough.

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: bug/backend/b748/resolver\-in\-coro
ebon magnetBOT
#

Build 20200214.1 succeeded

Requested by

GitHub

Duration

00:01:34

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] New comment on pull request #741: Refactor information\.py with lots of changes that makes the overall code cleaner and faster

All the requested changes should have been made, although, I can't seem to figure out why the test is failing, even though I did update it to reflect the changes made. Help on this would be appreciated, since I have zero clue 😓

It's due to dedent() not removing the leading whitespace. It only removes it if it is common to all lines. The lines added by channel_counts lack the leading whitespace. Therefore, the whitespace is not common to all lines and it isn't remove for any...

north knotBOT
#

Postgres backup completed!

regal archBOT
#
SebastiaanZ
[python-discord/bot] Issue opened: #751 Infraction scheduler raises exception when marking infraction as "permanent" during edit

When an existing temporary infraction is turned into a permanent infraction using the !infraction edit functionality, we ask the infraction scheduler to schedule a new task with infraction["expires_at"] = None. However, the scheduler expects to be called only for infractions that have a datetime string mapped to the "expires_at" key. This means that the scheduler will try to parse that None value with dateutil.parse.isoparse, which results in an exception:

Traceback (most ...
regal archBOT
#
SebastiaanZ
[python-discord/bot] New branch created: infr\-edit\-permanent\-fix
#
SebastiaanZ
[python-discord/bot] Pull request opened: #752 Stop scheduling expiration of permanent infractions on edit

The infraction edit command defined in bot.cogs.moderation.management contained a bug causing it to attempt to schedule an expiration task when turning a temporary infraction into a permanent infraction. Since the "expires_at" field of a permanent infraction is None, this caused an exception to occur in the scheduler:

Traceback (most recent call last):
  File "/bot/bot/cogs/moderation/scheduler.py", line 415, in _scheduled_task
    expiry = dateutil.parser.isoparse(infraction[...
ebon magnetBOT
#

Build 20200214.2 succeeded

Requested by

GitHub

Duration

00:01:48

Build pipeline

Bot

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] branch deleted: infr\-edit\-permanent\-fix
north knotBOT
ebon magnetBOT
#

Build 20200214.3 succeeded

Requested by

GitHub

Duration

00:03:02

Build pipeline

Bot

oak estuaryBOT
regal archBOT
regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200215.1 succeeded

Requested by

GitHub

Duration

00:01:23

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200215.2 succeeded

Requested by

GitHub

Duration

00:01:27

Build pipeline

Bot

regal archBOT
regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200215.3 succeeded

Requested by

GitHub

Duration

00:02:00

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200215.4 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Bot

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: feat/frontend/b685/expired\-infraction\-log\-duration
#
MarkKoz
[python-discord/bot] Pull request opened: #753 Show created date and duration in expired infraction log

Closes #685

  • Creation date is displayed in the log.
  • The duration between the expiration and the creation is displayed as a humanised delta. If the infraction had no expiration, then the duration is relative to the current time rather than an expiration.
  • The actual actor is displayed rather than always being the bot user.
  • The member is displayed as a mention rather than an ID.

Before:
![bild](https://user-images.githubusercontent.com/1515135/74598415-16387700-5026-11ea-9695-fb...

ebon magnetBOT
#

Build 20200216.1 succeeded

Requested by

GitHub

Duration

00:01:40

Build pipeline

Bot

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: bug/backend/b754/scheduler\-suppresses\-errors
regal archBOT
ebon magnetBOT
#

Build 20200216.2 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200216.3 succeeded

Requested by

GitHub

Duration

00:01:30

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200216.4 succeeded

Requested by

GitHub

Duration

00:01:39

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
#
MarkKoz
[python-discord/bot] New comment on issue #533: Display nickname as plain text in infraction mod logs instead of user id

Let's figure out exactly what the member and the actor should be displayed.

Information

These questions need to be answered for both the member and the actor separately:

  1. Should the ID be displayed alongside a username/nickname?
    • ID will still always be the fall-back when no name data is available
  2. Should the nickname be displayed?
    • Is it worth an API call to get the data or should it rely solely on the cache?
      • Should it use the latest data from Discord ...
regal archBOT
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200216.1 succeeded

Requested by

Leon Sandøy

Duration

00:03:15

Build pipeline

Site

regal archBOT
regal archBOT
regal archBOT
#
MarkKoz
[python-discord/site] New branch created: bug/backend/s329/docker\-compose\-tty
ebon magnetBOT
#

Build 20200216.2 succeeded

Requested by

GitHub

Duration

00:02:11

Build pipeline

Site

regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: bug/backend/s329/docker\-compose\-tty
#
MarkKoz
[python-discord/bot] Pull request opened: #756 Fix missing Django logs when using Docker Compose

Related to python-discord/site#329

Currently when starting the web server with Docker Compose, some log messages were not showing up. This is fixed by allocating a pseudo-tty to the web service in Docker Compose. It's added to the bot too just in case :)

Here are some messages which will appear with this fix:

web_1       | 431 static files copied to '/var/www/static'.
web_1       | Creating a superuser.
web_1       | Admin superuser already exists.
web_1       | Existing bot ...
ebon magnetBOT
#

Build 20200216.5 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

oak estuaryBOT
#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

ebon bolt
#

sorry guys

#

almost done

oak estuaryBOT
#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

#

<@&267628507062992896> WARNING: Unable to get DEFCON settings!

regal archBOT
north knotBOT
regal archBOT
ebon magnetBOT
#

Build 20200217.1 succeeded

Requested by

GitHub

Duration

00:04:29

Build pipeline

Site

regal archBOT
#
MarkKoz
[python-discord/bot] New branch created: feat/backend/b131/error\-handling
#
MarkKoz
[python-discord/bot] Pull request opened: #757 Handle more types of CommandError
  • Send an error message for all types of UserInputError. The "Something about your input seems off. Check the arguments:" message was too ambiguous to be of much help to users. The messages mostly use the default error messages defined in the exceptions.
  • Send and error message for BotMissingRole and BotMissingAnyRole. It shares the message with BotMissingPermissions. It's a cleaner and less dramatic way of handling these errors even though they will rarely be seen.
  • `on_command...
ebon magnetBOT
#

Build 20200217.1 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

regal archBOT
north knotBOT
#

Postgres backup completed!

oak estuaryBOT
regal archBOT
north knotBOT
ebon magnetBOT
#

Build 20200217.2 succeeded

Requested by

GitHub

Duration

00:03:22

Build pipeline

Bot

oak estuaryBOT
regal archBOT
#
SebastiaanZ
[python-discord/bot] New review comment on pull request #711: Prevent the role syncer from wiping the database table during API latency

This solution makes sense to me in terms of maintainability. It did confuse me for a moment, partly because the git blame isn't directly available in the PR review view, so I think we should add a comment about why we're defining these class attributes here. I would be fine with a single line comment referring to the commit for more information (partly to anticipate the relevant commit being pushed down by future commits.)

#
SebastiaanZ
[python-discord/bot] Pull request review submitted: #711 Prevent the role syncer from wiping the database table during API latency

Few questions, no major issues as far as I can tell. I've played around with it for a bit and it seems to work, but it's a fairly complex system and a real stress test will happen "in production". That will also show if things like a threshold of 10 for the user syncer confirmation message is low when dealing with a guild our size. It's probably fine and we can always adjust such things later.

regal archBOT
#
SebastiaanZ
[python-discord/bot] Issue opened: #758 Upgrading to Python 3\.8

Summary

We should upgrade the Python version of the bot to Python 3.8

Rationale

Python 3.8 offers significant improvements in the area of writing unittests for asyncio; in fact, you could say that Python 3.8 finally brings proper asyncio-support to Python's built-in unittest framework. By upgrading to Python 3.8, we'd no longer have to implement custom mock classes and decorators to make our test suite compatible with the plentiful asynchronous features of the bot that we're trying...

regal archBOT
#
F4zii
[python-discord/bot] New branch created: optimize/pagination/emoji\_collection\_structure
ebon magnetBOT
#

Build 20200217.3 succeeded

Requested by

GitHub

Duration

00:01:54

Build pipeline

Bot

regal archBOT
regal archBOT
oak estuaryBOT
north knotBOT
#

Postgres backup completed!

regal archBOT
#
F4zii
[python-discord/bot] New branch created: feat/F4zi/CommandSuggestion
ebon magnetBOT
#

Build 20200218.1 failed

Requested by

GitHub

Duration

00:00:56

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200218.2 failed

Requested by

GitHub

Duration

00:00:59

Build pipeline

Bot

regal archBOT
#
MarkKoz
[python-discord/bot] Pull request review submitted: #760 Feature: suggest command usage for misspelt commands

The tags cog is not the right place for this since this feature is not actually related to tags. As it is, it will suggest commands when tags are fetched. This may make sense when this is triggered via the CommandNotFound error but it doesn't when using the !tags get command or any of its aliases.

You're piggybacking on fact that the tags are fetched by the error handler when a command isn't found. Instead, the error handler should call this code more directly. It may be better to wait...

ebon magnetBOT
#

Build 20200218.4 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200218.5 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

#

Build 20200218.6 succeeded

Requested by

GitHub

Duration

00:01:36

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200218.8 succeeded

Requested by

GitHub

Duration

00:01:33

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200218.9 succeeded

Requested by

GitHub

Duration

00:01:39

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200218.10 succeeded

Requested by

GitHub

Duration

00:01:22

Build pipeline

Bot

regal archBOT
regal archBOT
#
F4zii
[python-discord/bot] New comment on pull request #760: Feature: suggest command usage for misspelt commands

Hey mark, as I've said, the current structure of the error_handler is a bit hard to change for that usage (since it reinvokes every misspelt command as a tag), I can wait or change its implementation if needed
I agree the tags aren't the place for this, I got a suggestion to base it there since its the easiest way, I will now work on a better way and update you :+1:
I also had an idea to use the returned value from the command invoke into a useful piece of data

north knotBOT
#

Postgres backup completed!

regal archBOT
ebon magnetBOT
#

Build 20200219.1 failed

Requested by

GitHub

Duration

00:01:57

Build pipeline

Site

regal archBOT
ebon magnetBOT
#

Build 20200219.1 succeeded

Requested by

GitHub

Duration

00:01:46

Build pipeline

Bot

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200219.2 succeeded

Requested by

GitHub

Duration

00:01:30

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200219.3 succeeded

Requested by

GitHub

Duration

00:01:25

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200219.4 succeeded

Requested by

GitHub

Duration

00:01:34

Build pipeline

Bot

regal archBOT
#
sco1
[bot:master] 7 new commits

b4d870a Utils: refactor format_infraction_with_duration... - MarkKoz
2a65569 Moderation: add creation date & duration to exp... - MarkKoz
9f3bcc5 Moderation: show correct actor in expired infra... - MarkKoz
695ea44 Moderation: show member as a mention in expired... - MarkKoz
66901fc Moderation: show avatar in infraction deactivat... - MarkKoz

#
sco1
[python-discord/bot] branch deleted: feat/frontend/b685/expired\-infraction\-log\-duration
north knotBOT
ebon magnetBOT
#

Build 20200219.5 succeeded

Requested by

GitHub

Duration

00:02:57

Build pipeline

Bot

oak estuaryBOT
regal archBOT
ebon magnetBOT
#

Build 20200219.6 succeeded

Requested by

GitHub

Duration

00:01:27

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200219.7 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200219.8 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200219.9 succeeded

Requested by

GitHub

Duration

00:01:28

Build pipeline

Bot

regal archBOT
regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200219.10 succeeded

Requested by

GitHub

Duration

00:01:32

Build pipeline

Bot

regal archBOT
ebon magnetBOT
#

Build 20200219.11 succeeded

Requested by

GitHub

Duration

00:01:34

Build pipeline

Bot

regal archBOT
regal archBOT
#
MarkKoz
[python-discord/bot] New review comment on pull request #760: Feature: suggest command usage for misspelt commands

Keeping in mind this is not strictly enforced, here are my suggestions for writing docstrings:

  1. Use the imperative mood.
  2. Try to include information about the return value in the summary, if it fits.
  3. A parameters/arguments section is generally something we don't use. If they warrant explicit explanation, then that information should be provided as sentences/paragraphs in the body of the docstring.

My attempt, feel free to modify:

        """
        Show contents of ...
regal archBOT
#
makusu2
[python-discord/snekbox] Issue opened: #57 Improve non\-developer access

At the moment, the only way to use snekbox is to follow the instructions in the README. It would be nice if there were also instructions on how to quickly get a working container up and running, even if it's just a script, although it'd be better if there were instructions on how to use the image on the Docker hub.

regal archBOT
regal archBOT
ebon magnetBOT
#

Build 20200220.1 failed

Requested by

GitHub

Duration

00:00:54

Build pipeline

Bot

north knotBOT
#

Postgres backup completed!

regal archBOT
#
jos-b
[python-discord/snekbox] New comment on issue #58: Don't run in host mode

I've just checked how we are deploying this and we actually create our own network which we then connect containers to (if you see bot it sends a request to http://snekbox:8060).

I believe it is set to host here purely for development purposes, deployment is not intended to be carried out through docker-compose.

#
jos-b
[python-discord/snekbox] New comment on issue #57: Improve non\-developer access

Also while we could simplify things somewhat this isn't the type of docker container where you just boot it up and get a web interface, it is an API so some sort of programming will always be required.

We do already have instructions on how to use the image in the README:

HTTP REST API

Communication with snekbox is done over a HTTP REST API. The framework for the HTTP REST > API is Falcon and the WSGI being used is Gunicorn. By default, the server is hosted on 0.0.0.0:8060 wit...

regal archBOT
#
scragly
[python-discord/bot] New branch created: logging
regal archBOT
#
scragly
[python-discord/bot] Pull request opened: #761 Refactor logging setup to be more explicit and cleaner\.

Description

This PR is to refactor the logging prep in our __init__.py module to avoid issues encountered with import sensitivity and overwritten logging settings.

It simplifies some existing code and removed anything that was no longer useful, such as the logmatic dependency and the aio_pika log setup..

The formatting of the logger was tweaked.

Background

Logging Levels and Handlers

Previously, we had a for loop that indiscriminately forced all registered in...