GitHub Actions run 9136850550 succeeded.
#dev-log
1 messages ยท Page 23 of 1
Connected!
GitHub Actions run 9138242894 succeeded.
Connected!
If it helps at all, the only change required for this is to literally swap push_scope for new_scope:
python-discord/bot@5b209b1 (#3047)
Our usages of push_scope are innocuous enough that the slight changes in behaviour are null for us.
c296ba3 Bump sphinx from 7.2.6 to 7.3.7 (#213) - dependabot[bot]
0ddd6bb Bump jinja2 from 3.1.3 to 3.1.4 (#218) - dependabot[bot]
0564dd9 Bump aiohttp from 3.9.3 to 3.9.4 (#220) - dependabot[bot]
ad678c6 Bump pytest-xdist from 3.5.0 to 3.6.1 (#216) - dependabot[bot]
I think we can disable RUF029, it's not worth changing an external api for this, and in one of the cases the function has to be async as it's awaited by discord.py. There's no real harm in having a non-async-using function marked async, and it can be sensible to mark something async to allow it to use async features in the future.
Connected!
Connected!
All looks good, only thing I've noticed is we store user display name but it looks missing from a lot of this.
It looks like the missing serialisation here was already present but maybe it should be added in now?
Do we not need to include the display name field here?
Oh just noticed the PR age, the serialisation might be present in main then.
d23ac09 Update workflow name in status embed workflow - ChrisLovering
d1acc6e use curl to download pr artifact (#123) - shtlrs
[python-discord/sir-robin] branch deleted: fix-status-embed
Connected!
Connected!
GitHub Actions run 9147892134 succeeded.
Connected!
Connected!
[python-discord/sir-lancebot] New branch created: improve-embed-action
Info on changes is in commits.
If this is deemed correct then I'll apply these changes to our other repos too.
GitHub Actions run 9150046020 succeeded.
[python-discord/site] New branch created: jb3/user-props-store
This PR introduces a UserModSettings model to store properties related to
moderator preference that we currently store in Redis. This is part of a wider
scale effort to migrate away from Redis any data which would be anything more
than slightly annoying in the event it gets lost.
This will require bot side changes but it is not a breaking change to merge this
when it is ready. Some manual migration will be required to move the current
moderator settings from Redis into this new PostgreSQL ...
GitHub Actions run 9150173978 failed.
Connected!
GitHub Actions run 9150756265 succeeded.
cb2d387 Copy status_embed workflow from sir-lancebot - wookie184
[python-discord/bot] New branch created: improve-status-embed-action
these are the same as the defaults so no need to pass them.
GitHub Actions run 9150975196 succeeded.
d9da4f3 Update status embed workflow - wookie184
[python-discord/site] New branch created: update-status-embed-workflow
Removes redundant and incorrect condition, and improves consistency with other repos
GitHub Actions run 9151012167 succeeded.
800f2a9 Improve status embed workflow - wookie184
[python-discord/sir-robin] New branch created: improve-status-embed-workflow
Removes redundant and incorrect condition, removes use of deprecated ::set-output, and ensures correct information is displayed in the embed.
The file is copied from https://github.com/python-discord/sir-lancebot/pull/1532 so we can also improve consistency between repos.
GitHub Actions run 9151068769 succeeded.
b05973f Update status embed workflow - wookie184
[python-discord/branding] New branch created: improve-status-embed-workflow
Use updated status embed workflow with various fixes and updates. This improves consistency with other repos.
This is a copy of https://github.com/python-discord/sir-lancebot/pull/1532, other than keeping the workflow name "Event Validation"
GitHub Actions run 9151104934 succeeded.
5cad430 Copy status_embed workflow from sir-lancebot (#... - wookie184
[python-discord/bot] branch deleted: improve-status-embed-action
What does this do and why?
Connected!
GitHub Actions run 9151368469 succeeded.
It means that if a status-embed workflow is triggered while one is already running it will kill the old one before running the new one. So if you quickly but separately push multiple commits in sequence it will only post the status of the newest CI run*.
I mainly added for consistency as most other repos had it already.
*now that I think about it, it's a bit more complicated than this, since the CI workflow takes longer than the status_embed workflow. If CI is replaced with a new run, t...
Thanks. If we already use it successfully in other repos then I'm not concerned with keeping it.
Yes, we do. This wasn't a thing when I opened the PR. I included it now.
Migrations are merged, display_name was added, please re-review.
GitHub Actions run 9153875387 failed.
Request a review from me if this is ready for review
GitHub Actions run 9153875387 succeeded.
617337a Update various dependencies used in actions wor... - wookie184
[python-discord/branding] New branch created: update-ci-versions
b8824d8 Update various dependencies used in actions wor... - wookie184
[python-discord/branding] branch deleted: update-ci-versions
GitHub Actions run 9160826105 succeeded.
[python-discord/site] branch deleted: update-status-embed-workflow
0896ebe Bump rapidfuzz from 3.9.0 to 3.9.1 (#1533) - dependabot[bot]
Connected!
GitHub Actions run 9160878343 succeeded.
GitHub Actions run 9160850849 succeeded.
GitHub Actions run 9160863393 succeeded.
fb1acce Bump rapidfuzz from 3.9.0 to 3.9.1 (#3058) - dependabot[bot]
2cf4178 Bump emoji from 2.11.1 to 2.12.1 (#1534) - dependabot[bot]
Connected!
GitHub Actions run 9161285235 succeeded.
Connected!
GitHub Actions run 9161309251 succeeded.
Connected!
GitHub Actions run 9161314102 was cancelled.
Connected!
GitHub Actions run 9161343166 succeeded.
I may misunderstand Django migrations and this may be a non-issue, but do we need to update the dependencies of the 0093_user_alts migration to instead depend on 0095_user_display_name (which should be the most recent migration)
[python-discord/site] New comment on pull request #773: Add guide for working with Python on Windows
If we can make a decision on whether to guide the user to have python on their PATH, or just to have them use py, it would help to move this forwards.
I prefer getting the user to have python on ther PATH for the reasons I mention here https://github.com/python-discord/site/pull/773#discussion_r1160869869, so personally I'm quite happy with leaving the PR mostly as is, though I could make some of the changes to make py a bit more visible as an option.
GitHub Actions run 9166659758 succeeded.
79ff950 handle empty string in old_reason - Esther-Goldberg
True. I don't think it's possible, but just in case it ever comes up I modified that.
GitHub Actions run 9166900800 succeeded.
One small bit that can be removed since the try/except was added, other than that all looks good. Thanks for working on this!
nomination_entries = original_nomination.entries
c91bf46 remove error message because issue is already h... - Esther-Goldberg
GitHub Actions run 9167509057 succeeded.
Great stuff, thanks again ๐
7569771 Fix case sensitivity bug in phishing button - vivekashok1221
3996fa6 Update regex to discard trailing ')' and lowerc... - vivekashok1221
ea10480 Skip adding phishing button if user already banned - vivekashok1221
69bc65b Use regex to detect Discord invite link - vivekashok1221
d757301 Reference the /tag slash-command instead in tag... - hedyhli
GitHub Actions run 9167646999 succeeded.
9705ac0 Add feature to append additional text to nomina... - Esther-Goldberg
[python-discord/bot] branch deleted: append-nominations
Connected!
GitHub Actions run 9167729094 succeeded.
Connected!
GitHub Actions run 9167745871 was cancelled.
Thoughts on ignoring rule RUF029?
Connected!
Thoughts on ignoring rule RUF029?
Sounds sensible to me, it seems fairly prone to false positives, and having something async when it doesn't need to be isn't really an issue anyway.
Very well. I shall make our thoughts a reality.
e3e792c Appeased the linter - Xithrius
GitHub Actions run 9167927265 succeeded.
7569771 Fix case sensitivity bug in phishing button - vivekashok1221
3996fa6 Update regex to discard trailing ')' and lowerc... - vivekashok1221
ea10480 Skip adding phishing button if user already banned - vivekashok1221
69bc65b Use regex to detect Discord invite link - vivekashok1221
d757301 Reference the /tag slash-command instead in tag... - hedyhli
GitHub Actions run 9170150451 succeeded.
Connected!
GitHub Actions run 9170169324 succeeded.
GitHub Actions run 9170710103 succeeded.
I couldn't find a good way to phrase the sentence that could concisely and professionally tell everyone that this button is for everyone other than the reminder's author, so I decided to list the reminder mentions upfront to make it clear what the button will do. In exchange the embed might be considered a little verbose (until the button times out).
If others feel the embed is fine as it is and is not too verbose , then let's stick with it- but how about "Notify me too" or "Join reminde...
7569771 Fix case sensitivity bug in phishing button - vivekashok1221
3996fa6 Update regex to discard trailing ')' and lowerc... - vivekashok1221
ea10480 Skip adding phishing button if user already banned - vivekashok1221
69bc65b Use regex to detect Discord invite link - vivekashok1221
d757301 Reference the /tag slash-command instead in tag... - hedyhli
[python-discord/bot] branch deleted: reply-to-eval
GitHub Actions run 9174044519 succeeded.
Connected!
GitHub Actions run 9174054039 succeeded.
GitHub Actions run 9174588296 succeeded.
e1869d4 Post nomination entries into the voting thread ... - jb3
[python-discord/bot] New branch created: jb3/nom-post-changes
This change moves us from posting multiple messages in the
nomination-voting channel to instead posting all entries into the voting
thread.
This makes the nomination process guaranteed to be contained within one
root message and one channel, instead of splitting into multiple
messages in the root if we went over the character limit.
It greatly simplifies both the creation and the archival of nomination
votes as we only need to handle one message.
It also means that all nominations are guar...
GitHub Actions run 9179229582 succeeded.
[python-discord/site] New branch created: jb3/nominations/filter-on-reviewed
335b632 Add reviewed to nomination filterset fields - jb3
Allows listing nominations based on whether the reviewed attribute is set.
Will be used for an upcoming bot feature to simplify finding the thread for an active nomination.
GitHub Actions run 9179359970 succeeded.
GitHub Actions run 9179673669 succeeded.
[python-discord/bot] New branch created: jb3/nominations/relay-updates
If a nomination is actively being voted on and a staff member creates, updates
or attaches a message to their existing nomination we currently do not relay
that to the vote thread.
This PR relays any of these events to the vote thread so they are not lost.
This also allows moderators to use the message context menu command to attach
any relevant messages they find whilst reviewing into the active voting thread.
GitHub Actions run 9179968461 succeeded.
Looks good, just some ideas to make it cleaner that i'd like your thoughts on.
If we added an api.get_active_nomination(user_id) -> Nomination | None function, I think this could be made a lot cleaner. I'd been thinking of suggesting that anyway as it'd be useful in quite a few other places as well.
nomination = await api.get_active_nomination(nominee_id)
if nomination and nomination.thread_id:
log.debug(f"Found thread ID for {nominee_id} nomination, relaying new context.")
thread = await get_or_fetc...
Since it's taking the api, bot, and calling methods on the cog, it may be cleaner to make it take the cog itself as an argument instead (and not have maybe_relay_update as a staticmethod).
I don't really mind though.
# Regex for finding a nomination, and extracting the nominee.
The get_review command will need updating now that make_review returns another value:
https://github.com/python-discord/bot/blob/7437d98bfa8287a91857f860567efd748e38e438/bot/exts/recruitment/talentpool/_cog.py#L766
(I don't mind what you make the command do, or even if you want to remove it instead, I don't think it's that useful).
Not tested yet but looking pretty solid, thanks ๐ช
can't comment on all the relevant lines, but are we safe to just send a single archive embed now?
GitHub Actions run 9182969022 succeeded.
[python-discord/branding] New branch created: allow-events-crossing-years
Maybe use .mention for consistency
GitHub Actions run 9183924414 succeeded.
I have made it follow the more concise format (second screenshot) as per request from @Xithrius.
GitHub Actions run 9183938078 succeeded.
Diff of the force-pushed changes.
diff --git a/bot/exts/fun/trivia_quiz.py b/bot/exts/fun/trivia_quiz.py
index 6041d031..d624e0fe 100644
--- a/bot/exts/fun/trivia_quiz.py
+++ b/bot/exts/fun/trivia_quiz.py
@@ -625,7 +625,7 @@ class TriviaQuiz(commands.Cog):
for cat, description in self.categories.items():
embed.description += (
- f"- **{cat.capitalize()}**\n{description.capitalize()}\n\n"
+ f"- **{cat.capitalize()}**: {de...
db7c0d1 Trivia quiz: Fix question about surrogate codep... - L3viathan
827445b Merge pull request #1505 from python-discord/L3... - wookie184
f86fda6 Bump ruff from 0.3.4 to 0.3.5 (#1503) - dependabot[bot]
19f4432 Bump pillow from 10.2.0 to 10.3.0 (#1504) - dependabot[bot]
2f22178 Bump lxml from 5.2.0 to 5.2.1 (#1507) - dependabot[bot]
109d112 Trivia: Fix misleading category description emb... - hedyhli
[python-discord/sir-lancebot] branch deleted: fix/trivia-help-text
GitHub Actions run 9184038977 succeeded.
Connected!
GitHub Actions run 9184043702 succeeded.
[python-discord/bot] New branch created: support-events-crossing-years
531acee Support events that span from one year to another - wookie184
ccc79d1 Update documentation to mention events crossing... - wookie184
GitHub Actions run 9184150223 succeeded.
Closes #171
Must be merged after https://github.com/python-discord/bot/pull/3065
Connected!
GitHub Actions run 9184186320 succeeded.
GitHub Actions run 9184237697 succeeded.
GitHub Actions run 9184272155 succeeded.
There must be exactly 1 fallback event, and 0 or more non-fallback events. If `start_date` is a later day in the year than `end_date`, the event is interpreted as starting in one year and ending in the next. Both bounds are inclusive, and the format shown in the example above must be followed.
Perhaps?
entry_count = len(nomination.entries)
return f"They have **{entry_count}** nomination{'s' if entry_count > 1 else ''} this round."
GitHub Actions run 9184571772 succeeded.
Connected!
GitHub Actions run 9184621881 succeeded.
GitHub Actions run 9184635179 succeeded.
Connected!
GitHub Actions run 9184640528 succeeded.
a21a971 Add new Nomination API filter to filter to acti... - jb3
5f2bf17 Add get_active_nomination API method for Talent... - jb3
ded9db6 Relay any creations or amendments to nomination... - jb3
c2b3e27 Merge pull request #3064 from python-discord/jb... - jb3
f8abd6a Post nomination entries into the voting thread ... - jb3
GitHub Actions run 9185851601 succeeded.
GitHub Actions run 9186020047 succeeded.
GitHub Actions run 9186247534 succeeded.
GitHub Actions run 9189962510 succeeded.
GitHub Actions run 9202669490 succeeded.
This might be kind of obvious but I feel it's still useful information to inlude.
There must be exactly 1 fallback event, and 0 or more non-fallback events. For single-day events, `end_date` must be equal to `start_date`. If `start_date` is a later day in the year than `end_date`, the event is interpreted as starting in one year and ending in the next. Both bounds are inclusive, and the format shown in the example above must be followed.
GitHub Actions run 9207820742 succeeded.
6023c10 Allow events to cross from one year to another - wookie184
968aa2f Make the New Year event active in December and ... - wookie184
ccc79d1 Update documentation to mention events crossing... - wookie184
7577400 Nicer formatting in README - wookie184
3151bf7 Clarify how to specify one day events - wookie184
[python-discord/branding] branch deleted: allow-events-crossing-years
fe7887d Support events that span from one year to anoth... - wookie184
[python-discord/bot] branch deleted: support-events-crossing-years
Connected!
GitHub Actions run 9208070279 succeeded.
GitHub Actions run 9208153951 succeeded.
GitHub Actions run 9208159982 succeeded.
I don't think there's a good workaround for the replying and including extra text issues, which is a dealbreaker for me.
Yes, i agree.
I'll close this for now
@jb3
I may misunderstand Django migrations and this may be a non-issue, but do we need to update the dependencies of the 0093_user_alts migration to instead depend on 0095_user_display_name (which should be the most recent migration)
We do not. The merged migration takes care of resolving conflicts.
GitHub Actions run 9211020005 succeeded.
0799c76 Improve accuracy (and efficiency) of MockContext - wookie184
7909349 Reply to eval commands instead of using a menti... - wookie184
c0e95e8 Fix typo - wookie184
ff1d3a8 Fix showing !source on tags when tags cog is ... - hedyhli
8fade13 Bump regex from 2024.4.28 to 2024.5.10 (#3044) - dependabot[bot]
[python-discord/bot] branch deleted: vivek/fix-eval-truncation
GitHub Actions run 9211198952 succeeded.
Connected!
GitHub Actions run 9211211563 succeeded.
GitHub Actions run 9212612881 succeeded.
GitHub Actions run 9212626801 failed.
GitHub Actions run 9212641429 succeeded.
Connected!
GitHub Actions run 9212626801 succeeded.
Give a default name of "Name not found" if unicodedata is unable to find one, to fix the faulty hyperlinks.

GitHub Actions run 9213417119 succeeded.
Connected!
GitHub Actions run 9214055690 succeeded.
GitHub Actions run 9214084729 succeeded.
Connected!
GitHub Actions run 9214095692 succeeded.
8b208d4 Bump pydantic from 2.6.4 to 2.7.1 (#215) - dependabot[bot]
6b52051 Bump fakeredis from 2.21.3 to 2.23.2 (#221) - dependabot[bot]
d482da8 Bump sentry-sdk from 2.2.0 to 2.3.0 (#1537) - dependabot[bot]
Connected!
GitHub Actions run 9214598420 succeeded.
I probably should have waited on merging other dependabot PRs to avoid making a conflict here... my bad.
Could you fix pls Xith (and could someone else approve too so it can be merged without more conflicts)
bebc51f Bump HassanAbouelela/actions from setup-python_... - dependabot[bot]
GitHub Actions run 9214654412 was cancelled.
089b7f4 Add alternate accounts to the user model - jchristgit
[python-discord/site] branch deleted: user-alts
Connected!
6bd8cd1 Add a cog to manage tracking a user's alt accounts - ChrisLovering
98c7a2c Indicate if the user has alts when seaching for... - ChrisLovering
058146f Don't allow bots to be marked as alts - ChrisLovering
81ce2f4 Nicely format error when editing alts where tar... - ChrisLovering
9de7190 Output user alts in user command when ran in mo... - ChrisLovering
[python-discord/bot] branch deleted: feat/1353/alt-users
GitHub Actions run 9214676886 succeeded.
Connected!
GitHub Actions run 9214708726 succeeded.
GitHub Actions run 9214816941 succeeded.
2c02f5f Allow listing alts for a user via the alts root... - ChrisLovering
[python-discord/bot] New branch created: alt-aliases
a673a5c Allow listing alts for a user via the alts root... - ChrisLovering
[python-discord/bot] branch deleted: alt-aliases
GitHub Actions run 9214940119 succeeded.
GitHub Actions run 9214950764 was cancelled.
Connected!
GitHub Actions run 9214957273 succeeded.
GitHub Actions run 9215699818 succeeded.
GitHub Actions run 9216596110 failed.
GitHub Actions run 9216626850 failed.
GitHub Actions run 9216658912 failed.
@lxnn Hi, any update on this?
GitHub Actions run 9218693895 succeeded.
GitHub Actions run 9218749963 succeeded.
GitHub Actions run 9218760384 succeeded.
GitHub Actions run 9218778143 succeeded.
GitHub Actions run 9218877940 succeeded.
GitHub Actions run 9218911091 was cancelled.
GitHub Actions run 9218915989 succeeded.
b977cf4 Improve status embed workflow (#124) - wookie184
[python-discord/sir-robin] branch deleted: improve-status-embed-workflow
Connected!
GitHub Actions run 9222565913 succeeded.
a058959 Make !warn fail if DM unsuccessful - vivekashok1221
[python-discord/bot] New branch created: vivek/warn-dm-fail
Closes #1352
I've made it so that !warn will fail if the user has their DMs disabled (or has blocked the bot) AND the command was invoked in a "private" channel which the user does not have access to.
GitHub Actions run 9223888097 succeeded.
GitHub Actions run 9223924880 succeeded.
I'm open to changing this to something else like "Failed to apply warning to @mention because the user has their DMs disabled".
I chose the current message because I felt it accounted for cases where users block the bot too, but I realize the distinction is irrelevant.
"failed to apply" seems a bit lacking. Maybe additional_info should be appended something like "Failed to show the warning to the user"?
This is the full log title. It's standard for failed infractions.
Do you still want to add more information to the title?
Oh wait, I misunderstood.
Yeah, I'll add additional_info
@mbaruh
How about this? Should I add more emphasize to the additional info?
Looks good. Could italicize it for style and make sure it's on a separate line in case additional_info already has something in it
This is great, only one issue I noticed.
I wonder if we should make the date metadata optional (to allow for date ranges) and extract it from the file name by default. Currently there's some inconsistency with the month name (e.g. Apr vs April), which that would help avoid.
This adds an unwanted space.
Before:
After:
For warnings, additional_info will not have anything in it. In fact, the only place I could find additional_info used is for the !superstar command.
1b5c072 Bump sentry-sdk from 2.2.1 to 2.3.1 (#1327) - dependabot[bot]
I wonder if we should make the date metadata optional (to allow for date ranges) and extract it from the file name by default. This would help avoid the inconsistency of month names you mentioned
Good idea ๐
GitHub Actions run 9225248345 succeeded.
Makes sense, but it seems prudent to treat it by what it can be rather than how it's used right now
23b58cc Add additional info to mod log embed - vivekashok1221
GitHub Actions run 9225449065 succeeded.
9ae82da Lazily create guild on text/voice channel mocks - wookie184
54ae53a Make use of fakeredis instead of mocking - wookie184
f067ba9 Don't setup the cog for Notifier and Argument P... - wookie184
71af1e4 Just use the notifier instead of patching - wookie184
5a33925 Selectively patch SilenceNotifier only where ne... - wookie184
[python-discord/bot] New branch created: faster-silence-tests
Currently the tests for the !silence commands are pretty slow, taking up almost half of the execution time of the whole test suite.
This PR more than doubles the speed of pytest tests/bot/exts/moderation/test_silence.py (from >5s to <2s for me), resulting in the overall test suite being about 1/3 faster.
This definitely makes sense to look through commit by commit, as the commit descriptions explain each change.
GitHub Actions run 9231067820 succeeded.
1ee9100 Use COVERAGE_CORE=sysmon when running tests in CI - wookie184
[python-discord/bot] New branch created: use-coverage-sysmon
https://coverage.readthedocs.io/en/7.5.1/cmd.html#execution-coverage-run
In Python 3.12 and above, you can try an experimental core based on the new sys.monitoring module by defining a COVERAGE_CORE=sysmon environment variable. This should be faster, though plugins and dynamic contexts are not yet supported with it.
Confirmed it gives the same result for us, just a lot faster.
GitHub Actions run 9231351394 succeeded.
Looks good, one minor thing, let me know what you think?
Looks good, my only thing would be I prefer to use a designated env block, then we can document it.
run: pytest -n auto --cov -q
env:
# Use "sys.monitoring" based coverage backend for better speed (see #3075)
COVERAGE_CORE: sysmon
19c3b1d Specify environment variable using env block - wookie184
Good idea, committed your suggeston.
GitHub Actions run 9231508173 succeeded.
Connected!
GitHub Actions run 9231707495 succeeded.
GitHub Actions run 9231858991 succeeded.
GitHub Actions run 9232410931 succeeded.
Connected!
GitHub Actions run 9240148808 failed.
GitHub Actions run 9240448781 failed.
GitHub Actions run 9240469147 failed.
GitHub Actions run 9240536432 failed.
Connected!
GitHub Actions run 9249805141 succeeded.
GitHub Actions run 9255177133 succeeded.
Description
Currently, only staff can use the .rp command in channels like #python-discussion. I propose we change it so any user can use it, as with the .topic command.
Reasoning
More than just mods can benefit from the command. It's a good way to link people to reliable articles for more in-depth information on various concepts. Non-staff members should still have the ability to give these articles if they think it's helpful.
Proposed Implementation
This functionalit...
When a deleted message is logged in #message-change-log, also add a link to the message it was replying to. This will provide better context about the deleted message and is a trivial addition.
(originally proposed by @bj0key in #mod-tools)
This is what the embed looks like currently:
01d701a Add support for parsing system information - jchristgit
[python-discord/king-arthur] New branch created: system-information-support
This commit adds support for parsing miscellaneous system file formats, allowing us to further incorporate parsing for files such as /proc/PID/status for future command purposes.
[king-arthur] Branch system-information-support was force-pushed to `f1797a2`
[king-arthur] Branch system-information-support was force-pushed to `8c64edd`
I did not see this, I see this now, I think this is good, I think we should do it, what does @jb3 think?
2f11d78 use triple backticks as prefix and suffix - shtlrs
f949fef ignore too many arguments errors - shtlrs
I did not see this, I see this now, I think this is good, I think we should do it, what does @jb3 think?
Both Markus and Volcyy like this
[king-arthur] Branch system-information-support was force-pushed to `59ebd3f`
Looks good! Can't test but I trust you. GOAT!
[python-discord/king-arthur] branch deleted: paginate-pod-logs
GitHub Actions run 9277252446 succeeded.
GitHub Actions run 9277314549 succeeded.
GitHub Actions run 9284868277 succeeded.
What should the command do?
The idea is us being able to execute specific actions on one of our netcup boxes.
For this to happen, a king-arthur user needs to be created on all of our boxes.
Then, using its own private key, KA can SSH into a particular box and execute a command from there.
I am not sure how to scope this in terms of commands/cogs, but i thought we could have a netcup cog which contains 2 commands
- a
rawcommand, to allow flexivility of using any command we...
GitHub Actions run 9294924586 succeeded.
Description
I changed the uptime command to use a discord formatted timestamp, rather than formatting the start_time and sending it. This way you can see exactly when the bot started, in your own timezone.
In addition, I also added some small formatting to the ping command, so the gateway ping is show in a tiny codeblock like this.
Did you:
- [X] Join the Python Discord Community?
- [X] Read all the comments in this template?
- [X] En...
GitHub Actions run 9296131693 failed.
GitHub Actions run 9301098121 succeeded.
GitHub Actions run 9302712100 succeeded.
Thanks for the contribution.
The change to the uptime command looks fine to me but i'm not sure about the change to the ping command.
The linting is also not passing, if you look at https://github.com/python-discord/sir-lancebot/pull/1542/files you can see the issues, and you can use poetry run task lint locally to lint locally (and poetry run task precommit to set up precommit which will automatically check before you commit).
I think both ways look fine, so I don't really think it's worth changing unless there's a good reason.
16f5425 Bump sentry-sdk from 2.3.0 to 2.3.1 (#1539) - dependabot[bot]
Connected!
GitHub Actions run 9310607497 was cancelled.
GitHub Actions run 9310618390 succeeded.
Connected!
GitHub Actions run 9310618913 was cancelled.
Connected!
GitHub Actions run 9310630648 succeeded.
Connected!
GitHub Actions run 9310713367 was cancelled.
Connected!
GitHub Actions run 9310731193 succeeded.
GitHub Actions run 9310757878 succeeded.
Connected!
GitHub Actions run 9310766878 succeeded.
There was a discussion about this a while ago, but it didn't reach a concensus. Starts here: #dev-contrib message
The argument was mainly that a lot of the responses from the command may not be relevant to the person being helped, so ideally the helper should have ensured that there is a particular helpful article shown in the response, in which case they can share it directly. For example, if someone just wanted to learn abo...
4f46f60 Bump django-distill from 3.1.3 to 3.2.4 (#1328) - dependabot[bot]
483cc70 Bump requests from 2.31.0 to 2.32.2 (#226) - dependabot[bot]
a4b830b Bump coverage from 7.5.1 to 7.5.3 (#1331) - dependabot[bot]
GitHub Actions run 9310993703 succeeded.
GitHub Actions run 9310979350 was cancelled.
GitHub Actions run 9311000123 succeeded.
GitHub Actions run 9311004988 succeeded.
I mostly see the rp command being helpful in cases that need more explanation and that aren't already in a short help tag. We do have a !lists command, and I think it explains enough. I do agree that it's not ideal for some results to be off the mark, but I don't see this as a huge issue, since the most that can happen is the embed just isn't helpful. It's currently not helpful at all to most users, so being helpful most of the time is still better in my opinion.
GitHub Actions run 9321915272 succeeded.
Suspect Issues
This pull request was deployed and Sentry observed the following issues:
- โผ๏ธ AttributeError: 'datetime.timedelta' object has no attribute 'minutes'
arthur.exts.systems.system_information in on_me...View Issue
<sub>Did you find this useful? React with a ๐ or ๐</sub>
GitHub Actions run 9322153415 succeeded.
6d29811 Improve entropy in system information reporting - jchristgit
[python-discord/king-arthur] New branch created: improve-friendliness
5d2d536 Bump HassanAbouelela/actions from setup-python_... - dependabot[bot]
[python-discord/king-arthur] branch deleted: improve-friendliness
Connected!
[python-discord/king-arthur] New branch created: system-software-interaction
367a802 Add support for fetching software information - jchristgit
[king-arthur] Branch system-software-interaction was force-pushed to `44722a4`
[python-discord/king-arthur] branch deleted: system-software-interaction
GitHub Actions run 9322540441 succeeded.
GitHub Actions run 9325363556 succeeded.
Fair enough. I guess it's personal preference but definitely not a necessary change.
GitHub Actions run 9330036010 succeeded.
Doc item doc_item.symbol_id='aiohttp.ClientSession' present in loaded documentation inventories not found on site, inventories may need to be refreshed.
GitHub Actions run 9331669553 succeeded.
GitHub Actions run 9331802352 succeeded.
Connected!
[python-discord/king-arthur] New branch created: data-fix
8c45ff2 Fix data inconsistency in system data report - jchristgit
GitHub Actions run 9337645197 succeeded.
cf8acde Allow King Arthur to send supportive PyDis-spec... - jchristgit
[python-discord/king-arthur] New branch created: system-pleasure-emitting-module
[king-arthur] Branch system-pleasure-emitting-module was force-pushed to `ec8fc92`
[king-arthur] Branch system-pleasure-emitting-module was force-pushed to `643ed0e`
[king-arthur] Branch system-pleasure-emitting-module was force-pushed to `e2eef30`
[king-arthur] Branch system-pleasure-emitting-module was force-pushed to `b72aaf9`
[python-discord/king-arthur] branch deleted: system-pleasure-emitting-module
GitHub Actions run 9337760528 succeeded.
Connected!
GitHub Actions run 9344975528 succeeded.
All workers are checked for code quality on Pull Requests and automatically sent to Cloudflare once they are merged.
[python-discord/king-arthur] New branch created: jb3/features/face-generator
Add a new M-x face command to generate DevOps team compatible avatars given
uploaded files/attached URLs.
For several reasons, this command should not be opened wider than the DevOps
team:
- It passes mostly untrusted URL data into ImageMagick
- It allows for endpoints in cluster to be hit through arbitrary URL hitting
- It runs things in a blocking context
For this reason, this command is only a bit of fun for DevOps role members and
should never be wider than that.
a5cbe49 Use Prometheus drop-in database engines - jb3
[python-discord/site] New branch created: jb3/monitoring/prometheus-db-metrics
This is a drop-in change that allows the django-prometheus package to export
metrics detailing statistics on database usage within the application.
There are no other changes required and this is completely transparent to the
rest of the application, the engine is just a passthrough to the underneath
postgresql engine.
GitHub Actions run 9359600508 succeeded.
GitHub Actions run 9365405294 succeeded.
GitHub Actions run 9367007991 succeeded.
Should we apt auto-clean and delete apt lists after this?
The arg default is 60 for resolution, either this doc string needs changing to 60, or the arg needs changing to 100.
Generate a system-compatible face for the given file.
For consistency we should either make this an exact version, or update the others to be carot versions.
GitHub Actions run 9368793496 succeeded.
[python-discord/king-arthur] branch deleted: jb3/features/face-generator
Suspect Issues
This pull request was deployed and Sentry observed the following issues:
- โผ๏ธ ExtensionFailed: Extension 'arthur.exts.systems.system_information' raised an error: ImportError: MagickWand share...
discord.ext.commands.bot in _load_from_module_specView Issue
<sub>Did you find this useful? React with a ๐ or ๐</sub>
Connected!
GitHub Actions run 9374931681 succeeded.
GitHub Actions run 9374911923 succeeded.
GitHub Actions run 9374932184 succeeded.
GitHub Actions run 9376341332 succeeded.
GitHub Actions run 9378567667 succeeded.
GitHub Actions run 9383806183 succeeded.
Hi @wookie184, I'm so sorry. I only got as far as starting to familiarise myself with the codebase to work on this issue and then it fell by the way-side. I've un-assigned myself from the issue.
[python-discord/king-arthur] New branch created: improved-system-resource-support
[king-arthur] Branch improved-system-resource-support was force-pushed to `2769800`
[python-discord/king-arthur] branch deleted: improved-system-resource-support
GitHub Actions run 9388319659 succeeded.
GitHub Actions run 9395811758 succeeded.
GitHub Actions run 9399307985 succeeded.
GitHub Actions run 9400729417 succeeded.
fe589c8 Update deployment to use infra repository - jb3
[python-discord/metricity] New branch created: jb3/deployment/infra-repo
Updates the deployment workflows to pull in the deployment.yaml file
from the infra repository in keeping with our other projects.
[python-discord/metricity] branch deleted: jb3/deployment/infra-repo
[python-discord/metricity] New branch created: reduce-memory-usage-on-startuyp
8ed588a Rename utils to syncer_utils for clarity - ChrisLovering
312a7bc Move channel & thread syncer to sync utils file - ChrisLovering
2f64b8d Add cog that syncs the guild on startup - ChrisLovering
32c6ec5 Use a generator isntead of a list to hold the m... - ChrisLovering
0863b4d Bump metricity version to 2.6.0 - ChrisLovering
[metricity] Branch reduce-memory-usage-on-startuyp was force-pushed to `9f3ec0d`
This PR also moves some code around to shared util functions, to reduce the size of the cogs themselves.
The only commit with actual new code is https://github.com/python-discord/metricity/commit/cc30e97ef5164bf1674da4f30698cb0e95041b4f
[metricity] Branch reduce-memory-usage-on-startuyp was force-pushed to `2284ec8`
[metricity] Branch reduce-memory-usage-on-startuyp was force-pushed to `a03c02c`
Untested, but looks good.
GitHub Actions run 9412132051 succeeded.
GitHub Actions run 9415343117 succeeded.
[python-discord/site] New branch created: mgmt-cmd-kill-db-cnx
a89fe54 add a management command to close all connections - shtlrs
We are experiencing SSL errors in site which we think are due to the abrupt shut down of the django app.
A potential solution is to close all the connections before shutting the server down.
This will work in conjunction with this infra PR
GitHub Actions run 9416300775 failed.
GitHub Actions run 9416853720 succeeded.
This doesn't, and cannot work, see my comment in infra.
I think we should close this. Sorry.
Yeah i noticed that once i had tested it, and was planning on changing the approach once you look at my suggestion in [devoops](#dev-oops message)
GitHub Actions run 9421410545 succeeded.
[python-discord/site] New branch created: jb3/deployment/gunicorn-from-docker
- Change
manage.pyto only be used for debug running of the site - Update Dockerfile to use the
gunicorncommand to run site in production - Update docker-compose for new local debug running
Hopefully, this will rectify some odd database issues we've been having related
to other application and database code being loaded before the first request is
hit, leading to errors on first request served by site after boot.
GitHub Actions run 9421874662 failed.
GitHub Actions run 9421900359 succeeded.
I will write and update the site with an init container in the deployment manifest at python-discord/infra once we merge this PR.
Would it be more convenient to have poetry run be the entrypoint?
That's a good call, updated in force push.
GitHub Actions run 9422463221 succeeded.
e8106f3 Update Dockerfile to use production run command - jb3
dc7237c Update docker compose to use new debug run command - jb3
602ad79 Update manage.py to handle solely running in de... - jb3
23087e9 Update taskipy start task to remove redundant -... - jb3
3698532 Merge pull request #1338 from python-discord/jb... - jb3
[python-discord/site] branch deleted: jb3/deployment/gunicorn-from-docker
GitHub Actions run 9422765454 succeeded.
currently HOME is set as home which is a relative path, which means for example when you use pathlib.Path.home() it gives you a relative path, which wont work correctly. The path should be absolute, i.e /home
(I am not too familiar with the codebase, but this seems to be the line it is set)
https://github.com/python-discord/snekbox/blob/d38694817cb5ee8481eb41a27b807fe97911d74c/config/snekbox.cfg#L21
this isnt really that big of a issue, but thought it worth to point out, as fo...
GitHub Actions run 9445476163 failed.
^^^^ just intermittent worker outage, not "real" failure
GitHub Actions run 9445476163 succeeded.
GitHub Actions run 9446443142 succeeded.
GitHub Actions run 9447032779 succeeded.
GitHub Actions run 9447985949 succeeded.
GitHub Actions run 9448229399 succeeded.
Connected!
GitHub Actions run 9448532465 succeeded.
Connected!
GitHub Actions run 9449423399 succeeded.
GitHub Actions run 9465643441 succeeded.
f5c6c45 Bump rapidfuzz from 3.9.2 to 3.9.3 (#3082) - dependabot[bot]
GitHub Actions run 9467862011 succeeded.
Connected!
GitHub Actions run 9467900386 succeeded.
GitHub Actions run 9467918224 succeeded.
Connected!
Connected!
GitHub Actions run 9467936568 succeeded.
GitHub Actions run 9467942394 succeeded.
GitHub Actions run 9467946247 succeeded.
Connected!
Connected!
GitHub Actions run 9467967579 succeeded.
GitHub Actions run 9467954758 was cancelled.
GitHub Actions run 9467973807 succeeded.
We only use this for more_itertools.chunked, but 3.12 has itertools.batched so I'm gonna remove this dep and use that instead.
Connected!
GitHub Actions run 9467981921 succeeded.
Connected!
GitHub Actions run 9467990972 succeeded.
[python-discord/bot] New branch created: use-itertools-batched
Does the same thing (except returning tuples instead of lists).
https://docs.python.org/3.12/library/itertools.html#itertools.batched
GitHub Actions run 9468081645 failed.
GitHub Actions run 9468124841 succeeded.
afba287 Add poetry-plugin-export plugin to fix CI warning - wookie184
[python-discord/sir-lancebot] New branch created: fix-poetry-export-warning
Noticed this warning https://github.com/python-discord/sir-lancebot/actions/runs/9467981921/job/26083317639#step:4:14
Warning: poetry-plugin-export will not be installed by default in a future version of Poetry.
In order to avoid a breaking change and make your automation forward-compatible, please install poetry-plugin-export explicitly. See https://python-poetry.org/docs/plugins/#using-plugins for details on how to install a plugin.
To disable this warning run 'poetry config warni...
GitHub Actions run 9469007114 succeeded.
5a6dfaf Update old redis version in docker-compose - wookie184
[python-discord/bot] New branch created: use-latest-redis
I don't think there are any particularly relevant changes, but the previous version was 4 years old.
We've been doing fine with just :latest on lancebot, so I think it's fine here too.
GitHub Actions run 9469536428 succeeded.
04ba2a9 Add poetry-plugin-export plugin to fix CI warning - wookie184
[python-discord/bot] New branch created: fix-poetry-export-warning
GitHub Actions run 9470072949 succeeded.
61ff035 Bump gitpython from 3.1.42 to 3.1.43 (#223) - dependabot[bot]
b398d4d Bump aiodns from 3.1.1 to 3.2.0 (#232) - dependabot[bot]
[python-discord/bot] branch deleted: use-latest-redis
c17d29a Bump furo from 2024.1.29 to 2024.5.6 (#230) - dependabot[bot]
[python-discord/bot] branch deleted: fix-poetry-export-warning
Connected!
GitHub Actions run 9471180851 was cancelled.
Connected!
GitHub Actions run 9471197776 succeeded.
873ed32 Bump pydantic from 2.7.1 to 2.7.3 (#234) - dependabot[bot]
7e95d3b Ignore RUF029, due to false positives and it no... - wookie184
Ignored RUF029, as was done on lancebot https://github.com/python-discord/sir-lancebot/pull/1538
dd4b987 Bump the ci-dependencies group across 1 directo... - dependabot[bot]
c2dd756 Fix site startup command used in docker-compose... - wookie184
[python-discord/bot] New branch created: fix-site-in-docker
Needed as entrypoint was changed in python-discord/site#1338
GitHub Actions run 9500169773 succeeded.
GitHub Actions run 9500209997 succeeded.
aa74e32 Fix site startup command used in docker-compose... - wookie184
[python-discord/bot-core] New branch created: fix-site-in-docker
Needed as entrypoint was changed in python-discord/site#1338
8403de0 Fix site startup command used in docker-compose... - wookie184
[python-discord/bot-core] branch deleted: fix-site-in-docker
dbc0ae2 Fix site startup command used in docker-compose... - wookie184
[python-discord/bot] branch deleted: fix-site-in-docker
Connected!
GitHub Actions run 9500769517 succeeded.
5a6dfaf Update old redis version in docker-compose - wookie184
04ba2a9 Add poetry-plugin-export plugin to fix CI warning - wookie184
0eace5f Merge pull request #3091 from python-discord/us... - wookie184
3dfd1e5 Merge branch 'main' into fix-poetry-export-warning - wookie184
07c88c7 Merge pull request #3092 from python-discord/fi... - wookie184
[python-discord/bot] branch deleted: use-itertools-batched
GitHub Actions run 9501267859 succeeded.
Connected!
GitHub Actions run 9501281954 succeeded.
GitHub Actions run 9519631067 succeeded.
@wookie184 thanks for the review and sorry for the long delay. I've updated the response format, the "sluggified" / "kebabified" version of the names can now be found in the slug field for the respective category, and the filter_slugs field for each filter. To be specific, filter_slugs[3] == to_kebabcase(slugs[3]). Let me know what you think.
ec869c7 Allow some bots through the GitHub Webhook Filter - jb3
[python-discord/site] New branch created: jb3/github-filter/allow-some-bots
This allows the Fast Forward bot and GitHub Actions scripts through the
webhook filter.
- Fast Forward bot should be allowed as otherwise any event created by
this bot (i.e. it's merges to main) are not reported into Discord as it
is considered a bot payload - GitHub Actions are generally things we have created ourselves and are
not normally high noise, and as such are also worth reporting
GitHub Actions run 9535677218 succeeded.