#dev-log

1 messages ยท Page 23 of 1

odd spireBOT
regal archBOT
#
jb3
[python-discord/bot] branch deleted: jb3/active-nomvote-thresholds
oak estuaryBOT
odd spireBOT
oak estuaryBOT
regal archBOT
regal archBOT
thin oysterBOT
#
Sir Robin

Connected!

regal archBOT
#
[python-discord/sir-robin] branch deleted: pass-exc-value-for-sentry
thin oysterBOT
#
Sir Robin

Connected!

regal archBOT
regal archBOT
#
[python-discord/sir-robin] branch deleted: fix-status-embed
night lilyBOT
#
Sir Lancebot

Connected!

thin oysterBOT
#
Sir Robin

Connected!

odd spireBOT
thin oysterBOT
#
Sir Robin

Connected!

oak estuaryBOT
regal archBOT
#
[python-discord/sir-lancebot] New branch created: improve-embed-action
odd spireBOT
regal archBOT
#
jb3
[python-discord/site] New branch created: jb3/user-props-store
#
jb3

This PR introduces a UserModSettings model to store properties related to
moderator preference that we currently store in Redis. This is part of a wider
scale effort to migrate away from Redis any data which would be anything more
than slightly annoying in the event it gets lost.

This will require bot side changes but it is not a breaking change to merge this
when it is ready. Some manual migration will be required to move the current
moderator settings from Redis into this new PostgreSQL ...

odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: improve-status-embed-action
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/sir-robin] New branch created: improve-status-embed-workflow
odd spireBOT
regal archBOT
#
[python-discord/branding] New branch created: improve-status-embed-workflow
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
#

It means that if a status-embed workflow is triggered while one is already running it will kill the old one before running the new one. So if you quickly but separately push multiple commits in sequence it will only post the status of the newest CI run*.

I mainly added for consistency as most other repos had it already.

*now that I think about it, it's a bit more complicated than this, since the CI workflow takes longer than the status_embed workflow. If CI is replaced with a new run, t...

regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/branding] branch deleted: update-ci-versions
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
oak estuaryBOT
regal archBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
oak estuaryBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
#

If we can make a decision on whether to guide the user to have python on their PATH, or just to have them use py, it would help to move this forwards.

I prefer getting the user to have python on ther PATH for the reasons I mention here https://github.com/python-discord/site/pull/773#discussion_r1160869869, so personally I'm quite happy with leaving the PR mostly as is, though I could make some of the changes to make py a bit more visible as an option.

regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
odd spireBOT
regal archBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] branch deleted: fix/source-command-for-tags
oak estuaryBOT
odd spireBOT
odd spireBOT
regal archBOT
#

I couldn't find a good way to phrase the sentence that could concisely and professionally tell everyone that this button is for everyone other than the reminder's author, so I decided to list the reminder mentions upfront to make it clear what the button will do. In exchange the embed might be considered a little verbose (until the button times out).

If others feel the embed is fine as it is and is not too verbose , then let's stick with it- but how about "Notify me too" or "Join reminde...

regal archBOT
#

7569771 Fix case sensitivity bug in phishing button - vivekashok1221
3996fa6 Update regex to discard trailing ')' and lowerc... - vivekashok1221
ea10480 Skip adding phishing button if user already banned - vivekashok1221
69bc65b Use regex to detect Discord invite link - vivekashok1221
d757301 Reference the /tag slash-command instead in tag... - hedyhli

#
[python-discord/bot] branch deleted: reply-to-eval
odd spireBOT
oak estuaryBOT
odd spireBOT
odd spireBOT
regal archBOT
#
jb3
[python-discord/bot] New branch created: jb3/nom-post-changes
#
jb3

This change moves us from posting multiple messages in the
nomination-voting channel to instead posting all entries into the voting
thread.

This makes the nomination process guaranteed to be contained within one
root message and one channel, instead of splitting into multiple
messages in the root if we went over the character limit.

It greatly simplifies both the creation and the archival of nomination
votes as we only need to handle one message.

It also means that all nominations are guar...

odd spireBOT
regal archBOT
#
jb3
[python-discord/site] New branch created: jb3/nominations/filter-on-reviewed
odd spireBOT
odd spireBOT
regal archBOT
#
jb3
[python-discord/bot] New branch created: jb3/nominations/relay-updates
#
jb3

If a nomination is actively being voted on and a staff member creates, updates
or attaches a message to their existing nomination we currently do not relay
that to the vote thread.

This PR relays any of these events to the vote thread so they are not lost.

This also allows moderators to use the message context menu command to attach
any relevant messages they find whilst reviewing into the active voting thread.

odd spireBOT
regal archBOT
#

If we added an api.get_active_nomination(user_id) -> Nomination | None function, I think this could be made a lot cleaner. I'd been thinking of suggesting that anyway as it'd be useful in quite a few other places as well.

        nomination = await api.get_active_nomination(nominee_id)
        
        if nomination and nomination.thread_id:
            log.debug(f"Found thread ID for {nominee_id} nomination, relaying new context.")
            thread = await get_or_fetc...
regal archBOT
#

The get_review command will need updating now that make_review returns another value:
https://github.com/python-discord/bot/blob/7437d98bfa8287a91857f860567efd748e38e438/bot/exts/recruitment/talentpool/_cog.py#L766
(I don't mind what you make the command do, or even if you want to remove it instead, I don't think it's that useful).

Not tested yet but looking pretty solid, thanks ๐Ÿ’ช

regal archBOT
#
jb3
[bot] Branch jb3/nominations/relay-updates was force-pushed to `7df00e0`
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/branding] New branch created: allow-events-crossing-years
#
jb3
[bot] Branch jb3/nominations/relay-updates was force-pushed to `e710d9f`
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#

Diff of the force-pushed changes.

diff --git a/bot/exts/fun/trivia_quiz.py b/bot/exts/fun/trivia_quiz.py
index 6041d031..d624e0fe 100644
--- a/bot/exts/fun/trivia_quiz.py
+++ b/bot/exts/fun/trivia_quiz.py
@@ -625,7 +625,7 @@ class TriviaQuiz(commands.Cog):
 
         for cat, description in self.categories.items():
             embed.description += (
-                f"- **{cat.capitalize()}**\n{description.capitalize()}\n\n"
+                f"- **{cat.capitalize()}**: {de...
#
[python-discord/sir-lancebot] branch deleted: fix/trivia-help-text
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: support-events-crossing-years
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
#
jb3
[bot] Branch jb3/nominations/relay-updates was force-pushed to `ded9db6`
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#
jb3

a21a971 Add new Nomination API filter to filter to acti... - jb3
5f2bf17 Add get_active_nomination API method for Talent... - jb3
ded9db6 Relay any creations or amendments to nomination... - jb3
c2b3e27 Merge pull request #3064 from python-discord/jb... - jb3

#
jb3
[python-discord/bot] branch deleted: jb3/nominations/relay-updates
oak estuaryBOT
odd spireBOT
regal archBOT
#
jb3
[python-discord/bot] branch deleted: jb3/nom-post-changes
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#

This might be kind of obvious but I feel it's still useful information to inlude.

There must be exactly 1 fallback event, and 0 or more non-fallback events. For single-day events, `end_date` must be equal to `start_date`. If `start_date` is a later day in the year than `end_date`, the event is interpreted as starting in one year and ending in the next. Both bounds are inclusive, and the format shown in the example above must be followed.
odd spireBOT
regal archBOT
#
[python-discord/branding] branch deleted: allow-events-crossing-years
#
[python-discord/bot] branch deleted: support-events-crossing-years
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] branch deleted: vivek/fix-eval-truncation
odd spireBOT
oak estuaryBOT
odd spireBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
regal archBOT
odd spireBOT
regal archBOT
#

6bd8cd1 Add a cog to manage tracking a user's alt accounts - ChrisLovering
98c7a2c Indicate if the user has alts when seaching for... - ChrisLovering
058146f Don't allow bots to be marked as alts - ChrisLovering
81ce2f4 Nicely format error when editing alts where tar... - ChrisLovering
9de7190 Output user alts in user command when ran in mo... - ChrisLovering

#
[python-discord/bot] branch deleted: feat/1353/alt-users
odd spireBOT
oak estuaryBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/sir-robin] branch deleted: improve-status-embed-workflow
thin oysterBOT
#
Sir Robin

Connected!

odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: vivek/warn-dm-fail
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: faster-silence-tests
#

Currently the tests for the !silence commands are pretty slow, taking up almost half of the execution time of the whole test suite.

This PR more than doubles the speed of pytest tests/bot/exts/moderation/test_silence.py (from >5s to <2s for me), resulting in the overall test suite being about 1/3 faster.

This definitely makes sense to look through commit by commit, as the commit descriptions explain each change.

odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: use-coverage-sysmon
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
jb3
[python-discord/bot] branch deleted: use-coverage-sysmon
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
odd spireBOT
regal archBOT
#

Description

Currently, only staff can use the .rp command in channels like #python-discussion. I propose we change it so any user can use it, as with the .topic command.

Reasoning

More than just mods can benefit from the command. It's a good way to link people to reliable articles for more in-depth information on various concepts. Non-staff members should still have the ability to give these articles if they think it's helpful.

Proposed Implementation

This functionalit...

regal archBOT
regal archBOT
#
[python-discord/king-arthur] New branch created: system-information-support
regal archBOT
regal archBOT
regal archBOT
regal archBOT
#
jb3
[python-discord/king-arthur] branch deleted: paginate-pod-logs
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
#

What should the command do?

The idea is us being able to execute specific actions on one of our netcup boxes.

For this to happen, a king-arthur user needs to be created on all of our boxes.
Then, using its own private key, KA can SSH into a particular box and execute a command from there.

I am not sure how to scope this in terms of commands/cogs, but i thought we could have a netcup cog which contains 2 commands

  1. a raw command, to allow flexivility of using any command we...
regal archBOT
odd spireBOT
regal archBOT
#

Description

I changed the uptime command to use a discord formatted timestamp, rather than formatting the start_time and sending it. This way you can see exactly when the bot started, in your own timezone.

In addition, I also added some small formatting to the ping command, so the gateway ping is show in a tiny codeblock like this.

Did you:

odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
#

Thanks for the contribution.

The change to the uptime command looks fine to me but i'm not sure about the change to the ping command.

The linting is also not passing, if you look at https://github.com/python-discord/sir-lancebot/pull/1542/files you can see the issues, and you can use poetry run task lint locally to lint locally (and poetry run task precommit to set up precommit which will automatically check before you commit).

night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
oak estuaryBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
#

There was a discussion about this a while ago, but it didn't reach a concensus. Starts here: #dev-contrib message

The argument was mainly that a lot of the responses from the command may not be relevant to the person being helped, so ideally the helper should have ensured that there is a particular helpful article shown in the response, in which case they can share it directly. For example, if someone just wanted to learn abo...

odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
#

I mostly see the rp command being helpful in cases that need more explanation and that aren't already in a short help tag. We do have a !lists command, and I think it explains enough. I do agree that it's not ideal for some results to be off the mark, but I don't see this as a huge issue, since the most that can happen is the embed just isn't helpful. It's currently not helpful at all to most users, so being helpful most of the time is still better in my opinion.

regal archBOT
regal archBOT
#
jb3
[king-arthur] Branch system-information-support was force-pushed to `3e942ba`
#
jb3
[python-discord/king-arthur] branch deleted: system-information-support
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/king-arthur] New branch created: improve-friendliness
#
[python-discord/king-arthur] branch deleted: improve-friendliness
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
regal archBOT
#
[python-discord/king-arthur] New branch created: system-software-interaction
#
[python-discord/king-arthur] branch deleted: system-software-interaction
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
oak estuaryBOT
#

Doc item doc_item.symbol_id='aiohttp.ClientSession' present in loaded documentation inventories not found on site, inventories may need to be refreshed.

regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
regal archBOT
#
[python-discord/king-arthur] New branch created: data-fix
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/king-arthur] New branch created: system-pleasure-emitting-module
#
[python-discord/king-arthur] branch deleted: system-pleasure-emitting-module
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#
jb3
[python-discord/king-arthur] New branch created: jb3/features/face-generator
#
jb3
[king-arthur] Branch jb3/features/face-generator was force-pushed to `a15c00c`
#
jb3

Add a new M-x face command to generate DevOps team compatible avatars given
uploaded files/attached URLs.

For several reasons, this command should not be opened wider than the DevOps
team:

  • It passes mostly untrusted URL data into ImageMagick
  • It allows for endpoints in cluster to be hit through arbitrary URL hitting
  • It runs things in a blocking context

For this reason, this command is only a bit of fun for DevOps role members and
should never be wider than that.

#
jb3
[king-arthur] Branch jb3/features/face-generator was force-pushed to `8f2c27f`
#
jb3
[king-arthur] Branch jb3/features/face-generator was force-pushed to `6db607b`
#
jb3
[king-arthur] Branch jb3/features/face-generator was force-pushed to `0db3b92`
regal archBOT
#
jb3
[python-discord/site] New branch created: jb3/monitoring/prometheus-db-metrics
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
#
jb3
[python-discord/site] branch deleted: jb3/monitoring/prometheus-db-metrics
odd spireBOT
regal archBOT
regal archBOT
#
jb3
[king-arthur] Branch jb3/features/face-generator was force-pushed to `236be7e`
regal archBOT
#
jb3
[python-discord/king-arthur] branch deleted: jb3/features/face-generator
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/king-arthur] New branch created: improved-system-resource-support
#
jb3
[python-discord/king-arthur] branch deleted: improved-system-resource-support
odd spireBOT
odd spireBOT
odd spireBOT
odd spireBOT
regal archBOT
#
jb3
[python-discord/metricity] New branch created: jb3/deployment/infra-repo
#
[python-discord/metricity] branch deleted: jb3/deployment/infra-repo
regal archBOT
#
[python-discord/metricity] New branch created: reduce-memory-usage-on-startuyp
odd spireBOT
regal archBOT
odd spireBOT
odd spireBOT
regal archBOT
#
[python-discord/site] New branch created: mgmt-cmd-kill-db-cnx
odd spireBOT
odd spireBOT
regal archBOT
regal archBOT
odd spireBOT
regal archBOT
#
jb3
[python-discord/site] New branch created: jb3/deployment/gunicorn-from-docker
#
jb3
  • Change manage.py to only be used for debug running of the site
  • Update Dockerfile to use the gunicorn command to run site in production
  • Update docker-compose for new local debug running

Hopefully, this will rectify some odd database issues we've been having related
to other application and database code being loaded before the first request is
hit, leading to errors on first request served by site after boot.

odd spireBOT
regal archBOT
#
jb3
[site] Branch jb3/deployment/gunicorn-from-docker was force-pushed to `887bd3d`
odd spireBOT
regal archBOT
regal archBOT
#
jb3
[site] Branch jb3/deployment/gunicorn-from-docker was force-pushed to `23087e9`
odd spireBOT
regal archBOT
#
jb3
[python-discord/site] branch deleted: jb3/deployment/gunicorn-from-docker
odd spireBOT
odd spireBOT
regal archBOT
#

currently HOME is set as home which is a relative path, which means for example when you use pathlib.Path.home() it gives you a relative path, which wont work correctly. The path should be absolute, i.e /home

(I am not too familiar with the codebase, but this seems to be the line it is set)
https://github.com/python-discord/snekbox/blob/d38694817cb5ee8481eb41a27b807fe97911d74c/config/snekbox.cfg#L21

this isnt really that big of a issue, but thought it worth to point out, as fo...

regal archBOT
odd spireBOT
mint goblet
#

^^^^ just intermittent worker outage, not "real" failure

odd spireBOT
odd spireBOT
odd spireBOT
odd spireBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
odd spireBOT
odd spireBOT
oak estuaryBOT
regal archBOT
odd spireBOT
regal archBOT
odd spireBOT
oak estuaryBOT
regal archBOT
night lilyBOT
#
Sir Lancebot

Connected!

regal archBOT
odd spireBOT
regal archBOT
night lilyBOT
#
Sir Lancebot

Connected!

oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
night lilyBOT
#
Sir Lancebot

Connected!

odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: use-itertools-batched
odd spireBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/sir-lancebot] New branch created: fix-poetry-export-warning
#

Noticed this warning https://github.com/python-discord/sir-lancebot/actions/runs/9467981921/job/26083317639#step:4:14

Warning: poetry-plugin-export will not be installed by default in a future version of Poetry.
In order to avoid a breaking change and make your automation forward-compatible, please install poetry-plugin-export explicitly. See https://python-poetry.org/docs/plugins/#using-plugins for details on how to install a plugin.
To disable this warning run 'poetry config warni...
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: use-latest-redis
odd spireBOT
regal archBOT
#
[python-discord/bot] New branch created: fix-poetry-export-warning
odd spireBOT
regal archBOT
#
[python-discord/bot] branch deleted: use-latest-redis
#
[python-discord/bot] branch deleted: fix-poetry-export-warning
oak estuaryBOT
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
regal archBOT
#
[python-discord/bot] New branch created: fix-site-in-docker
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
#
[python-discord/bot-core] New branch created: fix-site-in-docker
regal archBOT
#
[python-discord/bot-core] branch deleted: fix-site-in-docker
#
[python-discord/bot] branch deleted: fix-site-in-docker
oak estuaryBOT
odd spireBOT
regal archBOT
#
[python-discord/bot] branch deleted: use-itertools-batched
odd spireBOT
oak estuaryBOT
odd spireBOT
regal archBOT
odd spireBOT
regal archBOT
regal archBOT
#
jb3
[python-discord/site] New branch created: jb3/github-filter/allow-some-bots
odd spireBOT