6ec0877 Bump pre-commit from 3.6.0 to 3.6.1 (#2921) - dependabot[bot]
#dev-log
1 messages ยท Page 20 of 1
GitHub Actions run 7896670745 was cancelled.
Connected!
We have some high-quality articles over at /pages/ and I look forward to seeing more. However, as someone who has a fairly sound grasp of the organization and structure of the content as compared to a new user, I still struggle to navigate and discover more pages with ease. I often find myself stumbling upon pages I have not seen years before (despite themselves being present) as well as having troubles recalling the hierarchies of the content when ne...
GitHub Actions run 7897135745 succeeded.
a908b9a Migrate mailing lists to their own API endpoints - jchristgit
e0ccfe0 Bump ruff from 0.1.15 to 0.2.0 - dependabot[bot]
5cd802b Appeased the linter - Xithrius
e7b2b09 Merge pull request #1220 from python-discord/de... - ChrisLovering
ad2410e Merge branch 'main' into mailing-list-model - Xithrius
GitHub Actions run 7898373586 succeeded.
GitHub Actions run 7898415962 succeeded.
GitHub Actions run 7898493252 succeeded.
GitHub Actions run 7898591328 succeeded.
GitHub Actions run 7898700032 succeeded.
GitHub Actions run 7898765272 succeeded.
There are still a number of issues with the design, but I've run out of ideas on how to best solve them. So I'll mark this PR as ready for review now.
Added the secret to prod, just fix linting and we can get this merged
[python-discord/king-arthur] branch deleted: integrate-sentry
GitHub Actions run 7898987456 succeeded.
GitHub Actions run 7899516523 succeeded.
GitHub Actions run 7900877762 succeeded.
The entries
Our timeline was added following our 100K members milestone in PR #381. @ks129 suggested that we should dynamically load the timeline with YAML/Markdown files instead of using raw HTML, however it looks like we went ahead with the latter due to time constraints.
@ichard26 lead the...
GitHub Actions run 7905647410 succeeded.
Connected!
GitHub Actions run 7905653490 succeeded.
Connected!
After diving deeper into it, it turns out that it's a quirk of iOS/iPadOS + Safari. This SO question has a few solutions that worked perfectly for me:
https://stackoverflow.com/questions/18047353/fix-css-hover-on-iphone-ipad-ipod
- With javascript
<script>
document.addEventListener("touchstart", function() {},false);
</script>
- Add tabindex to body
<body tabindex=0>
- HTML ontouchmove
<html ontouchmove>
These are the only sol...
Why would you have to maintain it in 2 places ?
Reading this as it is is "painful" and one would need to squeeze their toughts in order to understand what's going on, and it isn't pleasant. Giving it structure would be more readable/intuitive/understandable.
Might be better to start enumerating from 1 using the start kwarg here
This currently doesn't take a None input into account.
If you have a look at the randomcase command, the bot will return a usage embed when a text isn't provided, so you should do the same here by exiting early and let the clean_text_or_reply raise a BadArgument exception
This function should not do the sending part, let it just clean the text & embed and return them as a tuple.
Also, the fun_cog in the function name is a redundant since it's a private function of the Fun cog.
GitHub Actions run 7930969996 succeeded.
Hey!
Thanks for the feedback. I've changed the name and the function now returns said tuple.
I'm struggling to put the BadArgument check in self._clean_text for some reason. I've now got the raise BadArgument added though and it's working. But I don't like the repeating of it.
GitHub Actions run 7933112786 succeeded.
Sorry I haven't seen these before.
One final sweep, and should be good.
Just a nit
cleaned_text, embed = await self._clean_text(ctx, text, conversion_func)
Since the function's name indicates "cleaning" rather than "converting"
If i'm not mistaken, it's the other way around where PascalCase should be pascalCase and CamelCase should be camelCase
So both docstrings & conversion functions need to be switched
same note here for the docstring about the pascal & camel case notation
There's a native way of doing this
word.capitalize() for word in text.split()
Cant believe I had them the wrong way around hey. Fixed in both files now xD
Closes #707 if approved.
(new PR because of branch)
Description
- Added 4 commands to fun.py to output a string in different cases to add to the already existing .randomcase
PascalCase, camelCase, snake_case, SCREAMING_SNAKE_CASE
.pascalcase aliases [.pascal .pcase]
.camelcase aliases [.camel .ccase]
.snakecase alias [.scase]
.screamingsnakecase aliases [.screamsnake .ssnake .screamingsnake] - Added a helper function in utils/helpers.py to attempt to strip a string of punctuat...
GitHub Actions run 7934618651 succeeded.
GitHub Actions run 7936667376 failed.
GitHub Actions run 7938081894 succeeded.
GitHub Actions run 7940893309 succeeded.
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
5abcfaf564897b10234799d924bf1e8ca7fc7034
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
7d9bde13815dac0b8b3a71ebb90597ab06e03b25
GitHub Actions run 7940940597 succeeded.
Looks good & works well, thanks!
[python-discord/bot-core] New branch created: document-bot-attributes
066a00a document the instance attributes of bot core - shtlrs
all_extensions (frozenset[str]): All extensions that were found within the ``module`` passed to ``self.load_extensions``. Use ``self.extensions`` to get just the loaded extensions.
Hey.
Can I take this one?
Sure, i've assigned you.
Closes #2613 after discussion in #2614
b0b758e document the instance attributes of BotBase - shtlrs
[python-discord/bot-core] branch deleted: document-bot-attributes
GitHub Actions run 7948391283 succeeded.
[python-discord/bot-core] New branch created: better-error-handling
9995d72 implement CommandNotFoundErrorHandler - shtlrs
8a52008 implement DefaultCommandErrorHandler - shtlrs
19fa760 register default and command not found error ha... - shtlrs
1fb3861 implement the MovedCommandErrorHandler - shtlrs
4ed6387 implement the handler for the UserInputError ex... - shtlrs
[python-discord/sir-lancebot] New branch created: use-botcore-command-error-manager
Closes #198
This is the first implementation of all the needed abstractions for the error handling in our bots.
All the necessary details will be found in the linked issue's description.
Part of this bot core issue
This acts as a demo of how error handling will be done in the bots.
This deflates the CommandErrorHandler from all the conditionals in place when it comes to error types.
Most importantly, it allows us to centralize error handling of both text and slash commands in one place, and reuse any necessary logic.
Note: We will make a beta release of the bot-core package to facilitate testing. In th...
GitHub Actions run 7951664923 failed.
Description
Add more trivia questions. Format is `- question - 'answer' or 'answer2' (note)
Science
- How much obsidian is required to craft an enchantment table? - '4'
CS
- Which Turing Award winner created a typesetting language based on Tex? - 'Lamport' or 'Leslie Lamport'
- What letter is used to separate date and time in ISO 8601? - 'T'
- HTTP/3 is built on which Transport Layer Protocol? - 'UDP'
- What algorithm yields accurate RTT measurements in TCP? - 'Karn' or...
GitHub Actions run 7955209606 succeeded.
GitHub Actions run 7955211018 succeeded.
GitHub Actions run 7955227592 succeeded.
GitHub Actions run 7955217433 was cancelled.
[python-discord/sir-lancebot] Pull request opened: #1460 Added "christmasify" avatar effect command.
Relevant Issues
Closes #937
Description
- Added "christmasify" command to add a Christmas touch to user's avatar.
- Currently has 2 effects - Room for future additions
- Make avatar chilly
- Add ornaments
Did you:
- [x] Join the Python Discord Community?
- [x] Read all the comments in this template?
- [x] Ensure there is an issue open, or link relevant discord discussions?
- [x] Read and agree to the [contributing g...
GitHub Actions run 7958108022 succeeded.
GitHub Actions run 7958115849 failed.
GitHub Actions run 7958122896 succeeded.
GitHub Actions run 7959194439 succeeded.
GitHub Actions run 7959200713 succeeded.
GitHub Actions run 7959207728 succeeded.
GitHub Actions run 7959212479 succeeded.
Connected!
GitHub Actions run 7959621003 succeeded.
Connected!
Connected!
GitHub Actions run 7960000315 failed.
[bot] Branch dependabot/pip/pydantic-settings-2.2.0 was force-pushed to `1c06ffe`
I've updated the config tests to make sure we can rely on the unit test upon bumping pydantic PRs
GitHub Actions run 7960062692 failed.
[bot] Branch dependabot/pip/pydantic-settings-2.2.0 was force-pushed to `68c4219`
GitHub Actions run 7960106957 succeeded.
bf8a1e5 ruff lint fix: Add trailing commas - ChrisLovering
6668505 ruff lint fix: Use a regular ssert instead of ... - ChrisLovering
7dcb962 ruff lint fix: Add explicit namespaces for pack... - ChrisLovering
9345fc7 ruff lint fix: Run remaining auto-fixable rules - ChrisLovering
5761b6a ruff lint fix: Manual non-breaking changes - ChrisLovering
[python-discord/bot-core] New branch created: Use-more-ruff-rules
This updated our ruff config to select all rules, and disable those I thought weren't useful.
The only breaking changes that I can see will affect our repos is the change to in_whitelist_check.
Draft release notes
Breaking Changes
All breaking changes are related to making boolean default and boolean-typed positional arguments in function definition keyword args only. The arg anmes and functions are listed below.
sync_app_commandsin `pydis_core.BotBase.load_extensions()...
[python-discord/bot-core] branch deleted: update-ruff
The trailing comma rule seems a bit intrusive, and not always relevant (for example after a **kwargs, but otherwise this looks good
GitHub Actions run 7969105295 succeeded.
The trailing comma rule seems a bit intrusive, and not always relevant (for example after a
**kwargs), but otherwise this looks good
Yea I can understand that. The linting rule likely makes more sense when used in combination with ruff format / black, as that impacts how they are formatted.
Do we want such a change ? the assertion methods offered by unittest do a lot more things than the native one. For instance, comparing lists is easier as it points out the difference between them, etc.
GitHub Actions run 7973672363 succeeded.
[python-discord/sir-lancebot] New review comment on pull request #1457: Add cases output in fun cog.
This doesn't seem to work very well for using text from a reply.
Consider this series of commands:
<img width="650" alt="image" src="https://github.com/python-discord/sir-lancebot/assets/50042066/55e9fc8b-e215-4ca7-8235-9c8914fe1d3e">
It works as expected. helloWorld gets converted to snake case, and back to camel case.
However, consider this example, where instead of using text provided as command arguments, replies are used instead:
<img width="650" alt="image" src="https://git...
[python-discord/sir-lancebot] New review comment on pull request #1457: Add cases output in fun cog.
A little nitpick-y, but let's capitalize the comments here as recommended by pep8.
# Return early if no text provided.
if not txt:
return None
# Take out punctuation
txt = re.sub(r"([^\w\s]|_)", " ", txt)
# Make full cap words lowercase but leave camelCase / PascalCase
words = [word.lower() if word.isupper() else word for word in txt.split()]
txt = " ".join(words)
# Attempt to split PascalCase and camelCase
words = []
...
I can see that pretty much all the functionalities are there, well done! I have a few comments.
[python-discord/sir-lancebot] New review comment on pull request #1457: Add cases output in fun cog.
There's quite a lot of potentially excessive " ".join and .split()s here.
Especially if you're going to opt for the solution in my first review comment, we're doing a .split immediately after a " ".join when neutralise_string returns.
One way we could improve this is to iterate over each word using an outer for-loop, before looping through each individual word like on line 26, and append to something like a new_words list. This removes the need of the .join call on line 21...
ca96322 Ensure messages returned for metricity data do ... - ChrisLovering
[python-discord/site] New branch created: fix-metricity-message-counts
The logic here was wrong due to the != requiring us to use negative logic.
GitHub Actions run 7975776476 succeeded.
[site] Branch fix-metricity-message-counts was force-pushed to `3bec3c3`
GitHub Actions run 7975837008 succeeded.
GitHub Actions run 7984249033 succeeded.
GitHub Actions run 7988919022 succeeded.
Connected!
GitHub Actions run 7989071555 succeeded.
Looks good to me. However, would've been great if there was a way to just get the date for the most recently uploaded file directly. I wonder how bad it would be if we'd just get the upload_time for the last element in the urls, and use the date+time from the API directly, without needing arrow.
[python-discord/sir-lancebot] Pull request opened: #1466 Added "christmasify" avatar effect command.
Relevant Issues
Closes #937
Description
- Added "christmasify" command to add a Christmas touch to user's avatar.
- Currently has 2 effects - Room for future additions
- Make avatar chilly
- Add ornaments
Did you:
- [x] Join the Python Discord Community?
- [x] Read all the comments in this template?
- [x] Ensure there is an issue open, or link relevant discord discussions?
- [x] Read and agree to the [contributing g...
So I've been trying to look for any notes regarding redis in the contributing pages and I came across this page:
https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/bot-extended-configuration-options/#with-the-bot-running-locally
There's a link to a heading "Working with redis" but there is no such heading on that page with that link. Only a "Starting redis using other methods" heading:
https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/bot-extended-con...
GitHub Actions run 7995339996 succeeded.
GitHub Actions run 7999926906 succeeded.
GitHub Actions run 8004197040 succeeded.
Connected!
GitHub Actions run 8011121825 succeeded.
Connected!
Connected!
GitHub Actions run 8011162596 succeeded.
GitHub Actions run 8011168562 failed.
GitHub Actions run 8011173344 succeeded.
Connected!
GitHub Actions run 8011243351 succeeded.
GitHub Actions run 8011247392 failed.
GitHub Actions run 8011260257 failed.
Connected!
Copying the files into the repo sounds good to me.
An alternative would be to use the the plugin but by extracting just the files we want manually rather than adding the plugin as an app, but I'm not sure exactly how that would work and still download/store lots of files from installing the module, so I think copying into the repo is probably the simpler and most efficient option.
[python-discord/bot] Pull request review submitted: #2927 Bump pydantic-settings from 2.1.0 to 2.2.0
I don't really understand the purpose of the added changes. What was wrong with the existing test? Why is the change in this PR? Why does whether it's running in CI need to be relevant to the test here?
I don't really understand the purpose of the added changes. What was wrong with the existing test?
The existing test dates back to when where we loaded the config from the yaml file, it's not relevant anymore
sections = (
cls
for (name, cls) in inspect.getmembers(constants)
if hasattr(cls, "section") and isinstance(cls, type)
)
This evaluates to nothing, so the test isn't doing anything.
Why is the change in this PR?
...
GitHub Actions run 8016027613 succeeded.
Thanks wookie.
I opted for all.min.css because I can't tell whether we would need the regular style as well in the future, and all.css would just include everything we are allowed to use for the free plan.
The latest FA release was added with only the required CSS/font files kept before force-pushing. I think it's safe to just include everything in webfonts since it's just a few files and we'll never know when we might use icons that need them.
e2388a6 Bump sentry-sdk from 1.40.2 to 1.40.3 (#1229) - dependabot[bot]
364824b Bump sentry-sdk from 1.40.3 to 1.40.4 - dependabot[bot]
44d5898 Merge pull request #1234 from python-discord/de... - Xithrius
570c4c0 Bump pre-commit from 3.6.0 to 3.6.1 - dependabot[bot]
c1cdcab Merge pull request #1230 from python-discord/de... - Xithrius
The existing test dates back to when where we loaded the config from the yaml file, it's not relevant anymore
Makes sense, thanks ๐
Because I wanted to test that pydantic loads variables correctly from the environment, not the env file. And I can't guarantee the value of an env variable on contribs machine if they ever run tests, which will cause a failure when such a variable doesn't exist :)
It's not ideal for a test to behave differently in CI versus locally. Can we use `os.e...
embed.set_footer(text=f"Latest release uploaded to PyPI on {upload_date}")
Thoughts on this to remove ambiguity of it referring to first release? Or do you think it's obvious?
This looks great :)
Where did you get ice_frame.png and ornaments_frame.png from? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version of ice_frame.png, currently it looks quite blurry.
it adds a blue hue to the img
This looks great :)
Where did you get
ice_frame.pngandornaments_frame.pngfrom? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version ofice_frame.png, currently it looks quite blurry.
It was just downloaded from google so i have no clue where the source actually is ๐
This looks great :)
Where did you getice_frame.pngandornaments_frame.pngfrom? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version ofice_frame.png, currently it looks quite blurry.It was just downloaded from google so i have no clue where the source actually is ๐
Reverse image search for ornaments_frame.png led me to [this](https://www.hiclipart.com/free-transparent-background-png-clipar...
This looks great :)
Where did you getice_frame.pngandornaments_frame.pngfrom? We need to make sure they're licensed appropriately so we can use them here. I also wonder if there's a higher quality version ofice_frame.png, currently it looks quite blurry.It was just downloaded from google so i have no clue where the source actually is ๐
Reverse image search for
ornaments_frame.pngled me to [this](https://www.hiclipart.com/free-transparent-bac...
Relevant Issues
Closes #1459
Description
Added questions to the trivia question json.
Did you:
- [x] Join the Python Discord Community?
- [x] Read all the comments in this template?
- [x] Ensure there is an issue open, or link relevant discord discussions?
- [x] Read and agree to the contributing guidelines?
GitHub Actions run 8026927556 succeeded.
GitHub Actions run 8027087975 succeeded.
Why not more concisely Released on {date}? It should be reasonably obvious that this represents the time when the "current upload" of that version was published. After all, this is what's displayed on the pypi website:
embed.set_footer(text=f"Released on {upload_date}")
And since we're modifying the text I'd like to add that explicitly stating "to PyPI" is somewhat unnecessary since it's a PyPI command. @GabeMillikan's suggestion also sounds reasonable to me.
GitHub Actions run 8033092612 succeeded.
@wookie184 I've closed this and Merged a new PR bump.
I'll update the tests in a separate PR
Connected!
I'm happy with the footer text to be just a Released / Uploaded + the date. However I do like to say that I added the "Uploaded to PyPI" after previous comments on that someone said it was unclear as to what it was uploaded. I do agree however that it's enough to just state "Released on <date>", so I will revert it back to that.
I'm running some tests to see if all are the same format, which I think it should be. It does seem however that not all versions are released on the same date. For now the only example I could find is pygame which has 2 different dates in the urls.
As far as I'm aware we can just skip the arrow by providing datetime.date objects:
return max(datetime.strptime(dist["upload_time"], "%Y-%m-%dT%H:%M:%S").date() for dist in data['urls'])
In which case comparing still works and the latest date...
Okay I did some digging. I think we can, and should, return the last element in the list. data["urls"][-1] is the top element on the downloads page. This will be the "source" distribution. Which is actually when the current version of the package was released. Later dates inside the urls are actually updated built distributions. So in either way, we'll need to use min() instead of max(), but as stated above I think this is unnecessary.
So I'm going with that and will await your feedba...
Just use the dedicated ISO-formatted field, which can be parsed natively with datetime.fromisoformat.
return min(datetime.fromisoformat(dist["upload_time_iso_8601"]) for dist in data["urls"]).date()
GitHub Actions run 8038169802 succeeded.
Yeah I found that later, thanks!
I've now switched away from the footer and utilising the discord timestamp together with the bot.utilts time.py
It should be here soon, would love your feedback. :)
GitHub Actions run 8038536262 succeeded.
GitHub Actions run 8039728654 succeeded.
GitHub Actions run 8041412777 succeeded.
GitHub Actions run 8044364837 succeeded.
Doc item doc_item.symbol_id='tutorial-toplevel' present in loaded documentation inventories not found on site, inventories may need to be refreshed.
!d r
Inventories refreshed
We should have a command to append to a nomination reason, when the current reason is okay and we just want to add information without repeating the entire reason. Like how we have !infraction edit and !infraction append.
The command should have a similar interface to the !talentpool edit reason command, with the only difference between the commands being how it changes the nomination reason.
We should have a context menu command for helpers to nominate users.
- The command will be available only to helpers.
- If the helper didn't nominate the user yet, a new nomination will be added, with the nomination reason being a jump link to the message the command was invoked on.
- If there is already an existing nomination from that helper for that user, the jump link will be appended to the nomination reason.
- Either way, the helper will be pinged with an appropriate confirmation ...
Connected!
GitHub Actions run 8060928929 was cancelled.
Connected!
GitHub Actions run 8064774961 succeeded.
I revisited this draft and incorporated the tag updates as per my previous suggestions. I've also condensed it for brevity.
Feedback from anyone interested in chipping in would be greatly appreciated!
Since the upload time provided by API is already in ISO 8601, we can just use min() on the upload_time_iso_8601 value and have it use string comparisons rather than with datetime, can't we?
However, I don't really know the differences between the distributions and why there's a difference in date.
Perhaps it's with the files being uploaded one by one during publishing, hence the delay of a few seconds between each. The last one, the source, as sorted alphabetically[^1], being up...
GitHub Actions run 8075827774 succeeded.
GitHub Actions run 8078781359 succeeded.
The following events' date should be updated:
| Event | New Date |
|---|---|
| Holi | 24/03 - 25/03 |
| Easter | 31/03 |
| Eid-ul-Fitar | 11/04 |
| Diwali | 31/10 - 1/11 |
Note: The given dates are exact dates
since we don't use exact date instead we extend the events date, so that should be done.
All the dates are picked up from Google Calendar, except the Easter is picked up from Wik...
4ef0731 Bump sentry-sdk from 1.40.5 to 1.40.6 (#2939) - dependabot[bot]
faee936 Bump sentry-sdk from 1.40.5 to 1.40.6 (#1468) - dependabot[bot]
Connected!
Connected!
GitHub Actions run 8107202787 succeeded.
Are we altering the interpreter at all? Breaking interactions with system Python tend to create dependency conflicts, which is the principle reason that we tend to dissuade individuals from utilizing the System Python installation.
I'd link to pyenv here for posterity.
- **Utilize [Pyenv](https://github.com/pyenv/pyenv) or Similar Tools:** Manage multiple Python versions and create isolated development environments for smoother workflows.
They may attempt to alter it by 'updating' it or deleting files and libraries they find unnecessary, both of which have already happened in PyDis.
Although the chances of it happening are significantly smaller than a simple dependency break, I don't see the harm in highlighting those risks as a stronger way to dissuade them from even trying.
That would be nice, yeah. I agree.
- **Critical Operation System Dependencies:** Altering the system Python installation may harm internal operating system dependencies.
GitHub Actions run 8115403517 failed.
Connected!
GitHub Actions run 8119879951 succeeded.
e14c819 Bump python-dateutil from 2.8.2 to 2.9.0.post0 ... - dependabot[bot]
GitHub Actions run 8119906662 was cancelled.
Connected!
Looks good and works well, just a few trivial comments.
[python-discord/sir-lancebot] New review comment on pull request #1457: Add cases output in fun cog.
The docstring would have to be updated to reflect the new function. Maybe the name too, up to you.
def split_words(txt: str | None) -> list[str] | None:
"""Neutralise all punctuation and cases and return a list of separated words."""
[python-discord/sir-lancebot] New review comment on pull request #1457: Add cases output in fun cog.
Consider making the variable name of the returned value more meaningful since the helper function was updated, and it's not immediately obvious that the text is actually a list here.
words = helpers.neutralise_string(text)
return "_".join(words)
Note that this also applies to the conversion_func for other case commands :)
[python-discord/sir-lancebot] New review comment on pull request #1457: Add cases output in fun cog.
@commands.command(name="screamingsnakecase", aliases=("screamsnake", "ssnake", "screamingsnake", "sscase"))
How about having a*case alias for all our case commands? It made sense to me during testing and was surprised it wasn't already added ๐
Sorry for the delay with reviews, this looks good to me!
Sorry for the delay here as well! This looks good to me! Thank you!
This is a good change. Thank you!
[python-discord/site] branch deleted: feat/font-awesome-plugin
I think these are fine fixes. Personally I would prefer ontouchmove since it seems to be pure HTML?
Sorry for the delay here, good catch!
[python-discord/site] branch deleted: fix-metricity-message-counts
Hmmm. I think it would make more sense to move the REDIS_USE_FAKEREDIS hint into the linked & missing section..?
Yes, I also prefer HTML solutions ๐
Seems like I forgot to add that, the second and third solutions included comes from this answer which also notes that:
TabIndex is the only one that works when Javacript is disabled.
The tabindex attribute is the standard way to make otherwise unresponsive HTML elements
:focus-ableand:hover-able.
-
Docker sets up "real" redis, so
REDIS_USE_FAKEREDISis only relevant to those that are not using docker, if I understand it correctly? If we remove that warning box entirely, users would need to click into the "Full environment variables" page to see information regarding redis set up.IMO, having a note on fakeredis there (like right now, but amended) lets people quickly set u...
IMO, having a note on fakeredis there (like right now, but amended) lets people quickly set up the development environment with the required env vars (such as redis ones) without needing to look into the full reference. What do you think?
I think that's a good idea :slightly_smiling_face:
For the Python bot I do agree it's fine to leave it as it is. Setting up Redis locally i...
Oh I was wondering about that, since ontouchmove sounded like it was something that invoked JS! I think tabindex is the best solution then, especially if it's the "standard way"
With the use of this command would we still funnel the full nomination content to the #nominations channel?
No plan to deprecate the text !nominate command, correct?
especially if it's the "standard way"
It's the standard way to do what it does, though I don't think it's any less hacky than the other solutions to solve this issue, since it's still not obvious why it fixes the issue (not a complaint about using it, just pointing it out).
My only question about using tabindex is if it has any other unwanted effects. It sounds like it should make the whole body of the page selectable through using tab, which doesn't sound ideal. In that case, `ontouc...
My only question about using tabindex is if it has any other unwanted effects. It sounds like it should make the whole body of the page selectable through using tab, which doesn't sound ideal.
I was also concerned about this, but during testing I wasn't actually able to see any visual effects of having the body selected.
That said, setting tabindex=-1 also fixes the problem, and makes it so it can't be s...
GitHub Actions run 8138929300 failed.
GitHub Actions run 8139908645 succeeded.
47168c7 ruff lint fix: Add explicit namespaces for pack... - ChrisLovering
9c8fbd7 ruff lint fix: Run remaining auto-fixable rules - ChrisLovering
ccd94c9 ruff lint fix: Manual non-breaking changes - ChrisLovering
4fd0b4d ruff lint fix: Breaking changes to make bool ar... - ChrisLovering
94f7d60 New ruff linting config - ChrisLovering
[python-discord/bot-core] branch deleted: Use-more-ruff-rules
[python-discord/bot-core] New branch created: breaking-deps-changes
This adds a few more breaking changes that I've wanted to do for a while since we're making a new major version.
- Drop Pydantic 1.X support. We had to use a deprecated function for backwards compat. It's been out long enough that I feel comfortable dropping support for it.
- Spliting fakeredis from the async-rediscache extra. This means that uses of this lib can install async-redis cache without having to install fakeredis, this allows for 3.12 support
- Drop support for 3.10. Suppor...
If this issue goes ahead, I'd like to be assigned to it.
GitHub Actions run 8147780618 failed.
[python-discord/branding] New branch created: update-events
Clsoes #204
See each commit's description for reasoning.
GitHub Actions run 8158058080 succeeded.
GitHub Actions run 8158089042 succeeded.
GitHub Actions run 8158155019 succeeded.
GitHub Actions run 8158720039 succeeded.
Connected!
GitHub Actions run 8170862964 succeeded.
GitHub Actions run 8172098618 succeeded.
GitHub Actions run 8183167680 succeeded.
GitHub Actions run 8186962768 failed.
GitHub Actions run 8198962959 succeeded.
GitHub Actions run 8201874553 succeeded.
Sorry for the delayed response. Yes, thank you!
@minalike We can funnel the full nomination content in the confirmation message. Yeah, let's do that.
@BruDriguezz assigned, let me know if there are any issues, thanks!
Connected!
GitHub Actions run 8210097750 succeeded.
Connected!
GitHub Actions run 8210108558 succeeded.
Connected!
GitHub Actions run 8210117099 succeeded.
Connected!
GitHub Actions run 8210173352 failed.
I will fix this in a couple hours
93f22d2 Bump rapidfuzz from 3.6.1 to 3.6.2 (#1470) - dependabot[bot]
Connected!
I'm okay with this. I think we can debate some of the wording a little bit, but ultimately I think it accomplishes the goal of succinctly answering the following:
"Why shouldn't I use the Python distributed with my OS?" and "What should I do instead?"
Technically installing a separate interpreter is done by Pyenv or similar tools, but I'm not sure engaging in that level of elaboration is going to make this any clearer to newcomers.
LGTM.
GitHub Actions run 8210499571 succeeded.
The current system that listens for GitHub links to format and post in a channel cannot handle URLs that point to a diff.
Supporting these types of links as well would allow for users to specifically demonstrate changes that occur in a series of commits, and also reduce future confusion on what kinds of links elicit a response from the bot.
GitHub Actions run 8216254947 failed.
This is a great idea. Approved.
As this is a decently large change, we have decided to consider this a project that Hedy has graciously accepted to take on as project lead.
d0d55c3 Bump sentry-sdk from 1.40.1 to 1.40.2 - dependabot[bot]
f48b05d Merge pull request #1227 from python-discord/de... - Xithrius
6cea888 Move resorce loading from view init() to AppCon... - RohanJnr
459d113 Update path variable in resource page tests - RohanJnr
88f2c27 Merge pull request #1228 from python-discord/re... - shtlrs
[python-discord/site] branch deleted: docs/suggest-resources
This is great, I've often found myself googling around for these links and how to do these things. Will definetely help in the future :)
f90b675 Resources: Add link to suggest new resources - hedyhli
774acbf Resources: Add guidelines on YAML files - hedyhli
e2388a6 Bump sentry-sdk from 1.40.2 to 1.40.3 (#1229) - dependabot[bot]
364824b Bump sentry-sdk from 1.40.3 to 1.40.4 - dependabot[bot]
44d5898 Merge pull request #1234 from python-discord/de... - Xithrius
[python-discord/site] branch deleted: docs/dark-theme-dev
GitHub Actions run 8221918520 succeeded.
GitHub Actions run 8221919098 was cancelled.
GitHub Actions run 8221929914 succeeded.
4d1ba10 Capitalize "Discord" in header; Change print st... - swfarnsworth
96038fd Rewriting of non-code sections. - swfarnsworth
36f1aa2 New tag to explain why == True et al are wrong. - swfarnsworth
ac3b8ae Bump regex from 2023.10.3 to 2023.12.25 (#2863) - dependabot[bot]
e136658 Bump rapidfuzz from 3.5.2 to 3.6.0 (#2865) - dependabot[bot]
GitHub Actions run 8224420880 was cancelled.
[python-discord/bot] Checks Failed on PR: #2864 Support reply as a message reference for !raw [json]
GitHub Actions run 8224422440 failed.
GitHub Actions run 8224468370 succeeded.
we should really get around to writing this as a d.py convertor in bot-core one of these days. This pattern seems to be used quite often now.
b2b89c1 Support reply as a message reference for raw co... - ichard26
[python-discord/bot] branch deleted: raw-reply
Connected!
GitHub Actions run 8228180937 succeeded.
GitHub Actions run 8228211809 succeeded.
[python-discord/bot] New branch created: update-config-tests
The old test relied on the old system where we loaded config from a yaml file, which ended up doing nothing.
GitHub Actions run 8228781724 succeeded.
Can re-use handler_name here.
Is it good practice to take a copy of a list that a function/class accepts as an argument? Especially since this class does indeed mutate the original list. If it makes a copy then this can be changed to Iterable as well.
Use {handler_name!r} instead of manually adding quotes
"determine" -> "get" to be terser
We can make it that it just accepts the handlers through the register_handler method only, WDYT ?
Definitely, I always forget to do that since there are no access modifiers.
This assumes if it's not one type then it must be the other. This is true now, but seems a bit error-prone in the case that a third type is added later. I dunno.
I agree, I just didn't think that such a type could be added especially when looking at the history of dpy.
How else would you have this done instead ?
b94786e Fix timeline icons for Summer Code Jam and AoC ... - hedyhli
[python-discord/site] New branch created: fix/timeline-icons
[python-discord/site] Pull request opened: #1255 Fix timeline icons for Summer Code Jam and AoC 2020
I found these two items on the timeline for which icons weren't showing up. This fix replaces the font awesome class to the most sensible replacement that I could find, which display correctly.

causes a change in behaviour.
I assume the behaviour we want is for the full message to be sent to the database, but the reason to be trimmed in the audit log (I assume because there's a limit there), but now it's also trimmed in the database.
_Originally posted by @wookie184 in https://github.com/python-discord/bot/pull/2316#discussion_r1439052748_
Screenshots of the new behaviour:
Check every type explicitly and have a catch-all else that raises an exception.
Yeah good thinking - I like that better.
I noticed there are a few more FA icons on our site that needs fixing, from looking at a deploy preview from before #1232 the issue might be from upgrading FA, from which incompatible classes we might've missed.
I think I'll just fix those as well in this PR together since I found them already.
GitHub Actions run 8246219411 succeeded.
GitHub Actions run 8249197980 succeeded.
GitHub Actions run 8264966603 succeeded.
Could we flip this, and make the default False, setting it to True when confirmed.
Shouldn't be an issue now, it jsut means that it fails safe if we have a bug around her ein teh future.
1d980c3 Bump azure/setup-kubectl from 3 to 4 (#2956) - dependabot[bot]
e24a9a1 Bump azure/setup-kubectl from 3 to 4 (#1475) - dependabot[bot]
Connected!
Connected!
GitHub Actions run 8275708297 succeeded.
GitHub Actions run 8276239990 succeeded.
GitHub Actions run 8276247386 succeeded.
Connected!
GitHub Actions run 8279364956 succeeded.
Connected!
[python-discord/snekbox] New branch created: 3.12.2-support
pyenv 2.3.36 added support for 3.12.2, it also happens to be the latest version as of writing.
I also bumped eval-deps up and reenabled yarl as multidict has 3.12 wheels now.
a6a8ccf Add dependabot config for docker & CI - ChrisLovering
[python-discord/snekbox] New branch created: add-dependabot
b4512e6 Bump the ci-dependencies group with 2 updates (... - dependabot[bot]
I'm a big fan of defensive programming, stgm. Thanks!
GitHub Actions run 8284766508 succeeded.
Untested, otherwise looks good to me
[python-discord/snekbox] branch deleted: 3.12.2-support
It's kind of annoying that the "lazy load" animation on the timeline doesn't work properly if you try to search for anything. Oh well. Thank you for the fixes.
GitHub Actions run 8286841776 succeeded.
There's a one-liner fix for that which just changes hidden items from visibility: hidden to opacity: 0. Further testing might be needed though.
The following test code:
!e ```py
with open(b"\xC3.txt", "w") as f:
f.write("test")
Snekbox fails with a (presumably non-exploitable) 500 error:
[FALCON] [ERROR] POST /eval => Traceback (most recent call last):
File "falcon/app.py", line 386, in falcon.app.App.call
File "falcon/app.py", line 1070, in falcon.app.App._get_body
File "falcon/response.py", line 270, in falcon.response.Response.render_body
File "falcon/media/json.py", line 179, in falcon.media.json.J...
GitHub Actions run 8291904512 succeeded.
GitHub Actions run 8291899464 was cancelled.
GitHub Actions run 8295864009 succeeded.
I'm bad at requesting reviews, apologies
GitHub Actions run 8304999372 failed.
GitHub Actions run 8305093794 succeeded.
Description
The bemyvalentine feature allows for valentines to either be secret/anonymous (sends the message to the selected user through DMs, without mentioning who it's from), or public by default (sends the message to #sir-lancebot-playground for everyone to see).
I would like for the non-secret mode to send valentines privately to the selected user in DMs, just like the secret mode.
The only difference would be that the valentine embed will include who the message is f...
f90b675 Resources: Add link to suggest new resources - hedyhli
774acbf Resources: Add guidelines on YAML files - hedyhli
212161c Add docs on Bulma, colors, dark mode, and CSS f... - hedyhli
ac57518 Fix pydis_site/README.md reference to static di... - hedyhli
364824b Bump sentry-sdk from 1.40.3 to 1.40.4 - dependabot[bot]
GitHub Actions run 8305652254 succeeded.
[python-discord/bot] New branch created: Continually-check-for-posts-that-need-to-be-closed
This PR adds a check that runs every 5 minutes to look for idle help channels and close them.
This is to cover the case where a Discord outage causes us to miss a help post creation.
I purposefully didn't use the discord.py task system here as this cog already has it's own scheduler and deals with closing all active tasks itself.
This PR also has two small changes to the help cog I noticed while writing & testing this PR.
Sentry Issue: BOT-3QY
Forbidden: 403 Forbidden (error code: 40058): Cannot message this thread until after the post author has sent an initial message.
(3 additional frame(s) were not displayed)
...
File "bot/bot.py", line 64, in on_error
await handle_forbidden_from_block(e_val, message)
File "bot/exts/help_channels/_cog.py", line 147, in on_thread_update
await _channel.help_post_archived(after...
GitHub Actions run 8306069914 succeeded.
[bot] Branch Continually-check-for-posts-that-need-to-be-closed was force-pushed to `a59cb68`
GitHub Actions run 8306094571 succeeded.
[bot] Branch Continually-check-for-posts-that-need-to-be-closed was force-pushed to `2d23a90`
GitHub Actions run 8306199149 succeeded.
Connected!
595fc72 Bump sentry-sdk from 1.41.0 to 1.42.0 - dependabot[bot]
af55ef4 Merge pull request #1256 from python-discord/de... - Xithrius
c729e62 Bump pymdown-extensions from 10.7 to 10.7.1 - dependabot[bot]
74110ee Bump django-filter from 23.5 to 24.1 - dependabot[bot]
576494a Merge pull request #1253 from python-discord/de... - jchristgit
GitHub Actions run 8317610516 succeeded.
b94786e Fix timeline icons for Summer Code Jam and AoC ... - hedyhli
8b9b929 Fix FA icons in Code Jam pages - hedyhli
d79ce73 Fix resources project-ideas FA icon - hedyhli
850bcf4 Merge branch 'main' into fix/timeline-icons - hedyhli
f9ceead Merge branch 'main' into fix/timeline-icons - ChrisLovering
[python-discord/site] branch deleted: fix/timeline-icons
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
I get the following error when my test account that I muted rejoins the server (while the timeout is still active) because member.is_timed_out() is True and hence reason is not assigned a value:
bot-1 | File "/bot/bot/exts/moderation/infraction/infractions.py", line 664, in action
bot-1 | await member.edit(timed_out_until=arrow.get(active_timeouts[0]["expires_at"]).datetime, reason=reason)
bot-1 | ...
Sorry for the late review, I was teaching my houseplants Morse code. Please forgive.
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
This line triggers an IndexError whenever a user without an active timeout infraction joins the server.
I didn't take an in-depth look at the code because I more-so care how it presents (and html is only so interesting). Overall, I love it! It presents what we do really well and is really and easily digestible.
Thank you so much for your work on this.
With Discord supporting scheduling events natively, I'm going to close this issue. For our bigger events, we'll still post them on our website. But the smaller ad-hoc ones can be run entirely on Discord with the native functionality now. If you're reading this and interested in running a smaller ad-hoc event, talk to Kat in the server.
a9dd0d2 Bump sentry-sdk from 1.26.0 to 1.27.0 (#2664) - dependabot[bot]
5e1a695 Bump lxml from 4.9.2 to 4.9.3 (#2668) - dependabot[bot]
7abd265 Undo sentry update - wookie184
e1157aa Merge pull request #2671 from python-discord/un... - mbaruh
b3ce995 Bump ruff from 0.0.275 to 0.0.277 (#2667) - dependabot[bot]
GitHub Actions run 8318603940 succeeded.
GitHub Actions run 8318693971 succeeded.
GitHub Actions run 8324145644 succeeded.
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
Good find, both were fixed in the force push
I think people tend to jump on breaking changes more than other ones, which makes me wonder whether it's a good idea to mention that we're splitting them in order to allow for python support here.
[python-discord/bot-core] branch deleted: breaking-deps-changes
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
Doesn't this overlook users whose timeout duration was edited while they were not present on the server but are still under a timeout when they rejoin the server? Once they rejoin the server, they will still be under the old timeout duration and not the new edited duration.
b94786e Fix timeline icons for Summer Code Jam and AoC ... - hedyhli
8b9b929 Fix FA icons in Code Jam pages - hedyhli
d79ce73 Fix resources project-ideas FA icon - hedyhli
850bcf4 Merge branch 'main' into fix/timeline-icons - hedyhli
f9ceead Merge branch 'main' into fix/timeline-icons - ChrisLovering
GitHub Actions run 8325224421 succeeded.
Would it be better to use EnvConfig from our constants.py here (overwriting env_file)? That way we're testing how our constants actually get loaded, rather than relying on updating this file if we change that in the future.
[python-discord/bot-core] branch deleted: better-error-handling
[python-discord/bot-core] New tag created: v11.0.0
GitHub Actions run 8326635846 succeeded.
[sir-lancebot] Branch use-botcore-command-error-manager was force-pushed to `fd6490c`
[sir-lancebot] Branch use-botcore-command-error-manager was force-pushed to `9d330d0`
GitHub Actions run 8326986159 failed.
GitHub Actions run 8327509448 failed.
GitHub Actions run 8327570705 succeeded.
GitHub Actions run 8331521615 failed.
Connected!
[python-discord/site] New branch created: fix/timeline-liechtenstein
f139622 Timeline: Fix Liechtenstein postcard image - hedyhli
The discord link which we've previously used stopped working for me, I've switched it to the raw github link from our branding repo instead.
GitHub Actions run 8339386326 succeeded.
Looks good! With Discord's new security and expirations for CDN links, we should look at changing all CDN links we use to something else.
f1d3a72 Timeline: Fix Liechtenstein postcard image (#1261) - hedyhli
[python-discord/site] branch deleted: fix/timeline-liechtenstein
GitHub Actions run 8341717397 failed.
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
Shouldn't we always use the expiry from the database?
With your current approach, if a moderator reduces the timeout duration, the infraction log will display the new duration. However, when the user rejoins the server, the old (original) longer timeout duration will be applied.
I've noticed something that could warrant it's own issue. When attempting to unmute a user who left the server, the bot will reply that the it has failed to pardon the infraction since the user has left the server. However, it will also mark the infraction as inactive in the db. This means that once the user rejoining, someone will have to manually remove the timeout.
GitHub Actions run 8342730426 succeeded.
GitHub Actions run 8343983836 failed.
GitHub Actions run 8343983836 succeeded.
GitHub Actions run 8343983836 succeeded.
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
I'm not on a streak this period of the year...
You're right, I'll fix that.
GitHub Actions run 8351464608 was cancelled.
GitHub Actions run 8351467652 succeeded.
I've noticed something that could warrant its own issue. When attempting to unmute a user who left the server, the bot will reply that the it has failed to pardon the infraction since the user has left the server. However, it will also mark the infraction as inactive in the db. This means that once the user rejoins, someone will have to manually remove the timeout.
Yes, i think this should be dealt with in a separate issue.
GitHub Actions run 8351479886 succeeded.
This has been originally raised by @vivekashok1221 here
The current scenario is this
Scenario
- A user is muted for 4 days
- The user leaves the server
- Someone with the right perms pardons the unmute
- The user rejoins the server
Problem
Step 3 will only pardon the infraction in our database, but the native discord timeout will still remain in place since we cannot edit that when a user is ...
Is the idea to display entire diffs, or only selected lines in the diff? If it's the entire diff, I think it'd often be too long to fit in a message. Only displaying selected lines could work, though I've found GitHub's UI for selecting/viewing specific lines in diffs isn't as good as for normal files, and (the reason I mention this) this seems potentially quite difficult to implement, given how the GitHub UI lets you select using line numbers from both things being compared.
I think it wo...
@zeptofine it was alright, you can reopen it if you're still interested in this.
Currently if someone uses the wrong symbol a different message should be sent indicating that they're using the wrong symbol.
The trade-off here depends on how many people use the wrong symbol when seeing the current message. If it's most people than this change would be worth it. If it's only a few people then it might be better to keep the message shorter and accept that in a few cases they'll need the se...
GitHub Actions run 8358789986 succeeded.
GitHub Actions run 8359858089 succeeded.
LGTM :star2: :1st_place_medal:
I do have a minor comment but I'm fine with merging this PR as it is.
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
The only thing I miiiiight change would be to check if member.timed_out_until is not same as the expiry time in the database before applying the timeout. This could potentially save an API call in the handful of scenarios when a user under a timeout rejoins the server and the timeout duration is unchanged (although, it is more likely that in the event a timed-out user does rejoin the server, the duration has not been edited).
Again, this case does not happen that often, and even if it...
Connected!
[sir-lancebot] Branch use-botcore-command-error-manager was force-pushed to `832acb1`
GitHub Actions run 8363935494 succeeded.
I'll squash the implementation commits along with the fixup one once the PR is ready to be merged.
da7a6d2 extract original error upon exceptions, if any - shtlrs
[python-discord/bot-core] New branch created: preserve-original-command
Discord py wraps errors in a CommandInvokeError instance, which hides the original error and results in only having the default error handler being invoked.
b6a888d Extract original error upon exceptions, if any ... - shtlrs
[python-discord/bot-core] branch deleted: preserve-original-command
[python-discord/bot-core] New tag created: v11.0.1
Connected!
GitHub Actions run 8366753349 succeeded.
[sir-lancebot] Branch use-botcore-command-error-manager was force-pushed to `5c610e0`
GitHub Actions run 8368562841 succeeded.
GitHub Actions run 8370045315 succeeded.
GitHub Actions run 8370353713 succeeded.
GitHub Actions run 8370471899 failed.
GitHub Actions run 8373721624 succeeded.
Connected!
GitHub Actions run 8374047555 succeeded.
GitHub Actions run 8375161049 succeeded.
GitHub Actions run 8375271182 succeeded.
Connected!
GitHub Actions run 8375764848 succeeded.
[sir-lancebot] Branch use-botcore-command-error-manager was force-pushed to `6f8a5b1`
GitHub Actions run 8375790935 succeeded.
GitHub Actions run 8375801652 succeeded.
Connected!
[python-discord/bot] New review comment on pull request #2839: Support editing of timeout durations.
I'll accept this only because your houseplants are talking good of you about your Morse code teaching methodology.
Implemented here
GitHub Actions run 8376194105 succeeded.
Connected!
92fc4b9 New Tag: "Avoid System Python for Development" ... - BruDriguezz
cefc328 Bump tldextract from 5.1.1 to 5.1.2 (#2962) - dependabot[bot]
[python-discord/bot] branch deleted: update-config-tests
GitHub Actions run 8376960269 was cancelled.
GitHub Actions run 8376962892 was cancelled.
Connected!
100c984 Bump rapidfuzz from 3.6.1 to 3.6.2 (#2945) - dependabot[bot]
f726584 Bump Azure/k8s-deploy from 4 to 5 (#1263) - dependabot[bot]
Connected!
GitHub Actions run 8377042001 succeeded.
GitHub Actions run 8377022938 was cancelled.
GitHub Actions run 8377077613 failed.
GitHub Actions run 8379148026 succeeded.
Connected!
Bulma v1.0.0 is here! ๐
https://bulma.io/documentation/start/migrating-to-v1/
A number of useful features were introduced that benefit us directly.
This means most, if not all...
- limitations described in #1176 (on the CSS side),
- warnings/tips documented in #1231, and
- the hardcoded colors throughout the code base...
...are no longer necessary once we upgrade.
Note though, we're still blocked by lemonsaurus/django-simple-bulma#100 if we decide to do this.
Overview o...
GitHub Actions run 8385428040 succeeded.
Connected!
A little update on this issue:
-
[x] How to suggest a new resource for inclusion (done in #1226)
-
[x] How to implement a new resource. What files need to be edited, and how? (done in #1226)
-
[ ] The review process for a new resource. Who reviews and approves these suggestions?
@swfarnsworth has [mentioned](#organisation message) they'll work on this once they've wrapped up the year-end survey project.
2f9f99d Fix broken Bulma logo in the footer - hedyhli
[python-discord/site] New branch created: fix/footer-bulma-logo
It looks like Bulma updated their links to their brand assets.
GitHub Actions run 8385812871 succeeded.
GitHub Actions run 8386064397 succeeded.
b72f457 Use proper logos and better positioning in the ... - hedyhli
[python-discord/site] New branch created: fix/footer-logo-filtering
Closes #662, and as part of it, also closes #458.
Changes
Footer logos and positioning:
- Switch from CSS filtering to actual logos with white text.
- Adjust positioning to align all text in the logos with baseline and ensure they're center aligned with a uniform side spacing.
GitHub Actions run 8387132477 succeeded.
GitHub Actions run 8387442338 succeeded.
GitHub Actions run 8389222068 failed.
@RohanJnr Do you remember the context of why we needed to implement this ?
Is this something you think you're going to finish or shall we clean it up/close it ?
Connected!
@mbaruh I see that we have the same FilterListViewSet registered under two different routes, which creates a namespace collision upon registration since we're not specifying a basename for the route which leads to DRF extracting a basic one based on the viewset's class name.
Having looked at the bot code, I don't see the /bot/filter-lists route being used, shall we just remove it then ?
Both Python and Sir-Lancebot have the ext command that allows to load/unload/list extensions.
The code is currently duplicated, and seems fit to be ported to bot-core as all bots could use that feature to have access to the same information about the different extensions' status.
[python-discord/sir-lancebot] New branch created: cleanup-constants
Closes #527
This removes some constants that were burried over the years, and reuses some constants that have been duplicated
GitHub Actions run 8391593811 succeeded.
Closing this since :
- the bot paginator has been ported to botcore and used here
- running the command doesn't raise any exceptions.
We've discussed this internally before, and I remember us not really liking the looks of the buttons.
In any case, the paginator is now a bot-core component, so I'll close this issue here.
[bot] Branch bug/2464/truncate-snekbox-blocked-exts was force-pushed to `37c5e93`
GitHub Actions run 8396361518 succeeded.
GitHub Actions run 8398377920 succeeded.
GitHub Actions run 8398686495 succeeded.
GitHub Actions run 8398704669 succeeded.
Connected!
What are our thoughts with this issue now that we use the forum-based help threads?
It was requested in [#community-meta](#community-meta message) recently, and @swfarnsworth also brought it up [internally](#organisation message).
Discord forums supports tracking your own thread natively so it's now less needed as it was when we used the dynamic help-channels...
This feature is now implemented by:
- #2117
- For: #2079
I believe this issue can be closed.
With a new design for our events page (#1210), weโll have to update our events page more often to keep it up-to-date. We need a way to minimize the efforts and friction for this redundant work by automating it in some way.
_Note: The problem this proposal tries to solve comes from the design of the new events page, for which PR is not yet merged, but in the event of that feature not ending up getting to production, I believe some ideas presented here can still be useful regardless of w...
Is this issue approved? If so, I'd be interested in working on this.
I made a quick prototype using the UI interaction button (similar to .bm), which will not support opt-outs at all.
<img width="550" alt="image" src="https://github.com/python-discord/bot/assets/50042066/69e75d5d-94c9-4f55-bb1c-b0c2170ab36e">
However, using reactions as originally proposed lets the original author see who also opted-in to be notified. With this approach we'd have to perhaps have it edit the original ...
Ideally, we would want to check for the command arguments against the list of valid filters (see the above linked issue - or python-discord/site#710). So once we have that endpoint on the site, we can then add in the "Resources for: <topic>" if the argument is a valid topic, and just the current normal "Resources" title otherwise.
Yes, you can start working on it.
We should probably be moving away from using reactions; the button is better UX. I don't think the ability to see who else added themselves is important; editing the message with the new count is sufficient, but I do not consider that a strict requirement.
We will have to keep in mind the limits on how many people can be mentioned.
[python-discord/bot] New branch created: codeowners
Updated CODEOWNERS via removing users that are no longer active on this repo.
[python-discord/site] New branch created: codeowners
Updated CODEOWNERS via removing users that are no longer active on this repo.
[python-discord/site] branch deleted: codeowners
[python-discord/bot] branch deleted: codeowners
4f655ff Removed inactive users from CODEOWNERS (#1485) - Xithrius
[python-discord/sir-lancebot] branch deleted: codeowners
Connected!
Connected!
Connected!
Yes, all mentions are pinged as message content together with the reminder embed sent publicly:
<img width="460" alt="image" src="https://github.com/python-discord/bot/assets/50042066/c527306a-349e-47d9-b94a-deee7fa492db">
So the mention limit will just be the 2000 character limit, counting all mentions to be in the <@ID> form. On average, the character limit might be exceeded with >90 different people click on the button to get mentioned, if I'm not mistaken.
GitHub Actions run 8404705259 succeeded.
GitHub Actions run 8404715108 failed.
GitHub Actions run 8404725994 succeeded.
GitHub Actions run 8404721051 succeeded.
GitHub Actions run 8404736323 succeeded.
GitHub Actions run 8404918687 succeeded.
I agree hedy.
IMO both the help-dm system, and the notifications when you open a new help channel can be deleted.
The forum channel solves both issues that the old system had that are the reasons for these features existing.
I agree that we can just delete this functionality.
[python-discord/sir-lancebot] New branch created: python-3.12
Relevant Issues
Description
This bumps lance up to Python 3.12.
Did you:
- [ ] Join the Python Discord Community?
- [ ] Read all the comments in this template?
- [ ] Ensure there is an issue open, or link relevant discord discussions?
- [ ] Read and agree to the contributing guidelines?