efd6c47 Bump rapidfuzz from 3.1.1 to 3.1.2 (#2689) - dependabot[bot]
d66c6de Bump deepdiff from 6.3.0 to 6.3.1 (#2673) - dependabot[bot]
a171406 Bump ruff from 0.0.277 to 0.0.280 - dependabot[bot]
3007011 Ignore RUF015 linting rule - ChrisLovering
9aa28c8 Remove unused noqa directive - ChrisLovering
#dev-log
1 messages ยท Page 17 of 1
GitHub Actions run 6371609147 succeeded.
Perhaps we could use this utility function? Suggested by @TizzySaurus
or has_any_role_check(ctx, constants.Roles.helpers)
has_any_role_check would need to be imported from bot.utils.checks import has_any_role_check
+1 for @Robin5605 's suggestion but LGTM
If that solves the "The implementation is a bit fragile as it depends on short-circuiting ..." problem, then I support it.
I'm going to refactor and push another commit--do not merge yet.
GitHub Actions run 6372044111 succeeded.
if user_is_op or user_is_staff:
await ctx.channel.edit(name=title)
I think not using a negative here makes the intent clearer
Closes Issue #2760.
The !raw command has been restricted to only prefix command usage since inception, and has not been touched since. With the introduction of new interfaces for executing commands (i.e. application context menus) and the inconvenience of copying message links to check their raw content, this pull request hopes to simplify the process by adding a context menu button for users to click.
GitHub Actions run 6372839156 failed.
b1b5dc4 Merge pull request #1104 from python-discord/no... - jchristgit
2229d01 Bump cryptography from 41.0.3 to 41.0.4 - dependabot[bot]
6bb6cfe Merge pull request #1112 from python-discord/de... - Xithrius
b305c8f Bump ruff from 0.0.290 to 0.0.291 - dependabot[bot]
3822f2d Merge pull request #1114 from python-discord/de... - Xithrius
[python-discord/site] branch deleted: remove-the-redirect-filter-list
GitHub Actions run 6372962860 succeeded.
GitHub Actions run 6373205252 failed.
I think this function should be simplified into just a function that accepts a message, and returns a str or list[str] (to accommodate for pagination). Accepting both a Context and Interaction feels a bit janky in my opinion.
async def _raw_context_menu_callback(self, interaction: discord.Interaction, message: discord.Message) -> None:
Needs to accept a message argument in order to be classified as a message context menu
This has already been fixed in a commit downstream. I was just writing a placeholder for the time.
I didn't feel quite the same way at first, but due to other reasons, this route of implementation is frankly garbage. I'll be moving the message sending responsibilities to the... overlying(?) methods.
I'll be moving the message sending responsibilities to the... overlying(?) methods.
That sounds like a good idea, now that we have two different methods that send the message in two different ways (normal!rawcommand and context-menu command. Former needs to usectx.sendwhile the latter needs to useinteraction.response.send_message). It would make sense to practice principle of least responsibility here and have one function that's just responsible for fetching the raw content.
GitHub Actions run 6378745124 succeeded.
[python-discord/bot] New branch created: remove-cooldown-role
This PR is an alternative to https://github.com/python-discord/bot/pull/2772 and is in discussions (internally) here
GitHub Actions run 6378807304 succeeded.
i would like to work on this
5ff7561 Bump arrow from 1.2.3 to 1.3.0 (#1376) - dependabot[bot]
Connected!
Marking as do not merge until internal discussions are complete, please feel free to do a code review though.
GitHub Actions run 6379879210 succeeded.
GitHub Actions run 6380365417 succeeded.
A few people have said that this is something that we want. Removing the do not merge label.
GitHub Actions run 6382987576 succeeded.
GitHub Actions run 6383700108 failed.
GitHub Actions run 6383958969 succeeded.
I've pushed some new changes that made send_raw_content only fetch and return a Paginator object instead. Feel free to take a look at the new commits while I go fix the tests. I think they're borked with the ContextMenu being there now.
Er, take that back. Tests passed with flying colors, haha!
d85a009 Use 3.12.0 over 3.12.0rc2 for 3.12 support - ChrisLovering
a218ccc Use 3.12.0 by default - ChrisLovering
32bb655 Replace 3.11 support with 3.13-dev - ChrisLovering
b5c7884 Update eval-deps markers for new Python versions - ChrisLovering
3da229c Bump all eval-deps to latest versions - ChrisLovering
[python-discord/snekbox] New branch created: python-3.12
This PR does a few things:
- Removes 3.10 & 3.11 in favour of 3.12 and 3.13-dev
- Use Python 3.12 as the default eval version
- Update eval-deps to support the two new versions of Python
- Bump all eval-deps to latest
- Removes the
tomldep from eval-deps as it is now part of the stdlib
GitHub Actions run 6385717158 succeeded.
GitHub Actions run 6386826478 succeeded.
GitHub Actions run 6386908386 succeeded.
GitHub Actions run 6386939310 succeeded.
Connected!
Connected!
GitHub Actions run 6387514307 succeeded.
Connected!
GitHub Actions run 6387623177 succeeded.
[python-discord/snekbox] branch deleted: python-3.12
d85a009 Use 3.12.0 over 3.12.0rc2 for 3.12 support - ChrisLovering
a218ccc Use 3.12.0 by default - ChrisLovering
32bb655 Replace 3.11 support with 3.13-dev - ChrisLovering
b5c7884 Update eval-deps markers for new Python versions - ChrisLovering
3da229c Bump all eval-deps to latest versions - ChrisLovering
GitHub Actions run 6388291209 succeeded.
GitHub Actions run 6388888353 failed.
182437b Update all references of 3.11 in eval to 3.12 - ChrisLovering
[python-discord/bot] New branch created: update-references-of-3.11-eval-to-3.12
[bot] Branch update-references-of-3.11-eval-to-3.12 was force-pushed to `0562ec0`
snekbox now runs 3.12 by default, so the user output should reflect that.
Once snekbox support multiple versions, version detection will be done programmatically based on snekbox's response.
GitHub Actions run 6390330421 succeeded.
The snekbox Dockerfile now installs both 3.12.0 and 3.13-dev to /lang/python/<version>.
There is also /lang/python/default which is a symlink to /lang/python/3.12/ which is what snekbox currently uses for eval.
Now we need to update snekbox's API to support multiple versions. The following is my opinion on how to do that.
A new endpoint GET /versions is added, which returns all versions snekbox supports. The response body would include the name, a human friendly name, and wheth...
GitHub Actions run 6391962861 succeeded.
GitHub Actions run 6392296634 succeeded.
GitHub Actions run 6392679654 succeeded.
GitHub Actions run 6396022742 succeeded.
I have identified the issue, it's due to the whitespace property of a.dropdown-item
Simple fix:-
- Remove the whitespace:no-wrap property however that would cause the menu item to look like the ss below
If the options needs to be in a single line then multiple CSS properties would need to be changed I imagine as I could not get it to work by playing around with some of the element properties only
<img width="1355" alt="image" src="https://github.com/python-discord/site/assets/45...
Perhaps we could trail out some button-based pagination here? It's a shame that users can only see one page with the context menu version. I think one of the largest (pun intended) issues people had with buttons for pagination is their large vertical size, though it may be less of an issue in ephemeral messages.
LGTM
I'm assuming you left this untouched because we currently do not support switching between python versions.
I'm assuming you left this untouched because we currently do not support switching between python versions.
Yea, it's unused anyway.
Yeah, okay. I'll try adding a view with some buttons to see if we can scroll through.
GitHub Actions run 6399573225 failed.
@ChrisLovering This was essentially the approach taken in #175, which has some discussion.
I think it is better to accept an arbitrary path to a binary to execute. I'm hesitant to make design decisions that pigeon-hole snekbox into just a Python evaluator or just a code evaluator in general. Technically there is not much difference between that and sandboxing arbitrary binaries.
On the other hand, that is the common use case, so we can compromise here. I don't see a strong need for expo...
GitHub Actions run 6401335067 succeeded.
I ain't see nothing missing, very nice.
[python-discord/bot] branch deleted: update-references-of-3.11-eval-to-3.12
e9b4730 Update all references of 3.11 in eval to 3.12 (... - ChrisLovering
f642584 Bump ruff from 0.0.291 to 0.0.292 (#1378) - dependabot[bot]
Connected!
GitHub Actions run 6401351898 succeeded.
Connected!
Connected!
GitHub Actions run 6405986630 succeeded.
Hi, I'd like to work on this
Hi @sarzz2, thanks for your interest in this issue :slightly_smiling_face: I have assigned you, let me know if you need help.
Doc item doc_item.symbol_id='enum.EnumType.__getattr__' present in loaded documentation inventories not found on site, inventories may need to be refreshed.
Connected!
GitHub Actions run 6415181688 succeeded.
Hello @jchristgit So if we try to implement the first solution "Collapse to using a hamburger menu a bit sooner." would be a bigger/more difficult change since the site is using Bulma to decide when to use a hamburger menu.
We would need to override various existing Bulma CSS classes, I have tried and haven't been able to do so successfully yet.
My proposal:-
Right now the discord button on the top right(which is causing the issue) has the following properties(in base.css):-
@sarzz2 I think that looks good. If you open a pull request we can check this out on a deploy preview?
Summary
Fixes #1015 Issue
Description of changes
removing the margin-left property from base.css to fix the overflow caused by the discord button logo on the top right of the page when screen size is lowered.
I confirm I have:
- [X] Joined the Python Discord community
- [X] Read the Code of Conduct and agree to it
- [X] I have discussed implementing th...
GitHub Actions run 6418880860 succeeded.
Hi, If no one is working on this, I'd like to implement this feature.
Connected!
I tested the preview deployment, and unfortunately the issue is not fixed. The issue is still reproducible on:
-
Stock chromium
-
Firefox, with persistent scrollbars
General > Browsing > Always show scrollbars:
Given how finnicky the issue is, I'm inclined to suggest the removal of both padding-left and padding-right directly, which fixes the issue in all my test cases. It is a visual change, but I don't think it hurts the look:
I tested the preview deployment, and unfortunately the issue is not fixed. The issue is still reproducible on:
- Stock chromium
<img alt="image" width="721" src="https://user-images.githubusercontent.com/41782385/273406615-74fe62a2-afae-4ed9-950e-38a64588b889.png">
- Firefox, with persistent scrollbars
General > Browsing > Always show scrollbars:<img alt="image" width="647" src="https://user-images.githubusercontent.com/41782385/273406685-6b7147e2-a075-48b8-91e3-d...
Sentry Issue: SIR-LANCEBOT-AR
AttributeError: 'async_generator' object has no attribute 'filter'
File "bot/exts/fun/snakes/_snakes_cog.py", line 1062, in snakify_command
async for message in ctx.history(limit=500).filter(
Unhandled command error: 'async_generator' object has no attribute 'filter'
2eb7c41 Remove usage of non-existent ctx.history.filter - shenanigansd
[python-discord/sir-lancebot] New branch created: shenanigansd-patch-1
Closes #1379
Putting this up as draft, the implementation is still under discussion.
It looks like we might be able to get the message history directly from a user object, removing the need for a filter entirely.
GitHub Actions run 6447690886 succeeded.
GitHub Actions run 6448022718 succeeded.
Connected!
be6b698 Remove the redirect FilterList on migration - ChrisLovering
b1b5dc4 Merge pull request #1104 from python-discord/no... - jchristgit
2229d01 Bump cryptography from 41.0.3 to 41.0.4 - dependabot[bot]
6bb6cfe Merge pull request #1112 from python-discord/de... - Xithrius
b305c8f Bump ruff from 0.0.290 to 0.0.291 - dependabot[bot]
[python-discord/site] branch deleted: fix-CJ-mobile-banner
GitHub Actions run 6448432193 succeeded.
...we can just remove
padding-right:2.5remto fix the issue with persistent scrollbars on firefox.
Sounds good to me!
GitHub Actions run 6448645153 succeeded.
Merged the main branch and updated the file to remove padding.
GitHub Actions run 6452861822 succeeded.
GitHub Actions run 6455583337 succeeded.
GitHub Actions run 6459316742 succeeded.
GitHub Actions run 6461967218 succeeded.
475bbdd Bump rapidfuzz from 3.3.1 to 3.4.0 (#2782) - dependabot[bot]
fe496bd Bump rapidfuzz from 3.3.1 to 3.4.0 (#1381) - dependabot[bot]
Connected!
Connected!
GitHub Actions run 6464807708 succeeded.
Connected!
[python-discord/snekbox] New branch created: multi-version-api
bf39453 Allow specifying a binary path when calling NsJ... - ChrisLovering
a487120 Add tests for multi-version support - ChrisLovering
1df5812 Allow setting a binary_path when calling /eval - ChrisLovering
8459803 Also split on hyphens in build python script - ChrisLovering
a9da83e Ensure test modules are enabled when building 3... - ChrisLovering
This allows setting a binary_path key in the request body to /eval to specify which binary to run under.
If not supplied, it defaults to "/lang/python/default/bin/python"
if supplied, snekbox ensures that the path is within /lang (to avoid executing arbitrary binaries on the fs) and that the file exists.
This PR also comes with two unrelated changes
- https://github.com/python-discord/snekbox/commit/84598033acb13e1300d2e4ffc2b556fce906edd8 was needed as previous we were dro...
GitHub Actions run 6481366250 succeeded.
I'd prefer it if somebody could pick this up, this branch is now 2 years behind so would suggest using it as a reference. although rebasing should be relatively easy.
GitHub Actions run 6488442270 succeeded.
GitHub Actions run 6491894560 succeeded.
GitHub Actions run 6491880801 was cancelled.
Connected!
Connected!
GitHub Actions run 6491920653 succeeded.
Connected!
GitHub Actions run 6510819249 succeeded.
GitHub Actions run 6520287981 failed.
GitHub Actions run 6520372829 succeeded.
Thanks for the pull request.
I don't think we want to introduce another linter to our projects as we use pre-commit and ruff to lint all of our project's style, see https://github.com/python-discord/bot/blob/main/.github/workflows/lint-test.yml.
In the future, it is probably better to first discuss ideas like this in an issue.
GitHub Actions run 6529509362 succeeded.
GitHub Actions run 6533875524 succeeded.
Connected!
Connected!
GitHub Actions run 6543048355 succeeded.
GitHub Actions run 6545769458 failed.
GitHub Actions run 6552707383 succeeded.
GitHub Actions run 6552800633 succeeded.
GitHub Actions run 6552815988 succeeded.
GitHub Actions run 6553676819 succeeded.
GitHub Actions run 6554900641 succeeded.
GitHub Actions run 6555359841 failed.
GitHub Actions run 6556065979 succeeded.
Connected!
GitHub Actions run 6556090961 was cancelled.
Connected!
GitHub Actions run 6556104400 succeeded.
Connected!
Looks fine; asked for a clarification
What we could do is replace the static text with response.json() and purely just proxy the response back, that might be more useful
Should we add something in the readme about multiple version support? Can just be a blurb I think.
Why restrict it to just files in that directory? It seems like an arbitrary restriction I don't think we should have.
typo
("/bin/bash", "test files outside of /lang cannot be run"),
Oh I missed this in your description
if supplied, snekbox ensures that the path is within /lang (to avoid executing arbitrary binaries on the fs) and that the file exists.
It is fairly trivial to bypass this restriction by using the execve syscall. We cannot block this syscall either (at least not through nsjail's seccomp filters). That is due to a quirk in which the filter is applied before nsjail's own execve call, causing nsjail to commit suicide.
Granted, there may be use c...
GitHub Actions run 6583918187 succeeded.
GitHub Actions run 6587476080 failed.
GitHub Actions run 6590104456 failed.
GitHub Actions run 6602012087 failed.
Connected!
Connected!
GitHub Actions run 6609038378 succeeded.
[python-discord/workers] branch deleted: bubble-up-upstream-discord-errors
GitHub Actions run 6612121481 failed.
GitHub Actions run 6616149906 succeeded.
Looks good, much clearer layout too!
GitHub Actions run 6636130775 succeeded.
GitHub Actions run 6639187739 failed.
GitHub Actions run 6640286000 succeeded.
Connected!
Connected!
[python-discord/bot-core] branch deleted: Update-deps
[python-discord/bot-core] New tag created: v10.4.0
Looks good! I checked and it doesn't seem like constants.Roles.help_cooldown is being referenced anywhere else in the code so this shouldn't break anything.
https://github.com/python-discord/bot/blob/main/bot/exts/info/source.py#L70-L72
I'm not sure what "in some cases" refers to here, but I think that removing that relative to should fix it
Closes #2770
The !src would give a GitHub link that's invalid for tags. For instance, this is the link given by !src enumerate compared to what it should've been:
https://github.com/python-discord/bot/blob/main/resources/tags/enumerate.mdhttps://github.com/python-discord/bot/blob/main/bot/resources/tags/enumerate.md
Note the difference. I think this is because of the path being relative to bot:
https://github.com/python-discord/bot/blob/66c8414396b28a7cac8f05602ee7f2b...
GitHub Actions run 6657772871 succeeded.
GitHub Actions run 6663348692 succeeded.
GitHub Actions run 6665752286 failed.
GitHub Actions run 6667323151 succeeded.
GitHub Actions run 6669871940 failed.
GitHub Actions run 6672518367 succeeded.
This new tag, "Avoid System Python for Development," highlights the drawbacks of using system Python for development work, providing solutions for developers. It promotes best practices to create isolated development environments and includes a helpful audio resource for further insights.
GitHub Actions run 6672611487 succeeded.
Was this tag approved anywhere? You can suggest new tags for the bot by opening an issue at python-discord/meta.
Was this tag approved anywhere? If it was approved somewhere like the
#comunity-metachannel, it would be helpful to link it here for more context. Otherwise, you can suggest new tags for the bot by opening an issue at our meta repository here.
Yeah, Stelercus has advised me to [open a draft PR](#community-meta message) for this particular issue.
I'll edit the PR's descript...
ae5345a Bump pydis-core from 10.2.0 to 10.4.0 (#2796) - dependabot[bot]
61bbdff Bump urllib3 from 2.0.4 to 2.0.6 (#2776) - dependabot[bot]
4af4594 Bump arrow from 1.2.3 to 1.3.0 (#2775) - dependabot[bot]
e9b4730 Update all references of 3.11 in eval to 3.12 (... - ChrisLovering
adc8825 Bump coverage from 7.3.1 to 7.3.2 (#2778) - dependabot[bot]
e9ebd5e Bump regex from 2023.8.8 to 2023.10.3 (#2780) - dependabot[bot]
[python-discord/bot] branch deleted: remove-cooldown-role
GitHub Actions run 6675231159 succeeded.
GitHub Actions run 6675224074 was cancelled.
Connected!
Connected!
GitHub Actions run 6706515593 succeeded.
Does this need fixing? Can i work on this?
Yep it does. Thank you for your interest, I've assigned you. Let me know if you need any pointers :slightly_smiling_face:
GitHub Actions run 6712450320 succeeded.
Connected!
GitHub Actions run 6716528018 succeeded.
GitHub Actions run 6716520820 was cancelled.
GitHub Actions run 6716553551 succeeded.
We likely want to set these two options now too, so that all the lint rules are enabled.
https://github.com/owl-corp/python-template/blob/main/pyproject.toml#L39-L40
[python-discord/bot] branch deleted: swfarnsworth/title-command-for-op
GitHub Actions run 6718394398 succeeded.
Description
The .hsp [text] command would take the provided text, split it into 3 roughly equal sized chunks, and append each of the chunks to []aha []tinky []oop in the places indicated by the brackets. Then, the resulting text would be posted on pydis.
Examples:
.hsp RFC (expected output: Raha Ftinky Coop)
.hsp Edd (expected output: Eaha Dtinky Doop (or Eaha Dinky Doop; see additional details))
.hsp intoxicant (expected output: intaha oxitinky cantoop)
Reasoning
We often...
[python-discord/site] New branch created: cj10-finalize
If you'd like to double check names and github stuff, talk with me (Kat) and I can give you access to the source documents.
GitHub Actions run 6727475451 succeeded.
GitHub Actions run 6728803384 succeeded.
We likely want to set these two options now too, so that all the lint rules are enabled.
"unsafe-fixes" does not really sound like something that we should enable. Or do we want to beta test run ti?
These team names are great :smile:
GitHub Actions run 6731278419 succeeded.
The following commands should be converting to hybrid slash commands:
- daystar
- leaderboard
- global leaderboard
- stats
- countdown
The following commands should be converted to slash-only and be ephemeral:
- connect/link
- disconnect/unlink
The following commands should only be able to be run in advent-of-code-bot-commands, sir-lancebot-playground, or bot-commands. If they are tried to run elsewhere, they should redirect to advent-of-code-bot-commands and let the user...
I'd like to make our help command nicer and more in line with what the Python bot has.
The subscribe command is no longer functional and enough time has passed that we no longer need it.
Should also make sure to remove any references to it in other commands in Sir Robin.
@brodycritchlow Absolutely! I'll assign you now
Closes #99
Removes the !subscribe command any references to it, since we have a new way of doing roles.
I'm assuming we want to keep the MovedCommandError just incase we need it later. It was only referenced in _cog.py before I removed the command here.
Perhaps we could instead explain what the new way is of subscribing to notifications?
@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.
"unsafe-fixes" does not really sound like something that we should enable. Or do we want to beta test run it?
this config flag was added in 0.1.0 as a way to disable auto-fixes that could potentially change the meaning of code. The link has an example of such a rule.
We already had all of these rules enabled, they've just been changed to opt-in now.
GitHub Actions run 6738387819 succeeded.
Sure, sounds good to me. Ill make the changes ASAP
@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.
Sure, how should I split the tasks?
GitHub Actions run 6741584794 succeeded.
41c6a7e Enable unsafe-fixes and preview for ruff - jchristgit
Ok, that makes sense! I've pushed a commit to enable the options.
GitHub Actions run 6742930484 failed.
dadb8f8 Bump sentry-sdk from 1.32.0 to 1.34.0 (#1393) - dependabot[bot]
2377c78 Bump rapidfuzz from 3.4.0 to 3.5.2 (#1394) - dependabot[bot]
Connected!
GitHub Actions run 6750975390 was cancelled.
Connected!
@n0Oo0Oo0b would you like to split this issue up into tasks? There seems to be a lot of commands / tasks involved and I'd be willing to take up some of that work if you don't mind.
Sure, how should I split the tasks?
@n0Oo0Oo0b I think splitting it up the same way Kat's done it should work. We could make PRs for each of them, so they can be reviewed more effectively. For instance, a PR titled Convert &daystar command into a hybrid command. This way we can get multiple people w...
fixes #1037
Summary
In the "Sub-Articles" section of the "Contributing" page, when the dropdown menu is expanded, some section names are cut off at the right edge of the page making user scroll horizontally.
Description of changes
removed nowrap property and adjusted CSS of the subarticle to make it fit on the page
I confirm I have:
- [X] Joined the Python Discord community
- [X] Read the [Code of Conduct](https://www.pydis.com/pages/code-of...
5637636 Refactor modules into subpackages - MarkKoz
3909703 Move iter_lstrip to separate utils module - MarkKoz
c85bc73 Refactor creation of NsJail args list into a se... - MarkKoz
64ca95c Refactor writing of input files into a separate... - MarkKoz
2c58889 Refactor attachment parsing into a separate fun... - MarkKoz
[python-discord/snekbox] branch deleted: refactor-2
85c7f8b Bump sentry-sdk from 1.33.0 to 1.34.0 (#2802) - dependabot[bot]
a23d0c9 Bump rapidfuzz from 3.4.0 to 3.5.2 (#2801) - dependabot[bot]
Connected!
GitHub Actions run 6766672877 was cancelled.
Connected!
GitHub Actions run 6769342829 succeeded.
[sir-lancebot] Branch dependabot/pip/ruff-0.1.3 was force-pushed to `61c3d6a`
[sir-lancebot] Branch dependabot/pip/ruff-0.1.3 was force-pushed to `428c8de`
GitHub Actions run 6769613785 succeeded.
GitHub Actions run 6773651595 failed.
GitHub Actions run 6780020576 succeeded.
Hi @vivekashok1221, are you still planning to work on this? If not, I would like to give it a try.
If I understand correctly, the agreement is to include the server icon as either the author or the thumbnail of the embed. We're not intending to go for the other ideas at the moment, correct?
Thanks!
@minalike Shall I be assigned? And should we remove the s: planning label?
GitHub Actions run 6790562505 succeeded.
Connected!
Part of #97
I feel like duplicating the code isn't the best way to go about this, but I couldn't really think of anything else. Any suggestions to avoid it are welcome.
GitHub Actions run 6796723916 succeeded.
I have explored the proposed approaches.
The easiest option is to include the icon in the embed thumbnail:
Another option is to use the author field. However, the author also needs a name, in addition to the icon. This opens a nice opportunity to move the event's name there, but the problem is that we currently include the event name in the body of the description:

File "bot/exts/backend/branding/_repository.py", line 179, in construct_event
meta_bytes = await self.fetch_file(contents["meta.md"].download_url)
File "bot/exts/backend/branding/_repository....
Using a hybrid group should turn all the commands into hybrid commands, which I was avoiding since I didn't know you could send ephemeral messages with them. But the ephemeral kwarg in ctx.send works, so I think this should be the best way to go.
GitHub Actions run 6811836083 succeeded.
Seems like converting all of them in one go would be pretty straightforward (see https://github.com/python-discord/sir-robin/pull/101#issuecomment-1803742152), so I don't think it's necessary to split this issue up anymore.
The latest commits should turn all the AoC commands into hybrid commands. Everything looks ok from my testing other than the channel restrictions, which don't work for text commands on my bot either, so it seems like something to do with my environment.
GitHub Actions run 6815053633 failed.
GitHub Actions run 6815230094 was cancelled.
GitHub Actions run 6815253810 succeeded.
GitHub Actions run 6815265291 failed.
77c6938 Bump kubernetes_asyncio to 28.2.0 - ChrisLovering
bdd52fb Format code to new ruff formatter standards - ChrisLovering
Connected!
I would like to look into this. I can implement some retry mechanism. I could also make the requests concurrent so that the sync is much faster and it'd be nice to add some tests.
ะะฑะฝะพะฒะปะตะฝะธะต 1.00
I would love to work together with someone on this feature. @sarzz2?
GitHub Actions run 6848927109 succeeded.
GitHub Actions run 6849951556 succeeded.
GitHub Actions run 6849961180 succeeded.
GitHub Actions run 6849970367 succeeded.
GitHub Actions run 6851091210 succeeded.
cf69220 Bump sentry-sdk from 1.34.0 to 1.35.0 (#2814) - dependabot[bot]
79556e5 Bump sentry-sdk from 1.34.0 to 1.35.0 (#1396) - dependabot[bot]
Connected!
GitHub Actions run 6851216034 succeeded.
Connected!
[python-discord/metricity] New branch created: bump-deps
032d42a Bump pytest-xdist from 3.3.1 to 3.4.0 (#2813) - dependabot[bot]
[sir-lancebot] Branch dependabot/pip/ruff-0.1.5 was force-pushed to `a6a8f8e`
Connected!
Connected!
GitHub Actions run 6859582711 succeeded.
Uh I was planning on doing it on my own if someone assigns me.
GitHub Actions run 6863461405 succeeded.
GitHub Actions run 6866900013 succeeded.
GitHub Actions run 6870915187 succeeded.
Connected!
GitHub Actions run 6873900447 succeeded.
Connected!
GitHub Actions run 6883372044 succeeded.
GitHub Actions run 6903700563 succeeded.
[python-discord/bot] New branch created: swfarnsworth/tag-updates
This PR updates two tags and introduces a new one about comparisons to True and False.
Regarding the new tag, I'm open to suggestions (and destructive criticism) about using vertical space more sparingly in the code section. I don't like having my_func(user_input) four times, but I'm worried that having ... on the same line as the if statements will be confusing for beginners.
GitHub Actions run 6916002185 succeeded.
Thank you for writing this and opening this PR.
It's important that tags be as terse as possible, so as to drive a very specific point before losing the reader's attention. It's also important that the instructions are easy to follow for the target audience.
If we go forward with this tag, I'd like to first condense it significantly, to something along these lines:
Operating systems often come with a system Python interpreter that is used internally. While it may be suitable for ex...
Thank you for writing this and opening this PR.
It's important that tags be as terse as possible, so as to drive a very specific point before losing the reader's attention. It's also important that the instructions are easy to follow for the target audience.
If we go forward with this tag, I'd like to first condense it significantly, to something along these lines:
Operating systems often come with a system Python interpreter that is used internally. While it may be s...
GitHub Actions run 6916653952 succeeded.
GitHub Actions run 6926097029 succeeded.
GitHub Actions run 6928890775 failed.
GitHub Actions run 6939746061 succeeded.
GitHub Actions run 6944043612 succeeded.
GitHub Actions run 6949747072 succeeded.
GitHub Actions run 6953395236 succeeded.
GitHub Actions run 6956091057 succeeded.
This repo is for discussing issues regarding out bot project.
If you have any questions, please ask them in this channel and withhold from opening blank issues.
I'll be closing this now.
GitHub Actions run 6957430209 succeeded.
Connected!
Connected!
Connected!
Connected!
Connected!
Connected!
GitHub Actions run 6963077196 succeeded.
Tested and works well. Thanks!
When the linting is fixed, I can push to get this merged through.
So an issue with the current approach, is that &aoc link still works as a regular command and is not ephemeral only. I would like to convert this completely over to a slash-only is possible. If it's not the most feasible then that's fine.
Additionally, with the hybrid group, I would prefer the prefix to be /aoc instead of the wordy /adventofcode
For the channel restrictions, that's not working because we're missing code that wraps the extensions with the whitelist command.
Sir-Lancebo...
74bc864 Bump sentry-sdk from 1.35.0 to 1.36.0 (#2821) - dependabot[bot]
truthy or falsey
Should we expand on what these mean?
Connected!
GitHub Actions run 6966521067 succeeded.
1f9bc8d Bump sentry-sdk from 1.35.0 to 1.36.0 (#1398) - dependabot[bot]
3b70dc8 Bump pytest-xdist from 3.4.0 to 3.5.0 (#2823) - dependabot[bot]
GitHub Actions run 6966530482 failed.
Connected!
Connected!
GitHub Actions run 6966565554 succeeded.
GitHub Actions run 6966571227 succeeded.
GitHub Actions run 6966588402 failed.
GitHub Actions run 6972300916 succeeded.
GitHub Actions run 6977134460 succeeded.
GitHub Actions run 6979361306 succeeded.
I lean towards no. It would make the scope of the tag a lot bigger and is not necessarily relevant to the reader. As is, newbies can make an assumption about what they mean and still understand the rest or they can ask what they mean. Either are good outcomes.
Maybe this is overthinking, but are people going to think they need to put their code inside the print('...')?
GitHub Actions run 6985032770 succeeded.
Connected!
GitHub Actions run 6991439728 succeeded.
[python-discord/bot] branch deleted: bump-bot-core
[python-discord/bot] New branch created: bump-deps
Connected!
GitHub Actions run 6991458048 failed.
GitHub Actions run 6991472202 was cancelled.
GitHub Actions run 6991473308 succeeded.
Connected!
Sentry Issue: BOT-3P0
AttributeError: 'dict' object has no attribute 'id'
File "bot/exts/moderation/infraction/management.py", line 288, in infraction_search_group
await self.search_user(ctx, query)
File "bot/exts/moderation/infraction/management.py", line 313, in search_user
prefix = f" - {user.id}"
Error executing command invoked by aboominister: !i s 409107086526644234
0ead8ab Don't shadow user object with dict when searchi... - ChrisLovering
[python-discord/bot] New branch created: fix/2827
GitHub Actions run 6991512528 succeeded.
d4fdbce Use new Discord markdown support for bot messag... - DownDev
09a1377 Don't shadow user object with dict when searchi... - ChrisLovering
[python-discord/bot] branch deleted: fix/2827
GitHub Actions run 6991529349 was cancelled.
GitHub Actions run 6991531653 succeeded.
Connected!
[python-discord/sir-lancebot] New branch created: bump-deps
Description
This bumps deps to latest, and uses the new logging util from bot-core. Copied the same thing as what I did in https://github.com/python-discord/bot/pull/2766
Did you:
- [ ] Join the Python Discord Community?
- [ ] Read all the comments in this template?
- [ ] Ensure there is an issue open, or link relevant discord discussions?
- [ ] Read and agree to the [contributing guidelines](https://pythondiscord.com/pages/contributing/con...
GitHub Actions run 6991635751 succeeded.
[python-discord/sir-lancebot] branch deleted: bump-deps
[sir-lancebot] Branch upgrade-pydantic-2 was force-pushed to `9fa1fb3`
GitHub Actions run 6991666195 succeeded.
Connected!
Connected!
69c08d1 Remove the need for calling dotenv manually by ... - ChrisLovering
[python-discord/sir-lancebot] New branch created: remove-manual-dotenv-call
Relevant Issues
Description
Did you:
- [ ] Join the Python Discord Community?
- [ ] Read all the comments in this template?
- [ ] Ensure there is an issue open, or link relevant discord discussions?
- [ ] Read and agree to the contributing guidelines?
GitHub Actions run 6991720432 succeeded.
Connected!
This PR has been open for around 2 years. Doesn't seem to be needed at the moment to continue, so I'll close this, at least for now.
Author hasn't responded to 2 pings. I'm taking over this PR.
69c08d1 Remove the need for calling dotenv manually by ... - ChrisLovering
[python-discord/sir-lancebot] branch deleted: remove-manual-dotenv-call
GitHub Actions run 6991750961 succeeded.
Connected!
Connected!
[python-discord/sir-robin] branch deleted: migrate-constants-to-pydantic-settings
GitHub Actions run 6991778226 succeeded.
I think the current example is enough for the tag. Also, there was no issue assigned, so next time please get approval from a core developer before proceeding with a PR.
Thanks!
[python-discord/sir-robin] New branch created: bump-deps
Getting the conversation going again, perhaps something simple like this would work:
embed.timestamp = f"Uploaded on {upload_time}"
GitHub Actions run 6991804007 succeeded.
Connected!
Yes, I like this better, as it doesn't imply the embed's timestamp but rather the version's.
Suspect Issues
This pull request was deployed and Sentry observed the following issues:
- โผ๏ธ TypeError: 'Timeout' object does not support the context manager protocol
bot.exts.backend.branding._cog in apply_assetView Issue
<sub>Did you find this useful? React with a ๐ or ๐</sub>
Connected!
GitHub Actions run 7000925842 succeeded.
GitHub Actions run 7000929151 succeeded.
GitHub Actions run 7000932156 succeeded.
GitHub Actions run 7004865496 succeeded.
GitHub Actions run 7006804362 succeeded.
[python-discord/bot-core] New branch created: bump-deps
Mark dependencies using tilde version specifiers. This is to allow user of pydis core to use newer versions of these libraries without us having to cut a new release.
This PR also bumps dev deps along with bumping the version of postgres used in the dev docker compose
Changelog:
GitHub Actions run 7012708624 succeeded.
Connected!
28a32fb Only debug log if debug is enabled - ChrisLovering
[python-discord/sir-robin] New branch created: only-debug-log-if-debug-is-enabled
I guess we can avoid spamming prod.
GitHub Actions run 7021468399 succeeded.
f916a3f Only debug log if debug is enabled (#104) - ChrisLovering
[python-discord/sir-robin] branch deleted: only-debug-log-if-debug-is-enabled
Connected!
GitHub Actions run 7024628906 failed.
Connected!
[python-discord/sir-robin] New branch created: sir-robin-touchups
[python-discord/sir-robin] Pull request opened: #105 Sir Robin Error Handling & Help Command updates
This PR updates and touches up the &help command output and some of the error handling. In addition, it also fixes how the channel whitelist works.
- Help command cog is shamelessly stolen from Sir Lancebot
- Error handling is updated to catch some of the new errors being thrown
- This unifies how we do the channel whitelisting and simplifies it as well
- Some general reorganization and cleanup of unused items
[python-discord/sir-robin] Checks Failed on PR: #105 Sir Robin Error Handling & Help Command updates
GitHub Actions run 7025824072 failed.
opps, think this is one I missed when I migrated robin to pydantic settings
We could do with adding a handler for CheckFailure too, so that we don't get people spamming this error by running one of the admin-only commands.
Doesn't need to be in this PR though.
I think this change is the cause of the below behaviour:
Previously the admin commands block and refresh could be ran anywhere, so long as you're an admin, but now the bot forces you to run them in this whitelist, which doesn't seem desirable for block especially
GitHub Actions run 7026082931 succeeded.
GitHub Actions run 7026344865 succeeded.
GitHub Actions run 7032634764 succeeded.
Connected!
Connected!
GitHub Actions run 7035862265 succeeded.
If you want event's lead to do this, then we'll need to remove the with_role deco just above this line, or remove this whitelist deco and add events lead to the with_role deco
GitHub Actions run 7036929185 succeeded.
50662f4 Update error handler to handle more types of er... - ChrisLovering
[python-discord/sir-robin] New branch created: more-check-failure-handling
This commit also splits out handling of common base classes for ease of reading
GitHub Actions run 7037101043 succeeded.
[sir-robin] Branch more-check-failure-handling was force-pushed to `ad4b4b6`
[sir-robin] Branch more-check-failure-handling was force-pushed to `dd8f559`
[sir-robin] Branch more-check-failure-handling was force-pushed to `2c4fc0b`
GitHub Actions run 7037332941 succeeded.
[sir-robin] Branch more-check-failure-handling was force-pushed to `d8e955f`
GitHub Actions run 7037717297 succeeded.
@janine9vn just wanted to ask, what's the reasoning behind making only the link/unlink commands fully slash commands, and making the other hybrids?
[python-discord/sir-robin] branch deleted: sir-robin-touchups
[python-discord/sir-robin] branch deleted: more-check-failure-handling
[python-discord/sir-robin] New branch created: sir-robin-touchups
Connected!
GitHub Actions run 7038069026 failed.
GitHub Actions run 7038628564 succeeded.
GitHub Actions run 7042494519 succeeded.
Connected!
GitHub Actions run 7045098189 succeeded.
Currently, when someone in the top 10 runs &aoc lb, their score gets moved to the top of the leaderboard:
I think it would make more sense for it to show up in the respective location within the top 10 instead.
It may also be worth considering displaying users outside the top 10 at the bottom, along with the users placed immediately before and after the user, like so:
...
Connected!
Connected!
482f25f Remove channel lock for countdown - janine9vn
[python-discord/sir-robin] New branch created: aoc-c-everywhere
This removes the channel lock for &aoc countdown. The command response is a single line message and is useful to have in other channels.
It also adds an in-month lock decorator for the stats command. This was overlooked in previously.
GitHub Actions run 7049305229 succeeded.
Pushed commit https://github.com/python-discord/sir-robin/pull/101/commits/619a1db4de522892e6b2c6d421f25846c50d601d that makes link/unlink commands slash-command only as requested by Kat.
Would like some feedback here on the technical side - I've used the app_command property of discord.ext.commands.HybridGroup, in order to make a slash-only command under the existing hybrid group.
Ho...
GitHub Actions run 7055742904 succeeded.
4ec9612 Fix NoneType default value for AoC LB - janine9vn
[python-discord/sir-robin] New branch created: aoc-lb-fix
Sometimes we don't have ignored days
GitHub Actions run 7056305567 succeeded.
[python-discord/sir-robin] branch deleted: aoc-lb-fix
[python-discord/sir-robin] branch deleted: aoc-c-everywhere
Connected!
[python-discord/bot] branch deleted: unfurl-redirects
37d34ec Update AoC leaderboard upload ot use new paste ... - ChrisLovering
[python-discord/sir-robin] New branch created: use-new-pasteservice
Maybe use log.error here since you're not providing any exception info.
log.exception automatically grabs exception context when it's used inside an except block
Didn't test this, but the change looks safe and good to me.
To be more specific, log.exception can only be used in an exception block, and it is a shortcut to log.error("foo", exc_info=err) where it automatically grabs exec info using sys.exc_info()
And I've been passing it all my life, TIL.
GitHub Actions run 7060341728 succeeded.
GitHub Actions run 7065565481 succeeded.
54d618d Bump sentry-sdk from 1.37.1 to 1.38.0 (#1402) - dependabot[bot]
aaeb8bb Bump sentry-sdk from 1.37.1 to 1.38.0 (#2830) - dependabot[bot]
@sarzz2 Sorry for the wait. I'll assign you, but if you've become uninterested, just let me know.
GitHub Actions run 7065885340 succeeded.
@Vyvy-vi Sorry for the wait. I've assigned you. If you no longer want to work on this, just let me know.
Connected!
@n0Oo0Oo0b Hello. Just wondering if there has been any progress on this feature. I'd like to see it get implemented. Thanks!
Connected!
Connected!
@n0Oo0Oo0b Hello. Just wondering if there has been any progress on this feature. I'd like to see it get implemented. Thanks!
I did have some progreess on the board generation but this has been on my backburner for a while. I'll be able to work on it soon once my exams are over and I'll open a draft PR once the board generation is done.
Description
Certain links, specifically ones with ../tree/.., are reacted to with Christmas trees.
Steps to Reproduce
Send a link to a GitHub directory in a channel where the bot reacts.
Expected Behaviour
The bot to... not do that.
Actual Behaviour
Known Impacted Platforms
- [x] Web
- [x] Desktop
- [x] Android App
- [x] iOS App
...
Here is the code in question: https://github.com/python-discord/sir-lancebot/blob/54d618da59e63936d6d9c6ab8fed5b325112289a/bot/exts/holidays/holidayreact.py#L64
It's matching on christams|tree, so it will match on every tree, regardless of it's festivity. It'll even match on the Grinch's trees! This is obviously extremely worrisome, we don't want the Grinch anywhere near our festivities!! This is a MUST FIX issue!!!
<details>
<summary>regex101 screenshots</summary>
![image...
1871a06 Replace or with space in christmas tree holiday... - shenanigansd
[python-discord/sir-lancebot] New branch created: shenanigansd-patch-1
Relevant Issues
This is one possible solution to #1403. I'll leave the floor open for discussion over other options.
Description
christmas|tree -> christmas tree to make sure that we only react to trees of the Christmas variety.
regex101 screenshots
, it looks like we're okay still reacting to most trees, just not when they're in a link.
I suppose this is a good compromise. We really shouldn't discriminate, lest we become grinches ourselves. I'd like to go ahead and close the comment floor and open up the review floor.
GitHub Actions run 7068773211 succeeded.
This will still match against trees of over varieties, such as "Grinch's tree", which you initially commented in #1403 that we didn't want?
It would also be nice to match against the plural "trees", whilst we're here.
If 'tree' on its own isn't enough to ensure its festiveness, maybe just matching (christ|x)mas would be fine?
I don't understand python and discord bots. This code was written for me, a person who can no longer maintain contact with anyone at all. The error itself:
Loop thread traceback (most recent call last):
File "C:\.HgBots\HG_bot_roles-main/main.py", line 877, in
client.run(discord_token)
File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\discord\client.py", line 860, in run
asynci...
Hello.
I'm afraid that you can't ask these kinds of questions here as it's reserved for issues related to our projects.
Feel free to join us at our discord where you can ask questions about something you need help with in Python in this forum channel
I'll be closing this issue now.
Are we certain we don't mind most trees? A lot of trees can be stated that have no relation to the season itself. "Grinch's tree", sure, but then what about "skeleton tree"? That will still react with a tree; the regex matches, but that's for halloween.
If we're going to activate it for Christmas, I'd rather you match for christmas/xmas then lookahead for tree.
Sentry Issue: BOT-3P5
The snekbox cog does not account for Discord's message length restriction when it generates the list of blocked files to append to the message.
HTTPException: 400 Bad Request (error code: 50035): Invalid Form Body
In content: Must be 2000 or fewer in length.
(4 additional frame(s) were not displayed)
...
File "bot/decorators.py", line 133, in inner
File "bot/exts/utils/snekbox/_c...
Hi, I'll work on it, just to clear up in the easy, medium, hard mode the range of no. will be increased right? No. of tries remain same for each mode
Easy: 1-50, Medium: 1-100 and Hard 1-200? 5 tries in each mode, sounds good?
GitHub Actions run 7082358986 succeeded.
Relevant Issues
Closes #1082
Description
Added new cog of guess the number game
Did you:
- [x] Join the Python Discord Community?
- [x] Read all the comments in this template?
- [x] Ensure there is an issue open, or link relevant discord discussions?
- [x] Read and agree to the contributing guidelines?
GitHub Actions run 7083062826 succeeded.
11eef8b Add alias make/create as an alias to alias add ... - StephenDaDev
c8b2522 Fix silently order in help embed (#3215) - lidistat67
485ab5a Remove user fetching from blocked command (#3242) - khakers
d6eba12 Update changelog - Taaku18
f2a434b Fix replies in dms not being sent (#3239) - RealCyGuy
2b66710 Fix #3291: Resolve code scanning alert for URL ... - Taaku18
f0c469e Implement #3187: Enhance bot join/leave logs ac... - Taaku18
7508d52 Update readme with new documentation links, pyt... - Taaku18
7dfd22c Merge branch 'master' into development - Taaku18
6d61cf2 Add JSON logging support (#3305) - nullishamy
ead6712 add ducky_bober.svg - decorator-factory
[python-discord/branding] New branch created: ducky-bober-emoji
:b: ober aka beaver :beaver:
GitHub Actions run 7092589308 succeeded.
I noticed that when using the bot command !tvmute the removal of the Voice Verified role (if the user currently has it) is not logged to #user-log.
Example and repro in mod channel:
#mods message
#user-log message
This behaviour seems to be on purpose, and caused by this LoC https://github.com/python-discord/bot/blob/main/bot/exts/moderation/infraction/infractions.py#L536
If it's decided that this should now be logged, then that line is the one to remove.
I guess we have history in the code base of intentionally ignoring logs for voice verification-related events (https://github.com/python-discord/bot/issues/2076). I'd be in favor of not ignoring.
It's used in a few places, can see them all here https://github.com/search?q=repo%3Apython-discord%2Fbot+.ignore(&type=code
GitHub Actions run 7098041449 succeeded.
GitHub Actions run 7099359706 succeeded.
GitHub Actions run 7100887678 succeeded.
GitHub Actions run 7103888306 failed.
Connected!
Connected!
GitHub Actions run 7110595026 succeeded.
I'm getting this as an error when I test it. Is it something about my settings/config that's wrong?
I'm getting this as an error when I test it. Is it something about my settings/config that's wrong?
You're probably not doing anything wrong. I didn't get a chance to test it when I made this, then quickly forgot about it.
Will give it a look later today.
GitHub Actions run 7113278423 succeeded.
[python-discord/metricity] branch deleted: bump-deps
[python-discord/metricity] New tag created: v2.3.2
[python-discord/quackstack] New branch created: bump-deps
[python-discord/quackstack] branch deleted: bump-deps
[python-discord/olli] New branch created: bump-deps
[python-discord/olli] branch deleted: bump-deps
[python-discord/olli] New tag created: v1.1.0
GitHub Actions run 7114539143 succeeded.
Connected!
Connected!
@janine9vn this issue was being caused by the max paste limit.
In the force push I've had to limit the leader board output to only the top 1000 so that we don't hit that.
GitHub Actions run 7121492277 succeeded.
Problem
Currently, all of the error handling is usually done through an ErrorHandler Cog.
This cog will only handle errors raised from Text Commands and will not catch errors raised from App Commands (Slash Commands and Context Menu Commands)
Solution
The way we can centralize handling for App Commands would ideally be by subclassing the CommandTree class and override the on_error method, then upon instantiating the bot, will pass this class as an argument to...
Fyi this is somewhat related to #85, which also mentions we should port over the error handling.
GitHub Actions run 7134342480 succeeded.
Connected!
Tested and now works with the top 1000 limit. Maybe in many years we'll have to deal with more than 1,000 active participants but that's a very-future-us problem.
GitHub Actions run 7138986935 succeeded.
4216b20 Fix broken netcup icon in "Powered by" footer - jchristgit
[python-discord/site] New branch created: fix-broken-netcup-icon-in-footer
The original URL this was hosted at is no longer available. Incorporate the netcup icon as found on
https://www.netcup.de/ueber-netcup/werbemittel/index.php.
GitHub Actions run 7139021678 failed.
My deepest apologies for not responding at an earlier date. I am no longer interested in working on this task. Good day.
[python-discord/site] branch deleted: lazy-load-footer-images
Connected!
[site] Branch fix-broken-netcup-icon-in-footer was force-pushed to `1389278`
1389278 Fix broken netcup icon in "Powered by" footer - jchristgit
GitHub Actions run 7139653573 was cancelled.
GitHub Actions run 7139667066 succeeded.
We don't want the game to carry on, so you should return here since the difficulty is invalid.
We should give more context here
await ctx.send("The game has timed out! If you wish to play again, you can start a new game.")
You should make the conversion only once, before anything else, then keep on using the converted number if successfull. The conversion should be done like I indicated in my previous comment.
GitHub Actions run 7141751961 succeeded.