#dev-log

Workflow Run

CI #958

Source Branch

reuse-fixup-blocker-workflow

regal archBOT Aug 12, 2023, 5:30 PM

#

shtlrs

[python-discord/bot] Pull request closed: #2717 Block fixup commits

#

shtlrs

[bot:main] 3 new commits

bab243c use the organisation's fixup commit blocker wor... - shtlrs
dd8069d Merge branch 'main' into reuse-fixup-blocker-wo... - shtlrs
436b6dd Merge pull request #2717 from python-discord/re... - shtlrs

#

shtlrs

[python-discord/bot] branch deleted: reuse-fixup-blocker-workflow

oak estuaryBOT Aug 12, 2023, 5:33 PM

#

Python Bot

Connected!

odd spireBOT Aug 12, 2023, 5:33 PM

#

[python-discord/bot] Workflow Failed

GitHub Actions run 5842610054 failed.

Actor

Workflow Run

CI #959

Commit

436b6dd

regal archBOT Aug 12, 2023, 5:48 PM

#

shtlrs

[python-discord/.github] Issue opened: #21 Fixup commit blocker workflow fails when ran on push.

This is normal as the pull_request variable isn't available in the context anymore.

proposed solution

We deactivate this for push events. The push happens once the merge has been done, and the merge is blocked if the fixup commits exist.

So i don't see a need to do this twice as origin/main and HEAD will be the same ref.

regal archBOT Aug 12, 2023, 8:49 PM

#

shtlrs

[bot:run-fixup-blocker-on-pr-only] 1 new commit

9c3b7e9 run ficup blocker on pull request events only - shtlrs

#

shtlrs

[python-discord/bot] New branch created: run-fixup-blocker-on-pr-only

#

shtlrs

[bot] Branch run-fixup-blocker-on-pr-only was force-pushed to `dcacfe3`

#

shtlrs

[python-discord/bot] Pull request opened: #2718 Run fixup blocker on pull request events only

This does two things:

Makes sure that the fixup blocker workflow only runs when the event is a pull_request
Makes the previously mentioned workflow depend on the lint-test one as we don't want to block linting on fixup commits still.

#

shtlrs

[site:use-fixup-commit-blocker] 1 new commit

3a52d09 run fixup blocker on pull requests only - shtlrs

#

shtlrs

[bot-core:fixup-commit-blocker] 1 new commit

9d60faa run fixup blocker on pull requests only - shtlrs

regal archBOT Aug 12, 2023, 9:25 PM

#

shtlrs

[bot] Branch run-fixup-blocker-on-pr-only was force-pushed to `ca171aa`

odd spireBOT Aug 12, 2023, 9:27 PM

#

[python-discord/bot] Checks Failed on PR: #2718 Run fixup blocker on pull request events only

GitHub Actions run 5843521636 failed.

PR Author

Workflow Run

CI #961

Source Branch

run-fixup-blocker-on-pr-only

regal archBOT Aug 12, 2023, 9:31 PM

#

shtlrs

[bot-core] Branch fixup-commit-blocker was force-pushed to `5aa30e5`

#

shtlrs

[bot] Branch run-fixup-blocker-on-pr-only was force-pushed to `1439618`

odd spireBOT Aug 12, 2023, 9:38 PM

#

[python-discord/bot] Checks Successful on PR: #2718 Run fixup blocker only when the ref isn't main's HEAD

GitHub Actions run 5843566383 succeeded.

PR Author

Workflow Run

CI #962

Source Branch

run-fixup-blocker-on-pr-only

regal archBOT Aug 12, 2023, 9:45 PM

#

shtlrs

[bot-core] Branch fixup-commit-blocker was force-pushed to `00615c3`

thin oysterBOT Aug 13, 2023, 6:34 AM

#

Sir Robin

Connected!

regal archBOT Aug 13, 2023, 8:27 AM

#

shtlrs

[site] Branch use-fixup-commit-blocker was force-pushed to `4a958d3`

odd spireBOT Aug 13, 2023, 8:30 AM

#

[python-discord/site] Checks Successful on PR: #1072 Block fixup commits

GitHub Actions run 5846286853 succeeded.

PR Author

Workflow Run

CI #470

Source Branch

use-fixup-commit-blocker

regal archBOT Aug 13, 2023, 11:25 AM

#

n0Oo0Oo0b

[python-discord/site] New comment on issue #901: New page on using cogs/extensions in discord.py

I see, thanks for the feedback.

#

n0Oo0Oo0b

[python-discord/site] Issue closed: #901 New page on using cogs/extensions in discord.py

#

n0Oo0Oo0b

[python-discord/bot] Pull request opened: #2719 Confirm reminder edit

Closes #2353

Screenshots:

Confirmation:

When cancelled:

When confirmed:

odd spireBOT Aug 13, 2023, 11:40 AM

#

[python-discord/bot] Checks Failed on PR: #2719 Confirm reminder edit

GitHub Actions run 5847081501 failed.

PR Author

Workflow Run

CI #963

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

regal archBOT Aug 13, 2023, 2:43 PM

#

jchristgit

[python-discord/site] Pull request review submitted: #1072 Block fixup commits

still great

#

jchristgit

[python-discord/site] Pull request closed: #1072 Block fixup commits

#

jchristgit

[site:main] 2 new commits

4a958d3 run fixup blocker when git ref isn't main - shtlrs
ea0bd41 Merge pull request #1072 from python-discord/us... - jchristgit

#

jchristgit

[python-discord/site] branch deleted: use-fixup-commit-blocker

#

jchristgit

[python-discord/bot] Pull request review submitted: #2718 Run fixup blocker only when the ref isn't main's HEAD

20 years later, still great

regal archBOT Aug 13, 2023, 3:40 PM

#

shtlrs

[.github:fixup-blocker-failing-in-forks] 1 new commit

f3a78e2 Use gh cli to checkout to fork's branch - amrouna2

#

shtlrs

[python-discord/.github] New branch created: fixup-blocker-failing-in-forks

#

shtlrs

[python-discord/.github] Pull request opened: #22 Use github cli to checkout to fork repo branches.

#

shtlrs

[.github] Branch fixup-blocker-failing-in-forks was force-pushed to `3e63963`

#

ChrisLovering

[branding:update-event-dates] 1 new commit

80c2a20 Update event dates for 2024 - ChrisLovering

#

ChrisLovering

[python-discord/branding] New branch created: update-event-dates

#

ChrisLovering

[python-discord/branding] Pull request opened: #200 Update event dates for 2024

odd spireBOT Aug 13, 2023, 3:55 PM

#

[python-discord/branding] Checks Successful on PR: #200 Update event dates for 2024

GitHub Actions run 5848255328 succeeded.

PR Author

Workflow Run

Event Validation #129

Source Branch

update-event-dates

regal archBOT Aug 13, 2023, 3:57 PM

#

shtlrs

[python-discord/bot] Pull request review submitted: #2719 Make admins confirm edits of other users' reminders

Mostly are nitpicks, and this is only a code review, i'll test it later.

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

class ModifyReminderConfirmationView(discord.ui.View):

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

REMINDER_EDIT_CONFIRMATION_TIMEOUT = 60

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

    """A view to confirm modifying someone else's reminder by admins."""

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

Maybe mentioning who that person is would be useful?

regal archBOT Aug 13, 2023, 4:21 PM

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

I think replying to the original message that invoked the command would be better.

odd spireBOT Aug 13, 2023, 4:24 PM

#

[python-discord/bot] Checks Cancelled on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5848378077 was cancelled.

PR Author

Workflow Run

CI #964

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

#

[python-discord/bot] Checks Failed on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5848379726 failed.

PR Author

Workflow Run

CI #965

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

#

[python-discord/bot] Checks Failed on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5848395590 failed.

PR Author

Workflow Run

CI #966

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

regal archBOT Aug 13, 2023, 7:44 PM

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

I actually meant the owner of the reminder.

So a reply + mentioning the actual author would be a good combo

odd spireBOT Aug 13, 2023, 10:23 PM

#

[python-discord/kubernetes] Checks Successful on PR: #162 Add archival notice to root README

GitHub Actions run 5849849186 succeeded.

PR Author

Lint Kubernetes manifests #406

Workflow Run

Source Branch

Add-archival-notice

odd spireBOT Aug 14, 2023, 1:56 AM

#

[python-discord/bot] Checks Failed on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5850976190 failed.

PR Author

Workflow Run

CI #967

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

#

[python-discord/bot] Checks Failed on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5850989850 failed.

PR Author

Workflow Run

CI #968

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

regal archBOT Aug 14, 2023, 2:03 AM

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

I see, it has been added now.

odd spireBOT Aug 14, 2023, 5:58 AM

#

[python-discord/site] Checks Successful on PR: #1073 Bump coverage from 7.2.7 to 7.3.0

GitHub Actions run 5852355349 succeeded.

PR Author

Workflow Run

CI #472

Source Branch

dependabot/pip/coverage-7.3.0

odd spireBOT Aug 14, 2023, 12:18 PM

#

[python-discord/bot] Checks Successful on PR: #2720 Bump coverage from 7.2.7 to 7.3.0

GitHub Actions run 5855570356 succeeded.

PR Author

Workflow Run

CI #969

Source Branch

dependabot/pip/coverage-7.3.0

odd spireBOT Aug 14, 2023, 2:39 PM

#

[python-discord/kubernetes] Workflow Cancelled

GitHub Actions run 5857097589 was cancelled.

Actor

Lint Kubernetes manifests #407

Workflow Run

Commit

5539fe5

regal archBOT Aug 14, 2023, 8:13 PM

#

shtlrs

[python-discord/bot] Pull request review submitted: #2719 Make admins confirm edits of other users' reminders

Works great !

Just a nitpick or two, and a small bug to fix.

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

This needs to be an f-string, otherwisei it won't render.

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

The author can only be a Member to invoke this since we don't allow commands in DMs.

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

This currently says Are you sure you want to modify {{mention}}'s reminder? when you're trying to delete it, which isn't quite explicit and doesnt point the invoker to the action.

It's better to make this clearer, and IIRC you'll have access to that from ctx.command.invoked_subcommand

#

ChrisLovering

[python-discord/.github] Pull request review submitted: #22 Use github cli to checkout to fork repo branches.

regal archBOT Aug 14, 2023, 10:18 PM

#

jchristgit

[python-discord/site] Pull request closed: #1073 Bump coverage from 7.2.7 to 7.3.0

#

jchristgit

[site:main] 2 new commits

f4a3fff Bump coverage from 7.2.7 to 7.3.0 - dependabot[bot]
6c760f2 Merge pull request #1073 from python-discord/de... - jchristgit

regal archBOT Aug 14, 2023, 10:36 PM

#

novialriptide

[python-discord/bot] New comment on issue #2646: Use new markdown features in messages

This looks much nicer.

regal archBOT Aug 15, 2023, 3:27 AM

#

Xithrius

[python-discord/bot] Pull request closed: #2720 Bump coverage from 7.2.7 to 7.3.0

#

Xithrius

[bot:main] 1 new commit

97a1846 Bump coverage from 7.2.7 to 7.3.0 (#2720) - dependabot[bot]

oak estuaryBOT Aug 15, 2023, 3:30 AM

#

Python Bot

Connected!

odd spireBOT Aug 15, 2023, 3:30 AM

#

[python-discord/bot] Workflow Failed

GitHub Actions run 5863280498 failed.

Actor

Xithrius

Workflow Run

CI #970

Commit

97a1846

regal archBOT Aug 15, 2023, 11:08 AM

#

wookie184

[python-discord/bot] Pull request review submitted: #2685 Bump pydis_core to v10

regal archBOT Aug 15, 2023, 11:24 AM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1343 Add a `.rfc` utility command

This looks great, I have one suggestion.

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #1343: Add a `.rfc` utility command

I think we should link to the rfc even if the abstract is included, in case someone wants to read further.

#

wookie184

[python-discord/bot] New review comment on pull request #2682: Use `LinePaginator` from `bot-core`

I would be against changing the emoji, as it's there since it looks better than the unicode bin. I'm also not a fan of needing to pass in the constants everywhere they're needed.

One simple way around this for now would be to just create a wrapper here that passes in the necessary constants and we can just use that instead. In the future we may want to think of other ways we can have configuration for bot-core.

#

shtlrs

[python-discord/bot] New review comment on pull request #2682: Use `LinePaginator` from `bot-core`

Yeah the Emoji cannot change since it has been set to the custom one for legacy purposes.

However, regarding the Emojis as parameter part, I'm also not a biggest fan but that was one of the solutions.

I don't understand why is the paginate method a static method in the first place.

The way I'd want to do this is to instantie the Paginator in the parent package's __init__.py module and have it as a singleton. The constructor would take in the Emojis that need to be used the entire lifet...

#

wookie184

[python-discord/bot] Pull request review submitted: #2316 Ask for confirmation when banning members with elevated roles

#

wookie184

[python-discord/bot] New review comment on pull request #2316: Ask for confirmation when banning members with elevated roles

When I press confirm or cancel the buttons seem to remain on the embed, so i'm not sure that this is working. ViewWithuserAndRoleCheck only seems to remove them when the embed times out, but I think we also want to remove them when a button is pressed.

#

wookie184

[python-discord/bot] New review comment on pull request #2682: Use `LinePaginator` from `bot-core`

paginate is a classmethod, and it's there because it needs to run async code which can't be done in the __init__.

It is still a bit strange since it doesn't actually return the class, so it would probably make sense to just expose paginate as a function by itself which creates a class internally. The current class cannot just be made into a singleton though as it contains state specific to an individual pagination.

#

shtlrs

[python-discord/bot] New review comment on pull request #2682: Use `LinePaginator` from `bot-core`

I meant class method *

Well, i don't remember what it does specifically now but I'll see what I can do about it

regal archBOT Aug 15, 2023, 12:30 PM

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2718 Run fixup blocker only when the ref isn't main's HEAD

odd spireBOT Aug 15, 2023, 12:52 PM

#

[python-discord/bot] Checks Successful on PR: #2721 Bump pydantic-settings from 2.0.2 to 2.0.3

GitHub Actions run 5867263766 succeeded.

PR Author

Workflow Run

CI #971

Source Branch

dependabot/pip/pydantic-settings-2.0.3

regal archBOT Aug 15, 2023, 2:12 PM

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

Maybe the action being performed could be passed into the function instead? Although it might be redundant since a Context object is already being passed in.

I think I will stick with using ctx.command.invoked_subcommand for now.

regal archBOT Aug 15, 2023, 2:34 PM

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

Also, would it be worth changing the message in L597 to also include the modification type? I feel like doing so might imply that editing/deleting other people's reminders have different permissions when they actually don't.

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

Could you please elaborate on this? What could the docstring be changed to instead? Would something like "Prevent other users from using the view buttons." be better?

odd spireBOT Aug 15, 2023, 2:42 PM

#

[python-discord/bot] Checks Failed on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5868356404 failed.

PR Author

Workflow Run

CI #972

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

regal archBOT Aug 15, 2023, 4:58 PM

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

Actually, it could be left as is, so don't mind me.

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

Also, would it be worth changing the message in L597 to also include the modification type? I feel like doing so might imply that editing/deleting other people's reminders have different permissions when they actually don't.

No you don't need to, as that message is destined to people who don't have the rights to do anything with a reminder.

The reason I asked you to make it explicit for adminds is because it will pinpoint the action they're about to do better.

regal archBOT Aug 16, 2023, 1:43 AM

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

This can now cause ghost pings for the reminder owner. Would sending a second message instead be better?

odd spireBOT Aug 16, 2023, 1:44 AM

#

[python-discord/bot] Checks Failed on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5873685027 failed.

PR Author

Workflow Run

CI #973

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

regal archBOT Aug 16, 2023, 2:34 AM

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

If the view times out, the view doesn't get deleted so the buttons fail with "application didn't respond."
Should we manually delete the view if it timed out (with the return value of View.wait()), or should all deleting (regardless of whether it timed out) happen in _can_modify?

regal archBOT Aug 16, 2023, 8:14 AM

#

DownDev

[python-discord/bot] Issue opened: #2722 Move PEP link to title in pep command

Im reffering to this pep command

Current look:

After change:

I can work on this (not like i already did it)

regal archBOT Aug 16, 2023, 9:28 AM

#

mbaruh

[python-discord/.github] Pull request review submitted: #22 Use github cli to checkout to fork repo branches.

#

mbaruh

[python-discord/.github] Pull request closed: #22 Use github cli to checkout to fork repo branches.

#

mbaruh

[.github:main] 2 new commits

3e63963 Use gh cli to checkout to fork's branch - shtlrs
c7fc953 Merge pull request #22 from python-discord/fixu... - mbaruh

#

jchristgit

[python-discord/bot] Pull request closed: #2718 Run fixup blocker only when the ref isn't main's HEAD

#

jchristgit

[bot:main] 2 new commits

1439618 run fixup blocker when git ref isn't main - shtlrs
eedd3af Merge pull request #2718 from python-discord/ru... - jchristgit

#

jchristgit

[python-discord/bot] branch deleted: run-fixup-blocker-on-pr-only

oak estuaryBOT Aug 16, 2023, 9:41 AM

#

Python Bot

Connected!

regal archBOT Aug 16, 2023, 9:46 AM

#

ChrisLovering

[python-discord/.github] branch deleted: fixup-blocker-failing-in-forks

#

ChrisLovering

[python-discord/.github] branch deleted: events-speedrun

#

ChrisLovering

[python-discord/.github] branch deleted: supress-grep-error

#

ChrisLovering

[python-discord/.github] branch deleted: tag-speedrun-ignore-update-merged

#

ChrisLovering

[python-discord/bot] branch deleted: fail-ci-on-fixup-commits

#

ChrisLovering

[python-discord/bot] branch deleted: fixup-commit-blocker-test

#

ChrisLovering

[python-discord/bot] branch deleted: kwzrd/ci-test

#

ChrisLovering

[python-discord/bot] branch deleted: internal-dns-api

#

ChrisLovering

[python-discord/bot] branch deleted: kwzrd/unittest-parallel

#

ChrisLovering

[python-discord/bot] branch deleted: ruff-investigation

#

ChrisLovering

[python-discord/bot] branch deleted: newlines-filter-exclude-help-forum

#

ChrisLovering

[python-discord/bot] branch deleted: rule-config-fix

#

ChrisLovering

[python-discord/bot] branch deleted: test-workflow

#

ChrisLovering

[python-discord/bot] branch deleted: swfarnsworth-automated-markdown-messages

#

ChrisLovering

[python-discord/bot] branch deleted: reminders-fetch

#

ChrisLovering

[python-discord/bot] branch deleted: feature/1903/fix-channel-inconsistencies

#

ChrisLovering

[python-discord/bot] branch deleted: feature/1903/sync-cooldown-roles

#

ChrisLovering

[python-discord/bot] branch deleted: remove-caching-util

#

ChrisLovering

[python-discord/sir-lancebot] branch deleted: command-match-errors

#

ChrisLovering

[python-discord/site] branch deleted: subclassing_bot

#

ChrisLovering

[python-discord/site] branch deleted: cj9-changes

#

ChrisLovering

[python-discord/site] branch deleted: rewrite

#

ChrisLovering

[python-discord/site] branch deleted: edit-on-github

#

ChrisLovering

[python-discord/site] branch deleted: easy-docker-migrations

#

ChrisLovering

[python-discord/site] branch deleted: smarter-resources

#

ChrisLovering

[python-discord/site] branch deleted: kyler/smarter-resources

#

ChrisLovering

[python-discord/site] branch deleted: lemon/smarter-resources/tag_filtering

#

ChrisLovering

[python-discord/site] branch deleted: #298-exemption-model

#

ChrisLovering

[python-discord/site] branch deleted: filter-rewrite

#

ChrisLovering

[python-discord/king-arthur] branch deleted: bump-dep

regal archBOT Aug 16, 2023, 3:01 PM

#

ChrisLovering

[python-discord/branding] Pull request review submitted: #199 Add Snake Day branding

#

ChrisLovering

[python-discord/branding] Pull request closed: #199 Add Snake Day branding

#

ChrisLovering

[branding:main] 1 new commit

84c8333 Add Snake Day branding (#199) - gustavwilliam

#

ChrisLovering

[python-discord/branding] branch deleted: snake-day

odd spireBOT Aug 16, 2023, 3:02 PM

#

[python-discord/branding] Workflow Successful

GitHub Actions run 5880471269 succeeded.

Actor

Workflow Run

Event Validation #130

Commit

84c8333

regal archBOT Aug 16, 2023, 3:21 PM

#

ChrisLovering

[branding] Branch update-event-dates was force-pushed to `be77693`

odd spireBOT Aug 16, 2023, 3:22 PM

#

[python-discord/branding] Checks Successful on PR: #200 Update event dates for 2023-24

GitHub Actions run 5880704233 succeeded.

PR Author

Workflow Run

Event Validation #131

Source Branch

update-event-dates

regal archBOT Aug 16, 2023, 3:22 PM

#

ChrisLovering

[python-discord/branding] Pull request closed: #200 Update event dates for 2023-24

#

ChrisLovering

[branding:main] 1 new commit

cd0eedc Update event dates for 2023-24 (#200) - ChrisLovering

#

ChrisLovering

[python-discord/branding] branch deleted: update-event-dates

#

ChrisLovering

[python-discord/branding] New comment on pull request #200: Update event dates for 2023-24

Checked by tizzy in Discord

odd spireBOT Aug 16, 2023, 3:23 PM

#

[python-discord/branding] Workflow Successful

GitHub Actions run 5880721550 succeeded.

Actor

Workflow Run

Event Validation #132

Commit

cd0eedc

regal archBOT Aug 16, 2023, 4:18 PM

#

ChrisLovering

[python-discord/bot] branch deleted: listcomp-rewrite

regal archBOT Aug 16, 2023, 7:20 PM

#

wookie184

[python-discord/bot] New comment on issue #2722: Move PEP link to title in pep command

Sounds sensible, feel free to open a PR

regal archBOT Aug 16, 2023, 7:47 PM

#

DownDev

[python-discord/bot] Pull request opened: #2723 feat: move link for PEP to title in !pep command

Closes #2722

odd spireBOT Aug 16, 2023, 7:49 PM

#

[python-discord/bot] Checks Successful on PR: #2723 feat: move link for PEP to title in !pep command

GitHub Actions run 5883172651 succeeded.

PR Author

Workflow Run

CI #975

Source Branch

DownDev:main

regal archBOT Aug 17, 2023, 12:07 AM

#

ichard26

[site:update-timeline] 2 new commits

c17777f Remove #today-i-teach and add missing date - ichard26
32c61d1 Add switch to pinnward paste service - ichard26

#

ichard26

[python-discord/site] New review comment on pull request #1065: Update timeline (August 2023)

Agreed.

#

ichard26

[python-discord/site] New review comment on pull request #1065: Update timeline (August 2023)

Thanks for checking @wookie184!

odd spireBOT Aug 17, 2023, 12:10 AM

#

[python-discord/site] Checks Failed on PR: #1065 Update timeline (August 2023)

GitHub Actions run 5885095140 failed.

PR Author

Workflow Run

CI #474

Source Branch

update-timeline

regal archBOT Aug 17, 2023, 12:20 AM

#

ichard26

[site:update-timeline] 77 new commits

58a72c4 Fix broken link found by httrack (#1018) - jchristgit
9742d98 Bump sentry-sdk from 1.27.1 to 1.28.0 - dependabot[bot]
36838e1 Merge pull request #1019 from python-discord/de... - Xithrius
3c0e58b Drop redirect usage from URL references (#1016) - jchristgit
bb04110 Bump whitenoise from 6.4.0 to 6.5.0 - dependabot[bot]

#

ichard26

[python-discord/site] New comment on pull request #1065: Update timeline (August 2023)

Not sure why the builds are failing, let's see if merging in main fixes it...

odd spireBOT Aug 17, 2023, 12:22 AM

#

[python-discord/site] Checks Failed on PR: #1065 Update timeline (August 2023)

GitHub Actions run 5885195665 failed.

PR Author

Workflow Run

CI #475

Source Branch

update-timeline

odd spireBOT Aug 17, 2023, 10:33 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1345 Bump emoji from 2.7.0 to 2.8.0

GitHub Actions run 5889807708 succeeded.

PR Author

Workflow Run

Status Embed #3633

Source Branch

dependabot/pip/emoji-2.8.0

odd spireBOT Aug 17, 2023, 12:34 PM

#

[python-discord/bot] Checks Successful on PR: #2724 Bump emoji from 2.7.0 to 2.8.0

GitHub Actions run 5890926488 succeeded.

PR Author

Workflow Run

CI #976

Source Branch

dependabot/pip/emoji-2.8.0

odd spireBOT Aug 17, 2023, 2:28 PM

#

[python-discord/site] Checks Failed on PR: #1065 Update timeline (August 2023)

GitHub Actions run 5885195665 failed.

PR Author

Workflow Run

CI #475

Source Branch

update-timeline

odd spireBOT Aug 17, 2023, 4:42 PM

#

[python-discord/king-arthur] Checks Successful on PR: #94 build(deps): bump pydantic from 1.10.9 to 2.2.0

GitHub Actions run 5893614059 succeeded.

PR Author

Workflow Run

Status embed #162

Source Branch

dependabot/pip/pydantic-2...

regal archBOT Aug 17, 2023, 8:13 PM

#

p0lygun

[python-discord/forms-frontend] Fork created: p0lygun/forms-frontend

#

p0lygun

[python-discord/forms-frontend] Pull request opened: #631 fix url to `Getting Started` Notion page

The current URL to guide is broken, this a small PR to fix that

#

shtlrs

[python-discord/forms-frontend] Pull request review submitted: #631 fix url to `Getting Started` Notion page

Looks great, thanks.

regal archBOT Aug 18, 2023, 4:37 AM

#

Xithrius

[python-discord/bot] Pull request closed: #2724 Bump emoji from 2.7.0 to 2.8.0

#

Xithrius

[bot:main] 1 new commit

2ae04b0 Bump emoji from 2.7.0 to 2.8.0 (#2724) - dependabot[bot]

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #1345 Bump emoji from 2.7.0 to 2.8.0

#

Xithrius

[sir-lancebot:main] 1 new commit

4dc0f9d Bump emoji from 2.7.0 to 2.8.0 (#1345) - dependabot[bot]

night lilyBOT Aug 18, 2023, 4:39 AM

#

Sir Lancebot

Connected!

oak estuaryBOT Aug 18, 2023, 4:40 AM

#

Python Bot

Connected!

regal archBOT Aug 18, 2023, 4:40 AM

#

Xithrius

[python-discord/bot] Pull request closed: #2721 Bump pydantic-settings from 2.0.2 to 2.0.3

#

Xithrius

[bot:main] 1 new commit

5c968ee Bump pydantic-settings from 2.0.2 to 2.0.3 (#2721) - dependabot[bot]

odd spireBOT Aug 18, 2023, 4:40 AM

#

[python-discord/bot] Checks Failed on PR: #2721 Bump pydantic-settings from 2.0.2 to 2.0.3

GitHub Actions run 5898862783 failed.

PR Author

Workflow Run

CI #978

Source Branch

dependabot/pip/pydantic-settings-2.0.3

oak estuaryBOT Aug 18, 2023, 4:42 AM

#

Python Bot

Connected!

odd spireBOT Aug 18, 2023, 5:10 AM

#

[python-discord/site] Checks Successful on PR: #1074 Bump ruff from 0.0.284 to 0.0.285

GitHub Actions run 5899017916 succeeded.

PR Author

Workflow Run

CI #476

Source Branch

dependabot/pip/ruff-0.0.285

regal archBOT Aug 18, 2023, 6:18 AM

#

shtlrs

[python-discord/bot] Pull request review submitted: #2723 feat: move link for PEP to title in !pep command

Didn't test this, but looks good & safe. Thanks.

#

shtlrs

[python-discord/bot] New review comment on pull request #2719: Make admins confirm edits of other users' reminders

We recently had a discussion about deleting messages like this. And it's not something we want to keep on doing.
Let's keep the view, but delete the buttons.

regal archBOT Aug 18, 2023, 8:01 AM

#

DownDev

[python-discord/bot] New comment on issue #2692: Automatically close help thread on ban

Can i work on this?

odd spireBOT Aug 18, 2023, 10:13 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1346 Bump ruff from 0.0.284 to 0.0.285

GitHub Actions run 5901453250 succeeded.

PR Author

Workflow Run

Status Embed #3635

Source Branch

dependabot/pip/ruff-0.0.285

regal archBOT Aug 18, 2023, 11:05 AM

#

jchristgit

[python-discord/site] New comment on pull request #1074: Bump ruff from 0.0.284 to 0.0.285

@lemonsaurus dog

#

jchristgit

[python-discord/site] Pull request closed: #1074 Bump ruff from 0.0.284 to 0.0.285

#

jchristgit

[site:main] 2 new commits

a611283 Bump ruff from 0.0.284 to 0.0.285 - dependabot[bot]
3cc489b Merge pull request #1074 from python-discord/de... - jchristgit

regal archBOT Aug 18, 2023, 11:29 AM

#

jchristgit

[python-discord/site] New comment on pull request #1065: Update timeline (August 2023)

Hm I'm a bit confused why they fail as well. @shtlrs I do not see fixup commits in the commit history on GitHub, do you have an idea why the test fails?

regal archBOT Aug 18, 2023, 11:45 AM

#

shtlrs

[python-discord/site] New branch created: timeline-branch-copy

#

shtlrs

[site] Branch timeline-branch-copy was force-pushed to `b099d4e`

#

shtlrs

[python-discord/site] Pull request opened: #1075 Timeline branch copy

This PR is only a copy of #1065 to test something related to our commit history.

This will be deleted in a few minutes, please ingore.

#

shtlrs

[site] Branch timeline-branch-copy was force-pushed to `2d4b938`

odd spireBOT Aug 18, 2023, 11:48 AM

#

[python-discord/site] Checks Cancelled on PR: #1075 Timeline branch copy

GitHub Actions run 5902234690 was cancelled.

PR Author

Workflow Run

CI #478

Source Branch

timeline-branch-copy

#

[python-discord/site] Checks Successful on PR: #1075 Timeline branch copy

GitHub Actions run 5902238968 succeeded.

PR Author

Workflow Run

CI #479

Source Branch

timeline-branch-copy

regal archBOT Aug 18, 2023, 11:51 AM

#

shtlrs

[python-discord/site] New comment on pull request #1075: Timeline branch copy

Tests are done, closing this.

#

shtlrs

[python-discord/site] Pull request closed: #1075 Timeline branch copy

odd spireBOT Aug 18, 2023, 11:54 AM

#

[python-discord/bot] Checks Failed on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5902279425 failed.

PR Author

Workflow Run

CI #980

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

regal archBOT Aug 18, 2023, 11:58 AM

#

shtlrs

[.github:do-not-checkout-fork] 1 new commit

90da58a Do not checkout the fork's branch - shtlrs

#

shtlrs

[python-discord/.github] New branch created: do-not-checkout-fork

#

shtlrs

[python-discord/.github] Pull request opened: #23 Do not checkout the fork's branch upon history comparison

Reasoning

Generally, when using the pull_request event as trigger for our CI, it uses the fork's CI context, allowing malicious users to tamper with CI.

We are switching to using pull_request_target as event, which ensures that CI is executed with our repo's context.

The main condition to using this is to not checkout nor execute the fork's code.

Solution

The approach was to add the fork as remote, but we only make a fetch operation instead of a checkout one, ...

odd spireBOT Aug 18, 2023, 12:07 PM

#

[python-discord/bot] Checks Successful on PR: #2725 Bump ruff from 0.0.284 to 0.0.285

GitHub Actions run 5902390209 succeeded.

PR Author

Workflow Run

CI #981

Source Branch

dependabot/pip/ruff-0.0.285

regal archBOT Aug 18, 2023, 12:14 PM

#

shtlrs

[python-discord/site] New comment on pull request #1065: Update timeline (August 2023)

@ichard26 @jchristgit
The base of the branch is very old, so it needs to be updated.
Looking at the commit history of main, I see this

What you need to do is

Remove the merge commit your just did: git reset --hard 32c61d1ddf15c9ef68183b998323167c6f038845
Checkout to main, and update it

git checkout main
git pull

Checkout to your branch git checkout -
4....

odd spireBOT Aug 18, 2023, 1:51 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1343 Add a `.rfc` utility command

GitHub Actions run 5903428822 succeeded.

PR Author

Workflow Run

Status Embed #3636

Source Branch

SomeHybrid:main

regal archBOT Aug 18, 2023, 1:52 PM

#

SomeHybrid

[python-discord/sir-lancebot] New comment on pull request #1343: Add a `.rfc` utility command

Demo screenshot here :)
<img width="663" alt="Screenshot 2023-08-18 at 20 51 40" src="https://github.com/python-discord/sir-lancebot/assets/91648368/f7ca1e16-861f-4f85-9f5c-eff1188ddc07">

regal archBOT Aug 18, 2023, 2:50 PM

#

jchristgit

[python-discord/site] New comment on pull request #1065: Update timeline (August 2023)

Thanks for the help!

#

shtlrs

[python-discord/site] Issue opened: #1076 Mention detailed guide to setting up redis for sir-lancebot

Recently, a contrib had issues setting up redis on sir-lancebot, and they started running into connection problems.

Up until today, I ran into the same issue, and it was the fact that redis_use_fakeredis wasn't set in my .env variable.

After some debugging, I realized that it was a host issue, as it needs to be set to redis for the two containers to be able to talk to each other over the docker network.

Looking at the docs now, it's only mentioned in the extended guide of `...

#

shtlrs

[python-discord/site] New comment on pull request #1065: Update timeline (August 2023)

Thanks for the help!

Winning 💪 💪 !!

odd spireBOT Aug 18, 2023, 4:53 PM

#

[python-discord/king-arthur] Checks Successful on PR: #95 build(deps): bump pydantic from 1.10.9 to 2.2.1

GitHub Actions run 5905107422 succeeded.

PR Author

Workflow Run

Status embed #163

Source Branch

dependabot/pip/pydantic-2...

#

[python-discord/king-arthur] Checks Successful on PR: #96 build(deps-dev): bump ruff from 0.0.270 to 0.0.285

GitHub Actions run 5905115103 succeeded.

PR Author

Workflow Run

Status embed #164

Source Branch

dependabot/pip/ruff-0.0.285

regal archBOT Aug 19, 2023, 2:16 AM

#

ichard26

[site] Branch update-timeline was force-pushed to `1c8ba18`

#

ichard26

[site] Branch update-timeline was force-pushed to `8967020`

odd spireBOT Aug 19, 2023, 2:17 AM

#

[python-discord/site] Checks Cancelled on PR: #1065 Update timeline (August 2023)

GitHub Actions run 5908922428 was cancelled.

PR Author

Workflow Run

CI #480

Source Branch

update-timeline

#

[python-discord/site] Checks Successful on PR: #1065 Update timeline (August 2023)

GitHub Actions run 5908924447 succeeded.

PR Author

Workflow Run

CI #481

Source Branch

update-timeline

regal archBOT Aug 19, 2023, 1:46 PM

#

wookie184

[python-discord/site] Pull request review submitted: #1065 Update timeline (August 2023)

This is great, thanks for doing this

regal archBOT Aug 19, 2023, 2:01 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1343 Add a `.rfc` utility command

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #1343: Add a `.rfc` utility command

Not that important but just a thought:

    @commands.cooldown(2, 10, commands.BucketType.user)

Given the responses are cached and it's just static content being fetched one every 10 seconds feels a bit strict (e.g. if someone mistyped). Could be even less strict than 2 per 10s as well, I don't really mind.

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #1343: Add a `.rfc` utility command

The ) is missing, so this doesn't show properly any more, e.g.:

Since the link is always in the title now though I think we can just remove this and have no description if there's no abstract.

#

wookie184

[python-discord/bot] Pull request closed: #2725 Bump ruff from 0.0.284 to 0.0.285

#

wookie184

[bot:main] 1 new commit

f59244f Bump ruff from 0.0.284 to 0.0.285 (#2725) - dependabot[bot]

oak estuaryBOT Aug 19, 2023, 2:05 PM

#

Python Bot

Connected!

regal archBOT Aug 19, 2023, 2:07 PM

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1346 Bump ruff from 0.0.284 to 0.0.285

#

wookie184

[sir-lancebot:main] 1 new commit

a47fef6 Bump ruff from 0.0.284 to 0.0.285 (#1346) - dependabot[bot]

night lilyBOT Aug 19, 2023, 2:09 PM

#

Sir Lancebot

Connected!

regal archBOT Aug 19, 2023, 2:10 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #2723 feat: move link for PEP to title in !pep command

Good improvement, thanks

#

wookie184

[python-discord/bot] Pull request closed: #2723 feat: move link for PEP to title in !pep command

#

wookie184

[bot:main] 1 new commit

4f4eef6 feat: move link for PEP to title in !pep comman... - DownDev

#

wookie184

[python-discord/bot] Issue closed: #2722 Move PEP link to title in pep command

odd spireBOT Aug 19, 2023, 2:13 PM

#

[python-discord/bot] Checks Failed on PR: #2723 feat: move link for PEP to title in !pep command

GitHub Actions run 5911874841 failed.

PR Author

Workflow Run

CI #983

Source Branch

DownDev:main

oak estuaryBOT Aug 19, 2023, 2:15 PM

#

Python Bot

Connected!

regal archBOT Aug 20, 2023, 12:58 AM

#

MarkKoz

[snekbox:feat/158/multi-version] 3 new commits

4244bfb Remove explicit package versions from Dockerfile - MarkKoz
dc89adc Update base images to Bookworm - MarkKoz
40829f8 Install multiple Python versions in image - MarkKoz

#

MarkKoz

[python-discord/snekbox] New branch created: feat/158/multi-version

regal archBOT Aug 20, 2023, 1:16 AM

#

MarkKoz

[snekbox] Branch feat/158/multi-version was force-pushed to `b0a4133`

regal archBOT Aug 20, 2023, 3:34 AM

#

MarkKoz

[snekbox] Branch feat/158/multi-version was force-pushed to `83d2561`

#

MarkKoz

[snekbox] Branch feat/158/multi-version was force-pushed to `e423b7c`

#

MarkKoz

[python-discord/snekbox] Pull request opened: #181 Feat/158/multi version

Closes #175
This is an alternative implementation to #178

Currently, this is a draft that just focuses on getting multiple Python interpreter versions into the image. Later, this PR will be updated with API changes as well. The goal for the API is for users to be able to pass an arbitrary path to an executable binary (e.g. a path to a different Python interpreter).

du -h --max-depth=1 /lang/python
93M	/lang/python/3.11
88M	/lang/python/3.12
181M	/lang/python

I observed...

regal archBOT Aug 20, 2023, 4:11 AM

#

[snekbox] GitHub Actions checks failure on pull request #181

#

MarkKoz

[snekbox:feat/158/multi-version] 1 new commit

0b0b0fd Fix numpy install for test - MarkKoz

#

[snekbox] GitHub Actions checks success on pull request #181

regal archBOT Aug 20, 2023, 9:44 AM

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #1331: AttributeError: '_Client' object has no attribute 'github_bot_repo'

Hi! @wookie184 I would like to work upon this issue. Can you please assign it to me.
Thank You.

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1331: AttributeError: '_Client' object has no attribute 'github_bot_repo'

Hi! @wookie184 I would like to work upon this issue. Can you please assign it to me. Thank You.

Sure, i've assigned you.

regal archBOT Aug 20, 2023, 10:04 AM

#

wookie184

[python-discord/bot] Pull request review submitted: #2719 Make admins confirm edits of other users' reminders

Nice, thanks for working on this.

regal archBOT Aug 20, 2023, 12:21 PM

#

jchristgit

[python-discord/site] Pull request review submitted: #1065 Update timeline (August 2023)

Ja. Maschine!

#

jchristgit

[python-discord/site] Pull request closed: #1065 Update timeline (August 2023)

#

jchristgit

[site:main] 4 new commits

2f0556d Update timeline (August 2023) - ichard26
e023838 Remove #today-i-teach and add missing date - ichard26
8967020 Add switch to pinnward paste service - ichard26
7453c2f Merge pull request #1065 from python-discord/up... - jchristgit

#

jchristgit

[python-discord/site] branch deleted: update-timeline

regal archBOT Aug 20, 2023, 5:08 PM

#

wookie184

[sir-lancebot] Branch upgrade-pydantic-2 was force-pushed to `45fed91`

odd spireBOT Aug 20, 2023, 5:09 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1321 Update to pydantic 2.0

GitHub Actions run 5918625376 succeeded.

PR Author

wookie184

Workflow Run

Status Embed #3638

Source Branch

upgrade-pydantic-2

regal archBOT Aug 20, 2023, 5:47 PM

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #1347 TypeError: Embed.__init__() got an unexpected keyword argument 'name'

Sentry Issue: SIR-LANCEBOT-AH

TypeError: Embed.__init__() got an unexpected keyword argument 'name'
  File "bot/exts/holidays/halloween/monstersurvey.py", line 111, in monster_vote
    vote_embed = Embed(

Unhandled command error: Embed.__init__() got an unexpected keyword argument 'name'

regal archBOT Aug 20, 2023, 6:17 PM

#

ekand

[python-discord/sir-lancebot] New comment on issue #1347: TypeError: Embed.__init__() got an unexpected keyword argument 'name'

I'm interested in working on this. I will start by trying to reproduce the error in Gitpod.

#

shtlrs

[python-discord/sir-lancebot] New comment on issue #1347: TypeError: Embed.__init__() got an unexpected keyword argument 'name'

Sure thing, I'll assign you.

regal archBOT Aug 20, 2023, 6:43 PM

#

shtlrs

[python-discord/sir-lancebot] New comment on issue #1347: TypeError: Embed.__init__() got an unexpected keyword argument 'name'

To give you context that you might be missing from sentry, it seems to happen when running this command

.monster vote goofy

regal archBOT Aug 20, 2023, 7:00 PM

#

ekand

[python-discord/sir-lancebot] New comment on issue #1347: TypeError: Embed.__init__() got an unexpected keyword argument 'name'

Thanks. That'll probably help.

regal archBOT Aug 20, 2023, 8:46 PM

#

parth-verma7

[python-discord/sir-lancebot] Pull request opened: #1348 Corrected attribute name to fetch github url in extensions.py

Relevant Issues

Description

Did you:

[ ] Join the Python Discord Community?
[ ] Read all the comments in this template?
[ ] Ensure there is an issue open, or link relevant discord discussions?
[ ] Read and agree to the contributing guidelines?

odd spireBOT Aug 20, 2023, 8:47 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1348 Corrected attribute name to fetch github url in extensions.py

GitHub Actions run 5919528632 succeeded.

PR Author

parth-verma7

Workflow Run

Status Embed #3639

Source Branch

parth-verma7:bug

regal archBOT Aug 20, 2023, 9:00 PM

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #1034: Add a Wordle command

@dannynotsmart I would like to work upon this issue. I got a 5 letter word txt file and I would like to accomplish the task2 for now. Please assign it to me. Thank You.

regal archBOT Aug 20, 2023, 9:43 PM

#

shtlrs

[python-discord/sir-lancebot] Pull request review submitted: #1348 Corrected attribute name to fetch github url in extensions.py

Thanks!

regal archBOT Aug 20, 2023, 11:19 PM

#

ekand

[python-discord/sir-lancebot] Pull request opened: #1349 Use title as parameter name for Embed in monster_vote

Relevant Issues

Closes #1347

Description

Change parameter name from name to title in a call to Embed in monstersurvey.py.

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read and agree to the contributing guidelines?

odd spireBOT Aug 20, 2023, 11:20 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1349 Use title as parameter name for Embed in monster_vote

GitHub Actions run 5920166231 succeeded.

PR Author

ekand

Workflow Run

Status Embed #3640

Source Branch

ekand:main

regal archBOT Aug 21, 2023, 2:09 AM

#

ichard26

[python-discord/site] New comment on pull request #1065: Update timeline (August 2023)

Oh, where are my manners?! Thank you very much @shtlrs for investigating and helping me with getting the CI to pass! :lemon:

regal archBOT Aug 21, 2023, 3:07 AM

#

shtlrs

[python-discord/site] New comment on pull request #1065: Update timeline (August 2023)

You're very much welcome! @ichard26

#

shtlrs

[python-discord/sir-lancebot] Pull request review submitted: #1349 Use title as parameter name for Embed in monster_vote

Thanks for fixing this!

#

HassanAbouelela

[python-discord/bot] New comment on issue #2679: Code snippets for paste service links

Issue approved, please leave a comment if you'd like to work on it.

#

HassanAbouelela

[python-discord/bot] New comment on issue #2646: Use new markdown features in messages

I'm giving this issue a limited approval. Switching lists to markdown seems fine, however please comment here if you wish to change something else with examples as shown in previous comment.

regal archBOT Aug 21, 2023, 7:14 AM

#

DownDev

[python-discord/bot] New comment on issue #2646: Use new markdown features in messages

I would like to be assigned

regal archBOT Aug 21, 2023, 8:47 AM

#

HassanAbouelela

[python-discord/bot] New comment on issue #2646: Use new markdown features in messages

You've been assigned, feel free to reach out in the dev-contrib channel if you have any questions. Good luck!

regal archBOT Aug 21, 2023, 9:11 AM

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #870: Unwanted error handling in command suggestions.

@Qwerty-133 Actually this has already been fixed. Please have a look.

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #1082: Add number guessing game

@Diabolical5777 I would like to work upon this feature issue. Please assign it to me.
Thank You.

regal archBOT Aug 21, 2023, 10:10 AM

#

wookie184

[python-discord/sir-lancebot] New comment on issue #870: Unwanted error handling in command suggestions.

Yeah, looks like it was fixed by https://github.com/python-discord/sir-lancebot/pull/1096, thanks

#

wookie184

[python-discord/sir-lancebot] Issue closed: #870 Unwanted error handling in command suggestions.

regal archBOT Aug 21, 2023, 12:00 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1349 Use title as parameter name for Embed in monster_vote

Tested and this now works as expected, thanks for the PR!

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1349 Use title as parameter name for Embed in monster_vote

#

wookie184

[python-discord/sir-lancebot] Issue closed: #1347 TypeError: Embed.__init__() got an unexpected keyword argument 'name'

#

wookie184

[sir-lancebot:main] 1 new commit

2a0d2f2 Use title as parameter name for Embed in monste... - ekand

night lilyBOT Aug 21, 2023, 12:02 PM

#

Sir Lancebot

Connected!

regal archBOT Aug 21, 2023, 12:05 PM

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1082: Add number guessing game

I'll mark this as approved.

@parth-verma7: As @Diabolical5777 indicated they would like to work on this first and were just waiting for approval, i'll give them a few days to indicate they would still like to do this if they are still interested. If they are not interested i'll put it up for grabs and you can take it.

#

wookie184

[python-discord/bot] New comment on issue #2646: Use new markdown features in messages

I'm giving this issue a limited approval. Switching lists to markdown seems fine, however please comment here if you wish to change something else with examples as shown in previous comment.

The previous example does not show other changes, only switching to markdown.

#

HassanAbouelela

[python-discord/bot] New comment on issue #2646: Use new markdown features in messages

I'm aware, I'm asking for examples if they decide to change something else.

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1348 Corrected attribute name to fetch github url in extensions.py

Tested and works as expected, thanks

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1348 Corrected attribute name to fetch github url in extensions.py

#

wookie184

[sir-lancebot:main] 1 new commit

b4ab162 Corrected attribute name to fetch github url in... - parth-verma7

odd spireBOT Aug 21, 2023, 12:22 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1348 Corrected attribute name to fetch github url in extensions.py

GitHub Actions run 5926160036 succeeded.

PR Author

parth-verma7

Workflow Run

Status Embed #3642

Source Branch

parth-verma7:bug

night lilyBOT Aug 21, 2023, 12:24 PM

#

Sir Lancebot

Connected!

regal archBOT Aug 21, 2023, 12:50 PM

#

DownDev

[python-discord/bot] Pull request opened: #2726 feat: use new markdown feature in new help channel message

Closes #2646

odd spireBOT Aug 21, 2023, 12:52 PM

#

[python-discord/bot] Checks Successful on PR: #2726 feat: use new markdown feature in new help channel message

GitHub Actions run 5926462257 succeeded.

PR Author

Workflow Run

CI #985

Source Branch

DownDev:fix-2646

regal archBOT Aug 21, 2023, 1:03 PM

#

sentry-io[bot]

[python-discord/bot] Issue opened: #2727 AttributeError: 'DMChannel' object has no attribute 'mention'

Sentry Issue: BOT-3KT

AttributeError: 'DMChannel' object has no attribute 'mention'
  File "bot/exts/filtering/_filter_lists/antispam.py", line 131, in process_deletion_context
    await deletion_context.send_alert(self)
  File "bot/exts/filtering/_filter_lists/antispam.py", line 192, in send_alert
    embed = await build_mod_alert(new_ctx, {antispam_list: messages})
  File "bot/exts/filtering/_ui/ui.py", ...

#

mbaruh

[python-discord/bot] New comment on issue #2727: AttributeError: 'DMChannel' object has no attribute 'mention'

Antispam should just ignore the DM channel honestly, that has several issues now that I think about it.

So around this line https://github.com/python-discord/bot/blob/4f4eef6c1701b844a4bb1bc21e6de2b53aa72843/bot/exts/filtering/_filter_lists/antispam.py#L69 we can filter out DM messages.

regal archBOT Aug 21, 2023, 1:39 PM

#

ChrisLovering

[python-discord/bot] New comment on issue #2727: AttributeError: 'DMChannel' object has no attribute 'mention'

Antispam should just ignore the DM channel honestly, that has several issues now that I think about it.

Is there a way to filter those message out of the FilterContext.message_cache before this function even gets hit, or is it too generic up the chain?

regal archBOT Aug 21, 2023, 2:28 PM

#

ChrisLovering

[king-arthur:main] 2 new commits

46f8c73 Bump dependencies to latest - ChrisLovering
63fa199 Pull manifest from infra repo - ChrisLovering

odd spireBOT Aug 21, 2023, 2:31 PM

#

[python-discord/king-arthur] Workflow Successful

GitHub Actions run 5927645867 succeeded.

Actor

Workflow Run

Status embed #165

Commit

63fa199

#

[python-discord/king-arthur] Checks Successful on PR: #95 build(deps): bump pydantic from 1.10.9 to 2.2.1

GitHub Actions run 5927647636 succeeded.

PR Author

Workflow Run

Status embed #166

Source Branch

dependabot/pip/pydantic-2...

regal archBOT Aug 21, 2023, 2:36 PM

#

mbaruh

[python-discord/bot] New comment on issue #2727: AttributeError: 'DMChannel' object has no attribute 'mention'

yeah the cache is used for other stuff so it shouldn't be filtered out there.

#

ChrisLovering

[bot-core:Bump-d.py] 1 new commit

908a30d Bump d.py to 2.3.2 - ChrisLovering

#

ChrisLovering

[python-discord/bot-core] New branch created: Bump-d.py

#

ChrisLovering

[python-discord/bot-core] Pull request opened: #192 Bump d.py to 2.3.2

#

mbaruh

[python-discord/bot] New comment on issue #2727: AttributeError: 'DMChannel' object has no attribute 'mention'

Well actually I guess a solution would be to just change the antispam config to not run in DMs, no code changes

#

ChrisLovering

[king-arthur:bump-pydantic] 1 new commit

4c7be21 Use pydantic-settings for config - ChrisLovering

#

ChrisLovering

[python-discord/king-arthur] New branch created: bump-pydantic

#

ChrisLovering

[python-discord/king-arthur] Pull request opened: #97 Use pydantic-settings for config

#

ChrisLovering

[king-arthur:bump-pydantic] 1 new commit

2b4e56b Remove isort config - ChrisLovering

odd spireBOT Aug 21, 2023, 2:56 PM

#

[python-discord/king-arthur] Checks Cancelled on PR: #97 Use pydantic-settings for config

GitHub Actions run 5927930052 was cancelled.

PR Author

Workflow Run

Status embed #167

Source Branch

bump-pydantic

regal archBOT Aug 21, 2023, 2:57 PM

#

ChrisLovering

[python-discord/king-arthur] Pull request closed: #97 Use pydantic-settings for config

#

ChrisLovering

[king-arthur:main] 3 new commits

4c7be21 Use pydantic-settings for config - ChrisLovering
2b4e56b Remove isort config - ChrisLovering
e961774 Merge pull request #97 from python-discord/bump... - ChrisLovering

#

ChrisLovering

[python-discord/king-arthur] branch deleted: bump-pydantic

odd spireBOT Aug 21, 2023, 2:58 PM

#

[python-discord/king-arthur] Checks Successful on PR: #97 Use pydantic-settings for config

GitHub Actions run 5927946790 succeeded.

PR Author

Workflow Run

Status embed #168

Source Branch

bump-pydantic

#

[python-discord/king-arthur] Workflow Successful

GitHub Actions run 5927976733 succeeded.

Actor

Workflow Run

Status embed #169

Commit

e961774

regal archBOT Aug 21, 2023, 3:18 PM

#

ChrisLovering

[king-arthur:use-infra-md-rule-doc] 1 new commit

54f8327 Pull devops rules from Github, not notion - ChrisLovering

#

ChrisLovering

[python-discord/king-arthur] New branch created: use-infra-md-rule-doc

#

ChrisLovering

[python-discord/king-arthur] Pull request opened: #98 Pull devops rules from Github, not notion

This logic assumes each line is one rule.

odd spireBOT Aug 21, 2023, 3:20 PM

#

[python-discord/king-arthur] Checks Successful on PR: #98 Pull devops rules from Github, not notion

GitHub Actions run 5928226449 succeeded.

PR Author

Workflow Run

Status embed #170

Source Branch

use-infra-md-rule-doc

regal archBOT Aug 21, 2023, 3:25 PM

#

DownDev

[python-discord/bot] New comment on issue #2679: Code snippets for paste service links

I can work on this when supakeen/pinnwand#194 is done and merged.

regal archBOT Aug 21, 2023, 3:46 PM

#

ChrisLovering

[king-arthur] Branch use-infra-md-rule-doc was force-pushed to `c977645`

odd spireBOT Aug 21, 2023, 3:48 PM

#

[python-discord/king-arthur] Checks Successful on PR: #98 Pull devops rules from Github, not notion

GitHub Actions run 5928528496 succeeded.

PR Author

Workflow Run

Status embed #171

Source Branch

use-infra-md-rule-doc

regal archBOT Aug 21, 2023, 3:48 PM

#

ChrisLovering

[king-arthur] Branch use-infra-md-rule-doc was force-pushed to `08a46bc`

odd spireBOT Aug 21, 2023, 3:50 PM

#

[python-discord/king-arthur] Checks Successful on PR: #98 Pull devops rules from Github, not notion

GitHub Actions run 5928548923 succeeded.

PR Author

Workflow Run

Status embed #172

Source Branch

use-infra-md-rule-doc

night lilyBOT Aug 21, 2023, 4:03 PM

#

Sir Lancebot

Connected!

regal archBOT Aug 21, 2023, 4:17 PM

#

jchristgit

[python-discord/king-arthur] New review comment on pull request #98: Pull devops rules from Github, not notion

shouldn't we pass maxsplit?

#

ChrisLovering

[king-arthur] Branch use-infra-md-rule-doc was force-pushed to `f8065f5`

Yea, nice spot https://github.com/python-discord/king-arthur/compare/08a46bc7f7942f666b7d12d7b84620b8a3c1bd19..f8065f5d88f5a2e975374b940f361f5af73ac855

#

ChrisLovering

[python-discord/king-arthur] New review comment on pull request #98: Pull devops rules from Github, not notion

#

ChrisLovering

[python-discord/king-arthur] Pull request closed: #82 build(deps-dev): bump black from 23.3.0 to 23.7.0

#

ChrisLovering

[python-discord/king-arthur] Pull request closed: #85 build(deps): bump aiohttp from 3.8.4 to 3.8.5

#

ChrisLovering

[python-discord/king-arthur] Pull request closed: #71 build(deps-dev): bump pre-commit from 3.3.2 to 3.3.3

odd spireBOT Aug 21, 2023, 4:34 PM

#

[python-discord/king-arthur] Checks Successful on PR: #98 Pull devops rules from Github, not notion

GitHub Actions run 5928993266 succeeded.

PR Author

Workflow Run

Status embed #173

Source Branch

use-infra-md-rule-doc

regal archBOT Aug 21, 2023, 6:19 PM

#

DownDev

[python-discord/bot] Issue opened: #2728 Syntax error in `!dotenv` command

In this tag there is a syntax error right there

regal archBOT Aug 22, 2023, 3:54 AM

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #1082: Add number guessing game

@wookie184 sure, I am open to solving issues:)

regal archBOT Aug 22, 2023, 1:31 PM

#

ChrisLovering

[python-discord/king-arthur] Pull request closed: #98 Pull devops rules from Github, not notion

#

ChrisLovering

[king-arthur:main] 1 new commit

f95ef39 Pull devops rules from Github, not notion (#98) - ChrisLovering

#

ChrisLovering

[python-discord/king-arthur] branch deleted: use-infra-md-rule-doc

#

ChrisLovering

[king-arthur:main] 1 new commit

da13888 Correct tuple typehint in config - ChrisLovering

odd spireBOT Aug 22, 2023, 1:33 PM

#

[python-discord/king-arthur] Workflow Cancelled

GitHub Actions run 5939563753 was cancelled.

Actor

Workflow Run

Status embed #174

Commit

da13888

#

[python-discord/king-arthur] Workflow Successful

GitHub Actions run 5939584490 succeeded.

Actor

Workflow Run

Status embed #175

Commit

da13888

regal archBOT Aug 22, 2023, 1:38 PM

#

ChrisLovering

[python-discord/metricity] branch deleted: message-sync-command

#

ChrisLovering

[python-discord/metricity] Pull request closed: #11 Message sync command

#

ChrisLovering

[python-discord/metricity] Pull request closed: #61 Bump pydis-core from 9.6.0 to 10.1.0

#

ChrisLovering

[python-discord/metricity] Pull request closed: #60 Bump various versions

#

ChrisLovering

[metricity:main] 7 new commits

9cb0fae Bump core dependencies - ChrisLovering
4c75401 Move linting to ruff - ChrisLovering
28c903b Update code style for new ruff rules - ChrisLovering
ded7118 Update CI to use ruff linting - ChrisLovering
e690eb4 Update CI action versions - ChrisLovering

#

ChrisLovering

[python-discord/metricity] branch deleted: bump-various-versions

#

ChrisLovering

[python-discord/metricity] New tag created: v2.1.0

#

ChrisLovering

[python-discord/metricity] New tag created: v2.0.1

#

ChrisLovering

[metricity:main] 1 new commit

37beaa5 Create Path object once whne loading config - ChrisLovering

#

ChrisLovering

[metricity:reusable-workflows-in-CI] 1 new commit

aeb3a01 Update CI to use reusable workflows and push an... - ChrisLovering

#

ChrisLovering

[python-discord/metricity] New branch created: reusable-workflows-in-CI

#

ChrisLovering

[python-discord/metricity] Pull request opened: #66 Update CI to use reusable workflows and push an image on release

#

ChrisLovering

[metricity] Branch reusable-workflows-in-CI was force-pushed to `ac00c28`

#

ChrisLovering

[metricity] Branch reusable-workflows-in-CI was force-pushed to `c4a6ed4`

#

ChrisLovering

[metricity] Branch reusable-workflows-in-CI was force-pushed to `56cf6fc`

#

ChrisLovering

[metricity] Branch reusable-workflows-in-CI was force-pushed to `aea3c43`

#

ChrisLovering

[python-discord/metricity] Pull request closed: #66 Update CI to use reusable workflows and push an image on release

#

ChrisLovering

[metricity:main] 1 new commit

16fc6c2 Update CI to use reusable workflows and push an... - ChrisLovering

#

ChrisLovering

[python-discord/metricity] branch deleted: reusable-workflows-in-CI

#

ChrisLovering

[metricity:main] 2 new commits

fd9163b Remove unused tox.ini - ChrisLovering
051e37d Checkout code in deploy step - ChrisLovering

#

ChrisLovering

[metricity:main] 1 new commit

fe0f98c Ensure images are pushed to ghcr on push to main - ChrisLovering

#

ChrisLovering

[metricity:main] 1 new commit

9ac345b Bump version in pyproject.toml - ChrisLovering

#

ChrisLovering

[python-discord/metricity] New tag created: v2.2.0

#

ChrisLovering

[metricity:main] 1 new commit

c780e6f Only trigger CI on release for published releases - ChrisLovering

odd spireBOT Aug 22, 2023, 4:32 PM

#

[python-discord/king-arthur] Checks Successful on PR: #99 build(deps): bump kubernetes-asyncio from 24.2.3 to 25.11.0

GitHub Actions run 5941547027 succeeded.

PR Author

Workflow Run

Status embed #176

Source Branch

dependabot/pip/kubernetes...

regal archBOT Aug 22, 2023, 6:45 PM

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #1082: Add number guessing game

@Diabolical5777 are you currently working upon this issue?

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #73: Seasonal information

@brad90four Hi! I would like to work upon this issue. Please assign it to me.
Thank You!

#

n0Oo0Oo0b

[python-discord/sir-lancebot] New comment on issue #985: Sudoku command

@DMFriends I would like to have a go at this.

regal archBOT Aug 22, 2023, 7:28 PM

#

parth-verma7

[python-discord/sir-lancebot] Issue opened: #1350 .gh user <github_username> returning multiple instances of result

Description

Expected Behaviour

Actual Behaviour

#

shtlrs

[python-discord/sir-lancebot] New comment on issue #1350: .gh user <github_username> returning multiple instances of result

This doesn't seem to be the case in production.

Are you sure you don't have 2 instances of your bot process running?

#

DMFriends

[python-discord/sir-lancebot] New comment on issue #985: Sudoku command

@DMFriends I would like to have a go at this.

Go ahead! Good luck!

#

ChrisLovering

[bot-core:Bump-d.py] 1 new commit

c200a01 Add pydantic BaseModel to target to ignore - ChrisLovering

#

jchristgit

[python-discord/bot-core] Pull request review submitted: #192 Bump d.py to 2.3.2

deutsche dogge

#

jchristgit

[python-discord/bot-core] New comment on pull request #192: Bump d.py to 2.3.2

@lemonsaurus dog

regal archBOT Aug 22, 2023, 9:48 PM

#

shtlrs

[.github:do-not-checkout-fork] 1 new commit

f92f7ce Add ANSI codes to colorize the logs - shtlrs

#

shtlrs

[.github] Branch do-not-checkout-fork was force-pushed to `ccb9822`

#

shtlrs

[.github] Branch do-not-checkout-fork was force-pushed to `7d668b1`

regal archBOT Aug 22, 2023, 10:21 PM

#

shtlrs

[.github] Branch do-not-checkout-fork was force-pushed to `8e7f15c`

#

shtlrs

[.github] Branch do-not-checkout-fork was force-pushed to `7936659`

#

shtlrs

[.github] Branch do-not-checkout-fork was force-pushed to `9904284`

regal archBOT Aug 22, 2023, 11:19 PM

#

brad90four

[python-discord/sir-lancebot] New comment on issue #73: Seasonal information

Tagging @Xithrius , any issues with assigning this to @parth-verma7 ?

regal archBOT Aug 23, 2023, 12:45 AM

#

Xithrius

[python-discord/sir-lancebot] New comment on issue #73: Seasonal information

I have no objections.

regal archBOT Aug 23, 2023, 3:21 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #1323 Snakes cleanup

regal archBOT Aug 23, 2023, 6:21 AM

#

MarkKoz

[python-discord/snekbox] Issue opened: #182 Make test_multiprocessing_shared_memory_disabled compatible with newer versions of glibc

The test_multiprocessing_shared_memory_disabled asserts that ENOSYS occurs. This comes from SHM_GET_NAME which comes from shm_open which comes from here in CPython. This works with Debian Bullseye which is on glibc 2.31.

However...

regal archBOT Aug 23, 2023, 9:32 AM

#

wookie184

[sir-lancebot:snakes-cleanup] 40 new commits

f0e2048 Undeprecate Bookmark Command - Robin5605
6972544 Merge branch 'python-discord:main' into undepre... - Robin5605
d4976e3 Remove typing.Union import - Robin5605
244be23 Fix build_bookmark_embed formatting issue - Robin5605
e38e090 Merge branch 'main' into undeprecate-bookmark - Robin5605

odd spireBOT Aug 23, 2023, 9:34 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1323 Snakes cleanup

GitHub Actions run 5949595951 succeeded.

PR Author

wookie184

Workflow Run

Status Embed #3644

Source Branch

snakes-cleanup

regal archBOT Aug 23, 2023, 9:34 AM

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1323 Snakes cleanup

#

wookie184

[sir-lancebot:main] 7 new commits

74e3e68 Use built in timeout handling for aiohttp inste... - wookie184
43cf31b Fix: stop using deprecated PIL .getsize method - wookie184
17303df Fix and simplify 'disambiguate' utility - wookie184
cb87d90 Type hint pagination as allowing float timeout - wookie184
d45356f Handle snakes without images - wookie184

#

wookie184

[python-discord/sir-lancebot] Issue closed: #1324 AttributeError: 'FreeTypeFont' object has no attribute 'getsize'

#

wookie184

[python-discord/sir-lancebot] branch deleted: snakes-cleanup

night lilyBOT Aug 23, 2023, 9:36 AM

#

Sir Lancebot

Connected!

regal archBOT Aug 23, 2023, 9:54 AM

#

wookie184

[python-discord/sir-lancebot] New comment on issue #985: Sudoku command

@n0Oo0Oo0b I've assigned you.

Given there have been a few different proposals for how this could be done here, could you clarify what you are working on? (e.g. what size, how it will be displayed to the user, how the user will enter guesses)

#

wookie184

[python-discord/sir-lancebot] New comment on issue #73: Seasonal information

@parth-verma7 What is the plan for implementation here given the previous discussion? As seasons work differently in different places, what type will be used? Will an API need to be used to get the necessary information?

#

wookie184

[python-discord/bot] New comment on issue #2728: Syntax error in `!dotenv` command

Good spot, feel free to open a PR

regal archBOT Aug 23, 2023, 10:45 AM

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #1350: .gh user <github_username> returning multiple instances of result

I guess I did both, Run with Docker and Run on the Host.

regal archBOT Aug 23, 2023, 11:00 AM

#

shtlrs

[python-discord/sir-lancebot] New comment on issue #1350: .gh user <github_username> returning multiple instances of result

I'll close this then. Thanks!

#

shtlrs

[python-discord/sir-lancebot] Issue closed: #1350 .gh user <github_username> returning multiple instances of result

regal archBOT Aug 23, 2023, 11:17 AM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1321 Update to pydantic 2.0

Looks good, one thing that we could change, but my approval stands either way

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1321: Update to pydantic 2.0

In the bot PR, I found you can pass these as class vars, and it just works with inheritance.

#

ChrisLovering

[sir-lancebot] Branch shenanigansd-patch-1 was force-pushed to `41faf9d`

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1214 holidayreact: add alternate spellings to February

#

ChrisLovering

[sir-lancebot:main] 1 new commit

328f11f holidayreact: add alternate spellings to Februa... - shenanigansd

#

ChrisLovering

[python-discord/sir-lancebot] branch deleted: shenanigansd-patch-1

odd spireBOT Aug 23, 2023, 11:24 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1214 holidayreact: add alternate spellings to February

GitHub Actions run 5950668621 succeeded.

PR Author

shenanigansd

Workflow Run

Status Embed #3646

Source Branch

shenanigansd-patch-1

night lilyBOT Aug 23, 2023, 11:25 AM

#

Sir Lancebot

Connected!

regal archBOT Aug 23, 2023, 12:04 PM

#

ChrisLovering

[python-discord/snekbox] New comment on pull request #181: Support Multiple Python Versions

FWIW, I think this is a good approach as far as the image is concerned.

odd spireBOT Aug 23, 2023, 12:57 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1343 Add a `.rfc` utility command

GitHub Actions run 5951618307 succeeded.

PR Author

Workflow Run

Status Embed #3648

Source Branch

SomeHybrid:main

regal archBOT Aug 23, 2023, 12:57 PM

#

SomeHybrid

[python-discord/sir-lancebot] New review comment on pull request #1343: Add a `.rfc` utility command

Fixed to 1 command per 5s

#

ChrisLovering

[python-discord/.github] Pull request review submitted: #23 Do not checkout the fork's branch upon history comparison

#

mbaruh

[python-discord/.github] Pull request closed: #23 Do not checkout the fork's branch upon history comparison

#

mbaruh

[.github:main] 3 new commits

90da58a Do not checkout the fork's branch - shtlrs
9904284 use git's --grep option - shtlrs
73a8099 Merge pull request #23 from python-discord/do-n... - mbaruh

regal archBOT Aug 23, 2023, 1:33 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1343 Add a `.rfc` utility command

Looks good, thanks!

#

ChrisLovering

[python-discord/bot] New comment on pull request #2726: feat: use new markdown feature in new help channel message

Does this PR cover everything required in that issue? If not, we shouldn't mark this PR as closing that issue.

regal archBOT Aug 23, 2023, 1:54 PM

#

DownDev

[python-discord/bot] New comment on pull request #2726: feat: use new markdown feature in new help channel message

I guess i can go over commands and see if there is something to change.

#

ChrisLovering

[python-discord/bot] New comment on pull request #2726: feat: use new markdown feature in new help channel message

I guess i can go over commands and see if there is something to change.

We can also just review & merge this PR, but not have it marked as closing the issue. With further changes in other PRs. It's up to you.

regal archBOT Aug 23, 2023, 3:43 PM

#

DownDev

[python-discord/bot] New comment on pull request #2726: feat: use new markdown feature in new help channel message

@ChrisLovering All i found that might also use markdown is the !extensions list command but dont know what you think

I could be displayed like this:

Obviously with emojis
But is it worth applying? I dont think so

#

DownDev

[python-discord/bot] New comment on pull request #2726: feat: use new markdown feature in new help channel message

@ChrisLovering Actually many tags dont use correct syntax for markdown. Also the !patreon supporters command is what i found for now.

All of the above are using the • instead of -

regal archBOT Aug 23, 2023, 4:39 PM

#

n0Oo0Oo0b

[python-discord/sir-lancebot] New comment on issue #985: Sudoku command

For grid size, I will start with a 4x4 but I might also add a 6x6 option later
The grid will be displayed as an image
.sudoku start to start, .sudoku [location] [number] to enter guesses. If the guess is correct, the board will be updated (most likely edit the original message). If the guess is incorrect, the bot will indicate it (perhaps a :x: reaction) and leave the board unchanged.

oak estuaryBOT Aug 23, 2023, 6:26 PM

#

Doc item doc_item.symbol_id='flask.Flask.default_config' present in loaded documentation inventories not found on site, inventories may need to be refreshed.

regal archBOT Aug 23, 2023, 7:41 PM

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #73: Seasonal information

@wookie184 I could not find any api for seasons .
My way:
i) Extract country.
ii) Extract the current time zone.
iii) Return the time zone from some database in which all the seasons vs country are stored.
I have attached a sample image, please have a look.

regal archBOT Aug 23, 2023, 8:05 PM

#

parth-verma7

[python-discord/sir-lancebot] New comment on issue #143: Independence Day

@jodth07 I would like to work upon this issue. Can you please assign it to me?
Thank You

regal archBOT Aug 23, 2023, 10:48 PM

#

brodycritchlow

[python-discord/bot] Pull request opened: #2729 Fix Dotenv Tag's Syntax

Closes #2728

Removed () from import statement.

odd spireBOT Aug 23, 2023, 10:50 PM

#

[python-discord/bot] Checks Failed on PR: #2729 Fix Dotenv Tag's Syntax

GitHub Actions run 5957248391 failed.

PR Author

brodycritchlow

Workflow Run

CI #986

Source Branch

brodycritchlow:dotenv-tag-syntax

regal archBOT Aug 24, 2023, 7:57 AM

#

DownDev

[python-discord/bot] Pull request opened: #2730 fix(logs): resolve SyntaxError in `!dotenv` command

Closes #2728

odd spireBOT Aug 24, 2023, 7:59 AM

#

[python-discord/bot] Checks Failed on PR: #2730 fix(logs): resolve SyntaxError in `!dotenv` command

GitHub Actions run 5961016991 failed.

PR Author

Workflow Run

CI #987

Source Branch

DownDev:fix-2728

odd spireBOT Aug 24, 2023, 8:18 AM

#

[python-discord/bot] Checks Failed on PR: #2730 fix(tags): resolve SyntaxError in `!dotenv` command

GitHub Actions run 5961212292 failed.

PR Author

Workflow Run

CI #988

Source Branch

DownDev:fix-2728

regal archBOT Aug 24, 2023, 8:42 AM

#

shtlrs

[python-discord/bot] New comment on pull request #2729: Fix Dotenv Tag's Syntax

Hi 👋

Thanks for opening up a PR to fix that.

However, I'm afraid tha that the issue wasn't assigned to you, and the person who opened it was told to feel free to open a PR to fix it.

Please make sure to receive confirmation before beginning to work on a PR so that it doesn't happen in the future, we don't want contributors' work to be wasted.

Sorry for that.

regal archBOT Aug 24, 2023, 2:14 PM

#

shtlrs

[bot:remove-fixup-job] 1 new commit

c744431 Remove call to the fixup reusable workflow - shtlrs

#

shtlrs

[python-discord/bot] New branch created: remove-fixup-job

#

shtlrs

[python-discord/bot] Pull request opened: #2731 Remove call to the fixup reusable workflow

We're having a couple of issues with the workflow so we're temporarily removing it.

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2731 Remove call to the fixup reusable workflow

#

ChrisLovering

[python-discord/bot] Pull request closed: #2731 Remove call to the fixup reusable workflow

#

ChrisLovering

[bot:main] 1 new commit

82301f2 Remove call to the fixup reusable workflow (#2731) - shtlrs

#

ChrisLovering

[python-discord/bot] branch deleted: remove-fixup-job

odd spireBOT Aug 24, 2023, 2:16 PM

#

[python-discord/bot] Checks Successful on PR: #2731 Remove call to the fixup reusable workflow

GitHub Actions run 5964923309 succeeded.

PR Author

Workflow Run

CI #989

Source Branch

remove-fixup-job

oak estuaryBOT Aug 24, 2023, 2:18 PM

#

Python Bot

Connected!

regal archBOT Aug 24, 2023, 2:58 PM

#

shtlrs

[python-discord/.github] New branch created: interpolate-commit-messages-var

#

shtlrs

[.github:interpolate-commit-messages-var] 1 new commit

f94f05f interpolate the commit_messages var

shtlrs

#

shtlrs

[python-discord/.github] Pull request opened: #24 Interpolate the variable holding all the fixup commits.

This makes sure that the expressions is evaluated based on the content of the var insteaf of the string "commit_messages"

#

ChrisLovering

[python-discord/.github] Pull request review submitted: #24 Interpolate the variable holding all the fixup commits.

odd spireBOT Aug 24, 2023, 6:49 PM

#

[python-discord/bot] Checks Successful on PR: #2726 feat: use new markdown feature in new help channel message

GitHub Actions run 5967716454 succeeded.

PR Author

Workflow Run

CI #991

Source Branch

DownDev:fix-2646

#

[python-discord/bot] Checks Successful on PR: #2726 feat: use new markdown feature in new help channel message

GitHub Actions run 5967745311 succeeded.

PR Author

Workflow Run

CI #992

Source Branch

DownDev:fix-2646

odd spireBOT Aug 24, 2023, 7:37 PM

#

[python-discord/bot] Checks Successful on PR: #2726 feat: use new markdown feature in new help channel message

GitHub Actions run 5968137536 succeeded.

PR Author

Workflow Run

CI #993

Source Branch

DownDev:fix-2646

#

[python-discord/bot] Checks Successful on PR: #2726 feat: use new markdown feature in new help channel message

GitHub Actions run 5968228999 succeeded.

PR Author

Workflow Run

CI #994

Source Branch

DownDev:fix-2646

odd spireBOT Aug 24, 2023, 8:46 PM

#

[python-discord/bot] Checks Successful on PR: #2726 feat: use new markdown feature in new help channel message

GitHub Actions run 5968732503 succeeded.

PR Author

Workflow Run

CI #995

Source Branch

DownDev:fix-2646

odd spireBOT Aug 24, 2023, 9:10 PM

#

[python-discord/bot] Checks Successful on PR: #2726 feat: use new markdown feature in new help channel message

GitHub Actions run 5968930860 succeeded.

PR Author

Workflow Run

CI #996

Source Branch

DownDev:fix-2646

regal archBOT Aug 25, 2023, 9:29 PM

#

jchristgit

[python-discord/site] New comment on pull request #657: Feature/darktheme

Hello

It has come to my attention that Python Discord . Com still has no Dark Theme switch. I was saddened by this and, head hanging down, trotted to this pull request to express my feelings of sadness.

django-simple-bulma recently had my PR merged that added a flag to skip adding JS, which I think should help with implementing this. What do you think?

regal archBOT Aug 26, 2023, 9:38 AM

#

shtlrs

[bot] Branch bump-to-pydis-core-10 was force-pushed to `d388353`

odd spireBOT Aug 26, 2023, 9:40 AM

#

[python-discord/bot] Checks Successful on PR: #2685 Bump pydis_core to v10

GitHub Actions run 5984085348 succeeded.

PR Author

Workflow Run

CI #997

Source Branch

bump-to-pydis-core-10

regal archBOT Aug 26, 2023, 10:06 AM

#

shtlrs

[bot:bump-to-pydis-core-10] 1 new commit

84f02e6 apply white space around operators - shtlrs

odd spireBOT Aug 26, 2023, 10:07 AM

#

[python-discord/bot] Checks Successful on PR: #2685 Bump pydis_core to v10

GitHub Actions run 5984180128 succeeded.

PR Author

Workflow Run

CI #998

Source Branch

bump-to-pydis-core-10

regal archBOT Aug 26, 2023, 10:07 AM

#

shtlrs

[python-discord/bot] Pull request closed: #2685 Bump pydis_core to v10

#

shtlrs

[bot:main] 11 new commits

85a1a3b update all instances of send_to_paste_service - shtlrs
959e2dd use bot-core caching util - shtlrs
f908666 use get_or_fetch_channel provided by bot-core - shtlrs
8bd0d95 use get_or_fetch_member provided by bot-core - shtlrs
1af0989 delete members utils module - shtlrs

#

shtlrs

[python-discord/bot] branch deleted: bump-to-pydis-core-10

oak estuaryBOT Aug 26, 2023, 10:10 AM

#

Python Bot

Connected!

regal archBOT Aug 26, 2023, 10:19 AM

#

shtlrs

[bot:fix-import-error] 1 new commit

b04a87f pass bot to get_or_fetch_channel - shtlrs

#

shtlrs

[python-discord/bot] New branch created: fix-import-error

#

shtlrs

[python-discord/bot] Pull request opened: #2732 Pass bot to get_or_fetch_channel

It seems this commit has been lost during the rebase.

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2732 Pass bot to get_or_fetch_channel

#

shtlrs

[bot] Branch fix-import-error was force-pushed to `7d5a6ea`

odd spireBOT Aug 26, 2023, 10:31 AM

#

[python-discord/bot] Checks Failed on PR: #2732 Pass bot to get_or_fetch_channel

GitHub Actions run 5984299716 failed.

PR Author

Workflow Run

CI #1000

Source Branch

fix-import-error

regal archBOT Aug 26, 2023, 10:32 AM

#

shtlrs

[bot:fix-import-error] 1 new commit

776e6d1 appease linter - shtlrs

odd spireBOT Aug 26, 2023, 10:33 AM

#

[python-discord/bot] Checks Successful on PR: #2732 Pass bot to get_or_fetch_channel

GitHub Actions run 5984308922 succeeded.

PR Author

Workflow Run

CI #1001

Source Branch

fix-import-error

regal archBOT Aug 26, 2023, 10:34 AM

#

shtlrs

[bot] Branch fix-import-error was force-pushed to `fe7f5ec`

odd spireBOT Aug 26, 2023, 10:36 AM

#

[python-discord/bot] Checks Successful on PR: #2732 Pass bot to get_or_fetch_channel

GitHub Actions run 5984319921 succeeded.

PR Author

Workflow Run

CI #1002

Source Branch

fix-import-error

regal archBOT Aug 26, 2023, 10:44 AM

#

ChrisLovering

[python-discord/bot] Pull request closed: #2732 Pass bot to get_or_fetch_channel

#

ChrisLovering

[bot:main] 1 new commit

28fa104 pass bot to get_or_fetch_channel in thread bump... - shtlrs

#

ChrisLovering

[python-discord/bot] branch deleted: fix-import-error

oak estuaryBOT Aug 26, 2023, 10:47 AM

#

Python Bot

Connected!

regal archBOT Aug 26, 2023, 10:57 AM

#

wookie184

[python-discord/bot] Pull request review submitted: #2730 fix(tags): resolve SyntaxError in `!dotenv` command

Thanks 👍

#

wookie184

[python-discord/sir-lancebot] New comment on issue #985: Sudoku command

Sounds good 👍

regal archBOT Aug 26, 2023, 1:13 PM

#

vivekashok1221

[python-discord/bot] Pull request review submitted: #2730 fix(tags): resolve SyntaxError in `!dotenv` command

odd spireBOT Aug 26, 2023, 2:34 PM

#

[python-discord/bot] Checks Successful on PR: #2730 fix(tags): resolve SyntaxError in `!dotenv` command

GitHub Actions run 5985372455 succeeded.

PR Author

Workflow Run

CI #1004

Source Branch

DownDev:fix-2728

regal archBOT Aug 26, 2023, 2:35 PM

#

DownDev

[python-discord/bot] New comment on pull request #2730: fix(tags): resolve SyntaxError in `!dotenv` command

Updated syntax and invalid link in this tag suggested by @TizzySaurus [here](#dev-contrib message)

#

shtlrs

[python-discord/bot] Pull request closed: #2730 fix(tags): resolve SyntaxError in `!dotenv` command

#

shtlrs

[bot:main] 3 new commits

625ec93 fix(tags): resolve SyntaxError in dotenv reset ... - DownDev
9d2e5b2 feat(tags): update link and syntax in dotenv tag - DownDev
c18abf8 Merge pull request #2730 from DownDev/fix-2728 - shtlrs

#

shtlrs

[python-discord/bot] Issue closed: #2728 Syntax error in `!dotenv` command

odd spireBOT Aug 26, 2023, 2:37 PM

#

[python-discord/bot] Checks Successful on PR: #2730 fix(tags): resolve SyntaxError in `!dotenv` command

GitHub Actions run 5985387153 succeeded.

PR Author

Workflow Run

CI #1005

Source Branch

DownDev:fix-2728

oak estuaryBOT Aug 26, 2023, 2:40 PM

#

Python Bot

Connected!

regal archBOT Aug 26, 2023, 2:43 PM

#

shtlrs

[python-discord/bot] Pull request review submitted: #2719 Make admins confirm edits of other users' reminders

Great work, thank you!

odd spireBOT Aug 26, 2023, 2:45 PM

#

[python-discord/bot] Checks Successful on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5985412221 succeeded.

PR Author

Workflow Run

CI #1007

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

odd spireBOT Aug 26, 2023, 3:44 PM

#

[python-discord/bot] Checks Successful on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5985656912 succeeded.

PR Author

Workflow Run

CI #1008

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

regal archBOT Aug 26, 2023, 3:45 PM

#

ChrisLovering

[python-discord/bot] Pull request closed: #2719 Make admins confirm edits of other users' reminders

#

ChrisLovering

[bot:main] 13 new commits

cedf79a Create ModifyConfirmationView - n0Oo0Oo0b
e82ae28 Ask for confirmation when an admin modifies ano... - n0Oo0Oo0b
30ff648 Update docstring to better match function behavior - n0Oo0Oo0b
3bf7e32 Apply suggestions from code review - n0Oo0Oo0b
cac8e34 Apply suggestions from code review - n0Oo0Oo0b

#

ChrisLovering

[python-discord/bot] Issue closed: #2353 Add confirmation step when deleting or modifying someone else's reminders

odd spireBOT Aug 26, 2023, 3:46 PM

#

[python-discord/bot] Checks Successful on PR: #2719 Make admins confirm edits of other users' reminders

GitHub Actions run 5985662210 succeeded.

PR Author

Workflow Run

CI #1009

Source Branch

n0Oo0Oo0b:confirm-reminder-edit

oak estuaryBOT Aug 26, 2023, 3:48 PM

#

Python Bot

Connected!

regal archBOT Aug 26, 2023, 7:38 PM

#

ichard26

[site:update-timeline-rev-2] 1 new commit

57d0fb5 Fix broken links and remove extraneous space in... - ichard26

#

ichard26

[python-discord/site] New branch created: update-timeline-rev-2

#

ichard26

[python-discord/site] Pull request opened: #1077 Fix broken links and remove extraneous space in timeline

Many thanks to @Rainb0wCodes for making me aware of the broken links.

This is not embarrassing in any way, not at all.,,

odd spireBOT Aug 26, 2023, 7:41 PM

#

[python-discord/site] Checks Failed on PR: #1077 Fix broken links and remove extraneous space in timeline

GitHub Actions run 5986642259 failed.

PR Author

Workflow Run

CI #483

Source Branch

update-timeline-rev-2

regal archBOT Aug 26, 2023, 9:15 PM

#

ChrisLovering

[python-discord/snekbox] Pull request review submitted: #181 Install Multiple Python Versions in the Image

regal archBOT Aug 27, 2023, 11:34 AM

#

shtlrs

[python-discord/bot] Pull request review submitted: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

#

shtlrs

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

                new_channel_names: list[str] = await self.bot.api_client.get(

#

shtlrs

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

IS this even possible ? We have a ton of channel names and we only rename 3.

#

shtlrs

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

Can you rebase onto main ?
There are breaking changes since the get_or_fetch_channel isn't available anymore, you need to import it from pydis_core

#

shtlrs

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

I think the approach can be enhanced a bit.
We can fetch 3 names (number of attempts) for each channel.
We iterate over each channel, and try to rename it three times, then exit, that way we can increase the chance of a successful rename OP.

number_of_names_to_fetch = MAX_ATTEMPS * len(CHANNELS)
channels = [get_or_fetch_channel(channel) for channel in CHANNELS]
names = iter(api_client.fetch_names(params={"random_items": number_of_names_to_fetch}))

renamed = set()
failed = ...

regal archBOT Aug 27, 2023, 12:49 PM

#

shtlrs

[python-discord/sir-lancebot] Pull request review submitted: #1343 Add a `.rfc` utility command

Looks good & works well, thank you !

#

shtlrs

[python-discord/sir-lancebot] Pull request closed: #1343 Add a `.rfc` utility command

#

shtlrs

[sir-lancebot:main] 9 new commits

f40a9bc Add RFC utility command - SomeHybrid
b87186e Fixed ruff issues - SomeHybrid
3a9be59 Applied isort to rfc.py - SomeHybrid
f19a5ee Added cache to RFC command - SomeHybrid
3fce0bc Added logging on fetching RFC - SomeHybrid

#

shtlrs

[python-discord/sir-lancebot] Issue closed: #1342 Add a `.rfc` command

odd spireBOT Aug 27, 2023, 12:52 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1343 Add a `.rfc` utility command

GitHub Actions run 5991031847 succeeded.

PR Author

Workflow Run

Status Embed #3649

Source Branch

SomeHybrid:main

night lilyBOT Aug 27, 2023, 12:54 PM

#

Sir Lancebot

Connected!

regal archBOT Aug 27, 2023, 4:54 PM

#

jchristgit

[python-discord/site] Pull request review submitted: #1077 Fix broken links and remove extraneous space in timeline

#

jchristgit

[python-discord/site] New comment on pull request #1077: Fix broken links and remove extraneous space in timeline

@shtlrs Good morning

Do you know why git fails in the fixup blocker CI?


Run commit_messages=$(git log origin/main..fork/update-timeline-rev-2 --format="%h %B" --grep "^fixup" --oneline)
  commit_messages=$(git log origin/main..fork/update-timeline-rev-2 --format="%h %B" --grep "^fixup" --oneline)
  if [ -n "commit_messages" ]; then
      echo -e "$RED Error: Make sure that all 'fixup' prefixed commits are squashed before merging."
      echo -e "$RED Commits that need fixin...

#

shtlrs

[python-discord/site] New comment on pull request #1077: Fix broken links and remove extraneous space in timeline

Good morning sir.

Yes, it's because i forgot to make a new workflow that needs to run on the pull_request_target event.

Also, another pr needs to be Merged for it to be fully
functionalhttps://github.com/python-discord/.github/pull/24

So, we can either bypass this, or remove the usage of it then rebase this branch.

Sorry for the hurdle.

#

jchristgit

[python-discord/.github] Pull request review submitted: #24 Interpolate the variable holding all the fixup commits.

It Is Great.

#

jchristgit

[python-discord/site] New comment on pull request #1077: Fix broken links and remove extraneous space in timeline

Sorry for the hurdle.

Wo gehobelt wird, da fallen Späne!!!!!!!!!!

#

jchristgit

[python-discord/site] Pull request closed: #1077 Fix broken links and remove extraneous space in timeline

#

jchristgit

[site:main] 2 new commits

57d0fb5 Fix broken links and remove extraneous space in... - ichard26
9528b2b Merge pull request #1077 from python-discord/up... - jchristgit

#

jchristgit

[python-discord/site] branch deleted: update-timeline-rev-2

#

jchristgit

[python-discord/site] New comment on pull request #1077: Fix broken links and remove extraneous space in timeline

Thanks!

regal archBOT Aug 27, 2023, 6:18 PM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

It is strictly possible, however unlikely, so figured it should be accounted for - especially since the handling is relatively simple.

#

TizzySaurus

[bot:fix-2500] 188 new commits

371eaa8 Add on-message-event.md - n0Oo0Oo0b
5f83740 Update bot/resources/tags/on-message-event.md - n0Oo0Oo0b
97efc1c Update bot/resources/tags/on-message-event.md - n0Oo0Oo0b
9936d6f Update on-message-event.md - n0Oo0Oo0b
d0ca29e Apply suggestions from code review - n0Oo0Oo0b

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

c8f79a68

odd spireBOT Aug 27, 2023, 6:34 PM

#

[python-discord/bot] Checks Failed on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 5992576726 failed.

PR Author

Workflow Run

CI #1011

Source Branch

fix-2500

regal archBOT Aug 27, 2023, 6:36 PM

#

TizzySaurus

[bot:fix-2500] 1 new commit

e296bb5 Migrate to pydis-core get_or_fetch_channel - TizzySaurus

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

Fixed in e296bb56

odd spireBOT Aug 27, 2023, 6:38 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 5992598204 succeeded.

PR Author

Workflow Run

CI #1012

Source Branch

fix-2500

regal archBOT Aug 27, 2023, 6:38 PM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

I don't see any real harm in documenting how the code works given the complexity.

regal archBOT Aug 27, 2023, 7:01 PM

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #113: Enable a limited tmpfs for shared memory

I've picked up this PR again, and in my testing, the process crashes with code 135 (SIGBUS). To trigger this, the code must write to the shared memory buffer. Merely creating the shared memory object is not enough.

What I've been stuck on is understanding what's going on when just the shared memory object is created. Here is the CPython code for it.

First it calls shm_open, and it has the `...

regal archBOT Aug 27, 2023, 7:52 PM

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #113: Enable a limited tmpfs for shared memory

It seems like no memory is consumed by just using ftruncate:

python -m snekbox '
import os
import _posixshmem
try:
   fd = _posixshmem.shm_open("test", os.O_CREAT | os.O_EXCL | os.O_RDWR, mode=0o600)
   os.ftruncate(fd, 52428800 * 5000000)
   print(os.stat(fd))
finally:
   _posixshmem.shm_unlink("test")
' --time_limit 0

os.stat_result(st_mode=33152, st_ino=2, st_dev=60, st_nlink=1, st_uid=65534, st_gid=65534, st_size=262144000000000, st_atime=1693165871, st_mti...

#

TizzySaurus

[bot:fix-2500] 1 new commit

2f738ad Rewrite logic for ot-channel renaming - TizzySaurus

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

Rewritten in 2f738ad1. Currently untested, but lmk what you think :)

odd spireBOT Aug 27, 2023, 7:54 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 5992886423 succeeded.

PR Author

Workflow Run

CI #1013

Source Branch

fix-2500

regal archBOT Aug 27, 2023, 7:55 PM

#

TizzySaurus

[bot:fix-2500] 1 new commit

b0296f6 Only call handle_failed_renames when a rename... - TizzySaurus

#

TizzySaurus

[bot] Branch fix-2500 was force-pushed to `267ef44`

odd spireBOT Aug 27, 2023, 7:56 PM

#

[python-discord/bot] Checks Cancelled on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 5992893428 was cancelled.

PR Author

Workflow Run

CI #1014

Source Branch

fix-2500

regal archBOT Aug 27, 2023, 7:57 PM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

The handle for this has changed with the rewrite, but is still there here. Also figured it made more sense to send a message to mod_meta than a log.warn, so updated to reflect that.

odd spireBOT Aug 27, 2023, 7:57 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 5992894753 succeeded.

PR Author

Workflow Run

CI #1015

Source Branch

fix-2500

regal archBOT Aug 27, 2023, 8:00 PM

#

vivekashok1221

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

I agree with keeping the handle since it could save some of my brain cells when, say, I'm running my own instance of the bot in a test server.

#

TizzySaurus

[bot:fix-2500] 1 new commit

27f4061 Add missing call to handle_failed_renames - TizzySaurus

odd spireBOT Aug 27, 2023, 8:08 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 5992945537 succeeded.

PR Author

Workflow Run

CI #1016

Source Branch

fix-2500

regal archBOT Aug 27, 2023, 8:09 PM

#

TizzySaurus

[bot:fix-2500] 1 new commit

5b6fb16 Only define failed_to_rename when required - TizzySaurus

#

shtlrs

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

That's what I'm saying, that the code can be understood by simply reading it, as the logic is kinda straightforward.

I personally don't think it's complex, we'll see what others have to say about it.

odd spireBOT Aug 27, 2023, 8:10 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 5992957698 succeeded.

PR Author

Workflow Run

CI #1017

Source Branch

fix-2500

regal archBOT Aug 27, 2023, 8:11 PM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

Yeah, in hindsight I agree -- these comments were removed as part of the rewrite.

regal archBOT Aug 27, 2023, 8:28 PM

#

TizzySaurus

[bot:fix-2500] 1 new commit

46dc93a Improve ot_channels_not_renamed_joined message - TizzySaurus

regal archBOT Aug 27, 2023, 9:11 PM

#

shtlrs

[python-discord/bot] Pull request review submitted: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

#

shtlrs

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

This code is now duplicated, you can simply break out of the loop, and have the second one do the handling.

regal archBOT Aug 27, 2023, 9:48 PM

#

TizzySaurus

[bot:fix-2500] 1 new commit

5c16d69 Remove code duplication - TizzySaurus

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2520: Handle off-topic channel names that are invalid for servers in Server Discovery

Good point, fixed in 5c16d697.

odd spireBOT Aug 27, 2023, 9:49 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 5993370299 succeeded.

PR Author

Workflow Run

CI #1018

Source Branch

fix-2500

regal archBOT Aug 28, 2023, 1:29 AM

#

janine9vn

[python-discord/sir-robin] New branch created: cj-perms-update

#

janine9vn

[sir-robin:cj-perms-update] 2 new commits

df70e47 Add bot roles as constants - janine9vn
ff317cd Add necessary permission overwrites - janine9vn

regal archBOT Aug 28, 2023, 2:46 AM

#

janine9vn

[sir-robin] Branch cj-perms-update was force-pushed to `b31c9b8`

#

janine9vn

[python-discord/sir-robin] Pull request opened: #88 Code Jam Permissions Update and a little bit extra

This corrects some permissions issues from last year:

Adds Sir Robin to individual team channels
Give the Event Lead roles manage_channels permission for the category
Adds Sir Lancebot and Python to team channels and the category overall, just to be sure

Why do we have to override permissions on the individual channels when it's being added to the category is a reasonable question you might ask when looking at this PR. The answer lies in the hell that is the Discord channel permis...

odd spireBOT Aug 28, 2023, 2:54 AM

#

[python-discord/sir-robin] Checks Failed on PR: #88 Code Jam Permissions Update and a little bit extra

GitHub Actions run 5995044772 failed.

PR Author

janine9vn

Workflow Run

Status Embed #265

Source Branch

cj-perms-update

regal archBOT Aug 28, 2023, 2:55 AM

#

janine9vn

[sir-robin] Branch cj-perms-update was force-pushed to `a5d29d3`

odd spireBOT Aug 28, 2023, 2:57 AM

#

[python-discord/sir-robin] Checks Failed on PR: #88 Code Jam Permissions Update and a little bit extra

GitHub Actions run 5995058500 failed.

PR Author

janine9vn

Workflow Run

Status Embed #266

Source Branch

cj-perms-update

regal archBOT Aug 28, 2023, 3:01 AM

#

janine9vn

[sir-robin] Branch cj-perms-update was force-pushed to `00479bf`

odd spireBOT Aug 28, 2023, 3:02 AM

#

[python-discord/sir-robin] Checks Successful on PR: #88 Code Jam Permissions Update and a little bit extra

GitHub Actions run 5995085427 succeeded.

PR Author

janine9vn

Workflow Run

Status Embed #267

Source Branch

cj-perms-update

odd spireBOT Aug 28, 2023, 5:09 AM

#

[python-discord/site] Checks Failed on PR: #1078 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 5995834028 failed.

PR Author

Workflow Run

CI #485

Source Branch

dependabot/pip/ruff-0.0.286

regal archBOT Aug 28, 2023, 5:36 AM

#

HassanAbouelela

[python-discord/sir-robin] Pull request review submitted: #88 Code Jam Permissions Update and a little bit extra

Cant test, but LGTM.

regal archBOT Aug 28, 2023, 9:37 AM

#

D0rs4n

[python-discord/sir-robin] Pull request review submitted: #88 Code Jam Permissions Update and a little bit extra

Tested out, LGTM

odd spireBOT Aug 28, 2023, 10:09 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #1351 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 5998502696 failed.

PR Author

Workflow Run

Status Embed #3651

Source Branch

dependabot/pip/ruff-0.0.286

odd spireBOT Aug 28, 2023, 12:33 PM

#

[python-discord/bot] Checks Failed on PR: #2733 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 5999851020 failed.

PR Author

Workflow Run

CI #1019

Source Branch

dependabot/pip/ruff-0.0.286

regal archBOT Aug 28, 2023, 1:33 PM

#

janine9vn

[python-discord/sir-robin] Pull request closed: #88 Code Jam Permissions Update and a little bit extra

#

janine9vn

[sir-robin:main] 4 new commits

df70e47 Add bot roles as constants - janine9vn
432c10d Add necessary permission overwrites - janine9vn
00479bf Ping teams in their team channel - janine9vn
3868b98 Merge pull request #88 from python-discord/cj-p... - janine9vn

#

janine9vn

[python-discord/sir-robin] branch deleted: cj-perms-update

thin oysterBOT Aug 28, 2023, 1:36 PM

#

Sir Robin

Connected!

regal archBOT Aug 28, 2023, 1:39 PM

#

D0rs4n

[sir-robin:pr/cjpaste] 1 new commit

fedf8cd Patch cj end to upload a file instead of paste ... - D0rs4n

#

D0rs4n

[python-discord/sir-robin] New branch created: pr/cjpaste

#

D0rs4n

[python-discord/sir-robin] Pull request opened: #89 Patch cj end to upload a file instead of paste service

Due to changes in the interface of the Paste Service, for the duration of the code jam, the bot will send a text file.

#

D0rs4n

[sir-robin:pr/cjpaste] 5 new commits

df70e47 Add bot roles as constants - janine9vn
432c10d Add necessary permission overwrites - janine9vn
00479bf Ping teams in their team channel - janine9vn
3868b98 Merge pull request #88 from python-discord/cj-p... - janine9vn
1d8c412 Merge branch 'main' into pr/cjpaste - D0rs4n

odd spireBOT Aug 28, 2023, 1:40 PM

#

[python-discord/sir-robin] Checks Cancelled on PR: #89 Patch cj end to upload a file instead of paste service

GitHub Actions run 6000616519 was cancelled.

PR Author

D0rs4n

Workflow Run

Status Embed #269

Source Branch

pr/cjpaste

#

[python-discord/sir-robin] Checks Failed on PR: #89 Patch cj end to upload a file instead of paste service

GitHub Actions run 6000622850 failed.

PR Author

D0rs4n

Workflow Run

Status Embed #270

Source Branch

pr/cjpaste

regal archBOT Aug 28, 2023, 1:49 PM

#

D0rs4n

[sir-robin:pr/cjpaste] 1 new commit

307773d Enhance code consistency in Code Jam Cog. - D0rs4n

odd spireBOT Aug 28, 2023, 1:50 PM

#

[python-discord/sir-robin] Checks Successful on PR: #89 Patch cj end to upload a file instead of paste service

GitHub Actions run 6000720032 succeeded.

PR Author

D0rs4n

Workflow Run

Status Embed #271

Source Branch

pr/cjpaste

regal archBOT Aug 28, 2023, 2:14 PM

#

janine9vn

[python-discord/sir-robin] Pull request review submitted: #89 Patch cj end to upload a file instead of paste service

tested and works nicely. Just a super small comment about a double period. Not required to merge.

#

janine9vn

[python-discord/sir-robin] New review comment on pull request #89: Patch cj end to upload a file instead of paste service

Duplicate period for these two, not major though.

regal archBOT Aug 28, 2023, 2:38 PM

#

ChrisLovering

[python-discord/sir-robin] Pull request review submitted: #89 Patch cj end to upload a file instead of paste service

A better approach would be to bump bot core to 10.X and use the util from there, as it would be a drop-in replacement as far as I can tell.

Approving this just in case there is a time concern for this PR.

regal archBOT Aug 28, 2023, 3:37 PM

#

mbaruh

[site:cj10-frameworks-update] 1 new commit

36051f3 Add additional approved frameworks for CJ10 - mbaruh

#

mbaruh

[python-discord/site] New branch created: cj10-frameworks-update

#

TizzySaurus

[bot:fix-2500] 1 new commit

3b7364c Don't fetch ot-names unnecessarily since fetchi... - TizzySaurus

#

mbaruh

[python-discord/site] Pull request opened: #1079 Add additional approved frameworks for CJ10

odd spireBOT Aug 28, 2023, 3:39 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 6001918761 succeeded.

PR Author

Workflow Run

CI #1020

Source Branch

fix-2500

#

[python-discord/site] Checks Failed on PR: #1079 Add additional approved frameworks for CJ10

GitHub Actions run 6001918859 failed.

PR Author

mbaruh

Workflow Run

CI #486

Source Branch

cj10-frameworks-update

regal archBOT Aug 28, 2023, 3:41 PM

#

TizzySaurus

[bot:fix-2500] 1 new commit

1e20c5a Add check to not add replacement name when the ... - TizzySaurus

odd spireBOT Aug 28, 2023, 3:43 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 6001953140 succeeded.

PR Author

Workflow Run

CI #1021

Source Branch

fix-2500

regal archBOT Aug 28, 2023, 3:45 PM

#

jchristgit

[python-discord/site] Pull request review submitted: #1079 Add additional approved frameworks for CJ10

#

janine9vn

[python-discord/site] Pull request review submitted: #1079 Add additional approved frameworks for CJ10

#

jchristgit

[python-discord/.github] New comment on pull request #24: Interpolate the variable holding all the fixup commits.

@mbaruh you have admin permissions, can you merge this? Please consider it an exchange for this picture of The Dog.

#

jchristgit

[python-discord/site] Pull request closed: #1079 Add additional approved frameworks for CJ10

#

jchristgit

[site:main] 2 new commits

36051f3 Add additional approved frameworks for CJ10 - mbaruh
f684cd7 Merge pull request #1079 from python-discord/cj... - jchristgit

#

jchristgit

[python-discord/site] branch deleted: cj10-frameworks-update

odd spireBOT Aug 28, 2023, 4:15 PM

#

[python-discord/king-arthur] Checks Successful on PR: #100 build(deps-dev): bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 6002281104 succeeded.

PR Author

Workflow Run

Status embed #177

Source Branch

dependabot/pip/ruff-0.0.286

thin oysterBOT Aug 28, 2023, 5:25 PM

#

Sir Robin

Connected!

regal archBOT Aug 28, 2023, 5:32 PM

#

ChrisLovering

[sir-robin:main] 1 new commit

280283b Add back exception content - ChrisLovering

thin oysterBOT Aug 28, 2023, 5:34 PM

#

Sir Robin

Connected!

regal archBOT Aug 28, 2023, 6:09 PM

#

ChrisLovering

[sir-robin:use-ruff] 4 new commits

9d15450 Migrate from flake8 to ruff - ChrisLovering
8773814 Update precommit rules - ChrisLovering
50e09cf ruff auto-fixes - ChrisLovering
d095ab9 Manual ruff fixes - ChrisLovering

#

ChrisLovering

[python-discord/sir-robin] New branch created: use-ruff

#

ChrisLovering

[python-discord/sir-robin] Pull request opened: #90 Migrate from flake8/isort to ruff

odd spireBOT Aug 28, 2023, 6:11 PM

#

[python-discord/sir-robin] Checks Successful on PR: #90 Migrate from flake8/isort to ruff

GitHub Actions run 6003366140 succeeded.

PR Author

Workflow Run

Status Embed #273

Source Branch

use-ruff

regal archBOT Aug 28, 2023, 6:16 PM

#

ChrisLovering

[sir-robin:main] 1 new commit

f21cbd8 Capitalise the category name for consistency wi... - ChrisLovering

thin oysterBOT Aug 28, 2023, 6:19 PM

#

Sir Robin

Connected!

regal archBOT Aug 28, 2023, 6:21 PM

#

ChrisLovering

[sir-robin:main] 1 new commit

78a9fb3 Send check failure context to codejams planning - ChrisLovering

#

ChrisLovering

[sir-robin] Branch use-ruff was force-pushed to `47a29a5`

thin oysterBOT Aug 28, 2023, 6:23 PM

#

Sir Robin

Connected!

regal archBOT Aug 28, 2023, 7:04 PM

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #113: Enable a limited tmpfs for shared memory

Linux has a concept of "sparse files", so fallocate does not actually cause memory to be allocated. Thus, there is no concern about being OOM here with insanely large fallocate calls. See https://stackoverflow.com/questions/58571685/do-files-in-dev-shm-take-up-memory-when-grown-with-ftruncate-but-are-not-writte

regal archBOT Aug 28, 2023, 7:47 PM

#

janine9vn

[python-discord/sir-robin] Pull request review submitted: #90 Migrate from flake8/isort to ruff

woof woof

#

janine9vn

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

smh that original cursed quote is totally necessary

#

ChrisLovering

[bot-core:Bump-d.py] 3 new commits

7ecbfe6 Skip resolving for pydantic model fields - ChrisLovering
e286a43 Replace isort with ruff's implementatation - ChrisLovering
b84ee8b Lint repo with new ruff rules - ChrisLovering

regal archBOT Aug 28, 2023, 8:12 PM

#

shtlrs

[python-discord/bot-core] Pull request review submitted: #192 Bump d.py to 2.3.2

LGTM, only the date needs to be updated.

#

shtlrs

[python-discord/bot-core] New review comment on pull request #192: Bump d.py to 2.3.2

This should be updated

regal archBOT Aug 28, 2023, 8:39 PM

#

ChrisLovering

[bot-core] Branch Bump-d.py was force-pushed to `a91c454`

https://github.com/python-discord/bot-core/compare/b84ee8bc0b0652e415b61303ee53ae49d09141c7..a91c4546c77d10bb921b8e807631d375989e2fb3

#

ChrisLovering

[python-discord/bot-core] New review comment on pull request #192: Bump d.py to 2.3.2

#

shtlrs

[python-discord/bot-core] New review comment on pull request #192: Bump d.py to 2.3.2

m0rge.

#

ChrisLovering

[python-discord/bot-core] Pull request closed: #192 Bump d.py to 2.3.2

#

ChrisLovering

[bot-core:main] 6 new commits

a2daec6 Bump d.py to 2.3.2 - ChrisLovering
a924e14 Add pydantic BaseModel to target to ignore - ChrisLovering
99cde31 Skip resolving for pydantic model fields - ChrisLovering
3a0ed37 Replace isort with ruff's implementatation - ChrisLovering
a91c454 Lint repo with new ruff rules - ChrisLovering

#

ChrisLovering

[python-discord/bot-core] branch deleted: Bump-d.py

#

ChrisLovering

[python-discord/bot-core] New tag created: v10.2.0

#

jchristgit

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

If this is unused and free of side effects, we can probably remove it altogether?

#

jchristgit

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

Are we sure this is equivalent? I've tested it and it seems fine, but since when is raising a class the same as raising an instance of it?

#

jchristgit

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

Why was the elif condition removed here?

#

jchristgit

[python-discord/sir-robin] Pull request review submitted: #90 Migrate from flake8/isort to ruff

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

The if block above returns, the the elif isn't needed

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

It's been like for all of Python 3.X. 2.7 behaved this way too.

https://docs.python.org/3/reference/simple_stmts.html#the-raise-statement

If it is a class, the exception instance will be obtained when needed by instantiating the class with no arguments.

#

ChrisLovering

[sir-robin] Branch use-ruff was force-pushed to `e1346ad`

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

Tests pass with it removed, so I removed it, nice spot. https://github.com/python-discord/sir-robin/compare/47a29a597336cb1766943fae83360f0afa1f10ab..e1346ad83b7f4c5b9dc16aca559a3d6d6472b801

odd spireBOT Aug 28, 2023, 9:13 PM

#

[python-discord/sir-robin] Checks Successful on PR: #90 Migrate from flake8/isort to ruff

GitHub Actions run 6005007683 succeeded.

PR Author

Workflow Run

Status Embed #277

Source Branch

use-ruff

regal archBOT Aug 28, 2023, 9:17 PM

#

TizzySaurus

[bot:fix-2500] 1 new commit

c8705f8 Fix issues discovered in testing - TizzySaurus

odd spireBOT Aug 28, 2023, 9:19 PM

#

[python-discord/bot] Checks Successful on PR: #2520 Handle off-topic channel names that are invalid for servers in Server Discovery

GitHub Actions run 6005056770 succeeded.

PR Author

Workflow Run

CI #1022

Source Branch

fix-2500

regal archBOT Aug 28, 2023, 10:16 PM

#

shtlrs

[python-discord/bot] Pull request closed: #2729 Fix Dotenv Tag's Syntax

regal archBOT Aug 28, 2023, 10:43 PM

#

MarkKoz

[snekbox] Branch jb3/shared-mem was force-pushed to `8028c08`

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #113: Enable a limited tmpfs for shared memory

Indeed. I've removed this change in the recent rebase.

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #113: Enable a limited tmpfs for shared memory

I've updated the tests to address the initial comment https://github.com/python-discord/snekbox/pull/113/commits/8028c08514a507e3de82a1260cbc79fe34095ccd, and I also bottomed out on the other thing I was confused on.

#

[snekbox] GitHub Actions checks success on pull request #113

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #113: Enable a limited tmpfs for shared memory

The test was changed to read this value from the config here c50b5473d74d6d2ef6f29eca68c65b4f61b3466d

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #113: Enable a limited tmpfs for shared memory

I don't know why it needs so much overhead 🤷 but in any case, the point of this test isn't to test the normal NsJail OOM killer — there are other tests for that.

#

MarkKoz

[python-discord/snekbox] New comment on pull request #113: Enable a limited tmpfs for shared memory

@wookie184 Testing for inode limits (and having inode limits) sounds like a good idea. Do you mind writing up a new issue for that? I think that situation would also apply to our temporary file system feature.

odd spireBOT Aug 29, 2023, 5:25 AM

#

[python-discord/site] Checks Failed on PR: #1080 Bump pymdown-extensions from 10.1 to 10.2

GitHub Actions run 6008262501 failed.

PR Author

Workflow Run

CI #488

Source Branch

dependabot/pip/pymdown-extensions-10.2

regal archBOT Aug 29, 2023, 7:28 AM

#

jchristgit

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

For else I would agree but we explicitly check that "key" is present here, so these forms are not equivalent

#

jchristgit

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

Huh, good to know

#

jchristgit

[python-discord/site] Pull request closed: #1080 Bump pymdown-extensions from 10.1 to 10.2

#

jchristgit

[site:main] 2 new commits

a42bbe0 Bump pymdown-extensions from 10.1 to 10.2 - dependabot[bot]
3cf8cff Merge pull request #1080 from python-discord/de... - jchristgit

odd spireBOT Aug 29, 2023, 7:32 AM

#

[python-discord/site] Checks Failed on PR: #1078 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 6009251864 failed.

PR Author

Workflow Run

CI #490

Source Branch

dependabot/pip/ruff-0.0.286

regal archBOT Aug 29, 2023, 8:38 AM

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

Ahh I see what you mean now. I was supposed to change the elif to ann if.

The if block above returns, so the elif isn't needed

I had meant here that elif isn't needed, just an if is fine.

#

ChrisLovering

[sir-robin] Branch use-ruff was force-pushed to `3f79871`

https://github.com/python-discord/sir-robin/compare/e1346ad83b7f4c5b9dc16aca559a3d6d6472b801..3f7987102ff0834dcc015f82d585446e935e82a0

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

odd spireBOT Aug 29, 2023, 8:40 AM

#

[python-discord/sir-robin] Checks Successful on PR: #90 Migrate from flake8/isort to ruff

GitHub Actions run 6009947752 succeeded.

PR Author

Workflow Run

Status Embed #278

Source Branch

use-ruff

regal archBOT Aug 29, 2023, 8:43 AM

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #90: Migrate from flake8/isort to ruff

I've just realised this file is for the old paste service anyway, which I'm going to delete in my next PR and it's entirely non-functional right now with the old paste service being offline

odd spireBOT Aug 29, 2023, 10:59 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1352 Bump pydis-core from 10.1.0 to 10.2.0

GitHub Actions run 6011339878 succeeded.

PR Author

Workflow Run

Status Embed #3652

Source Branch

dependabot/pip/pydis-cor...

odd spireBOT Aug 29, 2023, 12:48 PM

#

[python-discord/bot] Checks Successful on PR: #2734 Bump pydis-core from 10.1.0 to 10.2.0

GitHub Actions run 6012446358 succeeded.

PR Author

Workflow Run

CI #1023

Source Branch

dependabot/pip/pydis-core-10.2.0

regal archBOT Aug 29, 2023, 12:50 PM

#

ChrisLovering

[bot-core:test-bases-in-bot-core] 5 new commits

695d3d5 Copy-paste test base & helpers from bot - ChrisLovering
91484f3 Add ruff rule ignores for test utils - ChrisLovering
f76f602 Lint test utils with ruff - ChrisLovering
d0b730c Fix imports for test utils - ChrisLovering
6201f3a Update changelog for test helper migration - ChrisLovering

#

ChrisLovering

[python-discord/bot-core] New branch created: test-bases-in-bot-core

#

ChrisLovering

[python-discord/bot-core] Pull request opened: #193 Migrate test helpers to bot-core

This PR migrates the test helpers from the bot repo into bot core, along with their tests.

regal archBOT Aug 29, 2023, 2:55 PM

#

jchristgit

[python-discord/sir-robin] Pull request review submitted: #90 Migrate from flake8/isort to ruff

Great Pull Request

#

jchristgit

[python-discord/sir-robin] New comment on pull request #90: Migrate from flake8/isort to ruff

Great Dane

#

ChrisLovering

[sir-robin:main] 4 new commits

e94010b Migrate from flake8 to ruff - ChrisLovering
8c1615a Update precommit rules - ChrisLovering
3d0ce8e ruff auto-fixes - ChrisLovering
3f79871 Manual ruff fixes - ChrisLovering

#

ChrisLovering

[python-discord/sir-robin] Pull request closed: #90 Migrate from flake8/isort to ruff

#

ChrisLovering

[python-discord/sir-robin] branch deleted: use-ruff

#

ChrisLovering

[sir-robin:bump-bot-core] 4 new commits

a709c5f Bump all dependencies to latest - ChrisLovering
73e5b3b Copy updates to test helpers from bot repo - ChrisLovering
da1db96 Use bot-core's new paste service - ChrisLovering
9dfb4fa Remove unused service files - ChrisLovering

#

ChrisLovering

[python-discord/sir-robin] New branch created: bump-bot-core

#

ChrisLovering

[python-discord/sir-robin] Pull request opened: #91 Bump bot core and use new paste service

#

ChrisLovering

[sir-robin] Branch bump-bot-core was force-pushed to `4fa6163`

odd spireBOT Aug 29, 2023, 2:59 PM

#

[python-discord/sir-robin] Checks Successful on PR: #91 Bump bot core and use new paste service

GitHub Actions run 6014005889 succeeded.

PR Author

Workflow Run

Status Embed #279

Source Branch

bump-bot-core

#

[python-discord/sir-robin] Checks Successful on PR: #91 Bump bot core and use new paste service

GitHub Actions run 6014018272 succeeded.

PR Author

Workflow Run

Status Embed #280

Source Branch

bump-bot-core

regal archBOT Aug 29, 2023, 3:00 PM

#

ChrisLovering

[python-discord/sir-robin] New comment on pull request #89: Patch cj end to upload a file instead of paste service

A better approach would be to bump bot core to 10.X and use the util from there [...]

Since I wanted to update bot-core anyway, I've done this change in https://github.com/python-discord/sir-robin/pull/91

#

wookie184

[snekbox:enforce-filesize-limits] 2 new commits

0d1d02f Use pip-tools version that supports newer pip v... - wookie184
16b1a13 Limit total file size read from tmpfs to avoid ... - wookie184

#

wookie184

[python-discord/snekbox] New branch created: enforce-filesize-limits

thin oysterBOT Aug 29, 2023, 3:03 PM

#

Sir Robin

Connected!

regal archBOT Aug 29, 2023, 3:04 PM

#

wookie184

[python-discord/snekbox] Pull request opened: #183 Enforce filesize limits

Enforce a limit on file sizes when reading from tmpfs.

#

wookie184

[python-discord/snekbox] New review comment on pull request #183: Enforce filesize limits

To be clear, follow_symlinks is the default, I just passed it to be more explicit since i'm commeting on it.

#

wookie184

[python-discord/snekbox] Pull request review submitted: #183 Enforce filesize limits

#

[snekbox] GitHub Actions checks success on pull request #183

regal archBOT Aug 29, 2023, 3:23 PM

#

jb3

[python-discord/snekbox] Pull request review submitted: #183 Enforce filesize limits

LGTM, works fine locally and new tests seem to be working fine.

regal archBOT Aug 29, 2023, 4:12 PM

#

jb3

[python-discord/snekbox] Pull request closed: #183 Enforce filesize limits

#

jb3

[snekbox:main] 3 new commits

0d1d02f Use pip-tools version that supports newer pip v... - wookie184
16b1a13 Limit total file size read from tmpfs to avoid ... - wookie184
3c10b34 Merge pull request #183 from python-discord/enf... - jb3

#

jb3

[python-discord/snekbox] branch deleted: enforce-filesize-limits

#

[snekbox] GitHub Actions checks success on main

#

[snekbox] GitHub Actions checks success on main

odd spireBOT Aug 29, 2023, 4:35 PM

#

[python-discord/king-arthur] Checks Successful on PR: #101 build(deps): bump pydis-core from 10.1.0 to 10.2.0

GitHub Actions run 6015050971 succeeded.

PR Author

Workflow Run

Status embed #178

Source Branch

dependabot/pip/pydis-core...

regal archBOT Aug 29, 2023, 4:36 PM

#

ChrisLovering

[python-discord/snekbox] New review comment on pull request #181: Install Multiple Python Versions in the Image

Do we need to set --user here so that PYTHONUSERBASE is used by pip?

regal archBOT Aug 29, 2023, 5:17 PM

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #181: Install Multiple Python Versions in the Image

Yes, good catch. Also I think the env var needs to use export.

#

jb3

[python-discord/snekbox] New review comment on pull request #181: Install Multiple Python Versions in the Image

I think we still need --user here for Python to use PYTHONUSERBASE, unless installing with -m pip does something smarter by default?

#

jb3

[python-discord/snekbox] New review comment on pull request #181: Install Multiple Python Versions in the Image

                    find /lang/python -mindepth 1 -maxdepth 1 -type d -exec
                    PYTHONUSERBASE=/snekbox/user_base &&
                    {}/bin/python -m pip install --user -U

regal archBOT Aug 29, 2023, 5:50 PM

#

jb3

[python-discord/snekbox] Pull request review submitted: #181 Install Multiple Python Versions in the Image

all looks good and works locally -- just needs the --user change for deps and should be good to go!

regal archBOT Aug 29, 2023, 6:07 PM

#

jb3

[snekbox:feat/158/multi-version] 1 new commit

70d0e1a Install eval dependencies with --user & ensure ... - jb3

#

ChrisLovering

[python-discord/snekbox] Pull request review submitted: #181 Install Multiple Python Versions in the Image

#

jb3

[python-discord/snekbox] Pull request review dismissed: #181 Install Multiple Python Versions in the Image

all looks good and works locally -- just needs the --user change for deps and should be good to go!

regal archBOT Aug 29, 2023, 6:37 PM

#

ChrisLovering

[python-discord/snekbox] branch deleted: feat/158/multi-version

regal archBOT Aug 29, 2023, 6:59 PM

#

ChrisLovering

[snekbox:main] 8 new commits

fae8053 Remove explicit package versions from Dockerfile - MarkKoz
9b3f23b Use buildpack-deps as the builder base image - MarkKoz
0db60fc Install multiple Python versions in image - MarkKoz
a53e235 Use --link with COPY in Dockerfile - MarkKoz
e423b7c Remove leading empty strings from NsJail config... - MarkKoz

#

ChrisLovering

[python-discord/snekbox] Pull request closed: #181 Install Multiple Python Versions in the Image

#

[snekbox] GitHub Actions checks success on main

#

[snekbox] GitHub Actions checks success on pull request #181

#

mbaruh

[python-discord/bot] New comment on issue #1847: Lower spam filter strictness in bot command channels

This is done now

#

[snekbox] GitHub Actions checks success on main

regal archBOT Aug 29, 2023, 7:57 PM

#

mbaruh

[python-discord/bot] Issue closed: #1847 Lower spam filter strictness in bot command channels

#

ChrisLovering

[python-discord/snekbox] Pull request review submitted: #184 Disable dependencies without wheels on 3.12

#

jb3

[python-discord/snekbox] New branch created: jb3/3.12-ignores

#

jchristgit

[python-discord/snekbox] New comment on pull request #184: Disable dependencies without wheels on 3.12

Great dane

#

jb3

[python-discord/snekbox] New comment on pull request #184: Disable dependencies without wheels on 3.12

Thanks!

#

jb3

[python-discord/snekbox] Pull request closed: #184 Disable dependencies without wheels on 3.12

#

[snekbox] GitHub Actions checks success on pull request #184

#

[snekbox] GitHub Actions checks failure on main

#

jb3

[python-discord/snekbox] New branch created: jb3/refactor-eval-deps

#

jb3

[python-discord/snekbox] Pull request opened: #184 Disable dependencies without wheels on 3.12

Also use a numpy release candidate to maintain numpy and scipy.

All dependencies have been tested to install correctly on 3.12rc1 within the snekbox container.

#

jchristgit

[python-discord/snekbox] Pull request review submitted: #184 Disable dependencies without wheels on 3.12

Great pull request

#

jchristgit

[python-discord/snekbox] Pull request review submitted: #185 Refactor how we process eval dependencies

Great Pull Request

#

jchristgit

[python-discord/snekbox] New comment on pull request #185: Refactor how we process eval dependencies

Great Dane

#

jb3

[snekbox:main] 2 new commits

cd604fe Disable dependencies without wheels on 3.12 - jb3
0292661 Merge pull request #184 from python-discord/jb3... - jb3

#

[snekbox] GitHub Actions checks success on main

#

[snekbox] GitHub Actions checks failure on pull request #185

#

jb3

[snekbox:jb3/3.12-ignores] 1 new commit

cd604fe Disable dependencies without wheels on 3.12 - jb3

#

[snekbox] GitHub Actions checks success on pull request #185

#

jb3

[python-discord/snekbox] branch deleted: jb3/3.12-ignores

#

jb3

[python-discord/snekbox] branch deleted: jb3/refactor-eval-deps

#

[snekbox] GitHub Actions checks success on main

#

jb3

[python-discord/snekbox] New comment on pull request #185: Refactor how we process eval dependencies

Thanks!

#

jb3

[python-discord/snekbox] Pull request closed: #185 Refactor how we process eval dependencies

#

jb3

[snekbox:jb3/refactor-eval-deps] 2 new commits

9003c28 Move dependencies out of deployment file into t... - jb3
e836f80 Switch from using postStart hooks to an init co... - jb3

#

jb3

[python-discord/snekbox] Pull request opened: #185 Refactor how we process eval dependencies

Right now, our eval dependencies are pulled in using a script embedded within the deployment file, and all dependencies are listed there. This gets a bit messy the more dependencies we want to add, especially if we want to add version markers.

This PR splits out the dependencies into a new file under requirements/ and moves the dependency install process to it's own init container instead of being a task that executes within the snekbox container after it starts. This also allows for gre...

#

[snekbox] GitHub Actions checks success on main

#

jb3

[snekbox] Branch jb3/refactor-eval-deps was force-pushed to `4251c08`

#

ChrisLovering

[python-discord/snekbox] Pull request review submitted: #185 Refactor how we process eval dependencies

#

jb3

[snekbox:main] 3 new commits

e208c8c Move eval deps into their own requirements file - jb3
4251c08 Switch from using post start hooks to init cont... - jb3
afda301 Merge pull request #185 from python-discord/jb3... - jb3

odd spireBOT Aug 30, 2023, 6:02 AM

#

[python-discord/site] Checks Failed on PR: #1081 Bump sentry-sdk from 1.29.2 to 1.30.0

GitHub Actions run 6021132225 failed.

PR Author

Workflow Run

CI #491

Source Branch

dependabot/pip/sentry-sdk-1.30.0

regal archBOT Aug 30, 2023, 7:47 AM

#

SomeHybrid

[python-discord/sir-lancebot] Issue opened: #1353 Let the `.rfc` command be usable in other channels.

Description

Change the .rfc command to work in channels like #python-discussion

Reasoning

Currently, the .rfc command only works in #sir-lancebot-playground. However, the .rfc command should also be able to be used in other relevant channels like #python-discussion

Would you like to implement this yourself?

[x] I'd like to implement this feature myself
[x] Anyone can implement this feature

regal archBOT Aug 30, 2023, 9:51 AM

#

jchristgit

[python-discord/site] Pull request closed: #1081 Bump sentry-sdk from 1.29.2 to 1.30.0

#

jchristgit

[site:main] 2 new commits

fc458d0 Bump sentry-sdk from 1.29.2 to 1.30.0 - dependabot[bot]
aa23f4f Merge pull request #1081 from python-discord/de... - jchristgit

odd spireBOT Aug 30, 2023, 9:55 AM

#

[python-discord/site] Checks Failed on PR: #1078 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 6023335024 failed.

PR Author

Workflow Run

CI #493

Source Branch

dependabot/pip/ruff-0.0.286

regal archBOT Aug 30, 2023, 10:10 AM

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1353: Let the `.rfc` command be usable in other channels.

Sounds fine to me, feel free to open a PR

#

jchristgit

[python-discord/site] Pull request closed: #1078 Bump ruff from 0.0.285 to 0.0.286

#

jchristgit

[site:main] 2 new commits

5a08b47 Bump ruff from 0.0.285 to 0.0.286 - dependabot[bot]
cdcb8de Merge pull request #1078 from python-discord/de... - jchristgit

odd spireBOT Aug 30, 2023, 10:39 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1354 Bump sentry-sdk from 1.29.2 to 1.30.0

GitHub Actions run 6023797772 succeeded.

PR Author

Workflow Run

Status Embed #3653

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Aug 30, 2023, 11:11 AM

#

shtlrs

[python-discord/sir-lancebot] New comment on issue #1353: Let the `.rfc` command be usable in other channels.

@SomeHybrid Please let us know if you want to implement this yourself so that we assign it to you.

#

ChrisLovering

[python-discord/snekbox] New comment on pull request #175: Support Multiple Python Versions

Closing this now that https://github.com/python-discord/snekbox/pull/181 is merged

#

ChrisLovering

[python-discord/snekbox] Pull request closed: #175 Support Multiple Python Versions

#

SomeHybrid

[python-discord/sir-lancebot] New comment on issue #1353: Let the `.rfc` command be usable in other channels.

@SomeHybrid Please let us know if you want to implement this yourself so that we assign it to you.
👍

#

mbaruh

[python-discord/.github] New comment on pull request #24: Interpolate the variable holding all the fixup commits.

Dog accepted

#

mbaruh

[python-discord/.github] Pull request closed: #24 Interpolate the variable holding all the fixup commits.

#

mbaruh

[.github:main] 2 new commits

f94f05f interpolate the commit_messages var

shtlrs
09200df Merge pull request #24 from python-discord/inte... - mbaruh

regal archBOT Aug 30, 2023, 11:53 AM

#

ChrisLovering

[snekbox:update-eval-deps] 2 new commits

01ed0e7 Bump eval-deps to latest versions - ChrisLovering
e339998 Add references to when eval packages will be up... - ChrisLovering

#

ChrisLovering

[python-discord/snekbox] New branch created: update-eval-deps

#

ChrisLovering

[python-discord/snekbox] Pull request opened: #186 Update eval deps

#

[snekbox] GitHub Actions checks success on pull request #186

odd spireBOT Aug 30, 2023, 12:19 PM

#

[python-discord/bot] Checks Successful on PR: #2735 Bump sentry-sdk from 1.29.2 to 1.30.0

GitHub Actions run 6024722007 succeeded.

PR Author

Workflow Run

CI #1024

Source Branch

dependabot/pip/sentry-sdk-1.30.0

regal archBOT Aug 30, 2023, 12:34 PM

#

wookie184

[python-discord/snekbox] Issue opened: #187 Add inode limits to tmpfs

Adding an inode limit would limit the number of files/directories that can exist in the tmpfs we use for file IO. Given we already have file size limits, a maximum number of files we'll read, and a timeout, it shouldn't be too important, but it may be worth putting a limit to be safe. Currently it seems to be limited by the cgroup memory limit using (allowing for about 50_000 files with the current config).

This can be done by passing the nr_inodes argument here:
https://github.com/pyt...

#

wookie184

[python-discord/snekbox] Pull request review submitted: #113 Enable a limited tmpfs for shared memory

Great stuff, thanks for working on this

#

MarkKoz

[python-discord/snekbox] Pull request review dismissed: #113 Enable a limited tmpfs for shared memory

#

wookie184

[snekbox:jb3/shared-mem] 17 new commits

fae8053 Remove explicit package versions from Dockerfile - MarkKoz
9b3f23b Use buildpack-deps as the builder base image - MarkKoz
0db60fc Install multiple Python versions in image - MarkKoz
a53e235 Use --link with COPY in Dockerfile - MarkKoz
e423b7c Remove leading empty strings from NsJail config... - MarkKoz

#

[snekbox] GitHub Actions checks success on jb3/shared-mem

#

wookie184

[python-discord/snekbox] Pull request closed: #113 Enable a limited tmpfs for shared memory

#

wookie184

[snekbox:main] 4 new commits

abbf2e9 Enable a limited tmpfs for shared memory - jb3
8028c08 Update tests to account for shared memory - jb3
08e7636 Merge branch 'main' into jb3/shared-mem - wookie184
2b5f8a0 Merge pull request #113 from python-discord/jb3... - wookie184

#

wookie184

[python-discord/snekbox] branch deleted: jb3/shared-mem

#

[snekbox] GitHub Actions checks success on main

#

[snekbox] GitHub Actions checks success on main

#

ChrisLovering

[snekbox:test-init-container-in-CI] 1 new commit

7c7d7e8 Test deployment init container in CI - ChrisLovering

#

ChrisLovering

[python-discord/snekbox] New branch created: test-init-container-in-CI

#

ChrisLovering

[python-discord/snekbox] Pull request opened: #188 Test deployment init container in CI

This runs the same command, with the same env vars, that the init container in deployment.yaml does, but in CI.

Doing this gives us more reassurance that merging a PR will deploy to prod.

#

[snekbox] GitHub Actions checks success on pull request #188

#

ChrisLovering

[snekbox] Branch test-init-container-in-CI was force-pushed to `e7c0392`

#

[snekbox] GitHub Actions checks success on pull request #188

#

ChrisLovering

[snekbox] Branch test-init-container-in-CI was force-pushed to `28e5725`

#

ChrisLovering

[snekbox] Branch test-init-container-in-CI was force-pushed to `3f5eb47`

#

ChrisLovering

[snekbox] Branch test-init-container-in-CI was force-pushed to `c178381`

#

ChrisLovering

[snekbox] Branch test-init-container-in-CI was force-pushed to `e7cc447`

#

[snekbox] GitHub Actions checks success on pull request #188

#

[snekbox] GitHub Actions checks failure on pull request #188

#

ChrisLovering

[snekbox] Branch test-init-container-in-CI was force-pushed to `08a9156`

#

[snekbox] GitHub Actions checks failure on pull request #188

#

[snekbox] GitHub Actions checks success on pull request #188

#

ChrisLovering

[snekbox] Branch test-init-container-in-CI was force-pushed to `818307f`

#

[snekbox] GitHub Actions checks success on pull request #188

#

[snekbox] GitHub Actions checks success on pull request #188

regal archBOT Aug 30, 2023, 2:26 PM

#

wookie184

[snekbox:wookie184-fix-readme-link] 1 new commit

befd486 Fix link in readme - wookie184

#

wookie184

[python-discord/snekbox] New branch created: wookie184-fix-readme-link

#

wookie184

[python-discord/snekbox] Pull request opened: #189 Fix link in readme

Links to here https://github.com/python-discord/snekbox#memory-file-system, I assume it was just renamed at some point but this link wasn't updated.

#

[snekbox] GitHub Actions checks success on pull request #189

regal archBOT Aug 30, 2023, 3:17 PM

#

jb3

[python-discord/snekbox] Pull request closed: #188 Test deployment init container in CI

#

jb3

[snekbox:main] 2 new commits

818307f Test deployment init container in CI - ChrisLovering
4bbde82 Merge pull request #188 from python-discord/tes... - jb3

#

jb3

[python-discord/snekbox] branch deleted: test-init-container-in-CI

#

jb3

[python-discord/snekbox] Pull request review submitted: #188 Test deployment init container in CI

#

[snekbox] GitHub Actions checks success on main

#

jb3

[python-discord/snekbox] Pull request review submitted: #189 Fix link in readme

#

jb3

[snekbox:wookie184-fix-readme-link] 3 new commits

818307f Test deployment init container in CI - ChrisLovering
4bbde82 Merge pull request #188 from python-discord/tes... - jb3
8fe5293 Merge branch 'main' into wookie184-fix-readme-link - jb3

#

[snekbox] GitHub Actions checks success on pull request #189

#

[snekbox] GitHub Actions checks success on main

#

ChrisLovering

[python-discord/snekbox] Pull request closed: #189 Fix link in readme

#

ChrisLovering

[snekbox:main] 1 new commit

25b84f4 Fix link in readme (#189) - wookie184

#

ChrisLovering

[python-discord/snekbox] branch deleted: wookie184-fix-readme-link

#

[snekbox] GitHub Actions checks success on main

#

ChrisLovering

[snekbox] Branch update-eval-deps was force-pushed to `33d3dc3`

#

[snekbox] GitHub Actions checks success on pull request #186

#

[snekbox] GitHub Actions checks success on main

regal archBOT Aug 30, 2023, 10:08 PM

#

ChrisLovering

[snekbox:share-deployment-dep-script-with-ci] 1 new commit

bf7fb5d Make CI and deployment.yaml share the same depe... - ChrisLovering

#

ChrisLovering

[python-discord/snekbox] New branch created: share-deployment-dep-script-with-ci

#

ChrisLovering

[python-discord/snekbox] Pull request opened: #190 Make CI and deployment.yaml share the same dependency install script

#

ChrisLovering

[snekbox] Branch share-deployment-dep-script-with-ci was force-pushed to `4e58eb5`

#

[snekbox] GitHub Actions checks failure on pull request #190

#

[snekbox] GitHub Actions checks failure on pull request #190

#

ChrisLovering

[snekbox] Branch share-deployment-dep-script-with-ci was force-pushed to `3fc6442`

#

[snekbox] GitHub Actions checks failure on pull request #190

#

ChrisLovering

[snekbox] Branch share-deployment-dep-script-with-ci was force-pushed to `ddb35ad`

#

[snekbox] GitHub Actions checks failure on pull request #190

regal archBOT Aug 30, 2023, 10:53 PM

#

ChrisLovering

[snekbox] Branch share-deployment-dep-script-with-ci was force-pushed to `ac4f761`

#

ChrisLovering

[snekbox] Branch share-deployment-dep-script-with-ci was force-pushed to `9586c5b`

#

[snekbox] GitHub Actions checks failure on pull request #190

#

[snekbox] GitHub Actions checks success on pull request #190

regal archBOT Aug 31, 2023, 1:38 AM

#

MarkKoz

[python-discord/snekbox] Pull request review submitted: #190 Make CI and deployment.yaml share the same dependency install script

#

MarkKoz

[python-discord/snekbox] New review comment on pull request #190: Make CI and deployment.yaml share the same dependency install script

Would be good to add set -euo pipefail as sane defaults in case anything ever changes in this script

regal archBOT Aug 31, 2023, 3:59 AM

#

Xithrius

[python-discord/bot] Pull request closed: #2735 Bump sentry-sdk from 1.29.2 to 1.30.0

#

Xithrius

[bot:main] 1 new commit

066ff15 Bump sentry-sdk from 1.29.2 to 1.30.0 (#2735) - dependabot[bot]

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #1354 Bump sentry-sdk from 1.29.2 to 1.30.0

#

Xithrius

[sir-lancebot:main] 1 new commit

691bbe1 Bump sentry-sdk from 1.29.2 to 1.30.0 (#1354) - dependabot[bot]

oak estuaryBOT Aug 31, 2023, 4:02 AM

#

Python Bot

Connected!

odd spireBOT Aug 31, 2023, 4:02 AM

#

[python-discord/bot] Checks Failed on PR: #2733 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 6032866397 failed.

PR Author

Workflow Run

CI #1026

Source Branch

dependabot/pip/ruff-0.0.286

night lilyBOT Aug 31, 2023, 4:02 AM

#

Sir Lancebot

Connected!

regal archBOT Aug 31, 2023, 4:02 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #1352 Bump pydis-core from 10.1.0 to 10.2.0

#

Xithrius

[sir-lancebot:main] 1 new commit

4cbc00a Bump pydis-core from 10.1.0 to 10.2.0 (#1352) - dependabot[bot]

odd spireBOT Aug 31, 2023, 4:02 AM

#

[python-discord/sir-lancebot] Checks Failed on PR: #1351 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 6032877876 failed.

PR Author

Workflow Run

Status Embed #3654

Source Branch

dependabot/pip/ruff-0.0.286

regal archBOT Aug 31, 2023, 4:03 AM

#

Xithrius

[python-discord/bot] Pull request closed: #2734 Bump pydis-core from 10.1.0 to 10.2.0

#

Xithrius

[bot:main] 1 new commit

0e2fd19 Bump pydis-core from 10.1.0 to 10.2.0 (#2734) - dependabot[bot]

odd spireBOT Aug 31, 2023, 4:03 AM

#

[python-discord/sir-lancebot] Workflow Cancelled

GitHub Actions run 6032881092 was cancelled.

Actor

Xithrius

Workflow Run

Status Embed #3656

Commit

4cbc00a

#

[python-discord/bot] Checks Successful on PR: #2734 Bump pydis-core from 10.1.0 to 10.2.0

GitHub Actions run 6032872990 succeeded.

PR Author

Workflow Run

CI #1027

Source Branch

dependabot/pip/pydis-core-10.2.0

regal archBOT Aug 31, 2023, 4:03 AM

#

Xithrius

[sir-lancebot:dependabot/pip/ruff-0.0.286] 1 new commit

ea39b07 Made ruff happy - Xithrius

night lilyBOT Aug 31, 2023, 4:04 AM

#

Sir Lancebot

Connected!

oak estuaryBOT Aug 31, 2023, 4:05 AM

#

Python Bot

Connected!

regal archBOT Aug 31, 2023, 4:05 AM

#

Xithrius

[sir-lancebot:dependabot/pip/ruff-0.0.286] 2 new commits

4cbc00a Bump pydis-core from 10.1.0 to 10.2.0 (#1352) - dependabot[bot]
9b1c70c Merge branch 'main' into dependabot/pip/ruff-0.... - Xithrius

odd spireBOT Aug 31, 2023, 4:06 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1351 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 6032906977 succeeded.

PR Author

Workflow Run

Status Embed #3658

Source Branch

dependabot/pip/ruff-0.0.286

#

[python-discord/bot] Checks Failed on PR: #2733 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 6032903196 failed.

PR Author

Workflow Run

CI #1029

Source Branch

dependabot/pip/ruff-0.0.286

regal archBOT Aug 31, 2023, 4:07 AM

#

Xithrius

[bot:dependabot/pip/ruff-0.0.286] 1 new commit

30c1842 Made ruff happy - Xithrius

odd spireBOT Aug 31, 2023, 4:09 AM

#

[python-discord/bot] Checks Successful on PR: #2733 Bump ruff from 0.0.285 to 0.0.286

GitHub Actions run 6032917062 succeeded.

PR Author

Workflow Run

CI #1030

Source Branch

dependabot/pip/ruff-0.0.286

odd spireBOT Aug 31, 2023, 5:33 AM

#

[python-discord/site] Checks Failed on PR: #1082 Bump pymdown-extensions from 10.2 to 10.2.1

GitHub Actions run 6033444144 failed.

PR Author

Workflow Run

CI #495

Source Branch

dependabot/pip/pymdown-extensions-1...

#

[python-discord/site] Checks Failed on PR: #1083 Bump django-environ from 0.10.0 to 0.11.1

GitHub Actions run 6033449054 failed.

PR Author

Workflow Run

CI #496

Source Branch

dependabot/pip/django-environ-0.11.1

regal archBOT Aug 31, 2023, 7:10 AM

#

jchristgit

[python-discord/site] New comment on pull request #1083: Bump django-environ from 0.10.0 to 0.11.1

Good morning @shtlrs. Please accept this picture as a consolidation for waking you up this early.

It is my understanding that with the merge of https://github.com/python-discord/.github/pull/24 the fixup blocker should not pop up here. Or do we need to update something in this pull request?

#

jchristgit

[python-discord/site] New comment on issue #678: Document testing of site functionality

Good morning @Xithrius. Do you want to take on this task still?

#

shtlrs

[site:trigger-fixup-on-pr-target] 1 new commit

252c491 trigger the fixup workflow on the `pull_request... - shtlrs

#

shtlrs

[python-discord/site] New branch created: trigger-fixup-on-pr-target

#

jchristgit

[site:document-static-previews] 1 new commit

b51eed2 Document Netlify static previews - jchristgit

#

jchristgit

[python-discord/site] New branch created: document-static-previews

#

jchristgit

[python-discord/site] Pull request opened: #1084 Document Netlify static previews

Closes #677.

odd spireBOT Aug 31, 2023, 7:21 AM

#

[python-discord/site] Checks Failed on PR: #1084 Document Netlify static previews

GitHub Actions run 6034264506 failed.

PR Author

Workflow Run

CI #497

Source Branch

document-static-previews

regal archBOT Aug 31, 2023, 7:24 AM

#

shtlrs

[python-discord/site] Pull request opened: #1085 Trigger the fixup workflow on the `pull_request_targer` event

#

shtlrs

[python-discord/site] New comment on pull request #1083: Bump django-environ from 0.10.0 to 0.11.1

Good morning @shtlrs. Please accept this picture as a consolidation for waking you up this early.

It is my understanding that with the merge of python-discord/.github#24 the fixup blocker should not pop up here. Or do we need to update something in this pull request?

Good morning @jchristgit , I accept the doggo...

odd spireBOT Aug 31, 2023, 7:26 AM

#

[python-discord/site] Checks Failed on PR: #1085 Trigger the fixup workflow on the `pull_request_targer` event

GitHub Actions run 6034315146 failed.

PR Author

Workflow Run

CI #498

Source Branch

trigger-fixup-on-pr-target

regal archBOT Aug 31, 2023, 7:28 AM

#

jchristgit

[python-discord/site] Pull request review submitted: #1085 Trigger the fixup workflow on the `pull_request_targer` event

Thanks!

#

jchristgit

[python-discord/site] Pull request closed: #1085 Trigger the fixup workflow on the `pull_request_target` event

#

jchristgit

[site:main] 2 new commits

252c491 trigger the fixup workflow on the pull_request... - shtlrs [416ebfa`](https://github.com/python-discord/site/commit/416ebfa620bba2de98f2fd530cd716d097186255) Merge pull request #1085 from python-discord/tr... - jchristgit

#

jchristgit

[python-discord/site] branch deleted: trigger-fixup-on-pr-target

#

jchristgit

[site:main] 1 new commit

a74a8ef Pleasure the style dictator - jchristgit

odd spireBOT Aug 31, 2023, 7:30 AM

#

[python-discord/site] Workflow Cancelled

GitHub Actions run 6034347386 was cancelled.

Actor

Workflow Run

CI #499

Commit

416ebfa

regal archBOT Aug 31, 2023, 7:35 AM

#

shtlrs

[python-discord/site] New comment on pull request #1083: Bump django-environ from 0.10.0 to 0.11.1

@dependabot rebase

odd spireBOT Aug 31, 2023, 7:38 AM

#

[python-discord/site] Checks Successful on PR: #1083 Bump django-environ from 0.10.0 to 0.11.1

GitHub Actions run 6034424284 succeeded.

PR Author

Workflow Run

CI #501

Source Branch

dependabot/pip/django-environ-0.11.1

regal archBOT Aug 31, 2023, 7:44 AM

#

jchristgit

[python-discord/site] Pull request closed: #1083 Bump django-environ from 0.10.0 to 0.11.1

#

jchristgit

[site:main] 2 new commits

611efe8 Bump django-environ from 0.10.0 to 0.11.1 - dependabot[bot]
6c2d393 Merge pull request #1083 from python-discord/de... - jchristgit

odd spireBOT Aug 31, 2023, 7:48 AM

#

[python-discord/site] Checks Successful on PR: #1082 Bump pymdown-extensions from 10.2 to 10.2.1

GitHub Actions run 6034500039 succeeded.

PR Author

Workflow Run

CI #503

Source Branch

dependabot/pip/pymdown-extensions-1...

regal archBOT Aug 31, 2023, 9:07 AM

#

ChrisLovering

[snekbox:share-deployment-dep-script-with-ci] 2 new commits

5850599 fixup: add set -euo pipefail as sane defaults - ChrisLovering
38a8e97 fix: add make target for installing eval deps - ChrisLovering

#

ChrisLovering

[snekbox] Branch share-deployment-dep-script-with-ci was force-pushed to `f637e54`

#

ChrisLovering

[python-discord/snekbox] New review comment on pull request #190: Make CI and deployment.yaml share the same dependency install script

Added in https://github.com/python-discord/snekbox/pull/190/commits/b0180ee7cded3ca51ab832892ae162f13a0e1783 had to change it to run under bash for -o pipefail support.

I've also added a make target since I found myself copy-pasting from CI a lot while testing this.

#

[snekbox] GitHub Actions checks success on pull request #190

#

[snekbox] GitHub Actions checks success on pull request #190

regal archBOT Aug 31, 2023, 10:04 AM

#

jchristgit

[python-discord/site] Pull request closed: #1082 Bump pymdown-extensions from 10.2 to 10.2.1

#

jchristgit

[site:main] 2 new commits

a938817 Bump pymdown-extensions from 10.2 to 10.2.1 - dependabot[bot]
3290d8d Merge pull request #1082 from python-discord/de... - jchristgit

#

jchristgit

[site] Branch document-static-previews was force-pushed to `0cff3a3`

odd spireBOT Aug 31, 2023, 10:21 AM

#

[python-discord/site] Checks Successful on PR: #1084 Document Netlify static previews

GitHub Actions run 6036062404 succeeded.

PR Author

Workflow Run

CI #505

Source Branch

document-static-previews

regal archBOT Aug 31, 2023, 12:20 PM

#

n0Oo0Oo0b

[python-discord/bot] Pull request opened: #2736 Improve the `repl` tag

Closes python-discord/meta#214

#

n0Oo0Oo0b

[python-discord/bot] New comment on pull request #2736: Improve the `repl` tag

I'm not sure if having the for loop in the example is worth the additional vertical space, but I thought including some multiline input would be beneficial.

odd spireBOT Aug 31, 2023, 12:21 PM

#

[python-discord/bot] Checks Failed on PR: #2736 Improve the `repl` tag

GitHub Actions run 6037214140 failed.

PR Author

Workflow Run

CI #1031

Source Branch

n0Oo0Oo0b:improve-repl-tag

regal archBOT Aug 31, 2023, 12:33 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #2736 Improve the `repl` tag

Nice, this is a big improvement

#

wookie184

[python-discord/bot] New review comment on pull request #2736: Improve the `repl` tag

The >>> or ... at the start of some lines is the code input, and it indicates that you are in the Python REPL.

This sentence feels a bit clunky, maybe this would be better:

To enter the REPL, run `python` in the command line without any arguments. The `>>>` or `...` at the start of some lines are prompts to enter code, and indicate that you are in the Python REPL. Any other lines show the output of the code.

#

wookie184

[python-discord/bot] New comment on pull request #2736: Improve the `repl` tag

Also take a look at CI, looks like there's some trailing whitespace somewhere that needs removing

#

n0Oo0Oo0b

[python-discord/bot] New comment on pull request #2736: Improve the `repl` tag

Also take a look at CI, looks like there's some trailing whitespace somewhere that needs removing

The trailing whitespace is after the empty ... and >>> lines, otherwise they won't get syntax highlighted in Discord

#

wookie184

[python-discord/site] Pull request review submitted: #1084 Document Netlify static previews

Markdown doesn't seem to have rendered as intended https://deploy-preview-1084--pydis-static.netlify.app/pages/guides/pydis-guides/contributing/site/#773httpsgithubcompython-discordsitepull773issuecomment-1257224147

odd spireBOT Aug 31, 2023, 12:38 PM

#

[python-discord/bot] Checks Failed on PR: #2736 Improve the `repl` tag

GitHub Actions run 6037400447 failed.

PR Author

Workflow Run

CI #1032

Source Branch

n0Oo0Oo0b:improve-repl-tag

regal archBOT Aug 31, 2023, 12:42 PM

#

wookie184

[python-discord/bot] New comment on pull request #2736: Improve the `repl` tag

Also take a look at CI, looks like there's some trailing whitespace somewhere that needs removing

The trailing whitespace is after the empty ... and >>> lines, otherwise they won't get syntax highlighted in Discord

Oh interesting, try changing the codeblock language to python-repl, seems like it doesn't need the space then.

#

wookie184

[python-discord/bot] New comment on pull request #2736: Improve the `repl` tag

Hmm it seems like python-repl isn't supported at all on android (works on desktop for me though)

#

n0Oo0Oo0b

[python-discord/bot] New comment on pull request #2736: Improve the `repl` tag

Also take a look at CI, looks like there's some trailing whitespace somewhere that needs removing

The trailing whitespace is after the empty ... and >>> lines, otherwise they won't get syntax highlighted in Discord

Oh interesting, try changing the codeblock language to python-repl, seems like it doesn't need the space then.

That seems to work, thanks

#

sid-maddy

[python-discord/bot] New review comment on pull request #2736: Improve the `repl` tag

```python-repl

This allows you to trim the whitespace from the ... and >>> lines, while retaining the highlighting.

odd spireBOT Aug 31, 2023, 12:49 PM

#

[python-discord/bot] Checks Successful on PR: #2736 Improve the `repl` tag

GitHub Actions run 6037514329 succeeded.

PR Author

Workflow Run

CI #1033

Source Branch

n0Oo0Oo0b:improve-repl-tag

regal archBOT Aug 31, 2023, 12:56 PM

#

jchristgit

[site] Branch document-static-previews was force-pushed to `0e38906`

#

jchristgit

[python-discord/site] New comment on pull request #1084: Document Netlify static previews

I hate bad markdown implementations
I hate bad markdown implementations
I hate bad markdown implementations
I hate bad markdown implementations
I hate bad markdown implementations

odd spireBOT Aug 31, 2023, 12:59 PM

#

[python-discord/site] Checks Successful on PR: #1084 Document Netlify static previews

GitHub Actions run 6037619499 succeeded.

PR Author

Workflow Run

CI #506

Source Branch

document-static-previews

regal archBOT Aug 31, 2023, 1:10 PM

#

n0Oo0Oo0b

[python-discord/bot] Pull request opened: #2737 Improve the `in-place` tag

Closes python-discord/meta#213

odd spireBOT Aug 31, 2023, 1:12 PM

#

[python-discord/bot] Checks Successful on PR: #2737 Improve the `in-place` tag

GitHub Actions run 6037789382 succeeded.

PR Author

Workflow Run

CI #1034

Source Branch

n0Oo0Oo0b:improve-inplace-tag

regal archBOT Aug 31, 2023, 1:15 PM

#

n0Oo0Oo0b

[python-discord/bot] Pull request review submitted: #2736 Improve the `repl` tag

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2736: Improve the `repl` tag

To enter the REPL, run `python` (`py` on Windows) in the command line without any arguments. The `>>>` or `...` at the start of some lines are prompts to enter code, and indicate that you are in the Python REPL. Any other lines show the output of the code.

Suggested by MoyenChat in [#community-meta](#community-meta message)

odd spireBOT Aug 31, 2023, 1:17 PM

#

[python-discord/bot] Checks Successful on PR: #2736 Improve the `repl` tag

GitHub Actions run 6037855692 succeeded.

PR Author

https://github.com/python-discord/sir-robin/pull/91/commits/f166d325803f3c621807a3bbeade7ca106046c97

Workflow Run

CI #1035

Source Branch

n0Oo0Oo0b:improve-repl-tag

regal archBOT Aug 31, 2023, 1:22 PM

#

sid-maddy

[python-discord/bot] Pull request review submitted: #2736 Improve the `repl` tag

regal archBOT Aug 31, 2023, 1:59 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #2736 Improve the `repl` tag

#

wookie184

[python-discord/bot] Pull request closed: #2736 Improve the `repl` tag

#

wookie184

[bot:main] 1 new commit

03069d0 Improve the repl tag (#2736) - n0Oo0Oo0b

oak estuaryBOT Aug 31, 2023, 2:02 PM

#

Python Bot

Connected!

regal archBOT Aug 31, 2023, 2:11 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #2737 Improve the `in-place` tag

#

wookie184

[python-discord/bot] New review comment on pull request #2737: Improve the `in-place` tag

The full stop here will appear by itself

Should move it to the previous line, or split somewhere on a single space so no newline is rendered.

#

wookie184

[python-discord/site] Pull request review submitted: #1084 Document Netlify static previews

Thanks.

at least the deploy preview decided to work for this PR

#

wookie184

[python-discord/site] Pull request closed: #1084 Document Netlify static previews

#

wookie184

[site:main] 2 new commits

0e38906 Document Netlify static previews - jchristgit
cb6326c Merge pull request #1084 from python-discord/do... - wookie184

#

wookie184

[python-discord/site] Issue closed: #677 Document Netlify static previews

#

wookie184

[python-discord/site] branch deleted: document-static-previews

regal archBOT Aug 31, 2023, 5:39 PM

#

ChrisLovering

[python-discord/sir-robin] Pull request closed: #85 Fix a couple small bugs

#

ChrisLovering

[sir-robin:main] 1 new commit

239b344 Fix a couple small bugs (#85) - camcaswell

#

MarkKoz

[python-discord/snekbox] Pull request review submitted: #190 Make CI and deployment.yaml share the same dependency install script

Thanks

thin oysterBOT Aug 31, 2023, 5:41 PM

#

Sir Robin

Connected!

regal archBOT Aug 31, 2023, 5:50 PM

#

wookie184

[python-discord/sir-robin] Pull request review submitted: #91 Bump bot core and use new paste service

The uses of send_to_paste_service need to be changed now that it handles the errors that can be ranged (the old function worked by potentially returning None instead).

Also, it returns a PasteResponse now so you need .link to get the link from it rather than using the returned value directly

regal archBOT Aug 31, 2023, 6:09 PM

#

ChrisLovering

[python-discord/snekbox] Pull request closed: #190 Make CI and deployment.yaml share the same dependency install script

#

ChrisLovering

[snekbox:main] 1 new commit

7303301 Make CI and deployment.yaml share the same depe... - ChrisLovering

#

ChrisLovering

[python-discord/snekbox] branch deleted: share-deployment-dep-script-with-ci

#

[snekbox] GitHub Actions checks success on main

#

ChrisLovering

[sir-robin:bump-bot-core] 1 new commit

f166d32 fixup: handle errors that new send_to_paste_ser... - ChrisLovering

#

ChrisLovering

[python-discord/sir-robin] New comment on pull request #91: Bump bot core and use new paste service

The uses of send_to_paste_service need to be changed now that it handles the errors that can be ranged (the old function worked by potentially returning None instead).

Also, it returns a PasteResponse now so you need .link to get the link from it rather than using the returned value directly

#

ChrisLovering

[sir-robin] Branch bump-bot-core was force-pushed to `27d925e`

odd spireBOT Aug 31, 2023, 6:17 PM

#

[python-discord/sir-robin] Checks Successful on PR: #91 Bump bot core and use new paste service

GitHub Actions run 6040989605 succeeded.

PR Author

Workflow Run

Status Embed #283

Source Branch

bump-bot-core

#

[python-discord/sir-robin] Checks Successful on PR: #91 Bump bot core and use new paste service

GitHub Actions run 6040997321 succeeded.

PR Author

Workflow Run

Status Embed #284

Source Branch

bump-bot-core

regal archBOT Aug 31, 2023, 6:25 PM

#

[snekbox] GitHub Actions checks failure on main

#

wookie184

[python-discord/sir-robin] Pull request review submitted: #91 Bump bot core and use new paste service

LGTM

regal archBOT Aug 31, 2023, 7:23 PM

#

ChrisLovering

[snekbox:include-install-script-in-final-image] 1 new commit

a5f9ca1 Include install eval deps in final image - ChrisLovering

#

ChrisLovering

[python-discord/snekbox] New branch created: include-install-script-in-final-image

#

ChrisLovering

[python-discord/snekbox] Pull request opened: #191 Include install eval deps in final image

#

ChrisLovering

[sir-robin] Branch bump-bot-core was force-pushed to `3001fd4`

odd spireBOT Aug 31, 2023, 7:27 PM

#

[python-discord/sir-robin] Checks Successful on PR: #91 Bump bot core and use new paste service

GitHub Actions run 6041612966 succeeded.

PR Author

Workflow Run

Status Embed #285

Source Branch

bump-bot-core

regal archBOT Aug 31, 2023, 7:28 PM

#

[snekbox] GitHub Actions checks success on pull request #191

#

brodycritchlow

[python-discord/sir-lancebot] Issue opened: #1355 Add pastebin link to .bm command.

Description

I have recently been using the .bm command and noticed when bookmarking codeblocks it doesnt provide a pastebin link with it. It would be a nice feature to add this.

Reasoning

Provides an easier way to share / copy the code you bookmarked.

Would you like to implement this yourself?

[x] I'd like to implement this feature myself
[ ] Anyone can implement this feature

regal archBOT Aug 31, 2023, 8:06 PM

#

ChrisLovering

[sir-robin:add-ping-team-command] 2 new commits

5006072 Correct spelling mistake in Dockerfile - ChrisLovering
e42b09c Add new command to ping a cj team from their te... - ChrisLovering

#

ChrisLovering

[python-discord/sir-robin] New branch created: add-ping-team-command

#

ChrisLovering

[python-discord/sir-robin] Pull request opened: #92 Add ping team command

odd spireBOT Aug 31, 2023, 8:07 PM

#

[python-discord/sir-robin] Checks Successful on PR: #92 Add ping team command

GitHub Actions run 6041946698 succeeded.

PR Author

Workflow Run

Status Embed #286

Source Branch

add-ping-team-command

regal archBOT Aug 31, 2023, 8:32 PM

#

vivekashok1221

[python-discord/sir-robin] Pull request review submitted: #92 Add ping team command

LGTM.

#

jchristgit

[python-discord/sir-robin] Pull request review submitted: #92 Add ping team command

regal archBOT Aug 31, 2023, 9:37 PM

#

MarkKoz

[python-discord/snekbox] Pull request review submitted: #191 Include install eval deps in final image

#

ChrisLovering

[python-discord/snekbox] Pull request closed: #191 Include install eval deps in final image

#

ChrisLovering

[snekbox:main] 1 new commit

ae18976 Include install eval deps in final image (#191) - ChrisLovering

#

ChrisLovering

[python-discord/snekbox] branch deleted: include-install-script-in-final-image

#

[snekbox] GitHub Actions checks success on main

#

[snekbox] GitHub Actions checks success on main

regal archBOT Aug 31, 2023, 10:11 PM

#

DownDev

[python-discord/site] Pull request opened: #1086 refactor(guides): update json database guide

Proposed in python-discord/meta#217

regal archBOT Sep 1, 2023, 1:43 AM

#

n0Oo0Oo0b

[python-discord/bot] New review comment on pull request #2737: Improve the `in-place` tag

My bad, I thought it was on the previous line because of line wrapping.

odd spireBOT Sep 1, 2023, 1:52 AM

#

[python-discord/bot] Checks Successful on PR: #2737 Improve the `in-place` tag

GitHub Actions run 6044450889 succeeded.

PR Author

Workflow Run

CI #1037

Source Branch

n0Oo0Oo0b:improve-inplace-tag

regal archBOT Sep 1, 2023, 3:44 AM

#

SomeHybrid

[python-discord/sir-lancebot] Pull request opened: #1356 Allowed .rfc command in all channels

Relevant Issues

Closes #1353

Description

Used @whitelist_override(roles=(Roles.everyone,)) to allow the .rfc command in all channels

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read and agree to the [contributing guidelines](https://pythondiscord.com/pages/contributing/contributing-guidelin...

odd spireBOT Sep 1, 2023, 3:45 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1356 Allowed .rfc command in all channels

GitHub Actions run 6045165242 succeeded.

PR Author

Workflow Run

Status Embed #3659

Source Branch

SomeHybrid:main

regal archBOT Sep 1, 2023, 4:22 AM

#

ichard26

[python-discord/sir-robin] Pull request review submitted: #92 Add ping team command

This seems to be quite broken...?

#

ichard26

[python-discord/sir-robin] New review comment on pull request #92: Add ping team command

The /teams/find?name=<team name> API endpoint doesn't handle dashes. If this command is invoked in a team channel with a multi-word team, eg. cool-kids, the CJ MGMT system will run a (case insensitive) DB query for cool-kids. Problem is that the team is stored in the DB with the name Cool Kids. The casing doesn't matter, but the space/dash difference does...

#

ichard26

[python-discord/sir-robin] Pull request review submitted: #92 Add ping team command

#

ichard26

[python-discord/sir-robin] New review comment on pull request #92: Add ping team command

        team_resp = await self.bot.code_jam_mgmt_api.get("teams/find", params={"name": ctx.channel.name})

The API seems to 404 because of this extra slash...

regal archBOT Sep 1, 2023, 7:10 AM

#

jchristgit

[python-discord/site] New review comment on pull request #1086: refactor(guides): update json database guide

We should add an example here. How does SQL enforce data integrity? Which forms of bad data does it help against? For instance, in JSON (unless you write your own validation routine, which takes a lot of time and care), you can omit a key or set someone's age to "581 years" and it won't bat an eye. If you're unlucky, you will only catch it later when your app crashes. In an SQL database you would say age is a small integer and add a check constraint to ensure that age is between 0 and 120.

#

jchristgit

[python-discord/site] Pull request review submitted: #1086 refactor(guides): update json database guide

Thank you for the pull request.

Overall I am a fan of the format. However, given the audience I think we should expand a bit on the individual points and add examples to explain, for instance, why do I want data consistency, integrity, etc..

#

jchristgit

[python-discord/site] New review comment on pull request #1086: refactor(guides): update json database guide

Especially in regard to the previous point we should explain the benefits for secondary indexes and their queries here.

#

jchristgit

[python-discord/site] New review comment on pull request #1086: refactor(guides): update json database guide

I think we can expand on this a bit: how does horizontal scaling help SQL databases more than JSON? For instance, we could write that SQL databases can hold their indices and hot data in main memory allowing upgrading of main memory size for good performance gains, while JSON files have no built-in way to index data, so the main option you would have is loading the entire document into memory, which is a lot more inefficient.

#

jchristgit

[python-discord/site] New review comment on pull request #1086: refactor(guides): update json database guide

One point we could add: with the default naive way of writing JSON (and I'm not aware of any trivial, more efficient alternatives), you need to read in and write out the entire JSON file every time you make a change. Grossly inefficient and prone to fatal problems when your app crashes at the wrong time.

regal archBOT Sep 1, 2023, 8:54 AM

#

ChrisLovering

[sir-robin] Branch add-ping-team-command was force-pushed to `0169ca7`

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #92: Add ping team command

Resolved in the forcepush https://github.com/python-discord/sir-robin/compare/e42b09c0a8dfbb6a397ecfbc9201e663b66b0bc5..0169ca74bd9e1151f2b5b122cdf67287131c01bf

#

ChrisLovering

[python-discord/sir-robin] New review comment on pull request #92: Add ping team command

resolved in the forcepush. As you say, it would be nice to get a team via channel id and role id, since we store those too. One for next time I think
https://github.com/python-discord/sir-robin/compare/e42b09c0a8dfbb6a397ecfbc9201e663b66b0bc5..0169ca74bd9e1151f2b5b122cdf67287131c01bf

odd spireBOT Sep 1, 2023, 8:55 AM

#

[python-discord/sir-robin] Checks Successful on PR: #92 Add ping team command

GitHub Actions run 6047455755 succeeded.

PR Author

Workflow Run

Status Embed #287

Source Branch

add-ping-team-command

regal archBOT Sep 1, 2023, 9:25 AM

#

wookie184

[python-discord/bot] Pull request review submitted: #2737 Improve the `in-place` tag

Looks good, thanks!

#

wookie184

[python-discord/bot] Pull request closed: #2737 Improve the `in-place` tag

#

wookie184

[bot:main] 1 new commit

78577b3 Improve the in-place tag (#2737) - n0Oo0Oo0b

odd spireBOT Sep 1, 2023, 9:27 AM

#

[python-discord/bot] Checks Successful on PR: #2737 Improve the `in-place` tag

GitHub Actions run 6047761854 succeeded.

PR Author

Workflow Run

CI #1038

Source Branch

n0Oo0Oo0b:improve-inplace-tag

oak estuaryBOT Sep 1, 2023, 9:29 AM

#

Python Bot

Connected!

regal archBOT Sep 1, 2023, 9:30 AM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1356 Allow the `.rfc` command in all channels

Thanks 👍

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1355: Add pastebin link to .bm command.

The pastebin only supports storing pastes for up to 30 days, so i'm not sure how well it fits with the bookmark command which is intended to store things indefinitely.

odd spireBOT Sep 1, 2023, 12:42 PM

#

[python-discord/bot] Checks Failed on PR: #2738 Bump deepdiff from 6.3.1 to 6.4.0

GitHub Actions run 6049546151 failed.

PR Author