GitHub Actions run 4864635718 succeeded.
#dev-log
1 messages · Page 12 of 1
I see, you're welcome to take this on. The production environment only contains tokens and other secret values, no channels or roles.
GitHub Actions run 4865576224 succeeded.
GitHub Actions run 4868772031 succeeded.
GitHub Actions run 4868775518 succeeded.
GitHub Actions run 4868778940 succeeded.
Re.
I had completely forgotten about this, up until @shenanigansd reminded me.
He also said that he'd want to take this up, so I'll be assigning him.
I think mentioning other relevant tags at the end would be helpful
```
For more information on intents, see `/tag intents`. If prefix commands are still not working, see `/tag on-message-event`.
Speaking of the intents tag, I've just noticed there is a lot of overlap between it and this, maybe we could differentiate the two a bit more?
Thats a good point. I think the beginning is important to have, but maybe removing the part about the privilaged intents, and linking it would be useful. Also, incorporating the fact that you do have to enable it in the discord developer portal at the beginning. Does that sound good?
GitHub Actions run 4876874445 succeeded.
That sounds good to me. I think the intents tag can also be improved (primarily the length because it is very wordy at the moment) but it would be better addressed in a separate PR.
GitHub Actions run 4879551926 succeeded.
GitHub Actions run 4881970783 succeeded.
[king-arthur] Branch add\-pre\-commit\-hooks was force-pushed to `d6972de`
GitHub Actions run 4882711275 failed.
[king-arthur] Branch add\-pre\-commit\-hooks was force-pushed to `90413aa`
GitHub Actions run 4882730747 failed.
[king-arthur] Branch add\-pre\-commit\-hooks was force-pushed to `b4b3058`
[python-discord/king-arthur] branch deleted: add\-pre\-commit\-hooks
GitHub Actions run 4882768953 succeeded.
GitHub Actions run 4882784002 succeeded.
More general question, do we actually need dotenv as a package too?
docker compose loads from the .env files already, and so does poetry run ...
Should these be foo: str | None instead? Maybe even pydantic secret strs?
token: str
Make this required to be passed in
Should this be a pydantic secret str?
What's the rationale behind only sending suggestions if the user isn't a mod+? Surely it'd be helpful to mods+ too.
We could wait for it to be in botcore to add to lancebot since this is a low priority issue. I don't really mind.
I'd be happy to PR for both bot and sir-lancebot now, since it's a small and easy fix, and then it can be unified into a global handler in bot-core as part of the migration whenever that happens.
646e219 port command_wraps/update_wrapper_globals from bot - Numerlor
fcf0e0f add typing-extensions - Numerlor
a3b0ffb Add decorator to block duplicate command invoca... - Numerlor
83f8b2e Check assignments nested in ifs when searching ... - Numerlor
c51a2d7 Only append ids from Name nodes - Numerlor
[python-discord/bot] New branch created: fix\-2486
a3aba25 Add base handling for adding reaction to messag... - TizzySaurus
Completes the bot-side of #2486.
NB: Currently in draft state since there's a known issue where the incidents message scraper will still raise an error that doesn't get handled due to it being inside a scheduler. Currently not sure how to fix this, but going to look into it.
What
When the bot fails to add a reaction to a message because the user has the bot blocked (e.g. creating an incident, editing an eval invocation, etc.) the bot handles this via a log.debug statement, and if ...
GitHub Actions run 4888001956 succeeded.
Description
Lancebot's current help command doesn't subclass HelpCommand, unlike Python's. The former should be changed to match the latter because subclassing HelpCommand is the preferred way of creating custom help commands.
Reasoning
This wouldn't change anything for the end user, but internally, the bot wil...
This comment also mentions that changes to Python's help command should also be applied here, but the changes in python-discord/bot#519 (which refactored Python's help command to subclass HelpCommand) hasn't made it to Lancebot yet.
Isn't the real solution here having an integrated HelpCommand in bot-core that the two bots both use? Since I imagine the logic is extremely similar, if not the exact same across the two bots. This is part of python-discord/bot-core#85. So I guess that's the real solution to this issue.
It's not a good idea have the same logic in two (or more) places, why don't move the logic to a common place? like a module?
It's not a good idea have the same logic in two (or more) places, why don't move the logic to a common place? like a module?
@eamanu That's exactly what bot-core is, and what I just mentioned.
Sorry, I didn't read your comment @TizzySaurus well. Yes, that is better.
GitHub Actions run 4890626534 succeeded.
GitHub Actions run 4890626774 succeeded.
GitHub Actions run 4890629928 succeeded.
Description
When using .help command the signature of the command has extra space when there are no params
Steps to Reproduce
use .help command and look at the command signatures
Expected Behaviour
Display signature without extra space
Actual Behaviour
Displays signature with extra space
Known Impacted Platforms
- [x] Web
- [x] Desktop
- [ ] Android App
- [ ] iOS App
Would you like to implement a fix?
- [x] I'd like to implement the bug ...
GitHub Actions run 4892280636 was cancelled.
GitHub Actions run 4892298830 was cancelled.
Connected!
GitHub Actions run 4892315205 succeeded.
GitHub Actions run 4892331293 succeeded.
Connected!
GitHub Actions run 4892322260 was cancelled.
Connected!
More general question, do we actually need
dotenvas a package too?docker compose loads from the .env files already, and so does
poetry run ...
Hum, good question. Since docker loads them as env variables, there shouldn't be a need to include it. We'll test it out tonight.
We could make them a pydantic's SecretStr, but it will require calling get_secret_value for all of the secrets that we have.
I don't mind having that, it's just that it might not be that obvious to call that method whenever we use secrets, but we can enforce it during reviews i guess.
I'll make them nullable.
As for the SecretStr, see my comment here
It’s still valuable for anyone running outside poetry, is there a downside to including it?
It’s still valuable for anyone running outside poetry, is there a downside to including it?
Dear Scaleios,
Thank you for reaching out to us regarding running our bot. Please be advised that we do not support running our bot outside of either Poetry or Docker.
Poetry is a tool for dependency management and packaging in Python that we use to manage our bot's dependencies. Docker, on the other hand, is a containerization platform that allows us to package our bot and all its dependenc...
b90eeaf Bump pip-licenses from 4.3.0 to 4.3.1 (#1264) - dependabot[bot]
GitHub Actions run 4892786029 succeeded.
Connected!
c3666d0 Prepend [Closed] to name when closing help chan... - ChrisLovering
[python-discord/bot] New branch created: Prepend\-closed\-to\-closed\-help\-channels
This is to better indicate channels that have been closed when viewing them from the forum post list.
That was suggested by Ivo#4985 in [#comunity-feedback](#community-meta message)
GitHub Actions run 4892805761 succeeded.
[bot] Branch Prepend\-closed\-to\-closed\-help\-channels was force-pushed to `99b08c9`
[bot] Branch Prepend\-closed\-to\-closed\-help\-channels was force-pushed to `c70485f`
GitHub Actions run 4892825828 was cancelled.
GitHub Actions run 4892830079 succeeded.
This is now being ported to bot-core so that both bots can use the same code.
321e612 Bump pre-commit from 3.3.0 to 3.3.1 (#1263) - dependabot[bot]
Yea, I don't think we want this feature.
Connected!
I wonder whether it's worth to "ruining" the post title to add this indicator. Could also change it to "🔒" to make it shorter and make it less likely to happen (in that case it might make more sense to not add a placeholder for minimal disruption, as it would only remove one or two characters)
GitHub Actions run 4893637958 succeeded.
GitHub Actions run 4900761281 succeeded.
GitHub Actions run 4900787058 succeeded.
Just two more comments.
We should also prepare an announcement with instructions on what contribs need to change in their .env files before merging this.
Won't this error if Tokens.github is None? We should probably do something like
if Tokens.github:
REQUEST_HEADERS["Authorization"] = f"token {Tokens.github.get_secret_value()}"
This also applies for all the other places with a similar pattern.
Why has wolfram been moved here if we have a specific _Wolfram class?
[python-discord/bot-core] New branch created: log\-when\-waiting\-for\-guild\-to\-be\-available
[bot-core] Branch log\-when\-waiting\-for\-guild\-to\-be\-available was force-pushed to `4b69edb`
[bot-core] Branch log\-when\-waiting\-for\-guild\-to\-be\-available was force-pushed to `77ba4c3`
[python-discord/bot-core] branch deleted: log\-when\-waiting\-for\-guild\-to\-be\-available
fb954b1 update all env var names - shtlrs
[python-discord/site] New branch created: update\-sir\-lancebot\-contrib\-guide
[python-discord/bot-core] New tag created: v9\.6\.0
This Pull Request updates Sir-Lancebot's contribution guide to reference the new env variable keys changed in this pr
GitHub Actions run 4901522885 succeeded.
GitHub Actions run 4901544444 failed.
GitHub Actions run 4901554073 was cancelled.
GitHub Actions run 4901558386 succeeded.
Connected!
GitHub Actions run 4901670905 succeeded.
Sentry Issue: SIR-LANCEBOT-9W
AttributeError: module 'bot.constants' has no attribute 'codejam_categories_name'
(7 additional frame(s) were not displayed)
...
File "bot/utils/decorators.py", line 256, in predicate
result = in_whitelist_check(ctx, fail_silently=True, **kwargs)
File "bot/utils/checks.py", line 77, in in_whitelist_check
if category and category.name == constants.codejam_categories...
GitHub Actions run 4901673112 succeeded.
Connected!
We have a lot of Cogs that need some API key to function.
If the key isn't present, it would result in constant 401s.
This PR adds a change that won't load these Cogs & log a warning whenever these keys aren't present.
GitHub Actions run 4901783636 succeeded.
We are catching this further up
try:
with open(image_path, "wb") as out_file:
await self._generate_image(TEMPLATE.substitute(text=query), out_file)
except InvalidLatexError as err:
embed = discord.Embed(title="Failed to render input.")
if err.logs is None:
embed.description = "No logs available."
else:
logs_paste...
Description
A command that will fetch information about a certain day (can be filtered by the year too) for AOC puzzles.
Reasoning
I've seen a lot of people including myself have trouble remembering what day had what. Especially with puzzles from past years when people didn't participate, you have to look up the day every time to see what happened on that day.
In addition, being able to pull up the day from Discord rather than exiting into your browser to search up the day every...
There's currently an error log for bot.exts.utilities.reddit when missing the token, could we make that a warning for consistency?
Looks like the wrong constant? Also capitalise youtube as YouTube
Wolfram is the cog, not the constants config. This causes an error.
I assume because it can be noisy, it's not something I've changed in this PR though.
We're only catching the InvalidLatexError, which wont be raised in the case of a 5xx exception (since a ClientResponseError will be raised before the line we raise that error is reached).
Also, I think it's worth distinguishing between errors with a user's input, and error's with the server.
[python-discord/sir-lancebot] New branch created: migrate\-to\-ruff
Description
This migrates us from using flake8 to ruff as the new linter.
Did you:
- [x] Join the Python Discord Community?
- [x] Read all the comments in this template?
- [x] Ensure there is an issue open, or link relevant discord discussions?
- [x] Read and agree to the contributing guidelines?
GitHub Actions run 4902293791 succeeded.
This just wasn't used at all 🤷
GitHub Actions run 4902298440 failed.
GitHub Actions run 4902306191 succeeded.
5bdd195aefc1b3af562e336dd9edeb260002e085
There's currently an error log for
bot.exts.utilities.redditwhen missing the token, could we make that a warning for consistency?
Yessir we can 0e202c04bd6c5976afdcd4d10a62fde386dcf440
GitHub Actions run 4902450795 succeeded.
My bad, I hadn't still tested this yet, and I was trying to get something in a PR before I left the house.
5ba5275ab343ec36f2a2ab99f7d5a6dd2f4db8f6
def _get_query(self, query: str) -> Command | Cog | None:
"""Lookups for commonly used colours."""
"""Month of the year lookup. Used for in_month checks."""
looks good, missed one thing on my previous review.
log.warning("No Giphy token. Not loading SpookyGif cog.")
GitHub Actions run 4902515730 succeeded.
scheduling is something that is handled by bot-core, so the fix would need to be there. The error handler should probably be ported there first, so we don't have to duplicate this in multiple places. It might make sense to have central error handling that errors from everywhere are handled by, but i've not looked into it so i'm not too sure.
log.exception already adds exception information to the error.
| `CHANNELS_SIR_LANCEBOT_PLAYGROUND` | ID of the `#sir-lancebot-playground` channel |
The third column here seems to be ignored when rendering. They should probably either be removed, or given a header and filled in for some other values where helpful (e.g. REDIS_USE_FAKEREDIS). (Also, the default for CLIENT_DEBUG is True)
Looks good, thanks @hedyhli for the help with this!
b4e843e feat: Edit on GitHub button for content articles - hedyhli
1bed135 Edit on GitHub link instead of button - hedyhli
a34ebfa Use content articles source url in django.conf.... - hedyhli
7bf2766 Put 'Edit on GitHub' on breadcrum row with Sub-... - hedyhli
e3dcb3e Simplify line in page_src_url template filter - hedyhli
[python-discord/site] branch deleted: hedyhli\-edit\-on\-github
GitHub Actions run 4902687838 succeeded.
Ah, thought I caught all of these. I disabled the rule and went back and changed them all, or so I thought.
Not sure what this is doing either. If the conditional was the other way around it might make sense.
I.E specifically checking for len(winner_messages) == (i + 1) + 1 and then checking for if len(winner_messages) > i + 1: but even then is doesn't make sense, since both result in a break 🤷.
I'll just remove as you suggest
3887b52 fixup: code review changes - ChrisLovering
Yea, we can do that. Was likely a hold over from before cog_unload was async https://github.com/python-discord/sir-lancebot/pull/1270/commits/3887b52eeb6443c9b84cb537ebad4b0526efd9f2
GitHub Actions run 4902738431 succeeded.
the type hint in the function signature (past_datetime: datetime.datetime) needs to use just datetime too now.
datetime.date -> date
This type hint actually seems incorrect, as the list seems to contain datetimes, which also seems to potentially break some of the (confusing) logic. I don't think we should try and fix anything here though as it seems potentially non-trivial.
f9054b0 Use sys.exception over sys.exc_info and remove ... - TizzySaurus
GitHub Actions run 4902969363 succeeded.
scheduling is something that is handled by bot-core, so the fix would need to be there. The error handler should probably be ported there first, so we don't have to duplicate this in multiple places.
So are you suggesting to merge this PR as-is, and add the schedule handling to bot-core at a later time? I'd be okay with this, as long as the exceptions raised aren't going to cause sentry alerts etc.
GitHub Actions run 4903108915 succeeded.
GitHub Actions run 4903114040 succeeded.
self.hanukkah_dates.append(self._parse_time_to_datetime(date).date()) is the only line that appends, which appends a date, so this seems right?
GitHub Actions run 4903116715 succeeded.
[python-discord/bot-core] New branch created: ruff\-migration
Migrates the repo to use ruff for linting.
This also adds isort and updates step versions in CI
Had to do this as otherwise we'd have NoneType | NoneType if redis couoldn't be imported, which will raise an error
93bbdbd Bump pip-licenses from 4.3.0 to 4.3.1 (#2579) - dependabot[bot]
1cf9b6c Message content intent tag (#2566) - Canttuchdiz
fd9e765 Bump regex from 2023.3.23 to 2023.5.5 (#2578) - dependabot[bot]
c269df9 Bump pre-commit from 3.3.0 to 3.3.1 (#2577) - dependabot[bot]
f20212f Merge branch 'main' into fix-2500 - RohanJnr
GitHub Actions run 4903272035 succeeded.
As discussed in Discord.
elif isinstance(e.original, Forbidden):
try:
await try_handle_forbidden(e.original, ctx.message)
except Forbidden:
await self.handle_unexpected_error(ctx, e.original)
message = None
if event in ("on_message", "on_message_edit"):
message = args[0] if event == "on_message" else args[1]
imo this simpler, and much easier to read.
log.info(
"Failed to add reaction to message %d-%d since the message author (%d) has blocked the bot",
message.channel.id,
message.id,
message.author.id,
)
Info to make it appear in logs by default, as I think this would be useful. Also including a reference to the message so we can easily figure out where it came from
This function name, and docstring, should be updated to better reflect what it's doing. Something like handle_forbidden_from_block.
13fd8e8 Add done_callbacks param to create_task - TizzySaurus
[python-discord/bot-core] New branch created: add\-done\_callbacks\-to\-schedules
Adds a done_callbacks kwarg to the create_task scheduling util, and adds each callback to the task. This is done as part of python-discord/bot#2580 (ability for more refined error-handling on schedules, such as the incident-crawler), however is a general-purpose thing too.
Suggested and approved by @ChrisLovering.
For the record, @ChrisLovering and I have come up with a solution for handling errors in the schedules (see python-discord/bot-core#177).
We should bump the version in pyproject.toml and write a changelog entry too
done_callbacks: tuple[typing.Callable[[asyncio.Task, ...], any], ...] = (),
I think this is how you'd type this, since the callable could be a partial that sets some args/kwargs before passing it into this func.
The idea was that we can in the future add other specific discord.Forbidden errors too (not just the error code 90001 error).
If we ever find the need to do that then we can come up with a better name at that time, but for now it's needlessly mysterious to the caller as to what it does.
If we allow for this function to handle codes other than 90001, as was my plan, then we need to account for errors that may be raised from other events too though. Say, on_guild_leave or w/e. Which would mean this solution won't work (hence my dict and checking if it's None).
What's the benefit of this over adding the callback to the returned task?
What's the benefit of this over adding the callback to the returned task?
I'm not familiar with tasks, so you'd have to ask @ChrisLovering.
3a793d0 Correct typehint - TizzySaurus
GitHub Actions run 4903879606 succeeded.
Description
On Pygen, we love to joke about how often ChatGPT and Mojo come up in conversation. In fact, we've even started keeping track of how long we can go without mentioning them!
My suggestion is to add a timer to track how long we can last without mentioning them. The timer would let us know when someone finally brings them up again, and it would announce the new record for the longest time Pygen has gone without them coming up on the conversation.
Reasoning
The addition of...
... has long been used in UI yes, however you're taking that symbol and expanding it to potentially appearing several times at the same point, each time for a different reason.
I understand that this may seem obvious to the person who wrote the code, but I purposefully didn't look at the code when trying to understand the examples, and it wasn't obvious what's going on until I did. Your explanation in the latest comment is clear (although again I'm already "tainted" having already read t...
Thanks for the suggestion. How is this better than searching the channel for those words? It gives all the information while involving only the person interested in it. Making it a feature of the already chaotic python-general chat doesn't seem desirable.
Thanks for the suggestion. How is this better than searching the channel for those words? It gives all the information while involving only the person interested in it. Making it a feature of the already chaotic python-general chat doesn't seem desirable, not to mention the possible implication of potentially making the person who mentioned those words feel they're being made fun of.
Thanks for the feedback!
While it is true that one could manually search through the channel to track ...
You can use defaultdict here and set the default to a list.
Also, the reroll command does not work if the channel name is not found in the database. This can be a super rare edge case but we can handle it. Under the re_roll_command function, you can catch the Exception on the await self.de_activate_ot_name(ctx, old_ot_name) and log it. After that the function will continue to rename the channel.
I didn't even see the third column since it doesn't fit on my screen.
I'll just remove them.
88c52b4 remove defaults column - shtlrs
GitHub Actions run 4906495263 succeeded.
GitHub Actions run 4906504508 succeeded.
There's a mention of #sir-lancebot-commands on line 60 that should be changed to #sir-lancebot-playground.
Line below this one but I can't comment on it, USE_FAKEREDIS -> REDIS_USE_FAKEREDIS
I don't understand how the bot-core PR would help. Would we have to change all uses of create_task to add an error handler? That doesn't seem great, compared to just handling it there directly.
Ah, yeah, I'd missed the .date().
I think this is a good idea, but agree using 🔒 might be nicer.
I don't understand how the bot-core PR would help. Would we have to change all uses of create_task to add an error handler? That doesn't seem great, compared to just handling it there directly.
Yeah, you're right, in reality we'd want the handle_forbidden_from_block function to be in bot-core ,and automatically added in create_task. I'll make that change to the bot-core PR :+1:
Looks good to me, @Robin5605 would you like to take another look?
When executing the command /tag without any arguments, a list of all tags is displayed. However, for some reason there's a random bullet point at the top of the list:
Similarly, when the "Did you mean" message comes up for a non-exact multi-match, such as /tag name:f-str, the "Did you mean ..." has a space before the ... that shouldn't be there:
The relevant lines of code appear to be here and [here]...
Oops, looks like none of us tested the tags links.
The edit-on-gh link should probably be hidden on tags, it does not point to the right URL but the pre-existing GitHub icon link does, since it uses the base URL from Tag model
Maybe because the source files are in resources directory bu...
[bot-core] Branch add\-done\_callbacks\-to\-schedules was force-pushed to `763c92f`
This is essentially stalled by python-discord/bot-core#177 now. Once that's merged, I can remove handle_forbidden_from_block from here, and migrate to importing from bot-core.
GitHub Actions run 4907839311 was cancelled.
GitHub Actions run 4907843751 succeeded.
[bot] Branch Prepend\-closed\-to\-closed\-help\-channels was force-pushed to `c329fde`
[bot] Branch Prepend\-closed\-to\-closed\-help\-channels was force-pushed to `da4a2a7`
GitHub Actions run 4908039802 was cancelled.
GitHub Actions run 4908041267 succeeded.
Tested - works nicely, thanks!
[bot] Branch Prepend\-closed\-to\-closed\-help\-channels was force-pushed to `9f837ac`
52bddd4 Add trailing new line - TizzySaurus
GitHub Actions run 4908142008 succeeded.
c68f0b6 Add changelog and bump project version to 9.7.0 - TizzySaurus
0e9af52 Remove trailing whitespace - TizzySaurus
It's because of tag groups, https://github.com/python-discord/bot/issues/1545, we don't have any tag groups yet, so all tags are under the default group which has no name, hence is just a bullet point. Related: https://github.com/python-discord/bot/issues/2423
[python-discord/bot] branch deleted: Prepend\-closed\-to\-closed\-help\-channels
b0d207a Make _log_task_exception async - TizzySaurus
Connected!
[bot-core] Branch add\-done\_callbacks\-to\-schedules was force-pushed to `6d37c6d`
0fbbe20 Fix task not being passed into _log_task_exception - TizzySaurus
[bot-core] Branch add\-done\_callbacks\-to\-schedules was force-pushed to `d1bd136`
[python-discord/sir-lancebot] Pull request opened: #1272 Fix extra space in \.help command signature
Relevant Issues
Closes #1266
Description
Fix extra space being added to command signature in .help command
Did you:
- [x] Join the Python Discord Community?
- [x] Read all the comments in this template?
- [x] Ensure there is an issue open, or link relevant discord discussions?
- [x] Read and agree to the contributing guidelines?
GitHub Actions run 4908547286 succeeded.
I would like to work on this issue.
GitHub Actions run 4909026930 succeeded.
f2f5621 Bump pre-commit from 3.3.0 to 3.3.1 (#958) - dependabot[bot]
664bc1a Bump sentry-sdk from 1.21.1 to 1.22.0 (#2582) - dependabot[bot]
GitHub Actions run 4909202110 succeeded.
Connected!
5f3ffc7 Replace .get logic with a defaultdict - TizzySaurus
This can be simplified to
return ' '.join([cmd.qualified_name, *results])
GitHub Actions run 4909236992 succeeded.
Also, the
rerollcommand does not work if the channel name is not found in the database. This can be a super rare edge case but we can handle it. Under there_roll_commandfunction, you can catch the Exception on theawait self.de_activate_ot_name(ctx, old_ot_name)and log it. After that the function will continue to rename the channel.
That seems unrelated to this work, so should probably go in a separate PR?
GitHub Actions run 4909417970 succeeded.
separate
Ye sure, I'll open an issue for that later
GitHub Actions run 4911928354 succeeded.
GitHub Actions run 4912053664 succeeded.
GitHub Actions run 4912118291 succeeded.
GitHub Actions run 4913946544 succeeded.
GitHub Actions run 4915410995 failed.
GitHub Actions run 4915436578 succeeded.
GitHub Actions run 4915463552 succeeded.
ff39970 Use new | operator for type annotations - ChrisLovering
e811f1c Bump pydis-core from 9.5.1 to 9.6.0 (#2586) - dependabot[bot]
GitHub Actions run 4915513691 succeeded.
Connected!
GitHub Actions run 4915542902 succeeded.
Connected!
GitHub Actions run 4917251101 succeeded.
GitHub Actions run 4917260557 succeeded.
GitHub Actions run 4917274566 succeeded.
GitHub Actions run 4917349454 succeeded.
GitHub Actions run 4917405551 succeeded.
Actually thats right thanks for this comment
GitHub Actions run 4917625342 succeeded.
Connected!
GitHub Actions run 4918503377 succeeded.
Connected!
GitHub Actions run 4922832336 succeeded.
Coordinate's defintions already contains the the fact that it can be None Coordinate = tuple[int, int] | None, so I'm wondering if this is needed.
Looks good, just a couple of minor comments.
Shouldn't this have a warning level or higher ?
The amount parameter, that defines how many movies will be shown, defaults to 5.
Is was being entirely ignored before, and I don't think this error warrants a sentry alert, since it's just because it tried to submit something that's too long
GitHub Actions run 4927131785 succeeded.
[python-discord/sir-lancebot] branch deleted: migrate\-to\-ruff
Fake approval for good luck
GitHub Actions run 4927340446 succeeded.
Connected!
Suggestion: Add a reopen button to the closed thread embed for the thread owner to easily reopen their thread. This will address the annoyance of having to create a new thread when wanting to reopen a closed one.
[Here's](#python-discussion message) an example of the annoyance caused by the current system.
We discussed this when designing the new help system, and did not come up with a solution that works with the restrictions within Discord, and doesn't open it up for abuse.
For this specific request, it wouldn't work as you can't interact with buttons when posts are locked.
We discussed this when designing the new help system, and did not come up with a solution that works with the restrictions within Discord, and doesn't open it up for abuse.
For this specific request, it wouldn't work as you can't interact with buttons when posts are locked.
Ah, thats very sad. Welp thank you, didn't know that detail about discords interactions.
You can directly use append here
failed_renames[channel_indx].append(new_channel_name)
GitHub Actions run 4929887362 succeeded.
[python-discord/snekbox] branch deleted: file\-scan\-recursion\-fix
9952110 Ensure mp Pool is not reused to avoid broken pi... - ionite34
3ea786f Reduce file parse timeout from 8 to 5 seconds - ionite34
2abd6cd Handle recursion error cases from glob - ionite34
46dd830 Add timeout to MemFS.files and MemFS.files... - ionite34 [99d6b96](https://github.com/python-discord/snekbox/commit/99d6b969587be7d276c1aa980d9304474e9d1494) Provide files_timeout to MemFS.files_list` call - ionite34
Could we call asyncio.run on this line directly, rather than change the function to async and having that mash of partials when adding the call back?
I'm confused how using asyncio.run would work here. Doesn't that try to create a new event loop, which is a problem since we already have a running loop on that thread?
Connected!
Integration test failed in the job that run when #173 was merged to main. We may not be cleaning up test resources properly.
From the logs:
2023-05-09T21:12:56.6642706Z ....................2023-05-09 21:12:56...
Going to close this issue since I believe I've answered the question, and there's been no response for a few weeks. If you have follow-up questions, feel free to leave them here.
GitHub Actions run 4933779689 succeeded.
GitHub Actions run 4933774238 was cancelled.
GitHub Actions run 4935966887 failed.
Looks good, just one optional thing that might be good to do now too.
Cant comment higher, but pygrep hook can be removed from pre-commit as ruff covers it already (rule PGH)
GitHub Actions run 4936082566 failed.
GitHub Actions run 4936102600 succeeded.
[python-discord/site] branch deleted: ruff
MASCHINNNNNNNNNNNNNNNN
[python-discord/site] New branch created: psycopg3
GitHub Actions run 4936493532 failed.
5eada1e Add Django-specific rules for ruff - jchristgit
[python-discord/site] New branch created: django\-rules\-ruff
GitHub Actions run 4936533141 succeeded.
GitHub Actions run 4936559678 succeeded.
3cc0dc3 Do not duplicate "Edit on GitHub" link for tags - jchristgit
[python-discord/site] New branch created: no\-duplicate\-tag\-page\-github\-edit\-tag
Thanks for the report! I opened a PR that fixes this by hiding the link on tags.
GitHub Actions run 4936673093 succeeded.
[python-discord/site] branch deleted: no\-duplicate\-tag\-page\-github\-edit\-tag
I think we should add .jsondb tag (or other good name) to show why you shouldnt use JSON as database. There is already a message pinned in #discord-bots but i think it should be a tag.
[Pinned message](#discord-bots message)
It was already migrated to the site (link) in python-discord/site#700 (as part of python-discord/site#695), what would be the value in adding it as a tag as well?
I think it is easier to run a command instead of looking for a website link. Thats the same as looking through pins to find it. Maybe i am missing something to autopost the link for website.
That's a good point. Since we're within a callback here we can use asyncio.get_running_loop() to grab the loop and run_until_complete() to run this async function, right?
GitHub Actions run 4955539423 succeeded.
5eada1e Add Django-specific rules for ruff - jchristgit
3cc0dc3 Do not duplicate "Edit on GitHub" link for tags - jchristgit
5778017 Merge pull request #971 from python-discord/no-... - HassanAbouelela
3def0dd Merge branch 'main' into django-rules-ruff - Xithrius
30a744d Merge pull request #970 from python-discord/dja... - Xithrius
[python-discord/site] branch deleted: psycopg3
GitHub Actions run 4955554277 succeeded.
GitHub Actions run 4955551883 was cancelled.
625f574 Fix psycopg3 compatibility in metricity - jchristgit
[python-discord/site] New branch created: fix\-psycopg3\-compatibility\-in\-metricity
GitHub Actions run 4956834259 succeeded.
[python-discord/site] branch deleted: fix\-psycopg3\-compatibility\-in\-metricity
Another potential solution to avoid cluttering the channels is by sending the timer resets to a separate channel (maybe a thread in ot0?) to avoid clutter in #python-general itself
Description
Add 3 levels of difficulty to the connect 4 AI for the user to choose from:
- Easy: the current AI implementation
- Medium: the AI also attempts to create 'winning corrdinates' (coordinates where placing a counter will result in a win, each player has a different set of winning coordinates which may overlap) and also attempts to prevent the user from creating such coordinates.
- Hard: the AI will also account for 'parity' (I'm not sure what else to call it) be...
As a side note, I haven't tested any of the harder difficulties yet (they're just based on my experience and how I play the game) so feel free to suggest any other ideas for harder bots!
[python-discord/site] New branch created: Python\-3\.11
This bumps the site up to using Python 3.11. This includes the poetry project file, within the Docker image, in CI, and the target version for ruff.
This also fixes ruff linting errors by using the new datetime.UTC alias present in 3.11.
While running the test suite locally I noticed a test that failed on a Windows host, so updated that too.
Looks great, looking forward to running tests again on Debian Bookworm :muscle:
GitHub Actions run 4967179738 was cancelled.
GitHub Actions run 4967184863 was cancelled.
GitHub Actions run 4967187228 succeeded.
No, we cannot use run_until_complete because the loop is already running.
One solution may be to wrap the task being scheduled with another coroutine that awaits the original coroutine and the error handler afterwards. But that might be messy, particularly if we need to be careful about handling task cancellation.
Doc item doc_item.symbol_id='module-sympy.core.core' present in loaded documentation inventories not found on site, inventories may need to be refreshed.
GitHub Actions run 4973830259 succeeded.
GitHub Actions run 4976774798 succeeded.
193353b Upgrade to Python 3.11 - ChrisLovering
bc4fb26 Specify file encoding so tests pass on windows - ChrisLovering
509449c Use the new datetime.UTC alias over datetime.ti... - ChrisLovering
74fdd02 Bump ruff to latest - ChrisLovering
f5a46dc Merge pull request #973 from python-discord/Pyt... - jchristgit
[python-discord/site] branch deleted: Python\-3\.11
GitHub Actions run 4979529523 failed.
b2cbaf3 Fix linting errors from new ruff rules - ChrisLovering
Previous to the 2023 filters rewrite autobans were logged in #mod-alerts but did not ping moderators.
We should change the current behavior to match that (no ping), since there is no urgent moderation action required for autobans.
The command to be changed is filter compadd.
[Brief discussion](#mod-tools message)
GitHub Actions run 4979759143 succeeded.
GitHub Actions run 4980641294 succeeded.
GitHub Actions run 4980647695 succeeded.
GitHub Actions run 4980653442 succeeded.
I'm happy with this. Thanks!
GitHub Actions run 4981693355 succeeded.
371eaa8 Add on-message-event.md - n0Oo0Oo0b
5f83740 Update bot/resources/tags/on-message-event.md - n0Oo0Oo0b
97efc1c Update bot/resources/tags/on-message-event.md - n0Oo0Oo0b
9936d6f Update on-message-event.md - n0Oo0Oo0b
d0ca29e Apply suggestions from code review - n0Oo0Oo0b
Connected!
We currently have almost identical definitions of the LinePaginator class in both bot and sir-lancebot.
These classes can be ported over to bot-core and make them available for both of theses bots, and potentially any other one.
Suggestion
@mbaruh has suggested to make use of views and buttons for the paginator and move away from reactions.
GitHub Actions run 4983146523 succeeded.
6115936 Bump ruff from 0.0.265 to 0.0.267 (#1276) - dependabot[bot]
0999ef4 build(deps-dev): bump ruff from 0.0.265 to 0.0.... - dependabot[bot]
Connected!
GitHub Actions run 4984566488 succeeded.
GitHub Actions run 4985024042 failed.
[python-discord/site] New comment on pull request #975: Bump pymdown\-extensions from 9\.11 to 10\.0
As a...
-
file format
I want to...
-
Include the ability to include other files on the filesystem
Such that...
-
Users of my website can render Markdown content including my family photos
GitHub Actions run 4985203512 succeeded.
Sentry Issue: BOT-3G3
AttributeError: 'Object' object has no attribute 'mention'
File "bot/exts/moderation/infraction/management.py", line 284, in infraction_search_group
await self.search_user(ctx, discord.Object(query))
File "bot/exts/moderation/infraction/management.py", line 312, in search_user
prefix = f"{user.mention} - {user.id}"
Error executing command invoked by godlygeek#8814: !i s 4...
cc0f05e Don't access non-existant attr when getting inf... - ChrisLovering
[python-discord/bot] New branch created: fix\-attr\-error\-in\-infraction
GitHub Actions run 4989558951 succeeded.
[bot] Branch fix\-attr\-error\-in\-infraction was force-pushed to `bcfde22`
[bot] Branch fix\-attr\-error\-in\-infraction was force-pushed to `3979f73`
GitHub Actions run 4989575824 was cancelled.
[bot] Branch fix\-attr\-error\-in\-infraction was force-pushed to `c241c74`
[bot] Branch fix\-attr\-error\-in\-infraction was force-pushed to `ddac405`
GitHub Actions run 4989577834 succeeded.
GitHub Actions run 4989589438 was cancelled.
GitHub Actions run 4989592017 succeeded.
GitHub Actions run 4991037918 succeeded.
2c143cf Don't access non-existant attr when getting inf... - ChrisLovering
[python-discord/bot] branch deleted: fix\-attr\-error\-in\-infraction
Connected!
GitHub Actions run 4995140609 succeeded.
We should remain consistent with the titles, so let's capitalize these.
description: "Subclassing the discord.py `Bot` class to add more functionality and customizability."
status can be confused with the status (activity ) that a bot displays, wdyt of launch_time, or something in that fashion?
This is not entirely true, as you'll need to update the instantiation of the bot :P
oh right, this was there with the previous commits. I will change that. Maybe I should also talk abouts cogs and link it as it could be the next step?
GitHub Actions run 4995862479 succeeded.
3b8a6d8 Bump sentry-sdk from 1.22.2 to 1.23.0 (#1277) - dependabot[bot]
[bot] Branch dependabot/pip/ruff\-0\.0\.265 was force-pushed to `dfd452a`
Connected!
GitHub Actions run 4995894816 succeeded.
Connected!
GitHub Actions run 4995919105 failed.
GitHub Actions run 4995920133 succeeded.
GitHub Actions run 4995939553 failed.
A small comment about that wouldn't hurt, yeah.
6108721 Bump pytest-subtests from 0.10.0 to 0.11.0 (#2590) - dependabot[bot]
[bot] Branch dependabot/pip/ruff\-0\.0\.267 was force-pushed to `e8d7fbb`
Connected!
GitHub Actions run 4996030032 succeeded.
This is great. Thank you so much!
I would like to work on this issue, yet what would be a good user message in that case ?
I suggest : "Rendering server is unavailable, please try later"
Sure, I'll assign you.
As for the error message, what you've suggested or something like '' Server encountered an issue, please retry in a moment '' should do the job.
We can discuss this in the PR at the worst case.
I would love to work on this issue, also i suggest to
- Add the timeout as command input
- Change the timeout default value to match the possible anagrams (more anagrams => less timeout, reducing by 10 second starting from the +1 anagram)
Those suggestion are of course optional, will be happy to implement just the behavior described by Wookie
The next step would be to look into discord.py cogs as they help in organizing collections of commands into various files and folders. Refer to [the official docs](https://discordpy.readthedocs.io/en/stable/ext/commands/cogs.html) for more on them.
I don't think there's a need for the second example as the official docs do offer that IIRC.
Plus, we'll be removing it once we've made out own version :P
GitHub Actions run 5000230707 succeeded.
GitHub Actions run 5000267634 failed.
GitHub Actions run 5000283137 failed.
This PR throws an error when the github token is missing (when it tries it get it from .env file as defined in constants). Maybe we can try making this optional. We also need to update the .env guide on the site https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/bot/#appendix-full-env-file-options
token: str = ""
Ha ! Yes.
It didn't before because we weren't using pydantic at that time.
Good catch, i will take care of it!
we already have API_KEYS_GITHUB as optional, is the new token constant any different or does it use a different auth approach ?
Github introduced tokens per repo.
So this one will be granular in regards to the repo where tasks will be created
GitHub Actions run 5003058358 succeeded.
Last change, and we're ready to 🚢
One last comment (Sorry, I completely missed this)
IT would be nice to reference our guide that talks about subclassing context here.
Subclassing `Bot` can be very beneficial as it provides you with more control and customizability of how your bot functions, also allowing you to add extra features, such as custom bot attributes or methods. For example, the default [Context](https://discordpy.readthedocs.io/en/latest/ext/commands/api.html#discord.ext.commands.Context) can ...
GitHub Actions run 5004632854 succeeded.
GitHub Actions run 5004851708 succeeded.
Looks awesome, thank you for finishing this one up.
Relevant Issues & Changes
Closes #1146
I've added a catch for ClientResponseError, raised a LatexServerError and handled the later to return a user message, with a tiny refactoring of the code that creates the embed (in case of error)
Did you:
- [X] Join the Python Discord Community?
- [X] Read all the comments in this template?
- [X] Ensure there is an issue open, or link relevant discord discussions?
- [X] Read and agree to the [contrib...
@tarunsamanta2k20 hey, are you stilling working on this ?
These are some of changes we should be doing:
-
Change the tag embed footer to remove prefix and use /
-
We need better help message to tell users on how to use tags from a group. Currently, the syntax to view a tag from a group is
/tag name:<group_name> <tag_name>, this has to be mentioned in the tag help message.
Currently, the new /tag command has the syntax: /tag name:<group_name> <tag_name>. To use a tag from a group, group name has to be mentioned. This could be quite unintuitive to always enter the group name for a simple tag search. Incase if we are enforcing group name, lets try to keep them as simple as possible and short as possible.
Another approach would be to invoke a tag regardless of its group. Incase there are tags with the same name in multiple groups, the user will be prompted to...
GitHub Actions run 5014187915 succeeded.
GitHub Actions run 5014906063 succeeded.
GitHub Actions run 5016350048 succeeded.
As Janine pointed out, the tag functionality was greatly reduced with the slash command migration. I’m guessing slash commands don’t allow you to enter invalid commands? That is in part how we were handling tag matching before slash commands (its in the error handler).
If we can’t reimplement this flexibility with the slash-commands, then I don’t think this is a good use case for them, and we might be ...
GitHub Actions run 5023553041 succeeded.
use a music api to add /music etc
GitHub Actions run 5026561139 succeeded.
Hello 👋
use a music api to add /music etc
If you want to request that such a feature should be added, it needs to be created as an issue first.
Also, this looks like it's something more suitable for sir-lancebot
I'll be closing this pull request, so please don't hesitate to open up an issue in the other repo if you still want to request this.
Connected!
GitHub Actions run 5036598184 succeeded.
GitHub Actions run 5036610350 succeeded.
GitHub Actions run 5036617073 succeeded.
GitHub Actions run 5036631758 succeeded.
Connected!
GitHub Actions run 5036673562 succeeded.
FYI, the warnings that come with the tests are deprecation warnings saying some packages/modules will be remloved in python 3.13.
Connected!
GitHub Actions run 5036694822 succeeded.
1f3ab0a build docker image in all PRs - shtlrs
[python-discord/bot] New branch created: build\-docker\-image\-in\-ci
This updates our workflows to build (but not push) the docker image on each pull requests.
This will only push and deploy the image to our container register when the reference is main.
GitHub Actions run 5037571653 succeeded.
f469507 bymp python version to 3.11 - shtlrs
f480ca8 use pkgutil.resolve_name instead of unittest.mo... - shtlrs
[python-discord/sir-robin] New branch created: python\-311
This bumps sir-robin's python version to 3.11.
By the same occasion, this updates all references of typing.Optional and typing.Union to use the | gate.
GitHub Actions run 5038065749 succeeded.
shtlrs, stunning!
I was eagerly searching (binary search) for any malicious code introduced in this pull request, but to my surprise, I could not find any! Worse even, you even fixed a typo in the documentation!
Ship it!
[python-discord/sir-robin] branch deleted: python\-311
Connected!
217933c Bump tldextract from 3.4.1 to 3.4.4 - dependabot[bot]
0468615 Merge pull request #2602 from python-discord/de... - shtlrs
be9518d Bump pytest-xdist from 3.2.1 to 3.3.1 - dependabot[bot]
75d862d Merge pull request #2599 from python-discord/de... - shtlrs
22c1f6c Merge branch 'main' into build-docker-image-in-ci - shtlrs
GitHub Actions run 5039021452 succeeded.
I’m guessing slash commands don’t allow you to enter invalid commands?
slash commands are kinda gimmicky, like you have to explicitely tell discord that you are providing a value for thenameargument and only then the error handling takes place
In the case below, discord correctly parses the name argument
 call, which contains the logs (per the docs)
But i don't think it would be necessary since it's a server-side error and we can't make much out of it, I was just thinking out loud.
You could simplify this to
if hasattr(err, "logs")
Actually, we might even have access to logs in case of a 5xx.
It's poorly documented so 🤷
Thanks for the suggestion :), I gave it a try, yet this will only check if the attr exist and not its nullability
So now I use getattr (which is used internally by hasattr, https://docs.python.org/3/library/functions.html#hasattr)
GitHub Actions run 5082705160 succeeded.
based on the server code here https://github.com/DXsmiley/rtex/blob/master/src/jobs.py#L38
I think all potential rendering issue are handled, therefore no logs will be provided in the case of 5xx responses; so keeping raise_for_status seems logical in this case
What do you think ?
Yeah, i shouldn't have spoken out loud in the first place :P
The thing is, even if we have server logs, there's nothing we can do about it since we're only the client. (Unless you want to make a PR to the other repo to fix it :P)
So yes, let's keep it as is, since there's not much value to us here
Currently, the two exception blocks do the same thing.
- prepare embed
- send
- unlink.
_prepare_error_embed already takes in the error, so relay the full responsibility to what the error message would be to it (since it has all the context already)
So your try block will become
try:
# do something
except (InvalidLatexError | LatexServerError) as err:
preprare_error_embed(err)
# etc
return
and you do an isinstance(err, exceptionClass) che...
You're now retrieving that attribute, so might as well use it :D
logs_paste_url = await self._upload_to_pastebin(logs)
Since we'll never get logs upon server-side errors, I don't see any interest in having a ctor that takes in logs as param anymore, so this should be removed.
Later on, your getattr will take of fetching that attribute if it exists.
GitHub Actions run 5090066184 succeeded.
GitHub Actions run 5092060309 succeeded.
Connected!
GitHub Actions run 5092050110 was cancelled.
Connected!
GitHub Actions run 5092594734 succeeded.
Connected!
GitHub Actions run 5092618772 succeeded.
GitHub Actions run 5092666062 succeeded.
Connected!
Currently, the !charinfo command runs unicodedata.name() to figure out what name a character should be given. However, unicodedata.name() does not support control characters like the newline characters such as \n, the null character, or a variety of other ones that have unicode names as aliases but not official "recognized" names which are often "" for some reason.
There's an open bug on cpython for a few years now, but it doesn't look like there's much activity (https://github.com/py...
GitHub Actions run 5100087143 succeeded.
Both logical and lovely comment, applied with using tuple exceptions (pre-commit wasn't happy :') )
Fair comment, it indeed unneeded param, removed
Looks great ! Just one last comment.
The type hinting on this one isn't quite valid since you're only catching the two custom latex exceptions.
async def _prepare_error_embed(self, err: InvalidLatexError | LatexServerError | None) -> discord.Embed:
GitHub Actions run 5100157141 succeeded.
In many cases, users have been utilizing out of date packages. This would make the !pypi tag substantially more useful in visually parsing whether or not a package could be out of date for the current version of Python.
https://github.com/python-discord/bot/blob/main/bot/exts/info/pypi.py#L48-L67
Example snippet:
ver = info["version"]
releasedate = info["release"][ver]["0"]["upload_time"]
embed.description += f"\n Release Date {releasedate}"```
Should fall within the `i...
I would be willing to work on this if approved.
This would be a nice addition, thanks for proposing it.
However, aren't we always getting the latest version for each package? So how would it be out of date?
The pypi command takes no arguments and is agnostic to python/package versions.
I'm not saying this shouldn't be added as it would only be a nice addition, but more like to make sure I understand correctly.
We always obtain the latest (non-dev release) version of a package with the !pypi command as I understand it now. Supplying a date in the embed serves to simply reconcile this date against our current understanding of what is considered 'outdated'.
A recent example of when this was relevant: An individual was seeking assistance with a "Jarvis" package on PyPI, specifically implementing it within their own code. !pypi was invoked to retrieve information regarding the package, and further li...
I wasn't opposing you as I think it is indeed reasonable to include.
@Robin5605 Want me to assign you?
Closes #2613
Show the upload date and time of the requested package in the timestamp field of the embed. Looks similar to this:
If there are suggestions to move the timestamp somewhere else within the embed, I'm open to hearing them.
GitHub Actions run 5107128823 succeeded.
If there are suggestions to move the timestamp somewhere else within the embed, I'm open to hearing them.
I think an embed field with title would make it clearer what the date means. This will also let us add more information (such as supported python versions and link to github repo, if they're part of the API response too) to the embed.
ec47f94 Bump pip-licenses from 4.3.1 to 4.3.2 (#2604) - dependabot[bot]
38c0162 Bump emoji from 2.2.0 to 2.4.0 (#1287) - dependabot[bot]
Connected!
Connected!
GitHub Actions run 5108869051 succeeded.
Connected!
GitHub Actions run 5108908875 succeeded.
Should be fine now
I thought I pushed that commit myself...
Thanks Xith!
d7ab3ea Bump ruff from 0.0.269 to 0.0.270 (#1286) - dependabot[bot]
Connected!
GitHub Actions run 5112143125 succeeded.
GitHub Actions run 5112163052 succeeded.
GitHub Actions run 5112190684 succeeded.
Wouldn't ValueError make more sense here ?
I'm assuming ruff proposed the AssertionError because it was an assertion before, but that can be changed.
[python-discord/bot] New branch created: inject\-settings\-in\-bot\-core
d6ac50c add pydantic as a dependency - shtlrs
c6c7206 add settings.py - shtlrs
[python-discord/bot-core] New branch created: port\-constants
f0fb329 import _Channels from pydis_core - shtlrs
This look like a good issue to tackle, can i work on it ?
Sure, I've assigned you!
GitHub Actions run 5118052901 succeeded.
7c7a4f3 Temporarily remove suport for evaling under 3.10 - ChrisLovering
[python-discord/bot] New branch created: temp\-disable\-multi\-version
This is until snekbox supports multi-version natively https://github.com/python-discord/snekbox/issues/158
[python-discord/bot] Checks Successful on PR: #2618 Temporarily remove suport for evaling under 3.10
GitHub Actions run 5120111203 succeeded.
[python-discord/bot] Checks Successful on PR: #2618 Temporarily remove suport for evaling under 3.10
GitHub Actions run 5120595016 succeeded.
I can't test this now, but it looks pretty safe to approve the way it is.
I can't test this now, but it looks pretty safe to approve the way it is.
GitHub Actions run 5120647783 succeeded.
PR Author
Workflow Run
Source Branch
remove-snekbox-3.10
GitHub Actions run 5120723874 succeeded.
27dc1e1 Remove mentions fo there being multiple snekbox... - ChrisLovering
[python-discord/site] New branch created: remove\-mentions\-of\-multiple\-snekbox\-containers
With https://github.com/python-discord/bot/pull/2618 there will only be 1 snekbox container, that runs the latest verison of snekbox.
Supporting multiple versions of snekbox will be covered by https://github.com/python-discord/snekbox/issues/158 where a single instance of snekbox will nativly support multiple Python verisons.
[site] Branch remove\-mentions\-of\-multiple\-snekbox\-containers was force-pushed to `f351709`
GitHub Actions run 5120768212 was cancelled.
6fcf0c5 Remove mentions of there being multiple snekbox... - ChrisLovering
[python-discord/site] branch deleted: remove\-mentions\-of\-multiple\-snekbox\-containers
GitHub Actions run 5120773372 succeeded.
GitHub Actions run 5120868648 succeeded.
GitHub Actions run 5120874982 succeeded.
GitHub Actions run 5120885468 failed.
GitHub Actions run 5120892768 succeeded.
GitHub Actions run 5121776501 succeeded.
Sentry Issue: BOT-3GC
ConnectionRefusedError: [Errno 111] Connect call failed ('10.128.79.106', 80)
(1 additional frame(s) were not displayed)
...
File "asyncio/base_events.py", line 1085, in create_connection
raise exceptions[0]
File "asyncio/base_events.py", line 1069, in create_connection
sock = await self._connect_sock(
File "asyncio/base_events.py", line 973, in _connect_sock
await s...
I can't test this now, but it looks pretty safe to approve the way it is.
0cef9e7 Temporarily remove suport for evaling under 3.1... - ChrisLovering
[python-discord/bot] branch deleted: temp\-disable\-multi\-version
I can't test this now, but it looks pretty safe to approve the way it is.
Connected!
Was this one noqa'd because we use it in upstream bot projects ?
Yea, changing this would be a breaking change across the bots, so didn't bother for this PR
I figured, it's nothing anyways.
Connected!
Connected!
Connected!
We should add a sentry integration to KA so that any errors get pushed to sentry, like our other bots. Don't enable it in dev.
GitHub Actions run 5135658473 succeeded.
GitHub Actions run 5135713875 succeeded.
GitHub Actions run 5136334872 succeeded.
54b6716 Escape full stops in Filter.str - ChrisLovering
[python-discord/bot] New branch created: don't\-use\-full\-stop\-in\-Filter\.\_\_str\_\_
Discord sees a number followed by a dot as a potential numbered list, so messes up the numbering when on sequential lines. Escaping the dot disables this discord behaviour.
GitHub Actions run 5136647236 succeeded.
Baguette au fromage très délicieuse.
c0ce854 Escape full stops in Filter.str (#2621) - ChrisLovering
[python-discord/bot] branch deleted: don't\-use\-full\-stop\-in\-Filter\.\_\_str\_\_
Connected!
[python-discord/bot] New branch created: add\-new\-badges
This is so that the user_info command can output them
GitHub Actions run 5154258830 succeeded.
GitHub Actions run 5154487314 succeeded.
GitHub Actions run 5155746120 succeeded.
Connected!
I agree with @n0Oo0Oo0b here, it would be much better to indicate what that date represents here.
A range of the python supported versions is a good idea as well.
GitHub Actions run 5158512886 succeeded.
GitHub Actions run 5159523033 failed.
GitHub Actions run 5165828756 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5168678723 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5170602573 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
The name field is optional in the API, so I don't think we need to require it.
Not critical, but I'd go for 128. Closer to the old limit and still a power of 2 :D
I don't understand this line, how does it form the paste link? Seems like link is a boolean.
hah yea, not sure what I was thinking here either. Updated in the force push
A couple of things that might make sense to have but aren't blockers:
- Enable the "Use a longer URI" option, although I don't see it in the API docs.
- Return the deletion URL. This would allow us to cache it and potentially use it via a command if we find that a paste contains sensitive information.
if link := response_json.get("link"):
Do we not have linting here?
We should not sure why this wasn't picked up. I've updated this now anyway, to simply check for a 200 status code.
Enable the "Use a longer URI" option, although I don't see it in the API docs.
Return the deletion URL. This would allow us to cache it and potentially use it via a command if we find that a paste contains sensitive information.
I like both of these, added in a force push.
[python-discord/bot-core] New branch created: shenanigansd\-patch\-1
Quick single word type fix
I would be willing to take this if it happens to be accepted.
This needs to be updated.
max_size: The maximum number of bytes to be allowed. Anything larger that 128kB will be rejected.
I would be willing to take this if it happens to be accepted.
I already said in the original issue that I would like to implement this myself.
GitHub Actions run 5173765147 succeeded.
Should we also override the default of disabling CODE JAM category and remove Helpers bypass?
Oh shoot, my bad 🤦♂️
Didn't read correctly, I'm blind.
GitHub Actions run 5176077794 failed.
PR Author
Workflow Run
Source Branch
pinnwand-deployment
GitHub Actions run 5176309266 succeeded.