#dev-log

Workflow Run

Lint #2441

Source Branch

fix-issue-1090

regal archBOT Sep 18, 2022, 9:06 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #981 fix: subcommands inherit their parent's whitelist

#

ChrisLovering

[sir-lancebot:main] 8 new commits

2ee5d24 fix: subcommands inherit their parent's whitelist - onerandomusername
fb5f3f7 minor: remove print debugging statement - onerandomusername
065624e Apply suggestions from code review - onerandomusername
d8fe28e Split comment over lines evenly - wookie184
6199fd9 Remove unnecessary hasattr check - wookie184

odd spireBOT Sep 18, 2022, 9:07 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #981 fix: subcommands inherit their parent's whitelist

GitHub Actions run 3078624822 succeeded.

PR Author

Workflow Run

Lint #2443

Source Branch

onerandomusername:fix-whitelis...

night lilyBOT Sep 18, 2022, 9:07 PM

#

Sir Lancebot

Connected!

#

Sir Lancebot

Connected!

odd spireBOT Sep 18, 2022, 9:09 PM

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3078629432 succeeded.

PR Author

Workflow Run

Lint & Test #3172

Source Branch

shtlrs:2108-invoke-rule-command-wi...

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3078640651 succeeded.

PR Author

Workflow Run

Lint & Test #3173

Source Branch

shtlrs:2108-invoke-rule-command-wi...

regal archBOT Sep 18, 2022, 9:19 PM

#

shtlrs

[python-discord/site] New review comment on pull request #770: Add a collection of keywords per rule

You're correct, thank you !

odd spireBOT Sep 18, 2022, 9:20 PM

#

[python-discord/site] Checks Failed on PR: #770 Add a collection of keywords per rule

GitHub Actions run 3078663579 failed.

PR Author

Workflow Run

Lint & Test #1258

Source Branch

shtlrs:map-rules-to-keywords

regal archBOT Sep 18, 2022, 9:21 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1097 Fix issue \#1050

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1097: Fix issue \#1050

In the giphy api docs The url key on the original object isn't documented.

I am not sure if this is a documentation mistake on giphy's part, or if we're using an undocumented key that's likely to cause issues again in future.

To avoid all doubt, it might be better if we use data["data"]["images"]["downsized"]["url"], as that's documented and also has the benefit of guaranteeing that the image is <2MB.

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1060 fix \`\.movie\`

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1060: fix \`\.movie\`

This doesn't raise an error, so if this block was hit, code execution would continue and try to access result further down.

To aid with this, you could raise a bot.utils.exceptions.APIError with this message, and the bot's error handler will handle the sending of the error for you.

See the wikipedia cog for how this is used if needed.

Also, we should move this error handling into get_movies_data function, as this removes both code duplication and the need to pass around the sta...

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1060: fix \`\.movie\`

    async def get_movies_data(
        self,
        client: ClientSession,
        genre_id: str,
        page: int
    ) -> tuple[list[dict[str, Any]], int]:

To follow the style guide

regal archBOT Sep 18, 2022, 9:53 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1095 Use buttons for bookmark command\.

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1095: Use buttons for bookmark command\.

This whitespace is what's making CI sad

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1095: Use buttons for bookmark command\.

Does this need to be across multiple lines?

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1095: Use buttons for bookmark command\.

Does this need to be across multiple lines?

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #1095: Use buttons for bookmark command\.

If you're running black to do your formatting, you may want to change your line-length configuration to 120, which this project uses.

I also highly recommend installing pre-commit hooks using poetry run precommit to catch linting issues before commiting.

#

MarkKoz

[python-discord/bot-core] Pull request review submitted: #88 Add a decorator that stops successive duplicate invocations of commands

Hey, I forgot about this PR. Sorry it took me so long to take notice again. Just have some small suggestions.

#

MarkKoz

[python-discord/bot-core] New review comment on pull request #88: Add a decorator that stops successive duplicate invocations of commands

This code is very similar to is_on_cooldown. Thoughts on refactoring this into a search function that returns the item?

#

MarkKoz

[python-discord/bot-core] New review comment on pull request #88: Add a decorator that stops successive duplicate invocations of commands

This name is misleading because it implies this contains all arguments when it's actually only the unhashable ones.

#

MarkKoz

[python-discord/bot-core] New review comment on pull request #88: Add a decorator that stops successive duplicate invocations of commands

If you make the default an empty list, then the if statement below will not be needed.

#

MarkKoz

[python-discord/site] Pull request review submitted: #770 Add a collection of keywords per rule

#

MarkKoz

[python-discord/bot] Pull request review submitted: #2261 Add support to fetch rules via keywords

#

MarkKoz

[python-discord/bot] New review comment on pull request #2261: Add support to fetch rules via keywords

You forgot this.

        for rule_number in sorted(final_rule_numbers):

regal archBOT Sep 18, 2022, 10:50 PM

#

Numerlor

[python-discord/bot-core] New review comment on pull request #88: Add a decorator that stops successive duplicate invocations of commands

How would this look? setdefault could be used in both paths to make them the same there, but then set_cooldown also needs the list of cooldowns (which is half of the code) to set its own item if it's new

#

Numerlor

[python-discord/bot-core] New comment on pull request #88: Add a decorator that stops successive duplicate invocations of commands

For the failing doc I've opened https://github.com/tox-dev/sphinx-autodoc-typehints/pull/255

regal archBOT Sep 18, 2022, 11:22 PM

#

MarkKoz

[python-discord/bot-core] New review comment on pull request #88: Add a decorator that stops successive duplicate invocations of commands

You're right. I glanced over the last line that does an append. I suppose it wouldn't really work out nicely.

regal archBOT Sep 19, 2022, 12:27 AM

#

MarkKoz

[python-discord/bot-core] Pull request review submitted: #88 Add a decorator that stops successive duplicate invocations of commands

I'm out of my depth with the sphinx changes you've made, so I'll defer reviews of that to someone more experienced.

regal archBOT Sep 19, 2022, 3:07 AM

#

VirdanTheBurden

[python-discord/bot] New comment on issue #2271: Convert voice verification to a button

I can give this a go, if nobody minds.

regal archBOT Sep 19, 2022, 8:08 AM

#

wookie184

[python-discord/bot] New review comment on pull request #2274: Check for commands being None in try\_get\_tag and try\_silence

This function returns None on failure and success.

            return

#

wookie184

[bot:fix\-silence\-and\-tags\-when\-unloaded] 1 new commit

b6c2054 Return None instead of False in try_get_tag - wookie184

odd spireBOT Sep 19, 2022, 8:11 AM

#

[python-discord/bot] Checks Successful on PR: #2274 Check for commands being None in try_get_tag and try_silence

GitHub Actions run 3080848056 succeeded.

PR Author

Workflow Run

Lint & Test #3174

Source Branch

fix-silence-and-tags-when-unloaded

regal archBOT Sep 19, 2022, 8:43 AM

#

wookie184

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

thank you, thank you. This important change greatly reduces code size, causing code to be up to 100% of previous speed!

#

wookie184

[bot:update\-autoreview\-system] 1 new commit

ab22385 Change f-string to normal string - wookie184

#

wookie184

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

Yeah that would be nice

regal archBOT Sep 19, 2022, 11:34 AM

#

wookie184

[bot:update\-autoreview\-system] 125 new commits

8c46657 Incident archive improvements - TizzySaurus
1e0c0cf Fix tests - TizzySaurus
b7e0361 Address Reviews - TizzySaurus
40ab60f Allow referencing message as argument to !remi... - TizzySaurus [0be3332](https://github.com/python-discord/bot/commit/0be3332904690730589113b99198f2f3fc2f1091) Added DurationOrExpiry` type union - ionite34

odd spireBOT Sep 19, 2022, 11:36 AM

#

[python-discord/bot] Checks Successful on PR: #2245 Update autoreview system

GitHub Actions run 3082060101 succeeded.

PR Author

Workflow Run

Lint & Test #3175

Source Branch

update-autoreview-system

regal archBOT Sep 19, 2022, 11:44 AM

#

wookie184

[bot:update\-autoreview\-system] 1 new commit

3adbbdd Rename test function and re-add change removed ... - wookie184

odd spireBOT Sep 19, 2022, 11:47 AM

#

[python-discord/bot] Checks Successful on PR: #2245 Update autoreview system

GitHub Actions run 3082121970 succeeded.

PR Author

Workflow Run

Lint & Test #3176

Source Branch

update-autoreview-system

regal archBOT Sep 19, 2022, 11:54 AM

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1046: anagram delay

Marking this as an enhancement as the current behaviour is intended, as there can be multiple possible anagrams. Two improvements would be:

React with a green tick on messages that correctly guess an anagram.
Finish early if all possible anagrams have been guessed.

Are you still interested in doing this?

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1019: ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: application/json', url=URL\('http://a\.\.\.

Hey Can I work on it?

Are you still interested in working on this? Did you get anywhere with identifying the cause of the error?

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1007: Quiz question missing one of the correct answers

hello can i fix this issue? that is if it has not already been fixed yet

If you're still interested in fixing this feel free to open a PR

odd spireBOT Sep 19, 2022, 12:05 PM

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3082237926 succeeded.

PR Author

Workflow Run

Lint & Test #3177

Source Branch

shtlrs:2108-invoke-rule-command-wi...

regal archBOT Sep 19, 2022, 1:27 PM

#

wookie184

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

I've started having a look into whether this would be an improvement. So far it's seeming pretty good IMO. Some things I've looked into:

Custom converters

Custom converters don't represent the actual type passed to the function

async def my_command(self, ctx: Context, argument: URLConverter) -> None:
    reveal_type(argument)  # URLConverter. uh oh

We can fix these using typing.Annotated

async def my_command(self, ctx: Context, argument: Annotated[str, ...

odd spireBOT Sep 19, 2022, 3:49 PM

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3083764903 succeeded.

PR Author

Workflow Run

Lint & Test #3178

Source Branch

shtlrs:2108-invoke-rule-command-wi...

odd spireBOT Sep 19, 2022, 4:23 PM

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3083986187 succeeded.

PR Author

Workflow Run

Lint & Test #3179

Source Branch

shtlrs:2108-invoke-rule-command-wi...

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3084062540 succeeded.

PR Author

Workflow Run

Lint & Test #3180

Source Branch

shtlrs:2108-invoke-rule-command-wi...

regal archBOT Sep 19, 2022, 4:57 PM

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2261: Add support to fetch rules via keywords

Is there a reason this name is duplicated?

oak estuaryBOT Sep 19, 2022, 6:47 PM

#

Python Bot

Connected!

#

Python Bot

Connected!

#

Python Bot

Connected!

odd spireBOT Sep 19, 2022, 7:26 PM

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3085052149 succeeded.

PR Author

Workflow Run

Lint & Test #3181

Source Branch

shtlrs:2108-invoke-rule-command-wi...

regal archBOT Sep 19, 2022, 9:24 PM

#

decorator-factory

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

Am I correct that Annotated in this case isn't actually "type safe"? As in, I can just do Annotated[int, URLConverter]
Or is that going to be mostly solved with defining type aliases for Annotated in one place?

#

shtlrs

[python-discord/bot] Issue opened: #2280 Add discoverability of keywords that point to particular rules

This PR: Add support to fetch rules via keywords allows us now to invoke particular rules based on keywords that map to that rule.

The problem is that there is currently no way to discover what these keywords are other than looking at the source code to look for these keywords.

So I think having a new comm...

#

wookie184

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

Am I correct that Annotated in this case isn't actually "type safe"? As in, I can just do Annotated[int, URLConverter]
Or is that going to be mostly solved with defining type aliases for Annotated in one place?

Yeah.

I just realised we currently use the hacky solution of redefining the converters as the types they convert to under a TYPE_CHECKING condition. Pyright doesn't seem to like that (keeps using the original class type), not sure about mypy.

regal archBOT Sep 19, 2022, 9:51 PM

#

MarkKoz

[python-discord/bot] New review comment on pull request #2261: Add support to fetch rules via keywords

Define a constant instead and share that with the test. This avoids duplication.

#

MarkKoz

[python-discord/bot] Pull request review submitted: #2261 Add support to fetch rules via keywords

#

MarkKoz

[python-discord/bot] New review comment on pull request #2261: Add support to fetch rules via keywords

When there are multiple test cases, use the subTest context manager to isolate the asserts.

odd spireBOT Sep 19, 2022, 10:00 PM

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3085899138 succeeded.

PR Author

Workflow Run

Lint & Test #3182

Source Branch

shtlrs:2108-invoke-rule-command-wi...

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3085914149 succeeded.

PR Author

Workflow Run

Lint & Test #3183

Source Branch

shtlrs:2108-invoke-rule-command-wi...

regal archBOT Sep 19, 2022, 11:47 PM

#

JBarth86

[python-discord/sir-lancebot] New review comment on pull request #1097: Fix issue \#1050

Sounds logical. Change made.

regal archBOT Sep 20, 2022, 12:36 AM

#

MarkKoz

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

I don't feel like this feature is necessary. If it were to be added, the simplest way would be to have the same behaviour as the normal rules command, but with the added keywords in the embed. Maximise code re-use.

regal archBOT Sep 20, 2022, 1:36 AM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #2261 Add support to fetch rules via keywords

#

MarkKoz

[python-discord/bot] New review comment on pull request #2261: Add support to fetch rules via keywords

Sorry for the back-and-forth and not being clearer about this. The constant should be defined in information.py. The bot/constants.py file is meant for global constants i.e. constants shared by many modules. Tests don't really fit the criteria of "shared by many modules".

#

MarkKoz

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

Is there any accepted workaround for when annotations are used for something other than annotating types (such as for us with converters)? Or do type checkers work on the assumption that annotations always correspond to types?

#

MarkKoz

[python-discord/site] Pull request review submitted: #772 Fix Poetry 1\.2 Support & Lock Poetry Version

I have successfully tested running the image on my system, and I observe builds in CI are indeed passing. There should be discussion on whether Poetry's virtual environment should be cached. However, thanks to the forethought and ingenuity of the brilliant engineers at Python Discord DevOps, the caching is centralised at HassanAbouelela/actions, and we can have the discussion there.

I would like to extend my gratitude to @ChrisLovering and his ...

#

MarkKoz

[python-discord/site] Pull request closed: #772 Fix Poetry 1\.2 Support & Lock Poetry Version

#

MarkKoz

[python-discord/site] branch deleted: poetry\-1\.2

#

MarkKoz

[site:main] 2 new commits

b8f6416 Fix Poetry 1.2 Support - HassanAbouelela
fb2a796 Merge #772 - fix Poetry 1.2 support & lock Poet... - MarkKoz

odd spireBOT Sep 20, 2022, 2:02 AM

#

[python-discord/site] Workflow Successful

GitHub Actions run 3086905039 succeeded.

Actor

MarkKoz

Workflow Run

Deploy #294

Commit

fb2a796

regal archBOT Sep 20, 2022, 4:09 AM

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #1097 Fix issue \#1050

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #1097 Fix issue \#1050

#

Xithrius

[python-discord/sir-lancebot] Issue closed: #1050 KeyError: 'image\_url' in spookygif command

#

Xithrius

[sir-lancebot:main] 1 new commit

aaa9635 Fix issue #1050 (#1097) - JBarth86

night lilyBOT Sep 20, 2022, 4:12 AM

#

Sir Lancebot

Connected!

odd spireBOT Sep 20, 2022, 4:12 AM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3087369628 succeeded.

Actor

Workflow Run

Build #596

Commit

aaa9635

regal archBOT Sep 20, 2022, 6:25 AM

#

wookie184

[python-discord/bot] New comment on issue #1773: Add mypy to the codebase

Is there any accepted workaround for when annotations are used for something other than annotating types (such as for us with converters)? Or do type checkers work on the assumption that annotations always correspond to types?

That's what typing.Annotated is for.

There is also the typing.no_type_check decorator, but that would ignore all annotations on the function. (in practice, it seems mypy ignores the whole function, contrary to the typing docs? Pyright also doesn't seem to suppo...

odd spireBOT Sep 20, 2022, 7:38 AM

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3088264460 succeeded.

PR Author

Workflow Run

Lint & Test #3184

Source Branch

shtlrs:2108-invoke-rule-command-wi...

regal archBOT Sep 20, 2022, 2:59 PM

#

vivekashok1221

[python-discord/bot] Pull request review submitted: #2232 Add ability to delete multiple reminders at once & display mentions in \`\!remind list\`\.

Reviewed and tested.
LGTM :star2: .

regal archBOT Sep 20, 2022, 5:25 PM

#

CaedenPH

[python-discord/bot] Pull request closed: #2236 New tags relating \`module\`s

regal archBOT Sep 20, 2022, 6:16 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #2232 Add ability to delete multiple reminders at once & display mentions in \`\!remind list\`\.

#

wookie184

[python-discord/bot] New review comment on pull request #2232: Add ability to delete multiple reminders at once & display mentions in \`\!remind list\`\.

I just remembered, we don't usually put mentions in embeds as they often don't resolve (just show the ID in the mention rather than the name), so I'm not sure about this change.

regal archBOT Sep 20, 2022, 9:08 PM

#

ChrisLovering

[python-discord/bot-core] Pull request review submitted: #88 Add a decorator that stops successive duplicate invocations of commands

Looks good to me. Once sphinx-autodoc-typehints makes a release with your change we can get this updated and merged!

regal archBOT Sep 20, 2022, 9:52 PM

#

TizzySaurus

[bot:bot\-2231\-enhancements] 1 new commit

6fd9bae Display mention & str of the mentionable object... - TizzySaurus

#

TizzySaurus

[python-discord/bot] New review comment on pull request #2232: Add ability to delete multiple reminders at once & display mentions in \`\!remind list\`\.

Fixed, as per my comment on Discord :+1:

odd spireBOT Sep 20, 2022, 9:54 PM

#

[python-discord/bot] Checks Successful on PR: #2232 Add ability to delete multiple reminders at once & display mentions in `!remind list`.

GitHub Actions run 3093692661 succeeded.

PR Author

Workflow Run

Lint & Test #3185

Source Branch

bot-2231-enhancements

regal archBOT Sep 20, 2022, 9:58 PM

#

TizzySaurus

[python-discord/bot] New comment on pull request #2008: fix: check for the modteam role before reassigning the user's moderation role

Is this still necessary? I think the issue was fixed in 2b2dc95

Without actually testing anything, it does indeed look like this issue has been fixed (which would mean this can be closed).

regal archBOT Sep 21, 2022, 12:56 AM

#

MarkKoz

[python-discord/bot] Pull request review submitted: #2261 Add support to fetch rules via keywords

#

MarkKoz

[python-discord/site] Pull request closed: #770 Add a collection of keywords per rule

#

MarkKoz

[site:main] 11 new commits

c082323 add collection of keywords per rule - Amrou Bellalouna
a75ba77 add docstrings explaining the values that the R... - Amrou Bellalouna
672ba65 add suggested keywords - Amrou Bellalouna
f07f03a make docstring more explicit about the returned... - Amrou Bellalouna
c5fe65c Merge branch 'main' into map-rules-to-keywords - Amrou Bellalouna

odd spireBOT Sep 21, 2022, 12:58 AM

#

[python-discord/site] Checks Successful on PR: #770 Add a collection of keywords per rule

GitHub Actions run 3094479923 succeeded.

PR Author

Workflow Run

Lint & Test #1260

Source Branch

shtlrs:map-rules-to-keywords

regal archBOT Sep 21, 2022, 12:58 AM

#

MarkKoz

[python-discord/bot] Pull request closed: #2261 Add support to fetch rules via keywords

#

MarkKoz

[bot:main] 43 new commits

79ee2b0 fix "isistance" typo - Amrou Bellalouna
ddd829f add support for keywords when using the "rules"... - Amrou Bellalouna
357ed80 send the list of pre-defined keywords along wit... - Amrou Bellalouna
f924dd2 send the "no-match" error message in pure text ... - Amrou Bellalouna
c1ce683 accept keywords and rule numbers in any order - Amrou Bellalouna

odd spireBOT Sep 21, 2022, 12:59 AM

#

[python-discord/bot] Checks Successful on PR: #2261 Add support to fetch rules via keywords

GitHub Actions run 3094480126 succeeded.

PR Author

Workflow Run

Lint & Test #3186

Source Branch

shtlrs:2108-invoke-rule-command-wi...

#

[python-discord/site] Workflow Successful

GitHub Actions run 3094493834 succeeded.

Actor

MarkKoz

Workflow Run

Deploy #295

Commit

e538d96

oak estuaryBOT Sep 21, 2022, 1:04 AM

#

Python Bot

Connected!

odd spireBOT Sep 21, 2022, 1:04 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3094504397 succeeded.

Actor

MarkKoz

Workflow Run

Deploy #721

Commit

02b1f09

regal archBOT Sep 21, 2022, 8:22 AM

#

shtlrs

[python-discord/site] New comment on issue #753: Link to channel when using \!rule

Is this outdated ? Because when I run the command, I see no reference to no channel

#

shtlrs

[python-discord/site] New comment on issue #363: Add a more centered invite link

Since we have a Who are we section in the landing page, why not have a Join us one as well ?
That's pretty straightforward IMO, if someone likes who we are, then they'd want to join us for sure ( because we're the hottest python community, of course ), so I think it makes sense to have it as a "follow-up" link.

This section would then where people can find and join us pretty easily.

#

shtlrs

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

@MarkKoz How do you think people should discover keywords then ?

And I don't know if you remember, but in bot pr that adds the support for keywords, the first implementation did include the keywords in each rule invocation, but we said that it'd add too much clutter so it got removed.

regal archBOT Sep 21, 2022, 5:57 PM

#

senevr

[python-discord/sir-lancebot] Issue closed: #965 Add a BlackJack game where a member can play against Sir\-Lancebot

regal archBOT Sep 21, 2022, 8:30 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #2232 Add ability to delete multiple reminders at once & display mentions in \`\!remind list\`\.

#

wookie184

[bot:bot\-2231\-enhancements] 165 new commits

8c46657 Incident archive improvements - TizzySaurus
1e0c0cf Fix tests - TizzySaurus
b7e0361 Address Reviews - TizzySaurus
40ab60f Allow referencing message as argument to !remi... - TizzySaurus [0be3332](https://github.com/python-discord/bot/commit/0be3332904690730589113b99198f2f3fc2f1091) Added DurationOrExpiry` type union - ionite34

#

wookie184

[python-discord/bot] Pull request closed: #2232 Add ability to delete multiple reminders at once & display mentions in \`\!remind list\`\.

#

wookie184

[python-discord/bot] branch deleted: bot\-2231\-enhancements

#

wookie184

[bot:main] 8 new commits

a6ae842 Add ability to delete multiple reminders - TizzySaurus
f7bff3d Display mentions instead of name attribute in ... - TizzySaurus [1a9e4c0](https://github.com/python-discord/bot/commit/1a9e4c0c2a840635475ee0481b0d59528eeb9982) Merge branch 'main' into bot-2231-enhancements - TizzySaurus [11f3693](https://github.com/python-discord/bot/commit/11f369307cf4423458c7ce60aeda7637f35bef8e) Address Review - TizzySaurus [2930799`](https://github.com/python-discord/bot/commit/2930799460d8bc65c242b2f06426453304b6ed82) Merge remote-tracking branch 'origin/bot-2231-e... - TizzySaurus

odd spireBOT Sep 21, 2022, 8:34 PM

#

[python-discord/bot] Checks Successful on PR: #2232 Add ability to delete multiple reminders at once & display mentions in `!remind list`.

GitHub Actions run 3100918056 succeeded.

PR Author

Workflow Run

Lint & Test #3188

Source Branch

bot-2231-enhancements

oak estuaryBOT Sep 21, 2022, 8:38 PM

#

Python Bot

Connected!

odd spireBOT Sep 21, 2022, 8:38 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3100951960 succeeded.

Actor

Workflow Run

Deploy #722

Commit

71fbd5a

regal archBOT Sep 21, 2022, 8:41 PM

#

wookie184

[python-discord/site] New comment on issue #753: Link to channel when using \!rule

Nice, yeah, it doesn't seem like any of our rules reference channels now.

#

wookie184

[python-discord/site] Issue closed: #753 Link to channel when using \!rule

regal archBOT Sep 21, 2022, 9:51 PM

#

wookie184

[python-discord/bot] New comment on pull request #2008: fix: check for the modteam role before reassigning the user's moderation role

Since it's a bit more robust to have the check in the same place that the role is applied I think we could do this anyway.

I'll take this over and finish it off.

#

wookie184

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

This has been inactive for a while so I'll put it up for grabs.

#

ChrisLovering

[sir-lancebot] Branch bot\-core\-migration was force-pushed to `3578e97`

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #1092: Python 3\.10 & bot\-core migration

Rebased onto main. Only commit added was https://github.com/python-discord/sir-lancebot/commit/aaa96359448a39a5bbb9a0fd403f23b59b5df860 which doesn't conflict with any of these changes.

odd spireBOT Sep 21, 2022, 10:04 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1092 Python 3.10 & bot-core migration

GitHub Actions run 3101411232 succeeded.

PR Author

Workflow Run

Lint #2448

Source Branch

bot-core-migration

regal archBOT Sep 22, 2022, 7:55 AM

#

shtlrs

[python-discord/site] New review comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Nit: I think all these sentences should begin with a capital letter

#

shtlrs

[python-discord/site] New review comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Nit: The best way to install Docker*

#

shtlrs

[python-discord/site] Pull request review submitted: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Some very small nit changes.

Other than that, great work !

odd spireBOT Sep 22, 2022, 9:56 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1060 fix `.movie`

GitHub Actions run 3104504456 succeeded.

PR Author

CyberCitizen01

Workflow Run

Lint #2449

Source Branch

CyberCitizen01:movie-#1055

regal archBOT Sep 22, 2022, 10:02 AM

#

CyberCitizen01

[python-discord/sir-lancebot] New review comment on pull request #1060: fix \`\.movie\`

Alright. But I think as you suggested, I'll have to see the wikipedia cog to move forward.
(I'll try to do this in a couple of weeks as I have my exams from next week)

#

ChrisLovering

[python-discord/sir-lancebot] New review comment on pull request #1060: fix \`\.movie\`

No problem, real life come first as always!

Take your time and let us know if #dev-contrib if you need help!

regal archBOT Sep 22, 2022, 12:31 PM

#

Exenifix

[python-discord/site] New review comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Thanks for this suggestion, but I consider them kind of continuations of the sentence started in the header, not the standalone sentences. Not sure if this is proper, but I am going to leave it as it is for now, except I am going to bring "how to" to the header because it is in every item.

#

Exenifix

[python-discord/site] New review comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Yeah, you are right, thanks for this correction!

odd spireBOT Sep 22, 2022, 12:36 PM

#

[python-discord/site] Checks Successful on PR: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

GitHub Actions run 3105498126 succeeded.

PR Author

Exenifix

Workflow Run

Lint & Test #1262

Source Branch

Exenifix:main

#

[python-discord/site] Checks Successful on PR: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

GitHub Actions run 3105501941 succeeded.

PR Author

Exenifix

Workflow Run

Lint & Test #1263

Source Branch

Exenifix:main

regal archBOT Sep 22, 2022, 12:37 PM

#

Exenifix

[python-discord/site] New comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Sorry for this mess, for some reason github only allows to request only one review now.

#

shtlrs

[python-discord/site] Pull request review submitted: #733 Added discord\-app\-commands\.md

The comments I left are mostly nit changes.
Nice work !

#

shtlrs

[python-discord/site] New review comment on pull request #733: Added discord\-app\-commands\.md

Nit: I believe resumation is not an English word, resumption should be the one you're looking for.

#

shtlrs

[python-discord/site] New review comment on pull request #733: Added discord\-app\-commands\.md

Nit: Install the latest version of discord.py
It's a small nuance, but i think "of" is more suitable

#

shtlrs

[python-discord/site] New review comment on pull request #733: Added discord\-app\-commands\.md

Nit: You've been capitalizing "Slash Commands" from the start, so I think it's better to stay consistent. ( There are a couple of them, so a small CTRL + F will let you know which ones to change)

regal archBOT Sep 22, 2022, 2:05 PM

#

shtlrs

[python-discord/site] Pull request review submitted: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

regal archBOT Sep 23, 2022, 8:07 AM

#

shtlrs

[python-discord/bot] New comment on issue #2108: Allow invoking rule command with keywords rather than rule number

@wookie184 We forgot to close this.

#

wookie184

[python-discord/bot] Issue closed: #2108 Allow invoking rule command with keywords rather than rule number

regal archBOT Sep 23, 2022, 8:23 PM

#

ChrisLovering

[quackstack:allow\-request\-bodies] 6 new commits

2362cae gitignore local ducky cache - ChrisLovering
49a2922 Use poetry base image - ChrisLovering
3bc55d3 Bump deps & use Python 3.10 - ChrisLovering
6ac735f Add a dev volume mount and enable auto reload i... - ChrisLovering
198dff3 Update readme to suggest the non-hyphen version... - ChrisLovering

#

ChrisLovering

[python-discord/quackstack] New branch created: allow\-request\-bodies

#

ChrisLovering

[python-discord/quackstack] Pull request opened: #74 Split random ducks from ducks with specific options

This is mostly needed so that we do not have request bodies being used in GET requests, as this isn't supported in many HTTP client libraries (such as HTTPX).

This PR also bumps deps to latest, uses Pytohn 3.10 and updates the Dockerfile to use our new base image.

#

ChrisLovering

[sir-lancebot:update\-quackstack\-integration] 1 new commit

4f7c937 Update quackstack integration - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] New branch created: update\-quackstack\-integration

#

ChrisLovering

[python-discord/sir-lancebot] Pull request opened: #1100 Update quackstack integration

Description

With https://github.com/python-discord/quackstack/pull/74 the location for the generated duck as been moved to the Location header, as a full URL.

This should be merged at the same time, or shortly after the above PR.

Did you:

[ ] Join the Python Discord Community?
[ ] Read all the comments in this template?
[ ] Ensure there is an issue open, or link relevant discord discussions?
[ ] Read and agree to the [contrib...

#

ChrisLovering

[quackstack:allow\-request\-bodies] 1 new commit

5ad7d4b Update import order for isort configuration - ChrisLovering

odd spireBOT Sep 23, 2022, 8:32 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1100 Update quackstack integration

GitHub Actions run 3115464611 succeeded.

PR Author

Workflow Run

Lint #2450

Source Branch

update-quackstack-integration

regal archBOT Sep 23, 2022, 8:36 PM

#

ChrisLovering

[sir-lancebot] Branch update\-quackstack\-integration was force-pushed to `f3e140c`

odd spireBOT Sep 23, 2022, 8:37 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1100 Update quackstack integration

GitHub Actions run 3115490996 succeeded.

PR Author

Workflow Run

Lint #2451

Source Branch

update-quackstack-integration

regal archBOT Sep 23, 2022, 8:47 PM

#

HassanAbouelela

[python-discord/quackstack] Pull request review submitted: #74 Split random ducks from ducks with specific options

#

ChrisLovering

[sir-lancebot] Branch update\-quackstack\-integration was force-pushed to `9e561ae`

odd spireBOT Sep 23, 2022, 8:54 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1100 Update quackstack integration

GitHub Actions run 3115570971 succeeded.

PR Author

Workflow Run

Lint #2452

Source Branch

update-quackstack-integration

regal archBOT Sep 23, 2022, 9:03 PM

#

TizzySaurus

[bot-core:check\-rerun\-job\-util] 1 new commit

9461db3 Hard rewrite check_rerun_job util to remove a... - TizzySaurus

#

TizzySaurus

[bot-core:check\-rerun\-job\-util] 11 new commits

3efbae7 Add metricity to docker-compose so web doesn't ... - ChrisLovering
0f12f00 Update poetry to use 1.2.0 - ChrisLovering
ed2639b Don't mount project root in docker-compose - ChrisLovering
ce894c0 Use BOT_TOKEN in example project - ChrisLovering
6436908 Use Poetry Base In Docker Image - HassanAbouelela

#

ChrisLovering

[sir-lancebot:bot\-core\-migration] 2 new commits

3e07082 Update games cog token refresh logic - ChrisLovering
952a3a7 Remove all wait_until_guil_available as this is... - ChrisLovering

odd spireBOT Sep 23, 2022, 9:14 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1092 Python 3.10 & bot-core migration

GitHub Actions run 3115674529 succeeded.

PR Author

Workflow Run

Lint #2453

Source Branch

bot-core-migration

regal archBOT Sep 23, 2022, 9:58 PM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #1092 Python 3\.10 & bot\-core migration

This was a big PR. Some would say it was too big. Others are simply wrong.

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1092 Python 3\.10 & bot\-core migration

#

ChrisLovering

[python-discord/sir-lancebot] branch deleted: bot\-core\-migration

#

ChrisLovering

[sir-lancebot:main] 19 new commits

8395a7c Add bot core as a dep and bump all deps - ChrisLovering
31dfe02 Upgrade to Python 3.10 - ChrisLovering
69e6abd Don't override default flake8 ignore list - ChrisLovering
10cf080 Use monkey patches from botcore - ChrisLovering
510da51 Use BotBase from bot core - ChrisLovering

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #1100 Update quackstack integration

#

ChrisLovering

[sir-lancebot] Branch update\-quackstack\-integration was force-pushed to `0f47b5a`

odd spireBOT Sep 23, 2022, 10:02 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1100 Update quackstack integration

GitHub Actions run 3115895789 succeeded.

PR Author

Workflow Run

Lint #2455

Source Branch

update-quackstack-integration

night lilyBOT Sep 23, 2022, 10:02 PM

#

Sir Lancebot

Connected!

odd spireBOT Sep 23, 2022, 10:03 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3115893733 succeeded.

Actor

Workflow Run

Build #597

Commit

f9cc77f

#

[python-discord/sir-lancebot] Checks Successful on PR: #1101 Bump flake8-bugbear from 22.9.11 to 22.9.23

GitHub Actions run 3115910899 succeeded.

PR Author

Workflow Run

Lint #2456

Source Branch

dependabot/pip/flake8-bugbear-22...

#

[python-discord/sir-lancebot] Checks Successful on PR: #1102 Bump rapidfuzz from 2.9.0 to 2.10.0

GitHub Actions run 3115916284 succeeded.

PR Author

Workflow Run

Lint #2457

Source Branch

dependabot/pip/rapidfuzz-2.10.0

regal archBOT Sep 23, 2022, 10:48 PM

#

ionite34

[python-discord/quackstack] Pull request review submitted: #74 Split random ducks from ducks with specific options

Looks good, and thanks for the fix

#

ionite34

[python-discord/sir-lancebot] Pull request review submitted: #1100 Update quackstack integration

Looks good

#

ChrisLovering

[python-discord/quackstack] Pull request closed: #74 Split random ducks from ducks with specific options

#

ChrisLovering

[quackstack:main] 8 new commits

2362cae gitignore local ducky cache - ChrisLovering
49a2922 Use poetry base image - ChrisLovering
3bc55d3 Bump deps & use Python 3.10 - ChrisLovering
6ac735f Add a dev volume mount and enable auto reload i... - ChrisLovering
198dff3 Update readme to suggest the non-hyphen version... - ChrisLovering

#

ChrisLovering

[python-discord/quackstack] branch deleted: allow\-request\-bodies

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1100 Update quackstack integration

#

ChrisLovering

[python-discord/sir-lancebot] branch deleted: update\-quackstack\-integration

#

ChrisLovering

[sir-lancebot:main] 2 new commits

0f47b5a Update quackstack integration - ChrisLovering
d35a497 Merge pull request #1100 from python-discord/up... - ChrisLovering

night lilyBOT Sep 23, 2022, 10:53 PM

#

Sir Lancebot

Connected!

odd spireBOT Sep 23, 2022, 10:53 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3116095294 succeeded.

Actor

Workflow Run

Build #598

Commit

d35a497

regal archBOT Sep 23, 2022, 11:04 PM

#

TizzySaurus

[bot-core:check\-rerun\-job\-util] 2 new commits

c7eb65e Fix date in changelog.rst - TizzySaurus
ef00c18 Merge remote-tracking branch 'origin/check-reru... - TizzySaurus

regal archBOT Sep 24, 2022, 6:26 PM

#

wookie184

[python-discord/bot-core] Issue opened: #140 Keep references to tasks in utils\.scheduling\.create\_task

Quite a common (https://github.com/python-discord/bot/search?q=create_task) code pattern is to create a task with scheduling.create_task and not assign the returned task to anything.

The documentation for create_task (used under the hood by scheduling) warns against this:

**...

regal archBOT Sep 24, 2022, 6:53 PM

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2245 Update autoreview system

#

wookie184

[sir-lancebot:dependabot/pip/flake8\-bugbear\-22\.9\.23] 3 new commits

0f47b5a Update quackstack integration - ChrisLovering
d35a497 Merge pull request #1100 from python-discord/up... - ChrisLovering
646c1ba Merge branch 'main' into dependabot/pip/flake8-... - wookie184

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1101 Bump flake8\-bugbear from 22\.9\.11 to 22\.9\.23

#

wookie184

[sir-lancebot:main] 1 new commit

268cc3e Bump flake8-bugbear from 22.9.11 to 22.9.23 (#1... - dependabot[bot]

odd spireBOT Sep 24, 2022, 7:05 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1101 Bump flake8-bugbear from 22.9.11 to 22.9.23

GitHub Actions run 3119432201 succeeded.

PR Author

Workflow Run

Lint #2459

Source Branch

dependabot/pip/flake8-bugbear-22...

night lilyBOT Sep 24, 2022, 7:09 PM

#

Sir Lancebot

Connected!

odd spireBOT Sep 24, 2022, 7:09 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3119442697 succeeded.

Actor

Workflow Run

Build #599

Commit

268cc3e

#

[python-discord/sir-lancebot] Checks Successful on PR: #1102 Bump rapidfuzz from 2.9.0 to 2.10.0

GitHub Actions run 3119446329 succeeded.

PR Author

Workflow Run

Lint #2461

Source Branch

dependabot/pip/rapidfuzz-2.10.0

regal archBOT Sep 24, 2022, 7:11 PM

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1102 Bump rapidfuzz from 2\.9\.0 to 2\.10\.0

#

wookie184

[sir-lancebot:main] 1 new commit

e7a60bb Bump rapidfuzz from 2.9.0 to 2.10.0 (#1102) - dependabot[bot]

night lilyBOT Sep 24, 2022, 7:14 PM

#

Sir Lancebot

Connected!

odd spireBOT Sep 24, 2022, 7:14 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3119459688 succeeded.

Actor

Workflow Run

Build #600

Commit

e7a60bb

regal archBOT Sep 24, 2022, 7:33 PM

#

TizzySaurus

[python-discord/bot-core] New branch created: add\-message\-utils

#

TizzySaurus

[bot-core:add\-message\-utils] 1 new commit

0b0e5d2 Migrate all message utils from bot and sir-lanc... - TizzySaurus

regal archBOT Sep 24, 2022, 8:07 PM

#

TizzySaurus

[python-discord/bot-core] Pull request opened: #141 Migrate all message utils from bot and sir\-lancebot\.

As the title says, with approval from @ChrisLovering in dev-contrib.

This migration does contain a few changes, as per the following:

Constants

Since some of bot's message utils used constants, which don't exist on botcore, these had to be changed as follows:

NEGATIVE_REPLIES - defined as a constant at top of file
[Emojis.trashcan](https://github.com/python-discord/bot/blob/main/config-de...

regal archBOT Sep 24, 2022, 8:25 PM

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1079: Port GitHub code display embed from Python

NB: This is now waiting on python-discord/bot-core#141, as lancebot is missing certain util functions.

regal archBOT Sep 24, 2022, 9:27 PM

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1062: improving the \.latex command

Updating this to stalled since it's waiting on python-discord/bot-core#137.

regal archBOT Sep 25, 2022, 12:16 AM

#

HassanAbouelela

[python-discord/bot-core] New comment on pull request #141: Migrate all message utils from bot and sir\-lancebot\.

I don’t think we should implement constants this way. How would someone test bot features which rely on these constants? To be clear, this is not your fault, nor something that can be fixed in this PR, as it requires serious work on how we approach constants in bot-core in general. Work that we have so far failed to do.

When bot-core was first starting, this topic came up, and I fought to try and get what I think is the best compromise implemented, however I met great resistance. I’ll star...

#

HassanAbouelela

[python-discord/bot-core] Pull request closed: #141 Migrate all message utils from bot and sir\-lancebot\.

#

HassanAbouelela

[python-discord/bot-core] Pull request reopened: #141 Migrate all message utils from bot and sir\-lancebot\.

regal archBOT Sep 25, 2022, 8:13 AM

#

mbaruh

[python-discord/bot-core] New comment on pull request #141: Migrate all message utils from bot and sir\-lancebot\.

I agree that hardcoding these constants is the least preferable way to handle it. I still don't like the suggestion though.

If we pass constants to functions, we'd still have to change them in whichever project uses them

Yes, once. In this PR there is only one usage for these constants, and they could be easily passed as a bypass_roles argument or any other name you want.

I'd prefer bot-core to stay a generic library for bots. If we start tying it to specific projects I can onl...

regal archBOT Sep 25, 2022, 9:00 AM

#

HassanAbouelela

[python-discord/bot-core] New comment on pull request #141: Migrate all message utils from bot and sir\-lancebot\.

It is only one PR in some scenarios, but from my experience trying to migrate some of the utils, you'll still end up in a scenario having to change both. One example from here would be modifying the moderator role ID, and modifying the list of roles considered "mod roles" (like we did when we split the mod role in two).

In the provided example, you can work around that by passing the set of IDs directly, and despite being a cumbersome and repetitive API, will work. This is not true for all t...

regal archBOT Sep 25, 2022, 10:24 AM

#

wookie184

[python-discord/bot-core] New comment on pull request #141: Migrate all message utils from bot and sir\-lancebot\.

I like Hassan's suggestion here.

My understanding on roughly how it could work:

The project using bot-core defines the constants needed (e.g. with a pydantic config class). These would be based on it's own constants
This constants object is passed to the botcore Bot class on initialisation somehow.
The botcore Bot object sets these as global variables on a constants.py in bot-core (would need to be careful in exactly how this is done).
These constants can now be imported an...

regal archBOT Sep 25, 2022, 11:42 AM

#

mbaruh

[python-discord/bot-core] New comment on pull request #141: Migrate all message utils from bot and sir\-lancebot\.

@HassanAbouelela

It is only one PR in some scenarios, but from my experience trying to migrate some of the utils, you'll still end up in a scenario having to change both. One example from here would be modifying the moderator role ID, and modifying the list of roles considered "mod roles" (like we did when we split the mod role in two).

I said in the previous comment I agree hardocoding is not a good solution, so I'm not sure what this is aimed at.

In the provided example, you can...

regal archBOT Sep 25, 2022, 4:01 PM

#

wookie184

[site:add\-windows\-guide] 1 new commit

0129205 Add initial guide for errors with Python on Win... - wookie184

#

wookie184

[python-discord/site] New branch created: add\-windows\-guide

#

wookie184

[python-discord/site] Pull request opened: #773 Add guide for working with Python on Windows

This is an incomplete draft.

Not sure whether this would be better split up into different pages.

odd spireBOT Sep 25, 2022, 4:04 PM

#

[python-discord/site] Checks Successful on PR: #773 Add guide for working with Python on Windows

GitHub Actions run 3122790282 succeeded.

PR Author

Workflow Run

Lint & Test #1264

Source Branch

add-windows-guide

odd spireBOT Sep 25, 2022, 7:43 PM

#

[python-discord/kubernetes] Checks Successful on PR: #138 Add pixels-v2 manifest

GitHub Actions run 3123431332 succeeded.

PR Author

Lint Kubernetes manifests #287

Workflow Run

Source Branch

pixels-manifest

odd spireBOT Sep 25, 2022, 8:03 PM

#

[python-discord/kubernetes] Checks Successful on PR: #138 Add pixels-v2 manifest

GitHub Actions run 3123485435 succeeded.

PR Author

Lint Kubernetes manifests #288

Workflow Run

Source Branch

pixels-manifest

#

[python-discord/kubernetes] Checks Successful on PR: #138 Add pixels-v2 manifest

GitHub Actions run 3123494132 succeeded.

PR Author

Lint Kubernetes manifests #289

Workflow Run

Source Branch

pixels-manifest

odd spireBOT Sep 25, 2022, 8:37 PM

#

[python-discord/kubernetes] Checks Successful on PR: #138 Add pixels-v2 manifest

GitHub Actions run 3123584076 succeeded.

PR Author

Lint Kubernetes manifests #290

Workflow Run

Source Branch

pixels-manifest

regal archBOT Sep 25, 2022, 9:32 PM

#

shtlrs

[python-discord/bot] New comment on issue #1379: Adjust rich\_embeds filter so it doesn't catch edge case

Discussed in [discord](#dev-contrib message) with @mbaruh.

I'll reproduce the issue, and when I understand that, I'll drop the proposition here and we can discuss it.

odd spireBOT Sep 25, 2022, 9:45 PM

#

[python-discord/kubernetes] Checks Successful on PR: #138 Add pixels-v2 manifest

GitHub Actions run 3123781129 succeeded.

PR Author

Lint Kubernetes manifests #291

Workflow Run

Source Branch

pixels-manifest

regal archBOT Sep 25, 2022, 10:15 PM

#

shtlrs

[python-discord/bot] New comment on issue #1379: Adjust rich\_embeds filter so it doesn't catch edge case

@bast0006 Can you please provide the examples you've tried ?
Because I'm not sure I understand correctly here since you said

and thus a message with mobile.twitter.com in it is falsely detected as a rich embed for the watchlist.

When I use this link https://twitter.com/Nadallica86/status/1574145915048398854 or https://mobile.twitter.com/nedbat/status/1504062673809338370, _has_rich_embed works just fine.

But as soon as I use twitter's Lite version (with the 'mobile' prefix),...

odd spireBOT Sep 25, 2022, 10:24 PM

#

[python-discord/kubernetes] Checks Successful on PR: #138 Add pixels-v2 manifest

GitHub Actions run 3123894793 succeeded.

PR Author

Lint Kubernetes manifests #292

Workflow Run

Source Branch

pixels-manifest

regal archBOT Sep 26, 2022, 1:40 AM

#

MarkKoz

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

I don't think discoverability is too important because the primary way to use the command is
with rule numbers, which are already discoverable. The keyword support is there for those that happen to remember them or pick them up from seeing other users invoking the command. Furthermore, the keywords are intuitive enough that one is likely to correctly guess a keyword.

Having that info in a new command would not help discoverability much — it seems unlikely someone would figure out that co...

odd spireBOT Sep 26, 2022, 10:05 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1103 Bump rapidfuzz from 2.10.0 to 2.10.1

GitHub Actions run 3126833578 succeeded.

PR Author

Workflow Run

Lint #2463

Source Branch

dependabot/pip/rapidfuzz-2.10.1

regal archBOT Sep 26, 2022, 2:54 PM

#

ChrisLovering

[sir-lancebot:main] 2 new commits

bb0d8ed Bump rapidfuzz from 2.10.0 to 2.10.1 - dependabot[bot]
807ca00 Merge pull request #1103 from python-discord/de... - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1103 Bump rapidfuzz from 2\.10\.0 to 2\.10\.1

night lilyBOT Sep 26, 2022, 2:58 PM

#

Sir Lancebot

Connected!

odd spireBOT Sep 26, 2022, 2:59 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3128775492 succeeded.

Actor

Workflow Run

Build #601

Commit

807ca00

regal archBOT Sep 26, 2022, 3:50 PM

#

vivekashok1221

[python-discord/bot] Pull request review submitted: #2267 Improve reporting on autoban filter lists

Good stuff.

And we also gotta remember to update the config file for the staff test server (I don't mind doing it).

#

vivekashok1221

[python-discord/bot] New review comment on pull request #2267: Improve reporting on autoban filter lists

if allow_type is "Allow list", why would we autoban based on it? This question is probably not even related to the PR, it's just that I feel like I'm missing something :sweat_smile: .

#

vivekashok1221

[python-discord/bot] New review comment on pull request #2267: Improve reporting on autoban filter lists

This docstring is technically inaccurate since it can send the report in any channel (you probably pasted this over from another method).
Also. we should probably add a check to ensure that the command cannot be run in public channels.

regal archBOT Sep 26, 2022, 4:21 PM

#

shtlrs

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

Okay, I see your point.

Then I don't quite get the whole point of adding the feature in the first place if the rules are always discoverable and displayed in !help rules.

Can you explain more what you mean by

However, I don't think it currently supports dynamically generated descriptions.

odd spireBOT Sep 26, 2022, 9:08 PM

#

[python-discord/forms-backend] Checks Successful on PR: #214 Bump sentry-sdk from 1.9.3 to 1.9.9

GitHub Actions run 3131060283 succeeded.

PR Author

Workflow Run

Forms Backend #592

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Sep 27, 2022, 2:16 AM

#

MarkKoz

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

Then I don't quite get the whole point of adding the feature in the first place if the rules are always discoverable and displayed in !help rules.

Numbers are more difficult to remember than keywords. For example, I remember there is an "ad" keyword just from my quick testing session, but I still have no idea what the rule number for that is off the top of my head.

Can you explain more what you mean by

The help command displays what's in a command's docstring. If the keywords wer...

regal archBOT Sep 27, 2022, 6:12 AM

#

bast0006

[python-discord/bot] New comment on issue #1379: Adjust rich\_embeds filter so it doesn't catch edge case

https://mobile.twitter.com/nedbat/status/1504062673809338370 is rendered as the following:

== Raw embeds (1/1) ==

{'author': {'icon_url': 'https://pbs.twimg.com/profile_images/1559004270170628096/AaSLxb_F_400x400.jpg',
            'name': 'Ned Batchelder (@nedbat)',
            'proxy_icon_url': 'https://images-ext-1.discordapp.net/external/KcDnbosWojYPkPQ4Ummp1Ad-f2wJ8Ukq3PXnU7IK-ZU/https/pbs.twimg.com/profile_images/1559004270170628096/AaSLxb_F_400x400.jpg',
            ...

#

bast0006

[python-discord/bot] New comment on issue #1379: Adjust rich\_embeds filter so it doesn't catch edge case

There are three twitter embed cases here.

The first is https://twitter.com/nedbat/status/1504062673809338370, which embeds as type: rich with a 'url' of https://twitter.com/nedbat/status/1504062673809338370, which works as expected.

The second is https://m.twitter.com/nedbat/status/1504062673809338370, which embeds as type: link and thus is ignored appropriately.

The third is https://mobile.twitter.com/nedbat/status/1504062673809338370, which does embed as type: rich, but...

regal archBOT Sep 27, 2022, 8:07 AM

#

shtlrs

[python-discord/bot] New comment on issue #1379: Adjust rich\_embeds filter so it doesn't catch edge case

Thanks for the explanation, I turned out that I understood something else before, but I do see what you meant now.

I was thinking maybe we can eliminate the subdomain and only keep the 2nd level domain & TLD along with the same path & query parameters of course for comparison, but I'm wondering what could the edge cases be here.

The path would be the same and the domain as well (eventually), what's making me wonder if whether query parameters can be altered upon rendering that URL. ( on...

odd spireBOT Sep 27, 2022, 10:04 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1104 Bump sentry-sdk from 1.9.8 to 1.9.9

GitHub Actions run 3134700041 succeeded.

PR Author

Workflow Run

Lint #2465

Source Branch

dependabot/pip/sentry-sdk-1.9.9

night lilyBOT Sep 27, 2022, 3:48 PM

#

Sir Lancebot

Connected!

odd spireBOT Sep 27, 2022, 3:49 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3137019542 succeeded.

Actor

Workflow Run

Build #602

Commit

5659bb9

regal archBOT Sep 28, 2022, 4:08 AM

#

mbaruh

[python-discord/bot] New comment on issue #2281: Async function remove\_cog not awaited

Looks like a remnant of the move to discord.py 2.0.

I'm not sure awaiting it works. iirc raising an error will cause it to unload. Worth checking.

regal archBOT Sep 28, 2022, 5:56 AM

#

shtlrs

[python-discord/bot] New comment on issue #2281: Async function remove\_cog not awaited

@mbaruh do you mean the fact that it isn't awaited will throw and thus would still unload the cog?

I noticed it upon unloading a cog actually, and I thought it was ugly to have that exception in our logs.

BTW, couldn't this have been avoided if we used something like mypy? Why don't we actually have that in our project?

regal archBOT Sep 28, 2022, 6:29 AM

#

MarkKoz

[python-discord/bot] Issue opened: #2282 Handle Discord's rejection of off\-topic channel names due to disallowed words

Sentry Issue: BOT-38K

Summary

Discord must have recently added a new feature which rejects channel names if they contain certain words they don't like. This is a problem for our automated renaming of off-topic channels, which has some names with words that are no longer allowed. The first event of the Sentry issue above was caused by the name "ot0-welcome-and-fuck-you", for example.

#...

#

vivekashok1221

[python-discord/bot] New comment on issue #2282: Handle Discord's rejection of off\-topic channel names due to disallowed words

If option 3 isn't possible, option 1.b is a good compromise (get notified so that we can either change or delete the ot name).

regal archBOT Sep 28, 2022, 7:44 AM

#

shtlrs

[python-discord/bot] Pull request opened: #2283 1379 tranform urls upon rich embed filter application

closes #1379

The current implementation allows to collect the URLs from the sent messages and then apply a transformation on them.

The transformation here is basically a removal of the subdomain (if it exists) because of the way Discord renders some URLs (Twitter's in particular)

#

shtlrs

[python-discord/bot] New comment on pull request #2283: 1379 tranform urls upon rich embed filter application

@bast0006, @scragly The floor is yours.

odd spireBOT Sep 28, 2022, 7:47 AM

#

[python-discord/bot] Checks Successful on PR: #2283 1379 tranform urls upon rich embed filter application

GitHub Actions run 3141703917 succeeded.

PR Author

Workflow Run

Lint & Test #3190

Source Branch

shtlrs:1379-tranform-urls-upon-ric...

regal archBOT Sep 28, 2022, 8:27 AM

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2283: 1379 tranform urls upon rich embed filter application

You've created a variable final_urls and are adding urls to it, but then the check is still if ... embed.url not in urls, so does this even do anything?

Also, we have the tldextract lib installed in the project, which is better at separating subddomains from urls than urllib and then assuming the first 2 parts are the subdomain (which isn't always the case)/.

regal archBOT Sep 28, 2022, 8:43 AM

#

shtlrs

[python-discord/bot] New review comment on pull request #2283: 1379 tranform urls upon rich embed filter application

Shoot. The first implementation wasn't in a set and I was adding them in the original list, but I wanted to remove dups.
My bad, I'll fix that.

As for the tldextract one, i'll have a look at it right away

odd spireBOT Sep 28, 2022, 8:45 AM

#

[python-discord/bot] Checks Successful on PR: #2283 1379 tranform urls upon rich embed filter application

GitHub Actions run 3142080916 succeeded.

PR Author

Workflow Run

Lint & Test #3191

Source Branch

shtlrs:1379-tranform-urls-upon-ric...

odd spireBOT Sep 28, 2022, 10:04 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1105 Bump rapidfuzz from 2.10.1 to 2.10.2

GitHub Actions run 3142615808 succeeded.

PR Author

Workflow Run

Lint #2467

Source Branch

dependabot/pip/rapidfuzz-2.10.2

odd spireBOT Sep 28, 2022, 12:41 PM

#

[python-discord/bot] Checks Successful on PR: #2283 1379 tranform urls upon rich embed filter application

GitHub Actions run 3143604790 succeeded.

PR Author

Workflow Run

Lint & Test #3192

Source Branch

shtlrs:1379-tranform-urls-upon-ric...

regal archBOT Sep 28, 2022, 12:48 PM

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1105 Bump rapidfuzz from 2\.10\.1 to 2\.10\.2

#

wookie184

[sir-lancebot:main] 1 new commit

ca0220a Bump rapidfuzz from 2.10.1 to 2.10.2 (#1105) - dependabot[bot]

night lilyBOT Sep 28, 2022, 12:52 PM

#

Sir Lancebot

Connected!

odd spireBOT Sep 28, 2022, 12:53 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3143684920 succeeded.

Actor

Workflow Run

Build #603

Commit

ca0220a

odd spireBOT Sep 28, 2022, 3:44 PM

#

[python-discord/branding] Checks Successful on PR: #190 Add `duckysphere.svg`.

GitHub Actions run 3144946865 succeeded.

PR Author

kosayoda

Workflow Run

Event Validation #105

Source Branch

ducky-sphere

regal archBOT Sep 28, 2022, 5:33 PM

#

MrHemlock

[python-discord/bot] New comment on issue #2282: Handle Discord's rejection of off\-topic channel names due to disallowed words

I would think just going through and curating the list we have now and just clean them up. Probably not a great look for us to have fuck as one of our channel names anyway. Then I guess from there just have a regular filter on new additions.

A low tech solution makes more sense to me for something like this.

regal archBOT Sep 28, 2022, 7:12 PM

#

MarkKoz

[python-discord/bot] New comment on issue #2282: Handle Discord's rejection of off\-topic channel names due to disallowed words

@MrHemlock We don't know which words are disallowed. Thus, we cannot prevent new invalid names from being added.

#

MrHemlock

[python-discord/bot] New comment on issue #2282: Handle Discord's rejection of off\-topic channel names due to disallowed words

Fair. Just feels like more maintenance to have to have to add and potentially remove in future. Out of the three, 1 sounds the better solution given the current circumstances.

I do also think we should go through and curate the list again anyway. Couldn't hurt.

regal archBOT Sep 28, 2022, 7:38 PM

#

MarkKoz

[python-discord/bot] New comment on issue #2282: Handle Discord's rejection of off\-topic channel names due to disallowed words

Just feels like more maintenance to have to have to add and potentially remove in future.

Being concerned about complexity is valid. With that in mind, we could do one of the following (assuming we go with solution 1):

Only retry. Don't delete invalid names and don't notify about invalid names.
Just catch the error and do nothing. Downside: one of the channel names won't change.

In both cases, there is the additional downside of not knowing that some names are never being us...

#

MrHemlock

[python-discord/bot] New comment on issue #2282: Handle Discord's rejection of off\-topic channel names due to disallowed words

Something like a message in Mod alerts or Dev alerts would probably be sufficient for 2. Handle that case (delete, modify, etc.) and either trigger the try again or just let it sit until the next go.

regal archBOT Sep 28, 2022, 8:57 PM

#

minalike

[python-discord/branding] Pull request review submitted: #190 Add \`duckysphere\.svg\`\.

It is with absolute honor that I accept ducky_sphere into the fold of great duckies.

#

minalike

[python-discord/branding] Pull request closed: #190 Add \`duckysphere\.svg\`\.

#

minalike

[branding:main] 2 new commits

6c37432 Add duckysphere.svg. - kosayoda
3821bd1 Merge pull request #190 from python-discord/duc... - minalike

#

minalike

[python-discord/branding] branch deleted: ducky\-sphere

odd spireBOT Sep 28, 2022, 8:58 PM

#

[python-discord/branding] Workflow Successful

GitHub Actions run 3146825082 succeeded.

Actor

minalike

Workflow Run

Event Validation #106

Commit

3821bd1

regal archBOT Sep 29, 2022, 12:21 PM

#

TizzySaurus

[python-discord/bot-core] New comment on pull request #141: Migrate all message utils from bot and sir\-lancebot\.

That's the whole suggestion though, storing the common constants in bot-core.
Isn't this the whole purpose of bot-core (to remove duplicate code between the bots)?

I personally would be for a constants.py file on bot-core, that has all the constants that are required on both bot and lancebot. Other constants can stay within their respective repo (as they already are).

Yes, this means 2 PRs when moving constants to bot-core (1 on bot-core and one on the repo it used to be on for mig...

regal archBOT Sep 29, 2022, 7:24 PM

#

mbaruh

[bot:new\-filters] 222 new commits

8c46657 Incident archive improvements - TizzySaurus
1e0c0cf Fix tests - TizzySaurus
b7e0361 Address Reviews - TizzySaurus
3ad7cd9 Add required config and constants for snekbox 3.11 - ChrisLovering
234bd00 Allow users to eval code in either 3.11 or 3.10 - ChrisLovering

regal archBOT Sep 30, 2022, 6:19 AM

#

ionite34

[python-discord/bot] Pull request review submitted: #1917 Patreon

Wasn't able to test the role assignments on real users, but seem to work fine in manual testing.

regal archBOT Sep 30, 2022, 9:21 AM

#

mbaruh

[site:new\-filter\-schema] 3 new commits

8c07c20 Add voice mute to infraction choices - mbaruh
e7e55af Use the new models.JSONField - mbaruh
870238e Convert the infraction choices to uppercase - mbaruh

regal archBOT Sep 30, 2022, 2:18 PM

#

HassanAbouelela

[site:fix\-warnings] 14 new commits

c082323 add collection of keywords per rule - Amrou Bellalouna
b8f6416 Fix Poetry 1.2 Support - HassanAbouelela
a75ba77 add docstrings explaining the values that the R... - Amrou Bellalouna
672ba65 add suggested keywords - Amrou Bellalouna
f07f03a make docstring more explicit about the returned... - Amrou Bellalouna

#

jchristgit

[python-discord/site] Pull request closed: #768 Fix Warnings & Enable In Tests

#

jchristgit

[site:main] 6 new commits

cb40bab Fix Django Deprecation Warnings - HassanAbouelela
4998984 Fix Unittest Deprecation Warnings - HassanAbouelela
a2beb05 Enable Python Warnings In Tests - HassanAbouelela
7432612 Ignore Whitenoise's Static Directory Warning - HassanAbouelela
42b9f8d Merge branch 'main' into fix-warnings - HassanAbouelela

#

jchristgit

[python-discord/site] branch deleted: fix\-warnings

odd spireBOT Sep 30, 2022, 2:20 PM

#

[python-discord/site] Checks Successful on PR: #768 Fix Warnings & Enable In Tests

GitHub Actions run 3159431585 succeeded.

PR Author

Workflow Run

Lint & Test #1265

Source Branch

fix-warnings

#

[python-discord/site] Workflow Successful

GitHub Actions run 3159464604 succeeded.

Actor

jchristgit

Workflow Run

Deploy #298

Commit

fca03d3

regal archBOT Sep 30, 2022, 2:34 PM

#

ChrisLovering

[python-discord/site] New comment on pull request #760: Bump django from 4\.0\.6 to 4\.0\.7

@dependabot rebase

#

HassanAbouelela

[site] Branch bump\-dependencies was force-pushed to `f386eda`

#

HassanAbouelela

[python-discord/site] Pull request closed: #760 Bump django from 4\.0\.6 to 4\.0\.7

#

HassanAbouelela

[site:main] 2 new commits

c6d3c4b Bump django from 4.0.6 to 4.0.7 - dependabot[bot]
3a3b58b Merge pull request #760 from python-discord/dep... - HassanAbouelela

odd spireBOT Sep 30, 2022, 2:42 PM

#

[python-discord/site] Checks Failed on PR: #769 Update To 3.10 And Bump Dependencies

GitHub Actions run 3159580140 failed.

PR Author

Workflow Run

Lint & Test #1268

Source Branch

bump-dependencies

#

[python-discord/site] Checks Successful on PR: #760 Bump django from 4.0.6 to 4.0.7

GitHub Actions run 3159576455 succeeded.

PR Author

Workflow Run

Lint & Test #1267

Source Branch

dependabot/pip/django-4.0.7

regal archBOT Sep 30, 2022, 2:43 PM

#

ChrisLovering

[site] Branch extend\-download\-timeout was force-pushed to `1d47dc4`

#

jchristgit

[python-discord/site] Pull request closed: #767 Use a httpx\.Client for netlify static builds

#

jchristgit

[site:main] 2 new commits

1d47dc4 Use a httpx.Client for netlify static builds - ChrisLovering
c96e895 Merge pull request #767 from python-discord/ext... - jchristgit

#

jchristgit

[python-discord/site] branch deleted: extend\-download\-timeout

odd spireBOT Sep 30, 2022, 2:46 PM

#

[python-discord/site] Checks Successful on PR: #767 Use a httpx.Client for netlify static builds

GitHub Actions run 3159600634 succeeded.

PR Author

Workflow Run

Lint & Test #1270

Source Branch

extend-download-timeout

#

[python-discord/site] Workflow Successful

GitHub Actions run 3159612077 succeeded.

Actor

Workflow Run

Deploy #299

Commit

c96e895

#

[python-discord/site] Workflow Successful

GitHub Actions run 3159626912 succeeded.

Actor

jchristgit

Workflow Run

Deploy #300

Commit

c96e895

regal archBOT Sep 30, 2022, 2:58 PM

#

HassanAbouelela

[site] Branch bump\-dependencies was force-pushed to `13bce4d`

#

HassanAbouelela

[python-discord/site] New comment on pull request #769: Update To 3\.10 And Bump Dependencies

I've gone ahead and cleaned history, merged the main branch, and updated all dependencies again (including both dependencies which were waiting on fixes upstream).

This also means @jchristgit review should count since I snapped your changes out of existence 😀, or you can review again if you like

I've noticed that flake is failing locally when run through pre-commit (something we wouldn't see in CI), so I'm working on finding a fix for that now

odd spireBOT Sep 30, 2022, 3:03 PM

#

[python-discord/site] Checks Failed on PR: #769 Update To 3.10 And Bump Dependencies

GitHub Actions run 3159693609 failed.

PR Author

Workflow Run

Lint & Test #1272

Source Branch

bump-dependencies

regal archBOT Sep 30, 2022, 3:19 PM

#

HassanAbouelela

[site] Branch bump\-dependencies was force-pushed to `c4474c0`

#

HassanAbouelela

[python-discord/site] New comment on pull request #769: Update To 3\.10 And Bump Dependencies

Alright, everything seems to be working, but the test suite took 4+ minutes...

odd spireBOT Sep 30, 2022, 3:26 PM

#

[python-discord/site] Checks Successful on PR: #769 Update To 3.10 And Bump Dependencies

GitHub Actions run 3159831627 succeeded.

PR Author

Workflow Run

Lint & Test #1273

Source Branch

bump-dependencies

regal archBOT Sep 30, 2022, 5:53 PM

#

HassanAbouelela

[python-discord/site] New comment on pull request #769: Update To 3\.10 And Bump Dependencies

I've narrowed down the test slowness to the redirects tests, specifically on resource redirects which take 15 seconds per redirect in the django render function (only if running through the django test runner).

Downgrading sentry from 1.9.9 to 1.9.8 fixes the issue. Based on their issue tracker, 1.9.9 is broken big time.

#

HassanAbouelela

[site:bump\-dependencies] 1 new commit

802d85c Downgrade sentry-sdk To 1.9.8 - HassanAbouelela

odd spireBOT Sep 30, 2022, 5:58 PM

#

[python-discord/site] Checks Successful on PR: #769 Update To 3.10 And Bump Dependencies

GitHub Actions run 3160690061 succeeded.

PR Author

Workflow Run

Lint & Test #1274

Source Branch

bump-dependencies

regal archBOT Sep 30, 2022, 6:02 PM

#

ChrisLovering

[python-discord/site] Pull request review submitted: #769 Update To 3\.10 And Bump Dependencies

#

HassanAbouelela

[site:bump\-dependencies] 1 new commit

f3b9c75 Increase Request Timeout For GitHub API - HassanAbouelela

odd spireBOT Sep 30, 2022, 6:17 PM

#

[python-discord/site] Checks Successful on PR: #769 Update To 3.10 And Bump Dependencies

GitHub Actions run 3160800882 succeeded.

PR Author

Workflow Run

Lint & Test #1275

Source Branch

bump-dependencies

regal archBOT Sep 30, 2022, 6:35 PM

#

HassanAbouelela

[python-discord/site] Pull request closed: #769 Update To 3\.10 And Bump Dependencies

#

HassanAbouelela

[site:main] 13 new commits

04b1870 Bump & Use Exact Versions For Run Dependencies - HassanAbouelela
6d9c7c0 Bump Coverage - HassanAbouelela
8f6d63c Bump Developer Dependencies - HassanAbouelela
cd815d3 Fix Static Build - HassanAbouelela
9c81614 Upgrade To 3.10 - HassanAbouelela

#

HassanAbouelela

[python-discord/site] branch deleted: bump\-dependencies

#

HassanAbouelela

[python-discord/site] New comment on pull request #774: Bump sentry\-sdk from 1\.9\.8 to 1\.9\.9

As mentioned in #769, sentry 1.9.9 seems to be broken and should not be merged

#

HassanAbouelela

[python-discord/site] Pull request closed: #774 Bump sentry\-sdk from 1\.9\.8 to 1\.9\.9

odd spireBOT Sep 30, 2022, 6:41 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 3160932635 succeeded.

Actor

Workflow Run

Deploy #301

Commit

5692f98

#

[python-discord/site] Checks Successful on PR: #774 Bump sentry-sdk from 1.9.8 to 1.9.9

GitHub Actions run 3160923039 succeeded.

PR Author

Workflow Run

Lint & Test #1277

Source Branch

dependabot/pip/sentry-sdk...

regal archBOT Sep 30, 2022, 6:51 PM

#

mbaruh

[site:new\-filter\-schema] 1 new commit

855ce1e Fix send_alert not being added correctly in ser... - mbaruh

#

mbaruh

[bot:new\-filters] 1 new commit

c813e3f Add filter edit command - mbaruh

regal archBOT Sep 30, 2022, 7:32 PM

#

mbaruh

[bot:new\-filters] 1 new commit

dbb078b Add filter delete command - mbaruh

regal archBOT Sep 30, 2022, 9:52 PM

#

mbaruh

[bot:new\-filters] 8 new commits

4483b7c Voice ban -> voice mute in auto-infractions - mbaruh
72e164c Split actions and validations to their own pack... - mbaruh
7d46b1e Fix tests - mbaruh
5cf4a75 Correct logging - mbaruh
b07e276 Use try-except instead of is_digit in bypass_roles - mbaruh

regal archBOT Oct 1, 2022, 9:10 AM

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2283 1379 tranform urls upon rich embed filter application

Looks good and works well.

regal archBOT Oct 1, 2022, 1:52 PM

#

mbaruh

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

You could do this in one go without sorting with tuples.

#

mbaruh

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

It's not a mistake or anything but I think now - inserted_at > min_time is easier to read. Ignore if you want.

#

mbaruh

[python-discord/bot] Pull request review submitted: #2245 Update autoreview system

A few comments, looks great otherwise.

#

mbaruh

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

I wonder how good this is, since there's a potential starvation here for nominees with only one nomination. What I would do is take both parameters and give each of them a weight to create a total score. It would then review the nominee with the highest score.

Just off the top of my head, we could do something like:
number_of_nominations / number_for_currently_most_nominated + age / age_of_currently_oldest

This could be weighted for example to give the number of nominations more impo...

regal archBOT Oct 1, 2022, 3:05 PM

#

wookie184

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

I'm struggling to picture how such a weighting would act in practice.

If the talentpool is constantly growing, then so will the age of the oldest nomination in it. If the weighting of the next user picked is dependant on the age and number of nomination, then I don't know how you'd avoid the number of nominations required to be picked would also constantly growing.

I'd sort of accepted the starvation as a trade of between having a system that whilst isn't perfect, at least isn't broken....

#

wookie184

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

I picked that off the top of my head thinking something like "3 for people to vote on, and 1 waiting to be actioned", and wanted to avoid slower reviews holding others up, but i'm happy to change it to 3. Can always increase depending on how it works out.

regal archBOT Oct 1, 2022, 4:13 PM

#

mbaruh

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

Yeah just worried the earliest review will get buried or that the team will get saturated with reviews. Thinking about it I would maybe add a cooldown time after resolving a vote too (whether there's helpering or not), so that we don't get pinged right after resolving a vote.

#

mbaruh

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

If the talentpool is constantly growing, then so will the age of the oldest nomination in it. If the weighting of the next user picked is dependant on the age and number of nomination, then I don't know how you'd avoid the number of nominations required to be picked would also constantly growing

That's why I normalized the age by the age of the oldest vote. The contribution is capped at 1, and the older the oldest vote, the less of an effect its aging will have on the score.

Meaning, ...

#

mbaruh

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

And, if a nomination is so old it still dominates the score, then maybe it's time we took a look at it?

regal archBOT Oct 1, 2022, 4:48 PM

#

mbaruh

[site:new\-filter\-schema] 1 new commit

1970a36 Bring back enabled categories - mbaruh

regal archBOT Oct 1, 2022, 7:39 PM

#

mbaruh

[bot:new\-filters] 8 new commits

ff25bd0 Fix patching removed override - mbaruh
37bab91 Fix channel_scope checking IDs and names separa... - mbaruh
fb1af00 Stress that a filter was triggered in DM - mbaruh
fbe3a2e Bring back enabled categories, remove redundant... - mbaruh
39d3a77 Add a warning if an added filter has content id... - mbaruh

regal archBOT Oct 1, 2022, 10:18 PM

#

mbaruh

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

The bottom line is, instead of using the age as a tie breaker, you can use it as a regularization parameter, and strike a balance between popularity and age.

#

mbaruh

[python-discord/bot] New comment on pull request #2245: Update autoreview system

One more thing to consider if we're going to allow automatically starting votes again: We could query metricity to check when is the last message sent by the user. If it's too old the vote won't fare well.

odd spireBOT Oct 1, 2022, 10:21 PM

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 3166383038 succeeded.

Actor

Lint Kubernetes manifests #293

Workflow Run

Commit

631e3f5

#

[python-discord/kubernetes] Checks Successful on PR: #139 Fix Docs Theme Configuration

GitHub Actions run 3166411110 succeeded.

PR Author

Lint Kubernetes manifests #294

Workflow Run

Source Branch

docs-theme

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 3166411864 succeeded.

Actor

Lint Kubernetes manifests #295

Workflow Run

Commit

ee37161

regal archBOT Oct 2, 2022, 8:57 AM

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #1106 TypeError: Client\.wait\_for got some positional\-only arguments passed as keyword arguments: 'event'

Sentry Issue: SIR-LANCEBOT-8M

TypeError: Client.wait_for() got some positional-only arguments passed as keyword arguments: 'event'
  File "discord/ext/commands/core.py", line 190, in wrapped
    ret = await coro(*args, **kwargs)
  File "bot/exts/fun/hangman.py", line 112, in hangman
    message = await self.bot.wait_for(

Unhandled command error: Client.wait_for() got some positional-only arg...

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #1107 TypeError: object of type 'NoneType' has no len

Sentry Issue: SIR-LANCEBOT-8Q

TypeError: object of type 'NoneType' has no len()
  File "discord/ext/commands/core.py", line 190, in wrapped
    ret = await coro(*args, **kwargs)
  File "bot/exts/events/hacktoberfest/hacktober-issue-finder.py", line 49, in hacktoberissues
    embed = self.format_embed(issue)
  File "bot/exts/events/hacktoberfest/hacktober-issue-finder.py", line 108, in format_...

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #1108 AttributeError: 'Select' object has no attribute 'data'

Sentry Issue: SIR-LANCEBOT-8P

AttributeError: 'Select' object has no attribute 'data'
  File "discord/ui/view.py", line 425, in _scheduled_task
    await item.callback(interaction)
  File "bot/exts/utilities/epoch.py", line 124, in select_format
    selected = interaction.data["values"][0]

Ignoring exception in view "" for item "<Select placeholder='Select the format of your timestamp' min_v...

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #1109 HTTPException: 400 Bad Request $error code: 50035$: Invalid Form Body

Sentry Issue: SIR-LANCEBOT-8K

HTTPException: 400 Bad Request (error code: 50035): Invalid Form Body
In embeds: Embed size exceeds maximum size of 6000
(1 additional frame(s) were not displayed)
...
  File "bot/exts/utilities/wolfram.py", line 288, in wolfram_short_command
    await send_embed(ctx, message, color)
  File "bot/exts/utilities/wolfram.py", line 54, in send_embed
    await ctx.sen...

regal archBOT Oct 2, 2022, 12:38 PM

#

Rohith0009

[python-discord/site] Pull request opened: #775 Fixed Spelling and grammar mistakes

Fixed Many Spelling and Grammar mistakes

odd spireBOT Oct 2, 2022, 12:40 PM

#

[python-discord/site] Checks Successful on PR: #775 Fixed Spelling and grammar mistakes

GitHub Actions run 3168619167 succeeded.

PR Author

Rohith0009

Workflow Run

Lint & Test #1278

Source Branch

Rohith0009:main

regal archBOT Oct 2, 2022, 12:56 PM

#

TizzySaurus

[python-discord/site] New comment on pull request #775: Fixed Spelling and grammar mistakes

Does this have a corresponding issue and/or approval?

Also, a fair amount of these changes seem incorrect. E.g. "a permission" was in fact correct, as was "staff" since it doesn't have a plural.

#

TizzySaurus

[sir-lancebot:fix\-issue\-1106] 1 new commit

8deea42 Fix position-only arg. - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: fix\-issue\-1106

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #1110 Fix position\-only arg in hangman command\.

Relevant Issues

Closes #1106.

Description

As the title says. Client.wait_for is now a positional-only arg, so adjusted as such to fix the game (tested and it does now work).

Did you:

[x] Join the Python Discord Community?
-...

#

Rohith0009

[python-discord/site] New comment on pull request #775: Fixed Spelling and grammar mistakes

Also, a fair amount of these changes seem incorrect. E.g. "a permission" was in fact correct, as was "staff" since it doesn't have a plural.

Should I revert it back? I don't think there are a lot of incorrect changes

odd spireBOT Oct 2, 2022, 1:13 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1110 Fix position-only arg in hangman command.

GitHub Actions run 3168709351 succeeded.

PR Author

Workflow Run

Lint #2469

Source Branch

fix-issue-1106

regal archBOT Oct 2, 2022, 1:18 PM

#

TizzySaurus

[sir-lancebot] Branch fix\-issue\-1106 was force-pushed to `c27763e`

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1110 Fix position\-only arg in hangman & madlibs command\.

odd spireBOT Oct 2, 2022, 1:19 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1110 Fix position-only arg in hangman command.

GitHub Actions run 3168730617 succeeded.

PR Author

Workflow Run

Lint #2470

Source Branch

fix-issue-1106

#

[python-discord/site] Checks Successful on PR: #775 Fixed Spelling and grammar mistakes

GitHub Actions run 3168748908 succeeded.

PR Author

Rohith0009

Workflow Run

Lint & Test #1279

Source Branch

Rohith0009:main

regal archBOT Oct 2, 2022, 1:26 PM

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1107: TypeError: object of type 'NoneType' has no len

This appears to be a duplicate of #907, which was fixed in #908. When exactly was this traceback created?

#

HassanAbouelela

[python-discord/site] New comment on pull request #775: Fixed Spelling and grammar mistakes

Hello @Rohith0009, thanks for your PR!

Unfortunately, we do not accept pull requests not accompanied by issues, as outlined in our contribution guides. We also do not usually accept grammar fix PRs like this since they create a lot of conflicts propagated throughout our entire project, with usually minimal benefit.

If you'd like to have a go at one of our other issues, check out the issues tab for issues without the Planning or WIP ta...

#

HassanAbouelela

[python-discord/site] Pull request closed: #775 Fixed Spelling and grammar mistakes

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1108: AttributeError: 'Select' object has no attribute 'data'

This appears to be due to the change dpy made during 2.0 development where the Interaction and Select argument swapped positions. All 3 uses of this decorator need to be updated.

#

TizzySaurus

[sir-lancebot:fix\-GH\-1108] 1 new commit

f2de807 Fix order of function parameters on @discord.ui... - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: fix\-GH\-1108

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #1111 Fix order of function parameters on @discord\.ui\.select

Relevant Issues

Closes #1108.

Description

During development of dpy 2.0, the order of the interaction and select swapped, but this wasn't updated in the codebase. This PR fixes that in the 3 use-cases of the @discord.ui.select decorator.

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[...

odd spireBOT Oct 2, 2022, 1:47 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1111 Fix order of function parameters on @discord.ui.select

GitHub Actions run 3168810823 succeeded.

PR Author

Workflow Run

Lint #2471

Source Branch

fix-GH-1108

regal archBOT Oct 2, 2022, 1:51 PM

#

HassanAbouelela

[python-discord/sir-lancebot] Pull request review submitted: #1111 Fix order of function parameters on @discord\.ui\.select

Looks good, thanks

regal archBOT Oct 2, 2022, 2:08 PM

#

wookie184

[python-discord/bot] New comment on pull request #2245: Update autoreview system

One more thing to consider if we're going to allow automatically starting votes again: We could query metricity to check when the last message sent by the user is. If it's too old the vote won't fare well.

Yeah, that was part of the original specification in the issue. I still plan on adding that at some point, but I wanted to try and limit the scope for this PR so didn't do it here.

#

wookie184

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

Alright, I'm still not convinced that it's really necessary, but i'll try something.

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1107: TypeError: object of type 'NoneType' has no len

It's a new(ly found?) problem. The issue is that the body is null in the JSON, rather than not existing at all.

Example that caused the error: https://api.github.com/repos/Ank221199/WorkoutGenerator/issues/14

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1107: TypeError: object of type 'NoneType' has no len

It's a new(ly found?) problem. The issue is that the body is null in the JSON, rather than not existing at all.

Example that caused the error: https://api.github.com/repos/Ank221199/WorkoutGenerator/issues/14

I see. So dict.get("body") or "" should work?

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1107: TypeError: object of type 'NoneType' has no len

Yeah

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1110 Fix position\-only arg in hangman & madlibs command\.

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1110 Fix position\-only arg in hangman & madlibs command\.

#

wookie184

[python-discord/sir-lancebot] branch deleted: fix\-issue\-1106

#

wookie184

[sir-lancebot:main] 3 new commits

a617f5c Fix position-only arg in hangman.py - TizzySaurus
c27763e Fix position-only arg in madlibs.py - TizzySaurus
4a13e3a Merge pull request #1110 from python-discord/fi... - wookie184

#

wookie184

[python-discord/sir-lancebot] Issue closed: #1106 TypeError: Client\.wait\_for got some positional\-only arguments passed as keyword arguments: 'event'

night lilyBOT Oct 2, 2022, 2:28 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 2, 2022, 2:28 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3168935560 succeeded.

Actor

Workflow Run

Build #604

Commit

4a13e3a

regal archBOT Oct 2, 2022, 2:32 PM

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #1111: Fix order of function parameters on @discord\.ui\.select

Is Button still meant to come before Interaction?

#

TizzySaurus

[sir-lancebot:fix\-issue\-1107] 1 new commit

5f5523f Correct logic in format_embed. - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: fix\-issue\-1107

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #1112 Fix hacktoberfest\-issues bug

Relevant Issues

Closes #1107.

Description

As described in the issue, the value of the body key returned by the API can be a literal null value, meaning dict.get("body", "") won't substitute as the key does exist. Instead, we now use dict.get("body") or "".

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments...

odd spireBOT Oct 2, 2022, 2:39 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1112 Fix hacktoberfest-issues bug

GitHub Actions run 3168969152 succeeded.

PR Author

Workflow Run

Lint #2473

Source Branch

fix-issue-1107

regal archBOT Oct 2, 2022, 2:42 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1112 Fix hacktoberfest\-issues bug

LGTM, thanks

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #1111: Fix order of function parameters on @discord\.ui\.select

Good catch. This needs to be swapped, alongside the other uses of @discord.ui.button.

#

TizzySaurus

[sir-lancebot:fix\-GH\-1108] 1 new commit

3943d27 Fix order of function parameters on @discord.ui... - TizzySaurus

odd spireBOT Oct 2, 2022, 2:52 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1111 Fix order of function parameters on @discord.ui.select

GitHub Actions run 3169005313 succeeded.

PR Author

Workflow Run

Lint #2474

Source Branch

fix-GH-1108

regal archBOT Oct 2, 2022, 2:53 PM

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #1111: Fix order of function parameters on @discord\.ui\.select

Fixed :+1:

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #1111: Fix order of function parameters on @discord\.ui\.select

Extra space that shouldn't be there on the - interaction: line

#

TizzySaurus

[sir-lancebot:fix\-GH\-1108] 1 new commit

f72b949 Remove extra space. - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #1111: Fix order of function parameters on @discord\.ui\.select

Yep, fixed :+1:

odd spireBOT Oct 2, 2022, 2:58 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1111 Fix order of function parameters on @discord.ui.select

GitHub Actions run 3169025598 succeeded.

PR Author

Workflow Run

Lint #2475

Source Branch

fix-GH-1108

regal archBOT Oct 2, 2022, 2:59 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1111 Fix order of function parameters on @discord\.ui\.select

Thanks!

#

wookie184

[sir-lancebot:fix\-GH\-1108] 4 new commits

a617f5c Fix position-only arg in hangman.py - TizzySaurus
c27763e Fix position-only arg in madlibs.py - TizzySaurus
4a13e3a Merge pull request #1110 from python-discord/fi... - wookie184
0b240f2 Merge branch 'main' into fix-GH-1108 - wookie184

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1111 Fix order of function parameters on @discord\.ui\.select

#

wookie184

[python-discord/sir-lancebot] branch deleted: fix\-GH\-1108

#

wookie184

[sir-lancebot:main] 5 new commits

f2de807 Fix order of function parameters on @discord.ui... - TizzySaurus
3943d27 Fix order of function parameters on @discord.ui... - TizzySaurus
f72b949 Remove extra space. - TizzySaurus
0b240f2 Merge branch 'main' into fix-GH-1108 - wookie184
143bea4 Merge pull request #1111 from python-discord/fi... - wookie184

#

wookie184

[python-discord/sir-lancebot] Issue closed: #1108 AttributeError: 'Select' object has no attribute 'data'

odd spireBOT Oct 2, 2022, 3:01 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1111 Fix order of function parameters on @discord.ui.select

GitHub Actions run 3169031706 succeeded.

PR Author

Workflow Run

Lint #2476

Source Branch

fix-GH-1108

night lilyBOT Oct 2, 2022, 3:03 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 2, 2022, 3:03 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3169038408 succeeded.

Actor

Workflow Run

Build #605

Commit

143bea4

odd spireBOT Oct 2, 2022, 4:15 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1112 Fix hacktoberfest-issues bug

GitHub Actions run 3169253171 succeeded.

PR Author

Workflow Run

Lint #2478

Source Branch

fix-issue-1107

night lilyBOT Oct 2, 2022, 4:16 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 2, 2022, 4:17 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3169257519 succeeded.

Actor

Workflow Run

Build #606

Commit

fb3cae9

regal archBOT Oct 2, 2022, 5:34 PM

#

ChrisLovering

[bot] Branch move\-filter\-alerts was force-pushed to `f2d05d5`

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2267: Improve reporting on autoban filter lists

Updated the docstring in f2d05d5 (#2267). There is a cog wide check which ensures commands are only ran in mod channel (which is why we can't modify filters elsewhere)

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2267: Improve reporting on autoban filter lists

Hah, technically autobans can be added to allow lists, which in itself seems wrong.

#

ChrisLovering

[python-discord/bot] New comment on pull request #2267: Improve reporting on autoban filter lists

Rebased onto main (hence the forcepush)

odd spireBOT Oct 2, 2022, 5:37 PM

#

[python-discord/bot] Checks Successful on PR: #2267 Improve reporting on autoban filter lists

GitHub Actions run 3169465894 succeeded.

PR Author

Workflow Run

Lint & Test #3193

Source Branch

move-filter-alerts

regal archBOT Oct 2, 2022, 7:07 PM

#

vivekashok1221

[python-discord/bot] New review comment on pull request #2267: Improve reporting on autoban filter lists

The check only prevents non-mods from running the command as far as I can see, it doesn't impose any channel restriction.

#

ChrisLovering

[bot:move\-filter\-alerts] 1 new commit

2142d82 Make autoban report silently fail if output wil... - ChrisLovering

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2267: Improve reporting on autoban filter lists

Good point, 2142d82 (#2267)

odd spireBOT Oct 2, 2022, 7:22 PM

#

[python-discord/bot] Checks Successful on PR: #2267 Improve reporting on autoban filter lists

GitHub Actions run 3169786165 succeeded.

PR Author

Workflow Run

Lint & Test #3194

Source Branch

move-filter-alerts

regal archBOT Oct 2, 2022, 7:32 PM

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #1917 Patreon

Approving as my only comment won't affect us atm, so I'll leave it to you to decide whether to action it before merging.

#

ChrisLovering

[python-discord/bot] New review comment on pull request #1917: Patreon

If this list is empty, imo the embed should contain something like "No patrons in this tier" as opposed to being something like this:

regal archBOT Oct 2, 2022, 7:54 PM

#

vivekashok1221

[python-discord/bot] New review comment on pull request #2267: Improve reporting on autoban filter lists

True.

But you know what, we can leave this part as it is so that we can identify if an autoban is added to an allow-list.
It might be better to add a check to not allow autoban to be added to an allow-list in the first place but after a quick glance I don't think the bot will autoban based on allow list.
It is possible that a mod might accidentally add a filter to the allow list instead of blacklist and the report will help identify such cases (assuming we miss the original plain message...

regal archBOT Oct 3, 2022, 8:11 AM

#

vivekashok1221

[python-discord/bot] Pull request review submitted: #2267 Improve reporting on autoban filter lists

LGTM :star2:

#

ChrisLovering

[python-discord/bot] Pull request closed: #2267 Improve reporting on autoban filter lists

#

ChrisLovering

[python-discord/bot] branch deleted: move\-filter\-alerts

#

ChrisLovering

[bot:main] 6 new commits

4697076 Send filter alerts to #filter-log instead of #m... - ChrisLovering
fe86fb9 Namespace discord import in filter_lists - ChrisLovering
4f56106 Report on all autoban filters added in the last... - ChrisLovering
f2d05d5 Send weekly_autoban_report to ctx channel when ... - ChrisLovering
2142d82 Make autoban report silently fail if output wil... - ChrisLovering

oak estuaryBOT Oct 3, 2022, 8:29 AM

#

Python Bot

Connected!

odd spireBOT Oct 3, 2022, 8:29 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3172685880 succeeded.

Actor

Workflow Run

Deploy #723

Commit

1acaf6f

odd spireBOT Oct 3, 2022, 10:05 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1113 Bump rapidfuzz from 2.10.2 to 2.11.0

GitHub Actions run 3173269627 succeeded.

PR Author

Workflow Run

Lint #2480

Source Branch

dependabot/pip/rapidfuzz-2.11.0

regal archBOT Oct 3, 2022, 3:47 PM

#

shtlrs

[python-discord/bot] Pull request opened: #2284 Fix all non\-awaited bot\.remove\_cog calls

closes #2281

We currently have some instances of the bot.remove_cog async function that is not awaited.
This PR updates all those calls to be awaited

odd spireBOT Oct 3, 2022, 3:50 PM

#

[python-discord/bot] Checks Successful on PR: #2284 Fix all non-awaited bot.remove_cog calls

GitHub Actions run 3175527516 succeeded.

PR Author

Workflow Run

Lint & Test #3196

Source Branch

shtlrs:2281-fix-non-awaited-remove...

regal archBOT Oct 3, 2022, 5:26 PM

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2284 Fix all non\-awaited bot\.remove\_cog calls

odd spireBOT Oct 3, 2022, 9:16 PM

#

[python-discord/forms-backend] Checks Successful on PR: #215 Bump sentry-sdk from 1.9.3 to 1.9.10

GitHub Actions run 3177537390 succeeded.

PR Author

Workflow Run

Forms Backend #593

Source Branch

dependabot/pip/sentry-sd...

odd spireBOT Oct 4, 2022, 5:05 AM

#

[python-discord/site] Checks Successful on PR: #776 Bump sentry-sdk from 1.9.8 to 1.9.10

GitHub Actions run 3179539043 succeeded.

PR Author

Workflow Run

Lint & Test #1280

Source Branch

dependabot/pip/sentry-sdk...

odd spireBOT Oct 4, 2022, 10:31 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1114 Bump rapidfuzz from 2.10.2 to 2.11.1

GitHub Actions run 3181371461 succeeded.

PR Author

Workflow Run

Lint #2481

Source Branch

dependabot/pip/rapidfuzz-2.11.1

#

[python-discord/sir-lancebot] Checks Successful on PR: #1115 Bump sentry-sdk from 1.9.9 to 1.9.10

GitHub Actions run 3181379923 succeeded.

PR Author

Workflow Run

Lint #2482

Source Branch

dependabot/pip/sentry-sdk-1.9.10

regal archBOT Oct 4, 2022, 5:42 PM

#

Keyacom

[python-discord/bot] Pull request opened: #2285 Add slicing tag

This file adds a tag with an explanation on sequence slicing.

odd spireBOT Oct 4, 2022, 5:46 PM

#

[python-discord/bot] Checks Successful on PR: #2285 Add slicing tag

GitHub Actions run 3184258896 succeeded.

PR Author

Keyacom

Workflow Run

Lint & Test #3197

Source Branch

Keyacom:Keyacom-patch-1

regal archBOT Oct 4, 2022, 7:51 PM

#

HassanAbouelela

[python-discord/bot] New comment on pull request #2285: Add slicing tag

Hello, thanks for writing this up! Is there an issue for this tag?

regal archBOT Oct 4, 2022, 10:35 PM

#

Keyacom

[python-discord/bot] New comment on pull request #2285: Add slicing tag

I wrote this because after I helped a person in a help channel, I thought that it would be useful to write a slice syntax tag, even if there is no such issue about it in python-discord/meta.

The conversation:

The message where I mentioned the slice syntax (link):
#help-lemon message

#

HassanAbouelela

[python-discord/bot] New comment on pull request #2285: Add slicing tag

Alright, for now you can keep this PR open, but please open an issue on the meta repository detailing what it is you think should be added and why. Linking to this PR is a good idea to explain the what.

regal archBOT Oct 4, 2022, 11:42 PM

#

ddjerqq

[python-discord/bot] New comment on issue #2257: HTTPException: 400 Bad Request $error code: 50035$: Invalid Form Body

i can fix this, assign me to it if this is still relevant

odd spireBOT Oct 5, 2022, 5:20 AM

#

[python-discord/site] Checks Successful on PR: #777 Bump django from 4.1.1 to 4.1.2

GitHub Actions run 3187470177 succeeded.

PR Author

Workflow Run

Lint & Test #1281

Source Branch

dependabot/pip/django-4.1.2

regal archBOT Oct 5, 2022, 5:27 PM

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1115 Bump sentry\-sdk from 1\.9\.9 to 1\.9\.10

#

wookie184

[sir-lancebot:main] 2 new commits

a8b8dab Bump sentry-sdk from 1.9.9 to 1.9.10 - dependabot[bot]
87dc616 Merge pull request #1115 from python-discord/de... - wookie184

#

wookie184

[python-discord/bot] New comment on issue #2257: HTTPException: 400 Bad Request $error code: 50035$: Invalid Form Body

i can fix this, assign me to it if this is still relevant

Hi, I've assigned you 👍

odd spireBOT Oct 5, 2022, 5:32 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1114 Bump rapidfuzz from 2.10.2 to 2.11.1

GitHub Actions run 3191431407 succeeded.

PR Author

Workflow Run

Lint #2484

Source Branch

dependabot/pip/rapidfuzz-2.11.1

night lilyBOT Oct 5, 2022, 5:32 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 5, 2022, 5:33 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3191434163 succeeded.

Actor

Workflow Run

Build #607

Commit

87dc616

regal archBOT Oct 5, 2022, 5:33 PM

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1114 Bump rapidfuzz from 2\.10\.2 to 2\.11\.1

#

wookie184

[sir-lancebot:main] 2 new commits

d8101f5 Bump rapidfuzz from 2.10.2 to 2.11.1 - dependabot[bot]
a7eccc0 Merge pull request #1114 from python-discord/de... - wookie184

night lilyBOT Oct 5, 2022, 5:37 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 5, 2022, 5:38 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3191460340 succeeded.

Actor

Workflow Run

Build #608

Commit

a7eccc0

regal archBOT Oct 5, 2022, 5:45 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #2284 Fix all non\-awaited bot\.remove\_cog calls

Thanks :)

#

wookie184

[python-discord/bot] Pull request closed: #2284 Fix all non\-awaited bot\.remove\_cog calls

#

wookie184

[bot:main] 3 new commits

452da1a await unawaited remove_cog calls - Amrou Bellalouna
ff5dd52 Merge branch 'main' into 2281-fix-non-awaited-r... - wookie184
5752acc Merge pull request #2284 from shtlrs/2281-fix-n... - wookie184

#

wookie184

[python-discord/bot] Issue closed: #2281 Async function remove\_cog not awaited

odd spireBOT Oct 5, 2022, 5:48 PM

#

[python-discord/bot] Checks Successful on PR: #2284 Fix all non-awaited bot.remove_cog calls

GitHub Actions run 3191525595 succeeded.

PR Author

Workflow Run

Lint & Test #3198

Source Branch

shtlrs:2281-fix-non-awaited-remove...

oak estuaryBOT Oct 5, 2022, 5:54 PM

#

Python Bot

Connected!

odd spireBOT Oct 5, 2022, 5:54 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3191573813 succeeded.

Actor

Workflow Run

Deploy #724

Commit

5752acc

odd spireBOT Oct 5, 2022, 6:14 PM

#

[python-discord/bot] Checks Successful on PR: #1917 Patreon

GitHub Actions run 3191679604 succeeded.

PR Author

mathstrains21

Workflow Run

Lint & Test #3200

Source Branch

mathstrains21:patreon

regal archBOT Oct 5, 2022, 6:16 PM

#

wookie184

[python-discord/bot] New review comment on pull request #1917: Patreon

That makes sense, done 👍

#

wookie184

[python-discord/bot] New comment on pull request #1917: Patreon

I've also taken the liberty of adding the 3 patreon roles to the test server and updating the config.yml in notion.

Thanks, I definitely did not forget those were things that would need to be done :P

odd spireBOT Oct 5, 2022, 6:19 PM

#

[python-discord/bot] Checks Successful on PR: #1917 Patreon

GitHub Actions run 3191709667 succeeded.

PR Author

mathstrains21

Workflow Run

Lint & Test #3201

Source Branch

mathstrains21:patreon

regal archBOT Oct 5, 2022, 6:19 PM

#

wookie184

[python-discord/bot] Pull request closed: #1917 Patreon

#

wookie184

[python-discord/bot] Issue closed: #1765 Shoutout our patreon supporters\!

#

wookie184

[bot:main] 42 new commits

6ca77ac Add patreon role configuration - mathstrains21
a44e798 Create patreon.py and add setup - mathstrains21
526ce5f Merge branch 'python-discord:main' into patreon - mathstrains21
380dd5c Add patron message when someone gains a patron ... - mathstrains21
b38ec72 Merge branch 'patreon' of https://github.com/ma... - mathstrains21

oak estuaryBOT Oct 5, 2022, 6:24 PM

#

Python Bot

Connected!

odd spireBOT Oct 5, 2022, 6:24 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3191758727 succeeded.

Actor

Workflow Run

Deploy #725

Commit

5ab04a8

regal archBOT Oct 6, 2022, 6:48 AM

#

wookie184

[python-discord/site] Pull request closed: #776 Bump sentry\-sdk from 1\.9\.8 to 1\.9\.10

#

wookie184

[site:main] 2 new commits

d5882e8 Bump sentry-sdk from 1.9.8 to 1.9.10 - dependabot[bot]
63e040a Merge pull request #776 from python-discord/dep... - wookie184

odd spireBOT Oct 6, 2022, 6:53 AM

#

[python-discord/site] Checks Successful on PR: #777 Bump django from 4.1.1 to 4.1.2

GitHub Actions run 3195111509 succeeded.

PR Author

Workflow Run

Lint & Test #1283

Source Branch

dependabot/pip/django-4.1.2

#

[python-discord/site] Workflow Successful

GitHub Actions run 3195128357 succeeded.

Actor

Workflow Run

Deploy #304

Commit

63e040a

regal archBOT Oct 6, 2022, 1:26 PM

#

ddjerqq

[python-discord/bot] Pull request opened: #2286 \#2257 the title in help commands is too large\.

trimmed title in send_error_message. the title will be 256 characters at most now.

odd spireBOT Oct 6, 2022, 1:28 PM

#

[python-discord/bot] Checks Successful on PR: #2286 #2257 the title in help commands is too large.

GitHub Actions run 3197543337 succeeded.

PR Author

ddjerqq

Workflow Run

Lint & Test #3203

Source Branch

ddjerqq:feature/2257/trim-title-h...

regal archBOT Oct 6, 2022, 3:09 PM

#

CaedenPH

[python-discord/bot] Pull request review submitted: #2286 \#2257 the title in help commands is too large\.

Perhaps there is a better way to format this instead of just completely cutting off anything after 256 characters. Does anyone have any ideas?

#

CaedenPH

[python-discord/bot] New review comment on pull request #2286: \#2257 the title in help commands is too large\.

        embed = Embed(colour=Colour.red(), title=str(error)[:256])

Do you mean this? Otherwise its going to cut off the first 256 characters and include whatever is after that

regal archBOT Oct 6, 2022, 3:33 PM

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2286: \#2257 the title in help commands is too large\.

textwrap.shorten(error, width=100, placeholder="...")

odd spireBOT Oct 6, 2022, 3:42 PM

#

[python-discord/bot] Checks Successful on PR: #2286 #2257 the title in help commands is too large.

GitHub Actions run 3198525810 succeeded.

PR Author

ddjerqq

Workflow Run

Lint & Test #3204

Source Branch

ddjerqq:feature/2257/trim-title-h...

odd spireBOT Oct 6, 2022, 5:29 PM

#

[python-discord/king-arthur] Checks Successful on PR: #26 build(deps): bump tabulate from 0.8.10 to 0.9.0

GitHub Actions run 3199185194 succeeded.

PR Author

Lint, Build & Deploy #126

Workflow Run

Source Branch

dependabot/pip/ta...

regal archBOT Oct 6, 2022, 6:07 PM

#

mathstrains21

[python-discord/bot] New comment on pull request #1917: Patreon

Thanks @wookie184 for finishing this off for me!

regal archBOT Oct 6, 2022, 9:26 PM

#

thatbirdguythatuknownot

[python-discord/sir-lancebot] Issue opened: #1116 Add a bat reaction for Halloween

Description

Proposing to add a spooky reaction with the bat emoji to any message that has bat in it.

Reasoning

It's October, and currently there are only 4 emojis that are the result of a few key words. Maybe it's time to add a little more?

Proposed Implementation

Add a new entry to the SPOOKY_TRIGGERS dictionary in bot/exts/holidays/halloween/spookyreact.py. Unicode for bat emoji is \U0001F987.

Would you like to implement this yourself?

[x] I'd li...

odd spireBOT Oct 7, 2022, 5:21 AM

#

[python-discord/site] Checks Successful on PR: #778 Bump psycopg2-binary from 2.9.3 to 2.9.4

GitHub Actions run 3202425845 succeeded.

PR Author

Workflow Run

Lint & Test #1284

Source Branch

dependabot/pip/psycopg2-b...

regal archBOT Oct 7, 2022, 6:50 AM

#

Akarys42

[python-discord/modmail-plugins] Pull request opened: #26 Make all setup functions async

This is required with the new modmail release. You may want to double-check check it is compatible with the version of the bot you are currently running, and if not wait to merge it.

regal archBOT Oct 7, 2022, 7:34 AM

#

HassanAbouelela

[modmail-plugins:poetry\-1\.2] 1 new commit

2e2049b Switch To HassanAbouelela/setup-python Action - HassanAbouelela

#

HassanAbouelela

[python-discord/modmail-plugins] New branch created: poetry\-1\.2

#

HassanAbouelela

[python-discord/modmail-plugins] Pull request opened: #27 Fix CI For Poetry 1\.2

#

HassanAbouelela

[python-discord/modmail-plugins] Pull request closed: #27 Fix CI For Poetry 1\.2

#

HassanAbouelela

[modmail-plugins:main] 2 new commits

2e2049b Switch To HassanAbouelela/setup-python Action - HassanAbouelela
d20dfc6 Merge pull request #27 from python-discord/poet... - HassanAbouelela

#

HassanAbouelela

[python-discord/modmail-plugins] branch deleted: poetry\-1\.2

#

ChrisLovering

[modmail:master] 179 new commits

2682d58 oops - fourjr
e311828 Improved UI for group conversations, LOG_DISCOR... - fourjr
6431ab0 Fix typo in config_help - fourjr
fc156f9 Fix syntax - fourjr
68827f7 Fix ?contact command bug where the channel is... - Jerrie-Aries

#

ChrisLovering

[modmail:development] 50 new commits

3d494bb Add phish checker plugin - TheDiscordHistorian
6c481b4 Merge pull request #3113 from TheDiscordHistori... - Taaku18
b02934d Added sponsor - Taaku18
80dafca Update SPONSORS.json - Taaku18
a1aacbf Update bandit baseline: - fourjr

regal archBOT Oct 7, 2022, 1:14 PM

#

mbaruh

[site:new\-filter\-schema] 97 new commits

149e67b Remove IP From Compose Ports - HassanAbouelela
98fa159 Run Migrations For Tests - HassanAbouelela
fe4def7 Add GitHub Artifact API View - HassanAbouelela
0404e00 Update Netlify Build Script - HassanAbouelela
26a3c19 Make Awaiting Workflow Run A User Responsibility - HassanAbouelela

regal archBOT Oct 7, 2022, 1:51 PM

#

mbaruh

[site:new\-filter\-schema] 1 new commit

862d001 Properly add dm_embed to serializers - mbaruh

regal archBOT Oct 7, 2022, 2:41 PM

#

mbaruh

[python-discord/bot] New comment on issue #1276: Filtering \- New blacklist type that catch all subdomains of domain

The current system already filters subdomains, might be a by-product of one of the PRs. Going to close this for now.

#

mbaruh

[python-discord/bot] Issue closed: #1276 Filtering \- New blacklist type that catch all subdomains of domain

odd spireBOT Oct 7, 2022, 4:51 PM

#

[python-discord/king-arthur] Checks Successful on PR: #28 build(deps-dev): bump black from 22.6.0 to 22.10.0

GitHub Actions run 3206349441 succeeded.

PR Author

Lint, Build & Deploy #128

Workflow Run

Source Branch

dependabot/pip/bl...

regal archBOT Oct 7, 2022, 6:44 PM

#

gustavwilliam

[branding:swoopy\-logo] 1 new commit

39b141e Add swoopy logo to standard rotation - gustavwilliam

#

gustavwilliam

[python-discord/branding] New branch created: swoopy\-logo

#

gustavwilliam

[branding] Branch swoopy\-logo was force-pushed to `77e10b6`

#

gustavwilliam

[python-discord/branding] Pull request opened: #191 Add swoopy logo to evergreen logo rotation

Adds the "swoopy logo" to the evergreen logo rotation. The logo has been in the branding repo for a long time, but wasn't available after a new branding manager was implemented.

odd spireBOT Oct 7, 2022, 6:49 PM

#

[python-discord/branding] Checks Successful on PR: #191 Add swoopy logo to evergreen logo rotation

GitHub Actions run 3206965832 succeeded.

PR Author

gustavwilliam

Workflow Run

Event Validation #107

Source Branch

swoopy-logo

regal archBOT Oct 7, 2022, 7:01 PM

#

wookie184

[python-discord/branding] Pull request review submitted: #191 Add swoopy logo to evergreen logo rotation

Nice, good find.

#

wookie184

[python-discord/branding] Pull request closed: #191 Add swoopy logo to evergreen logo rotation

#

wookie184

[branding:main] 2 new commits

77e10b6 Add swoopy logo to standard rotation - gustavwilliam
3fbc1d8 Merge pull request #191 from python-discord/swo... - wookie184

#

wookie184

[python-discord/branding] branch deleted: swoopy\-logo

odd spireBOT Oct 7, 2022, 7:02 PM

#

[python-discord/branding] Workflow Successful

GitHub Actions run 3207034002 succeeded.

Actor

Workflow Run

Event Validation #108

Commit

3fbc1d8

odd spireBOT Oct 7, 2022, 7:52 PM

#

[python-discord/king-arthur] Checks Successful on PR: #27 Add devops rules command

GitHub Actions run 3207286391 succeeded.

PR Author

Lint, Build & Deploy #131

Workflow Run

Source Branch

devops-rukes

regal archBOT Oct 7, 2022, 8:00 PM

#

ChrisLovering

[king-arthur] Branch devops\-rukes was force-pushed to `4716123`

#

HassanAbouelela

[python-discord/king-arthur] New review comment on pull request #27: Add devops rules command

Let's skip this is the token isn't set. To support that, you'd need to give the token a default sentinel value in constants such as None.

#

HassanAbouelela

[python-discord/king-arthur] Pull request review submitted: #27 Add devops rules command

#

HassanAbouelela

[python-discord/king-arthur] Pull request review dismissed: #27 Add devops rules command

odd spireBOT Oct 7, 2022, 8:02 PM

#

[python-discord/king-arthur] Checks Successful on PR: #27 Add devops rules command

GitHub Actions run 3207336717 succeeded.

PR Author

Lint, Build & Deploy #132

Workflow Run

Source Branch

devops-rukes

regal archBOT Oct 7, 2022, 8:04 PM

#

ChrisLovering

[king-arthur:devops\-rukes] 1 new commit

731bafb Don't load devops rules if notion api key isn't... - ChrisLovering

#

ChrisLovering

[python-discord/king-arthur] New review comment on pull request #27: Add devops rules command

731bafb (#27)

odd spireBOT Oct 7, 2022, 8:13 PM

#

[python-discord/king-arthur] Checks Cancelled on PR: #27 Add devops rules command

GitHub Actions run 3207396579 was cancelled.

PR Author

Lint, Build & Deploy #134

Workflow Run

Source Branch

devops-rukes

regal archBOT Oct 7, 2022, 8:13 PM

#

ChrisLovering

[king-arthur] Branch devops\-rukes was force-pushed to `d475961`

odd spireBOT Oct 7, 2022, 8:13 PM

#

[python-discord/king-arthur] Checks Successful on PR: #27 Add devops rules command

GitHub Actions run 3207400087 succeeded.

PR Author

Lint, Build & Deploy #135

Workflow Run

Source Branch

devops-rukes

#

[python-discord/king-arthur] Checks Successful on PR: #27 Add devops rules command

GitHub Actions run 3207406520 succeeded.

PR Author

Lint, Build & Deploy #136

Workflow Run

Source Branch

devops-rukes

regal archBOT Oct 7, 2022, 8:42 PM

#

HassanAbouelela

[python-discord/king-arthur] Pull request review submitted: #27 Add devops rules command

It works well, and the implementation is really clean. This is nice. If you want to fix invalid indices before merging, feel free to.

#

ChrisLovering

[king-arthur:devops\-rukes] 1 new commit

68ec38d Return error if no devops rule match searched i... - ChrisLovering

#

ChrisLovering

[python-discord/king-arthur] Pull request closed: #27 Add devops rules command

#

ChrisLovering

[python-discord/king-arthur] branch deleted: devops\-rukes

#

ChrisLovering

[king-arthur:main] 4 new commits

4716123 Add devops rules command - ChrisLovering
d475961 Don't load devops rules if notion api key isn't... - ChrisLovering
68ec38d Return error if no devops rule match searched i... - ChrisLovering
fc47214 Merge pull request #27 from python-discord/devo... - ChrisLovering

odd spireBOT Oct 7, 2022, 8:49 PM

#

[python-discord/king-arthur] Checks Successful on PR: #27 Add devops rules command

GitHub Actions run 3207592612 succeeded.

PR Author

Lint, Build & Deploy #137

Workflow Run

Source Branch

devops-rukes

#

[python-discord/king-arthur] Workflow Successful

GitHub Actions run 3207596306 succeeded.

Actor

Lint, Build & Deploy #138

Workflow Run

Commit

fc47214

regal archBOT Oct 7, 2022, 9:27 PM

#

mbaruh

[python-discord/site] Pull request review submitted: #744 Add info about working with snekbox 3\.11 and metricity on bot

#

mbaruh

[site:snekbox\-311\-and\-metricity] 84 new commits

149e67b Remove IP From Compose Ports - HassanAbouelela
98fa159 Run Migrations For Tests - HassanAbouelela
fe4def7 Add GitHub Artifact API View - HassanAbouelela
0404e00 Update Netlify Build Script - HassanAbouelela
26a3c19 Make Awaiting Workflow Run A User Responsibility - HassanAbouelela

odd spireBOT Oct 7, 2022, 9:30 PM

#

[python-discord/site] Checks Successful on PR: #744 Add info about working with snekbox 3.11 and metricity on bot

GitHub Actions run 3207782726 succeeded.

PR Author

Workflow Run

Lint & Test #1285

Source Branch

snekbox-311-and-metricity

regal archBOT Oct 7, 2022, 9:30 PM

#

ChrisLovering

[site] Branch snekbox\-311\-and\-metricity was force-pushed to `5377fc1`

odd spireBOT Oct 7, 2022, 9:33 PM

#

[python-discord/site] Checks Successful on PR: #744 Add info about working with snekbox 3.11 and metricity on bot

GitHub Actions run 3207794823 succeeded.

PR Author

Workflow Run

Lint & Test #1286

Source Branch

snekbox-311-and-metricity

regal archBOT Oct 7, 2022, 9:34 PM

#

mbaruh

[python-discord/site] Pull request closed: #744 Add info about working with snekbox 3\.11 and metricity on bot

#

mbaruh

[site:main] 2 new commits

5377fc1 Add info about working with snekbox 3.11 on bot - ChrisLovering
c33e559 Merge pull request #744 from python-discord/sne... - mbaruh

#

mbaruh

[python-discord/site] branch deleted: snekbox\-311\-and\-metricity

odd spireBOT Oct 7, 2022, 9:39 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 3207825544 succeeded.

Actor

Workflow Run

Deploy #305

Commit

c33e559

regal archBOT Oct 7, 2022, 10:19 PM

#

mbaruh

[site:new\-filter\-schema] 1 new commit

e5d655a Add infraction channel setting - mbaruh

regal archBOT Oct 8, 2022, 9:07 AM

#

mbaruh

[site:new\-filter\-schema] 2 new commits

e23fcc3 Fix categories validation - mbaruh
88a2be8 Allow ping arrays to be empty - mbaruh

regal archBOT Oct 8, 2022, 12:44 PM

#

mbaruh

[site:new\-filter\-schema] 1 new commit

09375fc Allow char fields to be blank - mbaruh

#

mbaruh

[bot:new\-filters] 9 new commits

f91963f Add filter content processing before posting/pa... - mbaruh
6db78fa Fix bug with setting domain to notify - mbaruh
f12cc72 domain/exact -> domain/subdomains - mbaruh
7e227f6 Make auto-infraction actually work - mbaruh
19a660f Add more spacing in mod alert - mbaruh

regal archBOT Oct 8, 2022, 5:34 PM

#

gustavwilliam

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

This has been inactive for a while so I'll put it up for grabs.

What's left to do? Addressing your comment and fixing the merge conflict?

regal archBOT Oct 8, 2022, 6:01 PM

#

jakubhajek91

[python-discord/king-arthur] New star added

regal archBOT Oct 8, 2022, 7:52 PM

#

mbaruh

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

This has been inactive for a while so I'll put it up for grabs.

What's left to do? Addressing your comment and fixing the merge conflict?

Yeah, merge main, match the output embed to the existing one, and fix the bug

regal archBOT Oct 8, 2022, 9:51 PM

#

mbaruh

[bot:new\-filters] 1 new commit

67bb6b8 Add filter template option - mbaruh

regal archBOT Oct 9, 2022, 5:20 AM

#

onerandomusername

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

As far as I can tell the mfa code is no longer necessary as discord doesn't have mfa tokens like that now.

#

onerandomusername

[python-discord/bot] New comment on issue #1421: MFA User Token filter

Seems like this no longer exists. Users with MFA have the same style tokens as any other.

#

onerandomusername

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

There's also a bit of the matter that this regex is now out of date.

odd spireBOT Oct 9, 2022, 5:26 AM

#

[python-discord/bot] Checks Cancelled on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3212996146 was cancelled.

PR Author

Workflow Run

Lint & Test #3205

Source Branch

onerandomusername:enhan...

#

[python-discord/bot] Checks Cancelled on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3212996458 was cancelled.

PR Author

Workflow Run

Lint & Test #3206

Source Branch

onerandomusername:enhan...

#

[python-discord/bot] Checks Cancelled on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3213002119 was cancelled.

PR Author

Workflow Run

Lint & Test #3207

Source Branch

onerandomusername:enhan...

#

[python-discord/bot] Checks Cancelled on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3213003326 was cancelled.

PR Author

Workflow Run

Lint & Test #3208

Source Branch

onerandomusername:enhan...

#

[python-discord/bot] Checks Successful on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3213008009 succeeded.

PR Author

Workflow Run

Lint & Test #3209

Source Branch

onerandomusername:enhan...

regal archBOT Oct 9, 2022, 11:19 AM

#

wookie184

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

There's also a bit of the matter that this regex is now out of date. I don't know what the current token length is.

I can't recall any problems with false positives, even with the current regex, so we can afford to be very general with what we match. Could just check that the first and last parts are >= 10 and middle is >= 5 characters in length or something.

regal archBOT Oct 9, 2022, 4:50 PM

#

wookie184

[bot:update\-autoreview\-system] 3 new commits

35debe6 Move tests out of moderation/ directory - wookie184
8e15ff4 Use scoring system that weights age and number ... - wookie184
73c1541 Make changes requested in review - wookie184

odd spireBOT Oct 9, 2022, 4:53 PM

#

[python-discord/bot] Checks Successful on PR: #2245 Update autoreview system

GitHub Actions run 3214849562 succeeded.

PR Author

Workflow Run

Lint & Test #3210

Source Branch

update-autoreview-system

regal archBOT Oct 9, 2022, 6:46 PM

#

Akarys42

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

I agree with wookie, I think having extensive matching for the sake of even future-proofing is okay, considering additional checks are being performed

regal archBOT Oct 9, 2022, 10:38 PM

#

mbaruh

[bot:new\-filters] 2 new commits

6aeab23 Added filter list deletion command. - mbaruh
6fedd8f Rearrange UI into several modules - mbaruh

regal archBOT Oct 10, 2022, 1:31 AM

#

onerandomusername

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

The only inaccurate part is the last section is too short as it is, but because of how the parsing works, that isn't an issue, i suppose

odd spireBOT Oct 10, 2022, 5:05 AM

#

[python-discord/site] Checks Successful on PR: #779 Bump pyfakefs from 4.7.0 to 5.0.0

GitHub Actions run 3216982411 succeeded.

PR Author

Workflow Run

Lint & Test #1288

Source Branch

dependabot/pip/pyfakefs-5...

odd spireBOT Oct 10, 2022, 10:05 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1117 Bump flake8-isort from 4.2.0 to 5.0.0

GitHub Actions run 3218459304 succeeded.

PR Author

Workflow Run

Lint #2486

Source Branch

dependabot/pip/flake8-isort-5.0.0

regal archBOT Oct 10, 2022, 10:26 AM

#

wookie184

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

The only inaccurate part is the last section is too short as it is, but because of how the parsing works, that isn't an issue, i suppose

If that's the case I think we should just have no upper limit on the length of the last section. Otherwise the code is somewhat misleading in how it works.

odd spireBOT Oct 10, 2022, 5:29 PM

#

[python-discord/king-arthur] Checks Successful on PR: #29 build(deps-dev): bump flake8-isort from 4.2.0 to 5.0.0

GitHub Actions run 3221215011 succeeded.

PR Author

Lint, Build & Deploy #139

Workflow Run

Source Branch

dependabot/pip/fl...

regal archBOT Oct 10, 2022, 7:41 PM

#

mbaruh

[bot:new\-filters] 1 new commit

02fedb2 Add filter list edit command - mbaruh

#

mbaruh

[site] Branch new\-filter\-schema was force-pushed to `c3747b6`

https://flake8.pycqa.org/en/latest/release-notes/5.0.0.html

regal archBOT Oct 10, 2022, 8:21 PM

#

ChrisLovering

[bot:bump\-bot\-core] 3 new commits

224a05b Bump bot-core to 8.2.1 - ChrisLovering
168ccfe Bump all deps to latest - ChrisLovering
a349911 noqa an abstract class with no abstract methods - ChrisLovering

#

ChrisLovering

[python-discord/bot] New branch created: bump\-bot\-core

#

ChrisLovering

[python-discord/bot] Pull request opened: #2287 Bump bot\-core to 8\.2\.1 and bump other deps to latest

From the release notes on d.py [here](#381965829857738772 message) and [here](#381965829857738772 message) none of the breaking changes for the commit we were on to 2.0.1 affect us.

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2287 Bump bot\-core to 8\.2\.1 and bump other deps to latest

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2287: Bump bot\-core to 8\.2\.1 and bump other deps to latest

Breaking change in the major version bump was to remove support multiprocessing, which we don't use.
https://pypi.org/project/pytest-cov/

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2287: Bump bot\-core to 8\.2\.1 and bump other deps to latest

Breaking changes in this major version bump don't affect us

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2287: Bump bot\-core to 8\.2\.1 and bump other deps to latest

Breaking change in the major version bump was to remove support for Python 3.6.
https://pypi.org/project/flake8-isort/5.0.0/

odd spireBOT Oct 10, 2022, 8:25 PM

#

[python-discord/bot] Checks Successful on PR: #2287 Bump bot-core to 8.2.1 and bump other deps to latest

GitHub Actions run 3222132812 succeeded.

PR Author

Workflow Run

Lint & Test #3211

Source Branch

bump-bot-core

regal archBOT Oct 10, 2022, 8:45 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #2287 Bump bot\-core to 8\.2\.1 and bump other deps to latest

#

mbaruh

[python-discord/bot] New review comment on pull request #2287: Bump bot\-core to 8\.2\.1 and bump other deps to latest

Was this fixed?

#

ChrisLovering

[bot] Branch bump\-bot\-core was force-pushed to `a1f4f60`

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2287: Bump bot\-core to 8\.2\.1 and bump other deps to latest

No, and I completely ignored the commit directly above, which I left 😅.

Fixed in a forcepush.

odd spireBOT Oct 10, 2022, 8:59 PM

#

[python-discord/bot] Checks Successful on PR: #2287 Bump bot-core to 8.2.1 and bump other deps to latest

GitHub Actions run 3222306985 succeeded.

PR Author

Workflow Run

Lint & Test #3212

Source Branch

bump-bot-core

regal archBOT Oct 11, 2022, 6:28 AM

#

mbaruh

[python-discord/bot] Pull request review submitted: #2287 Bump bot\-core to 8\.2\.1 and bump other deps to latest

regal archBOT Oct 11, 2022, 7:30 AM

#

mbaruh

[bot:new\-filters] 1 new commit

fb4117b Filter list add command - mbaruh

regal archBOT Oct 11, 2022, 11:10 AM

#

mbaruh

[python-discord/sir-lancebot] New comment on issue #1098: 1D Cellular Automaton Generator

I think this is a fun standalone project to implement if you're interested in the algorithm, but honestly I don't think it fits the bot. It's not informational or interactive, and I don't see people using it.

#

mbaruh

[python-discord/sir-lancebot] Issue closed: #1098 1D Cellular Automaton Generator

#

thatbirdguythatuknownot

[python-discord/sir-lancebot] Pull request opened: #1118 Bat spooky reaction

Relevant Issues

Closes #1116

Description

Added new entry in SPOOKY_TRIGGERS. Use a bit more regex to match all the words specified in the issue.

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read and agree t...

odd spireBOT Oct 11, 2022, 11:20 AM

#

[python-discord/sir-lancebot] Checks Cancelled on PR: #1118 Bat spooky reaction

GitHub Actions run 3226381961 was cancelled.

PR Author

thatbirdguythatuknownot

Workflow Run

Lint #2487

Source Branch

thatbirdguythatuknownot:...

#

[python-discord/sir-lancebot] Checks Successful on PR: #1118 Bat spooky reaction

GitHub Actions run 3226386847 succeeded.

PR Author

thatbirdguythatuknownot

Workflow Run

Lint #2488

Source Branch

thatbirdguythatuknownot:...

regal archBOT Oct 11, 2022, 12:11 PM

#

CyberCitizen01

[python-discord/sir-lancebot] New review comment on pull request #1060: fix \`\.movie\`

Hey @ChrisLovering 👋🏻. I've implemented this, please review whenever possible.

regal archBOT Oct 11, 2022, 1:15 PM

#

mbaruh

[bot:new\-filters] 3 new commits

a4fba43 Rearrange FilterList class - mbaruh
ffcbf77 Add confirmation before filter deletion - mbaruh
a9d1371 Better API error handling - mbaruh

regal archBOT Oct 11, 2022, 2:50 PM

#

Sas2k

[python-discord/sir-lancebot] New comment on issue #1098: 1D Cellular Automaton Generator

ok, thanks for reviewing it @mbaruh

regal archBOT Oct 11, 2022, 8:00 PM

#

Akarys42

[python-discord/modmail-plugins] Pull request opened: #28 Make all setup functions async

This is required with the new modmail release. You may want to double-check check it is compatible with the version of the bot you are currently running, and if not wait to merge it.

This is just #26 but from a different branch.

#

Akarys42

[python-discord/modmail-plugins] New comment on pull request #26: Make all setup functions async

Closed in favor of #26. My fault for making a PR from main.

#

Akarys42

[python-discord/modmail-plugins] Pull request closed: #26 Make all setup functions async

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1060 fix \`\.movie\`

odd spireBOT Oct 11, 2022, 8:18 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1060 fix `.movie`

GitHub Actions run 3229956535 succeeded.

PR Author

CyberCitizen01

Workflow Run

Lint #2489

Source Branch

CyberCitizen01:movie-#1055

regal archBOT Oct 11, 2022, 8:19 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review dismissed: #1060 Fix the TMDB API error handling in movie cog

Thanks for the PR, I have a few comments.

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1118 Bat spooky reaction

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1117 Bump flake8\-isort from 4\.2\.0 to 5\.0\.0

#

ChrisLovering

[sir-lancebot:main] 2 new commits

7b236e3 Bump flake8-isort from 4.2.0 to 5.0.0 - dependabot[bot]
1ae1244 Merge pull request #1117 from python-discord/de... - ChrisLovering

night lilyBOT Oct 11, 2022, 8:24 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 11, 2022, 8:25 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3229989678 succeeded.

Actor

Workflow Run

Build #609

Commit

1ae1244

regal archBOT Oct 11, 2022, 11:19 PM

#

ZeroIntensity

[python-discord/bot] Issue opened: #2288 Eval output in general?

is there any chance eval output could be allowed in pygen? or at least stop the bot from deleting the message?

it’s really annoying trying to give examples or test something when the bot is deleting the message and/or you have to go to another channel to see the output

if spam is your worry it shouldn’t be all that hard to have a cooldown and line limit right?

regal archBOT Oct 12, 2022, 7:17 PM

#

ChrisLovering

[infra:remove\-unused\-roles] 1 new commit

63e95eb Delete roles we won't use with self-hosted k8s - ChrisLovering

#

ChrisLovering

[python-discord/infra] New branch created: remove\-unused\-roles

#

ChrisLovering

[python-discord/infra] Pull request opened: #70 Delete roles we won't use with self\-hosted k8s

This deletes the following:

auditbeat
certbot
elasticsearch
filebeat
jumpcloud
kibana (+kibana-nginx)
nginx (+nginx-cloudflare-mtls, nginx-geoip, nginx-ufw)
packetbeat
wireguard

#

ChrisLovering

[infra] Branch remove\-unused\-roles was force-pushed to `7410aa3`

#

ChrisLovering

[infra] Branch remove\-unused\-roles was force-pushed to `9e0c454`

#

Xithrius

[python-discord/site] Pull request closed: #779 Bump pyfakefs from 4\.7\.0 to 5\.0\.0

#

Xithrius

[site:main] 2 new commits

5f00c7b Bump pyfakefs from 4.7.0 to 5.0.0 - dependabot[bot]
01f5651 Merge pull request #779 from python-discord/dep... - Xithrius

#

ChrisLovering

[python-discord/site] New comment on pull request #778: Bump psycopg2\-binary from 2\.9\.3 to 2\.9\.4

@dependabot rebase

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #1060 Fix the TMDB API error handling in movie cog

#

Xithrius

[python-discord/sir-lancebot] Pull request review submitted: #1118 Add bat spooky reaction

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1118 Add bat spooky reaction

#

ChrisLovering

[sir-lancebot:main] 1 new commit

4499cc0 Add bat spooky reaction (#1118) - thatbirdguythatuknownot

#

ChrisLovering

[python-discord/sir-lancebot] Issue closed: #1116 Add a bat reaction for Halloween

odd spireBOT Oct 12, 2022, 7:29 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1060 Fix the TMDB API error handling in movie cog

GitHub Actions run 3237340202 succeeded.

PR Author

CyberCitizen01

Workflow Run

Lint #2491

Source Branch

CyberCitizen01:movie-#1055

regal archBOT Oct 12, 2022, 7:30 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1060 Fix the TMDB API error handling in movie cog

#

ChrisLovering

[sir-lancebot:main] 1 new commit

9dab976 Fix the TMDB API error handling in movie cog (#... - CyberCitizen01

#

ChrisLovering

[python-discord/sir-lancebot] Issue closed: #1055 KeyError: 'status\_code' in movie command

#

Xithrius

[python-discord/site] Pull request closed: #778 Bump psycopg2\-binary from 2\.9\.3 to 2\.9\.4

#

Xithrius

[site:main] 2 new commits

18f86ae Bump psycopg2-binary from 2.9.3 to 2.9.4 - dependabot[bot]
754f0c0 Merge pull request #778 from python-discord/dep... - Xithrius

odd spireBOT Oct 12, 2022, 7:31 PM

#

[python-discord/site] Checks Successful on PR: #777 Bump django from 4.1.1 to 4.1.2

GitHub Actions run 3237334742 succeeded.

PR Author

Workflow Run

Lint & Test #1291

Source Branch

dependabot/pip/django-4.1.2

#

[python-discord/site] Checks Successful on PR: #778 Bump psycopg2-binary from 2.9.3 to 2.9.4

GitHub Actions run 3237332369 succeeded.

PR Author

Workflow Run

Lint & Test #1290

Source Branch

dependabot/pip/psycopg2-b...

regal archBOT Oct 12, 2022, 7:33 PM

#

Xithrius

[python-discord/sir-lancebot] New comment on pull request #1095: Use buttons for bookmark command\.

@Diabolical5777 What's your status on this PR?

Thanks!

night lilyBOT Oct 12, 2022, 7:33 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 12, 2022, 7:34 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3237359962 succeeded.

Actor

Workflow Run

Build #611

Commit

9dab976

regal archBOT Oct 12, 2022, 7:35 PM

#

Xithrius

[python-discord/site] Pull request closed: #777 Bump django from 4\.1\.1 to 4\.1\.2

#

Xithrius

[site:main] 2 new commits

8d6458e Bump django from 4.1.1 to 4.1.2 - dependabot[bot]
bf1f39a Merge pull request #777 from python-discord/dep... - Xithrius

odd spireBOT Oct 12, 2022, 7:35 PM

#

[python-discord/site] Checks Successful on PR: #777 Bump django from 4.1.1 to 4.1.2

GitHub Actions run 3237364364 succeeded.

PR Author

Workflow Run

Lint & Test #1293

Source Branch

dependabot/pip/django-4.1.2

regal archBOT Oct 12, 2022, 7:36 PM

#

ChrisLovering

[python-discord/site] Pull request closed: #622 Easy docker migrations

#

Xithrius

[python-discord/site] New comment on pull request #626: feat: Edit on GitHub button for content articles

@hedyhli Greetings. What is your status on this PR?

Thanks!

odd spireBOT Oct 12, 2022, 7:42 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 3237412757 succeeded.

Actor

Workflow Run

Deploy #308

Commit

bf1f39a

#

[python-discord/site] Workflow Successful

GitHub Actions run 3237358475 succeeded.

Actor

Workflow Run

Deploy #306

Commit

754f0c0

#

[python-discord/site] Workflow Successful

GitHub Actions run 3237387109 succeeded.

Actor

Workflow Run

Deploy #307

Commit

bf1f39a

regal archBOT Oct 12, 2022, 7:43 PM

#

Xithrius

[python-discord/site] New comment on pull request #701: Migrate "Keeping Discord Bot Tokens Safe" pin

@Shom770 Greetings. What's your status on this PR?

Thanks!

regal archBOT Oct 12, 2022, 8:03 PM

#

jchristgit

[python-discord/infra] New comment on issue #21: IP/CIDR allocation method & tracking

Joe has concluded his research and after a lengthy research paper was published
and after even receiving a $250,000 grant from Leon "Lemon" Sandøy himself, his
research concluded that whilst driving a Ferrari is truly enjoyable, the
correct way to solve this matter of allocating IP addresses is to self-host the
most complicated cluster scheduling software known to man, Kubernetes. We are
excited to announce that as a result to this research, the general public had
the ability to for onc...

#

jchristgit

[python-discord/infra] Issue closed: #21 IP/CIDR allocation method & tracking

#

jchristgit

[python-discord/infra] New comment on issue #18: Install and configure Podman on all hosts

I am thrilled to announce that we have solved the issue of having to configure
a container engine on our hosts ourselves by deciding to configure a container
cluster management orchestration solution instead.

#

jchristgit

[python-discord/infra] Issue closed: #18 Install and configure Podman on all hosts

regal archBOT Oct 12, 2022, 10:07 PM

#

Xithrius

[python-discord/king-arthur] Fork created: Xithrius/king-arthur

#

Xithrius

[pixels:repo\-token\-remove] 1 new commit

cea130f REPO_TOKEN env var obliterated - Xithrius

#

Xithrius

[bot:repo\-token\-remove] 1 new commit

a949237 REPO_TOKEN env var obliterated - Xithrius

#

Xithrius

[site:repo\-token\-remove] 1 new commit

87ebf37 REPO_TOKEN env var obliterated - Xithrius

#

Xithrius

[python-discord/bot] New branch created: repo\-token\-remove

#

Xithrius

[sir-robin:repo\-token\-remove] 1 new commit

b1f0aa4 REPO_TOKEN env var obliterated - Xithrius

#

Xithrius

[python-discord/site] New branch created: repo\-token\-remove

#

Xithrius

[patsy:repo\-token\-remove] 1 new commit

f5159a3 REPO_TOKEN env var obliterated - Xithrius

#

Xithrius

[python-discord/quackstack] New branch created: repo\-token\-remove

#

Xithrius

[python-discord/patsy] New branch created: repo\-token\-remove

#

Xithrius

[python-discord/bot] Pull request opened: #2289 \`REPO\_TOKEN\` is no more\.

odd spireBOT Oct 12, 2022, 10:17 PM

#

[python-discord/bot] Checks Successful on PR: #2289 `REPO_TOKEN` is no more.

GitHub Actions run 3238247779 succeeded.

PR Author

Workflow Run

Lint & Test #3213

Source Branch

repo-token-remove

regal archBOT Oct 12, 2022, 10:20 PM

#

Xithrius

[python-discord/site] Pull request opened: #780 \`REPO\_TOKEN\` is no more\.

Solves part of https://github.com/python-discord/kubernetes/issues/140, since the repository is now public.

vague sphinx Oct 12, 2022, 10:20 PM

#

🍐

regal archBOT Oct 12, 2022, 10:20 PM

#

Xithrius

[python-discord/patsy] Pull request opened: #7 \`REPO\_TOKEN\` is no more\.

Solves part of https://github.com/python-discord/kubernetes/issues/140, since the repository is now public.

#

Xithrius

[python-discord/pixels] Pull request opened: #132 \`REPO\_TOKEN\` is no more\.

Solves part of https://github.com/python-discord/kubernetes/issues/140, since the repository is now public.

odd spireBOT Oct 12, 2022, 10:21 PM

#

[python-discord/patsy] Checks Failed on PR: #7 `REPO_TOKEN` is no more.

GitHub Actions run 3238278945 failed.

PR Author

Workflow Run

Lint & Test #36

Source Branch

repo-token-remove

#

[python-discord/sir-lancebot] Checks Successful on PR: #1119 `REPO_TOKEN` is no more.

GitHub Actions run 3238278802 succeeded.

PR Author

Workflow Run

Lint #2496

Source Branch

repo-token-remove

#

[python-discord/pixels] Checks Successful on PR: #132 `REPO_TOKEN` is no more.

GitHub Actions run 3238279274 succeeded.

PR Author

Workflow Run

Lint #430

Source Branch

repo-token-remove

#

[python-discord/site] Checks Successful on PR: #780 `REPO_TOKEN` is no more.

GitHub Actions run 3238278758 succeeded.

PR Author

Workflow Run

Lint & Test #1295

Source Branch

repo-token-remove

regal archBOT Oct 12, 2022, 10:37 PM

#

shenanigansd

[python-discord/bot] Pull request review submitted: #2289 \`REPO\_TOKEN\` is no more\.

#

shenanigansd

[python-discord/site] Pull request review submitted: #780 \`REPO\_TOKEN\` is no more\.

#

shenanigansd

[python-discord/sir-lancebot] Pull request review submitted: #1119 \`REPO\_TOKEN\` is no more\.

#

shenanigansd

[python-discord/sir-lancebot] Pull request review submitted: #1119 \`REPO\_TOKEN\` is no more\.

#

shenanigansd

[python-discord/sir-robin] Pull request review submitted: #63 \`REPO\_TOKEN\` is no more\.

#

shenanigansd

[python-discord/quackstack] Pull request review submitted: #75 \`REPO\_TOKEN\` is no more\.

#

shenanigansd

[python-discord/pixels] Pull request review submitted: #132 \`REPO\_TOKEN\` is no more\.

#

shenanigansd

[python-discord/patsy] Pull request review submitted: #7 \`REPO\_TOKEN\` is no more\.

regal archBOT Oct 13, 2022, 12:07 PM

#

ChrisLovering

[python-discord/pixels] Pull request review submitted: #132 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/pixels] Pull request closed: #132 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[pixels:main] 2 new commits

cea130f REPO_TOKEN env var obliterated - Xithrius
636dc82 Merge pull request #132 from python-discord/rep... - Xithrius

#

ChrisLovering

[python-discord/quackstack] Pull request review submitted: #75 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/quackstack] Pull request closed: #75 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/quackstack] branch deleted: repo\-token\-remove

#

Xithrius

[quackstack:main] 2 new commits

a330a88 REPO_TOKEN env var obliterated - Xithrius
ea9d349 Merge pull request #75 from python-discord/repo... - Xithrius

#

ChrisLovering

[python-discord/sir-robin] Pull request review submitted: #63 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/sir-robin] Pull request closed: #63 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[sir-robin:main] 2 new commits

b1f0aa4 REPO_TOKEN env var obliterated - Xithrius
efab152 Merge pull request #63 from python-discord/repo... - Xithrius

#

Xithrius

[python-discord/sir-robin] branch deleted: repo\-token\-remove

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1119 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/sir-lancebot] Pull request closed: #1119 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/sir-lancebot] branch deleted: repo\-token\-remove

#

Xithrius

[sir-lancebot:main] 1 new commit

cb532cf REPO_TOKEN is no more. (#1119) - Xithrius

#

ChrisLovering

[python-discord/site] Pull request review submitted: #780 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/site] Pull request closed: #780 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/site] branch deleted: repo\-token\-remove

#

Xithrius

[site:main] 2 new commits

87ebf37 REPO_TOKEN env var obliterated - Xithrius
84c4a10 Merge pull request #780 from python-discord/rep... - Xithrius

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2289 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[python-discord/bot] Pull request closed: #2289 \`REPO\_TOKEN\` is no more\.

#

Xithrius

[bot:main] 1 new commit

47bd2e8 REPO_TOKEN is no more. (#2289) - Xithrius

#

Xithrius

[python-discord/bot] branch deleted: repo\-token\-remove

odd spireBOT Oct 13, 2022, 12:09 PM

#

[python-discord/pixels] Workflow Successful

GitHub Actions run 3242221740 succeeded.

Actor

Workflow Run

Lint #431

Commit

636dc82

night lilyBOT Oct 13, 2022, 12:10 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 13, 2022, 12:11 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3242233050 succeeded.

Actor

Workflow Run

Build #612

Commit

cb532cf

thin oysterBOT Oct 13, 2022, 12:11 PM

#

Sir Robin

Connected!

odd spireBOT Oct 13, 2022, 12:14 PM

#

[python-discord/site] Workflow Successful

GitHub Actions run 3242252660 succeeded.

Actor

Workflow Run

Deploy #309

Commit

84c4a10

oak estuaryBOT Oct 13, 2022, 12:14 PM

#

Python Bot

Connected!

odd spireBOT Oct 13, 2022, 12:14 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3242259902 succeeded.

Actor

Workflow Run

Deploy #726

Commit

47bd2e8

regal archBOT Oct 13, 2022, 12:24 PM

#

ChrisLovering

[patsy:repo\-token\-remove] 1 new commit

737b839 Update patsy to use new pydis CI - ChrisLovering

odd spireBOT Oct 13, 2022, 12:26 PM

#

[python-discord/patsy] Checks Failed on PR: #7 `REPO_TOKEN` is no more.

GitHub Actions run 3242330969 failed.

PR Author

Workflow Run

Lint & Test #37

Source Branch

repo-token-remove

regal archBOT Oct 13, 2022, 12:32 PM

#

ChrisLovering

[patsy:repo\-token\-remove] 1 new commit

96beee5 Bump Python version and deps - ChrisLovering

#

ChrisLovering

[python-discord/patsy] Pull request closed: #7 \`REPO\_TOKEN\` is no more\.

#

ChrisLovering

[patsy:main] 3 new commits

c18c0f2 REPO_TOKEN env var obliterated - Xithrius
78d7494 Update patsy to use new pydis CI - ChrisLovering
c6cf54f Bump Python version and deps - ChrisLovering

#

ChrisLovering

[python-discord/patsy] branch deleted: repo\-token\-remove

odd spireBOT Oct 13, 2022, 12:34 PM

#

[python-discord/patsy] Checks Successful on PR: #7 `REPO_TOKEN` is no more.

GitHub Actions run 3242385289 succeeded.

PR Author

Workflow Run

Lint & Test #38

Source Branch

repo-token-remove

#

[python-discord/patsy] Workflow Failed

GitHub Actions run 3242404321 failed.

Actor

Workflow Run

Build & Deploy #27

Commit

c6cf54f

odd spireBOT Oct 13, 2022, 1:17 PM

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 3242613694 succeeded.

Actor

Workflow Run

Build & Deploy #28

Commit

4812cfb

regal archBOT Oct 13, 2022, 2:14 PM

#

gustavwilliam

[branding:lemoji/partying] 1 new commit

7341a37 Add lemon partying - gustavwilliam

#

gustavwilliam

[python-discord/branding] New branch created: lemoji/partying

#

gustavwilliam

[python-discord/branding] Pull request opened: #192 Add partying lemoji

Adds :lemoji_partying:.

odd spireBOT Oct 13, 2022, 2:17 PM

#

[python-discord/branding] Checks Successful on PR: #192 Add partying lemoji

GitHub Actions run 3243115765 succeeded.

PR Author

gustavwilliam

Workflow Run

Event Validation #109

Source Branch

lemoji/partying

regal archBOT Oct 13, 2022, 8:24 PM

#

ChrisLovering

[patsy:main] 1 new commit

c70e49e Rewrite to use SQLAlchemy - ChrisLovering

#

ChrisLovering

[patsy:main] 1 new commit

f394d9e Remove loguru and httpx - ChrisLovering

#

ChrisLovering

[patsy] Branch main was force-pushed to `15f4a20`

#

ChrisLovering

[patsy:main] 1 new commit

19af257 Update build action to use new lint action name - ChrisLovering

#

ChrisLovering

[patsy:main] 1 new commit

4f21880 Include migrations in built images - ChrisLovering

odd spireBOT Oct 13, 2022, 8:45 PM

#

[python-discord/patsy] Workflow Cancelled

GitHub Actions run 3245522862 was cancelled.

Actor

Workflow Run

Build & Deploy #29

Commit

19af257

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 3245561129 succeeded.

Actor

Workflow Run

Build & Deploy #30

Commit

4f21880

#

[python-discord/kubernetes] Checks Successful on PR: #141 Update patsy ports

GitHub Actions run 3245596264 succeeded.

PR Author

Lint Kubernetes manifests #296

Workflow Run

Source Branch

update-patsy-ports

regal archBOT Oct 13, 2022, 9:08 PM

#

Xithrius

[python-discord/king-arthur] Pull request opened: #30 \`REPO\_TOKEN\` is no more\.

Solves part of https://github.com/python-discord/kubernetes/issues/140, since the repository is now public.

#

Xithrius

[python-discord/king-arthur] New comment on pull request #30: \`REPO\_TOKEN\` is no more\.

@ChrisLovering since I can't request your review I'm pinging you directly instead.

odd spireBOT Oct 13, 2022, 9:10 PM

#

[python-discord/king-arthur] Checks Successful on PR: #30 `REPO_TOKEN` is no more.

GitHub Actions run 3245698324 succeeded.

PR Author

Lint, Build & Deploy #140

Workflow Run

Source Branch

Xithrius:patch-1

regal archBOT Oct 13, 2022, 9:11 PM

#

ChrisLovering

[python-discord/king-arthur] Pull request review submitted: #30 \`REPO\_TOKEN\` is no more\.

#

ChrisLovering

[python-discord/king-arthur] Pull request closed: #30 \`REPO\_TOKEN\` is no more\.

#

ChrisLovering

[king-arthur:main] 2 new commits

0dd65b0 REPO_TOKEN env var obliterated - Xithrius
9994ac3 Merge pull request #30 from Xithrius/patch-1 - ChrisLovering

odd spireBOT Oct 13, 2022, 9:13 PM

#

[python-discord/king-arthur] Workflow Successful

GitHub Actions run 3245711662 succeeded.

Actor

Lint, Build & Deploy #141

Workflow Run

Commit

9994ac3

#

[python-discord/kubernetes] Workflow Successful

GitHub Actions run 3245743053 succeeded.

Actor

Lint Kubernetes manifests #297

Workflow Run

Commit

6cf8de2

regal archBOT Oct 14, 2022, 8:33 AM

#

ChrisLovering

[patsy:main] 1 new commit

416d3cb Add black & isort to the repository - ChrisLovering

odd spireBOT Oct 14, 2022, 8:37 AM

#

[python-discord/patsy] Workflow Successful

GitHub Actions run 3248554152 succeeded.

Actor

Workflow Run

Build & Deploy #31

Commit

416d3cb

odd spireBOT Oct 14, 2022, 12:14 PM

#

[python-discord/bot] Checks Successful on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3249849093 succeeded.

PR Author

Workflow Run

Lint & Test #3215

Source Branch

onerandomusername:enhan...

#

[python-discord/bot] Checks Cancelled on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3249866654 was cancelled.

PR Author

Workflow Run

Lint & Test #3216

Source Branch

onerandomusername:enhan...

#

[python-discord/bot] Checks Successful on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3249872159 succeeded.

PR Author

Workflow Run

Lint & Test #3217

Source Branch

onerandomusername:enhan...

#

[python-discord/bot] Checks Successful on PR: #2006 enhancement(filters): use a stricter bot token regex

GitHub Actions run 3249891382 succeeded.

PR Author

Workflow Run

Lint & Test #3218

Source Branch

onerandomusername:enhan...

regal archBOT Oct 14, 2022, 12:31 PM

#

mbaruh

[python-discord/bot] New comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

Hey @onerandomusername, thanks for your work so far. We needed to get this merged so went ahead and implemented the comments. Sorry the MFA part didn't end up being used 😅

#

wookie184

[python-discord/bot] Pull request review dismissed: #2006 enhancement$filters$: use a stricter bot token regex

Just a couple things, could you also make the message match the other token message a bit closer, particularly:

having the user as a clickable mention and the ID in a codeblock afterwards
having the channel as a clickable mention
putting the censored token in a codeblock
adding the pfp of the user that send the message as a thumbnail

#

mbaruh

[python-discord/bot] Pull request review submitted: #2006 enhancement$filters$: use a stricter bot token regex

#

mbaruh

[python-discord/bot] Pull request closed: #2006 enhancement$filters$: use a stricter bot token regex

#

mbaruh

[bot:main] 1 new commit

cdb9183 enhancement(filters): use a stricter bot token ... - onerandomusername

oak estuaryBOT Oct 14, 2022, 12:38 PM

#

Python Bot

Connected!

odd spireBOT Oct 14, 2022, 12:38 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3250006672 succeeded.

Actor

Workflow Run

Deploy #727

Commit

cdb9183

regal archBOT Oct 14, 2022, 1:26 PM

#

hindutvaindian123

[python-discord/bot] New comment on commit `cdb9183`

Which coding language is this? I'm a beginner at Coding

#

HassanAbouelela

[python-discord/bot] New comment on commit `cdb9183`

New snake English (Python)

regal archBOT Oct 14, 2022, 4:22 PM

#

onerandomusername

[python-discord/bot] New review comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

way too lenient, this makes impossible tokens match.

regal archBOT Oct 14, 2022, 4:52 PM

#

HassanAbouelela

[python-discord/bot] New review comment on pull request #2006: enhancement$filters$: use a stricter bot token regex

Way too lenient is not defined by what it can match, but what it will match in practice, which so far has not been an issue. This PR made the regex a little more flexible in terms of false-positives, without increasing the possibility of false-negatives or creating something that has to be modified in the future.

regal archBOT Oct 15, 2022, 10:49 PM

#

ionite34

[python-discord/bot] Pull request review submitted: #2287 Bump bot\-core to 8\.2\.1 and bump other deps to latest

regal archBOT Oct 15, 2022, 11:37 PM

#

mbaruh

[bot:bump\-bot\-core] 3 new commits

47bd2e8 REPO_TOKEN is no more. (#2289) - Xithrius
cdb9183 enhancement(filters): use a stricter bot token ... - onerandomusername
67333f9 Merge branch 'main' into bump-bot-core - mbaruh

#

mbaruh

[python-discord/bot] Pull request closed: #2287 Bump bot\-core to 8\.2\.1 and bump other deps to latest

#

mbaruh

[bot:main] 6 new commits

224a05b Bump bot-core to 8.2.1 - ChrisLovering
bcd7051 Bump all deps to latest - ChrisLovering
3582ff5 noqa an abstract class with no abstract methods - ChrisLovering
a1f4f60 Use explicit mock channels in tests to remove w... - ChrisLovering
67333f9 Merge branch 'main' into bump-bot-core - mbaruh

#

mbaruh

[python-discord/bot] branch deleted: bump\-bot\-core

oak estuaryBOT Oct 15, 2022, 11:44 PM

#

Python Bot

Connected!

odd spireBOT Oct 15, 2022, 11:44 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3257562489 succeeded.

Actor

Workflow Run

Deploy #728

Commit

1811aa8

regal archBOT Oct 16, 2022, 8:34 AM

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #1120 AttributeError: 'async\_generator' object has no attribute 'flatten'

Sentry Issue: SIR-LANCEBOT-8S

AttributeError: 'async_generator' object has no attribute 'flatten'
  File "discord/client.py", line 409, in _run_event
    await coro(*args, **kwargs)
  File "bot/utils/decorators.py", line 81, in guarded_listener
    return await listener(*args, **kwargs)
  File "bot/exts/holidays/halloween/candy_collection.py", line 93, in on_reaction_add
    await self.hackto...

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #1121 TypeError: object of type 'NoneType' has no len

Sentry Issue: SIR-LANCEBOT-8R

TypeError: object of type 'NoneType' has no len()
  File "discord/ext/commands/core.py", line 190, in wrapped
    ret = await coro(*args, **kwargs)
  File "bot/exts/holidays/halloween/scarymovie.py", line 23, in random_movie
    selection = await self.select_movie()
  File "bot/exts/holidays/halloween/scarymovie.py", line 50, in select_movie
    selection_id = ra...

regal archBOT Oct 16, 2022, 9:04 AM

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1121: TypeError: object of type 'NoneType' has no len

Do we just want to change selection_id = random.choice(data.get("results")).get("id") to selection_id = random.choice(data.get("results", [])).get("id") here?

It seems there no validation afterwards to see whether selection_id is None before doing a GET request to the api, so I suppose this should be added too.

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1120: AttributeError: 'async\_generator' object has no attribute 'flatten'

I believe await self.hacktober_channel.history(limit=10).flatten() should instead be (await self.hacktober_channel.history(limit=10)).flatten(). Can I please be assigned to this?

regal archBOT Oct 16, 2022, 9:31 AM

#

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #1121: TypeError: object of type 'NoneType' has no len

Yea, both those sound good.

#

ChrisLovering

[python-discord/sir-lancebot] New comment on issue #1120: AttributeError: 'async\_generator' object has no attribute 'flatten'

I believe .flatten() was removed in 2.0, the way to do this now would be

[message async for message in self.hacktober_channel.history(limit=10)]

#

sentry-io[bot]

[python-discord/sir-lancebot] Issue opened: #1122 AttributeError: 'NoneType' object has no attribute 'id'

Sentry Issue: SIR-LANCEBOT-8T

AttributeError: 'NoneType' object has no attribute 'id'
  File "discord/client.py", line 409, in _run_event
    await coro(*args, **kwargs)
  File "bot/exts/core/help.py", line 191, in on_reaction_add
    if reaction.message.id != self.message.id:

Ignoring exception in on_reaction_add

regal archBOT Oct 16, 2022, 1:34 PM

#

shinigumi123

[python-discord/bot] Issue opened: #2290 S

regal archBOT Oct 16, 2022, 4:01 PM

#

Lutoswek

[python-discord/bot] Issue opened: #2291 Bot

#

Lutoswek

[python-discord/bot] Issue closed: #2291 Bot

regal archBOT Oct 16, 2022, 4:29 PM

#

brad90four

[python-discord/sir-lancebot] Issue opened: #1123 Add blurple to the list of color names for the \`\.color\` command

Description

blurple is not a recognized color for the color command

Steps to Reproduce

Run .color name blurple

Expected Behaviour

A color embed showing the color blurple (hex code #5865F2)

Actual Behaviour

Possible Solutio...

regal archBOT Oct 16, 2022, 5:42 PM

#

brad90four

[sir-lancebot:blurple\_color\_fix] 186 new commits

0567cf9 Created new branch and script for Real Python s... - brad90four
11de6a3 Updated script to include ERR_EMBED - brad90four
617a64b Updated import statements for "from discord.ext... - brad90four
ea02a5f Updated line 30 to include "commands.cooldowns"... - brad90four
e528332 Updated JSON headers for "results" and "url" - brad90four

#

brad90four

[python-discord/sir-lancebot] New branch created: blurple\_color\_fix

#

brad90four

[python-discord/sir-lancebot] Pull request opened: #1124 Blurple color fix

Relevant Issues

Closes #1123

Description

Added an entry for blurple.

Did you:

[X] Join the Python Discord Community?
[X] Read all the comments in this template?
[X] Ensure there is an issue open, or link relevant discord discussions?
[X] Read and agree to the [contributing guidelines](https://pythondiscord.com/pages/contributing...

#

brad90four

[python-discord/sir-lancebot] Pull request closed: #1124 Blurple color fix

#

brad90four

[python-discord/sir-lancebot] New comment on pull request #1124: Blurple color fix

Irrelevant files included in PR

odd spireBOT Oct 16, 2022, 5:45 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1124 Blurple color fix

GitHub Actions run 3260336085 succeeded.

PR Author

brad90four

Workflow Run

Lint #2498

Source Branch

blurple_color_fix

regal archBOT Oct 16, 2022, 5:48 PM

#

brad90four

[sir-lancebot:brad90four\-patch\-1] 1 new commit

21eeb70 Added blurple color - brad90four

#

brad90four

[python-discord/sir-lancebot] New branch created: brad90four\-patch\-1

#

brad90four

[python-discord/sir-lancebot] Pull request opened: #1125 Added \`blurple\` color

Relevant Issues

Closes #1123

Description

Added an entry for blurple.

Did you:

[X] Join the Python Discord Community?
[X] Read all the comments in this template?
[X] Ensure there is an issue open, or link relevant discord discussions?
[X] Read and agree to the [contributing guidelines](https://pythondiscord.com/pages/contributing/...

#

brad90four

[python-discord/sir-lancebot] branch deleted: blurple\_color\_fix

odd spireBOT Oct 16, 2022, 5:49 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1125 Added `blurple` color

GitHub Actions run 3260347070 succeeded.

PR Author

brad90four

Workflow Run

Lint #2499

Source Branch

brad90four-patch-1

regal archBOT Oct 16, 2022, 5:54 PM

#

shenanigansd

[python-discord/sir-lancebot] Pull request review submitted: #1125 Added \`blurple\` color

regal archBOT Oct 16, 2022, 8:29 PM

#

Robin5605

[python-discord/site] New comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

Hey! Would you mind working on @vivekashok1221's review? I think we can get it merged once that's done 😄

odd spireBOT Oct 16, 2022, 8:31 PM

#

[python-discord/site] Checks Successful on PR: #746 Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

GitHub Actions run 3260819296 succeeded.

PR Author

Exenifix

Workflow Run

Lint & Test #1297

Source Branch

Exenifix:main

regal archBOT Oct 16, 2022, 8:31 PM

#

Robin5605

[python-discord/site] New comment on pull request #738: Add a basic guide for Hikari in the Guides\.

Hello, thank you so much for the PR. Unfortunately, we don't have much experience in Hikari to be able to provide any meaningful feedback on the PR. As such, I think I'll be closing this. However, thanks for the PR though!

#

Robin5605

[python-discord/site] Pull request closed: #738 Add a basic guide for Hikari in the Guides\.

#

Robin5605

[python-discord/site] New comment on pull request #733: Added discord\-app\-commands\.md

Hi! What's your status on the PR? If you could fix up the linting issues and look over @shtlrs review, I think we'll be ready to merge!

regal archBOT Oct 16, 2022, 10:01 PM

#

TizzySaurus

[python-discord/sir-lancebot] New comment on pull request #1125: Added \`blurple\` color

As per my message on Discord (sending here for posterity sake), would be nice to also add og_blurple (#7289DA) as that's what the pydis branding uses.

regal archBOT Oct 16, 2022, 11:59 PM

#

brad90four

[sir-lancebot:brad90four\-patch\-1] 1 new commit

39e5db8 Add OG Blurple - brad90four

odd spireBOT Oct 17, 2022, 12:00 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1125 Added `blurple` color

GitHub Actions run 3261419145 succeeded.

PR Author

brad90four

Workflow Run

Lint #2500

Source Branch

brad90four-patch-1

regal archBOT Oct 17, 2022, 4:00 AM

#

Exenifix

[python-discord/site] New comment on pull request #746: Created a guide on how to run a bot with Docker and setup GitHub Actions for CI

I have already implemented what they requested, they just haven't reviewed it yet.

regal archBOT Oct 17, 2022, 1:51 PM

#

sentry-io[bot]

[python-discord/bot] Issue opened: #2292 TypeError: unsupported operand type$s$ for \+: 'SequenceProxy' and 'SequenceProxy'

Sentry Issue: BOT-398

TypeError: unsupported operand type(s) for +: 'SequenceProxy' and 'SequenceProxy'
  File "discord/ext/commands/core.py", line 190, in wrapped
    ret = await coro(*args, **kwargs)
  File "bot/exts/moderation/clean.py", line 514, in clean_users
    await self._clean_messages(ctx, users=users, channels=channels, first_limit=message_or_time)
  File "bot/exts/moderation/clea...

#

ChrisLovering

[bot:fix\-sequency\-proxy\-breaking\-change] 1 new commit

d53b855 Support the new SequenceProxy type in d.py - ChrisLovering

#

ChrisLovering

[python-discord/bot] New branch created: fix\-sequency\-proxy\-breaking\-change

#

ChrisLovering

[python-discord/bot] Pull request opened: #2293 Support the new SequenceProxy type in d\.py

This type is usd for a few attributes, including Guild.threads and guild.Channels. This type does not implement any of the add dunder methods, so we use itertools.chain to get a single iterator for both sequences.

Fixes BOT-398 Fixees #2292

odd spireBOT Oct 17, 2022, 1:54 PM

#

[python-discord/bot] Checks Successful on PR: #2293 Support the new SequenceProxy type in d.py

GitHub Actions run 3265720669 succeeded.

PR Author

Workflow Run

Lint & Test #3222

Source Branch

fix-sequency-proxy-breaking...

regal archBOT Oct 17, 2022, 1:55 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #2293 Support the new SequenceProxy type in d\.py

Astounding work

regal archBOT Oct 17, 2022, 8:36 PM

#

TizzySaurus

[python-discord/sir-lancebot] Pull request review submitted: #1125 Added \`blurple\` color

Works nicely :+1:

#

mbaruh

[bot:new\-filters] 4 new commits

6b89c1f Add filter matching command - mbaruh
2b8f85b More improvements to FilterList - mbaruh
e7e65c0 Change override handling - mbaruh
a7a04a1 Add a command to query filters by settings - mbaruh

odd spireBOT Oct 17, 2022, 9:09 PM

#

[python-discord/forms-backend] Checks Successful on PR: #216 Bump spectree from 0.10.5 to 0.11.0

GitHub Actions run 3268611994 succeeded.

PR Author

Workflow Run

Forms Backend #594

Source Branch

dependabot/pip/spectree-...

regal archBOT Oct 17, 2022, 10:07 PM

#

TizzySaurus

[sir-lancebot:fix\-issue\-1120] 1 new commit

43ea3c3 Remove calls to the deprecated .flatten() method - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: fix\-issue\-1120

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #1126 Remove calls to deprected \`\.flatten\` method\.

Relevant Issues

Closes #1120.

Description

Replaces .flatten() calls with an async for loop (the easterquiz ones had to be expanded due to a constraint with having an async comprehension within a non-async comprehension).

Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is ...

odd spireBOT Oct 17, 2022, 10:12 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1126 Remove calls to deprected `.flatten()` method.

GitHub Actions run 3268997633 succeeded.

PR Author

Workflow Run

Lint #2501

Source Branch

fix-issue-1120

regal archBOT Oct 18, 2022, 12:54 AM

#

minalike

[python-discord/bot] Pull request review submitted: #2293 Support the new SequenceProxy type in d\.py

🙌🏻

#

minalike

[python-discord/bot] Pull request closed: #2293 Support the new SequenceProxy type in d\.py

#

minalike

[python-discord/bot] Issue closed: #2292 TypeError: unsupported operand type$s$ for \+: 'SequenceProxy' and 'SequenceProxy'

#

minalike

[python-discord/bot] branch deleted: fix\-sequency\-proxy\-breaking\-change

#

minalike

[bot:main] 2 new commits

d53b855 Support the new SequenceProxy type in d.py - ChrisLovering
9f1ebb8 Merge pull request #2293 from python-discord/fi... - minalike

oak estuaryBOT Oct 18, 2022, 12:59 AM

#

Python Bot

Connected!

odd spireBOT Oct 18, 2022, 12:59 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3269797040 succeeded.

Actor

minalike

Workflow Run

Deploy #729

Commit

9f1ebb8

regal archBOT Oct 18, 2022, 3:15 AM

#

ionite34

[python-discord/bot] Issue opened: #2294 Zen command not using integer line when followed by words\.

Proposed fix

Parse string for potential integer before using word search.

regal archBOT Oct 18, 2022, 9:01 AM

#

ChrisLovering

[python-discord/bot] New comment on issue #2294: Zen command not using integer line when followed by words\.

The other option here it to make the sig something like async def zen(self, ctx: Context, search_index: int | None, *, search_string: str | None) which I think would have a similar affect and wouldn't require parsing inside the command handler.

regal archBOT Oct 18, 2022, 12:31 PM

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1126 Remove calls to deprected \`\.flatten\` method\.

The current egghead_quiz logic seems a bit dodgy, it's not obvious that the logic considers users making multiple votes, or adding extra reactions that aren't votes. Anyway, that's out of scope for here.

I wonder if using reaction.count could make some of the cases here cleaner.

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #1126: Remove calls to deprected \`\.flatten\` method\.

Shouldn't need the map any more, just get the id in the comprehension.

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #1126: Remove calls to deprected \`\.flatten\` method\.

I don't think these changes should be here?

#

wookie184

[python-discord/sir-lancebot] New review comment on pull request #1126: Remove calls to deprected \`\.flatten\` method\.

Putting a break here like on the last one would make the behaviour more obvious.

#

wookie184

[python-discord/sir-lancebot] Pull request review submitted: #1125 Added \`blurple\` color

#

wookie184

[python-discord/sir-lancebot] Pull request closed: #1125 Added \`blurple\` color

#

wookie184

[sir-lancebot:main] 1 new commit

6bbb12e Added Blurple and ` OG Blurple colours (#1125) - brad90four

#

wookie184

[python-discord/sir-lancebot] Issue closed: #1123 Add blurple to the list of color names for the \`\.color\` command

#

wookie184

[python-discord/sir-lancebot] branch deleted: brad90four\-patch\-1

night lilyBOT Oct 18, 2022, 12:41 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 18, 2022, 12:41 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3273496233 succeeded.

Actor

Workflow Run

Build #613

Commit

6bbb12e

regal archBOT Oct 18, 2022, 1:19 PM

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1122: AttributeError: 'NoneType' object has no attribute 'id'

I assume it's self.message that is None, as reaction.message should never be None. It seems like this is a race condition, a reaction is added (probably to a different message) before self.message is set.

I believe this should be fixed by moving the listener adding to after update_message is called: https://github.com/python-discord/sir-lancebot/blob/f9cc77f55a7bac9cff1f5674b36b3f17560f6bfe/bot/exts/core/help.py#L220-L228

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1121: TypeError: object of type 'NoneType' has no len

Do we just want to change selection_id = random.choice(data.get("results")).get("id") to selection_id = random.choice(data.get("results", [])).get("id") here?

random.choice will error on an empty sequence, so we should handle it being None/an empty array before trying to do that.

#

wookie184

[python-discord/bot] Issue closed: #1421 MFA User Token filter

regal archBOT Oct 18, 2022, 3:19 PM

#

wookie184

[python-discord/bot] New comment on issue #2295: Discord bot

Issues are for feature requests/bugs/questions relating to our bot. Please don't open an issue with no description

regal archBOT Oct 18, 2022, 4:37 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #2283 1379 tranform urls upon rich embed filter application

#

mbaruh

[python-discord/bot] Pull request closed: #2283 1379 tranform urls upon rich embed filter application

#

mbaruh

[bot:main] 7 new commits

b7a468d add remove_subdomain_from_url in bot util helpers - Amrou Bellalouna
6a0da9a transform urls matched in messages - Amrou Bellalouna
ce16838 collect all urls in a set to avoid duplicates - Amrou Bellalouna
caa2698 check for the url existence in the final_urls set - Amrou Bellalouna
0bf93eb use tldextract for a correct url decomposition - Amrou Bellalouna

#

mbaruh

[python-discord/bot] Issue closed: #1379 Adjust rich\_embeds filter so it doesn't catch edge case

odd spireBOT Oct 18, 2022, 4:40 PM

#

[python-discord/bot] Checks Successful on PR: #2283 1379 tranform urls upon rich embed filter application

GitHub Actions run 3275281554 succeeded.

PR Author

Workflow Run

Lint & Test #3224

Source Branch

shtlrs:1379-tranform-urls-upon-ric...

oak estuaryBOT Oct 18, 2022, 4:44 PM

#

Python Bot

Connected!

odd spireBOT Oct 18, 2022, 4:45 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3275319024 succeeded.

Actor

Workflow Run

Deploy #730

Commit

312bf43

regal archBOT Oct 18, 2022, 4:51 PM

#

mbaruh

[python-discord/bot] Pull request review submitted: #2245 Update autoreview system

Looks good!

#

mbaruh

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

It's not critical in practice, because of the speed of evaluation and the difference between nomination dates, but now should be constant across the nominations for correct behavior.

#

mbaruh

[python-discord/bot] New comment on pull request #2269: Allow evaling code from context menus

I'm not really sure on this one. I don't see any immediate downsides if someone were to try to eval someone else's code. The result would be ephemeral, and no damage is done.

What do you mean by "the result would be ephemeral"? Anyone can see the output right?

#

mbaruh

[python-discord/bot] Pull request review submitted: #2274 Check for commands being None in try\_get\_tag and try\_silence

#

mbaruh

[bot:fix\-silence\-and\-tags\-when\-unloaded] 168 new commits

6ca77ac Add patreon role configuration - mathstrains21
a44e798 Create patreon.py and add setup - mathstrains21
526ce5f Merge branch 'python-discord:main' into patreon - mathstrains21
380dd5c Add patron message when someone gains a patron ... - mathstrains21
b38ec72 Merge branch 'patreon' of https://github.com/ma... - mathstrains21

#

mbaruh

[python-discord/bot] Pull request closed: #2274 Check for commands being None in try\_get\_tag and try\_silence

#

mbaruh

[bot:main] 4 new commits

c8eb0ab Check for commands being None in try_get_tag an... - wookie184
b6c2054 Return None instead of False in try_get_tag - wookie184
6be1686 Merge branch 'main' into fix-silence-and-tags-w... - mbaruh
4a3321b Merge pull request #2274 from python-discord/fi... - mbaruh

#

mbaruh

[python-discord/bot] branch deleted: fix\-silence\-and\-tags\-when\-unloaded

odd spireBOT Oct 18, 2022, 5:17 PM

#

[python-discord/bot] Checks Successful on PR: #2274 Check for commands being None in try_get_tag and try_silence

GitHub Actions run 3275500558 succeeded.

PR Author

Workflow Run

Lint & Test #3226

Source Branch

fix-silence-and-tags-when-unloaded

oak estuaryBOT Oct 18, 2022, 5:21 PM

#

Python Bot

Connected!

odd spireBOT Oct 18, 2022, 5:21 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3275542257 succeeded.

Actor

Workflow Run

Deploy #731

Commit

4a3321b

regal archBOT Oct 18, 2022, 5:41 PM

#

lemonsaurus

[bot:lemon/resolve\-serious\-grammatical\-problem] 1 new commit

d8fd77b Resolve a serious grammatical problem in a comment - lemonsaurus

#

lemonsaurus

[python-discord/bot] New branch created: lemon/resolve\-serious\-grammatical\-problem

#

lemonsaurus

[python-discord/bot] Pull request opened: #2296 Resolve a serious grammatical problem in a comment

This has been a controversial comment, to be sure, but I have found the solution. Here is a compromise I know deep in my heart that we can all agree on.

odd spireBOT Oct 18, 2022, 5:46 PM

#

[python-discord/bot] Checks Successful on PR: #2296 Resolve a serious grammatical problem in a comment

GitHub Actions run 3275684464 succeeded.

PR Author

lemonsaurus

Workflow Run

Lint & Test #3228

Source Branch

lemon/resolve-serious-grammat...

regal archBOT Oct 18, 2022, 5:52 PM

#

wookie184

[python-discord/bot] Pull request review submitted: #2296 Resolve a serious grammatical problem in a comment

Yeah, we're Python programmers, we already have enough whitespace!!

#

lemonsaurus

[python-discord/bot] New comment on pull request #2296: Resolve a serious grammatical problem in a comment

That's very true @wookie184 thank you for that comment

#

jchristgit

[python-discord/bot] Pull request review submitted: #2296 Resolve a serious grammatical problem in a comment

This is a good change.

As part of my effort to review this pull request, I'm also signing Presidential Bill §142.4 into effect, making "fuckaroundery" a word of the English language.

#

ChrisLovering

[bot:main] 2 new commits

d8fd77b Resolve a serious grammatical problem in a comment - lemonsaurus
aa4a35e Merge pull request #2296 from python-discord/le... - ChrisLovering

#

ChrisLovering

[python-discord/bot] Pull request closed: #2296 Resolve a serious grammatical problem in a comment

#

ChrisLovering

[python-discord/bot] branch deleted: lemon/resolve\-serious\-grammatical\-problem

oak estuaryBOT Oct 18, 2022, 6:08 PM

#

Python Bot

Connected!

odd spireBOT Oct 18, 2022, 6:08 PM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3275833506 succeeded.

Actor

Workflow Run

Deploy #732

Commit

aa4a35e

odd spireBOT Oct 18, 2022, 9:12 PM

#

[python-discord/forms-backend] Checks Successful on PR: #217 Bump spectree from 0.10.5 to 0.12.0

GitHub Actions run 3276953788 succeeded.

PR Author

Workflow Run

Forms Backend #595

Source Branch

dependabot/pip/spectree-...

regal archBOT Oct 18, 2022, 9:14 PM

#

jchristgit

[python-discord/infra] Pull request closed: #70 Delete roles we won't use with self\-hosted k8s

#

jchristgit

[infra:main] 1 new commit

1295dd8 Delete roles we won't use with self-hosted k8s - ChrisLovering

#

jchristgit

[python-discord/infra] branch deleted: remove\-unused\-roles

#

jchristgit

[python-discord/infra] New comment on pull request #70: Delete roles we won't use with self\-hosted k8s

Legend!

regal archBOT Oct 19, 2022, 9:57 AM

#

shtlrs

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

@MarkKoz

I personally don't know if it's possible to dynamically generate doc strings, but a quick search will help me find out.

So if it's indeed possible, should we try going in that direction ?

#

shtlrs

[python-discord/bot] New comment on issue #2294: Zen command not using integer line when followed by words\.

I see that @minalike is working on a fix for this, maybe assign the issue then to let people know that it's being worked on ?

regal archBOT Oct 19, 2022, 10:19 AM

#

ChrisLovering

[python-discord/bot] New comment on issue #2294: Zen command not using integer line when followed by words\.

I see that @minalike is working on a fix for this, maybe assign the issue then to let people know that it's being worked on ?

Where do you see that?

#

ChrisLovering

[python-discord/bot] branch deleted: parallel\-fetch\-user\-bb

#

ChrisLovering

[python-discord/bot] branch deleted: single\-quotes

#

ChrisLovering

[python-discord/bot] branch deleted: see\-what\-black\-would\-change

#

ChrisLovering

[python-discord/bot] branch deleted: ChrisLovering\-patch\-2

#

shtlrs

[python-discord/bot] New comment on issue #2294: Zen command not using integer line when followed by words\.

Doesn't that mean that there's a dev branch for this bug ?
Also, looking at the name, I thought it made sense, unless there's something I'm missing

#

ChrisLovering

[python-discord/bot] New comment on issue #2294: Zen command not using integer line when followed by words\.

Interesting, I don't see that.

@minalike could you self assign if you're working on this

#

jchristgit

[python-discord/site] Pull request review submitted: #765 Migrate on\_command\_error pin

This looks good, but I think we should be using four-space indents here, shouldn't we?

#

wookie184

[bot:update\-autoreview\-system] 144 new commits

6ca77ac Add patreon role configuration - mathstrains21
a44e798 Create patreon.py and add setup - mathstrains21
526ce5f Merge branch 'python-discord:main' into patreon - mathstrains21
380dd5c Add patron message when someone gains a patron ... - mathstrains21
b38ec72 Merge branch 'patreon' of https://github.com/ma... - mathstrains21

odd spireBOT Oct 19, 2022, 10:34 AM

#

[python-discord/bot] Checks Successful on PR: #2245 Update autoreview system

GitHub Actions run 3280801839 succeeded.

PR Author

Workflow Run

Lint & Test #3230

Source Branch

update-autoreview-system

regal archBOT Oct 19, 2022, 10:49 AM

#

wookie184

[bot:update\-autoreview\-system] 1 new commit

8fe3e9d Calculate 'now' once to ensure it is constant f... - wookie184

#

wookie184

[python-discord/bot] New comment on pull request #2245: Update autoreview system

whoops, didn't mean to commit those constants changes 😓

odd spireBOT Oct 19, 2022, 10:52 AM

#

[python-discord/bot] Checks Successful on PR: #2245 Update autoreview system

GitHub Actions run 3280915929 succeeded.

PR Author

Workflow Run

Lint & Test #3231

Source Branch

update-autoreview-system

regal archBOT Oct 19, 2022, 10:53 AM

#

wookie184

[bot] Branch update\-autoreview\-system was force-pushed to `2419014`

odd spireBOT Oct 19, 2022, 10:56 AM

#

[python-discord/bot] Checks Successful on PR: #2245 Update autoreview system

GitHub Actions run 3280936136 succeeded.

PR Author

Workflow Run

Lint & Test #3232

Source Branch

update-autoreview-system

regal archBOT Oct 19, 2022, 10:56 AM

#

wookie184

[python-discord/bot] Pull request closed: #2245 Update autoreview system

#

wookie184

[bot:main] 17 new commits

1d6d21d Implement new autoreview system. - wookie184
5047667 Remove now unused scheduler from talentpool - wookie184
4e59178 Make handling of reviews over multiple messages... - wookie184
eaecf34 Dont await tasks.loop methods - wookie184
52757d2 Fix message detection and remove unused parameter - wookie184

#

wookie184

[python-discord/bot] branch deleted: update\-autoreview\-system

#

wookie184

[python-discord/bot] Issue closed: #1746 Updates to nomination review system posting conditions

#

wookie184

[python-discord/bot] New review comment on pull request #2245: Update autoreview system

True, fixed 👍

oak estuaryBOT Oct 19, 2022, 11:02 AM

#

Python Bot

Connected!

odd spireBOT Oct 19, 2022, 11:02 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3280987147 succeeded.

Actor

Workflow Run

Deploy #733

Commit

e453a16

regal archBOT Oct 19, 2022, 11:09 AM

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2286: \#2257 the title in help commands is too large\.

        # Embed titles have a length limits, so we trim here.

having a number out of context in a comment isn't very useful.

I know it links to the issue you are fixing, but in 2 months when someone looks at this code, they won't.
Linking the comment to the issue doesn't really add anything, since we already explain why we need to do this.

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2286: \#2257 the title in help commands is too large\.

a title of 256 characters is far too long. I know discord allows it to be this long, but that doesn't mean it would be a good title.

        embed = Embed(
            colour=Colour.red(),
            title=textwrap.shorten(error, width=150, placeholder="…"),
        )

Doing something like this, where we limit to 150 characters, and also append an ellipses would be better IMO.

This suggestion will also require an import textwrap at the top of the file.

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2286 \#2257 the title in help commands is too large\.

#

lemonsaurus

[python-discord/branding] Pull request review submitted: #192 Add partying lemoji

Dude! I totally missed out on this PR. This was a very nice birthday gift, and of course, it's an excellent emoji as always. I need this in my life.

Thank you @gustavwilliam. 🔥 🐶 🔥

#

lemonsaurus

[python-discord/branding] Pull request closed: #192 Add partying lemoji

#

lemonsaurus

[branding:main] 2 new commits

7341a37 Add lemon partying - gustavwilliam
b1e2c62 Merge pull request #192 from python-discord/lem... - lemonsaurus

#

lemonsaurus

[python-discord/branding] branch deleted: lemoji/partying

odd spireBOT Oct 19, 2022, 11:13 AM

#

[python-discord/branding] Workflow Successful

GitHub Actions run 3281061830 succeeded.

Actor

lemonsaurus

Workflow Run

Event Validation #110

Commit

b1e2c62

regal archBOT Oct 19, 2022, 11:13 AM

#

lemonsaurus

[python-discord/branding] New comment on pull request #192: Add partying lemoji

also, this emoji could have had a disasterous name, but you have tactically dodged this bullet, for which I applaud you. Nuff said.

regal archBOT Oct 19, 2022, 12:46 PM

#

minalike

[python-discord/bot] New comment on issue #2294: Zen command not using integer line when followed by words\.

Hm? No I am not working on this issue.

#

ChrisLovering

[python-discord/bot] New comment on issue #2294: Zen command not using integer line when followed by words\.

Alright cool, your creation of this branch made it seem like you were https://github.com/python-discord/bot/tree/zen-args-fix

#

shtlrs

[python-discord/bot] New comment on issue #2294: Zen command not using integer line when followed by words\.

@ChrisLovering I can take this if you'll assign it to me

regal archBOT Oct 19, 2022, 6:59 PM

#

kkrypt0nn

[python-discord/bot] Issue opened: #2297 Add a \`doesntwork\` or similar tag

People tend to just send in help channels or similar such messages

Hey, can you help me? My code doesn't work.

Although we may have a code snippet from them, which may not be the source of the issue, there is a lot of valuable information that is lost. Useful information would contain things like

What is the user's end goal?
What is the current behaviour of the code? Is it working until some point or not starting at all?
What are some solutions the user has tried?
What is th...

regal archBOT Oct 19, 2022, 7:39 PM

#

MarkKoz

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

I personally don't know if it's possible to dynamically generate doc strings, but a quick search will help me find out.

I am not certain, but you can look into appending to the function's __doc__ attribute.

So if it's indeed possible, should we try going in that direction ?

I'm fine with it. Does anyone else have objections?

odd spireBOT Oct 19, 2022, 8:32 PM

#

[python-discord/bot] Checks Successful on PR: #2287 Bump bot-core to 8.2.1 and bump other deps to latest

GitHub Actions run 3257549005 succeeded.

PR Author

Workflow Run

Lint & Test #3220

Source Branch

bump-bot-core

regal archBOT Oct 19, 2022, 9:38 PM

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #1126: Remove calls to deprected \`\.flatten\` method\.

I don't think a break works here, since we do want to iterate over all the reactions in this case.

What I will do though, is make users a set, since we don't the same user showing up twice.

#

TizzySaurus

[sir-lancebot] Branch fix\-issue\-1120 was force-pushed to `08bf905`

odd spireBOT Oct 19, 2022, 9:43 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1126 Remove calls to deprected `.flatten()` method.

GitHub Actions run 3285190713 succeeded.

PR Author

Workflow Run

Lint #2503

Source Branch

fix-issue-1120

regal archBOT Oct 19, 2022, 9:49 PM

#

TizzySaurus

[sir-lancebot:fix\-issue\-1120] 1 new commit

db35e5e Add break statement to loop to make its funct... - TizzySaurus

odd spireBOT Oct 19, 2022, 9:50 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1126 Remove calls to deprected `.flatten()` method.

GitHub Actions run 3285225947 succeeded.

PR Author

Workflow Run

Lint #2504

Source Branch

fix-issue-1120

regal archBOT Oct 19, 2022, 10:01 PM

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1121: TypeError: object of type 'NoneType' has no len

random.choice will error on an empty sequence, so we should handle it being None/an empty array before trying to do that.
Right, that makes sense. What do we actually want to do in the event that .get("results") or selection_id ends up being None?

In fact, reading through the code and [API documentation](https://developers.themoviedb...

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1122: AttributeError: 'NoneType' object has no attribute 'id'

I believe this should be fixed by moving the listener adding to after update_page is called.

Looking through the code I don't see an issue with moving the listeners to below the update_page, and update_page defines self.message if it's not already defined meaning it'd no longer be None.

TL;DR; I agree with your assessment.

If no one else picks this up in the next fews days then I will.

regal archBOT Oct 19, 2022, 10:30 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request review submitted: #1126 Remove calls to deprected \`\.flatten\` method\.

regal archBOT Oct 19, 2022, 11:09 PM

#

shtlrs

[python-discord/bot] Pull request opened: #2298 change the signature to include a "zen\_rule\_index"

closes #2294

The change here was as simple as applying the signature that @ChrisLovering has suggested, which is quite is similar to the way we search for rules.

#

shtlrs

[python-discord/bot] New comment on pull request #2298: change the signature to include a "zen\_rule\_index"

@ChrisLovering Take it away !

odd spireBOT Oct 19, 2022, 11:11 PM

#

[python-discord/bot] Checks Successful on PR: #2298 change the signature to include a "zen_rule_index"

GitHub Actions run 3285611060 succeeded.

PR Author

Workflow Run

Lint & Test #3234

Source Branch

shtlrs:issue-2294-zen-command

#

[python-discord/bot] Checks Successful on PR: #2298 change the signature to include a "zen_rule_index"

GitHub Actions run 3285620486 succeeded.

PR Author

Workflow Run

Lint & Test #3235

Source Branch

shtlrs:issue-2294-zen-command

regal archBOT Oct 19, 2022, 11:31 PM

#

ionite34

[python-discord/sir-lancebot] Pull request review submitted: #1126 Remove calls to deprected \`\.flatten\` method\.

#

ionite34

[python-discord/sir-lancebot] New review comment on pull request #1126: Remove calls to deprected \`\.flatten\` method\.

Time complexity in this part seems like it can be better, currently iterates for 2N times for N total users reacted. For 2 reactions, each with 500 users, currently, we iterate a constant of 2000 times (for loop that builds list + list.count) on each new reaction.

Suggest this as an alternative:
In the same case of 1000 users, this would iterate a best case of 1 time and a worst case of 500 times.

@staticmethod
async def already_reacted(new_reaction: discord.Reaction, user: Union...

regal archBOT Oct 20, 2022, 12:15 AM

#

thegamecracks

[python-discord/bot] Issue opened: #2299 timeit does not evaluate setup code when using the version switcher button

When using the timeit command with a setup block and clicking the "Run in 3.10/3.11" button, any variables previously defined in the are no longer present, typically producing NameErrors in the resulting job:

It appears that the PythonVersionSwitcherButton does not store the commandline arguments used in the initial execution which leaves out the setup code ...

odd spireBOT Oct 20, 2022, 2:10 AM

#

[python-discord/site] Checks Successful on PR: #765 Migrate on_command_error pin

GitHub Actions run 3286309313 succeeded.

PR Author

Robin5605

Workflow Run

Lint & Test #1298

Source Branch

Robin5605:discordpy-error-handling

odd spireBOT Oct 20, 2022, 5:06 AM

#

[python-discord/site] Checks Successful on PR: #781 Bump pyjwt from 2.5.0 to 2.6.0

GitHub Actions run 3286954185 succeeded.

PR Author

Workflow Run

Lint & Test #1299

Source Branch

dependabot/pip/pyjwt-2.6.0

regal archBOT Oct 20, 2022, 7:35 AM

#

wookie184

[python-discord/bot] New review comment on pull request #2298: change the signature to include a "zen\_rule\_index"

Better to use the style mentioned in our style guide https://www.pythondiscord.com/pages/guides/pydis-guides/contributing/style-guide/#bracket-and-item-arrangement

async def zen(
    self, 
    ctx: Context,
    zen_rule_index: int | None,         
    *, 
    search_value: Union[int, str, None] = None
) -> None:

#

shtlrs

[python-discord/bot] New review comment on pull request #2298: change the signature to include a "zen\_rule\_index"

You are definitely right, my bad.
Applied the suggestion

odd spireBOT Oct 20, 2022, 7:43 AM

#

[python-discord/bot] Checks Successful on PR: #2298 change the signature to include a "zen_rule_index"

GitHub Actions run 3287711484 succeeded.

PR Author

Workflow Run

Lint & Test #3236

Source Branch

shtlrs:issue-2294-zen-command

regal archBOT Oct 20, 2022, 7:58 AM

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1121: TypeError: object of type 'NoneType' has no len

random.choice will error on an empty sequence, so we should handle it being None/an empty array before trying to do that.
Right, that makes sense.

What do we actually want to do in the event that .get("results") or selection_id ends up being None?

I don't think there's any reason it should be None so probably send a message to the user saying no results were found and maybe log a warning so we can look into it.

In fact, reading through [the code](https://...

#

wookie184

[python-discord/bot] New comment on pull request #2008: fix: check for the modteam role before reassigning the user's moderation role

Changed my mind again, I think this can just be closed :)

#

wookie184

[python-discord/bot] Pull request closed: #2008 fix: check for the modteam role before reassigning the user's moderation role

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2298 change the signature to include a "zen\_rule\_index"

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2298: change the signature to include a "zen\_rule\_index"

        self,
        ctx: Context,
        zen_rule_index: int | None,
        *,
        search_value: Union[int, str, None] = None

#

ChrisLovering

[python-discord/bot] New review comment on pull request #2298: change the signature to include a "zen\_rule\_index"

            search_value: str | None = None

An int would never be used here, as it would be picked up with the index arg first. if the user provides two ints, then only the first will be used anyway.

#

shtlrs

[python-discord/bot] New review comment on pull request #2298: change the signature to include a "zen\_rule\_index"

That's true

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1093: Make date formats consistent for \`\.github\` embeds

If the status gets approved can I be assigned this issue?

There's still not really a conclusion on what should be changed for each part (apart from the second part).

odd spireBOT Oct 20, 2022, 8:08 AM

#

[python-discord/bot] Checks Successful on PR: #2298 change the signature to include a "zen_rule_index"

GitHub Actions run 3287870246 succeeded.

PR Author

Workflow Run

Lint & Test #3237

Source Branch

shtlrs:issue-2294-zen-command

regal archBOT Oct 20, 2022, 8:09 AM

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2298 change the signature to include a "zen\_rule\_index"

#

wookie184

[python-discord/bot] Pull request review submitted: #2298 change the signature to include a "zen\_rule\_index"

Looks good, thanks!

#

wookie184

[python-discord/bot] Pull request closed: #2298 change the signature to include a "zen\_rule\_index"

#

wookie184

[bot:main] 5 new commits

e57c6aa change the signature to include a "zen_rule_index" - Amrou Bellalouna
05b636e update doc strings to reflect the usage of the ... - Amrou Bellalouna
c5aaccb apply style guidelines to signature - Amrou Bellalouna
5556a60 remove int from search_value's type union - Amrou Bellalouna
1e18187 Merge pull request #2298 from shtlrs/issue-2294... - wookie184

#

wookie184

[python-discord/bot] Issue closed: #2294 Zen command not using integer line when followed by words\.

odd spireBOT Oct 20, 2022, 8:19 AM

#

[python-discord/bot] Workflow Successful

GitHub Actions run 3287946597 succeeded.

Actor

Workflow Run

Deploy #734

Commit

1e18187

oak estuaryBOT Oct 20, 2022, 8:19 AM

#

Python Bot

Connected!

regal archBOT Oct 20, 2022, 8:28 AM

#

Ibrahim2750mi

[python-discord/sir-lancebot] New comment on issue #1093: Make date formats consistent for \`\.github\` embeds

@wookie184 For the first part I think these lines are concerned

We could use either dd/mm/yyyy or mm/dd/yyyy for both.

Don't know about the third part, I think its better the way its now.

#

wookie184

[python-discord/sir-lancebot] New comment on issue #1093: Make date formats consistent for \`\.github\` embeds

@wookie184 For the first part I think these lines are concerned
* https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/utilities/githubinfo.py#L350-L351
* https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/utilities/githubinfo.py#L264

We could use either dd/mm/yyyy or mm/dd/yyyy for both.

I would be happy with using dd/mm/yyyy for both although others may prefer using timestamps not in the footer so it's localised (CC @minalike?), i'...

#

wookie184

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

I'd be fine with that. I also think a static command displaying the aliases would be fine if that doesn't work, i.e. not displaying rule text or taking any arguments, just displaying all the keywords along with each rule number.

odd spireBOT Oct 20, 2022, 9:24 PM

#

[python-discord/forms-backend] Checks Successful on PR: #218 Bump uvicorn from 0.18.2 to 0.19.0

GitHub Actions run 3293032894 succeeded.

PR Author

Workflow Run

Forms Backend #596

Source Branch

dependabot/pip/uvicorn-0...

#

[python-discord/forms-backend] Checks Successful on PR: #219 Bump sentry-sdk from 1.9.3 to 1.10.0

GitHub Actions run 3293034664 succeeded.

PR Author

Workflow Run

Forms Backend #597

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Oct 21, 2022, 1:26 AM

#

Aayush2005

[python-discord/bot] Issue opened: #2300 TypeError: function argument 'code' must be code, not str

I was trying to run the source coded of the Python Bot , I have all the modules installed with correct versions , still it is raising error starting from bot-main\bot__main__.py", line 3, in import aiohttp

ending with
class CeilTimeout(async_timeout.timeout): TypeError: function() argument 'code' must be code, not str

regal archBOT Oct 21, 2022, 1:58 AM

#

MarkKoz

[python-discord/bot] New comment on issue #2300: TypeError: function argument 'code' must be code, not str

This error was reported here https://github.com/aio-libs/aiohttp/issues/6794 Do any of the comments there help you resolve this issue?

#

Aayush2005

[python-discord/bot] New comment on issue #2300: TypeError: function argument 'code' must be code, not str

I tried all of them , none helped !
also I reinstalled all the modules required for the execution with the supported versions .

`Traceback (most recent call last):
File "c:\Users\aayus\Downloads\bot-main\bot_main_.py", line 3, in <module>
import aiohttp
File "C:\Users\aayus\AppData\Local\Programs\Python\Python39\lib\site-packages\aiohttp_init_.py", line 6, in <module>
from .client import (
File "C:\Users\aayus\AppData\Local\Programs\Python\Python39\lib\site-packa...

#

MarkKoz

[python-discord/bot] New comment on issue #2300: TypeError: function argument 'code' must be code, not str

Are you using the latest code from the repository? We've fairly recently moved the bot to be on Python 3.10, but it appears you're still using 3.9. If you used Poetry to install the dependencies, as is intended, then it would've warned you about that or even failed I think.

odd spireBOT Oct 21, 2022, 5:06 AM

#

[python-discord/site] Checks Successful on PR: #782 Bump sentry-sdk from 1.9.10 to 1.10.0

GitHub Actions run 3294905898 succeeded.

PR Author

Workflow Run

Lint & Test #1300

Source Branch

dependabot/pip/sentry-sdk...

odd spireBOT Oct 21, 2022, 10:11 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1127 Bump pip-licenses from 3.5.4 to 3.5.5

GitHub Actions run 3296590483 succeeded.

PR Author

Workflow Run

Lint #2505

Source Branch

dependabot/pip/pip-licenses-3.5.5

#

[python-discord/sir-lancebot] Checks Successful on PR: #1128 Bump sentry-sdk from 1.9.10 to 1.10.0

GitHub Actions run 3296598752 succeeded.

PR Author

Workflow Run

Lint #2506

Source Branch

dependabot/pip/sentry-sdk-1.10.0

odd spireBOT Oct 21, 2022, 12:38 PM

#

[python-discord/site] Checks Successful on PR: #773 Add guide for working with Python on Windows

GitHub Actions run 3297456925 succeeded.

PR Author

Workflow Run

Lint & Test #1301

Source Branch

add-windows-guide

regal archBOT Oct 21, 2022, 1:30 PM

#

wookie184

[site:add\-windows\-guide] 1 new commit

65a3ee2 Wrap lines and make some more changes - wookie184

odd spireBOT Oct 21, 2022, 1:34 PM

#

[python-discord/site] Checks Successful on PR: #773 Add guide for working with Python on Windows

GitHub Actions run 3297814039 succeeded.

PR Author

Workflow Run

Lint & Test #1302

Source Branch

add-windows-guide

regal archBOT Oct 21, 2022, 2:53 PM

#

wookie184

[site:add\-windows\-guide] 1 new commit

f072093 Made some changes after proof-reading - wookie184

odd spireBOT Oct 21, 2022, 2:56 PM

#

[python-discord/site] Checks Successful on PR: #773 Add guide for working with Python on Windows

GitHub Actions run 3298367080 succeeded.

PR Author

Workflow Run

Lint & Test #1303

Source Branch

add-windows-guide

regal archBOT Oct 21, 2022, 3:02 PM

#

wookie184

[python-discord/site] New comment on pull request #773: Add guide for working with Python on Windows

This still isn't quite finished, but it'd be good to get some reviews on the content. Please leave a comment if you think there's anything that should be added (you can take a look at the linked issues for ideas).

regal archBOT Oct 21, 2022, 3:23 PM

#

mbaruh

[python-discord/site] New comment on pull request #773: Add guide for working with Python on Windows

Thanks for this! A few immediate comments:

Should we maybe have a subdirectory for all of this? an issue might encompass several of those articles, and they're relativeley scattered in the currently resulting list of guides..
Is "Don't use the py installer" a stance we want to take? I'm not a fan of it myself, but maybe it would be wiser to have a general page about it, with a section about caveats to watch out for.
In the PATH section, I think it's worth noting that if it contains...

regal archBOT Oct 21, 2022, 4:06 PM

#

wookie184

[python-discord/site] New comment on pull request #773: Add guide for working with Python on Windows

* Should we maybe have a subdirectory for all of this? an issue might encompass several of those articles, and they're relatively scattered in the currently resulting list of guides..

Yeah, that would probably make sense

* Is "Don't use the py installer" a stance we want to take? I'm not a fan of it myself, but maybe it would be wiser to have a general page about it, with a section about caveats to watch out for.

WDYM by "py installer"?

* In the PATH section, I thi...

regal archBOT Oct 21, 2022, 4:30 PM

#

wookie184

[python-discord/bot] Issue opened: #2301 Nominations: Fix logic for when to send a new vote

Currently if a vote is archived within a day of being sent, a new vote can be sent immediately, even though a day hasn't passed since that vote was archived.

We should fix this by using redis to cache the date of when the most recent nomination was sent. Then we'll check if it's been a day since this date, even if the nomination was archived.

#

wookie184

[python-discord/bot] Issue opened: #2302 Nominations: Take into account activity when reviewing

We should check that a user has been active in the past 7 days before choosing them to review.

This will require an endpoint on site that queries metricity for a user's message count.

I don't think we need to worry about clearing out users that stop being active completely in this issue, it might be better to update the !tp list command to display activity information somehow so they can be cleared out every now and again.

#

mbaruh

[python-discord/site] New comment on pull request #773: Add guide for working with Python on Windows

WDYM by "py installer"?

Oh sorry I meant the microsoft store page.

maybe it should be moved to another point on that page or made more obvious?

Ah I missed that. yeah maybe it should be in the form of "this is what you need to make sure of to make it work"

#

wookie184

[python-discord/bot] Issue opened: #2303 Nominations: \`\!talentpool queue\` command

This would allow queueing a user to be reviewed next rather than using the autoreviewer. A mod could run !tp q 493839819168808962 and that user would be reviewed when the reviewer is next ready, returning to the autoreviewer after the queue is empty.

We should also have a !tp queue clear command to clear the queue, and a !tp queue list command to show the current queue members.

#

wookie184

[python-discord/site] New comment on pull request #773: Add guide for working with Python on Windows

WDYM by "py installer"?

Oh sorry I meant the microsoft store page.

Well, I don't think we should recommend that people use it (due to said caveats), so i'm not sure what else would be on such a page (maybe how to uninstall it lol).

maybe it should be moved to another point on that page or made more obvious?

Ah I missed that. yeah maybe it should be in the form of "this is what you need to make sure of to make it work"

👍

#

mbaruh

[python-discord/bot] New comment on issue #2302: Nominations: Take into account activity when reviewing

Something else that can be done automatically is unnominate anyone who hasn't been active in the past ~3 months (with a suitable message in chat).

regal archBOT Oct 21, 2022, 5:59 PM

#

shtlrs

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

@MarkKoz I think that changing that dynamically is going to be a PITA concerning how simple this should be.
The doc dunder attribute is not writable, which throws an AttributeError upon trying to modify/write to it.

So we could go with @wookie184's approach here, and we have a static command that fetches the rules & kws & maybe even cache them per rule number ?

No need to make the http request each & every time, WDYT?

regal archBOT Oct 21, 2022, 7:05 PM

#

MarkKoz

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

I think that changing that dynamically is going to be a PITA concerning how simple this should be.
The doc dunder attribute is not writable, which throws an AttributeError upon trying to modify/write to it.

Seems pretty straight forward. I don't know why you'd get an error.

>>> def foo():
...     """hello world"""
>>> foo.__doc__
'hello world'
>>> foo.__doc__ = "1"
>>> foo.__doc__
'1'
>>>

we have a static command that fetches the rules & kws & maybe even cache...

regal archBOT Oct 21, 2022, 9:06 PM

#

Keyacom

[python-discord/bot] New comment on pull request #2285: Add slicing tag

Thanks for writing this, the structure of this tag is good, although I think some of the information isn't necessary. It's best to keep tags short and snappy, otherwise people wont read them.

I've tried condensing the tag down a bit, could you take a look and see what you think and maybe merge both our versions togther?

Yes, I consider that feasible, but keep in mind that sentences must start with a capital letter. In line 6:

- *slicing* is a way of accessing a part of a...

#

wookie184

[python-discord/bot] New comment on issue #2303: Nominations: \`\!talentpool queue\` command

Thoughts on what the best way to persist this queue would be?

#

Keyacom

[python-discord/bot] New review comment on pull request #2285: Add slicing tag

By now, even I don't think they are necessary.

#

Keyacom

[python-discord/bot] New review comment on pull request #2285: Add slicing tag

Woops, I just didn't notice that.

odd spireBOT Oct 21, 2022, 9:12 PM

#

[python-discord/forms-backend] Checks Successful on PR: #220 Bump sentry-sdk from 1.9.3 to 1.10.1

GitHub Actions run 3300479672 succeeded.

PR Author

Workflow Run

Forms Backend #598

Source Branch

dependabot/pip/sentry-sd...

regal archBOT Oct 21, 2022, 9:18 PM

#

wookie184

[python-discord/site] Issue opened: #783 Endpoint for getting activity from metricity

This issue is required for bot#2302

The endpoint should take a list of user IDs and a number of days (or just a timestamp?), and return the number of messages sent by each user from now up to the date/interval provided. This data is available through metricity.

The reason I suggest an endpoint taking multiple user IDs at once is that I assume it would be more efficient as a single query, as we may want to use this endpoint on all nominated users at once (e.g. to check for users in the tale...

regal archBOT Oct 22, 2022, 7:44 AM

#

Keyacom

[python-discord/bot] New review comment on pull request #2285: Add slicing tag

Another thing I didn't notice.

regal archBOT Oct 22, 2022, 8:28 AM

#

bast0006

[python-discord/bot] Issue opened: #2304 Nominations: Link previous nomination threads

It would be nice if we could add links to previous nomination threads to both !tp history and newly created nomination threads. As it stands, we have to search for the username in the discord thread history (and this isn't particularly great UX nor reliable).

Storing the thread ID for a nomination sounds like a good first step (and probably worth committing immediately even before other features are complete?), then searching through threads by username to attempt to rediscover old thread...

regal archBOT Oct 22, 2022, 10:11 AM

#

TizzySaurus

[sir-lancebot:fix\-issue\-1120] 1 new commit

38d1589 Improve time complexity of already_reacted fu... - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New review comment on pull request #1126: Remove calls to deprected \`\.flatten\` method\.

Done, thanks :+1:

odd spireBOT Oct 22, 2022, 10:13 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1126 Remove calls to deprected `.flatten()` method.

GitHub Actions run 3302882789 succeeded.

PR Author

Workflow Run

Lint #2507

Source Branch

fix-issue-1120

regal archBOT Oct 22, 2022, 10:23 AM

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1074: Use replied message as argument to \`\.randomcase\` when text isn't provided\.

It seems I forgot about this issue, but it's now back on my radar and will hopefully have a PR ready over the next week or two.

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1121: TypeError: object of type 'NoneType' has no len

I don't think there's any reason it should be None so probably send a message to the user saying no results were found and maybe log a warning so we can look into it.

Yep, that sounds good.

If we used the results from the first request we'd be much more limited in the results we got.

Right, I see. For some reason I was thinking that the initial response would include all entries, which isn't actually the case as you stated (it seems to return 20).

Side note: we may ...

regal archBOT Oct 22, 2022, 12:37 PM

#

wookie184

[bot:2301\-fix\-voting\-conditions] 1 new commit

afb2ff6 Store time of last vote in redis to prevent vot... - wookie184

#

wookie184

[python-discord/bot] New branch created: 2301\-fix\-voting\-conditions

#

wookie184

[python-discord/bot] Pull request opened: #2305 Store time of last vote in redis to prevent vote triggering early

Previously if a vote was sent and ended within a day a new one could be sent immediately.

Closes #2301

odd spireBOT Oct 22, 2022, 12:41 PM

#

[python-discord/bot] Checks Failed on PR: #2305 Store time of last vote in redis to prevent vote triggering early

GitHub Actions run 3303287447 failed.

PR Author

Workflow Run

Lint & Test #3239

Source Branch

2301-fix-voting-conditions

regal archBOT Oct 22, 2022, 12:56 PM

#

wookie184

[bot:2301\-fix\-voting\-conditions] 1 new commit

b065b24 Fix tests - wookie184

odd spireBOT Oct 22, 2022, 1:00 PM

#

[python-discord/bot] Checks Successful on PR: #2305 Store time of last vote in redis to prevent vote triggering early

GitHub Actions run 3303335392 succeeded.

PR Author

Workflow Run

Lint & Test #3240

Source Branch

2301-fix-voting-conditions

regal archBOT Oct 22, 2022, 4:01 PM

#

ChrisLovering

[sir-lancebot:fix\-issue\-1120] 2 new commits

6bbb12e Added Blurple and OG Blurple colours (#1125) - brad90four [ab0f39a`](https://github.com/python-discord/sir-lancebot/commit/ab0f39ad7195996fcb0a15fb3914b7b35a056782) Merge branch 'main' into fix-issue-1120 - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1126 Remove calls to deprected \`\.flatten\` method\.

#

ChrisLovering

[python-discord/sir-lancebot] branch deleted: fix\-issue\-1120

#

ChrisLovering

[sir-lancebot:main] 6 new commits

1934b18 Remove calls to the deprecated .flatten() method - TizzySaurus
08bf905 Remove unnecessary map() - TizzySaurus
db35e5e Add break statement to loop to make its funct... - TizzySaurus
38d1589 Improve time complexity of already_reacted fu... - TizzySaurus
ab0f39a Merge branch 'main' into fix-issue-1120 - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] Issue closed: #1120 AttributeError: 'async\_generator' object has no attribute 'flatten'

#

ChrisLovering

[sir-lancebot:dependabot/pip/sentry\-sdk\-1\.10\.0] 7 new commits

1934b18 Remove calls to the deprecated .flatten() method - TizzySaurus
08bf905 Remove unnecessary map() - TizzySaurus
db35e5e Add break statement to loop to make its funct... - TizzySaurus
38d1589 Improve time complexity of already_reacted fu... - TizzySaurus
ab0f39a Merge branch 'main' into fix-issue-1120 - ChrisLovering

odd spireBOT Oct 22, 2022, 4:02 PM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1126 Remove calls to deprected `.flatten()` method.

GitHub Actions run 3303855903 succeeded.

PR Author

Workflow Run

Lint #2508

Source Branch

fix-issue-1120

regal archBOT Oct 22, 2022, 4:03 PM

#

ChrisLovering

[python-discord/sir-lancebot] Pull request closed: #1128 Bump sentry\-sdk from 1\.9\.10 to 1\.10\.0

#

ChrisLovering

[sir-lancebot:main] 3 new commits

ac4ea79 Bump sentry-sdk from 1.9.10 to 1.10.0 - dependabot[bot]
f6eecfc Merge branch 'main' into dependabot/pip/sentry-... - ChrisLovering
4532159 Merge pull request #1128 from python-discord/de... - ChrisLovering

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #1127: Bump pip\-licenses from 3\.5\.4 to 3\.5\.5

@dependabot rebase

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #1127: Bump pip\-licenses from 3\.5\.4 to 3\.5\.5

@dependabot rebase

night lilyBOT Oct 22, 2022, 4:07 PM

#

Sir Lancebot

Connected!

odd spireBOT Oct 22, 2022, 4:07 PM

#

[python-discord/sir-lancebot] Workflow Successful

GitHub Actions run 3303868996 succeeded.

Actor

Workflow Run

Build #615

Commit

4532159

regal archBOT Oct 22, 2022, 4:19 PM

#

wookie184

[python-discord/bot] Issue opened: #2306 Nominations: Clean up

I'd like to:

Remove the cache of nominations, as we refresh it almost every time before using it anyway so it's pretty useless. It's also a potential for bugs in places we forget to keep it updated.
Convert the site response of nominations into dataclasses or pydantic models. This means we don't have to use dictionary accessing everywhere and makes my IDE happy because it knows the types. (I think pydantic would probably be easiest as it handles dictionary->model conversion automaticall...

regal archBOT Oct 22, 2022, 5:18 PM

#

ChrisLovering

[python-discord/sir-lancebot] New comment on pull request #1127: Bump pip\-licenses from 3\.5\.4 to 3\.5\.5

@dependabot recreate

regal archBOT Oct 22, 2022, 7:23 PM

#

wookie184

[bot:2306\-nominations\-cleanup] 3 new commits

1170b79 Use pydantic to model nominations and split API... - wookie184
ec8b5c5 Remove mark_reviewed command, cleanup and bug f... - wookie184
bd3da1e Fix tests - wookie184

#

wookie184

[python-discord/bot] New branch created: 2306\-nominations\-cleanup

#

wookie184

[python-discord/bot] Pull request opened: #2307 Talentpool Cleanup

Closes #2306. Not completely tested yet but should be good enough for a review.

odd spireBOT Oct 22, 2022, 7:28 PM

#

[python-discord/bot] Checks Successful on PR: #2307 Talentpool Cleanup

GitHub Actions run 3304429303 succeeded.

PR Author

Workflow Run

Lint & Test #3241

Source Branch

2306-nominations-cleanup

regal archBOT Oct 22, 2022, 7:40 PM

#

mbaruh

[bot:move\_security\_cog] 1 new commit

a39ce55 Move Security cog to backend extension - mbaruh

#

mbaruh

[python-discord/bot] New branch created: move\_security\_cog

#

mbaruh

[python-discord/bot] Pull request opened: #2308 Move Security cog to backend extension

That cog is out of place for the filters extension.

#

ChrisLovering

[python-discord/bot] Pull request review submitted: #2308 Move Security cog to backend extension

odd spireBOT Oct 22, 2022, 7:44 PM

#

[python-discord/bot] Checks Successful on PR: #2308 Move Security cog to backend extension

GitHub Actions run 3304472696 succeeded.

PR Author

Workflow Run

Lint & Test #3242

Source Branch

move_security_cog

regal archBOT Oct 22, 2022, 9:05 PM

#

shtlrs

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

My bad, what I meant is, we have another callback that fetches & composes the rules, and then the help argument in the command decorator will take that callback.

And what I also meant is that this callback will cache the results so that we don't have to get them over & over again.
But it'll require an instance of the API client to do that, is there a global instance we could use ? (from bot core maybe ?)

What do you think ?

#

shtlrs

[python-discord/bot] New comment on issue #2304: Nominations: Link previous nomination threads

@bast0006 IF you could explain what nominations are & how they work in a Nutshell, I'll gladly take this on once we finish planning it up

regal archBOT Oct 22, 2022, 10:58 PM

#

wookie184

[python-discord/bot] New comment on issue #2304: Nominations: Link previous nomination threads

@bast0006 IF you could explain what nominations are & how they work in a Nutshell, I'll gladly take this on once we finish planning it up

The talentpool is our system for getting new helpers (users with the "helper" role), and nominations are a part of this. The overview of how it works is:

Any helper can run the !nominate command (in a staff channel), to nominate someone they think could be a good helper
When a user is nominated they are put in a "pool" of users waiting to be ...

#

shtlrs

[python-discord/bot] New comment on issue #2304: Nominations: Link previous nomination threads

Thanks @wookie184, that's gives me a very good basic understanding of how it works!

Yes, I'll gladly wait on your PR then I'll tackle this if approved!

regal archBOT Oct 23, 2022, 3:39 AM

#

MarkKoz

[python-discord/bot] New comment on issue #2280: Add discoverability of keywords that point to particular rules

My bad, what I meant is, we have another callback that fetches & composes the rules, and then the help argument in the command decorator will take that callback.

Keep in mind discord.py expects a string value, not a function. It looks like @command(help=myfunc()) may work since this gets executed as the cog loads, and extensions are loaded after the Bot has already been created and has an APIClient.

But it'll require an instance of the API client to do that, is there a global inst...

regal archBOT Oct 23, 2022, 9:48 AM

#

TizzySaurus

[sir-lancebot:randomcase\-reply\-enhancement] 1 new commit

0fbca07 Add ability to reply to a message instead of pa... - TizzySaurus

#

TizzySaurus

[python-discord/sir-lancebot] New branch created: randomcase\-reply\-enhancement

#

TizzySaurus

[python-discord/sir-lancebot] Pull request opened: #1129 Add ability to use replied message's content as \`\.randomcase\` argument\.

Closes #1074.

Description

As per title.

Users can now reply to a message to its contents as the text argument, thanks to a call to botcore.utils.commands.clean_text_or_reply.

![image](https://user-images.githubusercontent.com/47674925/197385559-bc08af46-37ba-463d-90ba-2b8b2af...

#

TizzySaurus

[python-discord/sir-lancebot] New comment on issue #1074: Use replied message as argument to \`\.randomcase\` when text isn't provided\.

Managed to get it done in my spare time this morning -- #1129.

odd spireBOT Oct 23, 2022, 9:54 AM

#

[python-discord/sir-lancebot] Checks Successful on PR: #1129 Add ability to use replied message's content as `.randomcase` argument.

GitHub Actions run 3306624795 succeeded.

PR Author