Bad / dumb code | Brackeys Community | Page 1

mental void · 2023-02-09T21:07:31.354Z

if(player.GetComponent ()!=null){ player.GetComponent ().ApplyDamage(); } why is this code bad / dumb?

mental void Feb 9, 2023, 9:07 PM

#

if(player.GetComponent<someScript>()!=null){
player.GetComponent<someScript>().ApplyDamage();
}

why is this code bad / dumb?

queen spear Feb 9, 2023, 9:08 PM

#

Because you're calling GetComponent twice

#

on the same thing

#

use TryGetComponent instead

mental void Feb 9, 2023, 9:12 PM

#

can you explain more please

queen spear Feb 9, 2023, 9:13 PM

#

Which part, why it's bad? Or do you mean an example for TryGetComponent

mental void Feb 9, 2023, 9:13 PM

#

yeah example

#

on trygetcomponent

fresh fulcrum Feb 9, 2023, 9:13 PM

#

The docs have one https://docs.unity3d.com/ScriptReference/Component.TryGetComponent.html

mental void Feb 9, 2023, 9:15 PM

#

if i use try get component then how would call the method that is in component?

queen spear Feb 9, 2023, 9:16 PM

#

The docs give an example for that

#

if (TryGetComponent(out HingeJoint hinge))
{
    hinge.useSpring = false;
}

mental void Feb 9, 2023, 9:18 PM

#

i do not quite understand the parameter that is given to this function like out thing cause that is used in raycast i think

queen spear Feb 9, 2023, 9:19 PM

#

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/out-parameter-modifier

out parameter modifier - C# Reference

mental void Feb 9, 2023, 9:21 PM

#

ok what method would be better if there is no such thing as trygetcomponent in above code

queen spear Feb 9, 2023, 9:22 PM

#

There is tho

mental void Feb 9, 2023, 9:22 PM

#

assume that its not available i mean

queen spear Feb 9, 2023, 9:22 PM

#

Why would I assume that

#

You're literally already calling GetComponent. If you can call GetComponent, you can call TryGetComponent

mental void Feb 9, 2023, 9:25 PM

#

alright thanks for your time and help @queen spear
@fresh fulcrum appreciate it guys

#Bad / dumb code