What can be optimized here? | The San Andreas Multiplayer SAMP open.mp Official Community 🐧 | Page 1

scarlet hatch Oct 4, 2022, 5:41 PM

#

i can do my magic without profiling if i had your code

rancid coral Oct 4, 2022, 5:43 PM

#

wdym

scarlet hatch Oct 4, 2022, 5:43 PM

#

what i touch is optimised after

rancid coral Oct 4, 2022, 5:45 PM

#

can you touch Red Dead Redemption 2 code please

scarlet hatch Oct 4, 2022, 5:47 PM

#

unfortunately no, but lets be on-topic, post here an image with that html file viewed on an browser because i really can't view that on phone

urban shell Oct 4, 2022, 5:49 PM

#

30% of total time is spent in OnPlayerUpdate and OnPlayerKeyStateChange, so start there

scarlet hatch Oct 4, 2022, 5:51 PM

#

what you have in OnPlayerUpdate

rancid coral Oct 4, 2022, 5:51 PM

#

public OnPlayerUpdate(playerid)
{

TimerAFK[playerid] = gettime();
return 1;

}

scarlet hatch Oct 4, 2022, 5:55 PM

#

is not really bad, but u call gettime() everytime a player is sending packets to the server, and is calling every ~30ms, differs when the player is moving/idling

rancid coral Oct 4, 2022, 5:56 PM

#

Yes, but I can't think another way to see if the player is AFK or not

scarlet hatch Oct 4, 2022, 5:57 PM

#

a 1 sec timer will be good enough

rancid coral Oct 4, 2022, 5:58 PM

#

But with 1 sec timer there is no way to see if the player is online or not, OnPlayerUpdate is not called when the player is AFK that's how can i see if the player is AFK or not

scarlet hatch Oct 4, 2022, 5:59 PM

#

you can check if the player stays in a position more than 10 seconds or so, and if it stays, is afk (shit cooldown)

finite prairie Oct 4, 2022, 6:00 PM

#

If you use weapon-config,just use it's IsPlayerPaused function, basically the same as your check you are doing it twice if you have WC

rancid coral Oct 4, 2022, 6:01 PM

#

That may be a solution, but it can't guarantee if he's afk or not, btw I don't think a gettime uses a lot of resources.

Another solution I was thinking now is that in a 1 second timer I can gettime() and in OnPlayerUpdate TimerAFK[playerid] = gettimeVariable;

#

That way I dont have to call gettime a lot of times in a second.

I dont use WC.

scarlet hatch Oct 4, 2022, 6:05 PM

#

no

that is not really bad for your server, gettime() isn't an resource eater, maybe you have some includes which are hooking OnPlayerUpdate, which can do a lot more

urban shell Oct 4, 2022, 6:07 PM

#

that one line of code can't cause a self time of 20% and a total time of 30%

rancid coral Oct 4, 2022, 6:07 PM

#

I think the only include hooking OnPlayerUpdate is Nex-AC

scarlet hatch Oct 4, 2022, 6:07 PM

#

bingo, i looked in nex-ac some times ago, and yeah, is doing a lot of operations in OnPlayerUpdate

rancid coral Oct 4, 2022, 6:23 PM

#

Uhmm

#

So, nothing that I can do to optimize more.

scarlet hatch Oct 4, 2022, 6:27 PM

#

well, look at your code

rancid coral Oct 4, 2022, 6:31 PM

#

I'm only using 5 or 6 nex-ac anticheats, I think if I write them in my gamemode and stop using nex-ac can reduce onplayerupdate usage?

scarlet hatch Oct 4, 2022, 6:38 PM

#

write them in a better way

rancid coral Oct 4, 2022, 6:39 PM

#

Yes, AFAIK nex-ac is "very" optimized

#What can be optimized here?