#Possibly change Message.startThread to accept an object

13 messages · Page 1 of 1 (latest)

deep stump
turbid temple

Perhaps. GuildChannelManager#create takes an object (although it has a lot more params), and so does GuildMember#ban (which only has two)

But some methods like GuildEmojiManager#create take both "regular" parameters and an optional object

deep stump

I'm just saying that because the transition from message.startThread to threadManager.create is very annoying

and recently there's been a lot of changes in the direction of using objects all across the lib

so it makes sense to me

turbid temple

You should probably get input from maintainers and other people. I think its a good idea

Maybe change some other methods, too

deep stump

what other methods?

turbid temple

manager #create methods

deep stump

and yeah i want input from maintainers but this thread was ignored lol

deep stump

Possibly change Message.startThread to accept an object

hexed tundraBOT

pr_open #6244 in discordjs/discord.js by ImRodry opened <t:1627695334:R> (review required)
refactor(Message): accept a single object instead of 3 arguments
📥 npm i ImRodry/discord.js#startthread-refactor