tepid vineBOT May 10, 2023, 1:26 PM

#

create-discord-bot

tepid vineBOT May 15, 2023, 7:23 PM

#

Jiralite

[discordjs/discord.js] New comment on pull request #9570: feat$create\-discord\-bot$: Add prompts, command handler and deployment script

I'm getting some errors picked up by ESLint in the template directory, but the lint script does not check that. Should that be tweaked?

tepid vineBOT May 22, 2023, 7:22 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9570 feat$create\-discord\-bot$: Add prompts, command handler and deployment script

#

Jiralite

[discordjs/discord.js] New review comment on pull request #9570: feat$create\-discord\-bot$: Add prompts, command handler and deployment script

@suneettipirneni missed this (and the JavaScript version)?

#

suneettipirneni

[discord.js:refactor/create\-discord\-bot/prompts] 1 new commit

38165fb fix: remove uneeded listeners - suneettipirneni

tepid vineBOT May 25, 2023, 4:49 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9570 feat$create\-discord\-bot$: Add prompts, command handler and deployment script

tepid vineBOT May 25, 2023, 9:59 PM

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9570 feat$create\-discord\-bot$: Add prompts, command handler and deployment script

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9570: feat$create\-discord\-bot$: Add prompts, command handler and deployment script

as I rember from my case
exiting program here will make it undefined
so you should check if it isnt

tepid vineBOT May 28, 2023, 6:53 AM

#

sdanialraza

[discordjs/discord.js] Issue opened: #9603 feat$create\-discord\-bot$: enhancements request for TypeScript template

Which application or package is this feature request for?

create-discord-bot

Feature

I really like the progress so far with this package, but there are a few things I'd like to request to do with the TypeScript template:

It would be a good idea for the tool to not install the packages automatically so the user can install them whenever they want.
Upon running the command using the TypeScript template, and waiting for everything to install. It shows this error [here](ht...

tepid vineBOT May 28, 2023, 9:40 AM

#

jaw0r3k

[discordjs/discord.js] Pull request opened: #9604 chore: add \`no\-install\` option and minor fixes

Please describe the changes this PR makes and why it should be merged:
Resolves: #9603

copilot:walkthrough

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added)

tepid vineBOT May 28, 2023, 12:45 PM

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9604 chore: add \`no\-install\` option and minor fixes

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9604: chore: add \`no\-install\` option and minor fixes

Souji's pr extends that

tepid vineBOT Jun 9, 2023, 8:53 AM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9604 chore: add \`no\-install\` option and minor fixes

#

vladfrangu

[discordjs/discord.js] New review comment on pull request #9604: chore: add \`no\-install\` option and minor fixes

Why was this changed again?

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9604 chore: add \`no\-install\` option and minor fixes

#

vladfrangu

[discordjs/discord.js] New review comment on pull request #9604: chore: add \`no\-install\` option and minor fixes

I see it was changed in https://github.com/discordjs/discord.js/pull/9570 too, so ignore this. That said, changing it here and in that PR will probably cause merge conflicts

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9604 chore: add \`no\-install\` option and minor fixes

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9570 feat$create\-discord\-bot$: Add prompts, command handler and deployment script

tepid vineBOT Jun 12, 2023, 6:16 PM

#

suneettipirneni

[discord.js] Branch refactor/create\-discord\-bot/prompts was force-pushed to `23f43d1`

Compare changes

tepid vineBOT Jul 6, 2023, 1:33 PM

#

malezjaa

[discordjs/discord.js] Pull request opened: #9687 feat(cli): improve CLI functionality

Description:

Hey!

This pull request aims to enhance the project configuration process and make it more user-friendly and enjoyable.

Changes Made:

Implemented a guided prompt system using the @clack/prompts library to provide users with a smoother and more intuitive project setup experience.
Improved the style of messages displayed during the project configuration.

Testing:

Manually tested the project setup process, ensuring that the prompts fun...

#

Jiralite

[discordjs/discord.js] New comment on pull request #9687: feat(cli): improve CLI functionality

Have you seen #9570?

#

malezjaa

[discordjs/discord.js] New comment on pull request #9687: feat(cli): improve CLI functionality

Oh. xd

#

malezjaa

[discordjs/discord.js] New comment on pull request #9687: feat(cli): improve CLI functionality

Why couldn't this have been merged earlier?

#

Jiralite

[discordjs/discord.js] New comment on pull request #9687: feat(cli): improve CLI functionality

It is not merged/

#

malezjaa

[discordjs/discord.js] New comment on pull request #9687: feat(cli): improve CLI functionality

Pardon me, I meant, why wasn't this merged at all?

tepid vineBOT Jul 6, 2023, 2:24 PM

#

malezjaa

[discordjs/discord.js] Pull request closed: #9687 feat(cli): improve CLI functionality

tepid vineBOT Jul 7, 2023, 12:32 PM

#

TetieWasTaken

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

TetieWasTaken

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

const rest = new REST().setToken(process.env.TOKEN);

#

TetieWasTaken

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

const rest = new REST().setToken(process.env.TOKEN!);

tepid vineBOT Jul 15, 2023, 8:03 PM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #9604 chore: add `no-install` option and minor fixes

tepid vineBOT Jul 15, 2023, 11:39 PM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

sdanialraza

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

	/** @type {import('../events/index.js').Event<Events.InteractionCreate>} */

#

sdanialraza

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

		name: Events.InteractionCreate,

#

sdanialraza

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

/** @type {import('./index.js').Event<Events.ClientReady>} */

#

sdanialraza

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

	const interactionCreateEvent: Event<Events.InteractionCreate> = {

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

suneettipirneni

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script


/** @type {import('./index.js').Event<Events.ClientReady>} */

Is there a specific reason you want to do this? It seems to be more of a stylistic choice.

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

sdanialraza

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

Because I think it's a good idea to use these enums when possible.

tepid vineBOT Jul 16, 2023, 12:34 AM

#

D4isDAVID

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

D4isDAVID

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

 * Defines the structure of a command.
 *
 * @typedef {object} Command

Just another nitpick

#

D4isDAVID

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

 * @type {import('../util/loaders.js').StructurePredicate<Command>}

This doesn't accept a predicate, it is a predicate

#

D4isDAVID

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

directoryStats already exists, isn't this redundant?

tepid vineBOT Jul 16, 2023, 3:08 PM

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

iCrawl

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

Use 0 if you turn off rules.

tepid vineBOT Jul 16, 2023, 4:13 PM

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

suneettipirneni

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

I'd rather keep this explicit.

#

suneettipirneni

[discord.js:refactor/create-discord-bot/prompts] 1 new commit

eb1e460 fix: remaining requested changes - suneettipirneni

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

D4isDAVID

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

D4isDAVID

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

 * @property {import('discord.js').RESTPostAPIApplicationCommandsJSONBody} data The data for the command
 * @property {(interaction: import('discord.js').CommandInteraction) => Promise<void> | void} execute The function to execute when the command is called

Nitpick to make it fit with the Event typedef

#

D4isDAVID

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

This may be completely redundant too? Since something similar is already done prior to this.

#

D4isDAVID

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

/**
 * Defines the predicate to check if an object is a valid Event type.
 *
 * @type {import('../util/loaders').StructurePredicate<Event>}
 * @returns {structure is Event}
 */

Nitpick to make it fit with the command predicate

#

suneettipirneni

[discord.js:refactor/create-discord-bot/prompts] 1 new commit

91cd061 chore: requested changes - suneettipirneni

#

D4isDAVID

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

D4isDAVID

[discordjs/discord.js] New review comment on pull request #9570: feat(create-discord-bot): Add prompts, command handler and deployment script

Still redundant, this line doesn't do anything except for throwing an error if a file (not a directory) of this name already exists, in which case it would be nice to have an error message.

#

suneettipirneni

[discord.js:refactor/create-discord-bot/prompts] 1 new commit

7fa1865 fix: remove redundant call - suneettipirneni

#

D4isDAVID

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

kodiakhq[bot]

[discord.js:main] 1 new commit

84f1b18 feat(create-discord-bot): Add prompts, command ... - suneettipirneni

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9570 feat(create-discord-bot): Add prompts, command handler and deployment script

#

D4isDAVID

[discordjs/discord.js] Pull request opened: #9719 feat(create-discord-bot): throw error if the directory is a file

Please describe the changes this PR makes and why it should be merged:

Throw an error if the given directory is not actually a directory.

See #9570 (review).

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9719 feat(create-discord-bot): throw error if the directory is a file

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9719 feat(create-discord-bot): throw error if the directory is a file

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #9719 feat(create-discord-bot): throw error if the directory is a file

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9719 feat(create-discord-bot): throw error if the directory is a file

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9719 feat(create-discord-bot): throw error if the directory is a file

#

kodiakhq[bot]

[discord.js:main] 1 new commit

351a18b feat(create-discord-bot): throw error if the di... - D4isDAVID

tepid vineBOT Jul 19, 2023, 5:13 AM

#

Jiralite

[discordjs/discord.js] New comment on pull request #9604: chore: add `no-install` option and minor fixes

This needs a rebase.

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9604 chore: add `no-install` option and minor fixes

#

Jiralite

[discordjs/discord.js] New review comment on pull request #9604: chore: add `no-install` option and minor fixes

Do you mean #9570?

tepid vineBOT Jul 31, 2023, 7:34 PM

#

iCrawl

[discord.js:main] 1 new commit

43d3b48 chore(create-discord-bot): release create-disco... - iCrawl

tepid vineBOT Jul 31, 2023, 8:18 PM

#

iCrawl

[discord.js:main] 1 new commit

3bc0dce chore: fix changelog - iCrawl

tepid vineBOT Aug 3, 2023, 7:51 PM

#

jaw0r3k

[discordjs/discord.js] Pull request opened: #9747 fix: create-discord-bot was not running in the shell

Please describe the changes this PR makes and why it should be merged:

Found in [djs-questions post](#1136741339476803728 message)

Status and versioning classification:

This PR only includes non-code changes, like changes to documentation, README, etc.

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9747 fix: create-discord-bot was not running in the shell

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #9747 fix: create-discord-bot was not running in the shell

#

Qjuh

[discordjs/discord.js] New review comment on pull request #9747: fix: create-discord-bot was not running in the shell

Disable eslint rule n/shebang for this line

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9747 fix: create-discord-bot was not running in the shell

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9747: fix: create-discord-bot was not running in the shell

I was faster

tepid vineBOT Aug 3, 2023, 8:27 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9747 fix: create-discord-bot was not running in the shell

tepid vineBOT Aug 3, 2023, 9:50 PM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #9747 fix: create-discord-bot was not running in the shell

tepid vineBOT Aug 4, 2023, 6:46 AM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #9747 fix(create-discord-bot): add shebang in main file

tepid vineBOT Aug 4, 2023, 7:53 PM

#

jaw0r3k

[discordjs/discord.js] Issue opened: #9751 feat(create-discord-bot): automatically update versions in templates

Which application or package is this feature request for?

create-discord-bot

Feature

Every version update can cause errors like that

As templates dont have ^workspace things

Ideal solution or implementation

While publishing create-discord-bot package the script could use latest versions for the templates

Alternative solutions or implementations

No response

...

tepid vineBOT Aug 9, 2023, 9:45 AM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9747 fix(create-discord-bot): add shebang in main file

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9747 fix(create-discord-bot): add shebang in main file

#

kodiakhq[bot]

[discord.js:main] 1 new commit

99194fc fix(create-discord-bot): add shebang in main fi... - jaw0r3k

tepid vineBOT Aug 9, 2023, 4:05 PM

#

Jiralite

[discordjs/discord.js] New review comment on pull request #9604: chore: add `no-install` option and minor fixes

This seems like an unrelated change.

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9604 chore: add `no-install` option and minor fixes

tepid vineBOT Aug 9, 2023, 5:15 PM

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9604 chore: add `no-install` option and minor fixes

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9604: chore: add `no-install` option and minor fixes

well its listed in pr description so idk
but idk if making another pr just for that is worth it

tepid vineBOT Aug 17, 2023, 7:38 PM

#

iCrawl

[discord.js:main] 1 new commit

58d9024 chore(create-discord-bot): release create-disco... - iCrawl

#

iCrawl

[discord.js:] 1 new commit

41d55e4 chore(create-discord-bot): release create-disco... - iCrawl

tepid vineBOT Aug 21, 2023, 7:00 PM

#

iCrawl

[discord.js:feat/bun-and-deno-templates] 1 new commit

55e375f feat(create-discord-bot): bun/deno templates - iCrawl

#

iCrawl

[discordjs/discord.js] Pull request opened: #9795 feat(create-discord-bot): bun/deno templates

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

its definitely not necessary

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

Do we really need console.log in every case?

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

} satisfies Event<Events.ClientReady>;

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

} satisfies Event<Events.ClientReady>;

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

				`yarn set version stable`,
				`yarn config set nodeLinker node-modules`,
				`yarn config set logFilters --json '[{ "code": "YN0002", "level": "discard" }, { "code": "YN0013", "level": "discard" }, { "code": "YN0032", "level": "discard" }, { "code": "YN0060", "level": "discard" }]'`,
				`yarn plugin import interactive-tools`,
				`yarn plugin import workspace-tools`,

just cleaner code

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

tepid vineBOT Aug 21, 2023, 7:52 PM

#

iCrawl

[discord.js] Branch feat/bun-and-deno-templates was force-pushed to `804aa07`

Compare changes

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

Yeah...

#

iCrawl

[discord.js] Branch feat/bun-and-deno-templates was force-pushed to `3c6e52c`

Compare changes

#

iCrawl

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

It's only for some to create proper spacing in the terminal output.

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

One console.log before switch statement isnt enough? Without duplicating it in every case

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

iCrawl

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

👍

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

iCrawl

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

I don't think it matters too much does it, the packageManager here cannot be anything different anyway

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

iCrawl

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

😠

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

just change it to
if (packageManager === 'yarn')

and use one console.log

#

iCrawl

[discord.js] Branch feat/bun-and-deno-templates was force-pushed to `742e74e`

Compare changes

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

iCrawl

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

I guess thats true.

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #9795 feat(create-discord-bot): bun/deno templates

#

iCrawl

[discordjs/discord.js] New review comment on pull request #9795: feat(create-discord-bot): bun/deno templates

But I also want to use the console log only on yarn, pnpm, and deno. I can make a default case and get rid of one statement and make a default instead.

#

iCrawl

[discord.js] Branch feat/bun-and-deno-templates was force-pushed to `e7c8240`

Compare changes

tepid vineBOT Aug 21, 2023, 8:30 PM

#

iCrawl

[discord.js] Branch feat/bun-and-deno-templates was force-pushed to `200daba`

Compare changes

#

iCrawl

[discord.js] Branch feat/bun-and-deno-templates was force-pushed to `2be5b97`

Compare changes

#

iCrawl

[discordjs/discord.js] Pull request closed: #9795 feat(create-discord-bot): bun/deno templates

#

iCrawl

[discord.js:main] 1 new commit

dd5e745 feat(create-discord-bot): bun/deno templates (#... - iCrawl

#

kodiakhq[bot]

[discord.js:build/deps] 2 new commits

dd5e745 feat(create-discord-bot): bun/deno templates (#... - iCrawl
165a6d7 Merge branch 'main' into build/deps - kodiakhq[bot]

tepid vineBOT Aug 24, 2023, 10:48 PM

#

IanMitchell

[discordjs/discord.js] Pull request review submitted: #9781 ci: Stop documentation upload for create-discord-bot

tepid vineBOT Aug 25, 2023, 9:57 AM

#

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #9604 feat: add `no-install` option and minor fixes

tepid vineBOT Aug 25, 2023, 8:08 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9604 feat: add `no-install` option and minor fixes

#

Jiralite

[discordjs/discord.js] New review comment on pull request #9604: feat: add `no-install` option and minor fixes

Should this not be --no-install?

tepid vineBOT Aug 25, 2023, 8:33 PM

#

jaw0r3k

[discordjs/discord.js] Pull request review submitted: #9604 feat: add `no-install` option and minor fixes

#

jaw0r3k

[discordjs/discord.js] New review comment on pull request #9604: feat: add `no-install` option and minor fixes

Crawl used diffrent syntax so for continuity i also used it

tepid vineBOT Aug 25, 2023, 8:55 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9604 feat: add `no-install` option and minor fixes

#

Jiralite

[discordjs/discord.js] New review comment on pull request #9604: feat: add `no-install` option and minor fixes

This (and that) should change.

tepid vineBOT Aug 26, 2023, 7:04 PM

#

FlowSwift

[discordjs/discord.js] Issue opened: #9807 create-discord-bot setup failing

Which package is this bug report for?

create-discord-bot

Issue description

Seems like create-discord-bot is not working properly and esling is being configured wrong from my understanding.
What I did:
Installed the eslint extension.
npx create-discord-bot . and installed the typescript version
I then get in vscode the following:
Missing file extension "ts" for "./util/loaders.js" for all the imports

Code sample

No response

Versions

Everything is latest versio...

tepid vineBOT Aug 26, 2023, 8:58 PM

#

jaw0r3k

[discordjs/discord.js] Pull request opened: #9808 fix(create-discord-bot): minor fixes

Please describe the changes this PR makes and why it should be merged:

There still occurs picocolors is a CommonJS module issue but is going to be fixed in crawl's pnpm pr

Statement checking if we are not using deno:

Why?

Deno doesnt need package..json

allowSyntheticDefaultImports rule:

Why?

node:process doesnt work

allowImportingTsExtensions rule...

tepid vineBOT Aug 26, 2023, 9:31 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9604 feat: Add `no-install` option

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9604 feat: Add `no-install` option

#

kodiakhq[bot]

[discord.js:main] 1 new commit

8325fa6 feat: Add no-install option (#9604) - jaw0r3k

#

kodiakhq[bot]

[discordjs/discord.js] Issue closed: #9603 Enhancements request for TypeScript template

tepid vineBOT Aug 27, 2023, 7:08 PM

#

iCrawl

[discord.js:main] 1 new commit

e1ae7b4 chore(create-discord-bot): disable eslint rule ... - iCrawl

#

iCrawl

[discordjs/discord.js] Pull request closed: #9808 fix(create-discord-bot): minor fixes

tepid vineBOT Aug 28, 2023, 7:34 AM

#

iCrawl

[discordjs/discord.js] Pull request closed: #9781 ci: Stop documentation upload for create-discord-bot

tepid vineBOT Aug 28, 2023, 10:24 AM

#

jaw0r3k

[discordjs/discord.js] New comment on issue #9807: create-discord-bot eslint bug

Fixed by e1ae7b4d5779b4006e8769879713cc9382d37dbe

#

Jiralite

[discordjs/discord.js] Issue closed: #9807 create-discord-bot eslint bug

tepid vineBOT Aug 28, 2023, 6:55 PM

#

jaw0r3k

[discordjs/discord.js] Issue opened: #9810 Running the built create script with deno throws an error

Which package is this bug report for?

create-discord-bot

Issue description

Build the create-discord-bot package
Run the dist file with deno

Code sample

No response

Versions

deno 1.36.2 (release, x86_64-pc-windows-msvc)
v8 11.7.439.1
typescript 5.1.6

Issue priority

Medium (should be fixed soon)

Which partials do you have configured?

Not applica...

tepid vineBOT Aug 31, 2023, 8:02 AM

#

filename24

[discordjs/discord.js] Issue opened: #9812 feat(create-discord-bot): github repository import template

Which application or package is this feature request for?

create-discord-bot

Feature

Creating a template using a GitHub repository

Ideal solution or implementation

I think we can provide a function that first checks if the GitHub repository is found, and then downloads and renames the repository.

Alternative solutions or implementations

No response

Other context

No response

tepid vineBOT Aug 31, 2023, 8:18 AM

#

Jiralite

[discordjs/discord.js] New comment on issue #9812: feat(create-discord-bot): github repository import template

This seems like a fundamental Git query accomplished with git clone [email protected]:filename24/filename24.git renamed, for example, no?

tepid vineBOT Sep 1, 2023, 10:14 AM

#

filename24

[discordjs/discord.js] New comment on issue #9812: feat(create-discord-bot): github repository import template

This seems like a fundamental Git query accomplished with git clone [email protected]:filename24/filename24.git renamed for example, no?

Yes, that's right, but if you look at the code, you're doing a git clone using the [REPLACE_ME] name in the package.json.

#

Jiralite

[discordjs/discord.js] New comment on issue #9812: feat(create-discord-bot): github repository import template

I'm struggling to understand now. Isn't the solution to that to follow the respective repository's instructions?

tepid vineBOT Sep 3, 2023, 6:42 AM

#

filename24

[discordjs/discord.js] New comment on issue #9812: feat(create-discord-bot): github repository import template

If you're going to write a template, you're most likely going to write a git clone. But if you're going to do a create-discord-bot, why not build something that installs the module, automatically removes the cloned .git fullder, and automatically does a git init, for example create-discord-bot hellobot --example https://github.com?

tepid vineBOT Oct 7, 2023, 3:03 PM

#

erayreperit

[discordjs/discord.js] Pull request opened: #9875 an error was occurring due to the module resolution :3

Please describe the changes this PR makes and why it should be merged:
The module in tsconfig.json was changed as it was causing an error because since the moduleResolution is set to NodeNext, it must also be set to NodeNext.

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9875 an error was occurring due to the module resolution :3

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9875 fix: update module to `NodeNext` in tsconfig.json

tepid vineBOT Oct 7, 2023, 4:07 PM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9875 fix: update module to `NodeNext` in tsconfig.json

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9875 fix: update module to `NodeNext` in tsconfig.json

#

kodiakhq[bot]

[discord.js:main] 1 new commit

f586283 fix: update module to NodeNext in tsconfig.js... - erayreperit

tepid vineBOT Nov 12, 2023, 5:59 PM

#

vladfrangu

[discord.js:chore/release-train] 1 new commit

3e365cb chore: git cliff pls - vladfrangu

tepid vineBOT Nov 12, 2023, 7:34 PM

#

jaw0r3k

[discordjs/discord.js] Pull request opened: #9949 fix: import picocolors as default

Please describe the changes this PR makes and why it should be merged:

Running: npm create [email protected] throws commonjs module error coused by importing picocolor

Status and versioning classification:

This PR only includes non-code changes, like changes to documentation, README, etc.

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9949 fix: import picocolors as default

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9949 fix: import picocolors as default

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9949 fix: import picocolors as default

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9949 fix: import picocolors as default

#

kodiakhq[bot]

[discord.js:main] 1 new commit

8a6045f fix: import picocolors as default (#9949) - jaw0r3k

tepid vineBOT Nov 12, 2023, 8:12 PM

#

Jiralite

[discord.js:feat/version-update] 1 new commit

e8bd354 feat: bump package versions - Jiralite

#

Jiralite

[discordjs/discord.js] Pull request opened: #9951 feat: bump package versions

Bumps dependency versions due to recent releases.

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9951 feat: bump package versions

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9951 feat: bump package versions

#

kyranet

[discordjs/discord.js] Pull request review submitted: #9951 chore: bump package versions

#

vladfrangu

[discord.js:feat/version-update] 1 new commit

cad1589 chore(create-discord-bot): release create-disco... - vladfrangu

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9951 feat: bump package versions

#

kodiakhq[bot]

[discord.js:main] 1 new commit

f0ec70d feat: bump package versions (#9951) - Jiralite

tepid vineBOT Nov 18, 2023, 3:50 PM

#

mallusrgreatv2

[discordjs/discord.js] Issue opened: #9985 Property '#private' in type 'REST' refers to a different member that cannot be accessed from within type 'REST'.

Which package is this bug report for?

create-discord-bot

Issue description

Steps

Do yarn create discord-bot.
In options use typescript.
In src/util/deploy.ts, error occurs.

Argument of type 'import("(location of bot code)/node_modules/@discordjs/rest/dist/index").REST' is not assignable to parameter of type 'import("(location of bot code)/node_modules/@discordjs/rest/dist/index", { assert: { "resolution-mode": "import" } }).REST'.
Property '#private' in type...

#

Jiralite

[discord.js:fix/bump-versions] 1 new commit

6372983 fix: bump versions - Jiralite

#

Jiralite

[discordjs/discord.js] Pull request opened: #9986 fix: Bump versions to prevent /rest type error

Resolves #9985.

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9986 fix: Bump versions to prevent /rest type error

#

kyranet

[discordjs/discord.js] Pull request review submitted: #9986 fix: Bump versions to prevent /rest type error

#

jaw0r3k

[discordjs/discord.js] New comment on pull request #9986: fix: Bump versions to prevent /rest type error

Doesnt seem working for me...

Updated versions:

#

BlankParticle

[discordjs/discord.js] Pull request opened: #9987 fix(create-discord-bot): Fix typo for Bun Template

Please describe the changes this PR makes and why it should be merged:
There was a typo in create-discord-bot for Bun/TypeScript template which caused it to throw errors at time of install.

Status and versioning classification:

#

vladfrangu

[discordjs/discord.js] New comment on pull request #9986: fix: Bump versions to prevent /rest type error

@jaw0r3k please npm ls @discordjs/rest 🙏

#

mallusrgreatv2

[discordjs/discord.js] New comment on pull request #9986: fix: Bump versions to prevent /rest type error

@jaw0r3k please npm ls @discordjs/rest 🙏

I also have the same issue:
├─┬ @discordjs/[email protected] │ ├── @discordjs/[email protected] │ └─┬ @discordjs/[email protected] │ └── @discordjs/[email protected] deduped └─┬ [email protected] └── @discordjs/[email protected] deduped

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #9987 fix(Bun): Fix typo for Bun template

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9987 fix(Bun): Fix typo for Bun template

tepid vineBOT Nov 18, 2023, 4:58 PM

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9987 fix(Bun): Fix typo for Bun template

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9987 fix(Bun): Fix typo for Bun template

#

kodiakhq[bot]

[discord.js:main] 1 new commit

ce0be39 fix(Bun): Fix typo for Bun template (#9987) - BlankParticle

#

vladfrangu

[discordjs/discord.js] New comment on pull request #9986: fix: Bump versions to prevent /rest type error

PR is blocked till we get a resolution for https://github.com/microsoft/TypeScript/issues/56455 🤞

tepid vineBOT Nov 19, 2023, 1:50 AM

#

ckohen

[discordjs/discord.js] New comment on pull request #9986: fix: Bump versions to prevent /rest type error

For those that find this PR before that is resolved, a solution is importing directly from @discordjs/rest since it has exports for both module types that TS resolves properly.

tepid vineBOT Nov 26, 2023, 7:52 PM

#

darionbuilds

[discordjs/discord.js] New comment on pull request #9986: fix: Bump versions to prevent /rest type error

PR is blocked till we get a resolution for microsoft/TypeScript#56455 🤞

Just as an FYI, this was marked as working as intended on the TS repo.

tepid vineBOT Nov 26, 2023, 8:54 PM

#

ckohen

[discordjs/discord.js] New comment on pull request #9986: fix: Bump versions to prevent /rest type error

Which unfortunately means my previous suggestion is the best way to overcome this. I think we plan on making it work by faking djs having esm support in TS land, which is incredibly dumb, and balloons the package size for literally no reason, but alas.

tepid vineBOT Nov 30, 2023, 10:41 PM

#

Jiralite

[discord.js] Branch fix/bump-versions was force-pushed to `c199e6d`

Compare changes

#

Jiralite

[discordjs/discord.js] New comment on pull request #9986: build: Bump versions

#10009 was raised to fix #9985, so this will just bump dependencies.

tepid vineBOT Nov 30, 2023, 11:19 PM

#

kodiakhq[bot]

[discordjs/discord.js] Issue closed: #9985 Property '#private' in type 'REST' refers to a different member that cannot be accessed from within type 'REST'.

tepid vineBOT Dec 30, 2023, 5:58 PM

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #9986 build: Bump versions

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #9986 build: Bump versions

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #9986 build: Bump versions

#

kodiakhq[bot]

[discord.js:main] 1 new commit

136c66c build: Bump versions (#9986) - Jiralite

#

suneettipirneni

[discord.js:feat/using-support] 2 new commits

136c66c build: Bump versions (#9986) - Jiralite
e4bff42 Merge branch 'main' of https://github.com/disco... - suneettipirneni

tepid vineBOT Jan 22, 2024, 9:44 AM

#

didinele

[discordjs/discord.js] New comment on issue #9810: Running the create-discord-bot with `deno` causes an error

Does this still happen?

tepid vineBOT Jan 22, 2024, 6:03 PM

#

jaw0r3k

[discordjs/discord.js] New comment on issue #9810: Running the create-discord-bot with `deno` causes an error

Well it shouldnt
But it do

But i have latest version and promises cp exists

And the function was added to promises struct so maybe i am doing something wrong https://github.com/littledivy/deno/blob/20bb2c8daaba6b78710a24014828f3db90e4e807/ext/node/polyfills/fs.ts#L141

#

jaw0r3k

[discordjs/discord.js] New comment on issue #9810: Running the create-discord-bot with `deno` causes an error

Well this works

tepid vineBOT Jan 22, 2024, 6:28 PM

#

didinele

[discordjs/discord.js] New comment on issue #9810: Running the create-discord-bot with `deno` causes an error

Seems like a deno issue still? Should probably open another one on their end.

tepid vineBOT Jan 26, 2024, 7:13 PM

#

sdanialraza

[discordjs/discord.js] Pull request opened: #10103 refactor: improve structure validation with zod

Please describe the changes this PR makes and why it should be merged:
This improves the structure validation for command and event types with zod.

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating

tepid vineBOT Jan 27, 2024, 1:28 AM

#

FabricSoul

[discordjs/discord.js] Pull request opened: #10104 fix: Update tsconfig to address type checking issues

…to address type checking issues

Please describe the changes this PR makes and why it should be merged:
This PR updates the tsconfig.json file by enabling strictNullChecks, noEmit, and allowImportingTsExtensions options. These changes improve the type checking process by ensuring that null and undefined values are handled correctly, preventing type-related runtime errors. Furthermore, the noEmit option is set to true to enable type-checking without compiling the code, suitab...

tepid vineBOT Jan 27, 2024, 9:54 AM

#

Qjuh

[discordjs/discord.js] New comment on pull request #10104: fix: Update tsconfig to address type checking issues

How does the noEmit suit the build process in package.json which only calls tsc and nothing else? If it doesn’t emit then there won’t be files to run.

tepid vineBOT Jan 28, 2024, 6:49 PM

#

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #10103 refactor: improve structure validation with zod

tepid vineBOT Jan 30, 2024, 5:59 PM

#

codershiba

[discordjs/discord.js] Pull request review submitted: #10104 fix: Update tsconfig to address type checking issues

#

codershiba

[discordjs/discord.js] New review comment on pull request #10104: fix: Update tsconfig to address type checking issues

tepid vineBOT Feb 14, 2024, 1:38 PM

#

Jiralite

[discordjs/discord.js] New comment on issue #9810: Running the create-discord-bot with `deno` causes an error

Does 1.40.4 still have this issue, as https://github.com/denoland/deno/pull/22263 was a part of it?

tepid vineBOT Feb 14, 2024, 2:04 PM

#

jaw0r3k

[discordjs/discord.js] New comment on issue #9810: Running the create-discord-bot with `deno` causes an error

This error was fixed.
But there is a next strange one
<img src="https://github.com/discordjs/discord.js/assets/76836550/62b394ba-3870-45a6-bd70-7b1d4d4da4e6" height="60px" />

As the structure is created as:
<img src="https://github.com/discordjs/discord.js/assets/76836550/a61db354-1321-4fef-b6e4-e639867108c4" height="100px" />
So somehow is is created within Typescript folder

tepid vineBOT Feb 17, 2024, 7:34 PM

#

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #10103 refactor: improve structure validation with zod

tepid vineBOT Feb 21, 2024, 8:16 PM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #10103 refactor: improve structure validation with zod

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10103 refactor: improve structure validation with zod

#

kodiakhq[bot]

[discord.js:main] 1 new commit

1d56544 refactor: improve structure validation with zod... - sdanialraza

tepid vineBOT Feb 23, 2024, 12:11 AM

#

vladfrangu

[discordjs/discord.js] New review comment on pull request #10104: fix: Update tsconfig to address type checking issues

This should only be enabled for deno/bun, not every TS project! 👀

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #10104 fix: Update tsconfig to address type checking issues

tepid vineBOT Feb 23, 2024, 2:11 AM

#

FabricSoul

[discordjs/discord.js] Pull request review submitted: #10104 fix: Update tsconfig to address type checking issues

#

FabricSoul

[discordjs/discord.js] New review comment on pull request #10104: fix: Update tsconfig to address type checking issues

Make sense

tepid vineBOT May 4, 2024, 5:17 PM

#

vladfrangu

[discord.js:chore/release] 1 new commit

9f53693 chore: brother why - vladfrangu

tepid vineBOT Jun 9, 2024, 5:10 PM

#

Jiralite

[discordjs/discord.js] Issue closed: #9810 Running create-discord-bot yields a node:fs/promises cp error

#

Jiralite

[discordjs/discord.js] New comment on issue #9810: Running create-discord-bot yields a node:fs/promises cp error

Since this was a Deno issue and not a discord.js issue, I'll be closing this.

This error was fixed. But there is another strange one <img alt="" height="60px" src="https://private-user-images.githubusercontent.com/76836550/304757990-62b394ba-3870-45a6-bd70-7b1d4d4da4e6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc5NTE3NjYsIm5iZiI6MTcxNzk1MTQ2NiwicGF0aCI6Ii83NjgzNjU1MC8zMDQ3NTc5OTAtNjJiM...

tepid vineBOT Jun 24, 2024, 1:07 PM

#

Jiralite

[discord.js:chore/email-update] 1 new commit

5e5c6e3 chore: my email too - Jiralite

tepid vineBOT Aug 14, 2024, 6:56 PM

#

almeidx

[discord.js:fix/cdb-node-generation] 1 new commit

8d73e78 fix: failed build in node and bad lints - almeidx

#

almeidx

[discordjs/discord.js] Pull request opened: #10444 fix: failed build in node and bad lints

Please describe the changes this PR makes and why it should be merged:
The typescript build was failing for bots created under node.js due to the usage of .ts imports

ESLint was also failing due to the strictNullChecks tsconfig option not being enabled

After fixing the build, prettier was formatting the files in the dist folder

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes

#

almeidx

[discord.js] Branch fix/cdb-node-generation was force-pushed to `431598e`

Compare changes

tepid vineBOT Aug 14, 2024, 8:14 PM

#

ckohen

[discordjs/discord.js] Pull request review submitted: #10444 fix: failed build in node and bad lints

#

ckohen

[discordjs/discord.js] New review comment on pull request #10444: fix: failed build in node and bad lints

Rather than enable this single option, please turn extends into an array and add @sapphire/ts-config to it that includes many options that might have been thought to be included in extra-strict

tepid vineBOT Aug 20, 2024, 3:38 PM

#

almeidx

[discord.js:fix/cdb-node-generation] 1 new commit

c538222 chore: update tsconfigs - almeidx

#

almeidx

[discordjs/discord.js] Pull request closed: #10104 fix: Update tsconfig to address type checking issues

#

almeidx

[discordjs/discord.js] New comment on pull request #10104: fix: Update tsconfig to address type checking issues

Superceded by #10444

tepid vineBOT Aug 20, 2024, 6:14 PM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #10444 fix: failed build in node and bad lints

tepid vineBOT Aug 20, 2024, 10:34 PM

#

ckohen

[discordjs/discord.js] Pull request review submitted: #10444 fix: failed build in node and bad lints

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #10444 fix: failed build in node and bad lints

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10444 fix: failed build in node and bad lints

#

kodiakhq[bot]

[discord.js:main] 1 new commit

00accf7 fix: failed build in node and bad lints (#10444) - almeidx

tepid vineBOT Dec 10, 2024, 12:17 AM

#

SaltyQuetzals

[discordjs/discord.js] Issue opened: #10653 Template generated by create-discord-bot does not compile

Which package is this bug report for?

create-discord-bot

Issue description

Run npx create-discord-bot, electing to use TypeScript
Allow the bot to set up the template in a directory
cd into the directory
npm run build

Error reproduces on step 5.

Code sample

No response

Versions

discord.js 14.16.0
@discordjs/core 1.2.0
Node.js 20.11.0
TypeScript 5.5.4
MacOS Sequoia 15.2

Issue priority

Medium (should be fixed soon)

Which ...

tepid vineBOT Jan 1, 2025, 10:59 PM

#

Jiralite

[discord.js:feat/bump-cdb] 1 new commit

c3272d7 feat: upgrade cdb deps - Jiralite

#

Jiralite

[discordjs/discord.js] Pull request opened: #10673 feat: Upgrade create-discord-bot dependencies

Resolves #10653.

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #10673 feat: Upgrade create-discord-bot dependencies

#

ckohen

[discordjs/discord.js] Pull request review submitted: #10673 feat: Upgrade create-discord-bot dependencies

#

almeidx

[discordjs/discord.js] Pull request review submitted: #10673 feat: Upgrade create-discord-bot dependencies

#

kodiakhq[bot]

[discord.js:main] 1 new commit

a111cdd feat: Upgrade create-discord-bot dependencies (... - Jiralite

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10673 feat: Upgrade create-discord-bot dependencies

#

kodiakhq[bot]

[discordjs/discord.js] Issue closed: #10653 Template generated by create-discord-bot does not compile

#

vladfrangu

[discord.js:chore/release-cdb] 1 new commit

b744af7 chore(create-discord-bot): release create-disco... - vladfrangu

#

almeidx

[discordjs/discord.js] Pull request opened: #10674 chore(create-discord-bot): release [email protected]

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10674 chore(create-discord-bot): release [email protected]

#

vladfrangu

[discord.js] Branch chore/release-cdb was force-pushed to `4a3951c`

Compare changes

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #10674 chore(create-discord-bot): release [email protected]

#

ckohen

[discordjs/discord.js] Pull request review submitted: #10674 chore(create-discord-bot): release [email protected]

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10674 chore(create-discord-bot): release [email protected]

#

kodiakhq[bot]

[discord.js:main] 1 new commit

ad0d9a2 chore(create-discord-bot): release create-disco... - almeidx

tepid vineBOT Jan 27, 2025, 11:51 PM

#

Jiralite

[discordjs/discord.js] Issue closed: #9812 github repository import template

#

Jiralite

[discordjs/discord.js] New comment on issue #9812: github repository import template

If you mean this should be a tool to install anyone's template, we will not be doing that. This is the template. Follow a repository's instructions to learn how to deal with their templates.

#

Jiralite

[discordjs/discord.js] Issue closed: #9751 automatically update versions in templates

#

Jiralite

[discordjs/discord.js] New comment on issue #9751: automatically update versions in templates

With recent changes, this should no longer be an issue.

tepid vineBOT Feb 21, 2025, 11:12 PM

#

schrodienieur

[discordjs/discord.js] Issue opened: #10774 Command in subdirectory was skipped and not registered

Which package is this bug report for?

create-discord-bot

Issue description

Steps to reproduce:

Run npm create discord-bot
Select JavaScript template
Create folder named utility in the commands folder.
Add user command in the utility subdirectory

./commands/utility/user.js

/** @type {import('../index').Command} */
export default {
	data: {
		name: 'user',
		description: 'Provides information about the user.',
	},
	async execute(interaction) {
		await intera...

#

schrodienieur

[discordjs/discord.js] Pull request opened: #10775 fix(create-discord-bot): register command files in subdirectories

Resolves #10774

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10775 fix(create-discord-bot): register command files in subdirectories

I believe the Deno template needs this too. Would you mind checking? The code there more or less seems identical.

#

schrodienieur

[discordjs/discord.js] New comment on pull request #10775: fix(create-discord-bot): register command files in subdirectories

I believe the Deno template needs this too. Would you mind checking? The code there more or less seems identical.

done

tepid vineBOT Feb 24, 2025, 2:16 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10775 fix(create-discord-bot): register command files in subdirectories

tepid vineBOT Feb 27, 2025, 11:27 AM

#

benjGam

[discordjs/discord.js] Pull request review submitted: #10775 fix(create-discord-bot): register command files in subdirectories

tepid vineBOT Mar 6, 2025, 6:22 PM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #10775 fix(create-discord-bot): register command files in subdirectories

#

Qjuh

[discordjs/discord.js] New review comment on pull request #10775: fix(create-discord-bot): register command files in subdirectories

since we use that URL twice now (here and 4 lines earlier) shouldn't it be defined as a const and be used twice for performance reasons?

tepid vineBOT Mar 16, 2025, 3:36 PM

#

Jiralite

[discord.js:refactor/guide-url] 1 new commit

44e186b refactor(constants): update guide URL - Jiralite

#

Jiralite

[discordjs/discord.js] Pull request opened: #10803 refactor(constants): Update guide URL

Pointing the guide to the updated one rather than the stale one.

tepid vineBOT Mar 16, 2025, 5:05 PM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #10803 refactor(constants): Update guide URL

#

almeidx

[discordjs/discord.js] Pull request review submitted: #10803 refactor(constants): Update guide URL

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #10803 refactor(constants): Update guide URL

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10803 refactor(constants): Update guide URL

#

kodiakhq[bot]

[discord.js:main] 1 new commit

eabcc52 refactor(constants): Update guide URL (#10803) - Jiralite

#

Qjuh

[discordjs/discord.js] Pull request review dismissed: #10775 fix(create-discord-bot): register command files in subdirectories

#

almeidx

[discordjs/discord.js] Pull request review submitted: #10775 fix(create-discord-bot): register command files in subdirectories

tepid vineBOT Mar 16, 2025, 6:31 PM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #10775 fix(create-discord-bot): register command files in subdirectories

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10775 fix(create-discord-bot): register command files in subdirectories

#

kodiakhq[bot]

[discordjs/discord.js] Issue closed: #10774 Command in subdirectory was skipped and not registered

#

kodiakhq[bot]

[discord.js:main] 1 new commit

79b79b6 fix(create-discord-bot): register command files... - schrodienieur

tepid vineBOT Apr 13, 2025, 5:15 PM

#

hugoovf

[discordjs/discord.js] Issue opened: #10834 ERR_UNSUPPORTED_ESM_URL_SCHEME after X create discord-bot

Which package is this bug report for?

create-discord-bot

Issue description

The problem is at https://github.com/discordjs/discord.js/blob/main/packages/create-discord-bot/template/TypeScript/src/util/loaders.ts#L60

const structure = (await import(`${dir}/${file}`)).default; gives no problem on Windows

Code sample

Versions

The NodeJS version is shown in th...

tepid vineBOT Apr 13, 2025, 7:17 PM

#

almeidx

[discord.js:fix/cdb-template-import] 1 new commit

1270d0f fix: structure imports on windows - almeidx

#

almeidx

[discordjs/discord.js] Pull request opened: #10835 fix: structure imports on windows

Fixes #10834

tepid vineBOT Apr 13, 2025, 7:36 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10835 fix: structure imports on windows

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #10835 fix: structure imports on windows

#

didinele

[discordjs/discord.js] Pull request review submitted: #10835 fix: structure imports on windows

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10835 fix: structure imports on windows

#

kodiakhq[bot]

[discord.js:main] 1 new commit

5c0b714 fix: structure imports on windows (#10835) - almeidx

#

kodiakhq[bot]

[discordjs/discord.js] Issue closed: #10834 ERR_UNSUPPORTED_ESM_URL_SCHEME after X create discord-bot

tepid vineBOT May 2, 2025, 10:23 PM

#

vladfrangu

[discord.js:chore/bump-djs-in-crb] 1 new commit

d0b7d66 chore: bump discord.js across create-discord-bo... - vladfrangu

tepid vineBOT May 3, 2025, 4:24 PM

#

sdanialraza

[discord.js:refactor/remove-register-events-function] 1 new commit

f1addeb refactor: remove registerEvents function - sdanialraza

#

sdanialraza

[discordjs/discord.js] Pull request opened: #10877 refactor: remove `registerEvents` function

Please describe the changes this PR makes and why it should be merged:
Removes the registerEvents util function:

Moved the interactionCreate event to the events folder, the commands loading is also done there now
Moved loading event handlers to index

[Internal Discussion](#internals message)

#

almeidx

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

almeidx

[discordjs/discord.js] New review comment on pull request #10877: refactor: remove `registerEvents` function

This doesn't appear to be correct. Missing .bind(client) when registering the events. Also applies to the other templates

tepid vineBOT May 3, 2025, 4:59 PM

#

sdanialraza

[discord.js:chore/update-create-discord-bot-dependencies] 1 new commit

2d21e04 chore: update create-discord-bot dependencies - sdanialraza

#

sdanialraza

[discordjs/discord.js] Pull request opened: #10878 chore: update create-discord-bot dependencies

We do a bit of updating

tepid vineBOT May 3, 2025, 5:53 PM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

sdanialraza

[discordjs/discord.js] New review comment on pull request #10877: refactor: remove `registerEvents` function

#1209960895141388389 message

#

almeidx

[discordjs/discord.js] Pull request review dismissed: #10877 refactor: remove `registerEvents` function

tepid vineBOT May 4, 2025, 8:55 AM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #10878 chore: update create-discord-bot dependencies

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

Qjuh

[discordjs/discord.js] New review comment on pull request #10877: refactor: remove `registerEvents` function

Why do this? It would be valid to access this.data from within the execute() function, but typescript would disallow you to do that now.

tepid vineBOT May 4, 2025, 1:56 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10878 chore: update create-discord-bot dependencies

tepid vineBOT May 5, 2025, 6:57 AM

#

didinele

[discordjs/discord.js] Pull request review submitted: #10878 chore: update create-discord-bot dependencies

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10878 chore: update create-discord-bot dependencies

#

kodiakhq[bot]

[discord.js:main] 1 new commit

4acb714 chore: update create-discord-bot dependencies (... - sdanialraza

tepid vineBOT May 5, 2025, 8:16 PM

#

sdanialraza

[discord.js] Branch refactor/remove-register-events-function was force-pushed to `42c0103`

Compare changes

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

sdanialraza

[discordjs/discord.js] New review comment on pull request #10877: refactor: remove `registerEvents` function

Ah, accidentally added that to commands/index.ts instead of events/index.ts, fixed now

tepid vineBOT May 6, 2025, 4:57 AM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

Qjuh

[discordjs/discord.js] New review comment on pull request #10877: refactor: remove `registerEvents` function

Same question though, an event‘s execute could also have some reason to access this.name or once.

tepid vineBOT May 6, 2025, 3:29 PM

#

sdanialraza

[discord.js] Branch refactor/remove-register-events-function was force-pushed to `fcd1f00`

Compare changes

tepid vineBOT May 6, 2025, 4:49 PM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

tepid vineBOT May 7, 2025, 9:17 AM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

Jiralite

[discordjs/discord.js] New review comment on pull request #10877: refactor: remove `registerEvents` function

Due to #10878, this needs updating.

tepid vineBOT May 7, 2025, 11:27 AM

#

sdanialraza

[discord.js] Branch refactor/remove-register-events-function was force-pushed to `85d1e54`

Compare changes

#

Jiralite

[discordjs/discord.js] Pull request review dismissed: #10877 refactor: remove `registerEvents` function

tepid vineBOT May 7, 2025, 1:23 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

tepid vineBOT May 7, 2025, 4:21 PM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

vladfrangu

[discordjs/discord.js] New review comment on pull request #10877: refactor: remove `registerEvents` function

Why don't we do another good practice thing and wrap the event.execute in a try-catch?

tepid vineBOT May 10, 2025, 8:30 PM

#

sdanialraza

[discord.js:refactor/remove-register-events-function] 1 new commit

b454a19 refactor: use try-catch - sdanialraza

tepid vineBOT May 11, 2025, 10:27 AM

#

didinele

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

didinele

[discordjs/discord.js] New review comment on pull request #10877: refactor: remove `registerEvents` function

if execute is async this try block doesn't do anything
applies to other places as well

tepid vineBOT May 11, 2025, 11:57 AM

#

sdanialraza

[discord.js] Branch refactor/remove-register-events-function was force-pushed to `acd6bd2`

Compare changes

#

didinele

[discordjs/discord.js] Pull request review dismissed: #10877 refactor: remove `registerEvents` function

tepid vineBOT May 11, 2025, 12:21 PM

#

almeidx

[discordjs/discord.js] Pull request review submitted: #10877 refactor: remove `registerEvents` function

#

kodiakhq[bot]

[discord.js:main] 1 new commit

2c21de6 refactor: remove registerEvents function (#10... - sdanialraza

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10877 refactor: remove `registerEvents` function

tepid vineBOT Jun 16, 2025, 12:52 PM

#

vladfrangu

[discord.js:chore/bump-djs-in-create-discord-bot-and-app] 1 new commit

9fe59cf chore: bump discord.js across create-discord-x ... - vladfrangu

#

vladfrangu

[discordjs/discord.js] Pull request opened: #10935 chore: bump discord.js across create-discord-x templates

Please describe the changes this PR makes and why it should be merged:

New release, new template bumps

One of these days we should really make these replacers that happen when the template gets dropped in the file system (and move deno to import mappings >.>)

Status and versioning classification:

I know how to update typings and have done so, or typings don't need updating
This PR only includes non-code changes, like changes to documentation, README, etc.

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10935 chore: bump discord.js across create-discord-x templates

tepid vineBOT Jun 16, 2025, 1:22 PM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #10935 chore: bump discord.js across create-discord-x templates

tepid vineBOT Jun 18, 2025, 9:46 AM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #10935 chore: bump discord.js across create-discord-x templates

#

kodiakhq[bot]

[discord.js:main] 1 new commit

127bb59 chore: bump discord.js across create-discord-x ... - vladfrangu

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10935 chore: bump discord.js across create-discord-x templates

tepid vineBOT Jun 22, 2025, 10:49 AM

#

vladfrangu

[discord.js:chore/release-cdb] 2 new commits

986fc3b chore(create-discord-bot): release create-disco... - vladfrangu
57c15ad chore(ci): handle identical deploy to create-di... - vladfrangu

#

vladfrangu

[discordjs/discord.js] Pull request opened: #10947 chore(create-discord-bot): release [email protected]

Please describe the changes this PR makes and why it should be merged:

Bumps create-discord-bot (and create-discord-app) to 4.0.0 for consistency (discord-app is at 3.1.0 right now, while discord-bot is at 1.x)

Also adds in a CI step for the multi-deploy, but might not be ideal, @iCrawl would love thoughts

Status and versioning classification:

This PR only includes non-code changes, like changes to documentation, README, etc.

tepid vineBOT Jun 22, 2025, 12:23 PM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #10947 chore(create-discord-bot): release [email protected]

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10947 chore(create-discord-bot): release [email protected]

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #10947 chore(create-discord-bot): release [email protected]

tepid vineBOT Jun 22, 2025, 9:37 PM

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #10947 chore(create-discord-bot): release [email protected]

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10947 chore(create-discord-bot): release [email protected]

#

kodiakhq[bot]

[discord.js:main] 1 new commit

8e374aa chore(create-discord-bot): release create-disco... - vladfrangu

tepid vineBOT Jun 22, 2025, 10:11 PM

#

vladfrangu

[discord.js:ci/fix-create-discord-bot-to-create-discord-app-publish] 1 new commit

5e6459f chore: fix create-discord-bot -> create-discord... - vladfrangu

#

vladfrangu

[discordjs/discord.js] Pull request opened: #10951 chore: fix create-discord-bot -> create-discord-app formatting

Please describe the changes this PR makes and why it should be merged:

Fixes prettier linting when the script is called

Status and versioning classification:

#

vladfrangu

[discord.js:ci/fix-create-discord-bot-to-create-discord-app-publish] 1 new commit

e70e034 chore: readme for bun - vladfrangu

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #10951 chore: fix create-discord-bot -> create-discord-app formatting

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #10951 chore: fix create-discord-bot -> create-discord-app formatting

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #10951 chore: fix create-discord-bot -> create-discord-app formatting

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10951 chore: fix create-discord-bot -> create-discord-app formatting

#

kodiakhq[bot]

[discord.js:main] 1 new commit

cd76c9a chore: fix create-discord-bot -> create-discord... - vladfrangu

tepid vineBOT Jul 5, 2025, 7:50 PM

#

almeidx

[discord.js:chore/bump-deps] 1 new commit

60b2f59 chore: templates - almeidx

tepid vineBOT Jul 6, 2025, 6:58 PM

#

almeidx

[discord.js:chore/bump-deps] 1 new commit

1ac66a8 chore: requested changes - almeidx

tepid vineBOT Jul 7, 2025, 10:42 PM

#

SuperchupuDev

[discordjs/discord.js] Pull request opened: #10971 refactor(create-discord-bot): replace deps with built-in apis

Please describe the changes this PR makes and why it should be merged:
The target node version being set to 22.12.0 allows create-discord-bot to become a lot smaller in terms of dependency count:

node:fs/promises' glob was added in node 22.0.0. we can use it instead of fast-glob since we don't need any fast-glob exclusive functionality.
node:util's [styleText](https://nodejs.org/api/util.html#utilstylet...

tepid vineBOT Jul 8, 2025, 4:01 AM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #10971 refactor(create-discord-bot): replace deps with built-in apis

tepid vineBOT Jul 8, 2025, 4:18 AM

#

didinele

[discordjs/discord.js] Pull request review submitted: #10971 refactor(create-discord-bot): replace deps with built-in apis

tepid vineBOT Jul 8, 2025, 7:14 AM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #10971 refactor(create-discord-bot): replace deps with built-in apis

#

kodiakhq[bot]

[discord.js:main] 1 new commit

ee3ca6f refactor(create-discord-bot): replace deps with... - SuperchupuDev

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #10971 refactor(create-discord-bot): replace deps with built-in apis

tepid vineBOT Jul 8, 2025, 10:49 AM

#

almostSouji

[discord.js:legacy-guide] 2 new commits

ee3ca6f refactor(create-discord-bot): replace deps with... - SuperchupuDev
fef5f2f Merge branch 'main' into legacy-guide - almostSouji

tepid vineBOT Aug 2, 2025, 8:43 AM

#

Ratnia

[discordjs/discord.js] Pull request opened: #11024 add Deno

Please describe the changes this PR makes and why it should be merged:
PR: adding deno command on README.md and PackManager.ts
Status and versioning classification:

#

Ratnia

[discordjs/discord.js] New comment on pull request #11024: add Deno

Just Noticed the deno command is missing from README.md and PackageManager so that's the main reason

tepid vineBOT Aug 2, 2025, 9:16 AM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #11024 add Deno

Do you use Deno? deno create does not exist.

#

Ratnia

[discordjs/discord.js] New comment on pull request #11024: add Deno

I just realised...

#

Jiralite

[discordjs/discord.js] Pull request closed: #11024 add Deno

tepid vineBOT Aug 20, 2025, 10:10 PM

#

vladfrangu

[discord.js:chore/bump-djs-in-cdb] 1 new commit

728d6f3 feat: bump discord.js in create-discord-bot/app - vladfrangu

#

vladfrangu

[discordjs/discord.js] Pull request opened: #11048 feat: bump discord.js in create-discord-bot/app

Please describe the changes this PR makes and why it should be merged:

Title says it all

Status and versioning classification:

#

vladfrangu

[discord.js:chore/bump-djs-in-cdb] 1 new commit

1210671 chore: forgot core - vladfrangu

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #11048 feat: bump discord.js in create-discord-bot/app

tepid vineBOT Aug 20, 2025, 11:22 PM

#

ckohen

[discordjs/discord.js] Pull request review submitted: #11048 feat: bump discord.js in create-discord-bot/app

tepid vineBOT Aug 21, 2025, 6:58 AM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #11048 feat: bump discord.js in create-discord-bot/app

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #11048 feat: bump discord.js in create-discord-bot/app

#

kodiakhq[bot]

[discord.js:main] 1 new commit

4b6060d feat: bump discord.js in create-discord-bot/app... - vladfrangu

tepid vineBOT Aug 22, 2025, 3:52 PM

#

almeidx

[discord.js:refactor/cdb-deno-and-loader] 1 new commit

c0e37cb refactor: update deno template and loader logic - almeidx

#

almeidx

[discord.js] Branch refactor/cdb-deno-and-loader was force-pushed to `20edf0b`

Compare changes

#

almeidx

[discordjs/discord.js] Pull request opened: #11060 refactor: update deno template and loader logic

Add deno detection to the default package manager option
Use import attributes instead of the deprecated import assertions
Updated the deno template to use the imports option, to avoid including the version of packages in every import
- This simplifies dependency updates
Updated TypeScript templates to use descriptive type parameter names
Rewrote the loadStructures function to use the glob function from node:fs/promises

#

almeidx

[discord.js] Branch refactor/cdb-deno-and-loader was force-pushed to `c3daf55`

Compare changes

tepid vineBOT Aug 29, 2025, 12:57 PM

#

almeidx

[discord.js:refactor/cdb-deno-and-loader] 1 new commit

66297ef yeet - almeidx

tepid vineBOT Aug 30, 2025, 11:08 AM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #11060 refactor: update deno template and loader logic

tepid vineBOT Aug 30, 2025, 12:05 PM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #11060 refactor: update deno template and loader logic

tepid vineBOT Sep 4, 2025, 12:34 PM

#

didinele

[discordjs/discord.js] Pull request review submitted: #11060 refactor: update deno template and loader logic

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #11060 refactor: update deno template and loader logic

#

kodiakhq[bot]

[discord.js:main] 1 new commit

8ca279e refactor: update deno template and loader logic... - almeidx

tepid vineBOT Oct 5, 2025, 10:18 AM

#

akilesh1706

[discordjs/discord.js] New comment on issue #11092: Add create-discord-app to the Release workflow

@Jiralite I can work on this issue. Can I get it assigned as part of Hacktober fest 2025?

tepid vineBOT Oct 8, 2025, 10:33 AM

#

kodiakhq[bot]

[discordjs/discord.js] Issue closed: #11092 Add create-discord-app to the Release workflow

tepid vineBOT Oct 24, 2025, 3:33 PM

#

Jiralite

[discord.js:feat/cda-release] 1 new commit

840e889 build: bump versions - Jiralite

#

Jiralite

[discord.js] Branch feat/cda-release was force-pushed to `7c82edb`

Compare changes

tepid vineBOT Oct 24, 2025, 4:00 PM

#

Jiralite

[discord.js:feat/cda-release] 1 new commit

be88b49 build: specify monoRepo - Jiralite

#

Jiralite

[discord.js:feat/cda-release] 1 new commit

e8ea21e chore(create-discord-bot): release create-disco... - Jiralite

#

Jiralite

[discordjs/discord.js] Pull request opened: #11198 chore: Release create-discord-app/bot

conventional-recommended-bump wanted to use 5.0.0. Specifying "monoRepo": true seems to fix that.

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #11198 chore: Release create-discord-app/bot

#

didinele

[discordjs/discord.js] Pull request review submitted: #11198 chore: Release create-discord-app/bot

tepid vineBOT Oct 24, 2025, 6:06 PM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #11198 chore: Release create-discord-app/bot

#

Jiralite

[discordjs/discord.js] Pull request closed: #11198 chore: Release create-discord-app/bot

#

Jiralite

[discord.js:main] 1 new commit

c05f653 chore: Release create-discord-app/bot (#11198) - Jiralite

tepid vineBOT Oct 31, 2025, 10:21 PM

#

sdanialraza

[discord.js:chore/migrate-eslint-configs] 1 new commit

719f7b7 chore: migrate eslint configs - sdanialraza

#

sdanialraza

[discordjs/discord.js] Pull request opened: #11234 chore: migrate eslint configs

Please describe the changes this PR makes and why it should be merged:
Migrates ESLint configs to the flag config format.

tepid vineBOT Nov 8, 2025, 7:21 PM

#

almeidx

[discordjs/discord.js] Pull request review submitted: #11234 chore: migrate eslint configs

tepid vineBOT Nov 8, 2025, 9:29 PM

#

almeidx

[discord.js:feat/cdb-zod-upgrade] 1 new commit

cfd22e9 feat: upgrade zod to v4 - almeidx

#

almeidx

[discord.js] Branch feat/cdb-zod-upgrade was force-pushed to `1bf0ff2`

Compare changes

#

almeidx

[discordjs/discord.js] Pull request opened: #11258 feat: upgrade zod to v4

Upgrade zod to v4 on the create-discord-bot templates.

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #11258 feat: upgrade zod to v4

#

Jiralite

[discordjs/discord.js] New review comment on pull request #11258: feat: upgrade zod to v4

Shouldn't the key here be a string?

tepid vineBOT Nov 8, 2025, 10:47 PM

#

almeidx

[discord.js:feat/use-node-typescript] 1 new commit

fe4fce5 feat: use native node typescript - almeidx

#

almeidx

[discord.js] Branch feat/use-node-typescript was force-pushed to `f6a8104`

Compare changes

#

almeidx

[discordjs/discord.js] Pull request opened: #11259 feat: use native node typescript

Adapted the TypeScript template for native ts support on Node.js
Added the templates to the pnpm-workspace on this repository, to ease dependency management
- This means the templates had to have unique and valid names, so I had to refactor the logic on the package a bit
Removed tamasfe.even-better-toml from the recommended dependencies, because it seems completely random?
Added pnpm-lock.yaml to .prettierignore

#

almeidx

[discord.js] Branch feat/use-node-typescript was force-pushed to `4b42f76`

Compare changes

#

almeidx

[discord.js] Branch feat/use-node-typescript was force-pushed to `c2baa37`

Compare changes

tepid vineBOT Nov 9, 2025, 10:57 AM

#

almeidx

[discord.js:feat/cdb-zod-upgrade] 1 new commit

8a86405 fix: requested changes - almeidx

tepid vineBOT Nov 9, 2025, 11:32 AM

#

sdanialraza

[discordjs/discord.js] Pull request review submitted: #11258 feat: upgrade zod to v4

tepid vineBOT Nov 9, 2025, 12:27 PM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #11259 feat: use native node typescript

#

vladfrangu

[discordjs/discord.js] New review comment on pull request #11259: feat: use native node typescript

Couldn't this be a **/*?

tepid vineBOT Nov 12, 2025, 9:15 AM

#

didinele

[discordjs/discord.js] Pull request review submitted: #11234 chore: migrate eslint configs

tepid vineBOT Nov 12, 2025, 9:44 AM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #11234 chore: migrate eslint configs

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #11234 chore: migrate eslint configs

#

kodiakhq[bot]

[discord.js:main] 1 new commit

d923e90 chore: migrate eslint configs (#11234) - sdanialraza

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #11259 feat: use native node typescript

#

Qjuh

[discordjs/discord.js] New review comment on pull request #11259: feat: use native node typescript

ditto

#

Qjuh

[discordjs/discord.js] New review comment on pull request #11259: feat: use native node typescript

won't this be wrong if running with pnpm or yarn now?

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #11258 feat: upgrade zod to v4

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #11258 feat: upgrade zod to v4

#

kodiakhq[bot]

[discord.js:main] 1 new commit

538b47d feat: upgrade zod to v4 (#11258) - almeidx

#

almeidx

[discordjs/discord.js] Pull request review submitted: #11259 feat: use native node typescript

#

almeidx

[discordjs/discord.js] New review comment on pull request #11259: feat: use native node typescript

no. but ill make it more clear

#

almeidx

[discord.js] Branch feat/use-node-typescript was force-pushed to `37799b4`

Compare changes

#

almeidx

[discord.js] Branch feat/use-node-typescript was force-pushed to `8a726ca`

Compare changes

tepid vineBOT Nov 12, 2025, 11:44 AM

#

Qjuh

[discordjs/discord.js] Pull request review submitted: #11259 feat: use native node typescript

tepid vineBOT Nov 24, 2025, 8:37 AM

#

didinele

[discord.js:chore/no-prefer-global] 1 new commit

1717188 fix: shebang stuff - didinele

tepid vineBOT Nov 28, 2025, 10:35 AM

#

didinele

[discord.js:chore/no-prefer-global] 1 new commit

47bd426 chore: update template eslint config files - didinele

tepid vineBOT Dec 6, 2025, 9:57 PM

#

Jiralite

[discord.js:build/dep-bump] 2 new commits

2017943 build: amend package.json.hbs - Jiralite
3f13a49 build: create-discord-bot - Jiralite

#

Jiralite

[discord.js:build/dep-bump] 1 new commit

a6f67c0 build: final change - Jiralite

tepid vineBOT Dec 8, 2025, 9:14 PM

#

almeidx

[discord.js] Branch feat/use-node-typescript was force-pushed to `056306a`

Compare changes

#

Copilot

[discordjs/discord.js] Pull request review submitted: #11259 feat: use native node typescript

Pull request overview

This PR modernizes the TypeScript templates to leverage Node.js's native TypeScript execution, eliminating the need for a build step. The templates are also integrated into the pnpm workspace for better dependency management, requiring unique package names. Additionally, an unrelated VS Code extension recommendation has been removed, and pnpm-lock.yaml is now excluded from Prettier formatting.

Removed TypeScript transpilation requirement by using .ts file extens...

#

Copilot

[discordjs/discord.js] New review comment on pull request #11259: feat: use native node typescript

The module and moduleResolution options are set to "NodeNext", but for Bun projects, "Bundler" resolution is more appropriate. Bun has its own module resolution algorithm that differs from Node.js, and "Bundler" mode is designed for bundlers and runtimes like Bun.

Consider changing:

"module": "NodeNext",
"moduleResolution": "NodeNext",

to:

"module": "ESNext",
"moduleResolution": "Bundler",

		"module": "ESNext",
		"moduleResolution": "Bundler",

#

Copilot

[discordjs/discord.js] New review comment on pull request #11259: feat: use native node typescript

Empty placeholder file contains only export {};. This appears to be a minimal placeholder to make the file a valid TypeScript module, but it doesn't implement any actual bot functionality. This should either be removed or replaced with actual implementation code before release.

Consider either:

Implementing the actual bot initialization code (similar to the Node.js TypeScript template at packages/create-discord-bot/template/TypeScript/src/index.ts)
Removing this file if it's not ne...

#

Copilot

[discordjs/discord.js] New review comment on pull request #11259: feat: use native node typescript

Missing erasableSyntaxOnly compiler option. The TypeScript template includes "erasableSyntaxOnly": true in its tsconfig.json (line 6), but this Bun TypeScript template doesn't. Since both templates are meant to support native TypeScript execution, they should have consistent compiler options.

Add the missing option:

"compilerOptions": {
	"allowImportingTsExtensions": true,
	"erasableSyntaxOnly": true,
	"declaration": false,
	// ...
}

		"allowImportingTsExtensi...

#

Copilot

[discordjs/discord.js] New review comment on pull request #11259: feat: use native node typescript

Empty placeholder file contains only console.log() without any arguments. This will output undefined to the console. This appears to be a placeholder that should either be removed or replaced with actual implementation code before release, or at minimum should log a meaningful message.

Consider either:

Implementing the actual bot initialization code (similar to other templates)
Removing this file if it's not needed
Adding a meaningful placeholder message: `console.log('Bot start...

tepid vineBOT Dec 8, 2025, 11:19 PM

#

almeidx

[discordjs/discord.js] New comment on pull request #11259: feat: use native node typescript

@coderabbitai review

tepid vineBOT Dec 8, 2025, 11:46 PM

#

almeidx

[discord.js:feat/use-node-typescript] 1 new commit

c2f6866 fix: use basename - almeidx

tepid vineBOT Dec 9, 2025, 12:27 AM

#

almeidx

[discord.js:feat/use-node-typescript] 1 new commit

05f5428 Update packages/create-discord-bot/template/Bun... - almeidx

#

almeidx

[discord.js:feat/use-node-typescript] 1 new commit

38d5290 Change module and moduleResolution to ESNext an... - almeidx

#

iCrawl

[discordjs/discord.js] Pull request review submitted: #11259 feat: use native node typescript

tepid vineBOT Dec 9, 2025, 2:22 AM

#

iCrawl

[discordjs/discord.js] Pull request closed: #11259 feat: use native node typescript

#

iCrawl

[discord.js:main] 1 new commit

ec3ef7b feat: use native node typescript (#11259) - almeidx

tepid vineBOT Dec 9, 2025, 1:07 PM

#

ManInTheHam

[discordjs/discord.js] Pull request opened: #11348 feat: add Bun templates for create-discord-bot

Closes #11346

This PR implements Bun templates for the create-discord-bot package:

Added TypeScript Bun template with complete src structure and configuration
Added JavaScript Bun template with complete src structure and configuration
Both templates mirror the Node.js versions with Bun-specific configuration

The templates include:

src/index.ts / src/index.js - Main bot entry point
src/util/deploy.ts / src/util/deploy.js - Command deployment utility
`package...

tepid vineBOT Dec 14, 2025, 7:20 AM

#

majiayu000

[discordjs/discord.js] Pull request opened: #11365 feat(create-discord-bot): implement Bun templates

Summary

Implements complete Bun templates for create-discord-bot, both TypeScript and JavaScript versions.

TypeScript template (template/Bun/TypeScript/)
JavaScript template (template/Bun/JavaScript/)

Each template includes:

src/index.{ts,js} - Main entry point using Bun.env
src/commands/ - Command structure with ping and user commands
src/events/ - Event handlers (ready, interactionCreate)
src/util/loaders.{ts,js} - File loader using Bun.Glob and `Bu...

tepid vineBOT Dec 21, 2025, 9:09 AM

#

jacobhumston

[discordjs/discord.js] Pull request opened: #11368 feat(create-discord-bot): allow empty git-repositories

This pull request allows the template to be created inside empty git repositories. This is done by checking if the file list only includes .git. The main reasoning for this pr is to allow the command to be easily used on new repositories that were created on GitHub for example. If the empty git repository is detected, a .gitignore is also created for convivence.

Note: The error can actually be by bypassed by adding a file named .git. However, I am not sure if logic checking for ...

tepid vineBOT Dec 21, 2025, 7:19 PM

#

almeidx

[discordjs/discord.js] Pull request review submitted: #11368 feat(create-discord-bot): allow empty git-repositories

We should just use the isFolderEmpty helper from the create-next-app package.

https://github.com/vercel/next.js/blob/7fb2aa908216fb3a910c7fa6d24524412b5af6e5/packages/create-next-app/helpers/is-folder-empty.ts#L6

We'd need to ensure their license is included in the file

tepid vineBOT Dec 21, 2025, 7:58 PM

#

jacobhumston

[discordjs/discord.js] New comment on pull request #11368: feat(create-discord-bot): allow empty git-repositories

We should just use the isFolderEmpty helper from the create-next-app package.

https://github.com/vercel/next.js/blob/7fb2aa908216fb3a910c7fa6d24524412b5af6e5/packages/create-next-app/helpers/is-folder-empty.ts#L6

We'd need to ensure their license is included in the file

I've implemented your requested change; however, I wasn't really sure how to go about adding a .gitignore. Should we include a .gitignore for each template instead? Or just avoid creating one altogether.

tepid vineBOT Dec 21, 2025, 9:42 PM

#

almeidx

[discordjs/discord.js] New comment on pull request #11368: feat(create-discord-bot): allow empty git-repositories

I think we can just include a .gitignore in each template

tepid vineBOT Dec 22, 2025, 12:44 AM

#

jacobhumston

[discordjs/discord.js] New comment on pull request #11368: feat(create-discord-bot): allow empty git-repositories

I think we can just include a .gitignore in each template

I added https://github.com/github/gitignore/blob/main/Node.gitignore to each template, bun init actually includes a .gitignore but it seems to just be a simplified version of the node one.

tepid vineBOT Dec 22, 2025, 8:16 PM

#

almeidx

[discordjs/discord.js] Pull request review submitted: #11368 feat(create-discord-bot): allow certain files/folders to be included in the target directory

#

almeidx

[discordjs/discord.js] New review comment on pull request #11368: feat(create-discord-bot): allow certain files/folders to be included in the target directory

As is, this comment will not be included in dist/index.js. The question is, should it? Seemingly, changing the start of this comment to /*! seems to make it be included at the bottom of the minified bundle

cc @iCrawl @ckohen

tepid vineBOT Dec 22, 2025, 9:00 PM

#

jacobhumston

[discordjs/discord.js] Pull request review submitted: #11368 feat(create-discord-bot): allow certain files/folders to be included in the target directory

#

jacobhumston

[discordjs/discord.js] New review comment on pull request #11368: feat(create-discord-bot): allow certain files/folders to be included in the target directory

Adding @license also places the comment to the bottom as well.

tepid vineBOT Jan 2, 2026, 6:05 PM

#

costajohnt

[discordjs/discord.js] Pull request opened: #11376 feat(create-discord-bot): implement Bun templates

Summary

Implements the Bun templates for create-discord-bot, addressing issue #11346.

This PR adds complete TypeScript and JavaScript templates for Bun that mirror the existing Node.js templates with Bun-specific optimizations:

Key Changes

Bun.env instead of process.env for environment variables (idiomatic Bun)
Bun.Glob for file pattern matching (better performance than node:fs/promises glob)
oven.bun-vscode added to recommended VS Code extensions
**npm.pa...

tepid vineBOT Jan 6, 2026, 9:06 PM

#

costajohnt

[discordjs/discord.js] New comment on pull request #11376: feat(create-discord-bot): implement Bun templates

Response to CodeRabbit Review Comments

Thank you for the thorough review! I've analyzed all 14 suggestions and want to address them:

Maintaining Consistency with Existing Templates

The Bun templates in this PR intentionally mirror the patterns used in the existing Node.js templates in this same monorepo. This ensures:

Consistent behavior across all runtime options
Easier maintenance (same patterns = same fixes)
Familiar structure for users switching between runtimes

...

tepid vineBOT Jan 7, 2026, 4:19 PM

#

almeidx

[discordjs/discord.js] Pull request review submitted: #11368 feat(create-discord-bot): allow certain files/folders to be included in the target directory

#

almeidx

[discordjs/discord.js] New review comment on pull request #11368: feat(create-discord-bot): allow certain files/folders to be included in the target directory

Let's go with @license then

tepid vineBOT Jan 7, 2026, 5:57 PM

#

almeidx

[discordjs/discord.js] Pull request review submitted: #11368 feat(create-discord-bot): allow certain files/folders to be included in the target directory

tepid vineBOT Jan 12, 2026, 7:14 PM

#

almeidx

[discordjs/discord.js] Pull request closed: #11376 feat(create-discord-bot): implement Bun templates

#

almeidx

[discordjs/discord.js] New comment on pull request #11376: feat(create-discord-bot): implement Bun templates

Duplicate of #11348

#

almeidx

[discordjs/discord.js] Pull request closed: #11365 feat(create-discord-bot): implement Bun templates

#

almeidx

[discordjs/discord.js] New comment on pull request #11365: feat(create-discord-bot): implement Bun templates

Duplicate of #11348

tepid vineBOT Jan 12, 2026, 7:49 PM

#

almeidx

[discordjs/discord.js] Pull request review submitted: #11348 feat: add Bun templates for create-discord-bot

tepid vineBOT Jan 15, 2026, 11:41 PM

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #11348 feat: add Bun templates for create-discord-bot

#

Jiralite

[discordjs/discord.js] New review comment on pull request #11348: feat: add Bun templates for create-discord-bot

--env-file isn't required for Bun as it is detected by default.^1 Whether we want to be explicit about that is not a blocker from me.

#

Jiralite

[discordjs/discord.js] Pull request review submitted: #11368 feat(create-discord-bot): allow certain files/folders to be included in the target directory

#

almeidx

[discordjs/discord.js] Pull request review submitted: #11348 feat: add Bun templates for create-discord-bot

#

almeidx

[discordjs/discord.js] New review comment on pull request #11348: feat: add Bun templates for create-discord-bot

Good to know. I think it would be better to be explicit since that way it will [likely] throw an error if the .env file is missing

tepid vineBOT Jan 16, 2026, 12:55 PM

#

didinele

[discordjs/discord.js] Pull request review submitted: #11368 feat(create-discord-bot): allow certain files/folders to be included in the target directory

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #11368 feat(create-discord-bot): allow certain files/folders to be included in the target directory

#

kodiakhq[bot]

[discord.js:main] 1 new commit

52a69d7 feat(create-discord-bot): allow certain files/f... - jacobhumston

tepid vineBOT Jan 16, 2026, 3:25 PM

#

vladfrangu

[discordjs/discord.js] Pull request review submitted: #11348 feat: add Bun templates for create-discord-bot

#

kodiakhq[bot]

[discord.js:main] 1 new commit

be78e26 feat: add Bun templates for create-discord-bot ... - ManInTheHam

#

kodiakhq[bot]

[discordjs/discord.js] Pull request closed: #11348 feat: add Bun templates for create-discord-bot

#create-discord-bot

Updates for https://github.com/discordjs/discord.js/tree/main/packages/create-discord-bot

Which application or package is this feature request for?

Feature

Description:

Changes Made:

Testing:

Which application or package is this feature request for?

Feature

Ideal solution or implementation

Alternative solutions or implementations

...

Which package is this bug report for?

Issue description

Code sample

Versions

Which package is this bug report for?

Issue description

Code sample

Versions

Issue priority

Which partials do you have configured?

Which application or package is this feature request for?

Feature

Ideal solution or implementation

Alternative solutions or implementations

Other context

Which package is this bug report for?

Issue description

Steps

Which package is this bug report for?

Issue description

Code sample

Versions

Issue priority

Which ...

Which package is this bug report for?

Issue description

Which package is this bug report for?

Issue description

Code sample

Versions

Pull request overview

Summary

Summary

Key Changes

Response to CodeRabbit Review Comments

Maintaining Consistency with Existing Templates

...