contributing | discord.js - imagine an app | Page 1

hushed root May 2, 2023, 4:50 AM

#

how do I fix these problems

midnight saddle May 2, 2023, 4:57 AM

#

Crawl just switched to bundler, which should resolve just fine. When are you getting this?

#

(also we can continue the convo from PR here)

hushed root May 2, 2023, 4:58 AM

#

I fast forwarded my branch & followed the contributing guide (yarn --immutable and yarn build)

#

basically none of my dependencies are resolving

midnight saddle May 2, 2023, 4:59 AM

#

if it built fine then it's just an ide error

#

have you tried restarting you ide?

#

(vsc in particular has a hard time after installing deps for some reason)

hushed root May 2, 2023, 5:00 AM

#

same issue unfortunately, restarting ts server & vscode don't seem to work

midnight saddle May 2, 2023, 5:00 AM

#

but it does build....hmmm

hushed root May 2, 2023, 5:00 AM

#

well actually I went from 30 errors to 7 so some things are working now

#

with build I have a tsup error

midnight saddle May 2, 2023, 5:01 AM

#

you're on windows huh

hushed root May 2, 2023, 5:01 AM

#

yeah lol

midnight saddle May 2, 2023, 5:02 AM

#

yeah, change the noExternal line in tsup.config.ts to noExternal = [/(?:(?:cjs)|(?:esm))_shims/],

hushed root May 2, 2023, 5:03 AM

#

thanks, seems to work

midnight saddle May 2, 2023, 5:03 AM

#

if my PR to tsup doesn't make it in soon, i'll PR it as a patch to our repo, usually tsup goes pretty fast

#

cool

#

does your PR happen to be based on my PR, or is it based on main

#

cause I'm suspecting not removing the resolveBody util will be important

hushed root May 2, 2023, 5:06 AM

#

it's on main

#

I got it to build correctly, tomorrow I'll fix tests and whatever

#

my branch is https://github.com/KhafraDev/discord.js/tree/byob-http-client

midnight saddle May 2, 2023, 5:18 AM

#

would you mind if I take some of the ideas here and morph my PR to do what you are suggesting. There's some things I'd like to add / change, but I really do like this idea.

hushed root May 2, 2023, 5:19 AM

#

I dont mind at all, feel free to take anything from there

midnight saddle May 2, 2023, 5:20 AM

#

awesome, I'll get to that in a bit then, and I'll request your review on the PR once I'm done

midnight saddle May 2, 2023, 11:36 AM

#

nevermind, can't request review cause you only commented, but it's done

#contributing