#How are Multiple PRs generally handled?

6 messages · Page 1 of 1 (latest)

surreal canopy
#

the question isn't directly related to djs but to the procedure of merging PRs in djs

• if a "topic" already has a PR, are PRs which supercede it accepted? If so what are the conditions for such PRs, eg, if a PR has been stale and has a few bugs, will fixing the bugs in the PR and making a new one be considered valid?

• if a "topic" has an incomplete PR, would making a superceding PR be considered valid?

• if a "new topic" has a new incomplete PR, would PRs introducing the same topic in a different manner with more content be considered valid?

the purpose of this question might seem like PR farming but i swear it's not and definitely unrelated to hacktoberfest the next month dogeHaHa

languid mesa
#

Why not simply contribute to the PR directly instead of making a new one?

surreal canopy
#

If the PR has too less content or If the PR is stale for example

civic shuttle
#

Depends how much something actually supercedes an existing PR. If theres an existing PR where requests for changes have just been ignored, author isn't responding and it isn't going to be merged in its current state, I'd say go right ahead

#

As for a topic being "incomplete", I don't see that happening very often, but again if the original author is still working on it and active, its probably rude to just push ahead with one that includes all the same work + a little more

#

Would be better to do a PR that has the extra functionality and reference "this should be merged after 1234"