#Website

1333 messages · Page 2 of 2 (latest)

dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
#
Qjuh
[discordjs/discord.js] Pull request opened: #10900 feat: structures

Please describe the changes this PR makes and why it should be merged:

Supersedes #8417

Introduces a generic structure implementation for the main lib (and others) to build on.

⚠️ This is currently in a very early proof of concept stage published as a PR to formulate ideas and solidify the intended structure (ha) of the module.

TODO:

  • [ ] Application
  • [ ] Audit Log
  • [ ] Auto Moderation
  • [ ] Channel
    • [x] Channels
    • [x] Mixins
      • [x] DM
      • [x] Guild
      • [x] Text
      • [...
dark summitBOT
dark summitBOT
#
almeidx
[discordjs/discord.js] New review comment on pull request #10900: feat: structures 
export * from './ChannelOwnerMixin.js';
export * from './ChannelParentMixin.js';
export * from './ChannelPermissionMixin.js';
export * from './ChannelPinMixin.js';
export * from './ChannelSlowmodeMixin.js';
export * from './ChannelTopicMixin.js';
export * from './ChannelWebhookMixin.js';
export * from './DMChannelMixin.js';
export * from './GuildChannelMixin.js';
export * from './TextChannelMixin.js';
export * from './ThreadChannelMixin.js';
export * from './ThreadOn...
dark summitBOT
dark summitBOT
#
paul-nguyen-1
[discordjs/discord.js] Issue opened: #10914 Duplicated word in the api-extractor.json file: "the the"

Which application is this bug report for?

Documentation

Issue description

In line 346, there is a duplicated word in the line "Specifies whether the message should be written to the the tool's output log". Note that the comment contains a duplicated word “the the”.

Steps to Reproduce

  1. Visit https://github.com/discordjs/discord.js/blob/main/api-extractor.json.
  2. Search using Command/CTRL + F or jump to line 346 to visit the comment "Specifies whether the ...
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
#
Ashish-bbg
[discordjs/discord.js] Issue opened: #10932 Code example requires ES module setup to support top-level await

Which application is this bug report for?

Documentation

Issue description

The code example in the documentation uses import and top-level await:

import { REST, Routes } from 'discord.js';

await rest.put(...);

This throws a SyntaxError unless the project is set up as an ES module, either by:

  • Adding "type": "module" in package.json, or

  • Renaming the file extension to .mjs

Even though the TOP they mentions "Node.js 22.12.0 or newer", that alone isn’t enoug...

dark summitBOT
#
almostSouji
[discordjs/discord.js] New comment on issue #10932: Code example requires ES module setup to support top-level await

As of version 22.7 node uses syntax detection and the example should run with a warning about re-parsing causing a performance overhead along with instructions on how to remove those [^1]. Accordingly, the recommended version 22.12.0 (though, really, people should generally use the recommended LTS) is beyond that point and should work as advertised.

(node:6378) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/user/Documents/test/index.js is not specified and it doesn'...
dark summitBOT
#
Ashish-bbg
[discordjs/discord.js] New comment on issue #10932: Code example requires ES module setup to support top-level await

👋Thanks for the quick response!

I did some deeper testing with Node.js v22.16.0 and I wanted to clarify why the example still fails for me (and likely others too):
Although Node 22+ supports auto module detection with a warning, it still throws a fatal SyntaxError when import is used at the top of a .js file without either:

  • "type": "module" in package.json, or
  • using a .mjs file extension.
    Even after adding a harmless line like console.log() above the import, Node shows th...
dark summitBOT
dark summitBOT
#
Ashish-bbg
[discordjs/discord.js] New comment on issue #10932: Code example requires ES module setup to support top-level await

@almostSouji @Jiralite @Qjuh @millette

Yes, you guys are absolutely right — my package.json had "type": "commonjs", and removing it resolved the issue.

But I’d still suggest updating the example with a short note, because:

When someone runs npm init -y, the generated package.json defaults to "type": "commonjs", which causes this example to fail with a SyntaxError.

So for most users, running the example as-is in a new Node project still won't work unless they:

  • remove ...
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
#
didinele
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

Why not abstract? So classes that don't have any work to do here don't need to implement? Not sure I love that, we could go this route instead if we want to avoid empty implementations everywhere:

	protected _optimizeData?(_data: Partial<DataType>): void;

and calls do this._optimizeData.?(); (kMixinConstruct also follows this pattern)

(notice the lack of an abstract keyword, that actually requires explicitly specifying it in the subclass even if you don't want...

dark summitBOT
#
Qjuh
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

This method gets defined/overridden in the Mixin process. Making it optional instead of an empty function body would mean that every implementation of a Structure would have to do the optional chaining of that method call in their constructor. kMixinConstruct works completely different, as it's not a method that gets overridden but instead all of them get combined into a single function that gets called in the Structure base class here if present. Implementers don't need to worry about th...

#
Qjuh
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

Ideally substructures (which objects as properties technically are) would be cloned in their _toJSON() applied after this in the Mixin. When that happens the structuredClone of that object would be completely replaced/overwritten again and we have unneeded overhead. So the real question is if we want to rely on implementation always overriding in Mixin or extended class if there are substructures or if we want to go the safe (but less performant) route of always deep cloning (structuredCl...

dark summitBOT
#
vladfrangu
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

pro tip: you can define ['constructor']: typeof BitField<Flags, Type> on the class level to skip all this casting, or make a getter function for it (https://www.typescriptlang.org/play/?#code/MYGwhgzhAECiAeYC2AHEBTAPAdQPYHdp14AXdAOwBMYByMG6AH2hoCMaA+aAbwCgBISulBgATumgQSYEgEtgRRKgwAFUbhQAuaCVEBXdAG5eAoSPHQA2jWC5yU-cBK5RNALraSATxTpcAMzglNCw8fA5jU2FwC29fSgA1MBADbTDI-n89cgAKAEoeAX5ZQJySAAtZCAA6OPRE5INoAF5WlnoCvn5uiqrq23tdPScXauJkELUNIv4AelnoRaXllYA9AH4igF8TbvnoAEEQMlFyGVkAN3Rd-l6akdEx4NV1FCL9la...

dark summitBOT
dark summitBOT
#
Qjuh
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

This works nicely for properties, but fails on new this.constructor(...) because BitField is abstract. Any ideas for those cases too? (https://www.typescriptlang.org/play/?ssl=23&ssc=1&pln=24&pc=1#code/IYIwzgLgTsDGEAJYBthjAgogD2AWwAdkBTAHgHUB7AdwWOwmIDsATDAcmHYQB8F2Q7AHwIA3gCgAkC2IpgUYgkjAIAS1h1chEgAUolAgC4E0AK7EA3OKky5ChAG12sSk0hRT8SlHYBdYxAAngTElABmWFpEZFTUQlY2sqj2QSEsAGrAyObGsQmSYaZMABQAlGJSkqoRxRAAFqpgAHSpxBlZ5ggAvD38XOUSkkP1jU0ubmZeUE30+NF6BpWSAPTLCOsbm1sAegD8lQC+1kOrCACCyIxQTCqqAG7E...

dark summitBOT
#
didinele
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

Initially I came up with

type NonAbstract<Constructor> = Constructor extends abstract new (...args: infer Args) => infer Instance ? new (...args: Args) => Instance : never;

but that got rid of static props, but with some tweaking I got this:
https://www.typescriptlang.org/play/?#code/C4TwDgpgBAcg9gOwIICMDOwBOBDAxsAHgBUoIAPYCBAEzSm3Sz2CgQgHcoAKAOj+0wBzNAC56CEAEooAXgB84kApkAoKFBLlKNOgww58rDtz48BwsQEsEAMwiYoSIWmnyo1uw4CSCDNgS4EGrqUAD83GycvPzOYk7Crgo+fgEQ0gBkUAAKlrgA1sQANFB5ECBw...

dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
wild tapir
#

Website

dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
#
Qjuh
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

Java: https://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#clone()
C#: https://learn.microsoft.com/en-us/dotnet/api/system.icloneable?view=netcore-3.1
C++: uses copy constructors instead, so fair, they don't
Ruby: https://docs.ruby-lang.org/en/3.4/Kernel.html#method-i-clone
Python: they use deepcopy and copy instead of clone indeed
PHP: they use the __clone() method https://www.php.net/manual/en/language.oop5.cloning.php
I could go on but I guess you see what i mean

dark summitBOT
dark summitBOT
#
almeidx
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

Discoverability for one. It's also much worse DX.

There's basically 2 levels of end-user. The actual end-users, i.e. users of discord.js, and other libs extending structures, like discord.js itself will

Patch and clone I think would realistically only be used by the latter, which maybe justifies "hiding" them behind symbols. DataTemplate is meant to be used by the actual end users, and in my eyes is one of the selling points of /structures

dark summitBOT
#
almeidx
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

This @ts-expect-error comment is actually suppressing 2 errors, one of which seems unexpected as it isn't related to the reasoning in the comment.

Moving the arguments into a new line reveals the second error, on the Object.assign() call, specifically the clone:

No overload matches this call.
  Overload 1 of 4, '(target: {}, source: Readonly<Partial<DataType>>): Readonly<Partial<DataType>>', gave the following error.
    Argument of type 'DataType' is not assignable to parameter...
dark summitBOT
#
Qjuh
[discordjs/discord.js] New review comment on pull request #10900: feat: @discordjs/structures

I understand the idea, but that would mean that users implementing this would either

  • also do protected static override readonly [DataTemplatePropertyName]: ... making it same/worse than symbols
  • use protected static override readonly DataTemplate: ... and not match how it's written in the base class, which is also weird (and face the same issue if renamed)
    The purpose of the variables for DataTemplatePropertyName is merely to be used in the Mixin function, which is in another file....
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
#
Jiralite
[discordjs/discord.js] New comment on issue #11022: Several documentation problems.

If the exports you are describing do not exist, then discord.js would be totally broken as no API requests would be made and you would not be able to connect to the gateway. All hell would break loose in the support server (for years), but alas, nothing of the sort is happening. Things are not working out for you because of unknown reasons – you have not provided enough information to work with. You should head over to the support server and see how we can help.

A...

dark summitBOT
dark summitBOT
dark summitBOT
#
Jiralite
[discordjs/discord.js] Pull request review dismissed: #11026 feat: rpc

Missing stuff:

https://github.com/discordjs/discord.js/blob/943c39e4c068447c968faa3814d3622e02dca3fb/.github/ISSUE_TEMPLATE/01-package_bug_report.yml#L11-L32

https://github.com/discordjs/discord.js/blob/943c39e4c068447c968faa3814d3622e02dca3fb/.github/ISSUE_TEMPLATE/03-feature_request.yml#L11-L33

https://github.com/discordjs/discord.js/blob/943c39e4c068447c968faa3814d3622e02dca3fb/.github/workflows/deprecate-version.yml#L5-L23

https://github.com/discordjs/discord.js/blob/943c39e4c068447c9...

dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
#
vladfrangu
[discordjs/discord.js] Issue opened: #11186 Docs website doesn't handle dtypes `@unstable` tags nicely

Which application is this bug report for?

Documentation

Issue description

In discord-api-types, we use the @unstable tag on several types to denote that a specific type, field, enum value, etc, is currently not fully documented, but does exist, and as such should not be relied upon. The djs docs website doesn't handle those tags quite nicely

Steps to Reproduce

Look at https://discord-api-types.dev/api/discord-api-types-v10/enum/UserFlags#Quarantined, then https://discord.js...

dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
#
samheckle
[discordjs/discord.js] Issue opened: #11232 Retrieving & adding roles with `getRole` vs. `fetch()`

Which application is this bug report for?

Documentation

Issue description

There's a bit of a discrepancy between the FAQ guides and the documentation and would love some clarification. I'm just confused as to where these get methods are being defined for roles, as the docs use fetch requests instead.

I see that interaction.options is defined by BaseInteraction. In the common use case of adding roles based on reactions, I don't think this works and you would need to use the `R...

dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
dark summitBOT
#
rohitsivakumar30643
[discordjs/discord.js] Issue opened: #11300 Incorrect method .addComponents() shown in ContainerBuilder documentation

Which application is this bug report for?

Documentation

Issue description

The documentation example for ContainerBuilder shows a method call:

.addComponents(separator, section)

However, .addComponents() does not exist in the discord.js builders API.

The correct methods are:

  • .addSeparatorComponents(separator)
  • .addSectionComponents(section)

This incorrect example appears in:
packages/builders/src/components/v2/Container.ts

This can confuse developers and cause TypeError...

dark summitBOT
dark summitBOT
dark summitBOT
#
Mazurex
[discordjs/discord.js] Issue opened: #11424 EmbedBuilder "extends BuildersEmbed" link points to 404 page

Which application is this bug report for?

Documentation

Issue description

On the documentation page for EmbedBuilder, the extends BuildersEmbed link points to a 404 page.
Because of this, there is no accessible documentation for Embeds.

Steps to Reproduce

  1. Go to https://discord.js.org/docs/packages/discord.js/14.25.1/EmbedBuilder:Class
  2. Click on "extends BuildersEmbed"

Versions

  • Mozilla Firefox for Linux Mint 148.0.2 (64-bit)
  • Linux Mint (Cinnamon)

Issue ...

dark summitBOT
dark summitBOT
#
carolinaisslaying
[discordjs/discord.js] Issue opened: #11523 Various type properties lead to a 404 error on the docs

Which application is this bug report for?

Documentation

Issue description

Clicking on the link to various type properties leads to a 404 error on the docs. Searching for them also leads to a 404 error.

I have noted this down as a medium priority issue, as multiple pages of the documentation are completely missing. It does not seem particularly urgent but I believe it is more than a minor annoyance.

Steps to Reproduce

Example:

  1. Go to https://discord.js.org/docs/packages/dis...
dark summitBOT
#
MorganVonBrylan
[discordjs/discord.js] Issue opened: #11531 Add the name of the class/enum/etc in the page title

Which application is this bug report for?

Documentation

Issue description

Currently, all the title says is "discord.js", the version number, and then "discord.js" again.
This is not helpful at all when using the browsing history or when you have several tabs.

It would be much better if there were, for example, User:class | discord.js (version), UserFlags:Enum | discord.js (version), etc.

I remember that this had already been an issue in the past, and it had been fixed, so th...

dark summitBOT
#
vaguul
[discordjs/discord.js] New comment on issue #11531: Add the name of the class/enum/etc in the page title

Not a maintainer, but the current website code seems to explain part of this.

In apps/website/src/app/docs/packages/[packageName]/[version]/[[...item]]/page.tsx, generateMetadata() parses the item path and then does:

const titlePart = decodedItemName.split(':')?.[0] ?? decodedItemName;

return {
  title: `${titlePart} (${packageName} - ${version})`,
};

So for a docs item like User:Class or UserFlags:Enum, the page title intentionally drops the :Class / :Enum part. The...