#Missing types for application command options

1 messages · Page 1 of 1 (latest)

coarse igloo

As pointed out by Jira recently on GitHub, discord.js was missing a few typings for application command options.
Namely Boolean, Role, User and Mentionable.

I cross-checked all possible options, and found a few possible missing types that I'm not sure about (see yellow fields in attached image).

  1. ApplicationCommandOption includes ApplicationCommandAttachmentOption. However, ApplicationCommandOptionData does not include ApplicationCommandAttachmentOptionData (which doesn't even exist). Is that correct?
  2. ApplicationCommandSubCommandData does not include ApplicationCommandAttachmentOption. This is probably correct, since I can't imagine an attachment being part of a subcommand. But... is it? - Actually, I should test this one by myself.
  3. ApplicationCommandAutocompleteOption is part of ApplicationCommandOptionData. The naming is inconsistent, since I'd have expected it to be called ApplicationCommandAutocompleteOptionData. Is there a reason for that?
  4. ApplicationCommandAutocompleteOption (or anything having to do with autocomplete) is missing from ApplicationCommandOption.

I just wanna make sure that the typings for application command options are correct, but I'm very new to this.