archive-github-djs

[heavy crow]

erdemozturkfun

[discordjs/discord.js] Issue opened: #6489 Commands and interactions dont register

Please describe the problem you are having in as much detail as possible:
Im having issue with registering commands or interactions.
The code runs without errors but /ping command doesnt show up in / commands.

Include a reproducible code sample here, if possible:

// index.js
const {Client, Intents} = require('discord.js');
const { token } = require('./config.json');


const client = new Client({
	intents: [Intents.FLAGS.GUILDS, Intents.FLAGS.GUILD_MESSAGES...

GoldenAngel2

[discordjs/discord.js] New comment on issue #6489: Commands and interactions dont register

You need to register slash commands: https://discordjs.guide/interactions/registering-slash-commands.html
Gives you examples for that.

Note: Global slash commands can take up to 1 hour to show up in all servers, guild slash commands is instant

For coding questions/support use the server: https://discord.gg/djs

[heavy crow]

Jiralite

[discordjs/discord.js] New comment on pull request #6484: feat\(Message\): Add method to resolve a component by id

Link buttons don't have a custom id, so there is nothing unique about them. You can have the same structure of a link button for 25 buttons in a message. It's not ideal to have a resolver for something that is not unique (just yet)!

ImRodry

[discordjs/discord.js] New comment on pull request #6484: feat\(Message\): Add method to resolve a component by id

I was suggesting using the same logic but for the button's URL. I know you can have the same URL in different buttons but I don't see why anyone would do that. You could also add a warning saying it will return the first button with the given URL if a URL is passed.
Alternatively I think you should add some sort of note saying LINK buttons will not work as they do not have customIds

ImRodry

[discordjs/discord.js] Pull request opened: #6490 feat: set methods for MessageActionRow and MessageSelectMenu

Please describe the changes this PR makes and why it should be merged:
Following the PR that added the setFields method for MessageEmbeds, this PR adds two new methods: setOptions for MessageSelectMenu and setComponents for MessageActionRow.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don'...

[heavy crow]

erdemozturkfun

[discordjs/discord.js] New comment on issue #6489: Commands and interactions dont register

Thanks it works now!

erdemozturkfun

[discordjs/discord.js] Issue closed: #6489 Commands and interactions dont register

[heavy crow]

Taelyn

[discordjs/discord.js] Issue opened: #6491 applicationCommandCreate doesnt fire

applicationCommandCreate doesnt fire when Guild Command is created
Havent tried Delete and Update but my guess is the same issue

According to Docs and Discord Developer it should fire for both Guild and Client Command Applications

client.on('applicationCommandCreate', async command => {
    console.log(command)
});

Further details:

• discord.js version: 13.1
• Node.js version: 16.6.2
• Operating system: x64 win 10

[heavy crow]

Jiralite

[discordjs/discord.js] New comment on issue #6491: applicationCommandCreate doesnt fire

This is not a bug: see https://github.com/discord/discord-api-docs/issues/3690#issuecomment-902915187.

On this note, we should remove them too.

Taelyn

[discordjs/discord.js] Issue closed: #6491 applicationCommandCreate doesnt fire

[heavy crow]

ImRodry

[discordjs/discord.js] Pull request opened: #6492 refactor\(Client\): remove applicationCommand events

Please describe the changes this PR makes and why it should be merged:
This PR removes applicationCommand events as a Discord developer said they were not meant to be sent to bots (https://github.com/discord/discord-api-docs/issues/3690#issuecomment-902915187). This can be a semver minor since the events never fired anyway.
Upstream PR:

• https://github.com/discord/discord-api-docs/pull/3691

Status and versioning classification:

• Code changes have been tested against the Disc...

kyranet

[discordjs/discord.js] Pull request review submitted: #6482 docs\(MessageManager\): fix typo

Jiralite

[discordjs/discord.js] Pull request review submitted: #6492 refactor\(Client\): remove applicationCommand events

You have missed these:
https://github.com/discordjs/discord.js/blob/e87324ed9d221ab7d13b8609f9a6fe1e72070707/src/util/Constants.js#L213-L215
https://github.com/discordjs/discord.js/blob/e87324ed9d221ab7d13b8609f9a6fe1e72070707/src/util/Constants.js#L267-L269
https://github.com/discordjs/discord.js/blob/e87324ed9d221ab7d13b8609f9a6fe1e72070707/typings/index.d.ts#L4684-L4686

iCrawl

[discordjs/discord.js] Pull request review submitted: #6482 docs\(MessageManager\): fix typo

iCrawl

[discordjs/discord.js] Pull request closed: #6482 docs\(MessageManager\): fix typo

iCrawl

[discord.js:main] 1 new commit

70cc029 docs(MessageManager): fix typo (#6482) - ImRodry

ajpalkovic

[discordjs/discord.js] Pull request review submitted: #6485 docs\(ThreadManager\): Fix typo

ajpalkovic

[discordjs/discord.js] New review comment on pull request #6485: docs\(ThreadManager\): Fix typo

I wouldn't say that is necessarily accurate

the guild feature will exist for private threads if they have private threads, same for 3/7 day times

github-actions[bot]

[discord.js:docs] 1 new commit

72a4258 Docs build for branch main: 70cc0295f833cd988ea... - iCrawl

iCrawl

[discordjs/discord.js] Pull request review submitted: #6478 feat: export BaseCommandInteraction

iShibi

[discordjs/discord.js] Pull request opened: #6493 feat: add support for GuildEvent

Please describe the changes this PR makes and why it should be merged:

This PR starts the work of adding support for GuildEvent structure:

• discord/discord-api-docs#3586

Todo:

• [x] Add GuildEvent class
• [ ] Define all properties of the GuildEvent class
• [ ] Add Complete Documentation
• [ ] Add Complete Typings
• [ ] Get List of guild events in a guild
• [ ] Post Create a guild event
• [ ] Get List of guild events available to the bot
• [ ] Get A guild even...

iCrawl

[discordjs/discord.js] New comment on issue #6477: Chains/Functions not sending messages after collecting messages

The issue tracker is only for bug reports and enhancement suggestions. If you have a question, please ask it in the Discord server instead of opening an issue – you will get redirected there anyway.

iCrawl

[discordjs/discord.js] Issue closed: #6477 Chains/Functions not sending messages after collecting messages

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

vladfrangu

[discordjs/discord.js] New review comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

I don't see the point of that documentation for ThreadChannel#id link - especially if threads ever stop sharing IDs with their message

   * reject. If you just need the id of that message, use {@link ThreadChannel#id} instead.</info>

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6490 feat: set methods for MessageActionRow and MessageSelectMenu

Sure

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6492 refactor\(Client\): remove applicationCommand events

LGTM after Jiralite's comments are resolved

ImRodry

[discordjs/discord.js] New comment on pull request #6492: refactor\(Client\): remove applicationCommand events

Sorry I fixed and forgot to push xD

ImRodry

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

ImRodry

[discordjs/discord.js] New review comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

If they intentionally made it like this, I doubt this will ever change, but I'll apply that suggestion

[heavy crow]

entres999

[discordjs/discord.js] Issue opened: #6494 node version problem

If I go to my bot's project folder in CMD/Shell and I type node -v it will tell me 16.7.0. The same in the package.json file. But using the code console.log(process.version) it will tell me v14.17.5. How can i fix this?

ImRodry

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

Once the upstream PR lands, please add the @see link (maybe add a TODO comment so you don't forget)

ImRodry

[discordjs/discord.js] Pull request review submitted: #6493 feat: add support for GuildEvent

I know this is still a draft, these are just some notes for the future mostly

ImRodry

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

You can probably make the typedef for this already

ImRodry

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

Same as above

iShibi

[discordjs/discord.js] Pull request review submitted: #6493 feat: add support for GuildEvent

iShibi

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

sure, I'll resolve these convos only when it's done so that I don't forget

ImRodry

[discordjs/discord.js] Pull request review submitted: #6493 feat: add support for GuildEvent

ImRodry

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

Oh forgot this but this is why the CI is failing

       * The id of the stage channel this event belongs to
       * @type {Snowflake}

[heavy crow]

Sniped

[discordjs/discord.js] New comment on issue #6480: Threads with discord\.js

I can reproduce something to this effect, where whenever a thread is created both the threadCreate event and messageCreate events are emitted. The message object in the messageCreate event seems to have a content string that is the same as the name of the thread created. This repo reproduces what appears to be causing this bug.

It looks like whenever you thread on a cached message, a message event is emitted with no content, and whenever you ...

ImRodry

[discordjs/discord.js] New comment on issue #6494: node version problem

The issue tracker is for issues with the package. Please send questions on the Discord server only and close this

ImRodry

[discordjs/discord.js] New comment on issue #6480: Threads with discord\.js

When a thread is created, a message of type THREAD_CREATED is sent so this behavior is expected. You have to run your own checks to prevent this from happening. Please send all future questions on the Discord server in the future so as to not clog the issue tracker

[heavy crow]

bastianmarin

[discordjs/discord.js] Issue opened: #6495 Problem getting the members of a Role \(Role Members Cache\)

I'm trying to move my bot from v12 to v13 but I have some issues that I really don't know if it's a bug or something I don't understand.

I try to retrieve the collection of members of a role from its cache but in v13 it does not return all of them unlike v12 which returns all the members.

Use Client.guilds.cache.get(...).roles.fetch(...).members

in version 12 I ge...

iCrawl

[discordjs/discord.js] New comment on issue #6495: Problem getting the members of a Role \(Role Members Cache\)

The issue tracker is only for bug reports and enhancement suggestions. If you have a question, please ask it in the Discord server instead of opening an issue – you will get redirected there anyway.

iCrawl

[discordjs/discord.js] Issue closed: #6495 Problem getting the members of a Role \(Role Members Cache\)

[heavy crow]

entres999

[discordjs/discord.js] Issue closed: #6494 node version problem

[heavy crow]

advaith1

[discordjs/discord.js] Pull request opened: #6496 feat\(Invite\): support friend invites

Please describe the changes this PR makes and why it should be merged:
Adds support for friend invites:

• https://github.com/discord/discord-api-docs/pull/3659

To be non-breaking, this PR adds a supportFriendInvites ClientOption: by default, it is false, and fetching a friend invite will continue to throw an error. If it is set to true, fetching a friend invite will return an Invite with channel as null.

The guide should recommend setting supportFriendInvites to true.

*...

suneettipirneni

[discordjs/discord.js] New review comment on pull request #6476: types: Allow message component interaction collectors to infer collected interaction types

Good point, that has been fixed.

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #6476 types: Allow message component interaction collectors to infer collected interaction types

Drylozu

[discordjs/discord.js] Pull request opened: #6497 types\(CommandInteractionOptionResolver\): add missing parameter

Please describe the changes this PR makes and why it should be merged:
This PR adds the missing parameter called resolved in CommandInteractionOptionResolver that was introduced in #6384 but not added in the typings.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

vladfrangu

[discordjs/discord.js] Pull request review dismissed: #6476 types: Allow message component interaction collectors to infer collected interaction types

vladfrangu

[discordjs/discord.js] Pull request review dismissed: #6488 feat\(ThreadChannel\): add fetchStarterMessage

[heavy crow]

loidnoir

[discordjs/discord.js] Issue opened: #6498 User banner/accent color

Is your feature request related to a problem? Please describe.
I wanna create user information command and cant get banner/accent color

Describe the ideal solution
Add banner and accent color property for users

Describe alternatives you've considered
No alternative solutions

Additional context

const banner = .bannerURL

vBread

[discordjs/discord.js] New comment on issue #6498: User banner/accent color

#6117

[heavy crow]

Megatank58

[discordjs/discord.js] Pull request opened: #6499 docs\(Formatters\): fix typo of TimestampStyles

Please describe the changes this PR makes and why it should be merged:

This pr makes the style parameter of TimestampStyle to TimestampStylesString as the style is of string not an object

Status and versioning classification:

• This PR only includes non-code changes, like changes to documentation, README, etc.

[heavy crow]

Wondermarin

[discordjs/discord.js] Pull request opened: #6500 feat\(CommandInteractionOptionResolver\): add default value for get\[option\]

Please describe the changes this PR makes and why it should be merged:

Adds the defaultValue parameter for getBoolean, getString, getInteger, and getNumber in cases when the option is optional.

I'm not sure whether it's worth adding this parameter for the rest of the options, so for now I've stopped only on the "primitive" ones.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how ...

[heavy crow]

advaith1

[discordjs/discord.js] New comment on pull request #6500: feat\(CommandInteractionOptionResolver\): add default value for get\[option\]

getString('field', false, 'default')

is longer than

getString('field') ?? 'default'

so this doesn't seem very useful

ckohen

[discordjs/discord.js] Pull request opened: #6501 feat\(Threads\): add support for invitable in private threads

Please describe the changes this PR makes and why it should be merged:

Closes: #6379

Fixes a bug in typings that didn't pass the allowable thread types properly for news channels since this relies on it.

⚠️ The invitable field in the thread creation endpoint does not seem to be respected at the moment, it is supported here, but the API does not utilize it, always setting true.

Status and versioning classification:

• Code changes have been tested against the Discord A...

[heavy crow]

almeidx

[discordjs/discord.js] Pull request review submitted: #6496 feat\(Invite\): support friend invites

The supportFriendInvites client option is missing in the typings

[heavy crow]

ImRodry

[discordjs/discord.js] Pull request opened: #6502 docs\(GuildChannelCreateOptions\): fix \#type type

Please describe the changes this PR makes and why it should be merged:
The type of the type property in this typedef was set to string|number which is misleading since this is actually supposed to be a ChannelType, so this PR fixes that.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• This PR only includes non-code changes, like changes to documentation, README, etc.

ImRodry

[discordjs/discord.js] New review comment on pull request #6501: feat\(Threads\): add support for invitable in private threads

Since we're using node v16.6 now, why not change this and all the other ones above to the following

        this.invitable ??= null;

ImRodry

[discordjs/discord.js] Pull request review submitted: #6501 feat\(Threads\): add support for invitable in private threads

[heavy crow]

BlackKnight683

[discordjs/discord.js] Issue opened: #6503 Client Shard Timeour Error

Please describe the problem you are having in as much detail as possible:
My discord bot keeps getting timed our randomly, i have no idea why. Its a lavalink music bot running along another bot of mine which does not crash. the vps is given 4gb ram and 2vCore CPU

Include a reproducible code sample here, if possible:

const app = express();
const port = 2...

ImRodry

[discordjs/discord.js] New comment on issue #6503: Client Shard Timeour Error

The issue tracker is not for asking questions. The issue you are facing is not a problem with the library so please ask on the Discord server and close this

BlackKnight683

[discordjs/discord.js] New comment on issue #6503: Client Shard Timeour Error

Alrighty

BlackKnight683

[discordjs/discord.js] Issue closed: #6503 Client Shard Timeour Error

[heavy crow]

Megatank58

[discordjs/discord.js] Pull request opened: #6504 docs: fix wrong type being displayed in docs

Please describe the changes this PR makes and why it should be merged:
Interaction should be MessageComponentInteraction instead of ButtonInteraction

Status and versioning classification:

• This PR only includes non-code changes, like changes to documentation, README, etc.

ImRodry

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

ImRodry

[discordjs/discord.js] New review comment on pull request #6504: docs: fix wrong type being displayed in docs

Why

[heavy crow]

Megatank58

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

Megatank58

[discordjs/discord.js] New review comment on pull request #6504: docs: fix wrong type being displayed in docs

Interaction can be both select menu interaction and button interaction but here only button interaction was mentioned

ImRodry

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

ImRodry

[discordjs/discord.js] New review comment on pull request #6504: docs: fix wrong type being displayed in docs

No, this mentioned Interaction and is still correct, please revert this

Megatank58

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

Megatank58

[discordjs/discord.js] New review comment on pull request #6504: docs: fix wrong type being displayed in docs

Oh my bad I'll close the pr

ImRodry

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

ImRodry

[discordjs/discord.js] New review comment on pull request #6504: docs: fix wrong type being displayed in docs

No, just revert this line alone

Megatank58

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

Megatank58

[discordjs/discord.js] New review comment on pull request #6504: docs: fix wrong type being displayed in docs

yeah sorry i misspelled

thehackerboi69github

[discordjs/discord.js] Pull request review submitted: #6327 refactor\(Client\): remove message sweeping options

[heavy crow]

scripted1337

[discordjs/discord.js] Issue opened: #6505 u should tbh make a python api wrapper

ok

scripted1337

[discordjs/discord.js] Issue closed: #6505 u should tbh make a python api wrapper

[heavy crow]

Medallyon

[discordjs/discord.js] Issue opened: #6506 GuildMember\.identity

Is your feature request related to a problem? Please describe.
I noticed that d.js doesn't implement Guild-specific Identities. User.displayAvatarURL() only retrieves the user's default avatar. Discord's newest feature, Server Identities, allows people to change their nickname and avatar for specific Guilds.

Describe the ideal solution
I think d.js could implement GuildMember.identity, where identity is of type GuildMemberIdentity, thereby also moving `GuildMember...

[heavy crow]

vBread

[discordjs/discord.js] New comment on issue #6506: GuildMember\.identity

#5696

Medallyon

[discordjs/discord.js] New comment on issue #6506: GuildMember\.identity

OH. I looked for "identity" in issues & PRs and couldn't find any duplicates. Thanks =)

Medallyon

[discordjs/discord.js] Issue closed: #6506 GuildMember\.identity

[heavy crow]

Wondermarin

[discordjs/discord.js] New comment on pull request #6500: feat\(CommandInteractionOptionResolver\): add default value for get\[option\]

getString('field', false, 'default')

is longer than

getString('field') ?? 'default'

so this doesn't seem very useful

Yes, it's true.

However, in TypeScript, the solution you are talking about is unsafe, because with this operator you can assign a string to getInteger and it will not cause an error.

And the current implementation looks more expensive:

// Current implementation.
const x = getInteger("x") ?? "5"; // no er...

[heavy crow]

jkcoxson

[discordjs/discord.js] Issue opened: #6507 TextChannel Webhooks methods don't resolve

Please describe the problem you are having in as much detail as possible:
A bot is able to create a Webhook just fine, but the promise for creating a Webhook and the promise for fetching a Webhook is never resolved or rejected.
Include a reproducible code sample here, if possible:

client.on('ready', () => {
    console.log('ready');
    const channel = client.channels.cache.get('123');
    channel.createWebhook('MyFancyWebhook').catch(err => {
        console.log(err);...

suneettipirneni

[discordjs/discord.js] New comment on pull request #6500: feat\(CommandInteractionOptionResolver\): add default value for get\[option\]

getString('field', false, 'default')

is longer than

getString('field') ?? 'default'

so this doesn't seem very useful

Yes, it's true.

However, in TypeScript, the solution you are talking about is unsafe, because with this operator you can assign a string to getInteger and it will not cause an error.

And the current implementation looks more expensive:

...

[heavy crow]

Wondermarin

[discordjs/discord.js] New comment on pull request #6500: feat\(CommandInteractionOptionResolver\): add default value for get\[option\]

However, in TypeScript, the solution you are talking about is unsafe, because with this operator you can assign a string to getInteger and it will not cause an error.

Typescript will evaluate the type to number | string in the example you gave. Even if someone does this in their code, you won't be able to use the type number | string as a number or string without casting at some point to a number or string. If you get a union type composed of two orthogonal types it's pre...

[heavy crow]

kyranet

[discordjs/discord.js] New comment on pull request #6500: feat\(CommandInteractionOptionResolver\): add default value for get\[option\]

I'd consider that as user-error, and it's their responsibility to do such things. Besides, the default is always evaluated and cannot be done lazily, and you can't stop them from using getString('field') ?? 'default' either way.

[heavy crow]

RavenDuffy

[discordjs/discord.js] Issue opened: #6508 No "exports" main defined in \.\.\./discord\-api\-types/package\.json

The Problem:
I'm attempting to create a bot using typescript. So far, I've basically been following the tutorial provided. When I try to register slash commands (either globally or per guild), I encounter the issue below:

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in ...\node_modules\discord-api-types\package.json
    at new NodeError (node:internal/errors:371:5)
    at throwExportsNotFound (node:int...

vladfrangu

[discordjs/discord.js] New comment on issue #6508: No "exports" main defined in \.\.\./discord\-api\-types/package\.json

Not a bug, you need to add a version to the import of discord-api-types :D

For further questions, feel free to ask in our Discord server

RavenDuffy

[discordjs/discord.js] New comment on issue #6508: No "exports" main defined in \.\.\./discord\-api\-types/package\.json

Yeah, someone just responded and told me.. haha good time I guess. Thanks though!

RavenDuffy

[discordjs/discord.js] Issue closed: #6508 No "exports" main defined in \.\.\./discord\-api\-types/package\.json

[heavy crow]

PuneetGopinath

[discordjs/discord.js] New review comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

    return this.channel.messages.fetch(this.id, options) ?? null;

PuneetGopinath

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

PuneetGopinath

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

I guess it has to be nullable as I tried deleting the starter message in a thread

ImRodry

[discordjs/discord.js] New comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

@PuneetGopinath refer to monbrey’s comment: https://github.com/discordjs/discord.js/pull/6488#issuecomment-903110014

ImRodry

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

ImRodry

[discordjs/discord.js] New review comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

Even if fetch didn’t throw an error this is still invalid

NotSugden

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

NotSugden

[discordjs/discord.js] New review comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

this is not valid, MessageManager#fetch (MessageManager#_fetchId) does not return null

PuneetGopinath

[discordjs/discord.js] New comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

@PuneetGopinath refer to monbrey’s comment: #6488 (comment)

Ohk. Didn't notice, but the ?? null wasn't there.

PuneetGopinath

[discordjs/discord.js] New comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

@PuneetGopinath refer to monbrey’s comment: #6488 (comment)

Ohk.

monbrey

[discordjs/discord.js] New comment on pull request #6488: feat\(ThreadChannel\): add fetchStarterMessage

Ohk. Didn't notice, but the ?? null wasn't there.

Nor should it be there, because fetch will either resolve to a Message, or throw. Nullish-coallescing is not possible or correct in any sense.

[heavy crow]

J-Human

[discordjs/discord.js] Pull request opened: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

Please describe the changes this PR makes and why it should be merged:

This allows users to mark media as spoilers before sending them to Discord's API. The motivation behind this is for convenience, as in, users not needing to place the SPOILER_ string.

You'll see a validation if the given argument is false, as it's possible to have the spoiler string inside the string itself, hence removing the title users would expect. I have adapted this from #6473 but I didn't make it an ...

vBread

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

vBread

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

   * Sets whether this attachment is a spoiler
   * @param {boolean} spoiler Whether the attachment should be marked as a spoiler

Wording here could be improved to be consistent with other descriptions (e.g., .setNSFW)

[heavy crow]

ckohen

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ckohen

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

You should do the reverse validation here to avoid ending up with SPOILER_SPOILER_name.png or something

[heavy crow]

ckohen

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

No need for else if here, just use if since the first statement always returns

ckohen

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ckohen

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ckohen

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

    }
    if (this.spoiler === true) this.name.replace('SPOILER_', '');
    return this;

That's not quite what I meant 😆 The else is redundant since the first if block always returns

[heavy crow]

ThatAnonyG

[discordjs/discord.js] New comment on pull request #6027: fix\(Structures\): remove Structures

Amazing.. time to take my bot for DAYS to fix this mess. Thanks DJS.

Positive2022

[discordjs/discord.js] Issue opened: #6510 Bot crash while it updates itself

Please describe the problem you are having in as much detail as possible:
I was updating my bot's pfp and I had my bots console opened cuz I was updating it. Just when i updated the bot's pfp, the bot crashed giving out an error.

Error:

/home/container/node_modules/discord.js/src/client/actions/UserUpdate.js:11
    const oldUser = newUser._update(data);
                            ^

TypeError: Cannot read property '_update' of undefined
    at UserUpdateAction.hand...

Positive2022

[discordjs/discord.js] New comment on issue #6510: Bot crash while it updates itself

Note: Also happened when I changed the bots username.
Note 2: The pfp error that occured when I changed application's pfp which ofcourse changes bot user's pfp.

[heavy crow]

Jiralite

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

Has this been tested? This method is calling the spoiler getter, which returns the basename utility method and passes the URL across. But that won't exist via instantiating this class and will throw an error?

ThatAnonyG

[discordjs/discord.js] New comment on pull request #6027: fix\(Structures\): remove Structures

👍 Completely break commando and any bots that use Structures properly.

Sounds a great plan to me :D

PenPow

[discordjs/discord.js] New comment on pull request #6027: fix\(Structures\): remove Structures

👍 Completely break commando and any bots that use Structures properly.

Sounds a great plan to me :D

Commando is deprecated, and doesn't support V13, it is recommended that you use Sapphire instead.

As stated in the original description, they are impossible to maintain, unpredictable, and still can be easily implemented using databases. Using structures is a personal preference, and complicates support.

[heavy crow]

Keke27210

[discordjs/discord.js] Pull request opened: #6511 fix\(UserUpdateAction\): rely on client\.user when ids match

Please describe the changes this PR makes and why it should be merged:

When the UserManager cache is disabled, updating the client user will result in a crash. The user update action gets the old state of the user via the UserManager cache, even if it's the client user. However, when it's disabled, nothing is being returned and so newUser._update throws a type error.

This fix makes the code get client.user if client.user.id and data.id are equal.

**Status and versioni...

ThatAnonyG

[discordjs/discord.js] New comment on pull request #6027: fix\(Structures\): remove Structures

👍 Completely break commando and any bots that use Structures properly.

Sounds a great plan to me :D

Commando is deprecated and doesn't support V13, it is recommended that you use Sapphire instead.

As stated in the original description, they are impossible to maintain, unpredictable, and still can be easily implemented using databases. Using structures is a personal preference, and complicates support.

"Using structures is a personal preference" - BRUH...

ThatAnonyG

[discordjs/discord.js] New comment on pull request #6027: fix\(Structures\): remove Structures

I found somewhat of a better solution to the absence of the Structures class which works with typescript too.

import { Message, MessageEmbed } from "discord.js";
import { Xenus } from "..";

type ExtendedMessage = {
  embed: MessageEmbed;
  sm(content: string, specialType?: "err" | "base"): Promise<Message>;
} & Message;

function extendMessage(this: Xenus, message: Message): ExtendedMessage {
  const embed = new MessageEmbed().setTimestamp();
  const sm = (content: string...

ImRodry

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ImRodry

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

What if spoiler is true and the name already starts with SPOILER_ ? I believe this should also be checked for if spoiler is false
Also spoiler should probably be true by default like other setX methods

ImRodry

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ImRodry

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

Oh and why is this being fixed again? You should probably rebase xD

[heavy crow]

GkqqNkKC

[discordjs/discord.js] Issue opened: #6512 Channels glitching when deleted

After deleting a channel using the bot, the desktop client (windows) still shows the channel in the side panel, but the channel was deleted, so it can't be accessed

Refreshing the client gets rid of the problem. I thought it was a problem on the client's side, but now that it passed years and the problem is still there, it signals me that there's something else

Recently I encountered this problem for voice channels, though probably it happens to text ones too. I have to mention that I c...

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6511 fix\(UserUpdateAction\): rely on client\.user when ids match

iShibi

[discordjs/discord.js] New comment on pull request #6511: fix\(UserUpdateAction\): rely on client\.user when ids match

What if the UserUpdate gets triggered by a non-client user who isn't cached? The newUser will be undefined in that case too and the same error will occur. I think you should use the getUser method here.

SpaceEEC

[discordjs/discord.js] New comment on issue #6507: TextChannel Webhooks methods don't resolve

I can't reproduce this one 70cc0295f833cd988ea627b37d20536f73e21630, both promises resolve fine for me.
The commit you specified doesn't exist on our repo (seems to be a commit from #6482).

You could try logging the debug event, maybe you are rate limited:
client.on("debug", console.log); and client.on("rateLimit", console.log);

ImRodry

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ImRodry

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

String.prototype.replace does not change the original string, so this is needed

    if (spoiler === false && this.name.startsWith('SPOILER_')) {
        this.name = this.name.replace('SPOILER_', '');
    }

J-Human

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

J-Human

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

Yep, seems like I forgot about that, since commits ago.

J-Human

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

J-Human

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

Wait, couldn't it just be if (spoiler === false && this.name.startsWith('SPOILER_')) this.name = this.name.replace('SPOILER_', '');? I recall @ ckohen suggesting to disregard the if/else chain, so...

iShibi

[discordjs/discord.js] New comment on pull request #6511: fix\(UserUpdateAction\): rely on client\.user when ids match

There is a chance that getUser will too return undefined if the client didn't opt for USER partial. The GuildMemberUpdate action handler does it the right way.

ImRodry

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

What are you suggesting? I just moved it to a new like because otherwise ESLint would complain

ImRodry

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

SpaceEEC

[discordjs/discord.js] New comment on issue #6512: Channels glitching when deleted

This reads very much like a client bug: The channel is actually gone and the client still shows it until reloading it.

You can report those in the Discord Testers Discord Server (I don't know if they are open again), or though the Bug form.
If it's an api bug, you can report it here: [discord/discord-api-docs#api-bug-report](https://github.com/discord/discord-api-docs/issues/new?assignees=&labels=bug&template=api-bug-report...

SpaceEEC

[discordjs/discord.js] Issue closed: #6512 Channels glitching when deleted

ImRodry

[discordjs/discord.js] New comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

I suggested the brackets exactly because of that. You should install eslint locally so that it tells you about these errors before pushing.

J-Human

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

J-Human

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

Woops

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

I think this one should be updated too then:
https://github.com/discordjs/discord.js/blob/b43a441d4b3881f55a8c39a6773a7d3399a06dc1/src/structures/interfaces/InteractionResponses.js#L34

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6501 feat\(Threads\): add support for invitable in private threads

SpaceEEC

[discordjs/discord.js] New review comment on pull request #6501: feat\(Threads\): add support for invitable in private threads

I didn't test this, but wouldn't never be more appropriate here?

  invitable?: AllowedThreadType extends 'GUILD_PRIVATE_THREAD' | 12 ? boolean : never;

ImRodry

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

Imo you only need 1 return at the end, the others are redundant. Otherwise LGTM

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6502 docs\(GuildChannelCreateOptions\): fix \#type type

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6499 docs\(Formatters\): fix typo of TimestampStyles

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6476 types: Allow message component interaction collectors to infer collected interaction types

LGTM, just one question

vladfrangu

[discordjs/discord.js] New review comment on pull request #6476: types: Allow message component interaction collectors to infer collected interaction types

Doesn't this throw an error / shouldn't it throw a type error?

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6496 feat\(Invite\): support friend invites

vladfrangu

[discordjs/discord.js] New review comment on pull request #6496: feat\(Invite\): support friend invites

If we want to move forward with feature flags, we should probably group them under one object. Thoughts @discordjs/the-big-3?

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6117 feat\(User\): banners and accent colors

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6497 types\(CommandInteractionOptionResolver\): add missing parameter

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6497 types\(CommandInteractionOptionResolver\): add missing parameter

SpaceEEC

[discordjs/discord.js] Issue closed: #6480 Threads with discord\.js

ImRodry

[discordjs/discord.js] Pull request review submitted: #6117 feat\(User\): banners and accent colors

ImRodry

[discordjs/discord.js] New review comment on pull request #6117: feat\(User\): banners and accent colors

To make this compatible with ColorResolvable

  public readonly hexAccentColor: HexColorString | null;

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6455 feat\(Guild\): Add \`Guild\#maximumBitrate\` getter\.

vladfrangu

[discordjs/discord.js] New review comment on pull request #6455: feat\(Guild\): Add \`Guild\#maximumBitrate\` getter\.

    }

    switch (PremiumTiers[this.premiumTier]) {

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6455 feat\(Guild\): Add \`Guild\#maximumBitrate\` getter\.

vladfrangu

[discordjs/discord.js] Pull request review submitted: #6425 feat\(MessageTypes\): add CONTEXT\_MENU\_COMMAND \(23\)

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6490 feat: set methods for MessageActionRow and MessageSelectMenu

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6490 feat: set methods for MessageActionRow and MessageSelectMenu

This is actually missing the validation the add___ methods have 😅

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6478 feat: export BaseCommandInteraction

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6485 docs\(ThreadManager\): Fix typo

ImRodry

[discordjs/discord.js] New comment on pull request #6490: feat: set methods for MessageActionRow and MessageSelectMenu

This is actually missing the validation the add___ methods have 😅

No it’s not because the splice methods do that. That was something I included in the embed PR and was asked to change

Megatank58

[discordjs/discord.js] New comment on pull request #6504: docs: fix wrong type being displayed in docs

I think this one should be updated too then:
https://github.com/discordjs/discord.js/blob/b43a441d4b3881f55a8c39a6773a7d3399a06dc1/src/structures/interfaces/InteractionResponses.js#L34

Right I'll do that

Keke27210

[discordjs/discord.js] New comment on pull request #6511: fix\(UserUpdateAction\): rely on client\.user when ids match

There is a chance that getUser will too return undefined if the client didn't opt for USER partial. The GuildMemberUpdate action handler does it the right way.

Discord's USER_UPDATE is only emitted for client user's changes. Changes for other users have to go through the GUILD_MEMBER_UPDATE event, where the UserUpdate action is not being calle...

[heavy crow]

suneettipirneni

[discordjs/discord.js] New review comment on pull request #6476: types: Allow message component interaction collectors to infer collected interaction types

So interactionType is an allowed option currently for InteractionCollectorOptions which it seems that createMesaageComponent() uses, IIRC thats how it was setup before this PR.

But I do see your point, this may be a mistake, since interaction type doesn't have anything to do with component interactions.

suneettipirneni

[discordjs/discord.js] Pull request review submitted: #6476 types: Allow message component interaction collectors to infer collected interaction types

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6484 feat\(Message\): Add method to resolve a component by id

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6490 feat: set methods for MessageActionRow and MessageSelectMenu

Whoops the second then.
I must have mistaken that for a plain splice. 😓

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6455 feat\(Guild\): Add \`Guild\#maximumBitrate\` getter\.

ImRodry

[discordjs/discord.js] New comment on pull request #6490: feat: set methods for MessageActionRow and MessageSelectMenu

All good!

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6496 feat\(Invite\): support friend invites

SpaceEEC

[discordjs/discord.js] New review comment on pull request #6496: feat\(Invite\): support friend invites

If we are going that way, grouping them would in my opinion be the best way to go about this.

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6414 feat\(ApplicationCommand\): add \#equals

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6468 feat\(Message\): Prevent fetching an interaction webhook\.

iCrawl

[discordjs/discord.js] Pull request closed: #6468 feat\(Message\): prevent fetching an interaction webhook\.

iCrawl

[discord.js:main] 1 new commit

f39b597 feat(Message): prevent fetching an interaction ... - fasterplayer

github-actions[bot]

[discord.js:docs] 1 new commit

d1a96b2 Docs build for branch main: f39b597e3120701287e... - iCrawl

iCrawl

[discordjs/discord.js] Pull request closed: #6455 feat\(Guild\): Add \`Guild\#maximumBitrate\` getter\.

iCrawl

[discord.js:main] 1 new commit

21983de feat(Guild): Add Guild#maximumBitrate getter.... - fasterplayer

iCrawl

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

github-actions[bot]

[discord.js:docs] 1 new commit

c41f7e4 Docs build for branch main: 21983de3e00b6ae72bb... - iCrawl

iCrawl

[discordjs/discord.js] Pull request review submitted: #6484 feat\(Message\): Add method to resolve a component by id

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6453 fix\(BaseClient\): produce an error for non object options

iCrawl

[discordjs/discord.js] Pull request review submitted: #6485 docs\(ThreadManager\): Fix typo

iCrawl

[discordjs/discord.js] Pull request closed: #6478 feat: export BaseCommandInteraction

iCrawl

[discord.js:main] 1 new commit

c14e594 feat: export BaseCommandInteraction (#6478) - wakfi

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6452 types: require component type in raw object formats

Jiralite

[discordjs/discord.js] Issue opened: #6513 Possibility of same old & new structure for \`\#threadMembersUpdate\`

Please describe the problem you are having in as much detail as possible:
.threadMembersUpdate has the possibility of emitting the same Collection for both the oldMembers & newMembers parameters.

This is achieved by the following:

1. Join a thread
2. Restart your bot to ensure reproducibility. Do not fetch active threads!
3. Leave the thread

Upon leaving the thread, oldMembers and newMembers will emit the same Collection. Needless to say, this is quite......

iCrawl

[discordjs/discord.js] Pull request review submitted: #6497 types\(CommandInteractionOptionResolver\): add missing parameter

iCrawl

[discordjs/discord.js] Pull request closed: #6497 typings\(CommandInteractionOptionResolver\): add missing parameter

iCrawl

[discord.js:main] 1 new commit

656b518 typings(CommandInteractionOptionResolver): add ... - Drylozu

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6324 refactor\(MessageCreate\): remove message event

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6326 refactor\(InteractionCreate\): remove interaction event

iCrawl

[discordjs/discord.js] Pull request review submitted: #6499 docs\(Formatters\): fix typo of TimestampStyles

github-actions[bot]

[discord.js:docs] 1 new commit

1beeddd Docs build for branch main: c14e594d8a905d5559a... - iCrawl

github-actions[bot]

[discord.js:docs] 1 new commit

ae85c36 Docs build for branch main: 656b51875f82a82a442... - iCrawl

iCrawl

[discordjs/discord.js] Pull request review submitted: #6502 docs\(GuildChannelCreateOptions\): fix \#type type

iCrawl

[discordjs/discord.js] Pull request closed: #6452 typings: require component type in raw object formats

iCrawl

[discord.js:main] 1 new commit

c232baa typings: require component type in raw object f... - monbrey

github-actions[bot]

[discord.js:docs] 1 new commit

9361a42 Docs build for branch main: c232baa7154a4f07904... - iCrawl

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6419 feat\(GuildChannel\): Add \`GuildChannel\#private\` getter

SpaceEEC

[discordjs/discord.js] New review comment on pull request #6419: feat\(GuildChannel\): Add \`GuildChannel\#private\` getter

This seems quite redundant to me.

   * @type {boolean}

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6410 feat\(TypeGuards\): add \`TypeGuards\` utility for commonly used data types

SpaceEEC

[discordjs/discord.js] New review comment on pull request #6410: feat\(TypeGuards\): add \`TypeGuards\` utility for commonly used data types

This should throw a discord.js type error:
https://github.com/discordjs/discord.js/blob/c232baa7154a4f07904ad5b0b8557ebb452bfb66/src/errors/DJSError.js#L59

You can probably use INVALID_TYPE here:
https://github.com/discordjs/discord.js/blob/c232baa7154a4f07904ad5b0b8557ebb452bfb66/src/errors/Messages.js#L97

SpaceEEC

[discordjs/discord.js] New review comment on pull request #6410: feat\(TypeGuards\): add \`TypeGuards\` utility for commonly used data types

Same here:

   * Throws a type error if the object has no `type field`.
   * @param {Object} object The object to type check.
   * @private

SpaceEEC

[discordjs/discord.js] New review comment on pull request #6410: feat\(TypeGuards\): add \`TypeGuards\` utility for commonly used data types

We aren't super consistent with this, but I think putting private below returns is how we do it in most cases:

   * @param {string|number} type The type to resolve
   * @param {Object} object The enum to resolve to
   * @param {string[]} fields The enum fields to check
   * @returns {boolean} Whether the type is part of the enum
   * @private

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6394 types\(Enums\): mark enums as const enums

I don't really see the point, but if everything works. 🤷

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6492 refactor\(Client\): remove applicationCommand events

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6327 refactor\(Client\): remove message sweeping options

[heavy crow]

Jiralite

[discordjs/discord.js] New comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

This is a bit strange now. If a user runs .setSpoiler(), the attachment will be marked as a spoiler that is yet to be sent. If they decide to run the .spoiler getter to see if it's been marked as a spoiler, it'll throw an error because it's expecting a URL. Right now it's valid only for received messages... maybe it should be adjusted for to-be messages also?

Favna

[discordjs/discord.js] Pull request opened: #6514 types\(MessageEmbed\): allow \`null\` for \`setTimestamp\`

Please describe the changes this PR makes and why it should be merged:

This one is for @almostSouji. Can't post a screenshot of prof chat but y'all can find it there.

Status and versioning classification:

• Code changes have been tested against the Discord API (by Souji, as far as I can tell), or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[heavy crow]

NotSugden

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

NotSugden

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

i would personally go for this approach

const isSpoiler = this.name.startsWith("SPOILER_");
if (spoiler != isSpoiler) {
  if (spoiler) {
    this.name = `SPOILER_${this.name}`;
  } else {
    this.name = this.name.slice(8);
    // or
    this.name = this.name.replace(/^SPOILER_/, '');
  }
}
return this;

or at the least putting the this.name.startsWith(...); in a variable instead of calling it twice, and using an else if statement below

[heavy crow]

ImRodry

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

I agree and slice may actually be better

ImRodry

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ImRodry

[discordjs/discord.js] New comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

This is a bit strange now. If a user runs .setSpoiler(), the attachment will be marked as a spoiler that is yet to be sent. If they decide to run the .spoiler getter to see if it's been marked as a spoiler, it'll throw an error because it's expecting a URL. Right now it's valid only for received messages... maybe it should be adjusted for to-be messages also?

Tbh it should’ve been like that from the beginning, and it’s as simple as adding ?? this.name inside the Util.basename call

NotSugden

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

    const id = this.resolveId(options.guildEvent ?? options);

this would probably make more sense

NotSugden

[discordjs/discord.js] Pull request review submitted: #6493 feat: add support for GuildEvent

NotSugden

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

this would throw on 0, granted 0 is not a valid privacy level but the error would seem to indicate that neither a string or a number was passed

ImRodry

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

You’d need to add nullish coalescing then because options might be a snowflake

ImRodry

[discordjs/discord.js] Pull request review submitted: #6493 feat: add support for GuildEvent

NotSugden

[discordjs/discord.js] Pull request review submitted: #6414 feat\(ApplicationCommand\): add \#equals

NotSugden

[discordjs/discord.js] New review comment on pull request #6414: feat\(ApplicationCommand\): add \#equals

the same here as the above

NotSugden

[discordjs/discord.js] New review comment on pull request #6414: feat\(ApplicationCommand\): add \#equals

would the indexes be the same for both arrays?

could do

return existing.every((option, idx) => this._optionEquals(option, options[idx]));

in any case an every call would probably be what i'd use here

ImRodry

[discordjs/discord.js] Pull request review submitted: #6414 feat\(ApplicationCommand\): add \#equals

ImRodry

[discordjs/discord.js] New review comment on pull request #6414: feat\(ApplicationCommand\): add \#equals

The order in which you send options does actually matter so two commands should not be considered equal if they have the same options in a different order

NotSugden

[discordjs/discord.js] Pull request review submitted: #6493 feat: add support for GuildEvent

NotSugden

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

a snowflake isn't null/undefined

ImRodry

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

Ah nvm I thought that would throw an error but I just confused it for sth else

ImRodry

[discordjs/discord.js] Pull request review submitted: #6493 feat: add support for GuildEvent

[heavy crow]

kyranet

[discordjs/discord.js] New review comment on pull request #6410: feat\(TypeGuards\): add \`TypeGuards\` utility for commonly used data types

private static must be should after public static, same for the JS methods.

kyranet

[discordjs/discord.js] Pull request review submitted: #6410 feat\(TypeGuards\): add \`TypeGuards\` utility for commonly used data types

SpaceEEC

[discordjs/discord.js] Pull request review submitted: #6514 types\(MessageEmbed\): allow \`null\` for \`setTimestamp\`

kyranet

[discordjs/discord.js] Pull request review submitted: #6419 feat\(GuildChannel\): Add \`GuildChannel\#private\` getter

kyranet

[discordjs/discord.js] New review comment on pull request #6419: feat\(GuildChannel\): Add \`GuildChannel\#private\` getter

I'd argue that this suggestion's code feels hacky, and does the same steps.

• If Snowflake -> Get ?Role -> permissionsFor(Role?)
• Get Role -> If Role -> permissionsFor(Role)

Only difference is that permissionsFor(Snowflake)'s return type is nullable (because the case of invalid role IDs) whereas permissionsFor(Role) is not, so in the event when we rewrite to TypeScript, this would be one nullish assertion operator less.

Also, in the event Discord ever changes the `...

kyranet

[discordjs/discord.js] Pull request review submitted: #6419 feat\(GuildChannel\): Add \`GuildChannel\#private\` getter

kyranet

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

kyranet

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

We could also maake an isSpoiler getter, and flatten indentation a bit:

if (spoiler === this.isSpoiler) return this;

this.name = spoiler
  ? `SPOILER_${this.name}`
  : this.name.slice('SPOILER_'.length);

return this;

kyranet

[discordjs/discord.js] Pull request review submitted: #6514 types\(MessageEmbed\): allow \`null\` for \`setTimestamp\`

kyranet

[discordjs/discord.js] Pull request review submitted: #6488 feat\(ThreadChannel\): add fetchStarterMessage

kyranet

[discordjs/discord.js] Pull request review submitted: #6492 refactor\(Client\): remove applicationCommand events

ImRodry

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ImRodry

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

But this.spoiler already exists ?

kyranet

[discordjs/discord.js] Pull request review submitted: #6502 docs\(GuildChannelCreateOptions\): fix \#type type

kyranet

[discordjs/discord.js] Pull request review submitted: #6499 docs\(Formatters\): fix typo of TimestampStyles

kyranet

[discordjs/discord.js] Pull request review submitted: #6485 docs\(ThreadManager\): Fix typo

kyranet

[discordjs/discord.js] Pull request review submitted: #6511 fix\(UserUpdateAction\): rely on client\.user when ids match

kyranet

[discordjs/discord.js] Pull request review submitted: #6484 feat\(Message\): Add method to resolve a component by id

kyranet

[discordjs/discord.js] Pull request review submitted: #6504 docs: fix wrong type being displayed in docs

NotSugden

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

NotSugden

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

yeah, i put the simple isSpoiler in the suggested code because of the problem mentioned before of it requiring a URL, if thats fixed then the getter could be used instead

ImRodry

[discordjs/discord.js] Pull request review submitted: #6509 feat\(MessageAttachment\): allow files to be marked as spoilers

ImRodry

[discordjs/discord.js] New review comment on pull request #6509: feat\(MessageAttachment\): allow files to be marked as spoilers

Yeah fixing the getter would be the best approach like I suggested below this

kyranet

[discordjs/discord.js] Pull request review submitted: #6410 feat\(TypeGuards\): add \`TypeGuards\` utility for commonly used data types

kyranet

[discordjs/discord.js] Pull request review submitted: #6490 feat: set methods for MessageActionRow and MessageSelectMenu

[heavy crow]

iShibi

[discordjs/discord.js] Pull request review submitted: #6493 feat: add support for GuildEvent

iShibi

[discordjs/discord.js] New review comment on pull request #6493: feat: add support for GuildEvent

Not sure why I chose to validate privacyLevel here. The lib leaves the validation of these types of required values for the api. Changed it in f1e6d8e

kyranet

[discordjs/discord.js] Pull request review submitted: #6476 types: Allow message component interaction collectors to infer collected interaction types

Those are some very complex types, but as long as tests pass, LGTM

[heavy crow]

Default-01

[discord.js] New discussion #6515: Bring back the message string arrays for messages and embeds\.

In Discord.js V12 it was possible to set an array of strings in an embed description or a message, this was very handy to keep the code clean instead of 1 crazy long string with \n to break.

Here is an example of the string array:

name: `——————[ Settings ]——————`,
value: [
        `${data.antiinvite ? '' : ''} | AntiInvite`,
        `${data.antistaffping ? '' : ''} | AntiStaffPing`,
        `${data.antispam.enabled ? '' : ''} | AntiSpam`,
        `${data.antiswear.enabled ? ...

Jiralite

[discordjs/discord.js] New comment on discussion #6515: Bring back the message string arrays for messages and embeds\.

Why can't you just do this?

[
  `${data.antiinvite ? '![On](https://cdn.discordapp.com/emojis/838758070632054814.webp?size=128 "On")' : '![Off](https://cdn.discordapp.com/emojis/838758070615146526.webp?size=128 "Off")'} | AntiInvite`,
  `${data.antistaffping ? '![On](https://cdn.discordapp.com/emojis/838758070632054814.webp?size=128 "On")' : '![Off](https://cdn.discordapp.com/emojis/838758070615146526.webp?size=128 "Off")'} | AntiStaffPing`,
  `${data.antispam.enabled ? '![On](https://cdn.discordapp.com/emojis/838758070632054814.webp?size=128 "On")' : '![Off](https://cdn.discordapp.com/emojis/838758070615146526.webp?size=128 "Off")'} | AntiSpam`,
  `${data.antiswear.enabled ? '![On](https://cdn.discordapp.com/emojis/838758070632054814.webp?size=128 "On")' : '![Off](https://cdn.discordapp.com/emojis/838758070615146526.webp?size=128 "Off")'} | AntiSwearing`,
  `${data.levelsystem ? '![On](https://cdn.discordapp.com/emojis/838758070632054814.webp?size=128 "On")...

[heavy crow]

ckohen

[discordjs/discord.js] Pull request review submitted: #6414 feat\(ApplicationCommand\): add \#equals

ckohen

[discordjs/discord.js] New review comment on pull request #6414: feat\(ApplicationCommand\): add \#equals

IIRC, discord sometimes reorders things, and reordered options / choices do not actually get taken into account.
I used for...of for two reasons

1. return directly from the loop (its one less op too!)
2. make it clear that the loop stops as soon as it hits a non-equal option
   Bonus 3. If for some reason any of the functions need to be async in the future, we don't need to rewrite the loop

ImRodry

[discordjs/discord.js] Pull request review submitted: #6414 feat\(ApplicationCommand\): add \#equals

ImRodry

[discordjs/discord.js] New review comment on pull request #6414: feat\(ApplicationCommand\): add \#equals

Discord does take order into account and deploys options in the exact order you provide them, so this change is important

[heavy crow]

ckohen

[discordjs/discord.js] Pull request review submitted: #6414 feat\(ApplicationCommand\): add \#equals

ckohen

[discordjs/discord.js] New review comment on pull request #6414: feat\(ApplicationCommand\): add \#equals

Hmm, it does take it into account, but not everything is deployed in the order provided (client side that is, API still has the correct order) E.g. subcommand groups are always displayed before subcommands on the same level.

Its hard to say which behavior would be more confusing given that. I imagine most people store the command definition somewhere in their code, but if you were to reconstruct a command from the way the client displayed it (again, you could just fetch it to be sure ...

ImRodry

[discordjs/discord.js] Pull request review submitted: #6414 feat\(ApplicationCommand\): add \#equals