Learning Top Down Mechanics, Attempting to Add Bow and Arrow: | Godot Café | Page 1

dusty carbon Dec 18, 2023, 1:54 AM

#

And yeah it's not working.

I'm wanting to be able to shoot via mouse, so I tried to set it up based on that.
The player is 8 directional with animations, and uses a prefix/suffix setup to determine animations
I also elected to separate movement and attack into separate functions that are called on in the physics_process.
Movement works just fine, but when I try to click for attack, it will crash the game and give me this error:
"Invalid call: Nonexistent function 'instance' in base 'PackedScene'.

I'll drop the code in the comments, since it's too long to put here. if you need any more info please let me know.

#



var speed = 100
var last_nonzero_velocity = Vector2.ZERO
var bow_damage = 10
var arrow_speed = 200

func _physics_process(delta):
    handle_movement()
    if Input.is_action_just_pressed("attack"):
        handle_attack()

func handle_movement():
    # Get input
    velocity = Vector2.ZERO
    
    if Input.is_action_pressed("right"):
        velocity.x += 1
    if Input.is_action_pressed("left"):
        velocity.x -= 1
    if Input.is_action_pressed("down"):
        velocity.y += 1
    if Input.is_action_pressed("up"):
        velocity.y -= 1
    
    # Move the player
    velocity = velocity.normalized()
    velocity = velocity * speed
    move_and_slide()
    
    # store the last nonzero velocity
    if velocity != Vector2.ZERO:
        last_nonzero_velocity = velocity
    
    # Set the animation based on the velocity
    if velocity.x != 0 || velocity.y != 0:
        $AnimatedSprite2D.play("walk_" + get_animation_suffix(velocity))  # "walk_" is the animation prefix
    else:
        $AnimatedSprite2D.play("idle_" + get_animation_suffix(last_nonzero_velocity))  # "idle_" is the animation prefix

# Function to get the animation suffix based on the velocity
func get_animation_suffix(velocity):
    velocity = velocity.normalized()
    print(velocity.x)
    print(velocity.y)
    
    if velocity.x == 1:
        return "right"
    elif velocity.y == 1:
        return "down"
    elif velocity.x == -1:
        return "left"
    elif velocity.y == -1:
        return "up"
    
    # Diagonal velocity
    if velocity.x > 0:
        if velocity.y > 0:
            return "down_right"
        else:
            return "up_right"
    else:
        if velocity.y > 0:
            return "down_left"
        else:
            return "up_left"

#

    # Calculate the direction based on mouse position
    var mouse_position = get_global_mouse_position()
    var player_direction = (mouse_position - global_position).normalized()
    
    # Load the arrow scene
    var arrow_scene = preload("res://Instanced_Objects/arrow.tscn")
    assert(arrow_scene, "Error loading arrow scene")

    # Instance the arrow scene
    var arrow_instance = arrow_scene.instance() as Node  # Use the appropriate type

    # Set the arrow's position
    arrow_instance.global_position = global_position
    
    # Set arrow properties (direction, speed, damage, etc.)
    arrow_instance.direction = player_direction
    arrow_instance.damage = bow_damage
    arrow_instance.speed = arrow_speed
    
    # Add the arrow to the scene
    add_child(arrow_instance)

    # Determine the attack animation based on the mouse position
    var attack_animation_suffix = get_animation_suffix(player_direction)

    # Play the appropriate attack animation
    $AnimatedSprite2D.play("attack_" + attack_animation_suffix)

rigid cairn Dec 18, 2023, 2:23 AM

#

If Godot 4, you're looking for instantiate() rather than instance()

#

@dusty carbon

dusty carbon Dec 18, 2023, 2:38 AM

#

Alright so, that stopped it from crashing at least. I also added a script to the arrow which I will share. But I recorded a short video to show what it's doing now. Here's the arrow's script:



# Properties
var speed: float = 200
var direction: Vector2 = Vector2.ZERO
var damage: int = 10

func _process(delta):
    # Move the arrow
    move_and_slide()

func _on_area_2d_body_entered(body):
    # Check for collisions with other entities
    if body.has_method("take_damage"):
        body.take_damage(damage)
    queue_free()

#

I can sometimes see the arrow just exist for a split second then disappear

rigid cairn Dec 18, 2023, 2:49 AM

#

Does player have a take_damage() method? If so, the arrow could be colliding with the player and triggering this code

#

In that case you can change layers/masks around so that the Arrow body's mask does not match the player body's layer.

#

Actually it seems that queue_free() is called on any collision with a body, since it's outside the if statement

#

But yeah I recommend the mask/layer thing to fix it either way

dusty carbon Dec 18, 2023, 2:52 AM

#

okay oooone sec

#

Okay no dice. the video shows that the arrow appears towards the bottom right of the screen when I click (I circled my mouse in the area) not only that, it doesn't play the attack animation fully. just flashes it for a second.

#

Another issue I just ran into is when I put the queue_free() inside the if statement, well...heres the clip

rigid cairn Dec 18, 2023, 3:02 AM

#

Mind showing how you have the Arrow set up in its scene? (It might have been dragged away from the origin point of the scene)

dusty carbon Dec 18, 2023, 3:02 AM

#

yup

rigid cairn Dec 18, 2023, 3:02 AM

#

You will also want to add the arrow as child of the main scene node.

#

Seems like right now it's being added as child of your CharacterBody2D

#

(Which would probably give it another "push" since it begins to inherit your player's position)

dusty carbon Dec 18, 2023, 3:04 AM

#

Okay...so am I to take the handle_attack() function and move it over to a script on the world?

rigid cairn Dec 18, 2023, 3:05 AM

#

You could do get_parent().add_child(arrow_instance)
or get_tree().current_scene.add_child(arrow_instance)

rigid cairn Dec 18, 2023, 3:05 AM

#

dusty carbon Okay...so am I to take the handle_attack() function and move it over to a script...

Valid approach but probably not necessary.

#

Let me know if it keeps disappearing. Seems like a separate issue.

dusty carbon Dec 18, 2023, 3:06 AM

#

Would I put that lil snippet of code you suggested here?

rigid cairn Dec 18, 2023, 3:06 AM

#

Bit lower

#

dusty carbon Dec 18, 2023, 3:07 AM

#

PFFFFT

#

WELL I GOT A RESULT XD

#

hold on one sec lemme get a clip

rigid cairn Dec 18, 2023, 3:07 AM

#

oh lord

dusty carbon Dec 18, 2023, 3:08 AM

#

rigid cairn Dec 18, 2023, 3:08 AM

#

woah lmao

dusty carbon Dec 18, 2023, 3:08 AM

#

yup XD

rigid cairn Dec 18, 2023, 3:09 AM

#

Well seems to be spawning at the player now at least

#

and not disappearing

dusty carbon Dec 18, 2023, 3:09 AM

#

yeah it'll only disappear instantly if it's queue_free is not in the if statement

rigid cairn Dec 18, 2023, 3:10 AM

#

Anyway you could try:

#

Well

#

Do you want character to be able to push arrows around / be pushed by arrows?

dusty carbon Dec 18, 2023, 3:11 AM

#

Not particularly. I was wanting the collider to only determine whether the arrow hits something. not make it so it can be moved.

#

I also need to figure out how to make it rotate towards the mouse on shot and figure out why the player animation is only lasting half a second

rigid cairn Dec 18, 2023, 3:12 AM

#

dusty carbon Not particularly. I was wanting the collider to only determine whether the arrow...

Ok cool in that case you can just set the collision mask of the Arrow's body to none (or something that isn't the player's layer)
Area2D is what you'll use for detecting a hit target

rigid cairn Dec 18, 2023, 3:13 AM

#

dusty carbon I also need to figure out how to make it rotate towards the mouse on shot and fi...

Can use look_at() for that. arrow_instance.look_at(get_global_mouse_position()), before or after you add_child()

#

Player animation... make sure it's set to loop.

dusty carbon Dec 18, 2023, 3:14 AM

#

these are where the collision mask is right? cause the arrow is set to 2, player set to 1

rigid cairn Dec 18, 2023, 3:14 AM

#

Mm those are the light and visiblity masks, not collision - look a bit further up

#

Make sure the body is selected

dusty carbon Dec 18, 2023, 3:15 AM

#

ah silly me

#

also, setting the attack animations to loop did just about nothing

#

it still just plays for one frame

rigid cairn Dec 18, 2023, 3:16 AM

#

But yeah layer is where the object exists
Mask is which layers it detects

rigid cairn Dec 18, 2023, 3:17 AM

#

dusty carbon it still just plays for one frame

Hmm. I think this:

#

Is constantly running

#

And overwrites this

dusty carbon Dec 18, 2023, 3:19 AM

#

So two things then:
how do I stop idle from playing constantly only until the attack animation is done
and the arrow, while facing the mouse and not sending me flying anymore, is staying nice and still

rigid cairn Dec 18, 2023, 3:19 AM

#

Could try

elif !$AnimatedSprite2D.is_playing():

#

just before you set it to idle

#

Or maybe wrap the whole thing in that

if !$AnimatedSprite2D.is_playing():
  if velocity.x != 0 || velocity.y != 0:
    ...
  else:
    ...

rigid cairn Dec 18, 2023, 3:22 AM

#

dusty carbon So two things then: how do I stop idle from playing constantly only until the at...

I don't see where you set the arrow's velocity in your code. Only its direction.

dusty carbon Dec 18, 2023, 3:22 AM

#

Alrighty that makes the animation play through! Now it just stops on the last frame of attack until I move

dusty carbon Dec 18, 2023, 3:22 AM

#

rigid cairn I don't see where you set the arrow's `velocity` in your code. Only its `directi...

I...totally never did that XD

rigid cairn Dec 18, 2023, 3:23 AM

#

gdyipee

rigid cairn Dec 18, 2023, 3:25 AM

#

dusty carbon Alrighty that makes the animation play through! Now it just stops on the last fr...

Hmm, show code where you set it to idle?

dusty carbon Dec 18, 2023, 3:26 AM

#

    if !$AnimatedSprite2D.is_playing():
        if velocity.x != 0 || velocity.y != 0:
            $AnimatedSprite2D.play("walk_" + get_animation_suffix(velocity))  # "walk_" is the animation prefix
        else:
            $AnimatedSprite2D.play("idle_" + get_animation_suffix(last_nonzero_velocity))  # "idle_" is the animation prefix```

rigid cairn Dec 18, 2023, 3:26 AM

#

Odd, it should be setting to idle as soon as you're sitting still and no animations are currently playing.

dusty carbon Dec 18, 2023, 3:26 AM

#

weird aint it?

#

On a side note, i got the arrow moving

#

just replaced move and slide with that

rigid cairn Dec 18, 2023, 3:27 AM

#

If you want to preserve collisions (make the arrow bounce off walls maybe) you'll need to keep using move_and_slide() - just set the built-in velocity to the direction in _ready()

#

Otherwise you can use position its no big deal

dusty carbon Dec 18, 2023, 3:28 AM

#

oh I don't want it bouncing. just disappearing on collision

#

oop two new problems XD

rigid cairn Dec 18, 2023, 3:29 AM

#

gddeadinside

dusty carbon Dec 18, 2023, 3:29 AM

#

ikr

#

righty-o so, i shoot, and the arrow, despite me increasing the speed, moves at a snails pace, and also now the animation, once finished, stays there. and only changes when I shoot in a different direction

#

this is just...vexing

rigid cairn Dec 18, 2023, 3:31 AM

#

You are multiplying by delta which is a value that is very small. (0.01-0.10) You'll need to make speed much larger

#

100-1000

#

But yeah I am very confused as to why it's not changing to idle animation when you're 1. sitting still and 2. no animations are playing

dusty carbon Dec 18, 2023, 3:32 AM

#

no dice. I also just purged the delta multiplication and arrow goes at mach fuck, still cant change the speed tho XD

rigid cairn Dec 18, 2023, 3:36 AM

#

Last ditch effort before I go AFK

if !$AnimatedSprite2D.is_playing():
        if velocity.is_equal_approx(Vector2.ZERO):
            $AnimatedSprite2D.play("walk_" + get_animation_suffix(velocity))  # "walk_" is the animation prefix
        else:
            $AnimatedSprite2D.play("idle_" + get_animation_suffix(last_nonzero_velocity))  # "idle_" is the animation prefix

#

(the is_equal_approx() is the change I did)

#

Just in case your velocity is hanging out at just above or below zero, causing the else to never be ran

dusty carbon Dec 18, 2023, 3:39 AM

#

yup, nope. now even moving it stays on idle_down unless I shoot, in which case same as before it stays at the end of attack animation

rigid cairn Dec 18, 2023, 3:39 AM

#

foiled again

dusty carbon Dec 18, 2023, 3:39 AM

#

XD F homie, F

rigid cairn Dec 18, 2023, 3:39 AM

#

I'll be back soonish, if you still need help I can keep at it

#

best of luck

dusty carbon Dec 18, 2023, 3:39 AM

#

Aight go do you man

dusty carbon Dec 18, 2023, 4:19 AM

#

Here's what I tried before waiting for a savior:
I tried adding a ready function such as:

    $AnimatedSprite2D._on_animated_sprite_2d_animation_finished.connect("animation_finished")```

Then I changed up the handle_attack function as such:

```func handle_attack():
    # Calculate the direction based on mouse position
    var mouse_position = get_global_mouse_position()
    var player_direction = (mouse_position - global_position).normalized()
    
    # Load the arrow scene
    var arrow_scene = preload("res://Instanced_Objects/arrow.tscn")
    assert(arrow_scene, "Error loading arrow scene")

    # Instance the arrow scene
    var arrow_instance = arrow_scene.instantiate() as Node  # Use the appropriate type

    # Set the arrow's position
    arrow_instance.global_position = global_position
    
    # Set arrow properties (direction, speed, damage, etc.)
    arrow_instance.direction = player_direction
    arrow_instance.damage = bow_damage
    arrow_instance.speed = arrow_speed
    
    # Add the arrow to the scene
    get_tree().current_scene.add_child(arrow_instance)
    arrow_instance.look_at(get_global_mouse_position())

    # Determine the attack animation based on the mouse position
    var attack_animation_suffix = get_animation_suffix(player_direction)

    # Play the appropriate attack animation
    $AnimatedSprite2D.play("attack_" + attack_animation_suffix)
    
    if $AnimatedSprite2D.animation_finished("attack_"):
        attacking = false


func _on_animated_sprite_2d_animation_finished():
    pass # Replace with function body.

Tried that, now it crashes immediately saying:
"Invalid getindex '_on_animated_sprite_2d_animation_finished' (on base: 'AnimatedSprite2D')"

#

oh I also added a variable "attacking" and set it to false, changing to true when the attack button is pressed

dusty carbon Dec 18, 2023, 5:13 AM

#

FIGURED THE ARROW ISSUE OUT I'M DUMB

dusty carbon Dec 18, 2023, 5:46 AM

#

HAHAHA

#

Got a bud who knows python really well, he downloaded godot and figured it out for me

#

So this is what he did:

#Learning Top Down Mechanics, Attempting to Add Bow and Arrow: