Important:
This mechanic is pretty hard to test, so I'm sorry if some of these features are already implemented!
I like the idea a lot! Finding pots to then learn how to craft them is like a very fun and unique idea! However, I have a couple of suggestions that would make it a bit better.
- Right now the entries for corruption pots don't show up in crimson worlds and vice versa. I don't think that's a good idea. Not being able to craft corruption pots in crimson worlds because you can't discover them there, yet you can get the resources in hardmode is annoying (same can be said about the lack of ability to look at their entries).
I think that it should work this way: destroying a pot from the evil biome should automatically unlock the entry of opposite evil biome pot and count as a discovery for both of them
That's how Bestiary works. Salamdaders, Giant Shellies and Crawdads can't all exist in one world at once. Only two of the can. That's why Bestiary unlocks the third entry when the other two ones are unlocked. What I'm trying to say is thaty solution will also make Bestiary and Potstiary more consistent.
Also, I don't think Zenith Pots should be uncraftable outside of the getfixedboi seed. Maybe their entries should unlock when all the other entries are unlocked (that would fit the "Zenith" name)? You would still only be able to naturally find them on the seed though. - I think there should be a system that makes sure that at least one of each pot registered in the Potstiary is going to be generated in the world (excluding the ones from the alternative evil biome and the zenith ones, of course). Since you need to find a pot to be able to craft it, it's important that are able to discover all of them.
This should also work for the pots from other mods that are registered if that's possible to do.