#Code Review Alert

3 messages · Page 1 of 1 (latest)

spring gale
#

https://wago.io/7dWkg6HmB
I uploaded that and got a code review alert. the code is variations of this on init action:

PlayerFrameHealthBarText.Show = function() end```
and the alert is `setting read-only field 'Show' of global 'PlayerFrameHealthBarText' (W122)`

my intention is to hide the default Blizzard status text and then break its show function so it doesn't show up again, which i guess the automated code review is cranky about. is this something i should ignore or is there a cleaner way of permanently hiding it?

people might wonder "why not disable blizzard status text through interface options?" - this doesn't completely get rid of it as it still shows up when you have character frame open or mouseover on health/mana bar and i'd rather completely hide it.
spring gale
#

Code Review Alert

heavy garnet
#

Sounds like what you're doing is not intended so getting error messages seems reasonable.
If you're getting the result that you're after then you can safely ignore those code review alerts