Title Inline rolls from text editor | Foundry VTT | Page 1

lunar nacelle May 5, 2022, 3:29 PM

#

I think I can module this

lunar nacelle May 5, 2022, 3:55 PM

#

Only really need to pass the flavor through Roll.replaceFormulaData as well, which _onClickInlineRoll does not do currently

#

though in this particular instance, the name of the actor would be the speaker on the chat message

twin stone May 5, 2022, 4:08 PM

#

That would be awesome! Let me know if I can help

lunar nacelle May 5, 2022, 4:15 PM

#

I already have it working. I am just trying to imagine a use case other than what you mentioned

#

which I already mentioned is slightly pointless because the speaker on the message is set to actor.name already

twin stone May 5, 2022, 4:32 PM

#

So it titles it "Gamemaster" in the chat but I want it to use the name of the actor who's sheet it was on, in the same way that if the attack roll has "+ @bab" it pulls in it's stat for bab

#

Melee [[/r 1d20+5 #@actor.name makes a Halbred Attack]] halberd +5

#

apologies if I described anything incorrectly 🙂

lunar nacelle May 5, 2022, 4:38 PM

#

the click event does not know the app it comes from. It uses the selected token's information

twin stone May 5, 2022, 4:40 PM

#

[[/r 1d20+5 +@bab]] properly pulls in the actor's 4 bab, with no token selected

#

token isn't even spawned, doing this from the character sheet opened from the "Actors Directory"

lunar nacelle May 5, 2022, 4:41 PM

#

nevermind, you are right. let me fiddle with this for a sec

twin stone May 5, 2022, 4:41 PM

#

thanks! Appreciate the interest

lunar nacelle May 5, 2022, 4:41 PM

#

question, would you want item data in any case?

twin stone May 5, 2022, 4:42 PM

#

not that I can think of for my uses cases no

lunar nacelle May 5, 2022, 4:43 PM

#

I'll throw that in there anyway

#

twin stone May 5, 2022, 4:52 PM

#

that's awesome

lunar nacelle May 5, 2022, 4:57 PM

#

took it a step further with a bit that I had in there for someone else's request

twin stone May 5, 2022, 4:58 PM

#

looks solid

lunar nacelle May 5, 2022, 5:11 PM

#

ignore the name, try this

📎 inline-adv-dis-crit.zip

twin stone May 5, 2022, 5:15 PM

#

Sorry do I just unzip and toss that into \FoundryVTT\Data\modules ? Tried that and its not showing up for me. I've never installed a module manually before

lunar nacelle May 5, 2022, 5:16 PM

#

yeah, you have to return to the setup page and relaunch the world after you do that with a new module though

twin stone May 5, 2022, 5:17 PM

#

oh I found it. I think because I haven't updated foundry itself in a while

#

I was planning on updating though, so might as well do that now

lunar nacelle May 5, 2022, 5:18 PM

#

core version shouldnt matter, I just put in in version 9 from habit

twin stone May 5, 2022, 5:18 PM

#

oh okay, I;ll try updating that file then. I'm only on 0.8.9

lunar nacelle May 5, 2022, 5:19 PM

#

or just drop this in the module folder over the other one

📎 module.json

#

version 9 is pretty dope though

twin stone May 5, 2022, 5:22 PM

#

hmm it showed up, I enabled it, and I still got the same result. Maybe I do need to be on version 9?

lunar nacelle May 5, 2022, 5:23 PM

#

do you have libwrapper installed?

#

I didn't list it as a dependency, but it is necessary to overwrite the function

twin stone May 5, 2022, 5:23 PM

#

oh yeah, but not enabled. Will enable and try again

#

[Detected 2 packages: inline-adv-dis-crit, lib-wrapper]
    at HTMLAnchorElement.:gift:TextEditor._onClickInlineRoll#inline-adv-dis-crit (module.js:39)
    at B.:gift:call_wrapper [as call_wrapper] (libWrapper-wrapper.js:551)
    at HTMLAnchorElement.:gift:TextEditor._onClickInlineRoll#0 (libWrapper-wrapper.js:164)
    at HTMLBodyElement.dispatch (jquery.min.js:2)
    at HTMLBodyElement.v.handle (jquery.min.js:2)```

lunar nacelle May 5, 2022, 5:24 PM

#

what the heck

twin stone May 5, 2022, 5:25 PM

#

I'm happy to upgrade to version 9 if you want 😆

lunar nacelle May 5, 2022, 5:26 PM

#

I didn't think that was a v9 thing, but you can try it

twin stone May 5, 2022, 5:37 PM

#

updated lib wrapper as well, and one of those two updated fixed it!

cinder bolt May 5, 2022, 7:03 PM

#

BTW, supporting inline rolls in text editors in actor/item sheets is up to game systems/modules to do. Foundry doesn't enforce inline roll support on them.

Or rather, Foundry can't enforce the product of said thing will have inline rolls parsed. The editor itself needs to display them unprocessed.

lunar nacelle May 5, 2022, 7:20 PM

#

TextEditor is not enforced on character sheets as far as I know, but inline rolls are parsed by TextEditor by Foundy

cinder bolt May 5, 2022, 7:21 PM

#

Yes, though only if inline roll conversion is enabled with a parameter.

#Title Inline rolls from text editor