Prof_dresser macro assistance | Foundry VTT | Page 1

ruby cipher Nov 25, 2021, 3:58 PM

#

There may be an issue with the argument. If you can't read ._id it probably means that the argument isn't a valid target.

#

Log args[0] and check it's what you think it is.

normal quail Nov 25, 2021, 4:01 PM

#

Where would be the best place to put the "Log" command in the macro. I tried just slapping it in, but it didn't like it.

ruby cipher Nov 25, 2021, 4:11 PM

#

Er, it's console.log(args) in that context. I used log as a shortcut. 🙂

#

Are you actually feeding args to your macro call?

normal quail Nov 25, 2021, 4:26 PM

#

😛 Yeah, I remembered that while I was in the shower. Thanks.
No, I'm not feeding it any args.

ruby cipher Nov 25, 2021, 4:26 PM

#

That'll be your problem, as args implies arguments. 🙂

normal quail Nov 25, 2021, 4:28 PM

#

So it says that the caster is arg[0], which is what I wanted... hm... I'm checking something.

#

I have one other "_id":

    let castItem = tactor.data.items.find(i => i.name === "Dragon's Breath (attack)" && i.type === "weapon");
    if(castItem) await tactor.deleteOwnedItem(castItem._id)```
I wouldn't think that'd be it, because it's in the version where I'm not calling the spell DC and it doesn't throw any errors then...

ruby cipher Nov 25, 2021, 4:32 PM

#

What type of object is the caster, though? A token? An actor?

#

If it's an actor, args[0].actor is not valid.

normal quail Nov 25, 2021, 4:33 PM

#

Yeah, it is an actor.

ruby cipher Nov 25, 2021, 4:33 PM

#

There's your problem.

normal quail Nov 25, 2021, 4:33 PM

#

I was copying code from similar macros

ruby cipher Nov 25, 2021, 4:33 PM

#

You also don't need to get the actor if you already have the actor.

normal quail Nov 25, 2021, 4:34 PM

#

So, I could call on the 'tactor' instead?

ruby cipher Nov 25, 2021, 4:35 PM

#

No, I mean if args[0] is the actor, you don't need:
const actorD = game.actors.get(args[0].actor._id);

Because args[0] is already the actor.

#

The code there only works for real actors, too.

#

As synthetic actors (i.e. ones on tokens without 'link' checked) don't exist in the game's actor list.

normal quail Nov 25, 2021, 4:38 PM

#

I've only been targeting linked actors (thought that's good to know for the future).

#

Do you have any advice on how to pull the spellDC? That seems to be the real stumbling block.

ruby cipher Nov 25, 2021, 4:39 PM

#

I don't know anything about the structure of D&D5e, but it's probably a matter of finding the specific item representing the spell and doing something with its data.

#

Print the actor to the console to read its data structure. Items are stored in the actor.data.items structure, usually.

normal quail Nov 25, 2021, 4:42 PM

#

I'm trying to get the data off of the caster first and then apply it to the item.
actor.data.data.attributes.spelldc
actor.data.data.items.data.save.dc

ruby cipher Nov 25, 2021, 4:44 PM

#

Ahh, I see.

#

So where are you coming unstuck? What do you mean by 'pull the spell DC'?

#

You can just get it by referring to actor.data.data.attributes.spelldc I assume.

normal quail Nov 25, 2021, 4:45 PM

#

Sorry my terminology is not the best. Yes, I want to copy the caster's spellcasting DC onto the item because otherwise it tries to pull it from the actor who is receiving the item.

#

Essentially, I want to make actor.data.data.attributes.spelldc into a variable.

ruby cipher Nov 25, 2021, 4:46 PM

#

Yes.

#

Then apply that variable to the new item.

normal quail Nov 25, 2021, 4:46 PM

#

Exactly.

ruby cipher Nov 25, 2021, 4:47 PM

#

Okay, so, you should have what you need now!

normal quail Nov 25, 2021, 4:49 PM

#

?

#

Well, I have to get going. I'll hit my head against it some more tomorrow. Thank you very much for all your help. Even without this, the macro is really great.

#Prof_dresser macro assistance