Rigger Effect Macro Troubleshooting | Foundry VTT | Page 1

clever idol Oct 24, 2023, 5:44 PM

#

@native galleon @remote gale

#

This channel is the right place to discuss things when the subject is at the intersection of modules, macros, and the system itself. 🙂

native galleon Oct 24, 2023, 5:47 PM

#

So I've added the new effect to the vehicle, and on effect toggle (on), it's set to run the code copied from control-rig.js

remote gale Oct 24, 2023, 5:47 PM

#

under effects is it under inactive, or is it under persistent?

native galleon Oct 24, 2023, 5:47 PM

#

It starts as Inactive

clever idol Oct 24, 2023, 5:47 PM

#

What happens when you activate it?

native galleon Oct 24, 2023, 5:48 PM

#

It bumps up to "Persistent Effects"

clever idol Oct 24, 2023, 5:48 PM

#

But the code doesn't fire?

native galleon Oct 24, 2023, 5:48 PM

#

I see no indication that the code fires (e.g. the effect name doesn't change, skill ratings aren't added)

#

Ooh, I see a console error when I enable it: ReferenceError: key is not defined

remote gale Oct 24, 2023, 5:53 PM

#

can you send a screenshot of the error?

native galleon Oct 24, 2023, 5:53 PM

#

#

(all modules/systems updated as of this morning)

remote gale Oct 24, 2023, 5:56 PM

#

Did you remove any skills from the rigger?

native galleon Oct 24, 2023, 5:56 PM

#

I have not played with the skill list, no

remote gale Oct 24, 2023, 5:56 PM

#

like maybe any of the piloting or the gunnery skill?

clever idol Oct 24, 2023, 5:57 PM

#

There is a reason for that question.
whistles innocently and slips away into the shadows

native galleon Oct 24, 2023, 5:58 PM

#

I can confirm that the rigger possesses ranks in Pilot Ground Craft, Gunnery, and the like

remote gale Oct 24, 2023, 5:59 PM

#

it doesn't need ranks, the skill just has to be there. may do an edit to dynamically check for them so if one is missing it doesn't thrown an error.
But the error you got is on the check for the control rig

clever idol Oct 24, 2023, 5:59 PM

#

So... Do they have a Cyberwear item whose name starts with "Control Rig"?

native galleon Oct 24, 2023, 6:00 PM

#

They do

remote gale Oct 24, 2023, 6:01 PM

#

can you run the following in terminal for me and send the result
game.actors.getName("Test Rigger").items.getName("Control Rig (R1)")

Just replace Test Rigger with the name of the character in question

#

This is a V11 foundry instance correct?

native galleon Oct 24, 2023, 6:02 PM

#

Yep, returns just fine

#

Foundry 11.305, SR 0.14.1

remote gale Oct 24, 2023, 6:04 PM

#

can you expand the item and send it to me. or just copy it and send it as a code snippet in here?

native galleon Oct 24, 2023, 6:05 PM

#

Here's the item in question

📎 fvtt-Item-control-rig-r1-YG98qeBStiKaAXuj.json

remote gale Oct 24, 2023, 6:08 PM

#

I have found the error. use the one I just shared. I missed a change in the forEach Loop

📎 Control-Rig.js

native galleon Oct 24, 2023, 6:09 PM

#

Boom, macro fired successfully!

#

Thank you!

remote gale Oct 24, 2023, 6:10 PM

#

I changed from a standard for loop to a forEach loop and missed a line

#

I have pushed that fix into the repo as well. @clever idol, we should be good to close the thread

native galleon Oct 24, 2023, 6:11 PM

#

Thanks for the help @remote gale !

#Rigger Effect Macro Troubleshooting