#Duplicate Lore Lines Appearing

1 messages · Page 1 of 1 (latest)

cloud pine
#

After updating DeluxeMenus, I started using the new lore display option:
lore_append_mode: bottom.

However, I’ve encountered an issue where the lore lines are being displayed twice (duplicated), essentially showing two lines per entry.

Is there a known fix or workaround for this issue?

   material: mmoitems-MATERIAL:SLIME_01
   slots:
     - 10
   amount: 1
   lore:
     - ''
     - '&fpoints : %betonquest_CrystalQuest:point.pang.amount%'
     - '&f &a11points'
     - '&f → trade'
   lore_append_mode: bottom
   view_requirement:
     requirements:
       example_2:
         type: '>='
         input: '%betonquest_CrystalQuest:point.pang.amount%'
         output: '11'
   left_click_requirement:
     requirements:
       balance:
         type: '>='
         input: '%betonquest_CrystalQuest:point.pang.amount%'
         output: '11'
   left_click_commands:
     - "[message] &6아이템 교환이 완료되었습니다!"
     - '[close]'```
olive eagle
#

isn't it just that both your MMOItems' item lore and your item lore in DeluxeMenus are the same?

cloud pine
#

This is the state before purchasing the item through DeluxeMenus.
After the purchase, as shown in the image above, the item displays two duplicated lines of lore.

olive eagle
#

so it's after reopening the menu?

#

what if you reopen it again?

cloud pine
olive eagle
#

does it duplicate itself more and more each time you open the menu?

#

or only once?

cloud pine
#

It only duplicates once.

charred pelican
#

I've had another report of this before but I wasn't able to replicate it other item hooks. Might be an issue with our MmoItems hook

olive eagle
#

@charred pelicanpretty sure I found the issue

#

this is the refresh task in the MenuHolder class, it only gets the config's lore

#

your append logic is only when opening the menu

#

though that means it should overwrite the previous lore, and not duplicate it

#

so I'm kinda confused still

charred pelican
#

I couldn't replicate it with other plugins such as sgi

#

(I think that is what its called)

olive eagle
#

🤷

#

I'll try it later, I've fixed what I found and will PR it with the MiniMessage stuff

#

I think I'm almost done

#

oh, I am actually, I'll test it later and then open a PR

charred pelican
olive eagle
#

haven't tested yet

#

still at school

charred pelican
#

Hi. I wasn't able to actually replicate this issue with MMO Items. Do you experience this issue right now?

jade harness
#

it happend when you close and open again and, also, if i set a click action with [refresh]

charred pelican
#

Can you please execute /papi dump and send the generated link here, and also execute /dm dump <menu-name> (with a menu that this happens with) and send that link as well.

charred pelican
#

I don't have MMOItems but I think I found the issue.

jade harness
charred pelican
#

Let me see what else changed since then. I think you were 3 or 4 builds behind.

#

BTW, have you restarted the server or used reload?

jade harness
#

always restart

charred pelican
#

What commands btw? From menus? Or actual /dm commands?

jade harness
#

with /dm open every menu work

with the specific menu command, it dosent

charred pelican
#

Can you send the startup logs please?

round rockBOT
#
FAQ Answer:

Startup Log Location
Your latest startup log can be found in the logs folder of your
server directory, labeled as latest.log.
Please copy the contents and paste them to a paste service.
Type ?paste for more information.

charred pelican
#

Looking trough the update logs, I can't see anything that might break commands. Hopefully the logs can help.

jade harness
#

there's nothing rilevant, but i will send you soon on DM

charred pelican
#

Alright. I do see that this new option was addedenable_open_requirements_bypass_permissions. Any chance you were using the deluxemenus.openrequirement.bypass.* permission to bypass open requirements?

#

Now this permission is disabled by default and you need to enable it per menu.

jade harness
#

the thing is that there no requirements on those menus

#

is just something like

open_command:
  - test
register_command: true
open_commands:
  - '[sound] ENTITY_ARROW_HIT_PLAYER'
size: 54
items:```
charred pelican
#

Hmm. Can you set debugging level to LOWEST in config.yml, restart the server and try to open those menus? See if those logs help at all

jade harness
#

sure

#

in the meantime, consider that commands just disappear from tab

just like they dosent exist

#

debug dosent help cause command is not registered

charred pelican
#

Ah. Well, in that case, hopefully this debug mode will add more info on server start. Bcz commands are registered on server start.

jade harness
#

let me see

charred pelican
#

I'll be back in 10 minutes. Please send the startup log when you have time and I'll take a look.

Also, try the latest dev build from jenkins. See if that one has the same issue.

jade harness
#

Bug start happend from 211 DEV

210 work fine

charred pelican
jade harness
#

yeah, ping me if you find the issue!

thank you for your work

charred pelican
#

@jade harness I have another question. If you try running /deluxemenus:<command>, does it work?

#

For example, /deluxemenus:gilda

jade harness
#

i cant test now, i will let you know as soon as possible

charred pelican
charred pelican
#

Alright. It should contain the fix for MMOItems as well

#

will merge this and push to jenkins soon

jade harness
#

yes, i see

#

thank you very much

jade harness
#

quick question. Its normal that with a lot of MMO items, gui have a delay before opening? this happend only the 1st time open

i assume that plugin load item on 1st opening but its not better to preload at startup those items on some way?

charred pelican
#

Yeah, deluxemenus loads the items first time and then caches them. To preload them on startup would mean to basically load every single MMOItem in memory which is not good.

jade harness
#

alright, thank you

jade harness
# charred pelican Yeah, deluxemenus loads the items first time and then caches them. To preload th...

hello again. with latest ver, if i wanna open other menu, without using [close] i cannot do anymore

like:

this is what i have. This will open an external menu

      - '[player] is'```

with latest build i have to do in this way or it dosent work

this is what i have to do
```    left_click_commands:
      - '[player] is
      - '[close]'```

also, menu [refresh] have problem too. It dosent update like before... i have to click 2 times to update it sometimes.

I hope you can revert this folia update for now. Or, atleas, send me a modified verdione of DM before the 211 build. Thank you.


( i also sent a new error probably related to folia in DM )
charred pelican
#

Hi. Sorry, I've been very busy. I've opened a ticket about this on github. Will try to get you a build without folia for now.

charred pelican
jade harness
#

no worry! thanks