silent valley
hi. While using the deluxemenu function, I discovered that certain nbt tags are not supported by deluxemenu.
I got the NBT Tag of a specific item with the command(/data get entity manager SelectedItem), but I realized that nbt_string is not supported for that item.
Could you please add a feature to support this? If you could add it, it would be a really helpful feature for a lot of people.
Image: https://imgur.com/a/OfmqeGX
oak compass
Blitz if you see this we could maybe do something similar to what I did for checkitem to support compounds. ArmourersWorkShop..SkinType:armourers:sword ||Yes, I'm using an api not nms directly||
But I do wonder, what does adding an nbt tag to an item in deluxemenus do? Surely a combination of material/data/custommodeldata/name/lore would be enough to display what the item should look like
adding the custom tag by itself won't change how it looks
hushed badge
@oak compass depends how the plugin works. If it checks for SkinType to display a custom texture, you can not accomplish this in other ways
Also, for the format, I would use as separator a character that can not be used in a key
And would be better to allow players to use a SNBT string imo, instead of offering support for certain data types
nbt: "{ArmourersWorkShop: {SkinType: \"armourers:sword\"}}"```
Or to get rid of the escaping, load the NBTs from a .txt file or something like that
```txt
some-id-here {ArmourersWorkShop: {SkinType: "armourers:sword"}}
nbt: some-id-here
I suppose maybe, but to me it seems impossible to change which texture a player is seeing because of a custom nbt tag value. But then again, I am not a genius when it comes to RP stuff.
hushed badge
You can very much do that, at least with optifine
silent valley
Can't the function I suggest solve this problem?
Actually, I don't know much about the workshop structure, but I wondered if I could implement it with nbt tag.
oak compass
You can very much do that, at least with optifine
ah, with optifine it makes sense. But for vanilla client and bukkit/spigot/paper I don't think possible.
oak compass
Can't the function I suggest solve this problem?
Can you explain a little bit about why you need the nbt tag to be as such? Does the custom NBT tag define the texture somehow?
As I've said, to me that seems impossible. I just want to be able to replicate your item correctly
hushed badge
ah, with optifine it makes sense. But for vanilla client and bukkit/spigot/paper...
People use optifine, and besides custom textures, you can also use nbt for things that aren't supported by dm
oak compass
Ya, I'm trying to see the purpose for use inside of dm
silent valley
I'm using Armorus Workshop and I want to display them in the deluxe menu GUI.
There are many other plugins that support NBT Tags.
Since the deluxe menu has so many features, I would like to be able to display items with a special NBT tag in the deluxe menu as an All in One solution.
oak compass
If you give yourself an item with just those NBT tags does Armourers Workshop make that item look correct?
(Via /give)
Is that a mod not a plugin?
Idk how to even setup a testing environment for Armourers Workshop (if it is the mod)
silent valley
Is that a mod not a plugin?
If you give yourself an item with just those NBT tags does Armorers Workshop make that item look correct?
(Via /give)
-> yeah
Command: /give manager armorers_workshop:skin{ArmourersWorkshop: {SkinType: "armourers:wings", Identifier: "db:QisNoDZRPU"}}
Video: https://youtu.be/1kYTyI7v88I
Is that a mod not a plugin?
-> yeah this is mod
Idk how to even setup a testing environment for Armorers Workshop (if it is the mod)
-> Just put the mod (https://www.curseforge.com/minecraft/mc-mods/armourers-workshop/download/4056457 ) in the arclight bukkit and run it. I can help with testing.
oak compass
ya i see it's a mod it makes sense
silent valley
yeah
If the supported nbt tag range is further increased, it will increase the scalability of deluxemenu. That would be cool.
oak compass
agreed
oak compass
well I have no idea how to do it
and no idea where this would lie on the planning board
silent valley
I'll send you an example.
oak compass
Blitz if you see this we could maybe do something similar to what I did for chec...
I never even linked my code for this lol, but this is nowhere near how it would need to be done
I don't understand anything to do with the NMS code and nbt structure
silent valley
This is a form that supports nbt tag in shopgui that I got from my friend. You don't have to apply this method, but just send it as a resource for inspiration. Actually I don't know how to do it either.
oh
oak compass
ya, it's nice to have a layout we want, but implementing that
oak compass
```yaml
nbt: "{ArmourersWorkShop: {SkinType: \"armourers:sword\"}}"```
Or to ge...
as gaby said, this would be really nice to implement as far as anything nbt goes
oak compass
I don't think it will be implemented anytime soon, but Blitz is the main dev and will be busy for a little bit afaik
