#papi-updates

1 messages ยท Page 10 of 1

still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: change/placeholderexpansion\-methods
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [x] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

Updates the Placehold...

#
[PlaceholderAPI/PlaceholderAPI] branch deleted: change/placeholderexpansion\-methods
mint valveBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New tag created: 2\.10\.7
#
[PlaceholderAPI/PlaceholderAPI] branch deleted: update/request\-change\-wiki
mint valveBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: change/update\-instructions
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [x] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

[Pull request...

#
[PlaceholderAPI/PlaceholderAPI] branch deleted: change/update\-instructions
mint valveBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: change/update\-badges
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [x] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

Updates the Shields.i...

mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
#
PlaceholderAPI #65

Build: 65
Status: failure

Changes:

  • eb6fbd removed all instances of PlaceholderHook - Ranald Taylor
  • 3acb99 updated build file to include sources and javadoc jars in the publications - Ranald Taylor
  • df773a updated to remove previously deprecated members, added contracts to more methods - Ranald Taylor
  • 61c41d removed unused exception - Ranald Taylor

Artifacts:

still narwhalBOT
mint valveBOT
#
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: 2\.10\.7\-0
still narwhalBOT
#

Issue:

Parsing the previously working placeholder for the Server Expansion "%server_uptime%" produces an error in the server log:

[09:56:06] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'papi' in plugin PlaceholderAPI v2.10.7
	at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.16.1.jar:git-Paper-12...
still narwhalBOT
#

Please read

This template is only for reporting bugs of PlaceholderAPI!
If you want to request changes to the code of PlaceholderAPI, use the [Request change (PlaceholderAPI)] template.
For changes to the wiki use the [Request change (Wiki)] template.

Please also make sure that you use the [latest release][Spigot] or the latest [developement build][Jenkins] and that your bug isn't already reported on the [issues] page.

**Please report issues with expansions/placeholders to the...

still narwhalBOT
#

Please read

This template is only for requesting new functions to be added to PlaceholderAPI or for old one to be changed!
Please use the [Request change (Wiki)] template to ask for additions/changes to the wiki.
For reporting bugs of PlaceholderAPI use the [Bug report] template.

Also make sure that the [wiki] doesn't already mention such a function/change and that there isn't a issue about this change on the [issues] page.

We recommend to [open a Pull Request][Pull Requests] ...

still narwhalBOT
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [X] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

Introduces dynamic he...

still narwhalBOT
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [x] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

Cleaned up a bunch ...

still narwhalBOT
still narwhalBOT
#

I agree on the fact that this changes would've been enough for an increase of the minor version and not the patch... You don't really patch anything here, but instead rewrite the entire parsing system and deprecating old methods on the way. That are breaking changes which makes this 2.11.0 rather than 2.10.7... But it's too late I guess.

still narwhalBOT
still narwhalBOT
still narwhalBOT
#

these changes actually have to increment MINOR version, not PATCH.
I agree on the fact that this changes would've been enough for an increase of the minor version and not the patch
That are breaking changes which makes this 2.11.0 rather than 2.10.7

No... no no no.

That is not how semantic versioning works.

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backw...
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: dev
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

Please read

This template is only for requesting new information to be added to the wiki or for updating of already existing information!
Please use the [Request change (PlaceholderAPI)] template to ask for additions/changes to the plugin PlaceholderAPI.
For reporting bugs of PlaceholderAPI use the [Bug report] template.

Also make sure that the [wiki] doesn't already have the change and that there isn't a issue about this change on the [issues] page.

Type

What kind of c...

still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] branch deleted: change/update\-badges
#
[PlaceholderAPI/PlaceholderAPI] branch deleted: change/wiki\-navigation
mint valveBOT
still narwhalBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
still narwhalBOT
#

Please read

This template is only for requesting new information to be added to the wiki or for updating of already existing information!
Please use the [Request change (PlaceholderAPI)] template to ask for additions/changes to the plugin PlaceholderAPI.
For reporting bugs of PlaceholderAPI use the [Bug report] template.

Also make sure that the [wiki] doesn't already have the change and that there isn't a issue about this change on the [issues] page.

Type

What kind of c...

mint valveBOT
still narwhalBOT
still narwhalBOT
#

Please read

This template is only for requesting new functions to be added to PlaceholderAPI or for old one to be changed!
Please use the [Request change (Wiki)] template to ask for additions/changes to the wiki.
For reporting bugs of PlaceholderAPI use the [Bug report] template.

Also make sure that the [wiki] doesn't already mention such a function/change and that there isn't a issue about this change on the [issues] page.

We recommend to [open a Pull Request][Pull Requests] ...

still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: docs/wiki
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [x] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

This is a ongoing PR ...

#

I think the best solution would be to send a manual POST request whenever pushes are made to the master branch that aren't just for the wiki and .github folder.
But for that would we probably need to look into how Jenkins handles the POST webhooks from GitHub. If it just listens for any POST request and doesn't care at all for a request body, then a simple GitHub Action could do the trick. Otherwhise we would need to get the right body to be send too.

#

In what way? GitHub Actions doesn't store the generated files by default

GitHub Actions doesn't do anything by default, everything that it can do, you have to tell it to do.

(There is some sort of temp/limited storage, but that isn't optimal.)

If you use the upload artifact action, the binary is stored on the workflow for 90 days.

The only reliable way to keep jars would be to upload them somewhere like in a GitHub Release or some sort of storage or whatever.

Which is so...

#

I am very aware of this... After all am I using a release action myself but the thing is that a temp-storage won't be a good option and Releases should be reserved for... well... releases.

The best compromise I can see here is to make GitHub trigger a Jenkins build through a custom action IF Jenkins doesn't care about the content of a received POST request and only cares about the POST request itself be...

#

Releases should be reserved for... well... releases.

This doesn't really make sense, releases can be used for literally anything at all.
Many people use releases to mark a project at a point in time, be it alphas, beta, milestones, release candidates, or entire releases.

You really don't have to explain the basics of GitHub Actions to me. I had to work and struggle with those more than I can remember.

Every single sentence that I replied to had an unsure tone.

still narwhalBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: change/remove\-wiki\-template
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

This removes the Requ...

mint valveBOT
still narwhalBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
#

Issue

What is the issue? Describe it like you would tell a friend.

  • PlaceholderExpansion#register is deprecated
  • neither PlaceholderExpansion#onPlaceholderRequest(Player, String) nor PlaceholderExpansion#onRequest(OfflinePlayer, String) get triggered after update

Expected behaviour

What should PlaceholderAPI do?

  • PlaceholderExpansion#register not being deprecated (since it is a method used both on wiki page and on spigot update's changenotes
  • `PlaceholderE...
still narwhalBOT
still narwhalBOT
#

Please read

This template is only for requesting new information to be added to the wiki or for updating of already existing information!
Please use the [Request change (PlaceholderAPI)] template to ask for additions/changes to the plugin PlaceholderAPI.
For reporting bugs of PlaceholderAPI use the [Bug report] template.

Also make sure that the [wiki] doesn't already have the change and that there isn't a issue about this change on the [issues] page.

Type

What kind of c...

still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] branch deleted: docs/wiki
#
[PlaceholderAPI/PlaceholderAPI] New branch created: docs/wiki
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [x] Other: Workflow

Description

Provide additional information if needed.

[Pull requests]...

#
[PlaceholderAPI/eCloud-Client] New branch created: develop
#
[PlaceholderAPI/eCloud-API] New branch created: develop
#
[PlaceholderAPI/PlaceholderAPI] New branch created: change/update\-contributing
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [x] Other: Contributing.md file

Description

Provide additional information if needed.

This refact...

#
[PlaceholderAPI/PlaceholderAPI] branch deleted: change/remove\-wiki\-template
mint valveBOT
still narwhalBOT
still narwhalBOT
#
[PlaceholderAPI/eCloud-API] New branch created: feature/8\-docker\-support
mint valveBOT
#
PlaceholderAPI #79

Build: 79
Status: failure

Changes:

  • f6e639 dump on someone else - Ryan McCarthy
  • 0281e5 Hardcode plugin name in plugin.yml - Ryan McCarthy
  • d29455 Deprecate PlaceholderHook but not onRequest - Ryan McCarthy
  • 8e3c94 Remove deprecation for useful methods, set removal of deprecated methods to 2.11.0, registerPlaceholderHook will fail gracefully - Ryan McCarthy
  • a84336 Include JSONMessage with plugin instead of using maven repo to fetch - Ryan McCarthy
  • 94ce9d Add license header - Ryan McCarthy
  • 8c8294 Added missing commands to help commands, fixed some color / formatting - Ryan McCarthy
  • a23229 remove register deprecation as it won't be final. Set removal for deprecated methods to 2.11.0 - Ryan McCarthy
  • fc453a Add license header - Ryan McCarthy
  • 8c15cd remove JSONMessage repo, Update archive file name and license stuff - Ryan McCarthy

Artifacts:

still narwhalBOT
mint valveBOT
still narwhalBOT
#

Your issue lacks some essential information for us to provide you with proper help.

Please provide the following missing info:

  • PlaceholderAPI version you used in your plugin
  • PlaceholderAPI version you used on the server (if it is a dev build, also include the build number)
  • The actual expansions you use. Just saying "none except mine" is not an answer.
  • The code you have in your expansion.
mint valveBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: feature/add\-codeowners
mint valveBOT
still narwhalBOT
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [x] Other: Repository

Description

Provide additional information if needed.

This adds a CODEOWNER...

#
  • PlaceholderAPI version you used in your plugin
  • 2.10.7
  • PlaceholderAPI version you used on the server (if it is a dev build, also include the build number)
  • 2.10.7
  • The actual expansions you use. Just saying "none except mine" is not an answer.
  • I do not use any expansions except the one i am working on. It wont matter how we call the expansion, so it will be "TestExp"
  • The code you have in your expansion.
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [x] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

This PR improves the ...

#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

[Pull request...

still narwhalBOT
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [] Internal change (Doesn't affect end-user).
  • [X] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

Dynamic command descri...

still narwhalBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [x] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Provide additional information if needed.

This improves the `/p...

mint valveBOT
still narwhalBOT
#

This can have HEAVY issues when it would be used with the ITALIC or UNDERLINE enum field.
I don't say it will and I believe it won't be, but it could throw an IllegalArgumentException, because the of method makes a try-catch where it parses an integer from the provided String (which would fail in those cases.

You should add an if (hex.equals("&o")) return ChatColor.ITALIC (Same for Underline)

#
[PlaceholderAPI/Statistics-Expansion] branch deleted: development
still narwhalBOT
mint valveBOT
#
PlaceholderAPI #87

Build: 87
Status: success

Changes:

  • 9d43b7 Remove space before placeholders start - Ryan McCarthy
  • 0f8ce0 Set Manager to lower case - Ryan McCarthy
  • 97fd3a Make the message differentiate between singular and plural updates avail - Ryan McCarthy
  • 188546 Show help in alphabetical order - Ryan McCarthy
  • 91d370 Set artifact id to lower case - Ryan McCarthy

Artifacts:

mint valveBOT
mint valveBOT
mint valveBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#
[PlaceholderAPI/eCloud-Client] New branch created: feature/1\-docker\-support
still narwhalBOT
still narwhalBOT
#

Bug Report

Issue

What is the issue? Describe it like you would tell a friend.
Random stacktrace upon server start, plugin seems to function normally otherwise

Expected behaviour

What should PlaceholderAPI do?
Not output a stacktrace

Actual behaviour

What does PlaceholderAPI actually do?
Magic

How to reproduce

What steps did you made, to get this bug?
./start.sh

Installed expansions

Please list all expansions that are displayed when ...

#

I was wondering if the placeholder app team could please add the above placeholder (%mv_players_[world]%) into the plugin. This placeholder would return the number of players currently in a certain multiverse world. This would be very useful to a lot of people. Also, I did ask in the multiverse discord however they said to ask the placeholder api team directly, since you were the ones who made the original mv placeholders. Thanks, CrazyMMG

#

Oh I'm stupid my bad, never included the stacktrace here, was sidetracked.

[17:26:55 WARN]: [PlaceholderAPI] failed to download expansion information
java.util.concurrent.CompletionException: java.util.ConcurrentModificationException
at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273) ~[?:1.8.0_242]
at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280) ~[?:1.8.0_242]
at java.util.concurrent.CompletableFuture.uniAp...
still narwhalBOT
#

Bug Report

Issue

What is the issue? Describe it like you would tell a friend.

PlaceHolderAPI is generating errors when my server is stopped or restarted with either the latest Spigot version 2.10.8 or the latest developer version 2.10.9 DEV 92. (Running Paper 129).

Installed Plugins:
Plugins (39): ConditionalCommands*, CoreProtect, dynmap*, Dynmap-Essentials*, Essentials, EssentialsAntiBuild, EssentialsChat, EssentialsGeoIP, EssentialsSpawn, FarmLimiter, GriefPrevention,...

still narwhalBOT
#

Feature Request

Type

What kind of request is this? (Multiple selections possible)

  • [ ] New function for PlaceholderAPI.
    A new function that developers could use.
  • [ ] Change to code (Internal).
    Changes to code that won't affect the end-user.
  • [ ] Change to code (External).
    Changes to code that will affect the end-user (breaks stuff).
  • [x] Other: __________

Info

What is the change?
Please provide as much information (including links, images a...

still narwhalBOT
still narwhalBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: change/update\-templates
#

Please read

Please make sure you checked the following:

  • You checked the [Pull requests] page for any upcoming changes.
  • You documented any public code that the end-user might use.
  • You followed the [contributing file]

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [x] Other: Issue templates

Description

Provide additional information if needed.

Closes #416

...

#

Feature Request

Type

What kind of request is this? (Multiple selections possible)

  • [ ] New function for PlaceholderAPI.
    A new function that developers could use.
  • [ ] Change to code (Internal).
    Changes to code that won't affect the end-user.
  • [ ] Change to code (External).
    Changes to code that will affect the end-user (breaks stuff).
  • [x] Other: Repository

Info

What is the change?
Please provide as much information (including links, images a...

#

Actually there should be an issue made for everything you want to write code for.

Here's a copy from the discord:

Branch policy
We have 2 restricted branches we should only be PRed to.
These branches are master and develop.

  • master is for releases only and should only be PRed from the develop branch.
  • develop is where all feature and bugfix branches are PRed to. This branch will be used to get all features and bugfixes for the next relea...
still narwhalBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
#

If the changes are affecting the actual code would it be on the develop branch.
When you, however, only edit the docs to f.e. fix typos or invalid tags, should it target the docs branch which at a later point could be merged into develop.
The point of this would be to prevent an extreme amount of "fix typo" PRs that could trigger new builds with no changes other than Javadoc corrections.

still narwhalBOT
#

@PyvesB Can you test this build in the dev repo?

<repository>
  <id>dev</id>
  <url>https://repo.extendedclip.com/content/repositories/dev</url>
</repository>

<dependency>
  <groupId>me.clip</groupId>
  <artifactId>placeholderapi</artifactId>
  <version>2.10.9-DEV-93</version>
</dependency>```

I have tested this locally and can confirm that it works. Thanks for looking into this issue promptly, @extendedclip ! ๐Ÿ‘๐Ÿป

#
[PlaceholderAPI/eCloud-API] branch deleted: feature/8\-docker\-support
#
[PlaceholderAPI/eCloud-Client] branch deleted: feature/1\-docker\-support
still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
#

doing /papi parse me %server_uptime%
https://pastebin.com/L094pZiL
on Papi 2.10.8

Update the server expansion it still uses the old code.

Adding on to this since it has been re implemented, the current method does not get the correct start time. Server started just a few mins ago.. https://img.extendedclip.com/chrome_2020-07-31_21-48-58.png

check #15 which will fix this issue :)

still narwhalBOT
still narwhalBOT
#

Feature Request

Type

  • [x] Change to code (External).

Description

Whoever made this is someone who doesn't understand api design
image

My request is simple: enforce online players.
Why? First, backwards compatibility. API design is the politics game and you can't go breaking it without solid argument. I don't see ANY solid argument for breaking the working PlaceholderAPI#setPlaceholders(Player, String) .
Second, the ...

still narwhalBOT
still narwhalBOT
#

PlaceholderAPI did use OfflinePlayer since quite some time now and even recommended it over the Player option for multiple reasons:

  1. OfflinePlayer is nullable while Player would cause exceptions to happen.
  2. Not every expansion requires a Player instance to be used so it is often simpler to have null being passed in those situations instead of first trying to get a Player instance somewhere to then use for nothing.
  3. You can easly use a Player instance for the OfflinePlayer parameter...
still narwhalBOT
#

You're breaking completely working functionallity which isn't unsafe. This is just going to lead to more developers making their own alternatives of placeholderapi or use already existing ones (like mvdw's, although maxim doesn't suggest using it in his plugins except if we're adding placeholders) because no one knows shit about what api are you going to break every now and then.

Yes when you put a @Deprecated annotation you have to remove the method at some point (that's one of the rea...

#

Pull Request

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [x] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Closes #419

This undoes the deprecation of the setPlaceholders and setBracketPlaceholders methods that use a Player instance (With exception of the methods with the colorize param. Thos stay deprecated).

The Player instance is marked as @NotNull and in addition...

#
[PlaceholderAPI/PlaceholderAPI] branch deleted: feature/add\-codeowners
#
[PlaceholderAPI/PlaceholderAPI] branch deleted: change/update\-templates
#
[PlaceholderAPI/PlaceholderAPI] branch deleted: dev
#
[PlaceholderAPI/PlaceholderAPI] branch deleted: 2\.10\.7\-0
still narwhalBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New tag created: 2\.10\.9
mint valveBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

Bug Report

Issue

I have a towny server and I wanted to heave some leaderboards to show people who the top players are.
To get the leaderboards, I bought the Leaderheads plugin on spigot. It told me on their wiki I should use the placeholders and change the yml files after. Basicly when I wanted to download the placeholders. It told me it got installed succesfully. Reloading didn't work tho so I restarted the server to hopefully make it work. When I tried validating the leader...

mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

Pull Request

Type

  • [x] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Refactored TimeUtil utility class

  • Minimized TimeUtil#getRemaining.
  • Fixed a bug regarding how days and hours were calculated in TimeUtil#getTime.
  • Ditched the use of ints and use longs instead.
  • Implemented int-taking methods so it won't break for ...
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

Bug Report

Setting up a new JavaScript variable with ChatControl 8.7.1 (also 8.7.2) fails.

This is the message PAPI outputs when it fails:
[14:07:09 WARN]: [PlaceholderAPI] Failed to set ScriptEngine for javascript placeholder: blocks_flown

How to reproduce: https://github.com/kangarko/ChatControl-Pro/issues/1799

/papi dump output

https://paste.helpch.at/qofuxakuxu

I appreciate if you can guide me why this happens when ChatControl is installed, can you provide me mor...

still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
mint valveBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
still narwhalBOT
mint valveBOT
still narwhalBOT
#

Refactored naming of classes to be more consistent.

Added functional placeholder handlers, which can be registered:

public void enable() {
    registerPlaceholder("name", context -> ...);
}

Placeholder Scanning
Expansion authors would be able to mark classes with @PlaceholderScan which will activate scanning the class for valid placeholder annotations as such:


@Placeholder("name")
public String playerName(final PlaceholderContext context) {
     r...
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: dep\-updates
still narwhalBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: feature/label\-commenter
#

Pull Request

Type

  • [ ] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [x] Other: Issues/Pull requests

Description

This adds a GitHub Action, which allows us to send canned responses based on labels we (un)assign to issues and Pull requests.

For example could we send a Comment to an issue when the Type: Issue (Expansion) label is assigned, informing about the issue being caus...

#

I added a label-commenter-config.yml which currently has the following settings for the following labels:

Type: Issue (Expansion)
Comments on the issue about it being caused by an expansion and not PlaceholderAPI and that the issue should be reported to the Expansion's main issue tracker.

Type: Duplicate
Comments on the issue informing about the fact that another issue or Pull request exists, which is the exact same.

Closes the Issue/Pull request.

**Problem: More info re...

still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

Pull Request

Type

  • [x] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Right now does PAPI send an update notification to a joining player, even if "check_updates" is set to false. This is fixed with this PR.

Additionall was the Join listener moved from the UpdateChecker class to its own class in the listener folder (Makes more sense)

Closes...

still narwhalBOT
#

Thanks for the update, sorry it took so long to test. I receive the following error on shutdown/restart with version 101:

https://pastebin.com/EewDzjJ5

Hey.
Looking at the stacktrace you provided does it seem to be caused by another expansion/plugin and not PlaceholderAPI directly:
at me.thienbao860.expansion.spsexpansion.SpeedPerSecondExpansion.clear(SpeedPerSecondExpansion.java:121)

The above line points to an expansion (SpeedPerSecond Expansion) which cancels a task ([Li...

still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

Feature Request

Add /papi parse all and /papi parse all offline options.

Type

  • [ ] New function for PlaceholderAPI.
    A new function that developers could use.
  • [ ] Change to code (Internal).
    Changes to code that won't affect the end-user.
  • [ ] Other:
    add more options too commands.
    Soo you can target all players online and/or offline too.

Description

I use a command like this [console] papi parse %player_Name% %javascript_cooldown_tes1_start%

But side e...

still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: feature/441\-add\-parse\-all
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

1.6 code request

Since I have a lot of time to do stuff with this expansion, which I always love, seems to always not having enough for my benefit. With 1.6, all of my benefits are in there now; hopefully, to help not just me, but the others

Changes include:

  • Prevent script comment codes from parsing placeholders inside them
  • JSON Object handing: array support, better and organized data store (currently only for Nashorn, but it will be easy to integrate with other future ...
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: feature/update\-documentation
#

Pull Request

Type

  • [x] Internal change (Doesn't affect end-user).
  • [ ] External change (Does affect end-user).
  • [ ] Wiki (Changes towards the [Wiki]).
  • [ ] Other: __________

Description

Updates the Plugin's Javadoc (either by editing existing one or adding a new one) for better documentation of the methods that are supposed to be used by others.

Please let me know about any additional methods, classes, etc that need documentation.

Closes N/A

[W...

still narwhalBOT
#

Feature Request

Type

  • [x] New function for PlaceholderAPI.
    A new function that developers could use.
  • [ ] Change to code (Internal).
    Changes to code that won't affect the end-user.
  • [ ] Change to code (External).
    Changes to code that will affect the end-user (breaks stuff).
  • [ ] Other: __________

Description

It would be beneficial when PlaceholderAPI has some event that would be fired once all its expansions have been loaded.
This would be us...

still narwhalBOT
still narwhalBOT
#

Bug Report

Issue

There seems to be a disconnect in the API deprecation vs what is actually available right now. In the code it has an annotation for @ApiStatus.ScheduledForRemoval(inVersion = "2.11.0") https://github.com/PlaceholderAPI/PlaceholderAPI/blob/master/src/main/java/me/clip/placeholderapi/PlaceholderAPI.java#L272 however it appears to have already been removed in the latest version 2.10.9 available on Spigot MC now.

Expected behaviour

The method should still b...

still narwhalBOT
#

This is not a bug and also not the case.

The GitHub code is (at least) always the same as the latest spigot release (you can check the code at the time of the 2.10.9 release).

The ScheduledForRemoval annotation will also cause the IDE to display an error, so this could also be caused by it.

Anyway, this isn't a bug as you're not supposed to use those methods anyway.
If you have plugins using those methods, update them or nag the author about it.

still narwhalBOT
#

@Andre601 thanks for taking the time out of your day for your response.

  1. Donโ€™t understand how something being removed abrupt and prematurely is โ€œnot the caseโ€. The method is not in the latest version, whatโ€™s up for debate here?

  2. Well I guess this is one of those โ€œmaybeโ€ cases as Iโ€™ve pointed out.

  3. The method does not exist at all in the version, blaming the annotation has absolutely nothing to do with it.

  4. Saying it isnโ€™t a bug because weโ€™re โ€œnot supposed to use those meth...

still narwhalBOT
#
  1. Donโ€™t understand how something being removed abrupt and prematurely is โ€œnot the caseโ€. The method is not in the latest version, whatโ€™s up for debate here?

The debate here is whether it's worth it or not to update the downloads just to add a method that was planned for removal anyway.
The PlaceholderExpansion#register() existed for quite some time now, the wiki mentioned it in its examples too, so the question if we should update the releases (or even make a new one) just to re-add ...

still narwhalBOT
#

I don't think this is necessary. The current update checker only checks if enabled on startup and does not register the listener in the case it is disabled. There is nothing to fix as it is intentional to be that way. No need for dynamic update checker enable/disable. Either disable it and keep it that way or enable it and keep it that way.

still narwhalBOT
still narwhalBOT
#

So, just to understand this correct: What is the exact goal here?

* Parse the provided String based on the online players and send them the text? Or

* Parse the provided String based on the online players and send them to yourself?

I run this in deluxmenu [console] papi parse %player_Name% %javascript_cooldown_Miner_start%
I do like this, but only for player ho activate it.

The receiving placeholder are %javascript_cooldown_Miner_10800% (some you see i...

still narwhalBOT
still narwhalBOT
#

So, just to understand this correct: What is the exact goal here?

* Parse the provided String based on the online players and send them the text? Or

* Parse the provided String based on the online players and send them to yourself?

I think is more like number 1, But is not text i send. It for activate a java scripted timer placeholder. But i guess it almost same thing as send text?

still narwhalBOT
#

I think is more like number 1, But is not text i send. It for activate a java scripted timer placeholder. But i guess it almost same thing as send text?

I don't really understand what exactly you mean with that.
I right now added a all argument to the bcparse command, which - instead of just using the executor of the commands for the placeholders - takes every online player and sends them the info based on themself.

I again can't really get what you want to achieve here and I dou...

still narwhalBOT
#

I think is more like number 1, But is not text i send. It for activate a java scripted timer placeholder. But i guess it almost same thing as send text?

I don't really understand what exactly you mean with that.
I right now added a all argument to the bcparse command, which - instead of just using the executor of the commands for the placeholders - takes every online player and sends them the info based on themself.

I again can't really get what you want to ac...

still narwhalBOT
#

I see now. This is probably more an issue caused by your javascript and not really something we could solve through PlaceholderAPI.

The whole time did I assume you wanted a parse command to parse for all players or something...

@extendedclip Do you have any additional info on this (i.e. how the Javascript could be changed to not display the countdown lore when the player isn't on cooldown?)
Also, is the PR #442 still a somewhat good idea to add or not really useful? (It would essential...

still narwhalBOT
#

I see now. This is probably more an issue caused by your javascript and not really something we could solve through PlaceholderAPI.

The whole time did I assume you wanted a parse command to parse for all players or something...

@extendedclip Do you have any additional info on this (i.e. how the Javascript could be changed to not display the countdown lore when the player isn't on cooldown?)
Also, is the PR #442 still a somewhat good idea to add or not really useful?...

still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

It would be cool if you would add my plugin "StreamingDrops" to the list of plugins that use your API.

StreamingDrops has its own placeholders for external plugins (no cloud download).

A link to the plugin:
https://www.spigotmc.org/resources/76996/

An info about all available placeholders from PAPI:
https://github.com/morelaid/StreamDrops/wiki/PlaceholderAPI-Support#placeholderapi

If you need more information, please let me know.

still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: feature/451\-add\-streaming\-drops
#
[PlaceholderAPI/PlaceholderAPI] branch deleted: feature/451\-add\-streaming\-drops
still narwhalBOT
#
[PlaceholderAPI/PlaceholderAPI] New branch created: feature/add\-getBoolean
still narwhalBOT
#

Feature Request

Type

  • [x] New function for PlaceholderAPI.
    A new function that developers could use.
  • [ ] Change to code (Internal).
    Changes to code that won't affect the end-user.
  • [ ] Change to code (External).
    Changes to code that will affect the end-user (breaks stuff).
  • [ ] Other: __________

Description

Player Absorption placeholder vairable which measures the absorption of a player.

Maybe %player_absorption%.

Would be very useful...

#

Bug Report

Issue

I was previously using PAPI 2.10.6 and the expansion listplayers.jar was working as a means to tell my players who was in which world, I recently updated to 2.10.9 & 2.10.10-Dev108 and this expansion no longer works in both versions, when registered it throws the following error:

[Fri, 28. Aug 2020 16:11:00 BST INFO] Zefferis issued server command: /papi register Expansion-listplayers.jar
[Fri, 28. Aug 2020 16:11:00 BST WARN] listplayers is attempting to...
still narwhalBOT
#

Issue
What is the issue? Describe it like you would tell a friend.

Online player count is always showing (/60). %essentials_safe_online% placeholder is not working.

Expected behaviour
What should PlaceholderAPI do?

Show the correct playercount excluding vanished player (since the placeholder is meant to do that)

Actual behaviour
What does PlaceholderAPI actually do?

It doesn't show anything.

How to reproduce
What steps did you made, to get this bug?

PlaceholderAPI 2.1...

still narwhalBOT
#

This isn't a bug. It's an intentional behaviour. The warning clearly tells you what is happening: The Listplayers expansion is trying to register through PlaceholderHook which isn't recommended nor supported since ages.

You perhaps can use the Worlds Expansion to tell who was in which world (i.e. %world_recentquit_<world>% for who recently left in world <world>)

But again, this is not a bug.

still narwhalBOT
still narwhalBOT
#

Player Absorption placeholder vairable which measures the absorption of a player.

Source https://minecraft.fandom.com/wiki/Absorption#:~:text=Absorption%20is%20a%20status%20effect,be%20removed%20by%20drinking%20milk.

Absorption is a status effect that impacts a player's health bar in a positive manner by adding "extra hearts" in addition to a player's typical 20 HP. Absorption adds 4 HP per level of extra health to the player. Once enough damage has been taken by a player to depl...

still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

Hello @Andre601,

Thank you for reaching out to us about the wiki.
We would like to inform you, that you are now able to directly commit your changes to the wiki through a Pull request.
When doing so, make sure you follow these steps:

  • The Pull request targets the docs/wiki branch of the Repository.
  • You only made changes to the files inside the wiki folder.
  • You followed the general Styling Guidelines mentioned in the...
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
still narwhalBOT
#

Paper version git-Paper-174 (MC: 1.16.2) (Implementing API version 1.16.2-R0.1-SNAPSHOT)

`
31.08.2020 21:56:15 [WARNING] java.lang.NullPointerException
31.08.2020 21:56:15 [WARNING] at me.clip.placeholderapi.replacer.CharsReplacer.apply(CharsReplacer.java:44)
31.08.2020 21:56:15 [WARNING] at me.clip.placeholderapi.PlaceholderAPI.setPlaceholders(PlaceholderAPI.java:69)
31.08.2020 21:56:15 [WARNING] at me.clip.placeholderapi.PlaceholderAPI.setPlaceholders(PlaceholderAPI.java:97)
31.0...

still narwhalBOT
still narwhalBOT
#

Bug Report

Version: 2.10.9
Server: Paper 1.16.2

Issue

I personally hook PlaceholderAPI for custom placeholders from my plugins, and I just realized that non of them are being parsed.

It was working just fine until 2.10.6, and I decided to update today, so I did, and it refuses to parse the custom placeholders. However, the extensions work just fine.

I also tried /papi reload to see if it will load, but I was not successful.

Expected behaviour

Parse plac...

still narwhalBOT
still narwhalBOT
#

Hello @Andre601,

Your issue unfortunately lacks certain information that we require in order to help you with your issue.
Please make sure you provide the following information:

  • Currently used Versions of your server and PlaceholderAPI
  • Currently installed Expansions
  • Currently installed Plugins

The easiest way to provide those information is through the /papi dumb command which posts the required information and gives a URL to share.

This is an automated response.