Module Manager Patch | Kerbal Space Program | Page 1

lean kindle Apr 12, 2023, 12:09 PM

#

I want to Patch a Patch of SSPX. Especially the Tac-Ls patch.
But idk How to start the .cfg.
With a part config it would be @Part, but here i want patch the complete "TacGenericConverter" Module. But only in that config

📎 SSPXR-TACLS-00.cfg

quaint jasper Apr 12, 2023, 1:11 PM

#

there's nothing special about "part"

#

@tidal grailEVER just patches all of the top-level WHATEVER nodes it finds

#

...sorry for ping

#

if you haven't found it yet, the docs are useful, though sometimes incomplete: https://github.com/sarbian/ModuleManager/wiki/Module-Manager-Handbook

GitHub

Module Manager Handbook

Contribute to sarbian/ModuleManager development by creating an account on GitHub.

lean kindle Apr 12, 2023, 2:34 PM

#

quaint jasper there's nothing special about "part"

thx. sspx is done. But i dont get the patch for planetside to work (planetside ls patch from benjee)

📎 MMSEV_TAC_LS.cfg

#

@MMSEV_TAC_LS
{
@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]
{
@MODULE[TacGenericConverter]:AFTER[Benjee10_MMSEV]
{
@OUTPUT_RESOURCE
{
ResourceName = Food
Ratio = 0.00001925
DumpExcess = false
}
}
}
}

#

my patch

quaint jasper Apr 12, 2023, 3:02 PM

#

you can't have :AFTER on a non-top-level node

#

move that up to the first line

#

um

#

and I don't understand why you have a non-top-level @PART

lean kindle Apr 12, 2023, 3:04 PM

#

quaint jasper and I don't understand why you have a non-top-level `@PART`

becasue i want to edit the greenhouse converter, in that patch are multiple "TacGenericConverter". how would i specify that

quaint jasper Apr 12, 2023, 3:04 PM

#

but the PART isn't inside MMSEV_TAC_LS, is it?

lean kindle Apr 12, 2023, 3:05 PM

#

the part configs is saved somewhere eles

quaint jasper Apr 12, 2023, 3:05 PM

#

@MMSEV_TAC_LS
{
@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]

#

that says "find a PART node inside a MMSEV_TAC_LS node"

#

PARTs generally aren't inside other things

lean kindle Apr 12, 2023, 3:06 PM

#

yeah. but i tryed it without the @MMSEV_TAC_LS
{

quaint jasper Apr 12, 2023, 3:06 PM

#

then you did something else wrong

lean kindle Apr 12, 2023, 3:06 PM

#

and it dident worked

quaint jasper Apr 12, 2023, 3:07 PM

#

like the AFTER is in the wrong place

lean kindle Apr 12, 2023, 3:07 PM

#

so it have to be spmething like that

#

@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]:AFTER[Benjee10_MMSEV]
{
@MODULE[TacGenericConverter]
{
@OUTPUT_RESOURCE
{
ResourceName = Food
Ratio = 0.00001925
DumpExcess = false
}
}
}

quaint jasper Apr 12, 2023, 3:07 PM

#

the output_resource block looks suspect

#

are you trying to add a new output or replace an existing one?

lean kindle Apr 12, 2023, 3:08 PM

#

i just want to increase the food output for now

quaint jasper Apr 12, 2023, 3:08 PM

#

for that matter, does the part already have this converter module or are you trying to add one?

#

oh I see

lean kindle Apr 12, 2023, 3:09 PM

#

the coverter gets added with that #1095682055863537685 message

quaint jasper Apr 12, 2023, 3:09 PM

#

@OUTPUT_RESOURCE is going to target the first one it finds, so you need to specify the one you actually want: @OUTPUT_RESOURCE:HAS[#ResourceName[Food]]

#

and then all the keys inside need @ at the front, or else it will just add them

#

and you don't actually have to specify the resourcename and dumpexcess because you aren't changing them

lean kindle Apr 12, 2023, 3:12 PM

#

quaint jasper and then all the keys inside need `@` at the front, or else it will just add the...

so?

#

@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]:AFTER[Benjee10_MMSEV]
{
@OUTPUT_RESOURCE:HAS[#ResourceName[Food]]
{
ResourceName = Food
Ratio = 0.00001925
DumpExcess = false

}

quaint jasper Apr 12, 2023, 3:12 PM

#

and then all the keys inside need @ at the front, or else it will just add them
and you don't actually have to specify the resourcename and dumpexcess because you aren't changing them

lean kindle Apr 12, 2023, 3:13 PM

#

@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]:AFTER[Benjee10_MMSEV]
{
@OUTPUT_RESOURCE:HAS[#ResourceName[Food]]
{
@ResourceName = Food
@Ratio = 0.00001925
@DumpExcess = false

}

quaint jasper Apr 12, 2023, 3:14 PM

#

yes, except you could just delete the ones you're not changing

lean kindle Apr 12, 2023, 3:14 PM

#

so removing DumpExcess = false

quaint jasper Apr 12, 2023, 3:14 PM

#

and resourcename

lean kindle Apr 12, 2023, 3:17 PM

#

quaint jasper and resourcename

got that now, dident worked @PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]:AFTER[Benjee10_MMSEV]
{
@OUTPUT_RESOURCE:HAS[#ResourceName[Food]]
{
@Ratio = 0.00001925
}
}

quaint jasper Apr 12, 2023, 3:19 PM

#

ok, check the logs for the name of your patch and see when/where it applied

#

oh you know what

#

I don't think any of the planetside patches use FOR[Benjee10_MMSEV] so you can't use AFTER with that token

#

I could be wrong about that; but check ksp.log for a marker like :FOR[Benjee10_MMSEV] pass

lean kindle Apr 12, 2023, 3:23 PM

#

quaint jasper I could be wrong about that; but check ksp.log for a marker like `:FOR[Benjee10_...

i have that line

#

also :AFTER

quaint jasper Apr 12, 2023, 3:24 PM

#

ah ok, I just re-read the docs and it should be fine

lean kindle Apr 12, 2023, 3:24 PM

#

[LOG 17:15:42.450] Applying update zMein Zeugs/Greenhous/@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]:AFTER[Benjee10_MMSEV] to Benjee10_MMSEV/Parts/base_greenhouse.cfg/PART[Benjee10_MMSEV_baseGreenhouse]

quaint jasper Apr 12, 2023, 3:24 PM

#

ok that's good

#

search for the part name and make sure that your patch got applied after the base support patch

#

and check to see if any other patches are affecting that part

lean kindle Apr 12, 2023, 3:27 PM

#

so if my pathc comes afeter the patch of benjee and no other patch is patching my patch

quaint jasper Apr 12, 2023, 3:29 PM

#

I would expect it to work, yeah

#

but patches don't patch other patches, they just patch the current set of data

#

so you're looking for other patches that touch the same part

lean kindle Apr 12, 2023, 3:34 PM

#

there is only mine and that from benjee

#

in case you want to have a llok

📎 KSP.log

quaint jasper Apr 12, 2023, 3:37 PM

#

and you're sure the patch isn't applying? you can look in modulemanager.configcache to see the final state of all nodes after patching applies

#

that log doesn't contain "Benjee10_MMSEV_baseGreenhouse" anywhere

#

it's not done loading

lean kindle Apr 12, 2023, 3:39 PM

#

i right. i launched ksp in an accident and worked with full log

lean kindle Apr 12, 2023, 3:42 PM

#

quaint jasper it's not done loading

📎 KSP.log

quaint jasper Apr 12, 2023, 3:43 PM

#

well, there are 4 patches in total:

 8217 [LOG 17:40:24.775] Applying update Benjee10_MMSEV/Patches/TAC/MMSEV_TAC_LS/@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport] to Benjee10_MMSEV/Parts/base_greenhouse.cfg/PART[Benjee10_MMSEV_baseGreenhouse]
 8270 [LOG 17:40:24.800] Applying update zMein Zeugs/Greenhous/@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport] to Benjee10_MMSEV/Parts/base_greenhouse.cfg/PART[Benjee10_MMSEV_baseGreenhouse]
 8397 [LOG 17:40:24.923] Applying update ThunderAerospace/TacLifeSupport/MM_AddLifeSupportModule/@PART[*]:HAS[#CrewCapacity[>0],!MODULE[LifeSupportModule]]:FOR[TacLifeSupport] to Benjee10_MMSEV/Parts/base_greenhouse.cfg/PART[Benjee10_MMSEV_baseGreenhouse]
 8576 [LOG 17:40:25.009] Applying update B9PartSwitch/PartInfo/@PART[*]:HAS[@MODULE[ModuleB9PartSwitch]]:FOR[zzzzzz-B9PartSwitch] to Benjee10_MMSEV/Parts/base_greenhouse.cfg/PART[Benjee10_MMSEV_baseGreenhouse]

#

the b9ps one probably isn't interesting, but it's worth looking at the TACLS one

lean kindle Apr 12, 2023, 3:43 PM

#

for what do i have to search in th MMcache?

quaint jasper Apr 12, 2023, 3:43 PM

#

the part name

#

the entire part config should be there

lean kindle Apr 12, 2023, 3:44 PM

#

i cant find it

#

nvm found it

lean kindle Apr 12, 2023, 3:46 PM

#

quaint jasper the entire part config should be there

ok in the MM config its the old value

quaint jasper Apr 12, 2023, 3:47 PM

#

dumb question, but did you forget to save your cfg patch after editing it?

#

because in the log file it doesn't include the AFTER part

lean kindle Apr 12, 2023, 3:47 PM

#

nope. the sspx is in the same config but gets loadede

quaint jasper Apr 12, 2023, 3:47 PM

#

it's not the same patch you showed here

lean kindle Apr 12, 2023, 3:48 PM

#

looks like i had the after deleted

lean kindle Apr 12, 2023, 3:51 PM

#

quaint jasper it's not the same patch you showed here

added :AFTER[Benjee10_MMSEV], no change

📎 KSP.log

#

@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]:AFTER[Benjee10_MMSEV]
{
@OUTPUT_RESOURCE:HAS[#ResourceName[Food]]
{
@Ratio = 0.00001925
}
}

#

also if i edit the value in the benjee patch manually the manual edit gets applyed

quaint jasper Apr 12, 2023, 4:06 PM

#

OH

#

we forgot about the TacGenericConverter module

#

the @OUTPUT_RESOURCE node has to be inside @MODULE[TacGenericConverter] {}

#

you had that in the first version but removed it

lean kindle Apr 12, 2023, 4:08 PM

#

quaint jasper the @OUTPUT_RESOURCE node has to be inside @MODULE[TacGenericConverter] {}

@PART[Benjee10_MMSEV_baseGreenhouse]:NEEDS[TacLifeSupport]:AFTER[Benjee10_MMSEV]
{
MODULE[TacGenericConverter]
{
@OUTPUT_RESOURCE:HAS[#ResourceName[Food]]
{
@Ratio = 0.00001925
}
}
}

#

so?

quaint jasper Apr 12, 2023, 4:08 PM

#

need @ before MODULE

lean kindle Apr 12, 2023, 4:09 PM

#

right

quaint jasper Apr 12, 2023, 4:09 PM

#

but yeah that looks right

lean kindle Apr 12, 2023, 4:11 PM

#

yes. it works

lean kindle Apr 12, 2023, 4:11 PM

#

quaint jasper but yeah that looks right

thx

lean kindle Apr 12, 2023, 4:23 PM

#

quaint jasper but yeah that looks right

semse like the sspx patch wasent working

#

@SSPXR-ROOT-TACGREENHOUSE:NEEDS[TacLifeSupport,PlanetarySurfaceStructures]:AFTER[StationPartsExpansionRedux]
{
@MODULE[TacGenericConverter]
{
@OUTPUT_RESOURCE:HAS[#ResourceName[Food]]
{
@Ratio = 0.0000333927083
}
}
}

#

📎 KSP.log

quaint jasper Apr 12, 2023, 4:50 PM

#

well, you have a MODULE patch inside something that isn't a PART

lean kindle Apr 12, 2023, 4:52 PM

#

yes, how do i handle that?

quaint jasper Apr 12, 2023, 4:53 PM

#

look at your other patch that worked

lean kindle Apr 12, 2023, 4:54 PM

#

so i have to patch all 4 parts invidual.

quaint jasper Apr 12, 2023, 4:57 PM

#

Not necessarily

#

you can do @PART[a|b|c]

#

but if they have different ratios..

#

you can do math like @Ratio *= 5

lean kindle Apr 12, 2023, 5:02 PM

#

quaint jasper you can do math like @Ratio *= 5

that would increase the output by five, right

#Module Manager Patch