#Weather Registry / Weather Tweaks / mrov

1 messages Β· Page 26 of 1

viral pollenBOT
viral tree
#

🐐

drowsy willow
#

i did not check correctly and the update went live just now lmaoooooooo

abstract pivot
#

okay i was wondering why my nuget was taking its time

drowsy willow
#

oopsie 🀭

azure dirge
#

so... when you say "breaking change", what would be the thing to turn off to keep it from breaking an existing run?

drowsy willow
#

it's breaking if your code references those

#

which - for people just using Registry as-is - will not change anything

thorny salmon
#

no color?πŸ˜”
more seriously, should i be concerned about any of these changes that i dont even understand what it means

drowsy willow
#

i'll have that in the next one πŸ₯Ί

thorny salmon
#

Color hype train is real

viral tree
jade field
#

wait now that I think about it, this whole system is flawed because most of the moons have a different number of possible weathers so the weights of things will be thrown off

#

thought this can be semi fixable if I do the weights per moon instead

jade field
drowsy willow
#

it makes the clear weather rarer so it has the same % chance of happening everywhere

jade field
#

hrm

#

does it scale the % chance per moon or just globally to try and average it out between all of the moons?

#

oh also- if I used the moon specific weights, would that override the weather to weather weights?

#

so if I have a moon weight of 200 for rain, and a rain to rain weight of 50- what gets prioritized?
I wish there was a way to set weather to weather weights per moon.

rare sun
#

mrov sir i wanted to ask, now with this amazing beautiful astonishing update, do we need to worry about the config files? do we need to save them and regenerate or are we good?

drowsy willow
#

I wish there was a way to set weather to weather weights per moon.
that would be a MESS to make a clean configs for

#

soooooo i'm not thinking about adding that yet

drowsy willow
#

so no more regenerations

jade field
#

well I guess it would still be a mess regardless how it's done

#

could maybe have the moon specific configs be a separate file?
idunno I don't know enough to really suggest how things should be done

drowsy willow
#

i will add that to my todo

#

but i think it's gonna be neither quick nor clean to achieve that

light furnace
#

Is this normal? (I couldn't load into the moon. This happens commonly with the latest versions.

abstract pivot
#

reloading lobby

drowsy willow
drowsy willow
abstract pivot
#

idk i didnt test it more than once, i just opened up the lobby, exited, and got that error

#

i might've not rejoined the lobby, dont remember

drowsy willow
#

alrighty

#

will check

#

oh what the fuck is going on

drowsy willow
#

WeatherRegistry 0.7.2

  • fixed weather objects being destroyed when leaving the lobby (thanks: @abstract pivot , @light furnace !)
scenic zephyr
#

πŸ‘

abstract pivot
#

nice

ebon nimbus
#

okay so I want to change it so the weather is what makes scrap more valuable on my moons

#

and LQ says that the default scrap value multiplier of each moon is 0.4 (so I guess a scrap that has 100 value by default in the game is going to be worth like 40 in the game)

#

I'd like to know if I change the scrap value multiplier of Eclipsed weather to 1.5 for example, is that going to overwrite the scrap value multiplier of the moon (so a scrap that has 100 value by default going to be 150 on the moon) and change it to 1.5, or is it going to change the scrap's value after the 0.4 already affected it (aka if a scrap has 100 value by default, and would be worth 40 without weather, it's going to be 90)? And if it overwrites the moon's scrap value multiplier, then how does it work when there are 2 weather effects at once? Is it going to use their multiplier average?

drowsy willow
#

I'd like to know if I change the scrap value multiplier of Eclipsed weather to 1.5 for example, is that going to overwrite the scrap value multiplier of the moon
yes

#

Registry's default multipliers are both set to 1

#

under the hood it's still using 0.4 as the "base" one, but it's easier to do math having 1 as the base

#

And if it overwrites the moon's scrap value multiplier, then how does it work when there are 2 weather effects at once? Is it going to use their multiplier average?

WeatherTweaks "calculates" the "average" it should use based on the current weather settings

ebon nimbus
#

ohh okay

#

thanks

drowsy willow
ebon nimbus
#

bruh

#

I assumed something LQ says is worth 100-250 would be like 40-100 in the game thanks to that

abstract pivot
#

Yeah that's completely right

#

The numbers we have in editor are all multiplied by 0.4 by default

ebon nimbus
drowsy willow
#

it's pain

ebon nimbus
#

wait so does that mean if I change the multiplier to 0.8 in the weather config is it going to ultimately make scrap worth less than if I leave it 1 or make it worth more

abstract pivot
#

Depends on if the default mrov set is 0.4 or 1

#

Just check the default value and multiply that by whatever Multiplier you want

drowsy willow
abstract pivot
#

So your default is 1

ebon nimbus
#

okay I see I think I get it now then

drowsy willow
ebon nimbus
#

thank you

drowsy willow
#

cause it's easier to operate than calculating decimals

scenic zephyr
#

0.4 vanilla=1 mrov 0.6=1.5

thorny salmon
#

@drowsy willow is that ok if i do this every frame ?

drowsy willow
#

what are you doing

#

i mean

#

it's gonna be a bit expensive to do that every frame

#

why not WeatherManager.CurrentEffectTypes.Contains(<your type>? πŸ˜…

thorny salmon
#

i guess yeah, but i still need to know that every frame

drowsy willow
#

do you need to check that for a specific effect or for all present?

abstract pivot
#

you can check when weather changes

manic cobalt
thorny salmon
#

I need that info for a patch that applies every frame

abstract pivot
#

mrov does have an event for that

#

you definitely dont need to be redoing that every frame

drowsy willow
#

if you need to check one effect for enabling, use Weather.Effect.EffectActive

abstract pivot
#

yeah it does depend what you're trying to do

drowsy willow
#

if you need to check all of them, it's gonna be faster to add listener to EventManager.WeatherChanged(SelectableLevel level, Weather weather)

thorny salmon
#

Yeah basically, im just checking if 1 weather is active at any time for a patch in TimeOfDay.Update, how do i access that specific weather with Weather.Effect.EffectActive ?

manic cobalt
#

yeah but you can cache that result

drowsy willow
#

to get a specific Weather object use ConfigHelper.ResolveStringToWeather(string name)

#

and then get it's Effect

#

and field EffectActive πŸ˜‡

drowsy willow
thorny salmon
drowsy willow
#

don't put that into Update lol

#

resolve the string early, cache the result, perform property check in Update

manic cobalt
#

cachedResult;

void ThingThatRunsWhenWeatherChanges
   cachedResult = newestValue;

void UpdatePatch
    if (cachedResult)
        doThing

something rather

thorny salmon
#

ah yeah ok

drowsy willow
#

since the Weathers don't get replaced/removed until you leave the lobby

thorny salmon
#

okkk

drowsy willow
#

you can resolve it once everything is initialized

#

and just check for changes of that

#

πŸ˜…

thorny salmon
#

fiou ok, ill do that

#

Thanks πŸ™Œ

manic cobalt
#

in particular btw the thing that you ideally wanna avoid in update here is making new strings since at such a constant rate the memory allocation of constantly messing with strings can add up

drowsy willow
#

yeeeah

thorny salmon
#

Thats what i was wondering, i rarely do patch in update but for this one its the first time im checking something with string allocation etc and since this will run each frame i wanted a better solution, but i think the cached version will do just fine

drowsy willow
#

oh, absolutely

manic cobalt
#

when it doubt
do thing less

drowsy willow
#

reference and store everything before that, only perform the check in update

thorny salmon
#

Yep thanksπŸ€—

drowsy willow
#

mayhaps

queen ingot
#

update? big update adding 20 new weathers pog?

ebon nimbus
#

can we have wildfires that burn all loot bugs outside

drowsy willow
#

noooooo i'm not updating this mod for now πŸ˜…

lapis fractal
#

wait

#

why did you say "this mod"

#

Is there another mod your updating? Robot

drowsy willow
#

🀐

#

noooooooooooooooooooooooo

lapis fractal
#

you forgot to put the new Weather 6 weather you've been working on up there. Smh always so forgetful

#

Jokinggg

abstract pivot
severe pelican
#

I forgot the ship charger existed until I saw that mod in the ss lowkey

#

I've never used flashlights

#

It's just occured to me that if I can light up corridors I may get lost less often

#

Maybe I will consider flashlights

nimble ruin
#

Landed on the moon with any weather on it, got back to orbit and I can't pull the lever.

Landing on the moon without any weather and going back to orbit doesn't have that issue.

I have Hybrid chosen in cfg.

[Error  : Unity Log] ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
Stack trace:
System.Collections.Generic.List`1[T].get_Item (System.Int32 index) (at <787acc3c9a4c471ba7d971300105af24>:IL_0009)
WeatherRegistry.Algorithms.HybridWeatherSelection.SelectWeathers (System.Int32 connectedPlayersOnServer, StartOfRound startOfRound) (at ./Algorithms/HybridAlgorithm.cs:65)
WeatherRegistry.Patches.SetPlanetsWeatherPatch.GameMethodPatch (System.Int32 connectedPlayersOnServer, StartOfRound __instance) (at ./Patches/SetPlanetsWeather.cs:61)
(wrapper dynamic-method) StartOfRound.DMD<StartOfRound::SetPlanetsWeather>(StartOfRound,int)
(wrapper dynamic-method) TimeOfDay.DMD<TimeOfDay::OnDayChanged>(TimeOfDay)
(wrapper dynamic-method) StartOfRound.DMD<StartOfRound::PassTimeToNextDay>(StartOfRound,int)
(wrapper dynamic-method) StartOfRound+<EndOfGame>d__285.DMD<StartOfRound+<EndOfGame>d__285::MoveNext>(StartOfRound/<EndOfGame>d__285)
UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <e27997765c1848b09d8073e5d642717a>:IL_0026)
scenic zephyr
#

vanilla moons with modded weathers are working

nimble ruin
#

yeah

drowsy willow
#

thanks for the find - i'll try to get it fixed asap

thorny salmon
#

I found an issue but im not sure if it's from WR or Imperium, but now changing the weather while already landed on a moon with the Imperium menu change the weather of the actual moon, even if the moon you wanted to change the weather from is another moon different from the actual one, I do this only on a few occasions so idk which version of which mod has caused this issue, but this was working well in the past that I know for certain

slow maple
#

yeah Mrov noticed that a few days ago while looking at my moon

#

I thinkkk

thorny salmon
#

oH yeah i don"t think i have the latest version on my dev environment, my bad WATCHOUT

drowsy willow
#

no worries 🀭

thorny salmon
#

I have a question

abstract pivot
#

I dont have an answer πŸ˜”

thorny salmon
#

If a remove a weather myself with code, so it's no longer active on the moon (entering and exiting the facility does not respawn it since it's gone)
Then if a certain someone provoke a time shift effect (time is going back by several hours), is it normal that the weather is coming back ?

#

cause apparently it is possible but im surprised its real

thorny salmon
thorny salmon
#

idk

drowsy willow
#

WeatherRegistry 0.7.3

  • fixed an issue with HybridAlgorithm using an empty list of levels (thanks, @nimble ruin !)
abstract pivot
drowsy willow
#

which ones

abstract pivot
#

the ones where you dont recreate the weather effect if it already exists

drowsy willow
#

did you test it further?

#

cause i'm still waiting for those results to push the update

#

πŸ˜…

abstract pivot
#

ight ill test with the latest zip you gave me ig and let you know what else might be missing, assuming you implemented the changes i mentioned

drowsy willow
abstract pivot
# drowsy willow

inside that if statement you need to do:
entry.Value.Effect.name = entry.Value.Name

#

oh and ofc you need to run this code

#

but other than that its all good and fine

drowsy willow
#

alrighty, pushing the change

abstract pivot
#

thanksies

abstract pivot
#

also it would be nice if you did Assembly.GetCallingAssembly and put that into an internal or public field inside of Weather so we know which mod registered what weathers, though i know the impl might be a little more complicated if it's coming from an editor registeration

drowsy willow
#

yeah, i don't think it's gonna work with the editor components

abstract pivot
#

technically you could have em fill in a field for ModName but yeah

drowsy willow
#

i'll think about it

drowsy willow
#

oh the update didn't go through fuck

drowsy willow
#

once again i've tried pushing the thing that works locally but doesn't on the server

#

oopsie

thorny salmon
#

colors ? πŸ₯Ί

drowsy willow
#

my plans right now is to:

  • finish my project
  • work on terminalformatter fixes
  • registry update (and colors)
thorny salmon
#

Ye no problem take your time πŸ™Œ

proud zenith
rare sun
ancient depot
drowsy willow
thorny salmon
#

I found a bug when using Weather Tweaks
The weather was None > Stormy and when the weather changed there was no rain, there was just thunder bolts
Entering and exiting the facility did not fix the issue

#

However, i dont have my logs enabled rn so maybe its something more complex i cant tell

#

No, its not that sorry
Entering and exiting the facility did fix the issue but when someone was already outside it was not rendered correctly

drowsy willow
#

crazy 😭

#

i'll take a look

thorny salmon
#

i also found other issues related to "weather being destroyed but not really", ill take a look more into that and send you a detailed report

thorny salmon
#

Ok i wasnt able to reproduce this #1203871322841808906 message in my test profile so its most likely a mod conflicting issue, but i will not share my profile in which it happened since its 150 mods so its better not to dig this one, I'll see if it happens again next time im playing with friends

thorny salmon
#

So, the weather is Majora initially, the crew land on a moon
Everything is fine for now
Then the crash sequence begins and someone plays Oath to order, the animation happens, Majora is destroyed and removed from the moon
This code is used to remove the weather :

#

Then in my hope of testing stuff, I go inside and outside the facility, still nothing breaks the weather is None since Majora is no more, ok nice
Then I play Song of storms, which is supposed to add Stormy as a combined weather to the moon, this works but Majora is also spawning back... which is not expected

#

btw Majora explodes instant so I die 5s later but yeah

#

in this case, Stormy was added as a combined weather effect with this code :

#

So either EffectEnabled = false did not work as expected and there is some cache that still exists that store the weather in memory
Or AddWeatherEffect() is doing something wrong
Or something else but i cant tell whats going on besides these 2

#

Im using the latest WR and WT version this time so i know its not a me problem lol

#

This issue #1203871322841808906 message that i reported last time, experienced by @viral tree as they said to me, is very likely the same problem as the one i just reported

#

||looks like there is very few people that actively do insane weather manipulation like that, no wonder no one noticed this issue before πŸ˜‚ ||

drowsy willow
#

that is indeed crazy

#

i'll get back to you when i'll work on fixing this, thank you for the report πŸ˜‡

thorny salmon
viral tree
#

oh PikaHoldIN

scenic zephyr
#

It looks like the command "lobby load" from lobby control isn't compatible with your mod

drowsy willow
#

not again 😭

lunar glen
#

πŸ™ƒ

abstract pivot
pallid sandal
#

so from my understanding, WeatherTweak's weather combinations seem to work, but the whitelist and blacklist in WeatherRegistry does not work, e.g. experimentation has rain, stormy and flooded. Blacklist experimentation under rainy + stormy + flooded, the triple weather still appears. but if you blacklist rainy or stormy or flooded on experimentation, rainy + stormy + flooded no longer appears on experimentation

drowsy willow
abstract pivot
#

uh idk if there was anything more really, everytime i load into a save with my test profile it just errors like that

drowsy willow
#

weird

#

does this happen without dawnlib present?

#

oh what the hell why is the weather name an empty string

#

I can change it to TryAdd, but why is it happening now

abstract pivot
#

Dunno, I'll have to test later without anything other than WR but I might have an idea thinking of it now

#

Which would mean it's something in my dev version of cr

#

I'll let you know if it is

drowsy willow
#

okie

abstract pivot
#

I was changing my impl for weather registration and I think I had multiple weathers with the same name, which was an empty name

drowsy willow
#

that would trigger it, yeah

abstract pivot
#

I would probably purposefully throw if your register method sees a weather with an empty name

drowsy willow
#

honestly fair

coral ocean
#

heeeeeeeeeeeey

#

something is uh

#

wrong

#

with WeatherRegistry

#

I think its Registry

#

but its somehow messing with the ability to land on moons

#

especially with TerminalFormatter enabled

abstract pivot
#

you have an old version of mrovlib downloaded

rare sun
#

mrov

#

is your turn.

drowsy willow
#

for what

rare sun
#

nah im joking its just that im going to devs and asking them questions about their mods hehe

#

idk if you mind

drowsy willow
#

sure

rare sun
#

why did you decided to make weatherregistry?

#

:0

drowsy willow
#

hmm

#

i wish i had a simple answer

rare sun
#

really?? :0

drowsy willow
#

give me a second, i'll send an answer πŸ˜…

rare sun
#

oh okok haha im sorry

#

didnt expect it to be so crazy hehe

drowsy willow
#

WeatherRegistry was my attempt to:

  1. consolidate all weather-related mods that were out at the time:
  • WeatherTweaks for weather weights and changing selection algorithm
  • MeteoMultiplier/WeatherMultipliers for changing scrap rates
    and probably others I'm forgetting right now
  1. Add a way for modders to add their own weather types - this came out a few months after LLL was supposed to introduce weather creation; at some point I've decided to try doing it myself

  2. I wanted to divide WeatherTweaks into a few manageable chunks, which (at that point) was really needed

#

and - looking at it now - I feel that I could do the same thing again: divide WR into a few distinct chunks that each does their own thing

#

there's still a lot in my backlog/todo list regarding the development

#

and creating WR was an attempt to unify the modding scene to use one coordinated standard, which did not happen

#

and - in all honesty - my lack of experience regarding Unity, modding and everything is obvious in retrospect

#

but I've tried (and still am) to create the most useful tool for that specific purpose

rare sun
#

i've been seeing that in the modding scene

#

like wanting to unify everything into 1 mod

#

its really cool, tho makes development way more crazy, and sometimes having everything be in one place can be hard, specially when the dev doesnt wanna keep supporting or smth similar

drowsy willow
#

true

rare sun
#

but, on the other hand, what these mods have acomplish are astonishingly cool

drowsy willow
#

having 2 more specialized things is better than 1 general one

rare sun
#

without you, there would be no weather mods

drowsy willow
#

that also depends on # of people working on it

rare sun
#

without LLL/ LE, no moons and interior

#

etc

#

and now with dawnlib too

drowsy willow
#

yes and no

rare sun
#

maybe someone else would have done it

drowsy willow
#

at some point someone insane enough would've made it

rare sun
#

but it doesnt help seeing it that way, when it already is there

#

we already have that mad man hehe

drowsy willow
#

and i've seen quite a bunch of people saying that this mod "does too much"

#

which is true

#

but i don't see the point in separating it right now

rare sun
#

its hard for me to understand the issue in have too much

drowsy willow
#

I agree that it could be split up into:

  • adding modding weathers
  • weather multipliers control
  • weather selection control
abstract pivot
#

100% I would've added weather's into my api if mrov hadn't

drowsy willow
#

and i'm planning on adding something to push it into that direction

#

but i'm not known for working fast πŸ˜…

abstract pivot
#

And I might still in a way that's compatible, I hate the editing of enums and stuff that's just an icky implementation, which I know comes from LL 😭

abstract pivot
rare sun
#

xu really wants to make a monopoly

abstract pivot
#

I'd do moons and interiors too but no point while LLL exists just fine

rare sun
#

all mods will be coderebirth, this is not a joke anymore

abstract pivot
drowsy willow
#

honestly without that specific enum hack i wouldn't have known how to do this

#

and the implementation would be even worse than that πŸ˜†

abstract pivot
#

I just don't like the current options available in modding, which is why anyone creates apis or libs

rare sun
#

so idk

#

its hard to appeal for everyone

abstract pivot
#

Dont care

#

In the least respectful way, this is a non problem

drowsy willow
#

the "mod count too high" issue is a self-perception issue

#

it's not your responsibility as a modder to care about that

rare sun
#

the number of mods?

drowsy willow
#

yes

abstract pivot
#

Yeah

rare sun
#

yeah i completely agree

#

im just kinda confused

#

i thought you had an issue with lethallib adding monomod whatever as a dependency Xu haha

abstract pivot
#

Yeah because it's a pointless dependency

abstract pivot
#

LethalLib doesn't use mono detour

drowsy willow
#

let's not open that can of worms πŸ’€

abstract pivot
#

Lol

rare sun
#

i mean yeah im sorry

abstract pivot
#

All I'm gonna say is that whole thing is just a way for the dev to get free downloads

rare sun
#

was just confused by it, like contradicting opinions

#

no need to talk bout it

drowsy willow
abstract pivot
#

Yeah not like thunderstore pays us πŸ’€

rare sun
#

ok back on topic, yeah Xu is cool and would have made it herself

#

but that doesnt mean you already did it mrov!

drowsy willow
#

at some point i've just decided to try it

rare sun
#

this mod is amazing and maybe its not perfect

#

but has let people create some amazing things

drowsy willow
#

i remember talking about implementing weathers with Batby in (i think) February April of 2024

rare sun
#

LEB is amazing, LegendWeather is amazing, and all of them are possible because of this mod

#

ok another question

#

what would you say was the hardest thing to make in weather registry?

#

to code, or to get it working, or whatever you felt was the hardest

abstract pivot
#

What line of code was the toughest?

#

What really took it out of you to write? Which one?

rare sun
#

Xu just talking to talk is amazing

drowsy willow
#

I definitely remember how badly the first few versions of Registry worked

#

in all fairness

#

i have no recollection of my work before the latest update πŸ’€

rare sun
#

haha thats fair

#

im so glad you made this, ty!

#

also

#

didnt know weathertweaks came before registry!

drowsy willow
#

the og

#

my initial idea for tweaks was so simple

#

i was so innocent back then

rare sun
#

wooow, i think i stopped playing like around that time haha

rare sun
#

what was it?

abstract pivot
#

Here's a real question, why bigger ship exist? The ideas fine but was wider ship too big for you?

rare sun
#

i also had that question, tho i can kinda understand it hehe

drowsy willow
#

at some point i've been discussing with @hidden pelican and @slow maple the modded ship options and decided that making the ship ~20% wider and ~5% longer would hit the sweet spot

rare sun
#

i honestly really like your big ship

drowsy willow
#

aaaand that was the catalyst

#

and my last month of working

#

my biggest issue was that it was not realistic to the world of lethal company

#

it was just too big

#

a company trying to get as much money to the contained monster wouldn't have built a flying two-story machine

abstract pivot
#

I imagine that's for like some bigger groups of lethal company though, cuz seeing lunxara have a lobby of 11 people on just a slightly bigger ship is goofy

ancient depot
#

I do think Wider ship is too big, I like it but it has compat issues with tons of moons cus moon devs balance around the Vanilla ship

abstract pivot
#

Speak of thr devil

rare sun
#

XD

#

that timing tho

ancient depot
#

I do think 2 Story Ship however will be great when it gets compat with Bigger Ship

#

cus I do miss the 2nd floor

drowsy willow
abstract pivot
#

Just... bigger 2 story ship??

abstract pivot
ancient depot
drowsy willow
ancient depot
#

which idk how she plans to do that

drowsy willow
#

ummm

abstract pivot
#

I mean I don't really see the point

ancient depot
#

but I believe in her

drowsy willow
#

please dont

abstract pivot
#

Me when I have 3 mods touching the same thing and I gotta dig around patching false random methods everywhere

rare sun
#

what i like about your ship is that is comfy enough to have more than the normal amount of people, while also not feeling goofy when people with smaller amounts, or alone

daring pivot
#

They wrote gullible on the

the wider ship

drowsy willow
rare sun
#

:0

drowsy willow
rare sun
drowsy willow
#

cause i do like the feel and simplicity of it

drowsy willow
#

that might've been the biggest mistake i ever made

rare sun
#

XD

daring pivot
rare sun
#

its so cool i love it

daring pivot
slow maple
daring pivot
slow maple
#

i don't run lobbies of 11 but I do run lobbies of like, 6

rare sun
#

tbf, Lunxara is like the only one that plays with more than 6 people xd

drowsy willow
slow maple
drowsy willow
#

i mean

#

from march '24 to january this year

#

πŸ’€

rare sun
#

oh wow

slow maple
#

also all 3 together doesn't even make sense. like. how do you do wider + bigger

#

just ignore bigger's model changes or smth?

rare sun
drowsy willow
#

i feel like my work is complete

#

other than adding compat for a few requested mods (and maybe catwalk lights) I'm done with it unless issues arise

daring pivot
rare sun
#

with the ship?

drowsy willow
#

this is the first mod i'm truly proud of and i can consider complete

rare sun
#

yeah 100% deserved too

drowsy willow
#

this was not meant to go that way

#

watch me break this

drowsy willow
#

😈

rare sun
#

its crazy how detailed bozo is

#

and yet ogopogo still going crazy greed

abstract pivot
#

Codewise there's a good chunk

#

But the moon's a circle

daring pivot
# drowsy willow watch me break this

Actually wait yeah I have to do it like that because it gives an array of a single weather with ' > ', instead of every weather it goes through πŸ’€

rare sun
#

it has code

#

that in itself is more than 99% of moons hehehfebskfgbirhbf

abstract pivot
#

Yeah but if I'm just skipping all the code by walking for a moon straight line from ship to door it's not really impressive

rare sun
#

so you think the moon should make players do smth so the code doesnt feel unecessary?

daring pivot
daring pivot
#

I do like driving Cruiser on it but it was designed even before the Crusier existed so it was not intentional plink

rare sun
#

idk, even if the gameplay is straight line, all the things the moon has makes me wanna take that line differently idk

#

the balloons are so cool

#

and the weather effect

#

first time i played and it got late my jaw dropped

#

the animation is so coooool

#

i usually NEVER explore moons because i dont feel like its worth it, but bozoros had so many things it literally made me wanna explore the entire moon

#

i love itttt

#

so sillyyy

daring pivot
#

I do love it from a visual design point, it be why I revived it + expanded on stuff plink

rare sun
#

yesss

abstract pivot
#

Without a reason to really explore it for that stuff I never really tried to

rare sun
#

fair

#

everyone sees it different

#

for me, the moon invites me to try new things

#

doesnt force me, it calls me hehehe

#

same with all my friends

#

but i can see that if you ignore everything but the core gameplay, it can be a bit underwhleming

#

WAIT

daring pivot
rare sun
#

ok yeah

drowsy willow
#

i see the appeal of people doing Q&A's now 🀭

#

this shit is fun

drowsy willow
#

thanks for bringing me down the memory lane

rare sun
#

idk i would love to do more but my anxiety kills me

drowsy willow
#

no worries

#

πŸ˜…

daring pivot
#

We be a little anxious

rare sun
#

truth nuke

#

i just i would love to ask more devs and more questions but i fear they will find me annoying hehe

#

im like

#

ragatha

drowsy willow
#

don't worry about it

rare sun
#

hehe ty

#

i saw what you deleted

#

also another question mrov

#

the same, but for terminalformatter, why did you make it?

drowsy willow
#

so I've made it cleaner

#

and then the bloat happened

#

🀭 🀭

daring pivot
#

The bloatβ„’

drowsy willow
#

THE BLOAT ⚑

rare sun
#

:0 the bloat?

#

what happened

#

im scared

daring pivot
drowsy willow
#

I'd be more than happy to talk more about it

#

i have to sleep πŸ˜”

rare sun
#

haha its okay

#

i should go to sleep too

#

what time is it for you?

daring pivot
rare sun
#

mrov is german???? :0

daring pivot
#

||Idk I made it up greed||

rare sun
#

ok well gn mrov, have a great night sleep

#

and as always

#

good morning Kiszony greed

abstract pivot
#

Mrov a femboy so take a guess

rare sun
#

usa?

daring pivot
rare sun
abstract pivot
rare sun
#

so Kiszony a femboy too? :0

slow maple
abstract pivot
#

Yeah it is

ancient depot
daring pivot
viral tree
#

-# go to sleep

thorny salmon
severe pelican
#

It's all weather related so

ancient depot
thorny salmon
#

I just found a massive issue

#

LegendWeathers crash with NRE on WeatherDefinition during the mod initial loading phase (this happens with the current release of the mod) when LegendWeathers is installed alongside WeatherRegistery (and their dependencies) with no additional mods installed

#

But when LethalLevelLoader is also installed, then the crash is fixed

#

this is still a thing btw but i know you were working on BiggerShip during the last days #1203871322841808906 message

#

@drowsy willow

abstract pivot
#

send a log zigzag greed

thorny salmon
#

Wait no it's not LethalLevelLoader it's FixPluginTypesSerialization
10 mods: 0199a079-4bc1-4a5e-b3f9-767adc89da61 (disable FixPluginTypesSerialization to see the issue)

rare sun
#

Im getting scared of that mod

thorny salmon
abstract pivot
#

oh FixPluginTypesSerialization is definitely a mod that a lot of other code-based mods need, does mrov not depend on it?

thorny salmon
#

No

abstract pivot
#

anytime you use [Serializable] on a class you need that mod so it actually shows up in editor otherwise all the values are null

abstract pivot
#

so mrov should probably have it as a dependency on thunderstore if he does do [Serializable] on some classes

abstract pivot
#

screenshot me this class

#

oh actually its probably the ImprovedWeatherEffect

thorny salmon
#

ah yes

abstract pivot
#

then yeah both of those i think

#

ScriptableObjects and Monobehaviours dont need that serializable thing but pure classes like that do

thorny salmon
#

ok pfiew so it really is a mrov issue, glad its not my fault

#

also happy its an easy fix @drowsy willow

thorny salmon
abstract pivot
#

probably yeah lol

thorny salmon
#

oh boy oh boy

restive pilot
thorny salmon
#

but still

restive pilot
thorny salmon
#

cmon dont say that

restive pilot
rare sun
#

I also found out that enemyskinregistry needs it too

#

But doesnt have it as a dependency

drowsy willow
#

I wouldn't have found this

thorny salmon
#

looks like a weather is being registered but there is an issue with it idk

abstract pivot
#

i've been seeing that error too

thorny salmon
#

wesley just updated his mod, it could be that

rare sun
#

stormy thing is his yeah

drowsy willow
#

did you add a stormy variant with stormy script plink

drowsy willow
faint sinew
#

(I got rid of it)

drowsy willow
#

okie 🀭

west hemlock
#

That probably was asked before but since there is small but steady grow of weather mods, any chance for toggleable option like:
At the start of session/quota, all weathers weights set to 0/new list is created. List populates with X weathers and their weight restored, or set to 1, whatever, and rest gets disabled until new session/quota.

Similarly like "Selenes Choice" does that for moons or "CycleRandomizer" for interiors. I feel like that would make each run even more unique without the need to disable/enable specifics manually.

drowsy willow
#

That is a fun idea

#

I'll think about implementing it

west hemlock
#

Glad to see you find it interesting 😌

ancient depot
#

@drowsy willow Cream if WR is still working

#

πŸ”₯

drowsy willow
#

is it?

ancient depot
#

Yes

drowsy willow
#

how

#

lmao

ancient depot
#

Testing a fixed build of LLL that pacoito worked on

#

shit's working

drowsy willow
#

that's amazing 🀭

nocturne lily
#

dang

ancient depot
#

Also Terminal Stuff can be fixed for now by disabling it's networking

nocturne lily
#

thats good

abstract pivot
#

I doubt it'll work for long if its not been updated

nocturne lily
#

is the LLL fix gonna be uploaded as separate like how LLL Fixed V50 was

nocturne lily
abstract pivot
#

I meant WR

azure dirge
#

LLL is only the root of the equation. several other variables will need to be solved for as well. namely, moons and interiors

#

of course, im just parroting the obvious

nocturne lily
#

oh nvm

slow maple
ancient depot
slow maple
#

please not again

daring pivot
robust dirge
#

wow paquito my savior

slow maple
#

te quiero mucho paquito

#

letal company necesita un heroe...

rare sun
#

Paco fixing every mod

daring pivot
#

I mean ideally it shouldn't be uploaded as a separate thing, it's also got da fixes in my pull requests greed

rare sun
#

True goat of lc modding

slow maple
robust dirge
#

he should just update it...........

rare sun
#

Maybe a patch mod that fixes it

#

True

daring pivot
#

I mean ye I wouldn't just yoink it and repackage it (AdvancedLevelLoader πŸ’€)

robust dirge
#

less headaches

daring pivot
#

I do respect da original work plink

nocturne lily
#

that being said it is permissively licensed

daring pivot
#

Ye

nocturne lily
#

so if nothing comes out of this then it could be uploaded as a fork as a last resort

slow maple
#

yeah

nocturne lily
#

ideally just having batby push it to main would be better though

robust dirge
#

let's hope batby accepts

nocturne lily
#

not as many dependency string issues

ancient depot
#

Seichi is broken though, any moon with networked objects is gonna need an update

rare sun
#

Paco our saivour only nerfed by its internet

daring pivot
#

SeichiAdditions dll does networking stuff for the marriage mechanic

ancient depot
#

LMAO

rare sun
#

So basically every wesleys moon...

ancient depot
#

Well Espira let me start landing

#

then just crashed

nocturne lily
#

some moons i'm thinking of will probably be ok

ancient depot
#

Oh maybe the radar contours actually?

#

The sprites prolly need redone on the new Unity build

daring pivot
nocturne lily
#

lunar lights will probably be fine cus i think it uses jll which already got updated?

#

wither will probably need a recomp

daring pivot
#

I'm still updating my library plink

#

There was a larger fish that needed frying

nocturne lily
#

zeranos is probably mega screwed

daring pivot
#

Journeys cannot be completed lmao

#

Appies ||or seeds|| won't be accepted greed

drowsy willow
#

it compiled and (hopefully) will work without issues

daring pivot
slow maple
#

fantastic news paquito

drowsy willow
#

paco you are a motherfucking hero

rare sun
#

Is paco god?

ancient depot
#

Okay so I located what was crashing the game when landing the ship

#

It's either LethalSponge or TME

#

disabled those both and it stopped

slow maple
#

tme?

ancient depot
#

TooManyEmotes

#

I suspect it might be TME more likely

#

cus there is a huge lag spike when you emote too

#

before even landing

#

but idk

azure dirge
#

reenable 1, test, disable the 1 and reenable the other, test

ancient depot
#

Ye

#

I'll be doing that later since I have a collab stream I'm about to do soon

thorny salmon
#

WeatherDefinition class is dead until FixPluginTypeSerialization is updated

nocturne lily
#

fpts 1.1.4 was pushed earlier but idk if anyone checked that it worked

thorny salmon
#

I heard from xu that it's still broken

#

and daxcess is working on fixing it

nocturne lily
#

dang

daring pivot
#

Oh weird I had serialized stuff workin for me with the latest FPTS

thorny salmon
#

oh i just saw the update from 3 hours ago, i was speaking about the last one

#

Maybe the last update is fine yeah

nocturne lily
#

yea i know 1.1.3 wasnt working i didnt know abt 1.1.4 though

thorny salmon
#

there is no changelog πŸ’€

nocturne lily
#

yea

drowsy willow
drowsy willow
#

praying that it works πŸ₯Ί πŸ₯Ί πŸ₯Ί

thorny salmon
#

I'll check later, I'm gonna sleep now 😴

thorny salmon
#

Ok, the last version is working just fine
@drowsy willow don't forget to add FPTS to the dependencies on the mod's manifest file next time you update this mod

drowsy willow
#

that'll go up with a lot of breaking changes

#

wish me luck

thorny salmon
#

Lmao good luck my friend

#

Have you had some time to check this btw ? #1203871322841808906 message

drowsy willow
#

let's pretend that didn't happen and check on new version 🀭

abstract pivot
drowsy willow
#

replacing TimeOfDay.effects with scriptableobjects

drowsy willow
#

fuck it i'm biting the bullet

queen ingot
#

yummy bullet

abstract pivot
#

Hmm I see

drowsy willow
#

i mean

#

it will be backwards-compatible

abstract pivot
#

Isn't it the enum you gotta replace though?

drowsy willow
#

but i don't know to what extent

abstract pivot
#

Or well, I assumed you'd be wanting to replace that

drowsy willow
#

the enum is (unfortunately) used in a few places in vanilla

#

which i'm not replacing with dynamic search/magic numbers

#

cause that's stupid

#

soooooo the enum stays and is being modified in the same way?

#

but not actually used?

#

something like that

abstract pivot
#

Have u started work on it? I'd love to talk about it and discuss a bit, I don't know how much better things would be if a serializable class was replaced with SO's (atleast that's what I'm understanding is happening)

drowsy willow
#

since i know you also wanted to do that at some point

abstract pivot
#

Ah I'm in class rn but I'd be down to talk about it anytime cuz we're not really doing anything in class lol

#

I've also wanted to mess with weather registration at some point yeah

drowsy willow
#

sure, i'll send you what i have

abstract pivot
#

Bet

#

I'll take a look, I can't do the weather stuff i would maybe do rn since you're actually still active and alive but I've been working on moons and interiors

drowsy willow
#

i've succumbed to temptation

abstract pivot
#

So let me know if there's anything on that end you'd like to see as well

drowsy willow
#

okie!

abstract pivot
#

Fucking double tap reacts

#

Anyway

restive pilot
#

Careful

#

That is a very scary tightrope to walk on

drowsy willow
#

i am having fun

#

none of those options work πŸ˜‡

daring pivot
#

Did you remove the netcode patching step from your plugin's Awake()?

#

I find it is only needed for NetworkVariables specifically for some reason

drowsy willow
#

i'm pretty sure πŸ’€

daring pivot
daring pivot
#

It just stops happening with the netcode patching step present for some reason

abstract pivot
viral tree
abstract pivot
#

Rpc's for registering is just flawed

#

Ignoring late joiners and stuff, if you register something on host you should be identically registering it on client etc so never needed to rpc anything

#

:p

daring pivot
#

Hmm fair

drowsy willow
#

maybe to sync the order or something like that

daring pivot
#

I guess I meant for like weather multipliers

#

But value is probably synced at start of round or something

abstract pivot
#

Oh stuff like that, honestly zeekerss probably only takes the hosts' value for that already

drowsy willow
#

since the spawns are networked

drowsy willow
#

it did not happen on old network-patch version

#

and the old code works on new unity version lmao

daring pivot
#

I dunno πŸ’€

#

It is mystery greed

drowsy willow
#

πŸ’€

drowsy willow
#

nothing works

#

fun

ancient depot
#

Registry works for me

#

Lol

drowsy willow
#

fun

ancient depot
#

Maybe try regenerating your FPTS config?

drowsy willow
ancient depot
#

This guy

#

Your error is relating to serialization

#

Do you not have this installed?

drowsy willow
#

if this fixes my issue i'm leaving modding forever

#

it did nothing

ancient depot
#

Damn

#

lol

drowsy willow
#

i just need to completely rewrite my networking from using NetworkVariables to NetworkLists

#

or find another way to serialize everything

#

since unity doesn't want to

ancient depot
#

I just wish I knew why it just works in my profile

#

XD

thorny salmon
viral tree
daring pivot
#

Could try adding the netcode patching to your Plugin's Awake() even if theoretically it's not needed and shouldn't be doing anything πŸ’€

#
        private static void NetcodePatcher()
        {
            Type[] types;
            try
            {
                types = Assembly.GetExecutingAssembly().GetTypes();
            }
            catch (ReflectionTypeLoadException e)
            {
                types = [.. e.Types.Where(type => type != null)];
            }

            foreach (Type type in types)
            {
                foreach (MethodInfo method in type.GetMethods(BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static))
                {
                    if (method.GetCustomAttributes(typeof(RuntimeInitializeOnLoadMethodAttribute), false).Length > 0)
                    {
                        _ = method.Invoke(null, null);
                    }
                }
            }
        }
#

This specifically

drowsy willow
ancient depot
#

Ahhhhh

drowsy willow
#

which uses new patcher and does this

daring pivot
#

Patching in public restrooms prank

hidden pelican
#

patches all over

drowsy willow
#

almost

thorny salmon
#

Aktywuj system Windows

drowsy willow
#

nie

viral tree
#

Aktywuj system Windows

drowsy willow
#

nie ma szans

viral tree
#

Embrace windows 11
embrace AI bloat

drowsy willow
#

Windows 10 will be my final windows distro

patent briar
#

Come join Linux :3

viral tree
#

Embrace windows 11
-# Przejdź do ustawień aby aktywować system Windows.

queen ingot
#

all hail windows 11 CatPraise

nocturne lily
#

Windows 11* is ok i guess
-# *windows 11 with recall, wifi sense, telemetry, ..., gamebar disabled

stark scaffold
#

@drowsy willow Is weather tweaks and weather registry v73 compatible.

daring pivot
thorny salmon
#

yeah the mods may have some small issues but the general behavior is working

drowsy willow
#

from what I've tested (and heard) there weren't any game breaking issues on v73

rare sun
dreamy garden
#

The only bug I've found in WR is typing "Gordion" and breaking the terminal

#

Aside from that, everything is working fine

drowsy willow
#

or simulate

coral ocean
#

Are the weather mods incompatible with any other mods by any chance?

#

Or any terminal mods specifically?

dreamy garden
#

And that ends up replacing ButteryFixes option that should route Gordion to the Company for some reason

stark scaffold
#

@drowsy willow

https://github.com/AndreyMrovol/LethalWeatherRegistry/blob/main/WeatherRegistry/WeatherRegistry.csproj
https://github.com/AndreyMrovol/LethalWeatherTweaks/blob/main/WeatherTweaks/WeatherTweaks.csproj

Both weather registry and weather tweaks use the outdated version of the netcode patcher, so wouldn't something break?

GitHub

A Lethal Company mod for controlling game's weather system. - AndreyMrovol/LethalWeatherRegistry

GitHub

Changes to weather system in Lethal Company. Contribute to AndreyMrovol/LethalWeatherTweaks development by creating an account on GitHub.

drowsy willow
#

don't know

#

if something breaks let me know

drowsy willow
stark scaffold
thorny salmon
#

so the mod is 100% compatible with v73 have no fear my friend

coral ocean
stark scaffold
thorny salmon
#

idk

robust dirge
#

mrov are you compatible with me or do i have to downgrade

drowsy willow
#

I might upgrade to match versions

robust dirge
#

aaaaa i see

#

needs testing then

restive pilot
drowsy willow
#

fish utilities?

restive pilot
coral ocean
#

Me needs helps

#

I know 110% it has to do with the weather

#

weather mods

#

or something

#

them conflicting with another mod or type of mod

#

wait a fuckin minute is it General Improvements?

stark scaffold
# coral ocean

Are you using the fixed version of Lethal Level Loader?

coral ocean
#

My Ultra Modded Modpack is still on v72

#

everything in here is v72

stark scaffold
#

oh

coral ocean
#

I am not touching any mod

#

until the majority AT LEAST is updated

ancient depot
#

Majority do be updated now

#

I ran a stable session today on V73 and the performance uplift is insane

coral ocean
#

I have 402 mods theres only 75 updated mods for v73

ancient depot
#

You could just test to see which mods specifically break

stark scaffold
coral ocean
#

Im just gonna keep it at v72 just incase

#

cuz I really don't wanna remove like

#

half the modpack

#

or 75% of it

#

I worked so hard on this modpack

#

configs, mods I find interest in and also a lot of getting it to work somehow

#

Anyways

#

Uuuuuh

coral ocean
#

I feel like

#

its GeneralImprovements because of it saying something about the mod

#

then directly after it says "GetWeatherRegistryWeatherName"

daring pivot
coral ocean
daring pivot
#

Yeah

coral ocean
#

Gotcha

daring pivot
#

It's trying to run a thing from WR that doesn't exist anymore

coral ocean
#

Hmmm

daring pivot
#

Or uhhh I guess it exists but doesn't match signature maybe?

coral ocean
#

well the creator probably ain't gonna keep it v72

#

so

#

Disable?

daring pivot
daring pivot
#

I thought it got like removed in later versions of WR or somethin

coral ocean
#

Okay so yeah

#

imma disable generalimprovements then

drowsy willow
coral ocean
#

Shameless promotion is so real

#

I wish I could share my content here

#

but im not classified as a content creator out in these here parts

drowsy willow
#

yet

coral ocean
#

Genuinely tho

#

that would be so fucking cool

#

If I could actually get this

#

or like

#

there is a way to get it

#

it would definetely motivate my ass to make more lethal videos

#

I have been meaning to anyways

#

Actually now I do wonder what it takes to get Content Creator role

#

tho Im not going to ask about it cuz uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuh I honestly don't know why but I won't hardy har har

drowsy willow
coral ocean
drowsy willow
#

there might be a way

coral ocean
#

wait a fucking minute

#

WAIUT

#

WAIT

#

Mrov

#

may I

#

connect

#

these dots for you

drowsy willow
#

sure 🀭

coral ocean
#

Have 750 followers/subscribers on your platform - 1.66K Subscribers

Have at least 1 video that is 15-20 minutes in length or a 1 hour live stream involving Lethal Company - All 11 of my Lethal Videos are well above 20 (4 of them being over an hour long)

YouTube or Twitch account must be connected to your discord account - It is!!!

#

Funnily enough

rare sun
#

welp, guess i'll have to finish editing my video then hehehe

coral ocean
#

my Fedoraversary day is actually just lethal!!

#

with it being

#

4 HOURS!!!

#

LETS FUCKING GO

#

see that mrov???

#

I just fucking power moved

drowsy willow
#

amazing πŸ”₯

#

you got it chief

rare sun
#

apply apply!

coral ocean
#

I outta apply right now

#

Im gonna!!

drowsy willow
#

nice πŸ˜‡

coral ocean
#

so I can't dm the bot-

ancient depot
#

Maybe try later then, bot is prolly down rn

coral ocean
#

eh its alright

drowsy willow
coral ocean
#

I'll do it after work tomorrow

#

technically today since its 1:01 AM lol

#

oh

coral ocean
drowsy willow
#

in text chat

#

wherever

coral ocean
#

I'll do it in general

drowsy willow
#

and the modmail app should pop up

coral ocean
#

BOOM

#

Made

#

now

#

I shall play the waiting game

#

in the meantime I will edit

drowsy willow
coral ocean
#

This means

#

I gotta step up my A-Game with my Ultra Modded Lethal vids

#

along with plenty more

#

it'll be hard to play with others on different downgraded versions of my ultra modded modpack cuz lethal isn't mainstream anymore and not a lot of people play it anymore

drowsy willow
#

it's gonna be difficult for now

coral ocean
nocturne lily
#

this 750 follower req cant be for real

coral ocean
#

but I'll find the right souls to enjoy my favorite game with

nocturne lily
#

lunx did not have that many when she got it

coral ocean
#

Maybe it was different then?

rare sun
#

Probably different i would guess yeah

nocturne lily
#

wish i got in on that whenever it was that low

rare sun
coral ocean
#

I can't believe i didn't get in on this sooner honestly

rare sun
#

You could still apply to junior i guess

coral ocean
#

I love Lethal to death

rare sun
#

Junior is kinda cool bc it helps make you more well known

#

Turtle has it

#

I think you could apply to that too

coral ocean
#

who Wawa?

rare sun
#

Yeah wawawawawa

coral ocean
#

wa wa wa wa wa wawa

#

wa wa wa

#

wa wa wawa

nocturne lily
#

wawawawawawa

coral ocean
nocturne lily
#

i probably should but i need to get my stuff together and stream consistently

nocturne lily
#

ya

rare sun
#

Both times i saw you streaming it was 2 different games hehe

rare sun
nocturne lily
#

i only do it on friday typically

#

but my modpack got giga fucked

#

so im not able to do it for a bit

rare sun
#

Sad

coral ocean
#

If I do actually end up getting it

#

Im gonna stream Ultra Modded Lethal

#

in celebration

#

Actually!!

#

Better idea!!

rare sun
#

Send it on #community-creations

coral ocean
#

Modded Lethal Company

||With viewers||

rare sun
#

Whenever you stream it

coral ocean
#

I w i l l

nocturne lily
#

playing with viewers is really risky in games with prox chat

rare sun
#

True

nocturne lily
#

stopped doing that when someone joined and spammed racial slurs

rare sun
#

Xd classic

#

I think it was pacoito

daring pivot