#Weather Registry / Weather Tweaks / mrov

1 messages Β· Page 12 of 1

drowsy willow
#

thanks πŸ˜…

abstract pivot
#

Current issues:
The features I suggested πŸ₯Ί

drowsy willow
#

i remember πŸ˜…

pulsar monolith
#

Ability to disable scrap amount and value modifiers on the weathers? Messes with lethal quantities

unique wraith
#

The weather to weather weights in the config being unintuitive and a bit backwards if you ask me

old stirrup
#

Yeah It feels like they don't do anything

gritty blade
#

Well weather weights configuration feels a bit confusing at first but that's it, also fog patch? πŸ₯Ί

gritty blade
#

I didnt find weather weight unintuitive though but that's me

unique wraith
gritty blade
#

But even that way, it works the way I set it up, for me

unique wraith
#

Yeah the way it's laid out currently is not intuitive at all, it could also use a real description in the config entry

gritty blade
#

like I got the right amounts of weathers and balance but I get it

gritty blade
unique wraith
#

Also the defaults are currently "incorrect" because mrov also thought it worked the intuitive way

abstract pivot
#

Am I the only one who saw the config and just knew what weather to weather meant

#

Like why would None@160 on the stormy category mean stormy to none

azure dirge
#

probably. i was baffled so i left it alone

drowsy willow
#

heard

#

will improve

unique wraith
#

It's just different compared to every other config and doesn't even explain that

devout charm
gritty blade
#

Yeah a bit fuzzy and couple tries and you got it working

drowsy willow
#

i'm gonna be honest

#

i have not investigated if i made my own system wrong

#

time to fix my mistakes

old stirrup
gritty blade
#

I had to change it personally

old stirrup
#

Is that in the same weatherregistry config file?

drowsy willow
#

difficulty multiplier is a WeatherTweaks feature

drowsy willow
#

fuck πŸ˜†

#

i've tried to debug what's going on

#

the table is actually in reverse

#

so the columns are "from" and the rows are "to"

#

πŸ₯²

#

that will be changed

harsh flicker
#

Since it was reversed

drowsy willow
#

so you defined weights for the weather based on previous weather

#

and I'll change it to define it for the next weather

#

oh god, I've made it so badly

harsh flicker
#

Pain

#

Yeah i thought that would be a list of weathers to go from based on whatever the current is
So 300 for clear
Thats how I was using it

#

This explains the endless meteor showers and eclipseds on moons without other weathers
They had like 300 clear

#

So in that case, i dont need to change my config then if the next update is gonna swap it around?

#

So Rainy@300 on the None config will now mean a weight for 300 to Rainy from Clear?

drowsy willow
#

new update will create new config entries

#

I'm not planning to move those automatically

#

but I'll make something to convert those easier

drowsy willow
#

finally

abstract pivot
#

Weather>weather weight?

#

Are u missing some logs? 😭

drowsy willow
abstract pivot
#

So how does it work now qs you intend? If I were to go into None section of ur config, and add MeteorShower@150, it's 150 for meteor shower after none?

drowsy willow
#

yeah

abstract pivot
#

Sick

drowsy willow
#

and download curseforge-build artifact

#

other planned/promised features will come in the following days πŸ˜…

abstract pivot
#

Bro I don't play the game wdym test

drowsy willow
drowsy willow
abstract pivot
#

Just don't forget to add my vanilla weathers feature kitty_sip, now I go sleep

pulsar monolith
drowsy willow
pulsar monolith
harsh flicker
#

For now i might as well redo it then Cri2

abstract pivot
#

you forgor

drowsy willow
#

forgor what πŸ₯Ί

abstract pivot
#

well ig first i should ask what would happen if u set the first to false

#

is it equal chance between all weathers?

drowsy willow
#

it's gonna use vanilla algorithm to pick weathers

#

and Registry's sync to sync those

abstract pivot
#

yeah see dats half the problem, the reason people think registry messes up weathers and makes em dominant is because vanilla doesnt have as many weathers as someone who has my mod on

#

like if zeekerss makes MORE weathers, you wouldnt see "none" as often

#

but people coulda just mimicked that by giving everything the same weight lol

drowsy willow
#

i get what you mean, but that's not exactly how vanilla picks it

abstract pivot
#

the solution we came up with was to change the weights on your end to reflect "vanilla" weights

#

is it not?

#

i thoughgt it was just random between all weathers

drowsy willow
#

vanilla picks the # of moons to set weather to, and then picks random one

#

so the chances are equal, but for the moons that are "picked" to have weather

#

that's one of the reasons weight system is hard to setup to "mimic" the vanilla feel

abstract pivot
#

ooooh

drowsy willow
#

let me get the code snippet for ya

abstract pivot
#

yeah please

drowsy willow
#

StartOfRound.cs

public void SetPlanetsWeather(int connectedPlayersOnServer = 0)
    {
        for (int i = 0; i < this.levels.Length; i++)
        {
            this.levels[i].currentWeather = LevelWeatherType.None;
            if (this.levels[i].overrideWeather)
            {
                this.levels[i].currentWeather = this.levels[i].overrideWeatherType;
            }
        }
        Random random = new Random(this.randomMapSeed + 31);
        List<SelectableLevel> list = this.levels.ToList<SelectableLevel>();
        float num = 1f;
        if (connectedPlayersOnServer + 1 > 1 && this.daysPlayersSurvivedInARow > 2 && this.daysPlayersSurvivedInARow % 3 == 0)
        {
            num = (float)random.Next(15, 25) / 10f;
        }
        float num2 = Mathf.Clamp(this.planetsWeatherRandomCurve.Evaluate((float)random.NextDouble()) * num, 0f, 1f);
        Debug.Log(string.Format("Weather chance: {0}; {1}", num2, num));
        int num3 = Mathf.Clamp((int)(num2 * ((float)this.levels.Length - 2f)), 0, this.levels.Length);
        for (int j = 0; j < num3; j++)
        {
            SelectableLevel selectableLevel = list[random.Next(0, list.Count)];
            if (selectableLevel.randomWeathers != null && selectableLevel.randomWeathers.Length != 0)
            {
                selectableLevel.currentWeather = selectableLevel.randomWeathers[random.Next(0, selectableLevel.randomWeathers.Length)].weatherType;
            }
            list.Remove(selectableLevel);
        }
    }
abstract pivot
#

what i thought was happening was this:
none: 100 weight
stormy: 100 weight
eclipsed: 100 weight

vanilla^

none: 100 weight
stormy: 100 weight
eclipsed: 100 weight
meteorshower: 100 weight

custom^

Therefore less chance of getting none

#

my solution was to mimic vanilla by doing this:

none: 100 * something depending on the number of custom weathers for weight
stormy: 100
etc

#

but if the selection is different then ig that wouldent work

abstract pivot
#

i mean it clearly appealed to people so he MUST be doing something right πŸ˜‚

drowsy willow
#
for (int j = 0; j < num3; j++)
        {
            SelectableLevel selectableLevel = list[random.Next(0, list.Count)];
            if (selectableLevel.randomWeathers != null && selectableLevel.randomWeathers.Length != 0)
            {
                selectableLevel.currentWeather = selectableLevel.randomWeathers[random.Next(0, selectableLevel.randomWeathers.Length)].weatherType;
            }
            list.Remove(selectableLevel);
        }
#

and

        float num = 1f;
        if (connectedPlayersOnServer + 1 > 1 && this.daysPlayersSurvivedInARow > 2 && this.daysPlayersSurvivedInARow % 3 == 0)
        {
            num = (float)random.Next(15, 25) / 10f;
        }
drowsy willow
abstract pivot
#

could be that yeah

drowsy willow
#

not necessarily that it's the "right" way, but the way Registry works right now is just worse

#

so you can clearly point that out

drowsy willow
#

i could do it

#

so the weight of None scales with the amount of weathers?

drowsy willow
#

alrighty

#

i'll try to make that work

abstract pivot
ancient depot
#

Are you finally back bud?

abstract pivot
#

no

#

he's dead

drowsy willow
#

back to suffering

#

yes

ancient depot
#

Psh you were gone for months and were missed

abstract pivot
#

he was?

drowsy willow
#

to be fair

#

i've almost missed my deadline lol

abstract pivot
#

potato potata

drowsy willow
#

🀭

ancient depot
#

πŸ˜‚

drowsy willow
#

🀭 🀭 🀭

#

thanks

ancient depot
#

Yw XD I couldn't resist lol

drowsy willow
jade veldt
drowsy willow
abstract pivot
#

3 multipliers? wut

drowsy willow
#

oh the formatting

#

lol

#

it's 0,4 and 1

#

but formatted like crap

abstract pivot
#

lol curseforge build

drowsy willow
#

curseforge bleh

#

wait why is it packed like that lol

azure dirge
#

so... after i died and reentered a save file, some things were out of place. nothing out of the normal, just became annoying to deal with. so i made a new save file and started ordering gear again. the problem? typing in one modded item to order pulls up the price and delivery for a different one. after several trial and error typings, i learned that i am unable to access certain items that i need for my sessions

#

i think it's a terminal formatter thing?

wicked latch
#

Think it's an issue with current LLL release.

#

Is it being addressed? Not sure, the relevant code for items has been changed.

wicked latch
# wicked latch Think it's an issue with current LLL release.

Because rejoining a lobby in the same session does not refresh the terminal nodes (what you see after typing something for the terminal) and the buyable items list correctly, leading to other added items to take the place of the missing items.

azure dirge
wicked latch
#

Essentialy the first ever game lobby boot will work as intended. Any other game lobby boot after will not.

azure dirge
#

yea...

#

thanks, Zeekerssyoiled

abstract pivot
#

I dont think this is a zeekerss issue

azure dirge
#

ye i know. i just like bein a little shit

drowsy willow
#

interesting

#

I'll check it out

azure dirge
#

if it's lll, yer fine, boyo.

ancient depot
#

People got very annoyed with the Hoverboard doing that

#

Unfortunately LLL has a list of issues and bugs that Batby seems uninterested in fixing, like the bug with changing day speed and interior size changes not applying, which leads to having to use mods like CentralConfig and that has it's own problems if you toggle certain settings, it's come a long way though and Lass handles issues better than she used to which I'm glad to see

#

And I say seems uninterested cus they've given no official statement and I don't wanna assume anything or speak for them on their behalf

abstract pivot
abstract pivot
abstract pivot
ancient depot
# abstract pivot Rude

It wasn't meant to come off as rude though I knew it was gonna sound that way πŸ˜‚ more so meant to come off jokingly

#

Cus it was an annoying problem

ancient depot
pulsar monolith
drowsy willow
#

yeah, import it manually

harsh flicker
#

I remember this convo from a while ago but i stopped playing since then and only more recently started playing
How does WeatherTweaksBeta work with Registry? Would it add a bunch of combined weathers to the list of weathers for me to be able to set the scrap values + weighting individually?

drowsy willow
#

i don't remember exactly, but from what I can remember:

#

weathertweaks' weather combos use the weight of the "base" weather in the combo

#

so there's not an option to adjust it right now

#

but I'm in the middle of a rework for both mods, so there will be an option for that

ancient depot
#

The return of WeatherTweaks eh?

#

Can't wait to find all the bugs again

#

Time speed bug was definitely the funniest

harsh flicker
#

And also how does scrap value work with combined

pulsar monolith
#

Has anyone been able to test Turning off the scrap multipliers yet? Sorry I’ve been busy otherwise I would have tested myself!

harsh flicker
drowsy willow
harsh flicker
#

or

#

is it just a random number that kinda felt right for balancing?

#

No relation to the 0.4 default scrap multiplier at all, just coincidence

gritty blade
#

Not sure if it's intended but in changing weather containing "Foggy" eg. Foggy > None Foggy > Rainy etc. the fog is always the heavy fog and not like vanilla Foggy weather where it's randomly picking between light fog and heavy fog

gritty blade
pine fox
#

just wondering again when the scrap multipliers can be disabled so I can enable the mod without overriding some other multiplier sources

drowsy willow
#

the option for that is in the auto-builds, it will be in the next release

#

so probably after weekend

pine fox
#

Cool

latent sleet
#

not sure if this is due to registry/tweaks, but maybe it will be useful to reproduce the error. if you use the lobby control mod and type "lobby clear" command to restart the lobby, these weathers will start to appear afterwards :S

abstract pivot
#

You don't like 8?

#

My favourite weather

#

:<

#

Also welcome back

latent sleet
drowsy willow
#

I know about it, will try to get a fix ready πŸ˜…

drowsy willow
#

it might be hard to fix 🀭

bleak quarry
wicked latch
wicked latch
#

Also you're making a new logger everytime you use MrovLib's?

drowsy willow
#

umm

#

there's a possibility

wicked latch
#

There's also news from what I am seeing

#

Besides WeatherTweaks messages

drowsy willow
#

weathertweaks eww

drowsy willow
#

how's that?

abstract pivot
#

Bad

drowsy willow
#

πŸ₯²

robust timber
#

so is that a weatherregistry update or mrovlib?

#

bc i dont see any changelog details for mrovlib on thunderstore but i do have a new update available for it

ancient depot
#

Lib had to be updated first

robust timber
#

what will the registry update tweak? i havent been keeping posting in here

#

just weather config stuff?

ancient depot
#

It's a huge update from what mrov has said

#

Likely code cleanup among other fixes such as no longer overriding stuff if the scrap values are set to 1

#

He didn't spoil anything, just said it's a huge update he's been working on since the 3rd of October

harsh flicker
# drowsy willow every weather's multiplier is multiplied by 0.45, and the final multiplier is th...

Wait
So since its x0.45 on each weather....yet only 2 are combined at a time...
That means the multiplier will always be less than the weather on its own???
So if eclipsed is 1.5x scrap value
And flooded is 1.4x scrap value
Then for Eclipsed-Flooded, the value is gonna be (1.5 * 0.45) + (1.4 * 0.45)
So.... its... 1.305x Scrap value??? For Eclipsed-Flooded, which is more dangerous then either of them alone. You'd get more scrap value just going to Flooded than Eclipsed-Flooded?
How is this changed in the new version?

drowsy willow
#

but I'll definitely check what's happening with the multipliers

ancient depot
drowsy willow
#

I'm starting my 5-day working streak 😭

ancient depot
#

and yeah admittedly WeatherTweaks doesn't feel as essential as it used to, don't force yourself to work on it until you feel ready I know you hate it's code lol

drowsy willow
#

AND I have my bachelor's defense in the middle of that

#

fuuun

ancient depot
#

Mrov doing life stuff

drowsy willow
#

it's so surreal πŸ˜‚

#

WeatherRegistry 0.2.0

Please re-generate your configs!

  • merged #7: refactor: modify many LogWarnings -> LogDebugs (thanks, @storm pagoda !)
  • fixed WeatherController not syncing weather changes correctly (thanks, @dreamy oracle !)
  • fixed an issue with LobbyControl's lobby clear command spawning weather 6
  • changed how weather->weather weights are defined to be more intuitive:
    • previously setting None@200 in Rainy meant that if None was the previous weather, Rainy is set to 200 weight
    • now setting None@200 in Rainy means that if Rainy was the previous weather, None is set to 200 weight
    • updated the config entry description to reflect the change
  • added a toggle for using Registry's scrap multipliers
  • added a toggle between Registry's weighted weather selection and a vanilla algorithm
  • added WeatherSelectionAlgorithm class for allowing custom weather selection algorithms in the future
  • added CurrentWeathers class for easier management of selected weathers (this is a breaking change for WeatherManager.CurrentWeathers!) (obligatory ping for @queen crystal)
  • added methods allowing to modify randomWeathers to WeatherController: SetRandomWeathers, AddRandomWeather, RemoveRandomWeather
  • added Enabled property to ConfigHandler: weather developers can now opt-out of the Registry config entries from being used (thanks, @abstract pivot !)
  • added WeatherEffectOverride class for defining weather effect overrides
#

as always: let me know when anything breaks πŸ˜…

storm pagoda
#

I like getting pinged for something nice every once in a while

#

:3

ancient depot
#

Bad Mrov

#

XD

#

Hope he updates it before I stream today lol

drowsy willow
#

i've let him know what's gonna break, sorry for rushing it πŸ₯²

ancient depot
#

Lmao dw about it I just am like "Oh no how dare you break compat" peepoGiggles

#

If it's a good change in the long run though then goodge

drowsy willow
#

this is change o'clock

abstract pivot
#

Brother I also use your mod

drowsy willow
#

are you checking that field?

abstract pivot
#

I check SOMETHING for the current weather

#

Lemme check

#

Remember for the tornados uh

#

Warning

#

WeatherManager.GetCurrentWeather

#

Did u change that

drowsy willow
#

no

abstract pivot
#

Also while I'm here, do you know where the quota value is stored?

abstract pivot
drowsy willow
#

and that's it

abstract pivot
#

Oh nice

storm pagoda
#

There's a whole quota info struct in start of round, I think

abstract pivot
#

I just need it to do some math for quota sellin

drowsy willow
#

TimeOfDay.Instance.quotaVariables

abstract pivot
haughty ingot
#

sup

abstract pivot
#

Respond to that message an

#

Damn

#

Beat me to it

#

I was gonna say something mean

haughty ingot
drowsy willow
#

you still have the chance 🀭

abstract pivot
drowsy willow
#

starting quota is the first one on new save

#

i'm pretty sure

abstract pivot
#

oh lol, yeah okay ty

#

now i gotta find stuff like how much was already contributed and what the sales percentage is

#

so thats gonna be fun

abstract pivot
#

make the github public first bud

drowsy willow
#

OH SHIT

#

did i not?

abstract pivot
#

nope

#

but it seems like its in the terminal i think

drowsy willow
#

done

abstract pivot
#

now where do i access the terminal from Deadge

#

alright ty

#

have fun??? brother this is 4 lines of code

drowsy willow
#

🀭

abstract pivot
#

this doesnt even get me any of what i needed lmfao

drowsy willow
#

what do you want to know then πŸ˜…

abstract pivot
#

this is what i need basically i think

#

lol

drowsy willow
#

sell percentage for the company?

abstract pivot
#

yea

drowsy willow
abstract pivot
#

just for mods like lategameupgrades that modify that shi

#

oh companyBuyingRate

#

sick

drowsy willow
#

is jeb working?

abstract pivot
#

nope

drowsy willow
#

oh

#

what do i use then?

abstract pivot
#

your big fat ass

drowsy willow
#

uncalled for

#

but fair

abstract pivot
#

sorry πŸ˜”

gray kayak
#

mod whistle

drowsy willow
#

do i like

#

swear

#

or something

#

🀭

gray kayak
#

have you tried using your big fa-

novel relic
#

jeb frew up

drowsy willow
#

poor jeb

#

sick and unpaid

#

and lazy

novel relic
#

too many bones and oxygen tanks

brisk ether
drowsy willow
#

yes

stark scaffold
wraith gorge
#

Buncha error spams on moons with JLL as dependency and SDM interior failing to generate with the new update, Had to revert it for now

drowsy willow
#

as for the interior, I'll check out what's going on

sonic night
#

How does the WeatherToWeather weights in WeatherRegistry differ from WeatherTweaks? Does one override the other?

drowsy willow
#

WeatherTweaks stable overrides Registry, TweaksBeta uses Registry weights

harsh flicker
#

okay, got some things to report
First issue i had was with what i believe was from adding WeatherTweaksBeta
I added it to my profile as i was updating the mods today
Here is the old code: 01927d16-02c7-79b3-303d-0eb8ced17efe
And the new one: 01928c60-8745-5b1f-3237-cebfc5714826
I attached the list of mods i updated too

Once i loaded into moons...as you can see, all the fog and post processing was gone on clear weather, unsure about the other weathers
Whats strange is there was no errors in the log, and the issue persisted even when i disabled all the mods shown that updated, and disabled WeatherTweaksBeta, and even deleted it from the profile and deleted the config for it
All i could do was revert back to my old profile, update the mods but not add WeatherTweaksBeta, and then it was completely fine
You can likely replicate the issue by taking the old code shown above, updating the mods + adding the Beta, and then try loading into a moon

ancient depot
#

@drowsy willow your update seems to be very busted

harsh flicker
#

i also verified integrity of steam files, it seems something with the beta corrupts something that persists even when the mod is removed from the profile

ancient depot
#

Heatwave for example is not syncing for clients

harsh flicker
#

The second issue i have is with this profile, now with the previous issue gone: 01928c65-46c7-b843-4cf7-a9618e355924

harsh flicker
# harsh flicker The second issue i have is with this profile, now with the previous issue gone: ...

It works fine as it is there, but if i update these 2 mods, i can then no longer open the ship doors to go onto a moon
Also no errors in the log
Oddly, i noticed that the coloured weather name on the terminal also doesnt work anymore, AND the scroll menu for the moon list in the terminal doesnt work either
This also is weird because i thought JLL was updated to work with the new WeatherRegistry update

#

I dont have logs, but there was no errors in them anyways, and you can replicate it by doing the same with the profile
Later today after i play with friends i could provide logs of before/after updating to compare though if you want

novel relic
#

[Error :WeatherRegistry SunAnimator] Detected a null clip: Value cannot be null.

#

Only error in log after a lag explosion ^^

obsidian schooner
harsh flicker
#

Something with adding that mod caused issues even when removed

obsidian schooner
#

I think it could be something else

harsh flicker
#

i dont have any mods that mess with fog tho
So if anything its a conflict with it once its added to the profile that persists even when removed
My guess at first was Casino since it just updated with a halloween theme that might have something fog related, or maybe Chameleon or something

#

All in all it doesnt really matter though since he was gonna update it soon

obsidian schooner
harsh flicker
#

its a conflict then with something else, with no error

#

Which is still messed up it persists in the profile even with weathertweaksbeta removed

harsh flicker
harsh flicker
ancient depot
#

It was happening for clients only and they couldn't see Heatwave cus of it

harsh flicker
#

i mean, what imma do is just stay on the older version for now

harsh flicker
ancient depot
#

Did you make sure to regen your config?

harsh flicker
#

Yes, i deleted it so it could make a new one

ancient depot
harsh flicker
#

LQ

ancient depot
#

Wouldn't know anything about LQ unfortunately lol that mod always felt overcomplicated to me

#

But you could check your log for errors

harsh flicker
#

i mean for now its fine, i'm not in a rush to update JLL and Registry, there isnt much noticeable difference for me
I can try updating them again later and providing logs

abstract pivot
#

Shouldn't br labelled an error tbh

drowsy willow
#

do you have full log from that?

harsh flicker
#

i do not, but as i said when i have time later i could redownload that old profile, update the mods + add weatherbeta and probably replicate it since it happened everytime i tried to land

#

i have to do it to a new profile because once its done, it kinda breaks it even when the mod is turned off or removed

drowsy willow
#

this is really weird

#

I'll check

ancient depot
#

Btw @abstract pivot since we're here clients are seeing 2 tornados instead of 1 whenever we get Windy weather

#

I had a blue one earlier and clients saw a red and blue one inside of each other

abstract pivot
#

I changed nothing about tornados

drowsy willow
#

i feel danger

harsh flicker
#

Tornado is also invis for me and my clients, i can send log at end of session
But we are playing on the latest CodeRebirth but still using the older WeatherRegistry

drowsy willow
#

send the logs, please πŸ˜…

#

oh my lord, I've broken some things

#

not great

#

fully expected

harsh flicker
gritty blade
#

good luck mrov 😬

ancient depot
#

@abstract pivot MeteorShower is causing very poor fps

#

@drowsy willow I think your WeatherRegistry update is very broken

#

Sorry to say

#

It was stable before lol

wicked latch
#

Nice.

drowsy willow
#

very broken, as in?

#

any specific issues, logs, modpack codes?

ancient depot
#

but dying on Gorgonzola causes bad lag

#

Meteor Shower causes bad lag

wicked latch
#

Sounds like either error spam or you had no idea what you were doing in Update functions, mrov. Lol.

ancient depot
#

Tornados duplicate for clients

drowsy willow
#

i'm not doing anything in updates

wicked latch
#

So no heavy calculations between frames?

drowsy willow
#

no, sir

wicked latch
drowsy willow
#

this is everything that's changed in-between updates

wicked latch
#

We will have to look at logs and see then

drowsy willow
harsh flicker
drowsy willow
#

alrighty

#

okay, umm

#

i've installed latest TweaksBeta

#

and nothing works

#

lol

#

waaait

#

nevermind

#

it's not that

drowsy willow
#

oh, you know what's funny?

wicked latch
#

What is?

drowsy willow
#

HUH

wicked latch
#

Have you tried Tweaks aswell?

#

Because you still have those last I checked.

drowsy willow
#

no, what i mean is

#

registry is not even starting

#

HMMMM

rugged aurora
drowsy willow
#

oh nevermind, it's disabled?

#

what the fuck

wicked latch
drowsy willow
#

i'm after 10-hour shift, forgive me πŸ˜†

#

fucking fuck

ancient depot
drowsy willow
#

I GOT IT

#

this is fucking bizarre

wicked latch
#

Nice void?

drowsy willow
#

why is ship in a wrong place

#

why is

#

WHAT

wicked latch
#

How did you even manage to rotate the moon's scene?

ancient depot
#

Also @faint sinew please update Grand Armory to fix the dungen errors

wicked latch
#

Because I don't doubt you decided to rotate the ship for some reason.

drowsy willow
#

i loaded a new save and landed

#

HMMMMMMM

wicked latch
#

Are you sure you don't have some mod that does that?

drowsy willow
#

i'm not

bleak quarry
#

yea

#

I thought there was a mod that makes the ship and dropships spawn at random areas

wicked latch
#

I know about the dropship one.

drowsy willow
#

oh yeah, it's taht

#

100%

wicked latch
#

Not sure if there was a ship yet.

drowsy willow
#

i'm in a different place lol

bleak quarry
#

Bruh

wicked latch
#

Mrov can't even debug its own mod.

bleak quarry
drowsy willow
drowsy willow
#

and i've lost my glasses somewhere

bleak quarry
drowsy willow
#

holy fuck it's bad πŸ˜†

wicked latch
drowsy willow
#

okay, so something weathertweaks does is fucking everything up

#

and i've got a suspect

wicked latch
#

...

#

WeatherTweaks?

drowsy willow
#

vErY fuNnY

wicked latch
#

HuEuHuE

drowsy willow
#

okay, is it this one?

#

how would that even work lol

wicked latch
#

But is it supposed to put a weather though?

#

Because the prompt said clear.

#

Unless I am misunderstanding the whole thing, lol.

drowsy willow
#

this is the displayed name of None weather

wicked latch
#

Right.

#

Which is the same with what the log is saying, no?

drowsy willow
#

yeah

#

let me get that part

#

OOOOOH i think i see it

#

i don't

#

oh my

#

this is FUCKED UP

harsh flicker
#

thats in the pack

drowsy willow
#

alrighty

#

i've checked one suspicion in Tweaks, it's not it

#

okay, it's specifically clear weather

#

fuuuuck πŸ˜†

#

is the sunAnimator fucking everything up? really?

ancient depot
drowsy willow
#

what the fuck is causing that to happen πŸ˜†

wicked latch
#

What is what causing what happening?

drowsy willow
#

the missing fog

wicked latch
#

I thought they were on scene?

#

Or is it those AudioReverbTrigger things?

harsh flicker
#

Heres the thing, the issue didnt happen anymore if i just rolled back to an older version, updated, but never added WeathetTweaksBeta
But once added it broke permanentely πŸ’”

drowsy willow
#

i reproduced it instantly

#

but fuck me i have no idea why

harsh flicker
#

i mean in all fairness the pack has crap like LEC in it still KaguyaStare (Shenron needs to update his mod to LL instead)
So i am not surprised if there is just some obscure wack rly random stuff that happens in it
Tho i suppose figuring it out is still worthwhile since it kinda permanently breaks the profile even with beta tweaks removed n all

drowsy willow
#

something in the pack is interfering

#

but why does removing Tweaks fix it?

#

πŸ˜†

#

no clue

worldly sleet
#

simply do not use weathertweaks πŸ‘

drowsy willow
#

that's not a bad advice

#

i do not know which demon took over me when working on weathertweaks

#

but i HATE what came out of it

#

i give up for today

#

i can barely focus

#

i hate bugs like that πŸ˜‚

#

but i'll fix it earliest i can

#

damn you, weathertweaks

ancient depot
#

Just deprecate WeatherTweaks

#

problem solved

drowsy willow
#

do not tempt me

ancient depot
#

I mean you hate working on it so I'm kind of surprised you haven't already tbh

#

XD

drowsy willow
#

it's still working

#

some-fucking-how

waxen plover
#

I lost my settings randomly.

#

I put a ton of effort into customizing what weathers can happen on what moons in my wesleysmoons modpack and at some point my settings were defaulted.

#

I don't know when or what did it. Is this your first time hearing about something like this?

harsh flicker
waxen plover
#

Shucks, alright.

#

So it's gonna do that every update? I think I'd be better off saving my settings in a text doc.

#

Thanks for letting me know 🫢

gray kayak
#

I can't imagine every update

waxen plover
#

Hey I was just wondering if you happened to know which is correct for referring to Fission-C and Asteroid-13 of Wesley's Moons in the config: Fission & Asteroid or Fission-C & Asteroid-13?

gritty blade
#

Always backup especially config files and most importantly the ones that takes time
Even though saying this now is not super helpful ikr

#

I cried (inside) couple times cause of updates changing/replacing config files from various mods

waxen plover
#

I noticed that my config settings hadn't been working a day or two ago and basically ignored it because I assumed it was some mod conflict or something and I didn't feel like I had time to fix it. Glad to know it was a pretty simple (tedious) fix.

ancient depot
#

This was way before you popped in when Gorgonzola kept exploding

#

XD

ancient depot
#

@drowsy willow I do hope you can figure out why Weathers don't sync properly for clients with the latest update, like heatwave's visuals not working and them seeing double tornadoes and such

drowsy willow
waxen plover
drowsy willow
#

yeah

#

you can even do fissionc and asteroid13

#

and even (I'd have to check it for sure) asteroid

ancient depot
#

Jacob fixed the Gorgonzola fps murders

#

Lol

drowsy willow
#

there should be no desyncs in picked weathers

drowsy willow
ancient depot
#

Clients can't see the visuals

#

Windy

#

Clients see 2 Tornados inside of each other

#

Bug with the Registry update

#

Unsure if any other weathers are affected

#

It's not desynced as in they don't get the same weather

#

it's desynced as in things are very wonky for them

#

Windy could still technically be a CodeRebirth bug but Heatwave not working is 100% WR

drowsy willow
#

that is really interesting

ancient depot
#

Unless Heatwave was cus of the Sun Animator being null

#

Which is uhh

#

very likely

drowsy willow
#

which it shouldn't happen

#

because at the point of null reference

#

nothing is set

#

so literally nothing happens

#

I have to change it to a warning

storm pagoda
#

God help us

drowsy willow
#

the loglevel commander is here 😳

#

I've literally jumped up my chair

drowsy willow
ancient depot
drowsy willow
#

I'll have to test it on multiple clients

ancient depot
#

Something just doesn't sync properly ig

drowsy willow
#

will check what's going on

#

I THINK I KNOW

#

but will have to check

ancient depot
#

Mrov mark of stability Mrov

#

Mrov mark of stability

drowsy willow
#

every fucking update is a burning mess

#

aaaaargh

ancient depot
#

You had it stable, you updated it and something broke

#

Hehe

#

But it's okay

#

Tbf

#

It's not as broken as your WeatherTweaks updates

#

Those were a dumpster fire in comparison

#

XD

drowsy willow
ancient depot
#

Lmfao

drowsy willow
#

hehehe

#

I'm gonna take a proper look at it tomorrow

queen crystal
ancient depot
#

I threw 2 clients into the lake

#

fps didn't die

#

I guess only time will tell if it's fixed in Multiplayer but as far as lan goes

#

It's fixed there

queen crystal
#

Okay well that's good news but I wasn't expecting that. The damage trigger patches i did were for code that was added like 2 updates ago so if that fixed it then this has been a thing for a while and either nobody noticed or nobody reported it lmao

ancient depot
#

CodeRebirth also still appears to be likely, cus it messes with Kinematic body stuff and is the only mod to do so

waxen plover
#

is there a reliable way to get a moon to always be one particular weather? i tried blacklisting the moon from using 'none' weather and giving the moon 300 spawn weight for the particular weather i wanted it to always have and the weather is still clear almost every time i look

drowsy willow
#

as I've said before: nothing is set at that point in time

ancient depot
#

We're talking about the cheese lake lag issue

waxen plover
#

it's weird because it works for Atlantica always being Flooded but I can't get Asteroid-13 to always be Solar Flare or Desolation to always be Eclipsed.

ancient depot
#

If it still happens in Multi

#

lol

drowsy willow
#

what's showing up in your logs?

waxen plover
#

no clue i never check them don't know where they are & really don't want to know

#

what's your best shot in the dark guess

drowsy willow
#

I'm asking because your log file will show the exact percentage chance of that weather happening

waxen plover
#

fuck. that's so useful.

drowsy willow
#

and because they exist I'm not planning to guess πŸ˜…

waxen plover
#

LMAO

#

well on second thought i think it's only moons that are supposed to be weather-locked to weathers from LethalElements that are doing it im pretty sure i misremembered the eclipsed thing

drowsy willow
waxen plover
#

i probably shouldn't have asked about this at 4am can i pick this up with you another time

drowsy willow
#

certainly πŸ˜…

#

no worries

waxen plover
#

thank u for being active & willing to answer questions 🫢

abstract pivot
#

How many times is coderebirth gonna be randomly blamed

#

And how many times are the words "try/catch being the problem" gonna be said by someone who doesn't know code and doesn't even know if there is any try catches

abstract pivot
ancient depot
# abstract pivot How many times is coderebirth gonna be randomly blamed

Okay so I only mentioned CodeRebirth cus I readded it yesterday, and one of the errors I saw was regarding the kinematic body stuff I didn't say your mod was at fault I said it could be a possibility also when the game was lagging as bad as it was in the clip I sent before with no errors or anything really being logged that usually means the error is under a try/catch

#

Cus something should have been erroring

#

for it to lag that badly

abstract pivot
#

There is no reason to think it could be a try catch, MRAPI was lagging for you because UDA logged an error each frame which it didn't need to log because it wasn't being used how it's supposed to be used

ancient depot
#

Yeah it's just hard to know what it could have been

#

Since the fps literally died and became a slide show the second 2 people died

#

But neither me or clients got log spam

abstract pivot
#

And meteor showers performance should've ONLY improved, the whole visual updates point was for an improvement, not somehow fps decrease

ancient depot
#

The issue on StarlancerZero ended up being an issue with Chizra Temple and I told you I was sorry cus I didn't realize it til Pepsiman reprod the lag

#

I thought it was Meteor Shower cus Chizra has never lagged like that before

#

lol

#

Also the visuals for Meteor Shower are way nicer you did a really good job

abstract pivot
#

Wasn't me, v0xx offered to do it

ancient depot
#

Still

#

I approve

#

I like that they use the vanilla visuals for falling now

abstract pivot
#

I never planned to change the visuals lol, but I'm very thankful for hik

ancient depot
#

The trail

abstract pivot
#

Him*

ancient depot
#

Yeah he did good

#

It improved it greatly

#

The only thing you need to fix is the bug where it doesn't end at 12 PM like it's supposed to

#

It just lasts the whole day

#

lol

#

I think it's just not registering the config option

#

Cus there were no errors

abstract pivot
#

Wdym

#

The normalised time of day config? That works

ancient depot
#

It didn't work for me

#

and it also didn't for Pepsiman

#

πŸ€”

#

Cus the config says the time for it to leave says it should leave at 12PM ingame

abstract pivot
#

It was for made @harsh flicker so I'd have to check later if it worked with him, but it worked in my testing

#

Which 12pm

#

Like

#

After 11:59am

#

Or after 11:59pm

ancient depot
#

After 11:59AM ingame lol

#

based on your description

abstract pivot
#

I mean

#

I guess I should've put 12am

#

But like

ancient depot
#

Lmao that would make sense

abstract pivot
#

Normalised time of day the meteor shower would end

#

Idk why I'd end it after 4 hours lol

ancient depot
#

Yeah XD

#

I was very confused

abstract pivot
#

12pm would be like 0.3

ancient depot
#

Yeah lol, what time does the vanilla one end again?

#

I was thinking of setting it to end around the same time as that

abstract pivot
#

Vanilla one never ends

#

Only starts randomly

ancient depot
#

It also ends after a while

#

I've seen it ingame

#

It's kinda cool

abstract pivot
#

Oh then idk

#

I've never played with it more than checking it out when it got put into beta

ancient depot
#

Haha fair

gray kayak
#

Apparently Vanilla Meteors last 12 in-game hours

ancient depot
#

The vanilla one I might add the mod that disables it, cus it errors a lot whenever the meteors fall

ancient depot
gray kayak
#

which is like

#

70% of the round

ancient depot
#

Yeah so it ends around 8pm

#

So for CodeRebirth that would be like

#

0.7?

#

0.6 maybe?

gray kayak
#

I mean it can end at any time

#

since it starts at a random time

ancient depot
#

Yeah but CR's starts at the beginning of the day so

#

If you want it to last a certain amount of time

#

What would a good value be?

gray kayak
#

well the earliest the vanilla meteors can stop is like

#

what

#

8pm?

#

so can just go off that

ancient depot
#

It's hard to math it

#

cus 0.5 would be 6 PM

#

Actually if I think about it prolly not, 0.9 would be 11pm probs

#

so 0.7

abstract pivot
#

Day starts around like 7:30am

#

Ends at 12

#

So you've got, 16.5 hours

ancient depot
abstract pivot
#

Idk if that's when the normalised timer starts though lol

ancient depot
#

Unless you use something like CentralConfig which I got rid of cus it's so Volatile and exploded from JLL and WR's updates

#

Lmfao

#

Was fun seeing that error spam

abstract pivot
#

Well anyway, starting 8am, ends 12am, 16 hours

#

0.5 would be 4pm

#

0.75 would be 8pm

ancient depot
#

I was think 0.5 would be 6 cus it's half of 1

#

Lol

#

But ye makes sense

abstract pivot
#

16 hours/2

#

Is 8 hours

#

8 hours + 8am

ancient depot
abstract pivot
#

4pm

ancient depot
#

My brain was just doing bad math cus it's almost 5 am

#

XD

harsh flicker
abstract pivot
#

It's fine, lunxara just misread the config

wraith gorge
#

SDM interior still breaks with 0.2.0 and I thought it was before JLL updated but I have no idea why it has something to do with this, but it somehow does...

haughty ingot
wraith gorge
#

Hmm, for the moons I tested it in Sanguine and Solace

restive pilot
wicked latch
#

A mod that was made for a Modjam in the early days of modding.

#

The theme was essentialy making the scary game not scary.

wicked latch
#

@drowsy willow That doesn't seem good. :D

#

(Which also spawned two tornados)

#

Speaking of.

#

What do I need to change in the weather probe to make it not break your registry? :D

pulsar monolith
#

Hey so I’m curious is the mod working currently? Or is the errors because of the conflicts with another mod

wicked latch
#

Usually switching to major version means there could be bugs due to major changes.

#

Some say it's broken, some say it's fine.

#

So yeah, I would try with whatever modpack you have and see if there's any issues with latest release and if so see if going to a previous version makes it not fucky anymore.

ancient depot
#

It's a client sided issue

ancient depot
#

It could be that

wicked latch
waxen plover
#

Do you foresee any issues with setting the weight of a specific weather to almost 10 thousand?

#

I'm still being lazy about my issue. I doubt the number not being big enough was the problem but I just want to try the easy stuff first.

drowsy willow
#

sooo

#

there shouldn't be any issues πŸ˜…

waxen plover
#

Cool! I'll let you know if this improbably works.

waxen plover
#

WEATHER PROBE!?

#

WUH?

drowsy willow
pulsar monolith
#

Also just clarifying, does the config that disables scrap multiples disable both amount and value?

drowsy willow
#

yes

#

Registry will still print whatever multipliers are being used, but disabling scrap settings will not modify those values inside Registry in any way

#

in other words: Registry will print final multipliers in the log, even if it's not being set in Registry

obsidian schooner
#

and the AllwaysUnknown from BetaWT not working?

ancient depot
#

@drowsy willow you definitely need to fix WeatherRegistry

gritty blade
#

well seeing all that, i'm glad i did not update the mods since mrov took a break 😬

ancient depot
ancient depot
#

@queen crystal is the latest JLL still compatible with the previous version of WeatherRegistry? Cus I'm considering maybe downgrading it til Mrov has time to iron out the client sided bugs

queen crystal
#

nope! mrov changed the code on how to access modded weathers which is why I had to update in the first place

ancient depot
#

I hope to god he fixes it soon then

#

Cus the WeatherRegistry update has been a bit of a mess

pulsar monolith
#

Hey does the black list work for others? I blacklisted a modded moon but still got solar flare. Is it because I didn’t use the proper name or is this a glitch?

drowsy willow
#

"it's a mess" it less than helpful

ancient depot
#

Half the time when landing on a moon it says the wrong weather for them

#

IE Meteor Shower for them will say Rainy

#

and they go "Wtf?"

#

Please fix it

#

Please

#

Lol

#

Need modge to stop exploding

#

XD

drowsy willow
#

I'll definitely test what's happening today

#

because that shouldn't happen πŸ₯²

ancient depot
#

I remember you said you think you know what the problem is so hopefully it's an easy fix

#

lol

drowsy willow
#

oh lord

#

oh no

obsidian schooner
#

:,]

drowsy willow
#

what's your modpack code? I'll test what's going on

obsidian schooner
#

019293e3-c4aa-e69e-6bc5-6ba60e544b61
(188 mods)

drowsy willow
#

thanks πŸ₯Ή

obsidian schooner
#

to confirm

drowsy willow
#

alrighty πŸ˜…

#

so setting up multipliers in Registry doesn't affect anything?

obsidian schooner
#

pre-update

#

post-update

#

and even re-doing the settings, after launhing the game, it reset's to post-update

drowsy willow
#

that is very weird

#

just to be sure: are you changing the settings in correct category (Vanilla weather: Eclipsed - 2nd screenshot)?

#

because the categories changed πŸ₯²

obsidian schooner
drowsy willow
#

alright

#

that is a bad sign

obsidian schooner
#

wait

#

let me try not copying directly the old cfg

ancient depot
#

@drowsy willow This could be a case where WeatherTweaks is maybe causing more issues, cus my config values haven't done this

drowsy willow
obsidian schooner
#

setted up everything

#

Time to test again

ancient depot
drowsy willow
#

those two mods don't touch each other's configs

#

so no

ancient depot
obsidian schooner
#

but the multiplier works

#

that's a good advance

#

019293fa-04f4-54a9-e84f-53bf3f392594

Updated code with the WRMultiplier working

#

to only check the all unknown

drowsy willow
#

thanks, will check

#

thank god the configs aren't busted πŸ˜…

pulsar monolith
#

Any reason the blacklist wouldn’t work for certain weathers?

#

I used just semi colon to separate

drowsy willow
#

oh, that's interesting

#

what's your modpack code?

pulsar monolith
#

Maybe false alarm, I tried regenerating the config. Will test more soon and get back to you on that

obsidian schooner
ancient depot
#

In my pack it didn't actually desync, but the client saw it say the wrong weather when landing

obsidian schooner
#

didn't know that, sorry

ancient depot
#

Yeah

#

Any time we get Meteor Shower

#

it says Rainy for clients

#

WeatherRegistry's update has been so desynced

obsidian schooner
ancient depot
#

I think it's just a general issue

#

With WR atm

#

Cus I mean if you get windy clients see 2 tornados for example

obsidian schooner
dusky mesa
ancient depot
obsidian schooner
#

ooh

#

I see

dusky mesa
#

Sorry D:

obsidian schooner
#

no issues

ionic pollen
#

ok so

#

I tested this before hand

#

I'm currently, with this mod, unable to get past the "You are fired" screen

#

At first it flagged it as ShipWindows/2StoryShip. After removing them, it said WeatherRegistry, after removing that, it worked

#

#help-and-troubleshooting message

#

A link to the log

#

(also hi again Mrov sorry for breaking ur stuff like in the past ><)

#

im going to do one last run test just to double check if it's not one particular mod.

#

nope. flags WR again

#

(another log file if it helps.)

drowsy willow
#

i know why

#

oh no πŸ˜‚

drowsy willow
drowsy willow
#

or later on

obsidian schooner
drowsy willow
#

WeatherRegistry 0.2.1

  • fixed weather desyncs on first day (thanks: @ancient depot , @obsidian schooner !)
  • (hopefully) fixed an issue with game reset soft-locking the game (thanks: @ionic pollen !)
#

let me know if anything breaks πŸ₯Ί

stray sequoia
#

The 0.2 update means that custom weathers will be eventually cycled out 😦

#

There should at least be an API or default support for modded weathers

abstract pivot
#

wdym

#

this IS the api for modded weathers

drowsy willow
#

ummm

#

the WHAT

drowsy willow
#

weathertweaks will be updated soon-ish

#

because it's messing everything up πŸ˜‚

wicked latch
#

Nice.

ionic pollen
#

It worked

#

Can now be fired successfully

#

will let you know if anything else breaks when I next play x.x since i do be busy for a bits now

hybrid crescent
#

Sorry, I need help; if i'm trying to set it up so for exemple Offense has more chance to get the heatwave weather than the other moons, how do I make that happen in this config?

wicked latch
#

I would imagine giving a higher weight in Offense in the Level weights entry.

drowsy willow
#

Add: offense@300; in level weights

drowsy willow
#

i might've accidentally added LLL's ContentTag support

#

🀭

#

MrovLib 0.2.6

  • added LLL's ContentTag support for resolving SelectableLevels
#

mark the tag with $ symbol

#

and that's it

#

it works in all Registry configs

bleak quarry
#

W

hybrid crescent
#

I'm sure I must have messed up somewhere on my end but everytime I take off from a moon, the game softlocks and gives me this error

#

Tested on a custom moon and Experimentation

#

I reset the config for both Weather Tweaks and Weather Registry and it's fine now

azure dirge
#

generic remained awake and chose violence

#

again

drowsy willow
drowsy willow
drowsy willow
pine fox
#

@drowsy willow you changed the current weather array to something else?

pine fox
#

think this is good?

ancient depot
# pine fox think this is good?

I'm not really sure why your mod needs to reference this stuff anyways, I was quite surprised by how Volatile it was when WR and JLL updated tbh

pine fox
#

so I can apply it for it

#

doesn't matter anyway becasue grrrrr

#

wait actually there is a return there hmm

#

ok good yeah so it can be disabled now yay

drowsy willow
bleak quarry
#

Oh no

drowsy willow
#

why not just use this? πŸ₯Ί

#

I'll send you a PR later anyway πŸ˜…

#

why are you complicating it so much yourself? πŸ₯²

pine fox
#

I thought that was right?

pine fox
#

oh I see

#

CurrentWeathers.Contains(level) as a method that gets it rather than accessing it from elsewhere

drowsy willow
#

yeah

#

πŸ˜…

hybrid crescent
pine fox
# drowsy willow yeah

I would still need to access it through an instance, unless you made it a singleton

drowsy willow
pine fox
#

okie

loud obsidian
drowsy willow
loud obsidian
#

0192aba3-1eaf-62b0-1e46-67f861f5ac16

drowsy willow
#

Thanks, I'll check what's going on

loud obsidian
#

No problem, no rush

drowsy willow
grim wing
#

I've got a question regarding the scrap value multipliers. As I understand, all the scrap values in LC are by default multiplied by .4, so that they're 40% of 'true' value or whatnot. Are the scrap value multipliers in the WeatherRegistry config completely replacing that value, so that a value of 1 would be 2.5x higher than vanilla, or are they an additional multiplier to the .4 value, so that a value of 1 would be equal to vanilla? Same question for the scrap amount multiplier as well, I suppose.

drowsy willow
#

the defaults in Registry (1 for scrap value and 1 for scrap amount) are the equivalent of vanilla defaults (1 value and 0.4 amount)

#

i've made it that way so it's easier to work with (from the user perspective)

#

if you want to have 2.5x vanilla amount, you set the multiplier to 2.5 instead of (2.5 * 0.4 = 1)

grim wing
#

Gotcha, I'm used to modifying it through MeteoMultiplier or LethalQuantities, both of which preserve .4 as the default value

#

Thank you very much

drowsy willow
#

no worries πŸ˜…

strong nova
#

@drowsy willow And the fact that the weather is not shown next to it in brackets, is this setting applied in the config?

drowsy willow
#

i'm not sure i understand what you mean

#

are you talking about WeatherTweaks and the terminal setting?

strong nova
#

well, I remember in vanilla it showed the weather to the right of the moon

strong nova
#

I thought he was hiding something

drowsy willow
#

i'm not quite sure, honestly

#

what's your modpack code? I'll take a look

strong nova
#

Well, I'm confused too, I just haven't played for a long time

strong nova
strong nova
#

or 0192b3e2-cae3-58fb-eda1-0da6a1bad898

drowsy willow
strong nova
#

In vanilla without mods everything is fine

drowsy willow
#

I have some great news for the next update

strong nova
drowsy willow
#

i'll check why this is happening

#

WeatherRegistry 0.2.2

  • picked weathers are now saved to the savefile and will be restored on lobby reload