[WIP] Unity AssetRipper / Fixer

[trail oriole]

lol

[pearl burrow]

strangely

dungeon still works

but it links to the test maps dungeon

the facility is still generated

but the tepeort doesnt link to it

lemme try the fireexit

fuck compiling shader strikes again

[humble ember]

LLL will probavbly fix that automatically maybe

[pearl burrow]

honestly !

this silly bullshit was useful

it confirmed something for me

my multi level dungeon idea is possible

pikmin 2 style levels here i come..

[humble ember]

oh yeah i already have that working as a proof of concept

[trail oriole]

@tawdry arch if you want to try it out btw for your ui stuff (branch link is above it) #1199473521265475745 message

[pearl burrow]

weird

i spawned a jester in the test dungeon and manipulated its state manually and apparently it just works it pops between em

but now its popped and instead of heading for me standing on top of a door or just standing stil really close to me

its just... wandering around?

its funny i never seen it do that

itlooks like its just checking spots on the map

i wonder how unity navigation works

oh hey

this might be realted

oh right sprry for chatting in this channel

its very useful and seems to work perfectly thank y ouvery much

i should probably try testing mods in this

is there anything you know is INCOMPATIBLE with the editor?

[trail oriole]

nothing that I know of atm

[pearl burrow]

ah sweet thats not smething you can just do in unity explorer easily

[humble ember]

Very suprised lll’s scenemanager il stuff works

[trail oriole]

Yeah it's great for that sort of stuff

[heavy marten]

I go brr with shader graph. I just need to get the actual ripped game working on my side....

Which I have no clue how to do that lol

[pearl burrow]

hey guys where's money value stored again

[trail oriole]

#1199473521265475745 message to get the proper git link, and above is the branch link

Then just get the requirements/follow the steps

It's quite quick

[pearl burrow]

i wanna load up titan and see it with all the stuff loaded in properly

[trail oriole]

Terminal script on the TerminalScript object in the sample scene

[pearl burrow]

gotcha

hmm

changes to stuff while playing are reverted right

so i can just change weather values if i wanted to

[trail oriole]

In scene, yes, in an SO, no

[pearl burrow]

dang!!

how do i get this weather offa titan

[trail oriole]

I just modified titan's so to not have weather

[tranquil hare]

if you're lazy i'd just go down then back up

[pearl burrow]

fair

honestly dont matter anyway

damn selecting scene view after you load a new level really takes a bit

[trail oriole]

mmmm shaders

[pearl burrow]

oh by the way once we eventually figure out the iconic shader

[tranquil hare]

You can also make yourself start with a bunch of credits here every time if you change this

[pearl burrow]

where would we even put it

[trail oriole]

I'd just inject it to replace the broken shader

[pearl burrow]

wait

thisis real

its actually there

wouldnt it be funny to make this visible to players ingame

fuckin fourth wall of god above you

[trail oriole]

https://tenor.com/view/look-up-scared-willem-dafoe-gif-17761333

[pearl burrow]

the jester i spawned on the test map

it's still there

forgotten by the game's code

[tulip widget]

Where is the shop stuff at

[trail oriole]

yeah the test map is always loaded so things don't despawn from it

[tranquil hare]

Not sure, sorry. Haven't look at any of that

[trail oriole]

this stuff? #1199473521265475745 message

[pearl burrow]

actually that reminds me

cant you edit these properties at runtime

wheres the runtime version of the scriptableobjects stored

[trail oriole]

You can edit them at runtime yeah, (in the build they reset when you start the game again)

I still don't really get how you grab them properly in-game tbh

[pearl burrow]

im pretty sure the asset path structure still exists while ingame

its just that usually this stuff is loaded into values never really laoded dynamically

[humble ember]

U just like grab em

[trail oriole]

[pearl burrow]

actually i never properly figured it out

hookgenpatcher is needed as a dependancy for mods, right?

its not just for generating the mmhook files or anything

i dont think the mods folder [ProjectName]\Assets\LethalCompany\Mods actually works the way I'd like it to

unless its incompatible with subfolders or somethn

[trail oriole]

That folder is for in-editor custom plugins, not for putting normal ones.

[pearl burrow]

ahhhhh

makes sense

[trail oriole]

The normal one is either in the normal game path (if you have that option enabled), or next to Assets in Lethal Company/BepInEx (like where Library is)

even faster

[pearl burrow]

oh yeah speaking of that

will i need to copy that folder if i use this as a template

or can i leave it out and only copy the 4 folders we spoke of before

and it'll just be handled

[trail oriole]

No it gets auto generated

[pearl burrow]

ahhh sweet

good job honestly

i think its cool the more stuff we fix about this the better this becomes for testing

yknow i wonder if you could ever get steam online working in this lol

[trail oriole]

Or actually you might have to now that I think about it, since I copy the dlls over + the fake structure next to it. Might as well to be safe.

[trail oriole]

Can't, no

[pearl burrow]

ehhh alr

[trail oriole]

That's why I disabled clicking on Online lol

[pearl burrow]

wait so is it impossible or not allowed

[trail oriole]

(you don't have to copy plugins/config/etc just the core inside of BepInEx btw)

Technically both

Basically just those four things

Or if you use the normal game bepinex, you don't need this at all, so really up to you

[pearl burrow]

i mean since i use r2modman

i think that'd be a bad idea

[trail oriole]

Basically online play doesn't work since the hashes don't match across the two different builds

[pearl burrow]

keeping it local is good

build hashes?

have you checked what happens if you spoofed them?

[trail oriole]

Yeah basically, when compiled the rpcs/connection hashes are defined

[humble ember]

It’s not really something that needs fixing

[pearl burrow]

im just curious

[trail oriole]

So when a client from the normal game tries to connect, the hash is entirely wrong, so I just block the button

Probably better this way anyway so people don't do weird stuff

[pearl burrow]

oh right about this

if this works in editor does that mean it works just actually properly built?

[trail oriole]

I don't follow the last half of that

[pearl burrow]

like exported as an executable

[trail oriole]

Oh yeah you can build the game

[pearl burrow]

funny

so if someone was enough of a freak they could make a source-based mod instead of a plugin

im tryna think of a game people do that with but i dont actually remmeber any speciifc examples

super mario 64 actually

[trail oriole]

Terraria initially

Minecraft initially 🤔

[pearl burrow]

dang

is not workin

[trail oriole]

Well that patcher is a patcher, and local doesn't support patchers. If you want to use hookgen you have to make the dll from the normal game and copy that into plugins

[pearl burrow]

i copied it into Tools like the readme mentioned

should i put it here too

[trail oriole]

oh right the tool part was before I went goofy and manually load all dlls from plugins

I'd just move it into plugins

[pearl burrow]

right got this in

i just had the contents from this inside of this inside tools

unless you mean other stuff

hmm

lemme test

[trail oriole]

An example

[pearl burrow]

weird it jsut doesnt do it

did i forget a step

does bepinex even run?

oh wait hm it is

is it just the dancetools button that isnt working

yeah im not sure hte mods are being loaded

hm...

[trail oriole]

I mean, it tells you the dlls/mods it loads in the console

[pearl burrow]

well it says it loaded the dll

but nothing about bepinex actually running

ahh i see no config files were generated that kinda proves it

nothing in LogOutput either

wheres the part in the bepinex.cfg about the preloader anyway

[trail oriole]

Config files are generated in the project root

[pearl burrow]

wait

is this why it broke

[trail oriole]

why is there an mmhook for those

There should only be one for the main assembly

[pearl burrow]

hookgenpatcher made those

[trail oriole]

[pearl burrow]

i just copied the whole MMHOOK folder

if hookgenpatcher worked it'd make those itself too

[trail oriole]

Odd haven't seen it do that for me

[pearl burrow]

ArgumentException: Undefined target method for patch method static bool BepInExPatcher+IgnoreILHelpers::Prefix()
HarmonyLib.PatchClassProcessor.PatchWithAttributes (System.Reflection.MethodBase& lastOriginal) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
HarmonyLib.PatchClassProcessor.Patch () (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
Rethrow as HarmonyException: Patching exception in method null
HarmonyLib.PatchClassProcessor.ReportException (System.Exception exception, System.Reflection.MethodBase original) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
HarmonyLib.PatchClassProcessor.Patch () (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
HarmonyLib.Harmony.PatchAll (System.Type type) (at <474744d65d8e460fa08cd5fd82b5d65f>:0)
BepInExPatcher.OnLoad () (at Assets/LethalCompany/Tools/Plugins/BepInEx/Utility/BepInExPatcher.cs:113)

here's the whole error

[trail oriole]

Remove all of the mmhooks besides the assembly-csharp one to start with

[pearl burrow]

awright

[trail oriole]

Works for me, never used this before and I already hate it

Adds another event system

why

omg and it doesn't clear out its ui when you stop playing the game

the hell is the mod doing

[pearl burrow]

is there a way to view this as just a text log

[pearl burrow]

this file is fulla crud

[trail oriole]

lol

[pearl burrow]

sorry its the only cheat menu mod that seemed to work...

[trail oriole]

I just hate it since their ui is the only one I've seen that doesn't clean itself up, and makes new event systems each time

Like I have no idea what the hell it's doing

[pearl burrow]

anyways yeah nothing seemed to change

do you have the argumentexecption on your end

[trail oriole]

Nope, mine loads fine

Show me your plugins folder

[pearl burrow]

can they not be subfoldered

the mmhook has only 1 file in it now like you said to

[trail oriole]

Well remove the hookgen patcher folder entirely to start with

[pearl burrow]

should i remove all the mod manager related stuff like readmes and icons n stuff

[trail oriole]

And subfolders work fine

I don't think those types of files affect it

[pearl burrow]

would this be a problem btw

[trail oriole]

Probably

[pearl burrow]

aw

trash it?

[trail oriole]

Yes

From both patchers and plugins

[pearl burrow]

mm not sure if it was that, error still there

what line is the error even at anyway

undefined target method...

[trail oriole]

Try this https://www.nombin.dev/xezwdcqjha (replace the script contents there)

[pearl burrow]

oh you mean

copy this whole thing

[trail oriole]

Yes

[pearl burrow]

Ctrl+A Ctrl+V into the file im currently looking at

i see what you mean

[trail oriole]

:)))

Just realized I might need an "update patcher scripts" button

Since like the one I sent you isn't "in" the package

It's copied over

(since bepinex is downloaded I can't have them in the package)

[pearl burrow]

https://github.com/quackest/dancetools

btw heres this

if you can find why its making those errors

[trail oriole]

It makes them since their prefab has an extra event system in it

And I think the object persists because they DDOL it + hide it without destroying it

This is horrid

Maybe I can manually clean those up when the game ends

[pearl burrow]

oh yeah on that

will i have o to anything when i stop running hte game

[trail oriole]

Whatcha mean

[pearl burrow]

you said it leaves stuff behind

[trail oriole]

Oh yeah it does. I'm currently attempting to write a fix for that

[pearl burrow]

confirmed working by the by

[trail oriole]

gnome

[pearl burrow]

hooh

oh hey i didnt even need dancetools

LC debug menu doesnt have a fixed list

it probably reads from allItems

[trail oriole]

Ye, the items are based on allItems

Just the monster list isn't automatic

[pearl burrow]

do you mean it literally though

is there something left behind id have to like delete or something

[trail oriole]

No it's annoying objects that are made in a way that unity doesn't destroy them

One of the fun edge cases

ok not even the hide flags can find it

Where the hell is this object

https://tenor.com/view/target-acquired-aim-shoot-look-gif-14290039

I win

I killed it

I also accidentally killed the editor camera

[pearl burrow]

the editor is kinda weird about these objects

UNLESS

you use the other lighting thing

that i dont know how it works

which one is scene lighting?

[trail oriole]

Bottom

[pearl burrow]

right

i have exposure override on here tho hold on

yeah looks about right

once we fix the shader will it work in the editor?

i assume it would

[trail oriole]

Probably

[pearl burrow]

also yeah it shows the assets

but its really vague about paths

doesnt tell you where the mesh or whatever are from

[trail oriole]

Also fixed the event system issue

:)

https://www.nombin.dev/uxwzoxtrcg if you want to try it out (same file as before)

[pearl burrow]

glad to have tested

this will be very cool for testing a load of things

unityexplorer was nice but so slow i gotta admit

[trail oriole]

Yeah

[pearl burrow]

runtime c# console still useful though

[pearl burrow]

ooo

[humble ember]

Ill make a skip to SelectableLevel script this week

[heavy marten]

@trail oriole How long should process be..?

It has been over 30 minutes and nothing happened so far lmao

[heavy marten]

@trail oriole Sorry for the ping but VERY GOOD NEWS. I have found the issue concerning the shading of the game!

[humble ember]

👀

[tulip widget]

[heavy marten]

Yeah though I'll need to recreate the actual shader in shader graph.

But yeah the shader graphs are all completely borked from ripping the game

Shader is just.... black

[heavy marten]

Trying to actually export the decompiled shader just errors out:

Time to recreate the shader

[trail oriole]

Yeah haha

[trail oriole]

I assume you figured it out/it eventually finished for you? (I was asleep)

[trail oriole]

sick

[pearl burrow]

I guess something i wanna mention

i feel like the contrast is a bit high specifically in the scene view

not sure why

seems to be post processing

[trail oriole]

Not quite finished with the prefabs part, but it's getting there

[pearl burrow]

is this an automatic sorter you're working on?

oh hey and the assembly sorting too

[trail oriole]

Yeah some more sorting, but it's a bit of a pain to do sorting on these as I don't have access to any game types or anything (since this is tool-level). So can't do anything super specific

[pearl burrow]

dang really?

i wonder what the unity search even checks the value of

[heavy marten]

Getting somewhere...

Quickly added some outlines

[trail oriole]

[heavy marten]

It won't be 100% accurate though

Pure trial and error atm

[sage fable]

Recreating the posterization filter?

[heavy marten]

Yes since the ripping it doesn't work

Somewhat a good replica so far... I'll keep working on it

[sage fable]

its looks especially accurate on the light rays

noice

[humble ember]

@heavy marten dunno how well stuff compiles but i wonder if you could compare your built/yaml etc. shader file to the assetrip one to look for inconsistencies

[heavy marten]

That's the problem. I can't get the game's one to decompile on ripping

[humble ember]

doesnt nomnom have it?

i think i might

[heavy marten]

If you got it it'll make it so much easier for me

[sage fable]

doesnt Acerola scroll through the shader code on his video? i feel like someones gotta have it

[tulip widget]

edge detection drops off btw the farther away from camera it is

so it becomes super hard to see

posterizing the volumetric fog is also done to get that grainy effect on the fog

[humble ember]

@heavy marten this stuff/

?

[heavy marten]

Yes

[heavy marten]

I'll need that and probaly the _0 one as well unless they are the same

@humble ember This is also a dummy shader oof

[humble ember]

pain

[heavy marten]

All it does it set the albedo to Color

Trying to rip the Decompiled version of it does this:

It's all up to me to recreate it at this point..

[tulip widget]

@trail oriole its your fever dream

[pearl burrow]

the guy from the video had what looked like a shader assembly

i wonder where he got that

https://youtu.be/Z_-am00EXIc?t=718 yeah you can see it here

ohhh i see

its from a GPU memory dump

NVIDIA Nsight

[tulip widget]

You can just nab that

[pearl burrow]

im getting it now because it seems like a cool tool

in general

ill tell you if i can figure out how to get a shader assembly myself

[tulip widget]

Unity renders stuff upside at first

[heavy marten]

Yeah the shader will be a shader compiled for NVIDIA GPU API calls

Not shaders we are used to see

Our shader is more "human" than what the GPU actually gets

@pearl burrow I'm getting there

Weird posterization is complete

At least most of it

[heavy marten]

Outline is not much great for this type of thing. I'm sure he makes use of the Gbuffer for it

Which is what I'll be doing next

[trail oriole]

Nice

[heavy marten]

Looks quite accurate

There are some slight differences

But otherwise looks pretty similar

Just need to fix the skybox

And reduce the posterization from distant object

[humble ember]

is it unrealistic to get to like 99%:100% parity?

[heavy marten]

Cause that looks horrendous

[heavy marten]

Trying my best but most likely won't happen

Since we don't have the decompiled shader for it it's basically trial and error

Also the noisiness of the posterization is a unity editor thing. If you'd build the game it won't be like that

The graph looks horrendous lmfao

[trail oriole]

checkboard squad

[heavy marten]

I don't even know how I got to do so much progress already

[pearl burrow]

yeah i know but it'd still be useful wounnit

[severe tundra]

The noise is because he's posterizing light data and depth, and HDRP light is noisy

You can see it in game when a light is higher than the hallways the floor will look noisy as well

I don't know if actual colors are being posterized i didn't dive too deep into the disassembled shader

[heavy marten]

No I meant there's artifacts in the editor, which is normal, I know light is noisy though. There's some dithering in editor

[heavy marten]

Dropping this in here, It makes your game have the post processing that I've made. Simply import it and that's it.

Note the it'll replace the "SampleSceneRelay" scene!!!

This is also WIP!!!

It also adds a separate folder for the posterization asset so it doesn't get lost within the games folder

[severe tundra]

Beautiful

[heavy marten]

Skybox is still broken lol so there's that

[severe tundra]

Curious if it'l cause the same issue with my portals to see if i can try to fix that now :p

[severe tundra]

Wait the original isn't a fullscreenpass i think it was a drawrendererspass :p

[heavy marten]

Yes I'm aware

[severe tundra]

Oh @_@ was just making sure

[heavy marten]

I don't want to do that way it's lot more complicated than FS

Skybox fixed

I made the outside look much better I think...

[heavy marten]

Makes the outside much more enjoyable and accurate:

Same instructions as this: #1199473521265475745 message

[trail oriole]

the heck are the icons on the right

[sage fable]

Diversity player conditions

[tulip widget]

Fix water and the shader that appears when you bring stuff onto the ship

And the blob guy

[heavy marten]

These are all shaders I have to remake...

[heavy marten]

Trying to make this effect more accurate:

[tulip widget]

K

[heavy marten]

Mine:

[tulip widget]

Edge detection

[heavy marten]

Yeah its color based edge detection

That looks better

[trail oriole]

It's lookin good

Hoping to get some sorting done this weekend/laterthisweek to finally push this version onto main

(busy work week so haven't had time yet)

[heavy marten]

It's all guud

I'm also doing this cause I wanna remaster the entire graphics to something vanilla but with some differences

So remaking it will save me lots of time

[heavy marten]

Whenever I finish the whole thing I will cleanup the graph and make it easier to read so others can also do some editing as well for their own projects

Cause rn it's uhhhh

Yeah...

[trail oriole]

mmmm nodes

[heavy marten]

Well I made some sub graphs so it's smaller then what it truely is

My edge detection subgraph

Add that 2 times in the main one

[tulip widget]

unity package update when!!?!?

[heavy marten]

Soon c:

I need to finish a few things

[tulip widget]

@trail oriole I'm trying to test a mod I made with your tool, how do I include that mod in the build

[tulip widget]

It's a multiplayer mod so I have to build and add the mod

Do I just do it as you would normally install bepinex

[trail oriole]

Yeah I think you'd have to install bepinex for the build like normal. Haven't tested that part of it

[heavy marten]

I haven't slept... I'll post the new package when I wake up

[naive steppe]

@trail oriole Is there a public branch available or are you currently just putting out private ones for testing?

[trail oriole]

https://github.com/nomnomab/lc-project-patcher/tree/v0.3.0

[naive steppe]

Sick, ty

[naive steppe]

Just to try to minimize the amount of file moving I need to do and get some clarification, can I run this on my existing project that has LLL and Eva's template, or is does this strictly require a fresh project and then porting over all of my existing work?

[trail oriole]

It needs a fresh project

(mainly since there is not template now, and it uses a specific path or two for some stuff)

But after that I think you can run it in place to re-patch the scripts for future versions, but I've never tried that part

[naive steppe]

Alright. Well I have two backups, so I'll get to work on copying my stuff over :)

[trail oriole]

[severe tundra]

Hmm whats the alternative to patching events, other than manually adding them in the game code :p

[naive steppe]

https://tenor.com/view/cooking-chef-kitchen-penguin-cook-gif-6762191156963652554

@trail oriole

[trail oriole]

Success

[naive steppe]

Gonna try getting Auralis loaded in now, we'll see how that goes

[naive steppe]

Having to reassign scripts and stuff, but that's to be expected I suppose.

[heavy marten]

I just woke up

Imma upload the package now

[tulip widget]

Yipe

[heavy marten]

Better Posterization Effect

[tulip widget]

Have fun figuring out the slime shader LOL

[naive steppe]

@trail oriole is there a way to reconnect the scripts instead of having to go through every field and re-fill them?

[trail oriole]

Like for existing prefabs? For that part I'd use NG tools since that lets you remap on the object level (while the tool remaps on a project level and not with non-game existing stuff obv)

Or do you mean like the field values and not components

[naive steppe]

For the LC stuff I had been using with Eva's template. Like I had pulled the ItemShip and DoorTeleports and such, plus the SelectableLevel scripts from my already existing moons. I can slog through it just fine, but I figured I'd ask if there was a better way lol
Mostly the field values, I don't mind comparing to see what the missing script is. I'm unfamiliar with NG tools?

[trail oriole]

Ah okay, I'm not really sure on how that breaks (I guess something gets mismatched), if it's guids you could maybe see if you updated to their new one if it fixes it, but I don't remember if field values are stored with that (not at pc atm). If they are stored like that in the asset's file, then you could use the debug section of the tool to drop the script into it, and press the button below it to get the guid information and do a bulk replace. Otherwise you might have to do it all manually Does that makes sense?

[naive steppe]

I'll give it a try! Just to make sure, is this the tool you're referring to?

[trail oriole]

Oh yeah, that's when I thought you meant like the components were broken (I misread). This wouldn't help with fields

Is a useful tool to have either way though

[naive steppe]

Ahh, rip. At least I can copy/paste the spawn anim curves across projects (I think), which would really be the biggest hassle to recreate. Thanks for the utility suggestion though!

[trail oriole]

Actually I wonder

How are you moving the assets between projects?

If you export a package of all your prefabs and what-not, it should maintain all the data and connections afaik

[naive steppe]

Ooooh I hadn't thought of that, I was just copying the folder. I'll give that a shot

Should I have "Include Dependencies" checked, or would that mess with your template?

[trail oriole]

You can start with that selected, but just deselect anything game-related (like scripts). The guids might break on the transition over (and would need the replacing with ngtools/manual), but the fields might be fine, so worth a shot.

[naive steppe]

Hm, no luck with that attempt, but I'mma try something else

[naive steppe]

Yea still no luck. I don't have a ton of objects with custom scripts at least, so I'm just gonna do it the manual way, since it seems like that'll take way less time than figuring out a "shortcut" 🤭

Also, should the LLL dll go in the BepInEx folder?

Restarted the project and it told me to use Safe Mode

This was after I re-did it fresh

[trail oriole]

I haven't tested many plugins in-editor if you need to access them for your plugin (like dropping in the project itself). But normal plugins go into the game's normal bepinex directory, or the local bepinex directory (it's in the readme on the exact path) depending on which one you are using.

Guess I'd need more details on what you are doin with LLL

[naive steppe]

Just having it in the project since my moons depend on it, so I figured I'd need to have everything in one project. I also got the NG tools working (no clue why they weren't showing up at first) but it's detecting a broken script in every LC prefab. Is that normal or have I done something horribly wrong?

[humble ember]

they use eva's stubbed scripts and references to those stubbed scripts need to be references to your working scripts

[trail oriole]

I guess I'll have to try and import LLL directly/add a prefab from another project into the project to help out properly. Unless batby is able to help more on the LLL side with the errors. Not sure if I have a meeting tonight yet, if I don't I can look at it before bed.

[naive steppe]

No worries if not, I can stick to what I have working for now, just wanted to be an early adopter of new utilities 🤭

Your tool seems like a dream, being able to test things in-editor so easily

[trail oriole]

Would you be able to maybe share the project that has the working stuff so I have a test case to try and make stuff to migrate easier? Or is it like a "notouchmyunreleasedstuffmister" project currently haha. Otherwise I'd need some kind of example to work with for it.

[naive steppe]

Absolutely! I haven't made any changes since my most recent release, so I'll DM you with a download link. It's a bit chonky though bc of asset store stuff, is there any way you'd like me to pare it down?

[trail oriole]

I'd just need these folders (if the size above includes the Library and stuff)

[naive steppe]

Kk, I'll get them to you soon :)

[heavy marten]

I actually redid the color based edge detection from LC by uh 99% comparison. It's practically identical now

[naive steppe]

Does your shader work in-editor without hitting play?

[heavy marten]

Yes

I think I'm done with the shader

I'll be working on tweaking to make it look as much accurate as possible

The graph is horrendous

[naive steppe]

Nice, good luck!

[heavy marten]

Edge detection is a lot better now

At this point it looks just like the same one

[humble ember]

@heavy marten should do something to let you see 1:1 gameplay with vanilla shader and yours side by side

[heavy marten]

I'll do that

[heavy marten]

While recording I encountered her....

@humble ember There:

[naive steppe]

That's super impressive!

[leaden berry]

welp it just corrupted my relay scene now everything is Missing/Unasigned didint realize it replaces the scene in the unitypackage

[heavy marten]

That's weird... Shouldn't corrupt it ;-;

[quasi elbow]

Damn, can't get my proj to import the assets :/

[trail oriole]

When you finish it you should zip it up + provide instructions on what it needs so I can integrate them with the patcher instead "fix muh shadergraphs" button If it relies on a custom volume and what not, then that part could just be a prefab, and any camera changes could be injected afterward

[trail oriole]

@naive steppe tfw I am making a utility script to put in another project to extract all the type guids so the new project can read that and properly patch the stuff.

I am making progress

[naive steppe]

That's awesome! Glad my project is the guinea pig 🤭

[tulip widget]

@trail oriole How do I correctly add dungen in the asset ripper

[trail oriole]

After step 3, and before step 4. There is a blob about that.

[tulip widget]

How does it want me to add it? As a unity package

@trail oriole

[trail oriole]

Import everything from the package, drag the imported assets into the path it specifies, that's all

[tulip widget]

Ah I see

[tulip widget]

So I just put the dungen folder in Assets\Unity\AssetStore

[trail oriole]

If that's the only folder, yes

@naive steppe

Wait why is it grabbing from the output Heck

[trail oriole]

Welp I fixed the scripts on them, but the prefab links are still busted. That'll be for tomorrow or this weekend

[trail oriole]

The problem was that I didn't even have those prefabs in the other project, I added some (not all because file size) and it seems to properly grab them again. Neat

[naive steppe]

Oh sick, so the patcher worked?

[trail oriole]

Need to do a larger import of your test project to test, but I think so

[tulip widget]

Nice

Buttons to auto import LLL and Shaders

[trail oriole]

Yeah I'm trying to figure out better methods for integrating that stuff, and simplfying the installation more. Just might take a bit. Once Chaos has the shaders good to go I'll integrate that into a patch step so it doesn't break anything.

[trail oriole]

I now have that one dll step automated now, so I can remove it from the steps

[trail oriole]

@naive steppe https://github.com/nomnomab/lc-project-patcher/tree/v0.3.0?tab=readme-ov-file#can-i-transfer-assets-from-another-project-into-this-after-patching Seems to work. Not really sure about how to handle the duplicate assets (like the materials/textures/etc from the original project already existing in the new project) but everything else seems to migrate over to the new stuff.

[naive steppe]

Hell yea, I'll give it a shot later :)

[heavy marten]

@trail oriole For the shader, do you want me to show you the steps for setting it up so you can implement it?

[trail oriole]

Was afk, so just saw this. Yeah, steps + a zip of the content would be good

[heavy marten]

Will do c:

[naive steppe]

@trail oriole Just to clarify bc of the naming here, should I put all my Starlancer assets in here as well? Like the monobehaviour and prefabs I have

[trail oriole]

It's meant for store assets, your mod stuff would go into mods. Don't have to put in either if you don't want to, but it's just the tidy way if wanted.

[naive steppe]

kk, ty

[heavy marten]

@trail oriole Will start fixing the other shaders

I know that slime, ghost girl and the monitors needs fixing but otherwise anything else?

[tulip widget]

Circuit bees

[austere furnace]

the scrap collection thing?

[heavy marten]

Oh yeah that

[tulip widget]

Have you fixed water

[heavy marten]

Not yet I must fix it too

[naive steppe]

So @trail oriole is the graphical discrepancy in the editor the result of a better rip of the HDRP assets, or some different settings from my original project?
I was able to load into the game btw, but I couldn't see my moons. Probably just don't have something set up right yet

Ah, it's because my SelectableLevel scripts broke

[heavy marten]

Oh?

[naive steppe]

¯_(ツ)_/¯

I'm just guessing it's a more accurate rip, but idk

[trail oriole]

It's different because I assign the proper hdrp asset from the game, rather than the normal templates seemingly using the default hdrp asset instead

[trail oriole]

which ones are those?

[naive steppe]

The ones that contain the details of the moon, spawnable scrap and enemies, and spawn rate curves

My audio reverb presets also broke

[trail oriole]

Hmm

pain

oh I don't patch SOs with the external asset patcher

Yep that fixes all that

I'm just dumb

Pushed that for ya

I really should merge 0.3 soon, it's getting a bit thick for its number lol

[naive steppe]

Ah, it all makes sense then 🤭
At least I didn't do something wrong then

I don't have a ton of them, so it won't be too hard to redo them, but imma try and see if NG tools can do it for me. I clicked "manual pick" in the recovery window and it just keeps running without actually showing any progress 🫠

[trail oriole]

ng tools moment

btw the external asset patcher thing can be ran at any time, so if they are still busted it will still fix them

[naive steppe]

Oh sick, thanks 💙

[naive steppe]

Oh also, when I restarted it to get NG tools to show up, it prompted me for safe mode with these. Anything to worry about?

Got this message when I tried to rerun the asset patcher:

[trail oriole]

No idea what the first errors are about. The pop up box is saying you didn't select the json file you exported from the original project.

[naive steppe]

But I did ; - ;

I only have the Extract script in the original project, and I only have your tool in my new project, so I'm pretty sure there's no way I could be having a mismatch

wait

does the json have to be in the original projects asset folder?

welp nvm, I restarted the project and it's running now
IT is dumb

Success \[T]/
You're awesome @trail oriole

Now I just need @heavy marten's shader installation steps and I'm golden 👀

[trail oriole]

[humble ember]

@trail oriole seems a little dodge/low priority but I wonder about a feature where it downloads a thunderstore link and dependencies and puts them in a folder in /Plugins/

I could see it being preferred for devs to just provide a unitypackage tho

[tulip widget]

A fellow assurance prefab moon user I see

[naive steppe]

Fits the best visually without me having to make one myself 🤭

[tulip widget]

I concur

[heavy marten]

Yes gimme 2 sec I'll tell you

You can use my unitypackage but apparently the scene override breaks? so don't override the scene...

@trail oriole @naive steppe Go in SampleSceneRelay then go to Sytems/Rendering/CustomPass in the hiearchy. Then tjere should be a custom pass volume compenent in it. Simply use my posterization material and set it up like in the picture.

[tulip widget]

Is this the same for moons or is it automatic?

[naive steppe]

Awesome, thank you! I'll give it a go in a few. @trail oriole how would I go about getting my custom moon to actually load? I thought it'd just be as simple as putting the assetbundles in the bepinex folder area, but sadly not lol

[heavy marten]

Only SampleRelayScene needs it

[trail oriole]

Never tested the bundles directly in the project tbh. I think those would be loaded normally in the bepinex directory like you'd normally set up LLL for now (Lethal Company\BepInEx next to Assets). I'd have to see if I can extend the plugin finder to outside of assembly-csharp I guess while in-editor.

[tulip widget]

Nomnom, what's your plan after this update of the patcher

[austere furnace]

explode

[trail oriole]

Uhh probably more focus on the bepinex side of things I guess

[tulip widget]

Cool

[trail oriole]

Not sure yet, about to be nuked with normal work stuff between 3 teams so I have no exact plans yet

[tulip widget]

Also I have 2 machines which I use for lan tests however that doesn't work with the tool

It doesn't let lan connections fire

[trail oriole]

lol I don't have two machines to test that lan worked fine on one machine at least

[tulip widget]

Virtual box

It simulates another machine

[naive steppe]

Unfortunately not working for me. I also tried setting it to "Use Game BepInEx Directory" and putting my bundles (and LLL + dependencies) in the game's location and still nada.
Barring loading the bundles in editor, is there any way to force landing on a modded moon straight away by pressing play?

[trail oriole]

Works for me with the same structure it comes as 🤔 (game dir version on left, local dir version on right)

[naive steppe]

hmm, I'll investigate a bit more, ty for the example pics

[trail oriole]

There isn't a quick option for loading into a modded moon yet, but there is a way to auto skip and auto select the first save. Under the tool's menu item (tools/nomnom/blah blah) there is an option toggle for skipping the main menu near the bottom.

[naive steppe]

For some reason that hasn't been working for me

[humble ember]

That will break LLL lol

[trail oriole]

It didn't break it when I used it

[humble ember]

Your skipping where I load the assetbundles 🤔

Unless you did it the right way

[trail oriole]

I use the same execution flow, I just auto-select the buttons and stuff (instead of going whole hog past things).

Same delays that are baked in

huh

Where did the heckin scripts go

why you do this

Well no wonder your bepinex stuff seems broken

The bepinex patcher aint there at all

[naive steppe]

oh

yay it's not me still, I guess ^^;

[trail oriole]

Or I guess check to make sure that folder is empty. Check Assets\LethalCompany\Tools\Plugins\BepInEx\Utility

[naive steppe]

quite empty

[trail oriole]

Yep that's the issue, I have no idea why these got deleted lmao

[naive steppe]

I take comfort in knowing that I help identify issues 🤭

[trail oriole]

[tulip widget]

Ooh your schizophrenic

[trail oriole]

@humble ember yeah it's just this (gray because it's not in the project atm)

[humble ember]

Goat. I wish the mods that do this did it your way aswell 😛

Most of them skip entire scenes

[trail oriole]

Yeah I did that initially to test but it kept breaking the player settings entirely so I came up with this instead

Will be nice to also have this integrate pulling the lever maybe

[naive steppe]

@trail oriole when it's added back, will I need to re-do the initial setup of the project?

[trail oriole]

Normally, yes, but you can also just copy them into that folder from where they are in the package.

[naive steppe]

sick

[trail oriole]

https://github.com/nomnomab/lc-project-patcher/tree/v0.3.0/Editor/Libs/BepInExUtility~ They are in that folder

[naive steppe]

Okay so I updated the package in Unity, but I'm not seeing anywhere to grab those files. Am I misunderstanding something?

[naive steppe]

Ah kk

https://tenor.com/view/praising-gif-9178826062568275723

[trail oriole]

Heck yeah

[naive steppe]

Thanks again for your help, as always ^^ now I'm gonna set up the posterization shader

[trail oriole]

I'll probably start adding that + other shader stuff in 0.4

[naive steppe]

Thank you! I'm assuming we can just copy the custom pass object and put it in a different scene to preview while we work on it and just disable it before building? Or would the game's internal shader take over and wipe yours?

[trail oriole]

Where is that shader again

[naive steppe]

.

[heavy marten]

For previewing yeah

[trail oriole]

Ah okay, thought they were still modifying it after that

[naive steppe]

Maybe, but I can always just update the shader

[heavy marten]

Though this scene never gets deleted on load so if you wanna try it in game only the SampleSceneRelay needs it.

[heavy marten]

Yes I am still working on it

Though if you make the setup in your script I won't include the scene in the package but only the shader so it doesn't break people's project c:

[trail oriole]

What all do you even modify in the scene? If it's just a volume, then I'd just put it in a prefab and I'll just auto insert that into the scene via the patcher

[tulip widget]

Does the edge detection get less accurate the farther out you are like in game?

[heavy marten]

#1199473521265475745 message

[heavy marten]

Yes I implemented something similar

[trail oriole]

Gotcha, so yeah just needs a prefab

[naive steppe]

@trail oriole looks like animator and audio source components get broken in the conversion

[trail oriole]

for your moons?

[naive steppe]

yee

[trail oriole]

ffs okay so because I forgot about commented out code, I have to push another dumb fix for the patcher. If you want the menu skip to work you need to uncomment these btw in the bepinexpatcher script you copied over :)))))))))))))))))))))))))))))

[naive steppe]

I think it might be a similar problem to the materials where I'm already referencing basegame stuff

[naive steppe]

lmaooo thankee

[trail oriole]

Did you not copy over all the stuff from the original project? The fixer doesn't map the materials/clips/etc to new ones.

[naive steppe]

I didn't copy over the basegame assets I had already had ripped, is that what you mean?

[trail oriole]

Yeah, it won't auto migrate those for you, since I don't really have a way to do that part (different folder structures/could have different names/etc)

[naive steppe]

Understood. It's a simple fix for me anyways, I can just go into a vanilla scene and copy/paste

[trail oriole]

Yeah. I could look into a raw name migrator, but that would have to wait until 0.4

[naive steppe]

Fair enough

[trail oriole]

I think I have the steps as automatic as I can make them (for the main patcher)

[naive steppe]

Yee, it's fantastic. Much better than doing all that stuff by hand 🤭

[trail oriole]

[naive steppe]

Triskelion scene has been successfully rebuilt :)

[trail oriole]

[naive steppe]

wait crap, forgot the door broke

[heavy marten]

Ohhhh

I wonder what would happen if I started making moons....

Making open world, 3d renders and modeling is one of my strength

For example:

[naive steppe]

Nice! You'd be awesome at visuals for sure

[tulip widget]

ruhahg

[tulip widget]

Cool moon!

[naive steppe]

Thanks! :)

[austere furnace]

already found my use for this really nice to put some gizmos in there and actually visualise what my numbers mean

[jagged plover]

oh very nice

[naive steppe]

I haven't tested on any vanilla scenes yet, but interior enemies don't seem to spawn while playing in editor for me.

The assetbundles work fine though

[trail oriole]

That's odd

Vanilla spawns interior/outside work fine for me in editor

So might be something to do with your stuff or LLL? Unsure

[tulip widget]

Same

[naive steppe]

Dunno, but I'll keep investigating. In other news, and idk if you can help with this or not, but I can't seem to get my MonoBehaviour script to bundle? Do I need to make it a completely separate plugin to use it in-game?

[trail oriole]

ah yeah I don't really know how to handle the export-side of things if you test with in-editor script versions of a plugin. Since you have to use the same plugin in-game where the mono comes from to load it back up.

So that part is a bit of a gray area on how to approach it.

[naive steppe]

kk, I'll work on it 🫡

[pearl burrow]

i think im gonna use the secret labs mod to test if i can export prefabs and scriptables from a mod and like

test the dungeon flows in the dungen flow analyzer scene

anybody ever try that before

wait

how does LLL work?

this bundle's prefab folder just have a bunch of items in em

[trail oriole]

@heavy marten does this version of it not do proper depth clearing

[pearl burrow]

wait no that was secret labs mod i was lookin for SCPCBDunGen

[trail oriole]

ez adding however

[tulip widget]

@trail oriole So how do I build a mod with your tool

[trail oriole]

Dunno, haven't gotten there yet

[heavy marten]

Oh. Woops forgot to...

[heavy marten]

Try to set clear flag on the custom pass volume to depth and see if that fixes it. If not then I'll do it in the shader manually.

[trail oriole]

Hmm doesn't seem to change anything, regardless of the clear flags value. Odd

[austere furnace]

worked fine for me as well, got jumpscared by the spiders blue legs

[naive steppe]

Either I'm dummy unlucky or I've just got something set wrong. No big deal tho

[heavy marten]

Ight I'll fix it when I'm home

[trail oriole]

Once I do figure out in-editor plugin building, then the netcode patcher won't be needed. So that's fun

[tranquil hare]

That'll be really nice

[tulip widget]

Oh my god yessss my mod is so almost ready to be shipped out

[tulip widget]

Is it possible to do it manually

[spring eagle]

I think I have encountered some problems, how should I solve them?

[tulip widget]

Make sure you have
Git
.NET 8.0 or above

[trail oriole]

Until we get it finalized, gonna have this entry here

[naive steppe]

Is that gonna disable itself upon building asset bundles?

[trail oriole]

why would it

Nothing references it

[naive steppe]

Ah right, I forgot that the issue I had was I was using an object in the scene to let me preview the effect there

[trail oriole]

Ye, I grab it at runtime and clone it so it's all automatic

[naive steppe]

noice

[tulip widget]

Work on building plugins 😸

[tulip widget]

Anyways @trail oriole So how do I setup LLL within your tool

[trail oriole]

@naive steppe what did you end up doing for LLL? LLL dll in project and all the LLL/LethalLib plugin contents in local/game bepinex plugins?

[humble ember]

let me know if you need any help with that nomnom

i haven't looked at it but it's possible my folder search stuff isn't flexible enough?

[tulip widget]

@rugged sentinel could answer that too

[rugged sentinel]

what? who? where? huh?

[trail oriole]

Why ping them for this 🤔 I was working with starlancer with this directly

[rugged sentinel]

I'm here so I might as well dance

[trail oriole]

oh no, dance party

[tulip widget]

I mean what files did you use for LLL to work

[rugged sentinel]

I dragged the .dll into the thing

i think it was something like Assets/LethalCompany/Tools/BepInEx/Plugins

[tulip widget]

What all dll's did you use

[rugged sentinel]

LLL, LethalLib, MMhook

I think that was it

everything under those that was a dll

[tulip widget]

Ight

[naive steppe]

LLL, LethalLib, MMHook in Assets/LethalCompany/Tools/Plugins/BepinEx
With "Use Game BepinEx Directory" checked

[tulip widget]

Did you put all the dlls in there or folders?

[naive steppe]

Dlls

[tulip widget]

@trail oriole Hey so when I add the dll's they don't register when loading in

I finally got it

[naive steppe]

@heavy marten did you mention that you were working on (or going to work on) recreating the blob shader?

[heavy marten]

Yes I did

[naive steppe]

Sweet. Can't place a prefab slime on the planet rn, it'll just be invisible 🤭

[trail oriole]

Still not any closer to being able to build a mod from the editor This wouldn't be so difficult if I could inject a type remapper when the bundle was built, or somehow remap that type when loading the bundle. But both seem impossible so that's fun.

[trail oriole]

ok I might have figured it out, need to test with a more full mod to make sure

[naive steppe]

What do you think the issue was/how full of a mod do you need for testing?

[trail oriole]

Ok it seems to work the way I'd like it to, but only mostly. So for now I think the only way you can actually build a plugin is to make a regular net project and have it copy the output dll into the project mods. Basically the same process you'd normally do to have normal asset bundles functional. The good side of that at least, is that it most mods won't need the extra slew of dlls to import as well, as I already have those set up in the project. The main downside is recompilation times with the dll copies, but you can still test normal scripts in editor when needed. So that's that for now

This is also possible since I added support for in-project mods that aren't in the main assembly, so that's coolio

[tulip widget]

I platonically love you

[trail oriole]

[naive steppe]

https://tenor.com/view/elmo-hello-elmo-rise-elmo-hell-gif-9112913

[humble ember]

I don't think you can reasonably fix it btw @trail oriole but static meshes in scenes combine at build

so a lot of props in the basegame scenes are like stuck together

[trail oriole]

Got an example of what that looks like? Haven't seen it myself

[humble ember]

yeah one moment

[wide jasper]

so i ripped the lethal assets and dragged them into my unity project and im getting these errors anyone know what im doing wrong?

[humble ember]

wym you ripped lethal assets and dragged them

[wide jasper]

i dragged them into my unity project

[humble ember]

from where

[wide jasper]

wym

i dragged these in

@humble ember im in https://discord.com/channels/1168655651455639582/1173405906818564187 rn

[hollow jolt]

is there by any chance a way to use the mods from the folder of an r2modman profile?

[trail oriole]

uhhhh I've never used that before, but I assume it has the same format as the normal bepinex folder?

[hollow jolt]

yeah

[trail oriole]

Maybe I can swap the toggle for the game folder to just some directory 🤔

Or have both and if the path is empty it defaults to the game

That's probably more beginner friendly anyhow

I'll see about adding that for ya soon

[hollow jolt]

also super small (not sure if its fixable) but the exposed params for the diagetic mixer don't seem to have the correct names https://i.1a3.uk/1707874865.png

[trail oriole]

Do you know where the correct names are?

[hollow jolt]

Top 4 would be PlayerVolume0, PlayerVolume1, PlayerVolume2, PlayerVolume3 and the bottom 4 i believe would be the pitch for each player, which'd be PlayerPitch0, PlayerPitch1, PlayerPitch2, PlayerPitch3

[trail oriole]

oh I wonder if UE would have em

[hollow jolt]

not sure why the pitch parameters aren't being detected properly yet the volume ones are but 🤷‍♂️

[hollow jolt]

seems like i cant expose any of https://i.1a3.uk/1707875693.png on the existing player voices https://i.1a3.uk/1707875613.png

[trail oriole]

Weird, obv exposing those wouldn't affect the real one in the steam version, but yeah I'll look into that at some point

[tranquil hare]

The only annoying part about this is having to restart the editor to release loaded mod dlls... not much you can really do about that though

been a great tool

[trail oriole]

Fun fact about that, if the mods are in the editor in v0.4 (not in local or in the game's dir) then you can nuke them fine :) That's how you can now build your dlls from their external project into the editor, test, and rebuild to overwrite.

https://tenor.com/view/todd-howard-it-just-works-bethesda-this-all-just-works-gif-20598651

[tranquil hare]

[trail oriole]

Another cool thing is that all of the normal plugin deps are already in the patched project

So you generally only have to copy over the one plugin dll instead of like 12

[humble ember]

is any of this relevant if your using the basegame folders

[trail oriole]

whatcha mean

[humble ember]

ohhhh is this in context of like dlls that need to be in unity itself for eg. custom scriptableobjects

[trail oriole]

Yeah if you want to build a plugin (and have assetbundles export properly), you basically have to copy it over from a normal C# project

[humble ember]

ye but that's like what youve had to do already right

have assetbundles export properly?

[trail oriole]

How people already do it, yeah.

I now handle like 90% of the process on the editor side at least

Oh yeah you'll probably want to be on the bleeding edge versions while using it for LLL stuff. 0.4 has the experimental posterization shader, supporting the in-editor mod dlls themselves, and bepinex being in the package itself so I can actually update it for people lmao.

[humble ember]

where can i get that

[trail oriole]

https://github.com/nomnomab/lc-project-patcher/tree/v0.4.0 (you'll have to remove the older bepinex utility scripts in tools to support this version)

[tulip widget]

0.4 sounds crazy

[trail oriole]

The heck is that error lmao

[humble ember]

idk but its not letting me play

[trail oriole]

You are playing from InitSceneLaunchOptions right

[humble ember]

yeah

disabling use bepinex folder fixed it

let me know what you need

oh is it the unity adin thing

admin

[trail oriole]

huh

are you using unity as admin

[humble ember]

ye

[trail oriole]

Doesn't it yell at you to not do that

Why is it in admin lol

[humble ember]

ok without admin still

(skip to main menu is off too)

it looks like even though im trying to play with bepinex folder and LLL is running, it's not finding the scripts lll loads

[trail oriole]

I guess I'll test the normal directories again, but I just do this since it's supported now.

[humble ember]

yeah but i want to use my basegame folder

i want that because i want that, not because i can't do something else

(feel like that sounds rude but just being explicit about my intents here)

[trail oriole]

hm now that I think about it, if you have a mod in the project, and also in either the local/game bepinex folders I think it'll get loaded twice 🤔 (not saying that's your issue just realizing that might happen)

pain

[humble ember]

i dont have the mod in the project

[trail oriole]

hm seems to run fine for me with the game's bepinex folder (and LLL + other stuff in it)

I don't get that error or that warning

[humble ember]

rn ive

made new unity project

run tool in 0.4.0

skip main menu false

use bepinex folder

[trail oriole]

What mods are in the game's folder? Maybe one of them is causing issues somehow

[humble ember]

yeeee minimising my mods now

[humble ember]

whats this

[trail oriole]

Just how long it took the entire bepinex process to complete (loading plugins, extra stuff, custom injections, etc)

[trail oriole]

Looks like it can't find whatever the inpututils are

[humble ember]

i just have these now, no more warnings and error looking things but its still not finding ExtendedLevel

[trail oriole]

lol

Basically the same thing

[humble ember]

do you have lethallevelloader in your unity project

[trail oriole]

For this test nope

I guess nuke the editor log, run it again, then throw the log in here so I can look at it. Since I have no idea what's happening

[humble ember]

where can i get the log in a usable state

the core issue is that the bundle isn't finding the classes lethallevelloader has

[trail oriole]

go there, nuke its contents then press play. Should be good

[humble ember]

cleared it and it isnt regenning

oh nvm

@trail oriole https://hastebin.com/share/moziwumewo.makefile

is it concerning that these are not in the order they should be in regards to dependencies?

[trail oriole]

nah I don't really have a way to determine that anyway, I just have the dlls. I wouldn't need that if it auto found dll dependencies anyway, but the editor breaks the auto find so I do what I must (since it scans from exe downward and whatnot). The bepinex deps are still intact since I run that after they are all grabbed anyway.

[humble ember]

ok

let me know if i can provide anything else

[trail oriole]

I was able to replicate it just by having the bundle outside the editor, but I swear that used to work fine. I haven't changed how it loads up the stuff I'll have to look at it tomorrow since it's 1am though

[humble ember]

😔

thank you

for context i dont have like anything in editor

[trail oriole]

Weirdly enough, was curious to see what would happen if you put mmhook, lethallib, and LLL into the editor into tools (with them still being in the game's dir as well). And well, it didn't give the 2nd warning about the level type without an asset, but it still had the missing script on the object. So what the hell is its problem

Maybe it hates me

am I dumb or is it only not finding it for the first one

[humble ember]

scene file != extendedlevel

[trail oriole]

Well yeah, but it's using the same exact type in the loop above it to even print that 🤔 So the type definitely exists, and is actively being used, and seems to be loaded from a bundle to even be able to print that log in the first place. But I could be wrong here, just looking at the code around where that log is on the repo.

[humble ember]

yeah thats why im confused

the fact levellevelloader is doing stuff in the first place should prove that

[trail oriole]

Ok are we sure the bundle just isn't high?

It loads fine in game 🤔

Like even with the warning

Showed up on the terminal, I chose it, and loaded into it. And walked into the pyramid. So I'm confused lmao

[humble ember]

oh frl?

[trail oriole]

What is GameObject '' anyway

No name?

[humble ember]

idk, idc about that first one

its the extendedlevel one that scared me

[trail oriole]

That what seemed to be "missing" from that object

[humble ember]

naur

two seperate things

trust

[trail oriole]

okie, well it seems fine unless there is a magical thing that exploded

[humble ember]

apologies then

you got all the destroy errors right

[trail oriole]

playerinput ones?

[humble ember]

no

not sure if this is gonna be a problem or not

[trail oriole]

huh went to try and load it in-editor again as I had it before and now it can't load into the moon list in the terminal at all. Aight

[spring eagle]

Is that right?

I still confused in these errors.

[trail oriole]

@spring eagle check the info messages and see if they contain anything from the output. Also what version are you on? Could also send the whole log over

[trail oriole]

@humble ember that warning about the GameObject '' also happens in the normal game as well btw (with normal modded game). Also somehow in-editor (with in-editor bundles/libs/etc) RestoreVanillaLevelAssetReferences is getting null enemies, as spawnableEnemyWithRarity is sometimes null, so the .enemyType check throws. Not sure if this is a me thing or a thing about bundles sometimes?

[trail oriole]

ffs

It's in the same managed directory how can you not find it

[trail oriole]

Yeah I have no idea what happened but I straight up can't even load LLL anymore in the terminal even when I revert back to the working project The hell got touched

[tranquil hare]

[humble ember]

I do be using .Destroy

[tulip widget]

@trail oriole So I'm trying to test my LLL mod with your tool how do I do that?

[tranquil hare]

i love unity i love unity

[humble ember]

@trail oriole any chance I need to be more explicit in my destroy calls incase it’s calling editor variants somehow? Or is it a fundamental issue

[tulip widget]

I got it

[trail oriole]

I have no idea tbh. I even added a patch to check if a destroy was trying to destroy an asset, and not do that. But it didn't change the enemies still being null. I might just need to clone LLL and poke it so I can see what issue it actually is.

[humble ember]

@trail oriole do you understand what im doing

I can explain when i get home if not

[trail oriole]

Seems like you are just clearing out the old asset and replacing with a new one, and nuking the old one so it doesn't stick around. Although, if they aren't instances, why even destroy them I wonder. (No idea what else you do to them obv)

[humble ember]

Because other modders use Resources.FindObjectsOfType

and get the fake ones

[trail oriole]

[humble ember]

I don’t disagree

But I gotta play ball

[trail oriole]

which publicizer do you use

[humble ember]

uhh i dont recall

i dont think i do anything with the one i use anyway?

[trail oriole]

Oh I see you use this one

[humble ember]

oh true

[trail oriole]

You use it in a few places to access m_Prefabs and stuff

[humble ember]

ahh right

[trail oriole]

Although it doesn't seem to be doing its job

Unless I am missing an operation with it

(never used this one)

Even their readme looks quite plug-n-play with what you already have, so I dunno

Ah had to add a <Publicize Include="Unity.Netcode.Runtime" />

[humble ember]

@trail oriole no stress on it just keeping myself up to speed, using bepinex folders will cause a problem if i have the same dll in the project too right?

you don't check for doubles and/or still check the project folders with that option enabled

[trail oriole]

I don't check for duplicates atm yeah. Not really sure what it would do

[humble ember]

👍

[trail oriole]

am I high

I added a check for it above

how the hell is it null after

oh wait it's the to string function as well

@humble ember somehow enemies are null in experimentation...?

[humble ember]

is this because of what im doing or because your not accounting for some bepinex config stuff

what line is failing

[rugged sentinel]

Oh btw @trail oriole a few of the Audio reverb triggers in the vanilla maps were missing stuff when I ripped, had to dig and figure out how they worked so I can fix them for my level

[trail oriole]

insideEnemiesOverrides = BindValue("Inside Enemies Spawning List", "Add To Or Override The Inside Enemy Spawn Pool. (Minimum: 0, Maximum: 100)", SpawnableEnemiesWithRaritiesToString(selectableLevel.Enemies));

There are null enemies in that list of level enemies

[rugged sentinel]

I used 0.3.0 , don't know if you ended up catching that after

[trail oriole]

Also null in your vanilla fixer thing

[humble ember]

am i somehow destroying the real references while its being used in unity?

[trail oriole]

This is even with my block so you can't even destroy assets

I have no idea what is going on

blocks all of them so the assets should still be around

[humble ember]

whats AssetDatabase

the unity project right

[trail oriole]

Ye

[humble ember]

i feel like you might be solving the wrong problem?

I don't try and destroy base game assets

Like you shouldn't be catching anything

[trail oriole]

I know, this just removes the error and makes it a warning instead + doesn't actually try to in the first place. It's not so much a fix for your thing

Just used it to see if this was the issue

(and it isn't)

[humble ember]

well i dont know

[trail oriole]

huh

[humble ember]

what if i am correctly destroying the ones in the assetbundles, which has somehow been merged with the ones in the assetdatabase

like you might be catching the direct destroy attempt but not the indirect one

oh actually

@trail oriole is it possible you trying to run this before your catch safeguard just fucked up your rip?

[trail oriole]

oh god

maybe

[humble ember]

like does experimentation still have nulls when you dont play

[trail oriole]

Yeah

[humble ember]

yup

[trail oriole]

asset modifications are perm in editor

Time to re-rip for the 200th time

[humble ember]

would be cool if you had a manifest of all the files ripped so ripping again could potentially just like bring back/update the ones your missing

or smth

or re-rip certain types

[trail oriole]

Not sure what you are referring to here with the triggers, can you expand upon that? Like what stuff is missing

[humble ember]

@rugged sentinel did you try running lethal level loader in unity editor

like at any point

[trail oriole]

oh btw how good are you with .net stuff

Like not code, just the thing itself

[humble ember]

anything that isn't c# i dont really know or have any love for

[trail oriole]

Ah, someone has an issue with having .net 8 and still being unable to run asset ripper for some reason.

And I have no idea how to assist with it

[rugged sentinel]

Yeah I think so but I couldn't get anything to work in the editor as far as testing my map I just went back and forth with r2

[humble ember]

yeah thats why

current unity assetripper has an issue with .Destroy

running LLL destroys assetrip assets

[trail oriole]

Once I rerip I can verify if my guard works for this

It should

[rugged sentinel]

A buddy of mine that I'm working on mods with had the exact same issue

He couldn't rip anything

[trail oriole]

Was he able to fix it? I have no idea what is missing (the link was not very helpful in saying what it was either)

[rugged sentinel]

Nah we haven't had a jam sesh in a bit we were going to try again later

[trail oriole]

Ah okay

[rugged sentinel]

Sorry I couldn't be more helpful just wanted to let you know it's not some one off thing

[trail oriole]

No worries, just annoying that I have what is missing, I don't know what it is, so I can't test for it

New rip and somehow the default enemy list is smaller than what I had before lmao, the heck

Ok they no longer get nuked

IT WORKS AGAIN

Jesus christ

Wasted a whole day on this

[humble ember]

i mean its a pretty big deal

wasted isn't the right term

[trail oriole]

Like I had the destroy guard yesterday

All day today was trying to see if my thing was broken lmao

(it in fact was not broken )

[humble ember]

sorry about that

[trail oriole]

All good, don't know why I didn't think to just check the level

[humble ember]

the one last piece of the pie to get devving fairly nice is the checking/ignoring duplicate dlls and/or ignoring the project folders if use bepinex is enabled

[trail oriole]

Might add a toggle for that since some people might want to test some custom plugin in-editor alongside the game stuff. Generally you'd want everything in the editor (since that's mainly the preferred approach), but I'll handle this other case as much as I can.