#Lethal Things

1 messages · Page 6 of 1

tepid parrot
#

I imagine that when items are removed in the config they are not loaded into the game, or are they just not visable?

willow abyss
#

Completely removing items after already loading causes issues

analog dock
#

I doesn't do it with things from other mods that are disabled in the shop tho

willow abyss
#

This is a lethal lib thing also, not a lethal things thing

analog dock
#

This okay to run with LobbyControl? Or does that also prevent corruption of items

willow abyss
#

Anyway bed time

tepid parrot
tepid parrot
glad yew
tepid parrot
glad yew
#

I highly recommend using Matty_Fixes btw

glad yew
analog dock
#

Thanks guys 😄

glad yew
#

Smart Item Saving prevented me from getting a corrupted save when AbandonedCompanyAssets had the bug with the abandoned flashlights 😅

tepid parrot
#

I was also saved then hahaha

analog dock
#

Do I need LobbyControl if I get Matty's Fixes?

glad yew
glad yew
#

I would use LobbyControl Experimental btw, for proper compat with ReservedItemsCore

analog dock
tepid parrot
#

Yeah he did

#

It is in the live version now.

#

Using LobbyControl should work fine.

glad yew
#

Okay well originally it wasn't lol

tepid parrot
#

All good. 😛

#

@analog dock #1178456016254414878 message

tepid parrot
#

@willow abyss

found some errors.

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
LethalThings.Patches.PowerOutletStun.GameNetworkManager_Start (On.GameNetworkManager+orig_Start orig, GameNetworkManager self) (at O:/github/LethalThings/LethalThings/Patches/PowerOutletStun.cs:30)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.HookGameNetworkManager::Start?-1995997408(GameNetworkManager)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.TrampolineGameNetworkManager::Start?-1000219854(GameNetworkManager)
LethalThings.MonoBehaviours.GremlinEnergy.GameNetworkManager_Start (On.GameNetworkManager+orig_Start orig, GameNetworkManager self) (at O:/github/LethalThings/LethalThings/MonoBehaviours/GremlinEnergy.cs:28)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.HookGameNetworkManager::Start?2143665364(GameNetworkManager)

inland nexus
# tepid parrot Yeah he did

ReservedItemSlot compat is only in Experimental for now.. as it's a big rewrite i want it tested a bit, but release has a manual compat with a config list of slots numbers to ignore

spring gate
willow abyss
#

yeah

#

the github just does not contain any of the unity side stuff

spring gate
#

oh okay, thanks

#

that's fine

#

I got everything imported and building correctly with the main branch

#

just need to swap the files out with dev branch

willow abyss
#

that error isn't necessarily related to this mod tho

#

that error is thrown when an item is used on the charger that is missing some stuff

spring gate
#

yeah

willow abyss
#

actually no

spring gate
#

well wait a minute

willow abyss
#

not even charger

spring gate
#

isnt it run on start for gamenetworkmanager

willow abyss
#

this is just a monomod thing

spring gate
#

I played with the main branch files yesterday, it seemed to error when trying to check / modify a prefab with missing parameters

willow abyss
#

the stacktrace includes my stuff because i hook the function that had an error

spring gate
#

the top of the stack is your GameNetworkManager patch in PowerOutletStun

willow abyss
#

well i am just saying, if any mod causes an error anywhere in GameNetworkManager.Start all functions that hook that function will be in the stacktrace

spring gate
#

right that is also true

willow abyss
#

Plugin.logger.LogInfo($"Found {prefab.Prefab.name}");

#

this line errored

spring gate
#

yeah

willow abyss
#

because it would still just tostring

spring gate
#

I think it can be fixed with prefab?.Prefab?.name

#

which will just output null if prefab.Prefab is missing or prefab itself is null

willow abyss
#

the issue seems to be that there is a networkprefab somewhere in self.GetComponent<NetworkManager>().NetworkConfig.Prefabs.m_Prefabs that doesn't actually have an attached gameobject

#

which means something somewhere is very wrong

#

lol

spring gate
#

generally speaking its a good idea to use that null accessor operator to avoid incidents where a mod loads a corrupted prefab

willow abyss
#

i recommend looking into what mod is causing it in the first place

spring gate
#

thats a good idea yeah

#

I think it would also be helpful to use those null accessors just so lethalthings doesnt break more things if another mod happens to be broken

spring gate
#

one of the files in the dev branch refers to a namespace LethalThings.DynamicBone which doesnt seem to exist in the file structure. is this available anywhere? @willow abyss

willow abyss
spring gate
#

oh got it

willow abyss
#

i think i made modifications to it though

tranquil ibex
#

Any chance we'll ever get the boomba & or teleporter trap seperate?

glad yew
tranquil ibex
astral bay
#

I dont use tp trap due to the spawn rate being uhh

astral bay
tranquil ibex
astral bay
#

what issues

tranquil ibex
#

😐

glad yew
#

Btw setting this to false will prevent compat issues

astral bay
#

I dont think ive had issues?

analog dock
astral bay
#

not sure tho

tranquil ibex
#

It's nothing major just scraping errors out of modpack

#

from what I can tell it's relatively fine just disabling the mod actually bumped my frames slightly

#

could be within marigin of error though so idk

glad yew
#

So just disable the plushies you don't like that much

tranquil ibex
#

will try it again once I get done with other problems

glad yew
astral bay
#

if you care about performance (it may be fixed now) but I noticed that emote mod lowers fps by a bit

tranquil ibex
#

I'm rocking an average 120 with 110 mods on custom moons

tranquil ibex
#

we will see, trying now

astral bay
glad yew
#

Probably just needs some optimization

glad yew
# tranquil ibex

You can replace TME with BadAssCompany tbh if you want more performance

tranquil ibex
#

Performance is negligible

glad yew
#

You were just complaining about Lethal Things causing you lag not long ago wdym

tranquil ibex
glad yew
south cloak
south cloak
#

Ok that's what i thought, doesnt really matter then

small grove
small grove
#

i get like, frame drops from 80fps to 50-45fps

#

and I've got a pretty good pc

spring gate
#

@willow abyss I think the github dev branch is ahead of the build on thunderstore because I'm seeing some enemies appear in the config that I havent seen before + some errors related to unreleased features when I fixed the prefab things, but anyway here's what I changed to solve the errors:

GremlinEnergy.cs:

private static void GameNetworkManager_Start(On.GameNetworkManager.orig_Start orig, GameNetworkManager self)
{
    orig(self);

    List<NetworkPrefab> prefabs = self?.GetComponent<NetworkManager>()?.NetworkConfig?.Prefabs?.m_Prefabs;
    if (prefabs == null) return;

    foreach (var prefabContainer in prefabs)
    {
        GameObject prefab = prefabContainer?.Prefab;
        if (prefab?.GetComponent<BlobAI>()?.enemyType?.enemyName != "Blob") continue;

        blobPrefab = prefab;

        //Plugin.logger.LogMessage("Found blob prefab!");

        break;
    }
}

PowerOutletStun.cs

private static void GameNetworkManager_Start(On.GameNetworkManager.orig_Start orig, GameNetworkManager self)
{
    orig(self);

    List<NetworkPrefab> prefabs = self?.GetComponent<NetworkManager>()?.NetworkConfig?.Prefabs?.m_Prefabs;
    if (prefabs == null) return;

    foreach (var prefabContainer in prefabs)
    {
        GameObject prefab = prefabContainer?.Prefab;

        // Using this to search for bugged prefabs:
        /*
        if (prefab?.name == null)
        {
            Plugin.logger.LogWarning($"Found a potentially bugged prefab! Container [{prefabContainer}] | GameObject: [{prefab}]");
        }
        */

        if (prefab?.GetComponent<GrabbableObject>()?.itemProperties?.isConductiveMetal != true) continue;
        
        Plugin.logger.LogInfo($"Found conductive scrap [{prefab.name}]");
           
        var comp = prefab.AddComponent<LethalThings.PowerOutletStun>();
    }
}

and for what its worth, I wasnt able to catch any corrupted prefabs with that commented out warning log even in the modpack where the error was previously occurring. so I guess the error originated from before the loop? regardless, this does fix the issue

#

I'll also just test and make sure gremlin energy is actually working

spring gate
#

just tested the thunderstore release with the above changes applied (by compiling from the code reported by ILSpy) and everything is working correctly. GremlinEnergy was throwing an error if you died by drinking it though, which I solved with this last adjustment to GremlinEnergy.cs:

public IEnumerator undoAnimation()
{
    yield return new WaitForSeconds(3f);
    if (base.IsOwner)
    {
-        // damage player
-        playerHeldBy.DamagePlayer(50, hasDamageSFX: true, callRPC: true, CauseOfDeath.Unknown, 1);
-
        playerHeldBy.playerBodyAnimator.SetBool("useTZPItem", value: false);
        playerHeldBy.activatingItem = false;
+
+        // damage player
+        playerHeldBy.DamagePlayer(50, hasDamageSFX: true, callRPC: true, CauseOfDeath.Unknown, 1);
    }
}

@willow abyss

lethal marten
#

these look the exact same

willow abyss
#

i guess

spring gate
#

yes order of execution for the last one

#

the first two do basically the same as before but use null access to avoid null reference

willow abyss
#

alright i pushed the patches, i hope i didn't forget to comment out any of the work in progress stuff

#

lol

astral bay
spring gate
#

🙏 thank you

#

trying to make my modpack stable and less error prone but lethal things was too iconic to cut out

#

now I've only got morecompany and terminalplus to deal with

spring gate
#

or the rocket launcher

#

or the utility belt or remote radar or teleporter trap

#

one time on experimentation the only way forward was through a door that had a teleporter trap and it teleported me into an area surrounded by bunker spider webs lmao

#

it took me way too many tries to crouch jump through the door frame to get around it

turbid fox
#

woah... an update..

#

what new in this update?

glad yew
south cloak
turbid fox
#

Nice good shit

cloud juniper
#

Apparently the latest update has broke the remote radar??
Thats what my friend is saying, i'll get on in a bit and test and give a log if thats the case

cloud juniper
#

Can confirm, the radar just doesnt update your position, its locked at the ship

#

The pack i used at the time:
018e67bb-26b2-8bfe-9aa1-0c54ed84c417

ashen nimbus
willow abyss
#

uhh i guess that was one of the work in progress things i forgot about lol

royal lynx
#

weird error when i, not the host, started the ship towards rend, i wasnt using a utility belt nor was anyone like it says in the error(i think thats what its saying)

cloud juniper
# high yew

This would make a great reaction bubble gif

high yew
#

we were running away from a bracken and my friend said to just use the tp

#

the tp in question

storm saffron
#

I mean... as long as you stay on the mine till you tp...

#

Might even kill the bracken with it

dusty heart
#

i use the jetpack to kill the bracken

eternal halo
#

make it where fumos can spawn on the roombas

coarse pine
#

god is coming

whole pecanBOT
#
Luke 3:11 - Revised Standard Version (RSV)

<11> And he answered them, "He who has two coats, let him share with him who has none; and he who has food, let him do likewise."

coarse pine
#

he is merciful today

#

I think

restive zephyr
turbid fox
#

im sorry for the ping but what mod that give you a brick to throw?

muted remnant
turbid fox
#

thanks!!

verbal pollen
#

Unfortunate that MusicalInstruments is broken :(

marsh zealot
#

The items when I charge the lobby change continuously

astral axle
#

Just so it's logged here, LethalThings doesn't seem to be working in v50 as of now

manic wind
#

now im sad since lethal things isnt gonna be updated and will prob break

astral axle
willow shoal
#

Is it public ?

iron solstice
#

beta is public yes

willow shoal
#

How can i play it?

iron solstice
tender python
#

i hope lethalthings gets updated so i can still throw glizzies around 🥺

manic wind
marsh zealot
#

@willow abyss

primal dagger
#

i have tried not to spoil v50 for myself too much until it actually releases, but i do know that (or i'm pretty sure at least) (SPOILERS FOR V50 AHEAD!!!!!!!!!!)

#

||forest giants can now be burnt by lightning/explosions and die, which porbably means that you can now kill forest giants with a single rocket launcher rocket. that feels a bit overpowered tbh||

#

so this gives rocket launchers a HUGE buff and idk if it's for better or for worse

steady topaz
#

The rocket launcher was designed to be ridiculous rather than balanced, at least i intended it to be so

dusty heart
#

||forest giants WILL BURN TO THE GROUND!!!||

manic wind
#

Maybe my group is just bad

restive zephyr
#

rocket jumping !!

manic wind
willow abyss
#

was whatever update this is about released already? because i don't want to update for a beta since it'd be hard to support both beta and main with the same mod

royal lynx
#

plus LL is borked rn with v50 beta anyway, someone said they'll fix it later

glad yew
#

That someone was @visual prawn

#

LOL

royal lynx
#

Potato patata

glad yew
analog dock
#

LethalThings items showing on sale (in DiscountAlerts) when they're disabled is definitely a LethalThings bug, because they also show up on sale with the GeneralImprovements monitors

marsh zealot
#

The item which I buy on the shop when I log in the lobby change every time

scenic rapids
#

Not sure if this is a known issue but the flaregun can sometimes become pretty much inaccessible if placed inside the cupboard at certain positions. It kind of dips into the shelf and prevents you from picking it up.

willow abyss
manic wind
#

rip peak mod 🙏

honest solar
manic wind
#

isnt it not gonna be updated

#

as eba isnt interested in LC modding anymore

honest solar
#

oh no

manic wind
#

im gonna miss the boomba and teleport mine

dusty heart
#

rocket launcher ):

manic wind
honest solar
#

maybe someone will be approved to continue the mod

manic wind
#

ive been looking to spend some money lol

stoic ingot
#

@manic wind where did eba announce that?

manic wind
astral bay
#

its also just apperent in the thread theye dont really update the mod and arnt as active

#

nothing wrong with that tho its a hobby if you dont wanna mod a game anymore thats perfectly alrighjt

glad yew
glad yew
#

It's an old mod that's barely maintained stuff like this is to be expected unfortunately

manic wind
#

: (

astral bay
#

LT boomba kinda fits in the enemy mod I wanna do

glad yew
#

I had to remove it from my V49 pack cus it started conflicting with something and would cause high networking spikes and kill my streams

#

Yeah I miss Boomba

astral bay
#

yea i have a enemy mod planned to have more simple enemies

#

more small enemies

manic wind
astral bay
#

that arnt meant as much to be scary and more so a hazard

#

because that has not been done much yet

glad yew
#

I loved the scraps

#

Arson, Cookie, The Glizzy, and Gnarpy are all peak

astral bay
#

I just need a coder lol because I can only model

manic wind
#

he did mention he wanted to wait till v50 for doing mods tho

glad yew
#

The amount of times I had someone get stuck in a ceiling or wall

#

XD

astral bay
#

its not really the same

manic wind
#

closest option

#

boombas are way more aggressive tho

glad yew
#

Are the assets for the Boomba part of the MIT license?

astral bay
#

id guess not

#

would have to ask the modler

glad yew
#

I think some things are, like some of the scraps since @upper bridge Was able to make Maxwell and Cookie as scrap eaters I just dunno what is and what isn't lol

astral bay
#

1 of these 2 made it

glad yew
#

Yeah

astral bay
#

Bobilka might have but I checked there page and saw like rocket launcher but no boomba

glad yew
#

Well if Antlers did it you can contact her pretty easily

astral bay
#

true

#

did you make the boomba model

#

or was that somebody else

astral bay
glad yew
#

Oh nvm

#

My bad

#

My brain had a derp

#

XD

glad yew
#

I saw the "Or was that somebody else?" after you @ted her lmfao but my brain skipped you asking if she made Boomba model

glad yew
#

My cats actually do shit like this

#

LOL

#

The amount of times one steals the bowl from the other

manic wind
glad yew
#

XD

manic wind
#

the only like mugs

glad yew
#

lol

#

Maybe I should try that, maybe it's easier for them to see the water

manic wind
#

hes a good boi

astral bay
glad yew
#

I wonder if Antlers would be okay with Cookie Fumo being made a seperate scrap

#

I miss Cookie

astral hull
#

I thinky

#

Might have also been hyena

astral bay
astral hull
#

Probably bobilkga

#

True…

#

I just know I didn’t make it

astral bay
astral hull
#

Yeah that’s fine as long as you credit it

#

I should really remake the model at this point

glad yew
glad yew
#

:3

astral hull
#

I don’t mod

glad yew
#

Hehe

#

I wanna see the new model though

astral hull
#

We’ll see

glad yew
#

I think Zehs would be the perfect person to upload the scrap, since they already made Cookie a scrap eater tbh

astral bay
#

what bet

astral hull
#

I lost privileges to change my name for two months

glad yew
#

Oof

astral hull
#

So Robin has had full control over it

astral hull
#

Hello hyena

#

You were foretold only in legend (Eva mentioning you)

astral bay
glad yew
#

Do we know who made the other scraps?

astral bay
#

so I guess bobilka made the boomba model

glad yew
astral bay
#

but doesnt have it on there page

astral hull
#

I made the fart board, darts, teleporter trap, and cookie

astral hull
glad yew
#

Ooh

manic wind
#

I almost forgot this being really the only furniture mod

astral hull
#

I probably made other stuff I just forgor lol

glad yew
astral bay
#

maybe not me but somebody could

#

I cant code just model

astral hull
#

It’s been a while since I’ve modeled for the mod

astral bay
astral hull
#

I made the creature that’s still sitting in eba’s beta branch

astral bay
#

the silly

glad yew
#

It's so cute

astral hull
#

If someone adopts the mod and finishes the enemy AI

#

Friend AI

#

For now it’s kind of just abandonware

astral bay
#

same with that like

#

whatever the fucking

astral hull
#

@willow abyss did you have any idea for legal guardians

astral bay
#

I dont know how to describe it

#

it was some big machine

astral hull
#

Maggie

#

Maggie is finished though

#

I’m not sure why she isn’t out

astral bay
#

👀

glad yew
astral bay
#

it would be nice if they could hand off the project to somebody who is

glad yew
#

Ye

astral hull
willow abyss
astral hull
#

Creature doofus just made eva so frustrated she just lost all interest

willow abyss
#

they mean the uhh

#

deliver robot

astral hull
#

Oh!

#

Ruckus

willow abyss
#

yeah, that one has no ai or anything yet

#

it only has a model

astral hull
#

And a thousand names

willow abyss
#

so true

astral hull
#

Hi eba!!!

willow abyss
#

(not really i just burnt myself out i think)

astral hull
#

Thank you for reminding me to slap slaire today I forgot

willow abyss
#

also i think friend was finished

#

maybe?

astral hull
#

Anyway did you have ideas on who would adopt the mod

willow abyss
#

idk

astral hull
#

Sconey or Batby or Max

#

Or potatoe if you really wanted

royal lynx
#

thats quite the selection

glad yew
manic wind
#

maybe there should be a mod adoption agency for abandoned and open source mods lol

willow abyss
#

who whar

royal lynx
#

i would help port if need be but currently super busy with my mod, plus 90% of the code in LT i dont really understand/find unnecessary so i might break something

willow abyss
#

if someone wants to setup github actions for lethal things i'm fine with letting people push updates

royal lynx
#

a lot of the networking thats done is something I dont see the reason for being there

willow abyss
#

lethallib already has that

astral hull
glad yew
royal lynx
astral hull
#

I have been drilling into her better practices but it just rolls off her brain

#

Tooo smooth

unkempt silo
willow abyss
willow abyss
#

noita arena has the most indepth commit messages ever

royal lynx
merry summit
#

lmao I need to fix my own mod first cx, but I do like this mod

royal lynx
#

i think there was like a whole config for networking

willow abyss
#

If someone can uhh

royal lynx
#

i didnt really understand much of the reason it was there

#

this part

glad yew
#

I'd say Batby, Sconeys, or Zehs for sure are all solid choices to adopt it

willow abyss
#

bully lordfirespeed into setting up github release actions

royal lynx
#

i think hes on vacation rn

astral hull
willow abyss
astral hull
#

Commit messages and comments are related enough for me to make a bad segue

willow abyss
#

Oh another problem with lethalthings is that the unity project is FUCKED

#

and not in the repo

#

because it includes every single one of the game assets

glad yew
#

Yay Unity, @royal lynx having to redo all their scripts yesterday cus Unity corrupted them

willow abyss
royal lynx
#

but ur version might just be too old tbh

astral hull
#

Eva is fossil

royal lynx
#

the enemies can probably be easily ported tbh, im just worried about the scrap and shop items

#

those might just have to be redone almost from scratch from what i've seen happening

glad yew
#

The scraps work in V50 though, it's other code in LT that seems to break enemy and hazard spawns

#

I just dunno what

#

Batby would know

royal lynx
#

ehhh its weird to explain, but the enemies are majorly fine

glad yew
#

I see

manic wind
#

idk why but Id think hardest would be utility belt and dart board

glad yew
#

Utility belt at this point is sort of a deprecated feature though

glad yew
#

We have mods like Hotbarplus and ReservedItemSlots

glad yew
#

It's not as necessary as it used to be

willow abyss
#

i don't personally agree

#

as i would never use one of those mods

#

since they feel like cheating

glad yew
#

Fair, fair

willow abyss
#

(imo)

#

the whole point of the utility belt was to be a more gameplay integrated way of doing those things

royal lynx
#

i've always use utility belts, they seemed like a more fitting option for me

manic wind
glad yew
#

I do know Utility Belt rn is one of the buggier features

willow abyss
#

utility belt was always very prone to breaking when other mods mess with the inventory

willow abyss
#

AC?

#

idk what that is

glad yew
#

Advanced Company.

manic wind
willow abyss
#

oh yeah but advanced comp broke like a bunch of other stuff in my mods in the past

#

lmao

astral bay
#

AC is gone now

manic wind
#

Eh, never really had it break stuff

willow abyss
#

it used to break some terminal stuff

#

idk

manic wind
#

those broke a lot

royal lynx
willow abyss
#

lmao

#

i think thats still the case

glad yew
#

XD

willow abyss
#

i never pushed the thunderstore release to github main and then kept updating dev branch

#

so dev is ahead of thunderstore and main is behind

royal lynx
royal lynx
glad yew
#

but yeah probs

willow abyss
#

in all honesty

royal lynx
#

when im done with projects, if no one's picked this up and you dont mind sending me the assets i dont mind doing an overhaul from mostly scratch

willow abyss
#

i have no idea what changes are on the dev branch compared to thunderstore

#

like no clue whatsoever

#

lmao

glad yew
ember umbra
#

buh, that's why I don't do manual update

royal lynx
#

batby's gonna wake up to 5 pings from this

manic wind
ember umbra
#

only auto update

glad yew
#

Yeah Batby is

#

They're working on maintaining both LLL and LethalLib now

willow abyss
#

preferably i'd do the same thing as lethallib, where we set up github actions and i just give a bunch of people permissions

royal lynx
willow abyss
#

that'd require fixing the unity project and stuff first

royal lynx
#

just up until v50

#

no point to

manic wind
glad yew
manic wind
royal lynx
#

already has afaik, we're just waiting on v50

glad yew
#

I know the next update for LL is gonna fix the issues with the power level code on V50

glad yew
#

No

#

Batby fixed the main issues but discovered the power level code can still cause problems

#

it's why for example

#

Scopophobia breaks enemy and hazard spawns on V50 right now

#

But Scopophobia still needs updated

#

To support the new LOS code

manic wind
glad yew
willow abyss
#

it sounds like hell to have a mod work on two versions of the game if there is major differences, function signature changes would make the normal mmhooks basically impossible (talking lethallib)

royal lynx
glad yew
#

Scopophobia doesn't throw errors though so makes it difficult to know for sure

manic wind
royal lynx
glad yew
#

Is the code for only 1 shy guy not working

#

It spawns 2-3 pretty regularly for me

#

But there's supposed to only be 1

#

Lol

manic wind
#

ususally one inside and one outside

glad yew
#

Yeah

royal lynx
#

thats just the dev not setting the unity project right

#

nothing to do with LL

glad yew
#

But I've had a case where there were 2 inside and 1 outside before

manic wind
glad yew
#

It would help if the dev open sourced it tbh

royal lynx
#

welll not in this scenario but yes, open source is best

glad yew
#

Idk if it's harder to suggest it

#

Since he doesn't have it on github

#

Lol

royal lynx
#

i swear to god next beta ill just record a guide on how to do it

glad yew
#

I mean hopefully Zeekerss doesn't rewrite the LOS code again

#

☠️

royal lynx
#

i mean, it was a good chance

#

change*

#

im all for this change

glad yew
#

It was

royal lynx
#

opens up 100x more enemy possibilities

manic wind
glad yew
#

The Forest Giant ai is a lot better in V50, which is why I'm so surprised FairGiants updated

manic wind
glad yew
#

They don't just stand there

manic wind
#

but havent seen too many giants in v50

#

just in general

#

most I saw was when ||adam had the spawn rates of art||

high yew
#

but with giant fair ai they kinda feel a bit dumb, but honestly would prefer that any day over whatever it is in vanilla

sturdy skiff
#

Apologies if this was already addressed before ||(and the mod not being in active development ig)||

But has anyone encountered the bug where LT store items appear on sale but have their full prices applied on purchase?
Did anyone find a fix for that or do I just have to deal with it? 😛

scenic rapids
#

Found another bug wherein the rocket launcher's ammo isn't maintained between closing and re-opening a save, it empties out.

weary remnant
#

Does this mod work with v50's spike traps?

#

I heard somewhere that the teleporter traps mess with the spike trap code

glad yew
#

Lethal Things doesn't work with V50 period.

weary remnant
#

Awww, sad

#

Maxwell, my beloved

glad yew
weary remnant
#

Will it be updated once v50 officially comes out?

glad yew
#

This could change, @royal lynx might be taking on the project but it needs a whole rewrite

restive zephyr
#

oh no xu isn;t playing d&d anymore? :(

royal lynx
restive zephyr
#

damb

royal lynx
#

sure way of eliminating the entire party

restive zephyr
#

i'm glad i don't have to deal with the media chief

glad yew
#

lol

#

But Sconeys said they're focusing on their own mods rn

royal lynx
#

i feel like you misread my message

glad yew
#

Probably

royal lynx
#

slayer is talking about DND as in dungeons and dragons

glad yew
#

Oh I see I see now

#

My b my b

weary remnant
#

I removed lethal things but I'm still getting no enemies

#

Just nothing but this in the console

glad yew
weary remnant
#

Any idea which?

glad yew
#

Idk

weary remnant
#

Been trying to figure it out for days

#

I have LL but it's been updated to support v50, right?

glad yew
#

Yes

#

If you're using Locker or Scopophobia

#

disable those

#

Well Locker should be fine it just doesn't work

#

Scopophobia breaks enemy and hazard spawns though

weary remnant
#

Oh, I am using locker

#

018ec681-ce34-c22f-066b-935a4a01c1e0

#

I'll disable them

manic wind
#

wip update

weary remnant
#

Disabled it now

glad yew
#

Yeah Locker doesn't break spawns though

#

it just doesn't work at all

#

XD

weary remnant
#

Oh lol

#

I'm trying to figure out what in my pack is breaking spawns

manic wind
#

its locker

glad yew
#

Probably Scopophobia if you have it

weary remnant
#

I do not

manic wind
glad yew
#

I mean idk what enemy mods you're using

#

You should really check the chart tbh

manic wind
#

also peepers

weary remnant
#

Oh, I got both hecc

glad yew
manic wind
glad yew
#

But Peepers yes

weary remnant
#

I'm gonna miss those little guys

manic wind
#

or is it still wip

glad yew
#

No

#

It's still wip

weary remnant
#

It's very close to releasing

#

The second giant

manic wind
#

I guess that page was update early "Mod that adds a variety of giant enemies, part of the forest keeper family, Currently adds 2 brand new enemies."

alpine wraith
#

Peepers will be what is breaking it yeah

manic wind
weary remnant
#

I thought that got updated like yesterday

glad yew
#

Yeah harpist works with it rn but the new enemy is buggy

manic wind
glad yew
#

Haunted Harpist doesn't feel very vanilla friendly anyways

manic wind
alpine wraith
glad yew
#

More the ghost model itself tbh

#

lol

alpine wraith
#

I guess

weary remnant
#

Kind of a bit silly

#

But I like it

manic wind
#

tbh

#

Although I HATE the fiend

glad yew
#

The Fiend is such a mid mod tbh

alpine wraith
#

It's true it's silly and the model of the ghost itself is a little out of vanilla art style but I also think it's a little silly to be sayin that with some of the other mods being used lol

manic wind
#

also the jumpscare is cheasy

upper bridge
#

I've also noticed some issues with LethalThings that should be fixed

glad yew
#

Yeah I think you just need the assets from @willow abyss right?

upper bridge
#

I already decompiled LethalThings before for the Maxwell and Cookie Fumo assets.

#

Maybe, but I could also work with the stuff from the asset bundle.

#

Some things that need to be fixed are:

  • Maxwell saving the dance/play music state.
  • Scrap items audio being heard from the entire map

There's more stuff, but that's all I can think of at the moment. I'm eepy >w<

alpine wraith
willow abyss
#

there is some other issues i know of tho, notably the configs don't sync super well

#

also i was planning to update the mod for v50 when it releases, i thought the changes weren't that large?

#

certainly not to the point of requiring a full rewrite

royal lynx
royal lynx
royal lynx
glad yew
#

Batby never really went into detail on what all is causing that

#

Just narrowed it down to LT has code that's doing it

willow abyss
#

i mean probably is just a function signature that has changed for the enemy ai classes

#

tho that should show up in the debug console

glad yew
#

Yeah you'll have to check, I'd love to know what caused the networking problems in my v49 pack too

royal lynx
willow abyss
#

i have not touched v50 whatsoever so i have no clue whats even wrong

royal lynx
#

I'm assuming the roomba probably uses the LoS code anyway

glad yew
#

Yeah the Boomba likely does so it'll need the new LoS code

willow abyss
#

honestly just trying to compile with the v50 dlls is probably enough to point out the issues

glad yew
willow abyss
#

unless there is missing properties on the assets themselves, which would require updating the unity project and i ain't doing that

#

lmao

glad yew
#

I know some of the networking code was changed too, cus GhostCodes for example on V50 caused me networking spikes I didn't get on V49

glad yew
#

XD

royal lynx
#

Gl Zehs

glad yew
#

Zehs is a good dev tbh

#

I believe in them

#

They've made a couple of mods that I find to be essential

willow abyss
#

lmao

#

when i try to compile against v50

#

the only error i am getting is for a unfinished enemy

glad yew
#

Odd 😆 so I guess it's probably just come code in V50 that conflicts

#

Or maybe it has to do with the unfinished enemy

willow abyss
#

Severity Code Description Project File Line Suppression State Details
Error CS0103 The name 'HasLineOfSightToPosition' does not exist in the current context LethalThings O:\github\LethalThings\LethalThings\MonoBehaviours\FishFriend.cs 98 Active

#

its the line of sight thing ig

glad yew
#

Yeah

#

It was changed to CheckLineOfSightForPosition

#

@royal lynx managed to take the new code and make it work with both V50 and V49

#

For their giant

royal lynx
#

She is a better programmer than me in all ways you can think of, she'll have her own solutions for replacing line of sight lol, I did it the lazymans way and copy pasted it to all my aid code

royal lynx
willow abyss
#

👍

willow abyss
glad yew
royal lynx
royal lynx
willow abyss
#

nothing large anyhow

glad yew
#

I will say

willow abyss
#

the main things that are sent back and forth are booleans which is tiny

glad yew
#

DiFFoZ mentioned he got hudmanager spikes from LethalThings

royal lynx
willow abyss
#

the mod doesn't do any more networking than lethalcompany does by itself

glad yew
#

Yeah not sure

royal lynx
#

Oh there's some actual bugs with items being "registered" but not showing in the shop when you disable them in the config

#

They weirdly pop up like they're still there with discounts etc

glad yew
#

Yeah

#

I've seen that

willow abyss
#

thats more a lethallib issue

royal lynx
#

Ah icic, never happened with me though so idk tbh

willow abyss
#

the removing of items at runtime is very janky

#

me neither because i never disable anything in the config

#

if i could go back in time i wouldn't have a config file at all honestly

#

because it has only brought me more issues

glad yew
#

I will say I'd love to see the Toy Hammer get registered as scrap instead of an item, so it's not counted as a tool when you get a team wipe

#

XD

willow abyss
#

wait is that like github only?

glad yew
#

I'll have to test LT on V50 after you upload the new version, if all it needs is a recompile that's honestly really good

#

It might be yeah

willow abyss
#

so i assume everything else does too

glad yew
#

I've left it as default where it's set to be scrap

#

but the toy hammer stays on the ship after everyone dies

#

XD

willow abyss
glad yew
#

So if you find a toy hammer and put it on the ship, then die it should count as scrap that's lost

#

But it stays

#

But that might just be cus it can also be a shop item

willow abyss
#

uhh

glad yew
#

So that might be more of a LethalLib issue than a LT issue

willow abyss
#

theres two different assets

#

afaik

#

for the shop and the scrap one

#

i don't remember honestly

glad yew
#

Hmmmmm

royal lynx
#

Wait why tho (if you even remmeber)

#

I use the same asset for my scrap and item registration

willow abyss
#

so i don't have to modify it through code

#

adding the ping and stuff

royal lynx
#

Ahh that stuff

glad yew
#

That's weird that the scrap item isn't lost after dying then

royal lynx
#

Yeah idc how they get scanned 😂 but that's fair

glad yew
#

I wonder if there's a trigger for it that fails

willow abyss
#

i probably forgot to switch a boolean or something

glad yew
#

Probably

royal lynx
glad yew
#

So now knowing LT barely touches networking

#

Xu

willow abyss
glad yew
#

Inb4 it was GhostCodes and DarkMist killing shit

willow abyss
glad yew
#

Aight I'mma test this

willow abyss
#

i used vanilla as my standard for pretty much everything

#

all my custom items and stuff do some kind of networking at the very least

glad yew
#

Yeah then in theory it's networking stuff shouldn't conflict then, unless the main branch on TS is using outdated vanilla code somehow

royal lynx
willow abyss
#

it uses the contentloader class i wrote for lethallib a while ago

royal lynx
#

I was looking for some sort of list or class you made similarly to main branch

willow abyss
#

well this has an array of custom content

glad yew
#

had a Masked and a Redwood spawn in

#

XD

#

Not seen any mines or turrets yet though

willow abyss
glad yew
#

Okay good ^^

#

I guess my rng on this Adamance spawn is just lucky XD

#

Yeah everything is spawning in normally

glad yew
#

Btw @royal lynx wtf did Starlancer do?

#

XD

#

They're all diving into the ground

royal lynx
#

I told you he fucked up birds

glad yew
#

Lmfaooooo

glad yew
#

Ahaha

royal lynx
#

Hes sleeping sadly

glad yew
#

Yeah even the new enemies are spawning in properly, and I had Turrets and Mines on Dine too

#

Let me check if it still works on V49 as well cus if it's backwards compat we're good, which it should be since you didn't have to change anything only recompile it

#

@willow abyss New build is working perfectly on both v49 and v50, though the tp traps still don't spawn on custom moons for some reason

#

So you should be able to publish the new build to Thunderstore 🙂

#

and state it as you recompiled it to fix support for V50 most likely

willow abyss
#

they're defined with Levels.LevelTypes.All

#

which should include modded i think

#

if i remember lethallib correctly

glad yew
#

@unkempt silo Did you manage to not allow tp traps to spawn when you did the patch for LLL moons?

#

XD

willow abyss
#

did they touch the map hazard part at all

unkempt silo
glad yew
willow abyss
#

honestly i an barely understand my old code anymore

royal lynx
#

LLL update is coming out this weekend, depending on how things are it might just be better to port than maintaining rn lol

glad yew
willow abyss
#
var alwaysValid = mapObject.levels.HasFlag(Levels.LevelTypes.All) || (mapObject.spawnLevelOverrides != null && mapObject.spawnLevelOverrides.Any(item => item.ToLowerInvariant() == name.ToLowerInvariant()));
var isModded = mapObject.levels.HasFlag(Levels.LevelTypes.Modded) && !Enum.IsDefined(typeof(Levels.LevelTypes), name);

if (isModded)alwaysValid = true;

if (Enum.IsDefined(typeof(Levels.LevelTypes), name) || alwaysValid)
{
}
glad yew
willow abyss
#

lmao

royal lynx
#

It shouldn't be hard porting LL to LLL but yes, upto the maintainers

visual prawn
#

@willow abyss its very very low priority but if you chuck me an invite to lethal things i can take a look at a couple of it's things in the future 👁️

willow abyss
#

lethalthings doesn't have a good git repo that just works

#

but seemingly recompiling was enough to make everything work on v50

unkempt silo
visual prawn
#

suprised you had to recompile tbh

glad yew
willow abyss
visual prawn
#

ahhhh

#

was gonna say

#

very little in v50 changed fortunately

royal lynx
#

That wouldn't fix whatever other issues people were having, so I can't wait to see complaints later lol

willow abyss
#

but i assume the map hazards not working on modded maps was already a thing pre-v50

#

sounds more likely to be a lethallib issue

glad yew
royal lynx
#

So :shrug

glad yew
#

Yeah

royal lynx
#

Mod specific as in LT not LL

glad yew
#

the client crashes when pulling the lever

royal lynx
#

Yeah not LL

willow abyss
#

But anyhow i don't mind it being ported over at some point if people want to maintain the mod in the future

glad yew
#

That happened a lot for some reason

willow abyss
#

need to clean up the repo and stuff then

royal lynx
visual prawn
#

no promises but i do tend to wander around projects

willow abyss
#

I would really like to have proper git actions but that's not my expertise sadly

glad yew
#

c;

visual prawn
#

trueee, was neat to push a ll update

royal lynx
willow abyss
#

its nice to be able to just add maintainers without extra steps aStaffRuzikeLaugh

#

it worked pretty well for LL seemingly

royal lynx
glad yew
#

Rosie and Starlancer plan to update asap after the update pushes

visual prawn
#

i should just build in porting to LLL in LL lol

royal lynx
visual prawn
#

if you wanna do it via programming, remove some lines and change the function you use

if you wanna do it in editor, use my scriptableobjects and put your mod in an assetbundle with .lethalbundle as the extension

#

thats pretty much it

royal lynx
#

So people can register items etc without code now?

visual prawn
#

people can register everything without code

royal lynx
#

I'm curious to see how that works tbh, I'll have to do a bit of both if I wanna juggle with stuff like spawnweights and config tho no?

visual prawn
#

if you want to yeah

willow abyss
visual prawn
visual prawn
willow abyss
#

the only reason i care about lethallib being maintained is legacy mods tbh, it has done its job

visual prawn
#

i kinda have to

visual prawn
#

i do b exhusted

glad yew
#

and to finally get rid of LLLFixed from my pack

#

XD

willow abyss
#

I would really like for lethalthings to be adopted by someone in the future because i still feel fucking shitty about all the unused assets that people made for it

glad yew
royal lynx
#

If batby don't want it, idm using the assets you currently have, making the models etc was always the hard part for me anyway

visual prawn
#

i dont like want the project if someone else wants it

#

but i could see myself dabbling on it yknow

glad yew
#

I don't see why you all couldn't work on it lol

willow abyss
#

there is atleast 11 finished models

visual prawn
willow abyss
glad yew
#

Since 3 people all have interest, I see no reason why the 3 of you can't all adopt and work on it

royal lynx
visual prawn
#

feel free to ask me about it

willow abyss
glad yew
#

Ye

willow abyss
#

one day the boi will be real 😭

royal lynx
#

oh i love making outside enemies

#

:3

willow abyss
#

this is not an enemy

royal lynx
#

my eyes must be deceiving me

visual prawn
#

not with that attitude

#

oh lmaoo

royal lynx
#

ah a delivery bot

visual prawn
#

i was literally talkign about that idea today

#

in zeekers patreon chat

willow abyss
#

this idea has been picked up and dropped a bunch of times because every time i touched it i got burnt out within a day

royal lynx
#

doesnt seem to be a complicated one either

willow abyss
#

smallest namelist

royal lynx
visual prawn
#

people would prob just use csync nowadays

willow abyss
#

last thing i was trying to do was raycasted tracks or something

royal lynx
willow abyss
#

i wanted it to be really bouncy and dynamic

visual prawn
#

I mean this without any disrespect but any wacky code you see in lethallib, lethalthings, lethalexpansion almost always comes down to it being shit because its the first attempt at doing that thing

willow abyss
#

even the model is somewhat overengineered

#

yeah

#

the networkconfig stems from when most mods did not have one of those

royal lynx
#

Imma disappear for a bit cuz it's eid rn but I'd definitely give a hand to porting and fixing some LT issues whenever you decide to fix the Unity project and whatnot

willow abyss
#

i wonder if you could get a cleaner project from just unpacking the bundle lol

glad yew
#

c;

royal lynx
willow abyss
#

the unity project i used for lethalthings is like 6GB

#

because it has all the game assets

#

that was the main problem

visual prawn
willow abyss
#

lmao

#

thats unfair

#

this is like every project isn't it

visual prawn
#

its a few 😭

willow abyss
#

i also still have that runtime inspector project

#

i forgot about that

#

i cannot remember where that was left off

royal lynx
shadow wing
royal lynx
shadow wing
#

Let 'em skate

full magnet
#

omgggg lmao

upper bridge
willow abyss
#

i am so confused

upper bridge
#

It's one of my scrap eaters >w<

#

He has a chance to become evil maxwell after eating your scrap

astral hull
glad yew
#

Btw @royal lynx you should pin the V50 build of LT for people who wanna use it until eba pushes the update to TS probably

royal lynx
manic wind
#

Idk if this would be something you wanna patch but if you try to buy teh locket launcher with AC installed you can only buy the Rocket boots

royal lynx
#

this sounds like something you should be taking up with AC, a mod thats still maintained afaik

manic wind
#

prob another thing broken like the handheld terminal

royal lynx
astral axle
#

The guy removed all support to the vanilla terminal months ago

twin pumice
upper bridge
royal lynx
upper bridge
#

With the way I made scrap eaters, It shouldn't be hard at all to make one.

royal lynx
#

thats pretty interesting 🤔, though i doubt any would really use it considering the main sellmyscrap has most of the iconic ones people wanna see lol, woulda been a funny sight seeing the redwood but meh

upper bridge
royal lynx
upper bridge
#

Just have a giant hand grab into the ship >w<

royal lynx
#

lmaoo the best part is that it would work just as well too 😆

upper bridge
#

Mhm

royal lynx
#

this definitely isnt him kneeling halfway through his death animation

#

also i just realised the scan node isnt following his body, whoops

upper bridge
#

I have a pretty bare bones scrap eater base class ScrapEaterBehaviour.cs you can extend off of the do anything.

royal lynx
#

It's less the mod itself and more so I just like seeing streamer's/people's reactions to it lol

#

every now and then i think to myself "alright, im gonna surf twitch and promote the great giants!" and then lurk in some vtubers chat for 6 hours

#

i saw wesley in mago's chat though and that gave me confidence to suggest the mod and that was pretty funny seeing my giant in action live 😆

upper bridge
#

Hehe

upper bridge
royal lynx
upper bridge
#

targetScrap gets automatically assigned

#

And you do all your animating in IEnumerator StartAnimation()

royal lynx
#

yee that makes sense

#

just casually in the background

#

scrap eaters is such a nice concept though lol

#

eventually ill have to make something when im done with my giants for each one of em

royal lynx
unkempt silo
#

nah not thicc enough :3c

royal lynx
#

damn, gotta redo the models and animations now 😔

unkempt silo
#

ah btw @willow abyss you mentioned you were working on a LighterPatcher fork, right? Have you uploaded that to github or anything? I'd be interested in it :3

weary remnant
#

So is this mod is getting a v50 version?

royal lynx
#

check pins

weary remnant
#

Oooh, it does have one

#

Just it's not officially on thunderstore yet

#

I assume an official v50 version will be on the app eventually?

royal lynx
#

i assume so too

glad yew
weary remnant
#

Is the official drop still a mystery?

#

No word from Zeekers yet?

glad yew
#

Considering it's been 4-5 days since the last Beta build I'm guessing he's probably working on fixing the current bugs and working towards pushing it public

weary remnant
#

Exciting

willow abyss
#

yeah nah it doesn't seem to be in working conditions

#

no idea what i was even doing with it, you're probably better off forking lighterpatcher yourself

unkempt silo
#

oh well, thanks anyways! :3

vital forge
#

SHEEEEEEEE

astral bay
#

Flat as hell

#

The true cake is what dotflare does

#

Gives things the whole bakery guaranteed

royal lynx
#

whta did dotflare make

#

other than the fiend iirc

astral bay
#

They arnt as well known here compared to risk of rain 2

#

Every time they make a character model no matter what it is

royal lynx
#

icic

astral bay
#

It always backs the entire bakery

royal lynx
#

lol

#

sounds like they need to start making here

astral bay
#

It’s like there watermark / signature move

astral bay
#

It might actually have one I’m not sure

manic wind
#

liked that name better

astral bay
#

Like for example if you look at there HQ employee model that shit is packing

#

They sorta just do it as a joke at this point because it’s expected I think

royal lynx
#

is there even a mod that uses that employee model?

astral bay
#

It is indeed funny

astral bay