#Tonsmith

1 messages · Page 1 of 1 (latest)

weary trout
forest wyvern
#

I have an idea. Make so we can make soundpacks and change them with an in-game menu.

forest wyvern
#

It'd be funnier.

#

Also, should I remove the alt SFX from FG now?

heady badge
#

Why is this so deeply satisfying

weary trout
#

no lmao

heady badge
#

instant instal

idle kettle
#

I am so used to the original sound effects

#

This feels so cursed

heady badge
#

yeah but

#

peak

blazing plinth
#

amazing

weary trout
#

i dont know how i should react to that

forest wyvern
#

-# this mod has gained more traction than FG wtf. Is FG really that fucking horrid?

weary trout
#

3 people jogla

#

well 5

#

but 3 are from the fg dev team

forest wyvern
#

More than FG so far.

#

Whatever the case.

weary trout
#

you onto nothing

forest wyvern
#

I might make a sound replacer mod with soundpacks.

#

For the funsies.

weary trout
#

you can just commit to better sfx

#

actually

forest wyvern
#

?

weary trout
#

do we make a server lmao

forest wyvern
#

Not really.

#

The thread is good enough.

weary trout
#

yeah

#

regardless i think i will try making the sound replacer mod for practice

forest wyvern
#

Alright.

#

If you find out how to find the path the mod is located in tell me.

#

I want to know.

weary trout
#

can we react with a different emoji 💔

forest wyvern
#

So do I remove alt SFX from FG, @weary trout?

weary trout
#

No

forest wyvern
#

ok

rugged granite
weary trout
#

TODO: Custom Soundtrack

forest wyvern
shadow sail
weary trout
#

ill consider

weary trout
forest wyvern
#

I will.

#

can we rename the thing to Balatro Sound Replacer, possibly?

weary trout
#

betterSFX is fine

#

malverk isnt named Balatro Texture Replacer

forest wyvern
#

Alright.

weary trout
#

@forest wyvern i invited you to the repo

forest wyvern
#

ok hold on

weary trout
#

TODO: request BMM, add readme, make a thumbnail for the mod

forest wyvern
weary trout
#

@forest wyvern just use dev branch on the main repo

#

forks are overkill

weary trout
forest wyvern
#

It's still a work in progress.

weary trout
#

@forest wyvern an example mod template go figure your UI wizardry

forest wyvern
#

alright

rustic summit
#

This is cool

#

My fav sfx is the chips one

weary trout
#

were litterally making evil malverk

rustic summit
weary trout
#

indeed

rustic summit
#

Can't wait to change the mult sound to a deepfried one

#

That's a good idea

weary trout
#

i will work on the wiki once jogla is finished with the front end

upper saffron
#

I don't know how to download it

#

😭

weary trout
#

same as how you download any other mod lol

upper saffron
#

FORGET IT

#

I REMEMBER NOW

forest wyvern
#

@weary trout I'll do a quick wiki page thing while you try to figure stuff out.

toxic mulch
#

the github wiki

#

about how to make

#

an sound pack

#

btw i forgot to add it to the zip file but you do need BSFX as an dependency

forest wyvern
#

Amazing

#

I made a wiki page anyways.

#

Did you make the github wiki?

#

I can't make it because erm... perms.

toxic mulch
#

bruh

#

i will make the wiki

forest wyvern
#

jsut gib perms

toxic mulch
#

i will

#

probably

forest wyvern
#

yay oko

blazing plinth
#

im here...

toxic mulch
#

hello BepisFever (Ygg, B:SR, Stacked)

blazing plinth
#

raise fist

toxic mulch
#

d

forest wyvern
#

t

toxic mulch
#

the back end is solid enough that we can have a wiki

#

(dont worry, when the sound replacer is finished, we will have the current sound as a built in preset)

forest wyvern
forest wyvern
#

we swear we are working on it.

weary trout
#

Tonsmith

#

the name is actually not ton + smith

#

trust

forest wyvern
#

trust

rustic summit
#

Cool name

forest wyvern
weary trout
#

@azure summit

#

can we pin this

forest wyvern
#

-# play fool's gambit, goldenleaf will go fucking insane and kill the rest of the dev team otherwise

weary trout
#

its true

rustic summit
#

It's satisfying

forest wyvern
#

@weary trout I fucking told you to level the sounds.

weary trout
#

sci fi is awesome though,,,,

forest wyvern
#

Some of them fucking blast my eardrums.

weary trout
#

thats future goldenleaf problems

forest wyvern
#

Do it now and I'll upload a patch.

rustic summit
#

I have to close my ears whenever I open a pack lmfao

forest wyvern
#

That's T-now goldenleaf problems.

forest wyvern
weary trout
#

i dont have fl you do it yourself

#

also SHUT UP WERE FLOODING THE THREADD

forest wyvern
#

uh... a soundpack I made while testing and for the funsies.

#

if you make a soundpack, we strongly encourage you to post it in the server

forest wyvern
lean plank
#

peak

#

absolute custom balatro

rustic summit
#

But whatever

#

Who cares

#

Should have removed ping actually

weary trout
#
to_big = to_big or function(x) return x end``` ass wiki
weary trout
#

hiatus on this due to schoo

#

l

forest wyvern
#

note: I will continue development, but for any inquiries you may have, go ask me.

forest wyvern
forest wyvern
#

It has taken me like an hour or so, but now the UI isn't stupidly large.

forest wyvern
#

basic config menu

weary trout
#

new release

weary trout
#

this is still tonsmith's greatest achievement

bitter crest
#

peak

forest wyvern
#

real

pallid basin
#

hey guys what sfx can be added in this game that can work

forest wyvern
#

I'd say any SFX you want.

#

You can check the built-in soundpack to use as a reference.

pallid basin
#

ohh I see thank you !! I will try to see if it works

#

like other games soundtrack could feel nice too :)

forest wyvern
#

If any issues arise, do tell.

pallid basin
#

sure !

#

I imagine it's better to use fl studio and having fun doing the sfx 😂

forest wyvern
pallid basin
#

sure !

forest wyvern
#

I myself do not know how to do SFX. I have ported some SFXs other people made.

#

Just uh... try to not blast people's eardrums.

quaint sundial
#

Is there a list of music mods that are ported over to this?

toxic mulch
#

not much right now

#

but the discord is the main way for sharing soundpacks rn so you can check that out

forest wyvern
#

Otherwise you can port them yourself.

bitter crest
forest wyvern
#

it increases tonsmith's value, too

forest wyvern
bitter crest
#

hold on

#

there's alot more

forest wyvern
#

ah

#

got ya

pallid basin
#

Let them cook fr

forest wyvern
#

:3

forest wyvern
bitter crest
forest wyvern
#

oh

#

but can I?

bitter crest
#

and i havent made progress since im asleep

forest wyvern
#

ah

#

ok

bitter crest
#

heres the progress

forest wyvern
#

yummers

bitter crest
#

can you make a condition where it only plays when you enter blinds

forest wyvern
#

mmm yes

forest wyvern
#

woah, slightly better UI!

#

Now you can access the mod config from the soundpack menu and there is an actual search feature!

quaint sundial
# forest wyvern I am working on porting some. If you can provide links to these mods I will ask ...

B-Side
Epic Boss Music
Opandora's Box

Cryptid(?) iirc it has a different main menu theme?
Bakery

GitHub

A music replacement mod for balatro. Contribute to afterlightgames/b-side development by creating an account on GitHub.

GitHub

Adds the orchestral score of the Balatro theme from The Game Awards to all boss antes. - WalWalrus/EpicBossMusic

GitHub

Opandora's Box - A Balatro mod. Contribute to ohpahn/opandoras-box development by creating an account on GitHub.

GitHub

A miscellaneous Balatro mod. Contribute to BakersDozenBagels/BalatroBakery development by creating an account on GitHub.

bitter crest
#

i ported the entire OST from opandora

#

I don't think you need to port epic boss since the mod itself has their own config

toxic mulch
bitter crest
forest wyvern
forest wyvern
#

Now there should be less shenanigans when loading modded sounds and what not.

#

If you find any issues, let me know.

forest wyvern
#

I think it should be backwards compatible, tho.

forest wyvern
bitter crest
#

sure

bitter crest
forest wyvern
#

It shouldn't break.

#

Also, I believe the mods field should be {Vanilla}, since it only changes vanilla stuff

bitter crest
#

oh i thought its the source of the song

forest wyvern
#

<3

#

Yeah, the documentation isn't clear.

#

I'll fix that, probably

#

Remind me in the next revision.

forest wyvern
#

ah

#

That's the Tonsmith discord server

#

shit wrong link

bitter crest
forest wyvern
#

You can add checks, tho.

#

You just slap one of these into the sound you want and presto, conditionals!

#

Also, don't even bother setting a stupidly high number, Tonsmith will just use your pack priority as the actual number.

#

So long it returns anything that isn't false or nil, Tonsmith will pass the conditional.

forest wyvern
#

hold on

#
TNSMI.Pack{
  sound_table = {
    {key = "key", select_music_track = function () return true end}
  }
}
#

It hasn't been fully tested, so shit might not work as expected.

#

If issues arise, do tell me so I can look into it,

bitter crest
#

it will be done tonight i think

#

and then ill submit it to tonsmith server

forest wyvern
#

wahoo!

weary trout
#

mario sounding ass

bitter crest
#

the pack is done

forest wyvern
#

wahoo

bitter crest
#

soundpack released for future newcomers

forest wyvern
#

The miku one is very good if you want to go deaf.

latent latch
#

Oh, was B-Side already ported?

forest wyvern
#

It got ported a few hours ago, I believe.

#

Join the discord server and see for yourself, dunno

latent latch
#

Looks like it was, awesome

#

Good job on the sound manager this is just what I needed

#

Also thanks jogla for bringing it to my attention

forest wyvern
#

<3

toxic mulch
#

tonsmith

forest wyvern
#

kill

toxic mulch
#

fixed 1 typo and broke all soundpacks

#

amazing

forest wyvern
#

They still work

#

But I urge everyone to update their soundpacks accordingly.

shadow sail
#

does it have a server?

forest wyvern
shadow sail
#

please

forest wyvern
#

oh

#

it should work, right?

shadow sail
#

it did

forest wyvern
#

I saw

shadow sail
#

thanks

forest wyvern
#

Enjoy the few soundpacks there are.

shadow sail
#

btw i actually made my own mod

forest wyvern
#

ah

shadow sail
forest wyvern
#

gtg now

#

sorry

forest wyvern
#

bk

shadow sail
forest wyvern
#

Yes

shadow sail
#

btw i havent uploaded the recent version

#

now i have

ashen perch
#

Very useful mod

quaint sundial
#

Anyone else encountering missing sounds?

  • money
  • drawing cards
  • chips?
forest wyvern
#

Yep

#

I do not know why that's happening.

#

I'll look into that.

quaint sundial
forest wyvern
quaint sundial
forest wyvern
#

I will later.

quaint sundial
#

Unrelated, how to remove sound files from other mods without breaking it?
Game crashes when the sound folder is removed

forest wyvern
#

What do you mean?

idle kettle
#

I'm pretty sure you can't delete the whole folder since it needs that to function

#

But could you not just delete the contents of that folder?

quaint sundial
#

Sound files from other mods are already in Tonsmith's Sound Packs, want to remove them from the original

Wanted to disable the music from Lost Edition, but removing the sounds folder leads to a crash

forest wyvern
#

Ah.

#

Basically, TNSMI.Pack uses SMODS.Sound, and because of how SMODS.Sound works, the game will crash if it can't find the file for whatever sound.

#

If you want to remove a certain sound/music from a given pack, you will have to remove the entry from the TNSMI.Pack call.

weary trout
forest wyvern
forest wyvern
#

I guess I know what I'll be doing this weeked.
Rewrite half of Tonsmith's code, again! Yipee

quaint sundial
forest wyvern
#

Ah, then yeah.

#

Just make a soundpack that replaces the desired sound with just a silence file.

#

Support for this exact function is NOT planned for Tonsmith.

quaint sundial
#

Are the extra files in sound packs needed?

  • arcana
  • boss
  • celestial
  • shop

Think they're just copied from main.ogg

forest wyvern
#

They are different tracks, but you can make them point to the same file.

#

@quaint sundial

weary trout
#

tonsmith

weary trout
#

Tonsmith

forest wyvern
#

TNSMI revival

steady creek
#

Is it really going to be revived?

forest wyvern
#

Possibly

#

Least it's getting a re-write some time in the future/.

lofty herald
#

Okay aside from the known bug of not yet figuring out how to make the option cycle shoulder buttons dynamic without reloading the page, all of my contributions should be done? Ish?

lofty herald
#

Okay lastly, I updated the Spanish localization with some of the changed entries I made. I'm not a Spanish speaker so it was mostly a best guess based on similar instances of words I could find

forest wyvern
#

Ah

#

I will take care of the spanish localization.

#

@lofty herald Is it ready?

#

u sure this is how it's supposed to look?

lofty herald
#

Hmmm given the other one looks correct, I'm assuming the export for the 2x version of the default one is wrong

#

But also I should clear the default ones anyway since they're test objects

#

Yep, my mistake

forest wyvern
#

azamin

lofty herald
#

Whatever the reason, You're seeing the 2x version of sprites and the 2x for the default image is wrong

#

I can fix it when I get outta bed, plus I have to get rid of the 10 or so declared dummy soundpacka

forest wyvern
#

It crashes a shit load still.

#

I might look into that.

lofty herald
#

??? That's odd

#

Though I'm not testing with a ton of other mods

forest wyvern
#

Mainly with dummy packs and spanish localization for whatever reason.

lofty herald
#

....huh

forest wyvern
#

ye

lofty herald
#

I wonder why I didn't encounter either

forest wyvern
#

mods probably

lofty herald
#

I did revert the English text back to being labeled default so that it falls back on it

#

And the dummy packs...... Hm

forest wyvern
#

Also whatever you did, you need to add or remove soundpacks for this thing to work

lofty herald
#

Yeah, I noted that in an earlier PR

forest wyvern
#

I have to figure out what the fuck you did to the mod.

lofty herald
#

It correctly updates the option cycle text and the active colors, but for whatever reason, it won't seem to update the interactive state

forest wyvern
#

No like, the entire thing.

#

You basically re-wrote the entirety of TNSMI.

#

So now I have to figure out how it works now.

#

yipee.wav

lofty herald
#

Loading is basically identical, call TNSMI.SoundPack{} with a key and a sound table.

The main changes are:

  • priority for soundpacks is no longer determined or saved in a separate value. TNSMI.config.loaded_packs is the currently loaded soundpacks in priority order, and every time this is updated, TNSMI.save_soundpacks() runs through them in descending priority and fills in any sounds they replace, ignoring lower priority sounds if they've already been filled
  • TNSMI now uses SMODS.GameObject, which means more direct support for localization and UI. So the author/description has been moved to be similar entries as Jokers
  • a bunch of UI generation functions and callbacks were changed essentially to wait for player input before doing as any reloading of packs or priority
    1. Upon opening the menu, create_UIBox_soundpack() is called. This creates a priority CardArea, and the number of cardareas specified in the config rows, then places them in the UI
    2. Every time it needs to reload the list of available soundpacks, it calls G.FUNCS.reload_soundpack_cards() which specifically regenerates the cards in the config rows
    3. The SoundPack priority is only changed when the menu is opened, a pack is toggled (callback G.FUNCS.toggle_soundpack()), or a pack is dragged to change priority (G.FUNCS.TNSMI_change_priority())
    4. Soundpack cards are handled by the create_soundpack_card() function which creates the "fake" card and gives it a dummy center referring to the SoundPack, which handles the sprite atlas for the cover art, the hover behavior, and the click interactions automatically
#

Also, show me your mods list and I'll match the dev environment as much as I can to fix bugs

forest wyvern
#

I still have to figure out how to consistently replicate it.

forest wyvern
#

Still checking the code to be able to modify it in the future and what not.

lofty herald
#

Nodding nodding, understood

forest wyvern
#

at this point you are basically a Tonsmith dev, btw

#

Like, over half of the code of TNSMI is yours now, is it not?

lofty herald
#

shrug I admittedly didn't even intend or expect it to get merged. My goal was basically just to fulfill the specification for user use for providing it with Cardsauce/Arrow

lofty herald
#

That..... was way easier

#

Huh

forest wyvern
#

Tonsmith's code was a fucking dissaster.

#

Like, it was stitched together so fucking badly.

#

And a re-write was intended at some point.

#

You quite literally came in clutch for that.

#

So uh... yeah.

lofty herald
#

Well, in that case, let me go in and document the functions better

forest wyvern
#

Now I don't understand the code if 'my' own mod.

#

Currently fixing a git conflict thing

#

because I am stupid af

lofty herald
#

Hmm, for legacy support, I might re-add TNSMI.Pack as basically an alias for TNSMI.SoundPack

#

Calling one just calls the other

forest wyvern
#

mmmm

#

Nah.

#

It's a whole re-write of the mod.

#

We'll just call it Tonsmith v2.0

lofty herald
#

Oh, okay

lofty herald
#

Oh wait

#

lmao

#

I know why it crashes @forest wyvern

#

It's because I took out the localization definitions for the dummy packs without actually taking out the dummy packs themselves

#

That's my bad

forest wyvern
#

azamin

#

whenever you can can you make another PR thing?

lofty herald
#

I made one already for the fixed sprite size

forest wyvern
#

I am juggling rollbacks and shit because I may or may not have pushed things to main instead of dev.

lofty herald
#

Right now it's saying im 2 behind the main branch, but what's on the main branch looks like stuff from a few PRs ago

forest wyvern
#

I rolled it back.

#

Because this thing is meant to be going to dev

lofty herald
#

Ah

#

Let me see what happens when I sync

forest wyvern
#

nuke shit

#

Juggling shit and what not hold on

lofty herald
#

Hold on Im closing the one pull request for a bigger one

forest wyvern
#

ok

#

2 devs, trying to unfuck a github repo

lofty herald
#

Okay, made a new pull request, and it's actually targeting the dev branch now

#

This should, as far as I know, have all my changes

forest wyvern
#

merged and hopefully it works..?

lofty herald
#

Main still seems broken, since main.lua seems to still have my version

#

So almost there

forest wyvern
#

ik

#

We don't touch main

#

We'll overwrite it whenever we get to 2.0

lofty herald
#

Nodding

#

Then yeah dev branch should be everything

#

That last PR added a bunch of comments explaining some specific choices I made for functions

forest wyvern
#

I think something has violently imploded in both codebases

lofty herald
#

huh?

forest wyvern
#

I don't fucking know

lofty herald
#

That means there's a syntax error, but nothing showing up on my end

forest wyvern
#

I just cloned from your repo

lofty herald
#

oh lmao I know why

forest wyvern
#

"please fix"

lofty herald
#

Like I said, your main branch is broken, and my repo's main branch is synced to yours

forest wyvern
#

I don't fucking know

lofty herald
#

Mine is actually in the branch VG/code-refactor

forest wyvern
#

I am getting from your refactor, tho.

lofty herald
#

OOP I see it now

#

I just pulled

#

whaaaaaaa

forest wyvern
#

I do not know

#

You might have to roll back or something idfk

#

Sorry for the trouble 😭

lofty herald
#

you're fine, git is Like This sometimes

#

Yeah somehow there's a weird frankenstein of the orignal utils code and the refactor code

forest wyvern
#

sorryw

lofty herald
#

Okay I should have just fixed it?

#

Pull from the refactor branch again

forest wyvern
#

Let's see...

#

yummy callbacks

lofty herald
#

Although I did just encounter a bug I need to fix, which is that it's trying to load the dummy packs from my saved configs after they were removed

#

So a similar bug would probably occur if you disabled a mod that added a soundpack

#

Try now

forest wyvern
#

Let's see...

#

where tf is my vanilla

#

Or whatever other soundpack you have

lofty herald
#

That's vanilla sound, yeah

forest wyvern
#

ah

lofty herald
#

huh.....

#

I think I know

#

Go into your balatro > config directory here and delete this file:

forest wyvern
#

santa mierda

lofty herald
#

It's the old saved config from the earlier version, and I didn't add the default balatro being part of the default config until later

forest wyvern
#

Will maybe look into that.

lofty herald
#

So it'll get recreated on next load

lofty herald
forest wyvern
#

sounds don't get replaced when loading the game

#

and a wack ton of extra bugs probably

lofty herald
#

that's.....

#

it sounds like you're using an earlier version of my changes somehow, cause that also was something I didn't add until later?

#

I do hear the replaced sounds upon loading from my current repo

#

Possibly since it uses the postInitSplash function it's being overriden by something else?

forest wyvern
#

lemme pull again

lofty herald
#

Changed it so that it's just empty when there's nothing to display

forest wyvern
#

Just make it say page 1/1

#

Or make it so it blacks out like the other two buttons..?

lofty herald
#

Could def do that yeah

forest wyvern
#

also this lol

lofty herald
#

Yeah no clue. I tried calling recalculate() but seemingly that's still the result

#

????

#

odd

forest wyvern
#

UI is weird, plus that is dyna text

#

I think

lofty herald
#

Redid the thumbnail image for Fool's Gambit ost to fit the new size

forest wyvern
#

Mainly because golden leaf just took a random sprite from FG

lofty herald
#

Ah I see

lofty herald
#

Weird, it's somehow introduced a bug where sounds aren't resetting when packs are unloaded. Investigating,,,

lofty herald
#

There, fixed

#

@forest wyvern I also fixed the issue of sounds not being loaded on start. I was initially calling them in an overriden function initPostSplash without realizing that wasn't a vanilla function and was instead implemented in my API and called from prep_stage

lofty herald
#

Plus some more outlying bugs and edge cases such as fixing an issue when no other soundpacks are loaded, since I'm not including Fool's Gambit OST with my provide version

forest wyvern
#

The double tab

lofty herald
#

...whoa

#

ooop yep, I see it. It's correctly loading the audio tab, but it's not setting the game tab as unchosen

forest wyvern
#

btw, check if folden geaf has given you perms and shit to directly edit stuff in the main repo

#

So we don't have to juggle the two repos.

lofty herald
#

Fixed!!

#

Also I don't think I have permissions

#

Let me try something

forest wyvern
#

oko

#

fucked up menus when changing rows 'n stuff

#

It also affects card and button size.

lofty herald
#

It should affect the card and button size, they scale a little smaller when you expand the rows to make sure they fit on screen

#

So the right one looks like relatively expected behavior. The left one not so much

#

It so wideeeee

#

Im having trouble on my git even setting the remote URL to the main repo it seems

forest wyvern
#

Probably remove the scaling feature.

lofty herald
#

I def can, but I doubt 16/4 is gonna fit

forest wyvern
#

The default setting is the recommended one, but shit can go off-screen intentionally if you make the menu too large.

forest wyvern
#

If you are maxing it out, you should expect the menu to be stupidly large.

lofty herald
#

It's not that it's stupidly large, it's that it's completely unusable

#

(this is with the scaling turned of)

forest wyvern
#

Set max size to smaller numbers

#

Like 12x3

#

(allowed max size)

#

The old numbers were meant to be compatible with the old UI

lofty herald
#

The largest it can be while still fitting entirely within my monitor (1440p) is 2 rows, 9 columns

#

And it clips the top ever so slightly

forest wyvern
#

Scale down the cards slightly, maybe?

#

Also the middle looks so empty.

#

Max 2x8, min 1x4..?

#

I don't know if we need that setting at this point.

lofty herald
#

This is 3/8 with the packs sized down

forest wyvern
#

mmmmmmmmmmm

lofty herald
#

They're a tad small for my tastes so I can cap it at 2/8 like you said and make em bigger

forest wyvern
#

i am eepy af

lofty herald
#

Go sreep

forest wyvern
#

Can you cramm the cardareas closer together?

lofty herald
#

yep

forest wyvern
#

And yes, make shit bigger.

#

great

lofty herald
forest wyvern
#

noices

lofty herald
#

And yeah it's empty just cause it's scaling to the column size. I thought it was more user friendly if the pages stay the same size even if the final page can have less on some rows

#

So your eyes aren't moving around as much if the last page suddenly squishes

#

Plus recommended setting looks nice

forest wyvern
#

Recommended size looks nice.

#

The larger sizes are just if you really want.

#

i.e. have a shit load of soundpacks or something idk

#

I am going eep

#

I'll check back tomorrow

lofty herald
#

Night!!

forest wyvern
#

I am alive now.

lofty herald
#

I made a couple more changes to huddle the packs closer together, plus a few more buggixes

#

All of it is in my fork/open PR

forest wyvern
#

ok

lofty herald
#

So the main things that still need figuring out are basically all related to the option cycle:

  • fix the option cycle not updating its interaction state when a search query changes the page number between 1 and 2
  • fix the option cycle for some reason having an extra space when the search list is updated from 0 to 1 or greater
forest wyvern
#

oko

#

At this point Tonsmith is yours, is it not?

#

Around 0% of the codebase isn't yours.