A consumable stacking mod written from the ground up, inspired by incantation which aims to fix a lot of the problems with the mod in my eyes
https://github.com/lord-ruby/Overflow
#Overflow
1 messages · Page 1 of 1 (latest)
oh nice. yeah it always bugged me that incantation doesn't account for observatory and little things like that
it doesnt work with observatory rn but it should eventually
i have a few other things to fix too
works
some mods with freaky zany planets will have to manually add compat but most that are just a normal planet for a new hand type should work
the game crashes when opening up the config menu for the mod
i suppose it has something to do with not having entropy
by the way, this mod lets you swipe cards from void packs if you already have one
maybe fix that?
or is it intended
beautiful
not intended
typo moment
me when i copy paste my own code without fully changing it
real asf
split half button 🔥
the things of note here are the buttons take on the color of the consumable type and stacked non negatives now take up the right amount of slots
is the latter toggleable in config
not rn
okay
added
daring
glorious
with all the ego over there that will neve rhappen
in a thousand years
btw i didnt mention but this should be backwards compatible with anything that has incantation support other than stuff thats blacklisted from being stacked
i switched it from a whitelist to a blacklist because it made more sense to me
but this also means that 90% of consumables dont need can_stack since thats implied
observatory also works
with stacked planets
that's really nice to have
i've got a perkeo based thing that i'll need to switch over at some point
(un)lucky you
jen replied lmao
he said "it's nice to have for sure, but PWX will still use incantation"
i personally don't mind
maybe even surprising
i know
also jen replies to practically everything lmao
i much prefer devs that don't ban people for nothing anyway
is this a yandere dev moment
i don't know anything about yandere dev
"i can't dev, i got all my emails from fans to read every day"
other than he used to be a complete incel before he became yandere dev
lolz
there's like a metric ass ton of ppl online lmao

"i wish there was an easier way to do this"
if 1 then y
elseif 2 then x
elseif 3 then y
elseif 4 then x
...
repeat ad infinitum
crashed when opening config, assuming something in there requires you to have entropy or it won't work
that
might be the most nothing statement i've ever heard
i don't mean to be rude
but wow
what i mean by this is im pretty sure that this issue doesnt exist anymore
like i checked the code
for all mentions of entropy and found 0
This mod is clearly better, he just doesn't want his jank ass mod to get replaced by something that actually works 
also isnt this just extremely ego driven?
-# this mod is the same thing but better
-# (No hate towards Jen but this is kinda dumb
)
here we go again 🙏
my advice for this is to install the modpack
uninstall incantation, put overflow on it and pretend like nothing is wrong
no need to make a fuss over it imo

i cant bulk use cryptid planatary cards
the button just wont highlight
Oh i see the problem
I can just move the consumables ui closer to the jokers
One is still giving me trouble and thats sol
so far up
this is hopefully fixed by moving the buttons downward
which i pushed earlier
wait nvm
huh
this is so weird
the problem is its doing the bulk use buttons even when you cant bulk use
should be fixed now
Thanks moder i will download it again xD
By chance did u make it so u can bulk use the cash ones
Crashed, any idea what it might be
oops
i can fix this
this is because you dont have talisman but there should have been a fix for this
I do have talisman? Maybe wrong version of talisman then
i didnt yet
would this be wanted?
ye that's actually one annoyance I had with one of the consumable stacking mods
i can add it
I dont know if this is an issue with the mods i have installed, but i wnted to post this here to see if there's a way to fix. (this happens whenevr i press merge consumables)
this should be fixed idk let me check
try downloading this release: https://github.com/lord-ruby/Overflow/releases/tag/1.0.3
kk mthanks
mmmm
hello aiko
hiya! i don't know if you're aware of this bug already, but:
- i made a consumable which can only be used if the number of consumables is less than or equal to the number of consumable slots
- it behaves correctly if i split up my consumables into singletons, but it seems that stacks of the same are treated as just one, meaning the consumable can be used when it shouldn't
my can_use function:
can_use = function(self, card)
return #G.consumeables.cards + G.GAME.consumeable_buffer <= G.consumeables.config.card_limit
end,```
also, it seems that there's a X1, which i think should go away when a stack is separated
...are you counting .ability.immutable.overflow_amount of stacked consumables?
mm, no
i didn't know i had to do that
so i add on G.consumeables.ability.immutable.overflow_amount?
( @rose forge )
That's attached to a given consumeable... you'd want to iterate then.
As I check for context.other_consumable.ability.immutable.overflow_amount elsewhere.
i had a solution for this that doesnt involve manually checking stack size but i forgot that consumable_buffer exists so it doesnt use that
G.consumeables.config.card_count
except
with stacked negatives it doesnt do that
so youd have to check the amount specifically
mm, yikes
idk a good way around this other than to make my own utility function just to count the consumables
which is a fine solution ig
is this more ideal?
i think that'd be a good solution ^^
then i can check if that function exists, and if it does, use that, else use the method i used previously
mm, wait, the number that the card area displays could be returned ^^
like, the bit that says 0/2, eg.
because that seems to update just fine
the number that the card area displays can be access only if you stack non negatives
it doesnt check/mess with that if you stack negatives
right
i now have this:
function count_consumables()
local count = G.consumeables:get_total_count()
if count then return count
else return #G.consumeables.cards + G.GAME.consumeable_buffer end
end```
i would check that get_total_count actually exists first
otherwise youre gonna get attempt to call a nil value
function count_consumables()
local count = G.consumeables.get_total_count and G.consumeables:get_total_count()
if count then return count
else return #G.consumeables.cards + G.GAME.consumeable_buffer end
end```
this would work
ah, i'd do this:
function count_consumables()
if G.consumeables.get_total_count then return G.consumeables:get_total_count()
else return #G.consumeables.cards + G.GAME.consumeable_buffer end
end```
one of those two
you might want to test if you need to add the consumeable buffer on still
cause i honestly dont know
idk how early the count gets updated
mm, ya, negatives don't seem to work properly
-# 'tis where I realize I... didn't accurately implement the check, oop.
what mod is that card from
half expected temperence to have a bulk use function
it should, i think sleepy was working on it on a fork
i want bulk use on as many things as possible
including cryptid and ectoplasm and stuff
I remember that modded planets used to be glitched on Incantation, which is why I stopped using them
They'd stack fine, but bulk using just didn't work so you'd end up wasting tons of planets if you try leveling them up at once, since it'd only count as one level
cute pfp btw
and even vanilla planets would glitch sometimes
meaning I'd have to manually unstack planets whenever I played with incantation
Heya, minor bug report after using the new release for a bit:
- Bulk use on stacked planets doesn't update fool
- Splitting makes the original consumable not have a merge button
- Using one consumable while stacked doesn't decrease the sell value of the original stack
- Bulk use on Hermit/Temperance crashes with attached crashlog
- Things that generate consumables (Cartomancer, blue seals, etc.) still generate if two consumables are stacked
- Stacked consumables that generate more than one consumable will generate to fill the remaining slots, even if the slots are technically full
Obviously the last two wouldn't be problems if "Only stack negative consumables" was turned on, but I thought if you were going for a substantially better option than incantation then it would be nice
bulk use should update fool since its calling the regular use function thats weird but i can fix it
cartomancer and blue seals are just not done because i only thought perkeo created enough cards to matter
uhh
ill look into it all tomorrow
its 2am rn
COIN?
I think there's an issue where stuff have their sell value set to 0 when bought.
is there an easy way to disable consumable stacking for a whole set of modded consumables
i have a set here that is not playing nice with the stacking at all and I'm ready to cut my losses and make them not stack
Overflow.blacklist[ConsumableSetKey] = true
yeah i wanted to make it as easy as possible
you can also give the blacklist the key of a specific consumable too
if you wanted all planets to merge but not pluto for example itd just be Overflow.blacklist.c_pluto = true
they are still stacking
hm
I haven't updated in awhile actually
I'll try again after updating and see if it still stacks
it should work
whats your consumabletype definition and your blacklisting code look like
oh you know what it might be
i'm running the blacklist code before the consumables are defined as existing
yeah no still stacking
if next(SMODS.find_mod("Overflow")) then
Overflow.blacklist.c_gamer = true
end
i can't show more than these bits
thats really weird
yeah i'll try updating overflow and if it still doesn't work i'm not sure what to do
that caused a crash
does this look familiar
this is the line it crashed on
is this something to do with your talisman checks
I probably just need to update talisman
no i know the issue
oh what is it
replace to_big(X):to_number() with to_number(X)
i can fix it but im a bit busy rn
although
im pretty sure this is on talismans side
so you might need to update talisman
yeah i updated it anyway
yeah that worked
alright
the consumables still stack unfortunately
thats really weird
Mod priority was tested yet?
try going ingame and doing Overflow.blacklist.Planet = true
and seeing if it stops planets from merging
it does
thats really weird
maybe the blacklist is getting cleared somehow
try doing it for your consumable set in debugplus
i did the same thing with my consumable set
and it worked
so something is wrong with my mod check I'd guess
try just checking for Overflow (global table)
nice
there we go
crashed when pressing Split One on a negative pink color card from morefluff that had x2 on the stack
and 1 color card charge
Does this fix the sell value issue?
hey i posted a crash on your Overflow github site in 'issues', is that a good place to do it or is somewhere on discord better?
ok sorry for the ping, appreciate the mod
ok i was able to patch the bug temporarily (it just uses the first consumable rather than a random one and crashing) like this:
Bulk use doesn't seem to do it right (those planets are meant to be negative but somehow aren't but that's prob some other mod issue)
the thing that gave me 8 planet cards btw
also that's definitely not meant to happen (split it one at a time and used it)
the seal clearly said "Negative"
but proceeded to create non-negative anyway
doing bulk use doesn't actually use it all in bulk
i have to split and then mass use
nvm i cant mass use here
i have no fucking idea why it doesnt work
but its actually starting to piss me off
1.0.6 works fine
fixed
i just
undid the 1.1 release
well i reverted the changes in a new release since there was other stuff i needed to keep
this means its going to be incompatible with like 1 singular mod and idk which
but i cba to find out and only 1 person ever has reported it
there's a problem with identical consumables but with different sell value 💀
perkeo can stack consumables that have stacking disabled
it just broke my fucking consumable again and it crashed when i tried to split them and graaagh
No clue how I broke the mod. But somehow i'm producing enough planets for this to happen
just gonna have to leave my computer on overnight as the consumables manually stack
Ok i’m gonna have to recreate the events. Oh well. If we can figure this out I won’t have to wait
So it will probably be worth it
as long as you havent changed your mod list you shouldnt need to crash again
since the dump files dont really change if the mods dont change
I did. I removed overflow. Because I was stupid and forgot I can just toggle it off in settings.
you can add it back go to the main menu of the game and then send that file it should suffice
i see whjere the issue is
oh
latest release should fix it
The Merge All Button Broke
and the game froze when I hit next round so i'll tell you if that works
the patch
when it's done
and it just crashed without a crash report. So it's probably just the lag from all the planets. So I won't be able to test it until the merge issue is resolved
in case you need this again
I spotted this, wasn't aware that Constellation comes from Overflow /j
I forgor to mention that SMODS.scale_card now also handles scaling
and that breaks Constellation override (scales the wrong amount)
this should be fixed in the latest release
i have no idea why, but it simply doesn't work
Will this mod conflict with the Tarot Delux?
