#Overflow

1 messages · Page 1 of 1 (latest)

wary nexus
candid lotus
#

oh nice. yeah it always bugged me that incantation doesn't account for observatory and little things like that

wary nexus
#

it doesnt work with observatory rn but it should eventually

#

i have a few other things to fix too

#

some mods with freaky zany planets will have to manually add compat but most that are just a normal planet for a new hand type should work

boreal mortar
#

the game crashes when opening up the config menu for the mod

split ferry
split ferry
#

by the way, this mod lets you swipe cards from void packs if you already have one

#

maybe fix that?

#

or is it intended

rough portal
#

beautiful

wary nexus
wary nexus
#

me when i copy paste my own code without fully changing it

rough portal
#

real asf

wary nexus
#

(note that stacking non-negatives is off by default)

rough portal
#

split half button 🔥

wary nexus
#

the things of note here are the buttons take on the color of the consumable type and stacked non negatives now take up the right amount of slots

rough portal
#

is the latter toggleable in config

wary nexus
#

not rn

rough portal
#

okay

wary nexus
#

added

meager ridge
#

daring

split ferry
#

glorious

rotund drift
#

This needs to replace incantation in pwx

#

I can't stand incantation

split ferry
#

in a thousand years

zinc sapphire
#

I'm in the PWX server, boutta suggest this rq

#

Cus I find it interesting ^^

wary nexus
#

btw i didnt mention but this should be backwards compatible with anything that has incantation support other than stuff thats blacklisted from being stacked

#

i switched it from a whitelist to a blacklist because it made more sense to me

#

but this also means that 90% of consumables dont need can_stack since thats implied

#

observatory also works

#

with stacked planets

rough portal
#

i've got a perkeo based thing that i'll need to switch over at some point

split ferry
zinc sapphire
split ferry
#

an honor

#

is it not

zinc sapphire
#

he said "it's nice to have for sure, but PWX will still use incantation"

split ferry
#

oh my

#

unexpected

#

riveting

#

absolutely shocking

zinc sapphire
#

i personally don't mind

split ferry
#

maybe even surprising

split ferry
#

imho

zinc sapphire
#

i know

zinc sapphire
split ferry
#

i much prefer devs that don't ban people for nothing anyway

split ferry
zinc sapphire
#

i don't know anything about yandere dev

split ferry
#

"i can't dev, i got all my emails from fans to read every day"

zinc sapphire
#

other than he used to be a complete incel before he became yandere dev

split ferry
#

he still is

#

nothing changed

zinc sapphire
#

anyways im gonna head out

#

i'm getting trolled

#

by someone

split ferry
#

lolz

zinc sapphire
#

there's like a metric ass ton of ppl online lmao

split ferry
rough portal
rough portal
#

crashed when opening config, assuming something in there requires you to have entropy or it won't work

wary nexus
#

its probably a bug

#

cause thats not intended

#

i think this might be fixed though?

rough portal
#

that

#

might be the most nothing statement i've ever heard

#

i don't mean to be rude

#

but wow

wary nexus
#

what i mean by this is im pretty sure that this issue doesnt exist anymore

#

like i checked the code

#

for all mentions of entropy and found 0

rotund drift
#

-# (No hate towards Jen but this is kinda dumb shrug)

zinc sapphire
#

here we go again 🙏

zinc sapphire
#

uninstall incantation, put overflow on it and pretend like nothing is wrong

#

no need to make a fuss over it imo

rotund drift
idle hull
#

i cant bulk use cryptid planatary cards

#

the button just wont highlight

#

Oh i see the problem

#

I can just move the consumables ui closer to the jokers

#

One is still giving me trouble and thats sol
so far up

wary nexus
#

which i pushed earlier

#

wait nvm

#

huh

#

this is so weird

#

the problem is its doing the bulk use buttons even when you cant bulk use

#

should be fixed now

idle hull
idle hull
tough breach
wary nexus
#

oops

#

i can fix this

#

this is because you dont have talisman but there should have been a fix for this

tough breach
#

I do have talisman? Maybe wrong version of talisman then

wary nexus
#

maybe

#

either way i can fix it

wary nexus
#

would this be wanted?

tough breach
#

ye that's actually one annoyance I had with one of the consumable stacking mods

wary nexus
#

i can add it

delicate panther
#

I dont know if this is an issue with the mods i have installed, but i wnted to post this here to see if there's a way to fix. (this happens whenevr i press merge consumables)

wary nexus
#

this should be fixed idk let me check

delicate panther
#

kk mthanks

quasi tartan
#

mmmm

wary nexus
#

hello aiko

wide jewel
#

hiya! i don't know if you're aware of this bug already, but:

  • i made a consumable which can only be used if the number of consumables is less than or equal to the number of consumable slots
  • it behaves correctly if i split up my consumables into singletons, but it seems that stacks of the same are treated as just one, meaning the consumable can be used when it shouldn't
#

my can_use function:

can_use = function(self, card)
    return #G.consumeables.cards + G.GAME.consumeable_buffer <= G.consumeables.config.card_limit
end,```
#

also, it seems that there's a X1, which i think should go away when a stack is separated

rose forge
#

...are you counting .ability.immutable.overflow_amount of stacked consumables?

wide jewel
#

mm, no

#

i didn't know i had to do that

#

so i add on G.consumeables.ability.immutable.overflow_amount?

#

( @rose forge )

rose forge
#

That's attached to a given consumeable... you'd want to iterate then.

#

As I check for context.other_consumable.ability.immutable.overflow_amount elsewhere.

wary nexus
#

G.consumeables.config.card_count

#

except

#

with stacked negatives it doesnt do that

#

so youd have to check the amount specifically

wide jewel
#

mm, yikes

wary nexus
#

idk a good way around this other than to make my own utility function just to count the consumables

#

which is a fine solution ig

#

is this more ideal?

wide jewel
#

i think that'd be a good solution ^^

#

then i can check if that function exists, and if it does, use that, else use the method i used previously

#

mm, wait, the number that the card area displays could be returned ^^

#

like, the bit that says 0/2, eg.

#

because that seems to update just fine

wary nexus
#

the number that the card area displays can be access only if you stack non negatives

#

it doesnt check/mess with that if you stack negatives

wide jewel
#

right

wary nexus
#

might be better not as part of the cardarea class itself

wide jewel
#

oh! i guess i can use that then ^^

#

tyty!

wary nexus
#

this is new

#

so let me push it first but yea

#

okay its pushed

wide jewel
#

i now have this:

function count_consumables()
  local count = G.consumeables:get_total_count()
  if count then return count
  else return #G.consumeables.cards + G.GAME.consumeable_buffer end
end```
wary nexus
#

i would check that get_total_count actually exists first

#

otherwise youre gonna get attempt to call a nil value

wide jewel
#

ah true

#

oops

wary nexus
#
function count_consumables()
  local count = G.consumeables.get_total_count and G.consumeables:get_total_count()
  if count then return count
  else return #G.consumeables.cards + G.GAME.consumeable_buffer end
end```
#

this would work

wide jewel
#

ah, i'd do this:

function count_consumables()
  if G.consumeables.get_total_count then return G.consumeables:get_total_count()
  else return #G.consumeables.cards + G.GAME.consumeable_buffer end
end```
wary nexus
#

one of those two

wide jewel
#

i did the check in the wrong way, earlier ^^"

#

thanks!!

wary nexus
#

you might want to test if you need to add the consumeable buffer on still

#

cause i honestly dont know

#

idk how early the count gets updated

wide jewel
#

mm, ya, negatives don't seem to work properly

rose forge
#

-# 'tis where I realize I... didn't accurately implement the check, oop.

gray osprey
wide jewel
#

Phanta

#

that one in particular is a Development Card

peak linden
#

half expected temperence to have a bulk use function

wary nexus
#

it should, i think sleepy was working on it on a fork

#

i want bulk use on as many things as possible

#

including cryptid and ectoplasm and stuff

charred helm
# wary nexus observatory also works

I remember that modded planets used to be glitched on Incantation, which is why I stopped using them
They'd stack fine, but bulk using just didn't work so you'd end up wasting tons of planets if you try leveling them up at once, since it'd only count as one level

charred helm
charred helm
#

meaning I'd have to manually unstack planets whenever I played with incantation

zinc sapphire
#

well shit

#

forgot about this

tough breach
#

Heya, minor bug report after using the new release for a bit:

  • Bulk use on stacked planets doesn't update fool
  • Splitting makes the original consumable not have a merge button
  • Using one consumable while stacked doesn't decrease the sell value of the original stack
  • Bulk use on Hermit/Temperance crashes with attached crashlog
  • Things that generate consumables (Cartomancer, blue seals, etc.) still generate if two consumables are stacked
  • Stacked consumables that generate more than one consumable will generate to fill the remaining slots, even if the slots are technically full
    Obviously the last two wouldn't be problems if "Only stack negative consumables" was turned on, but I thought if you were going for a substantially better option than incantation then it would be nice
wary nexus
#

bulk use should update fool since its calling the regular use function thats weird but i can fix it

#

cartomancer and blue seals are just not done because i only thought perkeo created enough cards to matter

#

uhh

#

ill look into it all tomorrow

#

its 2am rn

tacit cliff
#

I think there's an issue where stuff have their sell value set to 0 when bought.

rough portal
#

is there an easy way to disable consumable stacking for a whole set of modded consumables

#

i have a set here that is not playing nice with the stacking at all and I'm ready to cut my losses and make them not stack

wary nexus
#

Overflow.blacklist[ConsumableSetKey] = true

rough portal
#

oh that's really easy

#

awesome

wary nexus
#

yeah i wanted to make it as easy as possible

#

you can also give the blacklist the key of a specific consumable too

#

if you wanted all planets to merge but not pluto for example itd just be Overflow.blacklist.c_pluto = true

rough portal
wary nexus
#

hm

rough portal
#

I haven't updated in awhile actually

#

I'll try again after updating and see if it still stacks

wary nexus
#

it should work

#

whats your consumabletype definition and your blacklisting code look like

rough portal
#

oh you know what it might be

#

i'm running the blacklist code before the consumables are defined as existing

#

yeah no still stacking

#
if next(SMODS.find_mod("Overflow")) then
    Overflow.blacklist.c_gamer = true
end

i can't show more than these bits

wary nexus
#

thats really weird

rough portal
#

yeah i'll try updating overflow and if it still doesn't work i'm not sure what to do

#

that caused a crash

#

does this look familiar

wary nexus
#

no

#

ive never seen it before

rough portal
#

this is the line it crashed on
is this something to do with your talisman checks

#

I probably just need to update talisman

wary nexus
#

no i know the issue

rough portal
#

oh what is it

wary nexus
#

its uhh

#

to_big can sometimes return a regular number

rough portal
#

why

#

how do I make it not do that

wary nexus
#

replace to_big(X):to_number() with to_number(X)

#

i can fix it but im a bit busy rn

#

although

#

im pretty sure this is on talismans side

#

so you might need to update talisman

rough portal
#

yeah i updated it anyway

#

yeah that worked

#

alright

#

the consumables still stack unfortunately

wary nexus
#

thats really weird

rose forge
#

Mod priority was tested yet?

rough portal
#

the other mod's priority is 0

#

actually wait i think it's 333

wary nexus
#

try going ingame and doing Overflow.blacklist.Planet = true

#

and seeing if it stops planets from merging

rough portal
#

it does

wary nexus
#

thats really weird

#

maybe the blacklist is getting cleared somehow

#

try doing it for your consumable set in debugplus

rough portal
#

i did the same thing with my consumable set

#

and it worked

#

so something is wrong with my mod check I'd guess

wary nexus
#

try just checking for Overflow (global table)

rough portal
#

yeah that did it

#

they don't stack anymore

wary nexus
#

nice

rough portal
#

there we go

rough portal
#

crashed when pressing Split One on a negative pink color card from morefluff that had x2 on the stack

#

and 1 color card charge

wary nexus
#

let me fix some stuff then do a new release

tacit cliff
bronze escarp
wary nexus
#

its fine

#

ive just been a little distracted today

bronze escarp
#

ok sorry for the ping, appreciate the mod

bronze escarp
#

ok i was able to patch the bug temporarily (it just uses the first consumable rather than a random one and crashing) like this:

fast sparrow
crystal pulsar
#

Bulk use doesn't seem to do it right (those planets are meant to be negative but somehow aren't but that's prob some other mod issue)

#

the thing that gave me 8 planet cards btw

#

also that's definitely not meant to happen (split it one at a time and used it)

fast sparrow
crystal pulsar
#

Mhm

#

Silly Seals is prob a bit outdated

#

uses some jenlib stuff methinks

crystal pulsar
#

figured it out

#

Engulf seems to be overriding some stuff

crystal pulsar
#

doing bulk use doesn't actually use it all in bulk

#

i have to split and then mass use

#

nvm i cant mass use here

wary nexus
#

i have no fucking idea why it doesnt work

#

but its actually starting to piss me off

#

1.0.6 works fine

#

fixed

#

i just

#

undid the 1.1 release

#

well i reverted the changes in a new release since there was other stuff i needed to keep

#

this means its going to be incompatible with like 1 singular mod and idk which

#

but i cba to find out and only 1 person ever has reported it

fast sparrow
#

there's a problem with identical consumables but with different sell value 💀

rough portal
#

perkeo can stack consumables that have stacking disabled

#

it just broke my fucking consumable again and it crashed when i tried to split them and graaagh

wary nexus
#

hm

#

hopefully fixed in the latest commit

radiant vessel
#

No clue how I broke the mod. But somehow i'm producing enough planets for this to happen

#

just gonna have to leave my computer on overnight as the consumables manually stack

wary nexus
#

can you send mods/lovely/dump/main.lua here

#

@radiant vessel

radiant vessel
#

Ok i’m gonna have to recreate the events. Oh well. If we can figure this out I won’t have to wait

#

So it will probably be worth it

wary nexus
#

as long as you havent changed your mod list you shouldnt need to crash again

#

since the dump files dont really change if the mods dont change

radiant vessel
wary nexus
#

you can add it back go to the main menu of the game and then send that file it should suffice

radiant vessel
#

If it doesn’t show the crash lmk

#

And ill recreate it

wary nexus
#

i see whjere the issue is

radiant vessel
#

oh

wary nexus
#

latest release should fix it

radiant vessel
#

and the game froze when I hit next round so i'll tell you if that works

#

the patch

#

when it's done

#

and it just crashed without a crash report. So it's probably just the lag from all the planets. So I won't be able to test it until the merge issue is resolved

#

in case you need this again

viral eagle
#

I spotted this, wasn't aware that Constellation comes from Overflow /j

fast sparrow
#

I forgor to mention that SMODS.scale_card now also handles scaling

#

and that breaks Constellation override (scales the wrong amount)

wary nexus
#

this should be fixed in the latest release

manic elm
#

i have no idea why, but it simply doesn't work

dreamy moon
#

Will this mod conflict with the Tarot Delux?