Modding Commission - $30 USD via Paypal

[burnt agate]

Good afternoon. I'd like to make a mod for my friend's birthday. The deadline is a long time away [August 29th], but I'd like it sooner than then [as our schedules both get busy in the summer]. I'd like to make a mod which adds 20 Egyptian god themed jokers. I'd like it to be as easy to install as possible, and minimal compatibility issues with cryptid or similar mods [although if that is a limitation, I am fine with making that sacrifice]. My budget is $30 USD. I do not expect art, though if you can do art that'd be huge and I'd be happy as hell. The joker mechanics are relatively simple aside from two of them, so I do not believe it'd be too hard. If you are interested in taking the job, I will list the jokers in a secondary message.
[PLEASE CONTACT ME BEFORE STARTING, EITHER VIA DM OR PINGING ME.]

• Osiris: Destroys all played unscoring cards. (Rare)
• Hathor: Gains ×1 mult for each lovers card used. (Rare)
• Bes: Prevents cards above a 5 from scoring. Each scored card gives ×2 mult (Rare)
• Anhur: ×2 mult during boss blinds (Uncommon)
• Ami-ut: Every 9th hand played, gain +30 chips (Uncommon)
• Isis: Adds two copies of the most recently destroyed card into the deck when blind is selected. (If no card has been destroyed, does nothing) (Rare)
• Ra: Retriggers all played hearts twice (Rare)
• Kek: Retriggers all played clubs twice (Rare)
• Set: Applies a random edition upon every played card after scoring (Uncommon)
• Mafdet: If the blind was defeated with the first hand played, gain ×0.5 mult (Rare)
• Anubis: Every time a card is destroyed, this joker gains +5 mult (Rare)
• Erebus: Every time a club or spades card is scored, this card gains ×0.02 mult (Rare)
• Horus: Gives ×2 mult when any king is scored (Rare)
• Ptah: Creates two negative worlds when blind is selected (Uncommon)
• Sobek: Creates one negative lovers when blind is selected (Uncommon)
• Nut: Creates one negative high priestess when blind is selected (Uncommon)
• Thoth: Each tarot card in your consumable slots provides ×1.5 mult (Rare)
• Min: After defeating a boss blind, there is a 1/3 chance to make a negative duplicate of a random joker you own (Rare)
• Khnum: Every 3rd hand played, get $5. (Common)
• Hapy: When blind selected, add a copy of the most recently scored king to the deck (Rare)

[thin dune]

I'd be willing to do this, except for Isis and Hapy. Those two would take me a significant amount of extra time and effort (I can elaborate if you'd like), and I value my time more than that. You'd get programmer art (meaning bare-bones but usable), and I'd prefer to make the mod the mod available on GitHub under the GPL 3.0 license (this means it will be available to anyone once published). I can also add it to the mod manager or create a post in #1209506514763522108 for it. Cryptid/other mod compatibility should be fine.

[burnt agate]

How much extra would I need to throw in for Isis & Hapy to be worth your while? I could also just rework those if it's too much effort no matter the money. I'd be fine with you posting publicly.

[thin dune]

Well, I expect the two together to be a similar amount of effort to the other eighteen together, so $20

[burnt agate]

I can make that happen. $50 usd total. Would you rather I do half up front half in post, or how would you like it.

[thin dune]

Sounds good, I'll dm you my information tomorrow

[burnt agate]

Perfect

[wild ruin]

I'd like to contribute for free if possible

[burnt agate]

If you'd like to contact Bakers, I've accepted their offer so I'd rather not do anything without them being fine with it

[wild ruin]

Alrighty then

[wild ruin]

@thin dune since i can't dm you, i decided to ask here. Can i help with any of the jokers? I dont request any money

[thin dune]

Yeah, that's fine. What did you want to work on?

[wild ruin]

I could take half of the jokers if you want to

[thin dune]

Thinking about it a bit more, I feel bad that that I would be getting paid and you wouldn't. So, I think I prefer to work alone unless you strongly insist otherwise

[wild ruin]

I offered to work for free some time before you in dms as well, but i think OP has missed it. I do want to do it, but if you say that you'll work alone i can't do anything 'bout it

[thin dune]

I'll leave it up to Maepl, then

[burnt agate]

I'd be fine with you working with @wild ruin, I did see the dm, I just didn't want someone to be working on it for free (I've had issues when someone has done stuff for free for me in the past). So if revo wants to do this as practice or something, idm

[wild ruin]

@thin dune if you tell me which ones that you'll do i can start the others in a few hours. I should be able to do all of em with no problem at all except for Isis and Bes i think

[thin dune]

Alright, I'll reserve Isis, Hapy, and Bes in that case.

[wild ruin]

If Hapy would be that time consuming i could do it

I have something similar in my mod

[thin dune]

My concerns on it are 1) retroactively seeing the last scored king from before the joker was acquired and 2) remembering the last scored king across a save & quit

If you have that already done, though, have at it

[wild ruin]

I think for 2, it could be saved with a hook

Im not sure if i understoof 1 correctly though

[thin dune]

that would go as follows:
Score a King in a blind
Buy Hapy in the shop
Select the next blind (should create a copy of the king)

[wild ruin]

-# i need to check it cause i think mine doesnt save

Ah i see

I will take a look but i cant guarantee

[burnt agate]

For 1, I apologize for this not being clear, I meant for both of these cards to only begin processing while they have been added to your joker slot

[thin dune]

I think G.playing_cards is saved and loaded in order, so you would be abled to save and load an index into that? I'd need to verify it, though

[wild ruin]

I will be able to check in like 30-45 minutes,

[thin dune]

Oh there's also if that king happens to get destroyed (which is something I'd have to implement for Isis anyways)

[wild ruin]

I think there is a context to chrck destroyed cards?

[thin dune]

you know, for both of these, maybe it could just store a copy of the relevant card in a hidden discard-style CardArea (which can be saved and loaded just fine)

[wild ruin]

I know for jokers its card.getting_sliced iirc

[thin dune]

yeah I have an actual plan for how to do it now

I'll get started on it tonight (I happen to be busy today)

[wild ruin]

Also to make cards above 5 not score it could debuff them

[thin dune]

i also think I know how i'll do that

namely a hook on SMODS's never_scores

[wild ruin]

Ah i see

Didnt know that existed

[thin dune]

smods has so many weird and poorly documented features lmao

[wild ruin]

True

I'll start with easy ones just to get them out of the way

[lyric cypress]

I can't be too much help but if I can contribute to the textures I'd be happy to for free as well

was currently trying to work on some personal changes to the paperback mod, but i'd be happy to shift focus

it sounds fun

oh sorry missed the message of not wanting help for free 🙌🏻

nvm ^

[thin dune]

I don't think anyone would be opposed to you helping (Maepl is fine with Revo helping for free)

[wild ruin]

^

[lyric cypress]

sick i'll send a dm to y'all

[thin dune]

i don't see a reason why we can't keep discussions here

[lyric cypress]

also fair

any concepts yet i can start on?

or is it still in ideating phase

[thin dune]

see here

[lyric cypress]

ah i meant texture wise sorry

[thin dune]

nope

nobody else has offered for art

[lyric cypress]

gotcha ill make a few concepts

[wild ruin]

looks like a hook is not needed @thin dune

normal vars seems to save just fine

[thin dune]

even through quitting the game entirely?

[wild ruin]

ye it saved

this is my card which copies card stats, and it saved

i could tweak it to copy kings and we'd be done with it

[wild ruin]

finished Osiris,Hathor,Anhur and Ami-ut for today

[thin dune]

Hapy and Isis should copy enhancement/edition/seal/extra chips etc, correct?

[lyric cypress]

i gotta head to bed soon but ill work on the textures tomorrow

did some prototyping but im super tired rn

[coarse flame]

There’s actually an undocumented context that would be perfect for the above 5s never score that lets you modify the scoring hand, ala splash

[thin dune]

oh right, that

i think i did know about that

heccin' smods and its trash documentation

[thin dune]

I destroyed a card while it was debuffed 😭
(They're created debuffed but fix themselves at the end of the round)

this is really funny but I should probably make it not count debuffed destroyed cards

also of note is that the order something like The Hanged Man destroys cards is hard to predict, which I like

[thin dune]

Update:
I have Bes, Isis, and Hapy working. Isis and Hapy are a touch strange with debuffs, but those are rare and the behavior isn't too surprising

I also noticed that you didn't choose a cost for any of these, either you can do that or I can

[slate kayak]

wait I need this can you document it

[thin dune]

look in you lovely dump at functions/state_events.lua::evaluate_play_intro()

[thin dune]

Update: I've also done Khnum and Min (I'm working backwards through the list). I will now go to bed

[wild ruin]

for Set, trying to apply the edition after scoring but it keeps applying the shader before anything. Any ideas on how do i fix that?

[wild ruin]

skipped set for now

[wild ruin]

done with Ra, Kek, Mafdet and Anubis

[burnt agate]

I forgot to mention because I didn't think somebody would do art, but I'd recommend skipping ami-ut. This is a minor deity who was mentioned in a one-off wikipedia article. The rest should be possible to find references for, but ami-ut is very much not one I'd look into

They're like, the god of the 9th day of the month? And I was just like, that'd be an easy enough joker

That said, I love the art! Looks great!

[burnt agate]

I didn't realize each card had a hard coded cost ngl, I thought it was rng based on rarity you can choose them

[lyric cypress]

thanks! + gotcha

[thin dune]

i can try to make these rng based on rarity, that should be fun

[burnt agate]

Up to you, I just want them to feel somewhat vanilla

[thin dune]

toss it in a G.E_MANAGED:add_event(Event {func = function() *DO THE THING HERE* return true end})

[wild ruin]

i forgot event managers....

[wild ruin]

set is done as well

im done with the first half

[thin dune]

Thoth, Nut, Sobek, and Ptah done, which leaves me to do Horus and Erebus (which I will do shortly)

[thin dune]

alright, those two are done (which means everything is coded)

@wild ruin: When you're free, can you send me what you've done?

@lyric cypress Same for you whenever you finish what you wan to do, ping me and I'll put it in

@burnt agate and Revo: How would you like to be credited for your contributions? I'll add mini-badges for idea, programming, and art, so you can choose the text and colors. I'll also put a message in the README and the mod's description.

Maepl: Is there anything specific you want for the mod name/description/badge (text/colors) or in the README on GitHub?

[lyric cypress]

heya ill do that soon

yall seem to be faster than a texturer haha

good on ya

[burnt agate]

1. Cite me as Maple Maelstrom, I also have a friend who helped with the ideas named Reaperkun
2. I have no clue for name, but make sure to mention the mod was "made for Osiris' birthday"

[thin dune]

Do you know which specific jokers you/Reaperkun/both helped with?

[burnt agate]

we both worked equally

[thin dune]

i'll mark you both for all of them, then

[wild ruin]

heres all the jokers

you can credit me as Revo. You can choose the colors if you want to since i dont have anything in mind

[arctic pond]

I'm interested to help with art (or code) 👀

[thin dune]

Code is done, and Pi is working on art (but I'm not sure where he is on that or if help is wanted/needed)

[arctic pond]

thumbsup

[lyric cypress]

any and all help is appreciated with the art

i'm trying to combine the most glaring characteristics of the jokers with a more pixely balatro style

[thin dune]

Here's the mod oh GitHub (currently with the really bad testing sprites i threw together):
https://github.com/BakersDozenBagels/balatroValleyOfTheKings

[wild ruin]

i thought a bit and chose some colors for credits. 7E7AFF being for badge and 40093A for the text. Would really appreciate it if you could change it

[thin dune]

done

[wild ruin]

thanks

[thin dune]

there are so many badges and yet there'll be more soon

[thin dune]

Quick code review for you (all of this is pretty minor):

• I specified colour = G.C.MULT in a few places where you return { message = localize("k_upgrade_ex") }
• A couple sticker compatibilities were set incorrectly (although you did remind me to set them for the ones I did)
• card:is_suit(suit, nil, true) -> card:is_suit(suit), the true is for calculating hands (debuffed cards count as their original suit), without it is for everything else (debuffed cards count as no suit)
• poll_edition() shouldn't specify the fifth argument for compatibility with other mods that add editions
• Anubis would only increment once if multiple cards were destroyed at the same time (I just multiplied the scaling by #context.removed)
• I did various minor refactorings, e.g. removing unnecessary code, merging ifs, migrating to the style I'd been using
• Set is weird but I don't blame you for that, I'll take a stab at properly fixing it later

Overall, your code was very good and helpful. Thank you for your help

[wild ruin]

for poll_edition(), i didn't actually know that it could be mod compatible, since the first time i used it it wouldnt pull any other editions other than specified ones.

Im not happy with how Set turned out, but it was the best i could do at the moment.

For sticker compatibilities, i took the skeleton from my own mod so i wouldnt need to type it all again and forgot to remove some parts of them

thank you for the review

[lyric cypress]

making a fork to play around w sprite uploads without disturbing the project!

[thin dune]

I can merge it in myself without much trouble

[lyric cypress]

gotcha

[thin dune]

but if you want to that's fine

[lyric cypress]

already done haha mb

[thin dune]

not like it hurts anything :P

[lyric cypress]

ye

also maybe with the help of @arctic pond the texturing could go faster I hope you keep the project alive till then :D

[arctic pond]

wawa!

[lyric cypress]

😂 wawa indeed

[thin dune]

only five more days for more wawa :scug:

[arctic pond]

started noting down details and stuff for anubis in the same style as the one that was posted by someone else, idk where im going with this just yet lol

[lyric cypress]

its a good start!