CG's Rarity Library - Custom Joker rarities without the hassle

[tribal thistle]

This mod is designed around 2 things:

1. The ability to easily create custom Joker rarities with just one function call (CGLIB.Rarity)
2. Compatibility with Cryptid, which already adds it's own rarities using it's own methods (they are very similar to what I'm doing, but I try to overwrite them or work side by side with them where I can)

However, I'm bound to have missed some things (like maybe there's some weird shader stuff with rarities that I forgot to account for, or maybe I did something wrong with shop pools and whatnot), so I do highly encourage you to tell me if something I've done here is incorrect or flawed. I did a limited amount of testing, both with Cryptid and without it, and I'm fairly sure it is ready for implementation. It's most certainly not completely polished, but the idea of releasing it now is that future changes will mostly only be bug fixes and minor additions.

https://github.com/cg-223/raritylib

i accidentally used 2 different github accounts when making this
oh well lol, i don't use github much so happens
documentation is inside docs.txt
i sure do hope nothing breaks while im at school

[odd stream]

why make a lib for something that can be added to steamodded API

https://github.com/Steamopollys/Steamodded/pull/244

forgot this existed

[golden lake]

its ready for review too

[tribal thistle]

im aware of this, but it just kinda isn't great

it's outdated isn't being worked on much afaik and from what i can tell just doesn't work

the only reason i made this was because my original approach was to try to work with that and had no success

was originally going to just be a me thing but I saw some other people needing something along these lines so got it into a publishable state

[golden lake]

looking at your lib rn and the first thing that comes to attention is "why is it not using smods' object system if its a smods mod"

[tribal thistle]

probably because i don't know what that is 🔥

[odd stream]

well, why not try to work it out with @mortal glacier

[tribal thistle]

i assume that's the person who was working on the steamodded rarity api fork?

[odd stream]

yo

[odd stream]

also

[tribal thistle]

suppose i was wrong

[golden lake]

the "that pr isnt great" comment doesnt sound great taking this into account

[vestal fossil]

We were both there in modding-dev cg. Flowwey worked on it in front of us , lmao

[tribal thistle]

odd i must've just not connected the dots then

[odd stream]

It's fine, I just think that libs that could be useful for other mods might as well be built into smods, to avoid mod dependencies

you really want to have as little dependencies as possible at all times

[tribal thistle]

ya that's fair, i was just in a rough spot where i wanted to make something to allow for this whole rarity lib thing to work, while also not encroaching on the existing pr for a rarity api, while also not breaking any other mods that implement their own custom rarities

but i do think i succeeded in that regard

assuming it like functions and all

[vestal fossil]

Cryptid is still very much in active development, so it's not like they couldn't just update how they do it

And the cryptod devs tend to Wyeth side by dude with the smodded devs (when they're not the same people) as far as I can tell

[golden lake]

math seems like he's actively looking out to help with compat for other mods (or at least he has been very cooperative with me for infinifusion despite the experimental nature of the mod)

[sharp mist]

Yeah Cryptid is already ready to go when Steamodded gets rarity API

This is cool but I think it would be better incorporated into Steamodded, working with the person writing the PR

[vestal fossil]

Jesus fucking Christ. I wrote this without my glasses and just now actually looked at it. It looks like I was having a stroke

[vestal fossil]

Intended message:
Cryptid devs tend to work side by side with the smodded devs (when they're not the same people) as far as I can tell

[hoary coral]

seems like an average message composed by me

[shrewd fiber]

Don't give up

[golden lake]

you forgot a comma

[mortal glacier]

Comically late to respond, but I do still want to know what part of it doesn't work.

This lib doesn't seem to be doing anything much different from it other than the injects going around the places Cryptid overrides and tracking the higher/lower rarity position of a rarity.

Latter of which I can't think of a use case of tracking.

[tribal thistle]

some error when i tried to create a rarity, chalked it up to "oh this must just be an outdated/dead project ill just not use it"
never really paid any more attention to it, although I admit at this point i definitely shouldve

[mortal glacier]

ah

[round sand]

@tribal thistle whens the next update

[tribal thistle]

😭 never

i can't believe i made this

i was so unaware

[misty walrus]

lowkey "epiclib" would be interesting

because thats such a common idea having one consistent way of getting it working would be useful

[round sand]

uninstalling this mod its so bad

[hoary coral]

Installing this mod its so bad