Hand Names - So you know how a ace high Straight Flush is a Royal Flush?

[smoky sail]

An ace-high Straight is a Broadway...and there are many more hands out there with fun names to try!
Introduces some new names for particular hands - find all 65!

See the end of the thread for a download.

[vocal steeple]

does this mod have Dead Man's Hand in it i really hope it does

[smoky sail]

Only one way to find out!

Well, two... I guess you can read the Lua source.

||Yes, it most certainly does!||

[smoky sail]

There's a bug with this right now, cards will be sorted into order before they're played. I need to rework how I'm checking for each hand slightly.

[candid minnow]

Did you ever fix the bug?

[smoky sail]

I didn't, but I appreciate you asking about it!

I think I need to rewrite it with patching instead of just overwriting the whole method

[candid minnow]

Well, I wish you luck in that endeavor.

[bronze cove]

i was just thinking about a mod like this, happy to see someone's made it already lol

[woven pollen]

Sick idea

[stable gorge]

We should have another mod that adds Jokers based around them

[woven pollen]

just installed this mod 🫡 will play with it in a bit in my modded instance

yeah I seem to be getting some sort of interaction where the order of played cards is reversing

/ is otherwise moving in an unexpected direction

I presume this functionality is so that certain types of hands look more aesthetically pleasing?

I love love love this mod though

great extra bit of flavor without adding any un-needed gameplay complexity or other content

[smoky sail]

it's not intentional, it's to do with how I've patched the game (incorrectly)

can't believe I wrote it half a year ago, wow

[woven pollen]

I see

[vocal island]

i saw xnopyt in the files
i approve of this message

[stiff hatch]

I can't make a git push request rn but if you want to have it not sort replace the HandNames.lua compare hands function with ```function compare_hands(scoring_hand, expected_ranks)
if #scoring_hand < #expected_ranks then
return false
end
local lookup_count = {}

for _, scoring_card in ipairs(scoring_hand) do
    lookup_count[scoring_card:get_id()] = (lookup_count[scoring_card:get_id()] or 0) + 1
end


for _, expected_card in ipairs(expected_ranks) do
    if not lookup_count[expected_card] or lookup_count[expected_card] == 0 then
        return false
    end
    lookup_count[expected_card] = lookup_count[expected_card] - 1
end

return true

end```

[woven pollen]

so just like replace whatever is in the compare_hands field with this?

will do

I really like this mod just for like the fun additions it does to normal gameplay

Thank you for the potential fix!!!

also this encouraged me to look in the files and potentially add some hands of my own 🧐

[smoky sail]

thank you!

I'll test it next week and update the gist

[woven pollen]

When I'm done with my current god run I'm gonna add this to my modpack and see how it fares

It looks like it'd be pretty easy to add some hands of my own aswell 🧐

[woven pollen]

FYI it seems to work fine (in terms of not re-ordering cards in played hands)

while still showing their names

[sand crest]

how do planets work?

[smoky sail]

I still think making sure it goes via the smods API instead of just reimplementing the entire function would be a good idea

[sand crest]

is it like it's own hand or like royal flush and straight flush both get leveled up by neptune?

[smoky sail]

this is like how a royal flush is a straight flush, yeah

[woven pollen]

if you're looking for a mod that ADDS a bunch of poker hands check out #1337113295391555595

both of these mods are sick

[smoky sail]

Fixed version - still doesn't use Lovely patching so may be incompatible with other mods.

[plush barn]

kinda sad

[smoky sail]

it was 😦 But it is fixed now!

[woven pollen]

This mod is goated

[candid minnow]

Wait, how do you install the mod into the game then?

[smoky sail]

same as you do with any other steamodded/smods mods

Once you've got lovely and steamodded set up, put it in a folder in the Mods folder you set up

When I say it doesn't use Lovely patching, I mean it's not written as a Lovely patch (i.e. it doesn't inject its code into the scoring function carefully using Lovely's API for that stuff - when Lovely loads it it just kinda overwrites the whole function, but that works for now)

[candid minnow]

I see.

[woven pollen]

this mod is GOATed

it's easy to add in custom hands aswell

[smoky sail]

Kinda wanna make a royal flush in spades a Royal Straight Flush as a reference to Kamen Rider Blade, but this mod doesn't distinguish on suit...yet

[woven pollen]

👀

I added a couple of hands based off of MTG creature statlines to the mod files (pair of 2's being grizzley bear and pair of 6's being dreadmaw)

The syntax in the files was very easy to understand which I enjoyed

My favorite part about this mod is seeing the fun names pop up from time to time, especially when I'm not expecting them